December 2008 - Wine-Devel - list.winehq.org

Re: wintrust: Sign-compare warnings fix
by Juan Lang Dec. 11, 2008

Dec. 11, 2008

Hi Andy, - if (pbEncoded[1] + 1 > cbEncoded) + if (pbEncoded[1] + 1U > cbEncoded) Is this change necessary? The resulting code is less clear than the original, IMO. It's clearly a spurious warning: a BYTE (max value 255) + 1 can't yield a value that overflows an unsigned int, so this comparison will always do what's wanted. Same with the change here: - else if (lenLen + 2 > cbEncoded) + else if (lenLen + 2U > cbEncoded) Otherwise, this patch looks fine to me. --Juan

2 3

re: compiling Windows code with g++ on Linux using msvcrt - good idea? if so, how do you do it?
by Dan Kegel Dec. 11, 2008

Dec. 11, 2008

Glad Wine is being helpful to you. If you're targeting plain old 32 bit intel-compatible linux or unix, have you considered simply using wine to run your windows binaries? That plus a very few tweaks in your source tree could get you what you want with potentially less effort. - Dan

1 0

Re: German translation for winehq.org
by Jeremy Newman Dec. 11, 2008

Dec. 11, 2008

Excellent work! -Newman Maik Schulz wrote: > Hi, > > please find attached a patch for the beginning of a German translation > of the new winehq.org. More patches to follow as I go through the > remaining templates. > > Cheers, > -Maik > > > ------------------------------------------------------------------------ > >

1 0

RE: [2/4] WineD3D: Set up the shaders when delaying fixed func applying
by Stefan Dösinger Dec. 11, 2008

Dec. 11, 2008

Here's an updated patch that fixes the compile issues > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Stefan Dösinger > Sent: Thursday, December 11, 2008 11:53 AM > To: wine-patches(a)winehq.org > Subject: [2/4] WineD3D: Set up the shaders when delaying fixed func > applying > > I skipped the original 2/5 patch because I found a last minute bug in > it. It should not affect the other patches though. > > Just fyi, this is my roadmap for cleaning up the fog mess this patch is > related to: > 1) Get rid of the GL_EXT_fog_coord-is-not-supported fallback and fake > the GL extension > 2) Remove the different pixel shader fog start and end optimization(and > probably reintroduce it in a cleaner way once the state_fog function is > sane) > 3) Separate the current fog state block into > fogenable+fogvertexmode+fogtablemode and fogstart-fogend > 4) Move the separated fog states into the fragment pipeline(since GLSL > and ARBfp override fog) > 5) Put the fog mode into the ps_compile_args structure to generate > shaders that can disable fog properly and support exponential fog > 6) Find some way to deal with glFogi(GL_FOG_COORDINATE_SOURCE_EXT, ...). > That part still belongs into the vertex pipe I think. > 7) the optimization removed in (2) is only needed for GLSL. We can > easilly reintroduce it once we have a full GLSL pipeline because then > the fog start and end stays independent of the pixel shader.

1 0

RE: [2/5] wined3d: baseShader.functionLength should be 0 when a NULL pFunction is passed.
by Stefan Dösinger Dec. 11, 2008

Dec. 11, 2008

Do we still have a case where a shader is created with a NULL function? I think we filter that in d3d8 now and just create a vdecl > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Henri Verbeet > Sent: Thursday, December 11, 2008 11:58 AM > To: wine-patches(a)winehq.org > Subject: [2/5] wined3d: baseShader.functionLength should be 0 when a > NULL pFunction is passed. >

2 2

RE: [2/4] WineD3D: Set up the shaders when delaying fixed func applying
by Stefan Dösinger Dec. 11, 2008

Dec. 11, 2008

Don't apply this patch, it has a bug and will cause a compile error > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Stefan Dösinger > Sent: Thursday, December 11, 2008 11:53 AM > To: wine-patches(a)winehq.org > Subject: [2/4] WineD3D: Set up the shaders when delaying fixed func > applying > > I skipped the original 2/5 patch because I found a last minute bug in > it. It should not affect the other patches though. > > Just fyi, this is my roadmap for cleaning up the fog mess this patch is > related to: > 1) Get rid of the GL_EXT_fog_coord-is-not-supported fallback and fake > the GL extension > 2) Remove the different pixel shader fog start and end optimization(and > probably reintroduce it in a cleaner way once the state_fog function is > sane) > 3) Separate the current fog state block into > fogenable+fogvertexmode+fogtablemode and fogstart-fogend > 4) Move the separated fog states into the fragment pipeline(since GLSL > and ARBfp override fog) > 5) Put the fog mode into the ps_compile_args structure to generate > shaders that can disable fog properly and support exponential fog > 6) Find some way to deal with glFogi(GL_FOG_COORDINATE_SOURCE_EXT, ...). > That part still belongs into the vertex pipe I think. > 7) the optimization removed in (2) is only needed for GLSL. We can > easilly reintroduce it once we have a full GLSL pipeline because then > the fog start and end stays independent of the pixel shader.

1 0

Re: jscript: Implement multiple Math functions.
by Jacek Caban Dec. 11, 2008

Dec. 11, 2008

Hi Patrick, Patrick Rudolph wrote: > From 0903060f5acac3bcadc4198bd59eb2ef87f78818 Mon Sep 17 00:00:00 2001 > From: Patrick Rudolph <patrick1804(a)web.de> > Date: Wed, 10 Dec 2008 16:51:19 +0100 > Subject: jscript: Implement multiple Math functions. > > modified: math.c > modified: tests/api.js > --- > dlls/jscript/math.c | 293 +++++++++++++++++++++++++++++++++++++++------ > dlls/jscript/tests/api.js | 32 +++++ > 2 files changed, 287 insertions(+), 38 deletions(-) > > diff --git a/dlls/jscript/math.c b/dlls/jscript/math.c > index e6b7202..56ba9cf 100644 > --- a/dlls/jscript/math.c > +++ b/dlls/jscript/math.c > @@ -20,6 +20,7 @@ > #include "wine/port.h" > > #include <math.h> > +#include <sys/time.h> > > #include "jscript.h" > > @@ -57,57 +58,105 @@ static const WCHAR tanW[] = {'t','a','n',0}; > static HRESULT Math_E(DispatchEx *dispex, LCID lcid, WORD flags, DISPPARAMS *dp, > VARIANT *retv, jsexcept_t *ei, IServiceProvider *sp) > { > - FIXME("\n"); > - return E_NOTIMPL; > + if(arg_cnt(dp) > 0) { > + FIXME("invalid arg_cnt %d\n", arg_cnt(dp)); > + return E_NOTIMPL; > + } > + > + if(retv) > + num_set_val(retv, exp(1)); > + return S_OK; > } > It's a JavaScript constant, not a function (and you've implemented it as if it would be a function). The same for other constants. [...] Please send smaller patches, preferable one patch per function, and add more tests. And first of all, make sure that tests are correct... > diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js > index 2868c0f..6430397 100644 > --- a/dlls/jscript/tests/api.js > +++ b/dlls/jscript/tests/api.js > @@ -585,6 +585,38 @@ ok(tmp === 2, "Math.pow(2, 2) = " + tmp); > tmp = Math.pow(2, 2, 3); > ok(tmp === 4, "Math.pow(2, 2, 3) = " + tmp); > > +tmp = Math.PI(); > What makes you think this test will work? Jacek

1 0

Coverity Telco coming up
by Kai Blin Dec. 11, 2008

Dec. 11, 2008

Hi folks, Coverity is hosting a telco tomorrow about some new technology they're going to roll out to projects. I'm planning to attend, and would like to bring up any issues we're currently having in the Q&A session. Issues I'm currently seeing with our Coverity experience: - Adding new developers to the access list is painfully slow - Builds are pretty outdated (They seem to be working on this) Anything else? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

5 5

(no subject)
by foobarbaz biffblaff Dec. 10, 2008

Dec. 10, 2008

Hi, I have a huge amount of Windows code that I'm porting to Linux. Wine is turning out to be a read godsend, thank you guys! Anyway, I've had tons of luck including the directory <wine_dir>/include/wine/windows in my include path. All my Windows types are there and everything is wonderful. I've even been able to link against the libraries by renaming, for example, foo.dll.so to libfoo.so and using -lfoo on the g++ command line. I actually haven't got all my functions defined so I don't know if this will actually run yet because the link isn't complete yet. My first question is whether this will work. Will all my Windows functions with function declarations defined in the windows directory and code compiled into foo.dll.so actually run? Second, I see that some of the functions I want to use are actually defined by headers in the msvcrt directory. However, this directory contains tons of header files that my system (and gcc) also have under /usr/include and gcc's own directories. I understand that msvcrt is Windows lib c, but I wonder how I'm supposed to use it with gcc to compile? I've tried -nostdinc to gcc, but the number of errors I get is enormous. It's not the end of the world if I can't use Wine's msvcrt, but if I could use it, it would define dozens more functions on which my program relies, or if its use was mandatory in order to get the functions implemented in foo.dll.so to work, then obviously I wonder how I'm supposed to compile my Windows code with Wine to make everything work? I'm sorry if this is a dumb question. I can't find a way to search the wine-devel mailing list other than with google and I can't find anything on there or other docs that answer this question, which I'm sure has been asked a million times and has a simple answer. Thank you thank you, Jeff _________________________________________________________________ Send e-mail faster without improving your typing skills. http://windowslive.com/Explore/hotmail?ocid=TXT_TAGLM_WL_hotmail_acq_speed_…

1 0

Re: wininet/tests: Use new test URLs on test.winehq.org.
by Paul Vriens Dec. 10, 2008

Dec. 10, 2008

Hi Alexandre, These changes introduce 15 errors on all platforms. -- Cheers, Paul.

1 0