February 2008 - Wine-Devel - list.winehq.org

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Wine desktop integration: current directory of app launched with doubleclick?
by Dan Kegel Feb. 15, 2009

Feb. 15, 2009

I *almost* have a great success story to report; the only thing keeping it from being a success story is the current directory chosen by Nautilus when double-clicking on .exe files. My wife hurt a finger trying to impersonate a Sampsonite Luggage gorilla, and had to go to a hand doctor. Along the way her hand got x-rayed, and the doctor handed her a cd-rom with the x-ray pictures on it. The disc has an autorun.inf on it that should start ViewSel.exe. I don't know if that's supposed to work with Wine and Nautilus, but probably doubleclicking on ViewSel.exe does the same thing. ViewSel.exe puts up two big buttons: low res (which launches a web browser on an html file), and high res (which launches a DICOM viewer). If you cd to the root of the cd-rom drive and run ViewSel, it works. If the current directory is anything else, it doesn't work. If you start the autorun app via Nautilus, those buttons don't work, so presumably it sets the current directory to something other than the root of the drive. To see, I created a wrapper shell script, ~/bin/mywine, containing #!/bin/sh pwd > /tmp/log and used "Start with" to launch ViewSel.exe with ~/bin/mywine. This showed that the current directory was $HOME. I had a look at the gnome code to see how it decided, but it was a bit hard to follow. (See gnome_vfs_mime_application_launch_with_env.) So I tried a little shell magic. I created a new wrapper shell script that assumes the argument is a path to a file, and sets the current directory to the directory containing that file: #!/bin/sh DIR=`dirname "$1"` DIR=`cd "$DIR"; pwd` cd "$DIR" wine "$@" That worked better; it let ViewSel.exe launch the DICOM viewer. So... I suppose the next step is to look at the debian/ubuntu packages for wine and see if that little wrapper script could be incorporated into the default way file browsers start wine? It sure would be nice if apps that expected the current directory to behave like this (it's not uncommon!) Just Worked. - Dan

4 9

today's valgrind results online
by Dan Kegel June 23, 2008

June 23, 2008

Online at http://kegel.com/wine/valgrind/20071002/ (I now include more info about memory leaks, but I still only report anything if there was an invalid memory reference.) The following tests were fixed in git yesterday, and no longer have any valgrind warnings: comctl32/rebar comctl32/status crypt32/chain crypt32/crl crypt32/msg cryptnet/cryptnet user32/msg wintrust/softpub Juan thinks nearly all of the remaining crypt32 errors can be suppressed (some are intentional). Here are the directories that still have warnings: advapi32 advpack cabinet comctl32 crypt32 d3d8 d3d9 d3dx8 dplayx dsound gdi32 gdiplus hlink kernel32 mlang msacm32 mscms mshtml msi msvcrt msxml3 netapi32 ntdll ole32 oleaut32 quartz riched20 riched32 rpcrt4 rsaenh setupapi shdocvw shell32 urlmon user32 usp10 wininet winmm wintrust - Dan

3 4

Re: ole32: Fix a failed call to DllGetClassObject while retrieving class object interface pointer.
by Robert Shearman June 17, 2008

June 17, 2008

Huang, Zhangrong wrote: > See dlls/ole32/compobj.c, > > static HRESULT apartment_getclassobject(struct apartment *apt, LPCWSTR dllpath, > BOOL apartment_threaded, > REFCLSID rclsid, REFIID riid, > void **ppv) > { > ................... > if (SUCCEEDED(hr)) > { > .................. > TRACE("calling DllGetClassObject %p\n", > apartment_loaded_dll->dll->DllGetClassObject); > /* OK: get the ClassObject */ > hr = apartment_loaded_dll->dll->DllGetClassObject(rclsid, riid, ppv); > ^^^^ > if (hr != S_OK) > ERR("DllGetClassObject returned error 0x%08x\n", hr); > } > .............. > } > > Reference to http://msdn2.microsoft.com/en-us/library/ms680760.aspx, > > riid > > [in] Reference to the identifier of the interface that the caller > is to use to communicate with the class object. Usually, this is > IID_IClassFactory (defined in the OLE headers as the interface > identifier for IClassFactory). > This doesn't mean anything other than CoCreateInstance is usually used instead of CoGetClassObject (and CoCreateInstance always passes in IID_IClassFactory for the IID). > We can't pass riid to DllGetClassObject directly sometimes, causes some dlls' > DllGetClassObject (like native adsldp.dll) can only return reference-counted > pointer to class factory via IID_IClassFactory, for retrieving the > pointer to the > class object interface requested in riid, we must try another way. > Thank you for your patch, but this behaviour seems a little strange and needs a little more investigation before I am happy that it is correct. What parameters are being passed in to CoGetClassObject to cause the call to fail for you? -- Rob Shearman

5 12

Re: hhctrl.ocx: Parse HTML entities in the table of contents.
by Alexandre Julliard April 15, 2008

April 15, 2008

Robert Shearman <rob(a)codeweavers.com> writes: > + p++; > + if ((*p == 'X') || (*p == 'x')) > + { > + /* hexadecimal entity */ > + while ((*p >= '0' && *p <= '9') || (*p >= 'a' && *p <= 'f') || > + (*p >= 'A' && *p <= 'F')) > + p++; > + ch = strtolW(start + 2, NULL, 16); > + } This is still broken. > + if (p - start - 1 <= sizeof(char_refs[0].name)) > + { > + for (i = 0; i < sizeof(char_refs)/sizeof(char_refs[0]); i++) > + if (!strncmpW(char_refs[i].name, start + 1, p - start - 1)) > + break; > + } This is still broken too. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: LoadStringW [1/2]
by Dmitry Timoshkov April 9, 2008

April 9, 2008

"Christopher" <raccoonone(a)procyongames.com> wrote: > +static void test_LoadStringW(void) > +{ > + HINSTANCE hInst = GetModuleHandle(NULL); > + WCHAR copiedstring[128], returnedstring[128], *resourcepointer = NULL; > + int strlen, strlen2; > + > + /* Check that the string which is returned by LoadStringW matches > + the string at the pointer returned by Load StringW when called with buflen = 0 */ > + strlen = LoadStringW(hInst, 2, (WCHAR *) &resourcepointer, 0); /* get pointer to resource. */ > + ok(strlen > 0, "LoadStringW failed to get pointer to resource 2, ret %d, err %d \n", strlen, GetLastError()); > + > + strlen2 = LoadStringW(hInst, 2, returnedstring, sizeof(returnedstring) /sizeof(WCHAR)); > + ok(strlen == strlen2, "LoadStringW returned different values dependent on buflen. ret1 %d, ret2 %d \n", > + strlen, strlen2); > + ok(strlen2 > 0, "LoadStringW failed to load resource 2, ret %d, err %d \n", strlen2, GetLastError()); > + > + if(resourcepointer != NULL) > + { > + memcpy(copiedstring, resourcepointer, strlen * sizeof(WCHAR)); > + copiedstring[strlen] = '\0'; > + } > + /* check that strings match */ > + ok(!memcmp(copiedstring, returnedstring, (strlen + 1)*sizeof(WCHAR)), > + "LoadStringW returned a string that does not match the string pointed to by the pointer it returned. \ > + returnedstring = %ls, copiedstring = %ls", returnedstring, copiedstring); > +} It's not clear what this test is supposed to show. If the 1st call to LoadStringW is supposed to set resourcepointer to not NULL, why don't you test it? Then 'if(resourcepointer != NULL)' check and copying to copiedstring are not needed. Also, if the test depends on a later patch to not fail, the test should be included in the patch. -- Dmitry.

4 15

Re: user32: Implement GetWindowModuleFileName with tests (try 2)
by Alexandre Julliard April 1, 2008

April 1, 2008

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes: > @@ -3121,9 +3133,21 @@ UINT WINAPI GetWindowModuleFileNameA( HWND hwnd, LPSTR lpszFileName, UINT cchFil > */ > UINT WINAPI GetWindowModuleFileNameW( HWND hwnd, LPWSTR lpszFileName, UINT cchFileNameMax) > { > - FIXME("GetWindowModuleFileNameW(hwnd %p, lpszFileName %p, cchFileNameMax %u) stub!\n", > - hwnd, lpszFileName, cchFileNameMax); > - return 0; > + HINSTANCE hInst; > + UINT ret; > + TRACE("hwnd %p, lpszFileName %p, cchFileNameMax %u\n", hwnd, lpszFileName, cchFileNameMax); > + > + hInst = (HINSTANCE)GetWindowLongPtrW(hwnd, GWLP_HINSTANCE); > + if (!hInst) > + { > + if (hwnd == GetDesktopWindow() || !IsWindow(hwnd)) > + return 0; > + hInst = GetModuleHandleW(0); > + } > + > + ret = GetModuleFileNameW(hInst, lpszFileName, cchFileNameMax); > + TRACE("--> %d %s\n", ret, debugstr_wn(lpszFileName, ret)); > + return ret; This won't work across processes. -- Alexandre Julliard julliard(a)winehq.org

2 2

"winefix" - interesting wrapper for wine
by Dan Kegel March 19, 2008

March 19, 2008

Tom W. found and publicized a script called "winefix" by an ubuntu forums user named "deadlydeathcone": http://digg.com/linux_unix/Winefix_improved_desktop_integration_for_Wine http://wine-review.blogspot.com/2007/10/winefix-improved-desktop-integratio… http://ubuntuforums.org/showthread.php?s=6e904c1df87d3fd1698ab5d7bbdbf664&t… It's got a bunch of interesting stuff. I wonder if we could get him to join wine-devel and start contributing to wine itself... - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 2

Re: user32: Test destroying the cursor of a parent process.
by Eric Pouech March 18, 2008

March 18, 2008

Andrew Riedi a écrit : > changelog: user32: Test destroying the cursor of a parent process. > > -- > Andrew Riedi > ------------------------------------------------------------------------ > > From 25a6a6a2eee92c4325d730ff85bd7cdf01bf2ace Mon Sep 17 00:00:00 2001 > From: Andrew Riedi <andrewriedi(a)gmail.com> > Date: Tue, 8 Jan 2008 05:03:55 -0800 > Subject: [PATCH] user32: Test destroying the cursor of a parent process. > > --- > dlls/user32/tests/cursoricon.c | 201 ++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 201 insertions(+), 0 deletions(-) > > diff --git a/dlls/user32/tests/cursoricon.c b/dlls/user32/tests/cursoricon.c > index 781282c..c2beffa 100644 > --- a/dlls/user32/tests/cursoricon.c > +++ b/dlls/user32/tests/cursoricon.c > @@ -32,6 +32,205 @@ > #include "wingdi.h" > #include "winuser.h" > > +static char **test_argv; > +static int test_argc; > +static HWND child = 0; > +static HWND parent = 0; > +static HANDLE child_process; > + > +#define PROC_INIT (WM_USER+1) > + > +LRESULT CALLBACK callback_child(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) > +{ > + BOOL ret; > + DWORD error; > + > + switch (msg) > + { > + /* Destroy the cursor. */ > + case WM_USER+1: > + SetLastError(0xdeadbeef); > + ret = DestroyCursor((HCURSOR) lParam); > + error = GetLastError(); > + todo_wine { > + ok(!ret, "DestroyCursor on the active cursor succeeded.\n"); > + ok(error == ERROR_DESTROY_OBJECT_OF_OTHER_THREAD, > + "Last error: 0x%08x\n", error); > + } > + return TRUE; > + case WM_DESTROY: > + PostQuitMessage(0); > + return 0; > + } > + > + return DefWindowProc(hwnd, msg, wParam, lParam); > +} > + > +LRESULT CALLBACK callback_parent(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) > +{ > + if (msg == PROC_INIT) > + { > + child = (HWND) wParam; > + return TRUE; > + } > + > + return DefWindowProc(hwnd, msg, wParam, lParam); > +} > + > +static void do_child(void) > +{ > + WNDCLASS class; > + MSG msg; > + BOOL ret; > + > + /* Register a new class. */ > + class.style = CS_GLOBALCLASS; > + class.lpfnWndProc = callback_child; > + class.cbClsExtra = 0; > + class.cbWndExtra = 0; > + class.hInstance = GetModuleHandle(NULL); > + class.hIcon = NULL; > + class.hCursor = NULL; > + class.hbrBackground = NULL; > + class.lpszMenuName = NULL; > + class.lpszClassName = "cursor_child"; > + > + SetLastError(0xdeadbeef); > + ret = RegisterClass(&class); > + ok(ret, "Failed to register window class. Error: %d\n", GetLastError()); > + > + /* Create a window. */ > + child = CreateWindowA("cursor_child", "cursor_child", WS_POPUP | WS_VISIBLE, > + 0, 0, 200, 200, 0, 0, 0, NULL); > + ok(child != 0, "CreateWindowA error %d\n", GetLastError()); > + > + /* Let the parent know our HWND. */ > + PostMessage(parent, PROC_INIT, (WPARAM) child, 0); > + > + /* Receive messages. */ > + while ((ret = GetMessage(&msg, child, 0, 0))) > + { > + ok(ret != -1, "GetMessage failed. Error: %d\n", GetLastError()); > + TranslateMessage(&msg); > + DispatchMessage(&msg); > + } > +} > + > +static void do_parent(void) > +{ > + char path_name[MAX_PATH]; > + PROCESS_INFORMATION info; > + STARTUPINFOA startup; > + WNDCLASS class; > + MSG msg; > + BOOL ret; > + > + /* Register a new class. */ > + class.style = CS_GLOBALCLASS; > + class.lpfnWndProc = callback_parent; > + class.cbClsExtra = 0; > + class.cbWndExtra = 0; > + class.hInstance = GetModuleHandle(NULL); > + class.hIcon = NULL; > + class.hCursor = NULL; > + class.hbrBackground = NULL; > + class.lpszMenuName = NULL; > + class.lpszClassName = "cursor_parent"; > + > + SetLastError(0xdeadbeef); > + ret = RegisterClass(&class); > + ok(ret, "Failed to register window class. Error: %d\n", GetLastError()); > + > + /* Create a window. */ > + parent = CreateWindowA("cursor_parent", "cursor_parent", WS_POPUP | WS_VISIBLE, > + 0, 0, 200, 200, 0, 0, 0, NULL); > + ok(parent != 0, "CreateWindowA error %d\n", GetLastError()); > + > + /* Start child process. */ > + memset(&startup, 0, sizeof(startup)); > + startup.cb = sizeof(startup); > + startup.dwFlags = STARTF_USESHOWWINDOW; > + startup.wShowWindow = SW_SHOWNORMAL; > + > + sprintf(path_name, "%s cursoricon %x", test_argv[0], (unsigned int) parent); > + ok(CreateProcessA(NULL, path_name, NULL, NULL, FALSE, 0L, NULL, NULL, &startup, &info), "CreateProcess failed.\n"); > + child_process = info.hProcess; > + > + /* Wait for child window handle. */ > + while ((child == 0) && (ret = GetMessage(&msg, parent, 0, 0))) > + { > + ok(ret != -1, "GetMessage failed. Error: %d\n", GetLastError()); > + TranslateMessage(&msg); > + DispatchMessage(&msg); > + } > +} > + > +static void init(void) > +{ > + test_argc = winetest_get_mainargs(&test_argv); > + > + /* Child process. */ > + if (test_argc >= 3) > + { > + sscanf (test_argv[2], "%x", (unsigned int *) &parent); > + > + ok(parent != NULL, "Parent not found.\n"); > + if (parent == NULL) > + exit(1); > + > + do_child(); > + exit(0); > + } > + else > + { > + do_parent(); > + } > +} > + > +static void finish_process(void) > +{ > + DWORD exit_code; > + BOOL ret; > + > + SendMessage(child, WM_CLOSE, 0, 0); > + ok(WaitForSingleObject(child_process, 30000) == WAIT_OBJECT_0, "Child process termination failed.\n"); > + > + ret = GetExitCodeProcess(child_process, &exit_code); > + ok(ret, "GetExitCodeProcess() failed. Error: 0x%08x\n", GetLastError()); > + ok(exit_code == 0, "Exit code == %d.\n", exit_code); > +} > + > +static void test_child_process(void) > +{ > + static const BYTE bmp_bits[4096]; > + HCURSOR cursor; > + ICONINFO cursorInfo; > + UINT display_bpp; > + HDC hdc; > + > + /* Create and set a dummy cursor. */ > + hdc = GetDC(0); > + display_bpp = GetDeviceCaps(hdc, BITSPIXEL); > + ReleaseDC(0, hdc); > + > + cursorInfo.fIcon = FALSE; > + cursorInfo.xHotspot = 0; > + cursorInfo.yHotspot = 0; > + cursorInfo.hbmMask = CreateBitmap(32, 32, 1, 1, bmp_bits); > + cursorInfo.hbmColor = CreateBitmap(32, 32, 1, display_bpp, bmp_bits); > + > + cursor = CreateIconIndirect(&cursorInfo); > + ok(cursor != NULL, "CreateIconIndirect returned %p.\n", cursor); > + > + SetCursor(cursor); > + > + /* Destroy the cursor. */ > + SendMessage(child, WM_USER+1, (WPARAM) parent, (LPARAM) cursor); > + > + /* Finish the child process. */ > + finish_process(); > +} > + > static void test_CopyImage_Check(HBITMAP bitmap, UINT flags, INT copyWidth, INT copyHeight, > INT expectedWidth, INT expectedHeight, WORD expectedDepth, BOOL dibExpected) > { > @@ -471,6 +670,7 @@ static void test_DestroyCursor(void) > > START_TEST(cursoricon) > { > + init(); > test_CopyImage_Bitmap(1); > test_CopyImage_Bitmap(4); > test_CopyImage_Bitmap(8); > @@ -480,4 +680,5 @@ START_TEST(cursoricon) > test_initial_cursor(); > test_CreateIcon(); > test_DestroyCursor(); > + test_child_process(); > } > > ------------------------------------------------------------------------ > > > IMO, the ok() tests in the child process are a bad idea (they won't be counted, nor returned as errors, by the parent process) all the tests should be done in parent, see kernel32/tests/process.c for some example on how to do it properly A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

3 2

[feature requist] Glide API support
by Vincent Weber March 5, 2008

March 5, 2008

Dear Wine devs, There are some games out there that were built with the Glide API. The Glide API is the graphics API of the 3dfx Voodoo cards and is basically a stripped down version of OpenGL. Could please consider adding support for the Glide API because I, and other have games that requires this API to be able to run under Wine. Now I know that there are Glide wrappers but they don't seem to work for a lot of people, including me, and Glide has been a very popular game API in the mid- to late 90's. Thanks in advance, Vincent Weber, weber dot vincent at gmail dot com

7 6

Regession tests
by Alistair Leslie-Hughes March 4, 2008

March 4, 2008

Hi, Some of the regessions test are failing with errors in output file like msxml3:domdoc start dlls/msxml3/tests/domdoc.c 1.80 msxml3:domdoc done (-1073741819) Is this due to a Seg Fault? Best Regards Alistair Leslie-Hughes

2 3

Next big app(s) to try?
by Dan Kegel March 3, 2008

March 3, 2008

Now that Adobe Photoshop CS2 is running kind of well (there are bugs that need fixing, but I'm trying to look ahead a bit), what big app(s) are worth focusing on next? Using http://wiki.winehq.org/LinuxApplicatonRequestSurvey, skipping Photoshop (which we should continue to fix up) and the ones that are either too hard, have native versions, or are probably something Codeweavers might already be doing, and adding in good old Framemaker (so close to working we might want to go for it just for the goodwill from all those tech writers), I think that leaves about seven big ticket apps, in rough order of popularity: http://wiki.winehq.org/AdobeDreamweaver iTunes http://wiki.winehq.org/AdobeIllustrator http://wiki.winehq.org/AdobeFlash http://wiki.winehq.org/AdobePremiere http://wiki.winehq.org/AdobeAcrobatPro http://wiki.winehq.org/AdobeFramemaker I've created wiki pages with trial download URLs for all but iTunes, and done a bunch of triage on them. Most of these could all use more triage and bugs filed. At some point the dust might settle, and it might become clearer which one(s) deserve to be focused on. I think Maarten is going to try iTunes, which would be great. - Dan

9 10

Any graphics card y'all like to see tests run on?
by Austin English March 1, 2008

March 1, 2008

Howdy, I'm about to get a new graphics card, because my current crappy Nvidia FX 5200 doesn't support widescreen, and I just got a shiny nice new 22". So, I'm going to upgrade my graphics card. I don't have a preference, since I don't game at all, just need something that will run 1920x1040 and $200<=. So any of you d3d/ddraw guys, is there some graphics card y'all need tests run on, and don't see around often, because now's your chance... -Austin

4 5

Re: kernel32 & winelib: Don't test string size in CompareStringW for null terminated strings
by Robert Shearman March 1, 2008

March 1, 2008

Adam Strzelecki wrote: > During playing with installing Visual Studio 2005 with WINE I found > out that WINE's MSI is spending lot of time inside lstrcmpW. With Mac > OS X process sampler I checked that actually 60-70% of CompareStringW > is wine_compare_string, rest is rest of function body, which is in > case 2 strlenW calls (inline). > I believe this isn't necessary, moreover most of compares in MSI are > non-matching on first few characters, however with current > implementation we go trough all strings with strlenW regardless of > anything, which is waste in CPU cucles. > I modified both CompareStringW and wine_compare_string so they work > with -1 strings without strlenW checking before. > This saves in my testing about 20-30% of CPU cycles. You introduce a lot of complexity into the low-level helper routines. We don't want to put Win32 quirks, like -1 meaning "until the null terminator" being put into the low-level functions unless we have to. In this case, if this is the sole cause of the slowdown then you would be better off caching the length at the MSI level since the strings are bound to be accessed more than once. However, I think you'll find that this is an algorithm problem in MSI rather than a performance issue in the functions you mention. By that, I mean it is likely that one MSI query is being performed again and again and that the results should be cached. > Note also that WINE's strlenW and lstrcmpW functions are far from > perfect. Normal msvcrt or glibc string functions are far more > optimized at machine code level. This makes strong impact on WINE > parts strongly relaying on string manipulation which is in this case MSI. How do you know that the compiler isn't generating the same assembly for the functions as that used by msvcrt / glibc? Theories like these need numbers to back them up. -- Rob Shearman

3 2

Re: kernel32 & winex11: WaitForMultipleObjectsEx should ignore NULL handles
by Robert Shearman March 1, 2008

March 1, 2008

Adam Strzelecki wrote: > Hi, > > In MSI dialog.c: msi_dialog_check_messages function it often happens > that is sends: > MsgWaitForMultipleObjects( 1, &handle, 0, INFINITE, QS_ALLINPUT ); > Where handle = NULL. I'm not sure if it is correct behavior. But > tracing it down I found out that kernel32 and winex11 sync functions > are not checking at all if the passes handles are not NULLs. > > So I'm not sure whether this patch is right or not, but I believe we > shouldn't bother wineserver with NULL handles!? > Yet maybe I don't understand clearly the way interserver communication > works, and sending "WaitFor" with NULL handle makes sense. Does it? No, but this is the wrong fix. You're assuming that because MSI code does action A and that causes bad effect when it does action B that the correct action is to fix B so that it doesn't have a bad effect. However, the bug could also be that action A shouldn't be done. In this case, MSI should not be calling MsgWaitForMultipleObjects with an invalid handle and in fact that barring memory corruption, this can't happen: > while (1) > { > msi_process_pending_messages( NULL ); > > if( !handle ) > break; > > /* > * block here until somebody creates a new dialog or > * the handle we're waiting on becomes ready > */ > r = MsgWaitForMultipleObjects( 1, &handle, 0, INFINITE, > QS_ALLINPUT ); > if( r == WAIT_OBJECT_0 ) > break; > } -- Rob Shearman

2 1

Re: wine.inf: Create fake dll entry for dosx.exe
by Justin Chevrier Feb. 29, 2008

Feb. 29, 2008

> Changelog: > > Create a fake dll entry for dosx.exe Anything wrong with this one liner? Justin Chevrier

2 1

Re: Conformance tests for LoadStringW and LoadStringA
by Christopher Feb. 29, 2008

Feb. 29, 2008

wine-devel-request(a)winehq.org wrote: > Message: 3 > Date: Fri, 29 Feb 2008 12:50:53 +0100 > From: Alexandre Julliard <julliard(a)winehq.org> > Subject: Re: Conformance tests for LoadStringW and LoadStringA > To: Christopher <raccoonone(a)procyongames.com> > Cc: wine-devel(a)winehq.org > Message-ID: <87y794yo9u.fsf(a)wine.dyndns.org> > Content-Type: text/plain; charset=us-ascii > > Christopher <raccoonone(a)procyongames.com> writes: > > >> > + ok(!memcmp(copiedstring, returnedstring, (length2 + 1)*sizeof(WCHAR)), >> > + "LoadStringW returned a string that does not match the string pointed to by the pointer it returned. \ >> > + returnedstring = %ls, copiedstring = %ls", (wchar_t *)returnedstring, (wchar_t *)copiedstring); >> > > You cannot cast a WCHAR* to a wchar_t*. > > -- Alexandre Julliard julliard(a)winehq.org Thanks, I assumed they were the same since under Windows WCHAR is typedef'ed as wchar_t. Is the proper way to handle this to use WideCharToMultiByte() on returnedstring and copiedstring, and then pass the converted (multibyte) strings to ok()? Christopher Berner

1 0

Re: kernel32: Forward fiber local storage APIs to thread local storage equivalents.
by Paul Chitescu Feb. 29, 2008

Feb. 29, 2008

Actually a lot of programs fail to start since the addition of these stubs. In particular anything that uses MSVCRT80. This is a major regression. Most applications seem to live a happy life without fiber local storage - is there one that would benefit from it? On Fri, 29 Feb 2008, Hans Leidekker wrote: > > Photoshop CS2 fails to start after the Fls* stubs were added. This patch > makes it start again but I'm not enough of an expert on this matter to say > if this is the right thing to do. > > -Hans > > Changelog > Forward fiber local storage APIs to thread local storage equivalents.

1 0

Re: msi: ACTION_RegisterProduct store all InstallProperties
by James Hawkins Feb. 29, 2008

Feb. 29, 2008

On Fri, Feb 29, 2008 at 9:13 AM, Adam Strzelecki <ono(a)java.pl> wrote: > Hi, > > WINE is writing properties such as Language or VersionMajor only to > Uninstall key in ACTION_RegisterProduct, while MSI_GetProductInfo is > trying to read those from InstallProperties key. > > So this patch duplicates all properties written into MSI product > Uninstall key, also to InstallProperies. > This is normal behavior I can see in Windows XP's MSI, as properties > are duplicated in both Uninstall and InstallProperties. > Please do not accept this patch. I'm trying to clean up the publishing code, and without tests to prove this case, it should not go in. The tests that do exist show that the properties are written into the Uninstall key on RegisterProduct, but not the product key. -- James Hawkins

1 0

Re: kernel32: Fix for WritePrivateProfileString Sharing Problem [2/2]
by James Hawkins Feb. 29, 2008

Feb. 29, 2008

On Fri, Feb 29, 2008 at 12:29 AM, Erich Hoover <ehoover(a)mines.edu> wrote: > Patch Originally From: > Louis Lenders > Description: > This patch adds conformance tests for WritePrivateProfileString sharing > problems. The patch was created by Louis Lenders and extensively tested, > but never submitted (see Bug #5024). Please note that a couple of the tests > now fail because cached profile information is returned, resolving that > problem is outside the scope of these patches. > Changelog: > kernel32: Test for WritePrivateProfileString Sharing Permissions > If a test fails, it has to be wrapped in todo_wine, else make test will fail. -- James Hawkins

2 3

Visual Studio 2005 installation finally works with WINE
by Adam Strzelecki Feb. 29, 2008

Feb. 29, 2008

Hi, Hmm.. I think my last mail didn't manage to get into the list because of too big image attachements, sorry. If it does, I'm sorry for dupes. I just want to mention that I've managed to install Visual Studio 2005 completely with WINE. 1) installed "vcrun6" (with winetricks) 2) applied 1 patch from http://bugs.winehq.org/show_bug.cgi?id=8439#c3 (Required for overall installation) 3) applied patched from http://appdb.winehq.org/appview.php?iVersionId=3754 (Required for .NET 2.0 installation) 4) applied "msi: ACTION_RegisterProduct store all InstallProperties" patch from wine-patches I've sent recently (Without this patch Visual Studio 2005 will think that MS XML 6.0 and some others is still uninstalled!) Installation goes without problem, however running "devenv.exe" causes several problems with .NET 2.0 packages and crashes a lot :( too bad. Most crashes and errors are because of few missing WINE API functions, and incomplete .NET 2.0 support. Still I think WINE's close to run Visual Studio! which will be great news for multi-platform developers. See attached screenshots from my MacBook Pro running OSX 10.5.2 at: http://bugs.winehq.org/show_bug.cgi?id=8439 Cheers, -- Adam Strzelecki |: nanoant.com :|

1 0

Visual Studio 2005 installation finally works with WINE
by Adam Strzelecki Feb. 29, 2008

Feb. 29, 2008

Hi, I just want to mention that I've managed to install Visual Studio 2005 completely with WINE. 1) installed "vcrun6" (with winetricks) 2) applied 1 patch from http://bugs.winehq.org/show_bug.cgi?id=8439#c3 (Required for overall installation) 3) applied patched from http://appdb.winehq.org/appview.php?iVersionId=3754 (Required for .NET 2.0 installation) 4) applied "msi: ACTION_RegisterProduct store all InstallProperties" match from patches list I just sent (Without this patch Visual Studio 2005 will think that MS XML 6.0 and some others is still uninstalled!) Installation goes without problem, however running "devenv.exe" causes several problems with .NET 2.0 packages and crashes a lot :( too bad. Most crashes and errors are because of few missing WINE API functions, and incomplete .NET 2.0 support. Still I think WINE's close to run Visual Studio! which will be great news for multi-platform developers. See attached screenshots from my MacBook Pro running OSX 10.5.2. Cheers, -- Adam Strzelecki |: nanoant.com :|

1 0

New winetricks 20080226: adds dotnet11 verb
by Dan Kegel Feb. 29, 2008

Feb. 29, 2008

In honor of .net 1.1 installing on today's git, here's a version of winetricks that knows how to grab and run the installer. Amusingly, I noticed that there are dozens of scripts out there that do this... it seems to be not uncommon in the windows world. As always, winetricks is at http://kegel.com/wine/winetricks and its source repository is at http://winezeug.googlecode.com BTW if anybody has any other small whiny things that almost but not quite fit in winehq, I'd be happy to consider hosting them in the winezeug repository. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

5 15

Re: Conformance tests for LoadStringW and LoadStringA
by Alexandre Julliard Feb. 29, 2008

Feb. 29, 2008

Christopher <raccoonone(a)procyongames.com> writes: > + ok(!memcmp(copiedstring, returnedstring, (length2 + 1)*sizeof(WCHAR)), > + "LoadStringW returned a string that does not match the string pointed to by the pointer it returned. \ > + returnedstring = %ls, copiedstring = %ls", (wchar_t *)returnedstring, (wchar_t *)copiedstring); You cannot cast a WCHAR* to a wchar_t*. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32: Move 16-bit printing functions to printdrv16.c.
by Alexandre Julliard Feb. 29, 2008

Feb. 29, 2008

Robert Shearman <rob(a)codeweavers.com> writes: > --- > dlls/gdi32/Makefile.in | 1 + > dlls/gdi32/printdrv.c | 752 > +--------------------------------------------- > dlls/gdi32/printdrv16.c | 779 > +++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 783 insertions(+), 749 deletions(-) That won't work, some of these functions are exported from gdi32. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dxdiagn: Fix the variable that the result of GetFileVersionInfoW is assigned to in DXDiag_AddFileDescContainer.
by Paul Vriens Feb. 29, 2008

Feb. 29, 2008

Robert Shearman wrote: > --- > dlls/dxdiagn/provider.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Rob, Is there a need to have it assigned, as the next line overwrites boolret again? -- Cheers, Paul.

2 1

Re: [PATCH] shlwapi: Handle PathCanonicalize with too long paths
by Robert Shearman Feb. 29, 2008

Feb. 29, 2008

Marcus Meissner wrote: > lpszPath) > { > WCHAR szPath[MAX_PATH]; > WCHAR szBuff[MAX_PATH]; > - MultiByteToWideChar(CP_ACP,0,lpszPath,-1,szPath,MAX_PATH); > + DWORD le = GetLastError(); > + int ret = MultiByteToWideChar(CP_ACP,0,lpszPath,-1,szPath,MAX_PATH); > + > + if (!ret) { > + FIXME("Failed to convert string to widechar (too long?), LE %d.\n", GetLastError()); > + SetLastError (le); /* failure does not change Lasterror, see testcase. */ > + return FALSE; > + } > Hi Marcus, FIXME should be used for unimplemented functionality, not for highlighting application bugs that will happen on Windows too. WARN would be more appropriate here. -- Rob Shearman

1 0

GSoC project ideas
by Kai Blin Feb. 28, 2008

Feb. 28, 2008

Hi, as promised, I'll start off this thread with the ideas we have on the wiki page [1] right now: * Implementing a WinePluginApi so other programs can use Windows DLLs inside of Linux apps * Improving our HTML/Win32 Help viewers. * Implementing the ASIO audio infrastructure for Cubase * Implement the MS Wsock dll (dlls/mswsock), an enhanced winsocket implementation * Valgrind and Wine integration (see: Wine_and_Valgrind) * Complete the Wine Web browser (aka. Internet Explorer) ie. frame controls, toolbar, status bar * Full URLMoniker implementation. (IE working with builtin urlmon.dll) * Implement transacted mode for OLE32 Storage (STGM_TRANSACTED) * Improve cmd.exe compatibility * Get Mozilla compiling as a Winelib application (http://www.winehq.org/site/winelib#mozilla) * Run the Mauve Java test suite against Sun's Windows JRE, and file bugs / write test cases in C / fix anything it finds * Run the MDAC conformance test suite against Microsoft's MDAC, and file bugs / write test cases in C / fix anything it finds * pick some real-world app or game that doesn't work well, and improve Wine so it installs and runs the app better. (Some good examples might be Photoshop, Visual Basic, a game etc) * pick a Windows feature that is incomplete in Wine, and improve the feature and its conformance tests. (Some good examples might be riched20, DirectPlay, etc) Feel free to add your own project ideas, maybe elaborate a bit on the deliverables of the idea. Cheers, Kai [1] http://wiki.winehq.org/SummerOfCode -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

8 14

Anybody has a patch for implementing WriteFileGather Kernel32.dll
by Michel Jacques Feb. 28, 2008

Feb. 28, 2008

Hello, I'm looking for an implementation of WriteFileGather in Kernel32.dll. Anybody has a candidate? Thanks in advance, Michel Jacques

3 2

Re: Spelling fixes (replace iff with if)
by Stefan Dösinger Feb. 28, 2008

Feb. 28, 2008

Am Donnerstag, 28. Februar 2008 18:19:28 schrieb Vitaly Lipatov: > Changelog: > - replace 'iff' with 'if' (just a spelling fixes) The usual meaning of iff is "if and only if", so its not necessarily a typo

1 0

Re: [2/10] WineD3D: Subclass queries
by Alexandre Julliard Feb. 28, 2008

Feb. 28, 2008

Stefan Dösinger <stefan(a)codeweavers.com> writes: > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c > index d1ab9a3..9dff960 100644 > --- a/dlls/wined3d/device.c > +++ b/dlls/wined3d/device.c > @@ -1143,6 +1143,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl_CreateQuery(IWineD3DDevice *iface, WINE > IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; > IWineD3DQueryImpl *object; /*NOTE: impl ref allowed since this is a create function */ > HRESULT hr = WINED3DERR_NOTAVAILABLE; > + const IWineD3DQueryVtbl *vtable; > > /* Just a check to see if we support this type of query */ > switch(Type) { > @@ -1161,6 +1162,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl_CreateQuery(IWineD3DDevice *iface, WINE > */ > FIXME("(%p) Event query: Unimplemented, but pretending to be supported\n", This); > } > + vtable = &IWineD3DEventQuery_Vtbl; > hr = WINED3D_OK; > break; So what is vtable set to in the other cases? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [4/10] D3D9: Don't use C casts to get the d3d9impl from IDirect3D9
by Alexandre Julliard Feb. 28, 2008

Feb. 28, 2008

Stefan Dösinger <stefan(a)codeweavers.com> writes: > This patch adds an inline conversion function similar to the ones used > in dinput. This is needed to implement IDirect3D9Ex, which uses a 2nd > vtable on the same object IDirect3D9Ex inherits from IDirect3D9, so you shouldn't need a 2nd vtable. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: Spelling fixes (replace iff with if)
by Dan Kegel Feb. 28, 2008

Feb. 28, 2008

lav at etersoft.ru wrote: > - replace 'iff' with 'if' (just a spelling fixes) 'iff' is shorthand for 'if and only if'. http://en.wikipedia.org/wiki/If_and_only_if So many of those 'typos' might actually be correct. Careful! - Dan

2 1

Re: [Wine] How about this replacement of WINE.
by Dan Kegel Feb. 28, 2008

Feb. 28, 2008

On Thu, Feb 28, 2008 at 8:26 AM, bussuser <wineforum-user(a)winehq.org> wrote: > http://www.reactos.org/forum/viewtopic.php?t=5240 > > It is based on WINE and ReactOS . It's not a wine replacement; it uses wine. Better description at http://www.reactos.org/forum/viewtopic.php?t=5240 It looks like they added hooks to the linux kernel to accept windows nt syscalls. Maybe they even allow using the system's normal shared library loader instead of Wine's special one. This is something I've often wanted to do, but it was way lower priority than getting wine working. I haven't looked at their project at all, no idea if it was done well. - Dan

4 5

Heap corruption in crypt32?
by Dan Kegel Feb. 28, 2008

Feb. 28, 2008

I strolled down memory lane a bit, and revisited the Sandra benchmark today, see http://www.winehq.org/pipermail/wine-devel/2006-December/052821.html Now the win2k version gets a lot farther. To install, first do sh winetricks vcrun2005sp1 gdiplus (Without native gdiplus, the installer complains you don't have it; without vcrun2005sp1, you get a few errors like fixme:actctx:parse_assembly_elem wrong version for assembly manifest.) The installer claims to be happy, but one sees err:module:import_dll Library CRYPTUI.dll (which is needed by L"C:\\windows\\temp\\is-KH13O.tmp\\certmgr.exe") not found err:module:LdrInitializeThunk Main exe initialization for L"C:\\windows\\temp\\is-KH13O.tmp\\certmgr.exe" failed, status c0000135 Could not get handle to service. on the console. Worse, when the app starts up, you get a heap error: err:heap:HEAP_ValidateInUseArena Heap 0x7f000000: in-use arena 0x7f02e2e0 next block has PREV_FREE flag err:heap:HEAP_ValidateInUseArena Heap 0x7f000000: bad back ptr 0x1c9ba51e for arena 0x7f02e798 I suppose that could be a result of cryptui being missing, but I ran it under valgrind anyway. This turned up interesting items like ==20325== Invalid read of size 1 ==20325== at 0x46F5E49: HEAP_CreateFreeBlock (heap.c:486) ==20325== by 0x46F621D: HEAP_ShrinkBlock (heap.c:575) ==20325== by 0x46F7979: RtlAllocateHeap (heap.c:1228) ==20325== by 0x5C60B74: new_object (handle.c:441) ==20325== by 0x5C6B1CD: new_key (rsaenh.c:830) ==20325== by 0x5C6C9DB: RSAENH_CPImportKey (rsaenh.c:2464) ==20325== by 0x4B4324A: CryptImportKey (crypt.c:1767) ==20325== by 0x4F2DCDC: CRYPT_ImportRsaPublicKeyInfoEx (encode.c:3923) ==20325== by 0x4F2DA3B: CryptImportPublicKeyInfoEx (encode.c:3955) ==20325== by 0x4F183FA: CRYPT_VerifyCertSignatureFromPublicKeyInfo (cert.c:1641) ==20325== by 0x4F1B069: CryptVerifyCertificateSignatureEx (cert.c:1723) ==20325== by 0x4F1EDCD: CRYPT_CheckSimpleChain (chain.c:744) ==20325== Address 0x7f02ecf8 is not stack'd, malloc'd or (recently) free'd quite early in the run (well before the heap errs). Juan, what do you make of it? Might this be a real bug in crypt32 or our heap? - Dan

2 1

Re: winejoystick.drv: Add axis remapping support
by Vitaliy Margolen Feb. 28, 2008

Feb. 28, 2008

Adolfo R. Brandes wrote: > Greetings! > > The purpose of this patch is to add registry axis remapping and POV > hat support to winejoystick.drv, much like what's already in place for > dinput/joystick_linux.c. I needed this for X-Wing Alliance > (http://appdb.winehq.org/objectManager.php?sClass=application&iId=2110) > which recognizes my Thrustmaster Top Gun Fox 2 Pro USB joystick, but > not the POV hat and with the Rudder and Throttle axes switched around. > > It uses the following conventions: > > HKCU\Software\Wine\Joystick\<joyname> = <axeslist> > > or > > HKCU\Software\Wine\AppDefaults\app.exe\Joystick\<joyname> = <axeslist> > > Where <joyname> is the device name (as shown in jstest), and > <axeslist> is a comma-separated list of axis names. However, in > contrast to joystick_linux.c, the axis names are the same as in > jstest. For example, in my case jstest reports: Don't do that. Keep it uniform. As-is it's a pain to configure. You want to introduce even more? First few general notes about your patch - do not mix tabs and spaces! Set tab width to be _always_ 8 spaces! For best results just don't use tabs. Do not change formating, of the function unless you changing big part of it and you changing it to default Wine formating (4 spaces, curly brackets on their own line). > +static char *axis_name(char *str, unsigned char type, int len) { > + switch(type) { > + case ABS_X: > + memcpy(str,"X",len - 1); > + break; > + case ABS_Y: The way you using this function it makes much more sense to return static text ex: static const char *axis_name(unsigned char type) { switch (type) { case ABS_X: return "X"; case ABS_Y: return "Y"; case ABS_Z: return "Z"; default: return "?"; } } BTW what will that "?" do? I don't see you comparing it against anything. > + else > + ERR("Not all joystick axes mapped: %d axes, %d arguments\n", nrOfAxes, j); Disabling axis might not be a bad thing, especially for testing. I don't think you need to worry about extra axis on the device that are not mapped to anything. > + for (i = 0; i < nrOfAxes; i++) > + switch(axis_map[i]) { > + case ABS_HAT0X: > + case ABS_HAT0Y: > + lpCaps->wCaps |= JOYCAPS_HASPOV; > + break; > + } You need both X and Y axis for it to work. You have to check that both are present. Also what about multiple POVs? Here you checking for only one. > switch(nrOfAxes) { > - case 6: lpCaps->wCaps |= JOYCAPS_HASV; > - case 5: lpCaps->wCaps |= JOYCAPS_HASU; > - case 4: lpCaps->wCaps |= JOYCAPS_HASR; > - case 3: lpCaps->wCaps |= JOYCAPS_HASZ; > - /* FIXME: don't know how to detect for > - JOYCAPS_HASPOV, JOYCAPS_POV4DIR, JOYCAPS_POVCTS */ > + case 6: > + lpCaps->wCaps |= JOYCAPS_HASV; > + lpCaps->wVmax = 0xFFFF; > + case 5: > + lpCaps->wCaps |= JOYCAPS_HASU; > + lpCaps->wUmax = 0xFFFF; > + case 4: > + lpCaps->wCaps |= JOYCAPS_HASR; > + lpCaps->wRmax = 0xFFFF; > + case 3: > + lpCaps->wCaps |= JOYCAPS_HASZ; > + lpCaps->wZmax = 0xFFFF; Now that you can remap axis it's not guaranteed that 6th axes is the speed and so on. Vitaliy.

2 2

Valgrind can't *quite* handle Adobe InDesign yet
by Dan Kegel Feb. 28, 2008

Feb. 28, 2008

http://bugs.kde.org/show_bug.cgi?id=126389 means that valgrind can't yet handle apps that throw exceptions during regular operation. Like, say, Adobe InDesign's installer. I would like to valgrind that to track down http://bugs.winehq.org/show_bug.cgi?id=11757 but I can't because valgrind doesn't handle fxrestor. I think, anyway... - Dan

2 3

schroedinger 1.0 (fast implementation of Dirac video codec) released
by Dan Kegel Feb. 28, 2008

Feb. 28, 2008

http://lwn.net/Articles/271058/ "Decodes HD720/25p in real-time on a Core Duo laptop" Yum. I'd like to see free codecs like this bundled with wine sometime.

1 0

Re: Alistair Leslie-Hughes : msvcrt: Implement wcscpy_s.
by James McKenzie Feb. 28, 2008

Feb. 28, 2008

Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 00609d5e7824a117084f3f4b75e1aec03b60102a > URL: http://source.winehq.org/git/wine.git/?a=commit;h=00609d5e7824a117084f3f4b7… > > Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Wed Feb 27 19:58:04 2008 +1100 > > msvcrt: Implement wcscpy_s. > > + > + if(size > numElement) > Is this correct? I think it should be different, maybe if (size<numElement)? > + { > + wcDest[0] = 0; > + return MSVCRT_EINVAL; > + } > + > + if(size > numElement) > This and the one above are the same. > + size = numElement; > + > + memcpy( wcDest, wcSrc, size*sizeof(WCHAR) ); > + > + return 0; > +} > > > >

3 3

Re: [AppDB] Add accessible link to front page
by Detlef Riekenberg Feb. 27, 2008

Feb. 27, 2008

On Mi, 2008-02-27 at 14:18 +0100, Alexander Nicolaysen Sørnes wrote: > Add a 'home' link to the top of the AppDB menu to make the front page > more accessible. > $g = new htmlmenu("AppDB"); > + $g->add('Home', BASE.'index.php'); What is more accessible in "AppDB" -> "Home" compared to "WineHQ Menu" -> "AppDB"? I see no difference. -- By by ... Detlef

3 2

Wineserver crash in inotify code
by Dan Kegel Feb. 27, 2008

Feb. 27, 2008

http://bugs.winehq.org/show_bug.cgi?id=11746 may explain a few mysterious wineserver crashes I saw a few weeks ago. Anyone feel like diving in to this one? It's probably a rat's nest of twisty linked lists, and a node isn't getting removed properly from all the lists it's in when it's freed, or something.

3 2

Re: [Wine] Re: Windows Kernel & Executive implementation
by Volodymyr Shcherbyna Feb. 27, 2008

Feb. 27, 2008

I am not sure that ReacOS is a good example. Quite a big amount of code in ReactOS contains leaked code of Windows (from Windows 2k). Recently I did a research, since I have access to Windows code(code premium subscription), I am able to compare things. 2008/2/23, Fireball <wineforum-user(a)winehq.org>: > > You could have a look at ReactOS about this (www.reactos.org) But anyway, > Wine's way of supporting this will [most probably] be different from > reactos' way. > > > > > > -- with best regards, Volodymyr

4 5

New winetricks 20080227: new verbs vbrun3, vbrun4, vbrun5, vbrun6
by Dan Kegel Feb. 27, 2008

Feb. 27, 2008

Detlef contributed verbs vbrun3 and vbrun4, thanks! And I added vbrun5 and vbrun6 as the preferred synonym for the existing verbs vbvm5 and vbrun60. That should be easier. As always, winetricks is at http://kegel.com/wine/winetricks and its source repository is at http://winezeug.googlecode.com

2 2

Bug for icons in toolbar (and how to deal with this in bugzilla)
by Paul Vriens Feb. 27, 2008

Feb. 27, 2008

Hi, This is about 'autoruns' from SysInternals (Microsoft) The icons on the first row of buttons look fine. All other rows however show the icons below the position they should actually be. I've looked at our bugzilla and found two bugs that look the same: http://bugs.winehq.org/show_bug.cgi?id=6948 http://bugs.winehq.org/show_bug.cgi?id=8813 Both are for different applications. Should I open a new one for 'autoruns' or use one of the existing ones? -- Cheers, Paul.

2 1

Re: msxml3:Implement wcscpy_s (try 4)
by Huw Davies Feb. 27, 2008

Feb. 27, 2008

On Wed, Feb 27, 2008 at 09:11:17PM +1100, Alistair Leslie-Hughes wrote: > Hi, > Corrected the spec file. > > Changelog: > msxml3: Implement wcscpy_s > > Best Regards > Alistair Leslie-Hughes > > From 5438165a1a5b3a2683948b93e34e9017f4958e61 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Wed, 27 Feb 2008 19:58:04 +1100 > Subject: [PATCH] Implement wcscpy_s > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/msvcrt/msvcrt.spec | 1 + > dlls/msvcrt/tests/string.c | 45 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/msvcrt/wcs.c | 41 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 87 insertions(+), 0 deletions(-) Note that the subject line should be 'msvcrt:...'. I guess Alexandre will fix this. Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Wine hostmask for Freenode IRC
by Kai Blin Feb. 27, 2008

Feb. 27, 2008

Hi folks. so what was the process of getting a wine/developer hostmask on freenode? I'll be hanging out on the #gsoc IRC channel, I'd like to make it a bit more obvious for students what project I mentor for. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

4 6

Re: X developer's conference, April 16-18
by Stefan Dösinger Feb. 27, 2008

Feb. 27, 2008

Hi, I'm picking up that topic again. I lost the original mail, so I apologize for the lost in-reply-to references. I think we have a few topics to talk to the X people about. If nobody else volunteers I could go to the conference personally, however, I'd need some support financing the travel costs. However, I'm European, so it might work better for someone local in the US. A few proposed topics: * Relative mouse movements * A few new GL extensions. Only partially concerns Xorg, but I think it is reasonable to present them there in the hope that ATI, Nvidia and Mesa people are there. -> Flat shading vertex colors -> sRGB writing without blending -> Texture rectangles with normalized coords -> GLSL support for some D3D shader instructions(mova, lit) -> More widespread support for a few existing extensions * Other things?

6 6

Re: msxml3: Implemented wcscpy_s (try 3)
by Dmitry Timoshkov Feb. 27, 2008

Feb. 27, 2008

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote: > Corrected comparisons, and error message in test. > diff --git a/dlls/msvcrt/msvcrt.spec b/dlls/msvcrt/msvcrt.spec > index d6cffcb..ebd718c 100644 > --- a/dlls/msvcrt/msvcrt.spec > +++ b/dlls/msvcrt/msvcrt.spec > @@ -761,6 +761,7 @@ > @ cdecl wcscmp(wstr wstr) ntdll.wcscmp > @ cdecl wcscoll(wstr wstr) MSVCRT_wcscoll > @ cdecl wcscpy(ptr wstr) ntdll.wcscpy > +@ cdecl wcscpy_s(wstr long wstr) MSVCRT_wcscpy_s What's happened to the spec entry fix? -- Dmitry.

2 1

.net 1.1 installs now!
by Dan Kegel Feb. 26, 2008

Feb. 26, 2008

Hey, http://bugs.winehq.org/show_bug.cgi?id=11678 is fixed, and VCToolkitSetup.exe now installs for me! Still more to do before .net 1.1 apps run, see http://bugs.winehq.org/show_bug.cgi?id=11742 And there are a few ugly looking nonfatal problems running the .net 1.1 installer, but they can wait...

2 1

Help me(Ajudem-me)C compiler cannot create executables
by flavio melo Feb. 26, 2008

Feb. 26, 2008

Hello I'm Flavio Melo(brazilian)! Well, i use the ubuntu 7.04, and there is any time that i try use the wine,but i no get install it, i can't for net because i haven't internet (repository), but i download the file wine-0.9.54 of your site in the other computer(in my job), and, i follow the instruccions(i think there are corrects, get it read manuals) and my terminal said: ---------------------------------------------------------------------------- flavio(a)Discipulo:~$ cd wine flavio(a)Discipulo:~/wine$ cd tools flavio(a)Discipulo:~/wine/tools$ ./wineinstall WINE Installer v0.75 ~/wine ~/wine/tools Running configure... configure: creating cache config.cache checking build system type... i686-pc-linux-gnulibc1 checking host system type... i686-pc-linux-gnulibc1 checking whether make sets $(MAKE)... yes checking for gcc... gcc checking for C compiler default output file name... configure: error: C compiler cannot create executables See `config.log' for more details. Configure failed, aborting install. flavio(a)Discipulo:~/wine/tools$ ----------------------------------------------------------------------------- I wrote to you for know if you can help me(Please), what i must make for my gcc compile? Thank for attencion! Meu testemunho... http://www.semearcristo.net/art/art_00007.aspx?idPag=1&idReg=1&idCat=6&strB… --------------------------------- Abra sua conta no Yahoo! Mail, o único sem limite de espaço para armazenamento!

3 2

Re: comctl32: rebar[1/4]: an implementation of RB_SIZETORECT (fixes bug #7774)
by John Klehm Feb. 26, 2008

Feb. 26, 2008

Missing patch On Tue, Feb 26, 2008 at 3:36 PM, Mikołaj Zalewski <mikolaj(a)zalewski.pl> wrote: > I couldn't work out the algorithm to make it pixel-for-pixel identical > as on Windows but this function implements the general idea that I hope > will work for applications. > > >

1 0

re: gdi32: Protect against short sized LOGPALETTE in CreatePalette.
by Dan Kegel Feb. 26, 2008

Feb. 26, 2008

Hi, your patch uses IsBadReadPtr(), but that function is deprecated in favor of using an exception handler. See http://www.winehq.org/pipermail/wine-devel/2006-April/046560.html Here's an example (sorry it's a messy one, it's just the first one google found): http://www.winehq.org/pipermail/wine-patches/2004-November/013791.html Please try recoding using that approach. If you have trouble getting this patch in, you might want to file a bug at http://bugs.winehq.org for your problem and link to your patch; that will record the problem so somebody else can pick it up later. - Dan

3 2

re: gdi32: Patch review request
by Dan Kegel Feb. 26, 2008

Feb. 26, 2008

Daniel Mario Vega wrote: >A few days ago I sent 2 patches for gdi32 to wine-patches >that passed unnoticed. I would like if someone could give > me some feedback on them. OK. I replied to each of them just now with my guess. Don't worry, patches being ignored is normal, it just means you have to improve them if possible and resend. If you do resend them, be sure to give the same subject as last time, with '(resend)' appended if no changes made, or '(try 2)' appended if there were changes, and append a note about the changes to the description.

1 0

re: gdi32: StartDocA support for legacy apps with incomplete DOCINFOA parameter.
by Dan Kegel Feb. 26, 2008

Feb. 26, 2008

This patch looks nice, but it could use a conformance test. Please add one and resend. And consider filing a bug and referring to the bug in the patch description, that never hurts. - Dan

1 0

Re: [try4] user32: cursoricon.c. Fix 16b BMP handling with BT_BITFIELD.
by Dmitry Timoshkov Feb. 26, 2008

Feb. 26, 2008

"Alexander Demakin" <avd(a)etersoft.ru> wrote: > This patch fixes image header handling with BT_BITFIELD value in biCompression > field. 3 DWORDs of mask were included into image bits, it caused some color > troubles and image horizontal shift. Size of bitmap info structure includes > now this bytes. > Changelog: > user32.dll Fix 16b BMP handling with BT_BITFIELD. I wonder whether gcc complained loudly that 'result' may be used uninitialized. -- Dmitry.

1 1

marshalled ITypeComp
by Guillermo Winkler Feb. 26, 2008

Feb. 26, 2008

Hi, I'm having some problems regarding ITypeInfo/ITypeComp implementation. IDispatch* pdisp; ITypeInfo* ptinfo; HRESULT hr = pdisp->GetTypeInfo(0, LOCALE_SYSTEM_DEFAULT, &typeinfo); hr = ptinfo->GetTypeComp(&ptcomp); pdisp is created from hr = CoCreateInstance(clsid, NULL, CLSCTX_SERVER, IID_IDispatch, (void**)&pdisp); That is, the server is an outprocess exe. In this case marshalling of ITypeComp fails in first instance because ITypeComp_fnQueryInterface (oleaut32\typelib.c) resolves on -> ITypeInfo_QueryInterface (oleaut32\typelib.c) That is not considering IID_ITypeComp as a valid alternative(but it is) if(IsEqualIID(riid, &IID_IUnknown) || IsEqualIID(riid,&IID_ITypeInfo)|| IsEqualIID(riid,&IID_ITypeInfo2)) *ppvObject = This; When I fixed this, I have a different problem now: fixme:ole:DllGetClassObject CLSID: {00020425-0000-0000-C000-000000000046} IID: {D5F569D0-593B-101A-B569-08002B2DBF7A} That is PSTypeComp to be marshalled asking for factory buffer IID_IPSFactoryBuffer. I would like to follow up with someone (if available) just to be sure I'm not wasting time on the wrong track. Thanks, Guillermo

2 2

gdi32: Patch review request
by Daniel Mario Vega Feb. 26, 2008

Feb. 26, 2008

Hi! A few days ago I sent 2 patches for gdi32 to wine-patches that passed unnoticed. I would like if someone could give me some feedback on them. Let me first give you some background about these patches. There is an application called "Compumap" that is a street map of some Argentine cities. It is rather popular here because some years ago it was distributed with a newspaper. The program works quite well under Wine (although the installer still has some problems), but when you try to print a map it crashes. A few weeks ago I had some free time and I decided to try to find out why it crashes. I run it through the Wine Debugger and also under a debugger in Windows XP. The problem happened to be two API calls with incomplete/invalid parameters. Windows XP returned NULL or ignore the wrong data, while Wine crashes. 1) gdi32: Protect against short sized LOGPALETTE in CreatePalette. http://www.winehq.org/pipermail/wine-patches/2008-February/050354.html This crash was caused by "CreatePalette(HDC, LOGPALETTE)" being called with a short allocated palette. Windows XP returned NULL in that case. I tried to reproduce that behavior by first checking the parameter with "IsBadReadPtr()" function. 2) gdi32: StartDocA support for legacy apps with incomplete DOCINFOA parameter. http://www.winehq.org/pipermail/wine-patches/2008-February/050357.html This issue was a call to "StartDocA(HDC, DOCINFOA)" with structure DOCINFOA not completely initialized (there is garbage in the last 2 fields). I debugged this API and found that Windows XP ignored those fields when the data "seems to be invalid". I think that the last 2 fields were introduced in Win32 and some applications ported from Win16 "forget" to clear them. I simulated Windows XP behaviour by putting some safe checks on those fields. With those 2 fixes, the application is able to print under Wine. Both patches are short and rather easy to review. I will appreciate if someone could give me some feedback on them. Thanks ... -- Daniel Mario Vega

1 0

Re: opengl32/tests: Add the trailing '\n' to an ok() call and make a spelling fix.
by Paul Vriens Feb. 26, 2008

Feb. 26, 2008

Francois Gouget wrote: > --- > dlls/opengl32/tests/opengl.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/opengl32/tests/opengl.c b/dlls/opengl32/tests/opengl.c > index 3836ba7..344e2c6 100644 > --- a/dlls/opengl32/tests/opengl.c > +++ b/dlls/opengl32/tests/opengl.c > @@ -384,9 +384,9 @@ START_TEST(opengl) > > /* We shouldn't be able to create a context from a hdc which doesn't have a pixel format set */ > hglrc = wglCreateContext(hdc); > - ok(hglrc == NULL, "wglCreateContext should fail when no pixel format has been set, but it passed"); > + ok(hglrc == NULL, "wglCreateContext should fail when no pixel format has been set, but it passed\n"); > error = GetLastError(); > - ok(error == ERROR_INVALID_PIXEL_FORMAT, "expected ERROR_INVALID_PIXEL_FORMAT for wglCreateContext without a pixelformat set, but recevied %#x", error); > + ok(error == ERROR_INVALID_PIXEL_FORMAT, "expected ERROR_INVALID_PIXEL_FORMAT for wglCreateContext without a pixelformat set, but recieved %#x\n", error); So where is the spelling fix ;-) Shouldn't that be "received"? -- Cheers, Paul.

1 0

Re: d3dx9: Add IMPORTLIB to every Makefile.in [PATCH 4/9]
by Alexandre Julliard Feb. 26, 2008

Feb. 26, 2008

tony.wasserka(a)freenet.de writes: >>From 881b8de1e044ff90bcb543501208a9cd879cbc16 Mon Sep 17 00:00:00 2001 > From: Tony Wasserka <tony.wasserka(a)freenet.de> > Date: Sat, 23 Feb 2008 13:55:40 +0100 > Subject: [PATCH] d3dx9: Add IMPORTLIB to every Makefile.in That shouldn't be needed, there are no such import libs on Windows. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9: Implement D3DXCheckVersion [PATCH 1/9]
by Alexandre Julliard Feb. 26, 2008

Feb. 26, 2008

tony.wasserka(a)freenet.de writes: > D3DXCheckVersion doesn't check for one specific D3DX version, but > for all that are compatible with our Wine code (i.e. d3dx9_24 to d3dx9_36) > The reasons for that were explained in these mails by me: > http://www.winehq.org/pipermail/wine-devel/2008-February/062290.html > and http://www.winehq.org/pipermail/wine-devel/2008-February/062292.html This is wrong, you should have a separate version check for each dll that checks the exact version of that dll. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcrt: Implemented wcscpy_s (try 2)
by Alistair Leslie-Hughes Feb. 26, 2008

Feb. 26, 2008

Hi, Is there any thing wrong with this patch? Best Regards Alistair Leslie-Hughes "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:fpljui$nsa$1(a)ger.gmane.org... > Hi, > Correct msvcrt.spec file > > Changelog: > msvcrt: Implemented wcscpy_s > -------------------------------------------------------------------------------- > From 6860771cc3fc06b3da63f7c674daf71861593ef3 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Fri, 22 Feb 2008 13:48:01 +1100 > Subject: [PATCH] Implemented wcscpy_s > > --- > dlls/msvcrt/msvcrt.spec | 1 + > dlls/msvcrt/tests/string.c | 45 > ++++++++++++++++++++++++++++++++++++++++++++ > dlls/msvcrt/wcs.c | 45 > ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 91 insertions(+), 0 deletions(-) > > diff --git a/dlls/msvcrt/msvcrt.spec b/dlls/msvcrt/msvcrt.spec > index d6cffcb..7b821e6 100644 > --- a/dlls/msvcrt/msvcrt.spec > +++ b/dlls/msvcrt/msvcrt.spec > @@ -761,6 +761,7 @@ > @ cdecl wcscmp(wstr wstr) ntdll.wcscmp > @ cdecl wcscoll(wstr wstr) MSVCRT_wcscoll > @ cdecl wcscpy(ptr wstr) ntdll.wcscpy > +@ cdecl wcscpy_s(ptr long wstr) MSVCRT_wcscpy_s > @ cdecl wcscspn(wstr wstr) ntdll.wcscspn > @ cdecl wcsftime(ptr long wstr ptr) MSVCRT_wcsftime > @ cdecl wcslen(wstr) ntdll.wcslen > diff --git a/dlls/msvcrt/tests/string.c b/dlls/msvcrt/tests/string.c > index c6dcd34..b09d204 100644 > --- a/dlls/msvcrt/tests/string.c > +++ b/dlls/msvcrt/tests/string.c > @@ -50,6 +50,7 @@ static int* (*pmemcmp)(void *, const void *, size_t n); > static int (*pstrcpy_s)(char *dst, size_t len, const char *src); > static int (*pstrcat_s)(char *dst, size_t len, const char *src); > static int (*p_mbsnbcpy_s)(unsigned char * dst, size_t size, const > unsigned char * src, size_t count); > +static int (*p_wcscpy_s)(wchar_t *wcDest, size_t size, const wchar_t > *wcSrc); > > #define SETNOFAIL(x,y) x = (void*)GetProcAddress(hMsvcrt,y) > #define SET(x,y) SETNOFAIL(x,y); ok(x != NULL, "Export '%s' not found\n", > y) > @@ -562,6 +563,47 @@ static void test__mbsnbcpy_s(void) > dest[0], dest[1], dest[2], dest[3], dest[4], dest[5], dest[6], > dest[7]); > } > > +static void test_wcscpy_s(void) > +{ > + static const WCHAR szLongText[] = { > 'T','h','i','s','A','L','o','n','g','s','t','r','i','n','g',0 }; > + static WCHAR szDest[18]; > + static WCHAR szDestShort[8]; > + int ret; > + > + if(!p_wcscpy_s) > + { > + skip("wcscpy_s not found\n"); > + return; > + } > + > + /* Test NULL Dest */ > + ret = p_wcscpy_s(NULL, 16, szLongText); > + ok(ret == EINVAL, "p_wcscpy_s expect EINVAL got %d\n", ret); > + > + /* Test NULL Source */ > + szDest[0] = 'A'; > + ret = p_wcscpy_s(szDest, 16, NULL); > + ok(ret == EINVAL, "expected EINVAL got %d\n", ret); > + ok(szDest[0] == 0, "szDest[0] not 0\n"); > + > + /* Test invalid size */ > + szDest[0] = 'A'; > + ret = p_wcscpy_s(szDest, 0, szLongText); > + ok(ret == EINVAL, "expected ERANGE got %d\n", ret); > + ok(szDest[0] == 0, "szDest[0] not 0\n"); > + > + /* Copy same buffer size */ > + ret = p_wcscpy_s(szDest, 18, szLongText); > + ok(ret == 0, "expected 0 got %d\n", ret); > + ok(lstrcmpW(szDest, szLongText) == 0, "szDest != szLongText\n"); > + > + /* Copy smaller buffer size */ > + szDest[0] = 'A'; > + ret = p_wcscpy_s(szDestShort, 8, szLongText); > + ok(ret == ERANGE, "expected EINVAL got %d\n", ret); > + ok(szDestShort[0] == 0, "szDest[0] not 0\n"); > +} > + > START_TEST(string) > { > char mem[100]; > @@ -577,6 +619,7 @@ START_TEST(string) > SET(pstrcpy_s,"strcpy_s"); > SET(pstrcat_s,"strcat_s"); > SET(p_mbsnbcpy_s,"_mbsnbcpy_s"); > + SET(p_wcscpy_s,"wcscpy_s"); > > /* MSVCRT memcpy behaves like memmove for overlapping moves, > MFC42 CString::Insert seems to rely on that behaviour */ > @@ -599,4 +642,6 @@ START_TEST(string) > test_strcpy_s(); > test_strcat_s(); > test__mbsnbcpy_s(); > + > + test_wcscpy_s(); > } > diff --git a/dlls/msvcrt/wcs.c b/dlls/msvcrt/wcs.c > index 92dd644..66b8907 100644 > --- a/dlls/msvcrt/wcs.c > +++ b/dlls/msvcrt/wcs.c > @@ -27,6 +27,8 @@ > #include "wine/unicode.h" > #include "wine/debug.h" > > +#include <msvcrt/errno.h> > + > WINE_DEFAULT_DEBUG_CHANNEL(msvcrt); > > > @@ -971,3 +973,46 @@ INT CDECL MSVCRT_iswxdigit( MSVCRT_wchar_t wc ) > { > return isxdigitW( wc ); > } > + > +/********************************************************************* > + * wcscpy_s (MSVCRT.@) > + */ > +INT CDECL MSVCRT_wcscpy_s( MSVCRT_wchar_t* wcDest, size_t numElement, > const MSVCRT_wchar_t *wcSrc) > +{ > + int size = 0; > + > + if(!wcDest) > + return EINVAL; > + > + if(!wcSrc) > + { > + wcDest[0] = 0; > + return EINVAL; > + } > + > + if(numElement <= 0) > + { > + wcDest[0] = 0; > + > + if(numElement < 0) > + return ERANGE; > + else > + return EINVAL; > + } > + > + size = strlenW(wcSrc) + 1; > + > + if(size > numElement) > + { > + wcDest[0] = 0; > + return ERANGE; > + } > + > + if(size > numElement) > + size = numElement; > + > + memcpy( wcDest, wcSrc, size*sizeof(WCHAR) ); > + > + return 0; > +} > + > -- > 1.5.4.1 > > -------------------------------------------------------------------------------- > >

2 1

Re: [6/6] msxml3: Tests for put_data
by Alistair Leslie-Hughes Feb. 26, 2008

Feb. 26, 2008

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:fpu31c$upv$4(a)ger.gmane.org... > +#if 0 > +/* For some Reason, IXMLDOMComment_put_data cannot be found even though > it can > + be exists in msxml2.h. > + */ > + /* put data Tests */ > + hr = IXMLDOMComment_put_data(pComment, _bstr_("This &is a > ; test <>\\")); > + ok(hr == S_OK, "ret %08x\n", hr ); > + > +#endif Hi, Im a little confused, IXMLDOMComment_put_data wasnt compiling on my machine, and yet Alexandre changed to include this code and now it compiles correctly? I event tried a >make clean; ./configure; make depend;make which didnt work either. Can anybody explain what was fixed? Best Regards Alistair Leslie-Hughes

2 1

Re: wininet: Fix retrieving the raw headers
by Alexandre Julliard Feb. 26, 2008

Feb. 26, 2008

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes: > @@ -3059,12 +3060,14 @@ static INT HTTP_GetResponseHeaders(LPWININETHTTPREQW lpwhr) > * We should first receive 'HTTP/1.x nnn OK' where nnn is the status code. > */ > memset(buffer, 0, MAX_REPLY_LEN); > + memset(buffertoken, 0, MAX_REPLY_LEN); > if (!NETCON_getNextLine(&lpwhr->netConnection, bufferA, &buflen)) > goto lend; > MultiByteToWideChar( CP_ACP, 0, bufferA, buflen, buffer, MAX_REPLY_LEN ); > + MultiByteToWideChar( CP_ACP, 0, bufferA, buflen, buffertoken, MAX_REPLY_LEN ); That's ugly, it shouldn't be necessary to have two copies of the whole data just to parse some status codes. -- Alexandre Julliard julliard(a)winehq.org

1 0

Valgrind results. Update for glibc-2.6.
by Dan Kegel Feb. 25, 2008

Feb. 25, 2008

Today's valgrind results online at http://kegel.com/wine/valgrind/logs-2008-02-25-summary.txt http://kegel.com/wine/valgrind/logs-2008-02-25/ Nothing too special (thanks for the cleanup, James), but this is the first set of results after updating my test machine from feisty to gutsy, and I had to apply http://kegel.com/wine/valgrind/futimesat.patch to my copy of valgrind svn to handle the new glibc properly. Already reported to Valgrind; see http://sourceforge.net/mailarchive/forum.php?thread_name=a71bd89a0802240546…

3 3

Re: Add a slight delay before testing the ddraw and d3d9 visual tests
by Dmitry Timoshkov Feb. 25, 2008

Feb. 25, 2008

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > This makes the tests pass on my pc. Perhaps there is something less hacky way like GdiFlush() which is more appropriate for this. -- Dmitry.

2 3

Re: d3dx9_xx
by Francois Gouget Feb. 25, 2008

Feb. 25, 2008

On Fri, 22 Feb 2008, "Luis C. Busquets Pérez" wrote: > The number of functions reported in > http://www.winehq.org/site/winapi_stats > for the following dlls is > > d3dx9_24 308 [...] That's because d3dx9_36 has some forwards to functions that have not been declared in d3dx8, not even as a stub. It's allowed of course but winapi does not like it and thus ignores those. Here's the list: d3dx9_36.spec: forward is broken: D3DXFresnelTerm => d3dx8.D3DXFresnelTerm d3dx9_36.spec: forward is broken: D3DXGetImageInfoFromFileA => d3dx8.D3DXGetImageInfoFromFileA d3dx9_36.spec: forward is broken: D3DXGetImageInfoFromFileInMemory => d3dx8.D3DXGetImageInfoFromFileInMemory d3dx9_36.spec: forward is broken: D3DXGetImageInfoFromFileW => d3dx8.D3DXGetImageInfoFromFileW d3dx9_36.spec: forward is broken: D3DXGetImageInfoFromResourceA => d3dx8.D3DXGetImageInfoFromResourceA d3dx9_36.spec: forward is broken: D3DXGetImageInfoFromResourceW => d3dx8.D3DXGetImageInfoFromResourceW d3dx9_36.spec: forward is broken: D3DXIntersectSubset => d3dx8.D3DXIntersectSubset d3dx9_36.spec: forward is broken: D3DXIntersectTri => d3dx8.D3DXIntersectTri d3dx9_36.spec: forward is broken: D3DXQuaternionSquadSetup => d3dx8.D3DXQuaternionSquadSetup d3dx9_36.spec: forward is broken: D3DXSplitMesh => d3dx8.D3DXSplitMesh d3dx9_36.spec: forward is broken: D3DXTessellateNPatches => d3dx8.D3DXTessellateNPatches -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ You can have my guns when you pry them from my kids cold, dead hands.

1 0

How should we treat users on bugzilla?
by Dan Kegel Feb. 25, 2008

Feb. 25, 2008

I've been seeing a lot of bugs closed as INVALID when a poor user didn't file the bug perfectly. IMHO this leads to Wine having a user-hostile reputation. Case in point: http://bugs.winehq.org/show_bug.cgi?id=11625 What can we do to reduce this kind of behavior? Maybe we should have a "three warnings" sort of policy. If somebody continues to be rude to users after being asked twice not to, we should consider taking away their Bugzilla privileges for a while. Sure, that would hurt our productivity, but it might be better to do that than to alienate our users. What do other people think? - Dan

13 28

Re: WGL: wglDeleteContext should fail on garbage handles [attempt2]
by Alexandre Julliard Feb. 25, 2008

Feb. 25, 2008

"Roderick Colenbrander" <thunderbird2k(a)gmx.net> writes: > Subject: [PATCH] wglDeleteContext should fail on a garbage hglrc. When > we receive garbage ctx->hdc is invalid which leads to a > crash. Retrieve a default DC and use it to pass hglrc to the display > driver. Luckily the opengl code maintains a list of valid opengl > contexts, so it can detect whether the hglrc is valid or not. :) If we are going to go in this direction, then the context should be made opaque in gdi32, and all calls should use the default DC. The alternative is to make the context a proper GDI handle, and have GDI check it for validity first. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11drv: Distinguish left and right keys for shift, ctrl and alt.
by Alexandre Julliard Feb. 25, 2008

Feb. 25, 2008

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > --- a/dlls/winex11.drv/keyboard.c > +++ b/dlls/winex11.drv/keyboard.c > @@ -1022,9 +1022,9 @@ static const WORD nonchar_key_vkey[256] = > 0, 0, 0, 0, 0, 0, 0, 0, /* FFD0 */ > 0, 0, 0, 0, 0, 0, 0, 0, /* FFD8 */ > /* modifier keys */ > - 0, VK_SHIFT, VK_SHIFT, VK_CONTROL, /* FFE0 */ > - VK_CONTROL, VK_CAPITAL, 0, VK_MENU, > - VK_MENU, VK_MENU, VK_MENU, 0, 0, 0, 0, 0, /* FFE8 */ > + 0, VK_LSHIFT, VK_RSHIFT, VK_LCONTROL, /* FFE0 */ > + VK_RCONTROL, VK_CAPITAL, 0, VK_MENU, > + VK_MENU, VK_LMENU, VK_RMENU, 0, 0, 0, 0, 0, /* FFE8 */ > 0, 0, 0, 0, 0, 0, 0, 0, /* FFF0 */ > 0, 0, 0, 0, 0, 0, 0, VK_DELETE /* FFF8 */ This is going to change the vkeys everywhere, I don't think that's correct. Things like WM_KEYDOWN have to report VK_SHIFT, not VK_LSHIFT etc. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: winex11drv: Remove special treatment for caps-lock and num-lock keys. [try-2]
by Alexandre Julliard Feb. 25, 2008

Feb. 25, 2008

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > - if (vkey) > - { > - switch (vkey & 0xff) > + if (!vkey) return; > + > + /* Adjust the NUMLOCK state if it has been changed outside wine */ > + if (!(key_state_table[VK_NUMLOCK] & 0x01) != !(event->state & NumLockMask)) > { > - case VK_NUMLOCK: > - KEYBOARD_GenerateMsg( VK_NUMLOCK, 0x45, event->type, event_time ); > - break; > - case VK_CAPITAL: > - TRACE("Caps Lock event. (type %d). State before : %#.2x\n",event->type,key_state_table[vkey]); > - KEYBOARD_GenerateMsg( VK_CAPITAL, 0x3A, event->type, event_time ); > - TRACE("State after : %#.2x\n",key_state_table[vkey]); > - break; > - default: > - /* Adjust the NUMLOCK state if it has been changed outside wine */ > - if (!(key_state_table[VK_NUMLOCK] & 0x01) != !(event->state & NumLockMask)) > - { > - TRACE("Adjusting NumLock state.\n"); > - KEYBOARD_GenerateMsg( VK_NUMLOCK, 0x45, KeyPress, event_time ); > - KEYBOARD_GenerateMsg( VK_NUMLOCK, 0x45, KeyRelease, event_time ); > - } > - /* Adjust the CAPSLOCK state if it has been changed outside wine */ > - if (!(key_state_table[VK_CAPITAL] & 0x01) != !(event->state & LockMask)) > - { > - TRACE("Adjusting Caps Lock state.\n"); > - KEYBOARD_GenerateMsg( VK_CAPITAL, 0x3A, KeyPress, event_time ); > - KEYBOARD_GenerateMsg( VK_CAPITAL, 0x3A, KeyRelease, event_time ); > - } > - /* Not Num nor Caps : end of intermediary states for both. */ > - NumState = FALSE; > - CapsState = FALSE; > + TRACE("Adjusting NumLock state (%#.2x).\n", key_state_table[VK_NUMLOCK]); > + X11DRV_send_keyboard_input( VK_NUMLOCK, 0x45, KEYEVENTF_EXTENDEDKEY, event_time, 0, 0 ); > + X11DRV_send_keyboard_input( VK_NUMLOCK, 0x45, KEYEVENTF_EXTENDEDKEY | KEYEVENTF_KEYUP, event_time, 0, 0 ); > + } > + /* Adjust the CAPSLOCK state if it has been changed outside wine */ > + if (!(key_state_table[VK_CAPITAL] & 0x01) != !(event->state & LockMask)) > + { > + TRACE("Adjusting Caps Lock state (%#.2x).\n", key_state_table[VK_CAPITAL]); > + X11DRV_send_keyboard_input( VK_CAPITAL, 0x3A, 0, event_time, 0, 0 ); > + X11DRV_send_keyboard_input( VK_CAPITAL, 0x3A, KEYEVENTF_KEYUP, event_time, 0, 0 ); > + } You still need to handle the case of caps lock or num lock keys differently, otherwise you'll generate duplicate messages. -- Alexandre Julliard julliard(a)winehq.org

1 0

SetPixelFormat broken in 0.9.54
by bill lam Feb. 25, 2008

Feb. 25, 2008

I run a opengl script that worked in 0.9.53 but crashed in 0.9.54 (and 0.9.55) I traced it failed at this line SetPixelFormat hdc;pixfmt;pfd with the following message in console: X Error of failed request: BadAccess (attempt to access private resource denied) Major opcode of failed request: 160 (Composite) Minor opcode of failed request: 1 () Serial number of failed request: 164 Current serial number in output stream: 182 Is this a known issue? ubuntu 7.10 amd64 regards,

2 1

GSOC (proposal)
by David Adam Feb. 25, 2008

Feb. 25, 2008

Here are my wishes for GSOC: D3DX dlls begin to be implemented. It seems that this could be a good GSOC to implement more feature of this dll, in particular the shader compiler. In the view of wined3d, I think about vertex blending, since there are tons of game using this feature. Stefan, is this doable in the scope of GSOC? Sound should be improved also, since there are games that still crash, in despite of M. Lankhorst's great job ( dmime, quartz,.... dlls problem). And the last but not the least :D: fix the infamous warping mouse bug. I know that it is mainly a problem with X server, but maybe a wine develooper could propose a GSOC to Xorg guys to fix this. David A.

3 2

AppDB stats
by Tony Lambregts Feb. 25, 2008

Feb. 25, 2008

Just a little note to all about the appdb stats. We now have 9000 application versions in the database. http://appdb.winehq.org/appdbStats.php Users: 23474 Comments: 21305 Application families: 5814 Versions: 9000 Application maintainers: 1462 Test reports: 18572 Screenshots: 6234 The Application maintainer stats is the most interesting in that we have 1462 individuals who now maintain applications. Most of these are regular users of wine and I for one really appreciate their effort in helping others. I would also like to recognize the individuals who have helped improve the AppDB code lately. Alexander Nicolaysen Sørnes Chris Morgan Jeff Zaroyko -- Tony Lambregts

1 0

re: GSoC project ideas
by Dan Kegel Feb. 25, 2008

Feb. 25, 2008

Kai wrote: > * Implementing a WinePluginApi so other programs can use > Windows DLLs inside of Linux apps That one's very tricky and systemy, a successful student would have to be a kernel and/or glibc maven, too. > * Valgrind and Wine integration (see: Wine_and_Valgrind) That one's sorted, or will be, so let's strike it. > * Run the Mauve Java test suite against Sun's Windows JRE, and file bugs / > write test cases in C / fix anything it finds Done. Mauve's a mess. We pass the part of it that makes sense. > * pick a Windows feature that is incomplete in Wine, and improve the feature > and its conformance tests. (Some good examples might be riched20 Believe it or not, there's still stuff to do there, I think. (Mostly COM-related?) - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

[1/7] D3D9: Add a non-shader reversed fog test
by Luke Bratch Feb. 25, 2008

Feb. 25, 2008

Something in this patch set breaks Peggle (Steam game, comes with The Orange Box) when it's running in software rendering mode. There is just a whole lot of: fixme:d3d_surface:surface_convert_format Cannot find a conversion function from format WINED3DFMT_X8R8G8B8 to WINED3DFMT_X8R8G8B8 Printed in the console. ___________________________________________________________ Rise to the challenge for Sport Relief with Yahoo! For Good http://uk.promotions.yahoo.com/forgood/

2 3

Sending updates to wine developers guide
by Austin English Feb. 25, 2008

Feb. 25, 2008

I was looking at the website.git online, I can't find the documentation so I can edit it. http://source.winehq.org/git/website.git/?a=blob;f=templates/en/documentati… references /docs/, but that doesn't exist on git. I'm sure a lot of the info is outdated, but I was mostly looking to fix the regression testing guides, which still reference CVS, and are horribly outdated. Any possibility of adding /docs/ to website.git? -Austin

2 1

Re: [3/4].Wbemprox.dll. Main modules for then library.
by Robert Shearman Feb. 25, 2008

Feb. 25, 2008

Ivan Sinitsin wrote: > --- /dev/null 2007-03-10 18:36:24 +0300 > +++ Makefile.in 2008-02-21 15:57:24 +0300 > @@ -0,0 +1,23 @@ > +TOPSRCDIR = @top_srcdir@ > +TOPOBJDIR = ../.. > +SRCDIR = @srcdir@ > +VPATH = @srcdir@ > +MODULE = wbemprox.dll > +IMPORTLIB = libwbemprox.$(IMPLIBEXT) > +IMPORTS = ole32 oleaut32 user32 advapi32 kernel32 shell32 > +EXTRALIBS = -luuid > + > +C_SRCS = \ > + main.c \ > + regsvr.c \ > + i_numwbemclassobject.c \ > + i_wbemservices.c \ > + mainclass.c \ > + factory.c > The files i_numwbemclassobject.c and i_wbemservices.c aren't included with this patch, so Wine would not compile if this patch was applied. Please also reconsider the naming of these files - I presume i_ standards for interface, but you aren't declaring an interface in these files but implementing an object. > + > + > +IDL_I_SRCS = wbemprox.idl > + > +(a)MAKE_DLL_RULES@ > + > +(a)DEPENDENCIES@ # everything below this line is overwritten by make depend > -- Rob Shearman

1 0

Re: [2/4]try2.Wbemprox.dll. Idl file.
by Robert Shearman Feb. 25, 2008

Feb. 25, 2008

Ivan Sinitsin wrote: > --- /dev/null 2007-03-10 18:36:24 +0300 > +++ wbemprox.idl 2008-02-21 16:09:20 +0300 > @@ -0,0 +1,260 @@ > Then doesn't appear to be a wbemprox.idl file in any version of the Platform SDK that I have access to. The interfaces in your file are in wbemcli.idl instead. Also, please diff from the toplevel wine directory. -- Rob Shearman

1 0

GSoC 2008 kickoff.
by Kai Blin Feb. 25, 2008

Feb. 25, 2008

Hi folks, Google announced the 2008 programme today and I wanted to use the opportunity to talk about the next steps we should take to get ready. I will start a separate thread to start collecting project ideas, presenting the ones mentioned on the wiki page [1]. New project ideas are very much welcome. If any of you feels like mentoring one of the projects, please mention that. If you're a student with your own project idea, please mention that as well. We will then have to discuss if we believe the projects are doable in a Summer of Code timeframe. When we talked about last year's projects on WineConf, it was the common opinion that we didn't do a very good job on that for 2007. I don't have a surefire solution for this, we should try being a bit more conservative though. I will add some more documentation to the SoC wiki page, does anybody have a good idea what we could call the post-mortem analysis? I know this is a correct technical term, but in my opinion it sounds a bit negative. Lacking a better alternative, I'd call it review. Can the native speakers come up with something else? Maarten, you wrote a wiki page about your 2007 experience. Could you add it to the "Helpful Links" section? [1] http://wiki.winehq.org/SummerOfCode Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: [msi/tests] Make tests run on win9x/NT4 again
by James Hawkins Feb. 25, 2008

Feb. 25, 2008

On Sun, Feb 24, 2008 at 10:30 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > MsiSourceListEnumSourcesA and MsiSourceListSetInfoA are only available as of W2K. > > Some tests will still fail on those platforms as the missing functions are not > skipped yet (part of a next patch when time permits). > > Changelog > Make tests run on win9x/NT4 again > This is nitpicky, but it took a long time to write those tests so I feel it's deserved. - r = MsiSourceListEnumSourcesA(prodcode, NULL, MSIINSTALLCONTEXT_USERUNMANAGED, + r = pMsiSourceListEnumSourcesA(prodcode, NULL, MSIINSTALLCONTEXT_USERUNMANAGED, MSICODE_PRODUCT | MSISOURCETYPE_URL, 0, NULL, &size); You can't see it in this email because it's wrapped, but the style of the file is that the continued function parameters on the next lines match up with the first character on the first line. So you need to add the missing space to any continuing lines. Please fix that. -- James Hawkins

2 1

Re: add rule for the .m suffix
by Emmanuel Maillard Feb. 24, 2008

Feb. 24, 2008

Hi, Did you convince Alexandre Julliard to include Objective-C on wine tree ?? Because you need to if you want to submit my patches to winehq, or rewrite it in plain C with Carbon. Emmanuel Le 20 févr. 08 à 13:31, Steven Edwards a écrit : > This is needed for quartzdrv patch. Trying to reduce the size of the > diff, I expect a real winequartzdrv will need it later on anyway > > -- > Steven Edwards > > "There is one thing stronger than all the armies in the world, and > that is an idea whose time has come." - Victor Hugo > <support-m-suffix.patch>

3 2

USB with libusb
by Eliot Blennerhassett Feb. 24, 2008

Feb. 24, 2008

Greetings, I have been reading about general USB support. E.g. http://www.winehq.org/?issue=331#USB%20Support%20in%20Wine which mentions 4 scenarios for giving apps access to USB. But here's a 5th that I am wondering about: The Windows app has been linked to (win32) libusb. How do I get it to use the linux version of libusb? Will it "just work", or do I need to make a libusb.dll for Wine that passes calls through to linux libusb? (I am talking to a hardware manufacturer that currently uses their own custom .sys driver to access usb on windows, suggesting libusb might make their app easier to port or just run with Wine) thanks and regards -- Eliot

2 1

USB with libusb
by Eliot Blennerhassett Feb. 24, 2008

Feb. 24, 2008

Greetings, I have been reading about general USB support. E.g. http://www.winehq.org/?issue=331#USB%20Support%20in%20Wine This mentions 4 scenarios. But here's a 5th that I am wondering about: The Windows app has been linked to libusb. How do I get it to use the linux version of libusb? Will it "just work", or do I need to make a libusb.dll for Wine that passes calls through to linux libusb? (I am talking to a hardware manufacturer that currently uses their own custom .sys driver to access usb on windows, suggesting libusb might make their app easier to port or just run with Wine) thanks and regards -- -- Eliot

1 0

Re: d3dx9: Add stubs for the ID3DXFont functions [PATCH 5/9, try 2]
by tony.wasserka＠freenet.de Feb. 24, 2008

Feb. 24, 2008

> You have fixed object to *object, what about other places with > a similar problem? Also, the stubs have to use FIXME not TRACE, > and if you do nothing with a passed in parameter, don't assign > it to an internal variable. There is no need to cast NULL either. > If you allocate memory on object creation, you must free it on > object destruction. There is no need to initialize 'object' to > NULL if on the next line you are doing an attempt to allocate it. > What's the point of adding all those includes to d3dx9_36_private.h > if you are not using them? Thanks for that detailed response :) I have fixed what you said and have attached the fixed patch to this mail. The added includes prevented the compilation from failing, but some of them were really not needed as you pointed out. If there won't be any criticisms until tomorrow afternoon I'll resend it to wine-patches.

1 0

Wine and PulseAudio
by Tomas Carnecky Feb. 24, 2008

Feb. 24, 2008

This subject was discussed a few months ago (around 10/2007). But it was rather a discussion about whether to make a PA sound driver or not. I personally would love to see that happen, if not only because PA has some very nifty features, like per-app volume, transparent sink switching etc, some of which are impossible to emulate through the alsa pulse plugin. Also, then next Ubuntu and Fedora releases will have PA enabled by default so if Wine doesn't work with that well there will be complaints. I switched my desktop to PA yesterday, got most apps working, and to my surprise even flash (netscape 32bit plugin in a 64bit browser). All apps that I need use PA natively, only Wine doesn't have a PA sound driver. Since winealsa.drv will stay the default driver for Linux for the foreseeable future, I started digging and hacking to see why it doesn't work with the alsa pulse plugin and what can be fixed. There are a few bug reports that track the winealsa.drv/PA issue, such as [1]. There is very little required to make it work. Only two tiny changes to the alsa pulse plugin (one can be described as a quirk, until I figure out how exactly the alsa API can be emulated using PA, seems to be a very specific issue in how Wine uses the alsa API since other apps work fine) and sound works perfectly (tested with foobar2000 and WoW, both playback and recording). alsa-1.0.16 was just released, so I hope the needed changes make it into the next version. In the PA volume control, all wine apps show up under the same name: ALSA plug-in [wine-preloader] and thus share the same volume and sink preferences. The alsa plugin could try to do some /proc/self voodoo to extract the true exe name. But given the simplicity of the PA API (no hwparams negotiation, just request a format and you'll get it) and the current problems with the alsa pulse plugin, I think a true wine sound driver would be a viable alternative. I'm still waiting to hear from those people who have said that they have a wine PA driver working :) tom [1] http://bugs.winehq.org/show_bug.cgi?id=10910.

3 6

Re: d3dx9: Add stubs for the ID3DXFont functions [PATCH 5/9, try 2]
by Dmitry Timoshkov Feb. 24, 2008

Feb. 24, 2008

<tony.wasserka(a)freenet.de> wrote: > Replaced the S_OKs with D3D_OKs, moved the QueryInterface TRACE out of the if condition > and replaced object by *object. You have fixed object to *object, what about other places with a similar problem? Also, the stubs have to use FIXME not TRACE, and if you do nothing with a passed in parameter, don't assign it to an internal variable. There is no need to cast NULL either. If you allocate memory on object creation, you must free it on object destruction. There is no need to initialize 'object' to NULL if on the next line you are doing an attempt to allocate it. What's the point of adding all those includes to d3dx9_36_private.h if you are not using them? -- Dmitry.

1 0

Re: d3dx9: Add stubs for the ID3DXRenderToSurface functions [PATCH 8/9]
by tony.wasserka＠freenet.de Feb. 24, 2008

Feb. 24, 2008

> Shouldn't that be a n (here and in the other patches)? > Setting object to NULL here doesn't do a whole lot, you should set > *object to NULL (also goes for the other QueryInterface > implementations). Also, you'll probably want to put the TRACE before > the if block. Thank you very much for pointing that out :) Is there anything else wrong with it or can I resend the patches? Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl. http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/i…

3 2

Re: d3dx9: Add stubs for the ID3DXRenderToSurface functions [PATCH 8/9]
by H. Verbeet Feb. 24, 2008

Feb. 24, 2008

On 23/02/2008, tony.wasserka(a)freenet.de <tony.wasserka(a)freenet.de> wrote: > +static HRESULT WINAPI ID3DXRenderToSurfaceImpl_QueryInterface(LPD3DXRENDERTOSURFACE iface, REFIID riid, LPVOID *object) > +{ > + ID3DXRenderToSurfaceImpl *This=(ID3DXRenderToSurfaceImpl*)iface; > + > + if(IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_ID3DXRenderToSurface)) { > + TRACE("(%p): QueryInterface from %sn", This, debugstr_guid(riid)); > + IUnknown_AddRef(iface); > + *object=This; > + return S_OK; > + } > + WARN("(%p)->(%s, %p): not foundn", iface, debugstr_guid(riid), object); > + object=NULL; > + return E_NOINTERFACE; > +} > + Setting object to NULL here doesn't do a whole lot, you should set *object to NULL (also goes for the other QueryInterface implementations). Also, you'll probably want to put the TRACE before the if block.

1 0

Re: d3dx9: Add stubs for the ID3DXFont functions [PATCH 5/9]
by H. Verbeet Feb. 24, 2008

Feb. 24, 2008

On 23/02/2008, tony.wasserka(a)freenet.de <tony.wasserka(a)freenet.de> wrote: > + TRACE("stubn"); Shouldn't that be a \n (here and in the other patches)?

1 0

Re: gdiplus: Implement GdipLoadImageFromFile
by Dmitry Timoshkov Feb. 23, 2008

Feb. 23, 2008

"Nathan Beckmann" <nathan.beckmann(a)gmail.com> wrote: > stat = GdipCreateBitmapFromStream(stream, bitmap); > > - if(!stat) > + if(stream) > IStream_Release(stream); The 'if' check above is not needed, GdipCreateStreamOnFile returns a status which is already checked. > + stat = GdipCreateStreamOnFile(filename, GENERIC_READ, &stream); > + > + if (stat != Ok) > + return stat; > + > + stat = GdipLoadImageFromStream(stream, image); > + > + if (stream) > + IStream_Release(stream); Same thing here. -- Dmitry.

1 0

Re: gdiplus: Implement GdipLoadImageFromFile
by James Hawkins Feb. 23, 2008

Feb. 23, 2008

On Sat, Feb 23, 2008 at 11:00 PM, Nathan Beckmann <nathan.beckmann(a)gmail.com> wrote: > Hi. My name is Nathan Beckmann. I'm working on GDI+ for a class > project at UCLA (sponsored by Google). > > This patch implements GdipLoadImageFromFile. > > It includes basic tests for invalid parameters, all of which pass on > Windows. I'm working on this in order to get ConvertImage.exe > (http://bugs.winehq.org/show_bug.cgi?id=10980) to work. Now I'm > working on image encoders/decoders. > > Implemented GdipLoadImageFromFile using > GdipLoadImageFromStream. Implementation based on > GdipCreateBitmapFromFile. > > Changed GdipCreateBitmapFromFile to properly release the Stream COM > object. > > Added tests for CreateBitmapFromFile and LoadImageFromFile when passed > with invalid parameters. One fix per patch. http://winehq.org/site/sending_patches -- James Hawkins

1 0

re: Sending updates to wine developers guide
by Dan Kegel Feb. 23, 2008

Feb. 23, 2008

> I can't find the documentation so I can edit it. Look at the bottom of http://winehq.org/site/git The command to load it into a local git repository is git cvsimport -v -k -d :pserver:anonymous(a)wine.cvs.sourceforge.net:/cvsroot/wine docs You can then send in patches.

1 0

Bugs fixed in 0.9.56
by Dan Kegel Feb. 23, 2008

Feb. 23, 2008

Here are the bugs marked fixed during the 0.9.56 cycle. (A few of them were fixed earlier, but not marked as such before.) 1737 Metafiles embedded in Rich Text don't render 3768 Blood 2 The Chosen - keyboard and mouse do not work 5114 suggesting more descriptive desktop window titles 5503 Opening help in Office97 triggers unhandled page fault 6383 Dual-core not being correctly supported 6914 C&C Red Alert pauses on shaking game view 7544 ReplaceFileW not implemented 7660 Mouse Movement not recognized at slower speeds in World of Warcraft 8236 Dungeon Siege 2 has some animation issues 8687 Online Poker program: unimplemented classes in shdocvw 8722 Unhandled Exception in InstallShield Wizard for 'Star Wars: The Best of PC' Games 9741 URLDownloadToFile only supports HTTP URL's 9917 Add X11 child window for client area 10010 Call of Duty 4 Demo: Fails to start: "Video card or driver doesn't support separate alpha blend." 10083 Inverted colours in C&C RA demo exit screen 10736 iTunes 7.5 hangs 10787 Can't install 3ds max 9 10808 Saitek P990 crashes MVP Baseball 2005 10973 Regression: Commandos 3 - menu not properly rendered 11008 Problem through the registration of an assembly 11009 Battlefield 1942: no longer starts after patching to Version 1.6 11037 Painkiller game crashes on startup 11136 Trados: TagEditor loosing contact with Workbench. 11187 Scanf bug 11204 mail inspector doubles messages in 0.9.53 11257 Can't install Slingplayer 11340 Warcraft 3 displays the start splashscreen forever and doesn't continue with the game start. 11348 EVE Online: character portrait parts are rendered with glitches 11362 ChemDraw9 messed up struture fonts 11398 Some PhotoShop controls are not working properly. 11426 Cryptographic exception in .NET Framework application 11480 msi2xml fails to convert an msi file to xml 11488 corefont installers hanging 11514 Adobe Acrobat Professional 6 fails to install 11545 call of duty 4 stopped working around the time of 0.9.54(not fixed with 55) 11550 Speed Commander 12 hangs on install while copying files 11553 Paintbrush movement becomes erratic with large brush in photoshop 11573 GTA San Andreas: Mouse skips with recent change to Wine 11645 OSDRT Client fails with "Protocol error: process 0015: sendmsg: Bad file descriptor" (wineserver crash) 11646 resident evil 4 crash just after wine start - Dan

2 2

wined3d: ActivateContext: try to fix wrong parameter?
by Rico Schüller Feb. 23, 2008

Feb. 23, 2008

Hi, as suggested I send this patch for a discussion. This is a workaround for this bug http://bugs.winehq.org/show_bug.cgi?id=11584 . I don't know if this patch is the right way to fix the problem. Could someone with more knowledge have a look at this? Cheers Rico

4 5

Re: website: add links to most popular active Wine forums
by Tom Wickline Feb. 22, 2008

Feb. 22, 2008

If you know of another active Wine forum - especially a non-english one - please let us know so we can add it to the list. (Email to dank(a)kegel.com would do.) Русский http://www.wine-forum.org/forumdisplay.php?f=44 Tom P.S Sorry, the forums at http://www.wine-forum.org/index.php were not popular enough to make this cut, may I ask how many users = popular? The forum has 750+ registered users in just over three months... 1, 2, 5 thousand?? On Tue, Feb 19, 2008 at 12:45 AM, Dan Kegel <dank(a)kegel.com> wrote: > Perhaps this will help slake the thirst of those who periodically ask > if Wine needs a forum. > > > >

12 20

Re: [Wine] Windows Kernel & Executive implementation
by Volodymyr Shcherbyna Feb. 22, 2008

Feb. 22, 2008

Read comments inline, 2008/2/23, Alan McKinnon <alan.mckinnon(a)gmail.com>: > > On Friday 22 February 2008, Volodymyr Shcherbyna wrote: > > Hello Tres, > > > > Yes, agree, there might be Linux equivalents to accomplish the same > > tasks. But let me pickup the description of winehq from official > > web-site : "[...] a compatibility layer for running Windows programs > > [...]". Doesn't that mean, that *all* software should work? > > > NO. > > It means that applications that users can reasonably expect to run > should be able to run. Note that it is applications that Wine targets. The description is quite non-precise. Who defines the policy of what should be run and what shouldn't? What I am trying to explain, is that, once something is designed to be compatible with Windows API, it should be compatible with at any case at any layers. For example, there is no sane reason in the world that VC++ should > always work under Wine, considering the deep knowledge of Windows that > is built into VC++. If you are developing a Windows app, then you > should compile it on ... Windows. And Wine runs atop a *nix system, so > it has no need to implement any NTFS-specific code as it does not need > to use NTFS as a storage layer. Should you need to manipulate NTFS for > some reason, we have ntfs-ng for that job. I don't care about file systems. What I would like to see in wine, is a little more abstractionist things, for example, file system filters support. NDIS IM filters, TDI providers, WFP, Kernel sockets and other things. There has to be a point where Wine stops and the correct answer to > anything more is "You should use Windows for that". I believe that line > lies just beyond user-space apps. Any other ideas on this issue? -- > Alan McKinnon > alan dot mckinnon at gmail dot com > > > -- with best regards, Volodymyr

1 0

Re: [Wine] Windows Kernel & Executive implementation
by Volodymyr Shcherbyna Feb. 22, 2008

Feb. 22, 2008

RegMon was just one of the examples. But basically, RegMon uses vxd driver for Windows 9x. For XP it uses NT driver which hooks SDT. On Server 2003 it uses legacy registry notification API. UMDF support started from XP. It does not cover 2k. Also, UMDF is just a part of WDF. However, I think it will be good to implement basic things, like NT drivers support. 2008/2/23, Dan Kegel <dank06(a)kegel.com>: > > Volodymyr Shcherbyna <v_scherbina(a)mvps.org> wrote: > > >>>[many apps use helper device drivers, e.g. RegMon, FileMon, TDIMom] > > > > http://source.winehq.org/source/dlls/ntoskrnl.exe/ntoskrnl.c > > > Unfortunately, that code just do stubs, and it is not actually executed > in > > kernel mode. > > > The current ntoskrnl.c is enough to run a few apps. > It's not intended to run arbitrary NT drivers. > > Now, RegMon uses a VxD, and I don't think we're ever planning on > really supporting those. Wine does ship with nine 'fake' VxD's; > these were added because they were needed by popular apps. > So if you have a particular VxD that's important enough, > we can reimplement it as part of Wine. > > I just noticed Microsoft's UMDF (User Mode Driver Framework). > I bet we could support UMDF drivers pretty well if we wanted to. > Have you ever played with that? > > - Dan > -- with best regards, Volodymyr

1 0

New winetricks 20080222: new verb 'colorprofile' by Hans
by Dan Kegel Feb. 22, 2008

Feb. 22, 2008

Hans Leidekker is working on http://bugs.winehq.org/show_bug.cgi?id=11532 (Photoshop doesn't support custom monitor profiles), and contributed a new verb for winetricks, 'colorprofile'. As usual, you can pick it up at http://kegel.com/wine/winetricks

1 0

wineprefixcreate failing?
by Maarten Lankhorst Feb. 22, 2008

Feb. 22, 2008

Hi all, Is it just me or is wineprefixcreate crashing horribly for others as well? Cheers, Maarten.

2 2