February 2008 - Wine-Devel - list.winehq.org

Re: WineD3D: request alpha in backbuffer mode, to work correctly with multiple opengl pixel formats
by Stefan Dösinger Feb. 22, 2008

Feb. 22, 2008

Am Freitag, 22. Februar 2008 23:31:43 schrieb Roderick Colenbrander: > Hi, > > In the default backbuffer based renderer in WineD3D the front and > backbuffer share the same pixel format while D3D itself decouples them. A > lot of applications use alpha on the backbuffer, so make sure we have > alpha. This change is needed because the single pixel format which we had > before always had alpha. > + /* In case of ORM_BACKBUFFER, make sure to request an alpha component for X4R4G4B4/X8R8G8B8 as we might need it for the backbuffer. */ It would be for offscreen buffers, not the back buffer. I'm sorry for the confusion in the earlier mail

1 0

Re: 1/2 WGL: remove the pixel format limitation (!)
by Stefan Dösinger Feb. 22, 2008

Feb. 22, 2008

Am Freitag, 22. Februar 2008 21:16:23 schrieb Roderick Colenbrander: > WineD3D has some small issues due to this change but those should be > investigated by Stefan, Chris, me and others. The code should get a lot of > testing as soon as possible. We discussed this on IRC. The problem is that we're still defaulting to back buffer / aux buffer offscreen rendering, and thus offscreen targets are bound to use the same format as the back buffer. In the D3D9 test this means that the backbuffer is X8R8G8B8, and the onscreen target is A8R8G8B8. The alpha is missing with this patch(used to be always there), so the test fails. The proper fix is to switch to FBOs for onscreen rendering whereever possible(FBO support still has problems that prevent that though), and on cards without FBOs try to use A8R8G8B8 instead of X8R8G8B8 for the backbuffer, and similarly for X1R5G5B5 and X4R4G4B4.

1 1

Re: [Wine] Windows Kernel & Executive implementation
by Volodymyr Shcherbyna Feb. 22, 2008

Feb. 22, 2008

Unfortunately, that code just do stubs, and it is not actually executed in kernel mode. -- with best regards, Volodymyr 2008/2/22, Dan Kegel <dank(a)kegel.com>: > > On Fri, Feb 22, 2008 at 3:02 AM, Volodymyr Shcherbyna > <v_scherbina(a)mvps.org> wrote: > > > I discovered that WineHQ project does not have support for drivers (am > I > > wrong?). In other words, quite a big amount of applications will fail > to > > function properly, because many of them are using helper device drivers > to > > get some extended functionality. I can just mention RegMon, FileMon, > TDIMom, > > and others. > > > I know very little about this, but my impression is that > Wine supports a limited set of NT os kernel APIs already. > The initial support was added by this patch: > http://www.winehq.org/pipermail/wine-cvs/2007-May/032546.html > The current set of supported calls can be seen here: > http://source.winehq.org/source/dlls/ntoskrnl.exe/ntoskrnl.c > > Feel free to implement more, or file enhancement requests > describing what nt os apis a popular app needs. > > - Dan >

1 0

Re: msi: MsiMergeDatabaseA/W stub
by James Hawkins Feb. 22, 2008

Feb. 22, 2008

On Thu, Feb 21, 2008 at 2:26 PM, Johan Dahlin <jdahlin(a)async.com.br> wrote: > Add stubs for MsiMergeDatabaseA/W, used by WiX's msi validation. > > diff --git a/dlls/msi/database.c b/dlls/msi/database.c > index 425486e..e74db8f 100644 > --- a/dlls/msi/database.c > +++ b/dlls/msi/database.c > @@ -1119,3 +1119,22 @@ HRESULT create_msi_remote_database( IUnknown *pOuter, LPVOID *ppObj ) > > return S_OK; > } > + > +UINT WINAPI MsiDatabaseMergeW( MSIHANDLE hDatabase, > + MSIHANDLE hDatabaseMerge, > + LPCWSTR szTableName ) > +{ > + FIXME("(%ld %ld %s): stub!\n", hDatabase, hDatabaseMerge, > + debugstr_w(szTableName)); > + return ERROR_SUCCESS; > +} > + > +UINT WINAPI MsiDatabaseMergeA( MSIHANDLE hDatabase, > + MSIHANDLE hDatabaseMerge, > + LPCSTR szTableName ) > +{ > + FIXME("(%ld %ld %s): stub!\n", hDatabase, hDatabaseMerge, > + szTableName); > + > + return ERROR_SUCCESS; > +} > Please use the same style as the rest of the file (4 space indentation). The A version should be before the W version. -- James Hawkins

2 2

Re: [1/2] user32:scroll: Added some tests for scrollbar [try2]
by Anatoly Lyutin Feb. 22, 2008

Feb. 22, 2008

Alexandre Julliard wrote: > The tests fail: > > ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p > user32_test.exe.so scroll.c && touch scroll.ok > scroll.c:56: Test failed: The scrollbar window should be disabled. > scroll.c:122: Test failed: The ShowScrollBar() should failed. > Yes! These tests must be failed in WINE, but it passes clear in Win XP. I just want to show you some incorrect behavior of scrollbar in WINE. Should I mark these tests as "todo_wine"? -- Best regards Anatoly Lyutin.

2 2

Re: [2/3] qmgr: Implement IUnkown interface for IBackgroundCopyJob.
by Alexandre Julliard Feb. 22, 2008

Feb. 22, 2008

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > +static ULONG WINAPI BITS_IBackgroundCopyJob_AddRef(IBackgroundCopyJob* iface) > +{ > + ICOM_THIS_MULTI(BackgroundCopyJobImpl, lpVtbl, iface); > + return InterlockedIncrement(&This->ref); > +} There's no reason to use something like ICOM_THIS_MULTI with a single interface. And if you really do have multiple interfaces, please use an inline function instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Printing images
by Alexander Demakin Feb. 22, 2008

Feb. 22, 2008

Hi all, I have some troubles with printing. BitBlt returns error when calling it for printer context due to implementation of PSDRV_SelectBitmap(). Does anybody know how to implement this function? Where can i find any documentation about it? Implementation of SelectBitmap() in EMFDRV and MFDRV just returns 0. Is it correct? Please, share your ideas. Thanks in advance, Demakin Alexander.

1 0

gdiplus: negative stride from dipCreateBitmapFromFile
by bill lam Feb. 22, 2008

Feb. 22, 2008

WHen I read a jpeg file of size about 600x400 pixels using gdiplus like this, GdipCreateBitmapFromFile fn BMP GdipGetImageWidth BMP w GdipGetImageHeight BMP h rt=. 0 0, w, h GdipBitmapLockBits BMP rt ImageLockModeRead PixelFormat32bppARGB DATA 'w h s f p r'=. DATA the member stride inside bitmapdata is negative, and its data buffer cannot be read successfully. when using native gdiplus that stride is positive, and it work ok. wine said itself cannot handle negitive stride yet so why itself create a bitmap wih negative stride in GdipCreateBitmapFromFile?

1 0

Re: New dll. Wbemprox.dll
by Alistair Leslie-Hughes Feb. 22, 2008

Feb. 22, 2008

Ivan Sinitsin wrote: > This patch add new library to the project wine. Name of the library > is - "wbemprox.dll".This library is a part of WMI technology. Now there four > interfaces are described - "IWbemLocator, IWbemServices, > IEnumWbemClassObject, IWbemClassObject". Almost all methods are stubs. > This library is used with some programs like "1C", to get some information > about system. > > static struct regsvr_interface const interface_list[] = { >+ { &IID_IWbemLocator, >+ "IWbemLocator", >+ NULL, >+ 1, /*ÞÉÓÌÏ ÍÅÔÏÄÏ×*/ Comment should be in English. >#define _WIN32_WINNT 0x0600 > >#ifndef __wbemprox_PRIVATE_H__ Defining _WIN32_WINNT doesn't seem right. This patches is large, try breaking it up. Best Regards Alistair Leslie-Hughes

1 0

Fun Project: Add dialogs to builtin IE
by Steven Edwards Feb. 22, 2008

Feb. 22, 2008

Hi, I submitted a proof of concept patch for this a week or so back that added a simple file->exit menu to the builtin Internet Explorer. I've spoken with Jacek a bit about it and it seems shdocvw.dll is the correct place to implement the UI layout if we are targeting IE versions less the 7. There seems to be a plugin interface the GUI uses for browser extensions but if a first pass I don't think we really need to support it. Unfortuntly due to time constraints I am not going to be able to work on this project so if there is anyone out there that wants to contribute with a simple fun project, please feel free to add menus, dialogs and the address bar. I'll try to help as best I can but I expect to be tied up for some time to come. Thanks Steven -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: msvcrt: Implemented wcscpy_s
by Dmitry Timoshkov Feb. 21, 2008

Feb. 21, 2008

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote: > --- a/dlls/msvcrt/msvcrt.spec > +++ b/dlls/msvcrt/msvcrt.spec > @@ -761,6 +761,7 @@ > @ cdecl wcscmp(wstr wstr) ntdll.wcscmp > @ cdecl wcscoll(wstr wstr) MSVCRT_wcscoll > @ cdecl wcscpy(ptr wstr) ntdll.wcscpy > +@ cdecl wcscpy_s(wstr long wstr) MSVCRT_wcscpy_s Type of the first parameter should be ptr, not wstr. -- Dmitry.

1 0

Re: appdb: Increase readability by using slightly softer colours on Warning and Notes
by Francois Gouget Feb. 21, 2008

Feb. 21, 2008

On Wed, 20 Feb 2008, Jeff Zaroyko wrote: > The default colours for warnings and notes on the appdb pages feel > rather strong, this patch changes the red and blue to be a bit softer. > > I think this makes it more readable. A comparison can be seen here: > http://jeffz.name/tmp/ In new.png the green looks darker than the others. Maybe it should be lightened up a bit too. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ In a world without fences who needs Gates?

4 7

Re: dmband: Indirection levels fix
by Robert Shearman Feb. 21, 2008

Feb. 21, 2008

Andrew Talbot wrote: > diff --git a/dlls/dmband/band.c b/dlls/dmband/band.c > index 891fb5a..8b89573 100644 > --- a/dlls/dmband/band.c > +++ b/dlls/dmband/band.c > @@ -173,7 +173,7 @@ static HRESULT WINAPI IDirectMusicBandImpl_IDirectMusicObject_SetDescriptor (LPD > This->pDesc->ftDate = pDesc->ftDate; > if (pDesc->dwValidData & DMUS_OBJ_MEMORY) { > This->pDesc->llMemLength = pDesc->llMemLength; > - memcpy (This->pDesc->pbMemData, pDesc->pbMemData, sizeof (pDesc->pbMemData)); > + memcpy (&This->pDesc->pbMemData, &pDesc->pbMemData, sizeof (pDesc->pbMemData)); > } > if (pDesc->dwValidData & DMUS_OBJ_STREAM) { > /* according to MSDN, we copy the stream */ This isn't correct. Judging by the surrounding code, this should be allocating a block of memory of This->pDesc->pbMemData and then passing pDesc->llMemLength into memcpy, possibly validating that pDesc->llMemLength isn't greater than UINT_MAX to avoid an overflow. -- Rob Shearman

2 1

Re: [1/2] ddraw: release interfaces when exiting with error
by Stefan Dösinger Feb. 21, 2008

Feb. 21, 2008

Am Mittwoch, 20. Februar 2008 22:03:51 schrieben Sie: > --- > dlls/ddraw/texture.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) Just a general comment(not specific to comments): For such cleanup work it works quite nice to use goto(!), as shown below. Your patch is OK as it is, but I think its a good idea to use this scheme in all places because it helps to prevent new problems from coming in when the code is changed. void *a = NULL, *b = NULL, *c = NULL; a = malloc(10); if(!a) goto error; b = malloc(10); if(!b) goto error; c = malloc(10); if(!c) goto error; if(dosomethingelse() == FAIL) goto error; return SUCCESS; error: f(c) free(c); f(b) free(b); f(a) free(a); return FAIL;

1 0

Re: dplayx: Fix incorrect check in DirectPlayLobbyAImpl_EnumLocalApplications and IDirectPlayLobbyAImpl_EnumAddressTypes.
by Marcus Meissner Feb. 21, 2008

Feb. 21, 2008

On Thu, Feb 21, 2008 at 04:44:34PM +0000, Robert Shearman wrote: > > Dereferencing a function pointer and checking it against NULL doesn't make > any sense, so remove the checks. > - if( !lpEnumAddressTypeCallback || !*lpEnumAddressTypeCallback ) > + if( !lpEnumAddressTypeCallback ) It looks as if they were meant as &&, but that does not make much sense either. Ciao, Marcus

1 0

Re: James Hawkins : itircl: Add a stub implementation of itircl.dll.
by Detlef Riekenberg Feb. 21, 2008

Feb. 21, 2008

On Sa, 2008-02-16 at 09:57 -0600, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 58b0686e951364686c3b5b55c18566df0960fd96 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=58b0686e951364686c3b5b55c… > > Author: James Hawkins <jhawkins(a)codeweavers.com> > Date: Fri Feb 15 17:39:46 2008 -0600 > > itircl: Add a stub implementation of itircl.dll. Hi James. While adding your Patch to http://wiki.winehq.org/Developers-Hints , I found this Page: http://www.helpware.net/aphelp/info.htm itircl.dll: HTML Help 1 (found on w2k and xp) itircl52.dll: MS Help 2 apircl.dll: Assistance Platform 1.0 (Vista) -- By by ... Detlef

1 0

Re: slc: Added stub for SLGetWindowsInformationDWORD
by Paul Vriens Feb. 21, 2008

Feb. 21, 2008

On Thu, Feb 21, 2008 at 10:20 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > Changelog: > slc: Added stub for SLGetWindowsInformationDWORD > > Best Regards > Alistair Leslie-Hughes > Hi Alistair, I know that function descriptions should always be your own words but I guess this is also true for header files. The comments in slerror.h are exactly like the comments on MSDN: http://msdn2.microsoft.com/en-us/library/aa965835(VS.85).aspx Cheers, Paul.

3 2

Re: Adding devices in setupapi
by Erich Hoover Feb. 20, 2008

Feb. 20, 2008

> > I think it probably does something similar to: > http://www.codeproject.com/KB/system/RemoveDriveByLetter.aspx > > Except instead of mapping a drive to usb device, it does it the other > way around. > > After looking more into it it really looks like this is the thing it > does. (I need a bunch of hacks for it to work, but alas.) However it > doesn't get me much further since our IOCTL_STORAGE_GET_DEVICE_NUMBER > ioctl is a stub. I would need something that can at least guarantee > uniqueness per volume for it, perhaps a conversion of drive letter to > integer. Now I just need to figure that one out. > > Cheers, > Maarten. > > I do not believe the device number matching is the problem, I have been exploring this problem a little with RemoveDriveByLetter and I believe that it is not working because the SymbolicLink entry is not added as a "real" thing in Wine. Performing an experiment with accessing the same drive letter in three different ways (results below, last parameter is "hDrive") I see that only the call with the registry-returned value for the drive fails (even if it is added to "HKLM/System/MountedDevices"). I believe that a call to IoCreateSymbolicLink must be made in order for the name returned by the registry to be recognized as an alias for the drive. I think iTunes is probably going through the device tree looking for its vendor and product code. It should get this back from CM_Get_Device_ID, but I do not have Windows so I cannot fake iTunes out to confirm this. SetupDiGetDeviceInterfaceDetail '\\?\USBSTOR#Disk&Ven_Apple&Prod_iPod&Rev_1.62#000A27001420C124&0#{53f56307-b6bf-11d0-94f2-00a0c91efb8b}': -1 SetupDiGetDeviceInterfaceDetail '\\?\Volume{00000000-0000-0000-0000-000000000048}': 60 SetupDiGetDeviceInterfaceDetail '\\.\H:': 64 Device number comparison: 1 1

1 0

No new Wine Weekly News?
by Austin English Feb. 20, 2008

Feb. 20, 2008

Hasn't been a new Wine Weekly News in about a month...quite a bit has been going on, with CS2 working out of the box, test suite fixes, etc. Anyone know what's going on? -Austin

2 1

Re: appdb: database issues
by Chris Morgan Feb. 20, 2008

Feb. 20, 2008

In include/query.php in query_appdb() we only call mysql_connect() if the global $hAppdbLink isn't a valid resource. So, when a user connects to display a page the first query should open the connection and upon completion of the script $hAppdbLink will be freed and the connection should be closed. So I'm not sure that this is the cause of the out-of-connections issue although I don't see a reason why we shouldn't just let php take care of this internally and apply a variation of your change where we always attempt to connect and select the appropriate database and remove the global handle and the resource check etc. Chris On Wed, Feb 20, 2008 at 6:01 PM, Jeff Zaroyko <jeffzaroyko(a)gmail.com> wrote: > The mysql database for the appdb/bugzilla appears to have gone down again, > I decided to look at the connection code in the appdb, as the appdb is thought > to be the culprit. > > I came across the call to mysql_connect which is using the new_link parameter > set to true, which is supposedly to force a new connection to be established. > > So, I searched through the git commit history using gitk and saw that Paul van > Schayck made a change introducing this, apparently because mysql was having > stability issues, back in 2005. > > http://www.winehq.org/pipermail/wine-patches/2005-January/014985.html > > my understanding is that php will automagically reuse connections if this is not > set, would there by any objection to trialling a removal of this > option to see if > stability increases? > > > >

1 0

Kudos for Photoshop work
by Dan Kegel Feb. 20, 2008

Feb. 20, 2008

In http://linux.slashdot.org/comments.pl?sid=460616&cid=22493322, an anonymous coward said: --- snip --- Preamble: I'm a photographer needing to process tens of thousands of photos relatively swiftly. The functionality I need isn't all that advanced (curves, levels, an occasional straighten horizon (measure + arbitrary rotate), crop, unsharp mask, and sometimes an action to find edges, feather and apply unsharp mask on that), but being able to access and apply this functionality swiftly is an absolute must because of the volume of photos I deal with. Photoshop is optimized to perfection to allow a swift workflow, while the gimp seems optimized to perfection to hinder it. Focus is never where I need it, shortcuts to access tools don't work depending on which sub-window has focus, etc. So yes, I really need Photoshop. I last tried Photoshop 7 under wine about a year ago. It was functional to an amazing degree (for someone who'd never seen or used wine before), but the rough edges were slightly too rough for me to be able to switch to Linux fulltime. I could trigger a dozen crashes in Photoshop at will just by resizing panels and doing other simple things like that, the program didn't feel native (alt-tabbing would keep the panels in the foreground, obscuring other programs), and focus sometimes strayed, amongst other lesser (but still annoyingly noticeable) issues. I just tried the latest wine with these Google sponsored improvements, and wow. This is an amazing difference. Every single issue I saw a year ago is gone. Photoshop feels as responsive as it does under Windows (perhaps even more so), and I went through an hour long editing session without being slowed down or annoyed even once. As far as I'm concerned, Linux is now ready to become my main OS. Google: I don't like your lack of respect for my privacy, but for this work on Wine, I can say from the bottom of my heart: Thank you! --- snip --- Ah. Music to my ears :-) - Dan

1 0

Re: Adding devices in setupapi
by Juan Lang Feb. 20, 2008

Feb. 20, 2008

> How hard is it to create a stub forwarder dll for setupapi and cfgmgr32? Not sure what you mean exactly. cfgmgr32 should forward to setupapi already, and I sent a patch that does that for the few stub functions that it had. setupapi's CM_* stubs could be improved, but I don't think you'll be able to forward them to any native code to try out: I expect the Windows configuration manager is rather too low level to run under Wine. You'll probably want to create a hacky version of setupapi that creates a fake device tree, with a root, USB hub, and iPod device, just to see if that makes iTunes happy. Does that answer your question? --Juan

2 1

Re: James Hawkins : msi: Forward MsiSourceListEnumSourcesA to a stub implementation of MsiSourceListEnumSourcesW .
by Detlef Riekenberg Feb. 20, 2008

Feb. 20, 2008

On Mi, 2008-02-20 at 06:46 -0600, > +/****************************************************************** > + * MsiSourceListEnumSourcesA (MSI.@) > + */ > +UINT WINAPI MsiSourceListEnumSourcesW( Greetings from Copy & Paste :-) BTW: Congratulations James for you new Address -- By by ... Detlef

1 0

bugzilla on the fritz again
by Dan Kegel Feb. 20, 2008

Feb. 20, 2008

Just started getting this: Software error: Can't connect to the database. Error: Too many connections Is your database installed and up and running? Do you have the correct username and password selected in localconfig?

2 1

Adding devices to registry with the help of hal
by Christian Gmeiner Feb. 20, 2008

Feb. 20, 2008

Hi all, I want you to present my current proof-of-conecpt. It shows how we can use hal.c of explorer to create registry keys for devices. Keep in mind that it only creates one registry key for each usb device at the moment. Before I investigate more time in this, I want to get some feedback about my method. If you are happy with it, I will finish this suftt :) Greets, Christian

2 1

Re: user32dll: cursoricon.c. Fix 16b BMP handling with BT_BITFIELD.
by Dmitry Timoshkov Feb. 20, 2008

Feb. 20, 2008

"Alexander Demakin" <avd(a)etersoft.ru> wrote: > This patch fixes image header handling with BT_BITFIELD flag. 12 bytes of mask > were included into image bits, it caused some color troubles and image > horizontal shift. Size of bitmap info structure includes now this bytes. You are mixing tabs and spaces again, and please use 4 spaces for indentation. > static int bitmap_info_size( const BITMAPINFO * info, WORD coloruse ) > { > int colors; > - > + int result; > if (info->bmiHeader.biSize == sizeof(BITMAPCOREHEADER)) Any reason you have removed a space after a variable declaration? > Changelog: > user32.dll Fix 16b BMP handling with BT_BITFIELD. Please have a look how others name the patches. A usual convenience is to write dll name without extension, ': ' and short description. -- Dmitry.

1 0

Re: gdi32dll: bitblt.c. Fix copying from uninitialized memory
by Dmitry Timoshkov Feb. 20, 2008

Feb. 20, 2008

"Alexander Demakin" <avd(a)etersoft.ru> wrote: > This patch adds check of return value of GetDIBits in BitBlt.c. If a error > occurs, GetDIBits returns 0 and bits variable points to uninitialized data. > It always occurs when calling BitBlt for printer context due to > implementation of PSDRV_SelectBitmap(). > Changelog: > gdi32.dll Fix copying from uninitialized memory. You are mixing tabs and spaces in the patch, otherwise tha patch looks good to me. -- Dmitry.

1 0

Re: dlls/msi/streams.c type fixes
by James Hawkins Feb. 20, 2008

Feb. 20, 2008

On Feb 17, 2008 6:23 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > This patch contains one or two items from my November patch the core > of which was independently recreated by Marcus and accepted and one > or two additional changes. It addresses the following warnings: > > streams.c: In function 'streams_set_table_size': > streams.c:59: warning: comparison between signed and unsigned > streams.c: In function 'STREAMS_delete': > streams.c:379: warning: comparison between signed and unsigned > streams.c: In function 'STREAMS_find_matching_rows': > streams.c:404: warning: comparison between signed and unsigned > > Gerald > > ChangeLog: > Adjust the signedness of three variables and add a comment for > add_streams_to_table(). > > Index: streams.c > =================================================================== > RCS file: /home/wine/wine/dlls/msi/streams.c,v > retrieving revision 1.11 > diff -u -3 -p -r1.11 streams.c > --- streams.c 16 Feb 2008 15:59:26 -0000 1.11 > +++ streams.c 17 Feb 2008 12:17:50 -0000 > @@ -39,7 +39,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(msidb); > > typedef struct tabSTREAM > { > - int str_index; > + UINT str_index; > LPWSTR name; > IStream *stream; > } STREAM; > @@ -54,7 +54,7 @@ typedef struct tagMSISTREAMSVIEW > UINT row_size; > } MSISTREAMSVIEW; > > -static BOOL streams_set_table_size(MSISTREAMSVIEW *sv, int size) > +static BOOL streams_set_table_size(MSISTREAMSVIEW *sv, UINT size) > { > if (size >= sv->max_streams) > { > @@ -372,7 +372,7 @@ static UINT STREAMS_modify(struct tagMSI > static UINT STREAMS_delete(struct tagMSIVIEW *view) > { > MSISTREAMSVIEW *sv = (MSISTREAMSVIEW *)view; > - int i; > + UINT i; > > TRACE("(%p)\n", view); > > @@ -440,6 +440,7 @@ static const MSIVIEWOPS streams_ops = > }; > > static INT add_streams_to_table(MSISTREAMSVIEW *sv) > + /* Return -1 in case of error. */ > { > IEnumSTATSTG *stgenum = NULL; > STATSTG stat; > Don't add random comments like this. -- James Hawkins

2 1

Re: shell32: Support getting the shell folder path for users other than the current user and the default user (take 2)
by Alexandre Julliard Feb. 20, 2008

Feb. 20, 2008

"Ge van Geldorp" <ge(a)thinstall.com> writes: > else > { > + LPWSTR sidStr = NULL; > LPCWSTR userPrefix = NULL; > HKEY hRootKey; This is not used anywhere. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [advapi32] QueryServiceConfig2 (3rd try) [resend]
by Alexandre Julliard Feb. 20, 2008

Feb. 20, 2008

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > + switch(dwLevel) { > + case SERVICE_CONFIG_DESCRIPTION: { > + static const WCHAR szDescription[] = {'D','e','s','c','r','i','p','t','i','o','n',0}; > + LPSERVICE_DESCRIPTIONW config = (LPSERVICE_DESCRIPTIONW) buffer; > + *needed = sizeof (SERVICE_DESCRIPTIONW); > + sz = size - *needed; > + r = RegQueryValueExW( hKey, szDescription, 0, &type, (LPBYTE) (config ? config + 1: NULL), &sz ); > + if((r == ERROR_SUCCESS) && ( type != REG_SZ)) { > + FIXME("SERVICE_CONFIG_DESCRIPTION: don't know how to handle type %d\n", type); > + return FALSE; > + } > + *needed += sz; > + if(config) { > + if(r == ERROR_SUCCESS) > + config->lpDescription = (LPWSTR) (config + 1); > + else > + config->lpDescription = NULL; You are still not handling overflows correctly. What happens if size is less than sizeof(SERVICE_DESCRIPTIONW)? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] user32:scroll: Added some tests for scrollbar [try2]
by Alexandre Julliard Feb. 20, 2008

Feb. 20, 2008

Anatoly Lyutin <vostok(a)etersoft.ru> writes: > Changelog: > Added some tests for scrollbar The tests fail: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so scroll.c && touch scroll.ok scroll.c:56: Test failed: The scrollbar window should be disabled. scroll.c:122: Test failed: The ShowScrollBar() should failed. make: *** [scroll.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Adding devices to registry with the help of hal
by Christian Gmeiner Feb. 20, 2008

Feb. 20, 2008

Hi all, I want you to present my current proof-of-conecpt. It shows how we can use hal.c of explorer to create registry keys for devices. Keep in mind that it only creates one registry key for each usb device at the moment. Before I investigate more time in this, I want to get some feedback about my method. If you are happy with it, I will finish this suftt :) Greets, Christian

1 0

re: Do we need a forum?
by Dan Kegel Feb. 19, 2008

Feb. 19, 2008

Steven Edwards wrote: > My thoughts, as well as > Tom's was that by creating a "blessed" location, all third parties as > well as vendors that develop Wine related products could say "if you > want to discuss using a vendor provided Wine product in a > non-supported manner all are advised to go here and share information" Yes, of course, it would be nice if there were One True Place to go, but the closest we're ever going to get is essentially the status quo, where the wine-users mailing list is the place of record for user support, the appdb is the place of record for looking for tips for a particular app, and all the other areas are secondary. We can improve slightly on this by linking to other popular wine forums as they pop up, emphasizing all the while that they are secondary. - Dan

5 8

Fwd: Adding devices in setupapi
by Maarten Lankhorst Feb. 19, 2008

Feb. 19, 2008

Hi Juan, 2008/2/19, Juan Lang <juan.lang(a)gmail.com>: > > I stubbed CM_get_parent by returning itself, however that makes it go > > in an infinite loop. > > Hm. > > > My guess is that I need to have some hub and usb ehci device as well. > > I don't know why it would want to call CreateFile on the device though > > but my expertise on that part is very limited, perhaps it allows > > communication to the ipod by accessing the device in a raw way? > > Perhaps, or perhaps it's just making sure you don't have a fake device :-/ > --Juan The only way to be sure would be to create my own test program that would do the same, and see what happens. How hard is it to create a stub forwarder dll for setupapi and cfgmgr32? Cheers, Maarten.

1 0

Saulius sent you a friend request on Yaari...
by Saulius Feb. 19, 2008

Feb. 19, 2008

1 0

Adding devices in setupapi
by Maarten Lankhorst Feb. 19, 2008

Feb. 19, 2008

Hi all, I'm trying to add the ipod detection from crossover wine to winehq. However it seems to be not compatibel due to changes to setupapi in the last 3 years. Basically what I want to do is add an usb mass storage device with the correct device path and register it with setupapi. Composing the string is easy but I'm not 100% sure what the locations are. The code seems a bit vague in that aspect. The snippet iTunes uses for detection is shown below: SetupDiGetClassDevsExW {53f56307-b6bf-11d0-94f2-00a0c91efb8b} (null) (nil) 0x00000012 (nil) (null) (nil) SetupDiEnumDeviceInterfaces 0x136638, (nil), {53f56307-b6bf-11d0-94f2-00a0c91efb8b}, 0, 0x7aa2140c How do I get my device listed in SetupDiEnumDeviceInterfaces there so iTunes can pick it up? Cheers, Maarten.

3 2

Making use of setupapi
by Maarten Lankhorst Feb. 19, 2008

Feb. 19, 2008

Hi folks, Any one around who understands setupapi? For iTunes I would need to add appropriate registry keys so that my usb device is detected. My idea is to use libusb to find the things like guid, revision etc and then adding the keys. However I am not 100% what the layout of the keys is. Cheers, Maarten.

3 3

Re: ddraw: Assign to structs instead of using memcpy
by Stefan Dösinger Feb. 19, 2008

Feb. 19, 2008

Am Samstag, 16. Februar 2008 23:33:37 schrieb Andrew Talbot: > Here, I am assuming that the "dwSize" elements in all these cases should be > set to the size of the struct each is in, respectively. Please advise if > this assumption is wrong. It's not necessarily true. Sometimes there are multiple versions of the same structure. You can check ddraw.h and d3dtypes.h. If there is only one version your assumption should be true. If there isn't, then your assumption may still be true. In that case there are some tests how the Setter methods deal with newer or older structures(in some cases we may need more tests) > Thanks, > > -- Andy. > --- > Changelog: > ddraw: Assign to structs instead of using memcpy. > > diff --git a/dlls/ddraw/device.c b/dlls/ddraw/device.c > index b60b6f3..03ccea8 100644 > --- a/dlls/ddraw/device.c > +++ b/dlls/ddraw/device.c > @@ -704,7 +704,7 @@ > IDirect3DDeviceImpl_1_CreateExecuteBuffer(IDirect3DDevice *iface, > object->d3ddev = This; > > /* Initializes memory */ > - memcpy(&object->desc, Desc, Desc->dwSize); > + object->desc = *Desc; > > /* No buffer given */ > if ((object->desc.dwFlags & D3DDEB_LPDATA) == 0) > diff --git a/dlls/ddraw/material.c b/dlls/ddraw/material.c > index d6b9a7c..8e17174 100644 > --- a/dlls/ddraw/material.c > +++ b/dlls/ddraw/material.c > @@ -250,7 +250,7 @@ IDirect3DMaterialImpl_SetMaterial(IDirect3DMaterial3 > *iface, /* Stores the material */ > EnterCriticalSection(&ddraw_cs); > memset(&This->mat, 0, sizeof(This->mat)); > - memcpy(&This->mat, lpMat, lpMat->dwSize); > + This->mat = *lpMat; > LeaveCriticalSection(&ddraw_cs); > > return DD_OK; > @@ -285,7 +285,7 @@ IDirect3DMaterialImpl_GetMaterial(IDirect3DMaterial3 > *iface, EnterCriticalSection(&ddraw_cs); > dwSize = lpMat->dwSize; > memset(lpMat, 0, dwSize); > - memcpy(lpMat, &This->mat, dwSize); > + *lpMat = This->mat; > LeaveCriticalSection(&ddraw_cs); > > return DD_OK; > diff --git a/dlls/ddraw/viewport.c b/dlls/ddraw/viewport.c > index deb4146..8dfc015 100644 > --- a/dlls/ddraw/viewport.c > +++ b/dlls/ddraw/viewport.c > @@ -261,7 +261,7 @@ IDirect3DViewportImpl_GetViewport(IDirect3DViewport3 > *iface, } > dwSize = lpData->dwSize; > memset(lpData, 0, dwSize); > - memcpy(lpData, &(This->viewports.vp1), dwSize); > + *lpData = This->viewports.vp1; > > if (TRACE_ON(d3d7)) { > TRACE(" returning D3DVIEWPORT :\n"); > @@ -301,7 +301,7 @@ IDirect3DViewportImpl_SetViewport(IDirect3DViewport3 > *iface, EnterCriticalSection(&ddraw_cs); > This->use_vp2 = 0; > memset(&(This->viewports.vp1), 0, sizeof(This->viewports.vp1)); > - memcpy(&(This->viewports.vp1), lpData, lpData->dwSize); > + This->viewports.vp1 = *lpData; > > /* Tests on two games show that these values are never used properly > so override them with proper ones :-) > @@ -856,7 +856,7 @@ IDirect3DViewportImpl_GetViewport2(IDirect3DViewport3 > *iface, } > dwSize = lpData->dwSize; > memset(lpData, 0, dwSize); > - memcpy(lpData, &(This->viewports.vp2), dwSize); > + *lpData = This->viewports.vp2; > > if (TRACE_ON(d3d7)) { > TRACE(" returning D3DVIEWPORT2 :\n"); > @@ -895,7 +895,7 @@ IDirect3DViewportImpl_SetViewport2(IDirect3DViewport3 > *iface, EnterCriticalSection(&ddraw_cs); > This->use_vp2 = 1; > memset(&(This->viewports.vp2), 0, sizeof(This->viewports.vp2)); > - memcpy(&(This->viewports.vp2), lpData, lpData->dwSize); > + This->viewports.vp2 = *lpData; > > if (This->active_device) { > > IDirect3DDevice3_GetCurrentViewport(ICOM_INTERFACE(This->active_device, > IDirect3DDevice3), &current_viewport);

2 3

Re: WineD3D: let flush_to_framebuffer_drawpixels use a valid rect
by Stefan Dösinger Feb. 19, 2008

Feb. 19, 2008

Am Dienstag, 19. Februar 2008 21:26:24 schrieben Sie: > Hi, > > Originally flush_to_framebuffer_drawpixels was called from UnlockRect, so > in that case LockedRect was always set. These days it can also be called > (through LoadLocation) from other places. This patch makes it use the > LockedRect when the surface is locked else the whole surface is uploaded. > This fixes rendering issues in Red Alert and other apps. Wouldn't it be better to make sure that the caller passes the correct rectangle to flush_to_framebuffer_* ? > - if(dxVersion >= 8) { > + if(0 && dxVersion >= 8) { Is this intentional?

1 0

Re: slc: Initial stub DLL (try 2)
by Robert Shearman Feb. 19, 2008

Feb. 19, 2008

Alistair Leslie-Hughes wrote: > slc: Initial stub dll I'm not sure we want to go down the path of implementing the functions in this DLL. Furthermore, this file isn't present on an XP SP2 installation. Can you give some information as to why this is needed and how the application depends on this DLL? -- Rob Shearman

3 3

Re: Make.rules.in: Pass the --nounistd flag to flex since unistd.h is a header that might not be present on all systems.
by Alexandre Julliard Feb. 19, 2008

Feb. 19, 2008

Robert Shearman <rob(a)codeweavers.com> writes: > If we do need it, we can include it in the .l file after config.h and > with an appropriate include guard. You should instead put a %option in the files that need it. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: Pass parms through to PdhLookupPerfIndexByNameW for checking
by Dmitry Timoshkov Feb. 19, 2008

Feb. 19, 2008

"Jeff Latimer" <lats(a)yless4u.com.au> wrote: > + if (machine && !(machineW = pdh_strdup_aw( machine ))) return PDH_MEMORY_ALLOCATION_FAILURE; > > - if (machine) > - { > - FIXME("remote machine not supported\n"); > - return PDH_CSTATUS_NO_MACHINE; > - } > if (!(nameW = pdh_strdup_aw( name ))) > return PDH_MEMORY_ALLOCATION_FAILURE; > > ret = PdhLookupPerfIndexByNameW( NULL, nameW, index ); You forgot to actually pass machineW to PdhLookupPerfIndexByNameW. -- Dmitry.

1 0

re: Do we need a forum?
by Dan Kegel Feb. 19, 2008

Feb. 19, 2008

Anybody who thinks we need another forum needs his head examined. There is no shortage of Wine forums. We just need to use the ones that already exist. Adding a new one will just fragment the community further. In particular, there are two forums right now that people already use to discuss wine problems: a generic one at http://www.linuxforums.org/forum/wine/ and an Ubuntu-specific one at http://ubuntuforums.org/forumdisplay.php?f=313 Let's just link to them. I'll submit a patch to do that in a minute. And I like Griswold's idea (on IRC) of improving the current appdb in small ways, e.g. changing the reply behavior to not open up a new page. For goodness' sake, don't create yet another new forum! - Dan

3 2

Re: slc: Add Initial DLL
by John Klehm Feb. 19, 2008

Feb. 19, 2008

On Feb 18, 2008 10:48 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > Changelog: > slc: Added Initial DLL > > Best Regards > Alistair Leslie-Hughes > > > > No Patch?

1 0

Re: iTunes
by Maarten Lankhorst Feb. 18, 2008

Feb. 18, 2008

Hi Christopher, Christopher Harvey wrote: > What needs to get done for iTunes to work? v7.6 basically works if you set windows version to windows vista, and find out why the installer fails to create the 'Bonjour service' registry stuff properly. I submitted 8 or so stub dll's to wine-patches that make iTunes v7.6 actually start after installation. It checks for the dll's and silently fails if they don't exist. I haven't done any further testing yet though, but it looks like it is probably a small installer bug that prevents itunes v7.6 from installing without first manually creating those registry keys. Cheers, Maarten.

6 17

Re: Usable Wine interface
by Remco Feb. 18, 2008

Feb. 18, 2008

----- Original Message ---- > From: Vitaliy Margolen <wine-devel(a)kievinfo.com> > To: wine-devel(a)winehq.org > Sent: Monday, February 18, 2008 4:16:17 AM > Subject: Re: Usable Wine interface > > Remco wrote: > > I'd like to add a feature-request (should this go somewhereelse?) > Yes, bugzilla -> enhancement. > > Vitaliy. Ok, thanks for the info. I added an entry: http://bugs.winehq.org/show_bug.cgi?id=11629 Remco ____________________________________________________________________________________ Looking for last minute shopping deals? Find them fast with Yahoo! Search. http://tools.search.yahoo.com/newsearch/category.php?category=shopping

5 5

Re: dlls/user32/edit.c -- remove superflous check (RESEND)
by Alexandre Julliard Feb. 18, 2008

Feb. 18, 2008

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > dwBufLen already indictes that this variable is of type DWORD and > thus always positive. I also looked at the implementation of > ImmGetCompositionStringW() and we do not seem to return a negative > value (such as -1). Maybe the implementation doesn't, but the function returns a LONG, and can (and probably should) return negative values on error. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] Environment variable to specify X11 window for desktop
by Robert Shearman Feb. 18, 2008

Feb. 18, 2008

Timothy Lee wrote: > The attached patch allows the WINE desktop to be embedded within an > existing X11 window, and is similar to the windowed mode in WINE. > > I've tested this feature using MS PowerPoint Viewer 2007, so that a > fullscreen slideshow can be fitted inside any X11 window. I'm struggling to imagine a case where the behaviour you've implemented is useful. -- Rob Shearman

6 13

Re: [PATCH 2/3] gdi32: Move EnumFontFamiliesEx16() and helper functions to gdi16.c.
by Michael Stefaniuc Feb. 18, 2008

Feb. 18, 2008

Michael Stefaniuc wrote: > --- > This duplicates for now the FONT_LogFont16ToW() function but Alexandre It duplicates FONT_LogFontWTo16() and not FONT_LogFont16ToW() (that one was already duplicated). > told me on irc that he removed the other user of it in an yet unpublished > patch. Thus FONT_LogFont16ToW() can be removed from font.c in a later FONT_LogFontWTo16() can be removed later on. > patch. > bye michael

1 0

Re: [1/16] msxml3: Support functions for typelib
by Alexandre Julliard Feb. 18, 2008

Feb. 18, 2008

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > +HRESULT get_typeinfo(enum tid_t tid, ITypeInfo **typeinfo) > +{ > + HRESULT hres; > + > + if(!typelib) { > + ITypeLib *tl; > + > + hres = LoadRegTypeLib(&LIBID_MSXML2, 3, 0, LOCALE_SYSTEM_DEFAULT, &tl); > + if(FAILED(hres)) { > + ERR("LoadRegTypeLib failed: %08x\n", hres); > + return hres; > + } > + > + if(InterlockedCompareExchangePointer((void**)&typelib, tl, NULL)) > + ITypeLib_Release(tl); > + } > + > + if(!typeinfos[tid]) { > + ITypeInfo *typeinfo; > + > + hres = ITypeLib_GetTypeInfoOfGuid(typelib, tid_ids[tid], &typeinfo); > + if(FAILED(hres)) { > + ERR("GetTypeInfoOfGuid failed: %08x\n", hres); > + return hres; > + } > + > + if(InterlockedCompareExchangePointer((void**)(typeinfos+tid), typeinfo, NULL)) > + ITypeInfo_Release(typeinfo); > + } > + > + *typeinfo = typeinfos[tid]; > + return S_OK; You should increment the ref count when you are returning a pointer, even if it's also stored in a global variable. -- Alexandre Julliard julliard(a)winehq.org

2 3

Autoplay considered harmful
by Dan Kegel Feb. 18, 2008

Feb. 18, 2008

http://www.sfgate.com/cgi-bin/article.cgi?f=/c/a/2008/02/15/BU47V0VOH.DTL&t… says that USB devices are being sold with infected autorun apps. "If you plug in, you're already infected," I'd say that's a pretty good argument for not supporting autoplay...

7 7

Re: [advapi32/tests #2] Don't set last error to 0 so we can check if it has changed
by Alexandre Julliard Feb. 18, 2008

Feb. 18, 2008

Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > We test for a last error of 0, so we shouldn't set it to 0 before the > function is called. This however introduces a todo_wine. Is there any reason to believe that last error should be 0 on success? This looks more like a broken test to me. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: include: Add support for executing finally code for exceptions without using a separate function.
by Alexandre Julliard Feb. 18, 2008

Feb. 18, 2008

Robert Shearman <rob(a)codeweavers.com> writes: > The first goal is accomplished by changing the previous two-state > variable of __first into a three-state variable where the third state > is the state in which the finally code is executed in the normal > case. The second goal is accomplished by calling sigsetjmp in > __wine_finally_handler to give the finally code a place to jump back > to after it has finished executing. That can't work, once you longjmp into the finally block you can't longjmp back, since you are no longer inside the function that did the setjmp. -- Alexandre Julliard julliard(a)winehq.org

2 1

iTunes
by Christopher Harvey Feb. 18, 2008

Feb. 18, 2008

What needs to get done for iTunes to work?

3 3

[PATCH] msvcrt/tests: Add more scanf floating-point tests.
by Jānis Rūcis Feb. 18, 2008

Feb. 18, 2008

The included patch adds a couple of scanf floating-point tests to expose a problem with the algorithm. It seems that it doesn't handle negative exponents very well, resulting in single-precision values being off-by-one in the last bit of significant compared to those obtained with the GNU C library or natively on Windows XP. All five tests pass on my Windows XP SP2 system (using a self-compiled msvcrt_crosstest.exe tool). Test 3 and 4 fail with the current source in Git. I will send another patch to this list with a potential fix. (I am not sending these to wine-patches because I'm not sure I should. "wine-devel" sounds about right.) --- dlls/msvcrt/tests/scanf.c | 40 ++++++++++++++++++++++++++++++++++++---- 1 files changed, 36 insertions(+), 4 deletions(-) diff --git a/dlls/msvcrt/tests/scanf.c b/dlls/msvcrt/tests/scanf.c index 65bea46..d5da3f6 100644 --- a/dlls/msvcrt/tests/scanf.c +++ b/dlls/msvcrt/tests/scanf.c @@ -28,7 +28,7 @@ static void test_sscanf( void ) char format[20]; int result, ret; char c; - float res1= -82.6267f, res2= 27.76f, res11, res12; + float orig, res; static const char pname[]=" St. Petersburg, Florida\n"; int hour=21,min=59,sec=20; int number,number_so_far; @@ -64,9 +64,41 @@ static void test_sscanf( void ) ok( result == 12, "sscanf reads %x instead of %x\n", result, 12 ); /* Check float */ - ret = sprintf(buffer,"%f %f",res1, res2); - ret = sscanf(buffer,"%f%f",&res11, &res12); - ok( (res11 == res1) && (res12 == res2), "Error reading floats\n"); + + orig = -82.6267f; + ret = sprintf(buffer, "%f", orig); + ret = sscanf(buffer, "%f", &res); + ok(ret == 1, "Expected 1 float, got %d\n", ret); + ok(res == orig, "Wrote %e (0x%x), but read %e (0x%x)\n", + orig, *(unsigned int *) &orig, res, *(unsigned int *) &res); + + orig = 27.76f; + ret = sprintf(buffer, "%f", orig); + ret = sscanf(buffer, "%f", &res); + ok(ret == 1, "Expected 1 float, got %d\n", ret); + ok(res == orig, "Wrote %e (0x%x), but read %e (0x%x)\n", + orig, *(unsigned int *) &orig, res, *(unsigned int *) &res); + + orig = -6.61589e-2f; + ret = sprintf(buffer, "%e", orig); + ret = sscanf(buffer, "%e", &res); + ok(ret == 1, "Expected 1 float, got %d\n", ret); + ok(res == orig, "Wrote %e (0x%x), but read %e (0x%x)\n", + orig, *(unsigned int *) &orig, res, *(unsigned int *) &res); + + orig = 1.72567e-7f; + ret = sprintf(buffer, "%e", orig); + ret = sscanf(buffer, "%e", &res); + ok(ret == 1, "Expected 1 float, got %d\n", ret); + ok(res == orig, "Wrote %e (0x%x), but read %e (0x%x)\n", + orig, *(unsigned int *) &orig, res, *(unsigned int *) &res); + + orig = 15.483e+3f; + ret = sprintf(buffer, "%e", orig); + ret = sscanf(buffer, "%e", &res); + ok(ret == 1, "Expected 1 float, got %d\n", ret); + ok(res == orig, "Wrote %e (0x%x), but read %e (0x%x)\n", + orig, *(unsigned int *) &orig, res, *(unsigned int *) &res); /* check strings */ ret = sprintf(buffer," %s", pname); -- 1.5.3.8

2 1

programs: add winestartfile for starting files from the unix path (for file managers)
by Vincent Povirk Feb. 18, 2008

Feb. 18, 2008

This is now attempt 4, not that anyone's counting. Adding winelib programs is a bit involved, and I imagine I've screwed something up along the way. If you know how to add them properly, please say something, even if it's to tell me I did it right. This patch adds a winelib program called winestartfile for starting files given the unix path. It attempts to mimic what windows explorer does to start files and provide some visible (gui) feedback when it doesn't work. The idea is that wine.desktop can then be modified to use winestartfile instead of wine, solving the following problems when starting exe files from file managers: * File managers typically do not set the working directory to the directory that contains an exe when they start it. Setting the working directory is the default behavior for windows explorer, and many windows programs rely on it. * File managers naturally use the unix path to start files, and the wine binary passes the unix path along to the exe it starts, rather than translating it to a windows path (this can and probably should also be fixed somewhere else). * Windows explorer always starts exe files with quotes around the path in the command-line, even if the path does not contain spaces. The wine binary does not (and probably should not) add quotes in this situation. A few apps rely on the quotes. See http://bugs.winehq.org/show_bug.cgi?id=5224#c14 -- Vincent Povirk

2 3

Re: inetcomm: Fix compilation on systems that don't support nameless unions.
by Marcus Meissner Feb. 18, 2008

Feb. 18, 2008

On Mon, Feb 18, 2008 at 11:54:22AM +0100, Francois Gouget wrote: > --- > dlls/inetcomm/mimeole.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > diff --git a/dlls/inetcomm/mimeole.c b/dlls/inetcomm/mimeole.c > index a0da6b9..e986e7f 100644 > --- a/dlls/inetcomm/mimeole.c > +++ b/dlls/inetcomm/mimeole.c > @@ -1257,7 +1257,7 @@ static HRESULT WINAPI sub_stream_CopyTo( > ULARGE_INTEGER totalBytesRead; > ULARGE_INTEGER totalBytesWritten; > > - TRACE("(%p)->(%p, %d, %p, %p)\n", iface, pstm, cb.LowPart, pcbRead, pcbWritten); > + TRACE("(%p)->(%p, %d, %p, %p)\n", iface, pstm, cb.u.LowPart, pcbRead, pcbWritten); > > totalBytesRead.QuadPart = 0; > totalBytesWritten.QuadPart = 0; > @@ -1525,7 +1525,7 @@ static HRESULT create_body_offset_list(IStream *stm, const char *boundary, struc > > zero.QuadPart = 0; > hr = IStream_Seek(stm, zero, STREAM_SEEK_CUR, &cur); > - start = cur.LowPart; > + start = cur.u.LowPart; > > do { > hr = IStream_Read(stm, overlap, PARSER_BUF_SIZE, &read); > @@ -1599,7 +1599,7 @@ static body_t *create_sub_body(MimeMessage *msg, IStream *pStm, BODYOFFSETS *off > IMimeBody_Load(mime_body, pStm); > zero.QuadPart = 0; > hr = IStream_Seek(pStm, zero, STREAM_SEEK_CUR, &cur); > - offset->cbBodyStart = cur.LowPart + offset->cbHeaderStart; > + offset->cbBodyStart = cur.u.LowPart + offset->cbHeaderStart; > if(parent) MimeBody_set_offsets(impl_from_IMimeBody(mime_body), offset); > IMimeBody_SetData(mime_body, IET_BINARY, NULL, NULL, &IID_IStream, pStm); > body = new_body_entry(mime_body, msg->next_hbody, parent); > @@ -1629,8 +1629,8 @@ static body_t *create_sub_body(MimeMessage *msg, IStream *pStm, BODYOFFSETS *off > IStream *sub_stream; > ULARGE_INTEGER start, length; > > - start.LowPart = cur->offsets.cbHeaderStart; > - length.LowPart = cur->offsets.cbBodyEnd - cur->offsets.cbHeaderStart; > + start.u.LowPart = cur->offsets.cbHeaderStart; > + length.u.LowPart = cur->offsets.cbBodyEnd - cur->offsets.cbHeaderStart; > create_sub_stream(pStm, start, length, &sub_stream); > sub_body = create_sub_body(msg, sub_stream, &cur->offsets, body); > IStream_Release(sub_stream); > @@ -1674,7 +1674,7 @@ static HRESULT WINAPI MimeMessage_Load( > > zero.QuadPart = 0; > IStream_Seek(pStm, zero, STREAM_SEEK_END, &cur); > - offsets.cbBodyEnd = cur.LowPart; > + offsets.cbBodyEnd = cur.u.LowPart; > MimeBody_set_offsets(impl_from_IMimeBody(root_body->mime_body), &offsets); > > list_add_head(&This->body_tree, &root_body->entry); > There seems to be damage in here, both ^M and lose 0s. Ciao, Marcus

1 0

Re: user32: Check for .ico and .cur magic.
by Dmitry Timoshkov Feb. 18, 2008

Feb. 18, 2008

"Andrew Riedi" <andrewriedi(a)gmail.com> wrote: > +#define ICON_DIB_SIZE 4264 It would be helpful to actually calculate the size instead of hardcoding the magic value. > + handle = LoadImageA(NULL, "icon.ico", IMAGE_CURSOR, 0, 0, LR_LOADFROMFILE); > + ok(handle != NULL, "LoadImage() failed.\n"); > + error = GetLastError(); > + ok(error == 0, "Last error: %u\n", error); > + > + /* Clean up. */ > + ret = DestroyIcon(handle); The fact that LoadImage has returned a not zero handle actually confirms nothing, you need to verify the contents of the loaded image with GetIconInfo. -- Dmitry.

1 0

re: iTunes
by Dan Kegel Feb. 18, 2008

Feb. 18, 2008

E. Savage wrote: > Maarten why not focus on supporting applications that > don't have viable open source solutions first? iTunes doesn't have any alternatives for these functions: - purchasing songs from iTunes Store - activating iPhone - new ipod/iPhone syncing Anybody who buys an iPhone and can't activate it on their Linux PC will blame Linux and think it's crap. Even developers like jwz, I bet; see http://jwz.livejournal.com/494040.html So yeah, iTunes is important. - Dan

2 1

Winnowing the 1.0 bug list
by Dan Kegel Feb. 17, 2008

Feb. 17, 2008

We now have about 100 bugs nominated for fixing in 1.0. Thanks to everybody who nominated bugs. Now it's time to winnow the list a bit. 1.0 bugs should be 'important' somehow, easy to reproduce, and have some chance of actually being fixed by, say, summer. The better understood a bug is, the more likely it is it can be fixed for 1.0, so even less important bugs can be 1.0 bugs if they're well enough understood and a patch is available. Here are a few bugs I'm thinking of deferring, and why: Not important enough http://bugs.winehq.org/show_bug.cgi?id=5807 Mercora IMRadio crashes http://bugs.winehq.org/show_bug.cgi?id=6048 Stokes crashes http://bugs.winehq.org/show_bug.cgi?id=8687 everestpoker and Programmer's Editor don't work http://bugs.winehq.org/show_bug.cgi?id=9288 Armed Assault doesn't load web page http://bugs.winehq.org/show_bug.cgi?id=9895 Alzip crashes Probably not doable by summer http://bugs.winehq.org/show_bug.cgi?id=609 Add BiDi support Not well enough understood: http://bugs.winehq.org/show_bug.cgi?id=6383 Dual-core not being correctly supported Do people agree with those assessments, and are there other bugs nominated for 1.0 that don't quite deserve it? - Dan

1 0

Re: [6/6] wined3d: take alpha from device palette entry for d3d 8 and later
by Stefan Dösinger Feb. 17, 2008

Feb. 17, 2008

Am Montag, 18. Februar 2008 02:37:00 schrieb Alexander Dorofeyev: >/*can ddraw and d3d < 8 surfaces use device's palette (d3d >= 8 feature)?*/ No, they can't, there is no API to access them

2 1

Re: appdb feature request: hide the ugly urls
by Remco Feb. 17, 2008

Feb. 17, 2008

> http://appdb.winehq.org/app/command-conquer-3-tiberium-wars/ > doesn't sound too bad, actually. And if somebody types in > an ambiguous URL, like > http://appdb.winehq.org/app/command-conquer > they should get a list of matching apps. So this is kind of > like a search function rather than a unique ID. > The difference being that apps would normally be > displayed at their shortest unique human-readable URL > rather than by ID #. > This may have an obscure but important benefit: I > read on the web somewhere that it boosts search engine rankings. > (Not that I'd know; I'm way away from that part of google.) > - Dan I'm pretty sure that's just because of the related words in the URL. An additional number doesn't hurt ranking. I know a lot of sites use an ID number and a title. The title makes it easy to see what the link points to. That's a usability benefit of itself. I don't think people should start using the URL bar as a search engine. The AppDB has a nice search engine already. And I think searching for literally all URLs is going to put a lot of strain on the server. Remco ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs

2 1

Usable Wine interface
by Remco Feb. 17, 2008

Feb. 17, 2008

I'd like to add a feature-request (should this go somewhereelse?). What about making a Wine GUI to behave more like emulators likeVirtualBox. It's extremely hard right now to get Wine in desktop mode.It would be nice if you could start Wine as an application, which opensup a window like this: http://xs224.xs.to/xs224/08081/mockup918.png (ignore the virtualbox-stuff) And if you start one of those prefixes, it by default opens a WineDesktop with a simple Taskbar & Start-menu. Somewhere in theStart-menu could be the option to switch to desktop integration mode.There could also be an option to run the Wine Desktop full-screen. Likethis: http://xs224.xs.to/xs224/08081/winedesktop771.png (forgive my GIMP skills) I believe this would be very good for usability. Desktop mode is morestable than seamless mode, yet it's hidden in winecfg. This kind of UIalso exposes the prefix-functionality in a transparent way. Wouldn'tthat be a nice 1.0 polishing idea? Remco ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs

3 2

Re: Next big app(s) to try?
by Remco Feb. 17, 2008

Feb. 17, 2008

I'd say, of the work-related apps, definitely MS Office 2007 (especially Outlook) and Internet Explorer 6 and 7. IE7 needs a lot of work still. IE6 doesn't break on any Wine bugs AFAIK, but needs a special environment to install correctly. A little Wine magic might help here. IE is one of the few native Windows parts that cannot reasonably be replaced. Web developers need to test their sites in the real thing. Of the fun-related apps, a few press-generating apps would be Crysis DX10-mode and iTunes (iPod sync). Remco ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs

2 1

Re: appdb feature request: hide the ugly urls
by Remco Feb. 17, 2008

Feb. 17, 2008

----- Original Message ---- > From: Dan Kegel <dank(a)kegel.com> > To: wine-devel <wine-devel(a)winehq.org> > Sent: Sunday, February 17, 2008 6:55:06 PM > Subject: appdb feature request: hide the ugly urls > > How hard would it be for the appdb to support > more readable URLs for vendors and applications? e.g. > Adobe Premiere is currently at > http://appdb.winehq.org/objectManager.php?sClass=application&iId=128 > but it'd be so slick to see instead > http://appdb.winehq.org/adobe/premiere > > Believe it or not, that little change would make the appdb > less scary for newcomers. > - Dan That's relatively easy to do with mod_rewrite. But it would have to be something like: http://appdb.winehq.org/app/128/adobe-premiere.html All the info is still in the URL (which mod_rewrite can extract), but it does look less scary. Remco ____________________________________________________________________________________ Be a better friend, newshound, and know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ

4 5

Re: dlls/shell32/pidl.c -- adjust to unsignedness of a type
by Alexandre Julliard Feb. 17, 2008

Feb. 17, 2008

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > @@ -109,7 +109,7 @@ BOOL WINAPI ILGetDisplayNameExW(LPSHELLF > return FALSE; > } > > - if (type >= 0 && type <= 2) > + if (type <= 2) > { > switch (type) > { The test should probably be removed completely since there's already a default for it in the switch() that follows. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/6] ddraw: fix executebuffer branching with non-zero offset
by Stefan Dösinger Feb. 17, 2008

Feb. 17, 2008

Am Montag, 18. Februar 2008 02:36:35 schrieb Alexander Dorofeyev: > Fixes a crash in Moto Racer 2. > --- > dlls/ddraw/executebuffer.c | 10 ++++++++-- > 1 files changed, 8 insertions(+), 2 deletions(-) The patches look good to me

1 0

appdb feature request: hide the ugly urls
by Dan Kegel Feb. 17, 2008

Feb. 17, 2008

How hard would it be for the appdb to support more readable URLs for vendors and applications? e.g. Adobe Premiere is currently at http://appdb.winehq.org/objectManager.php?sClass=application&iId=128 but it'd be so slick to see instead http://appdb.winehq.org/adobe/premiere Believe it or not, that little change would make the appdb less scary for newcomers. - Dan

1 0

Re: dlls/msi/streams.c -- simplify and constify
by James Hawkins Feb. 17, 2008

Feb. 17, 2008

On Nov 3, 2007 1:10 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > While removing the dead code I noticed that we can actually also > strengthen the const-ness of this function. > > Gerald > > ChangeLog: > Remove a check which never could trigger (due to the domain of the > variable in question) and increase const-ness of STREAMS_CreateView(). > > Index: dlls/msi/streams.c > =================================================================== > RCS file: /home/wine/wine/dlls/msi/streams.c,v > retrieving revision 1.7 > diff -u -3 -p -r1.7 streams.c > --- dlls/msi/streams.c 18 Oct 2007 13:00:57 -0000 1.7 > +++ dlls/msi/streams.c 3 Nov 2007 18:06:27 -0000 > @@ -430,7 +430,7 @@ static UINT add_streams_to_table(MSISTRE > return count; > } > > -UINT STREAMS_CreateView(MSIDATABASE *db, MSIVIEW **view) > +UINT STREAMS_CreateView(const MSIDATABASE *db, MSIVIEW **view) > { > MSISTREAMSVIEW *sv; > > @@ -444,9 +444,6 @@ UINT STREAMS_CreateView(MSIDATABASE *db, > sv->db = db; > sv->num_rows = add_streams_to_table(sv); > > - if (sv->num_rows < 0) > - return ERROR_FUNCTION_FAILED; > - > *view = (MSIVIEW *)sv; > > return ERROR_SUCCESS; > This change is wrong. If you'd actually read what the code intended to do instead of just fixing warnings, you'd see that add_streams_to_table returns -1 on error. While the check for < 0 is not correct, removing the check entirely is wrong. The check should be if (sv->num_rows == -1) return ERROR_FUNCTION_FAILED. -- James Hawkins

2 2

Re: Autoplay considered harmful
by Remco Feb. 17, 2008

Feb. 17, 2008

Vista (and I think XP too) ask whether you want to start the Autorun program, or do a few other actions (open explorer, copy disk, etc). Remco ----- Original Message ---- > From: Evil Jay <wine(a)eternaldusk.com> > To: Steven Edwards <winehacker(a)gmail.com> > Cc: wine-devel <wine-devel(a)winehq.org>; Dan Kegel <dank(a)kegel.com> > Sent: Saturday, February 16, 2008 5:44:15 PM > Subject: Re: Autoplay considered harmful > > The purist in me says that WINE should not improve on Windows - it > should behave the same way, warts and all. If I had a vote, I'd vote to > enable it by default, but give the user an easy way to disable it in > winecfg. (And I'd immediately disable it the first time I ran Winecfg!) > > But, whatever you guys decide to do is cool - as long as you keep > cranking out this great package! :) > > -Jesse > > > > Steven Edwards wrote: > > On Feb 16, 2008 8:58 AM, Dan Kegel wrote: > > > >> > http://www.sfgate.com/cgi-bin/article.cgi?f=/c/a/2008/02/15/BU47V0VOH.DTL&t… > >> says that USB devices are being sold with infected > >> autorun apps. "If you plug in, you're already infected," > >> > >> I'd say that's a pretty good argument for not supporting autoplay... > >> > > > > I was actually thinking about this today. The right method would be to > > use HAL notification events to prompt the user if they want to autorun > > when sticking a new cdrom in. There could even be warning text in the > > dialog so that if it pops up with other device insertion, the user > > would know that it could be a virus. > > > > > > > > ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs

5 4

Re: tools: add a wrapper script for starting files from file managers and make wine.desktop use it
by Vincent Povirk Feb. 16, 2008

Feb. 16, 2008

Please do not commit this patch as explained in comment 18 of bug 5224: http://bugs.winehq.org/show_bug.cgi?id=5224#c18 Windows explorer's default behavior is to always start programs with double quotes around their filenames, even if the filename does not contain a space. Apparently, this is impossible (or more difficult than it's worth) to do in a shell script so I will need to rewrite this as a winelib program. On Feb 13, 2008 7:44 PM, Vincent Povirk <madewokherd+d41d(a)gmail.com> wrote: > This is an attempt to solve the problems with double-clicking .exe > files from file managers. > > The patch adds a script named winestartfile that mimics what happens > on windows when a file is double-clicked in explorer. It starts the > file using start.exe with the full path to the file and in the > directory that contains it. > > It also modifies the wine.desktop shortcut to use that script when > opening .exe files. > > My previous attempt at this incorrectly ran start without giving a > full path (so that if a file named start.exe exists in the current > path, it will take precedence) and probably tried to change too many > things at once. > > -- > Vincent Povirk > -- Vincent Povirk

1 0

New winetricks 20080216: fixed comctl32 override, hide winetrickscache, add --version option
by Dan Kegel Feb. 16, 2008

Feb. 16, 2008

Austin nudged me into fixing comctl32 override, which has been broken since wine added support for sxs assemblies. He also was the third person to suggest hiding winetrickscache, so I guess it's what people want. And I added a --version option for a guy who said it would make packaging easier. As always, it's available at http://kegel.com/wine/winetricks and the svn repository is http://code.google.com/p/winezeug/ -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: WineD3D: add separate alpha blend support 3/3
by Stefan Dösinger Feb. 16, 2008

Feb. 16, 2008

Am Samstag, 16. Februar 2008 17:29:31 schrieb Roderick Colenbrander: > Hi, > > This patch adds support for separate alpha blend one of the last > unimplemented D3D9 features. Here are a few suggestions: *) Setting WINED3DPMISCCAPS_SEPARATEALPHABLEND in directx.c should only be done if the extension is supported *) after the "GL_LINE_SMOOTH needs GL_BLEND to work, according to the", WINED3DRS_SEPARATEALPHABLENDENABLE should probably be removed from the if block. I don't think that blending should be enabled if the WINED3DRS_ALPHABLENDENABLE is off. A test would be helpful for certainty. *) The code translating the separate blending settings could be moved into the if(stateblock->renderState[WINED3DRS_SEPARATEALPHABLENDENABLE]) block. That way they are only executed if they're needed(The compiler may take care of that though) *) The separate blend states should be grouped with the alpha states, ie, set the representative to STATE_RENDER(WINED3DRS_ALPHABLENDENABLE) instead of STATE_RENDER(WINED3DRS_SEPARATEALPHABLENDENABLE). Not doing that should not cause any rendering problems because the whole alpha blend states are set every time, but grouping them will improve performance. (e.g., if alphablendenable and separatealphaenable are changed state_blend is only executed once, not twice) *) The blendop is currently not reapplied if WINED3DRS_SEPARATEALPHABLENDENABLE is changed. One solution is to group the blendops with alphablend and move the code from state_blendop to state_blend. A better way is to make this a one-way dependency from state_alpha to state_blend. Compare STATE_RENDER(WINED3DRS_LIGHTING) and STATE_VDECL for a reference.

1 0

X developer's conference, April 16-18
by Dan Kegel Feb. 16, 2008

Feb. 16, 2008

http://www.x.org/wiki/Events/XDC2008 Seems like Wine might want a representative. What issues would we want to bring up there? - relative mouse motion events ...? - Dan

3 3

MSG_PEEK race in urlmon_test?
by Francois Gouget Feb. 16, 2008

Feb. 16, 2008

When I run the urlmon_test test the kernel (2.6.22.9) has this to say: Feb 16 05:53:54 amboise kernel: TCP(urlmon_test.exe:9836): Application bug, race in MSG_PEEK. Does anyone know what's up with that? Maybe someone who knows more than me about urlmon? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Hiroshima '45 - Czernobyl '86 - Windows '95

1 0

Re: wined3d: Fix bug in swapchain release which causes incorrect display mode changes.
by Chris Robinson Feb. 16, 2008

Feb. 16, 2008

On Saturday 16 February 2008 06:01:48 am Peter Dons Tychsen wrote: > Fixed bug in wined3d swapchain, which caused the release of the > swap-chain to mess around with the display-modes set by ddraw. Also > added test-case for this scenario. Reworked test code minimally, to > re-use existing test code. You may want to test D3D8 and D3D9 too, to see what they do when presented by the situation (since the code is shared). Also I don't think you should make those 2-space indents just to avoid changing those few lines.

1 0

Re: winedos: Allocate a console when loading dos applications
by Maarten Lankhorst Feb. 16, 2008

Feb. 16, 2008

Hi all, 2008/2/14, Dmitry Timoshkov <dmitry(a)codeweavers.com>: > "Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > > > > It worked before ba896e75d7fce68e5183007b65eae7e35490ccd4. (Around > > wine 0.9.33 or so) After that it was broken. I have a wine 0.9.9 that > > when run does create a seperate console for dos apps. My guess is that > > somewhere in the initialisation allocconsole would have to be called. > > > You need to talk to Alexandre since that's his patch. Still, there is > no AllocConsole() call removed by that commit, so it has nothing to do > with the regression. I've done a bunch of tests with a simple mingw app linked with -mconsole and found the following results (in xp sp2 vmware): - Asynchronous calls are not available for console handles (ReadFile only works in synchronous mode, ReadFileEx doesn't work) - I can do WaitForSingleObject(GetStdHandle(STD_INPUT_HANDLE), INFINITE); and it will only return when there is data to be read, like a key being pressed. in wine it will return immediately, this causes the breakage of dos apps after wine 0.9.33. These things make me think that the old behavior of wine is more correct then the current one, with relation to console handles. -Maarten.

2 1

Re: d3dx9 patches
by tony.wasserka＠freenet.de Feb. 16, 2008

Feb. 16, 2008

Okay, thanks. Then I'll just resend them and see if they get in this time. Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl. http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/i…

1 0

re: gecko download not robust?
by marco Feb. 15, 2008

Feb. 15, 2008

> > Hmm. gecko download hung for me once. I saw > fixme:urlmon:ProtocolStream_Read Read failed: 800c0008 > in the log, which makes me wonder if our download code > doesn't handle transient network errors well. > > Time to get rid of the download, and just bundle gecko outright, I say... I make the mandriva rpms for wine. This would make the rpms 30% bigger. And you would download the same gecko binary over and over again with every new version. But if that is not a problem than it can be easily done.

7 12

[PATCH] msvcrt: Fix scanf floating-point exponent handling.
by Jānis Rūcis Feb. 15, 2008

Feb. 15, 2008

This patch modifies the scanf floating-point algorithm to pass the tests I sent in my previous message. --- dlls/msvcrt/scanf.h | 40 +++++++++++++++++++++++++--------------- 1 files changed, 25 insertions(+), 15 deletions(-) diff --git a/dlls/msvcrt/scanf.h b/dlls/msvcrt/scanf.h index 7fe3cc4..66df15e 100644 --- a/dlls/msvcrt/scanf.h +++ b/dlls/msvcrt/scanf.h @@ -241,6 +241,12 @@ _FUNCTION_ { case 'G': { /* read a float */ long double cur = 0; int negative = 0; + + int decimal_places = 0; + unsigned int exponent = 0; + int negexp = 0; + long double be; + /* skip initial whitespace */ while ((nch!=_EOF_) && _ISSPACE_(nch)) nch = _GETC_(file); @@ -268,20 +274,17 @@ _FUNCTION_ { } /* handle decimals */ if (width!=0 && nch == '.') { - float dec = 1; nch = _GETC_(file); if (width>0) width--; while (width!=0 && (nch!=_EOF_) && _ISDIGIT_(nch)) { - dec /= 10; - cur += dec * (nch - '0'); + cur = cur * 10 + (nch - '0'); + decimal_places += 1; nch = _GETC_(file); if (width>0) width--; } } /* handle exponent */ if (width!=0 && (nch == 'e' || nch == 'E')) { - int exponent = 0, negexp = 0; - float expcnt; nch = _GETC_(file); if (width>0) width--; /* possible sign on the exponent */ @@ -292,20 +295,27 @@ _FUNCTION_ { } /* exponent digits */ while (width!=0 && (nch!=_EOF_) && _ISDIGIT_(nch)) { - exponent *= 10; - exponent += (nch - '0'); + exponent = exponent * 10 + (nch - '0'); nch = _GETC_(file); if (width>0) width--; } - /* update 'cur' with this exponent. */ - expcnt = negexp ? .1 : 10; - while (exponent!=0) { - if (exponent&1) - cur*=expcnt; - exponent/=2; - expcnt=expcnt*expcnt; - } } + + /* Combine exponent with decimal point. */ + for (; decimal_places > 0; decimal_places--) + { + if (exponent == 0) + negexp = 1; + + exponent += negexp ? +1 : -1; + } + + /* Perform exponentiation. */ + for (be = 1.0; exponent > 0; exponent--) + be *= 10.0; + + cur = negexp ? cur / be : cur * be; + st = 1; if (!suppress) { if (L_prefix) _SET_NUMBER_(long double); -- 1.5.3.8

1 0

d3dx9 patches
by tony.wasserka＠freenet.de Feb. 15, 2008

Feb. 15, 2008

Hi, It's nearly two weeks ago that I sent those patches, so I was curious if there are any problems with it? http://www.winehq.org/pipermail/wine-patches/2008-February/049554.html http://www.winehq.org/pipermail/wine-patches/2008-February/049667.html http://www.winehq.org/pipermail/wine-patches/2008-February/049677.html http://www.winehq.org/pipermail/wine-patches/2008-February/049679.html http://www.winehq.org/pipermail/wine-patches/2008-February/049705.html

2 1

Windows Mobile API
by Arthur Maciel Feb. 15, 2008

Feb. 15, 2008

Hi there. I´m not part of the mailing list, but I really want to know if there is any port of WINE to support Windows Mobile API (that is Windows for pocket pc, handhelds and pocket phones). This would come as a great solution for me, as I need specific WM programs on my pda. I really appreciate any help and information. Regards, Arthur

2 3

Google's support for Wine in 2007
by Dan Kegel Feb. 15, 2008

Feb. 15, 2008

As you might know, I work for Google, and part of my day job is to help improve Wine. Here's a little report about what we've been up to. Google uses Wine primarily as the basis for the Linux port of our photo management software, Picasa. In fact, the Linux version is exactly the Windows build of Picasa, bundled with a lightly patched version of Wine. Most of the work in that port was to improve Wine so it could handle Picasa, and that work is still going on. Codeweavers did the initial port, and Googlers Lei Zhang, Nigel Liang, and Michael Moss are improving Wine further for Picasa 2.7. Beyond Picasa, a few of us (Lei Zhang, Alex Balut, and I) have been fixing random Wine bugs in our 20% time. I've also been doing regular Valgrind runs over the Wine test suite, pestering developers who accidentally check in code that Valgrind doesn't like. Hats off to the Valgrind team for a great tool, and to the (non-Google) folks who work on Valgrind/Wine compatibility (Eric Pouech, Tom Hughes, and John Reiser, among others). Google also sponsored some work by Codeweavers to improve support for Photoshop ('cause so many people want it) and for Dragon Naturally Speaking ('cause even Linux users get RSI). While not yet perfect, those apps are a lot more usable now as a result. In particular, Photoshop CS and CS2 are quite usable indeed. (See http://wiki.winehq.org/AdobePhotoshop for details.) I also had the pleasure of hosting eight students as Google interns working on Wine throughout the year. Here are their names, and roughly what they worked on: Dan Hipschman: widl Evan Stade: gdiplus, Powerpoint Viewer James Hawkins: msi Jennifer Lai: win16 conformance tests Juan Lang: crypt32, iTunes Matt Jones: mono testing Mikolaj Zalewski: Photoshop, Limux Roy Shea: svchost, BITS So, you're wondering, what exactly does that all boil down to? I tallied all our accepted patches recently; the list is now up (along with the exact Wine source we use for Picasa) at http://code.google.com/opensource/wine.html I was pleasantly surprised at the size of the list. Separately, Google also sponsored nine Summer of Code students this year. Just to name two who remain active even after the end of summer: Alex Sørnes, who improved Wine's Wordpad, and Maarten Lankhorst, who solved tons of sound problems. (And oh, how nice it is to not have to change sound settings anymore!) All that may sound like a lot, and perhaps it is, but it pales compared to the work put in on Wine by the rest of the Wine developers. Thanks, everybody! I'm really looking forward to Wine 1.0 (which, according to Alexandre, is planned for sometime in 2008). Dan Kegel Software Engineer Google

5 6

Re: [PATCH] winex11.drv: get hwnd for injected mouse events
by Alexandre Julliard Feb. 15, 2008

Feb. 15, 2008

"Lei Zhang" <thestig(a)google.com> writes: > --- a/dlls/winex11.drv/mouse.c > +++ b/dlls/winex11.drv/mouse.c > @@ -278,6 +278,7 @@ void X11DRV_send_mouse_input( HWND hwnd, DWORD flags, DWORD x, DWORD y, > { > pt.x = (x * screen_width) >> 16; > pt.y = (y * screen_height) >> 16; > + hwnd = GetAncestor(WindowFromPoint(pt), GA_PARENT); This should not be needed, for injected events the window is determined on the server side. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: systray [4/4]: implement systray transparency
by Kirill K. Smirnov Feb. 15, 2008

Feb. 15, 2008

> We don't want to export such a specific function. Besides, it should > really be setting the window shape. I've just understood why we cannot rely upon setting window shape to get transparency. Let's consider almost empty icon or even empty - this may happen when application "flashes" icon, e.g. on incoming ICQ message. 1) Can be there active windows with empty visible area? 2) This windows do not correctly relay mouse events. -- Kirill

1 0

Re: systray [4/4]: implement systray transparency
by Kirill K. Smirnov Feb. 15, 2008

Feb. 15, 2008

> "Kirill K. Smirnov" <lich(a)math.spbu.ru> writes: > > diff --git a/dlls/winex11.drv/winex11.drv.spec > > b/dlls/winex11.drv/winex11.drv.spec index 36b83d7..126cbc5 100644 > > --- a/dlls/winex11.drv/winex11.drv.spec > > +++ b/dlls/winex11.drv/winex11.drv.spec > > @@ -130,6 +130,7 @@ # Desktop > > > > # System tray > > @ cdecl wine_make_systray_window(long) X11DRV_make_systray_window > > +@ cdecl wine_systray_window_clear(long) X11DRV_systray_window_clear > > We don't want to export such a specific function. Besides, it should > really be setting the window shape. Do I understand you correct that we should cut off transparent parts of icon, thus making window shape to match solid part of icon? Taking into account that almost every xembed-systray-aware application uses ParentRelative attribute (and KDE developers assumes this as I noticed at bug #3534), the idea of changing window shape sounds really strange. 1) Is there any strong reason why we really must change windows shape to achieve visual transparency? 2) Will it be better to stop embedding wine windows in favor of embedding pure X windows (like other apps do)? This way assumes implementing all xembed-specific stuff at winex11.drv side and exporting ONLY ONE function like wine_xembed_systray_handler(int cmd, void *data), which converts windows icon to X11 icon, creates X11 window with ParentRelative bkgrnd and embeds it. Explorer will use this function when it adds/removes icon to/from system tray. Also, this function will detect the case of wine virtual desktop and notify explorer to stop using xembed. I'm just not sure that this way will not break relaying mouse events. -- Kirill

2 1

Re: shell32: Fix character count passed into lstrcpnA in SHGetDataFromIDListA.
by Francois Gouget Feb. 15, 2008

Feb. 15, 2008

if (shortname) - lstrcpynA(pfd->cAlternateFileName, shortname, MAX_PATH); + lstrcpynA(pfd->cAlternateFileName, shortname, 14); sizeof(*pfd->cAlternateFileName) would be better than the magic 14 here. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ You can have my guns when you pry them from my kids cold, dead hands.

1 1

Re: Don't use GetExceptionCode and GetExceptionInformation in exception filter functions.
by Alexandre Julliard Feb. 15, 2008

Feb. 15, 2008

Robert Shearman <rob(a)codeweavers.com> writes: > Alternatively, we could get rid of the WINE_EXCEPTION_FILTER and > WINE_FINALLY_FUNC functions and make users of __EXCEPT and __FINALLY > declare the functions themselves and access the exception data > directly without use of macros. That would be better, the macros only make sense if we can use the standard ones. If we have to use a Wine-specific approach anyway then the macros are just making it harder to see what's going on. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ddraw / wined3d fighting over the resolution!
by Peter Dons Tychsen Feb. 15, 2008

Feb. 15, 2008

On Thu, 2008-02-14 at 09:18 +0100, Stefan Dösinger wrote: > Am Donnerstag, 14. Februar 2008 04:22:16 schrieb Peter Dons Tychsen: > > Why does the SwapChain-destroy function play around with the resolution > > at all. Is that really necessary? I think it should not do it if the > > caller is ddraw at least. > I thought I'm filtering this out in the case of ddraw, but maybe that got > lost. The reason why the swapchain restores the resolution is the different > way ddraw/d3d8 and d3d8/d3d9 set up the screen. > > In ddraw the app calls IDirectDraw7::SetDisplayMode. This sets the mode. Then > it creates a DDSCAPS_PRIMARYSURFACE surface, which creates the swapchain. > > In d3d8/d3d9 the swapchain controls the video mode > > I think the problem is that RestoreDisplayMode is called before the primary > surface is destroyed. The question is why this happens. I can think of the > following reasons: > > -> Refcounting problem, or the app just doesn't release the surfaces. Then > ddraw.dll destroys the objects on DLL_PROCESS_DETACH > > -> The app calls it that way. This needs a test, but I think it is not allowed > to call SetDisplayMode / RestoreDisplayMode while a primary surface is around OK, i have now eaten enough wine-gums to comprehend this.... I think there is a general problem in swapchain->release. The swapchain should only change the resolution back to the original *if* the current resolution is still the same as the swapchain enforced. If someone else has intervened, it should let it be. This fixes the problem at hand, but would also fix other silly problems. Some could for example have called Release() while the "window" is not even visible (tabbed to desktop for example). Please review my patch and let med know if it is submittable. If you hate it, i will eat more wine-gums. :-) /pedro

2 1

What's up with GetPrivateProfileString?
by Johan Gill Feb. 15, 2008

Feb. 15, 2008

http://bugs.winehq.org/show_bug.cgi?id=5424 The bug above is causing me some confusion regarding how GetPrivateProfileString should behave. Wine looks for maxis.ini in C:\Windows, and does not find it there. Therefore, Setup.exe exits. MSDN claims that if an absolute path is not provided, the windows directory is searched for the file. There are also some registry things to take into account, but maxis.ini should not be referenced in the registry since it is located on a CD-ROM and read before the autorun screen is shown. It seems very likely that GetPrivateProfileString on real Windows with just a filename as path argument looks in the current directory, but it would be nice if someone with a real Windows installation would check that. I can have a try at writing the test source if necessary.

1 0

Re: include: Fix the C_ASSERT macro to not generate an unused variable warning when compiling with gcc.
by Alexandre Julliard Feb. 15, 2008

Feb. 15, 2008

Robert Shearman <rob(a)codeweavers.com> writes: > @@ -279,10 +279,10 @@ extern "C" { > > /* Compile time assertion */ > > -#if defined(_MSC_VER) > +#if defined(_MSC_VER) || defined(__GNUC__) > # define C_ASSERT(e) typedef char __C_ASSERT__[(e)?1:-1] > -#elif defined(__GNUC__) > -# define C_ASSERT(e) extern char __C_ASSERT__[(e)?1:-1] > +#else > +# define C_ASSERT(e) This will break if you do two C_ASSERTs in the same scope. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] Add IRunnableTask interface (resend)
by Alexandre Julliard Feb. 15, 2008

Feb. 15, 2008

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes: > I have no idea why it wasn't applied, so this is a resend with no modifications. It should go in shobjidl.idl. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: systray [4/4]: implement systray transparency
by Alexandre Julliard Feb. 15, 2008

Feb. 15, 2008

"Kirill K. Smirnov" <lich(a)math.spbu.ru> writes: > diff --git a/dlls/winex11.drv/winex11.drv.spec b/dlls/winex11.drv/winex11.drv.spec > index 36b83d7..126cbc5 100644 > --- a/dlls/winex11.drv/winex11.drv.spec > +++ b/dlls/winex11.drv/winex11.drv.spec > @@ -130,6 +130,7 @@ # Desktop > > # System tray > @ cdecl wine_make_systray_window(long) X11DRV_make_systray_window > +@ cdecl wine_systray_window_clear(long) X11DRV_systray_window_clear We don't want to export such a specific function. Besides, it should really be setting the window shape. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winedos: Allocate a console when loading dos applications
by Dmitry Timoshkov Feb. 14, 2008

Feb. 14, 2008

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > Fixes bug 9178. > > I was looking hard at it, then I had to laugh, hard, when I found this > simple fix. This patch is not correct, think for instance of all win16 applications. -- Dmitry.

1 0

re: Fixing the last failing tests
by Dan Kegel Feb. 14, 2008

Feb. 14, 2008

Maarten wrote: > An example is IsWindowUnicode. It always returns TRUE on XP, but it > won't do that on 9x. That would mean something like: > ok(IsWindowUnicode() || !IsWindowUnicode(), "How can this fail?"); Maybe you can do something like if (CreateWindowExW doesn't work) { /* win95 without MSLU */ ok(!IsWindowUnicode()); } else { /* win95 with MSLU, or something with native unicode support */ ok(IsWindowUnicode()); }

2 3

[RFC] winecfg enhancements
by Reece Dunn Feb. 14, 2008

Feb. 14, 2008

Hi, I am looking at how we can make winecfg more useful. I have already supplied patches to allow importing a ubuntu human theme to work :). So I am now looking at how to build on that. On the Desktop Integration tab, I am planning on adding the following improvements: * Split the Appearance section into Theme and Appearance. The rationale behind this is while the two are linked, they are also distinct. It will make it possible to simplify "Install theme..." to just "Install...", and support enhancements below. * Pre-populate the Theme list with themes in WINDOWS/Resources/Themes and with other *.theme files added by the user. The rationale behind this is that it simplifies the workflow for the average usage (e.g. install a theme, then select it). * Rename "Install theme..." to "Add...". The rationale is that we are not installing a theme, but setting it as the theme being used. Having the theme appear in the Themes list in the future further supports this name change and workflow. * Rename "(No Theme)" to "Wine Default". The rationale behind this is that it isn't true that there is no theme installed (in the sense that a theme can be a set of colours and metrics). * Provide an "Export..." button to the Themes section. The rationale behind this is that it makes it easier to create, modify and preview themes being created. Therefore, you could create a Ubuntu Human or Oxygen theme from winecfg. * Make the theme importer read the themes [Theme]/DisplayName property. The rationale behind this is to make the display name user friendly. * Add --import-theme command line support to winecfg. The rationale behind this is to support loading a theme via a script (e.g. post-install configuration), without resorting to the winecfg GUI. * Make the shell folders a drop down list. The rationale behind this is that it is unclear what "link to" applies to. An alternative is to make the listview have the showselalways flag, so it is clearer what folder "link to" is relating to. Q: Should we provide a --simple mode for winecfg that has the work flow that Ubuntu is planning? Not specifying --simple would bring up the standard winecfg dialog. - Reece

8 10

Re: mscms: [GS]etColorSpace() are not supposed to be defined in icm.h.
by Detlef Riekenberg Feb. 14, 2008

Feb. 14, 2008

On Mi, 2008-02-13 at 21:52 +0100, Francois Gouget wrote: > diff --git a/include/icm.h b/include/icm.h The end of the attached Patchfile is broken: > &#;& -- By by ... Detlef

2 1

gecko valgrind errors show up better now
by Dan Kegel Feb. 14, 2008

Feb. 14, 2008

The new version of valgrind shows better stack dumps for gecko valgrind errors. For instance, Invalid read of size 4 at (within 0.1.0/wine_gecko/components/xppref32.dll) by (within 0.1.0/wine_gecko/components/xppref32.dll) by (within 0.1.0/wine_gecko/components/xppref32.dll) by (within 0.1.0/wine_gecko/components/xppref32.dll) by (within 0.1.0/wine_gecko/components/xppref32.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/necko.dll) by (within 0.1.0/wine_gecko/components/necko.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/necko.dll) by (within 0.1.0/wine_gecko/components/necko.dll) by load_gecko (nsembed.c:396) by NSContainer_Create (nsembed.c:1574) by HTMLDocument_Create (htmldoc.c:1232) by ClassFactory_CreateInstance (main.c:206) by CoCreateInstance (compobj.c:2411) by report_data (binding.c:444) by report_data_proc (binding.c:1262) Address 0x7f22e1e0 is not stack'd, malloc'd or (recently) free'd Invalid read of size 4 at (within 0.1.0/wine_gecko/components/rdf.dll) by (within 0.1.0/wine_gecko/components/rdf.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/profile.dll) by (within 0.1.0/wine_gecko/components/profile.dll) by load_gecko (nsembed.c:338) by NSContainer_Create (nsembed.c:1574) by HTMLDocument_Create (htmldoc.c:1232) by ClassFactory_CreateInstance (main.c:206) by CoCreateInstance (compobj.c:2411) by report_data (binding.c:444) by report_data_proc (binding.c:1262) by notif_wnd_proc (binding.c:184) Address 0x7f22e108 is not stack'd, malloc'd or (recently) free'd Conditional jump or move depends on uninitialised value(s) at (within 0.1.0/wine_gecko/components/necko.dll) by nsURI_QueryInterface (nsio.c:1181) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/necko.dll) by (within 0.1.0/wine_gecko/components/necko.dll) by nsIOService_NewChannelFromURI (nsio.c:2111) by (within 0.1.0/wine_gecko/components/rdf.dll) by (within 0.1.0/wine_gecko/components/rdf.dll) by (within 0.1.0/wine_gecko/components/rdf.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/profile.dll) by (within 0.1.0/wine_gecko/components/profile.dll) by load_gecko (nsembed.c:338) Invalid read of size 4 at (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/xpc3250.dll) by (within 0.1.0/wine_gecko/components/xpc3250.dll) by (within 0.1.0/wine_gecko/components/xpc3250.dll) by (within 0.1.0/wine_gecko/components/xpc3250.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/profile.dll) by load_gecko (nsembed.c:338) by NSContainer_Create (nsembed.c:1574) by HTMLDocument_Create (htmldoc.c:1232) by ClassFactory_CreateInstance (main.c:206) by CoCreateInstance (compobj.c:2411) by report_data (binding.c:444) by report_data_proc (binding.c:1262) by notif_wnd_proc (binding.c:184) by (within /home/dank/wine-git/dlls/user32/user32.dll.so) Address 0x7f22d1a8 is not stack'd, malloc'd or (recently) free'd etc., etc. Jacek, if you can give me a debug build of gecko, I can probably give you even better info. Interested? - Dan

2 1

Re: ddraw / wined3d fighting over the resolution!
by Peter Dons Tychsen Feb. 14, 2008

Feb. 14, 2008

Hello S. I have studied this a bit more. The app seems to do this purposely. In any case wined3d should not change the mode in this case. Either wined3d must detect this, or the code should be moved into d3d8/d3d9. On a similar note, i found i found a funny "RestoreDisplayMode()" call in "SetCooperateLevel()", when switching from full-screen. I tested with win-xp, and here this does not happen. This causes additional mode-switch flicker. I think i will chew on some nice German wine-gums (Haribo), and then send some patches :-). mmmmmm.... wine-gums.... they should sell them on wine.org... would be appropriate... :-) /p On Thu, 2008-02-14 at 09:18 +0100, Stefan Dösinger wrote: > Am Donnerstag, 14. Februar 2008 04:22:16 schrieb Peter Dons Tychsen: > > Why does the SwapChain-destroy function play around with the resolution > > at all. Is that really necessary? I think it should not do it if the > > caller is ddraw at least. > I thought I'm filtering this out in the case of ddraw, but maybe that got > lost. The reason why the swapchain restores the resolution is the different > way ddraw/d3d8 and d3d8/d3d9 set up the screen. > > In ddraw the app calls IDirectDraw7::SetDisplayMode. This sets the mode. Then > it creates a DDSCAPS_PRIMARYSURFACE surface, which creates the swapchain. > > In d3d8/d3d9 the swapchain controls the video mode > > I think the problem is that RestoreDisplayMode is called before the primary > surface is destroyed. The question is why this happens. I can think of the > following reasons: > > -> Refcounting problem, or the app just doesn't release the surfaces. Then > ddraw.dll destroys the objects on DLL_PROCESS_DETACH > > -> The app calls it that way. This needs a test, but I think it is not allowed > to call SetDisplayMode / RestoreDisplayMode while a primary surface is around

1 0

Re: Weird failure in kernel32 volume test
by Maarten Lankhorst Feb. 14, 2008

Feb. 14, 2008

Hi Jeremy, 2008/2/14, Jeremy White <jwhite(a)winehq.org>: > Anyone else has some tests that consistently fail on make test? > > > As of last nights git tip, I still had four failures: > > http://test.winehq.org/data/20080213/#Wine I submitted a patch for the comm test. I'm not 100% sure about the shelllink test. On that site there is also a failure for 'volume' which I experienced as well. I have really no idea what causes it though, but it looks like aj has done some work on it. Maybe you have any idea alexandre? Cheers, Maarten.

1 0