February 2008 - Wine-Devel - list.winehq.org

[winetest] Would it be worthwhile to send zipped version of the reports?
by Paul Vriens Feb. 12, 2008

Feb. 12, 2008

Hi, As more and more tests are developed I think it could make sense to zip the report files before sending. It will of course put a small extra burden on the winehq server but as the reports are text only we gain a 90% or so per report. Thoughts? -- Cheers, Paul.

2 2

Re: [advapi32/tests] Only use functions if they are implemented
by James Hawkins Feb. 12, 2008

Feb. 12, 2008

On Feb 12, 2008 10:34 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > Added some verbosity to the GetProcAddress stuff. The skips prevent the > crash(es) I'm seeing on win95. > What is the point of this 'verbosity'? You already add the skips, so if a function isn't available for a test, you're going to see it twice now. Also, it adds to the code size. -- James Hawkins

2 1

Re: browseui: Add undocumented Component Category Cache Daemon class
by Dmitry Timoshkov Feb. 12, 2008

Feb. 12, 2008

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > --- /dev/null > +++ b/dlls/browseui/compcatcachedaemon.c > @@ -0,0 +1,159 @@ > +/* > + * Progress dialog > + * > + * Copyright 2007 Mikolaj Zalewski Is the above information correct? -- Dmitry.

1 0

Re: Oleview: Added Dutch translations
by Dmitry Timoshkov Feb. 12, 2008

Feb. 12, 2008

"Frans Kool" <frans.kool(a)gmail.com> wrote: > From 2e5bda68273038f924f8f0d1b325a2a4c71f17ae Mon Sep 17 00:00:00 2001 > From: Frans Kool <Frans.Kool(a)gmail.com> > Date: Tue, 12 Feb 2008 12:04:56 +0100 > Subject: Oleview: Added Dutch translations This your patch as well as a previous one are wrapped. -- Dmitry.

1 0

Regesstion Tests
by Alistair Leslie-Hughes Feb. 12, 2008

Feb. 12, 2008

Hi, If I have Msxml3 with SP7 installed all the msxml tests pass without issue, but if I have Msxml3 SP3 installed, some fail. Should I improve the tests so that they can handle both cases? Best Regards Alistair Leslie-Hughes

2 1

Regular bugzilla hygeine
by Dan Kegel Feb. 12, 2008

Feb. 12, 2008

When we do a release, all the bugs in RESOLVED FIXED state can be closed (since they were only waiting on a release to be closed). We haven't been doing that, and as a result, lots and lots of bugs stacked up in RESOLVED FIXED state. But I don't see any reason we shouldn't start doing it, so I'm about to do it in honor of the 0.9.55 release. (I think I've figured out how to avoid changing any bugs flipped into that state since the 0.9.55 release, let's see if I get it right. Next time I'll do it right when Alexandre releases.) - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: comctl32: Fixed listview bug, when client sends bogus SETITEMSTATE request
by Dimi Paun Feb. 11, 2008

Feb. 11, 2008

On Tue, 2008-02-12 at 03:28 +0100, Peter Dons Tychsen wrote: > Fixed listview bug, when client sends bogus SETITEMSTATE request, > requesting all items to be focused. Looks good, tnx! -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Re: Resend patch from Norbert
by Vitaliy Margolen Feb. 11, 2008

Feb. 11, 2008

Rico Schüller wrote: > Hi, > > I only resend a patch because it isn't in the todays git and the author > didn't answer for a while. > > Cheers > Rico > > > ------------------------------------------------------------------------ > > > - memcpy(pRect, &This->updateStateBlock->scissorRect, sizeof(pRect)); > + memcpy(pRect, &This->updateStateBlock->scissorRect, sizeof(RECT)); To avoid such problems in the future one should use something like: *pRect = This->updateStateBlock->scissorRect; Doing a quick search through wined3d I've found number of places with memcpy instead of simple assignment of one struct to another struct. This is a good janitorial task to get rid of memcpy where simple assignment will work. Vitaliy.

3 2

Re: IStream interface for domdoc and terminate call
by Kornél Pál Feb. 11, 2008

Feb. 11, 2008

Also note you should test the behavior when call QueryInterface for IStream multiple times whether a new wrapper or the same wrapper is returned and whether the tree is cleared on QueryInterface. And I forgot to mention that calling Release on the IStream interface is the correct way of disposing the interface so that call may have effect on the object as well. Kornél ----- Original Message ----- From: "Kornél Pál" <kornelpal(a)gmail.com> To: "Josef Reidinger" <josef.reidinger(a)gmail.com>; <wine-devel(a)winehq.org> Sent: Monday, February 11, 2008 1:15 PM Subject: Re: IStream interface for domdoc and terminate call > OK, sorry I didn't realized that you try to modify the Wine > implementation. > > I think that delaying pasing for the fist time you call a method of the > DOMDocument object would be a good solution. This way you will not perform > any unnecessary parings. > > I don't know the exact details of MS implementations so you should check > when and how are parsing errors reported and when is the parsed document > available when you write the DOMDocument throug it's IStream interface and > you should dealy parsing to the latest possible time. > > Kornél > > ----- Original Message ----- > From: "Josef Reidinger" <josef.reidinger(a)gmail.com> > To: "Kornél Pál" <kornelpal(a)gmail.com> > Sent: Monday, February 11, 2008 12:58 PM > Subject: Re: IStream interface for domdoc and terminate call > > >> Hi >> I mean using call IStream_write like it is describe in bug #4811. >> >> Kornél Pál napsal(a): >>> Hi, >>> >>> If you mean passing an IStream interface to DOMDocument.save method: >>> As far as I know save method is synchronous (if I'm wrong you still can >>> set the async property to FALSE). So when the save method returns you >>> know that the entire document has been passed to the IStream. >>> >>> If you want to do something else please be more specific. >>> >>> Kornél >>> >>> ----- Original Message ----- From: "Josef Reidinger" >>> <josef.reidinger(a)gmail.com> >>> To: <wine-devel(a)winehq.org> >>> Sent: Monday, February 11, 2008 11:55 AM >>> Subject: IStream interface for domdoc and terminate call >>> >>> >>>> Hi, I try make IStream write interface for domdoc (msxml3). Problem is >>>> that microsoft doesn't have terminate string for write call and libxml >>>> have proble with it (more at >>>> http://mail.gnome.org/archives/xml/2008-February/msg00052.html ). Does >>>> anyone has any idea how solve it? (test in each dom call if is some >>>> nonparsed characters and force parsing looks very ugly). >>>> JR >>>> >>>> >>> >> >

1 0

Re: IStream interface for domdoc and terminate call
by Kornél Pál Feb. 11, 2008

Feb. 11, 2008

OK, sorry I didn't realized that you try to modify the Wine implementation. I think that delaying pasing for the fist time you call a method of the DOMDocument object would be a good solution. This way you will not perform any unnecessary parings. I don't know the exact details of MS implementations so you should check when and how are parsing errors reported and when is the parsed document available when you write the DOMDocument throug it's IStream interface and you should dealy parsing to the latest possible time. Kornél ----- Original Message ----- From: "Josef Reidinger" <josef.reidinger(a)gmail.com> To: "Kornél Pál" <kornelpal(a)gmail.com> Sent: Monday, February 11, 2008 12:58 PM Subject: Re: IStream interface for domdoc and terminate call > Hi > I mean using call IStream_write like it is describe in bug #4811. > > Kornél Pál napsal(a): >> Hi, >> >> If you mean passing an IStream interface to DOMDocument.save method: >> As far as I know save method is synchronous (if I'm wrong you still can >> set the async property to FALSE). So when the save method returns you >> know that the entire document has been passed to the IStream. >> >> If you want to do something else please be more specific. >> >> Kornél >> >> ----- Original Message ----- From: "Josef Reidinger" >> <josef.reidinger(a)gmail.com> >> To: <wine-devel(a)winehq.org> >> Sent: Monday, February 11, 2008 11:55 AM >> Subject: IStream interface for domdoc and terminate call >> >> >>> Hi, I try make IStream write interface for domdoc (msxml3). Problem is >>> that microsoft doesn't have terminate string for write call and libxml >>> have proble with it (more at >>> http://mail.gnome.org/archives/xml/2008-February/msg00052.html ). Does >>> anyone has any idea how solve it? (test in each dom call if is some >>> nonparsed characters and force parsing looks very ugly). >>> JR >>> >>> >> >

1 0

IStream interface for domdoc and terminate call
by Josef Reidinger Feb. 11, 2008

Feb. 11, 2008

Hi, I try make IStream write interface for domdoc (msxml3). Problem is that microsoft doesn't have terminate string for write call and libxml have proble with it (more at http://mail.gnome.org/archives/xml/2008-February/msg00052.html ). Does anyone has any idea how solve it? (test in each dom call if is some nonparsed characters and force parsing looks very ugly). JR

2 1

Re: pdh[3:3]: remove unnecessary tests done in PdhLookupPerfNameByIndexW
by Dmitry Timoshkov Feb. 11, 2008

Feb. 11, 2008

"Jeff Latimer" <lats(a)yless4u.com.au> wrote: > --- a/dlls/pdh/pdh_main.c > +++ b/dlls/pdh/pdh_main.c > @@ -837,14 +837,7 @@ PDH_STATUS WINAPI PdhLookupPerfNameByIndexA( LPCSTR machine, DWORD index, LPSTR > > TRACE("%s %d %p %p\n", debugstr_a(machine), index, buffer, size); > > - if (machine) > - { > - FIXME("remote machine not supported\n"); > - return PDH_CSTATUS_NO_MACHINE; > - } > - > if (!buffer || !size) return PDH_INVALID_ARGUMENT; > - if (!index) return ERROR_SUCCESS; Changelog mentions PdhLookupPerfNameByIndexW by the change is in PdhLookupPerfNameByIndexA. Why are you removing the checks in one place by leave the same in other one? Why the tests are unnecessary? -- Dmitry.

2 6

Re: [1/9] WineD3D: Add a test for the vFace register
by H. Verbeet Feb. 11, 2008

Feb. 11, 2008

On 11/02/2008, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > /* TODO: vFace (ps_3_0) */ You should probably remove that one :-)

1 0

re: Is there a Git Repositories for Unaccept Patches or (work in Progress)?
by Dan Kegel Feb. 11, 2008

Feb. 11, 2008

Joeseph wrote: > Is there a Git Repositories for Unaccept Patches or (work in Progress)? Not really, but people often attach patches to bugzilla entries if they're not quite good enough to submit. And if anybody wants to start such a git repository, more power to them. >An ntoskrnl.exe was written a couple of years ago to load drivers, >specifically the Safedisc Windows kernel driver, > but it still hasn't been accepted. The article you read is out of date; ntoskrnl.exe is now part of wine. > Basically threat unaccepted patch as bugs(while keeping the patch out of wine), instead of chucking it out the window. As I said above, developers are free to attach patches to bug reports. What you're really trying to get at is: sometimes developers get discouraged at how hard it is to get patches into Wine. But no mechanical aid will really help there. The only cure is persistance on the part of the developer, and assistance (chiefly good feedback) from other Wine developers. After a developer gets a few patches committed, the wine process starts to feel a lot smoother. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

6 11

Wine patches integrated into Valgrind svn
by Dan Kegel Feb. 10, 2008

Feb. 10, 2008

Hey, the Valgrind developers finally merged the Wine support patches! I just built Valgrind from svn as described here: http://valgrind.org/downloads/repository.html and on a fresh install of Gutsy, it just worked, no patches. To run Valgrind's tests under Wine, I configure valgrind with --prefix=/usr/local/valgrind-svn, then do something like cd wine-git/tools wget http://kegel.com/wine/valgrind/runtests.patch wget http://kegel.com/wine/valgrind/valgrind-daily.sh wget http://kegel.com/wine/valgrind/valgrind-suppressions wget http://kegel.com/wine/valgrind/valgrind-split-pl.txt -O valgrind-split.pl patch -p2 < runtests.patch Then to run all the tests, I do cd ~/wine-git sh tools/valgrind-daily.sh or to run just one test, I do export RUNTEST_USE_VALGRIND=1 cd ~/wine-git/dlls/riched20/tests make test I've only verified that this works well on one machine so far, but I have high hopes. Anyone else feel like giving it a whirl? - Dan

3 4

Re: Gdiplus: Implement GdipDrawArcI based on GdipDrawArc
by James Hawkins Feb. 10, 2008

Feb. 10, 2008

On Feb 10, 2008 4:04 PM, Royal Chan <chanroyal(a)gmail.com> wrote: > Change Log: > -Added GdipDrawArcI as GdipDrawArc that takes INT arguments > -Added a very similar conformance test to the one I did for GdipDrawArc > -Corresponding change to gdiplus.spec > No patch. -- James Hawkins

1 0

? on Repositories for Unaccept Patches and (work in Progress).
by Joseph Stein Feb. 10, 2008

Feb. 10, 2008

Is there a Git Repositories for Unaccept Patches or (work in Progress)? If not (which i think is the case and why I posting here instead of the user mailing list.), could you create one(along with a text file explain what need to be done to be accepted)? Here are some reason I think It is Needed. 1.) It would allow developer and users to see what the source done. I have read a very good article about usb support in wine an winehq.org here http://www.winehq.org/?issue=331 wich said that >An ntoskrnl.exe was written a couple of years ago to load drivers, >specifically the Safedisc Windows kernel driver, but it still hasn't been >accepted. Apparently there's some low-level internal Wine issues >and Alexandre wants those fixed before accepting the patch. 2.) Allow people two git possibly some things work that would other wise not work. using the patch for ntoskrnl.exe that was not accept as an example, (please correct me if i wrong), could possible git some drivers working (usb driver may be?) program to work. which is currently not possible with wine from what i read. Yes It dose cause other wine problem which is not big deal, if you compile and run wine form the source directory from which it is compiled instead of installing it (the multiple wine install way). In other words you code use the patch version of wine just for the program that need the patch to work .(Is it not better to have a broken wine (with partal diver) support, then a stable wine with-out (partal diver) support when The program you are running requires a driver.) 3.)If done right in my humble opinion would help prevent developer from getting discurage becuase all there work has be chuck out the window. Giving more Light to what i said above, What I mean buy "if done right",Is that if a developer(who is looking for something to do) would go look at what patches Have not be accepted (but have almost all basic done) and help the developer git it accepted ,Would in my humble opinion encourage more developer to join which is need for a complicated project such as wine. Basically threat unaccepted patch as bugs(while keeping the patch out of wine), instead of chucking it out the window. This type of thing is done in boost project i be-leave, but I taking it one step further and asking for a text file on "what need to be done to be include which each unaccepted patches". Thank you for any reply, Please forgive me if I got any of what i said above wrong, I'm not a real good developer and only have a real basic idea of wine and have not work on wine because it to confusing to me(but have download and looked at from git Repositories) --------------------------------- Be a better friend, newshound, and know-it-all with Yahoo! Mobile. Try it now.

4 3

Re: Gdiplus: conformance test for GdipDrawLineI in graphics.c
by James Hawkins Feb. 10, 2008

Feb. 10, 2008

On Feb 10, 2008 3:46 PM, Royal Chan <chanroyal(a)gmail.com> wrote: > Change Log: > -added conformance test mainly checking for input parameters > You forgot the patch again. -- James Hawkins

1 0

Re: Gdiplus: GdipDrawArc in graphics.c does not return InvalidParameter for bad values of height and width
by James Hawkins Feb. 10, 2008

Feb. 10, 2008

On Feb 10, 2008 3:19 PM, Royal Chan <chanroyal(a)gmail.com> wrote: > Change Log: > -added two checks for non-positive values of width and height > -added a conformance test for invalid parameters > You forgot the patch. -- James Hawkins

1 0

winecfg improvements
by Reece Dunn Feb. 10, 2008

Feb. 10, 2008

Hi, I have just submitted 4 patches that make it possible to import a colour theme from winecfg and have it correctly apply the colours. One example is the Ubuntu Human theme (see attachment), adapted from http://tombuntu.com/wp-content/uploads/2008/01/winehumancolours.txt. Enjoy, - Reece

1 0

Re: dlls/gdi32/font.c warning removal (RESEND)
by Alexandre Julliard Feb. 10, 2008

Feb. 10, 2008

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > The reason is that we have > > #define HDPTOLP(y) ((y<0)? \ > (-abs(INTERNAL_YDSTOWS(dc, (y)))): \ > (abs(INTERNAL_YDSTOWS(dc, (y))))) > > which is overly complicated for unsigned types. We can avoid these > warnings by using plain INTERNAL_YDSTOWS instead of HDPTOLP here. No, you still need the abs(). -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: WineD3D: split framebuffer -> texture path from LoadLocation
by Stefan Dösinger Feb. 10, 2008

Feb. 10, 2008

Am Sonntag, 10. Februar 2008 17:37:25 schrieb Roderick Colenbrander: > Hi, > > This patch puts the framebuffer -> texture from LoadLocation in a separate > function in a similar way to read_from_framebuffer. It borrows some code > from LoadLocation and read_from_framebuffer. > > Regards, > Roderick Colenbrander You're mixing tabs and spaces in this patch

2 2

Re: Implemented a stub for MsiSetExternalUIRecord in msi.dll
by James Hawkins Feb. 10, 2008

Feb. 10, 2008

On Feb 10, 2008 1:11 PM, Luke Benstead <kazade(a)gmail.com> wrote: > This unimplemented function causes the .NET framework 3.0 installer to fail > (and also Visual C++ express 8.0) with this patch the installer continues > further before crashing. This is my first ever patch on Wine (and working > with GIT) so I'm sure I've done something wrong, if so I apologize in > advance :) > > diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c > index 643f9cc..9fb6906 100644 > --- a/dlls/msi/msi.c > +++ b/dlls/msi/msi.c > @@ -992,6 +992,7 @@ end: > return state; > } > > + > INSTALLUILEVEL WINAPI MsiSetInternalUI(INSTALLUILEVEL dwUILevel, HWND *phWnd) > { > INSTALLUILEVEL old = gUILevel; Random whitespace change -> bad. > @@ -1008,6 +1009,18 @@ INSTALLUILEVEL WINAPI MsiSetInternalUI(INSTALLUILEVEL dwUILevel, HWND *phWnd) > return old; > } > > +/*********************************************************************** > + * MsiSetExternalUIRecord [MSI.@] > + */ > +UINT WINAPI MsiSetExternalUIRecord( INSTALLUI_RECORD_HANDLER puiHandler, > + DWORD dwMessageFilter, LPVOID pvContext, > + PINSTALLUI_RECORD_HANDLER ppuiPrevHandler ) > +{ > + FIXME("%p %08x %p %p", > + puiHandler, dwMessageFilter, pvContext, ppuiPrevHandler); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > INSTALLUI_HANDLERA WINAPI MsiSetExternalUIA(INSTALLUI_HANDLERA puiHandler, > DWORD dwMessageFilter, LPVOID pvContext) > { Used tabs -> bad. > @@ -2452,3 +2465,5 @@ UINT WINAPI MsiAdvertiseScriptA( LPCSTR szScriptFile, DWORD dwFlags, > debugstr_a( szScriptFile ), dwFlags, phRegData, fRemoveItems ); > return ERROR_CALL_NOT_IMPLEMENTED; > } > + > + More random whitespace changes. > @@ -573,6 +576,7 @@ UINT WINAPI MsiAdvertiseScriptW(LPCWSTR, DWORD, PHKEY, BOOL); > UINT WINAPI MsiCloseHandle(MSIHANDLE); > UINT WINAPI MsiCloseAllHandles(void); > INSTALLUILEVEL WINAPI MsiSetInternalUI(INSTALLUILEVEL, HWND*); > +UINT WINAPI MsiSetExternalUIRecord( INSTALLUI_RECORD_HANDLER, DWORD, LPVOID, PINSTALLUI_RECORD_HANDLER); Inconsistent whitespace. The rest of the file does not have spaces after parentheses. -- James Hawkins

1 0

gecko download not robust?
by Dan Kegel Feb. 10, 2008

Feb. 10, 2008

Hmm. gecko download hung for me once. I saw fixme:urlmon:ProtocolStream_Read Read failed: 800c0008 in the log, which makes me wonder if our download code doesn't handle transient network errors well. Time to get rid of the download, and just bundle gecko outright, I say...

2 1

Re: Is wine reporting the right value for MaxVertexBlendMatrices ?
by Alex Jackson Feb. 10, 2008

Feb. 10, 2008

> That said, GL_ARB_vertex_blend is not very common. Only MacOS supports it, and > it is software emulated there. The Linux ATI driver used to support it until > ATI switched to a different codebase. So this constant ends up beeing 0 > almost everywhere. The extension was dropped in favor of vertex programs, > since vertex programs appeared shortly after vertex blending and no gl app > was using it at this time. On Windows drivers emulate vertex blending using > vertex shaders. > > I am not sure if 0 is the correct value to return in case of no vertex > blending support. What happens if you set it to 1? 1 would be a reasonable > default as well, because we're still able to transform vertices with one > matrix(ie, unblened transformation). It could also be that this game silently > expects vertex blending to be supported: For one part, all dx8+ cards support > this feature on Windows, and on older cards Windows has software vertex > processing which can perform blending in a slow, but working fashion. > > I have a patch for software emulated vertex blending somewhere, but I dropped > it because I didn't come across an app which uses this function. Maybe its > time to revive it, and continue the work on a fixed function replacement > shader. Even on Windows, no OpenGL implementation that I know of supports GL_ARB_vertex_blend other than ATI's (and as you've pointed out, the new OpenGL stack that the Radeon HD's use on Windows and that all Radeons now use on Linux has dropped it). History lesson: Both GL_ARB_vertex_blend and D3D vertex blending are historically tied to a specific piece of hardware: the original ATI Radeon (GL_ARB_vertex_blend started out as GL_ATI_vertex_blend). Presumably, due to ATI's historically spotty OpenGL driver performance (okay, "historically" is being kind to ATI), any game developer who wanted to use the Radeon's capabilities targeted their game for D3D rather than OpenGL. Consequently, when nVidia released the GeForce 3 (the first video card with vertex shaders) they did implement D3D vertex blending via shaders in their D3D driver (since games were using it, and it wouldn't do if the "new" GF3 couldn't handle effects that the "old" Radeon could), but they didn't bother to implement it in their OpenGL driver, even though ATI had gotten it ARB-approved some months before the GF3 came out, since no games/apps were using it. The other video hardware makers (the few that were left by the DX8 era) followed NV's example: implement D3D vertex blending via shaders or in software (for entry-level and onboard hardware without vertex shaders), but don't bother with GL_ARB_vertex_blend since no one uses it. The upshot is that GL_ARB_vertex_blend is an ARB extension In Name Only; it's effectively ATI-only--and even ATI has abandoned it now. On the other hand, D3D vertex blending is universally available on modern and semi-modern hardware regardless of maker, and it looks like even some D3D9 games still use it instead of using vertex shaders. So it's better for WINE to implement vertex blending via vertex programs rather than depending on GL_ARB_vertex_blend. --AWJ-- _________________________________________________________________

3 2