February 2008 - Wine-Devel - list.winehq.org

Re: gdi32: Move 16-bit printing functions to printdrv16.c.
by Alexandre Julliard Feb. 29, 2008

Feb. 29, 2008

Robert Shearman <rob(a)codeweavers.com> writes: > --- > dlls/gdi32/Makefile.in | 1 + > dlls/gdi32/printdrv.c | 752 > +--------------------------------------------- > dlls/gdi32/printdrv16.c | 779 > +++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 783 insertions(+), 749 deletions(-) That won't work, some of these functions are exported from gdi32. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dxdiagn: Fix the variable that the result of GetFileVersionInfoW is assigned to in DXDiag_AddFileDescContainer.
by Paul Vriens Feb. 29, 2008

Feb. 29, 2008

Robert Shearman wrote: > --- > dlls/dxdiagn/provider.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Rob, Is there a need to have it assigned, as the next line overwrites boolret again? -- Cheers, Paul.

2 1

Re: [PATCH] shlwapi: Handle PathCanonicalize with too long paths
by Robert Shearman Feb. 29, 2008

Feb. 29, 2008

Marcus Meissner wrote: > lpszPath) > { > WCHAR szPath[MAX_PATH]; > WCHAR szBuff[MAX_PATH]; > - MultiByteToWideChar(CP_ACP,0,lpszPath,-1,szPath,MAX_PATH); > + DWORD le = GetLastError(); > + int ret = MultiByteToWideChar(CP_ACP,0,lpszPath,-1,szPath,MAX_PATH); > + > + if (!ret) { > + FIXME("Failed to convert string to widechar (too long?), LE %d.\n", GetLastError()); > + SetLastError (le); /* failure does not change Lasterror, see testcase. */ > + return FALSE; > + } > Hi Marcus, FIXME should be used for unimplemented functionality, not for highlighting application bugs that will happen on Windows too. WARN would be more appropriate here. -- Rob Shearman

1 0

GSoC project ideas
by Kai Blin Feb. 28, 2008

Feb. 28, 2008

Hi, as promised, I'll start off this thread with the ideas we have on the wiki page [1] right now: * Implementing a WinePluginApi so other programs can use Windows DLLs inside of Linux apps * Improving our HTML/Win32 Help viewers. * Implementing the ASIO audio infrastructure for Cubase * Implement the MS Wsock dll (dlls/mswsock), an enhanced winsocket implementation * Valgrind and Wine integration (see: Wine_and_Valgrind) * Complete the Wine Web browser (aka. Internet Explorer) ie. frame controls, toolbar, status bar * Full URLMoniker implementation. (IE working with builtin urlmon.dll) * Implement transacted mode for OLE32 Storage (STGM_TRANSACTED) * Improve cmd.exe compatibility * Get Mozilla compiling as a Winelib application (http://www.winehq.org/site/winelib#mozilla) * Run the Mauve Java test suite against Sun's Windows JRE, and file bugs / write test cases in C / fix anything it finds * Run the MDAC conformance test suite against Microsoft's MDAC, and file bugs / write test cases in C / fix anything it finds * pick some real-world app or game that doesn't work well, and improve Wine so it installs and runs the app better. (Some good examples might be Photoshop, Visual Basic, a game etc) * pick a Windows feature that is incomplete in Wine, and improve the feature and its conformance tests. (Some good examples might be riched20, DirectPlay, etc) Feel free to add your own project ideas, maybe elaborate a bit on the deliverables of the idea. Cheers, Kai [1] http://wiki.winehq.org/SummerOfCode -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

8 14

Anybody has a patch for implementing WriteFileGather Kernel32.dll
by Michel Jacques Feb. 28, 2008

Feb. 28, 2008

Hello, I'm looking for an implementation of WriteFileGather in Kernel32.dll. Anybody has a candidate? Thanks in advance, Michel Jacques

3 2

Re: Spelling fixes (replace iff with if)
by Stefan Dösinger Feb. 28, 2008

Feb. 28, 2008

Am Donnerstag, 28. Februar 2008 18:19:28 schrieb Vitaly Lipatov: > Changelog: > - replace 'iff' with 'if' (just a spelling fixes) The usual meaning of iff is "if and only if", so its not necessarily a typo

1 0

Re: [2/10] WineD3D: Subclass queries
by Alexandre Julliard Feb. 28, 2008

Feb. 28, 2008

Stefan Dösinger <stefan(a)codeweavers.com> writes: > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c > index d1ab9a3..9dff960 100644 > --- a/dlls/wined3d/device.c > +++ b/dlls/wined3d/device.c > @@ -1143,6 +1143,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl_CreateQuery(IWineD3DDevice *iface, WINE > IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; > IWineD3DQueryImpl *object; /*NOTE: impl ref allowed since this is a create function */ > HRESULT hr = WINED3DERR_NOTAVAILABLE; > + const IWineD3DQueryVtbl *vtable; > > /* Just a check to see if we support this type of query */ > switch(Type) { > @@ -1161,6 +1162,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl_CreateQuery(IWineD3DDevice *iface, WINE > */ > FIXME("(%p) Event query: Unimplemented, but pretending to be supported\n", This); > } > + vtable = &IWineD3DEventQuery_Vtbl; > hr = WINED3D_OK; > break; So what is vtable set to in the other cases? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [4/10] D3D9: Don't use C casts to get the d3d9impl from IDirect3D9
by Alexandre Julliard Feb. 28, 2008

Feb. 28, 2008

Stefan Dösinger <stefan(a)codeweavers.com> writes: > This patch adds an inline conversion function similar to the ones used > in dinput. This is needed to implement IDirect3D9Ex, which uses a 2nd > vtable on the same object IDirect3D9Ex inherits from IDirect3D9, so you shouldn't need a 2nd vtable. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: Spelling fixes (replace iff with if)
by Dan Kegel Feb. 28, 2008

Feb. 28, 2008

lav at etersoft.ru wrote: > - replace 'iff' with 'if' (just a spelling fixes) 'iff' is shorthand for 'if and only if'. http://en.wikipedia.org/wiki/If_and_only_if So many of those 'typos' might actually be correct. Careful! - Dan

2 1

Re: [Wine] How about this replacement of WINE.
by Dan Kegel Feb. 28, 2008

Feb. 28, 2008

On Thu, Feb 28, 2008 at 8:26 AM, bussuser <wineforum-user(a)winehq.org> wrote: > http://www.reactos.org/forum/viewtopic.php?t=5240 > > It is based on WINE and ReactOS . It's not a wine replacement; it uses wine. Better description at http://www.reactos.org/forum/viewtopic.php?t=5240 It looks like they added hooks to the linux kernel to accept windows nt syscalls. Maybe they even allow using the system's normal shared library loader instead of Wine's special one. This is something I've often wanted to do, but it was way lower priority than getting wine working. I haven't looked at their project at all, no idea if it was done well. - Dan

4 5

Heap corruption in crypt32?
by Dan Kegel Feb. 28, 2008

Feb. 28, 2008

I strolled down memory lane a bit, and revisited the Sandra benchmark today, see http://www.winehq.org/pipermail/wine-devel/2006-December/052821.html Now the win2k version gets a lot farther. To install, first do sh winetricks vcrun2005sp1 gdiplus (Without native gdiplus, the installer complains you don't have it; without vcrun2005sp1, you get a few errors like fixme:actctx:parse_assembly_elem wrong version for assembly manifest.) The installer claims to be happy, but one sees err:module:import_dll Library CRYPTUI.dll (which is needed by L"C:\\windows\\temp\\is-KH13O.tmp\\certmgr.exe") not found err:module:LdrInitializeThunk Main exe initialization for L"C:\\windows\\temp\\is-KH13O.tmp\\certmgr.exe" failed, status c0000135 Could not get handle to service. on the console. Worse, when the app starts up, you get a heap error: err:heap:HEAP_ValidateInUseArena Heap 0x7f000000: in-use arena 0x7f02e2e0 next block has PREV_FREE flag err:heap:HEAP_ValidateInUseArena Heap 0x7f000000: bad back ptr 0x1c9ba51e for arena 0x7f02e798 I suppose that could be a result of cryptui being missing, but I ran it under valgrind anyway. This turned up interesting items like ==20325== Invalid read of size 1 ==20325== at 0x46F5E49: HEAP_CreateFreeBlock (heap.c:486) ==20325== by 0x46F621D: HEAP_ShrinkBlock (heap.c:575) ==20325== by 0x46F7979: RtlAllocateHeap (heap.c:1228) ==20325== by 0x5C60B74: new_object (handle.c:441) ==20325== by 0x5C6B1CD: new_key (rsaenh.c:830) ==20325== by 0x5C6C9DB: RSAENH_CPImportKey (rsaenh.c:2464) ==20325== by 0x4B4324A: CryptImportKey (crypt.c:1767) ==20325== by 0x4F2DCDC: CRYPT_ImportRsaPublicKeyInfoEx (encode.c:3923) ==20325== by 0x4F2DA3B: CryptImportPublicKeyInfoEx (encode.c:3955) ==20325== by 0x4F183FA: CRYPT_VerifyCertSignatureFromPublicKeyInfo (cert.c:1641) ==20325== by 0x4F1B069: CryptVerifyCertificateSignatureEx (cert.c:1723) ==20325== by 0x4F1EDCD: CRYPT_CheckSimpleChain (chain.c:744) ==20325== Address 0x7f02ecf8 is not stack'd, malloc'd or (recently) free'd quite early in the run (well before the heap errs). Juan, what do you make of it? Might this be a real bug in crypt32 or our heap? - Dan

2 1

Re: winejoystick.drv: Add axis remapping support
by Vitaliy Margolen Feb. 28, 2008

Feb. 28, 2008

Adolfo R. Brandes wrote: > Greetings! > > The purpose of this patch is to add registry axis remapping and POV > hat support to winejoystick.drv, much like what's already in place for > dinput/joystick_linux.c. I needed this for X-Wing Alliance > (http://appdb.winehq.org/objectManager.php?sClass=application&iId=2110) > which recognizes my Thrustmaster Top Gun Fox 2 Pro USB joystick, but > not the POV hat and with the Rudder and Throttle axes switched around. > > It uses the following conventions: > > HKCU\Software\Wine\Joystick\<joyname> = <axeslist> > > or > > HKCU\Software\Wine\AppDefaults\app.exe\Joystick\<joyname> = <axeslist> > > Where <joyname> is the device name (as shown in jstest), and > <axeslist> is a comma-separated list of axis names. However, in > contrast to joystick_linux.c, the axis names are the same as in > jstest. For example, in my case jstest reports: Don't do that. Keep it uniform. As-is it's a pain to configure. You want to introduce even more? First few general notes about your patch - do not mix tabs and spaces! Set tab width to be _always_ 8 spaces! For best results just don't use tabs. Do not change formating, of the function unless you changing big part of it and you changing it to default Wine formating (4 spaces, curly brackets on their own line). > +static char *axis_name(char *str, unsigned char type, int len) { > + switch(type) { > + case ABS_X: > + memcpy(str,"X",len - 1); > + break; > + case ABS_Y: The way you using this function it makes much more sense to return static text ex: static const char *axis_name(unsigned char type) { switch (type) { case ABS_X: return "X"; case ABS_Y: return "Y"; case ABS_Z: return "Z"; default: return "?"; } } BTW what will that "?" do? I don't see you comparing it against anything. > + else > + ERR("Not all joystick axes mapped: %d axes, %d arguments\n", nrOfAxes, j); Disabling axis might not be a bad thing, especially for testing. I don't think you need to worry about extra axis on the device that are not mapped to anything. > + for (i = 0; i < nrOfAxes; i++) > + switch(axis_map[i]) { > + case ABS_HAT0X: > + case ABS_HAT0Y: > + lpCaps->wCaps |= JOYCAPS_HASPOV; > + break; > + } You need both X and Y axis for it to work. You have to check that both are present. Also what about multiple POVs? Here you checking for only one. > switch(nrOfAxes) { > - case 6: lpCaps->wCaps |= JOYCAPS_HASV; > - case 5: lpCaps->wCaps |= JOYCAPS_HASU; > - case 4: lpCaps->wCaps |= JOYCAPS_HASR; > - case 3: lpCaps->wCaps |= JOYCAPS_HASZ; > - /* FIXME: don't know how to detect for > - JOYCAPS_HASPOV, JOYCAPS_POV4DIR, JOYCAPS_POVCTS */ > + case 6: > + lpCaps->wCaps |= JOYCAPS_HASV; > + lpCaps->wVmax = 0xFFFF; > + case 5: > + lpCaps->wCaps |= JOYCAPS_HASU; > + lpCaps->wUmax = 0xFFFF; > + case 4: > + lpCaps->wCaps |= JOYCAPS_HASR; > + lpCaps->wRmax = 0xFFFF; > + case 3: > + lpCaps->wCaps |= JOYCAPS_HASZ; > + lpCaps->wZmax = 0xFFFF; Now that you can remap axis it's not guaranteed that 6th axes is the speed and so on. Vitaliy.

2 2

Valgrind can't *quite* handle Adobe InDesign yet
by Dan Kegel Feb. 28, 2008

Feb. 28, 2008

http://bugs.kde.org/show_bug.cgi?id=126389 means that valgrind can't yet handle apps that throw exceptions during regular operation. Like, say, Adobe InDesign's installer. I would like to valgrind that to track down http://bugs.winehq.org/show_bug.cgi?id=11757 but I can't because valgrind doesn't handle fxrestor. I think, anyway... - Dan

2 3

schroedinger 1.0 (fast implementation of Dirac video codec) released
by Dan Kegel Feb. 28, 2008

Feb. 28, 2008

http://lwn.net/Articles/271058/ "Decodes HD720/25p in real-time on a Core Duo laptop" Yum. I'd like to see free codecs like this bundled with wine sometime.

1 0

Re: Alistair Leslie-Hughes : msvcrt: Implement wcscpy_s.
by James McKenzie Feb. 28, 2008

Feb. 28, 2008

Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 00609d5e7824a117084f3f4b75e1aec03b60102a > URL: http://source.winehq.org/git/wine.git/?a=commit;h=00609d5e7824a117084f3f4b7… > > Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Wed Feb 27 19:58:04 2008 +1100 > > msvcrt: Implement wcscpy_s. > > + > + if(size > numElement) > Is this correct? I think it should be different, maybe if (size<numElement)? > + { > + wcDest[0] = 0; > + return MSVCRT_EINVAL; > + } > + > + if(size > numElement) > This and the one above are the same. > + size = numElement; > + > + memcpy( wcDest, wcSrc, size*sizeof(WCHAR) ); > + > + return 0; > +} > > > >

3 3

Re: [AppDB] Add accessible link to front page
by Detlef Riekenberg Feb. 27, 2008

Feb. 27, 2008

On Mi, 2008-02-27 at 14:18 +0100, Alexander Nicolaysen Sørnes wrote: > Add a 'home' link to the top of the AppDB menu to make the front page > more accessible. > $g = new htmlmenu("AppDB"); > + $g->add('Home', BASE.'index.php'); What is more accessible in "AppDB" -> "Home" compared to "WineHQ Menu" -> "AppDB"? I see no difference. -- By by ... Detlef

3 2

Wineserver crash in inotify code
by Dan Kegel Feb. 27, 2008

Feb. 27, 2008

http://bugs.winehq.org/show_bug.cgi?id=11746 may explain a few mysterious wineserver crashes I saw a few weeks ago. Anyone feel like diving in to this one? It's probably a rat's nest of twisty linked lists, and a node isn't getting removed properly from all the lists it's in when it's freed, or something.

3 2

Re: [Wine] Re: Windows Kernel & Executive implementation
by Volodymyr Shcherbyna Feb. 27, 2008

Feb. 27, 2008

I am not sure that ReacOS is a good example. Quite a big amount of code in ReactOS contains leaked code of Windows (from Windows 2k). Recently I did a research, since I have access to Windows code(code premium subscription), I am able to compare things. 2008/2/23, Fireball <wineforum-user(a)winehq.org>: > > You could have a look at ReactOS about this (www.reactos.org) But anyway, > Wine's way of supporting this will [most probably] be different from > reactos' way. > > > > > > -- with best regards, Volodymyr

4 5

New winetricks 20080227: new verbs vbrun3, vbrun4, vbrun5, vbrun6
by Dan Kegel Feb. 27, 2008

Feb. 27, 2008

Detlef contributed verbs vbrun3 and vbrun4, thanks! And I added vbrun5 and vbrun6 as the preferred synonym for the existing verbs vbvm5 and vbrun60. That should be easier. As always, winetricks is at http://kegel.com/wine/winetricks and its source repository is at http://winezeug.googlecode.com

2 2

Bug for icons in toolbar (and how to deal with this in bugzilla)
by Paul Vriens Feb. 27, 2008

Feb. 27, 2008

Hi, This is about 'autoruns' from SysInternals (Microsoft) The icons on the first row of buttons look fine. All other rows however show the icons below the position they should actually be. I've looked at our bugzilla and found two bugs that look the same: http://bugs.winehq.org/show_bug.cgi?id=6948 http://bugs.winehq.org/show_bug.cgi?id=8813 Both are for different applications. Should I open a new one for 'autoruns' or use one of the existing ones? -- Cheers, Paul.

2 1

Re: msxml3:Implement wcscpy_s (try 4)
by Huw Davies Feb. 27, 2008

Feb. 27, 2008

On Wed, Feb 27, 2008 at 09:11:17PM +1100, Alistair Leslie-Hughes wrote: > Hi, > Corrected the spec file. > > Changelog: > msxml3: Implement wcscpy_s > > Best Regards > Alistair Leslie-Hughes > > From 5438165a1a5b3a2683948b93e34e9017f4958e61 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Wed, 27 Feb 2008 19:58:04 +1100 > Subject: [PATCH] Implement wcscpy_s > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/msvcrt/msvcrt.spec | 1 + > dlls/msvcrt/tests/string.c | 45 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/msvcrt/wcs.c | 41 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 87 insertions(+), 0 deletions(-) Note that the subject line should be 'msvcrt:...'. I guess Alexandre will fix this. Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Wine hostmask for Freenode IRC
by Kai Blin Feb. 27, 2008

Feb. 27, 2008

Hi folks. so what was the process of getting a wine/developer hostmask on freenode? I'll be hanging out on the #gsoc IRC channel, I'd like to make it a bit more obvious for students what project I mentor for. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

4 6

Re: X developer's conference, April 16-18
by Stefan Dösinger Feb. 27, 2008

Feb. 27, 2008

Hi, I'm picking up that topic again. I lost the original mail, so I apologize for the lost in-reply-to references. I think we have a few topics to talk to the X people about. If nobody else volunteers I could go to the conference personally, however, I'd need some support financing the travel costs. However, I'm European, so it might work better for someone local in the US. A few proposed topics: * Relative mouse movements * A few new GL extensions. Only partially concerns Xorg, but I think it is reasonable to present them there in the hope that ATI, Nvidia and Mesa people are there. -> Flat shading vertex colors -> sRGB writing without blending -> Texture rectangles with normalized coords -> GLSL support for some D3D shader instructions(mova, lit) -> More widespread support for a few existing extensions * Other things?

6 6

Re: msxml3: Implemented wcscpy_s (try 3)
by Dmitry Timoshkov Feb. 27, 2008

Feb. 27, 2008

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote: > Corrected comparisons, and error message in test. > diff --git a/dlls/msvcrt/msvcrt.spec b/dlls/msvcrt/msvcrt.spec > index d6cffcb..ebd718c 100644 > --- a/dlls/msvcrt/msvcrt.spec > +++ b/dlls/msvcrt/msvcrt.spec > @@ -761,6 +761,7 @@ > @ cdecl wcscmp(wstr wstr) ntdll.wcscmp > @ cdecl wcscoll(wstr wstr) MSVCRT_wcscoll > @ cdecl wcscpy(ptr wstr) ntdll.wcscpy > +@ cdecl wcscpy_s(wstr long wstr) MSVCRT_wcscpy_s What's happened to the spec entry fix? -- Dmitry.

2 1

.net 1.1 installs now!
by Dan Kegel Feb. 26, 2008

Feb. 26, 2008

Hey, http://bugs.winehq.org/show_bug.cgi?id=11678 is fixed, and VCToolkitSetup.exe now installs for me! Still more to do before .net 1.1 apps run, see http://bugs.winehq.org/show_bug.cgi?id=11742 And there are a few ugly looking nonfatal problems running the .net 1.1 installer, but they can wait...

2 1