February 2008 - Wine-Devel - list.winehq.org

Autoplay considered harmful
by Dan Kegel Feb. 18, 2008

Feb. 18, 2008

http://www.sfgate.com/cgi-bin/article.cgi?f=/c/a/2008/02/15/BU47V0VOH.DTL&t… says that USB devices are being sold with infected autorun apps. "If you plug in, you're already infected," I'd say that's a pretty good argument for not supporting autoplay...

7 7

Re: [advapi32/tests #2] Don't set last error to 0 so we can check if it has changed
by Alexandre Julliard Feb. 18, 2008

Feb. 18, 2008

Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > We test for a last error of 0, so we shouldn't set it to 0 before the > function is called. This however introduces a todo_wine. Is there any reason to believe that last error should be 0 on success? This looks more like a broken test to me. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: include: Add support for executing finally code for exceptions without using a separate function.
by Alexandre Julliard Feb. 18, 2008

Feb. 18, 2008

Robert Shearman <rob(a)codeweavers.com> writes: > The first goal is accomplished by changing the previous two-state > variable of __first into a three-state variable where the third state > is the state in which the finally code is executed in the normal > case. The second goal is accomplished by calling sigsetjmp in > __wine_finally_handler to give the finally code a place to jump back > to after it has finished executing. That can't work, once you longjmp into the finally block you can't longjmp back, since you are no longer inside the function that did the setjmp. -- Alexandre Julliard julliard(a)winehq.org

2 1

iTunes
by Christopher Harvey Feb. 18, 2008

Feb. 18, 2008

What needs to get done for iTunes to work?

3 3

[PATCH] msvcrt/tests: Add more scanf floating-point tests.
by Jānis Rūcis Feb. 18, 2008

Feb. 18, 2008

The included patch adds a couple of scanf floating-point tests to expose a problem with the algorithm. It seems that it doesn't handle negative exponents very well, resulting in single-precision values being off-by-one in the last bit of significant compared to those obtained with the GNU C library or natively on Windows XP. All five tests pass on my Windows XP SP2 system (using a self-compiled msvcrt_crosstest.exe tool). Test 3 and 4 fail with the current source in Git. I will send another patch to this list with a potential fix. (I am not sending these to wine-patches because I'm not sure I should. "wine-devel" sounds about right.) --- dlls/msvcrt/tests/scanf.c | 40 ++++++++++++++++++++++++++++++++++++---- 1 files changed, 36 insertions(+), 4 deletions(-) diff --git a/dlls/msvcrt/tests/scanf.c b/dlls/msvcrt/tests/scanf.c index 65bea46..d5da3f6 100644 --- a/dlls/msvcrt/tests/scanf.c +++ b/dlls/msvcrt/tests/scanf.c @@ -28,7 +28,7 @@ static void test_sscanf( void ) char format[20]; int result, ret; char c; - float res1= -82.6267f, res2= 27.76f, res11, res12; + float orig, res; static const char pname[]=" St. Petersburg, Florida\n"; int hour=21,min=59,sec=20; int number,number_so_far; @@ -64,9 +64,41 @@ static void test_sscanf( void ) ok( result == 12, "sscanf reads %x instead of %x\n", result, 12 ); /* Check float */ - ret = sprintf(buffer,"%f %f",res1, res2); - ret = sscanf(buffer,"%f%f",&res11, &res12); - ok( (res11 == res1) && (res12 == res2), "Error reading floats\n"); + + orig = -82.6267f; + ret = sprintf(buffer, "%f", orig); + ret = sscanf(buffer, "%f", &res); + ok(ret == 1, "Expected 1 float, got %d\n", ret); + ok(res == orig, "Wrote %e (0x%x), but read %e (0x%x)\n", + orig, *(unsigned int *) &orig, res, *(unsigned int *) &res); + + orig = 27.76f; + ret = sprintf(buffer, "%f", orig); + ret = sscanf(buffer, "%f", &res); + ok(ret == 1, "Expected 1 float, got %d\n", ret); + ok(res == orig, "Wrote %e (0x%x), but read %e (0x%x)\n", + orig, *(unsigned int *) &orig, res, *(unsigned int *) &res); + + orig = -6.61589e-2f; + ret = sprintf(buffer, "%e", orig); + ret = sscanf(buffer, "%e", &res); + ok(ret == 1, "Expected 1 float, got %d\n", ret); + ok(res == orig, "Wrote %e (0x%x), but read %e (0x%x)\n", + orig, *(unsigned int *) &orig, res, *(unsigned int *) &res); + + orig = 1.72567e-7f; + ret = sprintf(buffer, "%e", orig); + ret = sscanf(buffer, "%e", &res); + ok(ret == 1, "Expected 1 float, got %d\n", ret); + ok(res == orig, "Wrote %e (0x%x), but read %e (0x%x)\n", + orig, *(unsigned int *) &orig, res, *(unsigned int *) &res); + + orig = 15.483e+3f; + ret = sprintf(buffer, "%e", orig); + ret = sscanf(buffer, "%e", &res); + ok(ret == 1, "Expected 1 float, got %d\n", ret); + ok(res == orig, "Wrote %e (0x%x), but read %e (0x%x)\n", + orig, *(unsigned int *) &orig, res, *(unsigned int *) &res); /* check strings */ ret = sprintf(buffer," %s", pname); -- 1.5.3.8

2 1

programs: add winestartfile for starting files from the unix path (for file managers)
by Vincent Povirk Feb. 18, 2008

Feb. 18, 2008

This is now attempt 4, not that anyone's counting. Adding winelib programs is a bit involved, and I imagine I've screwed something up along the way. If you know how to add them properly, please say something, even if it's to tell me I did it right. This patch adds a winelib program called winestartfile for starting files given the unix path. It attempts to mimic what windows explorer does to start files and provide some visible (gui) feedback when it doesn't work. The idea is that wine.desktop can then be modified to use winestartfile instead of wine, solving the following problems when starting exe files from file managers: * File managers typically do not set the working directory to the directory that contains an exe when they start it. Setting the working directory is the default behavior for windows explorer, and many windows programs rely on it. * File managers naturally use the unix path to start files, and the wine binary passes the unix path along to the exe it starts, rather than translating it to a windows path (this can and probably should also be fixed somewhere else). * Windows explorer always starts exe files with quotes around the path in the command-line, even if the path does not contain spaces. The wine binary does not (and probably should not) add quotes in this situation. A few apps rely on the quotes. See http://bugs.winehq.org/show_bug.cgi?id=5224#c14 -- Vincent Povirk

2 3

Re: inetcomm: Fix compilation on systems that don't support nameless unions.
by Marcus Meissner Feb. 18, 2008

Feb. 18, 2008

On Mon, Feb 18, 2008 at 11:54:22AM +0100, Francois Gouget wrote: > --- > dlls/inetcomm/mimeole.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > diff --git a/dlls/inetcomm/mimeole.c b/dlls/inetcomm/mimeole.c > index a0da6b9..e986e7f 100644 > --- a/dlls/inetcomm/mimeole.c > +++ b/dlls/inetcomm/mimeole.c > @@ -1257,7 +1257,7 @@ static HRESULT WINAPI sub_stream_CopyTo( > ULARGE_INTEGER totalBytesRead; > ULARGE_INTEGER totalBytesWritten; > > - TRACE("(%p)->(%p, %d, %p, %p)\n", iface, pstm, cb.LowPart, pcbRead, pcbWritten); > + TRACE("(%p)->(%p, %d, %p, %p)\n", iface, pstm, cb.u.LowPart, pcbRead, pcbWritten); > > totalBytesRead.QuadPart = 0; > totalBytesWritten.QuadPart = 0; > @@ -1525,7 +1525,7 @@ static HRESULT create_body_offset_list(IStream *stm, const char *boundary, struc > > zero.QuadPart = 0; > hr = IStream_Seek(stm, zero, STREAM_SEEK_CUR, &cur); > - start = cur.LowPart; > + start = cur.u.LowPart; > > do { > hr = IStream_Read(stm, overlap, PARSER_BUF_SIZE, &read); > @@ -1599,7 +1599,7 @@ static body_t *create_sub_body(MimeMessage *msg, IStream *pStm, BODYOFFSETS *off > IMimeBody_Load(mime_body, pStm); > zero.QuadPart = 0; > hr = IStream_Seek(pStm, zero, STREAM_SEEK_CUR, &cur); > - offset->cbBodyStart = cur.LowPart + offset->cbHeaderStart; > + offset->cbBodyStart = cur.u.LowPart + offset->cbHeaderStart; > if(parent) MimeBody_set_offsets(impl_from_IMimeBody(mime_body), offset); > IMimeBody_SetData(mime_body, IET_BINARY, NULL, NULL, &IID_IStream, pStm); > body = new_body_entry(mime_body, msg->next_hbody, parent); > @@ -1629,8 +1629,8 @@ static body_t *create_sub_body(MimeMessage *msg, IStream *pStm, BODYOFFSETS *off > IStream *sub_stream; > ULARGE_INTEGER start, length; > > - start.LowPart = cur->offsets.cbHeaderStart; > - length.LowPart = cur->offsets.cbBodyEnd - cur->offsets.cbHeaderStart; > + start.u.LowPart = cur->offsets.cbHeaderStart; > + length.u.LowPart = cur->offsets.cbBodyEnd - cur->offsets.cbHeaderStart; > create_sub_stream(pStm, start, length, &sub_stream); > sub_body = create_sub_body(msg, sub_stream, &cur->offsets, body); > IStream_Release(sub_stream); > @@ -1674,7 +1674,7 @@ static HRESULT WINAPI MimeMessage_Load( > > zero.QuadPart = 0; > IStream_Seek(pStm, zero, STREAM_SEEK_END, &cur); > - offsets.cbBodyEnd = cur.LowPart; > + offsets.cbBodyEnd = cur.u.LowPart; > MimeBody_set_offsets(impl_from_IMimeBody(root_body->mime_body), &offsets); > > list_add_head(&This->body_tree, &root_body->entry); > There seems to be damage in here, both ^M and lose 0s. Ciao, Marcus

1 0

Re: user32: Check for .ico and .cur magic.
by Dmitry Timoshkov Feb. 18, 2008

Feb. 18, 2008

"Andrew Riedi" <andrewriedi(a)gmail.com> wrote: > +#define ICON_DIB_SIZE 4264 It would be helpful to actually calculate the size instead of hardcoding the magic value. > + handle = LoadImageA(NULL, "icon.ico", IMAGE_CURSOR, 0, 0, LR_LOADFROMFILE); > + ok(handle != NULL, "LoadImage() failed.\n"); > + error = GetLastError(); > + ok(error == 0, "Last error: %u\n", error); > + > + /* Clean up. */ > + ret = DestroyIcon(handle); The fact that LoadImage has returned a not zero handle actually confirms nothing, you need to verify the contents of the loaded image with GetIconInfo. -- Dmitry.

1 0

re: iTunes
by Dan Kegel Feb. 18, 2008

Feb. 18, 2008

E. Savage wrote: > Maarten why not focus on supporting applications that > don't have viable open source solutions first? iTunes doesn't have any alternatives for these functions: - purchasing songs from iTunes Store - activating iPhone - new ipod/iPhone syncing Anybody who buys an iPhone and can't activate it on their Linux PC will blame Linux and think it's crap. Even developers like jwz, I bet; see http://jwz.livejournal.com/494040.html So yeah, iTunes is important. - Dan

2 1

Winnowing the 1.0 bug list
by Dan Kegel Feb. 17, 2008

Feb. 17, 2008

We now have about 100 bugs nominated for fixing in 1.0. Thanks to everybody who nominated bugs. Now it's time to winnow the list a bit. 1.0 bugs should be 'important' somehow, easy to reproduce, and have some chance of actually being fixed by, say, summer. The better understood a bug is, the more likely it is it can be fixed for 1.0, so even less important bugs can be 1.0 bugs if they're well enough understood and a patch is available. Here are a few bugs I'm thinking of deferring, and why: Not important enough http://bugs.winehq.org/show_bug.cgi?id=5807 Mercora IMRadio crashes http://bugs.winehq.org/show_bug.cgi?id=6048 Stokes crashes http://bugs.winehq.org/show_bug.cgi?id=8687 everestpoker and Programmer's Editor don't work http://bugs.winehq.org/show_bug.cgi?id=9288 Armed Assault doesn't load web page http://bugs.winehq.org/show_bug.cgi?id=9895 Alzip crashes Probably not doable by summer http://bugs.winehq.org/show_bug.cgi?id=609 Add BiDi support Not well enough understood: http://bugs.winehq.org/show_bug.cgi?id=6383 Dual-core not being correctly supported Do people agree with those assessments, and are there other bugs nominated for 1.0 that don't quite deserve it? - Dan

1 0

Re: [6/6] wined3d: take alpha from device palette entry for d3d 8 and later
by Stefan Dösinger Feb. 17, 2008

Feb. 17, 2008

Am Montag, 18. Februar 2008 02:37:00 schrieb Alexander Dorofeyev: >/*can ddraw and d3d < 8 surfaces use device's palette (d3d >= 8 feature)?*/ No, they can't, there is no API to access them

2 1

Re: appdb feature request: hide the ugly urls
by Remco Feb. 17, 2008

Feb. 17, 2008

> http://appdb.winehq.org/app/command-conquer-3-tiberium-wars/ > doesn't sound too bad, actually. And if somebody types in > an ambiguous URL, like > http://appdb.winehq.org/app/command-conquer > they should get a list of matching apps. So this is kind of > like a search function rather than a unique ID. > The difference being that apps would normally be > displayed at their shortest unique human-readable URL > rather than by ID #. > This may have an obscure but important benefit: I > read on the web somewhere that it boosts search engine rankings. > (Not that I'd know; I'm way away from that part of google.) > - Dan I'm pretty sure that's just because of the related words in the URL. An additional number doesn't hurt ranking. I know a lot of sites use an ID number and a title. The title makes it easy to see what the link points to. That's a usability benefit of itself. I don't think people should start using the URL bar as a search engine. The AppDB has a nice search engine already. And I think searching for literally all URLs is going to put a lot of strain on the server. Remco ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs

2 1

Usable Wine interface
by Remco Feb. 17, 2008

Feb. 17, 2008

I'd like to add a feature-request (should this go somewhereelse?). What about making a Wine GUI to behave more like emulators likeVirtualBox. It's extremely hard right now to get Wine in desktop mode.It would be nice if you could start Wine as an application, which opensup a window like this: http://xs224.xs.to/xs224/08081/mockup918.png (ignore the virtualbox-stuff) And if you start one of those prefixes, it by default opens a WineDesktop with a simple Taskbar & Start-menu. Somewhere in theStart-menu could be the option to switch to desktop integration mode.There could also be an option to run the Wine Desktop full-screen. Likethis: http://xs224.xs.to/xs224/08081/winedesktop771.png (forgive my GIMP skills) I believe this would be very good for usability. Desktop mode is morestable than seamless mode, yet it's hidden in winecfg. This kind of UIalso exposes the prefix-functionality in a transparent way. Wouldn'tthat be a nice 1.0 polishing idea? Remco ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs

3 2

Re: Next big app(s) to try?
by Remco Feb. 17, 2008

Feb. 17, 2008

I'd say, of the work-related apps, definitely MS Office 2007 (especially Outlook) and Internet Explorer 6 and 7. IE7 needs a lot of work still. IE6 doesn't break on any Wine bugs AFAIK, but needs a special environment to install correctly. A little Wine magic might help here. IE is one of the few native Windows parts that cannot reasonably be replaced. Web developers need to test their sites in the real thing. Of the fun-related apps, a few press-generating apps would be Crysis DX10-mode and iTunes (iPod sync). Remco ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs

2 1

Re: appdb feature request: hide the ugly urls
by Remco Feb. 17, 2008

Feb. 17, 2008

----- Original Message ---- > From: Dan Kegel <dank(a)kegel.com> > To: wine-devel <wine-devel(a)winehq.org> > Sent: Sunday, February 17, 2008 6:55:06 PM > Subject: appdb feature request: hide the ugly urls > > How hard would it be for the appdb to support > more readable URLs for vendors and applications? e.g. > Adobe Premiere is currently at > http://appdb.winehq.org/objectManager.php?sClass=application&iId=128 > but it'd be so slick to see instead > http://appdb.winehq.org/adobe/premiere > > Believe it or not, that little change would make the appdb > less scary for newcomers. > - Dan That's relatively easy to do with mod_rewrite. But it would have to be something like: http://appdb.winehq.org/app/128/adobe-premiere.html All the info is still in the URL (which mod_rewrite can extract), but it does look less scary. Remco ____________________________________________________________________________________ Be a better friend, newshound, and know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ

4 5

Re: dlls/shell32/pidl.c -- adjust to unsignedness of a type
by Alexandre Julliard Feb. 17, 2008

Feb. 17, 2008

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > @@ -109,7 +109,7 @@ BOOL WINAPI ILGetDisplayNameExW(LPSHELLF > return FALSE; > } > > - if (type >= 0 && type <= 2) > + if (type <= 2) > { > switch (type) > { The test should probably be removed completely since there's already a default for it in the switch() that follows. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/6] ddraw: fix executebuffer branching with non-zero offset
by Stefan Dösinger Feb. 17, 2008

Feb. 17, 2008

Am Montag, 18. Februar 2008 02:36:35 schrieb Alexander Dorofeyev: > Fixes a crash in Moto Racer 2. > --- > dlls/ddraw/executebuffer.c | 10 ++++++++-- > 1 files changed, 8 insertions(+), 2 deletions(-) The patches look good to me

1 0

appdb feature request: hide the ugly urls
by Dan Kegel Feb. 17, 2008

Feb. 17, 2008

How hard would it be for the appdb to support more readable URLs for vendors and applications? e.g. Adobe Premiere is currently at http://appdb.winehq.org/objectManager.php?sClass=application&iId=128 but it'd be so slick to see instead http://appdb.winehq.org/adobe/premiere Believe it or not, that little change would make the appdb less scary for newcomers. - Dan

1 0

Re: dlls/msi/streams.c -- simplify and constify
by James Hawkins Feb. 17, 2008

Feb. 17, 2008

On Nov 3, 2007 1:10 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > While removing the dead code I noticed that we can actually also > strengthen the const-ness of this function. > > Gerald > > ChangeLog: > Remove a check which never could trigger (due to the domain of the > variable in question) and increase const-ness of STREAMS_CreateView(). > > Index: dlls/msi/streams.c > =================================================================== > RCS file: /home/wine/wine/dlls/msi/streams.c,v > retrieving revision 1.7 > diff -u -3 -p -r1.7 streams.c > --- dlls/msi/streams.c 18 Oct 2007 13:00:57 -0000 1.7 > +++ dlls/msi/streams.c 3 Nov 2007 18:06:27 -0000 > @@ -430,7 +430,7 @@ static UINT add_streams_to_table(MSISTRE > return count; > } > > -UINT STREAMS_CreateView(MSIDATABASE *db, MSIVIEW **view) > +UINT STREAMS_CreateView(const MSIDATABASE *db, MSIVIEW **view) > { > MSISTREAMSVIEW *sv; > > @@ -444,9 +444,6 @@ UINT STREAMS_CreateView(MSIDATABASE *db, > sv->db = db; > sv->num_rows = add_streams_to_table(sv); > > - if (sv->num_rows < 0) > - return ERROR_FUNCTION_FAILED; > - > *view = (MSIVIEW *)sv; > > return ERROR_SUCCESS; > This change is wrong. If you'd actually read what the code intended to do instead of just fixing warnings, you'd see that add_streams_to_table returns -1 on error. While the check for < 0 is not correct, removing the check entirely is wrong. The check should be if (sv->num_rows == -1) return ERROR_FUNCTION_FAILED. -- James Hawkins

2 2

Re: Autoplay considered harmful
by Remco Feb. 17, 2008

Feb. 17, 2008

Vista (and I think XP too) ask whether you want to start the Autorun program, or do a few other actions (open explorer, copy disk, etc). Remco ----- Original Message ---- > From: Evil Jay <wine(a)eternaldusk.com> > To: Steven Edwards <winehacker(a)gmail.com> > Cc: wine-devel <wine-devel(a)winehq.org>; Dan Kegel <dank(a)kegel.com> > Sent: Saturday, February 16, 2008 5:44:15 PM > Subject: Re: Autoplay considered harmful > > The purist in me says that WINE should not improve on Windows - it > should behave the same way, warts and all. If I had a vote, I'd vote to > enable it by default, but give the user an easy way to disable it in > winecfg. (And I'd immediately disable it the first time I ran Winecfg!) > > But, whatever you guys decide to do is cool - as long as you keep > cranking out this great package! :) > > -Jesse > > > > Steven Edwards wrote: > > On Feb 16, 2008 8:58 AM, Dan Kegel wrote: > > > >> > http://www.sfgate.com/cgi-bin/article.cgi?f=/c/a/2008/02/15/BU47V0VOH.DTL&t… > >> says that USB devices are being sold with infected > >> autorun apps. "If you plug in, you're already infected," > >> > >> I'd say that's a pretty good argument for not supporting autoplay... > >> > > > > I was actually thinking about this today. The right method would be to > > use HAL notification events to prompt the user if they want to autorun > > when sticking a new cdrom in. There could even be warning text in the > > dialog so that if it pops up with other device insertion, the user > > would know that it could be a virus. > > > > > > > > ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs

5 4

Re: tools: add a wrapper script for starting files from file managers and make wine.desktop use it
by Vincent Povirk Feb. 16, 2008

Feb. 16, 2008

Please do not commit this patch as explained in comment 18 of bug 5224: http://bugs.winehq.org/show_bug.cgi?id=5224#c18 Windows explorer's default behavior is to always start programs with double quotes around their filenames, even if the filename does not contain a space. Apparently, this is impossible (or more difficult than it's worth) to do in a shell script so I will need to rewrite this as a winelib program. On Feb 13, 2008 7:44 PM, Vincent Povirk <madewokherd+d41d(a)gmail.com> wrote: > This is an attempt to solve the problems with double-clicking .exe > files from file managers. > > The patch adds a script named winestartfile that mimics what happens > on windows when a file is double-clicked in explorer. It starts the > file using start.exe with the full path to the file and in the > directory that contains it. > > It also modifies the wine.desktop shortcut to use that script when > opening .exe files. > > My previous attempt at this incorrectly ran start without giving a > full path (so that if a file named start.exe exists in the current > path, it will take precedence) and probably tried to change too many > things at once. > > -- > Vincent Povirk > -- Vincent Povirk

1 0

New winetricks 20080216: fixed comctl32 override, hide winetrickscache, add --version option
by Dan Kegel Feb. 16, 2008

Feb. 16, 2008

Austin nudged me into fixing comctl32 override, which has been broken since wine added support for sxs assemblies. He also was the third person to suggest hiding winetrickscache, so I guess it's what people want. And I added a --version option for a guy who said it would make packaging easier. As always, it's available at http://kegel.com/wine/winetricks and the svn repository is http://code.google.com/p/winezeug/ -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: WineD3D: add separate alpha blend support 3/3
by Stefan Dösinger Feb. 16, 2008

Feb. 16, 2008

Am Samstag, 16. Februar 2008 17:29:31 schrieb Roderick Colenbrander: > Hi, > > This patch adds support for separate alpha blend one of the last > unimplemented D3D9 features. Here are a few suggestions: *) Setting WINED3DPMISCCAPS_SEPARATEALPHABLEND in directx.c should only be done if the extension is supported *) after the "GL_LINE_SMOOTH needs GL_BLEND to work, according to the", WINED3DRS_SEPARATEALPHABLENDENABLE should probably be removed from the if block. I don't think that blending should be enabled if the WINED3DRS_ALPHABLENDENABLE is off. A test would be helpful for certainty. *) The code translating the separate blending settings could be moved into the if(stateblock->renderState[WINED3DRS_SEPARATEALPHABLENDENABLE]) block. That way they are only executed if they're needed(The compiler may take care of that though) *) The separate blend states should be grouped with the alpha states, ie, set the representative to STATE_RENDER(WINED3DRS_ALPHABLENDENABLE) instead of STATE_RENDER(WINED3DRS_SEPARATEALPHABLENDENABLE). Not doing that should not cause any rendering problems because the whole alpha blend states are set every time, but grouping them will improve performance. (e.g., if alphablendenable and separatealphaenable are changed state_blend is only executed once, not twice) *) The blendop is currently not reapplied if WINED3DRS_SEPARATEALPHABLENDENABLE is changed. One solution is to group the blendops with alphablend and move the code from state_blendop to state_blend. A better way is to make this a one-way dependency from state_alpha to state_blend. Compare STATE_RENDER(WINED3DRS_LIGHTING) and STATE_VDECL for a reference.

1 0

X developer's conference, April 16-18
by Dan Kegel Feb. 16, 2008

Feb. 16, 2008

http://www.x.org/wiki/Events/XDC2008 Seems like Wine might want a representative. What issues would we want to bring up there? - relative mouse motion events ...? - Dan

3 3

MSG_PEEK race in urlmon_test?
by Francois Gouget Feb. 16, 2008

Feb. 16, 2008

When I run the urlmon_test test the kernel (2.6.22.9) has this to say: Feb 16 05:53:54 amboise kernel: TCP(urlmon_test.exe:9836): Application bug, race in MSG_PEEK. Does anyone know what's up with that? Maybe someone who knows more than me about urlmon? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Hiroshima '45 - Czernobyl '86 - Windows '95

1 0