February 2008 - Wine-Devel - list.winehq.org

Re: wined3d: fix memcpy with wrong size parameter to simple assignment in GetScissorRect
by Stefan Dösinger Feb. 14, 2008

Feb. 14, 2008

Am Mittwoch, 13. Februar 2008 21:58:39 schrieb Rico Schüller: > Hi, > > this fixes the GetScissorRect function in wined3d. This is required for > the game Gothic3 where the misbehavior is seen. The patch looks ok to me

1 0

Weird failure in kernel32 volume test
by Maarten Lankhorst Feb. 14, 2008

Feb. 14, 2008

Hi all, The latest update of trying to be the second person for which all tests succeed. I sent a bunch of patches that make some tests pass. At the moment I have 3 failures on a clean wineprefix, with no icons on my desktop, and with wine in native window mode on kde 3.5.x: user32: 'msg' test fails. The famous 'win' test passes. kernel32: I get a very weird bug on the 'volume' test. It only occurs when I run my mini script for running the tests. I have absolutely no idea why I get ERROR_FILE_NOT_FOUND on FindFirstVolumeA on the first time I run the whole testsuite, and not successive runs. Anyone has experienced the same, or have an idea what is going on? msi: multi-sz failure in msi install, I did a todo_wine on it so it doesn't stop the build. It seems to be a recent failure though because I know that it didn't bomb out on install a few days ago. Anyone else has some tests that consistently fail on make test? Cheers, Maarten.

4 3

OUTB() and friends on Win32 and .sys files(Resent)
by Uwe Bonnes Feb. 14, 2008

Feb. 14, 2008

Hallo, some programm with source uses giveio.sys to access the parallel port. You can find the source for giveio.sys e.g. in the avrdude package. We have code in dlls/winedos/ppdev.c to emulate the directed access on the parallel port to accesses to /dev/ppdev. However this code is not called for WIN32 code. So after starting giveio with loaddrv.exe supplied with giveio > wine loaddrv.exe start giveio starting giveio... ok. > wine javr.exe crashes when the outb access happens: javr [<filename>] [-p<port>] [-f<fusefilename>] [-e<eepromfilename>] [-L] [-V] Allocated flash buffer of 128K Using giveio.sys to gain port access to 0x378 trace:seh:raise_exception code=c0000096 flags=0 addr=0x4014b6 trace:seh:raise_exception eax=00000000 ebx=00000000 ecx=00000378 edx=00000378 esi=00000378 edi=00110388 trace:seh:raise_exception ebp=0072fe50 esp=0072fe50 cs=0073 ds=007b es=007b fs=0033 gs=003b flags=00010246 trace:seh:call_stack_handlers calling handler at 0x7eddc5bc code=c0000096 flags=0 trace:seh:MSVCRT_signal (4, (nil)) wine: Unhandled privileged instruction at address 0x4014b6 (thread 0011), starting debugger... trace:seh:start_debugger Starting debugger "winedbg --auto 16 56" trace:seh:call_stack_handlers handler at 0x7eddc5bc returned 1 Unhandled exception: privileged instruction in 32-bit code (0x004014b6). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:004014b6 ESP:0072fe50 EBP:0072fe50 EFLAGS:00010246( - 00 -RIZP1) EAX:00000000 EBX:00000000 ECX:00000378 EDX:00000378 ESI:00000378 EDI:00110388 Stack dump: 0x0072fe50: 0072fe58 0040151a 0072fe88 00406ccf 0x0072fe60: 00000378 00000000 00000000 00403411 0x0072fe70: 00000001 00110388 0072fe88 0040a3ef 0x0072fe80: 0040a3ef 00000001 0072fec8 004025e4 0x0072fe90: 00000378 00000378 00110048 0040255c 0x0072fea0: 7ed5ff48 7ffdf000 0072fec8 7ed30f5c Backtrace: =>1 0x004014b6 outb+0x6(value=0x0, port=0x378) [/spare/bon/jtagprog/win/javr-2.8/ppiwin.c:311] in javr (0x0072fe50) MS msvcrt.dll also supplies outb(). What is the policy to handle outb() and friends? Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Re: Resend pdh[3:3]: remove unnecessary test done in PdhLookupPerfNameByIndexW
by Hans Leidekker Feb. 14, 2008

Feb. 14, 2008

On Thursday 14 February 2008 09:57:32 am Jeff Latimer wrote: > + machineW = pdh_strdup_aw( machine ); > + > + if (!(ret = PdhLookupPerfNameByIndexW( machineW, index, bufferW, &sizeW ))) In the unlikely event that pdh_strdup_aw fails the query will be run on the local machine instead of the remote machine. Please check for allocation failures like most other functions in there do. -Hans

3 2

[advapi32/tests] Don't crash tests for NT4
by Paul Vriens Feb. 14, 2008

Feb. 14, 2008

Hi, (Deliberately sent here and not to wine-patches). Hopefully someone can shed some light on this. I need this patch to have the security tests not crash on NT4. The part about the missing function is obvious. What is not so obvious though is that when I leave the LocalFree(NewAcl) in, the test crash. If I only do the LocalFree on success (as stated btw on MSDN for this function) this test doesn't crash. AFAIK LocalFree deals with passed NULL pointers so there must be something else going on. Changelog Don't crash tests for NT4 -- Cheers, Paul.

1 0

ddraw / wined3d fighting over the resolution!
by Peter Dons Tychsen Feb. 14, 2008

Feb. 14, 2008

Hi Stefan/Devs. The funny old game "Insane" has a resolution bug when it exits. I am not sure exactly how to fix this. 1) It call SetDisplayMode() - switches from 1280 x 1024 -> 640 x 480. OK. 2) It creates a 3D surface which starts the SwapChain - swapchain saves current resolution. 3) Exit. It calls RestoreDisplayMode() - switches back to 1280 x 1024. OK. 4) SwapChain is destroyed. Switches "back" to 640 x 480 ! BAD! I presume the code guesses that the caller does this in another sequence (and it does work fine in other sequences). Why does the SwapChain-destroy function play around with the resolution at all. Is that really necessary? I think it should not do it if the caller is ddraw at least. How do i fix this? Thanks, /pedro

2 1

Almost done...
by Maarten Lankhorst Feb. 13, 2008

Feb. 13, 2008

Hi all, Right now I got down to only the user32 msg test failing (minus the todo's). I solved the user32 win test with a very high-tech solution: Remove all icons from my desktop, which prevents the stupid file description popup from failing the user32 win test. The other way would be to run it in a wine desktop which would also prevent this (I got no failures on runtest, except the todo's). The msg tests are more difficult. For some reason I accidentally passed them once, when I had the debug scrolling on. But after that there were always failures on my pc. Is there any way to sync those so that it is less prone to timing issues? Cheers, Maarten.

1 0

Re: d3d: Add a slight delay before testing the ddraw and d3d9 visual tests
by Peter Dons Tychsen Feb. 13, 2008

Feb. 13, 2008

OK. I still think he should put a FIXME remark in the test-case, and document why Sleep() is needed. Someone might fix the driver someday. The only reason i yelled "alert!", is that i have seen so much bad code which has come to a state where the are Sleep(143) here and Sleep(1332) there, where nobody can remember why they are there and what the Sleep count represents (most of the time no-one ever knew! :-)). In the mean time, the real bugs just getter harder to find, as they are covered by all the messy Sleeps(). I see allot of this kind of yap in telecom embedded software (mobile phones etc.). In this case Maarten probably knows what he is doing (he usually does). But thanks for the follow up! And now i will go to Sleep(). Thanks, /p On Wed, 2008-02-13 at 11:28 +0100, Stefan Dösinger wrote: > Am Mittwoch, 13. Februar 2008 03:11:24 schrieb Peter Dons Tychsen: > > Eh, this does not seem like a proper way to get a unit test to pass. > > > > Sleep()... that leads to the dark side! :-) > I talked to Maarten on IRC about this. The problem seems to be that his > monitor takes ages to mode switch, but ChangeDisplaySettings returns before > this modeswitch is done. Also the opengl driver attempts to draw before the > setup is ready, which fails and causes the test failures. > > So it sounds like a driver bug which will only affect the tests(since games > draw repeatedly and do not care if the first few frames do not render > properly)

1 0

Re: [PATCH] include: add ISampleGrabber interface
by Lei Zhang Feb. 13, 2008

Feb. 13, 2008

On Feb 13, 2008 3:03 PM, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > This patch adds the ISampleGrabber interface, also needed by IMediaDet. > Bah, let me try again. Just realized I forgot to pass -n to git format-patch as well.

1 0

Re: msxml3: Implement IXMLDOMDocument IDispatch interface
by Alistair Leslie-Hughes Feb. 13, 2008

Feb. 13, 2008

Hi, Was there anything wrong with this patch? Dont commit this patch if nothing is wrong. I will submit a series of patches, that will include these changes. Best Regards Alistair Leslie-Hughes "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:fnchqv$a5r$1(a)ger.gmane.org... > Hi, > > Fixes bug http://bugs.winehq.org/show_bug.cgi?id=11257 > > Changelog: > msxml3: Implement IXMLDOMDocument IDispatch interface > > Best Regards > Alistair Leslie-Hughes > -------------------------------------------------------------------------------- > From 7cc5228684ed6d9aaace829cc1b8ebb43e5f4325 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Fri, 25 Jan 2008 22:34:36 +1100 > Subject: [PATCH] Implement IXMLDOMDocument IDispatch interface > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/msxml3/domdoc.c | 53 +++++++++++++++++++++++++++++++++------ > dlls/msxml3/main.c | 58 > +++++++++++++++++++++++++++++++++++++++++++ > dlls/msxml3/msxml_private.h | 8 ++++++ > 3 files changed, 111 insertions(+), 8 deletions(-) > > diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c > index 06388c8..9d6b94b 100644 > --- a/dlls/msxml3/domdoc.c > +++ b/dlls/msxml3/domdoc.c > @@ -416,16 +416,29 @@ static ULONG WINAPI domdoc_Release( > > static HRESULT WINAPI domdoc_GetTypeInfoCount( IXMLDOMDocument2 *iface, > UINT* pctinfo ) > { > - FIXME("\n"); > - return E_NOTIMPL; > + domdoc *This = impl_from_IXMLDOMDocument2( iface ); > + > + TRACE("(%p)->(%p)\n", This, pctinfo); > + > + *pctinfo = 1; > + > + return S_OK; > } > > static HRESULT WINAPI domdoc_GetTypeInfo( > IXMLDOMDocument2 *iface, > UINT iTInfo, LCID lcid, ITypeInfo** ppTInfo ) > { > - FIXME("\n"); > - return E_NOTIMPL; > + domdoc *This = impl_from_IXMLDOMDocument2( iface ); > + HRESULT hr; > + > + TRACE("(%p)->(%u %u %p)\n", This, iTInfo, lcid, ppTInfo); > + > + hr = get_typeinfo(IXMLDOMDocument2_tid, ppTInfo); > + if(SUCCEEDED(hr)) > + ITypeInfo_AddRef(*ppTInfo); > + > + return hr; > } > > static HRESULT WINAPI domdoc_GetIDsOfNames( > @@ -436,8 +449,21 @@ static HRESULT WINAPI domdoc_GetIDsOfNames( > LCID lcid, > DISPID* rgDispId) > { > - FIXME("\n"); > - return E_NOTIMPL; > + domdoc *This = impl_from_IXMLDOMDocument2( iface ); > + ITypeInfo *typeinfo; > + HRESULT hr; > + > + TRACE("(%p)->(%s %p %u %u %p)\n", This, debugstr_guid(riid), > rgszNames, cNames, > + lcid, rgDispId); > + > + if(!rgszNames || cNames == 0 || !rgDispId) > + return E_INVALIDARG; > + > + hr = get_typeinfo(IXMLDOMDocument2_tid, &typeinfo); > + if(SUCCEEDED(hr)) > + hr = ITypeInfo_GetIDsOfNames(typeinfo, rgszNames, cNames, > rgDispId); > + > + return hr; > } > > > @@ -452,8 +478,19 @@ static HRESULT WINAPI domdoc_Invoke( > EXCEPINFO* pExcepInfo, > UINT* puArgErr) > { > - FIXME("\n"); > - return E_NOTIMPL; > + domdoc *This = impl_from_IXMLDOMDocument2( iface ); > + ITypeInfo *typeinfo; > + HRESULT hr; > + > + TRACE("(%p)->(%d %s %d %d %p %p %p %p)\n", This, dispIdMember, > debugstr_guid(riid), > + lcid, wFlags, pDispParams, pVarResult, pExcepInfo, puArgErr); > + > + hr = get_typeinfo(IXMLDOMDocument2_tid, &typeinfo); > + if(SUCCEEDED(hr)) > + hr = ITypeInfo_Invoke(typeinfo, &(This->lpVtbl), dispIdMember, > wFlags, pDispParams, > + pVarResult, pExcepInfo, puArgErr); > + > + return hr; > } > > > diff --git a/dlls/msxml3/main.c b/dlls/msxml3/main.c > index 62bf2b5..41afbe6 100644 > --- a/dlls/msxml3/main.c > +++ b/dlls/msxml3/main.c > @@ -21,6 +21,8 @@ > > #include "config.h" > > +#define COBJMACROS > + > #include <stdarg.h> > #include "windef.h" > #include "winbase.h" > @@ -34,6 +36,61 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(msxml); > > + > +static ITypeLib *typelib; > +static ITypeInfo *typeinfos[LAST_tid]; > + > +static REFIID tid_ids[] = { > + &IID_IXMLDOMDocument2 > +}; > + > +HRESULT get_typeinfo(enum tid_t tid, ITypeInfo **typeinfo) > +{ > + HRESULT hres; > + > + if(!typelib) { > + ITypeLib *tl; > + > + hres = LoadRegTypeLib(&LIBID_MSXML2, 3, 0, LOCALE_SYSTEM_DEFAULT, > &tl); > + if(FAILED(hres)) { > + ERR("LoadRegTypeLib failed: %08x\n", hres); > + return hres; > + } > + > + if(InterlockedCompareExchangePointer((void**)&typelib, tl, NULL)) > + ITypeLib_Release(tl); > + } > + > + if(!typeinfos[tid]) { > + ITypeInfo *typeinfo; > + > + hres = ITypeLib_GetTypeInfoOfGuid(typelib, tid_ids[tid], > &typeinfo); > + if(FAILED(hres)) { > + ERR("GetTypeInfoOfGuid failed: %08x\n", hres); > + return hres; > + } > + > + if(InterlockedCompareExchangePointer((void**)(typeinfos+tid), > typeinfo, NULL)) > + ITypeInfo_Release(typeinfo); > + } > + > + *typeinfo = typeinfos[tid]; > + return S_OK; > +} > + > +static void process_detach(void) > +{ > + if(typelib) { > + unsigned i; > + > + for(i=0; i < sizeof(typeinfos)/sizeof(*typeinfos); i++) > + if(typeinfos[i]) > + ITypeInfo_Release(typeinfos[i]); > + > + ITypeLib_Release(typelib); > + } > +} > + > HRESULT WINAPI DllCanUnloadNow(void) > { > FIXME("\n"); > @@ -53,6 +110,7 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD > fdwReason, LPVOID lpv) > case DLL_PROCESS_DETACH: > #ifdef HAVE_LIBXML2 > xmlCleanupParser(); > + process_detach(); > #endif > break; > } > diff --git a/dlls/msxml3/msxml_private.h b/dlls/msxml3/msxml_private.h > index 8d79d2e..c7d97a1 100644 > --- a/dlls/msxml3/msxml_private.h > +++ b/dlls/msxml3/msxml_private.h > @@ -91,4 +91,12 @@ extern HRESULT DOMDocument_create( IUnknown *pUnkOuter, > LPVOID *ppObj ); > extern HRESULT SchemaCache_create( IUnknown *pUnkOuter, LPVOID *ppObj ); > extern HRESULT XMLDocument_create( IUnknown *pUnkOuter, LPVOID *ppObj ); > > +/* typelibs */ > +enum tid_t { > + IXMLDOMDocument2_tid, > + LAST_tid > +}; > + > +extern HRESULT get_typeinfo(enum tid_t tid, ITypeInfo **typeinfo); > + > #endif /* __MSXML_PRIVATE__ */ > -- > 1.5.3.7 > > -------------------------------------------------------------------------------- > >

1 0

[PATCH] Environment variable to specify X11 window for desktop
by Timothy Lee Feb. 13, 2008

Feb. 13, 2008

Dear all, The attached patch allows the WINE desktop to be embedded within an existing X11 window, and is similar to the windowed mode in WINE. I've tested this feature using MS PowerPoint Viewer 2007, so that a fullscreen slideshow can be fitted inside any X11 window. Regards, Timothy Lee

2 1

Re: user32: correct the caption bar and it's buttons' sizes
by Peter Oberndorfer Feb. 13, 2008

Feb. 13, 2008

On Mittwoch 13 Februar 2008, Divan Burger wrote: > What is the problem without the patch? is the caption bar drawn too high 1 pixel? I ask because i have a patch that restores the 1 pixel high line between the caption bar and the client area (and at the same time decreases the height of the caption bar) see it attached for the NC_DrawXXXButton functions: you also need to update hittest calculation else the wrong buttons are activated. For example when you press the mouse down on the left side of the close button, but maximize gets activated > case SM_CYCAPTION: > if (!spi_loaded[SPI_NONCLIENTMETRICS_IDX]) load_nonclient_metrics(); >- return nonclient_metrics.iCaptionHeight + 1; >+ return nonclient_metrics.iCaptionHeight; this breaks a test in sysparams.c:2416 ok_gsm( SM_CYCAPTION, ncm.iCaptionHeight+1); and 5 other tests Greetings Peter

1 0

missed systray patches
by Kirill K. Smirnov Feb. 13, 2008

Feb. 13, 2008

Hello, Is there anything wrong with the serie of patches? systray[0/4]: systray improvements [try 2] http://www.winehq.org/pipermail/wine-patches/2008-February/049772.html -- Kirill

1 0

Re: Fixing the last failing tests
by Peter Dons Tychsen Feb. 13, 2008

Feb. 13, 2008

Hello M. What is wrong with detecting the version, and branching the test code accordingly? Other tests do that IIRC. I think that is a better solution, if the version selector in winecfg is still going to be meaningful (registry). How about fixing the functions as well (like IsWindowUnicode), so it returns the correct data according to the version in winecfg (registry). However, i do like the irony in your example :-) /pedro On Tue, 2008-02-12 at 18:09 -0800, Maarten Lankhorst wrote: > Hi all, > > I'm very close to passing the whole wine conformance suite on my pc. > The only tests failing are in user32. These tests are failing in any > version of windows though. How do I make them pass on at least 1 > version of windows and wine? Would patches to make it run on xp and > wine be accepted? > > And if I can succeed with that, how do I make it work with other > versions of windows as well. > > Cheers, > Maarten. > > An example is IsWindowUnicode. It always returns TRUE on XP, but it > won't do that on 9x. That would mean something like: > ok(IsWindowUnicode() || !IsWindowUnicode(), "How can this fail?"); > >

3 2

How is the testsuite built for windows
by Maarten Lankhorst Feb. 13, 2008

Feb. 13, 2008

Hi all, I'm trying to get the tests to run in windows, but I'm not sure how to build them. Any attempt to do mingw cross compiling fails badly. Who managed to compile all wine tests for windows, and how is it done? Cheers, Maarten.

3 2

Re: [PATCH #1] wininet: Added beginning support for HTTP cache files.
by Robert Shearman Feb. 13, 2008

Feb. 13, 2008

Jacek Caban wrote: > + /* FIXME: Better check, when we have to create the cache file */ > + if(bSuccess && (lpwhr->hdr.dwFlags & INTERNET_FLAG_NEED_FILE)) { > + WCHAR url[INTERNET_MAX_URL_LENGTH]; > + WCHAR cacheFileName[MAX_PATH+1]; > + BOOL b; > + > + b = HTTP_GetRequestURL(lpwhr, url); > + if(!b) { > + WARN("Could not get URL\n"); > + goto lend; > + } > + > + b = CreateUrlCacheEntryW(url, lpwhr->dwContentLength > 0 ? lpwhr->dwContentLength : 0, NULL, cacheFileName, 0); > + if(b) { > + lpwhr->lpszCacheFile = WININET_strdupW(cacheFileName); > + lpwhr->hCacheFile = CreateFileW(lpwhr->lpszCacheFile, GENERIC_WRITE, FILE_SHARE_READ|FILE_SHARE_WRITE, > + NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL); > + if(lpwhr->hCacheFile == INVALID_HANDLE_VALUE) { > + WARN("Could not create file: %u\n", GetLastError()); > + lpwhr->hCacheFile = NULL; > + } > + }else { > + WARN("Could not create cache entry: %08x\n", GetLastError()); > + } > + } > > It may be beyond the scope of your patch, but you're creating the cache file without committing the entry elsewhere so that it can be found at a later time. According to MSDN, this should be done in HTTP_FinishedReading. -- Rob Shearman

1 0

Re: d3d: Add a slight delay before testing the ddraw and d3d9 visual tests
by Peter Dons Tychsen Feb. 13, 2008

Feb. 13, 2008

Eh, this does not seem like a proper way to get a unit test to pass. Sleep()... that leads to the dark side! :-) Why does it need a Sleep()? If its failing on Wine, then shouldn't it be fixed in the libs? And if its on orig-winxp-vista then there must be a better way to wait? Or no? The string "This makes the tests pass on my pc" isn't very good either. What system? In general, introducing magic Sleep() values in code is not a good idea. If the test system is stressed, you will start getting failures again = bad idea. /p On Wed, 2008-02-13 at 02:26 +0100, Stefan Dösinger wrote: > Am Mittwoch, 13. Februar 2008 02:25:30 schrieb Maarten Lankhorst: > > This makes the tests pass on my pc. > > d3d8 might need it as well > >

3 2

Re: Patch: create a WinHttpDetectAutoProxyConfigUrl function
by Dmitry Timoshkov Feb. 13, 2008

Feb. 13, 2008

"Joshua Hudson" <joshudson(a)gmail.com> wrote: > --- wine-0.9.54/dlls/winhttp/winhttp.spec 2008-02-11 20:54:39.000000000 > -0800 > +++ wine-0.9.54/dlls/winhttp/winhttp.spec.bak 2008-02-11 20:52:39.000000000 > -0800 The patch is wrapped. > @@ -8,7 +8,7 @@ > @ stub WinHttpConnect > @ stub WinHttpCrackUrl > @ stub WinHttpCreateUrl > -@ stdcall WinHttpDetectAutoProxyConfigUrl(long ptr) > +@ stub WinHttpDetectAutoProxyConfigUrl And this part seems to be reverted. -- Dmitry.

1 0

Alsa spitting out warnings every time Wine runs.
by Peter Dons Tychsen Feb. 13, 2008

Feb. 13, 2008

Hi Maarten & Devs. Great to see that audio is so much better in Wine now. But.... On fedora core 6 and 8 i get this every time i start Wine: ALSA lib conf.c:3949:(snd_config_expand) Unknown parameters 0 ALSA lib pcm.c:2145:(snd_pcm_open_noupdate) Unknown PCM default:0 ALSA lib conf.c:3949:(snd_config_expand) Unknown parameters 0 ALSA lib pcm.c:2145:(snd_pcm_open_noupdate) Unknown PCM default:0 I think its harmless, but what do you it means? How do i stop it? Should i fix it in Wine or Alsa? /p

2 1

Fwd: Congratulation!!!
by Maarten Lankhorst Feb. 13, 2008

Feb. 13, 2008

Hooray! I won the Microsoft e-mail award! And I thought my wine efforts would go unnoticed, but here I am winning the grand prize! ---------- Forwarded message ---------- From: marinamg(a)esplugues.org <marinamg(a)esplugues.org> Date: 12 feb. 2008 18:33 Subject: Congratulation!!! To: undisclosed-recipients Microsoft Award Team 22 Garden Close,PE9 2YP, London Date: 13th Feb 2008. Finally, Today we announce this year winners of the MICROSOFT E-MAIL AWARD held on the 13/02/2008, Your Email has won (£1,000,000.00) (CSC) Claims Security Code: CSC-74162007-04-LV-UK,Your Ref: MSC990/678. Contact your Fudiciary agent Mr. Steve Wallace along with your information via email. Sir. John Smith Email: johnsmithm(a)live.com

2 1

Fixing the last failing tests
by Maarten Lankhorst Feb. 12, 2008

Feb. 12, 2008

Hi all, I'm very close to passing the whole wine conformance suite on my pc. The only tests failing are in user32. These tests are failing in any version of windows though. How do I make them pass on at least 1 version of windows and wine? Would patches to make it run on xp and wine be accepted? And if I can succeed with that, how do I make it work with other versions of windows as well. Cheers, Maarten. An example is IsWindowUnicode. It always returns TRUE on XP, but it won't do that on 9x. That would mean something like: ok(IsWindowUnicode() || !IsWindowUnicode(), "How can this fail?");

2 1

Re: d3d: Add a slight delay before testing the ddraw and d3d9 visual tests
by Stefan Dösinger Feb. 12, 2008

Feb. 12, 2008

Am Mittwoch, 13. Februar 2008 02:25:30 schrieb Maarten Lankhorst: > This makes the tests pass on my pc. d3d8 might need it as well

1 0

Re: ddraw - Implement correct behavior for the DDEDM_REFRESHRATES flag in EnumDisplayModes() - REJECTED.
by Peter Dons Tychsen Feb. 12, 2008

Feb. 12, 2008

Hi Stefan. OK thanks for the fast, precise and well-cut review (and probably correct). I will fix the 3 issues and re-submit. /p On Wed, 2008-02-13 at 00:50 +0100, Stefan Dösinger wrote: > Am Mittwoch, 13. Februar 2008 00:39:52 schrieb Peter Dons Tychsen: > > Hi Devs. > > > > I had this patch silently rejected. > > Can anybody spot what is wrong with this patch? > My first thought was that filtering the modes like this is kinda ugly, but > given that ddraw uses wined3d and wined3d uses the d3d9 interface this is the > only way. (I don't think adding an extra flag to wined3d is cleaner, > considering that ddraw can sort this out on its own). > > However, I think you shouldn't clone the application's bug you're trying to > work around and deal with the "out of mode buffer" case. you can e.g. use > HeapReAlloc to increase the buffer without loosing the content. > > Another minor thing is the if(buffer) HeapFree(buffer) code. HeapFree checks > against NULL, so the extra check isn't needed, and it is sorta a policy not > to have redundant checks before HeapFree >

1 0

ddraw - Implement correct behavior for the DDEDM_REFRESHRATES flag in EnumDisplayModes() - REJECTED.
by Peter Dons Tychsen Feb. 12, 2008

Feb. 12, 2008

Hi Devs. I had this patch silently rejected. Can anybody spot what is wrong with this patch? It is really needed for some older games like Grand Theft Auto, and other oldies (but goodies!). /pedro

2 1

dbghelp/dwarf.c: new valgrind warnings?
by Dan Kegel Feb. 12, 2008

Feb. 12, 2008

I'm now seeing some new valgrind warnings when wine is doing stack dumps after crashes: + Conditional jump or move depends on uninitialised value(s) + at dwarf2_load_one_entry (dwarf.c:983) + by dwarf2_lookup_type (dwarf.c:858) + by dwarf2_load_one_entry (dwarf.c:1020) + by dwarf2_parse (dwarf.c:2060) + by elf_load_debug_info (elf_module.c:1085) + by module_get_debug (module.c:303) + by SymFromAddr (symbol.c:1071) + by stack_get_current_symbol (stack.c:143) + by display_print (display.c:174) + by wait_exception (tgt_active.c:178) + by dbg_active_auto (tgt_active.c:951) + by main (winedbg.c:544) I don't know when this started, but maybe it's related to recent changes by Eric Pouech? - Dan

2 1