February 2008 - Wine-Devel - list.winehq.org

Re: WineD3D: request alpha in backbuffer mode, to work correctly with multiple opengl pixel formats
by Stefan Dösinger Feb. 22, 2008

Feb. 22, 2008

Am Freitag, 22. Februar 2008 23:31:43 schrieb Roderick Colenbrander: > Hi, > > In the default backbuffer based renderer in WineD3D the front and > backbuffer share the same pixel format while D3D itself decouples them. A > lot of applications use alpha on the backbuffer, so make sure we have > alpha. This change is needed because the single pixel format which we had > before always had alpha. > + /* In case of ORM_BACKBUFFER, make sure to request an alpha component for X4R4G4B4/X8R8G8B8 as we might need it for the backbuffer. */ It would be for offscreen buffers, not the back buffer. I'm sorry for the confusion in the earlier mail

1 0

Re: 1/2 WGL: remove the pixel format limitation (!)
by Stefan Dösinger Feb. 22, 2008

Feb. 22, 2008

Am Freitag, 22. Februar 2008 21:16:23 schrieb Roderick Colenbrander: > WineD3D has some small issues due to this change but those should be > investigated by Stefan, Chris, me and others. The code should get a lot of > testing as soon as possible. We discussed this on IRC. The problem is that we're still defaulting to back buffer / aux buffer offscreen rendering, and thus offscreen targets are bound to use the same format as the back buffer. In the D3D9 test this means that the backbuffer is X8R8G8B8, and the onscreen target is A8R8G8B8. The alpha is missing with this patch(used to be always there), so the test fails. The proper fix is to switch to FBOs for onscreen rendering whereever possible(FBO support still has problems that prevent that though), and on cards without FBOs try to use A8R8G8B8 instead of X8R8G8B8 for the backbuffer, and similarly for X1R5G5B5 and X4R4G4B4.

1 1

Re: [Wine] Windows Kernel & Executive implementation
by Volodymyr Shcherbyna Feb. 22, 2008

Feb. 22, 2008

Unfortunately, that code just do stubs, and it is not actually executed in kernel mode. -- with best regards, Volodymyr 2008/2/22, Dan Kegel <dank(a)kegel.com>: > > On Fri, Feb 22, 2008 at 3:02 AM, Volodymyr Shcherbyna > <v_scherbina(a)mvps.org> wrote: > > > I discovered that WineHQ project does not have support for drivers (am > I > > wrong?). In other words, quite a big amount of applications will fail > to > > function properly, because many of them are using helper device drivers > to > > get some extended functionality. I can just mention RegMon, FileMon, > TDIMom, > > and others. > > > I know very little about this, but my impression is that > Wine supports a limited set of NT os kernel APIs already. > The initial support was added by this patch: > http://www.winehq.org/pipermail/wine-cvs/2007-May/032546.html > The current set of supported calls can be seen here: > http://source.winehq.org/source/dlls/ntoskrnl.exe/ntoskrnl.c > > Feel free to implement more, or file enhancement requests > describing what nt os apis a popular app needs. > > - Dan >

1 0

Re: msi: MsiMergeDatabaseA/W stub
by James Hawkins Feb. 22, 2008

Feb. 22, 2008

On Thu, Feb 21, 2008 at 2:26 PM, Johan Dahlin <jdahlin(a)async.com.br> wrote: > Add stubs for MsiMergeDatabaseA/W, used by WiX's msi validation. > > diff --git a/dlls/msi/database.c b/dlls/msi/database.c > index 425486e..e74db8f 100644 > --- a/dlls/msi/database.c > +++ b/dlls/msi/database.c > @@ -1119,3 +1119,22 @@ HRESULT create_msi_remote_database( IUnknown *pOuter, LPVOID *ppObj ) > > return S_OK; > } > + > +UINT WINAPI MsiDatabaseMergeW( MSIHANDLE hDatabase, > + MSIHANDLE hDatabaseMerge, > + LPCWSTR szTableName ) > +{ > + FIXME("(%ld %ld %s): stub!\n", hDatabase, hDatabaseMerge, > + debugstr_w(szTableName)); > + return ERROR_SUCCESS; > +} > + > +UINT WINAPI MsiDatabaseMergeA( MSIHANDLE hDatabase, > + MSIHANDLE hDatabaseMerge, > + LPCSTR szTableName ) > +{ > + FIXME("(%ld %ld %s): stub!\n", hDatabase, hDatabaseMerge, > + szTableName); > + > + return ERROR_SUCCESS; > +} > Please use the same style as the rest of the file (4 space indentation). The A version should be before the W version. -- James Hawkins

2 2

Re: [1/2] user32:scroll: Added some tests for scrollbar [try2]
by Anatoly Lyutin Feb. 22, 2008

Feb. 22, 2008

Alexandre Julliard wrote: > The tests fail: > > ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p > user32_test.exe.so scroll.c && touch scroll.ok > scroll.c:56: Test failed: The scrollbar window should be disabled. > scroll.c:122: Test failed: The ShowScrollBar() should failed. > Yes! These tests must be failed in WINE, but it passes clear in Win XP. I just want to show you some incorrect behavior of scrollbar in WINE. Should I mark these tests as "todo_wine"? -- Best regards Anatoly Lyutin.

2 2

Re: [2/3] qmgr: Implement IUnkown interface for IBackgroundCopyJob.
by Alexandre Julliard Feb. 22, 2008

Feb. 22, 2008

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > +static ULONG WINAPI BITS_IBackgroundCopyJob_AddRef(IBackgroundCopyJob* iface) > +{ > + ICOM_THIS_MULTI(BackgroundCopyJobImpl, lpVtbl, iface); > + return InterlockedIncrement(&This->ref); > +} There's no reason to use something like ICOM_THIS_MULTI with a single interface. And if you really do have multiple interfaces, please use an inline function instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Printing images
by Alexander Demakin Feb. 22, 2008

Feb. 22, 2008

Hi all, I have some troubles with printing. BitBlt returns error when calling it for printer context due to implementation of PSDRV_SelectBitmap(). Does anybody know how to implement this function? Where can i find any documentation about it? Implementation of SelectBitmap() in EMFDRV and MFDRV just returns 0. Is it correct? Please, share your ideas. Thanks in advance, Demakin Alexander.

1 0

gdiplus: negative stride from dipCreateBitmapFromFile
by bill lam Feb. 22, 2008

Feb. 22, 2008

WHen I read a jpeg file of size about 600x400 pixels using gdiplus like this, GdipCreateBitmapFromFile fn BMP GdipGetImageWidth BMP w GdipGetImageHeight BMP h rt=. 0 0, w, h GdipBitmapLockBits BMP rt ImageLockModeRead PixelFormat32bppARGB DATA 'w h s f p r'=. DATA the member stride inside bitmapdata is negative, and its data buffer cannot be read successfully. when using native gdiplus that stride is positive, and it work ok. wine said itself cannot handle negitive stride yet so why itself create a bitmap wih negative stride in GdipCreateBitmapFromFile?

1 0

Re: New dll. Wbemprox.dll
by Alistair Leslie-Hughes Feb. 22, 2008

Feb. 22, 2008

Ivan Sinitsin wrote: > This patch add new library to the project wine. Name of the library > is - "wbemprox.dll".This library is a part of WMI technology. Now there four > interfaces are described - "IWbemLocator, IWbemServices, > IEnumWbemClassObject, IWbemClassObject". Almost all methods are stubs. > This library is used with some programs like "1C", to get some information > about system. > > static struct regsvr_interface const interface_list[] = { >+ { &IID_IWbemLocator, >+ "IWbemLocator", >+ NULL, >+ 1, /*ÞÉÓÌÏ ÍÅÔÏÄÏ×*/ Comment should be in English. >#define _WIN32_WINNT 0x0600 > >#ifndef __wbemprox_PRIVATE_H__ Defining _WIN32_WINNT doesn't seem right. This patches is large, try breaking it up. Best Regards Alistair Leslie-Hughes

1 0

Fun Project: Add dialogs to builtin IE
by Steven Edwards Feb. 22, 2008

Feb. 22, 2008

Hi, I submitted a proof of concept patch for this a week or so back that added a simple file->exit menu to the builtin Internet Explorer. I've spoken with Jacek a bit about it and it seems shdocvw.dll is the correct place to implement the UI layout if we are targeting IE versions less the 7. There seems to be a plugin interface the GUI uses for browser extensions but if a first pass I don't think we really need to support it. Unfortuntly due to time constraints I am not going to be able to work on this project so if there is anyone out there that wants to contribute with a simple fun project, please feel free to add menus, dialogs and the address bar. I'll try to help as best I can but I expect to be tied up for some time to come. Thanks Steven -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: msvcrt: Implemented wcscpy_s
by Dmitry Timoshkov Feb. 21, 2008

Feb. 21, 2008

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote: > --- a/dlls/msvcrt/msvcrt.spec > +++ b/dlls/msvcrt/msvcrt.spec > @@ -761,6 +761,7 @@ > @ cdecl wcscmp(wstr wstr) ntdll.wcscmp > @ cdecl wcscoll(wstr wstr) MSVCRT_wcscoll > @ cdecl wcscpy(ptr wstr) ntdll.wcscpy > +@ cdecl wcscpy_s(wstr long wstr) MSVCRT_wcscpy_s Type of the first parameter should be ptr, not wstr. -- Dmitry.

1 0

Re: appdb: Increase readability by using slightly softer colours on Warning and Notes
by Francois Gouget Feb. 21, 2008

Feb. 21, 2008

On Wed, 20 Feb 2008, Jeff Zaroyko wrote: > The default colours for warnings and notes on the appdb pages feel > rather strong, this patch changes the red and blue to be a bit softer. > > I think this makes it more readable. A comparison can be seen here: > http://jeffz.name/tmp/ In new.png the green looks darker than the others. Maybe it should be lightened up a bit too. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ In a world without fences who needs Gates?

4 7

Re: dmband: Indirection levels fix
by Robert Shearman Feb. 21, 2008

Feb. 21, 2008

Andrew Talbot wrote: > diff --git a/dlls/dmband/band.c b/dlls/dmband/band.c > index 891fb5a..8b89573 100644 > --- a/dlls/dmband/band.c > +++ b/dlls/dmband/band.c > @@ -173,7 +173,7 @@ static HRESULT WINAPI IDirectMusicBandImpl_IDirectMusicObject_SetDescriptor (LPD > This->pDesc->ftDate = pDesc->ftDate; > if (pDesc->dwValidData & DMUS_OBJ_MEMORY) { > This->pDesc->llMemLength = pDesc->llMemLength; > - memcpy (This->pDesc->pbMemData, pDesc->pbMemData, sizeof (pDesc->pbMemData)); > + memcpy (&This->pDesc->pbMemData, &pDesc->pbMemData, sizeof (pDesc->pbMemData)); > } > if (pDesc->dwValidData & DMUS_OBJ_STREAM) { > /* according to MSDN, we copy the stream */ This isn't correct. Judging by the surrounding code, this should be allocating a block of memory of This->pDesc->pbMemData and then passing pDesc->llMemLength into memcpy, possibly validating that pDesc->llMemLength isn't greater than UINT_MAX to avoid an overflow. -- Rob Shearman

2 1

Re: [1/2] ddraw: release interfaces when exiting with error
by Stefan Dösinger Feb. 21, 2008

Feb. 21, 2008

Am Mittwoch, 20. Februar 2008 22:03:51 schrieben Sie: > --- > dlls/ddraw/texture.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) Just a general comment(not specific to comments): For such cleanup work it works quite nice to use goto(!), as shown below. Your patch is OK as it is, but I think its a good idea to use this scheme in all places because it helps to prevent new problems from coming in when the code is changed. void *a = NULL, *b = NULL, *c = NULL; a = malloc(10); if(!a) goto error; b = malloc(10); if(!b) goto error; c = malloc(10); if(!c) goto error; if(dosomethingelse() == FAIL) goto error; return SUCCESS; error: f(c) free(c); f(b) free(b); f(a) free(a); return FAIL;

1 0

Re: dplayx: Fix incorrect check in DirectPlayLobbyAImpl_EnumLocalApplications and IDirectPlayLobbyAImpl_EnumAddressTypes.
by Marcus Meissner Feb. 21, 2008

Feb. 21, 2008

On Thu, Feb 21, 2008 at 04:44:34PM +0000, Robert Shearman wrote: > > Dereferencing a function pointer and checking it against NULL doesn't make > any sense, so remove the checks. > - if( !lpEnumAddressTypeCallback || !*lpEnumAddressTypeCallback ) > + if( !lpEnumAddressTypeCallback ) It looks as if they were meant as &&, but that does not make much sense either. Ciao, Marcus

1 0

Re: James Hawkins : itircl: Add a stub implementation of itircl.dll.
by Detlef Riekenberg Feb. 21, 2008

Feb. 21, 2008

On Sa, 2008-02-16 at 09:57 -0600, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 58b0686e951364686c3b5b55c18566df0960fd96 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=58b0686e951364686c3b5b55c… > > Author: James Hawkins <jhawkins(a)codeweavers.com> > Date: Fri Feb 15 17:39:46 2008 -0600 > > itircl: Add a stub implementation of itircl.dll. Hi James. While adding your Patch to http://wiki.winehq.org/Developers-Hints , I found this Page: http://www.helpware.net/aphelp/info.htm itircl.dll: HTML Help 1 (found on w2k and xp) itircl52.dll: MS Help 2 apircl.dll: Assistance Platform 1.0 (Vista) -- By by ... Detlef

1 0

Re: slc: Added stub for SLGetWindowsInformationDWORD
by Paul Vriens Feb. 21, 2008

Feb. 21, 2008

On Thu, Feb 21, 2008 at 10:20 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > Changelog: > slc: Added stub for SLGetWindowsInformationDWORD > > Best Regards > Alistair Leslie-Hughes > Hi Alistair, I know that function descriptions should always be your own words but I guess this is also true for header files. The comments in slerror.h are exactly like the comments on MSDN: http://msdn2.microsoft.com/en-us/library/aa965835(VS.85).aspx Cheers, Paul.

3 2

Re: Adding devices in setupapi
by Erich Hoover Feb. 20, 2008

Feb. 20, 2008

> > I think it probably does something similar to: > http://www.codeproject.com/KB/system/RemoveDriveByLetter.aspx > > Except instead of mapping a drive to usb device, it does it the other > way around. > > After looking more into it it really looks like this is the thing it > does. (I need a bunch of hacks for it to work, but alas.) However it > doesn't get me much further since our IOCTL_STORAGE_GET_DEVICE_NUMBER > ioctl is a stub. I would need something that can at least guarantee > uniqueness per volume for it, perhaps a conversion of drive letter to > integer. Now I just need to figure that one out. > > Cheers, > Maarten. > > I do not believe the device number matching is the problem, I have been exploring this problem a little with RemoveDriveByLetter and I believe that it is not working because the SymbolicLink entry is not added as a "real" thing in Wine. Performing an experiment with accessing the same drive letter in three different ways (results below, last parameter is "hDrive") I see that only the call with the registry-returned value for the drive fails (even if it is added to "HKLM/System/MountedDevices"). I believe that a call to IoCreateSymbolicLink must be made in order for the name returned by the registry to be recognized as an alias for the drive. I think iTunes is probably going through the device tree looking for its vendor and product code. It should get this back from CM_Get_Device_ID, but I do not have Windows so I cannot fake iTunes out to confirm this. SetupDiGetDeviceInterfaceDetail '\\?\USBSTOR#Disk&Ven_Apple&Prod_iPod&Rev_1.62#000A27001420C124&0#{53f56307-b6bf-11d0-94f2-00a0c91efb8b}': -1 SetupDiGetDeviceInterfaceDetail '\\?\Volume{00000000-0000-0000-0000-000000000048}': 60 SetupDiGetDeviceInterfaceDetail '\\.\H:': 64 Device number comparison: 1 1

1 0

No new Wine Weekly News?
by Austin English Feb. 20, 2008

Feb. 20, 2008

Hasn't been a new Wine Weekly News in about a month...quite a bit has been going on, with CS2 working out of the box, test suite fixes, etc. Anyone know what's going on? -Austin

2 1

Re: appdb: database issues
by Chris Morgan Feb. 20, 2008

Feb. 20, 2008

In include/query.php in query_appdb() we only call mysql_connect() if the global $hAppdbLink isn't a valid resource. So, when a user connects to display a page the first query should open the connection and upon completion of the script $hAppdbLink will be freed and the connection should be closed. So I'm not sure that this is the cause of the out-of-connections issue although I don't see a reason why we shouldn't just let php take care of this internally and apply a variation of your change where we always attempt to connect and select the appropriate database and remove the global handle and the resource check etc. Chris On Wed, Feb 20, 2008 at 6:01 PM, Jeff Zaroyko <jeffzaroyko(a)gmail.com> wrote: > The mysql database for the appdb/bugzilla appears to have gone down again, > I decided to look at the connection code in the appdb, as the appdb is thought > to be the culprit. > > I came across the call to mysql_connect which is using the new_link parameter > set to true, which is supposedly to force a new connection to be established. > > So, I searched through the git commit history using gitk and saw that Paul van > Schayck made a change introducing this, apparently because mysql was having > stability issues, back in 2005. > > http://www.winehq.org/pipermail/wine-patches/2005-January/014985.html > > my understanding is that php will automagically reuse connections if this is not > set, would there by any objection to trialling a removal of this > option to see if > stability increases? > > > >

1 0

Kudos for Photoshop work
by Dan Kegel Feb. 20, 2008

Feb. 20, 2008

In http://linux.slashdot.org/comments.pl?sid=460616&cid=22493322, an anonymous coward said: --- snip --- Preamble: I'm a photographer needing to process tens of thousands of photos relatively swiftly. The functionality I need isn't all that advanced (curves, levels, an occasional straighten horizon (measure + arbitrary rotate), crop, unsharp mask, and sometimes an action to find edges, feather and apply unsharp mask on that), but being able to access and apply this functionality swiftly is an absolute must because of the volume of photos I deal with. Photoshop is optimized to perfection to allow a swift workflow, while the gimp seems optimized to perfection to hinder it. Focus is never where I need it, shortcuts to access tools don't work depending on which sub-window has focus, etc. So yes, I really need Photoshop. I last tried Photoshop 7 under wine about a year ago. It was functional to an amazing degree (for someone who'd never seen or used wine before), but the rough edges were slightly too rough for me to be able to switch to Linux fulltime. I could trigger a dozen crashes in Photoshop at will just by resizing panels and doing other simple things like that, the program didn't feel native (alt-tabbing would keep the panels in the foreground, obscuring other programs), and focus sometimes strayed, amongst other lesser (but still annoyingly noticeable) issues. I just tried the latest wine with these Google sponsored improvements, and wow. This is an amazing difference. Every single issue I saw a year ago is gone. Photoshop feels as responsive as it does under Windows (perhaps even more so), and I went through an hour long editing session without being slowed down or annoyed even once. As far as I'm concerned, Linux is now ready to become my main OS. Google: I don't like your lack of respect for my privacy, but for this work on Wine, I can say from the bottom of my heart: Thank you! --- snip --- Ah. Music to my ears :-) - Dan

1 0

Re: Adding devices in setupapi
by Juan Lang Feb. 20, 2008

Feb. 20, 2008

> How hard is it to create a stub forwarder dll for setupapi and cfgmgr32? Not sure what you mean exactly. cfgmgr32 should forward to setupapi already, and I sent a patch that does that for the few stub functions that it had. setupapi's CM_* stubs could be improved, but I don't think you'll be able to forward them to any native code to try out: I expect the Windows configuration manager is rather too low level to run under Wine. You'll probably want to create a hacky version of setupapi that creates a fake device tree, with a root, USB hub, and iPod device, just to see if that makes iTunes happy. Does that answer your question? --Juan

2 1

Re: James Hawkins : msi: Forward MsiSourceListEnumSourcesA to a stub implementation of MsiSourceListEnumSourcesW .
by Detlef Riekenberg Feb. 20, 2008

Feb. 20, 2008

On Mi, 2008-02-20 at 06:46 -0600, > +/****************************************************************** > + * MsiSourceListEnumSourcesA (MSI.@) > + */ > +UINT WINAPI MsiSourceListEnumSourcesW( Greetings from Copy & Paste :-) BTW: Congratulations James for you new Address -- By by ... Detlef

1 0

bugzilla on the fritz again
by Dan Kegel Feb. 20, 2008

Feb. 20, 2008

Just started getting this: Software error: Can't connect to the database. Error: Too many connections Is your database installed and up and running? Do you have the correct username and password selected in localconfig?

2 1

Adding devices to registry with the help of hal
by Christian Gmeiner Feb. 20, 2008

Feb. 20, 2008

Hi all, I want you to present my current proof-of-conecpt. It shows how we can use hal.c of explorer to create registry keys for devices. Keep in mind that it only creates one registry key for each usb device at the moment. Before I investigate more time in this, I want to get some feedback about my method. If you are happy with it, I will finish this suftt :) Greets, Christian

2 1

Re: user32dll: cursoricon.c. Fix 16b BMP handling with BT_BITFIELD.
by Dmitry Timoshkov Feb. 20, 2008

Feb. 20, 2008

"Alexander Demakin" <avd(a)etersoft.ru> wrote: > This patch fixes image header handling with BT_BITFIELD flag. 12 bytes of mask > were included into image bits, it caused some color troubles and image > horizontal shift. Size of bitmap info structure includes now this bytes. You are mixing tabs and spaces again, and please use 4 spaces for indentation. > static int bitmap_info_size( const BITMAPINFO * info, WORD coloruse ) > { > int colors; > - > + int result; > if (info->bmiHeader.biSize == sizeof(BITMAPCOREHEADER)) Any reason you have removed a space after a variable declaration? > Changelog: > user32.dll Fix 16b BMP handling with BT_BITFIELD. Please have a look how others name the patches. A usual convenience is to write dll name without extension, ': ' and short description. -- Dmitry.

1 0

Re: gdi32dll: bitblt.c. Fix copying from uninitialized memory
by Dmitry Timoshkov Feb. 20, 2008

Feb. 20, 2008

"Alexander Demakin" <avd(a)etersoft.ru> wrote: > This patch adds check of return value of GetDIBits in BitBlt.c. If a error > occurs, GetDIBits returns 0 and bits variable points to uninitialized data. > It always occurs when calling BitBlt for printer context due to > implementation of PSDRV_SelectBitmap(). > Changelog: > gdi32.dll Fix copying from uninitialized memory. You are mixing tabs and spaces in the patch, otherwise tha patch looks good to me. -- Dmitry.

1 0

Re: dlls/msi/streams.c type fixes
by James Hawkins Feb. 20, 2008

Feb. 20, 2008

On Feb 17, 2008 6:23 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > This patch contains one or two items from my November patch the core > of which was independently recreated by Marcus and accepted and one > or two additional changes. It addresses the following warnings: > > streams.c: In function 'streams_set_table_size': > streams.c:59: warning: comparison between signed and unsigned > streams.c: In function 'STREAMS_delete': > streams.c:379: warning: comparison between signed and unsigned > streams.c: In function 'STREAMS_find_matching_rows': > streams.c:404: warning: comparison between signed and unsigned > > Gerald > > ChangeLog: > Adjust the signedness of three variables and add a comment for > add_streams_to_table(). > > Index: streams.c > =================================================================== > RCS file: /home/wine/wine/dlls/msi/streams.c,v > retrieving revision 1.11 > diff -u -3 -p -r1.11 streams.c > --- streams.c 16 Feb 2008 15:59:26 -0000 1.11 > +++ streams.c 17 Feb 2008 12:17:50 -0000 > @@ -39,7 +39,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(msidb); > > typedef struct tabSTREAM > { > - int str_index; > + UINT str_index; > LPWSTR name; > IStream *stream; > } STREAM; > @@ -54,7 +54,7 @@ typedef struct tagMSISTREAMSVIEW > UINT row_size; > } MSISTREAMSVIEW; > > -static BOOL streams_set_table_size(MSISTREAMSVIEW *sv, int size) > +static BOOL streams_set_table_size(MSISTREAMSVIEW *sv, UINT size) > { > if (size >= sv->max_streams) > { > @@ -372,7 +372,7 @@ static UINT STREAMS_modify(struct tagMSI > static UINT STREAMS_delete(struct tagMSIVIEW *view) > { > MSISTREAMSVIEW *sv = (MSISTREAMSVIEW *)view; > - int i; > + UINT i; > > TRACE("(%p)\n", view); > > @@ -440,6 +440,7 @@ static const MSIVIEWOPS streams_ops = > }; > > static INT add_streams_to_table(MSISTREAMSVIEW *sv) > + /* Return -1 in case of error. */ > { > IEnumSTATSTG *stgenum = NULL; > STATSTG stat; > Don't add random comments like this. -- James Hawkins

2 1

Re: shell32: Support getting the shell folder path for users other than the current user and the default user (take 2)
by Alexandre Julliard Feb. 20, 2008

Feb. 20, 2008

"Ge van Geldorp" <ge(a)thinstall.com> writes: > else > { > + LPWSTR sidStr = NULL; > LPCWSTR userPrefix = NULL; > HKEY hRootKey; This is not used anywhere. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [advapi32] QueryServiceConfig2 (3rd try) [resend]
by Alexandre Julliard Feb. 20, 2008

Feb. 20, 2008

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > + switch(dwLevel) { > + case SERVICE_CONFIG_DESCRIPTION: { > + static const WCHAR szDescription[] = {'D','e','s','c','r','i','p','t','i','o','n',0}; > + LPSERVICE_DESCRIPTIONW config = (LPSERVICE_DESCRIPTIONW) buffer; > + *needed = sizeof (SERVICE_DESCRIPTIONW); > + sz = size - *needed; > + r = RegQueryValueExW( hKey, szDescription, 0, &type, (LPBYTE) (config ? config + 1: NULL), &sz ); > + if((r == ERROR_SUCCESS) && ( type != REG_SZ)) { > + FIXME("SERVICE_CONFIG_DESCRIPTION: don't know how to handle type %d\n", type); > + return FALSE; > + } > + *needed += sz; > + if(config) { > + if(r == ERROR_SUCCESS) > + config->lpDescription = (LPWSTR) (config + 1); > + else > + config->lpDescription = NULL; You are still not handling overflows correctly. What happens if size is less than sizeof(SERVICE_DESCRIPTIONW)? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] user32:scroll: Added some tests for scrollbar [try2]
by Alexandre Julliard Feb. 20, 2008

Feb. 20, 2008

Anatoly Lyutin <vostok(a)etersoft.ru> writes: > Changelog: > Added some tests for scrollbar The tests fail: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so scroll.c && touch scroll.ok scroll.c:56: Test failed: The scrollbar window should be disabled. scroll.c:122: Test failed: The ShowScrollBar() should failed. make: *** [scroll.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Adding devices to registry with the help of hal
by Christian Gmeiner Feb. 20, 2008

Feb. 20, 2008

Hi all, I want you to present my current proof-of-conecpt. It shows how we can use hal.c of explorer to create registry keys for devices. Keep in mind that it only creates one registry key for each usb device at the moment. Before I investigate more time in this, I want to get some feedback about my method. If you are happy with it, I will finish this suftt :) Greets, Christian

1 0

re: Do we need a forum?
by Dan Kegel Feb. 19, 2008

Feb. 19, 2008

Steven Edwards wrote: > My thoughts, as well as > Tom's was that by creating a "blessed" location, all third parties as > well as vendors that develop Wine related products could say "if you > want to discuss using a vendor provided Wine product in a > non-supported manner all are advised to go here and share information" Yes, of course, it would be nice if there were One True Place to go, but the closest we're ever going to get is essentially the status quo, where the wine-users mailing list is the place of record for user support, the appdb is the place of record for looking for tips for a particular app, and all the other areas are secondary. We can improve slightly on this by linking to other popular wine forums as they pop up, emphasizing all the while that they are secondary. - Dan

5 8

Fwd: Adding devices in setupapi
by Maarten Lankhorst Feb. 19, 2008

Feb. 19, 2008

Hi Juan, 2008/2/19, Juan Lang <juan.lang(a)gmail.com>: > > I stubbed CM_get_parent by returning itself, however that makes it go > > in an infinite loop. > > Hm. > > > My guess is that I need to have some hub and usb ehci device as well. > > I don't know why it would want to call CreateFile on the device though > > but my expertise on that part is very limited, perhaps it allows > > communication to the ipod by accessing the device in a raw way? > > Perhaps, or perhaps it's just making sure you don't have a fake device :-/ > --Juan The only way to be sure would be to create my own test program that would do the same, and see what happens. How hard is it to create a stub forwarder dll for setupapi and cfgmgr32? Cheers, Maarten.

1 0

Saulius sent you a friend request on Yaari...
by Saulius Feb. 19, 2008

Feb. 19, 2008

1 0

Adding devices in setupapi
by Maarten Lankhorst Feb. 19, 2008

Feb. 19, 2008

Hi all, I'm trying to add the ipod detection from crossover wine to winehq. However it seems to be not compatibel due to changes to setupapi in the last 3 years. Basically what I want to do is add an usb mass storage device with the correct device path and register it with setupapi. Composing the string is easy but I'm not 100% sure what the locations are. The code seems a bit vague in that aspect. The snippet iTunes uses for detection is shown below: SetupDiGetClassDevsExW {53f56307-b6bf-11d0-94f2-00a0c91efb8b} (null) (nil) 0x00000012 (nil) (null) (nil) SetupDiEnumDeviceInterfaces 0x136638, (nil), {53f56307-b6bf-11d0-94f2-00a0c91efb8b}, 0, 0x7aa2140c How do I get my device listed in SetupDiEnumDeviceInterfaces there so iTunes can pick it up? Cheers, Maarten.

3 2

Making use of setupapi
by Maarten Lankhorst Feb. 19, 2008

Feb. 19, 2008

Hi folks, Any one around who understands setupapi? For iTunes I would need to add appropriate registry keys so that my usb device is detected. My idea is to use libusb to find the things like guid, revision etc and then adding the keys. However I am not 100% what the layout of the keys is. Cheers, Maarten.

3 3

Re: ddraw: Assign to structs instead of using memcpy
by Stefan Dösinger Feb. 19, 2008

Feb. 19, 2008

Am Samstag, 16. Februar 2008 23:33:37 schrieb Andrew Talbot: > Here, I am assuming that the "dwSize" elements in all these cases should be > set to the size of the struct each is in, respectively. Please advise if > this assumption is wrong. It's not necessarily true. Sometimes there are multiple versions of the same structure. You can check ddraw.h and d3dtypes.h. If there is only one version your assumption should be true. If there isn't, then your assumption may still be true. In that case there are some tests how the Setter methods deal with newer or older structures(in some cases we may need more tests) > Thanks, > > -- Andy. > --- > Changelog: > ddraw: Assign to structs instead of using memcpy. > > diff --git a/dlls/ddraw/device.c b/dlls/ddraw/device.c > index b60b6f3..03ccea8 100644 > --- a/dlls/ddraw/device.c > +++ b/dlls/ddraw/device.c > @@ -704,7 +704,7 @@ > IDirect3DDeviceImpl_1_CreateExecuteBuffer(IDirect3DDevice *iface, > object->d3ddev = This; > > /* Initializes memory */ > - memcpy(&object->desc, Desc, Desc->dwSize); > + object->desc = *Desc; > > /* No buffer given */ > if ((object->desc.dwFlags & D3DDEB_LPDATA) == 0) > diff --git a/dlls/ddraw/material.c b/dlls/ddraw/material.c > index d6b9a7c..8e17174 100644 > --- a/dlls/ddraw/material.c > +++ b/dlls/ddraw/material.c > @@ -250,7 +250,7 @@ IDirect3DMaterialImpl_SetMaterial(IDirect3DMaterial3 > *iface, /* Stores the material */ > EnterCriticalSection(&ddraw_cs); > memset(&This->mat, 0, sizeof(This->mat)); > - memcpy(&This->mat, lpMat, lpMat->dwSize); > + This->mat = *lpMat; > LeaveCriticalSection(&ddraw_cs); > > return DD_OK; > @@ -285,7 +285,7 @@ IDirect3DMaterialImpl_GetMaterial(IDirect3DMaterial3 > *iface, EnterCriticalSection(&ddraw_cs); > dwSize = lpMat->dwSize; > memset(lpMat, 0, dwSize); > - memcpy(lpMat, &This->mat, dwSize); > + *lpMat = This->mat; > LeaveCriticalSection(&ddraw_cs); > > return DD_OK; > diff --git a/dlls/ddraw/viewport.c b/dlls/ddraw/viewport.c > index deb4146..8dfc015 100644 > --- a/dlls/ddraw/viewport.c > +++ b/dlls/ddraw/viewport.c > @@ -261,7 +261,7 @@ IDirect3DViewportImpl_GetViewport(IDirect3DViewport3 > *iface, } > dwSize = lpData->dwSize; > memset(lpData, 0, dwSize); > - memcpy(lpData, &(This->viewports.vp1), dwSize); > + *lpData = This->viewports.vp1; > > if (TRACE_ON(d3d7)) { > TRACE(" returning D3DVIEWPORT :\n"); > @@ -301,7 +301,7 @@ IDirect3DViewportImpl_SetViewport(IDirect3DViewport3 > *iface, EnterCriticalSection(&ddraw_cs); > This->use_vp2 = 0; > memset(&(This->viewports.vp1), 0, sizeof(This->viewports.vp1)); > - memcpy(&(This->viewports.vp1), lpData, lpData->dwSize); > + This->viewports.vp1 = *lpData; > > /* Tests on two games show that these values are never used properly > so override them with proper ones :-) > @@ -856,7 +856,7 @@ IDirect3DViewportImpl_GetViewport2(IDirect3DViewport3 > *iface, } > dwSize = lpData->dwSize; > memset(lpData, 0, dwSize); > - memcpy(lpData, &(This->viewports.vp2), dwSize); > + *lpData = This->viewports.vp2; > > if (TRACE_ON(d3d7)) { > TRACE(" returning D3DVIEWPORT2 :\n"); > @@ -895,7 +895,7 @@ IDirect3DViewportImpl_SetViewport2(IDirect3DViewport3 > *iface, EnterCriticalSection(&ddraw_cs); > This->use_vp2 = 1; > memset(&(This->viewports.vp2), 0, sizeof(This->viewports.vp2)); > - memcpy(&(This->viewports.vp2), lpData, lpData->dwSize); > + This->viewports.vp2 = *lpData; > > if (This->active_device) { > > IDirect3DDevice3_GetCurrentViewport(ICOM_INTERFACE(This->active_device, > IDirect3DDevice3), &current_viewport);

2 3

Re: WineD3D: let flush_to_framebuffer_drawpixels use a valid rect
by Stefan Dösinger Feb. 19, 2008

Feb. 19, 2008

Am Dienstag, 19. Februar 2008 21:26:24 schrieben Sie: > Hi, > > Originally flush_to_framebuffer_drawpixels was called from UnlockRect, so > in that case LockedRect was always set. These days it can also be called > (through LoadLocation) from other places. This patch makes it use the > LockedRect when the surface is locked else the whole surface is uploaded. > This fixes rendering issues in Red Alert and other apps. Wouldn't it be better to make sure that the caller passes the correct rectangle to flush_to_framebuffer_* ? > - if(dxVersion >= 8) { > + if(0 && dxVersion >= 8) { Is this intentional?

1 0

Re: slc: Initial stub DLL (try 2)
by Robert Shearman Feb. 19, 2008

Feb. 19, 2008

Alistair Leslie-Hughes wrote: > slc: Initial stub dll I'm not sure we want to go down the path of implementing the functions in this DLL. Furthermore, this file isn't present on an XP SP2 installation. Can you give some information as to why this is needed and how the application depends on this DLL? -- Rob Shearman

3 3

Re: Make.rules.in: Pass the --nounistd flag to flex since unistd.h is a header that might not be present on all systems.
by Alexandre Julliard Feb. 19, 2008

Feb. 19, 2008

Robert Shearman <rob(a)codeweavers.com> writes: > If we do need it, we can include it in the .l file after config.h and > with an appropriate include guard. You should instead put a %option in the files that need it. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: Pass parms through to PdhLookupPerfIndexByNameW for checking
by Dmitry Timoshkov Feb. 19, 2008

Feb. 19, 2008

"Jeff Latimer" <lats(a)yless4u.com.au> wrote: > + if (machine && !(machineW = pdh_strdup_aw( machine ))) return PDH_MEMORY_ALLOCATION_FAILURE; > > - if (machine) > - { > - FIXME("remote machine not supported\n"); > - return PDH_CSTATUS_NO_MACHINE; > - } > if (!(nameW = pdh_strdup_aw( name ))) > return PDH_MEMORY_ALLOCATION_FAILURE; > > ret = PdhLookupPerfIndexByNameW( NULL, nameW, index ); You forgot to actually pass machineW to PdhLookupPerfIndexByNameW. -- Dmitry.

1 0

re: Do we need a forum?
by Dan Kegel Feb. 19, 2008

Feb. 19, 2008

Anybody who thinks we need another forum needs his head examined. There is no shortage of Wine forums. We just need to use the ones that already exist. Adding a new one will just fragment the community further. In particular, there are two forums right now that people already use to discuss wine problems: a generic one at http://www.linuxforums.org/forum/wine/ and an Ubuntu-specific one at http://ubuntuforums.org/forumdisplay.php?f=313 Let's just link to them. I'll submit a patch to do that in a minute. And I like Griswold's idea (on IRC) of improving the current appdb in small ways, e.g. changing the reply behavior to not open up a new page. For goodness' sake, don't create yet another new forum! - Dan

3 2

Re: slc: Add Initial DLL
by John Klehm Feb. 19, 2008

Feb. 19, 2008

On Feb 18, 2008 10:48 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > Changelog: > slc: Added Initial DLL > > Best Regards > Alistair Leslie-Hughes > > > > No Patch?

1 0

Re: iTunes
by Maarten Lankhorst Feb. 18, 2008

Feb. 18, 2008

Hi Christopher, Christopher Harvey wrote: > What needs to get done for iTunes to work? v7.6 basically works if you set windows version to windows vista, and find out why the installer fails to create the 'Bonjour service' registry stuff properly. I submitted 8 or so stub dll's to wine-patches that make iTunes v7.6 actually start after installation. It checks for the dll's and silently fails if they don't exist. I haven't done any further testing yet though, but it looks like it is probably a small installer bug that prevents itunes v7.6 from installing without first manually creating those registry keys. Cheers, Maarten.

6 17

Re: Usable Wine interface
by Remco Feb. 18, 2008

Feb. 18, 2008

----- Original Message ---- > From: Vitaliy Margolen <wine-devel(a)kievinfo.com> > To: wine-devel(a)winehq.org > Sent: Monday, February 18, 2008 4:16:17 AM > Subject: Re: Usable Wine interface > > Remco wrote: > > I'd like to add a feature-request (should this go somewhereelse?) > Yes, bugzilla -> enhancement. > > Vitaliy. Ok, thanks for the info. I added an entry: http://bugs.winehq.org/show_bug.cgi?id=11629 Remco ____________________________________________________________________________________ Looking for last minute shopping deals? Find them fast with Yahoo! Search. http://tools.search.yahoo.com/newsearch/category.php?category=shopping

5 5

Re: dlls/user32/edit.c -- remove superflous check (RESEND)
by Alexandre Julliard Feb. 18, 2008

Feb. 18, 2008

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > dwBufLen already indictes that this variable is of type DWORD and > thus always positive. I also looked at the implementation of > ImmGetCompositionStringW() and we do not seem to return a negative > value (such as -1). Maybe the implementation doesn't, but the function returns a LONG, and can (and probably should) return negative values on error. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] Environment variable to specify X11 window for desktop
by Robert Shearman Feb. 18, 2008

Feb. 18, 2008

Timothy Lee wrote: > The attached patch allows the WINE desktop to be embedded within an > existing X11 window, and is similar to the windowed mode in WINE. > > I've tested this feature using MS PowerPoint Viewer 2007, so that a > fullscreen slideshow can be fitted inside any X11 window. I'm struggling to imagine a case where the behaviour you've implemented is useful. -- Rob Shearman

6 13

Re: [PATCH 2/3] gdi32: Move EnumFontFamiliesEx16() and helper functions to gdi16.c.
by Michael Stefaniuc Feb. 18, 2008

Feb. 18, 2008

Michael Stefaniuc wrote: > --- > This duplicates for now the FONT_LogFont16ToW() function but Alexandre It duplicates FONT_LogFontWTo16() and not FONT_LogFont16ToW() (that one was already duplicated). > told me on irc that he removed the other user of it in an yet unpublished > patch. Thus FONT_LogFont16ToW() can be removed from font.c in a later FONT_LogFontWTo16() can be removed later on. > patch. > bye michael

1 0

Re: [1/16] msxml3: Support functions for typelib
by Alexandre Julliard Feb. 18, 2008

Feb. 18, 2008

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > +HRESULT get_typeinfo(enum tid_t tid, ITypeInfo **typeinfo) > +{ > + HRESULT hres; > + > + if(!typelib) { > + ITypeLib *tl; > + > + hres = LoadRegTypeLib(&LIBID_MSXML2, 3, 0, LOCALE_SYSTEM_DEFAULT, &tl); > + if(FAILED(hres)) { > + ERR("LoadRegTypeLib failed: %08x\n", hres); > + return hres; > + } > + > + if(InterlockedCompareExchangePointer((void**)&typelib, tl, NULL)) > + ITypeLib_Release(tl); > + } > + > + if(!typeinfos[tid]) { > + ITypeInfo *typeinfo; > + > + hres = ITypeLib_GetTypeInfoOfGuid(typelib, tid_ids[tid], &typeinfo); > + if(FAILED(hres)) { > + ERR("GetTypeInfoOfGuid failed: %08x\n", hres); > + return hres; > + } > + > + if(InterlockedCompareExchangePointer((void**)(typeinfos+tid), typeinfo, NULL)) > + ITypeInfo_Release(typeinfo); > + } > + > + *typeinfo = typeinfos[tid]; > + return S_OK; You should increment the ref count when you are returning a pointer, even if it's also stored in a global variable. -- Alexandre Julliard julliard(a)winehq.org

2 3