February 2008 - Wine-Devel - list.winehq.org

Kudos for Photoshop work
by Dan Kegel Feb. 20, 2008

Feb. 20, 2008

In http://linux.slashdot.org/comments.pl?sid=460616&cid=22493322, an anonymous coward said: --- snip --- Preamble: I'm a photographer needing to process tens of thousands of photos relatively swiftly. The functionality I need isn't all that advanced (curves, levels, an occasional straighten horizon (measure + arbitrary rotate), crop, unsharp mask, and sometimes an action to find edges, feather and apply unsharp mask on that), but being able to access and apply this functionality swiftly is an absolute must because of the volume of photos I deal with. Photoshop is optimized to perfection to allow a swift workflow, while the gimp seems optimized to perfection to hinder it. Focus is never where I need it, shortcuts to access tools don't work depending on which sub-window has focus, etc. So yes, I really need Photoshop. I last tried Photoshop 7 under wine about a year ago. It was functional to an amazing degree (for someone who'd never seen or used wine before), but the rough edges were slightly too rough for me to be able to switch to Linux fulltime. I could trigger a dozen crashes in Photoshop at will just by resizing panels and doing other simple things like that, the program didn't feel native (alt-tabbing would keep the panels in the foreground, obscuring other programs), and focus sometimes strayed, amongst other lesser (but still annoyingly noticeable) issues. I just tried the latest wine with these Google sponsored improvements, and wow. This is an amazing difference. Every single issue I saw a year ago is gone. Photoshop feels as responsive as it does under Windows (perhaps even more so), and I went through an hour long editing session without being slowed down or annoyed even once. As far as I'm concerned, Linux is now ready to become my main OS. Google: I don't like your lack of respect for my privacy, but for this work on Wine, I can say from the bottom of my heart: Thank you! --- snip --- Ah. Music to my ears :-) - Dan

1 0

Re: Adding devices in setupapi
by Juan Lang Feb. 20, 2008

Feb. 20, 2008

> How hard is it to create a stub forwarder dll for setupapi and cfgmgr32? Not sure what you mean exactly. cfgmgr32 should forward to setupapi already, and I sent a patch that does that for the few stub functions that it had. setupapi's CM_* stubs could be improved, but I don't think you'll be able to forward them to any native code to try out: I expect the Windows configuration manager is rather too low level to run under Wine. You'll probably want to create a hacky version of setupapi that creates a fake device tree, with a root, USB hub, and iPod device, just to see if that makes iTunes happy. Does that answer your question? --Juan

2 1

Re: James Hawkins : msi: Forward MsiSourceListEnumSourcesA to a stub implementation of MsiSourceListEnumSourcesW .
by Detlef Riekenberg Feb. 20, 2008

Feb. 20, 2008

On Mi, 2008-02-20 at 06:46 -0600, > +/****************************************************************** > + * MsiSourceListEnumSourcesA (MSI.@) > + */ > +UINT WINAPI MsiSourceListEnumSourcesW( Greetings from Copy & Paste :-) BTW: Congratulations James for you new Address -- By by ... Detlef

1 0

bugzilla on the fritz again
by Dan Kegel Feb. 20, 2008

Feb. 20, 2008

Just started getting this: Software error: Can't connect to the database. Error: Too many connections Is your database installed and up and running? Do you have the correct username and password selected in localconfig?

2 1

Adding devices to registry with the help of hal
by Christian Gmeiner Feb. 20, 2008

Feb. 20, 2008

Hi all, I want you to present my current proof-of-conecpt. It shows how we can use hal.c of explorer to create registry keys for devices. Keep in mind that it only creates one registry key for each usb device at the moment. Before I investigate more time in this, I want to get some feedback about my method. If you are happy with it, I will finish this suftt :) Greets, Christian

2 1

Re: user32dll: cursoricon.c. Fix 16b BMP handling with BT_BITFIELD.
by Dmitry Timoshkov Feb. 20, 2008

Feb. 20, 2008

"Alexander Demakin" <avd(a)etersoft.ru> wrote: > This patch fixes image header handling with BT_BITFIELD flag. 12 bytes of mask > were included into image bits, it caused some color troubles and image > horizontal shift. Size of bitmap info structure includes now this bytes. You are mixing tabs and spaces again, and please use 4 spaces for indentation. > static int bitmap_info_size( const BITMAPINFO * info, WORD coloruse ) > { > int colors; > - > + int result; > if (info->bmiHeader.biSize == sizeof(BITMAPCOREHEADER)) Any reason you have removed a space after a variable declaration? > Changelog: > user32.dll Fix 16b BMP handling with BT_BITFIELD. Please have a look how others name the patches. A usual convenience is to write dll name without extension, ': ' and short description. -- Dmitry.

1 0

Re: gdi32dll: bitblt.c. Fix copying from uninitialized memory
by Dmitry Timoshkov Feb. 20, 2008

Feb. 20, 2008

"Alexander Demakin" <avd(a)etersoft.ru> wrote: > This patch adds check of return value of GetDIBits in BitBlt.c. If a error > occurs, GetDIBits returns 0 and bits variable points to uninitialized data. > It always occurs when calling BitBlt for printer context due to > implementation of PSDRV_SelectBitmap(). > Changelog: > gdi32.dll Fix copying from uninitialized memory. You are mixing tabs and spaces in the patch, otherwise tha patch looks good to me. -- Dmitry.

1 0

Re: dlls/msi/streams.c type fixes
by James Hawkins Feb. 20, 2008

Feb. 20, 2008

On Feb 17, 2008 6:23 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > This patch contains one or two items from my November patch the core > of which was independently recreated by Marcus and accepted and one > or two additional changes. It addresses the following warnings: > > streams.c: In function 'streams_set_table_size': > streams.c:59: warning: comparison between signed and unsigned > streams.c: In function 'STREAMS_delete': > streams.c:379: warning: comparison between signed and unsigned > streams.c: In function 'STREAMS_find_matching_rows': > streams.c:404: warning: comparison between signed and unsigned > > Gerald > > ChangeLog: > Adjust the signedness of three variables and add a comment for > add_streams_to_table(). > > Index: streams.c > =================================================================== > RCS file: /home/wine/wine/dlls/msi/streams.c,v > retrieving revision 1.11 > diff -u -3 -p -r1.11 streams.c > --- streams.c 16 Feb 2008 15:59:26 -0000 1.11 > +++ streams.c 17 Feb 2008 12:17:50 -0000 > @@ -39,7 +39,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(msidb); > > typedef struct tabSTREAM > { > - int str_index; > + UINT str_index; > LPWSTR name; > IStream *stream; > } STREAM; > @@ -54,7 +54,7 @@ typedef struct tagMSISTREAMSVIEW > UINT row_size; > } MSISTREAMSVIEW; > > -static BOOL streams_set_table_size(MSISTREAMSVIEW *sv, int size) > +static BOOL streams_set_table_size(MSISTREAMSVIEW *sv, UINT size) > { > if (size >= sv->max_streams) > { > @@ -372,7 +372,7 @@ static UINT STREAMS_modify(struct tagMSI > static UINT STREAMS_delete(struct tagMSIVIEW *view) > { > MSISTREAMSVIEW *sv = (MSISTREAMSVIEW *)view; > - int i; > + UINT i; > > TRACE("(%p)\n", view); > > @@ -440,6 +440,7 @@ static const MSIVIEWOPS streams_ops = > }; > > static INT add_streams_to_table(MSISTREAMSVIEW *sv) > + /* Return -1 in case of error. */ > { > IEnumSTATSTG *stgenum = NULL; > STATSTG stat; > Don't add random comments like this. -- James Hawkins

2 1

Re: shell32: Support getting the shell folder path for users other than the current user and the default user (take 2)
by Alexandre Julliard Feb. 20, 2008

Feb. 20, 2008

"Ge van Geldorp" <ge(a)thinstall.com> writes: > else > { > + LPWSTR sidStr = NULL; > LPCWSTR userPrefix = NULL; > HKEY hRootKey; This is not used anywhere. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [advapi32] QueryServiceConfig2 (3rd try) [resend]
by Alexandre Julliard Feb. 20, 2008

Feb. 20, 2008

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > + switch(dwLevel) { > + case SERVICE_CONFIG_DESCRIPTION: { > + static const WCHAR szDescription[] = {'D','e','s','c','r','i','p','t','i','o','n',0}; > + LPSERVICE_DESCRIPTIONW config = (LPSERVICE_DESCRIPTIONW) buffer; > + *needed = sizeof (SERVICE_DESCRIPTIONW); > + sz = size - *needed; > + r = RegQueryValueExW( hKey, szDescription, 0, &type, (LPBYTE) (config ? config + 1: NULL), &sz ); > + if((r == ERROR_SUCCESS) && ( type != REG_SZ)) { > + FIXME("SERVICE_CONFIG_DESCRIPTION: don't know how to handle type %d\n", type); > + return FALSE; > + } > + *needed += sz; > + if(config) { > + if(r == ERROR_SUCCESS) > + config->lpDescription = (LPWSTR) (config + 1); > + else > + config->lpDescription = NULL; You are still not handling overflows correctly. What happens if size is less than sizeof(SERVICE_DESCRIPTIONW)? -- Alexandre Julliard julliard(a)winehq.org

1 0