March 2008 - Wine-Devel - list.winehq.org

Re: [Tools 6/6] winetest: Issue a better description than '.' for the special failure modes. Write them as a note so they stand out better.
by Paul Vriens March 17, 2008

March 17, 2008

Francois Gouget wrote: > --- > winetest/gather | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/winetest/gather b/winetest/gather > index b502345..ee49f4a 100755 > --- a/winetest/gather > +++ b/winetest/gather > @@ -329,21 +329,21 @@ sub singletest($$$) { > EOF > } elsif ($count eq "winetest crash") { > print OUT <<"EOF"; > - <td class="result fail also-skip"><a > + <td class="note"><a > title="Test did not run as winetest crashed" > - >.</a></td> > + >winetest</a></td> > EOF > } elsif ($count eq "file limit") { > print OUT <<"EOF"; > - <td class="result fail also-skip"><a > + <td class="note"><a > title="Test is missing because of a partial report file" > - >.</a></td> > + >truncated</a></td> > EOF > } elsif ($count eq "test missing") { > print OUT <<"EOF"; > - <td class="result fail also-skip"><a > + <td class="note"><a > title="Test did not run for an unknown reason" > - >.</a></td> > + >not run</a></td> > EOF > } else { > my $class = $error?"fail":$todo?"todo":"pass"; Hi Francois, We currently have these single '.' also when there are multiple failures for an OS that are actually the same failures. For example the missing dll's. There are several dll's missing on win95 and win98 so it would be nice to have this reflected in the group piece of the page. I think green with a blue border looks much nicer than the single '.' we are currently having. Other thoughts? The new page layout is now present and I must say it looks better although Wine looks a bit worse now because all the green is gone :-). -- Cheers, Paul.

2 1

First wine cpl available to test - the regional settings
by pure_evil＠mail.bg March 17, 2008

March 17, 2008

I made the first cpl (intl.cpl), and, the actual executable that goes with it. http://www.keepandshare.com/doc/view.php?id=460541&da=y that should link to a file called intl_wine.zip. It contains 2 things: intl.cpl which goes into c:\windows\system32 and a folder - winecontrolapplets containing the executable winelocalesetup.exe. The folder goes into c:\windows. when using "wine control", that should've added a "Locale settings" icon in the control panel, and launching it should execute the winelocalesetup.exe. For some reason, though, it only reads the reg values, when trying to write 'em, they revert. (haven't tested it on a winbox yet though; if writing sticks there, a possible bug? Using wine 0.9.57. Tested it on two openSuSe 10.3 boxes though.) Give the concept a test drive, see if the duality matching cpl/real executable is feasable etc, drop me a line on cpls in general - which ones should be emulated etc. If you're more interested in only the regional settings themselves, test 'em out on a few locales; I've already done the US one, also "LANG=bg_BG wine control" and "LANG=ru_RU wine control" appear to show logical stuff, but I have no way of knowing whether the other locales look good. Cheers, Stefanov

1 0

Re: gdi: Add a stub for GdipCreateFontFamilyFromName
by Michael Stefaniuc March 17, 2008

March 17, 2008

Adam Petaccia wrote: > This patch is needed for me to run Tabula Rasa. > > This is my first patch, so please tell if I've broken conventions. Please add the correct declarations for "struct GpFontCollection" and "struct GpFontFamily". If you cannot find those on MSDN then check Mono; that one seems to have them too. But please do not cut'n'paste. bye michael > ------------------------------------------------------------------------ > > diff --git a/dlls/gdiplus/font.c b/dlls/gdiplus/font.c > index be60843..e0a781c 100644 > --- a/dlls/gdiplus/font.c > +++ b/dlls/gdiplus/font.c > @@ -27,6 +27,9 @@ > > #include "gdiplus.h" > #include "gdiplus_private.h" > +#include "wine/debug.h" > + > +WINE_DEFAULT_DEBUG_CHANNEL(gdiplus); > > GpStatus WINGDIPAPI GdipCreateFontFromLogfontW(HDC hdc, > GDIPCONST LOGFONTW *logfont, GpFont **font) > @@ -99,3 +102,10 @@ GpStatus WINGDIPAPI GdipGetLogFontW(GpFont *font, GpGraphics *graphics, > > return Ok; > } > + > +GpStatus WINGDIPAPI GdipCreateFontFamilyFromName(GDIPCONST WCHAR *name, struct GpFontCollection *fontCollection, struct GpFontFamily **FontFamily) > +{ > + FIXME("GdipCreateFontFamilyFromName: stub!\n"); > + > + return Ok; > +} > diff --git a/dlls/gdiplus/gdiplus.spec b/dlls/gdiplus/gdiplus.spec > index 4aac0df..1fbc57a 100644 > --- a/dlls/gdiplus/gdiplus.spec > +++ b/dlls/gdiplus/gdiplus.spec > @@ -85,7 +85,7 @@ > @ stdcall GdipCreateCustomLineCap(ptr ptr long long ptr) > @ stub GdipCreateEffect > @ stub GdipCreateFont > -@ stub GdipCreateFontFamilyFromName > +@ stdcall GdipCreateFontFamilyFromName(ptr ptr ptr) > @ stub GdipCreateFontFromDC > @ stdcall GdipCreateFontFromLogfontA(ptr ptr ptr) > @ stdcall GdipCreateFontFromLogfontW(ptr ptr ptr) > diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h > index 09ef83f..cd6a7d5 100644 > --- a/dlls/gdiplus/gdiplus_private.h > +++ b/dlls/gdiplus/gdiplus_private.h > @@ -184,4 +184,9 @@ struct GpStringFormat{ > StringAlignment vertalign; > }; > > +struct GpFontCollection{ > +}; > + > +struct GpFontFamily{ > +}; > #endif > > > ------------------------------------------------------------------------ > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Consulting Communications Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart Handelsregister: Amtsgericht Stuttgart HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich

2 1

advapi32 security tests and Vista (PROCESS_ALL_ACCESS)
by Paul Vriens March 17, 2008

March 17, 2008

Hi, I'm now looking at some of the failures for the security tests on Vista. Apparently PROCESS_ALL_ACCESS which is defined as: #define PROCESS_ALL_ACCESS (STANDARD_RIGHTS_REQUIRED|SYNCHRONIZE|0xfff) is changed on Vista: #define PROCESS_ALL_ACCESS (STANDARD_RIGHTS_REQUIRED|SYNCHRONIZE|0xffff) Should I change the tests (CreateProcess) to check for both possibilities or should our PROCESS_ALL_ACCESS be changed? I'm not sure what implications the latter one has yet. Only that using that mask on other windows versions will/could fail. -- Cheers, Paul.

2 1

Re: shell32: Support getting the shell folder path for users other than the current user and the default user (take 4)
by Alexandre Julliard March 17, 2008

March 17, 2008

"Ge van Geldorp" <ge(a)thinstall.com> writes: > This is getting embarassing :). Fix memory leak. Now it fails make test: ../../../tools/runtest -q -P wine -M shell32.dll -T ../../.. -p shell32_test.exe.so shellpath.c && touch shellpath.ok shellpath.c:305: Test failed: SHGetFolderLocation(NULL, CSIDL_FAVORITES, 2, 0, &pidl) returned 0x80070006, expected E_FAIL make[2]: *** [shellpath.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cabinet.dll -> FDICopy: Test added
by Dmitry Timoshkov March 17, 2008

March 17, 2008

"Vitaly Perov" <vitperov(a)etersoft.ru> wrote: > +void CreateEmptyCab(void) > +{ > + static char file_array [] = {77, 83, 67, 70, 0, 0, 0, 0, 36, 0, 0, 0, 0, 0, 0, 0, 36, 0, 0, 0, 0, 0, 0, 0, 3, 1, > 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}; It should be 'static const char' ? > + FILE* fp; > + int i; > + > + fp = fopen("test1.cab", "wb" ); > + if (!fp) trace("Can't create file test1.cab\n"); That should be an assert. > + for (i = 0; i < sizeof(file_array); i++) > + fputc(file_array[i], fp); What about fwrite? > + fclose(fp); > +} Functions you add should be static. Use Win32 APIs to create a temporary file. Set tab size to 8, and avoid using tabs to indent code at all. Avoid trailing spaces. -- Dmitry.

1 0

explorer: add /startfile switch for starting files from file managers
by Vincent Povirk March 17, 2008

March 17, 2008

This patch adds a switch, /startfile, to explorer.exe, used as "wine explorer /startfile filename". It accepts a windows or unix path. It attempts to mimic what windows explorer does to start files and provide some visible (gui) feedback when it doesn't work. The idea is that wine.desktop can then be modified to use this switch instead of wine, solving the following problems when starting exe files from file managers: * File managers typically do not set the working directory to the directory that contains an exe when they start it. Setting the working directory is the default behavior for windows explorer, and many windows programs rely on it. * File managers naturally use the unix path to start files, and the wine binary passes the unix path along to the exe it starts, rather than translating it to a windows path (this can and probably should also be fixed somewhere else). * Windows explorer always starts exe files with quotes around the path in the command-line, even if the path does not contain spaces. The wine binary does not (and probably should not) add quotes in this situation. A few apps rely on the quotes. See http://bugs.winehq.org/show_bug.cgi?id=5224#c14 My last attempt created a new winelib program; apparently this functionality fits in explorer. -- Vincent Povirk

2 1

re: cabinet.dll -> FDICopy: Test added
by Dan Kegel March 17, 2008

March 17, 2008

Did you forget the patch?

1 0

Re: user32: test processing of expose events (try 3)
by Paul Vriens March 17, 2008

March 17, 2008

Clinton Stimpson wrote: > Simplified from first try by removing unecessary thread. > Also fixing style to other code in file (thanks for feedback). > > ChangeLog: > user32: test processing of expose events > > Thanks, > Clinton Stimpson > > > ------------------------------------------------------------------------ > > The patch has been committed but makes sure that the user32 tests currently don't run on win95 anymore. Can the MsgWaitForMultipleObjectsEx be changed to a MsgWaitForMultipleObjects? If so, I'll sent in a patch, if not we have to exclude this test for win95 (and will also sent a patch). -- Cheers, Paul.

2 2

Re: msvcrt: Implement wcscat_s (try 4)
by Alexandre Julliard March 17, 2008

March 17, 2008

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Added missing test You should also test that you aren't overflowing the buffer. This should help you find a bug in your implementation. -- Alexandre Julliard julliard(a)winehq.org

1 0