Wine-Devel

wine-devel@list.winehq.org

April 2008

148 participants
402 discussions

Re: user32: Implement GetWindowModuleFileName with tests (try 2)
by Alexandre Julliard April 1, 2008

April 1, 2008

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes: > @@ -3121,9 +3133,21 @@ UINT WINAPI GetWindowModuleFileNameA( HWND hwnd, LPSTR lpszFileName, UINT cchFil > */ > UINT WINAPI GetWindowModuleFileNameW( HWND hwnd, LPWSTR lpszFileName, UINT cchFileNameMax) > { > - FIXME("GetWindowModuleFileNameW(hwnd %p, lpszFileName %p, cchFileNameMax %u) stub!\n", > - hwnd, lpszFileName, cchFileNameMax); > - return 0; > + HINSTANCE hInst; > + UINT ret; > + TRACE("hwnd %p, lpszFileName %p, cchFileNameMax %u\n", hwnd, lpszFileName, cchFileNameMax); > + > + hInst = (HINSTANCE)GetWindowLongPtrW(hwnd, GWLP_HINSTANCE); > + if (!hInst) > + { > + if (hwnd == GetDesktopWindow() || !IsWindow(hwnd)) > + return 0; > + hInst = GetModuleHandleW(0); > + } > + > + ret = GetModuleFileNameW(hInst, lpszFileName, cchFileNameMax); > + TRACE("--> %d %s\n", ret, debugstr_wn(lpszFileName, ret)); > + return ret; This won't work across processes. -- Alexandre Julliard julliard(a)winehq.org

2 2

Valgrind errors up the yin-yang in CloseServiceHandle
by Dan Kegel March 31, 2008

March 31, 2008

I don't have the full results yet, but here's a clue as to today's warn+heap regression referred to in http://bugs.winehq.org/show_bug.cgi?id=12246 that affects every program: ==12026== Invalid read of size 4 ==12026== at 0x4BDAECD: RPCRT4_CloseBinding (rpc_binding.c:301) ==12026== by 0x4BE0DB3: I_RpcFreeBuffer (rpc_message.c:1116) ==12026== by 0x4BC0BB2: NdrFreeBuffer (ndr_clientserver.c:173) ==12026== by 0x49375E6: svcctl_CloseServiceHandle (svcctl_c.c:119) ==12026== by 0x492F024: CloseServiceHandle (service.c:1008) ... ==12026== Address 0x7f000ec0 is not stack'd, malloc'd or (recently) free'd ==12019== Invalid read of size 4 ==12019== at 0x46E7F47: RtlEnterCriticalSection (critsection.c:482) ==12019== by 0x4986763: RpcAssoc_ReleaseIdleConnection (rpc_assoc.c:408) ==12019== by 0x4987F32: RPCRT4_CloseBinding (rpc_binding.c:308) ==12019== by 0x498DDB3: I_RpcFreeBuffer (rpc_message.c:1116) ==12019== by 0x496DBB2: NdrFreeBuffer (ndr_clientserver.c:173) ==12019== by 0x493E5E6: svcctl_CloseServiceHandle (svcctl_c.c:119) ==12019== by 0x4936024: CloseServiceHandle (service.c:1008) ==12019== by 0x48F4206: main (wineboot.c:586) ==12019== Address 0x7f000da4 is not stack'd, malloc'd or (recently) free'd ==12019== Invalid read of size 4 ==12019== at 0x4986764: RpcAssoc_ReleaseIdleConnection (rpc_assoc.c:409) ==12019== by 0x4987F32: RPCRT4_CloseBinding (rpc_binding.c:308) ==12019== by 0x498DDB3: I_RpcFreeBuffer (rpc_message.c:1116) ==12019== by 0x496DBB2: NdrFreeBuffer (ndr_clientserver.c:173) ==12019== by 0x493E5E6: svcctl_CloseServiceHandle (svcctl_c.c:119) ==12019== by 0x4936024: CloseServiceHandle (service.c:1008) ==12019== by 0x48F4206: main (wineboot.c:586) ==12019== Address 0x7f000d8c is not stack'd, malloc'd or (recently) free'd

1 0

Jump to page: