April 2008 - Wine-Devel - list.winehq.org

Re: user32 : Temporarily disable test for _WIN64.
by Dmitry Timoshkov April 25, 2008

April 25, 2008

"Erik de Castro Lopo" <mle+win(a)mega-nerd.com> wrote: > The file dlls/user32/tests/edit.c currently doesn't compile when > configured with --enable-win64 because GWL_WNDPROC (in include/winuser.h) > is not defined when _WIN64 is defined. Then you need to fix the test instead of disabling it. -- Dmitry.

4 8

Re: [PATCH] advapi32: add more checks in CRYPT_CreateMachineGuid.
by Dmitry Timoshkov April 25, 2008

April 25, 2008

"Lei Zhang" <thestig(a)google.com> wrote: > I'm getting a crash in CRYPT_CreateMachineGuid() with native > rpcrt4.dll. This adds some checks to work around it. I assume that "native" == "win9x" in this case. > pRpcStringFree = GetProcAddress(lib, "RpcStringFreeW"); > + if (!pUuidCreate || !pUuidToString || !pRpcStringFree) goto CreateMachineGuidCleaup; It would be better to use A versions of APIs then instead of failing, -- Dmitry.

2 1

"make test" - only four tests failing!
by Dan Kegel April 25, 2008

April 25, 2008

"make test" is pretty darn close to passing; only four tests left to fix. (Oddly, different sets fail depending on display mode.) Details at the end of http://bugs.winehq.org/show_bug.cgi?id=9916 Let's get these fixed before code freeze!

2 1

Re: Add an include/config.h variable WINE_IS_WIN64 which is 1 whenconfigured with --enable-win64 and 0 otherwise.
by Dmitry Timoshkov April 25, 2008

April 25, 2008

"Erik de Castro Lopo" <mle+win(a)mega-nerd.com> wrote: > Add an include/config.h variable WINE_IS_WIN64 which is 1 whenconfigured with --enable-win64 and 0 otherwise. It would be helpful to at least provide an explanation why yo need this, and why _WIN64 macro is not enough. -- Dmitry.

2 1

Re: ntdll : Do not error out on AMD-64 architecture when compiling win64.
by Dmitry Timoshkov April 25, 2008

April 25, 2008

"Erik de Castro Lopo" <mle+win(a)mega-nerd.com> wrote: > +#if WINE_IS_WIN64 > + if (nt->FileHeader.Machine == IMAGE_FILE_MACHINE_AMD64) > + MESSAGE("Support for AMD-64 architecture in progress but not yet working\n"); > + else > +#endif What's the point of this? -- Dmitry.

2 1

Re: shel32/tests : Use LOWORD to extract rc from pointer.
by Dmitry Timoshkov April 25, 2008

April 25, 2008

"Erik de Castro Lopo" <mle+win(a)mega-nerd.com> wrote: > - rc=(int)ShellExecute(NULL, operation, file, parameters, directory, > - SW_SHOWNORMAL); > + rc=LOWORD(ShellExecute(NULL, operation, file, parameters, directory, > + SW_SHOWNORMAL)); > > if (rc > 32) > { > @@ -167,7 +167,7 @@ static int shell_execute_ex(DWORD mask, LPCSTR operation, LPCSTR file, > DeleteFile(child_file); > SetLastError(0xcafebabe); > success=ShellExecuteEx(&sei); > - rc=(int)sei.hInstApp; > + rc=LOWORD(sei.hInstApp); > ok((success && rc > 32) || (!success && rc <= 32), > "%s rc=%d and hInstApp=%d is not allowed\n", shell_call, success, rc); > > @@ -836,24 +836,24 @@ static void test_find_executable(void) > /* Don't test FindExecutable(..., NULL), it always crashes */ > > strcpy(command, "your word"); > - rc=(int)FindExecutableA(NULL, NULL, command); > + rc=LOWORD(FindExecutableA(NULL, NULL, command)); > ok(rc == SE_ERR_FNF || rc > 32 /* nt4 */, "FindExecutable(NULL) returned %d\n", rc); You need to change the type of rc to HINSTANCE and fix the comparisons instead. What happens if the returned HINSTANCE has a value <= 32 in its low word? -- Dmitry.

1 0

Re: dinput: Limit number of supported axis and buttons [try 2]
by Christoph Frick April 25, 2008

April 25, 2008

On Thu, Apr 24, 2008 at 09:04:11AM -0600, Vitaliy Margolen wrote: ok, don't beat me on this one (i guess i could have asked this also for try one): > + FIXME("Can't support %d axes. Clamping down to 16\n", newDevice->axes); > ... > + WARN("Can't support %d buttons. Clamping down to 128\n", newDevice->buttons); why is axes a FIXME and buttons a WARN? -- cu

2 1

Re: dnghelp : Fix pointer cast.
by Erik de Castro Lopo April 25, 2008

April 25, 2008

Erik de Castro Lopo wrote: > > Make the pointer cast safe for Wine64. Please disregard this one as there is a better patch on the way. Cheers, Erik -- ----------------------------------------------------------------- Erik de Castro Lopo ----------------------------------------------------------------- "Within C++, there is a much smaller and cleaner language struggling to get out." -- Bjarne Stroustrup

1 0

Re: [PATCH 06/12] widl: Create a statement object for import statements.
by Alexandre Julliard April 24, 2008

April 24, 2008

Robert Shearman <rob(a)codeweavers.com> writes: > Move the writing of include directives into the generated header into > header.c. This one doesn't work right, it doesn't output the #include statements so the resulting .h files don't compile. -- Alexandre Julliard julliard(a)winehq.org

1 0

Call for testers
by Eric Pouech April 24, 2008

April 24, 2008

Has you may have seen, a new rendering interface is now available for Winhelp It should be better (with the last row of patches) than the old one, but still not perfect And likely not bug free, hence the call for testers I'm waiting for some real feedback from real users about reading your old .hlp files The new rendering is turned on by setting the env variable WINHELP_RICHEDIT to 1 A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0