May 2008 - Wine-Devel - list.winehq.org

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

re: Wine t-shirts?
by Dan Kegel Sept. 3, 2009

Sept. 3, 2009

Maarten wrote: > Why don't we have wine t-shirts any more? I dunno, where were they before? I just looked, couldn't find any on cafepress.com. I'd like to bring back the Codeweavers drunken penguin t-shirts, perhaps with a slightly more generic Wine design. Coincidentally, I found some site on the net had taken the logo from that shirt and erased the Crossover logo from the wine bottle; here's a cleaned-up copy: http://kegel.com/wine/wine-penguin-corkscrew.png

15 34

winequartz.drv Mac OS X UI discontinued?
by Adam Strzelecki July 11, 2009

July 11, 2009

Hi, I know that CodeWeavers supports quite nicely Mac builds of Wine, and CrossOver for Mac, yet all of them are X11. There was also once Darwine - an effort to provide Carbon Wine UI driver and Mac optimizations & L&F. Pretty many of those were merged back to Wine, but not winequartz.drv. Do you guys think about reviving winequartz.drv? This would greatly improve Wine on Mac as we could have native Mac fonts handling that's faster than FreeType, Dock icons for Wine applications, and few others. There's still old copy of the it hanging around, but it is abandoned, and no longer compiles with Wine. Or I think it would be cool to write new winecocoa.drv or sthing like that, as Apple officially states that Carbon is deprecated. While it is not well documented, it is pretty easy with Cocoa to make console non-bundled process to be UI foreground process and handle events and Dock: (This code is copyrighted by myself ;P) > int main(int argc, const char * argv[]) { > ProcessSerialNumber psn = {0, kCurrentProcess}; > OSStatus returnCode = TransformProcessType(&psn, > kProcessTransformToForegroundApplication); > SetFrontProcess(&psn); > > NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init]; > [NSApplication sharedApplication]; > > NSImage *icon = [NSImage imageNamed:@"NSApplicationIcon"]; > [NSApp setApplicationIconImage:icon]; > > [NSApp finishLaunching]; > > NSWindow *window = [[NSWindow alloc] > initWithContentRect:NSMakeRect(0, 0, 100, 100) > styleMask:NSTitledWindowMask| > NSClosableWindowMask|NSMiniaturizableWindowMask|NSResizableWindowMask > backing:NSBackingStoreBuffered defer:NO]; > [window center]; > [window setTitle:@"Test"]; > > NSButton *button = [[NSButton alloc] > initWithFrame:NSMakeRect(10, 10, 80, 80)]; > [button setTitle:@"What?"]; > [button setBezelStyle:1]; > [[window contentView] addSubview:button]; > [button release]; > > [window makeKeyAndOrderFront:NSApp]; > > while(1) { > NSEvent *event = [NSApp > nextEventMatchingMask:NSAnyEventMask > untilDate > :[NSDate distantFuture] > inMode:NSDefaultRunLoopMode > dequeue:YES > ]; > if(event) [NSApp sendEvent:event]; > } > [pool release]; > return 0; > } BTW. I heard that someone previously working for Wine project is now in Apple, it is true? Regards, -- Adam Strzelecki |: nanoant.com :|

20 55

Wine desktop integration: current directory of app launched with doubleclick?
by Dan Kegel Feb. 15, 2009

Feb. 15, 2009

I *almost* have a great success story to report; the only thing keeping it from being a success story is the current directory chosen by Nautilus when double-clicking on .exe files. My wife hurt a finger trying to impersonate a Sampsonite Luggage gorilla, and had to go to a hand doctor. Along the way her hand got x-rayed, and the doctor handed her a cd-rom with the x-ray pictures on it. The disc has an autorun.inf on it that should start ViewSel.exe. I don't know if that's supposed to work with Wine and Nautilus, but probably doubleclicking on ViewSel.exe does the same thing. ViewSel.exe puts up two big buttons: low res (which launches a web browser on an html file), and high res (which launches a DICOM viewer). If you cd to the root of the cd-rom drive and run ViewSel, it works. If the current directory is anything else, it doesn't work. If you start the autorun app via Nautilus, those buttons don't work, so presumably it sets the current directory to something other than the root of the drive. To see, I created a wrapper shell script, ~/bin/mywine, containing #!/bin/sh pwd > /tmp/log and used "Start with" to launch ViewSel.exe with ~/bin/mywine. This showed that the current directory was $HOME. I had a look at the gnome code to see how it decided, but it was a bit hard to follow. (See gnome_vfs_mime_application_launch_with_env.) So I tried a little shell magic. I created a new wrapper shell script that assumes the argument is a path to a file, and sets the current directory to the directory containing that file: #!/bin/sh DIR=`dirname "$1"` DIR=`cd "$DIR"; pwd` cd "$DIR" wine "$@" That worked better; it let ViewSel.exe launch the DICOM viewer. So... I suppose the next step is to look at the debian/ubuntu packages for wine and see if that little wrapper script could be incorporated into the default way file browsers start wine? It sure would be nice if apps that expected the current directory to behave like this (it's not uncommon!) Just Worked. - Dan

4 9

Free apps bundled with msvcp71?
by Dan Kegel Sept. 29, 2008

Sept. 29, 2008

Adobe Contribute 4, released in Nov 2006 or so, had a nice online trial at http://trials.adobe.com/Applications/Contribute/Adobe_Contribute_4_Win/Adob… and still online, I think, at http://www.soft32.com/download/63-129953-1/Adobe_Contribute_4_Win.exe Starting it fails with err:module:import_dll Library MSVCP71.dll (which is needed by L"C:\\Program Files\\Adobe\\Contribute 4\\CoreTypes.dll") not found Wine has a nice implementation of msvcr71.dll, but not the C++-oriented msvcp71.dll, nor is it likely to get one soon. This brings back the question: what's a good place to legally and freely download an application bundled with a full set of msvcp71.dll et al? Ideally something at Microsoft.com and/or something small and suitable for use in winetricks. Any ideas? - Dan

2 3

mono progress on mixed-mode assemblies...
by Dan Kegel Aug. 2, 2008

Aug. 2, 2008

http://lists.ximian.com/pipermail/mono-devel-list/2008-May/027767.html shows that Pál Kornél is now working on supporting apps that use msvcrt. Go Pal go!

7 15

Lots of input messages lingering in server slowing down wine tremendously?
by Alexander Dorofeyev July 8, 2008

July 8, 2008

Hi. There was a problem found recently in a fan-made mod of Forsaken (game), that certain input combinations were slowing wine very seriously. Holding down a keyboard button and moving mouse was found to be especially devastating to performance (200 fps to 10fps in a matter of 10-20 seconds). With help from people who develop this mod, I was able to isolate it in a very small and simplistic testcase, which shows this same problem. It will be included as attachment. Holding a key and moving mouse over the window steadily increases main loop latency from 10 to 50 (and even 100) in a short time, especially so if quickly clicking both mouse buttons as well. In a game this means going from 100 fps to 20 or 10 just because of input messages. Has to be noted that in the actual game the rate of slowdown seemed at least 2-3 times faster for reasons I don't know, but the testcase still should enough to show the problem. Now, I do realize that what the testcase is doing is bad practice, it's basically refusing to process certain types of messages, and PeekMessage just once during a loop is probably bad as well, but that's what the game was originally doing in its main game loop. They do plan to fix it in the game. Still, there are several concerns about it: 1) No slowdown happens of Windows as far as I can tell. No matter how much I move the mouse holding key and clicking madly, it shows same stable 15-16 ticks latency in the testcase. I don't know what it does, but somehow it handles this situation better than Wine. 2) Can this (broken) way of doing things be exposing some inefficiency in message handling, maybe something that could use optimization? I tried to put debug hacks into queue_hardware_message(), it seems that when slowdown is already VERY bad in Forsaken (10fps), message queue in wine server has about 400 or maybe 600 messages. Is that kind of processing overhead per message inevitable? (This is happening on AMD Athlon(tm) 3200+). Perhaps somebody who knows that part of code well may be interested in looking into performance issues in this case. Because, if 400-600 messages in the queue slow down the application to a crawl, then who knows, perhaps it decreases performance of more well-behaved but input-intensive apps as well, just less drastically (holding one or several keys to move, all the while aiming with mouse and abusing mouse buttons is a common thing in games, so there can be quite a few input messages flooding the server). The reason I decided to post it to wine-devel is because I'm not sure if this kind of thing is expected and unavoidable or a bug that can be fixed, so better to hear some comments first, then a bug entry can be opened if needed. #include <windows.h> HWND window; int PASCAL WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nCmdShow) { WNDCLASS wc = {0}; MSG msg; DWORD ticks, ticks2; HHOOK kbd_hook, mouse_hook; wc.lpfnWndProc = &DefWindowProc; wc.lpszClassName = "testwc"; RegisterClass(&wc); window = CreateWindow("testwc", "test", WS_OVERLAPPED | WS_VISIBLE | WS_CAPTION , 0, 0, 640, 480, 0, 0, 0, 0); ticks = GetTickCount(); for (;;) { if (PeekMessage(&msg, NULL, WM_NULL, WM_KEYFIRST, PM_REMOVE)) { if (msg.message == WM_QUIT) { DestroyWindow(window); break; } TranslateMessage(&msg); DispatchMessage(&msg); } //simulated work ticks2 = GetTickCount(); for (;;) { UINT i; volatile int dummy = 1; for (; i < 10000 && dummy; i++) ; if (GetTickCount() - ticks2 >= 10) break; } printf("main loop %u tick latency\n", GetTickCount() - ticks); ticks = GetTickCount(); } }

2 1

Alternate shell?
by Dan Kegel July 6, 2008

July 6, 2008

For a maximal dogfood experience, I was looking around for a way to use a replacement Windows shell with Wine as my desktop environment instead of gnome or kde. So far, all the ones I've found are either broken, hard to use, or just plain weird. I've been working through the list at http://www.dmoz.org/Computers/Software/Operating_Systems/Microsoft_Windows/… http://www.astonshell.com/aston/ - couldn't figure out how to run it? http://www.emergedesktop.org/ - kind of works, but very minimal, no start menu http://www.labyrinth.net.au/~mosses/rob/liteshell.html - works, but very minimal, no start menu http://purels.org - no help, just exits, saying "ha ha, you didn't configure me". Obviously not meant for me :-) http://www.lighttek.com/talisman.htm - pretty, but no Programs menu?! (Maybe that's there but broken, wine bug?) http://www.sky.franken.de/explorer/download.html - ROS explorer - prebuilt binary there is 3 years out of date, doesn't work too well Anyone have a favorite I should try? - Dan

11 19

New winetricks 20080402: new verbs dotnet20, win2k, flash, msls31; updated mono, liberation
by Dan Kegel July 3, 2008

July 3, 2008

Big news: as of today or so, wine doesn't need any patches to install the .net 2.0 runtime or run trivial .net 2.0 apps, so I've added a dotnet20 verb. No more futzing with recipes to try out simple .net 2 apps, huzzah! There are lots of other little changes, too: 20080402 r21 Added dotnet20, removed one kludge from dotnet11, added win2k verb, plus shorthand for winver=foo r20 Updated liberation fonts. 20080328 r19 Added flash. 20080326 r18 Fix i18n problem reported by Ricardo Cabral 20080321 r17 Added msls31 (seems to be needed by e-Sword) 20080317 r16 update mono12 to 1.2.9 ... As always, winetricks is downloadable from http://kegel.com/wine/winetricks and change history is at http://code.google.com/p/winezeug Thanks to the folks who keep feeding me improvements and suggestions! - Dan

4 3

today's valgrind results online
by Dan Kegel June 23, 2008

June 23, 2008

Online at http://kegel.com/wine/valgrind/20071002/ (I now include more info about memory leaks, but I still only report anything if there was an invalid memory reference.) The following tests were fixed in git yesterday, and no longer have any valgrind warnings: comctl32/rebar comctl32/status crypt32/chain crypt32/crl crypt32/msg cryptnet/cryptnet user32/msg wintrust/softpub Juan thinks nearly all of the remaining crypt32 errors can be suppressed (some are intentional). Here are the directories that still have warnings: advapi32 advpack cabinet comctl32 crypt32 d3d8 d3d9 d3dx8 dplayx dsound gdi32 gdiplus hlink kernel32 mlang msacm32 mscms mshtml msi msvcrt msxml3 netapi32 ntdll ole32 oleaut32 quartz riched20 riched32 rpcrt4 rsaenh setupapi shdocvw shell32 urlmon user32 usp10 wininet winmm wintrust - Dan

3 4

Re: ole32: Fix a failed call to DllGetClassObject while retrieving class object interface pointer.
by Robert Shearman June 17, 2008

June 17, 2008

Huang, Zhangrong wrote: > See dlls/ole32/compobj.c, > > static HRESULT apartment_getclassobject(struct apartment *apt, LPCWSTR dllpath, > BOOL apartment_threaded, > REFCLSID rclsid, REFIID riid, > void **ppv) > { > ................... > if (SUCCEEDED(hr)) > { > .................. > TRACE("calling DllGetClassObject %p\n", > apartment_loaded_dll->dll->DllGetClassObject); > /* OK: get the ClassObject */ > hr = apartment_loaded_dll->dll->DllGetClassObject(rclsid, riid, ppv); > ^^^^ > if (hr != S_OK) > ERR("DllGetClassObject returned error 0x%08x\n", hr); > } > .............. > } > > Reference to http://msdn2.microsoft.com/en-us/library/ms680760.aspx, > > riid > > [in] Reference to the identifier of the interface that the caller > is to use to communicate with the class object. Usually, this is > IID_IClassFactory (defined in the OLE headers as the interface > identifier for IClassFactory). > This doesn't mean anything other than CoCreateInstance is usually used instead of CoGetClassObject (and CoCreateInstance always passes in IID_IClassFactory for the IID). > We can't pass riid to DllGetClassObject directly sometimes, causes some dlls' > DllGetClassObject (like native adsldp.dll) can only return reference-counted > pointer to class factory via IID_IClassFactory, for retrieving the > pointer to the > class object interface requested in riid, we must try another way. > Thank you for your patch, but this behaviour seems a little strange and needs a little more investigation before I am happy that it is correct. What parameters are being passed in to CoGetClassObject to cause the call to fail for you? -- Rob Shearman

5 12

re: Bugs in Wine research
by Dan Kegel June 14, 2008

June 14, 2008

tomecek wrote: > we are students from Department of computer science at Aalborg > university. During this semester we were working on project on static > analysis using the Coccinelle tool > (http://www.emn.fr/x-info/coccinelle/) and Flawfinder > (http://en.wikipedia.org/wiki/Flawfinder) We decided to search for > bugs in Wine source code. Great, thanks! We didn't have a wiki page about static analysis and Wine yet, so I created one, http://wiki.winehq.org/StaticAnalysis At least a couple of the memory leaks you found seem like they might be worth fixing. If you could put your full results up somewhere, and link to them from that wiki page, we'll take a look.

3 4

Re: Bugs in Wine research
by tomecek＠cs.aau.dk June 14, 2008

June 14, 2008

> Dan Kegel wrote: >> James McKenzie <jjmckenzie51(a)sprintpcs.com> wrote: >>>>> we are students from Department of computer science at Aalborg >>>>> university. During this semester we were working on project on static >>>>> analysis using the Coccinelle tool >>>> http://wiki.winehq.org/StaticAnalysis >>> I was wondering if results from Wine 0.9.57 would continue to be valid? >>> Maybe the effort could shift to RC1? >> >> Sure, lots of the unused vars bugs in particular are probably >> already fixed. But the other issues have a pretty good >> chance of still being valid. >> > > Are there any volunteers to do this? > > My experience with Wine C code is fairly minimal, but it shouldn't be > too hard to look at one of their changes and see if it applies to > current git, and if it does just forward-port it. > > Thanks, > Scott Ritchie > > > > Hi, the complete results are available at http://www.cs.aau.dk/~dechouxb/results/complete/, the scripts used at http://www.cs.aau.dk/~dechouxb/cocci_scripts/done/. It is valid for Wine 0.9.57. Sorry for the delay, we were very busy. Unfortunately we cannot rerun the tests because we are leaving Aalborg University in 3 weeks. If you are interested I should be able to rerun these tests (with some improvements) at my home university during late August and September. Jaroslav Tomecek ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program.

3 2

Re: user32: Allow a NULL foreground window in the tests
by Dmitry Timoshkov June 14, 2008

June 14, 2008

"James Hawkins" <jhawkins(a)codeweavers.com> wrote: > According to msdn, "The foreground window can be NULL in certain > circumstances, such as when a window is losing activation. " which is > exactly when these failures occur. > > Changelog: > * Allow a NULL foreground window in the tests. NULL foreground window is already allowed, you just need to fix the callers of check_wnd_state() to pass 0 for foreground. -- Dmitry.

2 11

Fixing crashes in Tests (OS version check)
by Alistair Leslie-Hughes June 4, 2008

June 4, 2008

Hi, I've being investigating crashes that occur on Win98 when the tests run. I have fixed a couple already which where trivial. When I attempted to fix the snmpapi tests, I have found that i will end up removing alot of tests (~ 17). If I add a check for the windows version, I can skip the tests that will crash, also there is already tests with if(0) around them. What is the policy about checking the version of the OS before running certain tests? Best Regards Alistair Leslie-Hughes

8 11

Winetest grrr...
by Juan Lang June 2, 2008

June 2, 2008

Since my tiny little menu patch didn't go in, I figured Alexandre wanted a test. So I tried to compile and run the existing one on Windows XP. It failed for me: lots of menu size tests failed. I checked the test.winehq.org data, and I don't see lots of failures on XP, so... I thought I'd run winetest.exe from Paul Millar's site, just in case the compilation environment had something to do with it. That locks up my laptop somewhere in the d3d/ddraw tests. I know some video drivers are so broken we don't want to run on them. I have an ATI Radeon Mobility 250. I thought this was a fairly common card. Is locking up the machine really acceptable here? How the ^$*@ am I supposed to produce a test when the existing ones fail/crash/burn for me? Grrr... --Juan

5 9

Re: [2/2] ddraw: Rename IDirectDraw functions (try 2)
by Christian Costa June 1, 2008

June 1, 2008

Hi Michael, I think it would be better to fix function names in IDirectDraw7. Christian Michael Karcher a écrit : > The functions implementing IDirectDraw are called IDirectDrawImpl_Foo, > the ones implementing IDirectDraw7 are called alike. As they are > static functions in different files, the compiler has no problems > distinguishing them, but it confuses the reader of TRACE messages. > --- > dlls/ddraw/ddraw_thunks.c | 92 ++++++++++++++++++++++---------------------- > 1 files changed, 46 insertions(+), 46 deletions(-) > > ------------------------------------------------------------------------ > >

3 3

Re: ddraw: Don't release ddraw if a surface is still using it.
by Michael Karcher May 31, 2008

May 31, 2008

Am Samstag, den 31.05.2008, 12:08 +0200 schrieb Jens Albretsen: The patch looks like it would work as advertised, but the following snippet in the testcase smells fishy: > +static unsigned long getRefcount(IUnknown *iface) > +{ > + IUnknown_AddRef(iface); > + return IUnknown_Release(iface); > +} [...] > + IDirectDraw_Release(lpDD); > + > + ref = getRefcount(lpDD); > + ok(ref == 0, "Got refcount %ld, expected 0\n", ref); > + > + IUnknown_Release(surface); The IDirectDraw_Release seems to be dropping the reference count of the DirectDraw object to zero. This is OK, of course, as you might well drop the last reference. But this might put the DirectDraw object into a state where AddRef crashes, as parts of the object might get destroyed when the reference count drops down to zero. On wine, there is obviously no problem, as wine keeps the DirectDraw object itself alive for longer. On Windows, it is not clear to me that the DirectDraw object is not destroyed at the IDirectDraw_Release, the only thing we know is, that Direct Draw still is working (perhaps implemented by a subobject of the DirectDraw object which keeps living). I suggest to alternatively write the second part as + ref = IDirectDraw_Release(lpDD); + ok(ref == 0, "Got refcount %ld, expected 0\n", ref); + + IUnknown_Release(surface); Regards, Michael Karcher

3 3

MinGW RPM packages - discontinued
by Hans Leidekker May 31, 2008

May 31, 2008

Hi all, This is a message for those who used or contributed to the cross compiler packages available from this URL: http://mirzam.it.vu.nl/mingw/ Quoting myself from that page: I have decided to stop maintaining these packages. The original incentive to create these packages was to be able to build Wine's test suite as PE executables on Fedora. Wine recently changed its build system to use Wine's own headers and import libraries when cross compiling the test suite, which means that the mingw-w32api package (where most of the action was) is no longer needed. Another reason is that I'm moving towards Ubuntu as my main development platform. -Hans

3 3

Re: #1 wininet: Make resolving hostnames thread-safe. try2
by Rob Shearman May 31, 2008

May 31, 2008

2008/5/31 Hans Leidekker <hans(a)it.vu.nl>: > Make resolving hostnames thread-safe. > > +/* critical section to protect non-reentrant gethostbyname() */ > +CRITICAL_SECTION cs_gethostbyname; > +static CRITICAL_SECTION_DEBUG critsect_debug = > +{ > + 0, 0, &cs_gethostbyname, > + { &critsect_debug.ProcessLocksList, &critsect_debug.ProcessLocksList }, > + 0, 0, { (DWORD_PTR)(__FILE__ ": cs_gethostbyname") } > +}; > +CRITICAL_SECTION cs_gethostbyname = { &critsect_debug, -1, 0, 0, 0, 0 }; cs_gethostbyname should be static. -- Rob Shearman

1 0

Re: Fix debug log incosistencies and function naming
by Vitaliy Margolen May 31, 2008

May 31, 2008

Michael Karcher wrote: > Debugging DirectDraw reference counting is confusing, > as the IDirectDraw{,2,3,4}_AddRef methods dump to ddraw_thunk, > whereas the matching Release methods dump to ddraw. This > patch changes to consistently use the ddraw channel. > > Furthermore, as the methods from IDirectDraw7 are named > like "IDirectDrawImpl_Foo", the functions from IDirectDraw > (Direct Draw 1) get renamed to "IDirectDraw1Impl_Foo" to > avoid non-unique function names in trace logs. > --- Please make it two patches. One to change debug channel. Second to rename IDirectDrawImpl into IDirectDraw1Impl. Vitaliy.

1 0

Re: winex11.drv: Place tablet cursors in slots based on type
by James Hawkins May 31, 2008

May 31, 2008

On Sat, May 31, 2008 at 12:19 PM, John Klehm <xixsimplicityxix(a)gmail.com> wrote: > This patch looks bigger than it really is. A more detailed changelog is this: > No, it's as big as it seems. > - I've added a lot of comments describing how cursor slotting works. > - added code to slot the cursor appropriately from the get go > - use local memory to temporarily store cursor info before slotting it > (this change results in a lot of inserts deletes of '->' to '.' ) > - iterate through cursors with CURSORMAX and ACTIVE instead of gNumCursors > - cursors will always have a type now: PEN, ERASER, or OTHER > - removed cursor slot fixup code. no longer needed > - removed counters used to place the cursor in slot. no longer needed > Each one of those items should be a separate patch. -- James Hawkins

1 0

Re: dxdiagn: PhysicalMemory parameter is a string not long long
by Vitaliy Margolen May 31, 2008

May 31, 2008

Vitaliy Margolen wrote: > --- > dlls/dxdiagn/provider.c | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) > Was anything wrong with this patch? I've used a simple utility DxDiagOutput.exe from DXSDK to find and test this. Vitaliy.

2 4

Re: [PATCH] WM_IME_SETCONTEXT is sent when a window is activated
by Vitaliy Margolen May 31, 2008

May 31, 2008

Christopher GAUTIER wrote: > Changelog: > * dll/user32/defwnd.c: > WM_IME_SETCONTEXT is sent when a window is activated > > Description: > The WM_IME_SETCONTEXT message should be sent when a window is (de)activated > (source: http://msdn.microsoft.com/en-us/library/ms776117(VS.85).aspx) > The value for lParam was obtained by spying on the messages when > activating and deactivating the window. > Please add a test for this to user32/test/msg.c test Vitaliy.

1 0

wine site: Translate sendind_patches to Spanish in web.site.git
by Ángel Guzmán Maeso May 30, 2008

May 30, 2008

My patch needs commit. Changelog: Add translation Spanish to sending_patches in Wine site http://www.winehq.org/pipermail/wine-patches/2008-May/055157.html <http://www.apogeus.es>

4 14

Wine 1.0-rc3 build fails
by John Voltz May 30, 2008

May 30, 2008

Hi, I just tried building rc3 on Fedora 9, and it fails with this: make[2]: Entering directory `/home/john.voltz/workspace/wine/dlls/user32/tests' gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o broadcast.o broadcast.c gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o class.o class.c gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o clipboard.o clipboard.c gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o combo.o combo.c gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o cursoricon.o cursoricon.c gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o dce.o dce.c gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o dde.o dde.c gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o dialog.o dialog.c gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o edit.o edit.c gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o generated.o generated.c gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o input.o input.c gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o listbox.o listbox.c gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o menu.o menu.c {standard input}: Assembler messages: {standard input}:7412: Warning: end of file not at end of a line; newline inserted {standard input}:7745: Error: unknown pseudo-op: `.l' gcc: Internal error: Segmentation fault (program cc1) Please submit a full bug report. See <http://bugzilla.redhat.com/bugzilla> for instructions. make[2]: *** [menu.o] Error 1 make[2]: Leaving directory `/home/john.voltz/workspace/wine/dlls/user32/tests' make[1]: *** [user32/tests] Error 2 make[1]: Leaving directory `/home/john.voltz/workspace/wine/dlls' make: *** [dlls] Error 2

2 1

Ubuntu Popularity Contest - 37% Wine install base, 10% who use, and 7% who use regularly
by Scott Ritchie May 30, 2008

May 30, 2008

The Ubuntu "popcon" package is installed when a user opts to share anonymous usage data during the install process (or within the synaptic package manager). Analyzing the data (http://popcon.ubuntu.com/) we can see the following for Wine: wine 215262 installed 41731 use regularly 156710 don't use compare this with dpkg, which every Ubuntu system has: dpkg 576989 installed 151098 use regularly 411213 don't use Doing some division, this means that a rather high 37% of Ubuntu users have Wine installed, and 10% of all Ubuntu users actually make use of Wine. 7% use Wine "frequently", however popcon defines that. Combine this with other estimates of Ubuntu's user base (about 8 million last I heard), and you have approximately 800,000 Wine users. This data is slightly biased - it doesn't include most Wubi users who installed Ubuntu from within Windows, since they aren't given any installation questions. I believe, though can't prove, that this means we are under-representing Wine users, as it seems reasonable that Wubi installs would be more likely to have Windows applications to run and thus need Wine. Thanks, Scott Ritchie

3 3

README: Few more updates
by Austin English May 30, 2008

May 30, 2008

Anything wrong with this patch? http://www.winehq.org/pipermail/wine-patches/2008-May/055215.html

2 2

Double free in direct sound capture
by Michael Karcher May 30, 2008

May 30, 2008

Hello developers I was running the testcases with warn+heap, and noted some warnings from dsound:capture. They are caused by double free calls, and only happen with winealsa.drv, not with wineoss.drv. The following patch happens to makes the messages disappear. Could somebody with some knowledge about wine's DirectSound implementation please look into this issue and find a proper fix? Regards, Michael Karcher

2 2

Re: mscms/tests: The presence of an ICM file in the color directory has nothing to do with the presence of a registered RGB profile.
by Paul Vriens May 30, 2008

May 30, 2008

Francois Gouget wrote: > --- > > The tests were failing on my Windows systems because they have ICM files > in the color directory but they are not registered, i.e. they don't > even have the HKLM\Software\Microsoft\Windows > NT\CurrentVersion\ICM\RegisteredProfiles key. > > What matters for GetStandardColorSpaceProfile() is that that the > relevant value is set in HKLM\Software\Microsoft\Windows > NT\CurrentVersion\ICM\RegisteredProfiles. It may also check the presence > of the file but the presence of an 'srgb*.icm' file in the color > directory is by no means sufficient. > > > dlls/mscms/tests/profile.c | 33 ++++++++++++++++++++++----------- > 1 files changed, 22 insertions(+), 11 deletions(-) > > > ------------------------------------------------------------------------ > > This addition to the tests checks for a registry entry: + if (strcmp(szName, "RGB") == 0) + *has_space_rgb = TRUE; I see several systems (test.winehq.org) including some of mine that have "RGB " (extra space at the end). It seems that the logic that was added for has_space_rgb is also valid for "RGB ". Any idea? -- Cheers, Paul.

1 0

Re: msxml3: Fix crashes on win98
by Paul Vriens May 30, 2008

May 30, 2008

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > msxml3: Fix crashes on win98 > > Best Regards > Alistair Leslie-Hughes > > > ------------------------------------------------------------------------ > > Just a question. Why not use a goto to a cleanup session instead of having these huge indented blocks? Or is goto a bad thing by default? (I have the same 'issue' with the setupapi/devinst tests. All the tests in there have these big sets of indented code. In this setupapi case a simple return on failure would have been enough probably) -- Cheers, Paul.

2 1

Search for leftovers after running winetest
by Paul Vriens May 30, 2008

May 30, 2008

Hi, (Sorry, first one went to the wrong list) I just had a look at some of the stuff that's still around after running winetest a few months now on my W2K3 box (some of the regkeys are linked of course): Registry ======== HKEY_CLASSES_ROOT\Applications\shell32_test.exe HKEY_LOCAL_MACHINE\SOFTWARE\Classes\Applications\shell32_test.exe HKEY_CLASSES_ROOT\TypeLib\{D96D8A3E-78B6-4C8D-8F27-059DB959BE8A} HKEY_LOCAL_MACHINE\SOFTWARE\Classes\TypeLib\{D96D8A3E-78B6-4C8D-8F27-059DB959BE8A} (includes a reference to oleaut32_test.exe) HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\FileExts\.shlexec\OpenWithList (reference to shell32_test.exe) HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug (contains 'Debugger' which points to kernel32_test.exe) HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\StillImage\Debug\mscms_test.exe HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Enum\USB\BOGUS HKEY_LOCAL_MACHINE\SYSTEM\ControlSet001\Enum\USB\BOGUS HKEY_LOCAL_MACHINE\SYSTEM\ControlSet002\Enum\USB\BOGUS HKEY_CURRENT_USER\Software\Wine HKEY_LOCAL_MACHINE\SOFTWARE\Wine\msitest Filesystem ========== C:\Config.Msi C:\Documents and Settings\testuser (basically a testuser for each winetest run on xp+ systems) (Any maybe more) I'm wondering how this effects tests? Any ideas? Do other see the same leftovers? I also think we should remove all leftovers after the tests if possible. Nice janitorial task or important enough to be tackled quicker? -- Cheers, Paul.

2 3

Recent change causes registry creation to fail
by Benjamin M. Schwartz May 30, 2008

May 30, 2008

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I am trying to write a scripted wine installation in a nonstandard directory. As part of this procedure, I set $WINEPREFIX and then run wineprefixcreate. This worked perfectly in 0.9.59, but in 0.9.60+ it fails with wineserver: chdir to config dir : Not a directory wine: for some mysterious reason, the wine server failed to run "regedit" fails with the same error. Wine does run, but its registry appears to be screwy. For example, the DOS environment variables like %PROGRAMFILES% and %PATH% are not set at all. I have traced the error to a change made by Alexandre Julliard to registry.c in mid-April [1]. Why might that change have this effect? What should I do to avoid this problem? Thank you, Ben Schwartz OLPC volunteer [1] http://source.winehq.org/git/wine.git/?a=blobdiff;f=server/registry.c;h=d2c… -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkg/g8wACgkQUJT6e6HFtqTgdwCeM7S/HVIS8LU82qVQ5R3cs0Yt HGAAn3cQhdG4VR5H/2jbIbU7SS/uDRX4 =5Bd7 -----END PGP SIGNATURE-----

1 0

Re: advpack: don't close a handle if it wasn't opened
by James Hawkins May 30, 2008

May 30, 2008

On Thu, May 29, 2008 at 10:34 PM, Dan Kegel <dank(a)kegel.com> wrote: > Avoids referencing an undefined variable. > The right way to fix this is to set subkey to NULL in the beginning. -- James Hawkins

1 0

Currently Git doesn't build on Linux x86_64
by Erik de Castro Lopo May 29, 2008

May 29, 2008

Hi all, I've just pulled from git and the latest change I have is this one: commit 4c928d39ad82e576113a34bfa4d27dd0b3eaba17 Author: James Hawkins <jhawkins(a)codeweavers.com> Date: Wed May 28 19:15:15 2008 -0500 oleaut32: Disable olefont tests that fail on all platforms. When I ./configure it I get: checking for freetype-config... freetype-config checking for -lfreetype... not found configure: error: FreeType development files not found. Fonts will not be built. Dialog text may be invisible or unaligned. Use the --without-freetype option if you really want this. This is an Ubuntu Hardy system and I do have freetype installed: > dpkg -L libfreetype6-dev | grep libfreetype.so /usr/lib/libfreetype.so Is anyone else seeing this? Cheers, Erik -- ----------------------------------------------------------------- Erik de Castro Lopo ----------------------------------------------------------------- "Men who use terrorism as a means to power, rule by terror once they are in power." -- Helen Macinnes

3 2

Re: implemented first testcase for dxdiagn
by Vitaliy Margolen May 29, 2008

May 29, 2008

Markus wrote: > > ------------------------------------------------------------------------ > > > + hr = IDxDiagContainer_GetNumberOfProps(pAdapterContainer, &dwPropCount); > + ok(dwPropCount == 72, "Incorrect number of properties in display adapter container. " > + "Found (%d) should be (%d).\n", dwPropCount, 72); I don't think you can relay on that being true all the time. Besides what's the point in testing the number of properties? As a general note - if you add a test that currently fails on Wine it needs todo_wine at front of it. Vitaliy.

1 0

Re: ntdll: Strengthen current tests and add new tests for asynchronous I/O.
by Zac Brown May 29, 2008

May 29, 2008

Woops, ignore this patch. Its got a couple things wrong with it. I'll send a fix later on. -Zac Zac Brown wrote: > Strengthen current tests and add new tests for asynchronous I/O. Missing > test for empty messages as well as thoroughly testing input and output > of read/write commands. > > -Zac Brown > > > ------------------------------------------------------------------------ > > From d2a3cbaf6d71c3b0bcfa39afcf854de7e5daa5bb Mon Sep 17 00:00:00 2001 > From: Zac Brown <zac(a)zacbrown.org> > Date: Thu, 29 May 2008 13:34:50 -0700 > Subject: [PATCH] Strengthen current tests and add new tests for asynchronous I/O. > > --- > dlls/ntdll/tests/file.c | 103 ++++++++++++++++++++++++++++++++++++----------- > 1 files changed, 79 insertions(+), 24 deletions(-) > > diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c > index d824530..e3cbf77 100644 > --- a/dlls/ntdll/tests/file.c > +++ b/dlls/ntdll/tests/file.c > @@ -2,6 +2,7 @@ > * > * Copyright 2007 Jeff Latimer > * Copyright 2007 Andrey Turkin > + * Copyright 2008 Google (Zac Brown) > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -65,6 +66,7 @@ static inline BOOL is_signaled( HANDLE obj ) > } > > #define PIPENAME "\\\\.\\pipe\\ntdll_tests_file.c" > +#define TEST_BUF_LEN 10 > > static BOOL create_pipe( HANDLE *read, HANDLE *write, ULONG flags, ULONG size ) > { > @@ -114,7 +116,10 @@ static BOOL get_msg(HANDLE h) > { > LARGE_INTEGER timeout = {{-10000000*3}}; > DWORD res = pNtRemoveIoCompletion( h, &completionKey, &completionValue, &ioSb, &timeout); > - ok( res == STATUS_SUCCESS, "NtRemoveIoCompletion failed: %x\n", res ); > + if (res == STATUS_TIMEOUT) > + ok( res == STATUS_TIMEOUT, "NtRemoveIoCompletion should have timed out, got: %x\n", res ); > + else > + ok( res == STATUS_SUCCESS, "NtRemoveIoCompletion failed: %x\n", res ); > if (res != STATUS_SUCCESS) > { > completionKey = completionValue = 0; > @@ -507,6 +512,7 @@ static void test_iocp_fileio(HANDLE h) > FILE_COMPLETION_INFORMATION fci = {h, CKEY_SECOND}; > HANDLE hPipeSrv, hPipeClt; > NTSTATUS res; > + BOOL rw_res; > > hPipeSrv = CreateNamedPipeA( pipe_name, PIPE_ACCESS_INBOUND, PIPE_TYPE_MESSAGE | PIPE_READMODE_MESSAGE | PIPE_WAIT, 4, 1024, 1024, 1000, NULL ); > ok( hPipeSrv != INVALID_HANDLE_VALUE, "Cannot create named pipe\n" ); > @@ -533,49 +539,97 @@ static void test_iocp_fileio(HANDLE h) > if (hPipeClt != INVALID_HANDLE_VALUE) > { > OVERLAPPED o = {0,}; > - BYTE buf[3]; > + BYTE buf_send[TEST_BUF_LEN]; > + BYTE buf_rcv[TEST_BUF_LEN]; > DWORD read; > long count; > + unsigned int i; > > NTSTATUS res = pNtSetInformationFile( hPipeSrv, &iosb, &fci, sizeof(fci), FileCompletionInformation ); > ok( res == STATUS_SUCCESS, "NtSetInformationFile failed: %x\n", res ); > ok( U(iosb).Status == STATUS_SUCCESS, "iosb.Status invalid: %x\n", U(iosb).Status ); > > - count = get_pending_msgs(h); > - ok( !count, "Unexpected msg count: %ld\n", count ); > - ReadFile( hPipeSrv, buf, 3, &read, &o); > - count = get_pending_msgs(h); > - ok( !count, "Unexpected msg count: %ld\n", count ); > - WriteFile( hPipeClt, buf, 3, &read, NULL ); > - > - if (get_msg(h)) > + /* Try messages of differing lengths and values, checking that they match. */ > + for( i = 1; i < 10; i++ ) > { > - ok( completionKey == CKEY_SECOND, "Invalid completion key: %lx\n", completionKey ); > - ok( ioSb.Information == 3, "Invalid ioSb.Information: %ld\n", ioSb.Information ); > - ok( U(ioSb).Status == STATUS_SUCCESS, "Invalid ioSb.Status: %x\n", U(ioSb).Status); > - ok( completionValue == (ULONG_PTR)&o, "Invalid completion value: %lx\n", completionValue ); > + memset( buf_send, 0, TEST_BUF_LEN ); > + memset( buf_rcv, 0, TEST_BUF_LEN ); > + memset( buf_send, i, i ); > + > + /* Try reading before writing */ > + count = get_pending_msgs(h); > + ok( !count, "Unexpected msg count: %ld\n", count ); > + rw_res = ReadFile( hPipeSrv, buf_rcv, i, &read, &o ); > + ok( rw_res == FALSE, "Unexpected success of ReadFile\n" ); > + ok( GetLastError() == ERROR_IO_PENDING, "Expected error of ERROR_IO_PENDING, got %d\n", GetLastError() ); > + count = get_pending_msgs(h); > + ok( !count, "Unexpected msg count: %ld\n", count ); > + rw_res = WriteFile( hPipeClt, buf_send, i, &read, NULL ); > + ok( rw_res == TRUE, "Unexpected fail of WriteFile\n" ); > + if (get_msg(h)) > + { > + ok( completionKey == CKEY_SECOND, "Invalid completion key: %lx\n", completionKey ); > + ok( ioSb.Information == i, "Invalid ioSb.Information: %ld\n", ioSb.Information ); > + ok( U(ioSb).Status == STATUS_SUCCESS, "Invalid ioSb.Status: %x\n", U(ioSb).Status); > + ok( completionValue == (ULONG_PTR)&o, "Invalid completion value: %lx\n", completionValue ); > + ok( !memcmp( buf_send, buf_rcv, TEST_BUF_LEN ), "Receive buffer (%x %x %x) did not match send buffer (%x %x %x)\n", > + buf_rcv[0], buf_rcv[1], buf_rcv[2], buf_send[0], buf_send[1], buf_send[2] ); > + } > + count = get_pending_msgs(h); > + ok( !count, "Unexpected msg count: %ld\n", count ); > + > + /* Try writing before reading */ > + rw_res = WriteFile( hPipeClt, buf_send, i, &read, NULL ); > + ok( rw_res == TRUE, "Unexpected fail of WriteFile\n" ); > + count = get_pending_msgs(h); > + ok( !count, "Unexpected msg count: %ld\n", count ); > + rw_res = ReadFile( hPipeSrv, buf_rcv, i, &read, &o ); > + ok( rw_res == TRUE, "Unexpected fail of ReadFile\n" ); > + if (get_msg(h)) > + { > + ok( completionKey == CKEY_SECOND, "Invalid completion key: %lx\n", completionKey ); > + ok( ioSb.Information == i, "Invalid ioSb.Information: %ld\n", ioSb.Information ); > + ok( U(ioSb).Status == STATUS_SUCCESS, "Invalid ioSb.Status: %x\n", U(ioSb).Status); > + ok( completionValue == (ULONG_PTR)&o, "Invalid completion value: %lx\n", completionValue ); > + ok( !memcmp( buf_send, buf_rcv, TEST_BUF_LEN ), "Receive buffer (%x %x %x) did not match send buffer (%x %x %x)\n", > + buf_rcv[0], buf_rcv[1], buf_rcv[2], buf_send[0], buf_send[1], buf_send[2] ); > + } > + count = get_pending_msgs(h); > + ok( !count, "Unexpected msg count: %ld\n", count ); > } > - count = get_pending_msgs(h); > - ok( !count, "Unexpected msg count: %ld\n", count ); > > - WriteFile( hPipeClt, buf, 2, &read, NULL ); > + /* Try sending a message of length zero. */ > count = get_pending_msgs(h); > ok( !count, "Unexpected msg count: %ld\n", count ); > - ReadFile( hPipeSrv, buf, 2, &read, &o); > + rw_res = WriteFile( hPipeClt, buf_send, 0, &read, NULL ); > + ok( rw_res == TRUE, "Unexpected fail of WriteFile\n" ); > count = get_pending_msgs(h); > - ok( count == 1, "Unexpected msg count: %ld\n", count ); > + ok( !count, "Unexpected msg count: %ld\n", count ); > + rw_res = ReadFile( hPipeSrv, buf_rcv, TEST_BUF_LEN, &read, &o ); > + /* This passes on XP but not in wine. */ > + todo_wine ok( rw_res == TRUE, "Unexpected fail of ReadFile\n" ); > if (get_msg(h)) > { > ok( completionKey == CKEY_SECOND, "Invalid completion key: %lx\n", completionKey ); > - ok( ioSb.Information == 2, "Invalid ioSb.Information: %ld\n", ioSb.Information ); > + ok( ioSb.Information == 0, "Invalid ioSb.Information: %ld\n", ioSb.Information ); > ok( U(ioSb).Status == STATUS_SUCCESS, "Invalid ioSb.Status: %x\n", U(ioSb).Status); > ok( completionValue == (ULONG_PTR)&o, "Invalid completion value: %lx\n", completionValue ); > } > + count = get_pending_msgs(h); > + ok( !count, "Unexpected msg count: %ld\n", count ); > > - ReadFile( hPipeSrv, buf, sizeof(buf), &read, &o); > - CloseHandle( hPipeSrv ); > + rw_res = ReadFile( hPipeSrv, buf_rcv, TEST_BUF_LEN, &read, &o); > + ok( rw_res == FALSE, "Unexpected success of ReadFile\n" ); > + ok( GetLastError() == ERROR_IO_PENDING, "Expected error of ERROR_IO_PENDING, got %d\n", GetLastError() ); > + rw_res = CloseHandle( hPipeSrv ); > + ok( rw_res == TRUE, "Unexpected fail of CloseHandle\n" ); > count = get_pending_msgs(h); > - ok( count == 1, "Unexpected msg count: %ld\n", count ); > + /* > + * Wine reports 1 extra message. This is probably due to the server > + * reporting that a message is in the queue from sending an empty message above. > + * The offending code is suspected to be in ntdll/file.c in the NtReadFile function. > + */ > + todo_wine ok( count == 1, "Unexpected msg count: %ld\n", count ); > if (get_msg(h)) > { > ok( completionKey == CKEY_SECOND, "Invalid completion key: %lx\n", completionKey ); > @@ -586,7 +640,8 @@ static void test_iocp_fileio(HANDLE h) > } > } > > - CloseHandle( hPipeClt ); > + rw_res = CloseHandle( hPipeClt ); > + ok( rw_res == TRUE, "Unexpected fail of CloseHandle\n" ); > } > > static void test_iocompletion(void) > > > ------------------------------------------------------------------------ > >

1 0

uninformed musings on ddraw + bugs 2082 and 1347 + dib engine
by Vincent Povirk May 29, 2008

May 29, 2008

I apologize if what I'm about to say is wrong and useless. I feel the need to say it just in case it is not as wrong and useless as I fear. Background: We have two very difficult (possibly unfixable) ddraw bugs: http://bugs.winehq.org/show_bug.cgi?id=2082 - DirectDraw games only showing black screen http://bugs.winehq.org/show_bug.cgi?id=1347 - Screen is wiped/blanked on usage of DirectDraw Both of these bugs are the result of the fact that Windows (probably even Windows Vista when Aero is disabled, which I believe happens temporarily when an exclusive move ddraw app is active) ddraw can give apps direct access to the screen and X cannot. Instead of drawing to the screen, Wine draws to the application's window, which it determines based on an argument the application passed to SetCooperativeLevel. In the case of 2082, this window is obscured and no drawing happens even though it would on windows. There is a hack for ddraw that uses hwnd 0 instead (so drawing operations do go to the screen), but it can also break things in situations where an application uses both ddraw and gdi. 1347 is the result of non-fullscreen applications passing hwnd 0 to SetCooperativeLevel and (so I'm told) going through this series of steps: 1. Lock the primary surface, thus mapping the image on the screen to memory. 2. Write to your window. 3. Unlock the primary surface. On Windows, as long as Aero isn't running, this works out fine. But on Wine, mapping the image on the screen to memory is impossible. Instead, Wine simply gives the app an empty buffer, which the app writes to (but only its own window). It is impossible to determine afterwards which parts of the that buffer were written. When the primary surface is unlocked, Wine draws the image in the buffer to the application's SCL window, which is often (but not always) what the application happened to be drawing. Stefan mentions the idea of grabbing a screenshot when the surface is locked and writing it back when the surface is unlocked (which he says in one case would cause framerate to drop to less than 1 fps, which I believe). He thinks 1347 is unfixable. I think that if so, 2082 is also unfixable because even in fullscreen mode we can have problems caused by interactions with ddraw and gdi (using hwnd 0 is not always the right thing even for a fullscreen app). Now, here's where we get to the crazy uninformed ideas: What if, instead of picking one hwnd to draw to, ddraw drew to every window owned by an application? I'm making some assumptions here: it has to be possible to find the space occupied by "every window owned by an application" and draw to it at a reasonable speed. I'm also assuming that no app we want to support will want to draw to windows owned by other programs, especially X programs, even though there's nothing in ddraw that would prevent it. Well, we'd still theoretically have some problems. What if a program locked/unlocked the primary surface multiple times, once for each of various widgets that it wants to draw? The widgets would flicker. And what if a program has its own window that it wants to draw to with gdi? Its gdi parts would be painted black. Alright then, what if we had a single clientside buffer per app, the size and depth (as far as the app is concerned) of the screen, that was not synced with the actual contents of the screen but was preserved between locks/unlocks? Any operation in ddraw or gdi that resulted in a draw to the screen would have to first go through this buffer. The lock/unlock sequence would overdraw all the application's windows with the last thing the application drew there. Ignoring opengl (opengl and ddraw working simultaneously in one process should be extremely rare; maybe some swing apps do it), that should work pretty much perfectly. Sadly I can't even pretend to know enough to say how this affects opengl. It would require clientside buffers, and it would probably be difficult for current gdi to support. It seems like the sort of thing that would be more reasonable if we had a dib engine. (!) Also, giving every process a clientside buffer the size of the screen would be wasteful of memory (and optimizing for a rare case; most programs won't even have a primary surface, let along be locking/unlocking it). It may be more reasonable to have one per visible window or even one per X window, which would be manipulated as needed for lock/unlock (not sure about the X window thing because they'd have to be shared between processes.. but perhaps we need that capability anyway? it would also effectively mean we CAN give apps direct access to the screen for virtual desktops and CAN allow ddraw drawing to other Wine processes' windows). -- Vincent Povirk

6 8

winetest issue on w2k and below
by Paul Vriens May 29, 2008

May 29, 2008

Hi, Lately I've been seeing an issue with winetest on Windows whereby the kernel32_test.exe file can't be deleted after the test. On NT4 I've also seen popups during the test with some remark about not being able to initialize user32.dll. This is when the process test is run for kernel32. Anyone else seeing this? Or better yet, anyone know the cause? -- Cheers, Paul.

2 2

Re: advpack: Fix buffer sizes for possibly quoted strings (try 2, including testcase)
by James Hawkins May 29, 2008

May 29, 2008

On Thu, May 29, 2008 at 9:20 AM, Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> wrote: > Increase buffer size to make quoted strings fit. This fixes the problem > Dan described in > http://www.winehq.org/pipermail/wine-devel/2008-May/065954.html which > is caused by quoted 'HKLM' not fitting into prefix. This patch does, on > request, *not* fix the bigger picture issue that made it possible for > this bug to slip for such a long time, which is missing error checking > on SetupGetStringFieldW calls in get_dest_dir. Valid .inf files should, > of course, not exercise the missing error check, so on valid .inf > files, this patch is sufficient for correct behaviour. > > In the testcase with quoted 'HKLM', SetupGetStringFieldW fails because > of unsufficient buffer size, which is *ignore* by the current code. As > from the previous destination parsed in the patch the local automatic > variable still contains the unquoted HKLM and by luck does not get > overwritten between invocations of get_dest_dir, the testcase passes > nevertheless except if compiled by gutsy's gcc 4.1 without optimization > which puts the local variable to a stack location that does not survive > between different invocations of get_dest_dir. > > The attached change to the testcase "pollutes" the local variable prefix > with HKCU, so the bug is always exposed and not just by bad luck. > --- > dlls/advpack/advpack.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > You must've attached the wrong patch because there is no test case. Also, don't make a change to the existing tests. Please write a completely new test that exposes just the one bug you're trying to fix. They're called 'unit' tests for a reason. -- James Hawkins

1 0

Re: advpack: Fix buffer sizes for possibly quoted strings
by James Hawkins May 29, 2008

May 29, 2008

On Thu, May 29, 2008 at 8:58 AM, Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> wrote: > Increase buffer size to make quoted strings fit. This fixes the problem > Dan described in > http://www.winehq.org/pipermail/wine-devel/2008-May/065954.html which > is caused by quoted 'HKLM' not fitting into prefix. This patch does, on > request, *not* fix the bigger picture issue that made it possible for > this bug to slip for such a long time, which is missing error checking > on SetupGetStringFieldW calls in get_dest_dir. Valid .inf files should, > of course, not exercise the missing error check, so on valid .inf > files, this patch is sufficient for correct behaviour. > > In the testcase with quoted 'HKLM', SetupGetStringFieldW fails because > of unsufficient buffer size, which is *ignore* by the current code. As > from the previous destination parsed in the patch the local automatic > variable still contains the unquoted HKLM and by luck does not get > overwritten between invocations of get_dest_dir, the testcase passes > nevertheless except if compiled by gutsy's gcc 4.1 without optimization > which puts the local variable to a stack location that does not survive > between different invocations of get_dest_dir. > --- > dlls/advpack/advpack.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > Add a test case please. -- James Hawkins

1 0

AppDB: More information about the test environment needed
by Groeschel, Volker May 29, 2008

May 29, 2008

I just found two conflicting reports for Age of empires: http://appdb.winehq.org/objectManager.php?sClass=version&iId=10326 Both are on Ubuntu 8.04 and 1.0-rc1. One is Silver, one is Garbage. But it is just one example. My suggestion is to ask for more information about the test environment. To specify it I think it would be helpfull to know the grafics chip/card and the used driver. With the new free drivers around the block it could be even more helpfull to have this information. The same ATI card e.g. could use Radeon, RadeonHD or the Catalyst driver. The same is true for Nvidia with nvidia, nv and Nouveau driver. I often read that Wine developers recommend nvidia, but I actually have good experience with radeon. It is quite hard to get real informaltion on this topic.

2 1

Re: [1/2] tests: Add functions to make it possible to handle Windows misbehaviors that we don't want to reproduce in Wine.
by Alexandre Julliard May 29, 2008

May 29, 2008

Francois Gouget <fgouget(a)free.fr> writes: > This patch introduces the buggy(), deprecated() and strict_wine > functions I mentioned in: > http://www.winehq.org/pipermail/wine-devel/2008-April/065322.html I like the idea, but I don't think this should copy the todo mechanism, as it doesn't scale well. For todo that's OK because the number of todos is supposed to remain small, and get smaller as Wine improves; but strict checking is something we'll want more and more of, so ultimately we'll have them all over the place. It gets even worse if we want to be strict for other platforms too. So I would suggest to not add a strict(platform), but make buggy() and deprecated() always do strict checking except when platform is "windows". If we need to have a buggy() check succeed on Wine for some reason it can always be wrapped in a todo_wine. -- Alexandre Julliard julliard(a)winehq.org

1 0

2k is the default version?
by Austin English May 28, 2008

May 28, 2008

I was testing installing Virtualbox today and got an error that Windows XP is the minimum requirement. Funny I thought...we're emulating XP, it must want SP 2 or something strange. Fired up winecfg, and lo and behold, Windows 2000 is the default OS again. Thought I might be going crazy or botched my local tree, but checking out on a fresh tree shows the same thing. When/why did this happen? -Austin

4 7

wine video codec demo
by Dan Kegel May 28, 2008

May 28, 2008

I put together a little script demonstrating how to install and use various video codecs and use them in a test application (media player classic). To try it out, do wget http://kegel.com/wine/winetricks wget http://kegel.com/wine/codecdemo sh codecdemo (after of course reading both scripts to make sure they don't do something evil.) To make this demo script easier to write, I added quicktime72 and mpc verbs to winetricks. (I also added a vlc verb, but that wasn't so useful as a system codec test, since vlc has its own embedded codecs, and doesn't use the system's.) The demo shows that Quicktime works more or less, but .wmv doesn't work (even with the codecs); it probably needs either native quartz.dll or Maarten's VMR9 implementation (which he is busily finishing up now; it seems to be good at finding video card driver bugs). Next step: Dirac.

1 1

Re: [ws2_32/tests] Fix crash on win98
by Kai Blin May 28, 2008

May 28, 2008

On Wednesday 28 May 2008 10:08:49 Paul Vriens wrote: > Hi, > > As pi_size was uninitialized the value turned out to be the cause of this > crash. > > I don't know where that limit ( 2*sizeof(WSAPROTOCOL_INFOA) ) comes from > but tests show it has to be less then that on win98. Whoops, thanks for the catch. I had that initialized to 0 at one point in my test program, but it seems like I dropped it while reworking the tests. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

advpack.c must be compiled with optimization?
by Dan Kegel May 28, 2008

May 28, 2008

Oddly, if I compile the wine tree without -O2, the following test fails: ../../../wine advpack_test.exe.so advpack.c advpack.c:441: Test failed: Expected C:\Program Files, got C:\ advpack.c:443: Test failed: Expected size 17, got 4 make: *** [advpack.ok] Error 2 Compiling advpack/advpack.c with at least -O makes the problem go away.

3 3

Why I think it's worth fixing Valgrind warnings
by Dan Kegel May 28, 2008

May 28, 2008

If you're wondering whether it's worth fixing Valgrind warnings (after all, they are just warnings, right?): First, some of the valgrind errors that show up when running the test suite might be real bugs. That might be enough reason right there. Second, clearing out the valgrind errors that show up in the test suite make it a lot easier to find Wine bugs when running real apps on wine on valgrind. (The lower the background noise level, the easier it is to see the real problem.) Third, if valgrind works well on wine, windows developers might start coming to Wine just to run Valgrind on their apps to find app bugs. (Don't laugh! It could happen!) This is why I hired John Reiser to improve Valgrind/Wine support, why I've been fixing a few valgrind warnings lately, and why I think it's important for other people to start doing it, too. That said, it's important when fixing Valgrind errors to really understand the code you're changing, lest you paper over a bug with another bug, or make things worse. (Here would be a good place for me to thank James for his code reviews :-) - Dan

4 5

Coaxing appdb maintainers into testing their apps with rc1?
by Dan Kegel May 28, 2008

May 28, 2008

It doesn't look like many people are paying attention to http://wiki.winehq.org/PlatinumRegressionHunt Think it would be useful to email all the app maintainers and ask them to pretty please test their apps with rc1?

4 6

Ooodles of sexy new valgrind warnings
by Dan Kegel May 28, 2008

May 28, 2008

I updated to the latest valgrind from svn, and it gives lots of nifty new warnings. e.g. it warns if you are using the wrong free for a particular memory block, and it tells you where uninitialized blocks came from. http://kegel.com/wine/valgrind/logs-2008-05-25-summary.txt is a roadmap of where the sexy new stuff is; the details are in http://kegel.com/wine/valgrind/logs-2008-05-25/ For instance, it says diff -u logs-2008-05-20/vg-winmm_capture.txt logs-2008-05-25/vg-winmm_capture.txt + Uninitialised value was created by a client request + Mismatched free() / delete / delete [] Pulling up just that diff, http://kegel.com/wine/valgrind/logs-2008-05-25/vg-winmm_capture-diff.txt shows the latter error is + Mismatched free() / delete / delete [] + at RtlFreeHeap (heap.c:1287) + by wave_in_test_device (capture.c:397) + by func_capture (capture.c:716) + by run_test (test.h:414) + by main (test.h:463) + Address 0x440cc90 is 0 bytes inside a block of size 14 alloc'd + at malloc (vg_replace_malloc.c:207) + by wave_in_test_device (capture.c:388) + by func_capture (capture.c:716) + by run_test (test.h:414) + by main (test.h:463) Sure enough, memory is allocate with strdup() and freed with HeapFree(), tsk. Anyway, there's plenty here for everybody. Pile on! Tomorrow I'll start running these without -O2; Zac Brown reminded me that gives better stack tracebacks (i.e. it inhibits inlining, which often causes small static functions to disappear from the stack dumps in valgrind's error messages). - Dan

2 3

Re: mscoree: add implementation of GetCORSystemDirectory
by Vitaliy Margolen May 28, 2008

May 28, 2008

Vitaly Perov wrote: > Changeleg: > - mscoree: add implementation of GetCORSystemDirectory > What bug # does this patch fixes? Please leave all the new implementations to after the wine-1.0 Vitaliy.

1 0

Re: implemented further properties for DXDiagDisplayContainer in dxdiagn dll
by Vitaliy Margolen May 28, 2008

May 28, 2008

Markus wrote: > > ------------------------------------------------------------------------ > > Subject: implemented further properties for DXDiagDisplayContainer in dxdiagn dll Please do not send implementation of new things, especially as dangerous as this. Wine at the code freeze. You should be going over bugs in bugzilla and fixing them. Vitaliy.

1 0

WOW! Look at test.winehq.org now!
by Dan Kegel May 27, 2008

May 27, 2008

Alexandre did an awesome job of improving the index page. It's very polished and useful now. http://test.winehq.org/data/

6 5

re: shell32: Test against the long form of the path.
by Dan Kegel May 27, 2008

May 27, 2008

This change http://source.winehq.org/git/wine.git/?a=commit;h=f2aa3259b913d75a273296f28… seems to causes a test failure on my wine box, but more importantly, on several windows boxes as well: http://test.winehq.org/data/200805221320/2000_aenglish-2k/shell32:shelllink… http://test.winehq.org/data/200805221320/2003_jh-win2k3-vm/shell32:shelllin… http://test.winehq.org/data/200805221320/xp_om/shell32:shelllink.txt It passes on some systems, go figure: http://test.winehq.org/data/200805221320/xp_maarten-xp/shell32:shelllink.txt James, want to revert this one for now?

3 3

Winetest broken on Win98
by Francois Gouget May 27, 2008

May 27, 2008

So if anyone has been wondering why I don't run the tests on Win98 anymore... I still do! The problem is that since 2008/05/08 something prevents winetest from submitting the results. The 200805062030 winetest build works fine so that leaves a two/three days window where things went wrong. Unfortunately I have been unable to pinpoint a specific test that causes the problem. Here's a log I generated with the 200805211000 build: http://fgouget.free.fr/tmp/winetest.log I let winetest run for 90 minutes (normally it's over in about 15), then Windows was frozen, not responding to Ctrl-Alt-Del, using all the CPU and I had to hit VMware's reset button. The last test that was run is setupapi:parser, but according to the log it completed fine, and I can run it by hand just fine. Still according to the log the next test did not even start. Unfortunately the list of potential suspects is quite long. It would help if I could at least cross-build winetest but I always get errors (e.g. due to d3dx9_36). What happened to the resolution to get rid of the dependency on MinGW libraries? Alternatively, where's the lastest version of w32api with d3dx9_36? commit 382ed33b7a770d532bcf4b7dc392ee929c987c7a Author: Vitaliy Margolen <wine-patches(a)kievinfo.com> Date: Thu May 8 08:11:19 2008 -0600 dinput: Default value for unassigned POVs should be -1. commit b92d1c7fbef30114b3aa7f3197a5df3556c98b12 Author: Paul Vriens <paul.vriens.wine(a)gmail.com> Date: Thu May 8 15:06:53 2008 +0200 crypt32/tests: Cleanup registry after tests. commit 5714c4deee6f3c0cc30098d056fa4ce39a333878 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu May 8 11:12:03 2008 +0200 user32: The client rectangle is in screen coordinates for the initial WM_NCCALCSIZE. commit 09cb415109447c4be086f1c756f8a168628457f7 Author: Guy Albertelli <galberte(a)neo.rr.com> Date: Thu May 8 00:46:38 2008 -0400 listview: Return correct value from WM_NOTIFYFORMAT with test. commit 864e24d2e586b796c2069576ca6d8fe4e7b8cef7 Author: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> Date: Wed May 7 16:31:02 2008 -0700 kernel32: Fix temporary path test. commit db8e63af27b75d098db6f9a61a6fb0ab7d70d83f Author: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> Date: Wed May 7 15:44:48 2008 -0700 kernel32: Fix process tests to pass in Windows. commit fd7b277d8ac23706b1c819d2ed1fd0ee9833fd06 Author: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> Date: Tue May 6 15:06:17 2008 -0700 rpcrt4: Fix ndr_marshall test failures. Created with help from Robert Shearman. commit 51c28a1493c844eff4f4625d3398da5ee5d707fd Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Wed May 7 20:34:36 2008 +0900 gdi32: More carefully compare EMF records in tests. commit 3da466a9f75076f618a5440805cd211a98c7b628 Author: Kai Blin <kai.blin(a)gmail.com> Date: Wed May 7 12:35:06 2008 +0200 secur32: Fix ntlm tests on Vista. commit 02c66c2312d9bf98d0fc0d5d4ce56b8564718026 Author: Rob Shearman <rob(a)codeweavers.com> Date: Wed May 7 11:11:09 2008 +0100 rpcrt4: Add better traces for the server test. Handle failure to use one or more protocol sequences more gracefully, as ncacn_np servers aren't support on Win9x and ncacn_ip_tcp fails on some machines. commit 473717fefd06650e1e8d80c8dc0e16ab583cc673 Author: Detlef Riekenberg <wine.dev(a)web.de> Date: Tue May 6 20:26:05 2008 +0200 winspool: Set PrinterPorts for win3.x/win9.x compatibility. commit 7c051f13941b15bd0a399431e36cae16b8fe092e Author: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> Date: Tue May 6 14:14:56 2008 -0700 winetest: Fix CreateProcess so that debugger tests run without timing out. commit deee97d9eaa7dfe28a9e39f288c3c7ed39f6e7c8 Author: Paul Vriens <paul.vriens.wine(a)gmail.com> Date: Tue May 6 18:08:09 2008 +0200 advapi32/tests: Add another test. commit 6477a1c1bfd7966ff75b6847156a765ec088b0b3 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue May 6 15:54:07 2008 +0200 kernel32: Set the USERPROFILE and ALLUSERSPROFILE environment variables based on the ProfileList registry keys. commit c4d75213abe21dcd7697d2f9151a186ebb3f8c8d Author: Alexander Dorofeyev <alexd4(a)inbox.lv> Date: Tue May 6 00:49:34 2008 +0300 ddraw/tests: Add tests for IDirect3DDevice7_Load. I'm ignoring wininet and ntdll changes because they don't run due to missing imports. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

6 7

urlmon:protocol test timeouts
by James Hawkins May 27, 2008

May 27, 2008

Hi Jacek, The following patch causes timeouts for all platforms, can you have a look at it? commit 210854edf2e841af675d541d29f2b90cd2625d02 Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Jan 31 18:18:49 2008 +0100 urlmon: Added more protocol tests. http://test.winehq.org/data/156dad05c08cd921288aedf1b281ff23844a1692/ Thanks, James Hawkins

1 0

inkscape font rendering: is this bug #4386?
by Marcel Partap May 27, 2008

May 27, 2008

Hi all, as a poppler upgrade just broke my native inkscape and the 1.0 bug hunt is on, i thought i'd quickly try inkscape win32 (latest nightly build) and see if it works.. well stuff seems to look fine - except all glyphs (except from the file dialogs of course) are shown as black filled .. blurps (http://hfopi.org/files/temp/inkscape-font-rendering.png) kinda ;) now looking at the appdb it really surprised my inkscape is not yet in there.. also i am not sure if this font problem is probably something on my side (my x font server is behaving strangly atm: thunderbird has everything typeset with some gothic script?!) or if it corresponds to either bug #6519 or #4386 ? If someone can confirm this I'll add a bug report later today.. regards -- <div id="signature"> "Obstacles are those frightful things you see when you take your eyes off your goal." -- Henry Ford (1863-1947) Change the world! Vote revolution: http://hfopi.org/vote-future </div>

2 1

re: runtest: Add an option to run the tests with valgrind
by Dan Kegel May 27, 2008

May 27, 2008

Maarten wrote: > Usage: make test RUNTEST="$WINE_GIT/tools/runtest -V" VALGRIND_OPTS="..." That seems clumsier offhand than how I've been doing it, RUNTEST_USE_VALGRIND=1 make test

2 1

Re: wined3d: Use higher precision to convert floats into text.
by Chris Robinson May 27, 2008

May 27, 2008

On Monday 26 May 2008 12:37:04 pm Vitaliy Margolen wrote: > - shader_addline(buffer, "PARAM srgb_mul_low = {%f, %f, %f, > 1.0};\n", > + shader_addline(buffer, "PARAM srgb_mul_low = {%.12f, > %.12f, %.12f, 1.0};\n", I don't know if ARB shaders would except the notation (GLSL does), but would %.8e or somesuch work better than %.12f at maintaining accuracy?

4 6

listview maintainer review, please...
by Dan Kegel May 27, 2008

May 27, 2008

The curious Valgrind error + Conditional jump or move depends on uninitialised value(s) + at SetWindowPos (winpos.c:2034) + by LISTVIEW_UpdateSize (listview.c:9380) + by LISTVIEW_Size (listview.c:9320) + by LISTVIEW_WindowProc (listview.c:9949) + by (within /home/dank/wine-git/dlls/user32/user32.dll.so) + by call_window_proc (winproc.c:457) + by WINPROC_CallProcAtoW (winproc.c:901) + by CallWindowProcA (winproc.c:2282) + by listview_subclass_proc (listview.c:231) + by (within /home/dank/wine-git/dlls/user32/user32.dll.so) + by call_window_proc (winproc.c:457) + by WINPROC_CallProcWtoA (winproc.c:1267) + by WINPROC_call_window (winproc.c:2200) + by call_window_proc (message.c:1610) + by send_message (message.c:2434) + by SendMessageW (message.c:2557) + by DEFWND_DefWinProc (defwnd.c:746) + by DefWindowProcW (defwnd.c:1037) + by LISTVIEW_WindowProc (listview.c:9994) + by (within /home/dank/wine-git/dlls/user32/user32.dll.so) + Uninitialised value was created by a stack allocation + at LISTVIEW_UpdateSize (listview.c:9351) started happening recently. Looking at LISTVIEW_UpdateSize, it seems clear that if SendMessageW( infoPtr->hwndHeader, HDM_LAYOUT, 0, (LPARAM)&hl ); fails for whatever reason, hl will be undefined, and that's what Valgrind is complaining about. Here's a patch that skips the rest of the function if that line fails; it makes Valgrind happy, and doesn't seem to hurt the conformance tests. Can somebody familiar with the code have a look at that function and explain what's going on here? Thanks! - Dan

2 1

Re: [PATCH] Add Ex critical section initialisers for msvcrt
by Rob Shearman May 27, 2008

May 27, 2008

2008/5/26 Jon Griffiths <jon_p_griffiths(a)yahoo.com>: > The latest msvcrt needs InitializeCriticalSectionEx to load (e.g. > http://forum.utorrent.com/viewtopic.php?id=37243) I don't believe we should be adding new functions during code freeze, especially not totally implemented ones with no corresponding tests. However, I would encourage you to create a bug and to submit the patch when we start thawing. -- Rob Shearman

1 0

Re: user32: Allow scrolling via mouse drag outside scrollbar
by James Hawkins May 27, 2008

May 27, 2008

On Mon, May 26, 2008 at 1:46 PM, Dylan Smith <dylan.ah.smith(a)gmail.com> wrote: > When dragging the scrollbar thumb with the mouse, the mouse is able to > move away from the scrollbar and keep scrolling so long as it isn't too > far away from the scrollbar. This makes it easier to quickly scroll > with the mouse. > > This patch is an alternative to the Windows approach of allowing the > mouse to be dragged a certain distance from the scrollbar, and instead > allows the mouse to be dragged any distance away and still scroll. > Although this is different from Windows, it shouldn't result in any > compatibility issues. > > It is my personal opinion that this is a simpler and more usable > approach. > It doesn't matter if you think it's simpler and more usable. We are bug-for-bug compatible with Windows. -- James Hawkins

3 2

Re: fusion: improve UninstallAssembly stub slightly, fix typo in test
by James Hawkins May 27, 2008

May 27, 2008

On Mon, May 26, 2008 at 9:24 PM, Dan Kegel <dank(a)kegel.com> wrote: > Improve stub slightly so callers (like our test) looking for a > disposition find one. > Also fix a minor typo in the test. > diff --git a/dlls/fusion/asmcache.c b/dlls/fusion/asmcache.c index 7da79f4..5697433 100644 --- a/dlls/fusion/asmcache.c +++ b/dlls/fusion/asmcache.c @@ -151,6 +151,9 @@ static HRESULT WINAPI IAssemblyCacheImpl_UninstallAssembly(IAssemblyCache *iface { FIXME("(%p, %d, %s, %p, %p) stub!\n", iface, dwFlags, debugstr_w(pszAssemblyName), pRefData, pulDisposition); + /* caller might test disposition to see why it failed, so come up with some excuse... */ + if (pulDisposition) + *pulDisposition = IASSEMBLYCACHE_UNINSTALL_DISPOSITION_STILL_IN_USE; return E_NOTIMPL; } I disagree with this change. If you want to fix the valgrind warning, the test should set the disposition before calling UninstallAssembly. This disposition is misleading anyway. Hypothetically, a user of this API could sit in a loop waiting for the assembly to not be in use. -- James Hawkins

1 0

Re: fusion: use HeapAlloc, not strdup, to avoid malloc/HeapFree mismatch; don't test variable if not set
by James Hawkins May 26, 2008

May 26, 2008

On Mon, May 26, 2008 at 4:21 PM, Dan Kegel <dank(a)kegel.com> wrote: > Can't mix strdup and HeapFree. > > Fixes three valgrind errors > http://kegel.com/wine/valgrind/logs-2008-05-25/vg-fusion_asmcache.txt > diff --git a/dlls/fusion/tests/asmcache.c b/dlls/fusion/tests/asmcache.c index a160b0a..dcf26a0 100644 --- a/dlls/fusion/tests/asmcache.c +++ b/dlls/fusion/tests/asmcache.c @@ -922,8 +922,10 @@ static void test_InstallAssembly(void) todo_wine { ok(hr == S_OK, "Expected S_OK, got %d\n", S_OK); - ok(disp == IASSEMBLYCACHE_UNINSTALL_DISPOSITION_UNINSTALLED, - "Expected IASSEMBLYCACHE_UNINSTALL_DISPOSITION_UNINSTALLED, got %d\n", disp); + if (hr == S_OK) { + ok(disp == IASSEMBLYCACHE_UNINSTALL_DISPOSITION_UNINSTALLED, + "Expected IASSEMBLYCACHE_UNINSTALL_DISPOSITION_UNINSTALLED, got %d\n", disp); + } } Why did you add this change? The value of disp is independent of the value of hr. Also, the style of the braces doesn't match the rest of the file. -- James Hawkins

1 0

Best place for HOWTO documents for your favourite application?
by Reece Dunn May 26, 2008

May 26, 2008

Hi, I have been trying our various Oberon Media games. The thing that is holding this up from working is the hyperlinks on the intro screen (I am going to enter a bug report later on). I have worked out how to run and register the games (given a valid registration key that you have purchased) so that they will work under Wine. So this got me wondering... where do I put this? This complements the appdb, but is in a way orthogonal to it (that is there may be HOWTOs relating to individual games/applications, to vendors or to other areas such as installing Windows themes like the Zune theme). It will also help when more people start using Wine and want to get their favorite application running. My initial thoughts are that the wiki seems like a good place for this. Thoughts? Comments? - Reece

4 4

Re: user32: Increased area for scrolling via mouse drag outside scrollbar
by Dylan Smith May 26, 2008

May 26, 2008

I just realized that the behaviour of Windows in this situation feels buggy. To me it would actually be more usable to allow the mouse to be dragged anywhere on the screen, as long as the mouse button stays down, instead of just within some area close to the scrollbar. KDE and Gnome applications that I am running all appear to allow the mouse to be dragged anywhere on the screen to scroll. Therefore, I would like to know what other people think. Do we actually want to copy Windows when it makes usability worse and doesn't affect compatibility? Wouldn't it be cool to have a better implementation of the Windows platform? I still think this patch is an improvement, just not the best solution. On Mon, May 26, 2008 at 12:59 PM, Dylan Smith <dylan.ah.smith(a)gmail.com> wrote: > When dragging the scrollbar thumb with the mouse, the mouse is able to > move away from the scrollbar and keep scrolling so long as it isn't too > far away from the scrollbar. This makes it easier to quickly scroll > with the mouse. > > All that this patch changes is the distance that the mouse can be moved > away from the scrollbar before it is consider outside of the scrollbar > and returns to its original position. The constants are only > approximate, since I only tested visually against Windows XP SP3, so it > should at least feel the same. > --- > dlls/user32/scroll.c | 19 +++++++++++++++---- > 1 files changed, 15 insertions(+), 4 deletions(-) >

1 0

Re: README: Few more updates
by Aurimas Fischer May 26, 2008

May 26, 2008

Austin English wrote: > - Go to http://www.winehq.org/site/git for more information. > + Go to http://www.winehq.org/site/git/ for more information. this is not correct, second link returns 404 page.

2 1

Re: [PATCH] - fall back to the main HWND when there is no IMM HWND
by James Hawkins May 26, 2008

May 26, 2008

On Sun, May 25, 2008 at 6:59 PM, Christopher GAUTIER <krys(a)via.ecp.fr> wrote: > > Description: > > It is apparently valid to call ImmGetDefaultIMEWnd() without first > opening the IME with ImmSetOpenStatus(). In such cases, > ImmGetDefaultIMEWnd returns NULL (the value of hwndDefault), which > indicates a failure according to MSDN. As a result, some applications > may report a IME failure. Fallbacking to the main window handle fixes > this. > > > Changelog: > - dlls/imm32/imm.c: fall back to the main HWND when there is no IMM > HWND in ImmGetDefaultIMEWnd() > Please add a test case to prove this behavior is correct. -- James Hawkins

2 1

AppDB: how to handle the same application (specifically game) from different vendors.
by Reece Dunn May 26, 2008

May 26, 2008

Hi, While testing various casual games and adding the information to the AppDB, I have noticed something. The various casual game websites (such as Oberon Media/MSN, PopCap Games and Yahoo! Games) have several games that are the same (such as Bejeweled 2, Dinner Dash 2 and Zuma), but are packaged using different installers and have different splash screens. I haven't investigated to see if this extends to the loading screen as well, or if they behave differently. The AppDB already supports different versions, but I believe these are specific to one vendor. So the question is how to support the same game published from different vendors? - Reece

1 0

Speaker for talk about wine in Kiel (north of Germany) wanted
by haukeh May 26, 2008

May 26, 2008

Hi there, Alexandre said this would be the right place to ask for a speaker about a wine talk. So I'm asking here ;-) Is there anybody who can hold a speech about wine in Kiel (north of Germany, http://maps.google.com/maps?f=q&hl=en&geocode=&q=kiel+deutschland&ie=UTF8&z… The audience would be interested in solutions for excuting windows applications under Linux. The speech would be part of the speeches before the Kiel Linux days (www.kieler-linuxtage.de (German only)). Maybe another speaker about VirtualBox would attend for a comparison between full virtualisation and an api emulation solution. We would like to hear the speech this summer. A more precisely planning for a speach date will come when we have our speakers and when they have time. So write me please (in German because the speech is required in German too) if you are interested in holding this speech. Have a nice day, Hauke

1 0

Re: ws2_32: Add support for FROM_PROTOCOL_INFO to WSASocket()
by Dmitry Timoshkov May 26, 2008

May 26, 2008

"Kai Blin" <kai.blin(a)gmail.com> wrote: > + {FROM_PROTOCOL_INFO, FROM_PROTOCOL_INFO}, > }; > > static const int ws_socktype_map[][2] = > @@ -304,6 +305,7 @@ static const int ws_socktype_map[][2] = > MAP_OPTION( SOCK_DGRAM ), > MAP_OPTION( SOCK_STREAM ), > MAP_OPTION( SOCK_RAW ), > + {FROM_PROTOCOL_INFO, FROM_PROTOCOL_INFO}, > }; > > static const int ws_proto_map[][2] = > @@ -314,6 +316,7 @@ static const int ws_proto_map[][2] = > MAP_OPTION( IPPROTO_ICMP ), > MAP_OPTION( IPPROTO_IGMP ), > MAP_OPTION( IPPROTO_RAW ), > + {FROM_PROTOCOL_INFO, FROM_PROTOCOL_INFO}, > }; Although it was the case before, it's a mistake to have a comma after the last struct member initializer. > + if (lpProtocolInfo) { > + if (af == FROM_PROTOCOL_INFO) > + af = lpProtocolInfo->iAddressFamily; > + if (type == FROM_PROTOCOL_INFO) > + type = lpProtocolInfo->iSocketType; > + if (protocol == FROM_PROTOCOL_INFO) > + protocol = lpProtocolInfo->iProtocol; Please keep opening brace style/indentation consistent with code you have removed. > --- a/include/winsock.h > +++ b/include/winsock.h > @@ -146,6 +146,7 @@ extern "C" { > /* proper 4-byte packing */ > #include <pshpack4.h> > > +#define FROM_PROTOCOL_INFO (-1) PSDK has it in winsock2.h -- Dmitry.

6 10

Time to cull the changelog file
by Scott Ritchie May 26, 2008

May 26, 2008

A while back, Alexandre promised to wipe the changelog file "when we hit 1.0 or when it hits 4 gigabytes, whichever comes first." Well, it's about time. I suggest removing all changes for entries earlier than Wine 1.0-rc1, as having it completely empty would be a bit silly. As for where to archive the old changes online, I'm not sure. Culling the changelog like this will reduce package size substantially. The text, even when compressed, is rather large. Thanks, Scott Ritchie

6 7

Re: winex11: BitBlt returns TRUE when drawing outside of the clipping or visible region.
by James Hawkins May 26, 2008

May 26, 2008

On Sun, May 25, 2008 at 11:53 PM, Sergey Khodych <khodych(a)gmail.com> wrote: > > Please add a test to prove that this behavior is correct. -- James Hawkins

1 0

Re: winex11: BitBlt returns TRUE when drawing outside of the clipping or visible region.
by Vitaliy Margolen May 26, 2008

May 26, 2008

Sergey Khodych wrote: > > Please add a test for this.

1 0

winex11: BitBlt returns TRUE when drawing outside of the clipping or visible region.
by Sergey Khodych May 26, 2008

May 26, 2008

1 0

How to phrase Wine's success rate
by Dan Kegel May 25, 2008

May 25, 2008

When making announcements about Wine 1.0, it's useful to include an objective measure of how well it works for the average app, one that correctly conveys both Wine's promise and its limitations. Our current appdb stats are: Platinum 1500 Gold 1763 Silver 1194 Bronze 1071 Garbage 2512 That's 19% platinum and 41% gold-or-platinum. (Given rating inflation, we probably shouldn't claim that silver or below means "working" for the average person.) How about: "Of the apps we have tested with Wine, about 20% work well, and about another 20% work but have some glitches." That assumes we don't have too many regressions. It'd be nice if the appdb could give finer grained summaries, e.g. counts of apps that had actually been tested with wine-1.0rc*. - Dan

8 11

Re: avifil32/tests: [2/2] Add a test for AVISaveOptions and fix thedetected crash
by Dmitry Timoshkov May 25, 2008

May 25, 2008

"Detlef Riekenberg" <wine.dev(a)web.de> wrote: > - for (; nStreams > 0; nStreams--) { > + for (nStreams--; nStreams >= 0; nStreams--) { > if (ppOptions[nStreams] != NULL) { > ppOptions[nStreams]->dwFlags &= ~AVICOMPRESSF_VALID; Shouldn't this be for (nStreams - 1; nStreams >= 0; nStreams--) { instead? -- Dmitry.

2 1

Suggestions for AppDB/comment system
by doc May 25, 2008

May 25, 2008

Currently the replied comments require loading another page. I would like to suggest making the comment load in the same page using some javascript/ajax. I would submit a patch to do this, but I notice the appdb webpage is not being version controlled (as far as I can tell). So another suggestion I have is to put AppDB code into git :) I am also forwarding this to appdb(a)winehq.org but would like other peoples input.

2 2

Removinig CVS/GIT version from bugzilla
by Vitaliy Margolen May 25, 2008

May 25, 2008

I'm copying my response here to continue the conversation. Please don't remove cvs/git version. What should be done is: 1. Leave old bugs alone or modify them case-by-case 2. All bugs with "cvs/git" version from now on can be filed on the development branch between releases only. 3. After the next release, if the bug is still present, modify version to that release. Of course no modifying of old bugs. Vitaliy.

4 5

winetest failure summary for 1.0rc2
by Dan Kegel May 25, 2008

May 25, 2008

Wow, lots of people submitted test results for 1.0rc2 already! I ran my skipgood filter on it, put the digested data up at http://kegel.com/wine/failing-1.0-rc2.html and added a little analysis to http://wiki.winehq.org/MakeTestFailures To wit: -- snip --- Tests that fail on most versions of Windows As of 1.0-rc2, the following tests all fail on 2000, XP, 2003, and Vista: comctl32:listview ddraw:d3d gdi32:metafile kernel32:toolhelp mshtml:htmldoc oleaut32:olefont and a bunch more fail on most of those versions of Windows. See http://kegel.com/wine/failing-1.0-rc2.html for the full data. Most Common Failures on XP As of 1.0-rc2, the following tests fail on all machines running XP: comctl32:listview ddraw:d3d gdi32:metafile kernel32:actctx kernel32:toolhelp mshtml:htmldoc msvcrt:cpp oleaut32:olefont urlmon:url user32:input user32:listbox user32:msg and a whole mess fail for nearly all reporters. See http://kegel.com/wine/failing-1.0-rc2.html for the full data. Most Common Failures on Wine As of 1.0-rc2, here are the tests that fail on some Wine systems, and how many people they fail for: 14 user32:msg 12 user32:win 9 user32:input 6 dsound:ds3d dsound:ds3d8 kernel32:path user32:monitor 5 kernel32:process msi:install msi:package riched20:editor 4 comctl32:listview ddraw:visual dinput:device gdi32:font gdi32:metafile kernel32:profile kernel32:sync kernel32:virtual snmpapi:util urlmon:protocol user32:class wininet:internet 3 comctl32:monthcal ddraw:d3d kernel32:volume msi:msi setupapi:devinst shell32:shlfolder user32:menu userenv:userenv 2 advapi32:registry advapi32:security advapi32:service comctl32:tooltips d3d8:visual d3d9:visual ddraw:dsurface dsound:dsound kernel32:version msvcrt:time ntdll:exception psapi:psapi_main qedit:mediadet 1 advpack:advpack advpack:install ...[many deleted]... wininet:http winmm:wave winspool.drv:info Whew, that's a lot of data. I looked at all the ones that failed for five or more people: user32:msg, user32:win, and user32:input are probably people running non-blessed window managers; Alexandre's position is that we can ignore these, since upstream gnome's WM is fixed. dsound:ds3d is mostly "ds3d.c:891: Test failed: The primary volume changed from -27 to -960" (worrisome, random) plus "ds3d.c:896: Test failed: The primary pan changed from -5594 to -5595" (rounding error, just add slop of 1?). dsound:ds3d8 is the same. kernel32:path is mostly "path.c:899:TMP=c:\windows\temp"..."path.c:1178: Test failed: expected buf[0] upper case letter got c", probably people whose ~/.wine is old and has a windir that starts with a lowercase drive letter?! Has that changed recently? msi:install is mostly "install.c:4414: Test failed: File installed". msi:package is mostly "package.c:1661: Test failed: wrong return val (0)" riched20:editor has several failures. --- snip ---

6 8

Regression in wined3d: Add read_from_framebuffer_texture which combines code from read_from_framebuffer (drawpixels) and LoadLocation.
by Markus May 25, 2008

May 25, 2008

Hi, after investigating reports for the game 'World in Conflict', I identified the following patch to cause the game graphics to freeze (ambient sounds are still played though): ---- ba90a740beb9ce9a839cc843db8d87f5a37becdd is first bad commit commit ba90a740beb9ce9a839cc843db8d87f5a37becdd Author: Roderick Colenbrander <thunderbird2k(a)gmx.net> Date: Sun Feb 10 22:20:15 2008 +0100 wined3d: Add read_from_framebuffer_texture which combines code from read_from_framebuffer (drawpixels) and LoadLocation. This makes the code easier to read and the pieces borrowed from read_from_framebuffer are more correct than the code in LoadLocation. :040000 040000 74e4bdc73e367c8f38cd3d0818df0fc86eb788bf 3e54409be7c9d2964efbf3d3c2f3d3b84a267047 M dlls ---- The freezes only seem to occur if the native (Windows) dxdiagn.dll is used, as it lets the game properly detect the graphics card and thus enables additional graphics options (highend shaders, high-res textures, etc.). Apparently the freeze is only triggered with these options active. The game uses events in its drawing code and ("always") hangs after the following output: fixme:d3d9:D3DPERF_BeginEvent (color 0xffffffff, name L"Update verlet cloth") : stub fixme:d3d9:D3DPERF_EndEvent (void) : stub At one point, it was followed by this error: err:d3d_surface:surface_prepare_system_memory Surface without memory or pbo has SFLAG_INSYSMEM set! The point of the freeze appears to depend on many factors. If I move the camera around, it appears to freeze earlier than just letting the game run (e.g. a replay of a match). But once the patch is excluded, the game no longer freezes. If more info is needed, please specify how I can obtain it. -- Markus

3 2

winetest for 1.0rc2 - small post-run error message
by Susan Cragin May 25, 2008

May 25, 2008

Network transfer: Done (1116026 of 1116026) Finished susan(a)ubuntu:~/wine-git/programs/winetest$ fixme:ntdll:RtlNtStatusToDosErrorNoTeb no mapping for 8000000a susan(a)ubuntu:~/wine-git/programs/winetest$

1 0

Readme: Updates needed
by Austin English May 25, 2008

May 25, 2008

Alexandre committed a few fixed to the README today, but I still see a few things that may need fixing: ./tool/wineinstall - Has been mentioned to be deprecated a few times in bugzilla. If it's deprecated, we need to remove it. If not, we need to fix whatever it's doing wrong and stop discouraging its use. 3. REQUIREMENTS Linux version 2.0.36 or above FreeBSD 6.2 or later Solaris x86 2.5 or later NetBSD-current Mac OS X 10.4 or later Need to check these versions. FreeBSD should be 6.3, with patches, or preferably 7.0. Others, I don't know. Lastly, the translated READMEs under /documentation likely need _a lot_ of work. Those of you that are bilingual might take a stab at it... There were a couple other minor things that I've sent a patch for: urls lacking trailing backslash, mentioning version .9 instead of 1.0, using solitare as an example program (which we don't include, so I replaced with notepad), etc. -Austin

4 3

Re: msi: fix tab order
by James Hawkins May 25, 2008

May 25, 2008

On Sat, May 24, 2008 at 7:10 PM, Dan Kegel <dank(a)kegel.com> wrote: > When you press Tab in an msi dialog, focus moves the wrong way. > You can confirm the correct tab order by viewing the msi > file in Orca and looking at the Dialog and Control tables. > > It seems that tab order in user32 is equal to z order, > and SetWindowPos() is the function used to control both. > Our msi currently seems to get the first two args backwards; > reversing them fixes http://bugs.winehq.org/show_bug.cgi?id=10147 > and at least superficially makes more sense. > This change is wrong and breaks tab order in (at least) the office installer. -- James Hawkins

1 0

Re: [5/5] d3d9: Test our texop implementation
by Stefan Dösinger May 24, 2008

May 24, 2008

Am Samstag, 24. Mai 2008 10:33:42 schrieb H. Verbeet: > The color_match() function which this test introduces should be used > for the other visual tests that require an approximate match as well, > but doing this is outside the scope of this patch. Dan recently added color_near() for this purpose. Is there any difference between the functions(I see that yours passes the hardcoded slop as a parameter). Do you have any preference towards any implementation? I'm inclined to use yours because of the additional parameter and the better checking with abs()

2 1

Re: RFC: comctl32 indentations
by Hin-Tak Leung May 24, 2008

May 24, 2008

Andrew Talbot wrote: <snipped> > If, in this case, it turns out that the braces should be added, and doing so > would fix some longstanding bug with Photoshop CS2, say, then I doubt that > too many people would accuse me of having wasted their time. This is still a waste of time - I am not going to talk about 'what if's'. Show me the code and show you that you are right. Don't try to tell me that you 'may be' right.

1 0

Re: crypt32: CertComparePublicKeyInfo must ignore the leading zero
by Juan Lang May 24, 2008

May 24, 2008

This one's bugged me for ages, but I never tracked it down. Thanks! --Juan

1 0

Adding d3d9x_xx dlls to winetricks?
by Dan Kegel May 24, 2008

May 24, 2008

So... lots of people are going around installing all of directx, and maybe all they needed was, say, d3d9x_35. That's not good. This sounds like a job for winetricks! But I know nothing about direct3d. Could somebody have a look at this draft and see if it suffices? All I added was d3d9x_35 and d3d9x_36, is that the right set?

7 13

Re: wininet: Make resolving hostnames thread safe.
by Rob Shearman May 24, 2008

May 24, 2008

2008/5/19 Hans Leidekker <hans(a)it.vu.nl>: > @@ -151,7 +158,21 @@ BOOL GetAddress(LPCWSTR lpszServerName, INTERNET_PORT nServerPort, > name = HeapAlloc(GetProcessHeap(), 0, sz+1); > WideCharToMultiByte( CP_UNIXCP, 0, lpszServerName, len, name, sz, NULL, NULL ); > name[sz] = 0; > + > +#ifdef HAVE_LINUX_GETHOSTBYNAME_R_6 > + phe = NULL; > + buf = HeapAlloc(GetProcessHeap(), 0, bufsize); > + while (buf) > + { > + int res = gethostbyname_r(name, &hostentry, buf, bufsize, &phe, &locerr); > + if (res != ERANGE) break; > + bufsize *= 2; > + buf = HeapReAlloc(GetProcessHeap(), 0, buf, bufsize); > + } > + HeapFree(GetProcessHeap(), 0, buf); > +#else > phe = gethostbyname(name); > +#endif In the long term it would be better to use getaddrinfo instead of gethostbyname/gethostbyname_r, but that's too big a change for 1.0. Rob

2 1

Re: ddraw: [3/3] Fix for regression bug #13277
by Stefan Dösinger May 24, 2008

May 24, 2008

> + ref = getRefcount(lpDD); > + ok(ref == 1, "Got refcount %ld, expected 2\n", ref); > + > + IDirectDraw_Release(lpDD); > + > + ref = getRefcount(lpDD); > + ok(ref == 0, "Got refcount %ld, expected 1\n", ref); I think there's a copypaste error, it seems you forgot to adjust the error string. Your test shows the correctness of the patch pretty well, although out of curiosity, can you try this: Between the IDirectDraw_Release(), which reduces the refcount to 0 and the ref = getRefcount(), can you try to HeapAlloc() small portions(e.g. 512 bytes) of memory with HEAP_ZERO_MEMORY until you get an out of memory error. This should make it less likely that the lpDD object survives by luck. It might be destroyed by windows, but the memory is not yet overwritten by something else, so the getRefcount works by luck. If this does not lead to a crash, try the memory allocation + getRefcount again after the Surface::Release call below, there it should cause a crash. > @@ -1998,6 +2026,13 @@ IDirectDrawImpl_CreateNewSurface(IDirectDrawImpl *This, > InterlockedIncrement(&This->surfaces); > list_add_head(&This->surface_list, &(*ppSurf)->surface_list_entry); > > + IDirectDrawInternal_AddRef(This); > @@ -424,6 +424,9 @@ IDirectDrawSurfaceImpl_Release(IDirectDrawSurface7 *iface) > /* Reduce the ddraw refcount */ > if(ifaceToRelease) IUnknown_Release(ifaceToRelease); > LeaveCriticalSection(&ddraw_cs); > + > + /* Surface does not need ddraw anymore, release it's reference */ > + IDirectDrawInternal_Release(ddraw); The counterpart to IDirectDrawImpl_CreateNewSurface is IDirectDrawSurfaceImpl_Destroy, not _Release. CreateNewSurface is called for each complex sublevel surface(e.g. front+backbuffer if they are created via DDSC_COMPLEX), while IDirectDrawSurface::Release must be called only for the root surface(ie, the pointer returned from IDirectDraw::CreateSurface). That means you have to move the IDirectDrawInternal_Release into IDirectDrawSurfaceImpl_Destroy, otherwise there's a reference leak.

2 1

Re: rpcrt4: Skip client tests if the server isn't listening
by Rob Shearman May 24, 2008

May 24, 2008

2008/5/23 Maarten Lankhorst <m.b.lankhorst(a)gmail.com>: > --- > > *Don't apply, breaks tests* > > Rob: Is there anything wrong with this patch apart from the fact it > stops the tests from running in wine due to a failure? Would it > prevent windows failures? > > Ideally I would make our RpcMgmtIsServerListening return RPC_S_OK, but > I don't know the code so I'm afraid to make changes like this. Please give me links to test data that shows this happening and I'll try to figure out why the client isn't able to talk to the client. Rob

1 0

RFC: comctl32 indentations
by Andrew Talbot May 24, 2008

May 24, 2008

Hi, In toolbar.c:TOOLBAR_Destroy(), should the "if" statement at line 5439 be compound to match the indentation, or should the three invocations of TOOLBAR_DeleteImageList() be outdented? treeview.c: In TREEVIEW_DeleteItem(), how conditional is the call of TREEVIEW_SetFirstVisible() at line 1539? I'm guessing that the simple "if" statement at line 3045 just requires indenting(?) If the forum is the wrong place to raise this sort of query, please forgive and advise. :) Thanks, -- Andy.

2 2

Can I do this in WINE?
by Bret Comstock Waldow May 24, 2008

May 24, 2008

I have a Tablet PC, running Kubuntu, and I have just released a project on sourceforge to allow me to use the Microsoft hand writing recognition. The current approach uses a .NET server in IIS running on Tablet XP to provide the recognition. I would prefer to write a classic Windows program that accepts the polyline ink strokes, accesses the Tablet SDK & .dlls to recognize ink, and run that program in WINE directly in Linux without IIS and network connections. I'm thinking of my legal dual-boot installation, and reaching over with WINE to run the app just as I run Notepad from the Windows install now. I'm a Java programmer by day, and I haven't programmed Windows COM before (much). I'd like comments and advice (even help) on doing this. All of this message is written by hand in Linux using the SHIP project (except copying and pasting this URL): https://sourceforge.net/projects/ship-project/ Thanks in advance for information, bret

5 14

New winetricks 20080523: directx9, bugfixes
by Dan Kegel May 23, 2008

May 23, 2008

Another week, another winetricks. Changes since May 19's wine-devel annoucement: r52: - rotate sourceforge mirrors to avoid getting stuck on bad one - cope with users who rename c:/windows/Fonts to c:/windows/fonts - more conservative advice on sha1sum mismatches - handle bad exit status from /usr/bin/which on mac - cope with redhat.com sending decompressed files - use win2K when installing directx9 so it installs more stuff r50: - Added directx9 verb Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com

1 0

Proposed indentation fixes
by Andrew Talbot May 23, 2008

May 23, 2008

Hi All, I'm intending to "correct" some indentation anomalies, and I propose to do this in an "indiscriminate" way. In other words, I would set the indentation to match what the code does now, without any interpretation of what may have been intended. This means that something like if (a) b; c; would become 1) if (a) b; c; rather than 2) if (a) { b; c; } The advantages are that the code is "honest" and the existing behaviour is preserved. The disadvantages are that if (2) were intended, it won't be achieved here, and the corrected version will no longer "suggest" what was really intended. Is this "automatic" method still the way to go? Thanks, -- Andy.

2 2

unknown device issues after running winetest
by Paul Vriens May 23, 2008

May 23, 2008

Hi, On several windows boxes (VMware) I receive this nice message that Windows will try to find a driver for an unknown device. This device is added by the setupapi/devinst test and is not (or can't be?) properly removed after the tests. On NT/W2K I'm able to delete all the relevant registry keys (regedt32.exe) but on Vista I don't seem to be able to delete them Any idea? Do others have the same issue(s) ? -- Cheers, Paul.

5 30

Re: ddraw: Fixed in part regression bug #13277, retry
by Stefan Dösinger May 23, 2008

May 23, 2008

Please send test and patch in one patch file, or send them in different emails if a combined patch is too big(which surely isn't the case here)

1 0

rpcrt4 test failures
by Maarten Lankhorst May 23, 2008

May 23, 2008

Hi Rob, I roughly found the reason of the rpcrt4:server test crashing for me. It crashes when it's trying to connect to localhost through the rpc 'tcp' transport. The crash is likely caused because it can't connect to the locally hosted test server the tcp way, and decides to bomb out instead. However it won't say it failed to connect, instead it crashes on the first test-case that uses rpc. I would rather not have the test crash, that would also obscure the possibility of running the other tests in that file. However I don't know why it fails to connect over tcp (netbios works fine). I disabled my firewall entirely, so it shouldn't be the cause of this failure. Could there be other restrictions in place? Cheers, Maarten

1 0