May 2008 - Wine-Devel - list.winehq.org

Re: mlang: Make mlang tests pass under windows
by Dmitry Timoshkov May 8, 2008

May 8, 2008

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > + /* Not all codepages can be converted to UTF-8 */ > + if (cpinfo[i].uiCodePage == 20127 || cpinfo[i].uiCodePage == 28591 || cpinfo[i].uiCodePage == 28605) > + expected = S_FALSE; The statement above is not true. The reason for mlang test failures is that apparently mlang in Windows has its own idea of supported locales not connected to real kernel32 implementation. I'd leave the tests as they are, there is nothing wrong in them, we can't fix Windows bugs. -- Dmitry.

2 2

Bison 2.1 / Solaris
by Austin English May 8, 2008

May 8, 2008

Howdy, Tried compiling wine on Nexenta (Opensolaris kernel with GNU userland). Trying to test out the conformance test, but can't get it to compile: make[2]: Entering directory `/export/home/austin/wine/libs/wpp' gcc -c -I. -I. -I../../include -I../../include -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o preproc.o preproc.c gcc -c -I. -I. -I../../include -I../../include -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o wpp.o wpp.c bison -p ppy_ -o ppy.tab.c -d ppy.y make[2]: *** [ppy.tab.h] Broken Pipe make[2]: Leaving directory `/export/home/austin/wine/libs/wpp' make[1]: *** [wpp] Error 2 make[1]: Leaving directory `/export/home/austin/wine/libs' make: *** [libs] Error 2 austin(a)nexenta:~/wine$ bison --version bison (GNU Bison) 2.1 Looking at my feisty box, looks like it's using 2.3. Anyone had similar troubles getting wine to compile in 2.1? Google's not turning up much, aside from saying get it precompiled... -Austin

3 2

Re: wininet: Deal with bogus accept types array passed into HttpOpenRequestA.
by Maarten Lankhorst May 7, 2008

May 7, 2008

Hoi Hans 2008/5/7 Hans Leidekker <hans(a)it.vu.nl>: > > The bug reporting agent in Google Sketchup passes an accept types > array that includes a wild pointer and a pointer to an empty string, > both of which are ignored by Windows. Although the wild pointer changed > between a number of tries its high word remained unset, so we may get > away with a check on the high word instead of an exception handler. > > Fixes http://bugs.winehq.org/show_bug.cgi?id=11954 > > -Hans This test fails on xp for me, can you fix it? http.c:1767: Test failed: got ', */*, %p, , */*' expected '*/*, %p, */*' Cheers, Maarten.

1 0

Re: SOC 2008 Projects Announced
by Dylan Smith May 7, 2008

May 7, 2008

Hello everyone, My name is Dylan Smith, and I will be working on implementing tables in rich edit controls as a Google Summer of Code project. Any remaining time I have will also be focused on rich edit controls for this summer. Forgive me for taking so long to introduce myself on the developers mailing list. I ended up going straight for the code as soon as my exams finished. I just finished my last year of Software Engineering at Carleton University which is located in Ottawa, Canada. I will be returning to Carleton University for my Masters after the summer. I am thrilled that I am getting this opportunity to work on Wine for the summer. Happy coding to you all, Dylan

1 0

2nd draft: 1.0 call for testing
by Dan Kegel May 7, 2008

May 7, 2008

How's this look? It's on the wiki now: http://wiki.winehq.org/PlatinumRegressionHunt

1 0

winetricks missing MFC42
by Cesar Izurieta May 7, 2008

May 7, 2008

I see that MFC42 is missing on wine tricks. There's a cab available from: http://activex.microsoft.com/controls/vc/mfc42.cab that contains an installer. It would be nice to add this to winetricks I guess.

1 0

Re: [PATCH] check for iface->ref to avoid crash
by Robert Shearman May 7, 2008

May 7, 2008

Marcus Meissner wrote: > @@ -742,6 +742,9 @@ static void write_c_method_def(FILE *header, const type_t *iface) > > static void write_c_disp_method_def(FILE *header, const type_t *iface) > { > + if (!iface->ref) { > + error_loc("write_c_disp_method_def: no reference on interface(%p)\n", iface); > + } > do_write_c_method_def(header, iface->ref, iface->name); > } > This can't ever happen. dispinterfaces always derive from IDispatch: > dispinterfacehdr: attributes dispinterface { attr_t *attrs; > is_in_interface = TRUE; > is_object_interface > = TRUE; > $$ = $2; > if ($$->defined) > error_loc("multiple definition error\n"); > attrs = > make_attr(ATTR_DISPINTERFACE); > $$->attrs = > append_attr( check_dispiface_attrs($2->name, $1), attrs ); > $$->ref = > find_type("IDispatch", 0); > if (!$$->ref) > error_loc("IDispatch is undefined\n"); > $$->defined = TRUE; > if (!parse_only && > do_header) write_forward($$); > } -- Rob Shearman

2 1

Re: rpcrt4: Fix ndr_marshall test failures, try 2
by Robert Shearman May 7, 2008

May 7, 2008

Maarten Lankhorst wrote: > - ok(RPC_S_OK == RpcServerUseProtseqEp(ncalrpc, 20, endpoint, NULL), "RpcServerUseProtseqEp\n"); > - ok(RPC_S_OK == RpcServerRegisterIf(IFoo_v0_0_s_ifspec, NULL, NULL), "RpcServerRegisterIf\n"); > - ok(RPC_S_OK == RpcServerListen(1, 20, TRUE), "RpcServerListen\n"); > + status = RpcServerUseProtseqEp(ncalrpc, 20, endpoint, NULL); > + ok(RPC_S_OK == status, "RpcServerUseProtseqEp failed with status %08lx\n", status); > + status = RpcServerRegisterIf(IFoo_v0_0_s_ifspec, NULL, NULL); > + ok(RPC_S_OK == status, "RpcServerRegisterIf failed with status %08lx\n", status); > + status = RpcServerListen(1, 20, TRUE); > + ok(RPC_S_OK == status, "RpcServerListen failed with status %08lx\n", status); > Since the RPC status values are in decimal in winerror.h, it is more user-friendly to output them in decimal in the failure messages. -- Rob Shearman

1 0

What happened to the ntdll rtlstr tests?
by Maarten Lankhorst May 7, 2008

May 7, 2008

Hello Alexandre, Why were the fixes for the ntdll rtlstr test failures on windows not accepted? Cheers, Maarten.

2 1

Serial port support in wine-1.0: What to do to make it working ?
by Pavel Troller May 7, 2008

May 7, 2008

Hi! I have really BIG problems running any application, which needs to comm over a serial port: - My ham TCVR - My GPS - My multimeter - A lot of my mobiles - A lot of devices used in my work (special telco equipment, comms varying from simple AT-style commands up to complex proprietary binary protocols). In all the cases there are very similar problems - either the program doesn't detect the device properly, or the device doesn't respond, or in some cases the device does, what the program wants, but it then can't read it back. It looks that some archaic wine versions are better, for example I have to use wine-0.9.40 to communicate with a device in my work (simple text-based command-reply communication), any wine newer than say 0.9.50 doesn't work, the communication times out. Because I'm a telco engineer and serial comm is my daily work, and there are only windows versions of many tools I have to use, proper and mature serial port support is essential for me. So, what can I do to help fixing these problems ? Should I open a bug for every such a program ? Or just open one bug and state all the programs there ? I think that bugzilla contains a lot of bugs related to serial port; is it good to add a new ones ? I'm afraid I can't bisect a problem between 0.9.40 and current wine, but I can make a serial trace for both of them and look at the difference. Would it help to find at least this one particular problem ? Or what more can I do to make the serial port working ? I can code in C in the Linux environment, but I know NOTHING about windows... With regards, Pavel Troller

3 3

winetest problems
by James Hawkins May 7, 2008

May 7, 2008

Hi, I'm trying to fix the failing cross tests, but we haven't had a winetest build on Paul Millar's server in a few days. I'm not familiar with Paul's build process, so my only guess is that a recent commit has broken the build. In the meantime, I've tried a few things. I used John Klehm's crossbuild_tricks script [1] to build winetest. The build succeeded, but the submitted result [2] is empty or can't be parsed. I ran 'make crosstest' from the build directory which fails with: make[2]: Entering directory `/home/truiken/mywine/wine-build/dlls/advpack/tests' i586-mingw32msvc-gcc -c -I../../../../../wine/dlls/advpack/tests -I. -I../../../../../wine/include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o advpack.cross.o ../../../../../wine/dlls/advpack/tests/advpack.c ../../../../../wine/dlls/advpack/tests/advpack.c:1: warning: -fPIC ignored for target (all code is position independent) i586-mingw32msvc-gcc -c -I../../../../../wine/dlls/advpack/tests -I. -I../../../../../wine/include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o files.cross.o ../../../../../wine/dlls/advpack/tests/files.c ../../../../../wine/dlls/advpack/tests/files.c:1: warning: -fPIC ignored for target (all code is position independent) i586-mingw32msvc-gcc -c -I../../../../../wine/dlls/advpack/tests -I. -I../../../../../wine/include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o install.cross.o ../../../../../wine/dlls/advpack/tests/install.c ../../../../../wine/dlls/advpack/tests/install.c:1: warning: -fPIC ignored for target (all code is position independent) ../../../tools/make_ctests -o testlist.c advpack.c files.c install.c i586-mingw32msvc-gcc -c -I../../../../../wine/dlls/advpack/tests -I. -I../../../../../wine/include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o testlist.cross.o testlist.c testlist.c:1: warning: -fPIC ignored for target (all code is position independent) i586-mingw32msvc-gcc advpack.cross.o files.cross.o install.cross.o testlist.cross.o -o advpack_crosstest.exe -lcabinet -ladvapi32 -lkernel32 /usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/bin/ld: cannot find -lcabinet collect2: ld returned 1 exit status make[2]: *** [advpack_crosstest.exe] Error 1 make[2]: Leaving directory `/home/truiken/mywine/wine-build/dlls/advpack/tests' make[1]: *** [advpack/tests/__crosstest__] Error 2 make[1]: Leaving directory `/home/truiken/mywine/wine-build/dlls' Which (I assume) is usually fixed by Paul Millar's win32api custom patches. Any thoughts or ideas? [1] http://klehm.net/wine/crossbuild_tricks.sh [2] http://test.winehq.org/data/1a5aab0ddcc7a0dcde4403add73dbd80be746020/ -- James Hawkins

5 9

Re: [PATCH] fixed if check before strchr
by Eric Pouech May 6, 2008

May 6, 2008

Marcus Meissner a écrit : > Hi, > > spotted by Coverity (CID 701), a if (!spath) should be if (spath). > > Ciao, Marcus > --- > programs/winedbg/source.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/programs/winedbg/source.c b/programs/winedbg/source.c > index 5519c57..1db7092 100644 > --- a/programs/winedbg/source.c > +++ b/programs/winedbg/source.c > @@ -128,7 +128,7 @@ static BOOL source_locate_file(const char* srcfile, char* path) > while (!found) > { > spath = strchr(spath, '\\'); > - if (!spath) spath = strchr(spath, '/'); > + if (spath) spath = strchr(spath, '/'); > if (!spath) break; > spath++; > found = SearchPathA(dbg_curr_process->search_path, spath, NULL, MAX_PATH, path, NULL); > actually no the code intends to find the first occurence of / or \ A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

4 3

Re: [PATCH 1/3] dinput: Remove redundant variable.
by Vitaliy Margolen May 6, 2008

May 6, 2008

Vitaliy Margolen wrote: > --- > dlls/dinput/joystick_linux.c | 16 +++++++--------- > 1 files changed, 7 insertions(+), 9 deletions(-) > Forgot to add that this series of patches should finally address bugs 12052 and 11644. Was there anything wrong with these patches? Vitaliy.

1 1

draft Call for Testing
by Dan Kegel May 6, 2008

May 6, 2008

So, what should we be asking wine users to be doing once rc1 is out? How about this: --- snip --- Calling all wine users! Today, after 15 years of development, the first release candidate for wine-1.0.0 was released. Wine has been under heavy development in recent months, and some applications that used to work well no longer do. But we don't know which ones! Please help us find them, so we can fix them. Here's how: 0. Make sure your machine runs glxgears properly (if it crashes, you may need to update your graphics drivers) 1. Install wine-1.0.0-rc1 (you can download it from http://www.winehq.org/site/download ). Make sure wine's notepad starts up ok and says "wine 1.0.0 rc1" when you do Help / About Wine. 2. Visit the Wine application database at http://appdb.winehq.org/browse_by_rating.php?sRating=Platinum and pick out a few applications that supposedly work perfectly under Wine but do not yet have any test reports with wine-1.0.0-rc1 or later. 3. Try installing and running those apps, one at a time. Before installing each app, delete your .wine directory; that way you get a clean run, uncontaminated by the previous app's settings. 4. For each app you test, add a test report into Wine's AppDB. As a token of our thanks, we will pick one of the users who submits a healthy set of useful test results and send him or her a tasteful Wine-themed goodie of some sort. So fire up your keyboards and start testing! Thanks, and good hunting! --- snip --- (Not sure how the goodie would be handled, but I'm willing to cover the expenses myself, especially if I get to pick the winner :-) How's that sound?

7 8

Re: [PATCH 3/3] ddraw/tests: Add tests for IDirect3DDevice7_Load.
by Stefan Dösinger May 6, 2008

May 6, 2008

Am Montag, 5. Mai 2008 23:49:34 schrieb Alexander Dorofeyev: > + /* Freed in reverse order as native seems to dislike and crash on > freeing top level surface first. */ just fyi, native ignores refcounts on sublevels(if they are created as complex surface, not attached). As long as the top level exists, you can release the sublevels into oblivion if you want to, they'll stay around. If the top level is destroyed, the sublevels are destroyed regardless of their refcounts. There are some tests for this behavior in dsurface.c, and Wine does the same essentially. A very extensive test, wow!

1 0

Re: AppDB: update the general help page and also make it valid html
by Alexander Nicolaysen Sørnes May 6, 2008

May 6, 2008

> I've updated the general help page with links to git instead of cvs, > updated building instructions and also changed the html a little so it > validates, I've also removed a link to a cracks website and replaced > it with a statement about third party software. > > before and after: http://img222.imageshack.us/img222/8647/baiz4.png It's great that you're fixing up the help pages. But i don't see why you are removing the link to MegaGames; I added it to make it easier for users to test games without a how-to; removing it would appear to do the opposite. Alexander N. Sørnes

1 0

Re: netapi32: Fix test crash occuring when NetWkstaUserGetInfo fails, try 2
by James Hawkins May 6, 2008

May 6, 2008

On Tue, May 6, 2008 at 1:36 AM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > Improved from James Hawkins suggestions. > --- > Just to clear my name, this is not what I suggested :-) -- James Hawkins

1 0

wineserver socket file and DOS attacks
by Steven Elliott May 6, 2008

May 6, 2008

I have some concerns about the location of the socket file that wineserver uses. Since by default the current location is in /tmp my concern is that anyone can stop anyone else from using wine just by creating a directory named /tmp/.wine-500. As far as I know the only risk is denial of service in nature since wine seems to be smart enough to make sure the /tmp/.wine-500 is owned by the user invoking the wine application: > notepad wineserver: /tmp/.wine-500 is not owned by you Previously the socket file was under ~/.wine. I found this which briefly documents the change here: http://www.winehq.org/site/docs/winedev-guide/x2584 under section "7.3.2. The Wine server" it says: "In earlier versions of Wine the master socket mentioned above was actually created in the configuration directory; either your home directory's /wine subdirectory or wherever the WINEPREFIX environment variable points. Since that might not be possible the socket is actually created within the /tmp directory with a name that reflects the configuration directory." /tmp/.wine-<user Id> is hard coded in libs/wine/config.c, so that aspect of the socket file location is not configurable. Anyway, have alternatives such as the following been considered?: 1) Create the socket file in ~/.wine (or wherever WINEPREFIX points) like wine used to if the user's home directory exists and is writable. Use /tmp/.wine-<user Id> as a fallback. 2) Append some additional integer to /tmp/.wine-<user Id> that is incremented if that directory already exists and is owned by someone else. For example, if /tmp/.wine-500 already exists for user 500 but is owned by someone else then both wineserver and the wine application would append "-1" and then keep incrementing: /tmp/.wine-500 /tmp/.wine-500-1 /tmp/.wine-500-2 until they each found a directory owned by the current user (or until they are able to create one). Hopefully they would pick the same directory. I need to think more about how robust this would be. -- ----------------------------------------------------------------------- | Steven Elliott | selliott4(a)austin.rr.com | -----------------------------------------------------------------------

6 10

Bug#479659: RFH: wine -- Windows API implementation
by Ove Kaaven May 6, 2008

May 6, 2008

Package: wnpp Severity: normal Since my time may be limited in the future, I am seeking comaintainers for the Wine package in Debian, at least to ensure that new Wine releases may continue to be uploaded in a timely fashion, and to keep the package's bug count down. (And given that pretty much half the open bugs are "missing manpage" bugs, documentation writers would also help...) I have created a project for this on alioth.debian.org. I've loaded the current packaging (all versions since etch) into a Git repository there, and put up some instructions on http://pkg-wine.alioth.debian.org/ -- System Information: Debian Release: lenny/sid APT prefers testing APT policy: (650, 'testing'), (600, 'unstable') Architecture: i386 (i686) Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core) Locale: LANG=en_US.ISO-8859-1, LC_CTYPE=en_US.ISO-8859-1 (charmap=ISO-8859-1) Shell: /bin/sh linked to /bin/bash

1 0

bugzilla rights request
by Alexander Dorofeyev May 6, 2008

May 6, 2008

Hi. I would like to have rights to change bug status. I fix some bugs myself and also occasionally do some bug-triaging, so it would be handy. Thanks.

1 0

re: Vehicle for minor bugs?
by Dan Kegel May 5, 2008

May 5, 2008

Andrew Talbot wrote: > Frequently, I am finding minor bugs that I probably cannot fix myself, that > are probably not suitable for a Bugzilla bug report and that are likely to > be ignored if posted to wine-devel (witness my current postings: "XBOOL, > XBYTE, XINT8, etc." and "Five functions that cannot handle a NULL > parameter", I haven't seen those posts, where are they? I'd say a conformance test would be the right vehicle.

3 2

Re: Jacek Caban : mshtml: Added IMG element tests.
by Alistair Leslie-Hughes May 5, 2008

May 5, 2008

"Alexandre Julliard" <julliard(a)winehq.org> wrote in message news:E1Jszaj-0008Vx-SO(a)wine.codeweavers.com... > Module: wine > Branch: master > Commit: 29d8c366bb278a6b73c3669817063087d7cd080d > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=29d8c366bb278a6b73c366981… > > Author: Jacek Caban <jacek(a)codeweavers.com> > Date: Sun May 4 19:22:46 2008 +0200 > > mshtml: Added IMG element tests. > > --- > > dlls/mshtml/tests/dom.c | 19 +++++++++++++++++-- > 1 files changed, 17 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c > index 1039ab5..a3d0701 100644 > --- a/dlls/mshtml/tests/dom.c > +++ b/dlls/mshtml/tests/dom.c > @@ -48,6 +48,7 @@ static const char elem_test_str[] = > "<table><tbody></tbody></table>" > "<script id=\"sc\" type=\"text/javascript\"></script>" > "<test />" > + "<img /" ^^^ Is this mssing a ending > Best Regards Alistair Leslie-Hughes

2 1

Time-based releases idea
by Dan Kegel May 5, 2008

May 5, 2008

I just wrote up an idea related to release management for post-1.0 wine releases. It's online at http://wiki.winehq.org/TimeBasedReleases Essentially, the idea is to release in March and September, in time for the April and October releases of Ubuntu. For instance, following this strategy, we might plan to release wine-1.2.0 in September 2008 or March 2009. The alternative is to propose a set of criteria that wine-1.2 needs to meet, and working until they are met, which is what we did for wine-0.9 and wine-1.0 (I think; it's kind of hard to tell). I look forward to discussing this idea... perhaps we shouldn't bother to until after 1.0 is released, but I wanted to get it out early so the discussion can begin in time for us to move on it if we want to. - Dan

10 13

quartz: regression: Assertion failed at pin.c:1236
by Alex Villacís Lasso May 5, 2008

May 5, 2008

The patch: 3066116f76c0c44950fde3552485b37dce24d1f8 quartz: Clean up pullpin code. causes a regression in a test application I have. I see the following message in the console: pin.c:1236: PullPin_Init: La declaración `pCustomRequest' no se cumple. And I get an "Automation error" in a message box. This, every time I try to load an AVI file in a Windows Media Control. Reversing the patch gets rid of the error. I believe this patch was to be followed by a cleanup of code to ensure that no users of PullPin_Init pass a NULL pCustomRequest. However, this parameter gets passed as NULL from parser.c:92, which in turn gets it from avisplit.c, mpegsplit.c and waveparser.c, all of them with NULL as the value for the parameter. Was there supposed to be any follow-up patch for this? Why was it not committed? -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 1

Re: d3dx8: Dynamically import d3dx8 in the tests so the tests can be skipped if the dll is not found
by Paul Vriens May 5, 2008

May 5, 2008

Maarten Lankhorst wrote: > This is better then downright crashing on the missing dlls. > > This patch was created using grep and sed. :-) > --- > > > ------------------------------------------------------------------------ > > Hi Maarten, When do you see a crash? Winetest itself already checks if a dll is present. If it's not, the tests are skipped as can be seen on test.winehq.org.. -- Cheers, Paul.

3 2

[PATCH] Add SIO_KEEPALIVE_VALS support to winsock
by Couriousous May 5, 2008

May 5, 2008

Hello When Altium 6 is used with a license server, it need the WSAIoctl() with SIO_KEEPALIVE_VALS control code to succeed, otherwise it cannot connect to the license server. The following patch implement the missing parts and allow altium 6 to works perfectly with wine ! Regards, Philippe --- Index: dlls/ws2_32/socket.c =================================================================== --- dlls/ws2_32/socket.c +++ dlls/ws2_32/socket.c 2008-05-04 13:53:50.000000000 +0200 @@ -2292,6 +2292,48 @@ WSASetLastError(WSAEOPNOTSUPP); return SOCKET_ERROR; + case WS_SIO_KEEPALIVE_VALS: + if(lpvInBuffer) { + int fd; + struct tcp_keepalive *d = lpvInBuffer; + int idle = d->keepalivetime / 1000; + int interv = d->keepaliveinterval / 1000; + int enable = d->onoff ? 1: 0; + TRACE("socket %04lx, keepalivetime: %d, keepaliveinterval: %d\n", s, idle, interv); + if(idle == 0 || interv == 0) { + WSASetLastError(WSAEINVAL); + return SOCKET_ERROR; + } + fd = get_sock_fd( s, 0, NULL ); + if(setsockopt(fd, SOL_SOCKET, SO_KEEPALIVE, (void *) &enable, sizeof(int)) == -1) { + release_sock_fd( s, fd ); + WSASetLastError(WSAEINVAL); + return SOCKET_ERROR; + } +#if (defined TCP_KEEPIDLE) && (defined TCP_KEEPINTVL) + if(setsockopt(fd, IPPROTO_TCP, TCP_KEEPIDLE, (void *) &idle, sizeof(int)) == -1) { + release_sock_fd( s, fd ); + WSASetLastError(WSAEINVAL); + return SOCKET_ERROR; + } + + if(setsockopt(fd, IPPROTO_TCP, TCP_KEEPINTVL, (void *) &interv, sizeof(int)) == -1) { + release_sock_fd( s, fd ); + WSASetLastError(WSAEINVAL); + return SOCKET_ERROR; + } +#else + FIXME("Ignoreing keepalive interval and timeout"); +#endif + release_sock_fd( s, fd ); + break; + } else { + WSASetLastError(WSAEINVAL); + return SOCKET_ERROR; + } + + break; + default: FIXME("unsupported WS_IOCTL cmd (%08x)\n", dwIoControlCode); WSASetLastError(WSAEOPNOTSUPP); Index: include/winsock2.h =================================================================== --- include/winsock2.h +++ include/winsock2.h 2008-05-03 22:45:08.000000000 +0200 @@ -142,6 +142,7 @@ #define WS_SIO_ADDRESS_LIST_CHANGE _WSAIO(WS_IOC_WS2,23) #define WS_SIO_QUERY_TARGET_PNP_HANDLE _WSAIOR(WS_IOC_WS2,24) #define WS_SIO_GET_INTERFACE_LIST WS__IOR('t', 127, WS_u_long) +#define WS_SIO_KEEPALIVE_VALS _WSAIOW(WS_IOC_VENDOR,4) #else /* USE_WS_PREFIX */ #undef IOC_VOID #undef IOC_IN @@ -178,8 +179,16 @@ #define SIO_ADDRESS_LIST_CHANGE _WSAIO(IOC_WS2,23) #define SIO_QUERY_TARGET_PNP_HANDLE _WSAIOR(IOC_WS2,24) #define SIO_GET_INTERFACE_LIST _IOR ('t', 127, u_long) +#define SIO_KEEPALIVE_VALS _WSAIOW(IOC_VENDOR,4) #endif /* USE_WS_PREFIX */ +/* Argument structure for SIO_KEEPALIVE_VALS */ +struct tcp_keepalive { + u_long onoff; + u_long keepalivetime; + u_long keepaliveinterval; +}; + /* Constants for WSAIoctl() */ #define WSA_FLAG_OVERLAPPED 0x01 #define WSA_FLAG_MULTIPOINT_C_ROOT 0x02

3 2

Re: d3d8: Dangling pointers fix
by Stefan Dösinger May 5, 2008

May 5, 2008

Am Montag, 5. Mai 2008 17:42:51 schrieb Andrew Talbot: > I have moved the TRACEs to where I think they belong. Please give feedback > if this patch is incorrect. on a quick look it looks OK. Did you check if any output is written in the case of failures in those functions?

2 1

Vehicle for minor bugs?
by Andrew Talbot May 5, 2008

May 5, 2008

Hi, Frequently, I am finding minor bugs that I probably cannot fix myself, that are probably not suitable for a Bugzilla bug report and that are likely to be ignored if posted to wine-devel (witness my current postings: "XBOOL, XBYTE, XINT8, etc." and "Five functions that cannot handle a NULL parameter", and apologies if you are feverishly working on replies or patches for either of these ;) ). For an explicit example - from the later posting - I know that one should be able to call LookupPrivilegeNameW() with its optional "lpName" parameter given a NULL pointer argument, as indeed we do ourselves in advapi32/security:line 1760, but we pass this down, within our rendition of this function, as the first argument to strcpyW() (on line 1852). This is clearly a bug and it seems not to have been spotted by Coverity. The patch I sent for this would appear to have been inadequate, so it would be good if I could flag this bug up on a janitorial page somewhere, perhaps categorized by dll, so that the advapi32 experts (in this case) could occasionally browse for such things. What do people think? Thanks, -- Andy.

1 0

Re: credui: Danish translation
by Robert Shearman May 4, 2008

May 4, 2008

Jens Albretsen wrote: > Changelog: > Danish translation of credui > > +LANGUAGE LANG_DANISH, SUBLANG_DEFAULT > + > +IDD_CREDDIALOG DIALOG DISCARDABLE 0, 0, 213, 149 > +STYLE DS_MODALFRAME | DS_NOIDLEMSG | DS_CENTER | WS_POPUP | WS_CAPTION | WS_SYSMENU > +CAPTION "IDS_TITLEFORMAT" > +FONT 8, "MS Shell Dlg" > +BEGIN > + CONTROL IDB_BANNER,IDC_STATIC,"Statisk",SS_BITMAP | SS_CENTERIMAGE,0, > + 0,213,37 It's an easy mistake to make, but the third piece of data for the CONTROL statement is the name of a Windows class, so it shouldn't be translated. BTW, you can test your translation of credui by running the credui tests with the WINETESTINTERACTIVE environment variable to "1". -- Rob Shearman

1 0

winex11.drv: Set the size of returned DEVMODE to least common one as XP does
by David Adam May 4, 2008

May 4, 2008

Hello >- devmode->dmSize = sizeof(DEVMODEW); >- devmode->dmSpecVersion = MAKEWORD(1,4); >- devmode->dmDriverVersion = MAKEWORD(1,4); >+ devmode->dmSize = FIELD_OFFSET(DEVMODEW, dmICMMethod); >+ devmode->dmSpecVersion = DM_SPECVERSION; >+ devmode->dmDriverVersion = DM_SPECVERSION; Wouldn't it be better to write *devmode->dmDeviceName=*dev_name instead of > memcpy(devmode->dmDeviceName, dev_name, sizeof(dev_name)); David

2 1

Steampowered.com has sent me ~10 e-mails
by Brian Fuller May 4, 2008

May 4, 2008

I've gotten ~10 e-mails from steampowered.com regarding this issue. Everyone of them is virtually nothing but quoted information. I had TF2 crash on my computer, then I went back in, snagged the memory dumps and submitted them to steampowered.com, told them I was on the wine list and I needed better DLL support from Nvidia. Once they established that I had the advanced guide for myself, and I continued to procede by telling them: After running Steam and opening TF2, download initializes from server correctly, as connecting to server system goes down. kern.log: Apr 30 09:51:17 slinker-desktop kernel: [52605.857549] totem-plugin-vi[20091]: segfault at 4 rip 411a15 rsp 7fff5f4cb3e0 error 4 Apr 30 09:51:17 slinker-desktop kernel: [52605.934792] totem-plugin-vi[20089]: segfault at 4 rip 411a15 rsp 7fffaea1a930 error 4 Same two error messages in messages ----------- Next: Brian, Thank you for submitting these minidumps. If you continue to experience problems with game crashes, please complete the steps in the link below. Title: Troubleshooting Game Crashes Link: http://support.steampowered.com/kb_article.php?ref=7169-TIAV-5361 ------------- I'm not sure if this helps, but I was working on WineHT.dll at the same time, and maybe some sort of mis-interaction on the level of an application running on my operating system with your product could've resulted in the crash? I was just hoping with the specific information on those memory locations perhaps you could provide me some knowledge of the Windows/DirectX API that deals with these particular switches, as to enlighten me towards my game not crashing in the future. Sorry to complicate the issue :\ -BAF ----------- they responded with nothing but quotes Now I'm trying to differentiate on an iron curtain the color differences being generated by heat being applied using nothing but a router. Figuring out why it corrupted those packets would be accessed in the API, then put into the CPU, calculating this. Once you've calculated the color differentiations throughout the sheet, you could re-draw this sheet in 3d with the right colors using OpenGL. That's the goal at least. The important part being the edges between the different colors. They finally closed the ticket today. -BAF P.S. Just have a seat, I'll be right with you with valid code.

1 0

Re: [PATCH 1/3] headers: add CM_Reenumerate_DevNode, CM_Locate_DevNode prototypes
by Dmitry Timoshkov May 4, 2008

May 4, 2008

From: "Vitaly Lipatov" <lav(a)etersoft.ru> wrote: > +#ifdef UNICODE > +typedef DEVNODEID_W DEVNODEID; > +typedef DEVINSTID_W DEVINSTID; > +#else > +typedef DEVNODEID_A DEVNODEID; > +typedef DEVINSTID_A DEVINSTID; > +#endif Wine headers do that differently. > +CMAPI CONFIGRET WINAPI CM_Locate_DevNodeA(PDEVINST,DEVINSTID_A,ULONG); > +CMAPI CONFIGRET WINAPI CM_Locate_DevNodeW(PDEVINST,DEVINSTID_W,ULONG); > +#define CM_Locate_DevNode WINELIB_NAME_AW(CM_Locate_DevNode) > + > +CMAPI CONFIGRET WINAPI CM_Reenumerate_DevNode(DEVINST,ULONG); > +CMAPI CONFIGRET WINAPI CM_Reenumerate_DevNode_Ex(DEVINST,ULONG,HMACHINE); You need to add the prototypes when you add implementations. -- Dmitry.

1 1

X_BOOL, X_BYTE, X_INT8, etc.?
by Andrew Talbot May 3, 2008

May 3, 2008

In xlldrv.h, various scalar types are redefined, for example #define BOOL X_BOOL If these "X" variants exist on my system, they are not being included in xfont.c. Where should I find them, please? Thanks, -- Andy.

1 0

Possible Regression in 3Dmark 03 in win2000 mode
by Steven Edwards May 3, 2008

May 3, 2008

Hi, Sorry to spam wine-devel...I don't have the time to file a proper bug report right now and I did not want to waste my time if the directx guys were aware of it and working on it but 3DMark03 is crashing for me in wn2000 mode while it functions in win98 mode. This is a regression and a new bug, it would be nice to have as many benchmarks as possible working so when 1.0 ships we can compare results to windows. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 1

Re: WineD3D: RemoveContextFromArray fix (fixes bug 12924)
by Stefan Dösinger May 3, 2008

May 3, 2008

Am Samstag, 3. Mai 2008 20:23:17 schrieb Roderick Colenbrander: > Hi, > > RemoveContextFromArray forgot to check the last element in the array. This > led to memory corruption (bug 12924) where wined3d started removing a > pbuffer where none was created at all. This patch fixes it. The original > bug was spotted by Peter Oberndorfer and for him a similar fixed some other > program not sure which. Maybe a comment would be helpful, reminding the reader that This->numContexts was decremented already and thus the <= is used. It took me a while to figure that out when reading the patch

1 0

Fix building tools/widl (for bison 1.75, among others)
by Gerald Pfeifer May 3, 2008

May 3, 2008

After the following change about a week ago Rob Shearman <rob(a)codeweavers.com> widl: Make the rules for parsing fields in structures, encapsulated unions and non-encapsulated unions more strict. Move the rules in fields that handle empty union cases into separate union rules so that they can't erroneously be accepted for structures or other types of unions. I started seeing the following build failure on one older installation: bison -p parser_ -o parser.tab.c -d parser.y parser.y:749.2-751.15: type clash (`var' `attr_list') on default action parser.y:751.16: parse error, unexpected ":", expecting ";" or "|" parser.y:752.35-59: $2 of `ne_union_field' has no declared type parser.y:757.2-759.7: type clash (`var' `') on default action parser.y:759.8: parse error, unexpected ":", expecting ";" or "|" parser.y:759.45-760.50: $1 of `union_field' has no declared type parser.y:759.45-761.23: $2 of `union_field' has no declared type gmake: *** [parser.tab.h] Error 1 It turns out that current versions of bison do not enforce the documented grammer as strictly as older ones such as bison 1.75. Fixed thusly. Gerald ChangeLog: Fix syntax to also work with older versions of bison. Index: tools/widl/parser.y =================================================================== RCS file: /home/wine/wine/tools/widl/parser.y,v retrieving revision 1.199 diff -u -3 -p -r1.199 parser.y --- tools/widl/parser.y 1 May 2008 18:38:07 -0000 1.199 +++ tools/widl/parser.y 2 May 2008 12:07:24 -0000 @@ -747,6 +747,7 @@ field: m_attributes decl_spec declarat ne_union_field: s_field ';' { $$ = $1; } | attributes ';' { $$ = make_var(NULL); $$->attrs = $1; } + ; ne_union_fields: { $$ = NULL; } | ne_union_fields ne_union_field { $$ = append_var( $1, $2 ); } @@ -755,6 +756,7 @@ ne_union_fields: { $$ = NULL; } union_field: s_field ';' { $$ = $1; } | ';' { $$ = NULL; } + ; s_field: m_attributes decl_spec declarator { $$ = $3->var; $$->attrs = check_field_attrs($$->name, $1);

2 2

Five functions that cannot handle a NULL parameter
by Andrew Talbot May 3, 2008

May 3, 2008

In case anyone wishes to note or fix them, here are five functions that are being called with a NULL parameter that they cannot yet properly handle, and which they are passing down to a str...() or mem...() function. I may be wrong, but I don't think these have been caught by Coverity. The number in the brackets is, of course, the parameter affected. advapi/security.c:LookupPrivilegeNameW(3) dbghelp/stabs.c:stabs_pts_read_type_def(2) gdi/freetype.c:WineEngGetOutlineTextMetrics(3) msi/table:get_tablecolumns(3) setupapi/devinst.c:SetupDiGetDeviceInstanceIdW(3) Cheers, -- Andy.

1 0

Freeze in effect?
by Brian Fuller May 3, 2008

May 3, 2008

Gear = protein for all intents and purposes, as they stack, the cell grows. DNA limits the stacking capabilities All life starts from a cell (in atmosphere) mold first, water holds together around the planet to allow this only time permitting, but luckily mold cares just that much about the planet. You really don't think I can finish my project before June so maybe it can make it in 1.0?

1 1

Re: Wine release 0.9.61
by Brian Fuller May 3, 2008

May 3, 2008

Sockets on an application (on a TV attached) These sockets have an API. It allows the televisions to work in a group to produce a 2d wall that views 3d Milican/Thompson proved the electron exists I need this sizing to be emulated in code so to better analyze graphics in linux. (Increasing DLL timing interactions) If I could generate interrupts from windows using the sun architecture platform in an emulator to produce exception clouds that generated interrupts, and to be able to capture all this information in a memory dump, I could re-generate API. Now, once I get past that leap, I can open wine, and re-compile a C compiler that's built for windows, and put my own windows – for all intents and purposes call it a POSIX regulated OS, and run TF2 on it. Now my own windows supports TF2 well, except the fonts (I'm going to fix it real quick) On Fri, May 2, 2008 at 1:14 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > This is release 0.9.61 of Wine, a free implementation of Windows on Unix. > This release marks the beginning of the code freeze for the 1.0 release. > > What's new in this release (see below for details): > - Automatic updating of the WINEPREFIX directory. > - Winhelp now uses Richedit as display engine. > - Many RichEdit fixes. > - More improvements to IME support. > - More quartz fixes. > - Implementation for many more Gdiplus functions. > - Lots of bug fixes. > > Because of lags created by using mirrors, this message may reach you > before the release is available at the public sites. The sources will > be available from the following locations: > > http://ibiblio.org/pub/linux/system/emulators/wine/wine-0.9.61.tar.bz2 > http://prdownloads.sourceforge.net/wine/wine-0.9.61.tar.bz2 > > Binary packages for various distributions will be available from: > > http://www.winehq.org/site/download > > You will find documentation on > > http://www.winehq.org/site/documentation > > You can also get the current source directly from the git or CVS > repositories. Check respectively http://www.winehq.org/site/git or > http://www.winehq.org/site/cvs for details. > > If you fix something, please submit a patch; instructions on how to do > this can be found at http://www.winehq.org/site/sending_patches > > Wine is available thanks to the work of many people. See the file > AUTHORS in the distribution for the complete list. > > ---------------------------------------------------------------- > > Bugs fixed since 0.9.60: > > 3884 3DMark 2001 SE dies into debugger when trying to display about > screen > 4252 The Sting demo crashes > 5130 Faststone Image Viewer crashes on exit > 5159 Microphone xmit in Half Life and HL:S games very harsh and goes in > and out of "focus" > 6710 Mouse is invisible in Act of War : Direct Action > 7111 D3D & Via seems to don't work fine together... > 7157 MetaEditor Help Navigator Doesn't Work. > 7398 lockon crashes with null pointer dereference during loading > 7864 VobBlanker: Hangs when X-11 closes child window. > 7867 drmMap Failes -- Multiple Monitors: > 7881 JRE 1.3.1: RuntimeException in > sun.awt.Win32GraphicsDevice.getDefaultPixIDImpl(Native Method) > 8171 Strict Pasv response check should be modified. > 8300 Title bar shown in window style that does not have one > 8447 VobBlanker Crashes when openin some DVDs > 8520 combobox dropdown area should be customisable > 8720 Monopoly Tycoon demo crashes at startup > 8790 Sea Dogs: infinite loop on startup > 8960 lack of GLX causes wine to crash > 9039 GS-Auftrag Professional SQL aborts on startup > 9093 NexusTK crashes at start > 9115 unable to run setup for Office 2003 > 9257 Day of Defeat (a Half-Life 1 mod) - Mouse & Graphic > 9388 installer stuck for TRS 2006 Demo > 9959 Make wine updates work even if the registry changed > 10128 winecfg: not launching > 10198 IE's writing-mode:tb-rl (CJK-style vertical text layout) renders > fullwidth characters rotated when it should not > 10411 Synergy HL2 mod crashes in IHTMLWindow2_Release > 10676 Sega rally 2 crashes on start > 10984 sun jre 5 update 10 installer hangs in 0.9.52 > 11019 matlab r14 and r16 (7.0.4 and 7.3.0) and WriteItNow3.1.0s hang if > X in 24bpp mode > 11191 Chief Architect refuses to install > 11196 Adobe Acrobat Reader 3: Text of the Document is displayed as big > black boxes > 11402 Date selector not displayed in Lotus Notes 7.0.2 > 11647 mspaint: Multiple copy / paste operations will cause an exception > 11656 FarCry InstallShield wizard cannot be completed > 11741 ClocX installer has a z-order problem > 11806 regedit creates bogus hex:(1) value instead of empty "" > 11818 matlab r16 / 2006b / 7.3.0 hangs on startup with X in 16bpp mode > 11830 oRipa MSN Webcam Recorder crashes with page fault, backtrace in > user32 > 11875 Wine crashes and won't initialize any type of application > 11900 Unimplemented function msftedit.dll.DllGetVersion preventing > proper detection of richedit from Miranda IM History++ plugin > 12054 D3D9: Device test fails > 12127 Kai Power Tools filters z-order problem in Photoshop (7, CS2) > 12149 winedbg crashes loading a .pdb file > 12180 MSN Messenger 7.0 crash while configuring the Webcam > 12191 X11DRV_ChoosePixelFormat fails (Wing Commander: Secret Ops) > 12281 msxml3 test case fails > 12416 Deus Ex and Syberia2 both have corrupted graphics in 0.9.59 > 12420 wine 0.59 and kyodai > 12466 Chinese input method not working in DirectX game World of Warcraft > with wine 0.9.59 > 12478 Palringo: Pressing shift-enter in a chat window closes it > 12494 -lGLU flag not activated > 12555 Battlefield 1942 crashes when having joysticks attached > 12569 Window of PSPad is flashing, when new file is opened > 12575 Photoshop CS2 installer crashes in msi:ACTION_CallDllFunction > 12596 Picasa no longer starts maximized in KDE > 12610 Ctrl and Alt do not work in Guild Wars > 12621 Abilty to set virtual desktop on a per app basis > 12640 Applications written in Delphi has got minimize, maximize and size > controls disabled for its item in taskbar > 12644 GTA 3 Liberty City: texture corruption on cards with > GL_EXT_paletted_texture > 12656 EVE Online light effects and some other objects are not blended > correctly > 12657 Bad textures/shading in Dream Aquarium (white fishes) > 12666 Wine should refuse to run if pointed at a real Windows > 12695 when calling wineprefixcreate from wine launcher, WINEPREFIX is > ignored > 12707 some winemenubuilder processes never exit > 12712 OpenGL Application crashes with GLX error > 12727 non-fatal crash accompanies every program start > 12747 Trying to get Electric Quilt 6 working > 12761 net start spooler results in an infinite loop > 12763 Wineboot: Can't run wine cross test > 12765 Regression in ResHacker in wine-0.9.60 > 12769 control + enter sending the wrong key code > 12770 Build breaks > 12772 imm32: imm32.ok test fails > 12781 Dungeon Siege graphics problems since removing the pixel format > limitation > 12825 Xdrive Desktop Lite Crashes after login > 12837 Stack trace in socket.c when starting Call of Duty multiplayer > 12845 Mono 1.9.1 installer EULA is not rendered due to richedit > regression > 12855 opengl.ok test fails in PC-BSD but not Linux > 12860 magic the gathering online v3 doesn't run > 12898 EasyUO: disappears when reduced but still running > 12904 Thief The Dark Project crashes on game start > > ---------------------------------------------------------------- > > Changes since 0.9.60: > > Alam Arias (1): > include: Fix wingdi.h to define AW version of wglUseFontBitmaps and > wglUseFontOutlines. > > Alex Villacís Lasso (30): > riched20: Fix behavior of EM_REPLACESEL with painting disabled. > riched20: EM_SETTEXTEX supports RTF strings, with tests. > riched32: Add more todo tests for CR and LF behavior for richedit > 1.0. > riched32: Implement a portion of suggested interpretation of CRLF > handling for richedit 1.0 emulation. > richedit: EM_STREAMIN tests for richedit 1.0 emulation. > richedit: EM_STREAMIN tests for richedit 2.0. > richedit: Accept RTF stream that does not start with {\rtf1 in 1.0 > emulation. > uxtheme: Speed up UXTHEME_SizedBlt in the ST_TILE by building an > appropriately-sized memory bitmap out of the tile instead of iterating with > UXTHEME_Blt() directly. > uxtheme: Fix nasty regression with painting of themed progress bar. > uxtheme: Skip creation of temporary bitmap when painting a single > tile. > riched20: Yet more tests for EM_STREAMIN. > riched20: Implement ignoring of last \par for EM_STREAMIN. > riched20: Implement ignoring of last \par for EM_STREAMIN - 1.0 > emulation. > riched20: Reject RTF that is recognized as invalid. > richedit: Add support for encoding number of CR and LF contained > within a line break. > richedit: Fixups to move over to reliance on CR and LF counters. > richedit: Remove reliance on bEmulateVersion10 for end-of-line > handling in ME_InternalDeleteText. > richedit: EM_GETLINE: honor CR and LF counters. > richedit: EM_LINELENGTH: honor CR and LF counters. > richedit: Modify ME_GetTextW() to honor CR and LF encodings. > richedit: Remove indication for bCRLF, now that ME_GetTextW() knows > how to honor CR and LF counters. > richedit: Flip the big switch and encode actual CR and LF into > end-of-paragraph runs. > richedit: Implement rule that in 1.0 emulation, a single CR that > terminates the text is NOT a line break. > richedit: Only notify selection change when selection has actually > changed from previous notification. > richedit: Fix modify step setting in EM_SETCHARFORMAT. > richedit: WM_SETTEXT - Clear modify step flag before any > notifications can be sent. > richedit: Private movement of cursors in text insertion should not > cause WM_NOTIFY to be sent. > richedit: Paragraph may have multiple rows, which should possibly > update nHeight. > richedit: On failure to parse incoming text as RTF, EM_STREAMIN must > set dwError to -16. > richedit: Add tests for EM_FINDTEXT in 1.0 emulation, make them pass > under Wine. > > Alexander Dorofeyev (2): > wined3d: Add missing check for p8 primary in surface_download_data. > wined3d: Prevent console spamming in drawPrimitive. > > Alexander Morozov (1): > ntoskrnl.exe: Change calling conventions for Interlocked* functions. > > Alexander Nicolaysen Sørnes (2): > start: Update Norwegian Bokmål resource. > xcopy: Add Norwegian Bokmål resource. > > Alexandre Julliard (70): > gdi32: Return bitmask for 32-bit bitmaps too in GetDIBits. > user32: Remove redundant LocalUnlock calls. > ntdll: Automatically setup the dosdevices directory if it doesn't > exist. > wineboot: Add an option to update the prefix directory by > re-executing wine.inf. > wineboot: Automatically update the prefix directory if wine.inf > changes. > wineprefixcreate: Use wineboot --update to run wine.inf. > libwine: Allow to specify a non-existing directory as WINEPREFIX. > winecfg: Don't allow editing the configuration of the C drive. > user32: Dump more SetWindowPos flags. > user32: Invalide DCEs also when resizing a hidden window, or when > minimizing. > winex11: Use SetWindowPos to invalidate DCEs when changing the pixel > format. > winex11: Set type to dialog for owned popup windows. > winex11: Get rid of the unnecessary opengl debug channel. > winemenubuilder: Process messages while waiting for the semaphore or > the parent process. > winex11: Moved the ConfigureNotify handler to event.c. > msi: Avoid creating zero-length string values in the registry. > localspl: Avoid creating zero-length string values in the registry. > winex11: Moved the X11DRV_resize_desktop function to desktop.c. > winex11: Merged the contents of winpos.c into window.c. > winex11: Make sure that the window gravity is always set. > winex11: Don't allow changing the X11 size of a maximized window. > explorer: Convert the command line parsing to Unicode. > kernel32: If necessary reload the environment after wineboot has run. > user32: Make drivers non-const to avoid a compiler warning. > Make.rules: Move the all: target before the implicit rules to avoid > confusing FreeBSD make. > services.exe: Make the changed status event an auto-reset event. > services.exe: Don't reject config changes if the display name > corresponds to the service being changed. > wine.inf: Fix the service type of the spooler service. > explorer: Allow specifying a default size for each desktop using the > HKCU\Software\Wine\Explorer\Desktops registry key. > explorer: Retrieve the default desktop name from the startup > parameters or the registry. > user32: Allow the default desktop name to be specified on a per-app > basis. > makefiles: Add support for generating correct dependencies for tlb > files. > Add makedep magic comments for typelibs in resource files. > makedep: Don't try to open .tlb files. > oleaut32/tests: Store the test typelib in resources instead of > depending on an external file. > winex11: Don't force tool windows to unmanaged mode. > winecfg: Add a couple of Unicode helper functions. > winecfg: Allow to configure the desktop separately for each > application. > winex11: Check if IsXExtensionPointer is defined before using it. > shell32: Avoid traces that use size_t. > winex11: Merge the contents of clipping.c into graphics.c. > winex11: Don't put window manager decorations on shaped windows. > documentation: Remove PACKAGING, this is maintained on the wiki now. > winex11: Fix debug trace using the removed opengl channel. > ws2_32: Don't name a parameter errno. > ws2_32/tests: Fix the gethostname prototype. > gdiplus: Fix the GdipFillRectangles spec entries. > msvcrt: Rename a few functions to avoid conflicts with Windows > headers. > Include wine/port.h everywhere we use exceptions. > loader: Add stub versions of the pthread functions. > itss: Fix function prototype now that widl does the right thing with > const. > makefiles: List the static libraries as normal imports instead of > extra libs. > dxerr8: Don't use Wine debugging macros in static libraries. > dxerr9: Don't use Wine debugging macros in static libraries. > winex11: Register IME classes only when needed. > ntdll: Make the exception handling functions inline. > exception.h: Only push the exception frame after sigsetjmp. > exception.h: Preserve registers when calling RtlUnwind. > winex11: Avoid printing traces without a \n. > configure: Improve the check for the GLU library. > msftedit: Export a few more IIDs. > opengl32: Dynamically load libGLU. > make_makefiles: Avoid duplicate rules for static import libs on PE > builds. > winex11: Don't free the pixmap in X11DRV_DIB_CreateDIBFromPixmap > since we don't own it. > winex11: Ignore the specified owner if it's a zero-size window. > winex11: Only unmap a window when explicitly hidden, not just when > WS_VISIBLE is cleared. > user32: Add an exception handler around LB_GETTEXT to hide a Delphi > bug. > richedit: Avoid strlen in traces. > urlmon: Avoid sizeof in traces. > Updated the authors list. > > Alistair Leslie-Hughes (9): > msxml3: Implement get_namespaceURI. > msxml3: Add tests for get_prefix and get_namespaceURI. > msxml3: Implement get_prefix. > msxml3: Corrected IXMLDOMComment appendData with a broken > xmlTextConcat function. > msxml3: Corrected transformNode. > msxml3: Added IObjectWithSite support in IXMLDOMDocument2. > msxml3: Implement IDispatch for IXMLDOMNode. > msxml3: Implement IObjectSafety for IXMLDOMDocument2. > msxml3: Implement IXMLDOMComment insertData. > > Andrew Talbot (28): > kernel32: Remove unused variables. > mciseq: Remove unused variable. > mciavi32: Remove unused variables. > mcicda: Remove unused variable. > mciseq: Remove unused variable. > msi: Remove unused variables. > mshtml: Remove unused variable. > mpr: Remove unused variables. > msvfw32: Remove unused variable. > msvcrt: Remove unused variable. > oleaut32: Remove unused variables. > ntdll: Remove unused variables. > netapi32: Remove unused variable. > qcap: Remove unused variable. > riched20: Remove unused variables. > quartz: Remove unused variables. > rpcrt4: Remove unused variables. > shell32: Remove unused variables. > setupapi: Remove unused variables. > secur32: Remove unused variables. > comctl32: Dangling pointers fix. > shlwapi: Remove unused variables. > user32: Remove unused variables. > uxtheme: Remove unused variable. > wined3d: Remove unused variables. > advapi32: Use correct function pointer cast. > wineps.drv: Remove unused code. > winex11.drv: Remove unused variables. > > Aric Stewart (2): > comctl32: Fix an off-by-one error in toolbar TOOLBAR_SetHotItem. > hlink: Implement IExtensionServices. > > Austin English (4): > Spelling fixes. > Spelling fixes. > Spelling fixes. > shell32: Fix a typo. > > Bryan DeGrendel (1): > winex11: Rudimentary drawing support for display balloon tool tips in > systray. > > ByeongSik Jeon (25): > winecfg: Update Korean translation. > start: Update Korean translation. > reg: Add Korean translation. > net: Update Korean translation. > shdoclc: Update Korean translation. > imm32: Add stub and header of ImmRequestMessage. > imm32: Add stub and header of Imm{Create|Show|Destroy}SoftKeyboard. > user32: Pass the WM_IME_NOTIFY message to the default IME window. > imm32: Examine whether the fOpen value differs with its old value. > imm32: Pass the old conversion status value to the IME. > imm32: More implementation of the ImmGetConversionStatus(). > imm32: Reconstruct the ImmProcessKey, ImmTranslateMessage for the > VK_PROCESSKEY. > imm32: ImmGetVirtualKey return orignal virtual key value. > imm32: Fix a typo. > imm32: Add the updated ImmTranslateMessage declaration. > user32: Set the vkey value to VK_PROCESSKEY when IME process key. > imm32: Implementation of the Imm{Get|Set}CandidateWindow. > imm32: Implementation of the Imm{Get|Set}StatusWindowPos. > imm32: Updated implementation of the > Imm{Get|Set}CompositionFont{A|W}. > user32: Post the WM_KEY{DOWN|UP} message whenWM_IME_KEY{DOWN|UP} > message is generated by IME. > imm32: Updated implementation of the ImmEnumRegisterWord{A|W}. > imm32: Updated implementation of the ImmGetCandidateList{A|W}. > imm32: Updated implementation of the ImmGetCandidateListCount{A|W}. > imm32: Updated implementation of the ImmGetConversionList{A|W}. > imm32: Implementation of the ImmRequestMessage{A|W}. > > Dan Hipschman (3): > wininet: Remove custom content-length/type headers from redirects. > wininet: Don't forget the INTERNET_STATUS_REDIRECT callback in > HttpEndRequest. > gdi32: Add font faces to families in a specific order. > > Dan Kegel (2): > winecfg: Restrict dpi slider to sane values. > gdiplus: GdipLoadImageFromStream: initialize variable. > > David Adam (3): > wined3d: Fix a possible null dereference. > amstream: Fix the condition of existence of the IMediaStream > interface. > amstream: Register CLSID_AMDirectDrawStream. > > Dmitry Timoshkov (12): > winedump: Print contents of EMR_INTERSECTCLIPRECT and > EMR_EXTSELECTCLIPRGN. > gdi32: Add a test for ExtCreateRegion, make it pass under Wine. > gdi32: Add a test for EMR_EXTSELECTCLIPRGN, make it pass under Wine. > gdi32: Reselect objects into the DC only if scaling factors change. > fonts: Change encoding of tahomabd.sfd to unicode. > gdi32: Do not reselect objects while recording a metafile, that's > done at the playing time. > gdi32: Save/restore internal EMF playing state on > EMR_SAVEDC/EMR_RESTOREDC, add a test for this. > winecfg: Update Russian translation. > gdi32: Add SetPixel to the EMF DC functions. > gdi32: info->state.next is always NULL, there is no need to > save/restore it. > gdi32: Make the bitmap test pass under Windows 2000. > winecfg: Add a font size preview, update all language resources to > reflect this change. > > Dylan Smith (1): > richedit: Updated editor.h to reflect the contents of source files. > > Elias Benali (1): > winhelp: Check against a NULL pointer dereference. > > Eric Pouech (73): > winhelp: Add an (ugly) icon. > winhelp: Get rid of the WM_USER message. > winhelp: Moved all static data used when parsing HLP files into the > internal structures. > winhelp: Removed no longer needed field (wStringTableOffset) in > Globals. > winhelp: Fixed the parsing of a link containing both a .hlp file and > a window name. > winhelp: Always create a main window, even for popups. > winhelp: No longer store the WINHELP_WINDOW* inside the button box. > winhelp: Removed a couple of internal windows' handle and replaced > them with control IDs. > winhelp: Instead of loading all pages at once, allow to browse them > one by one. > winhelp: When no help file is passed on command line, we should open > then file pickup dialog. > winhelp: Silencing the copyright system record entry while parsing > help files. > winhelp: Get rid of the reuse concept for Windows and refactor the > code a bit for window creation / deletion. > winhelp: Added the notion of WINHELP_WNDPAGE and use it to move the > history to the global variables. > winhelp: Store the history in correct order. > winhelp: Present correctly the history when dealing with multiple > files. > winhelp: Properly handle the back button (in multiple windows, in > empty stack...). > winhelp: Fix window caption index in |SYSTEM. > winhelp: Fix the loading of a row in a table (especially, for > multiple paragraphs in a single cell). > winhelp: Properly display the page title. > winhelp: Don't add a page to the history when using the back button. > winhelp: Replaced an erroneous FIXME by a TRACE in > MACRO_DisableButton(). > winhelp: Fixed JumpId and JumpKeyword with correct signature and > implementation. > winhelp: Enable/Disable prev/next buttons if there's a prev/next > page. > winhelp: Simplified message box handling. > winhelp: Now use the icon out of hlpfile if any. > winhelp: Added ability to locate information within a page (and to > store it inside WNDPAGE). > winhelp: Also store the relative offsets of a page in the history and > back information sets. > winhelp: Simplify most of the helpers dealing with window creation. > winhelp: Store reference to the popup (if any) as a WINHELP_WINDOW > pointer. > winhelp: Popup's background color should be inherited from parent. > winhelp: Fix the link kind (and color) of the 0xEA-0xEF family. > winhelp: Be sure to raise a newly (re)created window in all cases. > winhelp: Added as an option, to use richedit to render the text > window. > winhelp: Start feeding the richedit control with relevant RTF stream. > winhelp: Add proper support for charset from headers and escaped non > ANSI characters in RTF stream. > winhelp: Added proper RTF conversion for non breakable space and > hyphen. > winhelp: Implement the first round of support for links in RichEdit. > winhelp: Correctly compute the popup size and manage the popup when > richedit is used. > winhelp: Create the shadow window also for popups handled by > RichEdit. > winhelp: Allow links inside popups to work properly. > winhelp: Setup a better font size for the richedit rendering. > winhelp: Added support for richedit tabs in paragraph format. > winhelp: Added support for paragraph information. > winhelp: Set the alignment of paragraph in richedit. > winhelp: Set the borders of a paragraph in richedit. > winhelp: Properly decode the keep bit in paragraph style. > winhelp: Emit proper RTF tokens for a bitmap. > winhelp: Emit the proper RTF stream for a metafile to RichEdit. > richedit: Properly handle the background in case of border in > paragraph. > richedit: Ensure wrapping is done all the time after inserting an RTF > stream. > wordpad: Open the filename passed on command line if any. > msvcrt: Fixed symbol unmangling for template-parameter-?? form, as > well as test. > msvcrt: undname: correctly handle multi-dimensional arrays. > msvcrt: Fixed space in type with double indirection. > winhelp: Make richedit the default for rendering. > winhelp: Generate the proper RTF data for a table formatting. > winhelp: Added support for transparent bitmaps. > msvcrt: Added __iob_func implementation. > janitorial: Prototype func() should be func(void). > winedump: Print more meaningful information about module list. > winedump: Added support for latest versions of Codeview (VC70). > winedbg: Try harder to locate a source file. > winedbg: Added implementation of qSupported request. > winedbg: Attach the source files to a given process, and unload them > at process end. > dbghelp: Prevent debug overflow of internal buffer while tracing. > dbghelp: Revert commit ae1791b0b8d181e0d01f8db1cae4eba48edefbac and > correctly fix what this patch was trying to do. > dbghelp: Some cleanup in dwarf include files. > winedbg: Added ability to print properly float/double values. > winhelp: Get rid of the old internal rendering. > winhelp: Remove the internal data used for the old rendering. > winhelp: We can now get rid of the tests about a NULL rtfData block. > winhelp: Added support for font scaling when using RichEdit. > winhelp: Added support for relative offsets in richedit rendered > pages. > > Erik de Castro Lopo (5): > include: Fix "warning: cast from pointer to integer of different > size". > user32/tests: Use SetWindowLongPtr instead of SetWindowLong. > crypt32: Use LOWORD on LPCSTR type instead of casting to int. > ntdll: Win64 fix for get_pointer_obfuscator. > dbghelp: Fix pointer cast. > > Frans Kool (2): > winecfg: Added missing Dutch translation. > start: Fixed Dutch translations. > > Gerald Pfeifer (1): > widl: Fix syntax to also work with older versions of bison. > > Guy Albertelli (4): > listview: Implement LVS_EX_GRIDLINES functionality. > listview: Implement 2 pixel decoration at top of report style with > grid lines. > listview: Correct return value from LVM_GETORIGIN including tests for > this. > usp10: Use passed hdc instead of cached one for ScriptTextOut with > test to check. > > Hans Leidekker (2): > usp10: Remove redundant code from ScriptTextOut. > usp10: Fix a few failing tests and make them pass on Wine. > > Herve Chanal (1): > winhelp: A nicer icon. > > Huw Davies (3): > user32: Fix bitmap_info_size to take into account bit field masks. > gdi32: Rename DIB_BitmapInfoSize to bitmap_info_size and fix to take > into account bit field masks. > winex11.drv: Rename X11DRV_DIB_BitmapInfoSize to bitmap_info_size and > fix to take into account bit field masks. > > Hwang YunSong(황윤성) (3): > reg: Updated Korean resource. > winhelp: Updated Korean resource. > start: Updated Korean resource. > > Jacek Caban (64): > mshtml: Parse and store onload attributes. > mshtml: Added load event support. > mshtml: Added IDispEx::GetDispID implementation. > mshtml: Added IDispatchEx::InvokeEx implementation. > mshtml: Added IDispatchEx::Invoke implementation. > mshtml: Added IDispatchEx::GetIDsOfNames implementation. > mshtml: Forward IOmNavigator's IDispatch method to IDispatchEx > implementation. > mshtml: Added window IDispatchEx implementation. > mshtml: Forward window IDispatch methods. > mshtml: Added navigator's IDispatchEx test. > mshtml: Added IHTMLWindow2::get_document implementation. > mshtml: Forward IHTMLWindow2::setTimeout to IHTMLWindow3::setTimeout. > mshtml: Added setTimeout implementation. > mshtml: Make IHTMLDocument2 iterface offset independent. > mshtml: Added HTMLDocument's IDispatchEx implementation. > mshtml: Forward IHTMLDocument2's IDispatch methods to IDispatchEx > implementation. > mshtml: Added IHTMLDocument3::getElementById implementation. > mshtml: Use heap_alloc_zero for allocating node objects. > mshtml.idl: Added DispHTMLUnknownElement declaration. > mshtml: Added elements IDispatchEx implementation. > urlmon: Ignore query and hash part in file protocol URL. > oleaut32: Properly clear VT_BSTR record. > oleaut32: Clear record in RecordDestroy. > oleaut32: Handle VT_R4 in RecordClear (spotted by Konrad Rzepecki). > mshtml: Fixed typo. > mshtml: Return S_OK in QueryContinue. > mshtml: Added more IDispatchEx tests. > mshtml: Return VT_NULL instead of empty string in getAttribute. > mshtml: Added IHTMLDOMNode2 stub implementation. > mshtml: Added IHTMLDOMNode2 to IDispatchEx support. > mshtml.idl: Added DispHTMLDOMText declaration. > mshtml.idl: Added IHTMLDOMTextNode declaration. > mshtml: Added get_firstChild implementation. > mshtml: Added IHTMLDOMTextNode stub implementation. > mshtml: Added IDispatchEx support to text node. > mshtml: Added get_nodeType implementation. > mshtml.idl: Added DispHTMLElementCollection declaration. > mshtml: Added IDispatchEx support to HTMLElementCollection object. > mshtml.idl: Added DispHTMLInputElement declaration. > mshtml: Added put_backgroundImage implementation. > mshtml: Added IHTMLInputElement::get_disabled implementation. > mshtml.idl: Added IHTMLDOMChildrenCollection and > DispDOMChildrenCollection declaration. > mshtml.idl: Added DispHTMLOptionElement declaration. > mshtml: Added IHTMLCommentElement declaration. > mshtml: Added support for custom DISPIDs. > mshtml: Added indexed access to HTMLElementCollection object support. > mshtml: Added IDispatchEx support to HTMLInputElement. > mshtml: Added IDispatchEx support to HTMLOptionElement. > mshtml.idl: Added DispHTMLImg implementation. > mshtml.idl: Added DispHTMLStyle declaration. > mshtml: Added get_childNodes implementation. > mshtml: Added IHTMLDOMChildrenCollection::get_length implementation. > mshtml: Added IHTMLDOMChildrenCollection::item implementation. > mshtml: Added IDispatchEx support to HTMLDOMChildrenCollection. > mshtml: Moved IDispatchEx initialization to HTMLElement_Init. > mshtml: Don't assume that nselem is valid in HTMLElement. > mshtml: Handle COMMENT_NODE like ELEMENT_NODE in element collection. > mshtml: Added IHTMLCommentElement stub implementation. > mshtml: Added comment and childNodes test. > mshtml.idl: Added DispHTMLCommentElement declaration. > mshtml: Added IDispatchEx support to HTMLCommentElement. > mshtml: Added IDispatchEx support to HTMLStyle. > mshtml: Added IHTMLImgElement stub implementation. > mshtml: Added IDispatchEx support to HTMLImgElement. > > James Hawkins (39): > advpack: Remove a test that fails inconsistently on several > platforms. > advapi32: Fix a test that fails on some versions of win2k. > advapi32: Remove a test that fails on some systems. > advpack: Fix a few failing tests in win95. > crypt32: Remove tests for properties not present on all systems. > inetcomm: Fix a test that fails on all systems. > kernel32: Skip the screen buffer tests if codepage 866 is not > available. > msi: Fix a few tests that fail in win9x. > advapi32: Fix a test that fails in win2k3. > kernel32: Fix a test that fails in win9x. > kernel32: Fix two tests that fail in win9x. > imm32: Fix a test that fails on all systems. > shdocvw: Fix a test that fails on all platforms. > version: Fix tests that fail in win9x and win2k. > kernel32: Fix a test that fails on win9x. > pdh: Fix two tests that fail on win2k3. > riched20: Fix a few tests that fail in XP and up. > shell32: Fix a test that fails in win2k3. > uxtheme: Fix a test that fails in win2k3. > advapi32: Fix a test that fails in win2k3 SP2. > d3d8: Fix a few test failures in win2k3. > gdi32: Remove a dependence on the amount of available memory. > winspool.drv: Disable a test for capabilities not available on all > printer drivers. > winmm: Remove a failing test that is driver-specific. > ddraw: Fix tests that fail with the reference rasterizer. > kernel32: Fix a test that fails in win2k3. > msi: Remove a debugging call. > cabinet: Revert "cabinet: Fix for FDICopy with an empty cabinet > file.". > d3d9: Fix a few test failures in win2k3. > ddraw: Remove a test that fails in VMs. > schannel: Fix a test that fails in win2k3. > user32: Fix a test that fails on platforms without IME. > msi: Add initial implementation of MsiPublishAssemblies. > gdi32: Remove a dependency on the amount of available memory. > user32: Fix a test that fails in win2k3. > urlmon: Fix a test that fails in win2k3. > ntdll: Fix two tests that fail on all NT platforms. > msi: A progid who is its own parent cannot have a clsid. > itss: Remove a test that we expect to fail sometimes. > > Jeff Latimer (1): > user32/tests: Fix typedefs & function definitions so that the code > compiles in visual C++ 2005. > > Jeff Zaroyko (3): > msadp32.acm: Use the same szShortName value as windows. > msacm32.drv: Increase the reported vDriverVersion. > wine.inf: Use lowercase for some drivers32 entries and remove > trailing whitespace. > > Jens Albretsen (1): > ddraw: Fixed device name. > > Jeremy White (1): > gdi32: Shift default height used in EnumStructs to the standard em > size of 2048. > > John Klehm (3): > winex11: Allow wintab devices with less than 5 axes. > winex11: Allow wizardpen to be detected as a stylus. > winex11: Add support for IsXExtensionPointer tablet devices. > > Joris Huizer (1): > mshtml: Fixed copy/paste mistake. > > Juan Lang (1): > cryptdlg: Implement GetFriendlyNameOfCertA/W. > > Kai Blin (3): > ws2_32: Work around the host name resolving to 127.x.x.x when using > that for binding. > ws2_32: Handle gethostbyname call failure, add tests. > secur32: Don't call waitpid() in dispatcher. > > Kirill K. Smirnov (3): > winhelp: We can reference any page in HLPFILE_BrowsePage(). Perform > similar change in HLPFILE_DoReadHlpFile() for the symmetry. > winhelp: Shift by 6 not 4 in case of old 3.0 file. > winhelp: Fix possible copy/paste error. > > Kusanagi Kouichi (8): > winex11.drv: Generate WM_IME_ENDCOMPOSITION when preedit ends. > winex11: Generate WM_IME_ENDCOMPOSITION when composition string is > canceled. > imm32: Fix a meaningless test. > winex11: Destroy the handle to the composition string after it is > cancelled. > imm32: Fix typos. > winex11: hCompStr should never be NULL because Wine expects it is not > NULL. > winex11: Remove unnecessary #include. > winex11: Allow XIM server to be started after Wine. > > Lei Zhang (13): > gdiplus: Initialize variables in the graphics test. > gdiplus: Do not access freed memory in a test. > user32: Add a test for sending WM_KEYDOWN to a child edit control. > user32: Handle VK_RETURN WM_KEYDOWN events better in edit controls. > winex11: control + enter should generate '\n' instead of '\r'. > user32: Edit controls should ignore WM_KEYDOWN on control + enter. > advapi32: Replace UuidToStringW call with a sprintfW. > winmm: Do not unload drivers when the process is terminating. > userenv: Add initial tests for CreateEnvironmentBlock. > userenv: Initial implementation of CreateEnvironmentBlock. > userenv: Add tests for environment variables for > CreateEnvironmentBlock. > userenv: Add more tests for environment variables for > CreateEnvironmentBlock. > userenv: Add a test for variable inheritance for > CreateEnvironmentBlock. > > Lionel Debroux (1): > dinput: joystick test: Improve reporting when enumerated > axes/buttons/POVs don't match capabilities. > > Maarten Lankhorst (41): > dsound: Skip the sound checks on the primary module and change its > driver module to "". > quartz: Make the video renderer drop preroll samples. > quartz: Fix theoretical memory leak. > quartz: Fix sample leak in file source on failure path. > quartz: Flux AsyncReader in PullPin_BeginFlush. > quartz: Make acmwrapper respect preroll samples. > quartz: Set media time in the file source. > quartz: No longer drop packets on discontinuities. > quartz: Drop preroll frames in directsound renderer too. > quartz: Only drop Preroll samples after obtaining its time. > quartz: Add more seek entries and fix a time continuity bug. > quartz: Change longlong printfs. > quartz: Add some more tests and fix wine to pass them. > explorer/mountmgr.sys: Move device hotplug code over to mount > manager. > quartz: Optimize the processing thread to fetch one sample while > processing another. > quartz: Fix error message names in tests. > quartz: Fix inverted logic in memallocator. > quartz: Copy discontinuity status in acmwrapper. > quartz: Add some sanity checks to file splitter. > quartz: Make wave parser and mpeg splitter zero copy by getting rid > of the seperate allocator for the output pin. > quartz: Make the file source support multiple samples by > preallocating enough handles. > dsound: Skip WAVE_FORMAT_EXTENSIBLE tests on directx < 8. > quartz: Add a vtable argument to Parser_Create that individual > filters can override. > quartz: NotifyAllocator does not like a null argument. > quartz: Fix time discontinuities in the acm wrapper. > quartz: Make the EnumPins interface dynamic. > quartz: Optimize the file source to do its job better. > quartz: Make dwSamplesProcessed a longlong. > quartz: Add a function that can be called when stopping processing > data. > quartz: Fix acmwrapper time regression. > quartz: Fix bug in memallocator with test. > quartz: Keep track of the time in the video renderer. > quartz: Handle failures better in acmwrapper. > quartz: Some state changes fixes. > Revert "quartz: Handle failures better in acmwrapper.". > quartz: More filesource fixes. > quartz: Clean up pullpin code. > quartz: Get rid of the sample holding code in the mpeg splitter. > quartz: Get rid of the sample holding code in the wave parser. > quartz: Silence a fixme that isn't. > headers: Add some extra defines to vfw.h. > > Markus Weiland (1): > dxdiagn: Implemented ullPhysicalMemory property for > DXDiagSystemInfoContainer. > > Mathias Gottschlag (2): > winecfg: Fix some errors in the German translation. > taskmgr: Fix some German translation errors. > > Matthias Derer (1): > winejack: Re-added line which has been accidently deleted. > > Michael Stefaniuc (4): > winecfg: Fix typos in the En(US) resource. > winecfg: Update and fix the Romanian translation. > start: Update the German translation. > winecfg: Transform the set_advanced() driveui function to unicode. > > Nikolay Sivov (34): > gdiplus: Implemented GdipVectorTransformMatrixPointsI. > gdiplus: Implemented GdipAddPathLine. > gdiplus: Implemented GdipDrawRectangle. > gdiplus: GdipCreateLineBrushI implemented using float args version. > gdiplus: Implemented GdipCloneFont. > gdiplus: Implemented GdipTransformMatrixPointsI. > gdiplus: Implemented GdipDrawPieI. > gdiplus: Implemented GdipDrawRectanglesI. > gdiplus: Implemented GdipDrawPolygon/GdipDrawPolygonI. > gdiplus: Implemented GdipFillPieI. > gdiplus: Implemented GdipGetLineRect/GdipGetLineRectI. > gdiplus: Implemented GdipGetLineColors. > gdiplus: Implemented GdipSetLineColors. > gdiplus: Implemented GdipAddPathBezier. > gdiplus: Implemented GdipDrawImageRect/GdipDrawImageRectI. > gdiplus: Implemented GdipAddPathBeziersI. > gdiplus: Implemented GdipAddPathEllipseI. > gdiplus: Implemented GdipCreatePathGradientI. > gdiplus: Implemented GdipCreateLineBrushFromRect. > gdiplus: Implemented GdipDrawCurve2I. > gdiplus: Implemented GdipDrawCurve/GdipDrawCurveI. > gdiplus: Implemented GdipDrawImage. > gdiplus: Implemented GdipDrawImagePointsRectI. > gdiplus: Implemented GdipFillEllipse/GdipFillEllipseI. > gdiplus: Implemented GdipFillRectangles/GdipFillRectanglesI. > gdiplus: Implemented GdipGetDpiX/GdipGetDpiY. > gdiplus: Implemented GdipGetPathGradientCenterPointI. > gdiplus: Implemented GdipGetPathPointsI. > gdiplus: Implemented GdipGetPathWorldBoundsI. > gdiplus: Implemented GdipIsMatrixEqual. > gdiplus: Implemented GdipIsMatrixIdentity. > gdiplus: Implemented GdipMultiplyWorldTransform. > gdiplus: Implemented GdipSetPathGradientCenterPointI. > gdiplus: Implemented GdipCreateFontFromDC. > > Paul Vriens (10): > tools/wine.inf.in: Fix a typo. > gdi32/tests: Run tests on win9x again. > oleaut32/tests: Skip a test on win9x. > user32/tests: Skip tests if function is not implemented. > kernel32/tests: Fix tests on win9x. > urlmon/tests: Fix timeout for tests on win9x. > user32/tests: Run tests again on win95. > winecfg: Better alignment of text and combobox. > kernel32/tests: Don't run tests on win9x if we are out of memory. > kernel32/tests: Skip some tests on win98. > > Petr Sumbera (1): > port: Add alternative for isinf. > > Reece Dunn (3): > shlwapi/tests: Fix the return codes for Windows 2000 (without IE6 > installed). > shlwapi/tests: Improve the way that the UrlCanonicalize tests report > failure. > shlwapi/tests: Add 'res:' protocol tests for UrlCanonicalize. > > Rico Schüller (1): > msftedit: Add DllGetVersion. > > Rob Shearman (54): > widl: Stop looping in check_remoting_args when a context_handle or > wire_marshal type is found as they are in effect fundamental types. > widl: Check that fields in structures and unions referenced by > non-local functions can be marshalled and that their attributes are > consistent. > widl: The implicit_handle attribute is allowed with a handle > explicitly specified in the function parameters. > widl: Automatically add "handle_t IDL_handle" parameter to functions > with no explicit handle specified whose containing interface has the > explicit_handle attribute. > widl: Issue an error instead of crashing for dividing by zero in a > constant expression. > widl: Add support for "->" and "." operators in expressions. > widl: Add support for arrays in expressions. > widl: Add support for '%' operator in expressions. > widl: Fix operator precedence in expressions. > widl: Require a constant expression for case statements. > widl: Add support for comparison, exclusive or, logical not and > positive operators in expressions. > widl: Remove EXPR_MEMBERPTR and implement it using EXPR_PPTR and > EXPR_MEMBER instead. > widl: Don't free input_name in pop_import as we keep pointers to it > in the var_t type now. > widl: Pass the actual type into check_remoting_fields and > check_field_common instead of the type name. > widl: Check that expressions resolve so that expressions in generated > code will compile. > widl: Move expression functions to a new file, expr.c. > widl: Use expr_resolve_type to get the type of the identifier in > write_conf_or_var_desc. > widl: Remove duplicated code in the form of the write_struct_expr > function by enhancing write_expr to allow toplevel identifiers to be > prefixed by a string, if specified. > crypt32: Decode the message content on finishing in CDecodeMsg_Update > for the streamed case as well as the non-streamed case. > wintrust: Implement WTHelperGetProvPrivateDataFromChain. > wintrust: Check that provider functions are not NULL before using > them. > widl: Implement lcid property on library declarations. > widl: Construct the pointer chain while parsing pointers, rather than > storing a ptr_level. > widl: Allow NULL to be used in expressions. > widl: Create a list of statements in the whole IDL file, instead of > just a list of interfaces. > widl: Add typedef statements to the statement lists. > widl: Consolidate most of the inner loop of reg_typedefs into > set_type. > widl: Rename pident to declarator and parse the array declarations as > part of declarators. > widl: Make the rules for parsing fields in structures, encapsulated > unions and non-encapsulated unions more strict. > widl: Add support for declaring multiple fields of a structure in one > statement. > widl: Add support for string literals and wide-string literals in > expressions. > widl: Create a statement object for import statements. > widl: Move the func_declarator rule entirely into direct_declarator. > rpcrt4: Use safe_copy_from_buffer instead of direct memory copy in > NdrBaseTypeUnmarshall. > widl: Add typedefs to typelibs which have the public or uuid > attributes, not any other attribute. > widl: Support hex digits that use an uppercase 0X prefix. > widl: Accept integer constant suffixes in the lexer. > ole32: Fix two comments about the running object table. > ole32: Add tests for registering a moniker more than once in the ROT > and then using it. > ole32: Add a test for marshaling an object as table-weak and as > normal and then unmarshaling and testing that the object is released on the > final release. > ole32: Keep track of the number of weak references to an object. > rpcss: When registering a moniker that is already registered in the > ROT another ROT entry should still be created and a distinct cookie > returned. > widl: Keep const attributes applied to pointers when writing out the > type. > widl: Add support for "inline" on function definitions. > widl: Make constdef and externdef take a declarator instead of an > ident so that functions and arrays can be defined using the statements. > widl: Allow pointer attributes to be applied to function pointers. > widl: callback, code, comm_status and in_line are attribute names, > not keywords. > widl: Prepare for supporting storage classes in declaration > statements. > widl: Add the parsing of storage classes into declaration-specifiers. > cryptdlg: Add stubs for CertTrustInit, CertTrustCertPolicy, > CertTrustCleanup and CertTrustFinalPolicy. > wininet: Don't crash in GetUrlCacheEntryInfoA/W if > lpdwCacheEntryInfoBufferSize is NULL. > wininet: Add tests for GetUrlCacheEntryInfoExA. > advapi32: Make sure not to return a credential with a NULL UserName > field when a Mac Keychain doesn't have an account name attribute. > widl: Consolidate writing of COM and dispatch interfaces into one > function to remove duplicated code. > > Robert Reif (1): > winmm: Fix a test failure on Windows with Terminal Server. > > Roderick Colenbrander (16): > wined3d: Add palette re-upload support for cards with hardware > palette support. > wgl: Put the core functionality of X11DRV_SetPixelFormat in a > separate function. > wgl: Add a wine specific WGL extension which allows you to change the > pixel format multiple times. > wined3d: Split WGL pixel format selection code off from > CreateContext. > wined3d: Store more information about pixel formats. This is needed > for some WineD3D_ChoosePixelFormat restructuring. > wined3d: Let WineD3D_ChoosePixelFormat operate on the pixel format > database we store at WineD3D startup. > wined3d: Also use WineD3D_ChoosePixelFormat for pbuffers. > wined3d: Fix a few small bugs in WineD3D_ChoosePixelFormat. > wined3d: Add multisampling support. > wgl: We were already advertising GL_EXT_framebuffer_sRGB but not the > corresponding WGL_FRAMEBUFFER_SRGB_CAPABLE_EXT. > opengl32: Drop the ChoosePixelFormat test as it is very unreliable. > opengl32: Get rid of X/GLX leftovers. > wined3d: Fix typo in pixel format trace. > wined3d: In window mode (!pbuffer) we want both a window drawable > format and double buffering. > wined3d: We don't want double buffering in pbuffer mode. > ddraw: Enable EnableAutoDepthStencil to receive depth support. > > Stefan Dösinger (11): > wined3d: Use the shader backend to enable / disable atifs and nvts. > wined3d: Support framebuffer reading from texture_rectangle sources. > d3d9: Add a test for NP2 stretchrect. > wined3d: Call activate_dimensions from the atifs code. > d3d9: Make the offscreen format test a bit more tolerant. > wined3d: More fglrx spam. > wined3d: Fix the GL_ATI_separate_stencil codepath. > wined3d: Fix DP2ADD in GLSL. > d3d9: Check textures for srgb writing, not surfaces. > d3d9: Dump the device information in the visual tests. > wined3d: Remove an unused variable. > > Stefan Leichter (1): > shell32: Implement SHGetFolderPathAndSubDirA/W. > > Steven Edwards (1): > rpcrt4: Correct the number of aguments for fill_method on unsupported > architectures. > > Tijl Coosemans (2): > hhctrl.ocx: Plug memory leak. > hhctrl: Fix NULL pointer dereference in some failure cases. > > Tomasz Jezierski (1): > shell32: Secure filename copy to fixed size variable wfileName. > > Tomasz Nowiński (1): > Fixed typos in the Polish translations. > > Vitaliy Margolen (9): > shdoclc: Add Russian translation. > Update Russian translation. > dinput: Limit number of supported axis and buttons. > dinput: Explicitly set extended key flag for Right Shift. > winex11: Fix GetKeyNameText for Right Shift. > winex11: Use constants instead of magic numbers in GetKeyNameText. > winex11: Fix MapVirtualKeyEx to properly map left-right modifier > keys. > dinput: Fix default axes mapping generation. > dinput: Fix typo. > > Vitaly Perov (2): > cabinet: Added a test for FDICopy with an empty cabinet file. > cabinet: Fix for FDICopy with an empty cabinet file. > > -- > Alexandre Julliard > julliard(a)winehq.org > >

1 0

Wine 1.0 code freeze! RC1 in 6 days!
by Dan Kegel May 2, 2008

May 2, 2008

Bet you never thought it would happen! The code freeze will be less rigid at first, but we're serious about not destabilizing Wine at this point. So go ahead and post your patches, but make sure you've got your ducks in a row, and don't be surprised if Alexandre pushes back. A clickable version of the following info is at http://kegel.com/wine/countdown.html Wine Release Countdown Wine 1.0 now in code freeze. 6 days to first release candidate. See WineReleasePlan for details. wine-0.9.61 was released on Friday, May 2nd, 2008. Wine is now in a code freeze in preparation for the 1.0 release. According to http://wiki.winehq.org/WineReleasePlan, wine-1.0.0-rc1, due out Friday, May 9, 2008, will be the first release candidate for 1.0. During the code freeze, patches that * are simple * come with a conformance test * fix a regression * are low risk are more likely to get in than other patches. (Heck, that's always true, but it's even truer during a freeze.) We will actively discourage patches that might endanger a June 1.0 release. Bug Status There are 45 open 1.0 bugs as of 2 May. Most of these will simply be rolled over to be fixed for a later release; we only have time to fix a few, and much as we'd like to fix the rest, most are not showstoppers. Changes since last week (with category and votes): New (!): 10288 programs 0 wine_gecko download hangs sometimes 11584 directx- 0 Multiple games crash with stack overflow error 12263 opengl 2 Sketchup Cannot initialize OpenGL - ChoosePixelFormat fails 12730 gdi32 1 gdi32: some tests fail when X is run in 16 bit mode, but not 32 bit 12914 tools 1 wineprefixcreate overrides custom entries in Explorer\\Shell Folders Fixed: 9039 kernel32 0 GS-Auftrag Professional SQL aborts on startup 9959 -unknown 9 Make wine updates work even if the registry changed 10984 winex11. 6 sun jre 5 update 10 installer hangs in 0.9.52 11019 winex11. 4 matlab r14 and r16 (7.0.4 and 7.3.0) and WriteItNow3.1.0s hang if X in 24bpp mode 12666 -unknown 0 Wine should refuse to run if pointed at a real Windows Deferred: 556 build-en 1 Reconcile the Windows and Wine spec files 1114 comctl32 3 Winrar2.90/3.00: Comboex doesn't trigger a event when you mouse-click in some value of it 1990 winex11. 1 modifier keys not released when switching desktop 3297 winex11. 13 UpdateWindow() doesn't call XFlush() 3546 shdocvw 2 CLSID_InternetShortcut not available... 4372 comctl32 1 listview: cannot drag several items 5055 -unknown 5 Deleting files from a window in wine doesn't send them to the Trash 5351 kernel32 11 Windows Installer 3.1 cannot install because of non-standard drive labeling 5623 winex11. 4 GetAsyncKeyState wrong if querying process doesn't have focus 5625 wininet 4 Wine does not handle internet proxy settings conveniently 5828 winex11. 25 Command and Conquer Generals (Zero Hour) doesn't change the mouse cursor from the default X mouse 7098 mscoree 1 RufzXP crashes on startup, needs mscoree.dll.CorBindToRuntimeEx 8095 ole 0 PQ Teaching toy crashes 9030 directx- 0 army men hangs on black screen 9304 shdocvw 4 Temple of Elemental Evil demo doesn't start - gui irresponsive 10815 -unknown 5 Cannot drag images into Adobe Photoshop 7 from the web / desktop 10905 shell32 0 thinstall firefox demo requires native msvcrt 11681 directx- 17 Add support for video overlay Here's the full list of current bugs: 11420 advapi32 0 service control manager API problem: name of named objects might differ (client vs. service process) 2493 comctl32 2 Multi-select listview: Shift-arrow up only selects top two items 11509 crypt32 0 Wordviewer 2003 is unable to open documents encrypted with AES 5535 directx- 18 Planescape:Torment doesn't work 11584 directx- 0 Multiple games crash with stack overflow error 3270 gdi32 16 Problem with minimized top-level windows 6519 gdi32 7 Wine blacks out rotated font bitmap 7571 gdi32 1 Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5) 9771 gdi32 45 Steam Friends doesn't work (fails to render correctly or refresh) 12730 gdi32 1 gdi32: some tests fail when X is run in 16 bit mode, but not 32 bit 5024 kernel32 5 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 10147 msi 2 Word Viewer 2003 - Tab behavior differs from Windows 8783 ntdll 14 USB serial ports do not work 9356 ntdll 11 Serial communication not working since wine-0.9.33 9942 ole 3 Powerpoint Viewer 2007 crashes opening .pptx files 12263 opengl 2 Sketchup Cannot initialize OpenGL - ChoosePixelFormat fails 5926 programs 1 Wine does not provide an implementation of winhlp32.exe 10288 programs 0 wine_gecko download hangs sometimes 5163 setupapi 14 Office XP 2002 crashes on installation 6095 shdocvw 16 MOTD in counter-strike 1.6 and counter-strike source does not render 8898 shdocvw 1 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 8439 shell32 9 Visual Studio .NET (7) install fails 11742 shlwapi 9 Small .net 1.1 app (FastMD5 1.3) fails to start up 12074 testcase 2 The conformance tests fail on Windows 6604 tools 3 Ship icons for the wine-tools that can be used in .desktop files 12914 tools 1 wineprefixcreate overrides custom entries in Explorer\\Shell Folders 5061 -unknown 6 Copying from Windows Firefox in Wine and pasting to Linux OpenOffice pastes metadata as data 5402 -unknown 0 Trying to run PhotoStitch 3.1 5844 -unknown 13 tray minimize 5948 -unknown 2 Star Trek: Armada does not install 7404 -unknown 3 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 8125 -unknown 0 Marratech 6.1 crashes on start 9178 -unknown 8 "hello world" dos program hangs 9916 -unknown 6 "make test" usually fails 11281 -unknown 4 CJK input many issues 12097 -unknown 3 Wine 1.0 should not ship out-of-sync resource translations 12246 -unknown 2 "make test" gives different results with and without warn+heap 664 user32 7 The help menu functionality inside programs is broken (messaging problem) 3023 user32 6 Orcad - "Place Part" never tries to put down a part 4523 user32 5 Can't copy from Firefox 1.5 and paste into OpenOffice 2 under Wine 124 wineserv 2 Review of Wine Server Protocol 2368 winex11. 7 Wine loses its X-Window when switching to another virt. desktop in Fvwm 7372 winex11. 14 can't copy and paste between gnome apps eg openoffice or gimp and wine apps such as dreamweaver or adobe photoshop 9787 winsock 52 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 12005 wintab32 1 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

1 0

kernel32: Implementation of GetLargestConsoleWindowSize.
by Reijo T Sund May 2, 2008

May 2, 2008

Eric Pouech (Fri May 2 01:38:37 CDT 2008): > first of all, implementing twice the same function is a bad idea > you should wrap the two implementations into a single function, and have > simple wrappers for handling the different return convention > in the other items: > - you never handle errors in return from server calls > - where do the 2 (resp 3) factors come from ? Kirill K. Smirnov (Fri May 2 04:47:48 CDT 2008): > Fortunately, since you do not check error codes (as Eric pointed out), > all variables get initialized to somehow sane values and this does not fail > for curses. Thank you very much for your comments. I have now revised the patch to have a single helper function and similar simple wrappers as there were with the fixed constants. I also added the error handling for the server calls, and initialized all variables to have sensible values even if the server calls fail, so that the code should not fail for curses. The factors 2 and 3 come from the fact that the client area is smaller than the desktop area, and in addition to window frames also the scrollbars and desktopbar should be taken into account. Please check out the test code attached to bug report 10919: http://bugs.winehq.org/show_bug.cgi?id=10919 I'll send the corrected version of the patch to the patches-list. Reijo

1 0

Problem with VoIP applications
by Pavel Troller May 2, 2008

May 2, 2008

Hi! I was trying to run FreeCall VoIP client, however, it detects a problem and tries to contact its authors. I've done a bit of googling and I've found that there are at least 3 similar programs (FreeCall, VoipCheap, VoipDiscount) which behave exactly the same way, they are using probably the same client. Also AppDb lists at least one of them, with identical symptoms. There is the following report generated by wine: patrol(a)arcus:~/.wine/drive_c/Program Files/FreeCall.com/FreeCall$ wine FreeCall.exe preloader: Warning: failed to reserve range 00000000-00010000 preloader: Warning: failed to reserve range 00000000-00010000 preloader: Warning: failed to reserve range 00000000-00010000 preloader: Warning: failed to reserve range 00000000-00010000 err:alsa:ALSA_CheckSetVolume Could not find 'PCM Playback Volume' element err:alsa:ALSA_CheckSetVolume Could not find 'PCM Playback Volume' element preloader: Warning: failed to reserve range 00000000-00010000 err:ole:CoInitializeEx Attempt to change threading model of this apartment from apartment threaded to multi-threaded err:ole:CoGetClassObject class {bcde0395-e52f-467c-8e3d-c4579291692e} not registered err:ole:CoGetClassObject class {bcde0395-e52f-467c-8e3d-c4579291692e} not registered err:ole:create_server class {bcde0395-e52f-467c-8e3d-c4579291692e} not registered fixme:ole:CoGetClassObject CLSCTX_REMOTE_SERVER not supported err:ole:CoGetClassObject no class object {bcde0395-e52f-467c-8e3d-c4579291692e} could be created for context 0x17 err:ole:CoInitializeEx Attempt to change threading model of this apartment from apartment threaded to multi-threaded err:ole:CoGetClassObject class {bcde0395-e52f-467c-8e3d-c4579291692e} not registered err:ole:CoGetClassObject class {bcde0395-e52f-467c-8e3d-c4579291692e} not registered err:ole:create_server class {bcde0395-e52f-467c-8e3d-c4579291692e} not registered fixme:ole:CoGetClassObject CLSCTX_REMOTE_SERVER not supported err:ole:CoGetClassObject no class object {bcde0395-e52f-467c-8e3d-c4579291692e} could be created for context 0x17 The preloader warnings are harmless in this case. I think the ole errors are the real cause. I don't need to use the program for calling, just to make a registration to FreeCall - they offer also the web-based registration, but then they don't allow to pay with PayPal - "for better security" :-(. Any chance the program could be started at least to allow the registration ? With regards, Pavel Troller

2 1

Re: DDraw: enable EnableAutoDepthStencil to receive depth support
by Stefan Dösinger May 2, 2008

May 2, 2008

Actually, setting AutoDepthStencil to TRUE is technically wrong, but I am afraid the only option. DDraw doesn't create a depth stencil surface automatically. The app has to create it manually, then attach it to the primary. When the app creates the depth stencil, ddraw creates a wined3d depth stencil. When the app attaches the depth stencil, ddraw calls SetDepthStencilSurface. So the bug is in WineD3D, not ddraw. We would have to fetch a depth stencil buffer from somewhere on SetDepthStencilSurface. In the very same way, a d3d9 application could set autodepthstencil = FALSE and create the depth stencil on its own. Since we cannot attach a depth stencil surface in the d3d9 way without rendering to an FBO(if they are available at all), we have a problem. One option would be to always create an opengl depth stencil capable format, which would undo some of the gains from the pixel format support. Another option is this patch - we didn't have a manual d3d9 depth stencil creation yet. A third option is to change the opengl pixelformat in SetDepthStencilSurface(upwards only, UNKNOWN -> D16 -> D24X8 -> D24S8).

1 0

Re: widl: Add a framework for automated testing of IDL files that should succeed or fail to be parsed.
by Dan Hipschman May 2, 2008

May 2, 2008

On Mon, Apr 28, 2008 at 08:37:26PM +0100, Robert Shearman wrote: > > This should aid in testing more-obscure parts of the parser that aren't > necessarily valid when using RPC (and hence don't make sense being put > in dlls/rpcrt4/tests/server.idl). Obviously this is a good idea. I tried doing something similar a while ago, but it didn't get accepted on the first try and I never asked why, so I'll ask why now. See here: http://winehq.org/pipermail/wine-patches/2006-September/030438.html It has some benefits over the approach you're proposing so it's worth bringing up. One is that it can run the tests against MIDL, so we know the tests themselves are correct (ok, MIDL has been known to do things differently than the spec, but we may want to copy MIDL's behaviour anyway, and in any case it's easier to automatically validate the tests on MIDL than to do so by hand or by inspection). Another is versatility in what it can test. Since the tests are shell scripts, not only can it test the success/failure of a parse, but it can check that all the correct files were created, and it can perform further tests on the output (e.g., if we have an import in the IDL file, we can grep the output to make sure a #include was generated for the import). It already supports "todo"s, and the test scripts look similar to the usual Wine tests written in C. On the other hand your method has some advantages over mine. You already provide a "make test" framework, and including the expected result of the compilation in the IDL file is cleaner. Alexandre may very well disagree with what I see as valid points (like testing on MIDL), but these are my suggestions anyway. Hope they're useful.

3 3

kernel32: Implementation of GetLargestConsoleWindowSize.
by Kirill K. Smirnov May 2, 2008

May 2, 2008

Hi, + + hWnd = GetConsoleWindow(); + + SERVER_START_REQ( get_window_rectangles ) + { + req->handle = hWnd; + ret = !wine_server_call_err(req); + colpix = reply->client.right - reply->client.left; + linpix = reply->client.bottom - reply->client.top; + colext = (reply->window.right - reply->window.left) - colpix; + linext = (reply->window.bottom - reply->window.top) - linpix; + } + SERVER_END_REQ; This piece of code does not checks for curses backend. Yes, right now it is broken in mainstream, but 1) it may resurrected some day 2) bug #8069 contains quick hack to make it working. Fortunately, since you do not check error codes (as Eric pointed out), all variables get initialized to somehow sane values and this does not fail for curses. -- Kirill

1 0

Re: [PATCH] user32: only send WM_SIZE if the window size actually changed.
by Alexandre Julliard May 2, 2008

May 2, 2008

"Lei Zhang" <thestig(a)google.com> writes: > We shouldn't send WM_SIZE in response to WM_WINDOWPOSCHANGED unless > the window size actually changed. The client size can change even if the window size doesn't. What are you trying to fix? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/5] kernel32: implement __wine_kernel_init_environment.
by Alexandre Julliard May 2, 2008

May 2, 2008

"Lei Zhang" <thestig(a)google.com> writes: > This makes several internal kernel32 process functions more flexible > in order to accommodate __wine_kernel_init_environment. > __wine_kernel_init_environment is needed for CreateEnvironmentBlock. It's not appropriate to export that from kernel32; userenv should use only standard APIs. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: kernel32: Implementation of GetLargestConsoleWindowSize.
by Eric Pouech May 2, 2008

May 2, 2008

Reijo T Sund a écrit : > >From e59f5ec4eaf6936b7ecb6e4d0a471d38622f22aa Mon Sep 17 00:00:00 2001 > From: Reijo Sund <reijo.sund(a)helsinki.fi> > Date: Thu, 1 May 2008 10:20:19 +0300 > Subject: kernel32: Implementation of GetLargestConsoleWindowSize. > > The function should return the largest size instead of hard coded > constants. A fix for the bug 10919. > first of all, implementing twice the same function is a bad idea you should wrap the two implementations into a single function, and have simple wrappers for handling the different return convention in the other items: - you never handle errors in return from server calls - where do the 2 (resp 3) factors come from ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: hhctrl.ocx: Fix for memory release problem in ReleaseWebBrowser (fixes bug #12767)
by Tefnet Developers May 1, 2008

May 1, 2008

Dnia 24-04-2008, czw o godzinie 12:48 +0200, Tomasz Jezierski - Tefnet pisze: > For more information check bug report. > Hi.. what's the status of this patch? I haven't found any comments on wine-devel about it.

2 1

Re: shlwapi: expose the IStream_Read and IStream_Write functions.
by Robert Shearman May 1, 2008

May 1, 2008

Reece Dunn wrote: > @@ -926,6 +926,13 @@ HRESULT WINAPI SHCreateStreamOnFileEx(LPCWSTR,DWORD,DWORD,BOOL,struct IStream*,s > > HRESULT WINAPI SHCreateStreamWrapper(LPBYTE,DWORD,DWORD,struct IStream**); > > +#undef IStream_Read > +#undef IStream_Write > + > +HRESULT WINAPI IStream_Read(struct IStream *, LPVOID, ULONG); > + > +HRESULT WINAPI IStream_Write(struct IStream *, LPCVOID, ULONG); > + > #endif /* NO_SHLWAPI_STREAM */ > > /* SHAutoComplete flags */ > You've put this in the section guarded by NO_SHLWAPI_STREAM, but in the PSDK header it isn't guarded by this define. If it were the case, then you could have fixed the issue in files that include shlwapi.h by defining this before including it. However, I think having to work around not being able to use the IStream_Read and IStream_Write macros is a bit ugly. -- Rob Shearman

2 1

Re: winex11.drv: Avoid setting DIALOG type to windows, this imposes not expected limitations in functionality
by Alexandre Julliard May 1, 2008

May 1, 2008

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > Metacity explicitly disables maximize, minimize and fullscreen capabilities > for windows of type _NET_WM_WINDOW_TYPE_DIALOG. Since Windows applications > don't expect such a restriction (dialogs can have maximize/minimize buttons > under Windows) it's better to avoid setting DIALOG type to windows at all. This will break z-order management, Metacity ignores the transient for hint on TYPE_NORMAL windows. Maybe we should try to not set the type at all? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: usp10: Fix a few tests that fail in win2k3
by Hans Leidekker May 1, 2008

May 1, 2008

On Thursday 01 May 2008 08:30:40 James Hawkins wrote: > + /* get new psc */ > + hr = ScriptPlace(hdc, &psc, pwOutGlyphs1, pcGlyphs, psva, &pItem[0].a, piAdvance, > + pGoffset, pABC); > + ok (hr == 0, "Should return 0 not (%08x)\n", hr); > + ok (psc != NULL, "psc should not be NULL\n"); > /* Set that is gets a psc and that returns 0 status */ > hr = ScriptTextOut(hdc, &psc, 0, 0, 0, NULL, &pItem[0].a, NULL, 0, pwOutGlyphs1, pcGlyphs, > piAdvance, NULL, pGoffset); test.winehq.org shows that this ScriptTextOut test fails on all versions of Windows and succeeds on Wine, so a better fix would be to reverse the check for psc and make Wine pass the test. The fix depends on Guy Albertelli's recent fix for ScriptTextOut, I'll send a patch after that one has been committed. -Hans

1 0

RFC: detecting wine drivers in the audio tests
by Robert Reif May 1, 2008

May 1, 2008

The returned result of some audio functions on windows may be inconsistent because a driver may actually supply the returned value. This presents a problem for the wine regression tests because a buggy driver may return an unexpected result which causes the test to fail. One way around this is to accept known failures as OK but that reduces the usefulness of the test for wine because it may allow wine bugs to slip in. I'm proposing the we determine if we are running on wine by defining a wine manufactures id and checking for that id in the test. If a wine driver is found, don't accept a failure as OK. The returned result should be well defined and any failure is unacceptable. However, if the driver is not a wine driver and there are known buggy windows drivers that return specific errors, we can check for that and not fail the test. This should be easier than maintaining a database of known broken drivers and black listing them. I am concerned that requiring 100% wine regression test success on windows is not practical when there are broken windows drivers out there. Accepting the failures as success is not good for wine because it may allow buggy wine drivers to also pass. I think we should hold wine audio drivers to higher standards than the typical audio card manufacture. I am suppling a minimal patch to the alsa driver and a single wave test to illustrate this concept. I hope this allows valid tests to remain in spite of buggy windows drivers. diff --git a/dlls/winealsa.drv/alsa.h b/dlls/winealsa.drv/alsa.h index 4cd2cf5..8433c12 100644 --- a/dlls/winealsa.drv/alsa.h +++ b/dlls/winealsa.drv/alsa.h @@ -51,6 +51,8 @@ #include "ks.h" #include "ksmedia.h" #include "ksguid.h" +#define MM_WINE_ALSA_VERSION 0x0100 // driver version + /* state diagram for waveOut writing: * * +---------+-------------+---------------+---------------------------------+ diff --git a/dlls/winealsa.drv/midi.c b/dlls/winealsa.drv/midi.c index 3e791d5..8ac0363 100644 --- a/dlls/winealsa.drv/midi.c +++ b/dlls/winealsa.drv/midi.c @@ -1134,10 +1134,10 @@ static void ALSA_AddMidiPort(snd_seq_cli * Does not seem to be a problem, because in mmsystem.h only * Microsoft's ID is listed. */ - MidiOutDev[MODM_NumDevs].caps.wMid = 0x00FF; - MidiOutDev[MODM_NumDevs].caps.wPid = 0x0001; /* FIXME Product ID */ - /* Product Version. We simply say "1" */ - MidiOutDev[MODM_NumDevs].caps.vDriverVersion = 0x001; + MidiOutDev[MODM_NumDevs].caps.wMid = MM_WINE; + MidiOutDev[MODM_NumDevs].caps.wPid = MM_WINE_ALSA; /* Product ID */ + /* Product Version. */ + MidiOutDev[MODM_NumDevs].caps.vDriverVersion = MM_WINE_ALSA_VERSION; MidiOutDev[MODM_NumDevs].caps.wChannelMask = 0xFFFF; /* FIXME Do we have this information? @@ -1190,10 +1190,10 @@ static void ALSA_AddMidiPort(snd_seq_cli * Does not seem to be a problem, because in mmsystem.h only * Microsoft's ID is listed. */ - MidiInDev[MIDM_NumDevs].caps.wMid = 0x00FF; - MidiInDev[MIDM_NumDevs].caps.wPid = 0x0001; /* FIXME Product ID */ - /* Product Version. We simply say "1" */ - MidiInDev[MIDM_NumDevs].caps.vDriverVersion = 0x001; + MidiInDev[MIDM_NumDevs].caps.wMid = MM_WINE; + MidiInDev[MIDM_NumDevs].caps.wPid = MM_WINE_ALSA; /* Product ID */ + /* Product Version. */ + MidiInDev[MIDM_NumDevs].caps.vDriverVersion = MM_WINE_ALSA_VERSION; /* FIXME Do we have this information? * Assuming the soundcards can handle diff --git a/dlls/winealsa.drv/mixer.c b/dlls/winealsa.drv/mixer.c index cc38f8f..68d09c6 100644 --- a/dlls/winealsa.drv/mixer.c +++ b/dlls/winealsa.drv/mixer.c @@ -54,10 +54,6 @@ WINE_DEFAULT_DEBUG_CHANNEL(mixer); #ifdef HAVE_ALSA -#define WINE_MIXER_MANUF_ID 0xAA -#define WINE_MIXER_PRODUCT_ID 0x55 -#define WINE_MIXER_VERSION 0x0100 - /* Generic notes: * In windows it seems to be required for all controls to have a volume switch * In alsa that's optional @@ -797,9 +793,9 @@ static DWORD MIX_GetDevCaps(UINT wDevID, memset(&capsW, 0, sizeof(MIXERCAPS2W)); - capsW.wMid = WINE_MIXER_MANUF_ID; - capsW.wPid = WINE_MIXER_PRODUCT_ID; - capsW.vDriverVersion = WINE_MIXER_VERSION; + capsW.wMid = MM_WINE; + capsW.wPid = MM_WINE_ALSA; + capsW.vDriverVersion = MM_WINE_ALSA_VERSION; lstrcpynW(capsW.szPname, mmixer->mixername, sizeof(capsW.szPname)/sizeof(WCHAR)); capsW.cDestinations = mmixer->dests; @@ -1421,9 +1417,9 @@ static DWORD MIX_GetLineInfo(UINT wDevID else Ml->Target.dwType = MIXERLINE_TARGETTYPE_WAVEOUT; Ml->Target.dwDeviceID = 0xFFFFFFFF; - Ml->Target.wMid = WINE_MIXER_MANUF_ID; - Ml->Target.wPid = WINE_MIXER_PRODUCT_ID; - Ml->Target.vDriverVersion = WINE_MIXER_VERSION; + Ml->Target.wMid = MM_WINE; + Ml->Target.wPid = MM_WINE_ALSA; + Ml->Target.vDriverVersion = MM_WINE_ALSA_VERSION; lstrcpynW(Ml->Target.szPname, mmixer->mixername, sizeof(Ml->Target.szPname)/sizeof(WCHAR)); return MMSYSERR_NOERROR; } diff --git a/dlls/winealsa.drv/waveinit.c b/dlls/winealsa.drv/waveinit.c index 1516aa6..8663d47 100644 --- a/dlls/winealsa.drv/waveinit.c +++ b/dlls/winealsa.drv/waveinit.c @@ -494,9 +494,9 @@ static int ALSA_AddPlaybackDevice(snd_ct wwo.outcaps.szPname, sizeof(wwo.outcaps.szPname)/sizeof(WCHAR)); wwo.outcaps.szPname[sizeof(wwo.outcaps.szPname)/sizeof(WCHAR) - 1] = '\0'; - wwo.outcaps.wMid = MM_CREATIVE; - wwo.outcaps.wPid = MM_CREATIVE_SBP16_WAVEOUT; - wwo.outcaps.vDriverVersion = 0x0100; + wwo.outcaps.wMid = MM_WINE; + wwo.outcaps.wPid = MM_WINA_ALSA; + wwo.outcaps.vDriverVersion = MM_WINE_ALSA_VERSION; rc = ALSA_ComputeCaps(ctl, pcm, &wwo.outcaps.wChannels, &wwo.ds_caps.dwFlags, &wwo.outcaps.dwFormats, &wwo.outcaps.dwSupport); @@ -534,9 +534,9 @@ static int ALSA_AddCaptureDevice(snd_ctl wwi.incaps.szPname, sizeof(wwi.incaps.szPname) / sizeof(WCHAR)); wwi.incaps.szPname[sizeof(wwi.incaps.szPname)/sizeof(WCHAR) - 1] = '\0'; - wwi.incaps.wMid = MM_CREATIVE; - wwi.incaps.wPid = MM_CREATIVE_SBP16_WAVEOUT; - wwi.incaps.vDriverVersion = 0x0100; + wwi.incaps.wMid = MM_WINE; + wwi.incaps.wPid = MM_WINE_ALSA; + wwi.incaps.vDriverVersion = MM_WINE_ALSA_VERSION; rc = ALSA_ComputeCaps(ctl, pcm, &wwi.incaps.wChannels, &wwi.ds_caps.dwFlags, &wwi.incaps.dwFormats, &wwi.dwSupport); diff --git a/dlls/winmm/tests/wave.c b/dlls/winmm/tests/wave.c index 2844be4..d902a4a 100644 --- a/dlls/winmm/tests/wave.c +++ b/dlls/winmm/tests/wave.c @@ -812,6 +812,7 @@ static void wave_out_test_device(int dev SYSTEM_INFO sSysInfo; DWORD flOldProtect; BOOL res; + BOOL wine = FALSE; GetSystemInfo(&sSysInfo); dwPageSize = sSysInfo.dwPageSize; @@ -821,9 +822,13 @@ static void wave_out_test_device(int dev rc==MMSYSERR_NODRIVER, "waveOutGetDevCapsA(%s): failed to get capabilities: rc=%s\n", dev_name(device),wave_out_error(rc)); - if (rc==MMSYSERR_BADDEVICEID || rc==MMSYSERR_NODRIVER) + if (rc!=MMSYSERR_NOERROR) return; + /* check for wine manufactures id */ + if (capsA.wMid == MM_WINE) + wine = TRUE; + rc=waveOutGetDevCapsW(device,&capsW,sizeof(capsW)); ok(rc==MMSYSERR_NOERROR || rc==MMSYSERR_NOTSUPPORTED, "waveOutGetDevCapsW(%s): MMSYSERR_NOERROR or MMSYSERR_NOTSUPPORTED " @@ -854,14 +859,23 @@ static void wave_out_test_device(int dev } rc=waveOutGetDevCapsA(device,&capsA,4); - ok(rc==MMSYSERR_NOERROR || rc==MMSYSERR_INVALPARAM, - "waveOutGetDevCapsA(%s): MMSYSERR_NOERROR or MMSYSERR_INVALPARAM " - "expected, got %s\n", dev_name(device),wave_out_error(rc)); + if (wine) // we really care that wine drivers do the right thing + ok(rc==MMSYSERR_NOERROR, "waveOutGetDevCapsA(%s): MMSYSERR_NOERROR " + "expected, got %s\n", dev_name(device),wave_out_error(rc)); + else // broken Windows drivers may fail so accept known failures + ok(rc==MMSYSERR_NOERROR || rc==MMSYSERR_INVALPARAM, + "waveOutGetDevCapsA(%s): MMSYSERR_NOERROR or MMSYSERR_INVALPARAM " + "expected, got %s\n", dev_name(device),wave_out_error(rc)); rc=waveOutGetDevCapsW(device,&capsW,4); - ok(rc==MMSYSERR_NOERROR || rc==MMSYSERR_NOTSUPPORTED, - "waveOutGetDevCapsW(%s): MMSYSERR_NOERROR or MMSYSERR_NOTSUPPORTED " - "expected, got %s\n",dev_name(device),wave_out_error(rc)); + if (wine) // we really care that wine drivers do the right thing + ok(rc==MMSYSERR_NOERROR, "waveOutGetDevCapsW(%s): MMSYSERR_NOERROR " + "expected, got %s\n",dev_name(device),wave_out_error(rc)); + else // broken Windows drivers may fail so accept known failures + ok(rc==MMSYSERR_NOERROR || rc== MMSYSERR_INVALPARAM || + rc==MMSYSERR_NOTSUPPORTED, "waveOutGetDevCapsW(%s): " + "MMSYSERR_NOERROR or MMSYSERR_INVALPARAM or MMSYSERR_NOTSUPPORTED " + "expected, got %s\n",dev_name(device),wave_out_error(rc)); nameA=NULL; rc=waveOutMessage((HWAVEOUT)device, DRV_QUERYDEVICEINTERFACESIZE, diff --git a/include/mmsystem.h b/include/mmsystem.h index bb13cfd..e232856 100644 --- a/include/mmsystem.h +++ b/include/mmsystem.h @@ -243,6 +243,7 @@ typedef void (CALLBACK *LPDRVCALLBACK)(H #define MM_MICROSOFT 1 /* Microsoft Corp. */ #define MM_CREATIVE 2 /* Creative labs */ +#define MM_WINE 255 /* Wine */ #define MM_MIDI_MAPPER 1 /* MIDI Mapper */ #define MM_WAVE_MAPPER 2 /* Wave Mapper */ @@ -262,6 +263,14 @@ #define MM_PC_JOYSTICK 12 #define MM_CREATIVE_SBP16_WAVEOUT 104 +#define MM_WINE_ALSA 1 +#define MM_WINE_AUDIOIO 2 +#define MM_WINE_COREAUDIO 3 +#define MM_WINE_ESD 4 +#define MM_WINE_JACK 5 +#define MM_WINE_NAS 6 +#define MM_WINE_OSS 7 + UINT WINAPI mmsystemGetVersion(void); BOOL WINAPI sndPlaySoundA(LPCSTR lpszSound, UINT fuSound); BOOL WINAPI sndPlaySoundW(LPCWSTR lpszSound, UINT fuSound);

8 8

Re: Dan Kegel : winecfg: Restrict dpi slider to sane values.
by Lei Zhang May 1, 2008

May 1, 2008

On Wed, Apr 23, 2008 at 5:59 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Module: wine > Branch: master > Commit: faaccca59be08be547ec4e1948b6306eff3808a2 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=faaccca59be08be547ec4e194… > > Author: Dan Kegel <dank(a)kegel.com> > Date: Tue Apr 22 17:56:36 2008 -0700 > > winecfg: Restrict dpi slider to sane values. > > --- > > programs/winecfg/x11drvdlg.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/programs/winecfg/x11drvdlg.c b/programs/winecfg/x11drvdlg.c > index bfa6ec5..c0ec058 100644 > --- a/programs/winecfg/x11drvdlg.c > +++ b/programs/winecfg/x11drvdlg.c > @@ -35,9 +35,9 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(winecfg); > > -#define RES_MAXLEN 5 /* the maximum number of characters in a screen dimension. 5 digits should be plenty, what kind of crazy person runs their screen >10,000 pixels across? */ > +#define RES_MAXLEN 5 /* max number of digits in a screen dimension. 5 digits should be plenty */ > #define MINDPI 96 > -#define MAXDPI 480 > +#define MAXDPI 144 /* making this too high surprises and hurts users */ > #define DEFDPI 96 > > #define IDT_DPIEDIT 0x1234 > > > > Dan, this basically reverted commit 0110512904d9c646abef416819a057c06d3f2c97, which bumped MAXDPI from 160 to 480 because some users specifically requested the ability for higher DPI settings. I think we need to decide what we want and stop the tug-o-war.

12 23