May 2008 - Wine-Devel - list.winehq.org

Re: ddraw: Fixed in part regression bug #13277
by Jens Albretsen May 23, 2008

May 23, 2008

On Friday 23 May 2008 06:35:22 you wrote: > Jens Albretsen wrote: > > On Thursday 22 May 2008 23:56:42 you wrote: > >> I don't have a compiler on my windows box, nor do I have cross > >> development tools on my linux box, but if you get me an exe I can test > >> on win xp (nvidia 7200 GT) or 2k (intel 865, or a variety of other > >> boxes). > >> > >> -Austin > > > > I have the same problem, I have absolutely no M$ stuff at home. > > I'm pretty sure what I did is correct, since like I said the game works > > on windows and now it also does in wine. Before wine was crashing so it > > can only be better. And next time someone runs the test on the M$ > > platforms we'll see if the test fails or what? Anyway without the patch > > we just get a crash. > > That's the part your have to prove with tests and test results. Just the > fact that it fixes one program doesn't mean it's correct and won't break > all other programs. > > This is been the worst part about Wine and d3d in particular. That small > "fixes" fix one game/problem yet break everything else. > > Vitaliy. In this case it was the function that did'nt check the arguments correctly, so it would break nothing only get more stable, but anyway I added a test, and It's been verified to work on windows XP. I can understand if it was like the other part I submitted where I was changing the public ref count and failing the tests. /Jens

1 0

Re: ddraw: Fixed in part regression bug #13277
by Jens Albretsen May 23, 2008

May 23, 2008

On Thursday 22 May 2008 23:56:42 you wrote: > I don't have a compiler on my windows box, nor do I have cross > development tools on my linux box, but if you get me an exe I can test > on win xp (nvidia 7200 GT) or 2k (intel 865, or a variety of other > boxes). > > -Austin I have the same problem, I have absolutely no M$ stuff at home. I'm pretty sure what I did is correct, since like I said the game works on windows and now it also does in wine. Before wine was crashing so it can only be better. And next time someone runs the test on the M$ platforms we'll see if the test fails or what? Anyway without the patch we just get a crash. > On 5/22/08, Jens Albretsen <jens(a)albretsen.dk> wrote: > > On Thursday 22 May 2008 23:39:33 you wrote: > >> On 5/22/08, Jens Albretsen <jens(a)albretsen.dk> wrote: > >> > I have no way of testing what is does native? Only got windows at > >> > work. > >> > >> If you need something tested on windows, or on a specific > >> version/locale you don't have access to, send a test app to wine-users > >> or wine-devel asking for testers. Odds are *someone* has the > >> configuration needed and time to do it. > > > > Anyone who want to apply the patches I did and do a "make test" of > > dlls/ddraw > > on windows?

2 1

Re: Cyrillic glyphs and bitmap fonts for Tahoma Bold
by Dmitry Timoshkov May 23, 2008

May 23, 2008

"Igor Tarasov" <tarasov.igor(a)gmail.com> wrote: > diff --git a/fonts/tahomabd.sfd b/fonts/tahomabd.sfd > index b9fdfa0..e42678a 100644 > --- a/fonts/tahomabd.sfd > +++ b/fonts/tahomabd.sfd > @@ -1,4 +1,4 @@ > -SplineFontDB: 1.0 > +SplineFontDB: 2.0 As I pointed out many times this is a fatal change, please leave it at 1.0. -- Dmitry.

1 0

Re: Alternate shell?
by Susan Cragin May 22, 2008

May 22, 2008

http://shellcity.net/cgi-bin/DB_Search/db_search.cgi?setup_file=topicpage.s… Don't forget this list. -----Original Message----- >From: Dan Kegel <dank(a)kegel.com> >Sent: May 22, 2008 6:16 PM >To: Wine Develop <wine-devel(a)winehq.org> >Subject: Alternate shell? > >For a maximal dogfood experience, I was looking around >for a way to use a replacement Windows shell with >Wine as my desktop environment instead of gnome >or kde. > >So far, all the ones I've found are either broken, hard to use, >or just plain weird. > >I've been working through the list at >http://www.dmoz.org/Computers/Software/Operating_Systems/Microsoft_Windows/… > >http://www.astonshell.com/aston/ - couldn't figure out how to run it? > >http://www.emergedesktop.org/ - kind of works, but very minimal, no start menu > >http://www.labyrinth.net.au/~mosses/rob/liteshell.html - works, but >very minimal, no start menu > >http://purels.org - no help, just exits, saying "ha ha, you didn't >configure me". Obviously not meant for me :-) > >http://www.lighttek.com/talisman.htm - pretty, but no Programs menu?! >(Maybe that's there but broken, wine bug?) > >http://www.sky.franken.de/explorer/download.html - ROS explorer - >prebuilt binary >there is 3 years out of date, doesn't work too well > >Anyone have a favorite I should try? >- Dan > >

1 0

Re: ddraw: Fixed in part regression bug #13277
by Alexander Dorofeyev May 22, 2008

May 22, 2008

Jens Albretsen wrote: > Changelog: > > Fixed Failure when texture was loading onto itself. > Fixes in part d3d7 regression bug #13277. > Still need to find a way to make d3d7 stay alive after the game releases the > interface. > Did you check what native does when asked to Load texture from itself? Is it D3D_OK or maybe something like INVALIDCALL? There already should be a few tests for IDirect3DTexture_Load in ddraw/tests/d3d.c so you can add a few lines there that test this.

3 3

Re: [rsaenh] don't throw error on salt with more that 128bit
by Juan Lang May 22, 2008

May 22, 2008

- /* salt length can't be greater than 128 bits = 16 bytes */ - if (blob->cbData > 16) - { - SetLastError(ERROR_INVALID_PARAMETER); - return FALSE; - } memcpy(pCryptKey->abKeyValue + pCryptKey->dwKeyLen, blob->pbData, blob->cbData); You can't just remove the check, an app that passes in a bad blob will overwrite memory. If that's not allowed in Windows, it shouldn't be in Wine, either. You really need to write a test case that shows what the correct limit for the salt length is, or show that Windows just crashes if you pass in too much salt data. That'll prevent future regressions from cropping up, too. --Juan

1 0

Re: ddraw: Fixed last part of regression bug #13277
by Stefan Dösinger May 22, 2008

May 22, 2008

Am Donnerstag, 22. Mai 2008 16:17:26 schrieb Jens Albretsen: > Changelog: > d3d1-7 surfaces was not ref counting ddraw so if there was surface and > ddraw was released, wine would kill everything. Now the Return to > Mysterious Island works and does a clean exit afterwards. I think the patch is wrong. There's a test that shows that this is not happening. If it doen't break any existing tests, please add a test to demonstrate that the change is correct

3 4

Re: ole32/tests: Add a trailing '\n' to ok() calls.
by Michael Karcher May 22, 2008

May 22, 2008

Am Donnerstag, den 22.05.2008, 10:37 +0200 schrieb Francois Gouget: > - ok(len == 39, "len: %d (expected 39)",len); > + ok(len == 39, "len: %d (expected 39)\n", len); [and so on] You are right. This was missing from my patch that got applied. I sent an updated version one hour later[1] (got through moderation 6 hours later or so), which does - Include the missing "\n" characters - Makes this function indented like the others in ole32/tests/compobj.c - Test another case that wine gets wrong (with todo_wine) In direct sucession[2], I sent a patch which corrects the problem in wine and removes the todo_wine from the testcase again. I did it that way to seperate the two patches, still preventing the testsuite to show an additional failure. Was something wrong with the way I handled the first not-that-good patch (apart from sending it with the missing new lines at all, of course)? Regards, Michael Karcher [1]: <1211272286.9165.17.camel(a)hermes2.karcher.local> [2]: <1211268226.9165.13.camel(a)hermes2.karcher.local>

1 0

Re: kernel32:Fix a test that fails for all platforms
by Alexandre Julliard May 22, 2008

May 22, 2008

"James Hawkins" <jhawkins(a)codeweavers.com> writes: > If you don't like this version, let me know. The other option is to > convert any forwards slashes in the result string to backslashes. This should most likely be fixed in winetest. -- Alexandre Julliard julliard(a)winehq.org

1 0

stub implementation of GdipImageGetFrameDimensionsCount
by Petr Dlouhý May 22, 2008

May 22, 2008

Hello, I want to ask, why my patch (http://www.winehq.org/pipermail/wine-patches/2008-May/054973.html) didn't get committed? -- Petr Dlouhý

1 0

Re: kernel32: Enumerate the Greek language group locales instead of Western Europe
by Alexandre Julliard May 22, 2008

May 22, 2008

"James Hawkins" <jhawkins(a)codeweavers.com> writes: > Any objections to this patch? The point of the test is to enumerate > locales of a language group, which still happens. The failure in > win2k3 can't easily be caught, so this works around that. Looking at the test results it seems the failure is because it passes an lcid of 0, that seems pretty trivial to catch. Did I miss something? -- Alexandre Julliard julliard(a)winehq.org

1 0

Take the Wine 1.0 Dogfood Challenge!
by Dan Kegel May 22, 2008

May 22, 2008

As I wrote two years ago: if we're expecting people to use Wine for real work, maybe we should start doing that ourselves. How's about everybody start using Wine for *everything*? See http://wiki.winehq.org/DogfoodChallenge

1 0

Re: headers: Update aviriff header to use 1 byte alignment
by Dmitry Timoshkov May 22, 2008

May 22, 2008

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > These structures are on disk formats, so normal alignment rules don't > apply here. PSDK has a different idea about aviriff.h alignment. -- Dmitry.

1 0

Thunderbird warning repeat - use --attach
by Jeremy White May 22, 2008

May 22, 2008

So it seems as though every month or so, some id10t is bit by the Thunderbird bug where it mangles perfectly reasonable looking git-format-patch drafts. This month, I won the prize! :-) I had always habitually done --attach, because that's what GitWine says to do. But after scratching my head, reading man pages, and checking my drafts, I decided that was lame; inline is always nicer, and I dropped the --attach. Big mistake; the draft may look okay, but the end result is mangled somehow. Thanks to Dmitry for alerting me. I've filed a bug with Mozilla over this: https://bugzilla.mozilla.org/show_bug.cgi?id=435020 My sense is that its a subtle bug of some kind; I've had a hard time articulating a strategy to reproduce it (which, by Occam's razor, immediately suggests I'm just missing something :-/). So if others are bit by this and can share any clues or tips for the Mozilla devs on how to reproduce it, I'd appreciate it. Cheers, Jeremy

4 4

Crosstests - Too large of log files?
by Austin English May 21, 2008

May 21, 2008

In the past 2 days, when running the cross tests on my work XP box, I keep getting an error that the log file is too big (1.6 Mb > 1.5 Mb max). Anyone else seeing this? It's submitting partial reports, which may or may not be useful. Can we get some compression going, or increase the max log size? -Austin

4 6

Re: mlang: accept character set names like ISO8859-1
by James Hawkins May 21, 2008

May 21, 2008

On Wed, May 21, 2008 at 6:22 PM, Dan Kegel <dank(a)kegel.com> wrote: > Accept names both with and without dash after ISO. > > Fixes http://bugs.winehq.org/show_bug.cgi?id=13340 > > The ugly string comparison could be avoided by > canonicalizing the input character set name, > though that would mean making a copy. Would > you prefer it that way instead? > > This doesn't change the miserable status of the > mlang tests on XP: > http://test.winehq.org/data/200805211000/#group_XP:mlang:mlang > Those are fixed by this patch: http://winehq.org/pipermail/wine-patches/2008-May/054961.html Julliard is suspicious of the ZeroMemory I had to add, so I need to add another test case to prove it. -- James Hawkins

1 0

Re: wined3d: Remove unneeded "extern" from function definition
by James Hawkins May 21, 2008

May 21, 2008

On Wed, May 21, 2008 at 3:50 PM, Andrew Talbot <andrew.talbot(a)talbotville.com> wrote: > Changelog: > wined3d: Remove unneeded "extern" from function definition. > > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index 7a1a355..684690b 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -2489,7 +2489,7 @@ HRESULT WINAPI IWineD3DSurfaceImpl_SaveSnapshot(IWineD3DSurface *iface, const ch > /** > * Slightly inefficient way to handle multiple dirty rects but it works :) > */ > -extern HRESULT WINAPI IWineD3DSurfaceImpl_AddDirtyRect(IWineD3DSurface *iface, CONST RECT* pDirtyRect) { > +HRESULT WINAPI IWineD3DSurfaceImpl_AddDirtyRect(IWineD3DSurface *iface, CONST RECT* pDirtyRect) { > IWineD3DSurfaceImpl *This = (IWineD3DSurfaceImpl *)iface; > IWineD3DBaseTexture *baseTexture = NULL; > These interface implementations could even be made static. -- James Hawkins

2 2

fedora 9/gcc 4.3 internal compiler error with wine 1.0 rc1
by Hin-Tak Leung May 21, 2008

May 21, 2008

This is probably a bug with gcc 4.3, but just in case there are some people who are knowledgeable with gcc in wine-devel, who may want to fix gcc so that wine can be built on f9: https://bugzilla.redhat.com/show_bug.cgi?id=445494 __________________________________________________________ Sent from Yahoo! Mail. A Smarter Email http://uk.docs.yahoo.com/nowyoucan.html

2 2

Re: crypt32: String resource IDs
by Juan Lang May 21, 2008

May 21, 2008

Don't forget to cc wine-devel on replies.. On Wed, May 21, 2008 at 9:55 AM, Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> wrote: > do we define "rsaenh.dll" as "application"? Not usually, as it's part of Windows and doesn't come with other applications. > So we do not currently have the needed strings (they seem to decribe > actions, for logging, error reporting or progress indication). The > strings we do have are differently numbered, but up to now, I don't know > about any code relying on those numbers. In that case, we just need to add some strings for it. The text values of the strings don't have to match for now. > Thats right. But for rsaenh.dll I need strings wine does not currently > have. The question is how I legally get these strings into wine. Now you're asking for advice I'm not qualified to give. Perhaps someone here can give better guidance. In particular you might ask Jeremy whether the SFLC has given any hints about the proper way to add UI elements to Wine. --Juan

1 0

Re: Patch against bug [13112]
by John Klehm May 21, 2008

May 21, 2008

On Tue, May 20, 2008 at 3:14 PM, Josep Maria Antolín Segura <jaz(a)pastnotecut.org> wrote: > Hello, > > I am resending here the patch attached to the bug # 13112 on bugzilla, regarding > the trackbar control of the comctl32.dll file. You forgot to attach the patch. --John

1 0

crypt32: String resource IDs
by Michael Karcher May 21, 2008

May 21, 2008

Dear developers, are the string resource IDs (IDS_*) in crypt32.dll supposed to be compatible to the native Microsoft DLL? It looks like the strings wine has starting at 1000 are based at 8000 in the crypt32.dll provided with XP. Since SP2, crypt32.dll has extra strings (e.g. at 7501 and following), which are not included in wine's version of the DLL. The reason I am asking is that the native rsaenh.dll fails to load because of failing GetStringW calls for crypt32.dll. It is supposed to fail, or should wine be made more compatible. In the latter case: How do we get string tables that are OK to use in Wine? Surely it is not allowed to just copy them from the Microsoft executable, but in the end, for 100% compatibility, we would have to provide an exact copy. Is there any policy in Wine? Regards, Michael Karcher

2 1

Most common winetest failures on wine
by Dan Kegel May 21, 2008

May 21, 2008

Thanks to everybody who responded to Jeremy's call to run winetest using the 'dotests' script at http://wiki.winehq.org/MakeTestFailures We now have 35 reports, and have some good data on which test failures are common. See the Most Common Failures section at the bottom. Here's what it says right now: The skipgood script above now also tallies tests by how many people they fail for. Currently, it shows: 35 shell32:shelllink 32 user32:msg 16 user32:input 14 ntdll:info 13 d3d9:visual 10 user32:win 8 ddraw:visual 7 urlmon:protocol 5 gdi32:font 4 winmm:wave 3 d3d9:query urlmon:url wininet:url 2 comctl32:tooltips ddraw:dsurface msxml3:domdoc quartz:referenceclock wininet:http 1 d3d8:visual d3d9:device dinput:device dsound:ds3d dsound:ds3d8 dsound:dsound ... Let's ignore the tests that only fail for one person for the moment, and look at the others. shell32:shelllink fails on all winetest reports from all machines, including on real Windows. Yet "make test" in shell32 succeeds on this test. Could somebody have a look at why it reliably fails under winetest? I filed this as bug 13311. user32:msg and user32:input are probably people running non-blessed window managers; Alexandre's position is that we can ignore these, since upstream gnome's WM is fixed. ntdll:info is a flaky test marked todo_wine that succeeds sometimes: "info.c:822: Test succeeded inside todo block: Expected to read 0 bytes, got 0" d3d9:visual failures are all from people not running an approved graphics card, and can be ignored (though maybe we should tell users we only support nvidia Geforce 6 and higher for 3d graphics...) user32:win appears to be nearly all people running unapproved window managers, though abraml-hardy-32 did get one failure "win.c:2555: Test failed: wrong active window (nil)" with KDE3 which should be investigated. [fixme: file bug?] ddraw:visual has two kinds of errors. The most common is "visual.c:2045: Test failed: Got color 00dcdde6, expected 0000ff00". Less common is mstefani's failure, "visual.c:481: Test failed: Untransformed vertex with linear vertex fog has color 00ff0000". [fixme: file bugs?] urlmon:protocol has three or so failure modes; most common is "protocol.c:1597: Test failed: Read failed: 8000000a (0 bytes)". [fixme: file bug?] gdi32:font has several failure modes, not sure what's going on there. [fixme: file bug?] winemm:wave might actually be a problem, perhaps Maarten can take a look. [fixme: file bug?] I haven't looked at the failures that happen for only 2 or 3 people.

4 4

Re: Adding d3d9x_xx dlls to winetricks?
by tony.wasserka＠freenet.de May 21, 2008

May 21, 2008

> So... lots of people are going around installing > all of directx, and maybe all they needed was, say, > d3d9x_35. That's not good. This sounds like > a job for winetricks! > But I know nothing about direct3d. Could somebody > have a look at this draft and see if it suffices? All > I added was d3d9x_35 and d3d9x_36, is that > the right set? You'll need all d3dx dlls, i.e. all from d3dx9_24 to d3dx9_37, as they all (well, most of them) differ a little bit.

1 0

Bad stub ? GetEffectiveRightsFromAclA / GetEffectiveRightsFromAclW
by Michel Jacques May 20, 2008

May 20, 2008

A quick question about stubs, I think above mentioned functions are badly stubbed in ./dlls/advapi32/security.c Current implementation outputs a message like "FIXME ... stub ..." but functions are not stubbed in the ./dlls/advapi32/advapi32.spec file. Is this wrong? If not, how can I know for sure if a function is stubbed(unimplemented)? Thanks, Michel

2 1

Re: kernel32: Comment out the Esperanto locale definitions, they are incomplete, and cause the problems
by Alexandre Julliard May 20, 2008

May 20, 2008

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > this patch fixes the problem reported in the bug 12884. > > Changelog: > kernel32: Comment out the Esperanto locale definitions, they are > incomplete, and cause the problems. This will only make Esperanto support even more incomplete and broken, plus it breaks the tests. It should be possible to fix the definitions by copying values from the Unix locale file. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] Fix 16 bit StringFromGUID2 to not use wide characters
by Dmitry Timoshkov May 20, 2008

May 20, 2008

"Michael Karcher" <wine(a)mkarcher.dialup.fu-berlin.de> wrote: > +INT WINAPI StringFromGUID2_16(REFGUID id, LPSTR str, INT cmax) > +{ > + char xguid[80]; > + int len; > + > + if (WINE_StringFromCLSID( id, xguid )) > + return 0; > + > + len = strlen( xguid ) + 1; /* The terminating zero counts */ > + if (len > cmax) > + return 0; > + > + strcpy( str, xguid ); > + return len; > +} This is not an equivalent of the old implementation, is it really supposed to fail if the buffer length is shorter than the guid? -- Dmitry.

2 4

Re: Bug in dlls/user32/edit.c
by Juan Lang May 20, 2008

May 20, 2008

Hi Bob, could you open a bug at bugs.winehq.org, and put everything you wrote in your email in the description? You might have more luck getting followup that way. Thanks, --Juan

2 1

Spec OpenGL benchmarks
by Dan Kegel May 19, 2008

May 19, 2008

On a whim, I tried the oldest SPEC OpenGL benchmark, SPECviewperf 6. SPECViewperf 6.1.2 lives here: http://www.spec.org/gwpg/pastissues/Feb2_02/opc.static/opcview.htm It's also downloadable from ftp://spec.it.miami.edu/dist/gpc/opc/viewperf/specviewperf612is01.exe So far, the two tests I've tried seem to run ok, though I don't know if the rendering is correct. On one machine, $ cd ".wine/drive_c/Program Files/SPECopc/SPECviewperf 6.1.2" $ wine cmd /c RunLight04.bat produced a proud 3 frames per second, woot! This is pretty slow compared to the published results from 2002, http://www.spec.org/gwpg/pastissues/Feb2_02/opc.data/summary.html even without thinking about how much faster today's CPUs are. Still, it's nice that it runs. Perhaps we can take some baseline data and start looking for bottlenecks one of these days. - Dan

4 4

New winetricks-20080519: add synonym mfc42, show package descriptions in zenity
by Dan Kegel May 19, 2008

May 19, 2008

Another week, another winetricks. Changes since last week's annoucement: - gnome users now see nice package descriptions - mfc42 is now listed as a synonym for vcrun6 Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com

1 0

Wine forums page links
by Ian Macfarlane May 19, 2008

May 19, 2008

The page http://www.winehq.org/site/forums needs to link to the new forums at http://forum.winehq.org/ (it does, but just in the site-wide sidebar not the page body). Regards, Ian

1 0

Can someone get a Maximizer 8 trial CD for me?
by Dan Kegel May 19, 2008

May 19, 2008

http://www.cabc.co.uk/maximizer8/trial_personal.htm free cd, but only for people in the EU. I'm interested because http://www.mindstab.net/wordpress/archives/292 is a recent report some this being one of the two "must have" apps for someone's dad. Thanks, Dan

2 1

Right way to cope with user error in make test?
by Jeremy White May 19, 2008

May 19, 2008

So...turns out that in this flood of new reporting, that one of the errors only happened to me, and it further turns out to be entirely user error; I didn't have libxslt. So, the obvious first solution is for me to actually read my configure results and deal with it. But I think I serve nicely as an example of the sort of incompetent user for whom it would still be nice to have make test work cleanly. I didn't see any obvious standard way of coping with this situation. Did I miss it? I imagined that maybe we'd skip these cases, but I didn't see evidence of that. I could also imagine a facility whereby we note that the configure was not clean, and then refuse to run make test (or at least refuse to run the full winetest battery). Should we make libxslt non optional (or at least require an explicit --without-libxslt in order to build without it)? Cheers, Jeremy

11 19

Re: kernel32: Add a few traces to help debug test failures [RESEND]
by Dmitry Timoshkov May 19, 2008

May 19, 2008

"James Hawkins" <jhawkins(a)codeweavers.com> wrote: > if(detailed_info->lpRootManifestPath) > ok(!lstrcmpiW(detailed_info->lpRootManifestPath, exinfo->root_manifest_path), > - "unexpected detailed_info->lpRootManifestPath\n"); > + "unexpected detailed_info->lpRootManifestPath: %s %s\n", > + strw(detailed_info->lpRootManifestPath), strw(exinfo->root_manifest_path)); As far as I can see strw() uses static buffer and is not able to handle more than one string at once. -- Dmitry.

1 0

Re: Right way to cope with user error in make test?
by Rolf Kalbermatter May 19, 2008

May 19, 2008

Please both calm down a bit. <dmitry(a)codeweavers.com> wrote: >"Steven Edwards" <winehacker(a)gmail.com> wrote: >><dmitry(a)codeweavers.com> wrote: >>> Not everyone supposed to run the Wine tests, only those do who >>> *really* can comprehend the results and able to do something with them. >> >> NO. Everyone that builds Wine from source should run make test. > >Why? Does it magically make something useful? Again, what about other >packages built from source? To limit running of the test frame work only to those that know exactly what they are doing is a to strict limitation IMHO. You should not forget that acceptance of a patch is based on the criteria that it runs make test. Which in may case has been always a limited make test in the directory itself only, since a whole make test seldom or never even got so far as to run for the component I was working at. While sending patches is of course the right thing to do, it has been and still is rather discouraging to get wine sources, building them on ones own box and finally run a make test and find that there are many areas where it simply reports failures or crashes altogether especially in areas I do not have the knowledge to do anything about and not the time to dig into much deeper. The fact that I couldn't get the whole make test to run out of the box on my system without bad crashes and/or numerous test failures has not only made me not run it anymore except in tree for the component I attempted to create a fix for, but has actually discouraged me in the past from working on more bug fixes or improvements other than what I have found strictly necessary to make a specific app working. >> It should pass 100% for everyone everywhere. If does not then there is >> something wrong. It does the world not 1 damn bit of good if passes on >> your system and no one elses. > >If the test doesn't pass for you, go ahead and fix it. I can't do that >for you if the test passes for me. But isn't that the crux of why this discussion started? Someone finding that a soft dependency of Wine on a library should not create a failure but a skip when that dependency was not satisifed and this was detectable in a sane way. And getting shot down that this system should be considerd broken. If the missing soft dependency should be considered a broken system then the dependency should be not soft and vice versa. I personally don't mind a test failure in a library that depends on something I know I don't use and consequently don't have installed but if it's possible to skip the tests for that why not do it? The test framework should not only help avoiding regressions for the VERY active developers but allow anyone working on Wine in one way or the other to have some confidence that he got it to build right. It's what I usually do when installing any source package to see if I missed something. Getting a long list of errors and sometimes crashes out of the box really leaves a bad taste and also makes it much harder to verify that my own modifications to it later on didn't break it in some ways. Rolf Kalbermatter

3 3

is run-time path translation standard
by Roumen Petrov May 18, 2008

May 18, 2008

Dear Wine developers, Starting from version 2.x the libtool would like the create an environment where user to be able to run win32 programs. The former version 1.5x has this capability, but with some limitation in case of cross-compilation environment. The current libtool HEAD revision contain code that create binary executable (C-wrapper). This wrapper executable setup environment and run the real executable. The development in case of cygwin/msys native environment is finished and now on the road is cross-compilation. Lest see recent libtool 2x discussion started here: http://lists.gnu.org/archive/html/libtool-patches/2008-05/msg00044.html The question if about translation at run time of items in PATH environment variable. My test show that we can add absolute paths from build system to the PATH and at run time those paths are translated to the paths in emulated environment. Is this translation documented, i.e. standard or it is just a "side-effect"? If translation is non-standard, could Wine team confirm that will keep it ? Note that Charles may is not subscribed to the list and please CC to him. Roumen P.S. Also, please consider a minor issue with winepath: http://bugs.winehq.org/show_bug.cgi?id=13265

1 0

Re: WineD3D: workaround for lack of depth/stencil
by Stefan Dösinger May 18, 2008

May 18, 2008

Am Sonntag, 18. Mai 2008 18:11:35 schrieb Roderick Colenbrander: > Hi, > > This patch is a workaround for a severe WineD3D issue which is too much > work and to risky to fix properly during the code freeze. It fixes drawing > issues in GTR2, Suppreme Commander, Call of Duty 2 Call of Duty 4 and > likely dozens of other games. Wouldn't it be better to write the FIXME only if the app requests a depth stencil format != D24S8?

1 0

What graphics cards do the d3d9 tests pass on?
by Dan Kegel May 18, 2008

May 18, 2008

Anyone know how to get the d3d9 tests to pass? Are there a set of graphic cards that are known to work with them? Right now, nobody who's reported test results under wine is seeing them pass: http://test.winehq.org/data/2470b0b31605133ec046330dd79fdccaa7ba33fe/#group… And, come to think of it, ditto for Windows: http://test.winehq.org/data/200804161000/#group_XP:d3d9:visual (though the data's pretty thin there). All the apparant successes are really just skipped tests. - Dan

6 6

Configure question about Wine / HAL
by Kris Moore May 17, 2008

May 17, 2008

I'm trying to get Wine to compile with HAL support on FreeBSD, and running into this error: > checking dbus/dbus.h usability... yes > checking dbus/dbus.h presence... yes > checking for dbus/dbus.h... yes > checking hal/libhal.h usability... yes > checking hal/libhal.h presence... yes > checking for hal/libhal.h... yes > checking for dbus_connection_close in -ldbus-1... no > configure: error: libhal development files not found, no dynamic device > support. > This is an error since --with-hal was requested. What exactly is -ldbus-1? Is there a way around this? Configure is finding the dbus and hal headers properly, and they both work properly on the system. -- Kris Moore PC-BSD Software http://www.pcbsd.com

4 11

curious failure and messages running a well-known installer
by Hin-Tak Leung May 17, 2008

May 17, 2008

I install the win32 version of ghostscript quite routinely under wine; just taken the old one off and put the new one in with wine rc1, the first time it bombed out with: err:module:map_image Could not map section _winzip_, file probably truncated err:module:map_image Could not map section _winzip_, file probably truncated wine: could not load L"H:\\mirror.cs.wisc.edu\\pub\\mirrors\\ghost\\GPL\\current\\gs862w32.exe": Bad EXE format for and 2nd/3rd time it went to completion. This is the first time ever I have a failure installing ghostscript. There are some messages which I don't remember seeing before also: fixme:shell:IShellLinkA_fnGetPath (0x14a980): WIN32_FIND_DATA is not yet filled. fixme:shell:IShellLinkA_fnGetPath (0x14aae8): WIN32_FIND_DATA is not yet filled. I seem to recall the _winzip_ thing is a known and fixed problem? anyway, the installer is at http://mirror.cs.wisc.edu/pub/mirrors/ghost/GPL/current/gs862w32.exe and I'd be interested to hear if somebody else the _winzip_ failure message. __________________________________________________________ Sent from Yahoo! Mail. A Smarter Email http://uk.docs.yahoo.com/nowyoucan.html

3 2

Re: WIKI: Add forum link to wiki site
by Dimi Paun May 17, 2008

May 17, 2008

On Sat, 2008-05-17 at 10:26 +0200, Rico Schüller wrote: > Hi, > > this patch adds the Wine Forum link to the WineHQ Menu in the wiki. Thanks! Now I'm just on my way out to New York, I'll get back in 3 days, I'll look at it when I get back. [If I don't commit it in 3-4 days, please ping me again, in case it felt through the cracks] -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Search data seems to show that each new product seems to raise Wine's profile a bit
by Dan Kegel May 17, 2008

May 17, 2008

It's a small effect, and it's not really surprising, but if you look at a graph of the relative search volume for the phrases linux wine linux photoshop linux warcraft linux steam it seems that each time a new big app starts working on Linux enough for people to start searching for it (photoshop, warcraft, steam), the number of queries for linux wine goes up a little bit. http://www.google.com/trends?q=linux+wine%2Clinux+photoshop%2C+linux+warcra… I'm just pleased to see that the effect is measurable, and not lost in the noise...

2 1

Re: [PATCH 2/3] shell32: implement make new folder UI changes.
by Jeff Latimer May 17, 2008

May 17, 2008

Lei Zhang wrote: > Hi, > > This implements the treeview UI changes to show users the newly created folder. > > ------------------------------------------------------------------------ > > I can't apply the patch. Is there one missing? Jeff Latimer

2 1

Wine 1.0 release status: 27 bugs left
by Dan Kegel May 17, 2008

May 17, 2008

Clickable copy at http://kegel.com/wine/countdown.html Wine Release Status Wine 1.0rc1 released on May 9. 6 days to second release candidate. wine-1.0rc1 was released on Friday, May 9th, 2008. Wine is now in a code freeze in preparation for the 1.0 release. According to http://wiki.winehq.org/WineReleasePlan, wine-1.0.0-rc2 will be due out Friday, May 23rd, 2008. It will be something like be the next to last release candidate for 1.0. Alexandre is on vacation, so git is a bit stale. In particular, Photoshop CS2 and DNS 9 don't install properly due to a regression introduced just before his vacation started; here's the fix. Some effort has been put into making it easy for people to automatically report "make test" failures; see MakeTestFailures for info and results. Bug Status There are 27 open 1.0 bugs as of 16 May. Most of these will simply be rolled over to be fixed for a later release; we only have time to fix a few, and much as we'd like to fix the rest, most are not showstoppers. Changes since last week (with category and votes): New (!): 8783 ntdll 15 USB serial ports do not work 13168 -unknown 0 Update the README before the 1.0 release Fixed: 3270 gdi32 16 Problem with minimized top-level windows 5844 -unknown 16 tray minimize 5926 programs 1 Wine does not provide an implementation of winhlp32.exe 5948 -unknown 2 Star Trek: Armada does not install 8898 shdocvw 1 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 11742 shlwapi 9 Small .net 1.1 app (FastMD5 1.3) fails to start up 12263 opengl 3 Sketchup Cannot initialize OpenGL - ChoosePixelFormat fails Abandoned: 664 user32 8 The help menu functionality inside programs is broken (messaging problem) Here's the full list of current bugs: 2493 comctl32 2 Multi-select listview: Shift-arrow up only selects top two items 11509 crypt32 0 Wordviewer 2003 is unable to open documents encrypted with AES 5535 directx- 21 Planescape:Torment doesn't work 9916 directx- 7 "make test" usually fails 11584 directx- 4 Multiple games crash with stack overflow error 12246 directx- 2 "make test" gives different results with and without warn+heap 12730 gdi32 1 gdi32: some tests fail when X is run in 16 bit mode, but not 32 bit 6519 gdi32 7 Wine blacks out rotated font bitmap 9771 gdi32 47 Steam Friends doesn't work (fails to render correctly or refresh) 5024 kernel32 6 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 10147 msi 2 Word Viewer 2003 - Tab behavior differs from Windows 8783 ntdll 15 USB serial ports do not work 10288 programs 0 wine_gecko download hangs sometimes 13071 quartz 0 Flashplayer crashes in a quartz bug 5163 setupapi 15 Office XP 2002 crashes on installation 6095 shdocvw 17 MOTD in counter-strike 1.6 and counter-strike source does not render 8439 shell32 10 Visual Studio .NET (7) install fails 12074 testcase 3 The conformance tests fail on Windows 5402 -unknown 0 Trying to run PhotoStitch 3.1 7404 -unknown 3 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 11281 -unknown 5 CJK input many issues 12097 -unknown 3 Wine 1.0 should not ship out-of-sync resource translations 13168 -unknown 0 Update the README before the 1.0 release 3023 user32 6 Orcad - "Place Part" never tries to put down a part 124 wineserv 2 Review of Wine Server Protocol 9787 winsock 67 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 12005 wintab32 2 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

1 0

Call for help with Wine 1.0 testing
by Jeremy White May 16, 2008

May 16, 2008

Hi Folks, One key goal for Wine 1.0 is that all of its conformance tests run successfully on nearly all systems. We would really like your help in figuring out how close we are to that goal. To that end, if you are comfortable with checking Wine out via git, could you please visit this page: http://wiki.winehq.org/MakeTestFailures and follow the instructions there? (It's really simple; build current git Wine, download + run a script). And, if you're a Wine developer, since Alexandre is away and the code freeze is on, why not look for one of those failures in your own make test results and see if you can fix it? Thanks! Jeremy

6 9

re: Right way to cope with user error in make test?
by Dan Kegel May 16, 2008

May 16, 2008

jwhite wrote: > The attached patch is one approach - skip the tests in this case. > Does this seem like a reasonable approach to folks? I like it. I would also like to see us get a lot tougher about letting people build wine without a full complement of development headers. Maybe our configure should have a sanity check at the end, and abort if something optional but very common is missing; we could add a --no-sanity-check option to enable configuring in that case if it's really intended. - Dan

3 4

Re: Right way to cope with user error in make test?
by Susan Cragin May 16, 2008

May 16, 2008

I have a string of crashes in my maketest. Distro Hardy UbuntuStudio, machine ASUS G1S. Several triaged Ubuntu bugs may be responsible. For instance, my video drivers don't work and I have defaulted to vesa. My soundcard doesn't yet work properly, and there are two open bugs related to this, one to do with my motherboard. HTH.

1 0

A console screen buffer sync problem in kernel32/editline.c
by FENG Yu Ning May 16, 2008

May 16, 2008

I have found a synchronization problem in kernel32/editline.c . The problem appears when read and write operations to the console are in different threads. Detail information is here: http://bugs.winehq.org/show_bug.cgi?id=13188 Solution to it should not be difficult. Could any developers look into this and fix it? Thanks very much!

1 0

Re: ALSA Midi port names
by Dmitry Timoshkov May 16, 2008

May 16, 2008

"Free Ekanayaka" <free(a)64studio.com> wrote: > I attach an amended patch for this bug: > > http://bugs.winehq.org/show_bug.cgi?id=13241 As it's been said the first hunk of your patch looks incorrect and seems not related. Also, please use your real name, Wine doesn't accept anonymous patches. -- Dmitry.

1 0

Re: richedit: empty text should result in a scroll range of 0. Tests for this behavior.
by Eric Pouech May 15, 2008

May 15, 2008

Alex Villacís Lasso a écrit : > Even though the code freeze is still in effect, I post this so that it > will be reviewed. For more information, see bug #12311. > > Changelog: > * richedit: empty text should result in a scroll range of 0. > * Tests for this behavior. > > ------------------------------------------------------------------------ > > what I don't understand is why the height of an empty doc is not zero (I had similar issues with the height of a doc where we systematically get one row too much). I believe this root cause should be fixed instead of the band aid your patch is providing A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 2

regressions running Photoshop?
by Dan Kegel May 15, 2008

May 15, 2008

Hmm. I just tried running Photoshop CS2 trial and Photoshop 5.5 trial, and both failed on current wine. CS2 complained "not enough DOS memory", and 5.5 complained lcms: Error #12288; Too many tags (2025813777) PS6 works, though.

2 3

re: ws2_32: Test for invalid hostnames again.
by Dan Kegel May 15, 2008

May 15, 2008

Kai, that test will always fail on some systems. How about this: just test for whether that function completes at all, rather than testing for success. - Dan

2 1

Re: dinput: Convert keyboard buffer from internal data format to user data format
by Vitaliy Margolen May 15, 2008

May 15, 2008

Sergey Khodych wrote: > > > Any particular reason for this? Do you have a program that sets different data format? The reason I ask - copying 256 bytes is much faster then iterating over the whole data format and copying one byte at a time. Vitaliy.

2 5

shell32 failures only under winetest, not make test?
by Dan Kegel May 14, 2008

May 14, 2008

Oddly, I only see shelllink.c:90: Test succeeded inside todo block: SHILCreateFromPath failed (0x00000000) shelllink.c:194: Test succeeded inside todo block: path_to_pidl returned a NULL pidl shelllink.c:214: Test failed: GetPath returned 'C:\nonexistent\file' shelllink: 190 tests executed (2 marked as todo, 3 failures), 0 skipped. when I run on wine with winetest-dist. When I do 'make test', shelllink.ok gets created fine. Anyone else see that?

1 0

Wineconf 2008
by Jeremy White May 14, 2008

May 14, 2008

Hi Folks, We have provisionally set Wineconf for the weekend of September 27/28 in Saint Paul, Minnesota. The Wine conference is open to all. We host 2 days of informal sessions to discuss technical issues related to Wine development. We'll likely also have a celebration of Wine 1.0, and other social activities. If you're interested in Wineconf, please visit this web page: http://www.winehq.org/site/wineconf/survey In particular, if you have given up on Wineconf because of travel costs, please indicate that on the form. I'll use the response data I get there to nail down the details. I look forward to seeing you all, and to celebrating 1.0! Cheers, Jeremy

1 0

Re: wine.inf: add a fake dll for sensapi.dll
by Austin English May 14, 2008

May 14, 2008

Anything wrong with this patch? http://www.winehq.org/pipermail/wine-patches/2008-May/054794.html

2 2

re: Serial port support in wine-1.0: What to do to make it working ?
by Dan Kegel May 14, 2008

May 14, 2008

Pavel wrote: > I have to use wine-0.9.40 to communicate with a device > in my work (simple text-based command-reply communication), > any wine newer than say 0.9.50 doesn't work, the communication times out. > ... I will try to dig into the driver and search for the bugs there. > One of the cases is I think simple, the device uses normal ASCII protocol > and I can talk to it using kermit or minicom, but the windows program > intended to control it simply stucks on the first command and never > gets a reply. I think there is a good place to start. Yep. FWIW, the fix might be tiny. Alexandre fixed a serial bug today, http://bugs.winehq.org/show_bug.cgi?id=9356 with just a single assignment. If you can come up with a simple way for others to reproduce the problem, that might help, too. Lessee... here are most of the existing serial bug reports; some of them (eg. 4055, 8783, 9988, 10051, 10056, 11399, 11811) have interesting info: http://bugs.winehq.org/show_bug.cgi?id=1244 (big grab bag of apps, some downloadable) http://bugs.winehq.org/show_bug.cgi?id=1700 (putty, downloadable) http://bugs.winehq.org/show_bug.cgi?id=4055 (interesting, points to kernel bug) http://bugs.winehq.org/show_bug.cgi?id=4633 (Garmin) http://bugs.winehq.org/show_bug.cgi?id=4753 (workaround, interesting, mentions kernel problem) http://bugs.winehq.org/show_bug.cgi?id=5154 (Siemens phone; 0.9.12 bad) http://bugs.winehq.org/show_bug.cgi?id=6895 (0.9.27 bad; timeout control broken) http://bugs.winehq.org/show_bug.cgi?id=5632 (Secure CRT behaves funny, downloadable) http://bugs.winehq.org/show_bug.cgi?id=8113 (0.27 good, 0.35 bad) http://bugs.winehq.org/show_bug.cgi?id=8783 (pinpoints the very commit that caused the problem in 0.9.23!) http://bugs.winehq.org/show_bug.cgi?id=9988 (good analysis, example code, patch) http://bugs.winehq.org/show_bug.cgi?id=10051 (HAL needs to create entries for serial ports?) http://bugs.winehq.org/show_bug.cgi?id=10056 (good source testcase!) http://bugs.winehq.org/show_bug.cgi?id=10573 (wine's tests fail on laptop with serial port; bisect) http://bugs.winehq.org/show_bug.cgi?id=11077 (HAL needs to create entries for serial ports) http://bugs.winehq.org/show_bug.cgi?id=11339 (bugfix for serial.c) http://bugs.winehq.org/show_bug.cgi?id=11811 (HAL support needs improvement) http://bugs.winehq.org/show_bug.cgi?id=11829 (0.9.22 good, 0.9.56 bad) http://bugs.winehq.org/show_bug.cgi?id=12479 (timeout problems?) OMG that's a lot of bugs. There has been a LOT of analysis done by various folks; now it's time to grind through it all and fix the problems. As I mentioned, Alexandre has fixed one already; perhaps he has time to look at a few more of these. FWIW, I have some win32 serial i/o example source code here, along with an archive of comments about problems (from back in the day when multiplayer games talked to modems): http://alumnus.caltech.edu/~dank/overlap.htm - Dan

3 3

TrendyFlash Site Builder works!
by Dan Kegel May 14, 2008

May 14, 2008

http://bugs.winehq.org/show_bug.cgi?id=9376 People who generate annoying cookiecutter Flash web sites can now migrate to LInux with confidence :-)

1 0

Re: comctl32: Fix statusbar text alignment bug #12693
by James Hawkins May 14, 2008

May 14, 2008

On Tue, May 13, 2008 at 7:59 PM, Igor Tarasov <tarasov.igor(a)gmail.com> wrote: > MSDN regarding statusbar text alignment says that "By default, text is > left-aligned <...> Text to the right of a single tab character is > centered, and text to the right of a second tab character is > right-aligned.". Current implementation, however, could be described > as "if the first character is tab, center the text. Then check second > character, if it is tab too, left-align the text". This patch makes > wine behave more like MSDN says and fixes bug > http://bugs.winehq.org/show_bug.cgi?id=12693 . > Please add a test case to prove this change is correct. -- James Hawkins

2 2

Re: [PATCH] [cmd]: use correct codepage when outputing unicode text to an ANSI stream
by Kirill K. Smirnov May 13, 2008

May 13, 2008

>> This doesn't look right. What if it's wineconsole with user backend >> (default) and OEM CP (which is different then UNIXCP)? Should probably hack >> GetConsoleOutputCP() instead. >> >this code is only used when no wineconsole is attached, so unixcp is the >right choice No, this is used in case of output redirection too. E.g. even in wineconsole, command c:>dir > list.txt will create a list.txt file in UNIXCP, but ConsoleOutputCP is expected. In most cases it does not hurt, but who knows... >however, it can be considered that GetConsoleOutputCP() should be >changed to return the unixcp and not the oem cp when no console is attached -- Kirill

1 0

Re: [PATCH] [cmd]: use correct codepage when outputing unicode text to an ANSI stream
by Vitaliy Margolen May 13, 2008

May 13, 2008

Eric Pouech wrote: > @@ -1437,7 +1437,7 @@ static void WCMD_output_asis_len(const WCHAR *message, int len, HANDLE device) { > } > > /* Convert to OEM, then output */ > - convertedChars = WideCharToMultiByte(GetConsoleOutputCP(), 0, message, > + convertedChars = WideCharToMultiByte(CP_UNIXCP, 0, message, > len, output_bufA, MAX_WRITECONSOLE_SIZE, > "?", &usedDefaultChar); > WriteFile(device, output_bufA, convertedChars, > > This doesn't look right. What if it's wineconsole with user backend (default) and OEM CP (which is different then UNIXCP)? Should probably hack GetConsoleOutputCP() instead. Vitaliy.

2 1

Lots of regressions in games in last few versions
by Vitaliy Margolen May 13, 2008

May 13, 2008

Several latest releases introduced lots and lots of regressions to a point that no games run as-is. Considering that we are at the code freeze, I'd like to see all patches that cause regressions, and all patches that depend on them starting from wine-0.9.58 be reverted. Also each patch to have a conformance test and statement which games where tested and what problems were fixed with each patch. Bugs: 13120, 13110, 13101, 13086 and on and on and on. Can some one explain what's the deal with games not working full screen? Why are there are of the sudden problems with pixel formats? Why lots of games crashing ActivatingContext? Why most games don't work anymore on ATI? If the whole point of wine-1.0 is to have photoshop working - then we might as well call it 'wine-photoshop' get it into a separate tree and don't let any changes not related to photoshop there. Vitaliy.

9 18

Re: [PATCH] Cache localised number chars
by Robert Shearman May 13, 2008

May 13, 2008

Michael Karcher wrote: > UDATE *lpUdate) > static void VARIANT_GetLocalisedNumberChars(VARIANT_NUMBER_CHARS *lpChars, LCID lcid, DWORD dwFlags) > { > static const VARIANT_NUMBER_CHARS defaultChars = { '-','+','.',',','$',0,'.',',' }; > + static VARIANT_NUMBER_CHARS lastChars; > + static LCID lastLcid = -1; > + static DWORD lastFlags = 0; > LCTYPE lctype = dwFlags & LOCALE_NOUSEROVERRIDE; > WCHAR buff[4]; > > + /* Asking for default locale entries is very expensive: It is a registry > + server call. So cache one localy, as Microsoft does it too */ > + if(lcid == lastLcid && dwFlags == lastFlags) > + { > + memcpy(lpChars, &lastChars, sizeof(defaultChars)); > + return; > + } > + > This introduces a race condition. -- Rob Shearman

2 1

Re: includes: Add vmr9 header
by Robert Shearman May 13, 2008

May 13, 2008

Maarten Lankhorst wrote: > @@ -0,0 +1,525 @@ > +/* > + * Copyright 2008 Maarten Lankhorst > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#include "unknwn.idl" You should use import here, not #include. -- Rob Shearman

2 1

re: Lots of regressions in games in last few versions
by Dan Kegel May 13, 2008

May 13, 2008

Vitaliy wrote: >> To get lots more people to try it and report bugs, so it can improve faster. >This is questionable. I can point to several bug reports that have several >dozen people reporting problems and that are still open for years. So just >saying more bug reports results into better Wine is not true. Sure, there are going to be hard bugs. Doesn't matter; on the whole, if we don't know about a bug, we can't fix it. And we need users to find the bugs for us, since only they really know how to use the apps. > Even targeted apps don't work perfectly - have some problems here and there. > People won't stand that. They already feed up with windows... When you get the bugs down below a certain point for a particular app, something funny happens: people start believing. And at that point they are willing to forgive a few issues. > The only loyal public Wine can have is gamers. And we still ignoring this fact. Because it's not a fact. It's a subjective conclusion you reached, but I do not share that opinion. Gamers are just as finicky as anyone else. > Oh and the whole point of wine-1.0 - and the way it's being > presented seems like a joke to me. Give me a break 4 apps?! > 3 of which being direct competitors to native Linux applications! > And such an old versions [97] that no one even uses them anymore. The release criteria are more about managing people's expectations. Underpromising and overdelivering. They're *supposed* to seem modest. Doesn't mean we don't care about other apps. > If anything we should be emphasizing that the code freeze is > to stabilize Wine and fix bugs. ALL bugs regardless of the app. I rather thought we were. That's the whole point of http://wiki.winehq.org/PlatinumRegressionHunt I'm not sure what you're angry about. None of us have that much control over exactly which way wine develops. We all scratch our own itches, and it improves at its own pace. What more do you want? - Dan

7 7

Re: [d3d9] shademode_test: increase slop in color comparison
by Stefan Dösinger May 13, 2008

May 13, 2008

Am Montag, 12. Mai 2008 22:54:18 schrieb Dan Kegel: > The test allowed for a slop of (-1,0) in the colors, > but on my machine, > nVidia Corporation NV17 [GeForce4 440 Go 64M] > the colors were off by +1. So change the code > to allow for a slop of +-1, and switch to a more readable > way of comparing colors. Henri once said he had a universal patch for color slop he was going to send, I'm not sure what happened to it

1 0

Re: winex11: Create a dummy parent window for composite child windows to avoid using the root.
by Chris Robinson May 13, 2008

May 13, 2008

Alexandre Julliard wrote: > - attrib.override_redirect = True; > attrib.colormap = data->colormap; > XInstallColormap(gdi_display, attrib.colormap); > > if(data->gl_drawable) XDestroyWindow(gdi_display, data->gl_drawable); > - data->gl_drawable = XCreateWindow(gdi_display, parent, -w, 0, w, h, 0, > + data->gl_drawable = XCreateWindow(gdi_display, dummy_parent, -w, 0, w, h, 0, > vis->depth, InputOutput, vis->visual, > CWColormap | CWOverrideRedirect, > &attrib); Did you mean to remove setting the override_redirect attribute? I remember having some alignment issues without it (the GL rendering was offset on the unseen window by the size of the decorations). But even if so, you'd need to remove the CWOverrideRedirect flag, because it's now taking the setting from the uninitialized override_redirect field.

2 1

Deprecated sound functions
by TheBlunderbuss May 12, 2008

May 12, 2008

During the day's compile, I noticed some functions were declared deprecated, mainly in sound components. I logged more context, if anyone needs it. alsa.c:738: warning: ‘snd_pcm_hw_params_get_tick_time’ is deprecated (declared at /usr/include/alsa/pcm.h:1108) alsa.c:738: warning: ‘snd_pcm_hw_params_get_tick_time_min’ is deprecated (declared at /usr/include/alsa/pcm.h:1109) alsa.c:738: warning: ‘snd_pcm_hw_params_get_tick_time_max’ is deprecated (declared at /usr/include/alsa/pcm.h:1110) dscapture.c:451: warning: ‘snd_pcm_sw_params_set_xrun_mode’ is deprecated (declared at /usr/include/alsa/pcm.h:1101) dsoutput.c:213: warning: ‘snd_pcm_sw_params_set_xrun_mode’ is deprecated (declared at /usr/include/alsa/pcm.h:1101) wavein.c:486: warning: ‘snd_pcm_sw_params_set_xfer_align’ is deprecated (declared at /usr/include/alsa/pcm.h:1104) waveout.c:762: warning: ‘snd_pcm_sw_params_set_xfer_align’ is deprecated (declared at /usr/include/alsa/pcm.h:1104) waveout.c:764: warning: ‘snd_pcm_sw_params_set_xrun_mode’ is deprecated (declared at /usr/include/alsa/pcm.h:1101)

2 2

Where does richedit20.dll fit in the to-do list?
by Syam Babu.S May 12, 2008

May 12, 2008

Dear Sir, While installing an application the installation stops for a long while copying ,Richedit20.dll, and finally I get the message cannot copy file may be disk full. I have more than 10 GB free. Can you enlighten me please ? Regards, Syam Babu

2 1

Re: Partial revert of c8bdebd... to fix bug #13093.
by Maarten Lankhorst May 12, 2008

May 12, 2008

Hello Reece, 2008/5/12 Reece Dunn <msclrhd(a)googlemail.com>: > The patch "winealsa: Remove calls to deprecated functions." broke > audio playback on Cepstral SwiftTalker [bug #13093] (may also affect > other text-to-speech software like Dragon Naturally Speaking) when > running on Ubuntu 8.04 with pulseaudio+alsa (but may break on other > platforms). > > This patch reverts two of those lines that are needed to fix this > issue and generate clean WINEDEBUG=+wave,+dsalsa output. It seems the winealsa patch had too much ill side effects I didn't intend to happen, can you rather do a full revert? Cheers, Maarten.

1 0

Re: Lots of regressions in games in last few versions
by Vitaliy Margolen May 12, 2008

May 12, 2008

James McKenzie wrote: > Vitaliy Margolen wrote: >> James McKenzie wrote: >>> Vitaliy Margolen wrote: >>>> Several latest releases introduced lots and lots of regressions to a >>>> point that no games run as-is. Considering that we are at the code >>>> freeze, I'd like to see all patches that cause regressions, and all >>>> patches that depend on them starting from wine-0.9.58 be reverted. >>>> >>>> Also each patch to have a conformance test and statement which games >>>> where tested and what problems were fixed with each patch. >>>> >>>> Bugs: 13120, 13110, 13101, 13086 and on and on and on. >>>> >>>> Can some one explain what's the deal with games not working full >>>> screen? Why are there are of the sudden problems with pixel formats? >>>> Why lots of games crashing ActivatingContext? Why most games don't >>>> work anymore on ATI? >>>> >>>> >>> Ya know there is a way to handle this. Bashing developers is not one >>> of them. Regression testing is. Some of our 'users' are not savvy >>> enough >> Oh really? So how many regression testing do you need to fix say... >> bug 11584 Multiple games crash with stack overflow error? 10? 20? 100 >> (look all the bugs marked as dups of it)? Unless some one actually >> starts fixing the bug, doing regression testing is pointless. Besides >> lots of new regressions have regression testing done on them. >> > There were several 'fixes' to this problem in the issue. And Stephan > continues to troubleshoot the problem. However, this is a VOLUNTEER > effort and most of us have 'real lives' to live. I would gladly work on > rich edit problems as they directly affect a program that I use. > However, I don't have enough hours in the day to attempt to work on > them. I picked up issue 6254, the lockup problem, and a patch proposed There are no patches that fix this problem (however hackish they might be). And it looks like a design problem. That's why someone with knowledge of the d3d needs to look at it. >> I'd like to trust all developers to make right decisions about what >> patches are low risk and which have to be tested with loads of apps. >> But it seems I can't. And no one saying what might break if some patch >> gets committed. And of course I understand that most things can't be >> tested with conformance tests there. But at least a minimum of several >> major titles have to be tested for regressions. >> >> > We need to do serious testing before any release. I lived in the QA Yes everything have to be tested. The business of sending patches that do "the right thing" have to stop. We all know that m$ always does things backwards. And most apps relay on that. > 'arena' for many years. However, we do have limited time and we don't > have all of the resources we'd like to have. Thus, some problems appear > in release code and we have to clean up the mess afterwards. In the No one should be cleaning up mess. There shouldn't be one in the first place. Or if some one got it in, it should be his responsibility to fix it, or get the whole damn thing out. > case of the issue you pointed out, the simple, but incorrect fix, was to > back out the change and then re-introduce it after some major work. > This would have delayed the improvement in framerates for many games and > productivity programs. And I tend to disagree with you there. I can point to number of things that weren't right to begin with. And it was clear right from the start. Yet they still not fixed, because now it's not trivial to fix the introduced problems. Or the whole idea was flowed and have to be redone. And I don't see what's so wrong with having 'git revert' as valid option for any problem patch? If problem is identified and it's not getting fixed before the next release - pull it out. This is the only option with our linear development where we don't have stable and development branches. Vitaliy

4 3

Re: stub implementation of GdipImageGetFrameDimensionsCount and GdipGetImageFlags
by Nikolay Sivov May 12, 2008

May 12, 2008

GdipGetImageFlags is commited today. 2008/5/12 Petr Dlouhý <petr.dlouhy(a)email.cz>: > This is fix for bug 13036 (http://bugs.winehq.org/show_bug.cgi?id=13036) It > allows Faktury 4.1 to start. > > -- > Petr Dlouhý > > >

1 0

Re: Partial revert of c8bdebd... to fix bug #13093.
by Vitaliy Margolen May 12, 2008

May 12, 2008

Reece Dunn wrote: > The patch "winealsa: Remove calls to deprecated functions." broke > audio playback on Cepstral SwiftTalker [bug #13093] (may also affect > other text-to-speech software like Dragon Naturally Speaking) when > running on Ubuntu 8.04 with pulseaudio+alsa (but may break on other > platforms). > > This patch reverts two of those lines that are needed to fix this > issue and generate clean WINEDEBUG=+wave,+dsalsa output. > > - Reece > > Wait a sec. Is the bug present without pulseaudio? Vitaliy.

1 0

Re: stub implementation of GdipImageGetFrameDimensionsCount and GdipGetImageFlags
by Vitaliy Margolen May 12, 2008

May 12, 2008

Petr Dlouhý wrote: > This is fix for bug 13036 > (http://bugs.winehq.org/show_bug.cgi?id=13036) It allows Faktury 4.1 to > start. > > +GpStatus WINGDIPAPI GdipGetImageFlags(GpImage* image, UINT *flags) > +{ > + static int calls; > + > + if(!image || !flags) > + return InvalidParameter; > + > + if(!(calls++)) > + FIXME("not implemented\n"); > + > + return Ok; > +} You need to print paramenters this function is called with. And don't forget include the "magic" word "stub" in the text of the fixme. Also why are you limiting number of printed fixmes? Vitaliy.

1 0

Re: [PATCH 2/2] wined3d: Activate context for the right target in surface_blt_to_drawable.
by Vitaliy Margolen May 12, 2008

May 12, 2008

Alexander Dorofeyev wrote: > > Fixes http://bugs.winehq.org/show_bug.cgi?id=12890 that affects several > games locking front buffer when using readtex RT lock mode. > --- > - ActivateContext(device, device->render_targets[0], CTXUSAGE_BLIT); > + ActivateContext(device, (IWineD3DSurface*)This, CTXUSAGE_BLIT); I think Stefan said something about this not being correct. The blitting is going into the render target not the current surface. In your case if the surface is not the render target, then it's not being properly selected. Vitaliy.

3 3

Re: d3dx9: Texturing functions
by tony.wasserka＠freenet.de May 12, 2008

May 12, 2008

> > So, the first thing I want to make sure is that we redirect the function calls correctly in order > > to reduce double coding. > > This means on the one hand that we should call the Extended versions of each function > > from inside of the simpler ones (most default parameters for the Ex functions are > > on MSDN) and on the other hand that we unify all D3DXCreateTextureFromXXEx > > functions somehow. I don't know how Resources are stored internally, but I guess > > the simplest would be to redirect all of them to D3DXCreateTextureFromFileInMemory, i.e. > > when D3DXCreateTextureFromFile is called we read the file into memory and call the > > InMemory function. I hope this shouldn't be too hard to be applied to the resource function > > either. Of course, this should also be done at the corresponding Surface, Volume and > > cube texture functions. > > Also, I haven't looked too much into it yet, but I guess we could go even a step further > > and define the CreateTextuteFromXX calls like this: > > 1. Redirect to the corresponding D3DXCreateXFromFileInMemoryEx call > > 2. Call D3DXCheckXRequirements > > 3. Call IDirect3DDevice9::CreateTexture > > 4. Lock its surface > > 5. Call LoadSurfaceFromFileEx with it > > > > This would reduce most of our coding work on LoadSurfaceFromFileEx. > > However, there are still plenty of formats supported by the texturing functions > > and thus, plenty of work for us to do. IIRC we once came to the decision to > > use libraries like libpng or so to reduce that work, too, so we'd just need > > to implement formats like .dds. > > I can't remember what the differences are between the CreateTexture and > LoadSurface functions, but this is what I'd do for the LoadSurface functions: > > LoadSurfaceFromMemory (read data with the specified pixel format) > LoadSurfaceFromFileInMemory (parse image format, read actual data into memory) > LoadSurfaceFromFile (open file, read contents into memory) > LoadSurfaceFromResource (open resource, read contents into memory) > LoadSurfaceFromSurface (read image data from a surface) > > This would mean two huge chunks of code: One which parses image formats > (LoadSurfaceFromFileInMemory), and one which handles all the resizing, > conversion, filtering and stuff (LoadSurfaceFromMemory). Sorry that I'm replying that late, I was a bit busy when you wrote the reply and then nearly forgot about it. I'd agree with that design and I'll soon prepare a stub-layout for texture.c for after-code-freeze. However, have you finished the D3DXCheckTextureRequirements code meanwhile so we can start implementing the other functions? Best regards, Tony Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl. http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/i…

1 0

re: Lots of regressions in games in last few versions
by Dan Kegel May 12, 2008

May 12, 2008

Marcel wrote: > i don't even see the point of a 1.0 release at this point in time. > This project has been a work in progress since 15 years. > Why the heck has it been decided to do a 'gold' release *now* anyways? To get lots more people to try it and report bugs, so it can improve faster. And to get the word out about its rapid progress in the last two years. Most people still think Wine can't wipe its nose. Now, for some users, Wine still can't wipe its nose -- it all depends on the app you try. But it seems that "linux wine sucks" pulls only about half as many hits as "linux wine amazing" in a web search, so we must be doing something right lately. - Dan

4 4

Re: Stop flooding with EV_TXEMPTY and EV_RXCHAR
by Vitaliy Margolen May 11, 2008

May 11, 2008

Michael Karcher wrote: > Do not generate an EV_TXEMPTY event if the transmitter is empty, > but if it got empty. Do not generate a EV_RXCHAR event if some > bytes are in the queue, but if some new bytes got into the queue. > Handle a Linux quirk that TIOCGICOUNT might report characters that > TIOCINQ does not yet report. > > Add some further TRACE calls to aid debugging. Please one change at a time (as a separate patch). In case of possible regressions it would be much easier to catch what was the cause. Vitaliy.

1 0

New winetricks 20080511: dotnet11 working again, new verb fontfix
by Dan Kegel May 11, 2008

May 11, 2008

Another week, another winetricks. Changes since last week's annoucement: - dotnet11 now works again. Removed GAC kludge, added font kludges. - new verb fontfix to install working versions of arphic fonts (bad versions crash dotnet 1.1) I haven't looked at whether dotnet20 also needs the font kludges... Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com

1 1

Re: [PATCH] ddraw: Fix some code unprotected by ddraw lock.
by Vitaliy Margolen May 11, 2008

May 11, 2008

Alexander Dorofeyev wrote: > --- > dlls/ddraw/device.c | 24 ++++++++++++++---------- > 1 files changed, 14 insertions(+), 10 deletions(-) > > What is this patch fixing? Do you have tests? Do you have a bug # showing the problem? Please explain why parts of the code needs to be protected? Vitaliy.

2 2

Concerning Bug 11509 (AES Provider Handling for Windows XP)
by Mounir IDRASSI May 10, 2008

May 10, 2008

Hi, >From what I see, the patch correcting this bug from Vijay has been refused because it modifies the name of the RSA and AES provider, which is wrong. However, this patch can be easily changed to keep the current name and simply add a new provider name. So, the declaration of the variable szRSAName should be changed to "static const WCHAR szRSAName[4][66]" and its value appended at the end with the new name of the provider for XP instead of modifying the last field. This way, I'm sure the patch will be accepted. Vijay : can you submit a modified version of your patch. Cheers, Mounir IDRASSI IDRIX - Cryptography And IT Security Experts http://www.idrix.fr

2 1

Wine 1.0 status: rc2 in 12 days, 34 bugs left
by Dan Kegel May 10, 2008

May 10, 2008

Hell is starting to freeze over. A clickable version of the following info is at http://kegel.com/wine/countdown.html Wine is now in a code freeze in preparation for the 1.0 release. According to http://wiki.winehq.org/WineReleasePlan, wine-1.0.0-rc2 will be due out Friday, May 23rd, 2008. It will be something like be the next to last release candidate for 1.0. During the code freeze, patches that * are simple * come with a conformance test * fix a regression * are low risk are more likely to get in than other patches. (Heck, that's always true, but it's even truer during a freeze.) We will actively discourage patches that might endanger a June 1.0 release. Bug Status There are 34 open 1.0 bugs as of 10 May. Most of these will simply be rolled over to be fixed for a later release; we only have time to fix a few, and much as we'd like to fix the rest, most are not showstoppers. Changes since last week (with category and votes): New (!): 13071 quartz 0 Flashplayer crashes in a quartz bug 13115 advapi 0 .net 1.1 installer fails in ControlService() Fixed: 8125 -unknown 0 Marratech 6.1 crashes on start 8783 ntdll 14 USB serial ports do not work 9178 -unknown 8 "hello world" dos program hangs 9356 ntdll 11 Serial communication not working since wine-0.9.33 11420 advapi32 0 service control manager API problem: name of named objects might differ (client vs. service process) Invalid: 12914 tools 1 wineprefixcreate overrides custom entries in Explorer\\Shell Folders Deferred: 2368 winex11. 7 Wine loses its X-Window when switching to another virt. desktop in Fvwm 4523 user32 5 Can't copy from Firefox 1.5 and paste into OpenOffice 2 under Wine 5061 -unknown 6 Copying from Windows Firefox in Wine and pasting to Linux OpenOffice pastes metadata as data 6604 tools 3 Ship icons for the wine-tools that can be used in .desktop files 7372 winex11. 14 can't copy and paste between gnome apps eg openoffice or gimp and wine apps such as dreamweaver or adobe photoshop 7571 gdi32 1 Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5) 9942 ole 3 Powerpoint Viewer 2007 crashes opening .pptx files Here's the full list of current bugs: 13115 advapi 0 .net 1.1 installer fails in ControlService() 2493 comctl32 2 Multi-select listview: Shift-arrow up only selects top two items 11509 crypt32 0 Wordviewer 2003 is unable to open documents encrypted with AES 5535 directx- 20 Planescape:Torment doesn't work 11584 directx- 2 Multiple games crash with stack overflow error 3270 gdi32 16 Problem with minimized top-level windows 6519 gdi32 7 Wine blacks out rotated font bitmap 9771 gdi32 45 Steam Friends doesn't work (fails to render correctly or refresh) 12730 gdi32 1 gdi32: some tests fail when X is run in 16 bit mode, but not 32 bit 5024 kernel32 5 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 10147 msi 2 Word Viewer 2003 - Tab behavior differs from Windows 12263 opengl 3 Sketchup Cannot initialize OpenGL - ChoosePixelFormat fails 5926 programs 1 Wine does not provide an implementation of winhlp32.exe 10288 programs 0 wine_gecko download hangs sometimes 13071 quartz 0 Flashplayer crashes in a quartz bug 5163 setupapi 14 Office XP 2002 crashes on installation 6095 shdocvw 16 MOTD in counter-strike 1.6 and counter-strike source does not render 8898 shdocvw 1 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 8439 shell32 10 Visual Studio .NET (7) install fails 11742 shlwapi 9 Small .net 1.1 app (FastMD5 1.3) fails to start up 12074 testcase 3 The conformance tests fail on Windows 5402 -unknown 0 Trying to run PhotoStitch 3.1 5844 -unknown 16 tray minimize 5948 -unknown 2 Star Trek: Armada does not install 7404 -unknown 3 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 9916 -unknown 6 "make test" usually fails 11281 -unknown 5 CJK input many issues 12097 -unknown 3 Wine 1.0 should not ship out-of-sync resource translations 12246 -unknown 2 "make test" gives different results with and without warn+heap 664 user32 8 The help menu functionality inside programs is broken (messaging problem) 3023 user32 6 Orcad - "Place Part" never tries to put down a part 124 wineserv 2 Review of Wine Server Protocol 9787 winsock 63 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 12005 wintab32 2 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

1 0

VB6 and wine_get_unix_file_name
by Escuder Nicolas May 10, 2008

May 10, 2008

Hello, I'm trying to make a function for using wine_get_unix_file_name in VB6 programs. Private Declare Function lstrcpyA Lib "kernel32.dll" (ByVal lpString1 As String, ByVal lpString2 As Long) As Long Public Declare Function GetProcessHeap Lib "kernel32" () As Long Public Declare Function HeapFree Lib "kernel32" (ByVal hHeap As Long, ByVal dwFlags As Long, IpMem As Any) As Long Public Declare Function wine_get_unix_file_name Lib "kernel32" (ByVal lpszSrc As String) As Long Public Function GetUnixPath(ByVal sPath As String) As String Dim ptr As Long Dim sBuffer As String * 255 ptr = wine_get_unix_file_name(StrConv(sPath, vbUnicode)) lstrcpyA sBuffer, ptr HeapFree GetProcessHeap(), 0, ByVal ptr GetUnixPath = sBuffer End Function Sub Main() UnixPath = GetUnixPath() MsgBox UnixPath End usb When running this code I got a blank msgbox can anyone help me please. See you. Escuder Nicolas

2 1

Re bug #8132
by Andrew Talbot May 10, 2008

May 10, 2008

I have marked this bug as fixed, because Alex has written some patches that, indeed, fix it. But these will be held back until after the code freeze, so the bug is still actually present in the current code. Would it be preferable to reopen it, therefore, until the patches are actually applied? Thanks, -- Andy.

3 2

Re: shdocvw: Use array syntax with array elements (Try 2)
by Jacek Caban May 10, 2008

May 10, 2008

Andrew Talbot wrote: > Including some instances that I left out, earlier. > > -- Andy. > --- > Changelog: > shdocvw: Use array syntax with array elements. > Why? Both syntaxes are correct, so it's a matter of style preferences. I prefer the style I use and I don't see any reason to change it. Jacek

2 1

CreateProcess and retrieving stdout and stderr from unix program
by Escuder Nicolas May 10, 2008

May 10, 2008

Hello, Is there a way to retrieve stdout and stderr when lauching unix program with CreateProcess. At this thime I can only get stdout / stderr from windows programs. See You Escuder Nicolas

1 0

Bugs in Wine research
by tomecek＠cs.aau.dk May 10, 2008

May 10, 2008

Hi, we are students from Department of computer science at Aalborg university. During this semester we were working on project on static analysis using the Coccinelle tool (http://www.emn.fr/x-info/coccinelle/) and Flawfinder (http://en.wikipedia.org/wiki/Flawfinder) We decided to search for bugs in Wine source code. Our aim was to find as many bugs in Wine source code as possible but on the other hand to find real and dangerous ones. We solved some of the Janitorial projects and beside that we searched for common bugs. We decided to deal with 2 of Janitorial Projects: Ignored return values and Memory leaks. Beside that searched for memory allocation without NULL checking. Then we ran some more scripts searching for not unlocking memory objects after locking them and searching for untested file descriptors. We also ran two tests looking for not dangerous problems: searching for unused variables and searching for pointers comparison to 0 instead of NULL. All the test were run on Wine 0.9.57 version. In http://www.cs.aau.dk/~tomecek/scripts.tar.gz we present the list of the most obvious bugs in 'diff' format and Coccinelle 'cocci' scripts in Semantic Patch Language (SmPL) used for bug searching. * Ignored return variables We found 115 function callings without checking the returned value which we considered to be possibly dangerous. In many cases we think that the behaviour could be dangerous but we need some information about the code. In 'ignored_return_values.diff' we present some examples of code where the returned value should not be ignored but it is so. * Unused variables This was one of the Janitorial Projects. This issue is not dangerous but it helps to clean the code and make it more readable. All of the variables could be removed using \textit{diff} file. We found 18 matches and all of them were true positives. Beside that we find some possible security bug with 'Flawfinder'. Here is the output: wine-0.9.57/programs/taskmgr/perfdata.c:292: [4] (access) ImpersonateLoggedOnUser: If this call fails, the program could fail to drop heightened privileges. Make sure the return value is checked, and do not continue if a failure is reported. * NULL comparison Sometimes developers use comparison of pointers to zero instead of NULL. This is not critical bug but the \textit{gcc} compiler warns against such using. In this case we were able to change all the zero comparison to NULL variant using Coccinelle. We found 176 matches and all of them were corrected automatically. * Memory allocation Using both functions for memory allocation - 'malloc' and 'HeapAlloc' - requires NULL checking of the returned value to be sure that the allocation was done correctly. We matched 598 possible bugs. In 'memAlloc.diff' we send to you 10 examples of bugs we have found. * Memory leaks This searching was part of one of the Janitorial Projects. We were looking for memory allocations where the pointer to the allocated memory is lost or forgotten without freeing the memory. We matched 13 of them as true positives. In 'memLeaks.diff' we send to you 5 examples of most obvious problems. * Object locking We were searching for locking object with 'GlobalLock()' without 'GlobalUnLock()' for unlocking. If the object was locked then it has to be unlocked to prevent deadlocks when some process or thread is waiting for unlocking of this object. We have 2 true positives. * Descriptors In this test we were looking for unchecked descriptors returned by fopen(), fdopen(), freopen(), open(), creat() and pipe() or for wrong check of this descriptors. fopen(), fdopen() and freopen() functions return in the case of failure 0 but the rest of these functions return -1. Sometimes programmers use it in wrong way and sometimes they do not check it anyway. We matched 3 wrong usings. If you are interested in our work or if you want the full list of bugs we found let us know. Regards, Bertrand Dechoux, Youenn Corre, Jaroslav Tomecek ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program.

1 0

Another app bundled with Wine: Navicat
by Dan Kegel May 9, 2008

May 9, 2008

http://navicat.com ships a Linux version which is based on Wine from late 2007 and the Picasa wrapper scripts. One more case study for http://kegel.com/wine/isv ... And users are, as usual, confused about whether they need to install Wine to run navicat. See e.g. http://ubuntuforums.org/showthread.php?t=670282 (Installing Wine may actually helped there, because he's on a 64 bit machine, and using aptitude to install wine brought in dependencies that also made Navicat's wine happy.)

1 0

Fixing wintab window messaging, bug 11846. Requesting review
by John Klehm May 9, 2008

May 9, 2008

Hey, Well I'm trying to nail down why sai paint tool isn't doing its pressure stuff and I think this is starting down the right track but I wanted to get some input from those more familiar with wine messaging and x11 events. Without the first patch sai can't find an x11 window to attach too and doesn't have any shot at all at getting pressure events from x11. After that patch is applied it attaches to an x11 window but then doesn't pass the information back to the child window that the wintab context was created in. The second patch implements an EnumChildWindows callback function in order to get it back to the child window. I'm asking for this review as while the above works to get the pressure events flowing I'm not sure if its the appropriate way to go. I believe these patches are on the path to fix http://bugs.winehq.org/show_bug.cgi?id=11846 Thanks, John Klehm

1 0

Re: [1/3] gdiplus: GdipGetImageFlags (bug 12144)
by Maarten Lankhorst May 8, 2008

May 8, 2008

Hello Nikolay, 2008/5/8 Nikolay Sivov <bunglehead(a)gmail.com>: > Maarten Lankhorst wrote: >> >> Hello Nikolay, >> >> 2008/5/8 Nikolay Sivov <bunglehead(a)gmail.com>: >> >>> >>> Changelog: >>> - simple implementation of GdipGetImageFlags >>> >>> --- >>> dlls/gdiplus/gdiplus.spec | 2 +- >>> dlls/gdiplus/gdiplus_private.h | 1 + >>> dlls/gdiplus/image.c | 11 +++++++++++ >>> include/gdiplusenums.h | 25 ++++++++++++++++++++++--- >>> include/gdiplusflat.h | 1 + >>> 5 files changed, 36 insertions(+), 4 deletions(-) >>> >> >> It's better to send changes to the wine headers in wine/include/ >> separately, and to add accompanying testcases when adding new >> functions. This allows us to verify changes more easy. It's a bit more >> work in the short run, but saves time in the long run. >> >> Cheers, >> Maarten. >> >> > > You're right of course (about tests). But it isn't that case: > GdipGetImageFlags just get a member, no more than a return. > So test for it is a redundant (at actual level of gdiplus.dll > implementation). You can still see what happens if you pass it null as argument, what flags are invalid, etc. Cheers, Maarten.

1 0

Re: [3/3] gdiplus: GdipCreateFromHWNDICM (bug 12185)
by Juan Lang May 8, 2008

May 8, 2008

You appear to have sent the wrong patch for this one. --Juan

1 0

Re: [1/3] gdiplus: GdipGetImageFlags (bug 12144)
by Maarten Lankhorst May 8, 2008

May 8, 2008

Hello Nikolay, 2008/5/8 Nikolay Sivov <bunglehead(a)gmail.com>: > Changelog: > - simple implementation of GdipGetImageFlags > > --- > dlls/gdiplus/gdiplus.spec | 2 +- > dlls/gdiplus/gdiplus_private.h | 1 + > dlls/gdiplus/image.c | 11 +++++++++++ > include/gdiplusenums.h | 25 ++++++++++++++++++++++--- > include/gdiplusflat.h | 1 + > 5 files changed, 36 insertions(+), 4 deletions(-) It's better to send changes to the wine headers in wine/include/ separately, and to add accompanying testcases when adding new functions. This allows us to verify changes more easy. It's a bit more work in the short run, but saves time in the long run. Cheers, Maarten.

1 0

Re: inetmib1(0/15)
by Maarten Lankhorst May 8, 2008

May 8, 2008

Hello Juan, 2008/5/8 Juan Lang <juan.lang(a)gmail.com>: > This series of patches implements the inetmib1 dll, mainly to fix bug 13004. I don't see any testcases? With the code freeze I think it is best to add them since it will have more chance of getting accepted. I don't know if it's a good idea otherwise to add code at this point in code freeze. Cheers, Maarten.

2 1

Re: ntdll: Fix RtlIntegerToUnicodeString so it won't overflow
by Alexandre Julliard May 8, 2008

May 8, 2008

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes: > @@ -1970,7 +1970,7 @@ NTSTATUS WINAPI RtlIntegerToUnicodeString( > } while (value != 0L); > > str->Length = (&buffer[32] - pos) * sizeof(WCHAR); > - if (str->Length >= str->MaximumLength) { > + if (str->Length + sizeof(WCHAR) >= str->MaximumLength) { > return STATUS_BUFFER_OVERFLOW; > } else { > memcpy(str->Buffer, pos, str->Length + sizeof(WCHAR)); There's no overflow here. The Windows implementation of RtlIntegerToUnicodeString seems badly confused but I don't think we need to replicate those bugs. -- Alexandre Julliard julliard(a)winehq.org

3 3

re: ntdll: Fix RtlIntegerToUnicodeString so it won't overflow
by Dan Kegel May 8, 2008

May 8, 2008

James wrote: > > It copies str->Length + sizeof(WCHAR) to the destination buffer > > according to james' testcases. > > No, the length is indeterminate. Oh, is that the test that checks whether not double-null terminating works? I think that test needs rewriting to be determinate... e.g. by putting in a list that has known bad (but properly terminated) elements after the nominal end, and making sure the bad part doesn't get processed... or something...

2 1

Re: [PATCH] cmd.exe: MSI packages execution implemented
by Vitaliy Margolen May 8, 2008

May 8, 2008

Vitaly Perov wrote: > Changelog: cmd.exe: MSI packages execution implemented > > > That doesn't look right. You sure this information is hard-coded into cmd.exe and it's not coming from the registry CLASSES hive? Vitaliy

3 2

winetest reports shows a lot of "debugger.c:185:debugger: done debugging..."
by Paul Vriens May 8, 2008

May 8, 2008

Hi, On test.winehq.org one can see that both the W98 and the NT4 reports show a lot of the mentioned lines. For example : http://test.winehq.org/data/200805081000/95_W95/report Any idea where these are coming from? They weren't there before (AFAIK). -- Cheers, Paul.

2 1

Review request: real async for GetAsyncKeyState (bug #5623)
by Rafał Miłecki May 8, 2008

May 8, 2008

Hi, This is my first wine patch and fix for bug #5623. This was tested and works fine however I suspect this is not clean enought for commiting to master. Would be nice if you could review this and tell me what sould be done better (and how?). This patch adds new variable: BYTE global_key_state_table[256]; to wineserver and two new entries in protocol: /* Get global key state */ @REQ(get_global_key_state) int key; /* key */ @REPLY BYTE value; /* status of key */ @END /* Set global key state */ @REQ(set_global_key_state) int key; /* key */ BYTE value; /* status for key */ @END That allows me to keep current *global* state of keyboard. Of course this will works only for wine windows from current wineserver. This was discussed in bug report and it is fine for reported applications. The last think I done is using wineserver in X11DRV_send_keyboard_input -- Rafał Miłecki

2 2

re: winetricks missing MFC42
by Dan Kegel May 8, 2008

May 8, 2008

Cesar wrote: > I see that MFC42 is missing on wine tricks. Nope! It's installed by the vcrun6 verb: echo " vcrun6 vc6redist from VS6sp4 (mfc42, msvcp60, msvcrt)" I've been considering making it more obvious. > There's a cab available from: > http://activex.microsoft.com/controls/vc/mfc42.cab Thanks, nice to have an alternate source.

4 5

Re: mlang: Fix some more tests to pass under windows, try 2
by Dmitry Timoshkov May 8, 2008

May 8, 2008

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > It disallows certain conversions now. Please don't commit this and other mlang related patches, they are wrong. Maarten, if your only intent is to show clean results under test.winehq.org that's not worth an effort without at least understanding why the test fails and what might be a proper fix for each failure. -- Dmitry.

1 0

Should winedevice.exe in the end be able to load file system drivers as well?
by Paul Vriens May 8, 2008

May 8, 2008

Hi, The comment in winedevice.exe says "Service process to load a kernel driver". But will winedevice.exe in the (far ?) future be the vehicle to load file system drivers as well. -- Cheers, Paul.

2 2