May 2008 - Wine-Devel - list.winehq.org

Re: winex11: BitBlt returns TRUE when drawing outside of the clipping or visible region.
by Vitaliy Margolen May 26, 2008

May 26, 2008

Sergey Khodych wrote: > > Please add a test for this.

1 0

winex11: BitBlt returns TRUE when drawing outside of the clipping or visible region.
by Sergey Khodych May 26, 2008

May 26, 2008

1 0

How to phrase Wine's success rate
by Dan Kegel May 25, 2008

May 25, 2008

When making announcements about Wine 1.0, it's useful to include an objective measure of how well it works for the average app, one that correctly conveys both Wine's promise and its limitations. Our current appdb stats are: Platinum 1500 Gold 1763 Silver 1194 Bronze 1071 Garbage 2512 That's 19% platinum and 41% gold-or-platinum. (Given rating inflation, we probably shouldn't claim that silver or below means "working" for the average person.) How about: "Of the apps we have tested with Wine, about 20% work well, and about another 20% work but have some glitches." That assumes we don't have too many regressions. It'd be nice if the appdb could give finer grained summaries, e.g. counts of apps that had actually been tested with wine-1.0rc*. - Dan

8 11

Re: avifil32/tests: [2/2] Add a test for AVISaveOptions and fix thedetected crash
by Dmitry Timoshkov May 25, 2008

May 25, 2008

"Detlef Riekenberg" <wine.dev(a)web.de> wrote: > - for (; nStreams > 0; nStreams--) { > + for (nStreams--; nStreams >= 0; nStreams--) { > if (ppOptions[nStreams] != NULL) { > ppOptions[nStreams]->dwFlags &= ~AVICOMPRESSF_VALID; Shouldn't this be for (nStreams - 1; nStreams >= 0; nStreams--) { instead? -- Dmitry.

2 1

Suggestions for AppDB/comment system
by doc May 25, 2008

May 25, 2008

Currently the replied comments require loading another page. I would like to suggest making the comment load in the same page using some javascript/ajax. I would submit a patch to do this, but I notice the appdb webpage is not being version controlled (as far as I can tell). So another suggestion I have is to put AppDB code into git :) I am also forwarding this to appdb(a)winehq.org but would like other peoples input.

2 2

Removinig CVS/GIT version from bugzilla
by Vitaliy Margolen May 25, 2008

May 25, 2008

I'm copying my response here to continue the conversation. Please don't remove cvs/git version. What should be done is: 1. Leave old bugs alone or modify them case-by-case 2. All bugs with "cvs/git" version from now on can be filed on the development branch between releases only. 3. After the next release, if the bug is still present, modify version to that release. Of course no modifying of old bugs. Vitaliy.

4 5

winetest failure summary for 1.0rc2
by Dan Kegel May 25, 2008

May 25, 2008

Wow, lots of people submitted test results for 1.0rc2 already! I ran my skipgood filter on it, put the digested data up at http://kegel.com/wine/failing-1.0-rc2.html and added a little analysis to http://wiki.winehq.org/MakeTestFailures To wit: -- snip --- Tests that fail on most versions of Windows As of 1.0-rc2, the following tests all fail on 2000, XP, 2003, and Vista: comctl32:listview ddraw:d3d gdi32:metafile kernel32:toolhelp mshtml:htmldoc oleaut32:olefont and a bunch more fail on most of those versions of Windows. See http://kegel.com/wine/failing-1.0-rc2.html for the full data. Most Common Failures on XP As of 1.0-rc2, the following tests fail on all machines running XP: comctl32:listview ddraw:d3d gdi32:metafile kernel32:actctx kernel32:toolhelp mshtml:htmldoc msvcrt:cpp oleaut32:olefont urlmon:url user32:input user32:listbox user32:msg and a whole mess fail for nearly all reporters. See http://kegel.com/wine/failing-1.0-rc2.html for the full data. Most Common Failures on Wine As of 1.0-rc2, here are the tests that fail on some Wine systems, and how many people they fail for: 14 user32:msg 12 user32:win 9 user32:input 6 dsound:ds3d dsound:ds3d8 kernel32:path user32:monitor 5 kernel32:process msi:install msi:package riched20:editor 4 comctl32:listview ddraw:visual dinput:device gdi32:font gdi32:metafile kernel32:profile kernel32:sync kernel32:virtual snmpapi:util urlmon:protocol user32:class wininet:internet 3 comctl32:monthcal ddraw:d3d kernel32:volume msi:msi setupapi:devinst shell32:shlfolder user32:menu userenv:userenv 2 advapi32:registry advapi32:security advapi32:service comctl32:tooltips d3d8:visual d3d9:visual ddraw:dsurface dsound:dsound kernel32:version msvcrt:time ntdll:exception psapi:psapi_main qedit:mediadet 1 advpack:advpack advpack:install ...[many deleted]... wininet:http winmm:wave winspool.drv:info Whew, that's a lot of data. I looked at all the ones that failed for five or more people: user32:msg, user32:win, and user32:input are probably people running non-blessed window managers; Alexandre's position is that we can ignore these, since upstream gnome's WM is fixed. dsound:ds3d is mostly "ds3d.c:891: Test failed: The primary volume changed from -27 to -960" (worrisome, random) plus "ds3d.c:896: Test failed: The primary pan changed from -5594 to -5595" (rounding error, just add slop of 1?). dsound:ds3d8 is the same. kernel32:path is mostly "path.c:899:TMP=c:\windows\temp"..."path.c:1178: Test failed: expected buf[0] upper case letter got c", probably people whose ~/.wine is old and has a windir that starts with a lowercase drive letter?! Has that changed recently? msi:install is mostly "install.c:4414: Test failed: File installed". msi:package is mostly "package.c:1661: Test failed: wrong return val (0)" riched20:editor has several failures. --- snip ---

6 8

Regression in wined3d: Add read_from_framebuffer_texture which combines code from read_from_framebuffer (drawpixels) and LoadLocation.
by Markus May 25, 2008

May 25, 2008

Hi, after investigating reports for the game 'World in Conflict', I identified the following patch to cause the game graphics to freeze (ambient sounds are still played though): ---- ba90a740beb9ce9a839cc843db8d87f5a37becdd is first bad commit commit ba90a740beb9ce9a839cc843db8d87f5a37becdd Author: Roderick Colenbrander <thunderbird2k(a)gmx.net> Date: Sun Feb 10 22:20:15 2008 +0100 wined3d: Add read_from_framebuffer_texture which combines code from read_from_framebuffer (drawpixels) and LoadLocation. This makes the code easier to read and the pieces borrowed from read_from_framebuffer are more correct than the code in LoadLocation. :040000 040000 74e4bdc73e367c8f38cd3d0818df0fc86eb788bf 3e54409be7c9d2964efbf3d3c2f3d3b84a267047 M dlls ---- The freezes only seem to occur if the native (Windows) dxdiagn.dll is used, as it lets the game properly detect the graphics card and thus enables additional graphics options (highend shaders, high-res textures, etc.). Apparently the freeze is only triggered with these options active. The game uses events in its drawing code and ("always") hangs after the following output: fixme:d3d9:D3DPERF_BeginEvent (color 0xffffffff, name L"Update verlet cloth") : stub fixme:d3d9:D3DPERF_EndEvent (void) : stub At one point, it was followed by this error: err:d3d_surface:surface_prepare_system_memory Surface without memory or pbo has SFLAG_INSYSMEM set! The point of the freeze appears to depend on many factors. If I move the camera around, it appears to freeze earlier than just letting the game run (e.g. a replay of a match). But once the patch is excluded, the game no longer freezes. If more info is needed, please specify how I can obtain it. -- Markus

3 2

winetest for 1.0rc2 - small post-run error message
by Susan Cragin May 25, 2008

May 25, 2008

Network transfer: Done (1116026 of 1116026) Finished susan(a)ubuntu:~/wine-git/programs/winetest$ fixme:ntdll:RtlNtStatusToDosErrorNoTeb no mapping for 8000000a susan(a)ubuntu:~/wine-git/programs/winetest$

1 0

Readme: Updates needed
by Austin English May 25, 2008

May 25, 2008

Alexandre committed a few fixed to the README today, but I still see a few things that may need fixing: ./tool/wineinstall - Has been mentioned to be deprecated a few times in bugzilla. If it's deprecated, we need to remove it. If not, we need to fix whatever it's doing wrong and stop discouraging its use. 3. REQUIREMENTS Linux version 2.0.36 or above FreeBSD 6.2 or later Solaris x86 2.5 or later NetBSD-current Mac OS X 10.4 or later Need to check these versions. FreeBSD should be 6.3, with patches, or preferably 7.0. Others, I don't know. Lastly, the translated READMEs under /documentation likely need _a lot_ of work. Those of you that are bilingual might take a stab at it... There were a couple other minor things that I've sent a patch for: urls lacking trailing backslash, mentioning version .9 instead of 1.0, using solitare as an example program (which we don't include, so I replaced with notepad), etc. -Austin

4 3

Re: msi: fix tab order
by James Hawkins May 25, 2008

May 25, 2008

On Sat, May 24, 2008 at 7:10 PM, Dan Kegel <dank(a)kegel.com> wrote: > When you press Tab in an msi dialog, focus moves the wrong way. > You can confirm the correct tab order by viewing the msi > file in Orca and looking at the Dialog and Control tables. > > It seems that tab order in user32 is equal to z order, > and SetWindowPos() is the function used to control both. > Our msi currently seems to get the first two args backwards; > reversing them fixes http://bugs.winehq.org/show_bug.cgi?id=10147 > and at least superficially makes more sense. > This change is wrong and breaks tab order in (at least) the office installer. -- James Hawkins

1 0

Re: [5/5] d3d9: Test our texop implementation
by Stefan Dösinger May 24, 2008

May 24, 2008

Am Samstag, 24. Mai 2008 10:33:42 schrieb H. Verbeet: > The color_match() function which this test introduces should be used > for the other visual tests that require an approximate match as well, > but doing this is outside the scope of this patch. Dan recently added color_near() for this purpose. Is there any difference between the functions(I see that yours passes the hardcoded slop as a parameter). Do you have any preference towards any implementation? I'm inclined to use yours because of the additional parameter and the better checking with abs()

2 1

Re: RFC: comctl32 indentations
by Hin-Tak Leung May 24, 2008

May 24, 2008

Andrew Talbot wrote: <snipped> > If, in this case, it turns out that the braces should be added, and doing so > would fix some longstanding bug with Photoshop CS2, say, then I doubt that > too many people would accuse me of having wasted their time. This is still a waste of time - I am not going to talk about 'what if's'. Show me the code and show you that you are right. Don't try to tell me that you 'may be' right.

1 0

Re: crypt32: CertComparePublicKeyInfo must ignore the leading zero
by Juan Lang May 24, 2008

May 24, 2008

This one's bugged me for ages, but I never tracked it down. Thanks! --Juan

1 0

Adding d3d9x_xx dlls to winetricks?
by Dan Kegel May 24, 2008

May 24, 2008

So... lots of people are going around installing all of directx, and maybe all they needed was, say, d3d9x_35. That's not good. This sounds like a job for winetricks! But I know nothing about direct3d. Could somebody have a look at this draft and see if it suffices? All I added was d3d9x_35 and d3d9x_36, is that the right set?

7 13

Re: wininet: Make resolving hostnames thread safe.
by Rob Shearman May 24, 2008

May 24, 2008

2008/5/19 Hans Leidekker <hans(a)it.vu.nl>: > @@ -151,7 +158,21 @@ BOOL GetAddress(LPCWSTR lpszServerName, INTERNET_PORT nServerPort, > name = HeapAlloc(GetProcessHeap(), 0, sz+1); > WideCharToMultiByte( CP_UNIXCP, 0, lpszServerName, len, name, sz, NULL, NULL ); > name[sz] = 0; > + > +#ifdef HAVE_LINUX_GETHOSTBYNAME_R_6 > + phe = NULL; > + buf = HeapAlloc(GetProcessHeap(), 0, bufsize); > + while (buf) > + { > + int res = gethostbyname_r(name, &hostentry, buf, bufsize, &phe, &locerr); > + if (res != ERANGE) break; > + bufsize *= 2; > + buf = HeapReAlloc(GetProcessHeap(), 0, buf, bufsize); > + } > + HeapFree(GetProcessHeap(), 0, buf); > +#else > phe = gethostbyname(name); > +#endif In the long term it would be better to use getaddrinfo instead of gethostbyname/gethostbyname_r, but that's too big a change for 1.0. Rob

2 1

Re: ddraw: [3/3] Fix for regression bug #13277
by Stefan Dösinger May 24, 2008

May 24, 2008

> + ref = getRefcount(lpDD); > + ok(ref == 1, "Got refcount %ld, expected 2\n", ref); > + > + IDirectDraw_Release(lpDD); > + > + ref = getRefcount(lpDD); > + ok(ref == 0, "Got refcount %ld, expected 1\n", ref); I think there's a copypaste error, it seems you forgot to adjust the error string. Your test shows the correctness of the patch pretty well, although out of curiosity, can you try this: Between the IDirectDraw_Release(), which reduces the refcount to 0 and the ref = getRefcount(), can you try to HeapAlloc() small portions(e.g. 512 bytes) of memory with HEAP_ZERO_MEMORY until you get an out of memory error. This should make it less likely that the lpDD object survives by luck. It might be destroyed by windows, but the memory is not yet overwritten by something else, so the getRefcount works by luck. If this does not lead to a crash, try the memory allocation + getRefcount again after the Surface::Release call below, there it should cause a crash. > @@ -1998,6 +2026,13 @@ IDirectDrawImpl_CreateNewSurface(IDirectDrawImpl *This, > InterlockedIncrement(&This->surfaces); > list_add_head(&This->surface_list, &(*ppSurf)->surface_list_entry); > > + IDirectDrawInternal_AddRef(This); > @@ -424,6 +424,9 @@ IDirectDrawSurfaceImpl_Release(IDirectDrawSurface7 *iface) > /* Reduce the ddraw refcount */ > if(ifaceToRelease) IUnknown_Release(ifaceToRelease); > LeaveCriticalSection(&ddraw_cs); > + > + /* Surface does not need ddraw anymore, release it's reference */ > + IDirectDrawInternal_Release(ddraw); The counterpart to IDirectDrawImpl_CreateNewSurface is IDirectDrawSurfaceImpl_Destroy, not _Release. CreateNewSurface is called for each complex sublevel surface(e.g. front+backbuffer if they are created via DDSC_COMPLEX), while IDirectDrawSurface::Release must be called only for the root surface(ie, the pointer returned from IDirectDraw::CreateSurface). That means you have to move the IDirectDrawInternal_Release into IDirectDrawSurfaceImpl_Destroy, otherwise there's a reference leak.

2 1

Re: rpcrt4: Skip client tests if the server isn't listening
by Rob Shearman May 24, 2008

May 24, 2008

2008/5/23 Maarten Lankhorst <m.b.lankhorst(a)gmail.com>: > --- > > *Don't apply, breaks tests* > > Rob: Is there anything wrong with this patch apart from the fact it > stops the tests from running in wine due to a failure? Would it > prevent windows failures? > > Ideally I would make our RpcMgmtIsServerListening return RPC_S_OK, but > I don't know the code so I'm afraid to make changes like this. Please give me links to test data that shows this happening and I'll try to figure out why the client isn't able to talk to the client. Rob

1 0

RFC: comctl32 indentations
by Andrew Talbot May 24, 2008

May 24, 2008

Hi, In toolbar.c:TOOLBAR_Destroy(), should the "if" statement at line 5439 be compound to match the indentation, or should the three invocations of TOOLBAR_DeleteImageList() be outdented? treeview.c: In TREEVIEW_DeleteItem(), how conditional is the call of TREEVIEW_SetFirstVisible() at line 1539? I'm guessing that the simple "if" statement at line 3045 just requires indenting(?) If the forum is the wrong place to raise this sort of query, please forgive and advise. :) Thanks, -- Andy.

2 2

Can I do this in WINE?
by Bret Comstock Waldow May 24, 2008

May 24, 2008

I have a Tablet PC, running Kubuntu, and I have just released a project on sourceforge to allow me to use the Microsoft hand writing recognition. The current approach uses a .NET server in IIS running on Tablet XP to provide the recognition. I would prefer to write a classic Windows program that accepts the polyline ink strokes, accesses the Tablet SDK & .dlls to recognize ink, and run that program in WINE directly in Linux without IIS and network connections. I'm thinking of my legal dual-boot installation, and reaching over with WINE to run the app just as I run Notepad from the Windows install now. I'm a Java programmer by day, and I haven't programmed Windows COM before (much). I'd like comments and advice (even help) on doing this. All of this message is written by hand in Linux using the SHIP project (except copying and pasting this URL): https://sourceforge.net/projects/ship-project/ Thanks in advance for information, bret

5 14

New winetricks 20080523: directx9, bugfixes
by Dan Kegel May 23, 2008

May 23, 2008

Another week, another winetricks. Changes since May 19's wine-devel annoucement: r52: - rotate sourceforge mirrors to avoid getting stuck on bad one - cope with users who rename c:/windows/Fonts to c:/windows/fonts - more conservative advice on sha1sum mismatches - handle bad exit status from /usr/bin/which on mac - cope with redhat.com sending decompressed files - use win2K when installing directx9 so it installs more stuff r50: - Added directx9 verb Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com

1 0

Proposed indentation fixes
by Andrew Talbot May 23, 2008

May 23, 2008

Hi All, I'm intending to "correct" some indentation anomalies, and I propose to do this in an "indiscriminate" way. In other words, I would set the indentation to match what the code does now, without any interpretation of what may have been intended. This means that something like if (a) b; c; would become 1) if (a) b; c; rather than 2) if (a) { b; c; } The advantages are that the code is "honest" and the existing behaviour is preserved. The disadvantages are that if (2) were intended, it won't be achieved here, and the corrected version will no longer "suggest" what was really intended. Is this "automatic" method still the way to go? Thanks, -- Andy.

2 2

unknown device issues after running winetest
by Paul Vriens May 23, 2008

May 23, 2008

Hi, On several windows boxes (VMware) I receive this nice message that Windows will try to find a driver for an unknown device. This device is added by the setupapi/devinst test and is not (or can't be?) properly removed after the tests. On NT/W2K I'm able to delete all the relevant registry keys (regedt32.exe) but on Vista I don't seem to be able to delete them Any idea? Do others have the same issue(s) ? -- Cheers, Paul.

5 30

Re: ddraw: Fixed in part regression bug #13277, retry
by Stefan Dösinger May 23, 2008

May 23, 2008

Please send test and patch in one patch file, or send them in different emails if a combined patch is too big(which surely isn't the case here)

1 0

rpcrt4 test failures
by Maarten Lankhorst May 23, 2008

May 23, 2008

Hi Rob, I roughly found the reason of the rpcrt4:server test crashing for me. It crashes when it's trying to connect to localhost through the rpc 'tcp' transport. The crash is likely caused because it can't connect to the locally hosted test server the tcp way, and decides to bomb out instead. However it won't say it failed to connect, instead it crashes on the first test-case that uses rpc. I would rather not have the test crash, that would also obscure the possibility of running the other tests in that file. However I don't know why it fails to connect over tcp (netbios works fine). I disabled my firewall entirely, so it shouldn't be the cause of this failure. Could there be other restrictions in place? Cheers, Maarten

1 0