May 2008 - Wine-Devel - list.winehq.org

Re: mlang: Make mlang tests pass under windows
by Dmitry Timoshkov May 8, 2008

May 8, 2008

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > + /* Not all codepages can be converted to UTF-8 */ > + if (cpinfo[i].uiCodePage == 20127 || cpinfo[i].uiCodePage == 28591 || cpinfo[i].uiCodePage == 28605) > + expected = S_FALSE; The statement above is not true. The reason for mlang test failures is that apparently mlang in Windows has its own idea of supported locales not connected to real kernel32 implementation. I'd leave the tests as they are, there is nothing wrong in them, we can't fix Windows bugs. -- Dmitry.

2 2

Bison 2.1 / Solaris
by Austin English May 8, 2008

May 8, 2008

Howdy, Tried compiling wine on Nexenta (Opensolaris kernel with GNU userland). Trying to test out the conformance test, but can't get it to compile: make[2]: Entering directory `/export/home/austin/wine/libs/wpp' gcc -c -I. -I. -I../../include -I../../include -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o preproc.o preproc.c gcc -c -I. -I. -I../../include -I../../include -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o wpp.o wpp.c bison -p ppy_ -o ppy.tab.c -d ppy.y make[2]: *** [ppy.tab.h] Broken Pipe make[2]: Leaving directory `/export/home/austin/wine/libs/wpp' make[1]: *** [wpp] Error 2 make[1]: Leaving directory `/export/home/austin/wine/libs' make: *** [libs] Error 2 austin(a)nexenta:~/wine$ bison --version bison (GNU Bison) 2.1 Looking at my feisty box, looks like it's using 2.3. Anyone had similar troubles getting wine to compile in 2.1? Google's not turning up much, aside from saying get it precompiled... -Austin

3 2

Re: wininet: Deal with bogus accept types array passed into HttpOpenRequestA.
by Maarten Lankhorst May 7, 2008

May 7, 2008

Hoi Hans 2008/5/7 Hans Leidekker <hans(a)it.vu.nl>: > > The bug reporting agent in Google Sketchup passes an accept types > array that includes a wild pointer and a pointer to an empty string, > both of which are ignored by Windows. Although the wild pointer changed > between a number of tries its high word remained unset, so we may get > away with a check on the high word instead of an exception handler. > > Fixes http://bugs.winehq.org/show_bug.cgi?id=11954 > > -Hans This test fails on xp for me, can you fix it? http.c:1767: Test failed: got ', */*, %p, , */*' expected '*/*, %p, */*' Cheers, Maarten.

1 0

Re: SOC 2008 Projects Announced
by Dylan Smith May 7, 2008

May 7, 2008

Hello everyone, My name is Dylan Smith, and I will be working on implementing tables in rich edit controls as a Google Summer of Code project. Any remaining time I have will also be focused on rich edit controls for this summer. Forgive me for taking so long to introduce myself on the developers mailing list. I ended up going straight for the code as soon as my exams finished. I just finished my last year of Software Engineering at Carleton University which is located in Ottawa, Canada. I will be returning to Carleton University for my Masters after the summer. I am thrilled that I am getting this opportunity to work on Wine for the summer. Happy coding to you all, Dylan

1 0

2nd draft: 1.0 call for testing
by Dan Kegel May 7, 2008

May 7, 2008

How's this look? It's on the wiki now: http://wiki.winehq.org/PlatinumRegressionHunt

1 0

winetricks missing MFC42
by Cesar Izurieta May 7, 2008

May 7, 2008

I see that MFC42 is missing on wine tricks. There's a cab available from: http://activex.microsoft.com/controls/vc/mfc42.cab that contains an installer. It would be nice to add this to winetricks I guess.

1 0

Re: [PATCH] check for iface->ref to avoid crash
by Robert Shearman May 7, 2008

May 7, 2008

Marcus Meissner wrote: > @@ -742,6 +742,9 @@ static void write_c_method_def(FILE *header, const type_t *iface) > > static void write_c_disp_method_def(FILE *header, const type_t *iface) > { > + if (!iface->ref) { > + error_loc("write_c_disp_method_def: no reference on interface(%p)\n", iface); > + } > do_write_c_method_def(header, iface->ref, iface->name); > } > This can't ever happen. dispinterfaces always derive from IDispatch: > dispinterfacehdr: attributes dispinterface { attr_t *attrs; > is_in_interface = TRUE; > is_object_interface > = TRUE; > $$ = $2; > if ($$->defined) > error_loc("multiple definition error\n"); > attrs = > make_attr(ATTR_DISPINTERFACE); > $$->attrs = > append_attr( check_dispiface_attrs($2->name, $1), attrs ); > $$->ref = > find_type("IDispatch", 0); > if (!$$->ref) > error_loc("IDispatch is undefined\n"); > $$->defined = TRUE; > if (!parse_only && > do_header) write_forward($$); > } -- Rob Shearman

2 1

Re: rpcrt4: Fix ndr_marshall test failures, try 2
by Robert Shearman May 7, 2008

May 7, 2008

Maarten Lankhorst wrote: > - ok(RPC_S_OK == RpcServerUseProtseqEp(ncalrpc, 20, endpoint, NULL), "RpcServerUseProtseqEp\n"); > - ok(RPC_S_OK == RpcServerRegisterIf(IFoo_v0_0_s_ifspec, NULL, NULL), "RpcServerRegisterIf\n"); > - ok(RPC_S_OK == RpcServerListen(1, 20, TRUE), "RpcServerListen\n"); > + status = RpcServerUseProtseqEp(ncalrpc, 20, endpoint, NULL); > + ok(RPC_S_OK == status, "RpcServerUseProtseqEp failed with status %08lx\n", status); > + status = RpcServerRegisterIf(IFoo_v0_0_s_ifspec, NULL, NULL); > + ok(RPC_S_OK == status, "RpcServerRegisterIf failed with status %08lx\n", status); > + status = RpcServerListen(1, 20, TRUE); > + ok(RPC_S_OK == status, "RpcServerListen failed with status %08lx\n", status); > Since the RPC status values are in decimal in winerror.h, it is more user-friendly to output them in decimal in the failure messages. -- Rob Shearman

1 0

What happened to the ntdll rtlstr tests?
by Maarten Lankhorst May 7, 2008

May 7, 2008

Hello Alexandre, Why were the fixes for the ntdll rtlstr test failures on windows not accepted? Cheers, Maarten.

2 1

Serial port support in wine-1.0: What to do to make it working ?
by Pavel Troller May 7, 2008

May 7, 2008

Hi! I have really BIG problems running any application, which needs to comm over a serial port: - My ham TCVR - My GPS - My multimeter - A lot of my mobiles - A lot of devices used in my work (special telco equipment, comms varying from simple AT-style commands up to complex proprietary binary protocols). In all the cases there are very similar problems - either the program doesn't detect the device properly, or the device doesn't respond, or in some cases the device does, what the program wants, but it then can't read it back. It looks that some archaic wine versions are better, for example I have to use wine-0.9.40 to communicate with a device in my work (simple text-based command-reply communication), any wine newer than say 0.9.50 doesn't work, the communication times out. Because I'm a telco engineer and serial comm is my daily work, and there are only windows versions of many tools I have to use, proper and mature serial port support is essential for me. So, what can I do to help fixing these problems ? Should I open a bug for every such a program ? Or just open one bug and state all the programs there ? I think that bugzilla contains a lot of bugs related to serial port; is it good to add a new ones ? I'm afraid I can't bisect a problem between 0.9.40 and current wine, but I can make a serial trace for both of them and look at the difference. Would it help to find at least this one particular problem ? Or what more can I do to make the serial port working ? I can code in C in the Linux environment, but I know NOTHING about windows... With regards, Pavel Troller

3 3

winetest problems
by James Hawkins May 6, 2008

May 6, 2008

Hi, I'm trying to fix the failing cross tests, but we haven't had a winetest build on Paul Millar's server in a few days. I'm not familiar with Paul's build process, so my only guess is that a recent commit has broken the build. In the meantime, I've tried a few things. I used John Klehm's crossbuild_tricks script [1] to build winetest. The build succeeded, but the submitted result [2] is empty or can't be parsed. I ran 'make crosstest' from the build directory which fails with: make[2]: Entering directory `/home/truiken/mywine/wine-build/dlls/advpack/tests' i586-mingw32msvc-gcc -c -I../../../../../wine/dlls/advpack/tests -I. -I../../../../../wine/include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o advpack.cross.o ../../../../../wine/dlls/advpack/tests/advpack.c ../../../../../wine/dlls/advpack/tests/advpack.c:1: warning: -fPIC ignored for target (all code is position independent) i586-mingw32msvc-gcc -c -I../../../../../wine/dlls/advpack/tests -I. -I../../../../../wine/include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o files.cross.o ../../../../../wine/dlls/advpack/tests/files.c ../../../../../wine/dlls/advpack/tests/files.c:1: warning: -fPIC ignored for target (all code is position independent) i586-mingw32msvc-gcc -c -I../../../../../wine/dlls/advpack/tests -I. -I../../../../../wine/include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o install.cross.o ../../../../../wine/dlls/advpack/tests/install.c ../../../../../wine/dlls/advpack/tests/install.c:1: warning: -fPIC ignored for target (all code is position independent) ../../../tools/make_ctests -o testlist.c advpack.c files.c install.c i586-mingw32msvc-gcc -c -I../../../../../wine/dlls/advpack/tests -I. -I../../../../../wine/include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o testlist.cross.o testlist.c testlist.c:1: warning: -fPIC ignored for target (all code is position independent) i586-mingw32msvc-gcc advpack.cross.o files.cross.o install.cross.o testlist.cross.o -o advpack_crosstest.exe -lcabinet -ladvapi32 -lkernel32 /usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/bin/ld: cannot find -lcabinet collect2: ld returned 1 exit status make[2]: *** [advpack_crosstest.exe] Error 1 make[2]: Leaving directory `/home/truiken/mywine/wine-build/dlls/advpack/tests' make[1]: *** [advpack/tests/__crosstest__] Error 2 make[1]: Leaving directory `/home/truiken/mywine/wine-build/dlls' Which (I assume) is usually fixed by Paul Millar's win32api custom patches. Any thoughts or ideas? [1] http://klehm.net/wine/crossbuild_tricks.sh [2] http://test.winehq.org/data/1a5aab0ddcc7a0dcde4403add73dbd80be746020/ -- James Hawkins

5 9

Re: [PATCH] fixed if check before strchr
by Eric Pouech May 6, 2008

May 6, 2008

Marcus Meissner a écrit : > Hi, > > spotted by Coverity (CID 701), a if (!spath) should be if (spath). > > Ciao, Marcus > --- > programs/winedbg/source.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/programs/winedbg/source.c b/programs/winedbg/source.c > index 5519c57..1db7092 100644 > --- a/programs/winedbg/source.c > +++ b/programs/winedbg/source.c > @@ -128,7 +128,7 @@ static BOOL source_locate_file(const char* srcfile, char* path) > while (!found) > { > spath = strchr(spath, '\\'); > - if (!spath) spath = strchr(spath, '/'); > + if (spath) spath = strchr(spath, '/'); > if (!spath) break; > spath++; > found = SearchPathA(dbg_curr_process->search_path, spath, NULL, MAX_PATH, path, NULL); > actually no the code intends to find the first occurence of / or \ A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

4 3

Re: [PATCH 1/3] dinput: Remove redundant variable.
by Vitaliy Margolen May 6, 2008

May 6, 2008

Vitaliy Margolen wrote: > --- > dlls/dinput/joystick_linux.c | 16 +++++++--------- > 1 files changed, 7 insertions(+), 9 deletions(-) > Forgot to add that this series of patches should finally address bugs 12052 and 11644. Was there anything wrong with these patches? Vitaliy.

1 1

draft Call for Testing
by Dan Kegel May 6, 2008

May 6, 2008

So, what should we be asking wine users to be doing once rc1 is out? How about this: --- snip --- Calling all wine users! Today, after 15 years of development, the first release candidate for wine-1.0.0 was released. Wine has been under heavy development in recent months, and some applications that used to work well no longer do. But we don't know which ones! Please help us find them, so we can fix them. Here's how: 0. Make sure your machine runs glxgears properly (if it crashes, you may need to update your graphics drivers) 1. Install wine-1.0.0-rc1 (you can download it from http://www.winehq.org/site/download ). Make sure wine's notepad starts up ok and says "wine 1.0.0 rc1" when you do Help / About Wine. 2. Visit the Wine application database at http://appdb.winehq.org/browse_by_rating.php?sRating=Platinum and pick out a few applications that supposedly work perfectly under Wine but do not yet have any test reports with wine-1.0.0-rc1 or later. 3. Try installing and running those apps, one at a time. Before installing each app, delete your .wine directory; that way you get a clean run, uncontaminated by the previous app's settings. 4. For each app you test, add a test report into Wine's AppDB. As a token of our thanks, we will pick one of the users who submits a healthy set of useful test results and send him or her a tasteful Wine-themed goodie of some sort. So fire up your keyboards and start testing! Thanks, and good hunting! --- snip --- (Not sure how the goodie would be handled, but I'm willing to cover the expenses myself, especially if I get to pick the winner :-) How's that sound?

7 8

Re: [PATCH 3/3] ddraw/tests: Add tests for IDirect3DDevice7_Load.
by Stefan Dösinger May 6, 2008

May 6, 2008

Am Montag, 5. Mai 2008 23:49:34 schrieb Alexander Dorofeyev: > + /* Freed in reverse order as native seems to dislike and crash on > freeing top level surface first. */ just fyi, native ignores refcounts on sublevels(if they are created as complex surface, not attached). As long as the top level exists, you can release the sublevels into oblivion if you want to, they'll stay around. If the top level is destroyed, the sublevels are destroyed regardless of their refcounts. There are some tests for this behavior in dsurface.c, and Wine does the same essentially. A very extensive test, wow!

1 0

Re: AppDB: update the general help page and also make it valid html
by Alexander Nicolaysen Sørnes May 6, 2008

May 6, 2008

> I've updated the general help page with links to git instead of cvs, > updated building instructions and also changed the html a little so it > validates, I've also removed a link to a cracks website and replaced > it with a statement about third party software. > > before and after: http://img222.imageshack.us/img222/8647/baiz4.png It's great that you're fixing up the help pages. But i don't see why you are removing the link to MegaGames; I added it to make it easier for users to test games without a how-to; removing it would appear to do the opposite. Alexander N. Sørnes

1 0

Re: netapi32: Fix test crash occuring when NetWkstaUserGetInfo fails, try 2
by James Hawkins May 6, 2008

May 6, 2008

On Tue, May 6, 2008 at 1:36 AM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > Improved from James Hawkins suggestions. > --- > Just to clear my name, this is not what I suggested :-) -- James Hawkins

1 0

wineserver socket file and DOS attacks
by Steven Elliott May 6, 2008

May 6, 2008

I have some concerns about the location of the socket file that wineserver uses. Since by default the current location is in /tmp my concern is that anyone can stop anyone else from using wine just by creating a directory named /tmp/.wine-500. As far as I know the only risk is denial of service in nature since wine seems to be smart enough to make sure the /tmp/.wine-500 is owned by the user invoking the wine application: > notepad wineserver: /tmp/.wine-500 is not owned by you Previously the socket file was under ~/.wine. I found this which briefly documents the change here: http://www.winehq.org/site/docs/winedev-guide/x2584 under section "7.3.2. The Wine server" it says: "In earlier versions of Wine the master socket mentioned above was actually created in the configuration directory; either your home directory's /wine subdirectory or wherever the WINEPREFIX environment variable points. Since that might not be possible the socket is actually created within the /tmp directory with a name that reflects the configuration directory." /tmp/.wine-<user Id> is hard coded in libs/wine/config.c, so that aspect of the socket file location is not configurable. Anyway, have alternatives such as the following been considered?: 1) Create the socket file in ~/.wine (or wherever WINEPREFIX points) like wine used to if the user's home directory exists and is writable. Use /tmp/.wine-<user Id> as a fallback. 2) Append some additional integer to /tmp/.wine-<user Id> that is incremented if that directory already exists and is owned by someone else. For example, if /tmp/.wine-500 already exists for user 500 but is owned by someone else then both wineserver and the wine application would append "-1" and then keep incrementing: /tmp/.wine-500 /tmp/.wine-500-1 /tmp/.wine-500-2 until they each found a directory owned by the current user (or until they are able to create one). Hopefully they would pick the same directory. I need to think more about how robust this would be. -- ----------------------------------------------------------------------- | Steven Elliott | selliott4(a)austin.rr.com | -----------------------------------------------------------------------

6 10

Bug#479659: RFH: wine -- Windows API implementation
by Ove Kaaven May 6, 2008

May 6, 2008

Package: wnpp Severity: normal Since my time may be limited in the future, I am seeking comaintainers for the Wine package in Debian, at least to ensure that new Wine releases may continue to be uploaded in a timely fashion, and to keep the package's bug count down. (And given that pretty much half the open bugs are "missing manpage" bugs, documentation writers would also help...) I have created a project for this on alioth.debian.org. I've loaded the current packaging (all versions since etch) into a Git repository there, and put up some instructions on http://pkg-wine.alioth.debian.org/ -- System Information: Debian Release: lenny/sid APT prefers testing APT policy: (650, 'testing'), (600, 'unstable') Architecture: i386 (i686) Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core) Locale: LANG=en_US.ISO-8859-1, LC_CTYPE=en_US.ISO-8859-1 (charmap=ISO-8859-1) Shell: /bin/sh linked to /bin/bash

1 0

bugzilla rights request
by Alexander Dorofeyev May 5, 2008

May 5, 2008

Hi. I would like to have rights to change bug status. I fix some bugs myself and also occasionally do some bug-triaging, so it would be handy. Thanks.

1 0

re: Vehicle for minor bugs?
by Dan Kegel May 5, 2008

May 5, 2008

Andrew Talbot wrote: > Frequently, I am finding minor bugs that I probably cannot fix myself, that > are probably not suitable for a Bugzilla bug report and that are likely to > be ignored if posted to wine-devel (witness my current postings: "XBOOL, > XBYTE, XINT8, etc." and "Five functions that cannot handle a NULL > parameter", I haven't seen those posts, where are they? I'd say a conformance test would be the right vehicle.

3 2

Re: Jacek Caban : mshtml: Added IMG element tests.
by Alistair Leslie-Hughes May 5, 2008

May 5, 2008

"Alexandre Julliard" <julliard(a)winehq.org> wrote in message news:E1Jszaj-0008Vx-SO(a)wine.codeweavers.com... > Module: wine > Branch: master > Commit: 29d8c366bb278a6b73c3669817063087d7cd080d > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=29d8c366bb278a6b73c366981… > > Author: Jacek Caban <jacek(a)codeweavers.com> > Date: Sun May 4 19:22:46 2008 +0200 > > mshtml: Added IMG element tests. > > --- > > dlls/mshtml/tests/dom.c | 19 +++++++++++++++++-- > 1 files changed, 17 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c > index 1039ab5..a3d0701 100644 > --- a/dlls/mshtml/tests/dom.c > +++ b/dlls/mshtml/tests/dom.c > @@ -48,6 +48,7 @@ static const char elem_test_str[] = > "<table><tbody></tbody></table>" > "<script id=\"sc\" type=\"text/javascript\"></script>" > "<test />" > + "<img /" ^^^ Is this mssing a ending > Best Regards Alistair Leslie-Hughes

2 1

Time-based releases idea
by Dan Kegel May 5, 2008

May 5, 2008

I just wrote up an idea related to release management for post-1.0 wine releases. It's online at http://wiki.winehq.org/TimeBasedReleases Essentially, the idea is to release in March and September, in time for the April and October releases of Ubuntu. For instance, following this strategy, we might plan to release wine-1.2.0 in September 2008 or March 2009. The alternative is to propose a set of criteria that wine-1.2 needs to meet, and working until they are met, which is what we did for wine-0.9 and wine-1.0 (I think; it's kind of hard to tell). I look forward to discussing this idea... perhaps we shouldn't bother to until after 1.0 is released, but I wanted to get it out early so the discussion can begin in time for us to move on it if we want to. - Dan

10 13

quartz: regression: Assertion failed at pin.c:1236
by Alex Villacís Lasso May 5, 2008

May 5, 2008

The patch: 3066116f76c0c44950fde3552485b37dce24d1f8 quartz: Clean up pullpin code. causes a regression in a test application I have. I see the following message in the console: pin.c:1236: PullPin_Init: La declaración `pCustomRequest' no se cumple. And I get an "Automation error" in a message box. This, every time I try to load an AVI file in a Windows Media Control. Reversing the patch gets rid of the error. I believe this patch was to be followed by a cleanup of code to ensure that no users of PullPin_Init pass a NULL pCustomRequest. However, this parameter gets passed as NULL from parser.c:92, which in turn gets it from avisplit.c, mpegsplit.c and waveparser.c, all of them with NULL as the value for the parameter. Was there supposed to be any follow-up patch for this? Why was it not committed? -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 1

Re: d3dx8: Dynamically import d3dx8 in the tests so the tests can be skipped if the dll is not found
by Paul Vriens May 5, 2008

May 5, 2008

Maarten Lankhorst wrote: > This is better then downright crashing on the missing dlls. > > This patch was created using grep and sed. :-) > --- > > > ------------------------------------------------------------------------ > > Hi Maarten, When do you see a crash? Winetest itself already checks if a dll is present. If it's not, the tests are skipped as can be seen on test.winehq.org.. -- Cheers, Paul.

3 2