June 2008 - Wine-Devel - list.winehq.org

Crash in localspl test?
by Dan Kegel June 25, 2008

June 25, 2008

Today I started getting a heap corruption and crash in localspl: dank(a)snazzy:~/wine-git/dlls/localspl/tests$ ../../../tools/runtest -P wine -M localspl.dll -T ../../.. -p localspl_test.exe.so localmon.c err:heap:HEAP_ValidateInUseArena Heap 0x110000: bad size 001232a0 for in-use arena 0x123128 err:module:find_forwarded_export module not found for forward 'winspool.drv.EnumPortsW' used by L"C:\\windows\\system32\\spoolss.dll" localmon.c:839: Tests skipped: got 2 localmon.c:982: Tests skipped: got 2 fixme:localspl:localmon_XcvDataPort command not supported: L"" fixme:localspl:localmon_XcvDataPort command not supported: L"monitorui" localmon: 72 tests executed (0 marked as todo, 0 failures), 2 skipped. wine: Unhandled page fault on read access to 0x04455379 at address 0x7ef978f1 (thread 0012), starting debugger... Backtrace: =>1 0x7ef978f1 process_detach+0x5b(bForceDetach=0x1, lpReserved=0x1) [/home/dank/wine-git/dlls/ntdll/loader.c:1074] in ntdll (0x0032fe78) 2 0x7ef9aa77 LdrShutdownProcess+0x6f() [/home/dank/wine-git/dlls/ntdll/loader.c:2144] in ntdll (0x0032fea8) 3 0x7ee35c79 ExitProcess+0x17(status=0x0) [/home/dank/wine-git/dlls/kernel32/process.c:2102] in kernel32 (0x0032fec8) 4 0x7ec8d4b7 in localspl_test (+0xd4b7) (0x0032fef8) 5 0x7ee31e5b start_process+0xe4(arg=0x0) [/home/dank/wine-git/dlls/kernel32/process.c:904] in kernel32 (0x0032ffe8) 0x7ef978f1 process_detach+0x5b [/home/dank/wine-git/dlls/ntdll/loader.c:1074] in ntdll: movl 0x34(%eax),%eax 1074 if ( !(mod->Flags & LDR_PROCESS_ATTACHED) ) I'm not alone; test.winehq.org shows others are getting it today, too, but not yesterday. Anyone know what's up with that?

3 3

wininet: InternetErrorDlg should return ERROR_NOT_SUPPORTED if error is not supported
by Alexander Morozov June 25, 2008

June 25, 2008

Changelog: InternetErrorDlg should return ERROR_NOT_SUPPORTED if error is not supported >From b89937296efd5a45772027f07b2fdbf80b5f480d Mon Sep 17 00:00:00 2001 From: Alexander Morozov <amorozov(a)builder.office.etersoft.ru> Date: Wed, 25 Jun 2008 19:07:34 +0400 Subject: [PATCH] wininet: InternetErrorDlg should return ERROR_NOT_SUPPORTED if error is not supported --- dlls/wininet/dialogs.c | 2 +- dlls/wininet/tests/dialogs.c | 1 - 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/dlls/wininet/dialogs.c b/dlls/wininet/dialogs.c index cf6ee5c..1ea9b9c 100644 --- a/dlls/wininet/dialogs.c +++ b/dlls/wininet/dialogs.c @@ -385,5 +385,5 @@ DWORD WINAPI InternetErrorDlg(HWND hWnd, HINTERNET hRequest, FIXME("Need to display dialog for error %d\n", dwError); return ERROR_SUCCESS; } - return ERROR_INVALID_PARAMETER; + return ERROR_NOT_SUPPORTED; } diff --git a/dlls/wininet/tests/dialogs.c b/dlls/wininet/tests/dialogs.c index 088ba01..168053f 100644 --- a/dlls/wininet/tests/dialogs.c +++ b/dlls/wininet/tests/dialogs.c @@ -66,7 +66,6 @@ static void test_InternetErrorDlg(void) ret = InternetErrorDlg(GetDesktopWindow(), hr, ERROR_FILE_NOT_FOUND, 0, NULL); - todo_wine ok(ret == ERROR_NOT_SUPPORTED, "InternetErrorDlg failed\n"); end_thread = 0; -- 1.5.4.5.GIT

2 1

wininet/tests: add InternetErrorDlg tests
by Alexander Morozov June 25, 2008

June 25, 2008

Changelog: Add InternetErrorDlg tests I ran these tests on Win98 and WinXP >From 687f7d365b97d1da95db222e5bd5bbdf5c62c76f Mon Sep 17 00:00:00 2001 From: Alexander Morozov <amorozov(a)builder.office.etersoft.ru> Date: Wed, 25 Jun 2008 19:01:42 +0400 Subject: [PATCH] wininet/tests: add InternetErrorDlg tests --- dlls/wininet/tests/Makefile.in | 3 +- dlls/wininet/tests/dialogs.c | 194 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 196 insertions(+), 1 deletions(-) create mode 100644 dlls/wininet/tests/dialogs.c diff --git a/dlls/wininet/tests/Makefile.in b/dlls/wininet/tests/Makefile.in index ba8f662..92d875b 100644 --- a/dlls/wininet/tests/Makefile.in +++ b/dlls/wininet/tests/Makefile.in @@ -3,9 +3,10 @@ TOPOBJDIR = ../../.. SRCDIR = @srcdir@ VPATH = @srcdir@ TESTDLL = wininet.dll -IMPORTS = wininet ws2_32 kernel32 +IMPORTS = wininet ws2_32 kernel32 user32 CTESTS = \ + dialogs.c \ ftp.c \ generated.c \ http.c \ diff --git a/dlls/wininet/tests/dialogs.c b/dlls/wininet/tests/dialogs.c new file mode 100644 index 0000000..c2f3878 --- /dev/null +++ b/dlls/wininet/tests/dialogs.c @@ -0,0 +1,194 @@ +/* + * Wininet - dialog tests + * + * Copyright 2008 Alexander Morozov for Etersoft + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include "windows.h" +#include "wininet.h" + +#include "wine/test.h" + +static LONG end_thread; + +static BOOL CALLBACK enum_wnd_proc(HWND hwnd, LPARAM lparam) +{ + SendMessageA(hwnd, WM_CLOSE, 0, 0); + InterlockedIncrement(&end_thread); + return TRUE; +} + +static DWORD CALLBACK killer_thread(LPVOID param) +{ + /* Without Sleep(50) a window failed to close sometimes */ + Sleep(50); + while (!end_thread) + EnumThreadWindows((DWORD)param, enum_wnd_proc, 0); + return 0; +} + +static void test_InternetErrorDlg(void) +{ + HANDLE hThread; + HINTERNET hi, hc, hr; + DWORD ret, id; + + hi = InternetOpenA("winetest", 0, NULL, NULL, 0); + ok(hi != NULL, "InternetOpen failed\n"); + hc = InternetConnectA(hi, "localhost", INTERNET_DEFAULT_HTTP_PORT, + NULL, NULL, INTERNET_SERVICE_HTTP, 0, 0); + ok(hc != NULL, "InternetConnect failed\n"); + hr = HttpOpenRequestA(hc, "GET", "/", NULL, NULL, NULL, 0, 0); + ok(hr != NULL, "HttpOpenRequest failed\n"); + + ret = InternetErrorDlg(NULL, NULL, ERROR_SUCCESS, 0, NULL); + todo_wine + ok(ret == ERROR_INVALID_HANDLE, "InternetErrorDlg failed\n"); + + ret = InternetErrorDlg(GetDesktopWindow(), hr, + ERROR_SUCCESS, 0, NULL); + todo_wine + ok(ret == ERROR_NOT_SUPPORTED, "InternetErrorDlg failed\n"); + + ret = InternetErrorDlg(GetDesktopWindow(), hr, + ERROR_FILE_NOT_FOUND, 0, NULL); + todo_wine + ok(ret == ERROR_NOT_SUPPORTED, "InternetErrorDlg failed\n"); + + end_thread = 0; + hThread = CreateThread(NULL, 0, killer_thread, + (LPVOID)GetCurrentThreadId(), 0, &id); + ok(hThread != NULL, "create thread failed\n"); + if (NULL != hThread) + { + ret = InternetErrorDlg(GetDesktopWindow(), hr, + ERROR_INTERNET_HTTP_TO_HTTPS_ON_REDIR, 0, NULL); + ok(ret == ERROR_CANCELLED || ret == ERROR_SUCCESS, + "InternetErrorDlg failed\n"); + InterlockedIncrement(&end_thread); + ret = WaitForSingleObject(hThread, 3000); + ok(ret == WAIT_OBJECT_0, "thread wait failed\n"); + CloseHandle(hThread); + } + + end_thread = 0; + hThread = CreateThread(NULL, 0, killer_thread, + (LPVOID)GetCurrentThreadId(), 0, &id); + ok(hThread != NULL, "create thread failed\n"); + if (NULL != hThread) + { + ret = InternetErrorDlg(GetDesktopWindow(), hr, + ERROR_INTERNET_POST_IS_NON_SECURE, 0, NULL); + ok(ret == ERROR_CANCELLED || ret == ERROR_SUCCESS, + "InternetErrorDlg failed\n"); + InterlockedIncrement(&end_thread); + ret = WaitForSingleObject(hThread, 3000); + ok(ret == WAIT_OBJECT_0, "thread wait failed\n"); + CloseHandle(hThread); + } + + end_thread = 0; + hThread = CreateThread(NULL, 0, killer_thread, + (LPVOID)GetCurrentThreadId(), 0, &id); + ok(hThread != NULL, "create thread failed\n"); + if (NULL != hThread) + { + ret = InternetErrorDlg(GetDesktopWindow(), hr, + ERROR_INTERNET_CLIENT_AUTH_CERT_NEEDED, 0, NULL); + todo_wine + ok(ret == ERROR_CANCELLED || ret == ERROR_SUCCESS, + "InternetErrorDlg failed\n"); + InterlockedIncrement(&end_thread); + ret = WaitForSingleObject(hThread, 3000); + ok(ret == WAIT_OBJECT_0, "thread wait failed\n"); + CloseHandle(hThread); + } + + end_thread = 0; + hThread = CreateThread(NULL, 0, killer_thread, + (LPVOID)GetCurrentThreadId(), 0, &id); + ok(hThread != NULL, "create thread failed\n"); + if (NULL != hThread) + { + ret = InternetErrorDlg(GetDesktopWindow(), hr, + ERROR_INTERNET_INVALID_CA, 0, NULL); + ok(ret == ERROR_CANCELLED || ret == ERROR_SUCCESS, + "InternetErrorDlg failed\n"); + InterlockedIncrement(&end_thread); + ret = WaitForSingleObject(hThread, 3000); + ok(ret == WAIT_OBJECT_0, "thread wait failed\n"); + CloseHandle(hThread); + } + + end_thread = 0; + hThread = CreateThread(NULL, 0, killer_thread, + (LPVOID)GetCurrentThreadId(), 0, &id); + ok(hThread != NULL, "create thread failed\n"); + if (NULL != hThread) + { + ret = InternetErrorDlg(GetDesktopWindow(), hr, + ERROR_INTERNET_SEC_CERT_CN_INVALID, 0, NULL); + ok(ret == ERROR_CANCELLED || ret == ERROR_SUCCESS, + "InternetErrorDlg failed\n"); + InterlockedIncrement(&end_thread); + ret = WaitForSingleObject(hThread, 3000); + ok(ret == WAIT_OBJECT_0, "thread wait failed\n"); + CloseHandle(hThread); + } + + end_thread = 0; + hThread = CreateThread(NULL, 0, killer_thread, + (LPVOID)GetCurrentThreadId(), 0, &id); + ok(hThread != NULL, "create thread failed\n"); + if (NULL != hThread) + { + ret = InternetErrorDlg(GetDesktopWindow(), hr, + ERROR_INTERNET_SEC_CERT_DATE_INVALID, 0, NULL); + ok(ret == ERROR_CANCELLED || ret == ERROR_SUCCESS, + "InternetErrorDlg failed\n"); + InterlockedIncrement(&end_thread); + ret = WaitForSingleObject(hThread, 3000); + ok(ret == WAIT_OBJECT_0, "thread wait failed\n"); + CloseHandle(hThread); + } + + /* This crashes + end_thread = 0; + hThread = CreateThread(NULL, 0, killer_thread, + (LPVOID)GetCurrentThreadId(), 0, &id); + ok(hThread != NULL, "create thread failed\n"); + if (NULL != hThread) + { + ret = InternetErrorDlg(GetDesktopWindow(), hr, + ERROR_INTERNET_INCORRECT_PASSWORD, 0, NULL); + ok(ret == ERROR_CANCELLED || ret == ERROR_SUCCESS, + "InternetErrorDlg failed\n"); + InterlockedIncrement(&end_thread); + ret = WaitForSingleObject(hThread, 3000); + ok(ret == WAIT_OBJECT_0, "thread wait failed\n"); + CloseHandle(hThread); + } */ + + InternetCloseHandle(hr); + InternetCloseHandle(hc); + InternetCloseHandle(hi); +} + +START_TEST(dialogs) +{ + test_InternetErrorDlg(); +} -- 1.5.4.5.GIT

2 1

Re: [6/7] gdiplus: Implemented GdipGetPathData with test
by Paul Vriens June 25, 2008

June 25, 2008

Nikolay Sivov wrote: > Changelog: > - Implemented GdipGetPathData with test > > --- > dlls/gdiplus/gdiplus.spec | 2 +- > dlls/gdiplus/graphicspath.c | 22 ++++++++++++++++++++++ > dlls/gdiplus/tests/graphicspath.c | 23 +++++++++++++++++++++++ > include/gdiplusflat.h | 1 + > 4 files changed, 47 insertions(+), 1 deletions(-) > > diff --git a/dlls/gdiplus/gdiplus.spec b/dlls/gdiplus/gdiplus.spec > index 70864ba..ed02a77 100644 > --- a/dlls/gdiplus/gdiplus.spec > +++ b/dlls/gdiplus/gdiplus.spec > @@ -323,7 +323,7 @@ > @ stub GdipGetNearestColor > @ stdcall GdipGetPageScale(ptr ptr) > @ stdcall GdipGetPageUnit(ptr ptr) > -@ stub GdipGetPathData > +@ stdcall GdipGetPathData(ptr ptr) > @ stdcall GdipGetPathFillMode(ptr ptr) > @ stub GdipGetPathGradientBlend > @ stub GdipGetPathGradientBlendCount > diff --git a/dlls/gdiplus/graphicspath.c b/dlls/gdiplus/graphicspath.c > index 4cbd33a..284b64c 100644 > --- a/dlls/gdiplus/graphicspath.c > +++ b/dlls/gdiplus/graphicspath.c > @@ -479,6 +479,28 @@ GpStatus WINGDIPAPI GdipDeletePath(GpPath *path) > return Ok; > } > > +GpStatus WINGDIPAPI GdipGetPathData(GpPath *path, GpPathData* pathData) > +{ > + if(!path || !pathData) > + return InvalidParameter; > + > + pathData->Count = path->pathdata.Count; > + > + pathData->Points = GdipAlloc(sizeof(PointF) * pathData->Count); > + if(!pathData->Points) > + return OutOfMemory; > + > + pathData->Types = GdipAlloc(pathData->Count); > + if(!pathData->Points) > + return OutOfMemory; > + > + /* copy data */ > + memcpy(pathData->Points, path->pathdata.Points, sizeof(PointF) * pathData->Count); > + memcpy(pathData->Types , path->pathdata.Types , pathData->Count); > + > + return Ok; > +} > + > GpStatus WINGDIPAPI GdipGetPathFillMode(GpPath *path, GpFillMode *fillmode) > { > if(!path || !fillmode) > diff --git a/dlls/gdiplus/tests/graphicspath.c b/dlls/gdiplus/tests/graphicspath.c > index 6436b1a..672f6da 100644 > --- a/dlls/gdiplus/tests/graphicspath.c > +++ b/dlls/gdiplus/tests/graphicspath.c > @@ -149,6 +149,28 @@ static void test_constructor_destructor(void) > expect(Ok, status); > } > > +static void test_getpathdata(void) > +{ > + GpPath *path; > + GpPathData data; > + GpStatus status; > + > + GdipCreatePath(FillModeAlternate, &path); > + status = GdipAddPathLine(path, 5.0, 5.0, 100.0, 50.0); > + expect(Ok, status); > + > + status = GdipGetPathData(path, &data); > + expect(Ok, status); > + expect((data.Count == 2), TRUE); > + expect((data.Points[0].X == 5.0) && (data.Points[0].Y == 5.0) && > + (data.Points[1].X == 100.0) && (data.Points[1].Y == 50.0), TRUE); > + expect((data.Types[0] == PathPointTypeStart) && (data.Types[1] == PathPointTypeLine), TRUE); > + > + GdipFree(data.Points); > + GdipFree(data.Types); > + GdipDeletePath(path); > +} > + > static path_test_t line2_path[] = { > {0.0, 50.0, PathPointTypeStart, 0, 0}, /*0*/ > {5.0, 45.0, PathPointTypeLine, 0, 0}, /*1*/ > @@ -605,6 +627,7 @@ START_TEST(graphicspath) > GdiplusStartup(&gdiplusToken, &gdiplusStartupInput, NULL); > > test_constructor_destructor(); > + test_getpathdata(); > test_line2(); > test_arc(); > test_worldbounds(); > diff --git a/include/gdiplusflat.h b/include/gdiplusflat.h > index 5ce32b2..e4f5d62 100644 > --- a/include/gdiplusflat.h > +++ b/include/gdiplusflat.h > @@ -225,6 +225,7 @@ GpStatus WINGDIPAPI GdipCreatePath2(GDIPCONST GpPointF*,GDIPCONST BYTE*,INT, > GpFillMode,GpPath**); > GpStatus WINGDIPAPI GdipCreatePath2I(GDIPCONST GpPoint*,GDIPCONST BYTE*,INT,GpFillMode,GpPath**); > GpStatus WINGDIPAPI GdipDeletePath(GpPath*); > +GpStatus WINGDIPAPI GdipGetPathData(GpPath*,GpPathData*); > GpStatus WINGDIPAPI GdipGetPathFillMode(GpPath*,GpFillMode*); > GpStatus WINGDIPAPI GdipGetPathPoints(GpPath*,GpPointF*,INT); > GpStatus WINGDIPAPI GdipGetPathPointsI(GpPath*,GpPoint*,INT); Hi, We seem to have numerous failures (and even more serious, test crashes) with these tests on Windows. I did check a few things myself but I'm lacking the knowledge to look further in to this. Running the tests on Wine succeeds for me, when I however run the same graphicspath tests on Wine with a native gdiplus.dll (through winetricks) this test is also crashing. -- Cheers, Paul.

2 3

wininet: fix crash
by Alexander Morozov June 25, 2008

June 25, 2008

Changelog: fix InternetErrorDlg crash >From 6ab5655ebe26611387c2586b06fad78c16de7239 Mon Sep 17 00:00:00 2001 From: Alexander Morozov <amorozov(a)builder.office.etersoft.ru> Date: Wed, 25 Jun 2008 19:05:40 +0400 Subject: [PATCH] wininet: fix crash --- dlls/wininet/dialogs.c | 3 +++ dlls/wininet/tests/dialogs.c | 3 +-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/wininet/dialogs.c b/dlls/wininet/dialogs.c index dd5aa31..cf6ee5c 100644 --- a/dlls/wininet/dialogs.c +++ b/dlls/wininet/dialogs.c @@ -75,6 +75,9 @@ static BOOL WININET_GetProxyServer( HINTERNET hRequest, LPWSTR szBuf, DWORD sz ) if (NULL == hIC) return FALSE; + if (NULL == hIC->lpszProxy) + return FALSE; + lstrcpynW(szBuf, hIC->lpszProxy, sz); /* FIXME: perhaps it would be better to use InternetCrackUrl here */ diff --git a/dlls/wininet/tests/dialogs.c b/dlls/wininet/tests/dialogs.c index c2f3878..088ba01 100644 --- a/dlls/wininet/tests/dialogs.c +++ b/dlls/wininet/tests/dialogs.c @@ -166,7 +166,6 @@ static void test_InternetErrorDlg(void) CloseHandle(hThread); } - /* This crashes end_thread = 0; hThread = CreateThread(NULL, 0, killer_thread, (LPVOID)GetCurrentThreadId(), 0, &id); @@ -181,7 +180,7 @@ static void test_InternetErrorDlg(void) ret = WaitForSingleObject(hThread, 3000); ok(ret == WAIT_OBJECT_0, "thread wait failed\n"); CloseHandle(hThread); - } */ + } InternetCloseHandle(hr); InternetCloseHandle(hc); -- 1.5.4.5.GIT

1 0

[Wine] Shortcuts not appearing in gnome panel drawers
by Darragh Bailey June 25, 2008

June 25, 2008

Tried posting the following question on wine-users. I suspect that those behind the creation of the mechanism by which wine creates launchers from windows shortcuts don't read that list. ----- Forwarded message from Darragh Bailey <felix(a)compsoc.nuigalway.ie> ----- I'm trying to trace why launchers created by wine due to a program installation are not appearing in the menus on my system. The launchers appear to have the correct contents, but for some reason gnome-panel is not adding them to my menus. Does anyone know how to run the relavent gnome tools with options to see what's happening when gnome reads these launchers. Keep in mind that there are at least 50 other launchers created by wine, that gnome has absolutely no problems in showing. ----- End forwarded message ----- Any suggestions on how to go about debugging this problem? -- Darragh "Nothing is foolproof to a sufficiently talented fool."

1 0

Re: richedit: Added missing defines and structures to richedit.h
by Michael Stefaniuc June 25, 2008

June 25, 2008

Hello Dylan, Dylan Smith wrote: > I tried to make richedit.h more consistent with the public SDK headers > by adding anything any missing defines and structures that I could find. > --- > include/richedit.h | 395 ++++++++++++++++++++++++++++++++++++++++++++++++++-- > 1 files changed, 384 insertions(+), 11 deletions(-) > > > ------------------------------------------------------------------------ Please do not use C++ style comments aka "//". Those are frown upon in Wine. bye michael

2 1

Re: user32:tests:msg.c Add msg tests for SetActiveWindow()
by Dmitry Timoshkov June 25, 2008

June 25, 2008

Anatoly Lyutin <vostok(a)etersoft.ru> wrote: > @@ -10845,6 +10997,7 @@ START_TEST(msg) > /* keep it the last test, under Windows it tends to break the tests > * which rely on active/foreground windows being correct. > */ > + test_SetActiveWindow(); > test_SetForegroundWindow(); > > UnhookWindowsHookEx(hCBT_hook); Isn't the comment above is clear enough to which test it belongs to? -- Dmitry.

2 1

Re: urlmon: Fix a few test failures
by Alexandre Julliard June 25, 2008

June 25, 2008

"James Hawkins" <jhawkins(a)codeweavers.com> writes: > One of the failures only happens with IE6, and the other was failing > across all platforms. > > Changelog: > * Fix a few test failures. This doesn't work here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so url.c && touch url.ok url.c:1146: Test failed: unexpected call OnProgress_SENDINGREQUEST make[2]: *** [url.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: inetmib1(16/31): Use a helper function to get the item and instance of the MIB2 interface table
by Alexandre Julliard June 25, 2008

June 25, 2008

"Juan Lang" <juan.lang(a)gmail.com> writes: > From 94c46a93327a62e4cdafd3c06f472efb82ee42af Mon Sep 17 00:00:00 2001 > From: Juan Lang <juan.lang(a)gmail.com> > Date: Tue, 20 May 2008 20:59:42 -0700 > Subject: [PATCH] Use a helper function to get the item and instance of the MIB2 interface table This one fails for me: ../../../tools/runtest -q -P wine -M inetmib1.dll -T ../../.. -p inetmib1_test.exe.so main.c && touch main.ok main.c:189: Test failed: expected 6, got 8 main.c:195: Test failed: expected 6, got 8 main.c:201: Test failed: expected 6, got 8 make[2]: *** [main.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

1 0

What to do with wrong AeDebug entries in the registry on Windows boxes?
by Paul Vriens June 25, 2008

June 25, 2008

Hi, I guess it's a leftover from old kernel/debugger tests but on some Windows boxes this registry key is filled with our test-debugger information. This is maybe/probably the reason some tests show "Timeout" for one box and "Crashed" for others. What would be the best approach to "restore" this key? I guess if we find the mentioning of our test in this registry key we should delete it. But what do we replace it with? I ran 'drwtsn32 -i' on my boxes to at least have the default in there, but that's of course not correct for people running other debuggers. -- Cheers, Paul.

1 0

Some Questions From The Bugzilla Project
by Max Kanat-Alexander June 25, 2008

June 25, 2008

Hey there Wine Bugzilla folks. I've been funded by the Mozilla Foundation to do a survey of the major Bugzilla-using organizations in the world, to find out what people like and don't like about Bugzilla, what we could improve, what changes you'd like to see in Bugzilla, etc., and you guys are one of the organizations picked for the survey. :-) The Bugzilla Project is going to use this information to prioritize its work on future releases, and we may even be able to get a grant from the Mozilla Foundation to work on some of the most popular or pressing issues. In other words, what you say here will really matter. I was wondering--who's the best contact there who I could ask a few questions to about how you guys use Bugzilla? It'd just be over email, unless you want to do it over IRC or on the phone. (Oh, and make sure you reply to me directly, since I'm not on the list.) -Max -- http://www.everythingsolved.com/ Competent, Friendly Bugzilla and Perl Services. Everything Else, too.

5 7

Re: [1/2] gdi32: defines for CreateFontIndirectEx (try3)
by Dmitry Timoshkov June 25, 2008

June 25, 2008

"Nikolay Sivov" <bunglehead(a)gmail.com> wrote: > --- a/include/wingdi.h > +++ b/include/wingdi.h > @@ -573,8 +573,8 @@ DECL_WINELIB_TYPE_AW(LPLOGFONT) > typedef struct > { > LOGFONTA elfLogFont; > - BYTE elfFullName[LF_FULLFACESIZE]; > - BYTE elfStyle[LF_FACESIZE]; > + CHAR elfFullName[LF_FULLFACESIZE]; > + CHAR elfStyle[LF_FACESIZE]; > } ENUMLOGFONTA, *LPENUMLOGFONTA; > > typedef struct > @@ -590,9 +590,9 @@ DECL_WINELIB_TYPE_AW(LPENUMLOGFONT) > typedef struct > { > LOGFONTA elfLogFont; > - BYTE elfFullName[LF_FULLFACESIZE]; > - BYTE elfStyle[LF_FACESIZE]; > - BYTE elfScript[LF_FACESIZE]; > + CHAR elfFullName[LF_FULLFACESIZE]; > + CHAR elfStyle[LF_FACESIZE]; > + CHAR elfScript[LF_FACESIZE]; > } ENUMLOGFONTEXA,*LPENUMLOGFONTEXA; You can't change that. -- Dmitry.

1 0

Re: ntdll: Add timestamp channel to log output.
by Dmitry Timoshkov June 25, 2008

June 25, 2008

"Peter Urbanec" <winehq.org(a)urbanec.net> wrote: > @@ -164,8 +166,16 @@ static int NTDLL_dbg_vlog( enum __wine_debug_class cls, struct __wine_debug_chan > /* only print header if we are at the beginning of the line */ > if (info->out_pos == info->output || info->out_pos[-1] == '\n') > { > + /* Prepend a timestamp to each line, if requested. */ > + if (TRACE_ON(timestamps)) > + { > + struct timeval tv; > + if (!gettimeofday(&tv, NULL)) > + ret += wine_dbg_printf( "[%ld.%06ld] ", tv.tv_sec, tv.tv_usec); > + } > + > if (TRACE_ON(tid)) > - ret = wine_dbg_printf( "%04x:", GetCurrentThreadId() ); > + ret += wine_dbg_printf( "%04x:", GetCurrentThreadId() ); > if (cls < sizeof(classes)/sizeof(classes[0])) > ret += wine_dbg_printf( "%s:%s:%s ", classes[cls], channel->name, function ); > } What about using the same indentation style as the existing code does? -- Dmitry.

1 0

sorry forgot to cut and paste some code =)
by celticht32＠aol.com June 25, 2008

June 25, 2008

the code is in : wine-1.0/dlls/wined3d/context.c here is the changed code : /* This function takes care of WineD3D pixel format selection. */ static int WineD3D_ChoosePixelFormat(IWineD3DDeviceImpl *This, HDC hdc, WINED3DFORMAT ColorFormat, WINED3DFORMAT DepthStencilFormat, BOOL auxBuffers, int numSamples, BOOL pbuffer, BOOL findCompatible) { ??? int iPixelFormat=0; ??? short redBits, greenBits, blueBits, alphaBits, colorBits; ??? short depthBits=0, stencilBits=0; ??? int i = 0; ??? int nCfgs = This->adapter->nCfgs; ??? WineD3D_PixelFormat *cfgs = This->adapter->cfgs; ??? BOOL exactDepthMatch = FALSE;? /*Changed june 23,08 */?? ??? PIXELFORMATDESCRIPTOR pfd;???? /*Changed june 23,08 */ ??? TRACE("ColorFormat=%s, DepthStencilFormat=%s, auxBuffers=%d, numSamples=%d, pbuffer=%d, findCompatible=%d\n", ????????? debug_d3dformat(ColorFormat), debug_d3dformat(DepthStencilFormat), auxBuffers, numSamples, pbuffer, findCompatible); ??? if (!getColorBits(ColorFormat, &redBits, &greenBits, &blueBits, &alphaBits, &colorBits)) ???? { ??????? ERR("Unable to get color bits for format %s (%#x)!\n", debug_d3dformat(ColorFormat), ColorFormat); ??????? return 0; ??? } ??? /* In WGL both color, depth and stencil are features of a pixel format. In case of D3D they are separate. ???? * You are able to add a depth + stencil surface at a later stage when you need it. ???? * In order to support this properly in WineD3D we need the ability to recreate the opengl context and ???? * drawable when this is required. This is very tricky as we need to reapply ALL opengl states for the new ???? * context, need torecreate shaders, textures and other resources. ???? * ???? * The context manager already takes care of the state problem and for the other tasks code from Reset ???? * can be used. These changes are way to risky during the 1.0 code freeze which is taking place right now. ???? * Likely a lot of other new bugs will be exposed. For that reason request a depth stencil surface all the ???? * time. It can cause a slight performance hit but fixes a lot of regressions. A fixme reminds of that this ???? * issue needs to be fixed. */ ??? if (DepthStencilFormat != WINED3DFMT_D24S8) ??????? FIXME("Add OpenGL context recreation support to SetDepthStencilSurface\n"); ??? DepthStencilFormat = WINED3DFMT_D24S8; /* Changed Section June 24,08 */ /*??? if(DepthStencilFormat) {???????????????????? Changed June 19,08*/ ??? getDepthStencilBits(DepthStencilFormat, &depthBits, &stencilBits); /*??? }?? This if will always be true because of the above? so just call getDepthStencilBits */ ??? /* Find a pixel format which EXACTLY matches our requirements (except for depth) */ ??? for(i=0; i<nCfgs; i++) ????? { ??????? cfgs = &This->adapter->cfgs[i]; ??????????????????? ??????? /* For now only accept RGBA formats. Perhaps some day we will ???????? * allow floating point formats for pbuffers. */ ??????? if (cfgs->iPixelType != WGL_TYPE_RGBA_ARB) ?????????? continue; ??????? /* In window mode (!pbuffer) we need a window drawable format and double buffering. */ ??????? if (!pbuffer && !(cfgs->windowDrawable && cfgs->doubleBuffer)) ?????????? continue; ?????? /* We like to have aux buffers in backbuffer mode */ ??????? if (auxBuffers && !cfgs->auxBuffers) ?????????? continue; ??????? /* In pbuffer-mode we need a pbuffer-capable format but we don't want double buffering */ ??????? if (pbuffer && (!cfgs->pbufferDrawable || cfgs->doubleBuffer)) ???????????? continue; /* This is faster and more efficient code wise since they are all related so evaluate them together Changed June 19,08 */ ??????? if ((cfgs->redSize != redBits) || (cfgs->greenSize != greenBits) || (cfgs->blueSize != blueBits) || (cfgs->alphaSize != alphaBits)) ???????????? continue; ??????? /* In all cases make sure the number of stencil bits matches our requirements ???????? * even when we don't need stencil because it could affect performance EXCEPT ???????? * on cards which don't offer depth formats without stencil like the i915 drivers ???????? * on Linux. */ ??????? if ((stencilBits != cfgs->stencilSize) && !((This->adapter->brokenStencil && stencilBits) <= cfgs->stencilSize)) ???????????? continue; ??????? /* Check multisampling support */ ??????? if (cfgs->numSamples != numSamples) ???????????? continue; ??????? /* We try to locate a format which matches our requirements exactly. In case of ???????? * depth it is no problem to emulate 16-bit using e.g. 24-bit, so accept that. */ ???????? if (cfgs->depthSize !=? depthBits)? /* Changed June 24,08 */ ??????????? continue; ??????? /* Exit the loop as we have found a format :) */ ??????? if (exactDepthMatch) ?????????? { ??????????? TRACE("Exact Depth Match\n"); ??????????? iPixelFormat = cfgs->iPixelFormat; ??????????? break; ?????????? } ??????? if (!iPixelFormat) ????????? { ??????????? /* In the end we might end up with a format which doesn't exactly match our depth ???????????? * requirements. Accept the first format we found because formats with higher iPixelFormat ???????????? * values tend to have more extended capabilities (e.g. multisampling) which we don't need. */ ??????????? TRACE("Emulating %d\n",cfgs->iPixelFormat); ??????????? iPixelFormat = cfgs->iPixelFormat; ??????????? break; /* Added June 24,08 */ ????????? } ??? } ??? /* When findCompatible is set and no suitable format was found, let ChoosePixelFormat choose a pixel format in order not to crash. */ /*??? if (!iPixelFormat && !findCompatible) ????? { ??????? ERR("Can't find a suitable iPixelFormat\n"); ??????? return FALSE; ????? } Remarked this out. Yes it will cycle through the 3 adapters (I am running dual head and for some reason it thinks I have 3 adapters not just the 2 for dual head) Why would findCompatible not be set for all adapters? this is what the DX 9c specs? say it should do then the application picks the best of all */ ????? ??? if (!iPixelFormat) ????? { ??????? TRACE("iPixelFormat = %d FindCompatible=%d\n",iPixelFormat, findCompatible); ??????? TRACE("Falling back to ChoosePixelFormat as we weren't able to find an exactly matching pixel format\n"); ??????? /* PixelFormat selection */ ??????? ZeroMemory(&pfd, sizeof(pfd)); ??????? pfd.nSize?????????? = sizeof(pfd); ??????? pfd.nVersion????? = 1; /* Should this be hard Coded or put into a #DEFINE so it can be changed later if needed */ ??????? pfd.dwFlags????? = PFD_SUPPORT_OPENGL | PFD_DOUBLEBUFFER | PFD_DRAW_TO_WINDOW;/*PFD_GENERIC_ACCELERATED*/ ??????? pfd.iPixelType?? = PFD_TYPE_RGBA; ??????? pfd.cAlphaBits?? = alphaBits; ??????? pfd.cColorBits??? = colorBits; ??????? pfd.cDepthBits?? = depthBits; ??????? pfd.cStencilBits? = stencilBits; ??????? pfd.iLayerType? = PFD_MAIN_PLANE; ??????? iPixelFormat????? = ChoosePixelFormat(hdc, &pfd); ??????? if (!iPixelFormat) ????????? { ??????????? /* If this happens something is very wrong as ChoosePixelFormat barely fails */ ?????????? ERR("Can't find a suitable iPixelFormat\n"); ?????????? return FALSE; ????????? } ????? } ??? TRACE("Found iPixelFormat\n"); ??? return iPixelFormat; } Chris

2 1

Code Review and findings in d3d while working on figuring out why...
by celticht32＠aol.com June 24, 2008

June 24, 2008

Ok I have been wandering around the code in context.c and have found a few things that I have opened a bug on (14000) but in further looking in context.c if I comment out the lines between 237 and 245 wine seems to continue working better infact? (I no longer get no iPixel errors using wine 1.0 with the latest ATI drivers) My question is this why wouldn't you want to find a compatible mode to use and just call the next few lines where it calls choose pixel format and if that fails for what ever reason then say you cant find a suitable iPixel format? If you leave the section there the following occurs. Start up EverQuest2.exe? it calls the iPixel function 3 times for some reason without the fix in bug 14000 it fails immediately. With the fix the first one succeeds then the second and third times it returns the no iPixel format to the application. If I comment out the above section it no longer fails at all but gets farther along. before throwing an unhandled exception (which happened before I started working with this problem ) which is documented in another bug (forget the number right now). Chris p.s. if needed I can post my context.c on the bug above or to the mailing list.. .just the function I have been working on....

2 1

Re: quartz: Have thread safety in memallocator
by Rob Shearman June 24, 2008

June 24, 2008

2008/6/23 Maarten Lankhorst <m.b.lankhorst(a)gmail.com>: > @@ -286,19 +287,24 @@ static HRESULT WINAPI BaseMemAllocator_GetBuffer(IMemAllocator * iface, IMediaSa > > *pSample = NULL; > > - if (!This->bCommitted) > - return VFW_E_NOT_COMMITTED; > + EnterCriticalSection(This->pCritSect); > + if (!This->bCommitted || This->bDecommitQueued) > + hr = VFW_E_NOT_COMMITTED; > + else > + ++This->lWaiting; > + LeaveCriticalSection(This->pCritSect); > + if (FAILED(hr)) > + return hr; > > - This->lWaiting++; > if (WaitForSingleObject(This->hSemWaiting, (dwFlags & AM_GBF_NOWAIT) ? 0 : INFINITE) != WAIT_OBJECT_0) > { > - This->lWaiting--; > + InterlockedDecrement(&This->lWaiting); > return VFW_E_TIMEOUT; > } > - This->lWaiting--; > > EnterCriticalSection(This->pCritSect); > { > + --This->lWaiting; > if (!This->bCommitted) > hr = VFW_E_NOT_COMMITTED; > else if (This->bDecommitQueued) Just because you increment a variable inside a critical section, it doesn't mean that it's safe against another thread using InterlockedIncrement/Decrement on it. Either only change the variable inside a critical section or only change it using interlocked functions. -- Rob Shearman

1 0

new failing tests
by James Hawkins June 24, 2008

June 24, 2008

Hi Alex, The following commit introduces several windows test failures across the board in riched20: commit 0e9ed5c10e3ac6b253712037f0b30046a5656239 Author: Alex Villacís Lasso <a_villacis(a)palosanto.com> Date: Sun May 11 09:54:58 2008 -0500 richedit: Empty text should result in a scroll range of 0. Tests for this behavior. Please take a look at the test results and either fix the tests or send in a patch to remove them. http://test.winehq.org Thanks, James Hawkins

2 3

Re: ntdll: Add time stamps to log output.
by Dmitry Timoshkov June 24, 2008

June 24, 2008

"Peter Urbanec" <winehq.org(a)urbanec.net> wrote: > This patch will prefix every line of log output with a time stamp. > > The time stamps are formatted as [seconds.microseconds] and measured as > elapsed time from the first time a message is output. This helps with > tracking down time sensitive bugs and it may also come in handy when > investigating performance. At the very least this should be a separate debug channel, if it ever gets included at all. -- Dmitry.

2 1

Re: [resend] gdi32/tests: Add tests for GdiGetCodePage.
by Dmitry Timoshkov June 24, 2008

June 24, 2008

"Huang, Zhangrong" <hzhrong(a)gmail.com> wrote: > As discussed in Bug 4065 (http://bugs.winehq.org/show_bug.cgi?id=4065) In the bug 4065 I suggested to comment out the failing tests before sending it to wine-patches. -- Dmitry.

2 5

RE: ddraw: Stop crash when dd7 isnt installed
by Stefan Dösinger June 24, 2008

June 24, 2008

> Changelog: > ddraw: Stop crash when dd7 isnt installed Do you really think it is worth polluting the code for this case? I haven't seen a windows box without dx7 since a LONG time. If you want to prevent a crash I think it is better to add some santiy checks at the beginning of the test and skip all the tests rather than polluting every test with lots and lots of possible error conditions coming from old dx versions

1 0

[PATCH] WM_IME_SETCONTEXT is sent when a window is activated
by Christopher GAUTIER June 24, 2008

June 24, 2008

Hello, Following up on http://www.winehq.org/pipermail/wine-patches/2008-May/055400.html >> Description: >> The WM_IME_SETCONTEXT message should be sent when a window is >> (de)activated >> (source: >> http://msdn.microsoft.com/en-us/library/ms776117(VS.85).aspx) >> The value for lParam was obtained by spying on the messages when >> activating and deactivating the window. On Sat May 31, Vitaliy Margolen wrote: >Please add a test for this to user32/test/msg.c test Having read user32/test/msg.c, it seems to me that the test is already written, since the WM_IME_SETCONTEXT message is in many cases specified as following WM_ACTIVATE in the various 'message Wm*[]' structures. Please tell me if something more needs to be done. Cheers, Christopher

1 0

Re: user32:tests:msg.c Remove TODO flag from a test.
by Alexandre Julliard June 24, 2008

June 24, 2008

Anatoly Lyutin <vostok(a)etersoft.ru> writes: > The test does not falls at the current Wine. Yes it does: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so msg.c && touch msg.ok msg.c:4334: Test failed: SetWindowPos:show_visible_popup_3: the msg 0x0046 was expected, but got msg 0x0086 instead msg.c:4334: Test failed: SetWindowPos:show_visible_popup_3: the msg 0x0086 was expected, but got msg 0x0006 instead msg.c:4334: Test failed: SetWindowPos:show_visible_popup_3: the msg 0x0006 was expected, but got msg 0x0009 instead msg.c:4334: Test failed: SetWindowPos:show_visible_popup_3: the msg 0x0009 was expected, but got msg 0x0008 instead msg.c:4334: Test failed: SetWindowPos:show_visible_popup_3: the msg 0x0008 was expected, but got msg 0x0007 instead msg.c:4334: Test failed: SetWindowPos:show_visible_popup_3: the msg sequence is not complete: expected 0007 - actual 0000 msg.c:10040: Tests skipped: Skipping DBCS WM_CHAR test in SBCS codepage 'ANSI Latin 1' msg.c:10859: Tests skipped: UnhookWinEvent is not available make[2]: *** [msg.ok] Error 6 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [2/2] gdi32: implementation of CreateFontIndirectEx (fix for13064) (resent)
by Dmitry Timoshkov June 24, 2008

June 24, 2008

"Nikolay Sivov" <bunglehead(a)gmail.com> wrote: > +/*********************************************************************** > + * CreateFontIndirectExA (GDI32.@) > + */ > +HFONT WINAPI CreateFontIndirectExA( const ENUMLOGFONTEXDVA *plf ) > +{ > + if(!plf) return NULL; > + > + return CreateFontIndirectA(&(plf->elfEnumLogfontEx.elfLogFont)); > +} > + > +/*********************************************************************** > + * CreateFontIndirectExW (GDI32.@) > + */ > +HFONT WINAPI CreateFontIndirectExW( const ENUMLOGFONTEXDVW *plf ) > +{ > + if(!plf) return NULL; > + > + return CreateFontIndirectW(&(plf->elfEnumLogfontEx.elfLogFont)); > +} You neither removed the 'if(!plf)' check, nor added a test or an explanation for this. > + if(!pCreateFontIndirectExA) > + skip("CreateFontIndirectExA not implemeted on this platform\n"); > + else > + { > + memcpy(&lfex.elfEnumLogfontEx.elfLogFont, &lf, sizeof(lf)); > + hfont = create_font_ex("Arial", &lfex); > + DeleteObject(hfont); > + } Presumably CreateFontIndirectEx uses the whole ENUMLOGFONTEXDVA structure, not just LOGFONT, so you need to fully initialize it. Also please remove trailing line spaces. -- Dmitry.

2 4

Re: [PATCH 5/7] widl: Fix type_memsize to follow aliases so that the correct size is calculated.
by Dan Hipschman June 24, 2008

June 24, 2008

On Mon, Jun 23, 2008 at 10:29:11PM +0100, Rob Shearman wrote: > diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c > index 1f8695a..84115fd 100644 > --- a/tools/widl/typegen.c > +++ b/tools/widl/typegen.c > @@ -809,7 +809,9 @@ size_t type_memsize(const type_t *t, unsigned int *align) > { > size_t size = 0; > > - if (t->declarray && is_conformant_array(t)) > + if (t->kind == TKIND_ALIAS) > + size = type_memsize(t->orig, align); > + else if (t->declarray && is_conformant_array(t)) > { > type_memsize(t->ref, align); > size = 0; What type of thing is this needed for? A typedef'd type should have all the same fields as the original except for the attributes, so for most cases in type_memsize it shouldn't be necessary to check whether the type is an alias. For anything that needs to check attributes, I would think it would be better to fix the predicates (such as is_conformant_array, etc.) if they do not detect that correctly 100% of the time.

2 1

Re: [2/8] gdi32: Implementation of CreateFontIndirectEx with test(fixes bug 13064)
by Dmitry Timoshkov June 24, 2008

June 24, 2008

"Nikolay Sivov" <bunglehead(a)gmail.com> wrote: > +/*********************************************************************** > + * CreateFontIndirectExA (GDI32.@) > + */ > +HFONT WINAPI CreateFontIndirectExA( const ENUMLOGFONTEXDVA *plf ) > +{ > + if(!plf) return NULL; > + > + return CreateFontIndirectA(&(plf->elfEnumLogfontEx.elfLogFont)); > +} > + > +/*********************************************************************** > + * CreateFontIndirectExW (GDI32.@) > + */ > +HFONT WINAPI CreateFontIndirectExW( const ENUMLOGFONTEXDVW *plf ) > +{ > + if(!plf) return NULL; > + > + return CreateFontIndirectW(&(plf->elfEnumLogfontEx.elfLogFont)); Why did you add the if(!plf) check? > +static HFONT create_font_ex(const char* test, const ENUMLOGFONTEXDV* lfex) > +{ > + HFONT hfont = CreateFontIndirectExA(lfex); > + ok(hfont != 0, "CreateFontIndirectEx failed\n"); > + if (hfont) > + check_font(test, &(lfex->elfEnumLogfontEx.elfLogFont), hfont); > + return hfont; > +} You need to load CreateFontIndirectExA dynamically, otherwise the test won't run under NT4/Win9x. > static void test_logfont(void) > { > LOGFONTA lf; > + ENUMLOGFONTEXDVA lfex; > HFONT hfont; > > memset(&lf, 0, sizeof lf); > @@ -137,6 +147,10 @@ static void test_logfont(void) > hfont = create_font("Arial", &lf); > DeleteObject(hfont); > > + lstrcpyA(lfex.elfEnumLogfontEx.elfLogFont.lfFaceName, "Arial"); > + hfont = create_font_ex("Arial", &lfex); > + DeleteObject(hfont); All the code in test_logfont() fully initializes the LOGFONT before passing it to an API, the test above doesn't, is there any reason for that? -- Dmitry.

1 0

Re: richedit: Ensure caret is seen if moved past end of view over trailing spaces
by Dylan Smith June 23, 2008

June 23, 2008

You can ignore this patch, I will resend it as a series with just what is dependant on it. Sorry about sending such a such a large series of patches before (44 of them) that seemed to be dependant on each other. They actually didn't contain many dependencies on each other. I'll try to make the dependancies clearer next time. On Mon, Jun 23, 2008 at 5:10 PM, Dylan Smith <dylan.ah.smith(a)gmail.com> wrote: > To test the bug, open up Wine's wordpad (try with native and builtin > riched20), then enter a line of text that ends with enough trailing > spaces to go past the end of the richedit control. In native richedit > controls the cursor is prevented from going past end of the richedit > control so that it stays visisble while still being moved over the > spaces that continue off the end of the view. This patch makes sure > Wine's builtin richedit controls do the same thing as Windows. > > The above steps will also show another bug that I have just submitted a > patch for, with a subject "richedit: Spaces at the end of a line should > not affect alignment shift length". > > For this patch will depends on a previous patch I submitted on June 17th > in order to apply cleanly. The email for the patch had a subject > "[38/44] richedit: Hide cursor when text is selected". > --- > dlls/riched20/caret.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) >

1 0

Re: [updated] winecfg: Added Windows registration information setting
by Alex Villacís Lasso June 23, 2008

June 23, 2008

Filipe Ferreira escribió: > This is a combination of both patches from my earlier submission. The > reason I made them separate was because I am unable to test other > languages besides > English. Though, if anyone could tell me how to run wine under a > different language, I would test them. > Find out the corresponding language and country code for the particular country and language combination you want to test, then run like this in a terminal: LANG=ja_JP.UTF-8 winecfg The above example runs winecfg with Japanese resources. It is what I used to run Japanese dating sims under Wine (just to test DirectSound and msacm32 support - I hereby disclaim any implied or explicit assertion of knowledge of the Japanese language). -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

1 0

Re: widl: The offset to the pointer layout in complex structures must be positive so add an assert and fix the format string.
by Alexandre Julliard June 23, 2008

June 23, 2008

"Rob Shearman" <robertshearman(a)gmail.com> writes: > Otherwise we could generate an incorrect format string and crash in a > weird way at runtime instead. Looks like the assert works ;) ../../tools/widl/widl -I. -I. -I../../include -I../../include -D__WINESRC__ -D_OLEAUT32_ -DCOM_NO_WINDOWS_H -p -P oleaut32_oaidl_p.c oleaut32_oaidl.idl widl: typegen.c:1856: write_struct_tfs: Assertion `absoff >= *tfsoff' failed. make[2]: *** [oleaut32_oaidl_p.c] Aborted -- Alexandre Julliard julliard(a)winehq.org

2 1

how to run wine under a different language
by Detlef Riekenberg June 23, 2008

June 23, 2008

On Mo, 2008-06-23 at 02:41 -0400, Filipe Ferreira wrote: > (Anyone care to share how to run wine under a different language?) - Install the language - Select the language from "locale -a" LC_ALL=de_DE.utf8 wine winecfg LC_ALL=en_US.utf8 wine winecfg LC_ALL=it_IT.utf8 wine winecfg -- By by ... Detlef

1 0

Re: dinput: Fix name clashes (Resend #2)
by Alexandre Julliard June 23, 2008

June 23, 2008

Andrew Talbot <andrew.talbot(a)talbotville.com> writes: > Is there anything wrong with this patch? (Having two "JoystickImpl" types in > the same dll confounds some static analyisis programs.) The types are local to the C file so there is no clash. If some tools don't understand that they need to be fixed. -- Alexandre Julliard julliard(a)winehq.org

2 3

wine 1.0
by Damoun D. June 23, 2008

June 23, 2008

Hi Dan, I just want to say that Wine 1.0 is fantastic! Also, I was wondering if by any chance you have a Google Grandcentral invite you can send me. Thanks so much, Damoun

1 0

Re: richedit: (9/8) EM_POSFROMCHAR tests
by Alex Villacís Lasso June 23, 2008

June 23, 2008

Alex Villacís Lasso escribió: > Found while debugging #13864 . While it does not solve the bug, it is > worthwhile to get this out of the way. > > EM_POSFROMCHAR can return the position of the requested character > through either a pointer to a POINTL through wParam, or through the > result value. When using the pointer method, native returns 0, builtin > returns MAKELONG(x,y) (just like the return method). Builtin should > choose one or the other, but not both at the same time. > > Changelog: > * When returning position through wParam pointer, EM_POSFROMCHAR must > return 0 as LRESULT. > * Add tests for EM_POSFROMCHAR for 1.0 and 2.0. > > ------------------------------------------------------------------------ > > Was there something wrong with this patch? -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 1

oleaut32/tests: initialize pointer before sending it over the wire??
by Dan Kegel June 23, 2008

June 23, 2008

While looking at the valgrind warning in http://kegel.com/wine/valgrind/logs-2008-06-20/vg-oleaut32_tmarshal.txt Conditional jump or move depends on uninitialised value(s) at serialize_param (tmarshal.c:736) by serialize_param (tmarshal.c:744) by xCall (tmarshal.c:1414) by ??? by func_tmarshal (tmarshal.c:1179) by run_test (test.h:449) by main (test.h:498) Uninitialised value was created by a stack allocation at test_typelibmarshal (tmarshal.c:762) The problem happens during a call to this method where widget is a pointer to an uninitialized pointer which will receive the pointer to the widget: interface IKindaEnumWidget : IUnknown { HRESULT Next( [out] IWidget **widget); I discovered that the attached patch prevented the problem. I don't quite understand why; at first glance, widget is an out parameter from the function, why would it be dereferenced while serializing the call?

3 3

Missed Patches
by Alistair Leslie-Hughes June 23, 2008

June 23, 2008

Hi, Any wrong with my patches gdi32: stop crash in font tests mapi32: stop crash under win98 secur32: fix crash under win98 shell32: Stop crash when an error occurs msxml3: Added xml Input Callbacks to support loading files from a Wine windows drive Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH] comctl32: Use ms sans serif in ip controls.
by Alexandre Julliard June 23, 2008

June 23, 2008

"Lei Zhang" <thestig(a)google.com> writes: > @@ -191,6 +194,10 @@ static LRESULT IPADDRESS_Create (HWND hwnd, const CREATESTRUCTA *lpCreate) > infoPtr->Enabled = TRUE; > infoPtr->Notify = lpCreate->hwndParent; > > + SystemParametersInfoW(SPI_GETICONTITLELOGFONT, 0, &logFont, 0); > + strcpyW(logFont.lfFaceName, MSSanSerif); > + hFont = CreateFontIndirectW(&logFont); Do you really need to hardcode MS Sans Serif? The other controls don't do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Development plans
by Alexandre Julliard June 23, 2008

June 23, 2008

Hi folks, Again, congrats to everybody for the 1.0 release! Now that I'm starting to recover from the shock of having actually shipped 1.0, here are a few notes on future development: 1) Code freeze is over, patches are accepted again. If you sent patches and they didn't get applied during code freeze, please rebase them against 1.0 and resend them. 2) Development will continue as usual in the git "master" branch. The 1.1.x development releases will be made from that branch every other Friday. 3) There is now a git "stable" branch, where only important bug fixes will be committed. The 1.0.x maintenance releases will be made from that branch whenever enough changes have accumulated to justify a release. The process I suggest for the 1.0.1 release is as follows: - all bugs should be fixed in the master branch first - once a bug fix has been committed to master, the corresponding bug report should be marked fixed, with the sha1 of the commit fixing it - the bug report should then be put into the 1.0.1 milestone. This will allow me to periodically query for 1.0.1 bugs that are fixed in master and cherry-pick the corresponding commits into the stable branch. -- Alexandre Julliard julliard(a)winehq.org

6 8

Re: avifil32: The importlib has the name vfw32
by Alexandre Julliard June 23, 2008

June 23, 2008

Detlef Riekenberg <wine.dev(a)web.de> writes: > avifil32: The importlib has the name vfw32 Not really, vfw32 is a common import lib for several dlls, not just avifil32. This will require some work to fix properly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/3] riched20: Implement ITextDocument_fnGetSelection.
by Alexandre Julliard June 23, 2008

June 23, 2008

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > @@ -532,6 +538,709 @@ static const ITextDocumentVtbl tdvt = { > ITextDocument_fnRangeFromPoint > }; > > +/*** IUnknown methods ***/ > +static HRESULT WINAPI ITextSelection_fnQueryInterface( > + ITextSelection *me, > + REFIID riid, > + void **ppvObj) > +{ > + ITextSelectionImpl *This = (ITextSelectionImpl *) me; > + > + TRACE("%p %s\n", This, debugstr_guid(riid)); > + > + *ppvObj = NULL; > + if (IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_ITextSelection)) > + { > + *ppvObj = me; > + return S_OK; > + } > + > + return E_NOINTERFACE; > +} > + > +static ULONG WINAPI ITextSelection_fnAddRef( > + ITextSelection *me) > +{ > + return 2; > +} > + > +static ULONG WINAPI ITextSelection_fnRelease( > + ITextSelection *me) > +{ > + return 1; > +} The ref counting isn't correct. Most likely ITextSelection should be implemented directly by the main object, and share its ref count. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winecfg: Added Windows registration information setting
by Dmitry Timoshkov June 23, 2008

June 23, 2008

"Filipe Ferreira" <filipe(a)tinypad.net> wrote: > Added english controls to winecfg About tab for registration info in En.rc > Added code for retrieving and setting registration info in main.c > Added textbox identifiers in resource.h Please add all the required changes to all .rc files, not only to En.rc. Otherwise all previously valid language resources become suddenly out of the sync. -- Dmitry.

1 0

Re: kernel32: initialize hole in struct in WaitNamedPipeW to avoid Valgrind warnings, take 2 (resend)
by Alexandre Julliard June 23, 2008

June 23, 2008

"Dan Kegel" <dank(a)kegel.com> writes: > Back in February, I tried doing this with a real memset, > but Alexandre demurred, probably objecting to the slight overhead. > So here's a version with no overhead unless you > have the Valgrind development headers installed, > and is done with Valgrind client notations. This isn't the right place for this, and pretty much all ioctls have the same potential problem. You should add a valgrind suppress for the whole category of such problems. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] wined3d: Report post pixelshader blending on WINED3DFMT_A16B16G16R16F
by Roderick Colenbrander June 23, 2008

June 23, 2008

Hi, I don't think we should implement it this way. For instance on GeforceFX cards blending is performed in software. Not too long ago (before 1.0) I also sent a patch for this e.g. by doing an extension check. I think I checked for ARB_color_buffer_float in combination with half pixel support. Roderick -- Ist Ihr Browser Vista-kompatibel? Jetzt die neuesten Browser-Versionen downloaden: http://www.gmx.net/de/go/browser

2 2

RPC questions
by Kai Blin June 23, 2008

June 23, 2008

Hi folks, hey Rob, I've been wanting to get into Wine RPC development for ages, and now I finally got myself to start reading through some of the code in dlls/rpcrt4. Now, after going over rpc_bindings.c, tests/rpc.c and tests/server.c, I've got a couple of questions about that code. I'd like to add a test for RpcBindingSetAuthInfo. It seems like server.c is the place to put it, right? If I want to use RPC_C_AUTHN_WINNT, I need server side authentication for this test. Has anyone ever tried that before? I'm assuming I might need to run Wine as root in order to be able to connect to the winbindd privileged pipe in order to check the user, need to try that in "plain" ntlm_auth first. Rob, you said you set up RPC so requests for Negotiate would be thumped to NTLM. I can't see that in RpcBindingSetAuthInfo. Is that patch in the tree, or is it too hacky? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 1

today's valgrind results online
by Dan Kegel June 23, 2008

June 23, 2008

Online at http://kegel.com/wine/valgrind/20071002/ (I now include more info about memory leaks, but I still only report anything if there was an invalid memory reference.) The following tests were fixed in git yesterday, and no longer have any valgrind warnings: comctl32/rebar comctl32/status crypt32/chain crypt32/crl crypt32/msg cryptnet/cryptnet user32/msg wintrust/softpub Juan thinks nearly all of the remaining crypt32 errors can be suppressed (some are intentional). Here are the directories that still have warnings: advapi32 advpack cabinet comctl32 crypt32 d3d8 d3d9 d3dx8 dplayx dsound gdi32 gdiplus hlink kernel32 mlang msacm32 mscms mshtml msi msvcrt msxml3 netapi32 ntdll ole32 oleaut32 quartz riched20 riched32 rpcrt4 rsaenh setupapi shdocvw shell32 urlmon user32 usp10 wininet winmm wintrust - Dan

3 4

re: richedit: WM_SETTEXT must immediately autodetect URLs, without waiting for a WM_CHAR.
by Dan Kegel June 23, 2008

June 23, 2008

Hi Alex! I just noticed a valgrind warning in richedit that might have something to do with your new test code in http://source.winehq.org/git/wine.git/?a=commit;h=38d7ba6eff6757b83b54b0485… The warning is: Conditional jump or move depends on uninitialised value(s) at test_EM_AUTOURLDETECT (editor.c:1559) by func_editor (editor.c:4203) by run_test (test.h:449) by main (test.h:498) Uninitialised value was created by a client request at mark_block_uninitialized (heap.c:164) by RtlAllocateHeap (heap.c:1239) by heap_alloc (editor.h:28) by RichEditWndProc_common (editor.c:2557) by RichEditWndProcA (editor.c:3353) by ??? (library.h:163) by call_window_proc (winproc.c:457) by WINPROC_call_window (winproc.c:2207) by call_window_proc (message.c:1610) by send_message (message.c:2434) by SendMessageA (message.c:2579) by test_EM_AUTOURLDETECT (editor.c:1545) by func_editor (editor.c:4203) by run_test (test.h:449) by main (test.h:498) Could you have a look at it? Thanks, Dan

1 0

Re: msxml3/tests: VT_EMPTY is not a string (resend 2)
by Paul Vriens June 23, 2008

June 23, 2008

Dan Kegel wrote: > This time using NULL instead of (void *) 0. > Hi Dan, - ok(lstrlenW(V_BSTR(&vValue)) == 0, "Expected empty value\n"); + ok(V_BSTR(&vValue) == (void *)0, "Expected null value\n"); Still using (void *)0 though. -- Cheers, Paul.

1 0

re: programs: add calc.exe
by Dan Kegel June 23, 2008

June 23, 2008

> I see he has taken the page down. Maybe drop the guy an email and see > if he still has the sources laying around. A little google searching found it's still there, just moved: http://jebriggs.com/winecalc/ Source is all there, about 5KLOC. - Dan

1 0

Re: programs: add calc.exe
by Steven Edwards June 23, 2008

June 23, 2008

On Sun, Jun 22, 2008 at 10:32 AM, Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > Hi, i noticed this while running Log Book Pro (http://logbookpro.com/) > That program has a menuentry to start Windows calculator, but it does > nothing, as wine does not implement this. With the attached patch at least a > calculator is started, instead of doing nothing. There was a Calc knock off sent to us a while back, you might try merging it in instead http://www.winehq.org/pipermail/wine-patches/2004-January/009481.html -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 1

Website down
by Austin English June 22, 2008

June 22, 2008

Did we get slashdotted/dugg to death? -Austin

6 6

Re: msi [6/6]: Rewrite the PublishProduct test to only check the registry changes
by Paul Vriens June 22, 2008

June 22, 2008

James Hawkins wrote: > Hi, > > Changelog: > * Rewrite the PublishProduct test to only check the registry changes. > > dlls/msi/tests/install.c | 148 +++++++++++++++++++++++++++------------------- > 1 files changed, 87 insertions(+), 61 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi James, I've noticed some (new) failure for the msi/install test: + CHECK_DEL_REG_STR(hkey, "Clients", ":"); + } This one is a REG_MULTI_SZ on my W2K3 box (and from the looks of the test results probably the same on XP/W2K3). The macro CHECK_DEL_REG_STR or actually the function check_reg_str checks only for REG_SZ and REG_EXPAND_SZ. I'm not sure what the fix should be: - replace the check for REG_EXPAND_SZ by REG_MULTI_SZ - add the REG_MULTI_SZ as well to the check -- Cheers, Paul.

2 1