June 2008 - Wine-Devel - list.winehq.org

Re: [PATCH] shell32: SHFileOperation: test added
by James Hawkins June 11, 2008

June 11, 2008

On Wed, Jun 11, 2008 at 12:01 PM, Vitaly Perov <vitperov(a)etersoft.ru> wrote: > Changelog: > - shell32: test added. It check whether SHFileOperation could correctly work > with input files mask '*.*' > + retval = SHFileOperationA(&shfo); + ok(retval == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", retval); + ok(!file_exists("testdir2\\one.txt"), "Expected one.txt to not exist\n"); Please don't add more of the weird spacing for the ok's. That is a byproduct of a huge patch that I sent to reduce the number of changes, and it just hasn't been fixed yet. -- James Hawkins

1 0

Compiling wine-1.0-rc3
by Alexandrov Anton June 11, 2008

June 11, 2008

Good afternoon. I tried to compile wine-1.0-rc3 and got this message: ------ ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./acledit.spec main.o -o acledit.dll.so -lkernel32 ../../libs/port/libwine_port.a winebuild: Cannot read main.o winegcc: ../../tools/winebuild/winebuild failed ------ I hadn't use any special options (only "./configure", "make depend && make"). gcc version: 4.1.2 linux kernel: 2.6.24 -- All the best, Alexandrov Anton.

1 0

Re: dsound: notification order
by Vitaliy Margolen June 11, 2008

June 11, 2008

Ulrich Hecht wrote: > Hi! > > This fixes sound in Ootake (http://www.ouma.jp/ootake/) Looks like > DSBPN_OFFSETSTOP is not always the last element. > > - /* DSBPN_OFFSETSTOP has to be the last element. So this is */ > - /* OK. [Inside DirectX, p274] */ > - /* */ > - /* This also means we can't sort the entries by offset, */ > - /* because DSBPN_OFFSETSTOP == -1 */ > + /* DSBPN_OFFSETSTOP is not necessarily the last element. */ Don't remove all the comments. They are still mostly valid. Just add that it's not always true for some broken apps. > if (offset == DSBPN_OFFSETSTOP) { > if (dsb->state == STATE_STOPPED) { > SetEvent(event->hEventNotify); > TRACE("signalled event %p (%d)\n", event->hEventNotify, i); > - return; > - } else > - return; Much better fix and easier to understand would be replacing "returns" for "continue". Then you won't need to reformat the whole block. Something like: @@ -247,9 +247,8 @@ void DSOUND_CheckEvent(const IDirectSoundBufferImpl *dsb, DWORD playpos, int len if (dsb->state == STATE_STOPPED) { SetEvent(event->hEventNotify); TRACE("signalled event %p (%d)\n", event->hEventNotify, i); - return; - } else - return; + } + continue; Vitaliy.

1 0

Wine + Fedora
by Louis Lenders June 11, 2008

June 11, 2008

Hi, just thought dropping a note here so you'd know: the troubles reported for wine+fedora 9, now also affect fedora 8. Last saturday i did a 'yum update', and after that about all wine-applications froze my computer. Only a hard reboot helped... Solved it by reverting back to kernel 2.6.24.7-92.fc8 Just in case a new wine-1.0 release comes out, and fedora-users start whining "wine 1.0 is really crap, it freezes my computer" , hope this will be fixed soon.

3 5

RE: ddraw: modify Direct3D device name
by Stefan Dösinger June 11, 2008

June 11, 2008

> Descent FreeSpace: The Great War and Descent FreeSpace 2 fail to detect > hardware acceleration through Direct3D when enumerating devices, they > expect the device name string to begin with "Direct3D - " > > This patch enables the Direct3D mode to be used. I am not entirely sure about this. I think there were other apps(Quicktime?) which depend on some other name. I think the best is to see which name Windows uses, make ddraw.dll read the name from WineD3D, and make WineD3D return the same name Windows does for the detected card.

2 2

Re: wininet: Make sure URL is terminated in InternetCrackUrlA.
by Alexandre Julliard June 10, 2008

June 10, 2008

Hans Leidekker <hans(a)it.vu.nl> writes: > Fixes http://bugs.winehq.org/show_bug.cgi?id=1968 > as well as a bunch of Valgrind warnings in the url test module. > > -Hans > > Changelog > Make sure URL is terminated in InternetCrackUrlA. The bug is in InternetCrackUrlW, it shouldn't require the string to be null-terminated. -- Alexandre Julliard julliard(a)winehq.org

3 3

Trying to build rc4 for MacOS, having problems with libpng, libjpeg, etc.
by Timothy Normand Miller June 10, 2008

June 10, 2008

Hi. I'm not subscribed. I'm trying to build rc4 for MacOS (Leopard), and I'm running into some problems, and I hope I'm not a bother to ask for some help. When I do ./configure, I get the following messages: onfigure: WARNING: libjpeg development files not found, JPEG won't be supported. configure: WARNING: libpng development files not found, PNG won't be supported. (and several other similar ones) I know for a fact that these libraries are installed under /sw (via Fink), along with the include files, but no matter what I do, I can't get get configure to find them. Here's how I'm trying to do it so far: export LDFLAGS=-L/sw/lib export LIBS="-lpng -ljpeg" ./configure --prefix=/sw --exec-prefix=/sw What am I missing? Thanks! -- Timothy Normand Miller http://www.cse.ohio-state.edu/~millerti Open Graphics Project

2 3

Re: gdi32: stop gdi font test crashing under win98
by Dmitry Timoshkov June 10, 2008

June 10, 2008

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote: > if (!*font_name && font_charset == DEFAULT_CHARSET) /* do it only once */ > { > + LOGFONT lf; > + memset(&lf, 0, sizeof(LOGFONT)); > + > efd.total = 0; > SetLastError(0xdeadbeef); > ret = EnumFontFamilies(hdc, NULL, arial_enum_proc, (LPARAM)&efd); > @@ -1333,7 +1336,7 @@ static void test_EnumFontFamilies(const char *font_name, INT font_charset) > > efd.total = 0; > SetLastError(0xdeadbeef); > - ret = EnumFontFamiliesEx(hdc, NULL, arial_enum_proc, (LPARAM)&efd, 0); > + ret = EnumFontFamiliesEx(hdc, &lf, arial_enum_proc, (LPARAM)&efd, 0); The test must use NULL in order to match the EnumFontFamilies results above. If it causes the crash under Win9x the test should be explicitly skipped on that platform. -- Dmitry.

1 0

Re: winex11.drv: Do not crash if UploadGlyph failed
by Alexandre Julliard June 10, 2008

June 10, 2008

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > this patch fixes the Firefox crashes reported in the bugs 4762 and 12307. > > Changelog: > winex11.drv: Do not crash if UploadGlyph failed. I don't think that's correct, it should still display the valid glyphs and use a replacement char for the invalid ones. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: Stop shlfileop tests crashing under win98
by Dan Kegel June 10, 2008

June 10, 2008

Alistair wrote: >- /* try an invalid list, only one null terminator */ >- init_shfo_tests(); >- shfo.pFrom = ""; >- shfo.wFunc = FO_DELETE; >- ret = SHFileOperation(&shfo); >- ok(ret == ERROR_ACCESS_DENIED, "Expected ERROR_ACCESS_DENIED, got %d\n", ret); >- ok(file_exists("test1.txt"), "Expected test1.txt to exist\n"); >+ /* This crashes under win98 */ >+ if(0) >+ { >+ /* try an invalid list, only one null terminator */ Hey Allistair, that paragraph looks like it was buggy - it should have had test1.txt followed by a single nul and then twice MAXPATH nonnulls and then a double nul, like the similar tests I fixed in http://www.winehq.org/pipermail/wine-patches/2008-May/055371.html As it is, there's no way FO_DELETE could see test1.txt to maybe delete it. James, do you agree? Perhaps you could leave it enabled if you fixed it like the ones I fixed. (Or tried to fix; sadly, Alexandre hasn't committed it yet. Why?) - Dan

3 3

Re: ddraw: Fix Setmaterial with a test
by Vitaliy Margolen June 10, 2008

June 10, 2008

David Adam wrote: > The test succeded in my windows XP box. > You have only ddraw test and no d3d test. Vitaliy.

1 0

Re: [ole32/tests 2/2] Fix crash on NT4 and below
by Rob Shearman June 10, 2008

June 10, 2008

2008/6/10 Paul Vriens <paul.vriens.wine(a)gmail.com>: > This 'fixes' the crash on win9x and NT4. > > @@ -1130,11 +1130,15 @@ static void test_data_cache(void) > hr = IOleCache_Uncache(pOleCache, 0xdeadbeef); > ok(hr == OLE_E_NOCONNECTION, "IOleCache_Uncache with invalid value should return OLE_E_NOCONNECTION instead of 0x%x\n", hr); > > - hr = IOleCache_Cache(pOleCache, NULL, 0, &dwConnection); > - ok(hr == E_INVALIDARG, "IOleCache_Cache with NULL fmtetc should have returned E_INVALIDARG instead of 0x%08x\n", hr); > + /* Both tests crash on NT4 and below */ > + if (0) > + { > + hr = IOleCache_Cache(pOleCache, NULL, 0, &dwConnection); > + ok(hr == E_INVALIDARG, "IOleCache_Cache with NULL fmtetc should have returned E_INVALIDARG instead of 0x%08x\n", hr); > > - hr = IOleCache_Cache(pOleCache, NULL, 0, NULL); > - ok(hr == E_INVALIDARG, "IOleCache_Cache with NULL pdwConnection should have returned E_INVALIDARG instead of 0x%08x\n", hr); > + hr = IOleCache_Cache(pOleCache, NULL, 0, NULL); > + ok(hr == E_INVALIDARG, "IOleCache_Cache with NULL pdwConnection should have returned E_INVALIDARG instead of 0x%08x\n", hr); > + } > > for (fmtetc.cfFormat = CF_TEXT; fmtetc.cfFormat < CF_MAX; fmtetc.cfFormat++) > { This test was added in response to a real application doing exactly this, so I think the test does have value when run on Win 2000+. Therefore, I think a version check would be better than "if (0)". -- Rob Shearman

2 1

Re: shell32: stop shlfolder tests crashing under win98
by Paul Vriens June 10, 2008

June 10, 2008

Alistair Leslie-Hughes wrote: > Hi, > Moved the null pointer checker to before it's first used. > > Changelog: > shell32: stop shlfolder tests crashing under win98 > > Best Regards > Alistair Leslie-Hughes > > > ------------------------------------------------------------------------ > > While your at it, could you add a skip message? -- Cheers, Paul.

1 0

Re: gdi32: Use 0xffff as a default character as Vista does
by Reece Dunn June 10, 2008

June 10, 2008

2008/6/10 Dmitry Timoshkov <dmitry(a)codeweavers.com>: > Hello, > > this patch fixes the problem reported in the bug 12305. In Wine Tahoma > character ':' is mapped to glyph index 0x1f, and that seems to be confusing > Firefox. > + TM.tmDefaultChar = pOS2->usDefaultChar ? pOS2->usDefaultChar : 0xffff; There is a UNICODE_NOCHAR constant for this. - Reece

2 1

Re: msxml3: tests/xmlelem.c: VT_EMPTY is not a string
by Michael Stefaniuc June 9, 2008

June 9, 2008

Dan Kegel wrote: > Casting a VT_EMPTY to a string gets you a null string. > The test was doing that and taking the string length, then comparing to zero. > Better to simply compare to null; that's a stronger test, and > avoids generating a behind-the-scenes exception. > > Passes on Wine and XP, and makes Valgrind output a bit easier on the eyes. > > > ------------------------------------------------------------------------ > diff --git a/dlls/msxml3/tests/xmlelem.c b/dlls/msxml3/tests/xmlelem.c > index 61a2300..229de78 100644 > --- a/dlls/msxml3/tests/xmlelem.c > +++ b/dlls/msxml3/tests/xmlelem.c > @@ -78,7 +78,7 @@ static void test_xmlelem(void) > hr = IXMLElement_getAttribute(element, str, &vValue); > ok(hr == S_FALSE, "Expected S_FALSE, got %d\n", hr); > ok(V_VT(&vValue) == VT_EMPTY, "Expected VT_EMPTY, got %d\n", V_VT(&vValue)); > - ok(lstrlenW(V_BSTR(&vValue)) == 0, "Expected empty value\n"); > + ok(V_BSTR(&vValue) == (void *)0, "Expected null value\n"); Is there a problem with using NULL instead of (void *)0? bye michael

2 1

Re: notepad: updated French translation
by Laurent Vromman June 9, 2008

June 9, 2008

Hi, I don't know if it is important since the translation is grammatically correct, but in windows (I checked on XP SP2), the exact translation is "À &propos du Bloc-notes..." and not "À &propos de Bloc-notes..." Laurent Jonathan Ernst wrote: > ------------------------------------------------------------------------ > > >

3 4

Please have a look at the current Valgrind warnings
by Dan Kegel June 9, 2008

June 9, 2008

After a few days of cleaning up Valgrind warnings in the Wine source tree, and adding suppressions where it made sense. I've whittled the list of Valgrind warnings down to 300 or so. This list is short enough that a mortal can look upon it without dispair, and even see a number of things that might be real bugs. The histogram of frequent errors is at http://kegel.com/wine/valgrind/logs-2008-06-08.counts.txt and shows one call stack per line (only top three locations are represented for each call stack). A few groups of warnings stand out: 10 of them are invalid calls to free() or friends, 30 of them involve WideCharToMultiByte, 50 of them are in ds3d or ds3d8, and 60 of them are in Gecko. (Ooodles and oodles are caused by nvidia's libgl, libfontconfig, libexpat, and libc; most of these are suppressed, or you'd die of bordom or anger reading the logs.) As before, the log broken out by directory is at http://kegel.com/wine/valgrind/logs-2008-06-08/ The full log is at http://kegel.com/wine/valgrind/logs-2008-06-08.log.gz This is run with --track-origins=yes, so you get nifty stack tracebacks for where the undefined values got their initial, um, nonvalue. This is often quite helpful for narrowing down the cause. The diff against CVS of the tree I ran this on is at http://kegel.com/wine/valgrind/logs-2008-06-08-patch.txt and is mostly the valgrind cleanup patches I've written that have not yet been committed (plus one rough one from Juan). It's given for completeness; I'll resubmit the individual patches once 1.0 is out. Oh, and the suppressions file I use is rather bigger now. As always, it's at http://kegel.com/wine/valgrind/valgrind-suppressions If you've read this far, congratulations and thanks. Please consider triaging one of these warnings. Just pick one at random, and if you really figure it out, please submit a fix; be sure to include the valgrind warning in the description of the patch. Even if all you figure out is how to improve the test and thereby not generate Valgrind warnings, that's great, please send in your patch. Every test we make squeaky-clean improves the signal-to-noise ratio for finding real problems. (But please don't submit any change you don't really understand, or that seems risky. The goal is not to clean up Valgrind warnings; it's to improve the quality of the test suite.) - Dan

2 1

Wine Profiling
by Stephen Eilert June 9, 2008

June 9, 2008

Hi, I'd like to know what's the procedure being used to profile Wine's code. More specifically, I want to try to track down slowdowns in some applcations, which requires profiling to identify where the bottlenecks are. Are there any specific procedures or utilities to instrument and generate profiling reports? Stephen

3 2

Re: Downgrade lack of libxslt from configure warning to notice
by Vitaliy Margolen June 8, 2008

June 8, 2008

Gerald Pfeifer wrote: > On a test system of mine which does not feature too many packages I am > getting the following: > > configure: libsane development files not found, scanners won't be supported. > configure: libgphoto2 development files not found, digital cameras won't be supported. > configure: libldap (OpenLDAP) development files not found, LDAP won't be supported. > configure: libcapi20 development files not found, ISDN won't be supported. > configure: WARNING: libxslt development files not found, xslt won't be supported. > > Looking that libxslt only seems to be used by msxml3, I am wondering > whether this really is worth a warning? > No, if anything any missing part should stop configure and exit with error. And if you force compiling without some feature Wine should be marked "tainted". So all bug reports and calls for help can be easily filtered and ignored. In short NEVER ignore missing dependencies. You never know what windows app might use and why. Vitaliy.

1 0

Re: Downgrade lack of libxslt from configure warning to notice
by Marcus Meissner June 8, 2008

June 8, 2008

On Sun, Jun 08, 2008 at 10:42:32PM +0200, Gerald Pfeifer wrote: > On a test system of mine which does not feature too many packages I am > getting the following: > > configure: libsane development files not found, scanners won't be supported. > configure: libgphoto2 development files not found, digital cameras won't be supported. > configure: libldap (OpenLDAP) development files not found, LDAP won't be supported. > configure: libcapi20 development files not found, ISDN won't be supported. > configure: WARNING: libxslt development files not found, xslt won't be supported. > > Looking that libxslt only seems to be used by msxml3, I am wondering > whether this really is worth a warning? > > How about the patch below? It probably should be an error, since otherwise msxml3 is only partial functional aka "broken". Ciao, Marcus

1 0

hey, small wine job on a rent-a-coder site
by Dan Kegel June 8, 2008

June 8, 2008

Anyone want to do a Picasa-like packaging of a commercial app? I just saw http://www.getacoder.com/projects/create_prm_deb_package_80623.html The offered fee is about 10x too small, but perhaps somebody would be interested in the challenge anyway.

1 0

RE: Some feedfack for string {\style} on msi
by Ge van Geldorp June 8, 2008

June 8, 2008

> I am trying to fix the bug 13408 related with ActiveSync, but > i need some information of how and when appear the string > {\style} on msi. > I need some specification or url for begin. Try http://msdn.microsoft.com/en-us/library/aa367524(VS.85).aspx (or search for "Adding Controls and Text").

2 1

re: Valgrind and COD4
by Dan Kegel June 8, 2008

June 8, 2008

Rico schrieb: > I'd like to run valgrind + wine + cod4. > [But when I run valgrind on my game], I got the preloader problem. That's a known problem, but it's not a serious one. [Still, John Reiser is working on a fix for it.] The real problem in your log is this: Memcheck: mc_main.c:817 (get_sec_vbits8): Assertion 'n' failed. Memcheck: get_sec_vbits8: no node for address 0x6032050 (0x6032054) You're using an old version of Valgrind, and wine is blowing its little mind. Please switch to building Valgrind out of svn; see http://wiki.winehq.org/Wine_and_Valgrind Good luck, and let me know how it goes! - Dan

2 3

Bugzilla bugs.winehq.org and it's git out of sync
by Jan Zerebecki June 8, 2008

June 8, 2008

The git repository contains version 3.0.4 but bugs.winehq.org still shows 3.0.2 . Can anyone who has access to it look after that? Thanks. Jan

2 1

Re: [2/2] gdi32/dib: Fix palette of 1bpp DIB in GetDIBits
by Eric Pouech June 8, 2008

June 8, 2008

Michael Karcher a écrit : > Windows always generates a black/white palette for 1 bit DIBs > generated from DDBs. Copying from the current palette only takes > place for color DDBs (not explicitly mentioned in MSDN), and only > if depth equal (MSDN states it, explicitly). > --- > As mentioned in [1/2], this series is intended to fix #6519, but a > third patch is needed additionally to these two patches. The patch > by Eric in the buglog does that job, but I think there is an "more > obviously correct" solution to it. I let Eric submit a patch if he > wants, as he tracked down the problem. If he tells me to go on, I > will submit my version myself instead. > I didn't retest after your two patches, but basically what my patch does is: - ensure we convert non black pixels (from DIB) into white pixels (in monochrome bitmap) in all cases - zero out the end of lines (after last pixel up to next dword aligned bit) this bug (and the mentionned 3 patches) are IMO good candidates for 1.0 the last item of this patch is not mandatory here, and can be dropped before inclusion to 1.0 (if needed) regarding this last patch and Michael comment: I'm only concerned with having the best fix in wine (who ever wrote it) so what's your idea about the fix ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 1

AutoCad and wine
by Louis Lenders June 8, 2008

June 8, 2008

This seems to be a must have for many people. Would be nice if we could have this running in near futurfe. I found that you can download a few old trialversions from http://www.brothersoft.com/autocad-download-78215.html (this is autocad2006l on the right side you can see the downloadlinks for 2004/2007/2008 as well) I'm currently testing AutoCAD 2004 and with a bit workarounds/tweaking it seems to run but the main issues seem to be with the installer; I'll add some info to the appdb; i'll test other versions lateron; if someone wants to join testing feel welcom ;)

1 0

kernel/debugger tests and win9x/winme
by Paul Vriens June 8, 2008

June 8, 2008

Hi, I (once more) had a look at the registry on my win95 box and found : HKLM\Software\Microsoft\Windows NT\CurrentVersion This is because we create that key ourselves if it doesn't exist. "Windows NT" is of course not present on a (normal) win98/winme box so I was wondering how we could change this test. It appears that win9x uses win.ini for the same purpose. Should we change the test to: 1. check if "HKLM\Software\Microsoft\Windows NT" exist 2. if it exist do our normal thing 3. if it doesn't use win.ini ? Or should we check for the "HKLM\Software\Microsoft\Windows NT" key and if doesn't exist skip all tests ? (We do have these keys lingering around after our winetest though). -- Cheers, Paul.

1 0

Some feedfack for string {\style} on msi
by Ángel Guzmán Maeso June 7, 2008

June 7, 2008

I am trying to fix the bug 13408 related with ActiveSync, but i need some information of how and when appear the string {\style} on msi. I need some specification or url for begin. Cheers. -- Shakaran

1 0

Re: kernel: updated French translation
by Laurent Vromman June 7, 2008

June 7, 2008

There are a few mistakes in your translations : The right translation for "Overflow" is "Dépassement", not "Dépacement" You often use the word "Mauvais" as a translation for "Bad". Sometimes, it could be better not to translate literally. For example, I think "Niveau de pilote incorrect" is a better translation for "Bad driver level" than "Mauvais niveau de pilote". You should try to avoid "Mauvais" anytime you can. Last thing : I'm not sure "Sémaphore" is a female word in french : http://fr.wikipedia.org/wiki/S%C3%A9maphore_(informatique) Laurent Jonathan Ernst wrote: > ------------------------------------------------------------------------ > > >

4 3

Valgrind and COD4
by Rico June 7, 2008

June 7, 2008

Hi, I'd like to run valgrind + wine + cod4. But there is a problem: The preloader problem. When I run valgrind --trace-children=yes ~/Desktop/wine/native/wine iw3sp.exe, I got the preloader problem. When I run ~/Desktop/wine/native/wine iw3sp.exe there is no preloader problem. Any hints on this? (The same applies for valgrind+wine+notepad.) Attached is the output from the valgrind run. Cheers Rico

1 0

Regression in winebrowser found and identified
by Pavel Troller June 7, 2008

June 7, 2008

Hi! Today we've found that winebrowser gets invalid URL consisting of many question marks instead of correct URL, in at least two cases: 1) Attempt to buy a game in Steam (yes, we are regularly doing that) 2) Trying to buy a program called CPT-Master from 3am systems, free demo which shows the problem when "Buy now" button is pressed in its welcome screen, can be downloaded at http://www.3amsystems.com/products/CPT-Master.exe The following commit has been identified as making the regression: e547cf7043e36fecfe5e23d1d6f93a9c5ba89c46 is first bad commit commit e547cf7043e36fecfe5e23d1d6f93a9c5ba89c46 Author: Hans Leidekker <hans(a)it.vu.nl> Date: Sun Apr 6 14:44:31 2008 +0200 winebrowser: Convert to Unicode. :040000 040000 4f3a034b18392677fc0dfd1ed6df7fefe843a10e 0ab8603a13e836a0b91dd2f146df8da59f7e79e4 M programs It really looks related to the problem which I'm reporting :-). BTW, my system is NOT running in Unicode. Maybe is it related ? I hope it is not yet mandatory. I'm using iso-8859-2 encoding, which works much better in my normal working environment. Please do your best to fix it before 1.0, I feel it really bad and I think that many programs may be affected by it. Should I submit a bug too ? With regards, Pavel Troller

2 2

Re: kernel: updated French translation
by Laurent Vromman June 7, 2008

June 7, 2008

Hi, There is a mistake here : "L'acquéreur de le sémaphore est mort" The right translation is : "L'acquéreur du sémaphore est mort" The translation of "broken pipe" is not good too, but I can't find anything better on the internet. You should maybe try something like "Tube indisponible (broken pipe)", if you think it is better. Laurent Jonathan Ernst wrote: > ------------------------------------------------------------------------ > > >

2 1

French translation only partial?
by Frans Kool June 7, 2008

June 7, 2008

Hi, I just had a look at the French translation of the dlls/kernel32/nls/winerr_fra.mc file. I noticed only the first 54 messages have been translated, whereas the other 1876 are still the English originals. Was this on purpose? Or was this a partial translation which needs to be finalized (the remaining 97.2%)? I'm all for translating Wine in as many languages as possible, but I doubt this is the way to get there. Is there some way to detect if the 'translation' of a message is identical to the original (English) one and have it show up as 'partially translated' in the translation overview [1]? As a side note, is there any review on translations or is the policy "any translation is better than no translation"? When Wine 1.0 is going to be released, how can we be sure that the application is actually completely translated. For example, if I really wanted to harm translations, I could make a copy of all English resource files, just change the 'LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT' to whatever language I would like to 'translate' and submit them. As far as I know, there is no way of detecting this. Anyone got ideas? Frans. [1] http://pf128.krakow.sdi.tpnet.pl/wine-transl/index.php

2 1

Re: [PATCH] GetUrlCacheEntryInfo*: Handle null dest pointer when length is given
by Rob Shearman June 7, 2008

June 7, 2008

2008/6/6 Jon Griffiths <jon_p_griffiths(a)yahoo.com>: > - if (dwRequiredSize > *lpdwBufferSize) > - { > - *lpdwBufferSize = dwRequiredSize; > + ret = dwRequiredSize > *lpdwBufferSize? FALSE : TRUE; > + *lpdwBufferSize = dwRequiredSize; > + > + if (!ret) > SetLastError(ERROR_INSUFFICIENT_BUFFER); > - return FALSE; > + else if (!lpCacheEntryInfo) > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + ret = FALSE; > } > - *lpdwBufferSize = dwRequiredSize; > - return TRUE; > + return ret; > } Internal functions should return an error code instead of calling SetLastError. This avoids situations like this: > @@ -1531,6 +1539,9 @@ BOOL WINAPI GetUrlCacheEntryInfoA( > FALSE /* ANSI */)) > { > URLCacheContainer_UnlockIndex(pContainer, pHeader); > + /* This case is inconsistent w.r.t RetrieveUrlCacheEntryFile */ > + if (!lpCacheEntryInfo && GetLastError() == ERROR_INVALID_PARAMETER) > + SetLastError(ERROR_INSUFFICIENT_BUFFER); > return FALSE; > } > TRACE("Local File Name: %s\n", debugstr_a(lpCacheEntryInfo->lpszLocalFileName)); -- Rob Shearman

2 2

Re: mshtml: Added FIXME about QUERY_USES_HISTORYFOLDER in about protocol.
by Paul Vriens June 7, 2008

June 7, 2008

Jacek Caban wrote: > --- > dlls/mshtml/protocol.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Jacek, return E_NOTIMPL; + case QUERY_USES_HISTORYFOLDER: + FIXME("Unsupported option QUERY_USES_HISTORYFOLDER\n"); default: return E_FAIL; } shouldn't there be a "return E_NOTIMPL" after the FIXME as we do with the others? -- Cheers, Paul.

3 2

RE: d3d8: Fix the null condition in ApplyStateBlock
by Stefan Dösinger June 6, 2008

June 6, 2008

What would be interesting to know is which effect this has on the states, but not in this patch I'd say, and not before the 1.0 release. In the long run it might be an idea to port the d3d9:stateblock test to d3d8 and see how d3d8 behaves

1 0

Re: urlmon: Fix a few failing tests in win2k3
by Jacek Caban June 6, 2008

June 6, 2008

James Hawkins wrote: > Hi, > > Changelog: > * Fix a few failing tests in win2k3. You've fixed tests on IE7, not only win2k3. It would be better to change Wine to behave like IE7. Also your patch lefts some variables in wrong state. I will send patches to fix it. Jacek

2 4

Re: [urlmon/tests 2/2] Fix test on IE7 (Resend)
by Jacek Caban June 6, 2008

June 6, 2008

Hi Paul, Paul Vriens wrote: > Hi, > > This (together with number 1 of course) fixes the tests on IE7 boxes. > > Not sure if a patch for urlmon/protocol.c is needed as well. Let me > know and > I'll sent one. > > Changelog > Fix test on IE7 While fixing such tests it's good to add FIXME in code so info about it won't be lost. It's not documented anywhere which protocol handles which options. I will send a patch. Jacek

1 0

Re: Remove unused variable in dlls/mlang/tests/mlang.c
by James Hawkins June 6, 2008

June 6, 2008

2008/6/5 Gerald Pfeifer <gerald(a)pfeifer.com>: > > ChangeLog: > Remove unused variable in test_EnumScripts(). > > Index: dlls/mlang/tests/mlang.c > =================================================================== > RCS file: /home/wine/wine/dlls/mlang/tests/mlang.c,v > retrieving revision 1.24 > diff -u -3 -p -r1.24 mlang.c > --- dlls/mlang/tests/mlang.c 4 Jun 2008 11:37:37 -0000 1.24 > +++ dlls/mlang/tests/mlang.c 5 Jun 2008 15:17:51 -0000 > @@ -594,7 +594,6 @@ static void test_EnumScripts(IMultiLangu > > for (i = 0; pGetCPInfoExA && i < n; i++) > { > - CPINFOEXA cpinfoex; > #ifdef DUMP_SCRIPT_INFO > trace("SCRIPTINFO #%u:\n" > "ScriptId %08x\n" > > > http://winehq.org/pipermail/wine-cvs/2008-June/044013.html -- James Hawkins

2 1

Compile wine on Red Hat 9
by Wen Huang June 6, 2008

June 6, 2008

Hi everybody, I was trying to compile a winehq on Red Hat 9 and I downloaded the source 0.9.60 from sourceforge. When I tried to compile by ./configure make depend make during the make step, it gave an error ..... gcc -c -I. -I. -I../../include -I../../include -I/usr/include/ libxml2 -I/usr/include/libxml2 -D__WINESRC__ -DCOM_NO_WINDOWS_H - D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after- statement -Wwrite-strings -Wpointer-arith -g -O2 -o cdata.o cdata.c cdata.c: In function `domcdata_appendData': cdata.c:601: void value not ignored as it ought to be make[2]: *** [cdata.o] Error 1 make[2]: Leaving directory `/home/tus/wine-0.9.60/dlls/msxml3' make[1]: *** [msxml3] Error 2 make[1]: Leaving directory `/home/tus/wine-0.9.60/dlls' make: *** [dlls] Error 2 Can anybody kindly offer some help? By the way, is there rpm package for wine I can use on Red Hat 9, I tried to use the script on Wine Red Hat wiki to generate a rpm, but it failed at the same step... Thanks, Wen

2 3

Wine in the news
by Dan Kegel June 6, 2008

June 6, 2008

http://www.australianit.news.com.au/story/0,24897,23797416-24169,00.html The new president of Red Hat, when asked about desktop linux, said: "My simple answer is until Apple's iTunes runs on consumer Linux desktops, it's not going to take off. I know you can run Wine, which runs Windows applications on Linux, so techies will beat me up on that, but fundamentally there are some major device driver issues with products that people like to use and this limits adoption. It's going to be slow until these issues are solved." http://news.zdnet.co.uk/software/0,1000000121,39429910,00.htm http://economyaustria.at/Text/?id=3363378 Vienna migrates some Linux workstations to Vista because a single app, Schlaumäuse, crashes under Wine. Looks like they send the software out upon request to teachers; see http://www.schlaumaeuse.de/ (Can somebody send me a copy?)

4 5

Bad free error involving shdocvw and COM?
by Dan Kegel June 6, 2008

June 6, 2008

In shdocvw/tests/webbrowser.c, at the end of test_WebBrowser, the call IUnknown_Release(unk) results in the following Valgrind error: Invalid free() / delete / delete[] at notify_free (heap.c:199) by RtlFreeHeap (heap.c:1284) by SysFreeString (oleaut.c:196) by DocHost_Release (dochost.c:550) by WebBrowser_Release (webbrowser.c:153) by test_WebBrowser (webbrowser.c:2028) by func_webbrowser (webbrowser.c:2070) by run_test (test.h:421) by main (test.h:470) Address 0x7f01dc14 is 8 bytes after a block of size 28 alloc'd at notify_alloc (heap.c:191) by RtlAllocateHeap (heap.c:1231) by COMPOBJ_DllList_Add (compobj.c:910) by apartment_getclassobject (compobj.c:794) by get_inproc_class_object (compobj.c:2138) by CoGetClassObject (compobj.c:2238) by get_protocol_cf (session.c:111) by get_protocol_info (session.c:219) by parse_canonicalize_url (internet.c:63) by CoInternetParseUrl (internet.c:184) by URLMonikerImpl_Construct (umon.c:1039) by CreateURLMonikerEx (umon.c:1097) by CreateURLMoniker (umon.c:1123) by create_moniker (navigate.c:564) by bind_to_object (navigate.c:600) by navigate_bsc (navigate.c:657) by navigate_bsc_proc (navigate.c:679) by process_dochost_task (dochost.c:43) by shell_embedding_proc (oleobject.c:65) by ??? (library.h:163) Seems like an important bug to fix, since it could conceivably lead to heap corruption. This is all our code, no gecko involved, so we ought to be able to sort it, but it's beyond my ken.

1 0

[website] Fix typo in Spanish translation of home.template
by Ángel Guzmán Maeso June 6, 2008

June 6, 2008

Fix several typos -- Shakaran

1 1

Double free error involving dsound and winealsa.drv
by Dan Kegel June 6, 2008

June 6, 2008

Hmm, freeing a buffer that's already been freed is bad, is it showstopper bad? http://bugs.winehq.org/show_bug.cgi?id=13723

2 1

Re: user32: EnumDisplaySettingsExA: fill in all of lpDevmode->dmDeviceName
by Dmitry Timoshkov June 6, 2008

June 6, 2008

"Dan Kegel" <dank(a)kegel.com> wrote: > 'Cause if we don't, code that expects it to be defined > is mildly surprised to find that bytes after the string's > terminating nul are undefined. > Fixes 16 Valgrind warnings of the form: > > Use of uninitialised value of size 4 > at mbstowcs_sbcs (mbtowc.c:78) > by wine_cp_mbstowcs (mbtowc.c:266) > by MultiByteToWideChar (locale.c:1846) > by GdiConvertToDevmodeW (driver.c:434) > by ChangeDisplaySettingsExA (sysparams.c:3011) > by ChangeDisplaySettingsA (sysparams.c:2980) > by test_ChangeDisplaySettingsEx (monitor.c:161) > Uninitialised value was created by a stack allocation > at test_ChangeDisplaySettingsEx (monitor.c:141) GdiConvertToDevmodeW should be fixed instead. -- Dmitry.

1 0

Re: kernel32: tests/path.c: Improve test for GetLongPathNameA
by James Hawkins June 5, 2008

June 5, 2008

On Wed, Jun 4, 2008 at 8:38 PM, Zac Brown <zac(a)zacbrown.org> wrote: > Add test to check for GetLongPathNameA on GetModuleFileNameA's returned > string. > > Found via errors existing in shell32/tests/shelllink.c. Checked against > Windows XP and Windows 2000. > + pGetModuleFileNameA = + (void*)GetProcAddress( GetModuleHandleA("kernel32.dll"), "GetModuleFileNameA" ); GetModuleFileNameA is available on all platforms, and besides, you use it without checking if it's NULL. +/* Try getting the long path of your module name */ + if(pGetLongPathNameA) { + ok(pGetModuleFileNameA(NULL,tmpstr,sizeof(tmpstr)),"GetModuleFileNameA failed %s\n", + tmpstr); + todo_wine ok(pGetLongPathNameA(tmpstr,tmpstr1,MAX_PATH),"GetLongPathNameA failed %s\n", + tmpstr); + } What is this testing? Just that GetLongPathName doesn't fail in this case (I'm not even sure what 'this case' is specifically)? You should be checking the return value and the value of the out variable. -- James Hawkins

1 0

Re: gdi32/tests: Take into account several Win9x bugs in GetObject(). (take 3)
by Paul Vriens June 5, 2008

June 5, 2008

Francois Gouget wrote: > --- > > This time without the bug that caused tests to fail in Wine and on > Windows XP. > > > + SetLastError(0xdeadbeef); > ret = GetBitmapBits(hbm, 0, NULL); > - ok(ret == bm.bmWidthBytes * bm.bmHeight, "%d != %d\n", ret, bm.bmWidthBytes * bm.bmHeight); > + gle=GetLastError(); > + ok(ret == bm.bmWidthBytes * bm.bmHeight || (ret == 0 && gle == ERROR_INVALID_PARAMETER /* Win9x */), "%d != %d\n", ret, bm.bmWidthBytes * bm.bmHeight); Any reason this one isn't put into a broken() for win9x (as you did with all the others). -- Cheers, Paul.

2 1

re: [PATCH] oleaut32: Fix valgrind warnings in vatype.c test
by Dan Kegel June 5, 2008

June 5, 2008

Hi Jon, I guess http://www.winehq.org/pipermail/wine-patches/2008-May/055352.html must have been too scary to commit. I independently sent in a fix for the easy part, and it was committed as http://winehq.org/pipermail/wine-cvs/2008-June/043999.html The last part of your patch, having to do with SysAllocStringByteLen(), seems correct to me, offhand. Maybe if you clean up the comment a bit more, sprinkle sugar on it, and resend, it'll make it in this time. It's so gross, though, that it really should serve as a reminder to us to switch to IMalloc... - Dan

2 1

Re: [AppDB] Allow admins to remove their admin rights
by Alexander Nicolaysen Sørnes June 4, 2008

June 4, 2008

På Onsdag 04 juni 2008 , 01:24:07 skrev Chris Morgan: > What new policy on dissidents? ;-) > > How does this patch enable admins to remove themselves? I'm afraid I > can't see how this change lets an admin remove their own admin status. > > Chris > > Yea, that particular piece of code isn't very clear on what it's doing. I found out that $aClean['iUserId'] would only be set when modifying another user, and it previously compared it to $oUser->iUserId before allowing the admin removal. Now we only check for admin rights, and the oUser->iUserId == aClean['iUserId'] check is performed later to see if we should redirect back to the user admin page. > > On Tue, Jun 3, 2008 at 6:34 AM, Alexander Nicolaysen Sørnes > > <alex(a)thehandofagony.com> wrote: > > This is in accordance with the AppDB's new policy on dissidents. :) > > > > > > Alexander N. Sørnes

2 3

Fixing crashes in Tests (OS version check)
by Alistair Leslie-Hughes June 4, 2008

June 4, 2008

Hi, I've being investigating crashes that occur on Win98 when the tests run. I have fixed a couple already which where trivial. When I attempted to fix the snmpapi tests, I have found that i will end up removing alot of tests (~ 17). If I add a check for the windows version, I can skip the tests that will crash, also there is already tests with if(0) around them. What is the policy about checking the version of the OS before running certain tests? Best Regards Alistair Leslie-Hughes

8 11