June 2008 - Wine-Devel - list.winehq.org

Re: [2/2] ddraw: Rename IDirectDraw functions (try 2)
by Christian Costa June 1, 2008

June 1, 2008

Hi Michael, I think it would be better to fix function names in IDirectDraw7. Christian Michael Karcher a écrit : > The functions implementing IDirectDraw are called IDirectDrawImpl_Foo, > the ones implementing IDirectDraw7 are called alike. As they are > static functions in different files, the compiler has no problems > distinguishing them, but it confuses the reader of TRACE messages. > --- > dlls/ddraw/ddraw_thunks.c | 92 ++++++++++++++++++++++---------------------- > 1 files changed, 46 insertions(+), 46 deletions(-) > > ------------------------------------------------------------------------ > >

3 3

Two quick press mentions about Microsoft and Wine (the other one)
by Dan Kegel June 1, 2008

June 1, 2008

Microsoft Wine (Sept '07): http://www.sommelierindia.com/blog/2007/10/changing_the_world_with_a_micr.h… Microsoft bans searches for Wine in France (today): http://www.sbpost.ie/post/pages/p/story.aspx-qqqt=MEDIA+AND+MARKETING-qqqs=… Not sinister, just funny. And somewhat inconvenient...

1 0

Re: try 2: shell32: fix SHFileOperation copying to an empty file list
by James Hawkins June 1, 2008

June 1, 2008

On Sun, Jun 1, 2008 at 1:35 AM, Vincent Povirk <madewokherd+d41d(a)gmail.com> wrote: > This partially fixex bug 13394. > > Apparently there are two separate issues involved in that bug, one > with empty destination lists (which Windows seems to treat as a list > containing one 0-length string), and one involving long filenames. > This patch only addresses the empty lists. > This fix is wrong. We already handle empty file lists in parse_file list. If the list is empty, dwNumFiles is 0. Why did you add another variable for that? Also, you need to add a test case for multiple source files and an empty dest list for the FO_MOVE operation. You will not get ERROR_ACCESS_DENIED (the test will fail with your change). -- James Hawkins

1 0

Acid test: migrating the spouse
by Dan Kegel June 1, 2008

June 1, 2008

Been looking forward to trying this for a long time. What with Wine 1.0 nearly here, and a brand new computer to populate, I thought I'd try actually migrating my spouse to Linux / Wine, or at least see why it isn't yet practical. I'll record the process here: http://kegel.com/wine/migrating-user-1.html So far it's not quite clear it'll work, but it should be educational, and I'll at least get a bunch of good bug reports out of it. - Dan

2 1

Fwd: shell32: fix SHFileOperation copying to an empty file list
by Vincent Povirk June 1, 2008

June 1, 2008

Grr, forgot to copy list. ---------- Forwarded message ---------- From: Vincent Povirk <madewokherd+d41d(a)gmail.com> Date: Sat, May 31, 2008 at 9:46 PM Subject: Re: shell32: fix SHFileOperation copying to an empty file list To: James Hawkins <truiken(a)gmail.com> On Sat, May 31, 2008 at 9:42 PM, James Hawkins <truiken(a)gmail.com> wrote: > I'm not either. There's a very simple way to implement this. Also, > you need to add tests for the FO_MOVE action as well. Do tell, sir. None of the other operations actually succeed when the destination is an empty list (except delete of course). I can add tests for them to ensure they don't crash, but it seems unnecessary. > @@ -131,6 +132,7 @@ static void clean_after_shfo_tests(void) > DeleteFileA("test3.txt"); > DeleteFileA("test_5.txt"); > DeleteFileA("one.txt"); > + DeleteFileA("filename.tex"); > DeleteFileA("test4.txt\\test1.txt"); > DeleteFileA("test4.txt\\test2.txt"); > DeleteFileA("test4.txt\\test3.txt"); > > typo, and why didn't you stick with the convention used for all the > other test files (.txt, not .text)? This was intentional. It was to show that extensions are trimmed to three characters in this case. -- Vincent Povirk -- Vincent Povirk

2 3

Re: shell32: fix SHFileOperation copying to an empty file list
by James Hawkins June 1, 2008

June 1, 2008

On Sat, May 31, 2008 at 8:10 PM, Vincent Povirk <madewokherd+d41d(a)gmail.com> wrote: > On Windows, copying files to an empty file list copies each file to > the working directory, truncating each filename to 8.3 format. See bug > 13394. > > I'm not very happy about the way I implemented this (a special loop > just for the weird case), but it doesn't seem possible to use the > current copy_files loop. This is too different from what the function > does in every other possible situation. > I'm not either. There's a very simple way to implement this. Also, you need to add tests for the FO_MOVE action as well. @@ -131,6 +132,7 @@ static void clean_after_shfo_tests(void) DeleteFileA("test3.txt"); DeleteFileA("test_5.txt"); DeleteFileA("one.txt"); + DeleteFileA("filename.tex"); DeleteFileA("test4.txt\\test1.txt"); DeleteFileA("test4.txt\\test2.txt"); DeleteFileA("test4.txt\\test3.txt"); typo, and why didn't you stick with the convention used for all the other test files (.txt, not .text)? -- James Hawkins

1 0