July 2008 - Wine-Devel - list.winehq.org

Re: [3/11] kernel32/tests: Add tests for Change/DeleteTimerQueueTimer.
by Rob Shearman July 19, 2008

July 19, 2008

2008/7/19 Dan Hipschman <dsh(a)linux.ucla.edu>: > +static void CALLBACK timer_queue_cb2(PVOID p, BOOLEAN timedOut) > +{ > + struct timer_queue_data1 *d = (struct timer_queue_data1 *) p; > + ok(timedOut, "Timer callbacks should always time out\n"); > + /* Wait until our own timer handle is set to avoid a pretty much > + impossible race condition (better safe than sorry). */ > + if (d->t) > + if (++d->num_calls == d->max_calls) You could change the above two lines to just "if (d->t && ++d->num_calls == d->max_calls)" and remove a level of indentation. > + { > + BOOL ret; > + SetLastError(0xdeadbeef); > + /* Note, XP SP2 does *not* do any deadlock checking, so passing > + INVALID_HANDLE_VALUE here will just hang. */ > + ret = pDeleteTimerQueueTimer(d->q, d->t, NULL); > + ok(!ret, "DeleteTimerQueueTimer\n"); > + todo_wine > + ok(GetLastError() == ERROR_IO_PENDING, "DeleteTimerQueueTimer\n"); > + } > +} > + > +static void CALLBACK timer_queue_cb3(PVOID p, BOOLEAN timedOut) > +{ > + struct timer_queue_data1 *d = (struct timer_queue_data1 *) p; > + ok(timedOut, "Timer callbacks should always time out\n"); > + /* Wait until our own timer handle is set to avoid a pretty much > + impossible race condition (better safe than sorry). */ > + if (d->t) > + if (++d->num_calls == d->max_calls) Ditto. > + { > + /* Basically kill the timer since it won't have time to run > + again. */ > + BOOL ret = pChangeTimerQueueTimer(d->q, d->t, 10000, 0); > + ok(ret, "ChangeTimerQueueTimer\n"); > + } > +} > + -- Rob Shearman

1 0

Re: oleaut32: fixed the safearray tests for Vista.
by Rob Shearman July 19, 2008

July 19, 2008

2008/7/18 Reece Dunn <msclrhd(a)googlemail.com>: > Seems like Vista has fixed the bug in the Windows version of > SafeArrayGetVarType, as indicated by > http://test.winehq.org/data/80ee225f23ea8093f57f1e7b29b7fb60e6f6cdda/vista_…, > so update the tests accordingly. How about fixing SafeArrayGetVarType to conform to the new behaviour and marking the old behaviour as broken? > ------=_Part_61560_4553795.1216418064126 > Content-Type: application/octet-stream; > name=0001-oleaut32-fixed-the-safearray-tests-for-Vista.patch > Content-Transfer-Encoding: base64 > X-Attachment-Id: f_fitbsg940 > Content-Disposition: attachment; > filename=0001-oleaut32-fixed-the-safearray-tests-for-Vista.patch Please try to configure your mail client to send the correct content type for .patch files or rename your patches to have a .txt extension. -- Rob Shearman

1 0

Re: [2 of 2] ole32: always return false when asked if NULL is the current clipboard
by Rob Shearman July 19, 2008

July 19, 2008

2008/7/17 Vincent Povirk <vincent(a)codeweavers.com>: > @@ -583,6 +583,9 @@ HRESULT WINAPI OleIsCurrentClipboard(IDataObject *pDataObject) > if (!theOleClipboard) > return E_OUTOFMEMORY; > > + if (pDataObject == NULL) > + return S_FALSE; > + Functionally, the patch is good, but one small nit about the style - the check before uses the !ptr style whereas the check that you introduce uses the ptr == NULL style. It would be nice if the checks had a consistent style. -- Rob Shearman P.S. Congratulations on your new job :-)

1 0

Re: [PATCH 3/3] mstask: Implement ClassFactory, DllGetClassObject, and DllCanUnloadNow
by Rob Shearman July 19, 2008

July 19, 2008

2008/7/18 Roy Shea <royshea(a)gmail.com>: > +static HRESULT WINAPI MSTASK_IClassFactory_QueryInterface( > + LPCLASSFACTORY iface, > + REFIID riid, > + LPVOID *ppvObj) > +{ > + ClassFactoryImpl *This = (ClassFactoryImpl *)iface; > + > + TRACE("\n\tIID:\t%s\n",debugstr_guid(riid)); > + if (This == NULL || ppvObj == NULL) > + return E_POINTER; Please don't introduce any more checks for This being NULL. -- Rob Shearman

1 0

Problem compiling wine tests with msvc in standalone mode.
by Reece Dunn July 19, 2008

July 19, 2008

Hi, I am using VS 2008 (9.0) Express in conjunction with the Vista SDK. When compiling the tests, I get: c:\Users\reece\wine\dlls\comctl32\tests>cl -D_X86_ -DSTANDALONE -I../../../inclu de listview.c Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 15.00.21022.08 for 80x86 Copyright (C) Microsoft Corporation. All rights reserved. listview.c c:\program files\microsoft sdks\windows\v6.0a\include\rpc.h(99) : warning C4005: 'RPCRTAPI' : macro redefinition ../../../include\rpc.h(53) : see previous definition of 'RPCRTAPI' c:\program files\microsoft sdks\windows\v6.0a\include\rpc.h(155) : warning C4005 : 'RpcTryExcept' : macro redefinition ../../../include\rpc.h(81) : see previous definition of 'RpcTryExcept' c:\program files\microsoft sdks\windows\v6.0a\include\rpc.h(162) : warning C4005 : 'RpcExcept' : macro redefinition ../../../include\rpc.h(82) : see previous definition of 'RpcExcept' c:\program files\microsoft sdks\windows\v6.0a\include\rpc.h(171) : warning C4005 : 'RpcTryFinally' : macro redefinition ../../../include\rpc.h(84) : see previous definition of 'RpcTryFinally' c:\program files\microsoft sdks\windows\v6.0a\include\rpc.h(178) : warning C4005 : 'RpcFinally' : macro redefinition ../../../include\rpc.h(85) : see previous definition of 'RpcFinally' c:\program files\microsoft sdks\windows\v6.0a\include\rpc.h(183) : warning C4005 : 'RpcEndFinally' : macro redefinition ../../../include\rpc.h(86) : see previous definition of 'RpcEndFinally' c:\program files\microsoft sdks\windows\v6.0a\include\rpc.h(185) : warning C4005 : 'RpcExceptionCode' : macro redefinition ../../../include\rpc.h(87) : see previous definition of 'RpcExceptionCod e' c:\program files\microsoft sdks\windows\v6.0a\include\rpcndr.h(33) : fatal error C1189: #error : incorrect <rpcndr.h> version. Use the header that matches with the MIDL compiler. Any ideas? Thanks, - Reece

2 2

Re: git inconsistency - cannot fetch latest patchset
by Kirill K. Smirnov July 19, 2008

July 19, 2008

В сообщении от Saturday 19 July 2008 14:24:40 Nikolay Sivov написал(а): > This 'missed' commit goes to stable branch. > http://source.winehq.org/git/wine.git/?a=shortlog;h=refs/heads/stable Thanks, I almost forgot about branches! Sorry for nuisance. -- Kirill

1 0

git inconsistency - cannot fetch latest patchset
by Kirill K. Smirnov July 19, 2008

July 19, 2008

Hello, According to wine-cvs mailing list, latest patch is "Vladimir Pankratov : hhctrl.ocx: Update Russian translation.", but it cannot be fetched, after fetch/rebase the following patch is the latest: "Huw Davies : winmm: Only fill in the MIXERLINEA struct if the call to mixerGetLineInfoW succeeds". Web interface to git tree http://source.winehq.org/git/wine.git/, does not contain that patch too. Does anybody observe the same issue? -- Kirill

2 1

Re: [8/11] kernel32: Implement the timer queue thread.
by Hans Leidekker July 19, 2008

July 19, 2008

On Saturday 19 July 2008 02:19:11 Dan Hipschman wrote: > It punts on some integer-wrapping issues. If someone runs their wineserver > for 49 days they may run into that issue. I just thought it would distract Have you thought about using GetTickCount64 instead of GetTickCount? -Hans

1 0

Re: kernel32/tests: Run the tests again on Win9x (TimerQueue)
by Dan Hipschman July 19, 2008

July 19, 2008

On Fri, Jul 18, 2008 at 09:27:49PM +0200, Detlef Riekenberg wrote: > Some functions are not present on win98: > CreateTimerQueue > CreateTimerQueueTimer > DeleteTimerQueueEx > > > Changelog: > kernel32/tests: Run the tests again on Win9x (TimerQueue) > > > > ???Dan, when you are finished with your Patchset, please give me a note. > Thanks > (???I saw more to do in this File: merge all GetProcAddress in one place, > use skip, GetLastError is different on win98 in a test.) Please use this one instead: http://www.winehq.org/pipermail/wine-patches/2008-July/058184.html so the other patches in the same set will apply. Thanks.

1 0

Errors on Run of winetricks dotnet11.
by James McKenzie July 19, 2008

July 19, 2008

It looks like something is crashing when running the .NET 1.1 installer. Is there an existent bug for this problem? If not, would it be worthwhile to create an issue for this? System: MacBook OS Version: 10.5.3 X11: 2.1.1 (I don't think this is what is causing the crash.) XCode is not installed on this system James McKenzie

1 0