July 2008 - Wine-Devel - list.winehq.org

WWN announcements on WineHQ
by Francois Gouget July 30, 2008

July 30, 2008

On http://www.winehq.org/ we have the following news items: July 13, 2008: Wine Weekly News Issue 349 WWN Issue 349 was released today. June 18, 2008: Wine Weekly News Issue 348 WWN Issue 348 was released today. That's pretty lame. Should either have a 2 or 3 sentence summary for the WWN releases, or simply reuse the index we show in the 'Weekly Newsletters' box. Actually with the combination of proper news items and the back issues page, that box would be pretty redundant. Maybe we should remove it? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The nice thing about meditation is that it makes doing nothing quite respectable -- Paul Dean

4 12

[PATCH] cmd: Use ShellExecuteExW instead of CreateProcess for opening files.
by Kirill K. Smirnov July 30, 2008

July 30, 2008

Hi, >+ sei.fMask = SEE_MASK_FLAG_DDEWAIT| >+ SEE_MASK_FLAG_NO_UI| >+ SEE_MASK_NO_CONSOLE| >+ SEE_MASK_NOCLOSEPROCESS; Console apps must be executed using exiting console, not a new one. -- Kirill

1 0

Re: wined3d: universal surface convertor function for unsigned integer color formats(5th attempt)
by Victor July 30, 2008

July 30, 2008

Well, the last attempt (with added big-endian support) was submitted several days ago, and again - no feedback, and patch still isn't accepted. What's wrong with patch now? --- Victor Eremin

4 11

Re: quartz: Add tests for avi splitter
by Paul Vriens July 30, 2008

July 30, 2008

Hi Maarten, NT4 doesn't have CreateToolhelp32Snapshot so none of the quartz tests will run on NT4 currently. Should I just create a patch that checks for the existence of this function and skip some tests? Or do we have another way to get the number of threads? We could use NtQuerySystemInformation but that's not available on Win9x. We could also have a mix of these two depending on the availability of CreateToolhelp32Snapshot. -- Cheers, Paul.

2 2

[crypt32/tests] Don't crash on win9x
by Juan Lang July 30, 2008

July 30, 2008

Hi Paul, thanks very much for looking into the crypt32 tests. - /* Weird--bad add disposition leads to an access violation in Windows. - */ (snip) + if (!on_win9x) + { + /* Weird--bad add disposition leads to an access violation in Windows. + * Both tests crash on win9x + */ This suggests to me that the test should just be removed, as it's very unlikely that an application will depend on such behavior. Leaving it around with an if (0) around it seems reasonable too. Any of these tests whose behavior is inconsistent across Windows versions, especially where some Windows versions crash, are good candidates for removal, IMO. --Juan

2 1

Re: [PATCH 1/5] quartz: Add tests for Video Mixing Renderer 9
by Alexandre Julliard July 30, 2008

July 30, 2008

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes: > From f3544f718dbebd3dca29d94dbbcbdd071884e5a6 Mon Sep 17 00:00:00 2001 > From: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> > Date: Mon, 28 Jul 2008 18:18:06 -0700 > Subject: [PATCH] quartz: Add tests for Video Mixing Renderer 9 > > --- > dlls/quartz/tests/Makefile.in | 5 +- > dlls/quartz/tests/null.h | 667 +++++++++++++++++++++++++++++ You should put that code in the C file, it doesn't belong in a header, especially since you are not using anywhere else. Building tests stand-alone is a nice to have, but it's not worth the cost of putting half the code in a header. > +#define trace_save trace > + > +/* Don't debug null by default */ > +#define debug(...) do { } while (0) Vararg macros are not portable. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 4/5] quartz: Make the vmr-9 implementation work
by H. Verbeet July 30, 2008

July 30, 2008

I just looked the patch over quickly since you mentioned d3d9, but here are a few things I noticed: > + hr = IDirect3DSurface9_LockRect(info->lpSurf, &lock, NULL, D3DLOCK_DISCARD); > + assert(hr == S_OK); ... > + hr = IDirect3DDevice9_Clear(This->d3d9_dev, 0, NULL, D3DCLEAR_TARGET, D3DCOLOR_XRGB(0, 0, 0), 1.0f, 0); > + if (hr != S_OK) I realize D3D_OK and S_OK have the same value, but using SUCCEEDED()/FAILED() would probably be more appropriate. Happens in a few other places as well. > +// info.dwFlags = VMR9AllocFlag_TextureSurface; ... > + FIXME("SendMessageW: %08x\n", hr); You'll probably want to remove these.

2 1

Re: [PATCH] wine.inf: Change Msi.Package actions to have the full msiexec path.
by Vitaliy Margolen July 30, 2008

July 30, 2008

Lei Zhang wrote: > Hi, > > On Windows, the Msi.Package action registry keys have the full path to > msiexec.exe. > ------------------------------------------------------------------------ > > +HKCR,Msi.Package\shell\Open\command,,0x20002,"""%SystemRoot%\System32\msiexec.exe"" /i ""%1"" %*" > +HKCR,Msi.Package\shell\Repair\command,,0x20002,"""%SystemRoot%\System32\msiexec.exe"" /f ""%1"" %*" > +HKCR,Msi.Package\shell\Uninstall\command,,0x20002,"""%SystemRoot%\System32\msiexec.exe"" /x ""%1"" %*" Should those 0x20002 be 0x20000 instead? Why do we need to preserve overrides of something that can be opened with msi only? Vitaliy

2 1

d3dx9: Add stubs for the ID3DXSprite functions
by David Adam July 30, 2008

July 30, 2008

Since the prototype for D3DXCreateSprite in d3dx9 and d3dx8 are not compatible, it would be worth to do the implementation in parallel (that is in the same patch), instead of duplicating the d3dx9 patch into the d3dx8 one. David

1 0

Re: [1/2] comctl32: support for drawing themed push buttons. [try 3]
by Alexandre Julliard July 30, 2008

July 30, 2008

"Reece Dunn" <msclrhd(a)googlemail.com> writes: > -typedef void (*pfThemedPaint)(HTHEME theme, HWND hwnd, HDC hdc); > +/* These are indices into a states array to determine the theme state for a given theme part. */ > +#define STATE_NORMAL 0 > +#define STATE_DISABLED 1 > +#define STATE_HOT 2 > +#define STATE_PRESSED 3 > +#define STATE_DEFAULTED 4 An enum would be nicer. > +static void PB_draw(HTHEME theme, HWND hwnd, HDC hDC, int drawState, UINT dtFlags) > +{ > + static const int states[] = { PBS_NORMAL, PBS_DISABLED, PBS_HOT, PBS_PRESSED, PBS_DEFAULTED }; > + > + RECT bgRect, textRect; > + HFONT font = (HFONT)SendMessageW(hwnd, WM_GETFONT, 0, 0); > + HFONT hPrevFont = font ? SelectObject(hDC, font) : NULL; > + int state = states[ drawState ]; > + WCHAR text[MAX_PATH]; > + int len = MAX_PATH; MAX_PATH is not appropriate for a button text, this has nothing to do with a path. You should define your own constant, though dynamic allocation would of course be preferable. -- Alexandre Julliard julliard(a)winehq.org

1 0