August 2008 - Wine-Devel - list.winehq.org

Re: [try 2][2/2]wined3d: Support first clipplane with ARB shaders
by Henri Verbeet Aug. 24, 2008

Aug. 24, 2008

2008/8/24 Fabian Bieler <der.fabe(a)gmx.net>: > + if (use_vs(stateblock->wineD3DDevice) && (enable ^ supported_by_shader_backend) & enable) { Did you mean to write if (use_vs(stateblock->wineD3DDevice) && (enable & ~supported_by_shader_backend)) { there?

1 0

ddraw_test crashes on windows xp sp3 (blue screen)
by Rico Schüller Aug. 24, 2008

Aug. 24, 2008

Hi, the attached patch solves a hard crash on my ati mobility 9600/9700 card. The code behind the c style comments let the application crash. The code between /* */ crash the hole system. Probably there have to be another check for supported cards/extensions. Cheers Rico diff --git a/dlls/ddraw/tests/d3d.c b/dlls/ddraw/tests/d3d.c index 221a95b..436a49c 100644 --- a/dlls/ddraw/tests/d3d.c +++ b/dlls/ddraw/tests/d3d.c @@ -2089,9 +2089,9 @@ static void DeviceLoadTest() ddsd.ddsCaps.dwCaps2 = DDSCAPS2_CUBEMAP | DDSCAPS2_CUBEMAP_POSITIVEX; ddsd.dwWidth = 128; ddsd.dwHeight = 128; - hr = IDirectDraw7_CreateSurface(lpDD, &ddsd, &cube_face_levels[0][0][0], NULL); - ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); - if (FAILED(hr)) goto out; +// hr = IDirectDraw7_CreateSurface(lpDD, &ddsd, &cube_face_levels[0][0][0], NULL); +// ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); +// if (FAILED(hr)) goto out; memset(&ddsd, 0, sizeof(DDSURFACEDESC2)); ddsd.dwSize = sizeof(ddsd); @@ -2100,13 +2100,13 @@ static void DeviceLoadTest() ddsd.ddsCaps.dwCaps2 = DDSCAPS2_CUBEMAP | DDSCAPS2_CUBEMAP_POSITIVEX | DDSCAPS2_CUBEMAP_POSITIVEY; ddsd.dwWidth = 128; ddsd.dwHeight = 128; - hr = IDirectDraw7_CreateSurface(lpDD, &ddsd, &cube_face_levels[1][0][0], NULL); - ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); - if (FAILED(hr)) goto out; +// hr = IDirectDraw7_CreateSurface(lpDD, &ddsd, &cube_face_levels[1][0][0], NULL); +// ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); +// if (FAILED(hr)) goto out; /* INVALIDPARAMS tests currently would fail because wine doesn't support partial cube faces (the above created cubemaps will have all faces. */ - hr = IDirect3DDevice7_Load(lpD3DDevice, cube_face_levels[0][0][0], NULL, cube_face_levels[1][0][0], NULL, +/* hr = IDirect3DDevice7_Load(lpD3DDevice, cube_face_levels[0][0][0], NULL, cube_face_levels[1][0][0], NULL, DDSCAPS2_CUBEMAP_ALLFACES); todo_wine ok(hr==DDERR_INVALIDPARAMS, "IDirect3DDevice7_Load returned: %x\n",hr); @@ -2132,6 +2132,7 @@ static void DeviceLoadTest() IDirectDrawSurface7_Release(cube_face_levels[0][0][0]); IDirectDrawSurface7_Release(cube_face_levels[1][0][0]); +*/ memset(cube_face_levels, 0, sizeof(cube_face_levels)); }

2 1

Re: d3dx8: Implementation of D3DXGetFVFVertexSize with tests try 2
by David Adam Aug. 24, 2008

Aug. 24, 2008

Hello, could you keep the style of the file, please? For instance for (.....) { xxxxxxxx } instead of for (.....) { xxxxxxxx } The same for the if condition and the switch condition? David

1 0

Re: Unbreak dlls/winhttp on FreeBSD (and likely other BSDs/Darwin)
by Hans Leidekker Aug. 24, 2008

Aug. 24, 2008

On Wednesday 20 August 2008 20:34:43 Gerald Pfeifer wrote: > This minor change on top of Hans' contributions in the recent days > unbreaks the build on FreeBSD (and likely other BSDs and possibly > Darwin/MacOS). Thanks. I didn't want to copy all of the ifdef blocks from wininet because I can't verify which ones are actually needed. So I'm counting on people like you to fix this up, and I'm sure I'll need your help again :) -Hans

2 1

How should I name the Traditional Chinese resource file ?
by Hongbo Ni Aug. 24, 2008

Aug. 24, 2008

Hi, For Chinese language, there are simplified Chinese (zh_CN) and traditional Chinese (zh_TW) sublanguage. Currently all the dlls have Chinese resource named with xxx_Cn.rc for simplified, and xxx_Zh.rc for traditional Chinese. For all the programs such as notepage, simplified Chinese resource is named Zh.rc (while it should be named Cn.rc inline with dlls), and there is no traditional Chinese resource. I want to add traditional Chinese resources for all programs. I have those options: 1. name it Zh_tw.rc, (but Alexandre seems not like it) 2. name it Tw.rc 3. rename all Zh.rc to Cn.rc, then name traditional as Zh.rc 4. just put both simplified and traditional Chinese in Zh.rc (not good as they are different encoding). My question is how should I name it ? Hongbo Ni

1 0

Re: kernel32/winerr: Add Russian translation
by Dmitry Timoshkov Aug. 24, 2008

Aug. 24, 2008

"Vladimir Pankratov" <scriptkid(a)mail.ru> wrote: > Added Russian translation. > > Changed files: > dlls/kernel32/nls/winerr_rus.mc > dlls/kernel32/kernel.rc > dlls/kernel32/Makefile.in Is there a reason you've used cp866 encoding instead of cp1251? Also, this doesn't look like a translation, messages don't match their english counterparts, how did you do that? -- Dmitry.

1 0

About patchwatcher
by Nikolay Sivov Aug. 23, 2008

Aug. 23, 2008

Dan, am I right that Patchwatcher now runs a whole test suite for every patch? I know that this situation is rather rare but still I think it make sense to run only tests changed by patch if this patch contains only test changes. I could save some time without any side effect. Since all test stored in 'tests' directory for each module it's very easy to determine that a patch brings changes only to this directory without affecting module itself. What you think about this?

2 1

Re: [1/2] wined3d: Support clipplanes with GLSL shaders
by Henri Verbeet Aug. 23, 2008

Aug. 23, 2008

> @@ -248,11 +248,12 @@ typedef struct { > void (*shader_generate_vshader)(IWineD3DVertexShader *iface, SHADER_BUFFER *buffer); > void (*shader_get_caps)(WINED3DDEVTYPE devtype, WineD3D_GL_Info *gl_info, struct shader_caps *caps); > BOOL (*shader_conv_supported)(WINED3DFORMAT conv); > + DWORD shader_supported_clipplanes; /* bitmask of supported clipplanes */ > } shader_backend_t; You shouldn't abuse the call table like that, you should store that flag in the private data instead.

1 0

Fwd: Patchwatcher: failed regression tests: d3dx8: replace loops with explicit computations to make them faster [PATCH] d3dx8: replace loops by explicit computations
by Dan Kegel Aug. 23, 2008

Aug. 23, 2008

Patchwatcher notes that the conformance test fails here: ../../../tools/runtest -q -P wine -M d3dx8.dll -T ../../.. -p d3dx8_test.exe.so math.c && touch math.ok math.c:442: Test failed: Expected matrix= (-0.214800,1.311600,0.475200,0.000000 0.950400,-0.883600,0.924400,0.000000 1.021200,0.193600,-1.358800,0.000000 18.298500,-29.624001,15.683499,1.000000 ) Got matrix= (-0.214800,1.311600,0.475200,0.000000 0.950401,-0.883601,0.924400,0.000000 1.021204,0.193593,-1.358803,0.000000 18.298538,-29.624159,15.683425,1.000000) Looks like rounding errors, but one way or another, you have to take care of that. Also: did you benchmark this change to verify it actually made things faster? Unrolling loops is no longer as sure-fire a win as it used to be. I'm inclined to prefer the more compact, clear loop unless there's hard evidence it's > 1% slower. - Dan ---------- Forwarded message ---------- From: <patchwatcher(a)kegel.com> Date: Fri, Aug 22, 2008 at 8:35 PM Subject: Patchwatcher: failed regression tests: d3dx8: replace loops with explicit computations to make them faster [PATCH] d3dx8: replace loops by explicit computations To: dank(a)kegel.com Hi! This is the experimental automated wine patchwatcher thingy. The latest git sources were built and tested with your patch "d3dx8: replace loops with explicit computations to make them faster [PATCH] d3dx8: replace loops by explicit computations" Result: the patch failed regression tests. You can retrieve the full build results at http://kegel.com/wine/patchwatcher/results/264.log and see the patch as parsed at http://kegel.com/wine/patchwatcher/results/264.txt See http://kegel.com/wine/patchwatcher/results for more info.

2 2

Re: wined3d/d3d9: Set the initial scissor rect to the window size
by H. Verbeet Aug. 23, 2008

Aug. 23, 2008

2008/8/21 Rico Schüller <kgbricola(a)web.de>: > + /* Set the scissor rect values */ > + scissor.left=0; > + scissor.right=ThisDevice->ddraw_width; > + scissor.top=0; > + scissor.bottom=ThisDevice->ddraw_height; > + IWineD3DDevice_SetScissorRect(device, &scissor); > + Are you sure you shouldn't be using the primary swapchain's backbuffer dimensions?

4 8

re: [Patch] 0001-Support-for-winscard.dll.patch
by Dan Kegel Aug. 23, 2008

Aug. 23, 2008

Heiko wrote: > This is my first patch using git and also for wine. > > Please check it and let me know which things can be made better. Hi! Welcome to Wine! You probably need to include a better description, and some conformance tests would help, too. (They should do basic error checking at least, and should skip checks that really need hardware if the required hardware isn't present.) Also, your patch failed to apply; see http://kegel.com/wine/patchwatcher/results/ You can avoid the particular problem by not including a diff for 'configure' in the patch; the diff for configure.ac suffices. We have lots of pages (way too many) of advice for how to send patches at winehq.org, but that bit of advice doesn't seem to be in any of them yet :-( http://www.winehq.org/site/sending_patches http://wiki.winehq.org/DeveloperFaq http://winehq.org/site/docs/winedev-guide/codingpractice It does show up in http://wiki.jswindle.com/index.php/Coding_Hints:Using_Diff - Dan

2 4

New winetricks 20080823: add non-activex-plugin for flash, work around indeo installer bug; updated divx, liberation, kdewin, directx9, ffdshow.
by Dan Kegel Aug. 23, 2008

Aug. 23, 2008

Just a bunch of little updates and fixes. Thanks to everyone who pointed out the issues. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com Changes since 20080710: r164: divx updated, change path and sha1sum to match. Thanks to Graham Inggs for the nudge. r163: Update liberation to 1.04. Thanks to Graham Inggs for the nudge. Uses the probably-gnu-specific --strip option to tar to get the fonts in the right place... but everybody's using gnu tar 1.15 or later, right? r162: Update kdewin to 0.9.3-1. Thanks to Graham Inggs for the nudge. r161: Register indeo codec harder; thanks to 414N for the tip. r112: Update directx9 to june 2008 release; thanks to Paul Drain for the tip. r111: Add non-activex flash plugin r110: Update ffdshow. Update version. r107: Add a little error checking, and missing quotes in one spot.

1 0

Crosstest building question
by Nikolay Sivov Aug. 23, 2008

Aug. 23, 2008

I have a problem building crosstest for GDI+ call GdipFillClosedCurve2. I've got the following: graphics.cross.o: In function `func_graphics':/home/mrlarch/wine/dlls/gdiplus/tests/graphics.c:593: undefined reference to `_GdipFillClosedCurve2(a)24' collect2: ld returned 1 exit status make[2]: *** [gdiplus_crosstest.exe] Error 1 make[2]: Leaving directory `/home/mrlarch/wine/dlls/gdiplus/tests' make[1]: *** [gdiplus/tests/__crosstest__] Error 2 make[1]: Leaving directory `/home/mrlarch/wine/dlls' make: *** [dlls/__crosstest__] Error 2 This never happened with other calls yet. Before this I've done 'make && make install' for library and make clean for 'tests' directory. Actually in definition file I have now -- GdipFillClosedCurve2(a)20 @216. I'm able to build ordinary (not cross) tests without any errors. I think the question is why reference name differs from .def file?

2 2

Patchwatcher status
by Dan Kegel Aug. 22, 2008

Aug. 22, 2008

I think I fixed the charset munging, so patches of non-english stretches of code should work now. That was the last big source of false failure reports, so I'm going to enable email notification to people whose patches fail. I'll probably clear the results page tonight to get rid of all the bogus failure notices caused by the charset conversion bug.

1 0

RE: Spore patch to fix UI and Part descriptions
by Stefan Dösinger Aug. 22, 2008

Aug. 22, 2008

> + rect.right = 0; > + rect.top = NULL; > + rect.left = NULL; > + rect.bottom= 0; NULL is (void *) 0, so this test is the same as the one above, except that the compiler may warn about an implicit cast from pointer to integer. Otherwise, this goes into the right direction. > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Andrew Fenn > Sent: Friday, August 22, 2008 2:52 AM > To: H. Verbeet; Stefan Dösinger > Cc: wine-patches(a)winehq.org > Subject: Re: Spore patch to fix UI and Part descriptions > > I made a new patch this time including a test. > > I put in some extra checking in SetScissorRect making sure that if rect > was null or it was an invalid rectangle that it was returned as invalid > as it should be. > > I'm not able to do a test on windows so if anyone does one please let > me know if there are any problems. Also please tell me if you spot any > problems with this patch. > > Thanks, > Andrew

1 0

Re: regedit 1/2: Convert key creation to unicode
by Michael Stefaniuc Aug. 22, 2008

Aug. 22, 2008

Alexander Nicolaysen Sørnes wrote: > regedit 1/2: Convert key creation to unicode Why do you add extra TCHARs then? You replace one or two with WCHAR and then add a lot more TCHARs. > From 2f56e158d55011ac4294d113f844c32fb998a2c2 Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Alexander=20Nicolaysen=20S=C3=B8rnes?= <alex(a)thehandofagony.com> > Date: Thu, 21 Aug 2008 23:49:34 +0200 > Subject: [PATCH] regedit: Convert key creation to unicode > > --- > programs/regedit/edit.c | 14 +++++++------- > programs/regedit/framewnd.c | 13 +++++++++---- > programs/regedit/main.h | 4 ++-- > programs/regedit/treeview.c | 14 +++++++++----- > 4 files changed, 27 insertions(+), 18 deletions(-) bye michael

2 1

Re: appwiz: fix some typos in the french resources
by Alexandre Julliard Aug. 22, 2008

Aug. 22, 2008

"David Adam" <david.adam.cnrs(a)gmail.com> writes: > - CONTROL "Ce logiciel peut �tre automatiquement d�sinstaller. Pour supprimer un programme ou modifier ses composants, s�lectionner le dans la liste, et cliquer sur Ajouter/Supprimer.", 1002, "STATIC", SS_LEFT | WS_CHILD | WS_VISIBLE | WS_GROUP, 40, 57, 270, 30 > + CONTROL "Ces logiciels peuvent �tre automatiquement d�sinstaller. Pour supprimer un programme ou modifier ses composants, s�lectionner le dans la liste, et cliquer sur Ajouter/Supprimer.", 1002, "STATIC", SS_LEFT | WS_CHILD | WS_VISIBLE | WS_GROUP, 40, 57, 270, 30 While you're at it you should fix the grammar too... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] shell32 - handle WM_CLOSE in the Control Panel window (fixed)
by James Mckenzie Aug. 22, 2008

Aug. 22, 2008

Vincent Povirk <madewokherd+8cd9(a)gmail.com> at Aug 21, 2008 8:49 PM (MST) wrote about [PATCH] shell32 - handle WM_CLOSE in the Control Panel window (fixed) > >WM_CLOSE is already handled by the default window procedure, >DefWindowProcW, which calls DestroyWindow. It's only necessary to >override the default for WM_CLOSE if you want to prevent the window >from being destroyed. > So what is the use of this case? Is it to prevent DestroyWindow from being called or is it to insert additional code before DestroyWindow is called. I'll have to git the current source and examine it further. Thank you for advising of the original case, which I had not assumed was what happened on a WM_CLOSE message. James McKenzie

1 0

Regression with d3d: Remove IWineD3DDevice::SetHwnd.
by Maxime Bellengé Aug. 22, 2008

Aug. 22, 2008

Hi This patch is causing a regression in the game Return to mysterious Island. When the game start it crashes displaying the trace I added at the end of the mail. I'm not an expert at all with ddraw but as it crashes on a NULL pointer, maybe there is an inconsistency between This->dest_window and This->ddraw_window ith this patch. Here is a link to the appdb page which contains a link to the demo of the game. http://appdb.winehq.org/objectManager.php?sClass=version&iId=3361 Thanks Maxime 34b37fe2411d83f1a6f3e11a7a1e4d28bd9b36ba is first bad commit commit 34b37fe2411d83f1a6f3e11a7a1e4d28bd9b36ba Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue Aug 5 14:24:10 2008 -0500 d3d: Remove IWineD3DDevice::SetHwnd. :040000 040000 70726cbb30d4e915779d7f0897cd44227f549e3e afda0b9ddba310280afcbe82a78ae4e2212f1801 M dlls :040000 040000 405e4687c093ec5c082507ce0195a7958799b4bf fc8ba10a277dc8b364967673fb81eb08f0844897 M include err:wgl:internal_SetPixelFormat Invalid operation on root_window err:d3d:CreateContext SetPixelFormat failed on HDC=0x2e8 for iPixelFormat=3 err:d3d:IWineD3DDeviceImpl_CreateAdditionalSwapChain Failed to create a new context fixme:ddraw:D3D7CB_CreateAdditionalSwapChain (0x19e2890) call to IWineD3DDevice_CreateAdditionalSwapChain failed wine: Unhandled page fault on read access to 0x00000014 at address 0x6113c944 (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000014 in 32-bit code (0x6113c944). fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_cmp (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_low (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_pow (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_mul_high (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value srgb_sub_high (a) Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:6113c944 ESP:0032ee38 EBP:0032ee50 EFLAGS:00210202( - 00 - -RI1) EAX:6113c9a0 EBX:61232e98 ECX:00110048 EDX:00000002 ESI:00000000 EDI:001379f8 Stack dump: 0x0032ee38: 00000000 6113c9a0 61233b70 61232e98 0x0032ee48: 001379f8 00000000 0032ef10 61165c7e 0x0032ee58: 001379f8 00000008 00000004 00000000 0x0032ee68: 7b88ef10 60721040 00000040 7bc63de1 0x0032ee78: 00000005 0032eeb8 0032eeb4 0032eeb0 0x0032ee88: 0032eeac 0032eea4 0032eea8 0032eea0 Backtrace: =>1 0x6113c944 arbfp_free+0x34(iface=0x1379f8) [/home/max/wine/wine/dlls/wined3d/arb_program_shader.c:2255] in wined3d (0x0032ee50) 2 0x61165c7e IWineD3DDeviceImpl_Init3D+0x25e(iface=<register ESI not in topmost frame>, pPresentationParameters=0x32f068, D3DCB_CreateAdditionalSwapChain=0x60987840) [/home/max/wine/wine/dlls/wined3d/device.c:2258] in wined3d (0x0032ef10) 3 0x60989057 IDirectDrawImpl_CreateSurface+0xc47(iface=0x19e2890, DDSD=0x32f12c, Surf=0xa11614, UnkOuter=(nil)) [/home/max/wine/wine/dlls/ddraw/ddraw.c:3292] in ddraw (0x0032f0c0) 4 0x6098b29e IDirectDraw4Impl_CreateSurface+0x3e(This=<register ESI not in topmost frame>, pSDesc=0x32f12c, ppSurface=<register EDI not in topmost frame>, pUnkOuter=(nil)) [/home/max/wine/wine/dlls/ddraw/ddraw_thunks.c:500] in ddraw (0x0032f0f0) 5 0x0048c680 in rtmi (+0x8c680) (0x00000400) 6 0x00000000 (0x00000000) 0x6113c944 arbfp_free+0x34 [/home/max/wine/wine/dlls/wined3d/arb_program_shader.c:2255] in wined3d: movl 0x14(%esi),%eax 2255 hash_table_destroy(priv->fragment_shaders, arbfp_free_ffpshader, &This->adapter->gl_info); Modules: Module Address Debug info Name (82 modules) PE 330000- 388000 Deferred ijl15 PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 400000- d7c000 Export rtmi PE 10000000-1008f000 Deferred spr ELF 6001f000-60155000 Deferred libwine.so.1 ELF 60156000-6016b000 Deferred libresolv.so.2 ELF 60322000-6032e000 Deferred libnss_files.so.2 ELF 60612000-6075b000 Deferred user32<elf> \-PE 60630000-6075b000 \ user32 ELF 6075b000-607f8000 Deferred gdi32<elf> \-PE 60770000-607f8000 \ gdi32 ELF 607f8000-60849000 Deferred advapi32<elf> \-PE 60800000-60849000 \ advapi32 ELF 60849000-608eb000 Deferred ole32<elf> \-PE 60860000-608eb000 \ ole32 ELF 608eb000-60950000 Deferred rpcrt4<elf> \-PE 60900000-60950000 \ rpcrt4 ELF 60950000-6096f000 Deferred iphlpapi<elf> \-PE 60960000-6096f000 \ iphlpapi ELF 6096f000-609c8000 Dwarf ddraw<elf> \-PE 60980000-609c8000 \ ddraw ELF 609c8000-60a00000 Deferred dinput<elf> \-PE 609d0000-60a00000 \ dinput ELF 60a00000-60a4a000 Deferred dsound<elf> \-PE 60a10000-60a4a000 \ dsound ELF 60a4a000-60adc000 Deferred winmm<elf> \-PE 60a50000-60adc000 \ winmm ELF 60adc000-60af5000 Deferred version<elf> \-PE 60ae0000-60af5000 \ version ELF 60af5000-60b09000 Deferred lz32<elf> \-PE 60b00000-60b09000 \ lz32 ELF 60b09000-60b3e000 Deferred winspool<elf> \-PE 60b10000-60b3e000 \ winspool ELF 60c65000-60cfe000 Deferred winex11<elf> \-PE 60c70000-60cfe000 \ winex11 ELF 60d0a000-60d18000 Deferred libgcc_s.so.1 ELF 60d18000-60d1a000 Deferred libnvidia-tls.so.1 ELF 60e52000-60e72000 Deferred imm32<elf> \-PE 60e60000-60e72000 \ imm32 ELF 60e75000-60e7a000 Deferred libxxf86vm.so.1 ELF 60e9c000-60ed1000 Deferred winealsa<elf> \-PE 60ea0000-60ed1000 \ winealsa ELF 60ed1000-60ee9000 Deferred msacm32<elf> \-PE 60ee0000-60ee9000 \ msacm32 ELF 60eed000-60fcd000 Deferred libasound.so.2 ELF 60fcd000-60ff4000 Deferred msacm32<elf> \-PE 60fd0000-60ff4000 \ msacm32 ELF 60ff4000-61008000 Deferred midimap<elf> \-PE 61000000-61008000 \ midimap ELF 61119000-61235000 Dwarf wined3d<elf> \-PE 61130000-61235000 \ wined3d ELF 6125d000-612dd000 Deferred opengl32<elf> \-PE 61270000-612dd000 \ opengl32 ELF 612f9000-6139e000 Deferred libgl.so.1 ELF 6139e000-620de000 Deferred libglcore.so.1 ELF 62aed000-62b13000 Deferred dmusic<elf> \-PE 62af0000-62b13000 \ dmusic ELF 7b800000-7b930000 Deferred kernel32<elf> \-PE 7b820000-7b930000 \ kernel32 ELF 7bc00000-7bca5000 Deferred ntdll<elf> \-PE 7bc10000-7bca5000 \ ntdll ELF 7bf00000-7bf03000 Deferred <wine-loader> Threads: process tid prio (all id:s are in hex) 00000008 (D) C:\Program Files\The Adventure Company\Retour sur l'�le myst�rieuse\RtMI.exe 00000028 15 00000023 0 00000009 0 <== 0000000c 0000001d 0 00000013 0 00000012 0 0000000e 0 0000000d 0 0000000f 00000015 0 00000014 0 00000011 0 00000010 0 00000016 00000017 0 Backtrace: =>1 0x6113c944 arbfp_free+0x34(iface=0x1379f8) [/home/max/wine/wine/dlls/wined3d/arb_program_shader.c:2255] in wined3d (0x0032ee50) 2 0x61165c7e IWineD3DDeviceImpl_Init3D+0x25e(iface=<register ESI not in topmost frame>, pPresentationParameters=0x32f068, D3DCB_CreateAdditionalSwapChain=0x60987840) [/home/max/wine/wine/dlls/wined3d/device.c:2258] in wined3d (0x0032ef10) 3 0x60989057 IDirectDrawImpl_CreateSurface+0xc47(iface=0x19e2890, DDSD=0x32f12c, Surf=0xa11614, UnkOuter=(nil)) [/home/max/wine/wine/dlls/ddraw/ddraw.c:3292] in ddraw (0x0032f0c0) 4 0x6098b29e IDirectDraw4Impl_CreateSurface+0x3e(This=<register ESI not in topmost frame>, pSDesc=0x32f12c, ppSurface=<register EDI not in topmost frame>, pUnkOuter=(nil)) [/home/max/wine/wine/dlls/ddraw/ddraw_thunks.c:500] in ddraw (0x0032f0f0) 5 0x0048c680 in rtmi (+0x8c680) (0x00000400) 6 0x00000000 (0x00000000)

1 0

Re: user32: fix error setting in FindWindow (try 2)
by Louis. Lenders Aug. 22, 2008

Aug. 22, 2008

----- Original Message ---- From: Alexandre Julliard <julliard(a)winehq.org> To: Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> Cc: wine-devel(a)winehq.org Sent: Friday, 22 August, 2008 4:54:49 AM Subject: Re: user32: fix error setting in FindWindow (try 2) "Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> writes: > diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c > index 1964e88..246347f 100644 > --- a/dlls/user32/tests/win.c > +++ b/dlls/user32/tests/win.c > @@ -4789,14 +4789,20 @@ static void test_hwnd_message(void) > SetLastError(0xdeadbeef); > found = FindWindowExA( GetDesktopWindow(), 0, 0, "message window" ); > ok( found == 0, "found message window %p/%p\n", found, hwnd ); > - todo_wine > - ok(GetLastError() == ERROR_FILE_NOT_FOUND, "ERROR_FILE_NOT_FOUND, got %d\n", GetLastError()); > + ok(GetLastError() == ERROR_FILE_NOT_FOUND, "ERROR_FILE_NOT_FOUND, got %d\n", GetLastError()); >Have you tried your test on Windows? According to the test results >there isn't any Windows version that sets last error here. If you're talking about the test above, that was a test written by someone else, i think it was committed on wednesday or so. I only take out the "todo_wine" there; i assumed that test passed on windows, as the patch was committed, but i now see on the test results page that it doesn't. I did run the test on windows yesterday , the whole console got spammed with lots of messages, and i guess i overlooked something then ( i now see on the testpage that the failing test appears in the first lines of the spam, i only overlooked the last part in the console as i expected an eventually failing test there) As FindWindowEx apparently doesn't set an error, I'll have to recheck what FindWindow does on windows Send instant messages to your online friends http://uk.messenger.yahoo.com

1 0

Re: [PATCH 1/2] mstask: Implemented CreateTrigger.
by Roy Shea Aug. 22, 2008

Aug. 22, 2008

> dlls/mstask/task.c | 4 ++-- > dlls/mstask/tests/task.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Please disregard this and the subsequent patch in the set. Patchwatecher found a few incorrect todo_wine statements that I forgot to remove. A revised version of the two patches has been resubmitted. Peace, -Roy

1 0

Re: user32: fix error setting in FindWindow (try 2)
by Alexandre Julliard Aug. 22, 2008

Aug. 22, 2008

"Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> writes: > diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c > index 1964e88..246347f 100644 > --- a/dlls/user32/tests/win.c > +++ b/dlls/user32/tests/win.c > @@ -4789,14 +4789,20 @@ static void test_hwnd_message(void) > SetLastError(0xdeadbeef); > found = FindWindowExA( GetDesktopWindow(), 0, 0, "message window" ); > ok( found == 0, "found message window %p/%p\n", found, hwnd ); > - todo_wine > - ok(GetLastError() == ERROR_FILE_NOT_FOUND, "ERROR_FILE_NOT_FOUND, got %d\n", GetLastError()); > + ok(GetLastError() == ERROR_FILE_NOT_FOUND, "ERROR_FILE_NOT_FOUND, got %d\n", GetLastError()); Have you tried your test on Windows? According to the test results there isn't any Windows version that sets last error here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Spore patch to fix UI and Part descriptions
by Marcus Meissner Aug. 22, 2008

Aug. 22, 2008

On Fri, Aug 22, 2008 at 02:51:56PM +0700, Andrew Fenn wrote: > I made a new patch this time including a test. > > I put in some extra checking in SetScissorRect making sure that if > rect was null or it was an invalid rectangle that it was returned as > invalid as it should be. > > I'm not able to do a test on windows so if anyone does one please let > me know if there are any problems. Also please tell me if you spot any > problems with this patch. > > --- a/dlls/d3d9/device.c > +++ b/dlls/d3d9/device.c > @@ -746,7 +746,8 @@ static HRESULT WINAPI IDirect3DDevice9Impl_GetDepthStencilSurface(LPDIRECT3DDE > } > } else { > WARN("Call to IWineD3DDevice_GetDepthStencilSurface failed\n"); > - *ppZStencilSurface = NULL; > + /* *ppZStencilSurface = NULL; */ > + return D3DERR_NOTFOUND; > } > LeaveCriticalSection(&d3d9_cs); > return hr; Again, you should likely add a LeaveCriticalSection(&d3d9_cs); to the error return too. Or just set hr = D3DERR_NOTFOUND; and fall through. Ciao, Marcus

1 0

Re: [PATCH] shell32 - handle WM_CLOSE in the Control Panel window (fixed)
by Vincent Povirk Aug. 22, 2008

Aug. 22, 2008

Why doesn't the WM_DESTROY case handle this properly? At first glance, it appears to have code for stopping the running applets and quitting from the main loop. Calling ExitProcess from WM_CLOSE is anything but graceful. Vincent Povirk On Thu, Aug 21, 2008 at 2:25 PM, Steven Edwards <winehacker(a)gmail.com> wrote: > This time without the TAB/space mixup > > Without this patch, if you have the Control Panel window open along > with an applet and you try to close the Panel window, you get a very > nice crash. This forces an exit with a little grace > > Changelog: > shell32 - handle WM_CLOSE in the Control Panel window > > -- > Steven Edwards > > "There is one thing stronger than all the armies in the world, and > that is an idea whose time has come." - Victor Hugo > > > >

3 6

re: patches
by Dan Kegel Aug. 22, 2008

Aug. 22, 2008

Louis wrote: > Hi, apparently none of my patches is making it into git, nor did i recieve any response from Alexandre about what's wrong with them. I guess i'm kind of "blacklisted" I don't think so. LOTS of people, me included, have trouble getting patches into git. You just have to have patience, try to figure out what needs improving, and keep at it. Michael Karcher already gave you some good feedback: http://winehq.org/pipermail/wine-devel/2008-August/068280.html I don't think you've followed up on that yet. And when in doubt, it never hurts to rediff and clean up your patch series and resend. Maintainers like Alexandre often get overwhelmed by incoming email. Linus Torvalds even said that he simply deletes his inbox when it gets too full, and that people who are serious about wanting their patches in will resend. This is probably true of Alexandre, especially after he gets back from a two week vacation, as he just did. - Dan

1 0