August 2008 - Wine-Devel - list.winehq.org

Re:activeds: add stub for ADsGetLastError
by Louis. Lenders Aug. 21, 2008

Aug. 21, 2008

Thanks for reviewing the patch James @@ -6,7 +6,7 @@ 8 stub ADsBuildVarArrayInt 9 stdcall ADsOpenObject(wstr wstr wstr long ptr ptr) 12 stub ADsSetLastError -13 stub ADsGetLastError +13 stdcall ADsGetLastError(ptr wstr long wstr long) >Both of those wstr parameters are out pointers so they should be ptr, not wstr. Didn't know that, so that has to be changed for sure /***************************************************** + * ADsGetLastError [ACTIVEDS.13] + */ +HRESULT WINAPI ADsGetLastError(LPDWORD pError, LPWSTR buffer, DWORD buflen, LPWSTR bufname, DWORD bufnamelen) +{ + FIXME("(%p,%p,%d,%p,%d)stub\n", pError, buffer, buflen, bufname, bufnamelen); + return E_POINTER; +} >Returning E_POINTER seems pretty wrong. In the documentation on http://msdn.microsoft.com/en-us/library/aa772183(VS.85).aspx it is listed as one of the possible return values. Of course one could also return E_NOTIMPL or E_FAIL etc, but for a stub this seemed like a good choice to me as well, the application (Dameware) doesn't seem to bother what is returned, it starts up just fine Send instant messages to your online friends http://uk.messenger.yahoo.com

2 1

Re: shobjidl.idl: add Taskbarlist interface defenitions
by James Hawkins Aug. 21, 2008

Aug. 21, 2008

On Wed, Aug 20, 2008 at 3:24 AM, Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > Hi , this interface is needed to get governor if poker running > (http://bugs.winehq.org/show_bug.cgi?id=14139) these first 3 patches is > only preliminary stuff, the rest of the stuff i'll send later on. > The "I'll send the rest later" is a warning light. You should further develop this and send it all later so we know this is actually going somewhere. -- James Hawkins

1 0

Re: [2/6][PATCH]Fixes an Async bug.
by Alexandre Julliard Aug. 21, 2008

Aug. 21, 2008

"Scott Lindeneau" <slindeneau(a)gmail.com> writes: > Fixes a bug in the async implementation. When checking for waiting > elements on a queue you need to check to see if ANY element is waiting, > not just the first element. When waking elements up you should ALERT an > element that is not already alerted. All other status messages should be > set. (This compensates for poll events that trigger other poll events > before garbage collection occurs and removes alerted elements from the > queues). This is wrong, it will lead to busy waiting. We very much want the first async to have been handled before we wake up for the next one. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: activeds: add stub for ADsGetLastError
by James Hawkins Aug. 21, 2008

Aug. 21, 2008

On Tue, Aug 19, 2008 at 4:14 PM, Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > Fixes a crash in Dameware utilities > @@ -6,7 +6,7 @@ 8 stub ADsBuildVarArrayInt 9 stdcall ADsOpenObject(wstr wstr wstr long ptr ptr) 12 stub ADsSetLastError -13 stub ADsGetLastError +13 stdcall ADsGetLastError(ptr wstr long wstr long) Both of those wstr parameters are out pointers so they should be ptr, not wstr. /***************************************************** + * ADsGetLastError [ACTIVEDS.13] + */ +HRESULT WINAPI ADsGetLastError(LPDWORD pError, LPWSTR buffer, DWORD buflen, LPWSTR bufname, DWORD bufnamelen) +{ + FIXME("(%p,%p,%d,%p,%d)stub\n", pError, buffer, buflen, bufname, bufnamelen); + return E_POINTER; +} Returning E_POINTER seems pretty wrong. -- James Hawkins

1 0

patches
by Louis. Lenders Aug. 21, 2008

Aug. 21, 2008

Hi, apparently none of my patches is making it into git, nor did i recieve any response from Alexandre about what's wrong with them. I guess i'm kind of "blacklisted" because of my dxdiag patch from a few months ago, where i took some code from a directX tutorial ( i thought tutorials were free code, well they aren't apparently). Anyway, there are i think some patches that contain useful things to fix some bugs, so if anyone would like to pick them up, feel free (espesially the fix for the google lively download) (@Alexandre: this is not a request from me to explain why the patches have been rejected. I don't want to be pissed off again by you like in your last mail; I may be a crappy coder, but i've been helping wine-users for a few years now, so i think i deserved a little more respect , than was reflected by that mail) Send instant messages to your online friends http://uk.messenger.yahoo.com

1 0

Re: [1/6][PATCH]AcceptEx Conformance Test
by James Hawkins Aug. 21, 2008

Aug. 21, 2008

On Thu, Aug 21, 2008 at 12:59 PM, Scott Lindeneau <slindeneau(a)gmail.com> wrote: > Simple overlapped server based on AcceptEx added to the test list > using simple clients. > Tests must always 'pass'. That is, the individual ok tests must all pass, or if they fail you must wrap the failing tests in todo_wine blocks. Since your test was sent before the fixes and there are no todo_wine's, I'm assuming some of these tests fail. -- James Hawkins

1 0

Re: Spore patch to fix UI and Part descriptions
by Marcus Meissner Aug. 21, 2008

Aug. 21, 2008

> > diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c > index ddeaca3..dfbf818 100644 > --- a/dlls/d3d9/device.c > +++ b/dlls/d3d9/device.c > @@ -746,7 +746,8 @@ static HRESULT WINAPI IDirect3DDevice9Impl_GetDepthStencilSurface(LPDIRECT3DDE > } > } else { > WARN("Call to IWineD3DDevice_GetDepthStencilSurface failed\n"); > - *ppZStencilSurface = NULL; > + //*ppZStencilSurface = NULL; > + return D3DERR_INVALIDCALL; > } > LeaveCriticalSection(&d3d9_cs); You might cause a locking problem here, returning with d3d9_cs held. Ciao, Marcus

1 0

LinuxJournal poll: What do you use to run Windows applications on your Linux desktop?
by Dan Kegel Aug. 21, 2008

Aug. 21, 2008

Don't all go out and vote - we don't want to skew the results - but check out http://www.linuxjournal.com/node/1007221/results What do you use to run Windows applications on your Linux desktop? August 19th, 2008 by LJ Staff Cedega 1% (8 votes) Crossover 4% (38 votes) VirtualBox 22% (195 votes) VMWare 14% (129 votes) Wine 37% (333 votes) Other 2% (21 votes) I don't need or want to run Windows apps 19% (167 votes) Wine comes out on top, but not yet majority. - Dan

1 0

WSAIoctl question.
by Scott Lindeneau Aug. 21, 2008

Aug. 21, 2008

I noticed a patch that was submitted by John Griffiths on the 13th of July that forwards functions by mwsock.c using the following code: (commit: 2da98052d90591474c65bed853ca75e1da714823) +static void get_fn(SOCKET s, GUID* guid, FARPROC* fn) +{ + FARPROC func; + DWORD len; + if (!WSAIoctl(s, SIO_GET_EXTENSION_FUNCTION_POINTER, guid, sizeof(*guid), + &func, sizeof(func), &len, NULL, NULL)) + *fn = func; +} But wine's WSAIoctl does not support the SIO_GET_EXTENSION_FUNCTION_POINTER. I was wondering how this works and what its for? Is it for using native libraries?

1 0

Re: [PATCH] mstask: Task PersistFile AddRef, QueryInterface, and Release.
by Alexandre Julliard Aug. 21, 2008

Aug. 21, 2008

Roy Shea <royshea(a)gmail.com> writes: > + TaskImpl *This = (TaskImpl*) > + ((char*)(iface) - offsetof(TaskImpl, persistVtbl)); Please define an inline function for this like many other interfaces do. -- Alexandre Julliard julliard(a)winehq.org

1 0