August 2008 - Wine-Devel - list.winehq.org

Re: [WineHQ] [4/4] news: Remove the 'Weekly Newsletters' box from the home page.
by Zachary Goldberg Aug. 5, 2008

Aug. 5, 2008

On Mon, Aug 4, 2008 at 9:28 AM, Francois Gouget <fgouget(a)free.fr> wrote: > --- > > So assuming that all the previous patches were miraculously correct, then, > as discussed on wine-devel, we don't need the 'Weekly Newsletters' box > anymore. > > site | 6 ------ > 1 files changed, 0 insertions(+), 6 deletions(-) > > > > I'm still not 100% convinced removing this box altogether is the right idea. Making the box smaller (via taking out the indicies) might still achieve the same purpose of de-cluttering while still providing a repository of links to recent WWNs. Also, we should add a link in the main menu to http://winehq.org/?issue=back.

3 3

Re: [dplayx 01/12] Tests for CreateGroup
by Paul Vriens Aug. 5, 2008

Aug. 5, 2008

Ismael Barros wrote: > Tests for CreateGroup > Fixed the implementation of CreateGroup and CreateGroupInGroup so that > it doesn't segfault when the service provider is not initialized > > --- > dlls/dplayx/dplay.c | 10 ++ > dlls/dplayx/tests/dplayx.c | 340 ++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 350 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Ismael, On what Windows version are you running your tests for verification? Is there anything particular you are doing to speed up the tests on your box? test.winehq.org already shows timeouts for all boxes that are running W2K or higher. This new patch serie will even add more tests but I'm afaid we will not see any output from it on the mentioned website. -- Cheers, Paul.

2 1

Re: [1/2] user32: Add a test for ToUnicode (try 5)
by Paul Vriens Aug. 5, 2008

Aug. 5, 2008

Andre Wisplinghoff wrote: > Wrapping was still wrong. Sorry for that. Just using attachments now. > > dlls/user32/tests/input.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 files changed, 37 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > Just some things that caught my attention: Could you trim the length for some of the lines somewhat? I also don't think you need all those comments in the first call to ToUnicode. There is a C++ comment in the patch, should be avoided. And as a last one, is it possible to use names instead of magic constants? -- Cheers, Paul.

2 1

Re: [2/2] user32:focus.c Remove unneeded palette messages.
by Dmitry Timoshkov Aug. 5, 2008

Aug. 5, 2008

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > I run test-cases on 98 and XP and I can not see where this messages have > been posted in tests. In Wine this messages have not processing. > > Does anybody something know about this? Try to run the tests in a paletted (256 color) mode. -- Dmitry.

2 1

Re: msxml3: Add ISAXContentHandler_endPrefix event (1/7)
by Alexandre Julliard Aug. 5, 2008

Aug. 5, 2008

Piotr Caban <piotr.caban(a)gmail.com> writes: > +static HRESULT namespacePush(saxlocator *locator, int ns) > +{ > + if(locator->nsStackLast+1>locator->nsStackSize) > + { > + locator->nsStackSize += STACKALLOCATIONSIZE; > + locator->nsStack = HeapReAlloc(GetProcessHeap(), 0, > + locator->nsStack, locator->nsStackSize); > + if(!locator->nsStack) return E_FAIL; You should preserve the existing stack on failure. Also the growth should be by a multiple of the current size instead of a constant. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9: Implementation of D3DXMatrixDecompose and tests
by tony.wasserka＠freenet.de Aug. 5, 2008

Aug. 5, 2008

Hi, 1. The order of + /*The components of the translation transformation vector are straigth in the fourth column of the transformation matrix*/ + (*pouttranslation).x=(*pM).m[3][0]; + (*pouttranslation).y=(*pM).m[3][1]; + (*pouttranslation).z=(*pM).m[3][2]; + + /*Let's calculate rotation now*/ + /*If some of the scale factors is zero, it is impossible to obtain the rotation*/ + if (((*poutscale).x==0)||((*poutscale).y==0)||((*poutscale).z==0)) + { + return D3DERR_INVALIDCALL; + } should be reversed, as we want to return D3DERR_INVALIDCALL as soon as possible (if needed). Also, the whole code can be simplified to: + /*If some of the scale factors is zero, it is impossible to obtain the rotation*/ + if ((poutscale->x==0)||(poutscale->y==0)||(poutscale->z==0)) + return D3DERR_INVALIDCALL; + + /*The components of the translation transformation vector are straigth in the fourth column of the transformation matrix*/ + pouttranslation->x=pM->m[3][0]; + pouttranslation->y=pM->m[3][1]; + pouttranslation->z=pM->m[3][2]; + + /*Let's calculate rotation now*/ (Note the removed {} which saves two lines of code) 2. I haven't tested this, but if you haven't done so yet, you should check the function's behavior if one of the pointers is NULL. If it segfaults with native d3dx9_36, your code is okay, otherwise you'll need an additional check right at the beginning. 3. Also, there were some spelling mistakes: + /*The scale factors are the modules of the three vectors __of that__ lie in __the__ column of the 3x3 submatrix*/ + /*The scale factors are the modules of the three vectors __which__ lie in __each__ column of the 3x3 submatrix*/ + /*If some of the scale factors is zero, it is impossible to obtain the rotation*/ + /*If __any scale factor__ is zero, it is impossible to obtain the rotation*/ + /*Then we go for the biggest component in order to __minimise__ division error as commonly explained in the __literacy__. + We just calculate one component from the diagonal to avoid sign loss of the square root. The first sign is not important + because the rotations (x,y,z,w) and (-x,-y,-z,-w) are equivalent. But if we __calc ulated__ the other two components we would have + to choose and could be wrong.*/ + /*Then we go for the biggest component in order to __minimize__ division error as commonly explained in the __literature__. + We just calculate one component from the diagonal to avoid sign loss of the square root. The first sign is not important + because the rotations (x,y,z,w) and (-x,-y,-z,-w) are equivalent. But if we __calculated__ the other two components we would have + to choose and could be wrong.*/ 4. Regarding the test, you should perhaps explain in a one-line comment what's special about the tested numbers in comparison to the others (other sign? invalid numbers? etc.) 5. It's not bad, but for the future you may want to split the implementation and the test in two patches so that you have a greater chance to get one of them in. Best regards, Tony Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl. http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/i…

1 0

Re: [NJS#80583] Re: ntdll: import dll from dir of referring dll if not found instandard locations
by Dmitry Timoshkov Aug. 5, 2008

Aug. 5, 2008

"Hongbo Ni" <hongbo(a)njstar.com> wrote: > I have posted a another patch regarding to windows hook into another > process. > http://www.winehq.org/pipermail/wine-patches/2008-August/059069.html > > Basically it change LoadlibraryW to LoadlibraryExW with Alt-path. > > Could you please let me know what your comment and guide me in coding > such test case? > > Basically the test need to inject 2 dlls into another process (say Notepad) > using SetWindowsHookEx(), and have some way to know if the dlls are > loaded by the target process. > > I can code the dll so it will send a message back to my test window to > inform me that they are loaded into Notepad. > > For those 2 DLLS, I have already made it on windows, How and where > can I add to wine test? > > Do I need submit the source and make file of those 2 dlls for maketest? > I am not sure how maketest create window DLL for auto-testing. Due to some problems there is no way to create an ELF wrapped hook dll using Wine tools. I'd suggest to create maximally stripped down test which works under Windows, and post an url to it with your fix. -- Dmitry.

1 0

Re: advapi32: Implement GetSecurityInfo.
by Dmitry Timoshkov Aug. 5, 2008

Aug. 5, 2008

"Dan Hipschman" <dsh(a)linux.ucla.edu> wrote: > +#include <assert.h> ... > @@ -2718,8 +2719,38 @@ DWORD WINAPI GetSecurityInfo( > PSECURITY_DESCRIPTOR *ppSecurityDescriptor > ) > { > - FIXME("stub!\n"); > - return ERROR_BAD_PROVIDER; > + SECURITY_DESCRIPTOR *sd; > + NTSTATUS status; > + ULONG n1, n2; > + > + status = NtQuerySecurityObject(hObject, SecurityInfo, NULL, 0, &n1); > + assert(status != STATUS_SUCCESS); > + if (status != STATUS_BUFFER_TOO_SMALL) > + return RtlNtStatusToDosError(status); assert() (or rather ok(0)) would be appropriate in the test case, but not in the implementation IMO. -- Dmitry.

1 0

Re: d3dx9: Implementation of D3DXGetVertexShaderProfile 2/2 try 4
by Ivan Gyurdiev Aug. 4, 2008

Aug. 4, 2008

Luis Busquets wrote: > + if ((caps.VS20Caps.NumTemps>=13) && > + (caps.VS20Caps.DynamicFlowControlDepth=24) && > + (caps.VS20Caps.Caps&D3DPS20CAPS_PREDICATION)) > + { > + return "vs_2_a"; > + } Please re-check - the second condition is an assignment and always true. - Ivan

1 0

Re: [4/10] WineD3D: Implement overlay position tracking
by H. Verbeet Aug. 4, 2008

Aug. 4, 2008

2008/8/4 Stefan Dösinger <stefan(a)codeweavers.com>: > and will be done in another patch wave. > About those... could you spread them out a bit? It's quite a bit of code to review, and right now I probably don't look as close as I probably should.

2 1