September 2008 - Wine-Devel

Re: winhttp: Implement some more options.
by Jacek Caban Sept. 3, 2008

Sept. 3, 2008

Hi Hans, Hans Leidekker wrote: > > +static BOOL session_set_option( object_header_t *hdr, DWORD option, LPVOID buffer, DWORD buflen ) > +{ > + if (hdr->type != WINHTTP_HANDLE_TYPE_SESSION) > + { > + release_object( hdr ); > + set_last_error( ERROR_WINHTTP_INCORRECT_HANDLE_TYPE ); > + return FALSE; > + release_object call looks wrong here. Also, if you use vtbls properly, you shouldn't need to check the type here. Jacek

2 1

Re: [PATCH 4/5] wined3d: Remove glDrawBuffer calls in BltOverride.
by Henri Verbeet Sept. 3, 2008

Sept. 3, 2008

2008/8/31 Alexander Dorofeyev <alexd4(a)inbox.lv>: > > Handled in ActivateContext, must be remains of pre-context management code. > --- > dlls/wined3d/surface.c | 10 ---------- > 1 files changed, 0 insertions(+), 10 deletions(-) > If you're going to remove those glDrawBuffer calls, you should remove the buffer variable completely.

2 3

Re: [9/9] gdiplus: initial GdipFlattenPath implementation
by Alexandre Julliard Sept. 3, 2008

Sept. 3, 2008

Nikolay Sivov <bunglehead(a)gmail.com> writes: > +/* free all nodes including argument */ > +void free_path_list(path_list_node_t *node) > +{ > + path_list_node_t *n = node; > + > + while(!n){ > + GdipFree(node); > + node = n = n->next; > + } This won't do what you want. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ntdll: Fix a few failing tests in Vista
by Alexandre Julliard Sept. 3, 2008

Sept. 3, 2008

"James Hawkins" <jhawkins(a)codeweavers.com> writes: > @@ -325,13 +327,21 @@ static void read_file_test(void) > iosb.Information = 0xdeadbeef; > offset.QuadPart = strlen(text) + 2; > status = pNtReadFile( handle, event, apc, &apc_count, &iosb, buffer, 2, &offset, NULL ); > - ok( status == STATUS_END_OF_FILE, "wrong status %x\n", status ); > - ok( U(iosb).Status == 0xdeadbabe, "wrong status %x\n", U(iosb).Status ); > - ok( iosb.Information == 0xdeadbeef, "wrong info %lu\n", iosb.Information ); > - ok( !is_signaled( event ), "event is signaled\n" ); > + ok( status == STATUS_END_OF_FILE || > + status == STATUS_PENDING, /* Vista */ > + "wrong status %x\n", status ); > + ok( U(iosb).Status == 0xdeadbabe || > + U(iosb).Status == STATUS_END_OF_FILE, /* Vista */ > + "wrong status %x\n", U(iosb).Status ); > + ok( iosb.Information == 0xdeadbeef || > + iosb.Information == 0, /* Vista */ > + "wrong info %lu\n", iosb.Information ); > ok( !apc_count, "apc was called\n" ); > SleepEx( 1, TRUE ); /* alertable sleep */ > - ok( !apc_count, "apc was called\n" ); > + if ( is_signaled( event ) ) > + ok( apc_count == 1, "apc was not called\n" ); > + else > + ok( !apc_count, "apc was called\n" ); The results are not independent, they should all depend on whether we got STATUS_PENDING or not. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [msxml3/tests 1/2] Use CreateFileA to please win98
by James Hawkins Sept. 3, 2008

Sept. 3, 2008

On Wed, Sep 3, 2008 at 2:54 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > CreateFileW is not implemented on win98. This fixes the 2 remaining test > failures for win98. > > (This is a replacement for the patch James sent). > > Changelog > Use CreateFileA to please win98 > Just a nitpick: + static const CHAR testXmlA[] = "test.xml"; You don't really need this variable. Same thing for the next patch. -- James Hawkins

2 1

Re: msxml3: Fix a failing test in win98
by Paul Vriens Sept. 3, 2008

Sept. 3, 2008

James Hawkins wrote: > Hi, > > Changelog: > * Fix a failing test in win98. > > dlls/msxml3/tests/xmlelem.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > ------------------------------------------------------------------------ > > Two things: The comment says "Win98 returns ERROR_URL_NOT_FOUND" but the ok now has a different comment. I don't think this fix is correct as the failure comes most likely from the GetFullPathNameW just above that. (This probably means the first change, commit 558ae52cc464269457833cfb08879550a63a5d13, was wrong as well). -- Cheers, Paul.

2 1

Re: msxml3: Fix two failing tests in win98
by Paul Vriens Sept. 3, 2008

Sept. 3, 2008

James Hawkins wrote: > Hi, > > Changelog: > * Fix two failing tests in win98. > > dlls/msxml3/tests/saxreader.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > > > ------------------------------------------------------------------------ > > I don't think this is the correct fix. It all fails because of the CreateFileW slightly above that. -- Cheers, Paul.

1 0

Common conformance test errors
by Dan Kegel Sept. 3, 2008

Sept. 3, 2008

The file http://kegel.com/wine/common-errors.txt is a list of the most common errors in patchwatcher log files, computed by running egrep ": Test failed: |: Test succeeded inside todo block: |^make\[.*\]: \*\*\* \["| sort | uniq -c | sort -rn on about 500 "make test" runs on a dual core box with a new nvidia card. Here are the top ten: 2597 urlmon:protocol.c:1597: Test failed: Read failed: 8000000a (0 bytes) 927 wininet:http.c:115: Test failed: unexpected status 51 (INTERNET_STATUS_CONNECTION_CLOSED) 927 wininet:http.c:115: Test failed: unexpected status 50 (INTERNET_STATUS_CLOSING_CONNECTION) 927 wininet:http.c:115: Test failed: unexpected status 11 (INTERNET_STATUS_NAME_RESOLVED) 927 wininet:http.c:115: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) 824 d3d9:device.c:829: Test failed: Screen height is 1024 824 d3d9:device.c:828: Test failed: Screen width is 1280 824 d3d9:device.c:782: Test failed: Screen height is 1024 824 d3d9:device.c:781: Test failed: Screen width is 1280 519 make[1]: *** [user32/tests/__test__] Error 2 So many of the tests fail always that I will probably have to start running the baseline tests fifty times after each git change, to catch all the ones that only happen a small percentage of the time. - Dan

1 0

Re: rpcrt4: Fix a failing test in Vista
by Rob Shearman Sept. 2, 2008

Sept. 2, 2008

2008/9/2 James Hawkins <jhawkins(a)codeweavers.com>: > Hi, > > Changelog: > * Fix a failing test in Vista. > > dlls/rpcrt4/tests/rpc.c | 4 +++- > dlls/schannel/tests/main.c | 4 +++- > 2 files changed, 6 insertions(+), 2 deletions(-) It looks like another fix got mixed in with this commit. Please resend without the schannel change. -- Rob Shearman

1 0

Re: [PATCH 3/5] wined3d: Make the condition to enter p8 conversion shader path more strict.
by Henri Verbeet Sept. 2, 2008

Sept. 2, 2008

2008/8/31 Alexander Dorofeyev <alexd4(a)inbox.lv>: > > This prevents shader path from being entered for an offscreen surface when > there is p8 render target and fixes failures in ddraw visual test (with > opengl rendering and RTL_READDRAW mode) and visual glitches in Red Alert. > --- > dlls/wined3d/surface.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > This is probably ok for this specific case, but in general I think primary_render_target_is_p8() is somewhat broken. It seems that in most places where it's used it is assumed that "This" is the primary render target. In some cases that's actually always true, but in those cases primary_render_target_is_p8() wouldn't need to check if there's a primary render target, it could just use a surface passed in as parameter. In the other cases, you don't actually know the surface is the primary render target, and you'd need to verify that first, after which you've essentially got the first case again.

2 2

mailman problems?
by Nikolay Sivov Sept. 2, 2008

Sept. 2, 2008

What seems to be the problems with mailing lists? As for me I get emails with a huge lag, still able to see them on web as they come (without any lag)

2 1

git still down...
by Dan Kegel Sept. 2, 2008

Sept. 2, 2008

$ git pull source.winehq.org[0: 209.46.25.134]: errno=Connection refused :-(

4 3

Re: Repeated messages (was Re: Adding Flawfinder to Patchwatcher)
by James Mckenzie Sept. 2, 2008

Sept. 2, 2008

Erik: I am and at four MB a pop this is getting very expensive. Fortunately, I have caught every one of them. Maybe gmail is choking on the message or the 'finished' command comes too late to prevent the message from being sent again and again. James McKenzie -----Original Message----- >From: Erik de Castro Lopo <mle+win(a)mega-nerd.com> >Sent: Aug 31, 2008 4:38 PM >To: wine-devel(a)winehq.org >Subject: Repeated messages (was Re: Adding Flawfinder to Patchwatcher) > >Austin English wrote: > >> I had a discussion with Dan about adding Flawfinder to the >> patchwatcher. > >Is anyone else getting multiple copies of this message? I seem >to be getting one every 10-20 minutes. > >A quick scan of the email headers suggests that this is getting >resent from within the Gmail system. Each duplicate has a received >line like: > > Received: by ey-out-1920.google.com with SMTP id 4so195432eyg.30 > for <wine-devel(a)winehq.org>; Thu, 28 Aug 2008 20:50:50 -0700 (PDT) > >with a unique SMTP id. > >Erik >-- >----------------------------------------------------------------- >Erik de Castro Lopo >----------------------------------------------------------------- >Beware the Lollipop of Mediocrity. >Lick it once, and you suck forever. > >

2 1

Re: wine-devel Digest, Vol 37, Issue 111
by Tim Schwartz Sept. 2, 2008

Sept. 2, 2008

So Austin, have you had a chance to have a discussion with Dan about adding flawfinder to patchwatcher? On Aug 31, 2008, at 4:12 AM, wine-devel-request(a)winehq.org wrote: > Send wine-devel mailing list submissions to > wine-devel(a)winehq.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://www.winehq.org/mailman/listinfo/wine-devel > or, via email, send a message with subject or body 'help' to > wine-devel-request(a)winehq.org > > You can reach the person managing the list at > wine-devel-owner(a)winehq.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of wine-devel digest..." > > > Today's Topics: > > 1. Adding Flawfinder to Patchwatcher (Austin English) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Thu, 28 Aug 2008 15:59:20 -0500 > From: "Austin English" <austinenglish(a)gmail.com> > Subject: Adding Flawfinder to Patchwatcher > To: "wine-devel(a)winehq.org" <wine-devel(a)winehq.org> > Message-ID: > <b6bb06270808281359o1d1258f9m1af82eddbb763f32(a)mail.gmail.com> > Content-Type: text/plain; charset="utf-8" > > I had a discussion with Dan about adding Flawfinder to the > patchwatcher. Currently, it's got some pretty generic errors, but it > seems able to test only patches, so we wouldn't be flooded with old > nonbugs (or we could set up a blacklist of safe errors). For > reference, I've run it on today's git. I'm attaching the full log, as > well as a condensed version of the most common errors (1 per error > type). Looks like a lot of chances for buffer overflows.. > > Thoughts? > > -Austin >

2 1

Re: Repeated messages (was Re: Adding Flawfinder to Patchwatcher)
by F Capela Sept. 2, 2008

Sept. 2, 2008

----- Original Message ---- From: L. Rahyen <research(a)science.su> > Yes, I can confirm this. Some time ago copies of this message > stopped coming. However, this was annoying because the message > contains "heavy" attachment. I hope this will not happen again... I'm receiving multiple copies of other messages also, from at least 4 different authors. Seems like all of them use GMail. Fábio Oliveira Schmidt Capela darkwalker_(a)yahoo.com

1 0

Re: mlang: Remove a test that fails on all systems
by Paul Vriens Sept. 2, 2008

Sept. 2, 2008

Hi, (Grabbed this mail from http://www.winehq.org/pipermail/wine-patches) This test however fails on Windows and succeeds on Wine so there must be something wrong (not 100% correct) in Wine? Maybe Aric should check this one out? -- Cheers, Paul.

2 3

Re: gdiplus: Add some documentation stubs to make winapicheck happy.
by Nikolay Sivov Sept. 2, 2008

Sept. 2, 2008

Francois Gouget wrote: > +/***************************************************************************** > + * GdipSetEmptye [GDIPLUS.@] > + */ > Typo here.

1 0

Implementing textures functions of d3dx using an extern library.
by Jérôme Gardou Sept. 2, 2008

Sept. 2, 2008

It appears this mail did not get in, so I resend it... ---------- Forwarded message ---------- From: Jérôme Gardou <jerome.gardou(a)gmail.com> Date: 2008/8/26 Subject: Implementing textures functions of d3dx using an extern library. To: wine-devel(a)winehq.org D3DX supports a wide range of file types for textures. Instead of rewriting everything from scratch, the best would certainly be to use some image processing library to handle them. As a bonus, this would allow lighter code. Some of those library are : SDL_Image : easy to use, but loading an image using a SDL_Surface is quite heavy. Moreover, the files supported are not enough for d3dx. MagickWand/MagickCore, the libraries on which imagemagick is based : Hard to use, and very heavy. Supports every format thet d3dx supports. FreeImage : Quite easy to use, the only files not supported are DIB and PFM... Not so widely represented. I had to recompile it, as packages for it are not available for 32 bits. (I use a 64 bits ubuntu system). Here is an implementation of D3DXGetImageInfoFromFileInMemory using FreeImage. Suggestions and comments are welcomed. PS : Please CC me your potential answers, as I'm not a subscriber of this list.

2 1

ntoskrnl.exe tests
by Alexander Morozov Sept. 2, 2008

Sept. 2, 2008

Hello, What should modify in these patches that they can be accepted: [try 5] [1/4] dlls/Maketest.rules.in: Add support of building various resources for cross and usual tests http://www.winehq.org/pipermail/wine-patches/2008-August/060204.html [try 5] [2/4] Add tests for ntoskrnl.exe http://www.winehq.org/pipermail/wine-patches/2008-August/060205.html [try 5] [3/4] include/ddk/wdm.h: Add IO_TYPE_* defines http://www.winehq.org/pipermail/wine-patches/2008-August/060203.html [try 5] [4/4] ntoskrnl.exe/tests: Add tests for IoInitializeIrp and IoAllocateIrp http://www.winehq.org/pipermail/wine-patches/2008-August/060206.html

1 0

Re: Patch for font size = 0x7fff in dialog templates
by Koro Sept. 2, 2008

Sept. 2, 2008

> This is a patch that fixes a discrepancy between WINE's dialog manager > and the real Windows one. If, in a dialog template, (assuming DS_SETFONT > is set) the font size is 0x7fff, it means that the dialog manager must > use the message box font and not read the rest of the font data > (facename and others) off the template. > > This quirk is "documented" in a comment there, and I have myself > confirmed this behavior with some of my code a few months ago: > http://blogs.msdn.com/oldnewthing/archive/2005/04/29/412577.aspx#413552 > > Sending patch as attachment because putting it inline would probably > word-wrap it all over the place. What was wrong with my patch? I never heard of it again, and last time I checked http://source.winehq.org/source/dlls/user32/dialog.c it still wasn't there.

2 1

Re: Recent msi/package tests failures
by James Mckenzie Sept. 1, 2008

Sept. 1, 2008

Paul/James: Paul Vriens wrote: >James Hawkins wrote: >> On Sat, Aug 30, 2008 at 3:17 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: >>> Hi, >>> >>> I just sent a few patches that fix the problem with the timeout on my >>> machines. >>> >>> Do you think it's still worthwhile to disable logging by using >>> MsiEnableLogA? When I now look in my temp folder I have a few hundred MSI >>> log files. We could either disable logging or create 1 file ourselves and >>> append everything to there (removing it afterwards maybe). >>> >> >> Logging to one file takes just as long as any other type of logging. >> No logging should be happening. No I don't think it's worth using >> MsiEnableLog to disable loggin. Logging is not enabled by default, >> and to enable it you have to change some registry entries, which I >> doubt anyone is doing. >> >The reason for the 1 file was not to speed up things but to limit the number of >logfiles in the temp directory (and maybe the ability to remove this file as we >know the one we created ourselves). > >On all of my boxes (95/98/NT/W2K/ 2 times XP/W2K3/Vista) I end up with 200 or so >logfiles in the temp directory after running the install tests. On none of these >boxes did I do anything to tinker with the msi logging settings. > >It would be nice if other could tell if they have a huge number of these >logfiles in their temp directory after running the tests. > +1 to one log file. I hate having to look through piles of log files to find errors. Yes, I know that I could grep them, but that is an added step that should not be needed. -- James McKenzie

2 1

Recent msi/package tests failures
by Paul Vriens Sept. 1, 2008

Sept. 1, 2008

Hi, I was looking into the recent test failures for the msi/package tests on my WinXP box. The reason for most of them was a stray MSITEST package that couldn't be removed via the 'Add/Remove Programs' (had to remove stuff from the registry). Any one else seeing this? (Adam Petaccia's XP box has the same issue I guess). -- Cheers, Paul.

5 12

RE: Fix for rendering issues when calling GetDepthStencilSurface
by Stefan Dösinger Sept. 1, 2008

Sept. 1, 2008

> When IWineD3DDevice_GetDepthStencilSurface returns WINED3DERR_NOTFOUND > it was setting ppZStencilSurface to null. This was the cause of > rendering issues with the 3d models in spore. Can you write a test for this? I think we have some depth stencil tests in dlls/d3d9/tests/device.c which you could use to test this. I think you are right with this patch - I vaguely remember writing a test for a different getter function, but it is better to be sure

3 4

Problems Running Windows app
by Chris Vermeulen Sept. 1, 2008

Sept. 1, 2008

Hi Please help me I'm currently running ubuntu 8.04, with wine 1.0 I've got a program that I use to program Telephone systems. It uses a SQL database with a web interface. but I can't get this to work on wine, if I want to install it gives me the following and just closes. Usage: Install a product: msiexec {package|productcode} [property] msiexec /i {package|productcode} [property] msiexec /a package [property] Repair an installation: msiexec /f[p|o|e|d|c|a|u|m|s|v] {package|productcode} Uninstall a product: msiexec /x {package|productcode} [property] Advertise a product: msiexec /j[u|m] package [/t transform] [/g languageid] msiexec {u|m} package [/t transform] [/g languageid] Apply a patch: msiexec /p patchpackage [property] msiexec /p patchpackage /a package [property] Modifiers for above operations: msiexec /l[*][i|w|e|a|r|u|c|m|o|p|v|][+|!] logfile msiexec /q{|n|b|r|f|n+|b+|b-} Register a module: msiexec /y module Unregister a module: msiexec /z module Display usage and copyright: msiexec {/h|/?} NOTE: Product code on commandline unimplemented as of yet Copyright 2004 Vincent B�ron Please help I'm hate this dual booting into windows. If I can get this working It'll be like a huge Christmas gift. If you need the program let me know and I'll get it to you Thanks Chris Vermeulen ##################################################################################### Notice This e-mail message and/or attachments may contain information that is confidential to ITEC and/or any of its affiliated companies. If you are not the intended recipient you cannot use, distribute or copy the message and/or attachments. In such a case, please notify the sender by return e-mail immediately and erase all copies of the message and/or attachments. Opinions, conclusions and other information in this message and/or attachments that do not relate to the official business of ITEC or any of its affiliated companies are neither given nor endorsed by it. ITEC and its affiliated companies accept no liability or responsibility of whatever nature for any failure or loss arising from the use of email as a form of communication. #####################################################################################

2 1