September 2008 - Wine-Devel

OT: linux market share trend data
by Dan Kegel Sept. 11, 2008

Sept. 11, 2008

I finally threw together a summary of four sources of linux market share data, see http://kegel.com/linux/marketshare.html

1 0

Re: richedit: Avoid acting on control words in skipped RTF groups (Bug 15227)
by Dylan Smith Sept. 11, 2008

Sept. 11, 2008

I noticed that this introduced a glitch, because I didn't have a destination callback for the \nesttableprops control word. This led to it being ignored, so nested tables would take on default properties. I will update this patch to fix this glitch and then resend it. On Wed, Sep 10, 2008 at 10:54 PM, Dylan Smith <dylan.ah.smith(a)gmail.com>wrote: > Previously the control words in skipped groups were being processed by > the read hook on the RTF parser. By moving this code into the class > callbacks for the parser, the skipped groups actually remain skipped. > > An example of a skipped group is a optional destination that isn't > recognized by the parser. The RTF specifications say to ignore these > groups, and native richedit controls act accordingly. > > This patch fixes bug 15227 which was caused by the \itap4 control word > in a destination which caused an unterminated table, since this control > word changes the nesting level by starting nested tables to reach that > nesting level. > --- > dlls/riched20/editor.c | 28 ++++++---------------------- > dlls/riched20/editor.h | 6 ++++++ > dlls/riched20/reader.c | 8 ++++++++ > 3 files changed, 20 insertions(+), 22 deletions(-) >

1 0

Re: winex11.drv: Add support for _NET_WORKAREA
by Alexandre Julliard Sept. 11, 2008

Sept. 11, 2008

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > SetRect( &rect, 0, 0, width, height ); > + rc_work = rect; > > - if (root_window != DefaultRootWindow( gdi_display ) || !query_screens()) > + if (!XGetWindowProperty( gdi_display, DefaultRootWindow(gdi_display), x11drv_atom(_NET_WORKAREA), 0, > + ~0, False, XA_CARDINAL, &type, &format, &count, > + &remaining, (unsigned char **)&work_area )) > { > - default_monitor.rcWork = default_monitor.rcMonitor = rect; > + if (type == XA_CARDINAL && format == 32 && count >= 4) > + { > + SetRect( &rc_work, work_area[0], work_area[1], > + work_area[0] + work_area[2], work_area[1] + work_area[3] ); > + } > + XFree( work_area ); > + } > + > + if (root_window != DefaultRootWindow( gdi_display ) || !query_screens( &rc_work )) > + { > + default_monitor.rcMonitor = rect; > + default_monitor.rcWork = rc_work; That won't do the right thing in desktop mode. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winemenubuilder: eliminate wineshelllink (try 3)
by Alexandre Julliard Sept. 11, 2008

Sept. 11, 2008

"Damjan Jovanovic" <damjan.jov(a)gmail.com> writes: > + /* winemenubuilder_semaphore ensures mutual exclusion for the temp file */ > + tempfilename = heap_printf("%s/next-wine-menu.temp", xdg_config_dir); That's not good enough, the config dir is global to all Wine instances. You really need safe temp file creation. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 02/14] inetcomm: Add a stub MimeInternational object.
by Alexandre Julliard Sept. 11, 2008

Sept. 11, 2008

Huw Davies <huw(a)codeweavers.com> writes: > @@ -8,6 +8,7 @@ IMPORTS = uuid ole32 ws2_32 user32 advapi32 kernel32 > > C_SRCS = \ > inetcomm_main.c \ > + internat.c \ > internettransport.c \ > mimeole.c \ > regsvr.c I find that abbreviating 'international' as 'internat' is a bit confusing, especially in a dll that also uses 'internet' in various places. Would you mind changing it to mimeintl.c or something like that? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: crypt32: Fix a failing test in win9x
by Paul Vriens Sept. 11, 2008

Sept. 11, 2008

James Hawkins wrote: > Hi, > > Changelog: > * Fix a failing test in win9x. > > dlls/crypt32/tests/ctl.c | 15 +++++++++++---- > 1 files changed, 11 insertions(+), 4 deletions(-) > > > > ------------------------------------------------------------------------ > > The !ret in: + else + { + ok(!ret && GetLastError() == CRYPT_E_EXISTS, + "expected CRYPT_E_EXISTS, got %d %08x\n", ret, GetLastError()); + } is superfluous. -- Cheers, Paul.

2 2

Re: [setupapi/tests] Fix a failure on Windows 2000
by James Hawkins Sept. 11, 2008

Sept. 11, 2008

On Wed, Sep 10, 2008 at 10:03 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > W2K doesn't fail with ERROR_INVALID_NAME but with ERROR_GENERAL_SYNTAX > (setupapi > error). > That error was added for a reason; it was seen on a win2k box. Please don't remove it. -- James Hawkins

2 2

Re: [PATCH 1/2] kernel32/test: Test import entries of a core windowsDLLs (Revision 2)
by Dmitry Timoshkov Sept. 11, 2008

Sept. 11, 2008

"Roy Shea" <royshea(a)gmail.com> wrote: > This revision places the new test with the other loader tests in > loader.c, and for testing loads kernel32.dll rather than riched20.dll Please move an existing and new tests to their own bodies, and use GetModuleHandle instead of LoadLibrary. -- Dmitry.

1 0

Re: devenum: Fix order of operations bug (Coverity id 709)
by Chris Robinson Sept. 10, 2008

Sept. 10, 2008

On Wednesday 10 September 2008 11:34:03 am Juan Lang wrote: > dwMediaTypeSize + (dwMediaTypeSize < 2 ? 1 : dwMediaTypeSize / 2) I'm pretty sure this would come out as: dwMediaTypeSize + (dwMediaTypeSize < (2 ? 1 : dwMediaTypeSize) / 2) But even if it doesn't, I don't think it'd hurt to be more explicit: dwMediaTypeSize + ((dwMediaTypeSize < 2) ? 1 : (dwMediaTypeSize/2))

3 3

Re: [PATCH] static buffer overflow checking
by Michael Karcher Sept. 10, 2008

Sept. 10, 2008

Am Mittwoch, den 10.09.2008, 22:12 +0200 schrieb Marcus Meissner: > This approach will not work with -O0, which might be a problem. If I were to decide, that would kill the patch. I really like to recompile the dlls I am currently debugging with -O0, as that makes following the code flow much easier. Having MultiByteToWideChar calls fail in that case seems to make recompilation of most DLLs (that export A and W functions) with -O0 impossible. Regards, Michael Karcher

3 3

Re: [jscript/tests] Prevent a crash on win9x
by Jacek Caban Sept. 10, 2008

Sept. 10, 2008

Paul Vriens wrote: > Hi, > > This at least prevents the crash on win9x. There are still numerous > failures on > win9x but they are visible now. (I'm not so sure about returning > S_FALSE in this case btw). IMO it would be better to return error code and break whole test on win9x or find a way to do so before running script. If we wanted to support win9x we'd probably need to add objects representing each function, which is not worth the trouble. Thanks, Jacek

1 0

Re: Fixed an infite loop in winedbg: review wanted
by Eric Pouech Sept. 10, 2008

Sept. 10, 2008

Florian Köberle a écrit : > Hello > > This patch address the infinite loop found at bug 15209: > http://bugs.winehq.org/show_bug.cgi?id=15209 > > At least one of the lines I moved in the loop doesn't make sense outsite: > count -= min(count, 256); > because the value of count will be always 0 after the loop. > > I also moved the following line which might be at the wrong position > too. About that I am not sure: > + fcp->Start += 256; > > Best regards, > Florian Koeberle > > ------------------------------------------------------------------------ > > looks a correct fix to me (moving both lines) A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: [PATCH 1/2] kernel32/test: Test import entries of a core windows DLLs (Revision 2)
by Paul Vriens Sept. 10, 2008

Sept. 10, 2008

Roy Shea wrote: > This revision places the new test with the other loader tests in > loader.c, and for testing loads kernel32.dll rather than riched20.dll > > The prior version of this patch is available for reference at: > http://www.winehq.org/pipermail/wine-patches/2008-September/061226.html > --- > dlls/kernel32/tests/loader.c | 72 ++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 72 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > Hi, Minor things : typo in "kerenl32_module" and shouldn't you free the library after the test? (Or maybe use GetModuleHandle, or does that defeat the test?) -- Cheers, Paul.

1 0

Patchwatcher security improvements
by Ambroz Bizjak Sept. 10, 2008

Sept. 10, 2008

Hi, I've abandoned my chroot aproach to improving security in patchwatcher. Instead I've implemented the ability to run untrusted code as a user different than the one running patchwatcher. This is because creating a chroot where Wine could be compiled and tested proved to be too difficult and platform-dependent. I've also added external time limits for running untrusted code. This as a whole should help prevent individual patches from stalling the patch watching process. It very easy to set up. All you need is a low-privileged user (but enough to run the tests, e.g. audio, video groups) and an empty folder where you can write but this user can only read (not your home folder, it shouldn't have access there anyway). To use it, start with a clean patchwatcher and adjust the variables in the patchwatcher.sh, then run "patchwatcher.sh intialize". It will instruct you to run some commands as root (setuid the wrapper). Run initialize again and it should build wine and run baseline tests. Then you can test it by putting a patch in patches/ and issuing the try_one_patch command. To start watching use the continuous_build command. Patch is attached.

4 7

Re: gdi32: Don't crash when copying to an EMF from a NULL bitmap.
by Austin English Sept. 10, 2008

Sept. 10, 2008

On Mon, Sep 8, 2008 at 3:03 PM, Austin English <austinenglish(a)gmail.com> wrote: > Based on an original patch by Mike McCormack. Rediffed against current > git. Testcase included, passes in WinXP. Fixes bug 4543. > Anything wrong with this one?

2 1

Re: Patchwatcher security improvements
by Ambroz Bizjak Sept. 10, 2008

Sept. 10, 2008

Dan Kegel wrote: > So the slave can be in another real machine, another virtual machine, or running as another user; anything as long as it can get read/write access to its subdirectory of the shared directory. The problem with your design right now is that you want to run the slave in some isolated environment and expect it to be secure. The build slave itself is a mission-critical process and putting it in a quarantine to run together with untrusted code allows malicious patches to interfere with its operation. This means an attacker can just kill it from inside his patch, causing the whole patch building operation to fail, or corrupt the baseline tree, or send hundreds of fake emails through the slave interface. So I plan to run the build slave itself in a trusted environment, but make it quarantine individual build operations (similar to my previous design with user switching). This way the impact of an attack is highly limited - all it can theoretically do is fake his own patch results.

1 0

Re: Praise of sorts for Wine re Softmaker Office 2008
by Susan Cragin Sept. 10, 2008

Sept. 10, 2008

>Dan Kegel wrote: >> http://forum.ubuntuusers.de/topic/softmaker-office-2008--eine-alternative--… >> has a review of an office suite named Softmaker Office 2008, >> available for Windows and now also Linux. The review says in part >> >> "Irritiert hat uns, daß die Windows-Version von Office 2008, die >> von Stick gestartet werden kann, unter Wine besser, schneller >> und stabiler läuft, wie die native Office 2008 für Linux. Wer also >> die Windows-Version legal erworben hat, kann hier Geld sparen." >> >> ("It irritated us that the Windows version runs better on Wine >> than the native Linux version. If you have the Windows version >> already, save your money and run it on Wine.") >> >> That's praise of sorts... although I hope it doesn't >> dissuade other vendors from doing native ports. >> - Dan >> > >I noticed the same type of thing when I was playing with DVD Shrink a couple >days ago. Ripping speed in DVD Shrink via Wine was significantly faster than on >Windows. What usually is a 2.5 hour process was about 1.5-1.75 hour process. > >I agree though, hopefully the software vendors will do native ports :). > >-Zac I just attended the convention for the National Verbatim Reporters Association in Savannah, where I demonstrated DNS 9.0 running on WINE with Ubuntu Studio (realtime kernel seems to make a slight difference). All the vendors were impressed, and one said he'd never seen DNS 9 run that fast, that accurately.

1 0

Re: [msi/tests] Create only one log file and delete it afterwards
by James Hawkins Sept. 10, 2008

Sept. 10, 2008

On Wed, Sep 10, 2008 at 7:39 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > Instead of having 200 logfiles we now create one that we can delete > afterwards > as we know the name. This is not to speed up the tests but merely to get rid > of > the log files. > > We have to pass something for the log mode otherwise we would still have > multiple files. > > (It also looks like Wine is still appending to that one file which is not > the > same as on Windows). > > Changelog > Create only one log file and delete it afterwards > Why don't you just disable logging? MsiEnableLog(0, NULL, 0); -- James Hawkins

2 1

Re: Patchwatcher security improvements
by Ambroz Bizjak Sept. 10, 2008

Sept. 10, 2008

Francois Gouget wrote: > This seems like an almost perfect task for a virtual machine: > * set up you virtual machine to taste > * take a snapshot > * to test a patch, fire up the virtual machine > * have it test the patch > * after the test or when it times out, revert it to the snapshot * rinse (done in the step above), repeat > > This could be done with VirtualBox, but maybe other alternatives based on Xen or KVM or some such would be better. The main issue I see with this is that the OpenGL / DirectSound tests will not run on the real hardware (as usual), but maybe a Xen-like approach could help there. > > It would also make it easy to test on FreeBSD / Solaris, at least if based on something like VirtualBox (not sure about the Xen-like > approaches). Seems like a good idea. I suggest only to use Linux as the host OS and run guests with KVM or VirtualBox, or even UML for Linux builds. Then we can run any OS that uses X as a guest and configure it to use the host's X display (through the virtual network). This should theoretically allow OpenGL through the XGL protocol, but VMGL can also be used if it doesn't work well. And sound hardware would be emulated by the VM software. I think I'll try getting a small Gentoo system to run in UML with a read-only root fs and make it boot as fast as possible. To try a patch, I would give it read access to the master Wine tree on the host, it would copy it to a writable temp folder and try it out. After it's finished or if the external timeout elapses, the UML process will be terminated and all of its writable storage will be reverted.

1 0

Re: explorer.exe: Implement SC_SCREENSAVE by starting xdg-screensaver
by Steven Edwards Sept. 10, 2008

Sept. 10, 2008

On Wed, Sep 10, 2008 at 7:28 AM, Paul Chitescu <paulc(a)voip.null.ro> wrote: > Changelog: > explorer.exe: Implement SC_SCREENSAVE by starting xdg-screensaver with option > to lock the screen. > > The desktop window reacts to SC_SCREENSAVE by starting the screen saver, just > like it happens in Windows. No action is taken (and returns FALSE) if running > in a virtual desktop. > > Alternatively, a non-zero lparam is used to signal that the screen should be > locked. This cooperates with the user32.dll patch that implements > LockWorkStation(). This is an extension, there is no equivalent in Windows > but all the programs I've seen that trigger the system screen saver set > lparam=0. You forgot to attach the patch. Also you can send both patches together as one diff. There is no reason to split them up in this case. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: [2/3] mshtml: Add tests for get_scrollLeft
by Dan Kegel Sept. 10, 2008

Sept. 10, 2008

Did you forget a todo_wine? ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so dom.c ... fixme:mshtml:HTMLTextContainer_get_scrollLeft (0x15371b8)->(0x32fd34) dom.c:1077: Test failed: IHTMLTextContainer::get_scrollLeft failed: -1 dom.c:1078: Test failed: unexpected left -1, expected 0 ... make[2]: *** [dom.ok] Error 2 On Tue, Sep 9, 2008 at 8:48 PM, Patchwatcher <patchwatcher(a)kegel.com> wrote: > Hi! This is the experimental automated wine patchwatcher thingy. > The latest git sources were built and tested with your patch > "[2/3] mshtml: Add tests for get_scrollLeft" > Result: the patch failed regression tests. > > You can retrieve the full build results at > http://kegel.com/wine/patchwatcher/results/1347.log > and see the patch as parsed at > http://kegel.com/wine/patchwatcher/results/1347.txt > See > http://kegel.com/wine/patchwatcher/results > for more info. > >

1 0

Re: user32/test Added test about window sizes
by Florian Köberle Sept. 10, 2008

Sept. 10, 2008

Hi Please don't apply this patch. I will commit an updated version with a fix soon. Thanks, Florian Koeberle

1 0

Re: include: Define sigset_t in pthread.h if HAVE_SIGSET_T isn't defined.
by Paul Vriens Sept. 10, 2008

Sept. 10, 2008

Rob Shearman wrote: > --- > include/wine/pthread.h | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Rob, MingW has it's own definition of sigset_t (include/sys/types.h) which conflicts with this. Do we need to guard the definition in pthread.h with a "!defined(__MINGW32__)" or is this something that needs to be fixed on the MingW side. (Maybe change our configure?) -- Cheers, Paul.

2 2

Re: typelib: Implement LoadTypeLib16
by Alexandre Julliard Sept. 10, 2008

Sept. 10, 2008

Detlef Riekenberg <wine.dev(a)web.de> writes: > +HRESULT WINAPI LoadTypeLib16(LPSTR szFile, ITypeLib** pptLib) > { > - FIXME("(%s,%p): stub\n",debugstr_a(szFile),pptLib); > + LPWSTR nameW = NULL; > + HRESULT hr; > + DWORD len; > > - if (pptLib!=0) > - *pptLib=0; > + TRACE("(%s, %p)\n", debugstr_a(szFile), pptLib); > + > + if (szFile) { > + len = MultiByteToWideChar(CP_ACP, 0, szFile, -1, NULL, 0); > + nameW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, szFile, -1, nameW, len); > + } > > - return E_FAIL; > + hr = LoadTypeLib(nameW, pptLib); > + HeapFree(GetProcessHeap(), 0, nameW); > + return hr; Most likely you need to return a 16-bit interface here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] kernel32/test: Test import entries of a core windows DLL (riched20.dll) (Revision)
by Alexandre Julliard Sept. 10, 2008

Sept. 10, 2008

Roy Shea <royshea(a)gmail.com> writes: > This revision adds copyright information, removes todo_wine statements > to reflect the current wine head, and fixes an implicit typecast > warning. > --- > dlls/kernel32/tests/Makefile.in | 1 + > dlls/kernel32/tests/loader_image.c | 98 ++++++++++++++++++++++++++++++++++++ > 2 files changed, 99 insertions(+), 0 deletions(-) > create mode 100644 dlls/kernel32/tests/loader_image.c Please merge that into the other loader tests, no need to create a new file. Also you should test this on kernel32.dll, there's no reason to create a dependency on richedit. -- Alexandre Julliard julliard(a)winehq.org

1 0