September 2008 - Wine-Devel

Patchwatcher status: added urlmon:protocol.c and urlmon:url.c to blacklist
by Dan Kegel Sept. 9, 2008

Sept. 9, 2008

These tests failed randomly for a few people: urlmon:url.c:2125: Test succeeded inside todo block: unexpected OnProgress_CONNECTING urlmon:url.c:2129: Test failed: expected OnProgress_SENDINGREQUEST urlmon:url.c:2131: Test failed: expected OnResponse urlmon:protocol.c:1597: Test failed: Read failed: 00000001 (0 bytes) urlmon:protocol.c:365: Test failed: expected ReportData urlmon:protocol.c:1598: Test failed: Read failed: 8000000a (0 bytes) so I've added urlmon:url.c and urlmon:protocol.c to the patchwatcher blacklist, All of the tests that currently touch the real internet probably need to be changed to touch a mock internet if we want to have reliable tests.

1 0

Re: user32.dll: Add stub for LockWorkStation
by Steven Edwards Sept. 9, 2008

Sept. 9, 2008

On Mon, Sep 8, 2008 at 2:32 PM, Paul Chitescu <paulc(a)voip.null.ro> wrote: > Changelog: > user32.dll: Stub for LockWorkStation() > > Not sure if user_main.c is the right place but I put it together with > ExitWindowsEx. Would you mind taking a shot at implementing this properly? It was on my TODO but I most likely will never get back to it. Here is my patch from before which was wrong. http://www.winehq.org/pipermail/wine-patches/2007-May/039240.html What we need to do is use SendMessage to talk to the existing explorer.exe process and have it do the locking. Feel free to use what i have to make a patch if your interested. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 1

re: Patchwatcher security improvements
by Dan Kegel Sept. 9, 2008

Sept. 9, 2008

Interesting. One of my goals is to support Solaris and BSD; have you tried your stuff there? I'm currently refactoring patchwatcher.sh; I've pulled the generic stuff out into libpatchwatcher.sh and the wine-specific stuff into wine-slave.sh. Your changes will fit nicely into wine-slave.sh, I hope. I'm surprised you had to give up on the chroot... I was planning on trying to run just wine-slave.sh in a chroot jail, since it's the only part that would actually try to run any part of the wine build system. - Dan

2 2

Re: user32/test Added test about window sizes
by Michael Karcher Sept. 9, 2008

Sept. 9, 2008

Am Dienstag, den 09.09.2008, 14:13 +0200 schrieb Florian Köberle: > + ok( width == 500 && height == 6, "rect is not 6x6 but %dx%d: %d,%d-%d,%d\n", > + width, height, rect.left, rect.top, rect.right, rect.bottom); [...] > + ok( width == 6 && height == 500, "rect is not 6x6 but %dx%d: %d,%d-%d,%d\n", > + width, height, rect.left, rect.top, rect.right, rect.bottom); These messages contain a copy & paste mistake. Please fix the 6x6. Regards, Michael Karcher

1 0

coverity ... new run finally
by Marcus Meissner Sept. 9, 2008

Sept. 9, 2008

Hi folks, A new Coverity run (274) was done finally, so we can restart looking at issues ;) Still a lot of NULL ptr migration issues which suck to fix, but well. Ciao, Marcus

1 0

Re: notepad: Only append .txt to missing files without a dot in them (try2)
by Rob Shearman Sept. 9, 2008

Sept. 9, 2008

2008/9/8 Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com>: > - if (!lstrcmp(txtW, cmdline + lstrlen(cmdline) - lstrlen(txtW))) > + if (strchrW(PathFindFileNameW(cmdline), '.')) You're using one shell helper function already so why not use PathFindExtensionW instead? -- Rob Shearman

1 0

Re: [1/5] secur32: Require gnutls for schannel
by Alexandre Julliard Sept. 9, 2008

Sept. 9, 2008

"Henri Verbeet" <hverbeet(a)gmail.com> writes: > diff --git a/dlls/secur32/Makefile.in b/dlls/secur32/Makefile.in > index df9695a..9805d92 100644 > --- a/dlls/secur32/Makefile.in > +++ b/dlls/secur32/Makefile.in > @@ -6,6 +6,8 @@ MODULE = secur32.dll > IMPORTLIB = secur32 > IMPORTS = netapi32 advapi32 kernel32 ntdll > DELAYIMPORTS = crypt32 > +EXTRALIBS = @GNUTLSLIBS@ > +EXTRAINCL = @GNUTLSINCL@ You need to load the library dynamically, we don't want the whole dll to fail to load if gnutls is missing at run-time. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mshtml: Implement HTMLElement2 get_scrollLeft
by Alexandre Julliard Sept. 9, 2008

Sept. 9, 2008

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > @@ -831,8 +831,31 @@ static HRESULT WINAPI HTMLElement2_put_scrollLeft(IHTMLElement2 *iface, long v) > static HRESULT WINAPI HTMLElement2_get_scrollLeft(IHTMLElement2 *iface, long *p) > { > HTMLElement *This = HTMLELEM2_THIS(iface); > - FIXME("(%p)->(%p)\n", This, p); > - return E_NOTIMPL; > + nsIDOMNSHTMLElement *nselem; > + PRInt32 left = 0; > + nsresult nsres; > + > + TRACE("(%p)->(%p)\n", This, p); > + > + if(!This->nselem) { > + FIXME("NULL nselem\n"); > + return E_NOTIMPL; > + } > + > + nsres = nsIDOMHTMLElement_QueryInterface(This->nselem, &IID_nsIDOMNSHTMLElement, (void**)&nselem); > + if(NS_SUCCEEDED(nsres)) { > + nsres = nsIDOMNSHTMLElement_GetScrollLeft(nselem, &left); > + nsIDOMNSHTMLElement_Release(nselem); > + if(NS_FAILED(nsres)) > + ERR("GetScrollLeft failed: %08x\n", nsres); > + }else { > + ERR("Could not get nsIDOMNSHTMLElement interface: %08x\n", nsres); > + } Printing an ERR is not a substitute for handling errors, you can't just continue as if nothing happened. Or if the error really can be legitimately ignored then you shouldn't have an ERR. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Simplify tools/wrc a bit (RESEND)
by Alexandre Julliard Sept. 9, 2008

Sept. 9, 2008

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > Any thoughts on this patch? It breaks the WANT_NEAR_INDICATION case. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: add minimal ctxtcall.h
by Rob Shearman Sept. 9, 2008

Sept. 9, 2008

2008/9/8 Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk>: > +typedef HRESULT (*PFNCONTEXTCALL)(ComCallData *pparam); You don't explicitly tell widl that this function is a __stdcall function. Please check if that is automatically added in the generated header file. If not, you'll have to specify it here. > + > +/***************************************************************************** > + * IContextcallback interface > + */ Please change "IContextcallback" to "IContextCallback". -- Rob Shearman

1 0