January 2009 - Wine-Devel - list.winehq.org

install-wine-deps.sh can now handle 32 bit wine on 64 bit systems
by Dan Kegel Jan. 4, 2009

Jan. 4, 2009

I just improved http://code.google.com/p/winezeug/source/browse/trunk/install-wine-deps.sh so it does all the futzing needed to build 32 bit wine on 64 bit systems (although at the moment it only does this for Ubuntu Intrepid). Because it puts the missing .so files in /usr/lib32, there's no need to futz with LDPATH. For example, after running the script, you can do either ./configure make to build 64 bit wine, or ./configure --target=i686-unknown-gnu-linux make to build 32 bit wine. Easy beans! - Dan

2 2

long in IDL files?
by Michael Stefaniuc Jan. 4, 2009

Jan. 4, 2009

Hello guys, i guess that we need to change long to LONG in IDL files too, right? Or would that be something that widl could/should do automatically? bye michael

3 3

Linus Torvalds on Wine back in 1998
by Dan Kegel Jan. 4, 2009

Jan. 4, 2009

http://fringe.davesource.com/Fringe/Computers/Linux/Manifesto.txt It's taken longer than he expected... --- snip --- WINE (the Linux emulator for Windows) works to a fairly surprising degree. You can run real Windows programs with it, but some of them don't look right, and some of them just crash. But it has been making big progress in the last year, and now you can actually run Word for Windows. It doesn't work for everybody and there are known bugs, but it's almost becoming usable. I doubt people will wake up and say, "Hey, let's get rid of the shackles of Microsoft and switch to Linux and WINE." But there are going to be more and more people who discover they really want the networking abilities of Linux, or who run a web server on it. WINE slowly expands the group of people who would find Linux or some other operating system acceptable because they really don't care about Microsoft per se; they care about a few programs. In a few years WINE will be good enough that you can actually consider running Linux instead of Windows. It won't take over 100% of the market, but that's OK, too, because when you don't have one major entity that owns most of the market, it's a much saner, competitive environment. I think that'll happen, regardless of Linux. --- snip ---

1 0

Re: Build wine with gcc-4.3 and ssp
by Stefan Reimer Jan. 4, 2009

Jan. 4, 2009

> On Sat, Jan 03, 2009 at 07:52:10PM +0100, Stefan Reimer wrote: >> > On Fri, Jan 02, 2009 at 11:14:52PM +0100, Stefan Reimer wrote: >> I am using gentoo hardened: >> >> gcc (Gentoo Hardened 4.3.2-r7 p1.5, ssp, fortify, pie-10.2.0) 4.3.2 glibc 2.8 >> >> Using gcc -v gives: >> >> /usr/libexec/gcc/x86_64-pc-linux-gnu/4.3.2/cc1 -quiet -v -I. -I. >> -I../include -I../include -imultilib 32 preloader.c -D_FORTIFY_SOURCE=2 -fPIE -fstack-protector -fstack-protector-all -fno-strict-overflow -quiet >> -dumpbase preloader.c -m32 -march=athlon64 -auxbase-strip preloader.o -O2 >> -Wall -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -version -fno-strict-aliasing -o - | >> /usr/lib/gcc/x86_64-pc-linux-gnu/4.3.2/../../../../x86_64-pc-linux-gnu/bin/as -V -Qy --32 -o preloader.o - >> >> The hardened gcc specs brings in -fPIE, which is similiar to -fPIC. >> >> So YES I do ;-) >> >> Is this a problem ? > > -fPIE is a bit useless for the preloader (wine-preloader is actually loaded at a fixed > address), but it should not fail to build I guess. > > Does Wine still work afterwards? > > I don't see the patch hurting anything though. > > Ciao, Marcus > Hi, -fPIE is introduced by using the gentoo hardened profile and is applied everywhere possible. I think wine should be able to be build with -fPIE, despite not improving security be any means. Wine works like a charm btw. Sry for the double postings! Cyas Stefan

1 0

Re: shell32: add explorer toolbar bitmaps
by Juan Lang Jan. 4, 2009

Jan. 4, 2009

> so I just cutted icons from other toolbars' bitmaps; Which other toolbars, specifically? You can't grab copyrighted work, you know. --Juan

6 12

Re: libs/wine/debug.c: enlcosed a 'write' function with 'if' to prevent gcc warnings. 'if' does nothing cause program exits right after the statement anyway. (bug # 16413)
by Alexandre Julliard Jan. 4, 2009

Jan. 4, 2009

titon barua <titanix88(a)gmail.com> writes: > @@ -177,7 +177,8 @@ static void debug_usage(void) > "Example: WINEDEBUG=+all,warn-heap\n" > " turns on all messages except warning heap messages\n" > "Available message classes: err, warn, fixme, trace\n"; > - write( 2, usage, sizeof(usage) - 1 ); > + /* enclosed in 'if' statement to prevent gcc warnings */ > + if (write( 2, usage, sizeof(usage) - 1 )); Please don't do that sort of thing. That's much worse than the warning. -- Alexandre Julliard julliard(a)winehq.org

1 0

Use of "patch" keyword in Bugzilla
by Vitaliy Margolen Jan. 4, 2009

Jan. 4, 2009

Moving this conversation to wine-devel. > What |Removed |Added > ---------------------------------------------------------------------------- > Keywords|patch | > > ------- Comment #7 From Vitaliy Margolen 2009-01-03 19:47:16 [reply] ------- > > Patch keyword is for patches attached to bugs only and not sent to > wine-patches. > > ------- Comment #8 From Austin English 2009-01-03 20:01:55 [reply] ------- > > (In reply to comment #7) >> Patch keyword is for patches attached to bugs only and not sent to >> wine-patches. >> > > It's still useful, e.g., if patch is not accepted. No it's not. The intension of that keyword was to fish all the patches out of buzilla and resubmit them to wine-patches. Or serve as a base for someone to improve upon. With mixing the two you make it nearly useless as most bugs will have it eventually. Especially all fixed ones. IMHO not even outright hacks should have "patch" keyword set. Yes they give an idea of where the problem is. But they are nothing more then investigation into the cause of the problem. Vitaliy.

2 1

Re: include: Change RPC_STATUS from long to LONG for Win64 compatibility.
by James Hawkins Jan. 4, 2009

Jan. 4, 2009

On Sat, Jan 3, 2009 at 4:49 PM, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > Also fix the compiler warnings introduced by this change. > > diff --git a/dlls/advapi32/crypt.c b/dlls/advapi32/crypt.c > index 5d0b15e..8ef0a5f 100644 > --- a/dlls/advapi32/crypt.c > +++ b/dlls/advapi32/crypt.c > @@ -305,7 +305,7 @@ static void CRYPT_CreateMachineGuid(void) > '%','0','2','x','%','0','2','x', > '%','0','2','x',0 }; > > - pUuidCreate = GetProcAddress(lib, "UuidCreate"); > + pUuidCreate = (void *)GetProcAddress(lib, "UuidCreate"); > rs = pUuidCreate(&uuid); > if (rs == S_OK) > { Inadvertent change? -- James Hawkins

2 1

Re: widl: fix handling of [local] functions without [call_as]
by Rob Shearman Jan. 4, 2009

Jan. 4, 2009

2009/1/3 Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de>: > @@ -548,8 +548,9 @@ static int write_proxy_methods(type_t *iface, int skip) > if (iface->funcs) LIST_FOR_EACH_ENTRY( cur, iface->funcs, const func_t, entry ) { > var_t *def = cur->def; > if (!is_callas(def->attrs)) { > + if (i != cur->idx ) error("widl internal error: method index mismatch"); > if (i) fprintf(proxy, ",\n"); > - if (skip) print_proxy( "0 /* %s_%s_Proxy */", iface->name, get_name(def)); > + if (skip || is_local(def->attrs)) print_proxy( "0 /* %s_%s_Proxy */", iface->name, get_name(def)); > else print_proxy( "%s_%s_Proxy", iface->name, get_name(def)); > i++; > } This will now cause methods with the [local] attribute and with a matching [call_as] method to no longer be included in the function table, which isn't what you want. -- Rob Shearman

2 1

Patch implementing riched20 : EM_PASTESPECIAL -- critique?
by Arren Lex Jan. 4, 2009

Jan. 4, 2009

Hello, all; Attached is a patch that implements the EM_PASTESPECIAL riched20 message, which pastes with a specified clipboard format -- http://msdn.microsoft.com/en-us/library/bb774214(VS.85).aspx Because there is (apparently) no ANSI clipboard implemented, the CF_TEXT clipboard format pastes garbage, so I have put in a workaround which treats a CF_TEXT as a CF_UNICODETEXT call. It prints a fixme when it does this, and when the ANSI clipboard is implemented the "if" block can simply be taken out to start using it. This patch was written to fix bug 14530 -- http://bugs.winehq.org/show_bug.cgi?id=14530 It is made against git commit bf25837eb7c08dc7faf13b886f6aed79a02506b8 (the tagging of 1.1.12) which is the latest at the time of writing. This is my first ever patch, and I am not familiar with wine or riched20 at all, so I would love to have some feedback about it before I submit it to the patches list. Can anyone suggest improvements? Thank you, - Alexander Dorokhine

1 1

Re: Build wine with gcc-4.3 and ssp
by Stefan Reimer Jan. 4, 2009

Jan. 4, 2009

> On Fri, Jan 02, 2009 at 11:14:52PM +0100, Stefan Reimer wrote: >> Hi, >> to build wine using gcc 4.3 with enabled ssp (stack-smashing-protector) the following patch must be applied to loader/preloader.c >> >> see gcc source ./gcc/config/i386/i386.c around line 24391 >> >> /* For 32-bit code we can save PIC register setup by using >> __stack_chk_fail_local hidden function instead of calling >> __stack_chk_fail directly. 64-bit code doesn't need to setup any PIC >> register, so it is better to call __stack_chk_fail directly. */ >> >> Patch: >> >> diff --git a/loader/preloader.c b/loader/preloader.c >> index 5fcb974..1143972 100644 >> --- a/loader/preloader.c >> +++ b/loader/preloader.c >> @@ -163,6 +163,7 @@ void __bb_init_func(void) { return; } >> >> /* similar to the above but for -fstack-protector */ >> void *__stack_chk_guard = 0; >> +void __stack_chk_fail_local(void) { return; } >> void __stack_chk_fail(void) { return; } >> >> /* data for setting up the glibc-style thread-local storage in %gs */ > > Hmm, > > why does this work for me on openSUSE then? > > The line: > gcc -c -I. -I. -I../include -I../include -Wall -pipe > -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -W type-limits -Wpointer-arith -march=i586 -mtune=i686 -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funw > ind-tables -fasynchronous-unwind-tables -g -o preloader.o preloader.c > > works fine here. Are you passing in -fPIC? > > Ciao, marcus > > > Hi, I am using gentoo hardened: gcc (Gentoo Hardened 4.3.2-r7 p1.5, ssp, fortify, pie-10.2.0) 4.3.2 glibc 2.8 Using gcc -v gives: /usr/libexec/gcc/x86_64-pc-linux-gnu/4.3.2/cc1 -quiet -v -I. -I. -I../include -I../include -imultilib 32 preloader.c -D_FORTIFY_SOURCE=2 -fPIE -fstack-protector -fstack-protector-all -fno-strict-overflow -quiet -dumpbase preloader.c -m32 -march=athlon64 -auxbase-strip preloader.o -O2 -Wall -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -version -fno-strict-aliasing -o - | /usr/lib/gcc/x86_64-pc-linux-gnu/4.3.2/../../../../x86_64-pc-linux-gnu/bin/as -V -Qy --32 -o preloader.o - The hardened gcc specs brings in -fPIE, which is similiar to -fPIC. So YES I do ;-) Is this a problem ? Cyas Stefan

2 2

REALLY EXCITING! wine iexplore.exe http://pyjs.org/examples/
by Luke Kenneth Casson Leighton Jan. 4, 2009

Jan. 4, 2009

aww folks - bless you :) if all of these worked, then it means that mshtml is coming along _really_ well! i went through the kitchen sink example, and it passed - everything - with flying colours. the library unit test - passes everything! even the SVG canvas (in the addons) works! i was _just_ about to get _really_ excited, when i ran the JSONRPC example, but awwwww, i got this: fixme:mshtml:nsUploadChannel_SetUploadStream Unsupported aContentType argument: "application/x-www-form-urlencoded" darn, darn :) if that had worked first time, it would have been _unbelievable_ - and _so_ exciting. i liked especially the way that internet explorer is detected as Mozilla-compatible. to support IE's javascript features _would_ perhaps bit a _little_ too much :) but the real purpose of this message is to say WELL XXXXING DONE! l.

2 1

question on how to do language bindings to MSHTML's COM interface
by Luke Kenneth Casson Leighton Jan. 3, 2009

Jan. 3, 2009

folks, hi, i have a rather intriguing issue i'd like to look at, which takes quite a bit of explaining as to why i'd like to go about it - if people are interested i can answer that, but for now i'll leave it at this: how, under linux, would i go about making an application that made _use_ of MSHTML.DLL's functionality, via its COM / DCE/RPC / MSRPC interface? in other words, if you are familiar with gecko / XUL, how would i go about making a gecko / XUL style of application, using MSHTML as the basis, and, once that was achieved, would it stand a chance of successfully running under vanilla windows, using MS's own version of MSHTML? yes i _am_ fully aware that, underneath, according to the wiki page on mshtml's implementation, mshtml underneath uses Gecko - but i don't _want_ to use the Gecko / XUL interface (mostly because it already exists! i don't like challenges that have already been done :) specifically, i'd _really_ like to have python bindings to the COM bindings to MSHTML - all under linux. so there are some _really_ weird esoteric "sub-questions" involved, such as: "what are the chances of porting pywin32 - specifically pywin32's COM bindings - to linux, thanks to widl and friends"? see http://sourceforge.net/projects/pywin32 many thanks for any advice and information. l.

2 4

[PATCH] Compile fix on Linux 2.6.28 / x86
by Pavel Troller Jan. 3, 2009

Jan. 3, 2009

Hi! Due to changes in Linux kernel include file structure, the following patch is necessary to compile wine with the 2.6.28 kernel: --- wine/dlls/ntdll/serial.c.old 2009-01-03 19:31:17.000000000 +0100 +++ wine/dlls/ntdll/serial.c 2009-01-03 20:31:11.000000000 +0100 @@ -74,6 +74,10 @@ #include "wine/debug.h" #ifdef HAVE_LINUX_SERIAL_H +#include <linux/version.h> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,28) +#include <asm/types.h> +#endif #include <linux/serial.h> #endif With regards, Pavel Troller

3 3

Re: Build wine with gcc-4.3 and ssp
by Marcus Meissner Jan. 3, 2009

Jan. 3, 2009

On Fri, Jan 02, 2009 at 11:14:52PM +0100, Stefan Reimer wrote: > Hi, > to build wine using gcc 4.3 with enabled ssp (stack-smashing-protector) > the following patch must be applied to loader/preloader.c > > see gcc source ./gcc/config/i386/i386.c around line 24391 > > /* For 32-bit code we can save PIC register setup by using > __stack_chk_fail_local hidden function instead of calling > __stack_chk_fail directly. 64-bit code doesn't need to setup any PIC > register, so it is better to call __stack_chk_fail directly. */ > > Patch: > > diff --git a/loader/preloader.c b/loader/preloader.c > index 5fcb974..1143972 100644 > --- a/loader/preloader.c > +++ b/loader/preloader.c > @@ -163,6 +163,7 @@ void __bb_init_func(void) { return; } > > /* similar to the above but for -fstack-protector */ > void *__stack_chk_guard = 0; > +void __stack_chk_fail_local(void) { return; } > void __stack_chk_fail(void) { return; } > > /* data for setting up the glibc-style thread-local storage in %gs */ Hmm, why does this work for me on openSUSE then? The line: gcc -c -I. -I. -I../include -I../include -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -W type-limits -Wpointer-arith -march=i586 -mtune=i686 -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funw ind-tables -fasynchronous-unwind-tables -g -o preloader.o preloader.c works fine here. Are you passing in -fPIC? Ciao, marcus

2 2

Re: kernel32: implement CPU detection for OpenBSD
by Rob Shearman Jan. 3, 2009

Jan. 3, 2009

2009/1/3 Austin English <austinenglish(a)gmail.com>: > diff --git a/dlls/kernel32/cpu.c b/dlls/kernel32/cpu.c > index 63ca277..10a8e87 100644 > --- a/dlls/kernel32/cpu.c > +++ b/dlls/kernel32/cpu.c > @@ -544,7 +544,7 @@ VOID WINAPI GetSystemInfo( > } > fclose (f); > } > -#elif defined (__NetBSD__) > +#elif defined (__NetBSD__) || defined(__OpenBSD__) > { > int mib[2]; > int value[2]; Why not just do something like the following: #ifdef __OpenBSD___ size_t value[2]; #else int value[2]; #endif And then you wouldn't have to ifdef each sysctl call. > @@ -557,31 +557,55 @@ VOID WINAPI GetSystemInfo( > #ifdef CPU_FPU_PRESENT > mib[1] = CPU_FPU_PRESENT; > value[1] = sizeof(int); > - if (sysctl(mib, 2, value, value+1, NULL, 0) >= 0) > +#ifdef __OpenBSD__ > + if (sysctl(mib, 2, value, (size_t *)(value+1), NULL, 0) >= 0) { > +#else > + if (sysctl(mib, 2, value, value+1, NULL, 0) >= 0) { > +#endif ... -- Rob Shearman

2 1

App Database Ratings
by Keith Muir Jan. 3, 2009

Jan. 3, 2009

Recently read the thread on the poor quality of the ratings but changing the wording isn't going to have much of an effect. A properly structured questionnaire that then suggests a rating will. The problem with this is the amount of work required to overhaul the database in order to do it. That said the ratings are instead of being objective, which is what wine users and developers want, subjective and nearly useless.

2 1

Fwd: [Wine] Look for a Wine Expert to Possibly hire....
by Austin English Jan. 3, 2009

Jan. 3, 2009

For those of you that don't read wine-users: ---------- Forwarded message ---------- From: BaseHead <wineforum-user(a)winehq.org> Date: Sat, Jan 3, 2009 at 4:18 AM Subject: [Wine] Look for a Wine Expert to Possibly hire.... To: wine-users(a)winehq.org Hey all! We make a Sound FX Database Program called BaseHead for windows. www.baseheadinc.com we would love to make it run on OS X and Linux with Wine. I did already get it up and running via Crossover which I saw is based on WINE which bought me here. It runs pretty chunky using Crossover tho.........8( We are looking to possibly hire someone to make us an all in one BaseHead/Wine Installer that is optimized to run under OS X and Linux that is custom for us. Basically we'd need someone that knows quite a bit about wine to tell us what will works good and what doesn't and if it's even possible. AND if we need to change certain coding to make it run better and what pitfalls to avoid etc.... if anyone one is interested send me an email steve 'AT' baseheadinc 'DOT' com or go to the site and use the contact forum thx!! Steve -- -Austin

1 0

Re: [PATCH 2/3] fusion: Add tests for the IAssemblyEnum interface. [try4]
by Alexandre Julliard Jan. 3, 2009

Jan. 3, 2009

"James Hawkins" <truiken(a)gmail.com> writes: > Now handling different ordering of directory listings. It doesn't work here: ../../../tools/runtest -q -P wine -M fusion.dll -T ../../.. -p fusion_test.exe.so asmenum.c && touch asmenum.ok asmenum.c:445: Test failed: Expected "wine, Version=1.0.1.2, Culture=neutral, PublicKeyToken=123456789abcdef0", got "wine, Version=1.0.1.2, Culture=neutral, PublicKeyToken=16a3fcd171e93a8d" asmenum.c:479: Test failed: Expected "Wine, Version=1.0.1.2, Culture=neutral, PublicKeyToken=16a3fcd171e93a8d", got "Wine, Version=1.0.1.2, Culture=neutral, PublicKeyToken=123456789abcdef0" asmenum.c:492: Test failed: Expected "Wine, Version=1.0.1.2, Culture=neutral, PublicKeyToken=123456789abcdef0", got "Wine, Version=1.0.1.2, Culture=neutral, PublicKeyToken=16a3fcd171e93a8d" asmenum.c:573: Test failed: Expected "wine, Version=1.0.0.0, Culture=neutral, PublicKeyToken=16a3fcd171e93a8d", got "wine, Version=1.0.1.2, Culture=neutral, PublicKeyToken=123456789abcdef0" asmenum.c:586: Test failed: Expected "wine, Version=1.0.1.2, Culture=neutral, PublicKeyToken=123456789abcdef0" or "wine, Version=1.0.1.2, Culture=neutral, PublicKeyToken=16a3fcd171e93a8d", got "wine, Version=1.0.0.0, Culture=neutral, PublicKeyToken=16a3fcd171e93a8d" make: *** [asmenum.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

1 0

libwine.so "incompatible"???
by Luke Kenneth Casson Leighton Jan. 3, 2009

Jan. 3, 2009

rob, anyone - any ideas? gcc -pthread -shared -o libpython2.5.so Modules/_typesmodule.o Modules/getbuildinfo.o Parser/acceler.o Parser/grammar1.o Parser/listnode.o Parser/node.o Parser/parser.o Parser/parsetok.o Parser/bitset.o Parser/metagrammar.o Parser/firstsets.o Parser/grammar.o Parser/pgen.o Parser/myreadline.o Parser/tokenizer.o Objects/abstract.o Objects/boolobject.o Objects/bufferobject.o Objects/cellobject.o Objects/classobject.o Objects/cobject.o Objects/codeobject.o Objects/complexobject.o Objects/descrobject.o Objects/enumobject.o Objects/exceptions.o Objects/genobject.o Objects/fileobject.o Objects/floatobject.o Objects/frameobject.o Objects/funcobject.o Objects/intobject.o Objects/iterobject.o Objects/listobject.o Objects/longobject.o Objects/dictobject.o Objects/methodobject.o Objects/moduleobject.o Objects/object.o Objects/obmalloc.o Objects/rangeobject.o Objects/setobject.o Objects/sliceobject.o Objects/stringobject.o Objects/structseq.o Objects/tupleobject.o Objects/typeobject.o Objects/weakrefobject.o Objects/unicodeobject.o Objects/unicodectype.o Python/Python-ast.o Python/asdl.o Python/ast.o Python/bltinmodule.o Python/ceval.o Python/compile.o Python/codecs.o Python/errors.o Python/frozen.o Python/frozenmain.o Python/future.o Python/getargs.o Python/getcompiler.o Python/getcopyright.o Python/getmtime.o Python/getplatform.o Python/getversion.o Python/graminit.o Python/import.o Python/importdl.o Python/marshal.o Python/modsupport.o Python/mystrtoul.o Python/mysnprintf.o Python/pyarena.o Python/pyfpe.o Python/pystate.o Python/pythonrun.o Python/structmember.o Python/symtable.o Python/sysmodule.o Python/traceback.o Python/getopt.o Python/pystrtod.o Python/dynload_shlib.o Python/thread.o Modules/config.o Modules/getpath.o Modules/main.o Modules/gcmodule.o Modules/threadmodule.o Modules/signalmodule.o Modules/posixmodule.o Modules/errnomodule.o Modules/pwdmodule.o Modules/_sre.o Modules/_codecsmodule.o Modules/zipimport.o Modules/symtablemodule.o Modules/xxsubtype.o -lpthread -ldl -lutil -lwine -lm; \ fi /usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-linux-gnu/4.3.2/../../../../lib/libwine.so when searching for -lwine /usr/bin/ld: skipping incompatible /usr/lib/../lib/libwine.so when searching for -lwine /usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-linux-gnu/4.3.2/../../../libwine.so when searching for -lwine /usr/bin/ld: skipping incompatible /usr/bin/../lib/libwine.so when searching for -lwine /usr/bin/ld: skipping incompatible /usr/lib64/libwine.so when searching for -lwine /usr/bin/ld: skipping incompatible /usr/lib/libwine.so when searching for -lwine /usr/bin/ld: cannot find -lwine collect2: ld returned 1 exit status

1 2

Re: winedbg: add a crash dialog for --auto mode (3rd try)
by Mikołaj Zalewski Jan. 3, 2009

Jan. 3, 2009

Is there something wrong with this patch?

1 0

Re: richedit: Mask window id on WM_COMMAND notifications.
by Dmitry Timoshkov Jan. 3, 2009

Jan. 3, 2009

"Dylan Smith" <dylan.ah.smith(a)gmail.com> wrote: > - SendMessageA(GetParent(hWnd), WM_COMMAND, (nCode<<16)|GetWindowLongW(hWnd, GWLP_ID), (LPARAM)hWnd); > + SendMessageA(GetParent(hWnd), WM_COMMAND, (nCode<<16)|(0xffff & GetWindowLongW(hWnd, GWLP_ID)), (LPARAM)hWnd); MAKEWPARAM and LOWORD are supposed to be used here. Also, have you tested what happens if real window id is larger than a 16-bit value, or just a negative 16-bit one? -- Dmitry.

2 1

Re: start.exe: don't use the NO_UI flag when invoked with /unix
by Austin English Jan. 3, 2009

Jan. 3, 2009

On Fri, Jan 2, 2009 at 6:30 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > This makes it possible to get feedback when something goes wrong starting a non-exe file through a Linux gui. > > > You forgot the patch ;-). -- -Austin

1 0

Re: start.exe: don't use the NO_UI flag when invoked with /unix
by James Hawkins Jan. 3, 2009

Jan. 3, 2009

On Fri, Jan 2, 2009 at 4:30 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > This makes it possible to get feedback when something goes wrong starting a non-exe file through a Linux gui. > Forgot the patch. -- James Hawkins

1 0

Status of dxdiagn?
by Dan Kegel Jan. 3, 2009

Jan. 3, 2009

Hi Markus, what's the status of dxdiagn these days? I see a number of games that say they need a native copy: http://www.google.com/search?q=dxdiagn+site%3Aappdb.winehq.org Do you know what needs doing before we can get native dxdiag working, http://bugs.winehq.org/show_bug.cgi?id=1429 ? Also, how about your dxdiagn conformance test? http://www.winehq.org/pipermail/wine-patches/2008-May/055355.html I know it didn't do much, maybe you could have it check a few required properties? I ask because I'm looking around for a student project, and implementing dxdiag.exe came to mind; looking around a bit, I saw dxdiagn, and figured it might be nice to tie up some loose ends there, too. - Dan

2 6

Re: [PATCH] oleaut32: PICTYPE_ICON returns EFAIL for get_hPal (try 2)
by Robert Reif Jan. 3, 2009

Jan. 3, 2009

Jon Griffiths wrote: > Hi, > > Smaller patch with properly static-ified icon data. > > Cheers > Jon > > > > ------------------------------------------------------------------------ > > Did this patch get dropped for a reason?

1 0

Re: [shell32 5/6] include: Add remotable stubs for non-default-marshallable shobjidl calls.
by Rob Shearman Jan. 2, 2009

Jan. 2, 2009

2009/1/1 Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de>: > diff --git a/include/shobjidl.idl b/include/shobjidl.idl > index a647798..c36f4ce 100644 > --- a/include/shobjidl.idl > +++ b/include/shobjidl.idl > @@ -452,6 +452,9 @@ interface IShellView : IOleWindow > [in] LPFNSVADDPROPSHEETPAGE pfn, > [in] LPARAM lparam); > > + [call_as(AddPropertySheetPages)] > + HRESULT RemoteAddPropertySheetPages(); > + > HRESULT SaveViewState(); > HRESULT SelectItem( > [in] LPCITEMIDLIST pidlItem, > @@ -582,6 +585,9 @@ cpp_quote("#endif") > [in] LPARAM lParam, > [in] LRESULT *pret); > > + [call_as(SendControlMsg)] > + HRESULT RemoteSendControlMsg(); > + > HRESULT QueryActiveShellView( [out] IShellView **ppshv ); > HRESULT OnViewWindowActive( [in] IShellView *pshv ); > > @@ -590,6 +596,8 @@ cpp_quote("#endif") > [in] LPTBBUTTONSB lpButtons, > [in] UINT nButtons, > [in] UINT uFlags); > + [call_as(SetToolbarItems)] > + HRESULT RemoteSetToolbarItems(); These shouldn't be necessary. What is it that you're trying to fix? > } > > > @@ -1441,9 +1449,12 @@ interface IAutoCompleteDropDown : IUnknown > { > cpp_quote("#define ACDD_VISIBLE 0x0001") > > - HRESULT GetDropDownStatus( > + [local] HRESULT GetDropDownStatus( > [out] DWORD *pdwFlags, > - [out, string] LPWSTR *ppwszString); > + [out] LPWSTR *ppwszString); > + > + [call_as(GetDropDownStatus)] > + HRESULT RemoteGetDropDownStatus(); This isn't correct. IAutoCompleteDropDown::GetDropDownStatus should be remoted as is. > > HRESULT ResetEnumerator(); > } -- Rob Shearman

2 4

Re: Implemented retrieval of szDeviceIdentifier property in dxdiagn
by Vitaliy Margolen Jan. 2, 2009

Jan. 2, 2009

Markus wrote: Few problems with your patch: > + IDirect3D9 *(WINAPI *pDirect3DCreate9)(UINT) = NULL; > + IDirect3D9 *pD3d = NULL; No need to initialize something you'll assign to anyway. > + d3d9_handle = LoadLibraryA( "d3d9.dll" ); You need to unload it when you done. > + memset(&adapter_ident, 0, sizeof(adapter_ident)); No need to clear this structure. > + StringFromGUID2(&adapter_ident.DeviceIdentifier, adapter_ident_str, 39); Why don't you put it directly into szIdentifierBuffer? > + memcpy( szIdentifierBuffer, adapter_ident_str, sizeof(adapter_ident_str) * sizeof(WCHAR) ); sizeof() gives size in bytes. You don't need to multiply it by sizeof(WCHAR). > + WCHAR deviceIdentBuffer[256]; First why 256 if all you need is 39? Second, why do you need it at all? There is already "buffer" which is big enough. > + DXDiag_GetDisplayDeviceIdentifier( &deviceIdentBuffer ); You don't need to take a reference from array. It's already a pointer (remove "&"). Any time you pass array like that you should also pass it's size. Vitaliy.

1 0

Re: [4/5] wined3d: Convert some BOOLs to bitfields in struct IWineD3DDeviceImpl.
by Rob Shearman Jan. 2, 2009

Jan. 2, 2009

2008/12/30 Henri Verbeet <hverbeet(a)codeweavers.com>: > > > From f6e4f88407491db8bb53d22d526f69b9ff761aaf Mon Sep 17 00:00:00 2001 > From: Henri Verbeet <hverbeet(a)codeweavers.com> > Date: Tue, 30 Dec 2008 14:56:49 +0100 > Subject: wined3d: Convert some BOOLs to bitfields in struct > IWineD3DDeviceImpl. > > Also fills a 3 byte hole. > --- > dlls/wined3d/device.c | 17 +++++---------- > dlls/wined3d/nvidia_texture_shader.c | 2 +- > dlls/wined3d/state.c | 4 +- > dlls/wined3d/wined3d_private.h | 36 > ++++++++++++++++----------------- > 4 files changed, 26 insertions(+), 33 deletions(-) How many instances of this structure are likely to be in a process at any one time? It seems to me as though as any memory savings gained by making the BOOLs into bitfields will be taken up by increased code size. There is also the risk that there will be a small performance penalty for this and the other similar changes too. These kinds of optimisations need to be backed up by benchmarks, for both memory and performance. -- Rob Shearman

2 1

Ubuntu popcon trivia
by Dan Kegel Jan. 2, 2009

Jan. 2, 2009

Did you know that almost as many people have Wine installed as have Sun's Java 6 installed? wget http://popcon.ubuntu.com/by_inst.gz gunzip by_inst.gz awk '/wine |sun-java6-jre/' by_inst | head rank name inst vote old recent old-files 1208 sun-java6-jre 390519 68179 313376 7354 1610 (Matthias Klose) 1321 wine 338377 42513 282338 13460 66 (Scott Ritchie) The highest 'inst' value in the file is 871814, so it looks like about 39% of machines subscribed to popcon have wine installed.

2 1

Re: widl: print error on [out, string] without size_is
by Michael Karcher Jan. 1, 2009

Jan. 1, 2009

Am Donnerstag, den 01.01.2009, 11:22 +0100 schrieb Michael Karcher: > The old behaviour was to emit a half-complete C statement without > any error message. This patch is bad. Please ignore. Regards, Michael Karcher

1 0

Re: ole32: Add HICON user marshalling stubs
by Rob Shearman Jan. 1, 2009

Jan. 1, 2009

2009/1/1 Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de>: > diff --git a/dlls/ole32/ole32.spec b/dlls/ole32/ole32.spec > index 79376ac..f7db2b0 100644 > --- a/dlls/ole32/ole32.spec > +++ b/dlls/ole32/ole32.spec > @@ -122,6 +122,10 @@ > @ stdcall HBITMAP_UserMarshal(ptr ptr ptr) > @ stdcall HBITMAP_UserSize(ptr long ptr) > @ stdcall HBITMAP_UserUnmarshal(ptr ptr ptr) > +@ stdcall HICON_UserFree(ptr ptr) > +@ stdcall HICON_UserMarshal(ptr ptr ptr) > +@ stdcall HICON_UserSize(ptr long ptr) > +@ stdcall HICON_UserUnmarshal(ptr ptr ptr) > @ stub HBRUSH_UserFree > @ stub HBRUSH_UserMarshal > @ stub HBRUSH_UserSize The functions should be added in the correct place so that the list of functions remains sorted. -- Rob Shearman

1 0

Re: [oleaut 1/3] include: add [unique] attributes to IPropertyBag::RemoteRead args
by Rob Shearman Jan. 1, 2009

Jan. 1, 2009

2009/1/1 Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de>: > diff --git a/include/oaidl.idl b/include/oaidl.idl > index 1cc166a..4ee3b43 100644 > --- a/include/oaidl.idl > +++ b/include/oaidl.idl > @@ -1620,9 +1620,9 @@ interface IPropertyBag : IUnknown > HRESULT RemoteRead( > [in] LPCOLESTR pszPropName, > [out] VARIANT *pVar, > - [in] IErrorLog *pErrorLog, > + [in, unique] IErrorLog *pErrorLog, > [in] DWORD varType, > - [in] IUnknown *pUnkObj); > + [in, unique] IUnknown *pUnkObj); In the PSDK only pErrorLog is a unique pointer. However, I believe you are making this change to avoid getting RPC_X_NULL_REF_POINTER exceptions when a NULL pErrorLog parameter is passed into IPropertyBag_Read, but MIDL ignores the pointer type for interface pointers and never outputs a NULL reference pointer check for them. So widl just needs to be fixed. > > HRESULT Write( > [in] LPCOLESTR pszPropName, -- Rob Shearman

2 2

Re: [oleaut 3/3] oleaut32: Implement IPropertyBag::Read proxying
by Rob Shearman Jan. 1, 2009

Jan. 1, 2009

2009/1/1 Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de>: > + hr = IPropertyBag_RemoteRead_Proxy(This, pszPropName, &outVariant, pErrorLog, > + V_VT(pVar), pUnk); > + if(SUCCEEDED(hr)) > + hr = VariantCopy(pVar, &outVariant); > + > + return hr; You're leaking the memory in outVariant here, since VariantCopy does a deep copy of all of the data. Is there a reason you don't just pass pVar into IPropertyBag_RemoteRead_Proxy? -- Rob Shearman

2 2

Re: [oleaut 2/3] include: Add [unique] attribute to IPersistPropertyBag::Load arg
by Rob Shearman Jan. 1, 2009

Jan. 1, 2009

2009/1/1 Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de>: > diff --git a/include/ocidl.idl b/include/ocidl.idl > index c40d155..d4979d7 100644 > --- a/include/ocidl.idl > +++ b/include/ocidl.idl > @@ -927,7 +927,7 @@ interface IPersistPropertyBag : IPersist > > HRESULT Load( > [in] IPropertyBag *pPropBag, > - [in] IErrorLog *pErrorLog); > + [in,unique] IErrorLog *pErrorLog); > > HRESULT Save( > [in] IPropertyBag *pPropBag, Same goes for this change. -- Rob Shearman

1 0

Drumming up qa publicity for sketchup on wine via Digg
by Dan Kegel Jan. 1, 2009

Jan. 1, 2009

Sketchup seems to be working pretty well, so I just posted http://digg.com/linux_unix/Google_Sketchup_7_working_in_Wine_1_1_11 to see if I could attract some real sketchup users to find more bugs. If folks agree that's a good idea, they can support it by digging it so it can show up on the front page. Thanks, Dan

2 2

Contribution to the Toolbar common control
by Alan Feldman Jan. 1, 2009

Jan. 1, 2009

Hello Wine developers, I am writing to this forum because I wanted to contribute some useful development information to your community while at the same time not have to get too involved as I currently have no plans to stay involved going forward. I wanted to say that I am *really* impressed with the codebase that you guys have developed! I stumbled across the Winehq site as I was looking for more information on Microsoft's Toolbar common control. The source code you guys have has made understanding the internals of the Toolbar control really easy and I really appreciate the work you guys have done. (I even took a peek at Microsoft's comctl32.dll disassembly to confirm a couple of the things you guys wrote and it checked out) ;-) So, anyway, in gratitude for what you guys have provided me I wanted to "give something back". I noticed that there are several Toolbar window messages which are listed as "unknown" which at the time of the writing of this e-mail are now definitely "known" and I would like to provide that information to someone to check in to your source code base. Here is my contribution: http://source.winehq.org/source/dlls/comctl32/toolbar.c Function: ToolbarWindowProc() TB_UNKWN45E is really TB_SETHOTITEM2 (WM_USER + 94) TB_UNKWN460 is really TB_SETLISTGAP (WM_USER + 96) TB_UNKWN462 is really TB_GETIMAGELISTCOUNT (WM_USER + 98) TB_UNKWN463 is really TB_GETIDEALSIZE (WM_USER + 99) TB_UNKWN467 (which is not in the Wine source yet) is really TB_GETITEMDROPDOWNRECT (WM_USER + 103) Those Toolbar window messages are currently not in the public Windows headers at this time but they have been *documented* on the MSDN Library web site now. Here are links to the MSDN Library help topics giving evidence to what I wrote up above: http://msdn.microsoft.com/en-us/library/cc835036(VS.85).aspx http://msdn.microsoft.com/en-us/library/bb787441(VS.85).aspx http://msdn.microsoft.com/en-us/library/cc835034(VS.85).aspx http://msdn.microsoft.com/en-us/library/cc835033(VS.85).aspx http://msdn.microsoft.com/en-us/library/cc835035(VS.85).aspx Also, in this source file: http://source.winehq.org/source/include/commctrl.h Someone took a REALLY good guess at the name of a Toolbar notification! TBN_WRAPHOTITEM is definitely the name of notification TBN_FIRST- 24. Good guess! I would say that the comment about this message being undocumented and just a "guess" can now be removed. Even though this message is also not in any public header file, this message is now *documented* and the documentation can be found here: http://msdn.microsoft.com/en-us/library/cc835032(VS.85).aspx Cheers! :-) Alan Feldman

3 5

Commit stats
by Hans Leidekker Jan. 1, 2009

Jan. 1, 2009

$ for year in {2002..2008}; do \ count=$( git log | grep ^Date: | grep $year | wc -l ); \ echo "Number of commits in $year: $count"; \ done Number of commits in 2002: 3094 Number of commits in 2003: 3283 Number of commits in 2004: 3851 Number of commits in 2005: 6006 Number of commits in 2006: 8431 Number of commits in 2007: 9532 Number of commits in 2008: 11292 -Hans

3 2

Shell32 proxies/stubs
by Michael Karcher Jan. 1, 2009

Jan. 1, 2009

Hello developers, this is just to let you know where the 3 standalone patches and three patch series I just posted to wine-devel are going: Having proxies for the COM objects of shell32.dll in actxprxy.dll, just as Windows XP and Vista does. It started with me wanting a guinea pig object that is apartment threaded and has proxies/stubs and present on every Windows installation to test a strange corner case in ole32. Looking around in my XP, I decided to use the MyComputer object that is already used in the ole32 testcase. Then I found out that Windows has them, but Wine misses them and thought to myself: Hey, this is just COM, adding a proxy should be just adding some lines to Makefile.in and widl does the rest. It turned out to be a quite fun project that revealed problems and/or missing features at nearly every component involved. The things I sent up to now fix most of the things below the proxies. What is still unsent is a three-patch-series to actxprxy to really add the proxies, and testcases for the remoting. While the shelllink testcase passes on my system even with remote calls, the shlfolder testsuite does not work correctly yet, revealing even more issues with ole32/widl I'm currently attacking. Regards, Michael Karcher

1 0