January 2009 - Wine-Devel - list.winehq.org

Re: kernel32: implement CPU detection for OpenBSD
by Francois Gouget Jan. 9, 2009

Jan. 9, 2009

On Fri, 2 Jan 2009, Austin English wrote: @@ -544,7 +544,7 @@ VOID WINAPI GetSystemInfo( } fclose (f); } -#elif defined (__NetBSD__) +#elif defined (__NetBSD__) || defined(__OpenBSD__) { int mib[2]; int value[2]; @@ -557,31 +557,55 @@ VOID WINAPI GetSystemInfo( #ifdef CPU_FPU_PRESENT mib[1] = CPU_FPU_PRESENT; value[1] = sizeof(int); - if (sysctl(mib, 2, value, value+1, NULL, 0) >= 0) +#ifdef __OpenBSD__ + if (sysctl(mib, 2, value, (size_t *)(value+1), NULL, 0) >= 0) { +#else + if (sysctl(mib, 2, value, value+1, NULL, 0) >= 0) { +#endif This was wrong to start with because even if size_t is 8 bytes, value+1 will only have space for 4. Plus the code tests whether value changed instead of testing *value! I'm sending a patch to fix that. Then you can resend your patch adding just the defined(__OpenBSD__). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A polar bear is a cartesian bear after a coordinate transform.

1 0

Re: [shell32/tests 6/6] Skip a test on Vista
by Reece Dunn Jan. 8, 2009

Jan. 8, 2009

2009/1/8 Paul Vriens <paul.vriens.wine(a)gmail.com>: > Hi, > > With this last patch all shlfileop tests succeed on all my boxes (Win95, > Win98, > NT4, W2K, W2K3 and Vista). > > Changelog > Skip a test on Vista +static BOOL on_vista = FALSE; + I don't see where this is used. Kudos for fixing the shell32:shfileop tests. - Reece

1 0

Re: setupapi/tests: Remove an unneeded cast.
by Hans Leidekker Jan. 8, 2009

Jan. 8, 2009

On Thursday 08 January 2009 00:05:01 Francois Gouget wrote: > memset(buffer, 0x55, sizeof(buffer)); > - retval = pStringTableLookUpStringEx(table, uilevel, ST_CASE_SENSITIVE_COMPARE, buffer, (LPDWORD)0); > + retval = pStringTableLookUpStringEx(table, uilevel, ST_CASE_SENSITIVE_COMPARE, buffer, NULL); > ok(retval != ~0u, "failed find 'UILEVEL' in string table\n"); > ok(memcmp(buffer, &data, 4), "unexpected data\n"); This test is there to show that the prototype of StringTableLookUpStringEx is broken; the last parameter is treated as an integer instead of a pointer and this notation serves to document that fact. But I can see how this will repeatedly trigger janitorial scripts, so I do not object to this patch going in. -Hans

6 7

Dates in Wine announcement
by Ian Macfarlane Jan. 8, 2009

Jan. 8, 2009

Very small suggestion - it would be helpful to have dates included somewhere (preferably near the top) of the wine announce pages, for example: http://www.winehq.org/announce/1.1.12 This will let people who come to it via search engines know what date this particular release was made on, without having to dig around. (it will also help prevent people mistaking an old development release for a new one - I'm sure most people have seen at least one news story about something where the reporter/blogger is reporting years-old news as new because they didn't look at the dates on the article, or there were no dates or they were a hard to spot grey colour). Just a small suggestion. Ian

4 3

WIDL and Windows rpcrt4
by Ge van Geldorp Jan. 8, 2009

Jan. 8, 2009

Hi Rob, Is WIDL supposed to generate code that's compatible with Windows RPCRT4.DLL? Because it appears this is currently not the case. When you look at http://test.winehq.org you'll see that the rpcrt4:server test fails on pretty much any Windows version. I investigated a bit more, the failures are caused by an exception 0x6e6 ("An internal error occurred in a remote procedure call (RPC)" thrown from NdrPointerBufferSize() in server_c.c function get_name(). The mingw-crosscompiled executable doesn't handle that exception which causes the process to crash. Since this is in WIDL-generated code, I decided to take a look at what MIDL generates for the same IDL file. It turns out that MIDL treats the name_t struct as a simple structure, while WIDL treats it as a complex structure. That made comparison a bit difficult. Since WIDL never seems to generate simple structures, I tried to convince MIDL to generate a complex structure too. After a bit of fiddling around (I'm no IDL expert...) I came up with the following type, a mix of name_t and sun_t: typedef struct { [string, size_is(size)] char *name; unsigned int size; [switch_is(s)] union { [case(SUN_I)] int i; [case(SUN_F1, SUN_F2)] float f; [case(SUN_PI)] int *pi; } u; int s; } complex_t; After staring at the WIDL-generated and MIDL-generated code for a while (which still differed quite a bit), I noticed something interesting: in the type format string, "unsigned int size" gets encoded as FC_ULONG by WIDL, but as FC_LONG by MIDL. I then went back to the server_c.c and server_s.c files generated by WIDL for the tests and changed the type format strings there (replaced the "unsigned int size" encoding from FC_ULONG by FC_LONG). With this change, the get_name() test passes :-). It then crashes later on with an access violation inside NdrVaryingArrayUnmarshall() in get_5numbers(), but let's take the problems one at a time... So it appears Windows RPCRT4.dll is not happy with FC_ULONG entries within a complex structure. I added a bunch of other primitive types to my complex_t structure to see how they are treated by MIDL. See attached complex.idl file and the MIDL-generated midl_complex_c.c file (also attached WIDL-generated widl_complex_c.c for completeness). It appears that MIDL simply drops the "unsigned" from any base type, at least within complex structures. "unsigned long" gets encoded as FC_LONG, "unsigned short" as FC_SHORT and "unsigned small" as FC_SMALL. Like I said, I'm no IDL expert. Does the stuff above make sense to you? Do you think it would be a good idea to change WIDL to generate the same encodings as MIDL? Thanks, Gé.

3 3

D3D shaders
by Anton Romanov Jan. 8, 2009

Jan. 8, 2009

Hi. First, sorry for maybe somewhat newbish questions/approach... but anyway. Do i understand correctly that wined3d implementation takes d3d shaders' bytecode and converts it to other format depending on hardware? What is the state of wine's d3d shaders' implementation? I'm asking because I've recently came across a MojoShader (http://icculus.org/mojoshader/) project which is a library (zlib licensed) to convert compiled Direct3D shaders from bytecode to some other format (several profiles). The library seems to work well - it is used for OpenGL renderer in Unreal Tournament 3 engine. So i wonder - can there be some benefit to wine from such a project? Thanks.

2 1

Implementing b3DAccelerationExists and b3DAccelerationEnabled in dxdiagn
by Markus Jan. 8, 2009

Jan. 8, 2009

Hello, can anyone tell me where to find information about the b3DAccelerationExists and b3DAccelerationEnabled properties in the display container returned by dxdiagn.dll and when they are supposed to be false or true? In fact, MSDN does not seem to provide information about any of the properties returned by that dll. Thanks, -- Markus

3 5

Proof the new site design is superior!
by Dan Kegel Jan. 8, 2009

Jan. 8, 2009

The new site design is already paying dividends. Look: http://www.zmogo.com/gear/the-new-year-linux-resolution-day-5/ says: "... I chose Wine mainly because its site is more appealing looking than VMware's, which has all the sleek design features and well-considered organization of an expired domain name..." :-)

2 1

Re: mshtml: Implement IHTMLStyle get/set Attribute
by Alistair Leslie-Hughes Jan. 8, 2009

Jan. 8, 2009

Hi, Is there anything wrong with this patch? Best Regards Alistair Leslie-Hughes > From dca7b396838e3367ad78144ccb07aed24cd5917f Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Mon, 5 Jan 2009 21:22:35 +1100 > Subject: [PATCH] Implement IHTMLStyle get/set Attribute > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/mshtml/htmlstyle.c | 69 > ++++++++++++++++++++++++++++++++++++++++++---- > dlls/mshtml/tests/dom.c | 36 ++++++++++++++++++++++++ > 2 files changed, 99 insertions(+), 6 deletions(-) > > diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c > index fa4ad51..3453f7b 100644 > --- a/dlls/mshtml/htmlstyle.c > +++ b/dlls/mshtml/htmlstyle.c > @@ -2048,18 +2048,75 @@ static HRESULT WINAPI > HTMLStyle_setAttribute(IHTMLStyle *iface, BSTR strAttribut > VARIANT AttributeValue, LONG lFlags) > { > HTMLStyle *This = HTMLSTYLE_THIS(iface); > - FIXME("(%p)->(%s v%d %08x)\n", This, debugstr_w(strAttributeName), > - V_VT(&AttributeValue), lFlags); > - return E_NOTIMPL; > + HRESULT hres; > + DISPID dispid; > + > + TRACE("(%p)->(%s v%d %08x)\n", This, debugstr_w(strAttributeName), > + V_VT(&AttributeValue), lFlags); > + > + if(!strAttributeName) > + return E_INVALIDARG; > + > + if(lFlags == 1) > + FIXME("Parameter lFlags ignored\n"); > + > + hres = HTMLStyle_GetIDsOfNames(iface, &IID_NULL, > (LPOLESTR*)&strAttributeName, 1, > + LOCALE_USER_DEFAULT, &dispid); > + if(hres == S_OK) > + { > + VARIANT ret; > + DISPID dispidNamed = DISPID_PROPERTYPUT; > + DISPPARAMS params; > + > + params.cArgs = 1; > + params.rgvarg = &AttributeValue; > + params.cNamedArgs = 1; > + params.rgdispidNamedArgs = &dispidNamed; > + > + hres = HTMLStyle_Invoke(iface, dispid, &IID_NULL, > LOCALE_SYSTEM_DEFAULT, > + DISPATCH_PROPERTYPUT, &params, &ret, NULL, NULL); > + } > + else > + { > + FIXME("Custom attributes not supported.\n"); > + } > + > + TRACE("ret: %08x\n", hres); > + > + return hres; > } > > static HRESULT WINAPI HTMLStyle_getAttribute(IHTMLStyle *iface, BSTR > strAttributeName, > LONG lFlags, VARIANT *AttributeValue) > { > HTMLStyle *This = HTMLSTYLE_THIS(iface); > - FIXME("(%p)->(%s %08x %p)\n", This, debugstr_w(strAttributeName), > - lFlags, AttributeValue); > - return E_NOTIMPL; > + HRESULT hres; > + DISPID dispid; > + > + TRACE("(%p)->(%s v%p %08x)\n", This, debugstr_w(strAttributeName), > + AttributeValue, lFlags); > + > + if(!AttributeValue || !strAttributeName) > + return E_INVALIDARG; > + > + if(lFlags == 1) > + FIXME("Parameter lFlags ignored\n"); > + > + hres = HTMLStyle_GetIDsOfNames(iface, &IID_NULL, > (LPOLESTR*)&strAttributeName, 1, > + LOCALE_USER_DEFAULT, &dispid); > + if(hres == S_OK) > + { > + DISPPARAMS params = {NULL, NULL, 0, 0 }; > + > + hres = HTMLStyle_Invoke(iface, dispid, &IID_NULL, > LOCALE_SYSTEM_DEFAULT, > + DISPATCH_PROPERTYGET, &params, AttributeValue, NULL, NULL); > + } > + else > + { > + FIXME("Custom attributes not supported.\n"); > + } > + > + return hres; > } > > static HRESULT WINAPI HTMLStyle_removeAttribute(IHTMLStyle *iface, BSTR > strAttributeName, > diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c > index de363bb..516aa3e 100644 > --- a/dlls/mshtml/tests/dom.c > +++ b/dlls/mshtml/tests/dom.c > @@ -2745,6 +2745,42 @@ static void test_default_style(IHTMLStyle *style) > ok(hres == S_OK, "put_overflow failed: %08x\n", hres); > SysFreeString(sOverflowDefault); > > + /* Attribute Tests*/ > + hres = IHTMLStyle_getAttribute(style, NULL, 1, &v); > + ok(hres == E_INVALIDARG, "getAttribute failed: %08x\n", hres); > + > + str = a2bstr("position"); > + hres = IHTMLStyle_getAttribute(style, str, 1, NULL); > + ok(hres == E_INVALIDARG, "getAttribute failed: %08x\n", hres); > + > + hres = IHTMLStyle_getAttribute(style, str, 1, &v); > + ok(hres == S_OK, "getAttribute failed: %08x\n", hres); > + ok(V_VT(&v) == VT_BSTR, "type failed: %d\n", V_VT(&v)); > + VariantClear(&v); > + > + hres = IHTMLStyle_setAttribute(style, NULL, v, 1); > + ok(hres == E_INVALIDARG, "getAttribute failed: %08x\n", hres); > + > + V_VT(&v) = VT_BSTR; > + V_BSTR(&v) = a2bstr("absolute"); > + hres = IHTMLStyle_setAttribute(style, str, v, 1); > + ok(hres == S_OK, "setAttribute failed: %08x\n", hres); > + VariantClear(&v); > + > + hres = IHTMLStyle_getAttribute(style, str, 1, &v); > + ok(hres == S_OK, "getAttribute failed: %08x\n", hres); > + ok(V_VT(&v) == VT_BSTR, "type failed: %d\n", V_VT(&v)); > + ok(!strcmp_wa(V_BSTR(&v), "absolute"), "str=%s\n", > dbgstr_w(V_BSTR(&v))); > + VariantClear(&v); > + > + V_VT(&v) = VT_BSTR; > + V_BSTR(&v) = NULL; > + hres = IHTMLStyle_setAttribute(style, str, v, 1); > + ok(hres == S_OK, "setAttribute failed: %08x\n", hres); > + VariantClear(&v); > + > + SysFreeString(str); > + > hres = IHTMLStyle_QueryInterface(style, &IID_IHTMLStyle2, > (void**)&style2); > ok(hres == S_OK, "Could not get IHTMLStyle2 iface: %08x\n", hres); > if(SUCCEEDED(hres)) { > -- > 1.5.4.3 > > -------------------------------------------------------------------------------- > >

1 0

Unused function in quartz
by Francois Gouget Jan. 7, 2009

Jan. 7, 2009

Hi, In the following commit you added the OutputPin_DeliverNewSegment() function to pin.c. However today it is unused. Is there any plan to use it? Is it still relevant? commit 0a6f11c88a8da49d80e4e7d8a0236ae4b36926b7 Author: Robert Shearman <R.J.Shearman(a)warwick.ac.uk> Date: Thu Sep 25 23:50:06 2003 +0000 - A few cosmetic fixes. - Various bug fixes. - Add some OutputPin helpers. - Add a new type of pin, PullPin. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ In a world without fences who needs Gates?

3 2