November 2009 - Wine-Devel - list.winehq.org

Infinite loop with translation DLL
by Uwe Bonnes Nov. 10, 2009

Nov. 10, 2009

Hello, around July 2009, I implemented a translation dll, allowing to run Win32 programms using ftd2xx.dll with Wine translating the calls to linux-libftd2xx. It was done while looking at dll/glu32. I was able to run mprog.exe (www.ftdichip.org) some time ago. Reapplying now, I hit an infinite loop with the first translated call. I short, ftd2xx.spec contains: @ stdcall FT_ListDevices(ptr ptr long) FTD2XX_FT_ListDevices and ftd2xx_main.c: extern FT_STATUS FT_ListDevices(PVOID, PVOID, DWORD); FT_STATUS WINAPI FTD2XX_FT_ListDevices( PVOID pArg1, PVOID pArg2, DWORD Flags ) { FT_STATUS res = FT_ListDevices(pArg1, pArg2, Flags); TRACE("res %s\n", res2string(res)); return res; } and dlls/ftd2xx/Makefile.in contains: EXTRALIBS = @FTD2XXLIBS@ with EXTRALIBS detected in configure.ac. MProig.exe calls FT_ListDevices(), which is resolves as FTD2XX_FT_ListDevices(). Then FTD2XX_FT_ListDevices() is entered and FT_ListDevices() resolves again to FTD2XX_FT_ListDevices(), resulting in an infinite loop. Can anybody help with the flaw in my implementation? Or did anything change in wine? The patches still linger on the mailing-list as "Stub implementation for ftd2xx.dll" Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 3

Re: [PATCH] server, ntoskrnl: Implement support for IRP_MJ_CREATE requests.
by Vitaliy Margolen Nov. 10, 2009

Nov. 10, 2009

Charles Davis wrote: > Also, add stub handlers in mountmgr. > > This patch fixes an issue with the previous one where wine would hang if > ntoskrnl got a STATUS_BUFFER_OVERFLOW back from thes server. > --- > +int suspend_thread( struct thread *thread ); > +int resume_thread( struct thread *thread ); > +static void complete_open( struct open_call *open, unsigned int status ) > +{ ... > + resume_thread( open->call.thread ); > This static struct object *device_open_file( struct object *obj, unsigned int access, > unsigned int sharing, unsigned int options ) > { ... > + suspend_thread( current ); Looks like a hack to me. You shouldn't be suspending/resuming threads directly like this. They should block on open operation. Vitaliy.

2 1

Re: mciwave: Rework MCI notification system.
by Paul Vriens Nov. 10, 2009

Nov. 10, 2009

On 11/10/2009 12:56 PM, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Hi, > > same patch as yesterday, with more spaces and volatile and mciSave fix thrown out. > > I was about to resend > [PATCH 2] winmm: MCI Close all causes one notification per open driver. > which I rebased as well when I realised that it's independent on the code here > (but should logically follow the present patch as #2). So I'm not resending that anew. > Please include it as well. > > Likewise, yesterday's > PATCH mciwave: Stop must not reset current position. > is completely independent on the notification stuff, so I'm not resubmitting it, > even though I sent it in third position. > > Well, I'll wait and see what feedback I get and what appears in git. > > Regards, > Jörg Höhle > Hi Jörg, Please resend all patches you want to have committed in a series with the proper numbering. If they can be applied independently then numbering is (strictly speeking) not needed but it does show where you're going. I'm not sure if it's only me but I have a hard time keeping tracking of all the patches you sent and what (or not) to apply in what order. -- Cheers, Paul.

1 0

Cpp Check Nov. 7th
by chris ahrendt Nov. 10, 2009

Nov. 10, 2009

Well its been a few since I ran CPP Check and so I ran it today and got the following: New CPP Check Errors for the Wine Code: [/home/cahrendt/wine-git/dlls/comctl32/imagelist.c:1908]: (error) Uninitialized variable: bmi_buf [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/shell32/shellord.c:416]: (error) Uninitialized variable: szText [/home/cahrendt/wine-git/dlls/shell32/shellord.c:416]: (error) Uninitialized variable: szTitle [/home/cahrendt/wine-git/dlls/shell32/shellpath.c:1360]: (error) Uninitialized variable: InfoBuffer [/home/cahrendt/wine-git/dlls/winex11.drv/xfont.c:2963]: (possible error) Resource leak: fd [/home/cahrendt/wine-git/server/mapping.c:118]: (error) Uninitialized variable: page_size Chris

2 1

Re: [PATCH 4] mciwave: Rework MCI notification system.
by Vitaliy Margolen Nov. 9, 2009

Nov. 9, 2009

Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Hi, > > + * Notifications in MCI work like a 1-element queue. > + * Each new notification request supersedes the previous one. > + volatile HANDLE hCallback; /* Callback handle for pending notification */ You do not need volatile here as AJ already explained. > + HANDLE old = InterlockedExchangePointer(&wmw->hCallback, NULL); > + if (old) mciDriverNotify(old,wDevID,MCI_NOTIFY_SUPERSEDED); > + mciDriverNotify(HWND_32(LOWORD(hWndCallBack)),wDevID,wStatus); Here and everywhere else in your patches, please add space before commas. > + if (wmw->hFile == 0)<----->return MCIERR_INTERNAL; /* FIXME: Save must work even after Open new. */ > . > - if (dwFlags & MCI_WAIT) > - { > - <->FIXME("MCI_WAIT not implemented\n"); > - } > - WAVE_mciStop(wDevID, 0, NULL); > + WAVE_mciStop(wDevID, MCI_WAIT, NULL); This looks like an unrelated change. Vitaliy.

1 1

Re: ntdll: fix memory leak in GetDiskFreeSpaceW
by Vitaliy Margolen Nov. 9, 2009

Nov. 9, 2009

Dan Kegel wrote: > Found while valgrinding chromium's app_unittests. > > + done: > + RtlFreeHeap(GetProcessHeap(), 0, val.Buffer); > + You should us RtlFreeUnicodeString( &val ); instead. Vitaliy.

1 0

re: Question on using winedbg when program does not crash, just becomes unresponsive
by Dan Kegel Nov. 9, 2009

Nov. 9, 2009

Susan asked: > [What can you do to get a backtrace of a hung app that won't hang when you run it in winedbg?] I ran into this last week and added a note to http://wiki.winehq.org/Backtraces "Alternately, instad of info process / attach, you can do 'bt all' to get backtraces of all threads in all running processes. This is handy when debugging hangs." That's not a very clear explanation, but what it means is: start winedbg without any app say 'bt all' in winedbg Voila, you now have backtraces for every process, including the hung one. It's your job to get that into a text file and remove the uninteresting ones...

3 3

The user32/win test crashes X on Intel cards
by Joerg-Cyril.Hoehle＠t-systems.com Nov. 9, 2009

Nov. 9, 2009

Hi, >Marcus got the same issue and he had an Intel card too Charles Davis wrote: >This happens on Mac OS X, too. Check out >http://xquartz.macosforge.org/trac/ticket/293 Charles forgot to mention that it affects NVidia on the Mac, which I did not explicitly write in the above bug report (the Mac people will have guessed it from the "early 2009 Mac mini" comment). More precisely SetWindowPos(hwnd, 0, -32769, -40000, -32769, -90000, SWP_NOMOVE); #if 0 SetWindowPos(hwnd, 0, 32768, 40000, 32768, 40000, SWP_NOMOVE); #endif SetWindowPos(hwnd, 0, -32769, -40000, -32769, -90000, SWP_NOSIZE); SetWindowPos(hwnd, 0, 32768, 40000, 32768, 40000, SWP_NOSIZE); is enough to let the tests succeed with Version: 2.3.3.2 (2.3.3) Build Info: X11server-480700~6 OS Version: Mac OS X 10.5.7 (9J61) This hints that the bug is in the X server, not the individual drivers? Regards, Jörg Höhle

2 1

Re: To error out or to skip tests?
by Greg Geldorp Nov. 9, 2009

Nov. 9, 2009

Hi Jörg > Failure to flag an error in such cases has known drawbacks: > - For several month, Austin did not notice that his BSD boxes had lost > sound. wave.ok simply reports "5 tests ok, 1 skipped" in joyfull > green, whereas it executed many tests half a year ago. > > - All those vmware boxes configured without sound and thus skipping > all but 5 wave.ok tests have for monthes *not* provided valuable > feedback to Wine. So they were actually *not* executing tests, when > they could have. > It's only when Paul tested one of my tests that he realized that > sound was not configured on one of his vmware boxes, promptly > configured the sound device, and the tests passed. > > The picture on test.winehq.org is a disaster: None of the w95, w98, nt4, > 2k, 2k3, Vista, 2k8, w7 machines have performed winmm:wave tests! > They all have no sound configured. Mostly useless. A lot of those VMware boxes are mine. They come in two flavors. Some of them (starting with esx-) are ESX VMs, ESX is VMware's data center product, which simply doesn't support sound. The others (starting with gvg-) are Server VMs, which do support sound. The reason I didn't configure sound on them is because I'm simply not interested in sound. I'll consider enabling sound, but to be honest I'm a bit put off by your aggressive tone. Anyway, the end result is that there will always be ESX VMs that can't run sound tests. Best regards, Ge.

5 12

Question on using winedbg when program does not crash, just becomes unresponsive
by Susan Cragin Nov. 9, 2009

Nov. 9, 2009

There is some sort of memory leak in Dragon NaturallySpeaking that makes the program become unresponsive (but not crash) after some minutes of using the Dictation Box. I have tried winedbg, SetOnFirstBreak but the program never actually crashes. Without SOFB, of course, winedbg goes for the first unhandled exception, which is harmless. I can't start winedbg right before the program crashes, because I don't know when it will do so. It just sort of wears down. There is nothing I do to make it become unresponsive. Any ideas?

1 0

To error out or to skip tests?
by Joerg-Cyril.Hoehle＠t-systems.com Nov. 9, 2009

Nov. 9, 2009

Hi, I apologize for the numerous occurrances of red color on test.winehq due to my new winmm MCI tests. That was not expected. However, turning something green is not a goal in itself. For some time now I wanted to query wine-devel about this topic, independently of my patches, so here it goes. An analysis reveals that my tests implement a detector of vmware (virtualbox etc.) default installs, i.e. MS-Windows systems that have not been configured with sound. No real user's machines would be like that (except for a w95 box I tried with a broken soundcard). The revealing line is > Tests skipped: Please install audio driver. Tests will fail (18 errors) This goes hand in hand with "5 tests, 0 errors, 1 skip" in winmm:wave. Exactly those systems skipping the wave tests produce 18-19 MCI errors. Failure to flag an error in such cases has known drawbacks: - For several month, Austin did not notice that his BSD boxes had lost sound. wave.ok simply reports "5 tests ok, 1 skipped" in joyfull green, whereas it executed many tests half a year ago. - All those vmware boxes configured without sound and thus skipping all but 5 wave.ok tests have for monthes *not* provided valuable feedback to Wine. So they were actually *not* executing tests, when they could have. It's only when Paul tested one of my tests that he realized that sound was not configured on one of his vmware boxes, promptly configured the sound device, and the tests passed. The picture on test.winehq.org is a disaster: None of the w95, w98, nt4, 2k, 2k3, Vista, 2k8, w7 machines have performed winmm:wave tests! They all have no sound configured. Mostly useless. Therefore, I believe it's sometimes better to flag an error than to calmly skip something. Last year already, submitting the ICCVID patches, I was thinking: "iccvid.dll may not part of every installation, but we want feedback so we should compare behaviour with MS-Windows systems equipped with that library and ask people to install it if not present". Likewise, Wine should compare with systems similarly equipped: d3d8, d3d9, dplay, dmusic etc. Perhaps an easy change on test.winehq would be to augment the blue color indicator of skipped tests to the full rectangle surface instead of the current green? Of course, I'll change my tests to flag a single error on systems without sound. -- Or no error at all, if that's wine-devel consensus. What do you think? Jörg Höhle. There's only few real MCI test errors I saw on test.winehq: the system "fg_winxp-ie8" that yields 1 error instead of 18: mci.c:391: Test failed: not enough time elapsed 80ms -- a flakey test. And on the ME systems: mci.c:603: Test failed: mci re-auto-open status mode returned error: 275 mci.c:612: Test failed: mci auto-open pause returned error: 275 Luckily, there are a few machines that pass all tests.

4 3

Another article that makes me want Wine to run in a sandbox
by Dan Kegel Nov. 8, 2009

Nov. 8, 2009

http://www.linuxinsider.com/rsstory/68566.html The article is about users who are willing to follow bogus instructions to solve a problem (or install something). It makes me want the average desktop to be really, really locked down... and for user-installed apps to run in a sandbox so they can't break the rest of the system. I am looking forward to hear what the discussion at http://sandboxing.org comes up with.

5 8

The user32/win test crashes X on Intel cards
by Francois Gouget Nov. 8, 2009

Nov. 8, 2009

I hit this issue while trying to run winetest for WineConf. I looked into it and the crash is caused by this line in dlls/user32/tests/win.c: SetWindowPos(hwnd, 0, 32768, 40000, 32768, 40000, SWP_NOMOVE); More precisely it's the setting of the window width and height to 32768 x 40000 that causes the crash. Looking at the .xsession-errors file I see the window manager reporting the following X server error: Anomalie dans le gestionnaire de fenêtres : Unexpected X error: BadAlloc (insufficient resources for operation) serial 11940 error_code 11 request_code 53 minor_code 0) Is it possible that this is just an out of memory issue caused by the huge window size? According to my tests 32000x32000 (a tad < 3GB) works but 32767x32767 (a tad >3GB) cause the crash. Here's my configuration: * Intel Corporation Mobile 945GME Express Integrated Graphics Controller rev 3 * VideoRAM: 256MB (according to /var/log/Xorg.0.log) * xserver-xorg-video-intel 2:2.9.0-1 Latest from Debian Testing. Debian Unstable does not seem to have a more recent driver. Marcus got the same issue and he had an Intel card too and we were the only two with this issue. So apparently this is Intel-specific. Does any one have an Intel card where this does not happen? What's your driver version? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Lotto: A tax on people who are bad at math." -- unknown "Windows: Microsoft's tax on computer illiterates." -- WE7U

2 2

Re: d3d9: quiet a few very noisy fixme's
by Austin English Nov. 8, 2009

Nov. 8, 2009

On Sun, Nov 8, 2009 at 6:14 AM, Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > These are spawned at huge rate in World in Conflict demo > (http://bugs.winehq.org/show_bug.cgi?id=11114) It'd be quicker/cleaner to just change them to warn's instead, IMHO. -- -Austin

2 1

Re: [PATCH] rpcrt4: compare networkoptions correctly (Coverity) (adjusted)
by Rob Shearman Nov. 8, 2009

Nov. 8, 2009

2009/11/8 Marcus Meissner <meissner(a)suse.de>: > @@ -84,6 +84,17 @@ static RPC_STATUS RpcAssoc_Alloc(LPCSTR Protseq, LPCSTR NetworkAddr, > return RPC_S_OK; > } > > +static BOOL compare_networkoptions(LPCWSTR opts1, LPCWSTR opts2) > +{ > + if ((opts1 == NULL) && (opts2 == NULL)) > + return TRUE; > + if ((opts1 == NULL) && (opts2 != NULL)) > + return FALSE; > + if ((opts1 != NULL) && (opts2 == NULL)) > + return FALSE; > + return !strcmpW(opts1, opts2); > +} > + > RPC_STATUS RPCRT4_GetAssociation(LPCSTR Protseq, LPCSTR NetworkAddr, > LPCSTR Endpoint, LPCWSTR NetworkOptions, > RpcAssoc **assoc_out) > @@ -97,8 +108,8 @@ RPC_STATUS RPCRT4_GetAssociation(LPCSTR Protseq, LPCSTR NetworkAddr, > if (!strcmp(Protseq, assoc->Protseq) && > !strcmp(NetworkAddr, assoc->NetworkAddr) && > !strcmp(Endpoint, assoc->Endpoint) && > - ((!assoc->NetworkOptions && !NetworkOptions) || !strcmpW(NetworkOptions, assoc->NetworkOptions))) > - { > + compare_networkoptions(NetworkOptions, assoc->NetworkOptions) > + ) { Looks good functionally, but please don't change the style. > assoc->refs++; > *assoc_out = assoc; > LeaveCriticalSection(&assoc_list_cs); Thanks, -- Rob Shearman

1 0

Re: winex11.drv: Implement FIXME in AlphaBlend
by Roderick Colenbrander Nov. 7, 2009

Nov. 7, 2009

Hi Peter, I didn't see this patch before because I was away at that time. The SourceConstantAlpha part looks correct to me. It might make sense to calculate blendfn.SourceConstantAlpha / 255 before the loop, so that it isn't recalculated each time. The other half of your patch is a separate change and it would require a separate patch. The part looks suspicious though. I don't understand why you need special locking there. Roderick On Mon, Oct 26, 2009 at 4:39 PM, Peter Urbanec <winehq.org(a)urbanec.net> wrote: > > > commit df78de34a06e32be9f37a3b34fe68e5b088a8578 > Author: Peter Urbanec <winehq.org(a)urbanec.net> > Date: Mon Oct 26 21:29:00 2009 +1100 > > Implement source alpha plus SourceConstantAlpha combined transparency. > Add DIB locking to prevent node icon rendering errors in Fusion composition flow views. > > diff --git a/dlls/winex11.drv/xrender.c b/dlls/winex11.drv/xrender.c > index 90503bf..26dc262 100644 > --- a/dlls/winex11.drv/xrender.c > +++ b/dlls/winex11.drv/xrender.c > @@ -1956,9 +1956,6 @@ BOOL CDECL X11DRV_AlphaBlend(X11DRV_PDEVICE *devDst, INT xDst, INT yDst, INT wid > return FALSE; > } > > - if ((blendfn.AlphaFormat & AC_SRC_ALPHA) && blendfn.SourceConstantAlpha != 0xff) > - FIXME("Ignoring SourceConstantAlpha %d for AC_SRC_ALPHA\n", blendfn.SourceConstantAlpha); > - > if(dib.dsBm.bmBitsPixel != 32) { > FIXME("not a 32 bpp dibsection\n"); > return FALSE; > @@ -1979,11 +1976,35 @@ BOOL CDECL X11DRV_AlphaBlend(X11DRV_PDEVICE *devDst, INT xDst, INT yDst, INT wid > > if (blendfn.AlphaFormat & AC_SRC_ALPHA) > { > - for(; y >= y2; y--) > + if (blendfn.SourceConstantAlpha == 0xff) > { > - memcpy(dstbits, (char *)dib.dsBm.bmBits + y * dib.dsBm.bmWidthBytes + xSrc * 4, > + for(; y >= y2; y--) > + { > + memcpy(dstbits, (char *)dib.dsBm.bmBits + y * dib.dsBm.bmWidthBytes + xSrc * 4, > widthSrc * 4); > - dstbits += (top_down ? -1 : 1) * widthSrc; > + dstbits += (top_down ? -1 : 1) * widthSrc; > + } > + } > + else > + { > + /* Source alpha plus SourceConstantAlpha */ > + for(; y >= y2; y--) > + { > + int x; > + DWORD *srcbits = (DWORD *)((char *)dib.dsBm.bmBits + y * dib.dsBm.bmWidthBytes) + xSrc; > + for (x = 0; x < widthSrc; x++) > + { > + DWORD argb = *srcbits++; > + BYTE *s = (BYTE *) &argb; > + s[0] = (s[0] * blendfn.SourceConstantAlpha) / 255; > + s[1] = (s[1] * blendfn.SourceConstantAlpha) / 255; > + s[2] = (s[2] * blendfn.SourceConstantAlpha) / 255; > + s[3] = (s[3] * blendfn.SourceConstantAlpha) / 255; > + *dstbits++ = argb; > + } > + if (top_down) /* we traversed the row forward so we should go back by two rows */ > + dstbits -= 2 * widthSrc; > + } > } > } > else > @@ -2006,6 +2027,7 @@ BOOL CDECL X11DRV_AlphaBlend(X11DRV_PDEVICE *devDst, INT xDst, INT yDst, INT wid > > } > > + X11DRV_LockDIBSection( devDst, DIB_Status_GdiMod ); > dst_pict = get_xrender_picture(devDst); > > wine_tsx11_lock(); > @@ -2017,6 +2039,8 @@ BOOL CDECL X11DRV_AlphaBlend(X11DRV_PDEVICE *devDst, INT xDst, INT yDst, INT wid > if(!src_format) > { > WARN("Unable to find a picture format supporting alpha, make sure X is running at 24-bit\n"); > + wine_tsx11_unlock(); > + X11DRV_UnlockDIBSection( devDst, TRUE ); > return FALSE; > } > > @@ -2055,6 +2079,7 @@ BOOL CDECL X11DRV_AlphaBlend(X11DRV_PDEVICE *devDst, INT xDst, INT yDst, INT wid > XDestroyImage(image); > > wine_tsx11_unlock(); > + X11DRV_UnlockDIBSection( devDst, TRUE ); > HeapFree(GetProcessHeap(), 0, data); > return TRUE; > } > > > >

2 1

Re: (retry) msctf/tests: handle an occassional unexpected SetFocus from wine
by Nicolas Le Cam Nov. 7, 2009

Nov. 7, 2009

2009/11/7 Aric Stewart <aric(a)codeweavers.com>: > --- > dlls/msctf/tests/inputprocessor.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > Here are the results for 100 consecutive runs : $ for i in {1..100}; do wine msctf_test.exe.so >> msctf_tests.log 2>&1; done $ grep "tests executed" msctf_tests.log | sort | uniq -c | sort -nr 77 inputprocessor: 230 tests executed (0 marked as todo, 0 failures), 0 skipped. 18 inputprocessor: 231 tests executed (0 marked as todo, 3 failures), 0 skipped. 3 inputprocessor: 234 tests executed (0 marked as todo, 4 failures), 0 skipped. 1 inputprocessor: 238 tests executed (0 marked as todo, 8 failures), 0 skipped. 1 inputprocessor: 236 tests executed (0 marked as todo, 6 failures), 0 skipped. I also did try to sleep between tests in case it could help but it doesn't seem so : $ for i in {1..100}; do wine msctf_test.exe.so >> msctf_tests.log 2>&1; sleep 1; done $ grep "tests executed" msctf_tests.log | sort | uniq -c | sort -nr 78 inputprocessor: 230 tests executed (0 marked as todo, 0 failures), 0 skipped. 17 inputprocessor: 231 tests executed (0 marked as todo, 3 failures), 0 skipped. 3 inputprocessor: 238 tests executed (0 marked as todo, 8 failures), 0 skipped. 2 inputprocessor: 236 tests executed (0 marked as todo, 6 failures), 0 skipped. For info, here is a run without your patch. $ for i in {1..100}; do wine msctf_test.exe.so >> msctf_tests.log 2>&1; sleep 1; done $ grep "tests executed" msctf_tests.log | sort | uniq -c | sort -nr 64 inputprocessor: 230 tests executed (0 marked as todo, 0 failures), 0 skipped. 18 inputprocessor: 236 tests executed (0 marked as todo, 4 failures), 0 skipped. 12 inputprocessor: 237 tests executed (0 marked as todo, 7 failures), 0 skipped. 3 inputprocessor: 234 tests executed (0 marked as todo, 4 failures), 0 skipped. 2 inputprocessor: 236 tests executed (0 marked as todo, 6 failures), 0 skipped. 1 inputprocessor: 238 tests executed (0 marked as todo, 8 failures), 0 skipped. If you need me to do more tests, just ask, I'm willing to go green ;) -- Nicolas Le Cam

1 0

Re: [PATCH] rpcrt4: Fixed incorrect NULL check condition (Coverity)
by Rob Shearman Nov. 7, 2009

Nov. 7, 2009

2009/10/17 Marcus Meissner <marcus(a)jet.franken.de>: > Hi, > > Coverity spotted that this could lead to NULL dereference, > and yes, the && should be ||. This is not what was intended. The code inside the if block shouldn't execute if assoc->NetworkOptions is NULL and NetworkOptions isn't and vice-versa. The comparison should probably be split into a separate function. > @@ -97,7 +97,7 @@ RPC_STATUS RPCRT4_GetAssociation(LPCSTR Protseq, LPCSTR NetworkAddr, > if (!strcmp(Protseq, assoc->Protseq) && > !strcmp(NetworkAddr, assoc->NetworkAddr) && > !strcmp(Endpoint, assoc->Endpoint) && > - ((!assoc->NetworkOptions && !NetworkOptions) || !strcmpW(NetworkOptions, assoc->NetworkOptions))) > + (!assoc->NetworkOptions || !NetworkOptions || !strcmpW(NetworkOptions, assoc->NetworkOptions))) Thanks, -- Rob Shearman

1 0

libsmbclient and wine?
by Dan Kegel Nov. 7, 2009

Nov. 7, 2009

Hi folks, it's often been said that wine can't use libsmbclient because of license problems. I'd like to look at that assumption a bit. - What would wine like to use libsmbclient for, if it could? - Would it suffice to just link it in to wineserver, or would it need to be invoked directly by all sorts of dlls? - Would we just use the system's libsmbclient (I hope so) rather than trying to import its source? Also, fwiw, I think the Samba guys are willing to multiplex their listening daemon so Wine could handle incoming named pipe requests if we want to. Thanks, Dan

3 2

Re: msctf/tests: handle an occassional unexpected SetFocus from wine
by Aric Stewart Nov. 7, 2009

Nov. 7, 2009

Please disregard this. I was testing the wrong version on my winvista machine and this causes a failure. revised version coming. -aric Aric Stewart wrote: > --- > dlls/msctf/tests/inputprocessor.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > ------------------------------------------------------------------------ > >

1 0

Re: msctf/tests: handle an occassional unexpected SetFocus from wine
by Nicolas Le Cam Nov. 7, 2009

Nov. 7, 2009

2009/11/7 Aric Stewart <aric(a)codeweavers.com>: > --- > dlls/msctf/tests/inputprocessor.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > > > Aric, is this for my versatile machine ? -- Nicolas Le Cam

1 0

Re: [CHANGE] Patch: regional settings update & translation
by Stefan Leichter Nov. 7, 2009

Nov. 7, 2009

Am Friday 06 November 2009 21:49:26 schrieb lejcik: > Signed-off-by: lejcik <lejcik(a)host.sk> > --- > dlls/kernel32/nls/csy.nls | 38 +++++++++++++++++++------------------- > dlls/kernel32/nls/sky.nls | 42 > +++++++++++++++++++++--------------------- > 2 files changed, 40 insertions(+), 40 deletions(-) To get a patch accepted, you need the send it with your real name. Bye Stefan

1 0

Link to Test Runs
by Mike Nov. 6, 2009

Nov. 6, 2009

Ok, I found this once before but I can't find it again. Where is the link to the test runs for different platforms, etc. I wanted to see if my tests passed Win 95. Sorry for asking questions that should probably be obvious, but we all start ignorant and some of us more ignorant and naive than others. Thanks, Mikey

2 1

Re: shell32/tests: Add Program Manager DDE Conformance Tests (try 2)
by Paul Vriens Nov. 6, 2009

Nov. 6, 2009

On 11/03/2009 04:32 AM, Mike wrote: > These conformance tests are for the program manager dde. Basic operations are tested. The current wine implementation (shell32/dde.c) of the Program Manager DDE is stubbed. This conformance tests were run and passed on Win 98 SE and Win XP SP2. Related Bug #9159 > > > --- > dlls/shell32/tests/Makefile.in | 1 + > dlls/shell32/tests/progman_dde.c | 551 ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 552 insertions(+), 0 deletions(-) > create mode 100644 dlls/shell32/tests/progman_dde.c > > Hi Mikey, These new tests introduce test failures on different platforms: http://test.winehq.org/data/tests/shell32:progman_dde.html Could you have a look? -- Cheers, Paul.

2 1

Re: winmm/tests: Add MCI waveaudio tests.
by Paul Vriens Nov. 6, 2009

Nov. 6, 2009

On 11/05/2009 02:35 PM, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Hi, > > this is the same as yesterday's patch except that I replaced the > ad-hoc skip auto-open test with one that specifically detects Wine's > missing auto-open functionality instead of another thing missing in Wine. > You will prefer that version; sorry for the quick-shot. > > Regards, > Jörg Höhle. > Hi Jörg, This one introduces several test failures: http://test.winehq.org/data/tests/winmm:mci.html I guess you already noticed, but could you have a look? -- Cheers, Paul.

1 0

Re: had trouble compiling today
by Susan Cragin Nov. 5, 2009

Nov. 5, 2009

>Looks like a gcc compiler bug, so you will need to report it there >and/or to the Ubuntu bug tracker. > >Out of interest: > a/ did this work when you were running karmic? Yes. Worked always with Karmic. Worked yesterday with Lucid. But downloaded new gcc today, and new git. So it's one or the other. > b/ what does "gcc --version" produce? gcc (Ubuntu 4.4.2-1ubuntu3) 4.4.2 > c/ is this an incremental build from a previous build on karmic? Yes. (In fact, it's pre-alpha lucid.) It may well be that there is a new gcc that depends on a new something else that hasn't been released yet. > d/ what happens if you clean out all build files (running "git >clean -fxd" in ~/wine will do this if ~/wine is a clone of the wine >git repository) and do a build -- does that resolve the issue? Oh, that's a nice command. I'll have to remember that one. Nothing happens. >NOTE: You should still report this to gcc/Ubuntu. Noted. Reported. Bug filed. >- Reece As I was getting ready to send this I noted another gcc floating by aptitude, so I gave that one a spin. No luck. The problem persists, but I bet the developers know about it.

1 0

Wine on OpenBSD, Theo de Raadt
by Yann Droneaud Nov. 5, 2009

Nov. 5, 2009

Hi, In a recent post ( <http://lwn.net/Articles/360312/> ), Theo de Raadt is criticising Linux page 0 handling. He argue that Linux allows page 0 mapping only for Wine. And OpenBSD won't allow page 0 mapping for security reasons (and performance reasons). Since Wine seems to be working on other *BSD and derivative systems, is this a problem ? Could someone comment on this issue. I don't find anything related on <http://wiki.winehq.org/OpenBSD> Regards. -- Yann Droneaud

5 7

had trouble compiling today
by Susan Cragin Nov. 5, 2009

Nov. 5, 2009

It may be me. I've upgraded to Lucid Lynx. My compile failed. gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o int21.o int21.c int21.c: In function ‘INT21_GetDriveAllocInfo’: int21.c:3556: internal compiler error: in int_cst_value, at tree.c:8305 Please submit a full bug report, with preprocessed source if appropriate. See <file:///usr/share/doc/gcc-4.4/README.Bugs> for instructions. make[2]: *** [int21.o] Error 1 make[2]: Leaving directory `/home/susan/wine/dlls/winedos' make[1]: *** [winedos] Error 2 make[1]: Leaving directory `/home/susan/wine/dlls' make: *** [dlls] Error 2 susan(a)ubuntu:~/wine$

2 1

Re: crypt32.dll: Initialize provider pointer to null before calling CryptAcquireContextW()
by Juan Lang Nov. 5, 2009

Nov. 5, 2009

Hi Paul, I imagine this is to avoid checking prov if CryptAcquireContextW fails. In that case, wouldn't it be better to check the return value of CryptAcquireContextW? --Juan

2 2

Weird error for the advapi32/eventlog tests on Vista+ when running winetest
by Paul Vriens Nov. 5, 2009

Nov. 5, 2009

Hi, Just noticed that we have 1 test failure on Vista+ for the advapi32/eventlog tests. I was sure I've tested these from Win95 up to Win7. When I run tests I want to do this as Administrator, so on Vista+ I select 'Run as Administrator' to start a command prompt, or to launch winetest. Running the mentioned crosscompiled tests is no problem unless you do this from the actual home directory (or any subdirectory) of the user that logged in. Winetest runs most of it's test in the %TEMP% directory and hence we see this failure. But I have no clue why (yet). Anyone? -- Cheers, Paul.

2 4

Comment request: wineconsole: Fix Alt+F10 sent when F10 pressed.
by Erich Hoover Nov. 4, 2009

Nov. 4, 2009

I thought this patch was pretty straightforward, comments? http://www.winehq.org/pipermail/wine-patches/2009-October/080779.html Erich Hoover ehoover(a)mines.edu

1 0

Re: mshtml/tests: Fix events test when pointer is on a corner.
by Jacek Caban Nov. 4, 2009

Nov. 4, 2009

Hi Nicolas, Nicolas Le Cam wrote: > Hi, > > Since commit 8272ecd3f2235b923f2ec67bb51d051bdfbf466f I'm having > errors on events tests. > > I just found that it only fails if pointer is on any corner. As I'm > always putting it on upper right corner when running winetest it was > always failing for me. > > Minimizing the test window fixed it for me. > Tested on Win2k SP4 and WinXP SP2 (both with IE6). > Minimizing window changes what we test and will break test interactive mode. We should change tests to accept cursor in left corner. Thanks, Jacek

2 4

Please write audio tests (was: Playing ULAW sample correctly?)
by Joerg-Cyril.Hoehle＠t-systems.com Nov. 4, 2009

Nov. 4, 2009

Hi, >1. generate a PCM sine wave tone (like winmm/tests/wave.c); Actually any repetitive signal may not be good enough for general purpose, sine or square. Perhaps add some change in volume? For instance, there currently is a bug somewhere that causes Wine to repeat the first second of an intro animation's sound (bug #18182, comment #3) instead of continuing. This would probably not be detected. Also, the µ-law speech sample I fed to the MCI produces stuttering. Perhaps that would not be heard with a sine wave, if the periods match. Still it's better to have a test than currently no test at all! >It is also quite simple to generate sine waves without any trig. Code for sine is already in winmm/tests/wave.c No need to reinvent. Regards, Jörg Höhle

2 1

Re: winmm/tests: Add MCI waveaudio tests.
by Alexandre Julliard Nov. 4, 2009

Nov. 4, 2009

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > +START_TEST(mci) > +{ > + HWND hwnd; > + hwnd = CreateWindowExA(0, "static", "winmm test", WS_POPUP, 0,0,100,100, > + 0, 0, 0, NULL); > + test_openCloseWAVE(hwnd); > + test_recordWAVE(hwnd); > + test_playWAVE(hwnd); > + test_asyncWAVE(hwnd); > + test_AutoOpenWAVE(hwnd); > + if(1) DeleteFile("tempfile.wav"); This fails to delete the file, probably because it's still open somewhere. -- Alexandre Julliard julliard(a)winehq.org

1 0

how to install a windows service in wine?
by Zhaohui Wang Nov. 4, 2009

Nov. 4, 2009

Hi all I am using wine 1.1.32, can anyone tell me how to install a windows service(say NETBIOS) in wine? I saw there is a services.exe running, but I didn't find any document on winehq saying how to add new wine services. I appreciate your help Best Regards Zhao Wang

2 2

Re: mciwave: Eliminate superfluous logs.
by Alexandre Julliard Nov. 4, 2009

Nov. 4, 2009

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > - WARN after ExitThread is superfluous (and not present in most other code) Most likely the ExitThread should be removed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mciwave: Use volatile on slot modified from recorder thread.
by Alexandre Julliard Nov. 4, 2009

Nov. 4, 2009

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > From b45e51940a42016e25a5c3a144968d81248927ed Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?J=C3=B6rg=20H=C3=B6hle?= <hoehle(a)users.sourceforge.net> > Date: Mon, 2 Nov 2009 23:49:42 +0100 > Subject: [PATCH] mciwave: Use volatile on slot modified from recorder thread. That's wrong. If there is proper synchronization you don't need volatile, and if there isn't volatile won't magically fix it. -- Alexandre Julliard julliard(a)winehq.org

1 0

msi: Initialize string pointer to NULL
by Kirill K. Smirnov Nov. 3, 2009

Nov. 3, 2009

Hi Nathan, >+ haystack_table_name = NULL; > r = table->ops->get_column_info( table, i, &col_name, NULL, > NULL, &haystack_table_name ); > if( r != ERROR_SUCCESS ) I'm afraid, but this patch silences valgrind only, but does not solves the problem. It seems to me, that if table->ops->get_column_info() succeeds, it initializes haystack_table_name, and if it fails, we do not use haystack_table_name at all (we immediately return from this function). Thus, the problem lies somewhere in get_column_info(). So it is useless (and harmful, because it confuses valgrind) to initialize it like this. -- Kirill

2 1

Re: crypt32: Implement CertAddEncodedCertificateToSystemStoreA/W
by Stefan Leichter Nov. 3, 2009

Nov. 3, 2009

Am Tuesday 03 November 2009 23:32:42 schrieb Juan Lang: > These were too easy to pass up. > --Juan +BOOL WINAPI CertAddEncodedCertificateToSystemStoreW(LPCWSTR pszCertStoreName, + const BYTE *pbCertEncoded, DWORD cbCertEncoded) +{ [snip] + store = CertOpenSystemStoreA(0, pszCertStoreName); This looks wrong to me ... Bye Stefan

2 1

Playing ULAW sample correctly?
by Joerg-Cyril.Hoehle＠t-systems.com Nov. 3, 2009

Nov. 3, 2009

Hi, Using the MCI, I've successfully played an ADPCM sample from Wikipedia, except at the very end of IMA ADPCM play: fixme:wavemap:wodWrite Not all src buffer has been written, expect bogus sound After play status length increased from 13813 to 13826! How comes? However, playing an ULAW sample, the same message occurs constantly (apparently once for each wavehdr played) and the sound is awfully chopped. The error could be anywhere (MCI, WAVE_MAPPER, gsm711 ACM, waveaudio ...). Are there audio tests in Wine beside winmm/wave.c? How is ulaw / how are the msacm/gsm711/gsm722/gsm602 tested? Does anybody know whether ULAW works in Wine? (Any app that uses it outside of MCI?) Thanks, Jörg Höhle

5 7

windows chromium testsuite valgrind warnings
by Dan Kegel Nov. 3, 2009

Nov. 3, 2009

For what it's worth, here are the valgrind warnings from a run of my current subset of the chromium test suite under valgrind+wine: http://kegel.com/wine/chromium/valgrind-logs/errors.html Mostly they're leaks. That's good news. For the few nonleak warnings, I already filed http://bugs.winehq.org/show_bug.cgi?id=20567 for the des one in http://kegel.com/wine/chromium/valgrind-logs/base_unittests/RSAPrivateKeyUn… http://kegel.com/wine/chromium/valgrind-logs/base_unittests/SignatureCreato… and http://kegel.com/wine/chromium/valgrind-logs/base_unittests/SignatureVerifi… and http://bugs.winehq.org/show_bug.cgi?id=20553 for the first one in http://kegel.com/wine/chromium/valgrind-logs/unit_tests/TableViewTest.log and am puzzling over the crash later in TableViewTest (though maybe once I clear up the first error, the crash will go away). The leaks aren't quite as important. I filed a few so far: http://bugs.winehq.org/show_bug.cgi?id=20544 shell32 imagelist memory leak on unload? http://bugs.winehq.org/show_bug.cgi?id=20545 memory leak in MMDRV_Init on exit? http://bugs.winehq.org/show_bug.cgi?id=20548 Memory leak in pending overlapped I/O? http://bugs.winehq.org/show_bug.cgi?id=20551 user32 clipboard memory leaks http://bugs.winehq.org/show_bug.cgi?id=20552 Memory leak in alloc_thread_tls? and http://bugs.winehq.org/show_bug.cgi?id=20549 secur32 memory leak on exit? which is already closed (it's an upstream issue and/or notabug). Of those, I'm only worried about 20548 and 20551. - Dan

1 0

Re: [PATCH 0/3] Handling DOS drives in mountmgr (try 2)
by Charles Davis Nov. 2, 2009

Nov. 2, 2009

Charles Davis wrote: > Hi, > > This patch series moves drive handling over to mountmgr. Mountmgr will > now associate UNIX device files directly to its created devices instead > of having ntdll handle converting something like \??\D: to > $WINEPREFIX/dosdevices/d::. This way, we can implement storage I/O > controls in mountmgr instead of ntdll, while the storage I/O controls > already in ntdll continue to work. > > It also allows drivers to associate UNIX device files to their device > objects, paving the way for separating the driver code from ntdll. > > Since nobody's said anything about my patches, I'll have to assume > they're good. (They work for me.) > > Chip > > I thought I fixed all the issues. What's wrong with my patches now? Chip

2 4

Re: eventlog tests and writing/clearing the logs
by Paul Vriens Nov. 2, 2009

Nov. 2, 2009

On 11/02/2009 05:51 PM, mellery wrote: > Hi, > > Will this involve implementing advapi:RegisterTraceGuidsW, and can I > help at all? > > Thanks, > Mike Event tracing is totally different from event logging. Be my guest to pick that up ;) Maybe it's a good idea to split the advapi32/eventlog.c into eventlog.c and eventtrace.c once the tracing is fleshed out a bit more. Particularly if we move most of functionality to services.exe (as on Windows). -- Cheers, Paul.

1 0

eventlog tests and writing/clearing the logs
by Paul Vriens Nov. 2, 2009

Nov. 2, 2009

Hi, I'm mostly done with the parameter tests and I'm starting to look what functional tests I can add. The biggest issues I have are: - Writing events needs to go a registered event source - Clearing an eventlog has to be with a registered event source - Registering our own event source can be done but needs a reboot to clear out any remnants. As we really want to test all of this, my proposal is to run these tests only in interactive mode. Doing so at least gives us some confidence that people know what they are doing. Worst case, they will have an extra event source that can only be deleted by removing some registry entries, a reboot and removal of the actual eventlog file (the registry removal will be part of the cleanup of course but you never know). Any thoughts on this? Correct approach? -- Cheers, Paul.

2 2

Re: gdi32: add testcases for copying an EMF from a NULL bitmap
by Nikolay Sivov Nov. 2, 2009

Nov. 2, 2009

On Mon, Nov 2, 2009 at 8:27 AM, Austin English <austinenglish(a)gmail.com> wrote: > Testcase for bug 4553 Are you sure? I don't see any related patches here. > > -- > -Austin > Why there's no wine failure in this test?

2 1

Re: mciwave: Fix copy&paste errors and remove superfluous log.
by Paul Vriens Nov. 2, 2009

Nov. 2, 2009

On 11/02/2009 02:56 PM, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Hi, > > - shareable is neither supported nor implemented by waveaudio (other MCIxyz support it); > Let mciOpen supply the same error code as MS-Windows. > - volatile dwPosition is recommended as the recorder thread callback updates it > (sometimes I think the whole structure should be declared volatile). > - WARN after ExitThread is superfluous (and not present in most other code) > -- should be ERR if at all. > - TRACE of wave format parameters is a duplicate and already logged a few lines earlier. > - TRUE (1) is not a valid return code in MMSYSTEM. > - INPUT/OUTPUTUNSPECIFIED is a typical example of copy&paste error. > > Later I'll fix the same in the other MCIxyz libraries (mcicda, mcimidi and mciwave are very similar, mciavi is different). I plan to patch the former 3 only. > > Regards, > Jörg Höhle > Hi Jörg, Doesn't the fact that you list 6 fixes mean you need to split up this patch? -- Cheers, Paul.

1 0

Remove NoAppDBEntry keyword?
by Austin English Nov. 2, 2009

Nov. 2, 2009

Anyone opposed to removing that keyword? -- -Austin

2 1

Errors using Wordpad from Wine 1.1.6 after applying this patch
by James McKenzie Nov. 1, 2009

Nov. 1, 2009

All: I've been attempting to bring Tony Rollo's EM_FORMATRANGE patch up to date and got to Wine 1.1.6. At the suggestion of Dylan Smith, I have been using Wordpad to test the patch after adding a little test because of poor display on the Print Preview. However, I've run into two what appears to be separate 'bugs'. The first occurs when I attempt to change the font size, I get an error "Invalid Number Format". The second is that I can change the displayed font one and only one time. I've reversed both of Andrey Turkin's patches that were applied between wine-1.1.5 and wine-1.1.6 but this did not resolve the error message and the inability to change fonts and actually introduced a possible third error where the font name is distorted where it shows a series of blocks and some other unintelligible data in the font display field on the screen. Any ideas on why this is happening? Patch attached with debugging code. James McKenzie

2 2

Re: [1/5] WineD3D: Add a parameter for SetRenderTarget viewport setup
by Stefan Dösinger Nov. 1, 2009

Nov. 1, 2009

Am 01.11.2009 um 13:28 schrieb Stefan Dösinger: > <0001-WineD3D-SetRT-viewport-param.txt> Please use the other [1/5] patch - this one has a wrong patch description in the file

1 0