November 2009 - Wine-Devel - list.winehq.org

windows chromium testsuite valgrind warnings
by Dan Kegel Nov. 3, 2009

Nov. 3, 2009

For what it's worth, here are the valgrind warnings from a run of my current subset of the chromium test suite under valgrind+wine: http://kegel.com/wine/chromium/valgrind-logs/errors.html Mostly they're leaks. That's good news. For the few nonleak warnings, I already filed http://bugs.winehq.org/show_bug.cgi?id=20567 for the des one in http://kegel.com/wine/chromium/valgrind-logs/base_unittests/RSAPrivateKeyUn… http://kegel.com/wine/chromium/valgrind-logs/base_unittests/SignatureCreato… and http://kegel.com/wine/chromium/valgrind-logs/base_unittests/SignatureVerifi… and http://bugs.winehq.org/show_bug.cgi?id=20553 for the first one in http://kegel.com/wine/chromium/valgrind-logs/unit_tests/TableViewTest.log and am puzzling over the crash later in TableViewTest (though maybe once I clear up the first error, the crash will go away). The leaks aren't quite as important. I filed a few so far: http://bugs.winehq.org/show_bug.cgi?id=20544 shell32 imagelist memory leak on unload? http://bugs.winehq.org/show_bug.cgi?id=20545 memory leak in MMDRV_Init on exit? http://bugs.winehq.org/show_bug.cgi?id=20548 Memory leak in pending overlapped I/O? http://bugs.winehq.org/show_bug.cgi?id=20551 user32 clipboard memory leaks http://bugs.winehq.org/show_bug.cgi?id=20552 Memory leak in alloc_thread_tls? and http://bugs.winehq.org/show_bug.cgi?id=20549 secur32 memory leak on exit? which is already closed (it's an upstream issue and/or notabug). Of those, I'm only worried about 20548 and 20551. - Dan

1 0

Re: [PATCH 0/3] Handling DOS drives in mountmgr (try 2)
by Charles Davis Nov. 2, 2009

Nov. 2, 2009

Charles Davis wrote: > Hi, > > This patch series moves drive handling over to mountmgr. Mountmgr will > now associate UNIX device files directly to its created devices instead > of having ntdll handle converting something like \??\D: to > $WINEPREFIX/dosdevices/d::. This way, we can implement storage I/O > controls in mountmgr instead of ntdll, while the storage I/O controls > already in ntdll continue to work. > > It also allows drivers to associate UNIX device files to their device > objects, paving the way for separating the driver code from ntdll. > > Since nobody's said anything about my patches, I'll have to assume > they're good. (They work for me.) > > Chip > > I thought I fixed all the issues. What's wrong with my patches now? Chip

2 4

Re: eventlog tests and writing/clearing the logs
by Paul Vriens Nov. 2, 2009

Nov. 2, 2009

On 11/02/2009 05:51 PM, mellery wrote: > Hi, > > Will this involve implementing advapi:RegisterTraceGuidsW, and can I > help at all? > > Thanks, > Mike Event tracing is totally different from event logging. Be my guest to pick that up ;) Maybe it's a good idea to split the advapi32/eventlog.c into eventlog.c and eventtrace.c once the tracing is fleshed out a bit more. Particularly if we move most of functionality to services.exe (as on Windows). -- Cheers, Paul.

1 0

eventlog tests and writing/clearing the logs
by Paul Vriens Nov. 2, 2009

Nov. 2, 2009

Hi, I'm mostly done with the parameter tests and I'm starting to look what functional tests I can add. The biggest issues I have are: - Writing events needs to go a registered event source - Clearing an eventlog has to be with a registered event source - Registering our own event source can be done but needs a reboot to clear out any remnants. As we really want to test all of this, my proposal is to run these tests only in interactive mode. Doing so at least gives us some confidence that people know what they are doing. Worst case, they will have an extra event source that can only be deleted by removing some registry entries, a reboot and removal of the actual eventlog file (the registry removal will be part of the cleanup of course but you never know). Any thoughts on this? Correct approach? -- Cheers, Paul.

2 2

Re: gdi32: add testcases for copying an EMF from a NULL bitmap
by Nikolay Sivov Nov. 2, 2009

Nov. 2, 2009

On Mon, Nov 2, 2009 at 8:27 AM, Austin English <austinenglish(a)gmail.com> wrote: > Testcase for bug 4553 Are you sure? I don't see any related patches here. > > -- > -Austin > Why there's no wine failure in this test?

2 1

Re: mciwave: Fix copy&paste errors and remove superfluous log.
by Paul Vriens Nov. 2, 2009

Nov. 2, 2009

On 11/02/2009 02:56 PM, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Hi, > > - shareable is neither supported nor implemented by waveaudio (other MCIxyz support it); > Let mciOpen supply the same error code as MS-Windows. > - volatile dwPosition is recommended as the recorder thread callback updates it > (sometimes I think the whole structure should be declared volatile). > - WARN after ExitThread is superfluous (and not present in most other code) > -- should be ERR if at all. > - TRACE of wave format parameters is a duplicate and already logged a few lines earlier. > - TRUE (1) is not a valid return code in MMSYSTEM. > - INPUT/OUTPUTUNSPECIFIED is a typical example of copy&paste error. > > Later I'll fix the same in the other MCIxyz libraries (mcicda, mcimidi and mciwave are very similar, mciavi is different). I plan to patch the former 3 only. > > Regards, > Jörg Höhle > Hi Jörg, Doesn't the fact that you list 6 fixes mean you need to split up this patch? -- Cheers, Paul.

1 0

Remove NoAppDBEntry keyword?
by Austin English Nov. 2, 2009

Nov. 2, 2009

Anyone opposed to removing that keyword? -- -Austin

2 1

Errors using Wordpad from Wine 1.1.6 after applying this patch
by James McKenzie Nov. 1, 2009

Nov. 1, 2009

All: I've been attempting to bring Tony Rollo's EM_FORMATRANGE patch up to date and got to Wine 1.1.6. At the suggestion of Dylan Smith, I have been using Wordpad to test the patch after adding a little test because of poor display on the Print Preview. However, I've run into two what appears to be separate 'bugs'. The first occurs when I attempt to change the font size, I get an error "Invalid Number Format". The second is that I can change the displayed font one and only one time. I've reversed both of Andrey Turkin's patches that were applied between wine-1.1.5 and wine-1.1.6 but this did not resolve the error message and the inability to change fonts and actually introduced a possible third error where the font name is distorted where it shows a series of blocks and some other unintelligible data in the font display field on the screen. Any ideas on why this is happening? Patch attached with debugging code. James McKenzie

2 2

Re: [1/5] WineD3D: Add a parameter for SetRenderTarget viewport setup
by Stefan Dösinger Nov. 1, 2009

Nov. 1, 2009

Am 01.11.2009 um 13:28 schrieb Stefan Dösinger: > <0001-WineD3D-SetRT-viewport-param.txt> Please use the other [1/5] patch - this one has a wrong patch description in the file

1 0