December 2009 - Wine-Devel - list.winehq.org

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Re: Improve handling of invalid input in dlls/comctl32/datetime.c
by Nikolay Sivov Jan. 19, 2011

Jan. 19, 2011

On 12/25/2009 14:18, Gerald Pfeifer wrote: > Otherwise max_count will be undefined in the following loop may do > interesting things it seems. (Does Coverity diagnose similar items?) > > Gerald > > ChangeLog: > Improve handling of invalid input in DATETIME_ReturnFieldWidth. > > diff --git a/dlls/comctl32/datetime.c b/dlls/comctl32/datetime.c > index c240d4f..08c7082 100644 > --- a/dlls/comctl32/datetime.c > +++ b/dlls/comctl32/datetime.c > @@ -38,6 +38,7 @@ > * -- FORMATCALLBACK > */ > > +#include<assert.h> > #include<math.h> > #include<string.h> > #include<stdarg.h> > @@ -619,6 +620,9 @@ DATETIME_ReturnFieldWidth (const DATETIME_INFO *infoPtr, HDC hdc, int count, SHO > lctype = LOCALE_SMONTHNAME1; > max_count = 12; > break; > + default: > + assert(0); > + max_count=0; > } > > cx = 0; > Hi, Gerald. This can't even happen. spec if filtered later with: --- case THREECHARMONTH: case FULLMONTH: case THREECHARDAY: case FULLDAY: --- So no default case here.

3 6

Wine runs IE7!
by Hans Leidekker Nov. 26, 2010

Nov. 26, 2010

Well, sort of. I found bugs in shell32, rpcrt4, comctl32 and wininet that I had to implement, stub and override my way past before it would render a page, but finally, here's the obligatory screenshot. -Hans

3 2

current state of full screen on MacOS?
by Joerg-Cyril.Hoehle＠t-systems.com Oct. 21, 2010

Oct. 21, 2010

Hi, I'd like to know whether a MacOSX user can expect full screen modes to work, as I've heard only rumors and too little facts. My experience is this: + winecfg's window opens fine even with desktop set uo full screen, no window. E.g. as in the initial setting after rm -rf ~/.wine; wine winecfg. + Likewise, other programs opening windows work fine (regedit, notepad etc.). - Programs that offer a "select screen resolution" requester present a list whose largest vertical/Y resolution is 22 pixel less than what the monitor offers. I believe OSX reserves some place for its menu bar. Lower resolution entries, e.g. 1024x768 and 800x600, are listed normally. They work in desktop window mode. - Programs that want to make use of full screen fail or hang somehow. The issue may be two-fold: a) full screen does not work at all, or b) switching to full screen resolutions less than my LCD's native resolution does not work, and applications do not cope with that. E.g. many want to display a low-resolution intro video. - Approx. two monthes ago, a hybrid desktop mode was implemented in Wine: eliminate the desktop window when it matches the full screen size; recreate it when switching back to lower resolutions. I've not observed that effect either, but the idea is brilliant. I've heard that OSX would not switch to lower resolutions like Linux machines do with e.g. xrandr -s 1 or -s 2 etc. My LCD monitor can stretch low resolution VGA signals, e.g. when plugged to a Linux netbook. However the "early 2009" nVidia Macs do not produce analog video signals anymore, and I'm using the DVI-D output. What's the current state of Wine (and Darwine) w.r.t. full screen mode? Is it just my digital DVI + LCD setting or is there an issue with Wine? I've built Wine-1.1.24 with OSX 10.5.7 and XQuartz 2.3.3.2. Thank you, Jörg Höhle.

3 2

Re: Use GCC's -Wlogical-op if possible
by Austin English Sept. 19, 2010

Sept. 19, 2010

On Thu, Jun 18, 2009 at 12:32 PM, Gerald Pfeifer<gerald(a)pfeifer.com> wrote: > I verified this does not cause any extra warnings with GCC 4.4, whereas > GCC 4.5 will become quite a bit more useful in that regard and thus help > spot any issues. > > As with -Wtype-limits that I suggested last year, I pledge to keep close > an eye on this and to address any issues proactively as part of my nightly > test builds. > > Gerald > > ChangeLog: > Use GCC's -Wlogical-op if possible. > > diff --git a/configure.ac b/configure.ac > index bef311e..3f7a657 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1385,8 +1385,9 @@ then > WINE_TRY_CFLAGS([-fno-builtin],[AC_SUBST(BUILTINFLAG,"-fno-builtin")]) > WINE_TRY_CFLAGS([-fno-strict-aliasing]) > WINE_TRY_CFLAGS([-Wdeclaration-after-statement]) > - WINE_TRY_CFLAGS([-Wwrite-strings]) > + WINE_TRY_CFLAGS([-Wlogical-op]) > WINE_TRY_CFLAGS([-Wtype-limits]) > + WINE_TRY_CFLAGS([-Wwrite-strings]) > > dnl Check for noisy string.h > saved_CFLAGS="$CFLAGS" > > > Causes 106 more warnings on 4.3.3 of this sort: tab.c:693: warning: logical ‘&&’ with non-zero constant will always evaluate as true cert.c:1627: warning: logical ‘||’ with non-zero constant will always evaluate as true -- -Austin

8 18

Re: [PATCH] winedbg: gdb proxy mode: support qAttached packet
by Eric Pouech Aug. 30, 2010

Aug. 30, 2010

Paul Bolle a écrit : > Add support for the qAttached packet. Main benefit is that if gdb was > attached to a debuggee and it quits it will now ask if it should detach > from the debuggee instead of asking whether the debuggee should be > killed. (It still will ask whether the debuggee should be killed if it > launched the debuggee itself). > > Signed-off-by: Paul Bolle <pebolle(a)tiscali.nl> > --- > Would it be better to add a new member to gdbctx instead of using a > separate variable (qAttached_reply)? > yes, inclusion in gdbctx is preferred (and storage should rather be an integer rather than a string pointer) A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 1

Re: [PATCH 2/3] winex11.drv: set global key state
by Alexandre Julliard Aug. 18, 2010

Aug. 18, 2010

Rafał Miłecki <zajec5(a)gmail.com> writes: > @@ -1250,6 +1250,21 @@ void X11DRV_send_keyboard_input( WORD wVk, WORD wScan, DWORD event_flags, DWORD > key_state_table[wVkStripped] = key_state_table[wVkL] | key_state_table[wVkR]; > } > > + SERVER_START_REQ( set_global_key_state ) > + { > + req->key = wVk; > + req->state = key_state_table[wVk]; > + wine_server_call( req ); > + } > + SERVER_END_REQ; > + SERVER_START_REQ( set_global_key_state ) > + { > + req->key = wVkStripped; > + req->state = key_state_table[wVkStripped]; > + wine_server_call( req ); > + } > + SERVER_END_REQ; > + You don't want to add 2 extra server calls for every key, especially since the server already receives the necessary information through the key event. -- Alexandre Julliard julliard(a)winehq.org

3 2

re: Remove NoAppDBEntry keyword?
by Dan Kegel April 24, 2010

April 24, 2010

Jerome Leclanche wrote: > Austin English <austinenglish at gmail.com> wrote: >> Anyone opposed to removing that keyword? > > +1 on removing it. > It would be nice to have a bugzilla filter to replace it, too. > > Are we keeping "tasklist" and "tasklet" keywords as well? theres > barely a dozen very old bugs for both of them. I think it'd be fine to remove noappdbentry, tasklist, and tasklet. If there are no objections by next weekend, let's go ahead and do it. - Dan

4 4

Re: [1/7] avifile: Initial test data and simple test for avifil32 depends
by Paul Vriens Jan. 3, 2010

Jan. 3, 2010

On 12/30/2009 03:21 AM, Julius Schwartzenberg wrote: > This patch depends on Detlef Riekenberg's patch from June 2008 and > expects it to have been applied: > http://www.winehq.org/pipermail/wine-patches/2008-June/056310.html > > It was not committed due to bug 14085: > http://bugs.winehq.org/show_bug.cgi?id=14085 Can't you just submit that initial test framework with the 3 imports (if all 3 are indeed needed)? The bug will of course not be closed but at least some of your work could be committed. -- Cheers, Paul.

4 3

avifile tests
by Julius Schwartzenberg Jan. 1, 2010

Jan. 1, 2010

Hi, I still have some fixes for avifile here, but because they are quite nasty, I thought it'd be useful to have proper tests to show the fixes are really correct. Unfortunately there is still a problem with the avifile tests as Detlef indicated in this mail: http://www.winehq.org/pipermail/wine-devel/2009-November/079693.html Based on Detlef's patch however, I was able to create an initial patch which should provide the base for the tests I want to add. I have attached it here. The idea of the tests is that I write out a complete AVI file with the stdio functions and then read it back in using the VFW API and test the values in the different headers through the API. Later tests will change the values of the default headers and test how this affects the headers when they are being read back in. (I discovered Windows' avifil32 overrides some headers with values from other headers, there is some more info in my previous mails.) The inlining structure of the current header file is now actually based on the RIFF tree in the AVI file. Is this useful or should I just use plain indentation? Should the avi file data really be put in an extra header or should it be merged with api.c? What do you think of the general idea of the tests? Thanks a lot in advance for your feedback! Julius >From 00dc5fa4d767b2edbb0e9d42931c0fd9585c1b90 Mon Sep 17 00:00:00 2001 From: Julius Schwartzenberg <julius.schwartzenberg(a)gmail.com> Date: Fri, 25 Dec 2009 20:29:43 +0100 Subject: initial version of avifile testing framework --- dlls/avifil32/tests/api.c | 72 ++++++++++++++++++ dlls/avifil32/tests/api_test.h | 160 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 232 insertions(+), 0 deletions(-) create mode 100644 dlls/avifil32/tests/api_test.h diff --git a/dlls/avifil32/tests/api.c b/dlls/avifil32/tests/api.c index 55b194f..c41ebfb 100644 --- a/dlls/avifil32/tests/api.c +++ b/dlls/avifil32/tests/api.c @@ -20,6 +20,7 @@ */ #include <stdarg.h> +#include <stdio.h> #include "windef.h" #include "winbase.h" @@ -28,6 +29,8 @@ #include "vfw.h" #include "wine/test.h" +#include "api_test.h" + /* ########################### */ static const CHAR winetest0[] = "winetest0"; @@ -87,11 +90,80 @@ static void test_AVISaveOptions(void) /* ########################### */ +void init_test_struct(COMMON_AVI_HEADERS *cah) +{ + MainAVIHeader *mah = malloc(sizeof(MainAVIHeader)); + AVIStreamHeader *ash0 = malloc(sizeof(AVIStreamHeader)); + AVIStreamHeader *ash1 = malloc(sizeof(AVIStreamHeader)); + PCMWAVEFORMAT *pcmwf = malloc(sizeof(PCMWAVEFORMAT)); + memcpy(mah, &defmah, sizeof(defmah)); + memcpy(ash0, &defash0, sizeof(defash0)); + memcpy(ash1, &defash1, sizeof(defash1)); + memcpy(pcmwf, &defpcmwf, sizeof(defpcmwf)); + cah->mah = mah; + cah->ash0 = ash0; + cah->ash1 = ash1; + cah->pcmwf = pcmwf; +} + +void create_avi_file(COMMON_AVI_HEADERS *cah) +{ + FILE * pFile; + pFile = fopen("small.avi", "wb"); + + fwrite(file_header, 1, sizeof(file_header), pFile); /* de file wordt hier niet goed aangemaakt */ + fwrite(cah->mah, 1, sizeof(MainAVIHeader), pFile); + fwrite(streamlist, 1, sizeof(streamlist), pFile); + fwrite(cah->ash0, 1, 0x38, pFile); + fwrite(videostreamformat, 1, sizeof(videostreamformat), pFile); + fwrite(padding1, 1, sizeof(padding1), pFile); + fwrite(videopropheader, 1, sizeof(videopropheader), pFile); + fwrite(cah->ash1, 1, 0x38, pFile); + fwrite(audiostreamformat_pre, 1, sizeof(audiostreamformat_pre), pFile); + fwrite(cah->pcmwf, 1, sizeof(PCMWAVEFORMAT), pFile); + fwrite(data, 1, sizeof(data), pFile); + + fclose (pFile); +} + +void test_default_data() +{ + COMMON_AVI_HEADERS *cah; + PAVIFILE pFile; + int res; + LONG lSize; + WAVEFORMATEX wfx; + PAVISTREAM pStream; + + cah = calloc(sizeof(int),4); + init_test_struct(cah); + create_avi_file(cah); + + res = AVIFileOpen(&pFile, "small.avi", OF_SHARE_DENY_WRITE, 0L); + ok(res == 0, "Unable to open file: error=%u\n", res); + + res = AVIFileGetStream(pFile, &pStream, 0, 1); + ok(res == 0, "Unable to open audio stream: error=%u\n", res); + + ok(AVIStreamReadFormat(pStream, AVIStreamStart(pStream), NULL, &lSize) == 0, "Unable to read format size\n"); + ok(AVIStreamReadFormat(pStream, AVIStreamStart(pStream), &wfx, &lSize) == 0, "Unable to read format\n"); + + ok(wfx.wFormatTag == 1, "got %u (expected 1)\n",wfx.wFormatTag); + ok(wfx.nChannels == 2, "got %u (expected 2)\n",wfx.nChannels); + ok(wfx.wFormatTag == 1, "got %u (expected 1)\n",wfx.wFormatTag); + ok(wfx.nSamplesPerSec == 11025, "got %u (expected 11025)\n",wfx.nSamplesPerSec); + ok(wfx.nAvgBytesPerSec == 22050, "got %u (expected 22050)\n",wfx.nAvgBytesPerSec); + ok(wfx.nBlockAlign == 2, "got %u (expected 2)\n",wfx.nBlockAlign); +} + +/* ########################### */ + START_TEST(api) { AVIFileInit(); test_AVISaveOptions(); + test_default_data(); AVIFileExit(); } diff --git a/dlls/avifil32/tests/api_test.h b/dlls/avifil32/tests/api_test.h new file mode 100644 index 0000000..395cfa3 --- /dev/null +++ b/dlls/avifil32/tests/api_test.h @@ -0,0 +1,160 @@ +/* + * Unit test suite header for AVI Functions + * + * Copyright 2009 Julius Schwartzenberg + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + * + */ + + +typedef struct common_avi_headers { + MainAVIHeader *mah; + AVIStreamHeader *ash0; + AVIStreamHeader *ash1; + PCMWAVEFORMAT *pcmwf; +} COMMON_AVI_HEADERS; + +static const MainAVIHeader defmah = +{ + 0x00008256, /* dwMicroSecPerFrame */ + 0x000080e8, /* dwMaxBytesPerSec */ + 0x00000000, /* dwPaddingGranularity */ + 0x00000910, /* dwFlags */ + 1, /* dwTotalFrames */ + 0, /* dwInitialFrames */ + 2, /* dwStreams */ + 0x00100000, /* dwSuggestedBufferSize*/ + 8, /* dwWidth */ + 6, /* dwHeight */ + { 0, 0, 0, 0 } /* dwReserved[4] */ +}; + +static const AVIStreamHeader defash0 = +{ + streamtypeVIDEO, /* fccType */ + 0x30323449, /* fccHandler */ + 0x00000000, /* dwFlags */ + 0, /* wPriority */ + 0, /* wLanguage */ + 0, /* dwInitialFrames */ + 0x000003e9, /* dwScale */ + 0x00007530, /* dwRate */ + 0, /* dwStart */ + 1, /* dwLength */ + 0x00100000, /* dwSuggestedBufferSize*/ + 0xffffffff, /* dwQuality */ + 0, /* dwSampleSize */ + { 0, 0, 0, 0 } /* short left right top bottom */ +}; + +static const AVIStreamHeader defash1 = +{ + /* AVIStreamHeader */ + streamtypeAUDIO, /* fccType */ + 1, /* fccHandler */ + 0, /* dwFlags */ + 0, /* wPriority */ + 0, /* wLanguage */ + 0, /* dwInitialFrames */ + 1, /* dwScale */ + 0x00002b11, /* dwRate */ + 0, /* dwStart */ + 0x00000665, /* dwLength */ + 0x00003000, /* dwSuggestedBufferSize*/ + 0xffffffff, /* dwQuality */ + 2, /* dwSampleSize */ + { 0, 0, 0, 0 } /* short left right top bottom */ +}; + +static const PCMWAVEFORMAT defpcmwf = +{ + { + 1, /* wFormatTag */ + 2, /* nChannels */ + 11025, /* nSamplesPerSec */ + 22050, /* nAvgBytesPerSec */ + 2, /* nBlockAlign */ + }, + 8, /* wBitsPerSample */ +}; + +/* Extra data needed to get the VFW API to load the file */ +DWORD file_header[] = +{ + FOURCC_RIFF, 0x34c6 /* length */, formtypeAVI, + FOURCC_LIST, 0x1ac /* length */, + listtypeAVIHEADER, ckidAVIMAINHDR, sizeof(MainAVIHeader), +}; + +/* MainAVIHeader mah */ + +DWORD streamlist[] = +{ + FOURCC_LIST, 0xd4 /* length */, + listtypeSTREAMHEADER, ckidSTREAMHEADER, 0x38 /* length */, +}; + +/* AVIStreamHeader ash0 */ + +DWORD videostreamformat[] = +{ + ckidSTREAMFORMAT, 0x28 /* length */, + 0x00000028, 0x00000008, 0x00000006, 0x00180001, + 0x30323449, 0x00000090, 0x00000000, 0x00000000, + 0x00000000, 0x00000000, +}; +DWORD padding1[] = +{ + ckidAVIPADDING, 0xc /* length */, + 0x00000004, 0x00000000, 0x63643030 +}; +DWORD videopropheader[] = +{ + 0x70727076, 0x44 /* length */, + 0x00000000, 0x00000000, + 0x0000001e, 0x00000008, 0x00000006, 0x00100009, + 0x00000008, 0x00000006, 0x00000001, 0x00000006, + 0x00000008, 0x00000006, 0x00000008, 0x00000000, + 0x00000000, 0x00000000, 0x00000000, + FOURCC_LIST, 0x70 /* length */, + listtypeSTREAMHEADER, ckidSTREAMHEADER, 0x38 /* length */, +}; + +/* AVIStreamHeader ash1 */ + +DWORD audiostreamformat_pre[] = +{ + ckidSTREAMFORMAT, sizeof(PCMWAVEFORMAT) /* length */, +}; + +/* PCMWAVEFORMAT pcmwf */ + +DWORD data[] = +{ + ckidAVIPADDING, 0xc /* length */, + 0x00000004, 0x00000000, 0x62773130, + ckidAVIPADDING, 0xc /* length */, + 0x6c6d646f, 0x686c6d64, 0x000000f8, + FOURCC_LIST, 0x18 /* length */, + 0x4f464e49, + 0x54465349, 0xc /* length */, + 0x6676614c, 0x332e3235, 0x00302e37, + ckidAVIPADDING, 0x4 /* length */, + 0, + + FOURCC_LIST, 0xd1b /* length */, listtypeAVIMOVIE, + 0, 0 +}; -- 1.6.3.3

4 6

valgrind bot back online
by Dan Kegel Dec. 31, 2009

Dec. 31, 2009

The valgrind bot seems to have locked up soon after I left for vacation, but it's back up. Today's results: http://kegel.com/wine/valgrind/logs/2009-12-31-09.07/ Stats: 1 Invalid free/ delete / delete[] 1 Use of uninitialised value of size 4 2 Invalid write of size 4 2 Source and destination overlap in memcpy 3 Syscall param writev 6 Invalid read of size 2 8 Invalid write of size 1 12 Invalid read of size 4 49 Conditional jump or move depends on uninitialised value 598 XXX bytes in XXX blocks are definitely lost total: 682 The total on Dec 18th was 807. Nice progress!

1 0

va_list breakage introduced today
by Gerald Pfeifer Dec. 31, 2009

Dec. 31, 2009

I believe the following patch commit 8268ed978389662c7b43212e008037cae3ce900e Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Dec 28 22:19:31 2009 +0100 kernel32: Do not include 16-bit headers in 32-bit files. is causing gmake[2]: Entering directory `/usr/test/Wine/dlls/kernel32' /files/pfeifer/gcc/bin/gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_KERNEL32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -Wtype-limits -Wpointer-arith -I/usr/local/include -g -O2 -o module.o module.c In file included from module.c:36:0: ../../include/winbase.h:1560:84: error: expected declaration specifiers or '...' before 'va_list' ../../include/winbase.h:1561:85: error: expected declaration specifiers or '...' before 'va_list' In file included from module.c:37:0: ../../include/winternl.h:2223:81: error: expected declaration specifiers or '...' before 'va_list' ../../include/winternl.h:2389:58: error: expected declaration specifiers or '...' before 'va_list' ../../include/winternl.h:2390:75: error: expected declaration specifiers or '...' before 'va_list' over here on my FreeBSD 7.2 tester. Gerald

2 2

WineTestBot changes
by Greg Geldorp Dec. 31, 2009

Dec. 31, 2009

I've completed phase 2 of the testbot: besides (32 and 64 bit) Windows executables you can now also submit patch files to the bot. The bot will apply the patch files to a clean git tree, cross-compile the test and run the test on Windows VMs. You'll also be able to download the cross-compiled test executable to test it on different Windows machines. Ge.

3 2

Re: [PATCH 2/2] d3d10: Parse effect shaders as anonymous shaders.
by Henri Verbeet Dec. 31, 2009

Dec. 31, 2009

2009/12/31 Rico Schüller <kgbricola(a)web.de>: > struct d3d10_effect_shader_variable *s; ... > + v->data = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(struct d3d10_effect_shader_variable)); ... > + s = v->data; I think this would be nicer: s = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*s)); ... v->data = s; That's mostly my fault for writing it like that in the first place, but we might as well fix that. > + default: > + ERR("This should not happen!\n"); > + break; You'll probably want to return E_FAIL here. > + struct d3d10_effect_variable *v = &e->anonymous_shaders[e->anonymous_shader_current]; > + struct d3d10_effect_type *t = &e->anonymous_shader_type[e->anonymous_shader_current]; ... > + hr = parse_fx10_anonymous_shader(o->pass->technique->effect, o->type); ... > + o->data = &o->pass->technique->effect->anonymous_shaders[o->pass->technique->effect->anonymous_shader_current-1]; If you create a structure for anonymous shaders, you can store that in a single array. You can then pass a pointer to that structure to parse_fx10_anonymous_shader(), and handle "anonymous_shader_current" in parse_fx10_object(). E.g.: struct d3d10_effect *effect = o->pass->technique->effect; struct d3d10_effect_anonymous_shader *shader = &effect->anonymous_shaders[effect->anonymous_shader_current]; hr = parse_fx10_anonymous_shader(effect, o->type, shader); if (FAILED(hr)) return hr; ++effect->anonymous_shader_current; o->data = shader; Note that you should also validate that "anonymous_shader_current" < "anonymous_shader_count". The count is supposed to be correct, but the .fx might lie about it, possibly on purpose.

1 0

Re: [PATCH 1/2] d3d10: Add a function to initialize the null variables.
by Henri Verbeet Dec. 31, 2009

Dec. 31, 2009

2009/12/31 Rico Schüller <kgbricola(a)web.de>: > +static struct d3d10_effect_variable null_local_buffer = {0}; > +static struct d3d10_effect_variable null_variable = {0}; > +static struct d3d10_effect_variable null_scalar_variable = {0}; > +static struct d3d10_effect_variable null_vector_variable = {0}; > +static struct d3d10_effect_variable null_matrix_variable = {0}; > +static struct d3d10_effect_variable null_string_variable = {0}; > +static struct d3d10_effect_variable null_shader_resource_variable = {0}; > +static struct d3d10_effect_variable null_render_target_view_variable = {0}; > +static struct d3d10_effect_variable null_depth_stencil_view_variable = {0}; > +static struct d3d10_effect_variable null_shader_variable = {0}; > +static struct d3d10_effect_variable null_blend_variable = {0}; > +static struct d3d10_effect_variable null_depth_stencil_variable = {0}; > +static struct d3d10_effect_variable null_rasterizer_variable = {0}; > +static struct d3d10_effect_variable null_sampler_variable = {0}; This doesn't hurt (much), but since a lot of people seem to be unaware of this I think it's worth mentioning again. Global variables as well as static (local) variables are initialized to 0 / NULL by default. The way this works in the language spec is that objects with static storage duration (i.e. the entire lifetime of the program/module) are initialized to 0 / NULL unless explicitly initialized. In practice that means global and static variables (but note that static on a global variable or function has a different meaning from static on a local variable). > +static void d3d10_null_effect_variable_init(struct d3d10_effect_variable *v, struct ID3D10EffectVariableVtbl *vtbl) > +{ > + v->vtbl = vtbl; > + v->buffer = &null_local_buffer; > + v->effect = NULL; > + v->name = NULL; > + v->semantic = NULL; > + v->buffer_offset = 0; > + v->annotation_count = 0; > + v->flag = 0; > + v->data_size = 0; > + v->type = &null_type; > + v->elements = NULL; > + v->members = NULL; > + v->annotations = NULL; > +} Most of these are redundant, since the variable will be already initialized with zeroes.

1 0

Tango Icons (Almost) Ready to Go!!
by Joel Holdsworth Dec. 31, 2009

Dec. 31, 2009

Hi All, I'm pleased to announce that after a lot of work lately I've pretty much completed the graphics for the icons for shell32, user32 and the programs all sizes and screen depths: http://www.airwebreathe.org.uk/wine-icon/ There are a few minor things left to do: * comctl32: Finish and submit - only idb_std_small.bmp needs to be upgraded. Only idb_std_small.bmp is 32-bit in XP, and Vista * comdlg32: Convert bitmaps to 8-bit. Maybe rework comdlg32 so that the graphics are stored as a icons not bitmaps for so that different colour depths can be handled elegantly. What does windows do? * credui: Test on a low bit-depth platform, and submit. * cryptui: Redo emblems on certwarning.bmp, certerror.bmp, and convert bitmaps into icons for so that different colour depths can be handled elegantly. * winecfg: new transparent bitmap won't work without xrender on a 32-bpp screen. Think again. * wine: image lists still strip the alpha channel. talk to thunderbird about 32-bit DDBs * control, dxdiag, iexplore, winecfg: These programs currently do not have an icon, and although my patches add the icon to the src dir, further patches will be needed to add the icon to the progam's resources, and display them in the app windows. These things are all relatively minor, and I think at this stage it would be good to merge as soon as possible. The only major issue that remains is that there are 3 icons from Gnome that need to be relicensed as LGPL for our use. I've e-mailed the gnome artists mailing list, so hopefully we'll hear back from them soon. Once this is done I'm suggesting we merge the icons for shell32, user32 and the programs. If you're interested you can try them right now at the public-beta-2 branch of my gitorious repo: http://gitorious.org/wine-tango/wine-tango/commits/public-beta-2 My final question is about what to do with my source artwork. The artwork has been collected from a variety of sources. Some is SVGs, some gimp .xcf.bz2s, and some plain PNGs. I guess these shouldn't go into the wine source repo, but does anyone have any bright ideas where these files *should* go? They'll need to be published in case the icons ever need to be changed in any way. Any thoughts? Best Regards Joel

3 3

Re: [3/4] jscript: Fix various memory and reference count leaks.
by Jacek Caban Dec. 31, 2009

Dec. 31, 2009

Hi Rob, Thanks for your work on jscript. Unfortunately fixing Valgrind on jscript is not going to be easy. Most of your fixes are good, except clear_global part and "jscript: Fix a circular reference caused by object and function objects being able to have properties that are objects and functions." patch. I've sent a test showing that Windows doesn't do that. To fix it properly we need to implement a garbage collector. I've designed it in the very early days of jscript, but I never had time to implement it. Thanks, Jacek

2 2

Re: Tango Icons (Almost) Ready to Go!!
by Joel Holdsworth Dec. 31, 2009

Dec. 31, 2009

On Thu, 2009-12-31 at 10:20 +0100, Warren Dumortier wrote: > Thanks for all your work (is there some screenshot)? > There's no doubt that the Tango icons are good, but would it be > possible to easily make icon themes maybe, to have Oxygen icons for > example? If i understand it's hardcoded, like on Windows, but making a > theming feature is probably a lot of work right? There will be some theming work coming later when someone finishes implementing the uxtheme stuff. My icons are about getting a base theme that works well. The point of Tango is that it shouldn't look to badly out of place on Mac, KDE, Gnome or even Windows. That's a good starting point, which we can build upon if someone can implement a wine theme bridge.

1 0

Re: [PATCH] hlink/tests: Repair test to work as intended
by Paul Vriens Dec. 31, 2009

Dec. 31, 2009

On 12/29/2009 12:40 AM, Andrew Eikum wrote: > > Paul Vriens 'fixed' this test to ensure that two strings are not the > same. Instead, the test should test that two strings _are_ the same, > but I accidentally compared the wrong strings in the original version. > --- > dlls/hlink/tests/browse_ctx.c | 19 +++++++++++-------- > 1 files changed, 11 insertions(+), 8 deletions(-) > > Hi Andrew, Sorry about that. Thanks for really fixing it this time. -- Cheers, Paul.

2 1

Re: [2/3] kernel32: Generate the CommonProgramFiles and ProgramFiles environment variables.
by Alexandre Julliard Dec. 31, 2009

Dec. 31, 2009

Andrew Nguyen <arethusa26(a)gmail.com> writes: > Some experimentation showed that the registry values that are read do > control the CommonProgramFiles and ProgramFiles environment variables. Is there any reason to not define it like the other environment variables? Is there really an app that would change the CurrentVersion key and expect the environment variable to change? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] kernel32: Generate the CommonProgramFiles and ProgramFiles environment variables.
by Nikolay Sivov Dec. 31, 2009

Dec. 31, 2009

On 12/31/2009 05:47, Andrew Nguyen wrote: > Some experimentation showed that the registry values that are read do > control the CommonProgramFiles and ProgramFiles environment variables. > --- > dlls/kernel32/process.c | 27 ++++++++++++++++++++++++++- > 1 files changed, 26 insertions(+), 1 deletions(-) > Hi, Andrew. Alexandre recently removed 16bit headers inclusion, I don't think you should revert this.

1 0

Re: Acting as advisor for wcmd-uplift project?
by Dan Kegel Dec. 31, 2009

Dec. 31, 2009

Peter Dons Tychen wrote: > Why not place the test in the source tree along with all of > the other tests. Of course this requires the tests to be run from a C > based file Yep. I should have a patch ready to submit tomorrow that is a barebones batch file test driver written in C suitable for use with winetestbot. > It would however mean that one could add tests for all of the > other command line utility programs much easier > (not possible now at all). Good point. The cmd tests can test not just cmd, but things like expand and extrac32, too. So, where should the tests live? I had been thinking programs/cmd/tests, but maybe something like programs/tests would be better given that it can test more than just cmd. - Dan

10 18

Wine prefix creation status
by Erich Hoover Dec. 30, 2009

Dec. 30, 2009

I recently installed the bundled Wine for Mac OS X for someone and noticed something that would be nice for "normal Wine." In the bundled Mac OS X version a progress dialog* is displayed when prefix creation is occurring, are there any plans to do something like this for Wine 1.2? Erich Hoover ehoover(a)mines.edu *Note that this dialog doesn't show "real" progress, but at least lets the user know something is happening.

1 0

Re: CPPCheck Dec 29
by chris ahrendt Dec. 30, 2009

Dec. 30, 2009

On 12/29/2009 11:17 PM, Alasdair Sinclair wrote: > > return size; ok will file a false positive... thanks chris

1 0

Removing WPARAM/LPARAM Casts
by James Mckenzie Dec. 30, 2009

Dec. 30, 2009

I've noticed that Michael Stefuic (sp?) has removed quite a few WPARAM/LPARAM casts when calling SendMessage() and was wondering/inquiring if he was going do this to riched20/tests/editor.c since I noticed he put in a change for riched20. Michael are you going to do so, or are you going to leave this to others? Thank you. James McKenzie

2 3

Re: [PATCH 2/2] user32/uitools: Fix FillRect behaviour for invalid brush passed
by Alexandre Julliard Dec. 30, 2009

Dec. 30, 2009

Nikolay Sivov <bunglehead(a)gmail.com> writes: > diff --git a/dlls/user32/tests/Makefile.in b/dlls/user32/tests/Makefile.in > index 102653f..4f4e812 100644 > --- a/dlls/user32/tests/Makefile.in > +++ b/dlls/user32/tests/Makefile.in > @@ -19,6 +19,7 @@ CTESTS = \ > input.c \ > listbox.c \ > menu.c \ > + misc.c \ > monitor.c \ > msg.c \ > resource.c \ Names like misc.c should be avoided. Something like uitools.c would be preferable, particularly since that's where the tested function resides in user32. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: wined3d: Added further Nvidia Geforce 8xxx detection.
by Roderick Colenbrander Dec. 30, 2009

Dec. 30, 2009

Since we group cards, there is no need to add a lot of extra PCI ids. On Wed, Dec 30, 2009 at 1:02 PM, Aaron Brazener <rnbrznr(a)googlemail.com> wrote: > The attached patch is to add the missing PCI device information for > the Nvidia 8xxx series of cards. > > > >

1 0

CPPCheck Dec 29
by chris ahrendt Dec. 30, 2009

Dec. 30, 2009

I just ran CPP check this evening and got the following : rpcrt4/rpc_transport.c 490 (error) Uninitialized variable smb_floor 761 (error) Uninitialized variable pipe_floor 885 (error) Uninitialized variable tcp_floor If you look at the code : static size_t rpcrt4_ncacn_np_get_top_of_tower(unsigned char *tower_data, const char *networkaddr, const char *endpoint) { twr_empty_floor_t *smb_floor; twr_empty_floor_t *nb_floor; size_t size; size_t networkaddr_size; size_t endpoint_size; TRACE("(%p, %s, %s)\n", tower_data, networkaddr, endpoint); networkaddr_size = networkaddr ? strlen(networkaddr) + 1 : 1; endpoint_size = endpoint ? strlen(endpoint) + 1 : 1; size = sizeof(*smb_floor) + endpoint_size + sizeof(*nb_floor) + networkaddr_size; if (!tower_data) return size; It is correct in that these three are not initialised and could point to anything on the local stack. Additionally if you look above you can get potentially a bogus return.. Additionally for tcp_floor: static size_t rpcrt4_ip_tcp_get_top_of_tower(unsigned char *tower_data, const char *networkaddr, unsigned char tcp_protid, const char *endpoint) { twr_tcp_floor_t *tcp_floor; twr_ipv4_floor_t *ipv4_floor; struct addrinfo *ai; struct addrinfo hints; int ret; size_t size = sizeof(*tcp_floor) + sizeof(*ipv4_floor); TRACE("(%p, %s, %s)\n", tower_data, networkaddr, endpoint); if (!tower_data) return size; Same problem here as well Chris

2 1

Re: [3/4] d3dx9: Implement D3DXAssembleShader function, really basic shader assembler.
by Henri Verbeet Dec. 29, 2009

Dec. 29, 2009

2009/12/28 Matteo Bruni <matteo.mystral(a)gmail.com>: > Why do you need the fake parser? Can't you just not support those shader versions yet? There's also (in general) not much of a point in adding structure fields that aren't used yet. > +/* This file needs the original d3d9 definitions. The bwriter ones > + * aren't useable because they are wine-internal things. We're writing > + * d3d8/9 shaders here, so we need the d3d9 definitions (which are > + * equal to the d3d8 ones) > + */ This doesn't seem to match what the code actually does. > +/* Debug utility routines. Some are not reentrant, check asmutils.c */ Same as above. > +const char *debug_print_dstreg(const struct shader_reg *reg, shader_type st) { > + return wine_dbg_sprintf("%s", get_regname(reg, st)); > +} > + > +const char *debug_print_srcreg(const struct shader_reg *reg, shader_type st) { > + switch(reg->srcmod) { > + case BWRITERSPSM_NONE: > + return wine_dbg_sprintf("%s", get_regname(reg, st)); > + } > + return "Unknown modifier"; > +} "return get_regname(reg, st);" should work at least as well. > +/* Mutex used to guarantee a single invocation > + of the D3DXAssembleShader function (or its variants) at a time. > + This is needed as wpp isn't thread-safe */ > +extern CRITICAL_SECTION wpp_mutex; It's probably easier to just statically initialize the critical section in shader.c. As for splitting things up, I think it's ok to e.g. add the pre-processor first, and just return E_NOTIMPL from assemble_shader().

2 3

Linux Gaming: Are We There Yet?
by Jaime Rave Dec. 29, 2009

Dec. 29, 2009

Excelent review from the guys in AnandTech of the current status of gaming in Linux, they have tested Wine vs CrossOver Games vs Cedega vs Windows 7 and the results are quite good. http://www.anandtech.com/linux/showdoc.aspx?i=3700 -- Jaime Rave Torres Ingeniero de Sistemas Miembro de la Fundación de Software Libre de Colombia http://www.fslcol.org/ http://sobrelibertad.blogspot.com/ 3003160361

1 0

Re: dbghelp: Make sure the ClientPointers flag is set correctly
by Henri Verbeet Dec. 29, 2009

Dec. 29, 2009

2009/12/29 Jason Green <jave27(a)gmail.com>: > commit 317da09400946ca9f97361a47a227595c5bedfe3 > Author: Eric van Beurden <ericvb(a)transgaming.com> > Date: Tue Dec 29 12:35:03 2009 -0500 > > Make sure the ClientPointers flag isn't set incorrectly Mostly out of curiosity, how did you generate this patch? That looks like the kind of output git log gives, not git format-patch.

2 2

Re: [3/4] d3dx9: Implement D3DXAssembleShader function, really basic shader assembler.
by Alexandre Julliard Dec. 29, 2009

Dec. 29, 2009

Matteo Bruni <matteo.mystral(a)gmail.com> writes: > + > +%option reentrant bison-bridge These won't work on old flex versions, and will get you in trouble with the flex police (aka Michael Stefaniuc ;-) -- Alexandre Julliard julliard(a)winehq.org

3 2

Guide for creating new AppInstall tests
by Sam S. Dec. 29, 2009

Dec. 29, 2009

Hello Wine team! After reading the introduction to AppInstall at http://www.winehq.org/wwn/360, I decided to try and write some additional application tests for it. There are at least two freely downloadable win32 apps that I run with Wine, that have in the past (in my experience) been quite sensitive to small improvements/regressions in certain areas of wine (gecko engine and opengl, namely), so having them automatically tested daily could be useful... Unfortunately, however, the wiki page (http://wiki.winehq.org/Appinstall) doesn't really provide a guide for how to go about doing this... It explains the text that will need to be put in the actual test script (which I could have also figured out by looking at the well-documented example scripts), but almost nothing about how you need to set up your working environment, what files to put where, which commands to call, etc, for the purpose of writing/testing a new AppInstall script from scratch. In absence of such a guide, I just downloaded the whole http://winezeug.googlecode.com/svn/trunk/appinstall directory, copied it into a Windows XP environment (because according to the WWN article, you're supposed to write the tests on Windows), and started by duplicating one of the example files. However, when I open a Command Prompt window and try to run one of the .ahk files with AutoHotKey, nothing really happens - all I see is some additional Command Prompt windows popping up for a split second and disappearing again, and then the command returns - nothing downloaded, no output, no error messages, nothing. (Btw, I don't even understand where the dowloads specified in the scripts are supposed to end up...) How am I supposed to do this? More generally: Could someone who knows how to do this maybe put up a step-by-step guide for users who want to contibute by writing new AppInstall tests, with no prior knowledge? Possibly something along the lines of: - what/how do download - on Windows: what files to put where / how to set up the environment - on Windows: how to create a new test-script / where to put it - on Windows: how to get all those checksums - on Windows: how to properly test-run/debug the new script - on Linux+Wine: what files to put where / how to set up the environment - on Linux+Wine: how to test-run the new script previously created on Windows - where to upload/send finished test-scripts to Thanks! Sam PS: When will there be a new WWN?

2 3

Building and packaging Wine Gecko
by Anssi Hannula Dec. 29, 2009

Dec. 29, 2009

Hi all! I see that Wine has recently started to always request installation of Gecko, and that it is recommended to use a distribution provided package. We do not yet provide a wine-gecko package in Mandriva, but we'd like to. According to our policy (and the policy of e.g. Debian, Fedora) everything in our main repositories has to be compiled by us without external binaries compiled by a third party. I noticed there are build instructions here: http://wiki.winehq.org/BuildingWineGecko However, the instructions on that page ask for copying binaries directly provided in wine-mozilla tarball, and for modifying mingw32 headers. These actions are rather unacceptable for us (I guess the latter one is workaroundable, though). I saw that http://wiki.winehq.org/Gecko says Gentoo and openSUSE package Gecko properly. I looked at the Gentoo package [1] and saw that they simply download the prebuilt cab, which we can't do. I took a look in openSUSE src.rpm [2], but found no references to Gecko, and I didn't see any separate wine-gecko src.rpm there. I did found wine-gecko OpenSUSE binary packages in Wine's SourceForge page, but no source packages or information on how it was built. Is it really not possible to build Wine Gecko from the source code, on command line, on Linux? Or is it just that nobody has written any instructions on how to do that? [1] http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-emulation/wine/wine-1.1… [2] http://download.opensuse.org/factory/repo/src-oss/suse/src/wine-1.1.28-3.4.… -- Anssi Hannula Mandriva packager

10 24

Re: dlls/user32/combo.c: Fix an issue where pressing 's' in a combobox shows the dropdown isntead of finding an entry starting with 's'.
by Dmitry Timoshkov Dec. 29, 2009

Dec. 29, 2009

"David Quintana (gigaherz)" <gigaherz(a)gmail.com> wrote: > Issue was caused by VK_F4 having the same exact code as a lowercase 's'. > So the code, which treated WM_CHAR and WM_KEYDOWN as the same, executed > the wrong piece of code which was meant to be ONLY for WM_KEYDOWN. Thanks for spotting this bug. Anyway the fix is not correct. Virtual key codes should be tested only in the WM_KEYDOWN handler, WM_CHAR handler should test for character codes. Also, as Nikolay asked please don't use C++ comments in Wine code. -- Dmitry.

2 1

Difficulty fixing a regression in reading text files with MSVCRT
by Erich Hoover Dec. 29, 2009

Dec. 29, 2009

In a surprise last-minute request it became necessary for me to get Athena Visual Studio running under Wine again (http://appdb.winehq.org/objectManager.php?sClass=version&iId=15183) A couple of commits to MSVCRT (that are needed for other reasons) caused regressions in Wine's ability to run this application and I am having a lot of difficulty getting Athena working again. The commits that revealed the problem are: ebe4a9e321800fbe6d2004a640cd276a28d15c38: Remove CRs earlier in ascii mode. 7f3c70c52fe470d431a51b3363ed4f7336d5f7f5: Remove CRs earlier in ascii mode in fseek, too. After tracing down a lot of rabbit holes, it appears that the problem is somehow related to how the buffer boundary influences the file position reported by ftell. I've attached a test case that appears related to the issue. I can use a native MSVCRT for now, but I would appreciate some assistance so that this issue can be properly resolved at some point. Erich Hoover ehoover(a)mines.edu

2 1

Re: dlls/user32/combo.c: Fix an issue where pressing 's' in a combobox shows the dropdown isntead of finding an entry starting with 's'.
by Nikolay Sivov Dec. 28, 2009

Dec. 28, 2009

On 12/28/2009 22:18, David Quintana (gigaherz) wrote: > Issue was caused by VK_F4 having the same exact code as a lowercase 's'. > So the code, which treated WM_CHAR and WM_KEYDOWN as the same, executed > the wrong piece of code which was meant to be ONLY for WM_KEYDOWN. > > Patch is attached. > > > > Please resubmit without cpp style comments.

1 0

Re: [PATCH 3/5] wined3d: Introduce "context_apply_state()" to setup a context for a specific usage.
by Stefan Dösinger Dec. 28, 2009

Dec. 28, 2009

Am 27.12.2009 um 19:57 schrieb Henri Verbeet: > +/* Context activation is done by the caller. */ > +static void context_apply_state(struct wined3d_context *context, IWineD3DDeviceImpl *device, enum ContextUsage usage) The patch looks ok to me, but out of curiosity: Do you intend to make this function available to other wined3d code like context_acquire is, or is the main motivation of the patch to tidy up the context_acquire() function?

2 2

Remove Macintosh platform
by Austin English Dec. 28, 2009

Dec. 28, 2009

I just moved the last macintosh platforms to ppc32/x86, so can someone with the appropriate permissions remove that option. Thanks! -Austin

2 3

Re: [PATCH 1/3] wininet: Test also InternetCrackUrlW in test_crack_url.
by Paul Vriens Dec. 28, 2009

Dec. 28, 2009

On 12/27/2009 01:27 AM, Jacek Caban wrote: > --- > dlls/wininet/tests/url.c | 77 > ++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 77 insertions(+), 0 deletions(-) > Hi Jacek, Looks like these tests need at least IE7 to succeed. Could you have a look? -- Cheers, Paul.

1 0

Defining missing DirectInput constants
by Javier Kohen Dec. 28, 2009

Dec. 28, 2009

Hi, I'm implementing DInput's SetActionFormat call. I need to add the DInput Action Mapping Constants to Wine's dinput.h so I can map between the user requested action and the DIJOFS_* Joystick Device Constants. Is it OK to copy constant definitions from Microsoft's SDK? If not, can somebody help me or give some pointers on how to figure them out? This API call is needed at least for the Overlord game, which now works with my XBox 360 gamepad, but all action mappings are currently wrong. Thanks,

2 1

Re: [PATCH 2/3] wininet: Always set lpszUrlPath in InternetCrackUrlW.
by Alexandre Julliard Dec. 28, 2009

Dec. 28, 2009

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/wininet/internet.c | 38 +++++++++++++------------------------- > 1 files changed, 13 insertions(+), 25 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so internet.c && touch internet.ok wine: Unhandled page fault on read access to 0x00000000 at address 0x68699521 (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x68699521). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:68699521 ESP:0032d180 EBP:0032d1f8 EFLAGS:00010297( R- -- I S -A-P-C) EAX:cbcd24a4 EBX:686b1894 ECX:3432db62 EDX:6865b6c4 ESI:00000000 EDI:00000000 Stack dump: 0x0032d180: 00000000 00000000 00000000 00000000 0x0032d190: 00000000 00000000 00000000 00000000 0x0032d1a0: 00000000 00000000 00000000 0000000c 0x0032d1b0: 00000000 00000000 6865b6b8 00000000 0x0032d1c0: 00000006 00000000 00000000 00000000 0x0032d1d0: 00000000 00000000 00000000 00000000 Backtrace: =>0 0x68699521 InternetCrackUrlW+0x3c1(lpszUrl_orig=0x6865b6b8, dwUrlLength_orig=6, dwFlags=0, lpUC=0x32fb44) [/home/julliard/wine/wine/dlls/wininet/../../include/wine/unicode.h:311] in wininet (0x0032d1f8) 1 0x6869cd2c INTERNET_InternetOpenUrlW+0xec(hIC=0x148d18, lpszUrl=<register EDI not in topmost frame>, lpszHeaders=(nil), dwHeadersLength=0, dwFlags=0, dwContext=0) [/home/julliard/wine/wine/dlls/wininet/internet.c:2846] in wininet (0x0032fb98) 2 0x6869d34e InternetOpenUrlW+0x10e(hInternet=0x1, lpszUrl=<register EDI not in topmost frame>, lpszHeaders=(nil), dwHeadersLength=0, dwFlags=0, dwContext=0) [/home/julliard/wine/wine/dlls/wininet/internet.c:2990] in wininet (0x0032fbf8) 3 0x6864d4f3 test_null+0x3f3() [/home/julliard/wine/wine/dlls/wininet/tests/internet.c:400] in wininet_test (0x0032fca8) 4 0x6864f71b func_internet+0xbab() [/home/julliard/wine/wine/dlls/wininet/tests/internet.c:850] in wininet_test (0x0032fd98) 5 0x686560c0 run_test+0x130(name="internet.c") [/home/julliard/wine/wine/dlls/wininet/tests/../../../include/wine/test.h:537] in wininet_test (0x0032fdd8) 6 0x686562ae main+0x11e(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/wininet/tests/../../../include/wine/test.h:586] in wininet_test (0x0032fe88) 7 0x68656d34 __wine_spec_exe_entry+0x84(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in wininet_test (0x0032feb8) 8 0x7b8769d5 start_process+0x55(peb=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1038] in kernel32 (0x0032fee8) 9 0x7bc6f9e4 call_thread_func+0xc() in ntdll (0x0032fef8) 10 0x7bc6fbc0 call_thread_entry_point+0x70(entry=0x7b876980, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2391] in ntdll (0x0032ffc8) 11 0x7bc4cd5a in ntdll (+0x3cd5a) (0x0032ffe8) 0x68699521 InternetCrackUrlW+0x3c1 [/home/julliard/wine/wine/dlls/wininet/../../include/wine/unicode.h:311] in wininet: cmpw $10,0x0(%edi) 311 for (end = ptr + n; ptr < end; ptr++) if (*ptr == ch) return (WCHAR *)(ULONG_PTR)ptr; -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [TRY 2] extrac32: Create directory tree before extraction
by Ilya Shpigor Dec. 28, 2009

Dec. 28, 2009

Hi, Why this patch don't have been commited? There are mistakes? I really want to make extrac32 better, but I don't know what to do if nobody answer me. -- Best regards, Ilya Shpigor.

1 0

Re: Remove cpp_quote hackery from wined3d.idl (was: tools/widl: Split expr_int_const off from expr)
by Henri Verbeet Dec. 28, 2009

Dec. 28, 2009

2009/12/24 Gerald Pfeifer <gerald(a)pfeifer.com>: > On Mon, 21 Dec 2009, Henri Verbeet wrote: >>> How shall we best tackle this? >> At least for the wined3d ones, we might as well just add them to the >> enum, the macros aren't strictly necessary. > > Done thusly. We just need to move WINEMAKEFOURCC to a local header, > the rest of the cpp_quote can go and we lose a couple of dozen warning > messages (rightfully) issued by GCC 4.5 snapshots. > I already sent pretty much the same patch, http://source.winehq.org/git/wine.git/?a=commitdiff;h=3288911ae3e3cbd7124ed…

2 2

Re: msvcrt: add some demangle features
by Eric Pouech Dec. 28, 2009

Dec. 28, 2009

André Hentschel a écrit : > - > + if (*sym->current == 'A') sym->current++; > I don't understand how this would be necessary? Are you sure it's needed ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 2

Re: wined3d: adjust glPolygonOffset size
by Henri Verbeet Dec. 27, 2009

Dec. 27, 2009

2009/12/27 Austin English <austinenglish(a)gmail.com>: > See bug 18993. Original author is credited in patch ( Dorek Biglari ). > This doesn't look right from my understanding of the d3d9 depth bias behaviour. Afaik D3DRS_SLOPESCALEDEPTHBIAS is a multiplication factor for the maximum depth slope (i.e. difference in z-value over distance for a polygon's vertices), just like in OpenGL. I attached an alternative patch to the bug.

1 0

Re: qedit: Implement partially the Sample Grabber filter
by Rob Shearman Dec. 26, 2009

Dec. 26, 2009

2009/12/23 Paul Chitescu <paulc(a)voip.null.ro>: > Changelog: > qedit: Implement partially the Sample Grabber filter > > The IMediaPosition, IMediaSeeking and IQualityControl interfaces are currently > not implemented at all. No programs I've tested tried to query them though. > > Buffering of samples is also not implemented yet, applications usually install > an ISampleGrabberCB callback. Thread-safety is non-existent in your newly written code. DirectShow uses multiple threads so I would say thread-safety is a requirement, not a nice-to-have. -- Rob Shearman

1 0

Re: Acting as advisor for wcmd-uplift project?
by Peter Dons Tychsen Dec. 25, 2009

Dec. 25, 2009

On Tue, 2009-12-22 at 15:36 -0600, Austin English wrote: > Sure. FWIW, I'm working on some AutoHotKey/Appinstall tests for cmd, > but it's a bit difficult, since the only way to capture the stdout is > to pipe it to a file first. Hey, i think a test suite for cmd is an excellent idea, and is surely what is needed to lift the quality of this module. However, i think using AutoHotKey in an external script might not be the optimal solution. Why not place the test in the source tree along with all of the other tests. Of course this requires the tests to be run from a C based file and not a AHK file, as i doubt that AJ wants AHK in git. It would however mean that one could add tests for all of the other command line utility programs much easier (not possible now at all). I don't really see "cmd" as an external tool but and integrated part of the Wine product. Therefore i think these tests belong in the main git tree. In any case, tests are better than no tests! (just to state the obvious :-)) /pedro

2 1

Re: [3/5] WineD3D: Set WINED3D_BUFFER_CREATEBO in buffer_init
by Henri Verbeet Dec. 24, 2009

Dec. 24, 2009

2009/12/22 Stefan Dösinger <stefan(a)codeweavers.com>: > + conv = ((FVF & WINED3DFVF_POSITION_MASK) == WINED3DFVF_XYZRHW ) || (FVF & (WINED3DFVF_DIFFUSE | WINED3DFVF_SPECULAR)); > hr = buffer_init(object, This, Size, Usage, WINED3DFMT_VERTEXDATA, > - Pool, GL_ARRAY_BUFFER_ARB, NULL, parent, parent_ops); > + Pool, GL_ARRAY_BUFFER_ARB, NULL, parent, parent_ops, conv); This looks questionable, we use the FVF to determine that the buffer is going to need conversion, but don't pass that FVF to the buffer itself? Shouldn't this just use the existing code in buffer.c to determine when we need conversion in the first place, and just drop the VBO when the overhead becomes too large? Note that if we have EXT_vertex_array_bgra we don't need conversion for the color data in the first place.

3 3

Re: [PATCH 2/5] wined3d: Focus the focus window.
by Stefan Dösinger Dec. 24, 2009

Dec. 24, 2009

Am 22.12.2009 um 18:32 schrieb Henri Verbeet: > + SetFocus(This->focus_window); > + Is this correct for windowed rendering as well?

2 1

Re: [winspool 2/6] Move the dlopen of libcups to a separate function, allowing CUPS to be used prior to the full on loading of CUPS printers.
by Detlef Riekenberg Dec. 24, 2009

Dec. 24, 2009

Hi Jeremy What is your reason for your work in winspool.drv? What are your plans? Even if the Patchset changes some things, it's not the correct location to do that. winspool.drv must not do anything with the registry or the driver files. winspool.drv must not use cups at all wineps.drv must not use cups at all That all belong to a print provider, together with a print monitor. To make our live easy, the printprovider and printmonitor for CUPS and LPR will be integrated into localspl.dll (windows is using seperate provider/monitor: See inetpp.dll and lprmon.dll with friends) I have a Patch here for moving AddPrinter to localspl, that address most of your changes, but a small peace of code is only in my test app and not in the Patch yet (get default DEVMODEW from the Driver) An important issue is, that we store DEVMODEA in the registry. Code is there to handle that, bu it failed on julliards machine. My localspl.dll has a cups.c, but that need more work(i can't continue before mid januar). And IMHO, using wine_get_unix_file_name in High-level dlls is wrong by design. W2k pro and XP pro have driver directories only for supported environments. (Servers are different) When you think, that you need the driver directories, they can be created with wine.inf Please avoid ANSI strings in new code. (strdupWtoA should go away) -- By by ... Detlef ___________________________________________________________ Preisknaller: WEB.DE DSL Flatrate für nur 16,99 Euro/mtl.! http://produkte.web.de/go/02/

3 2

Re: gdiplus: Add stub for GdipIsVisibleClipEmpty
by Alexandre Julliard Dec. 24, 2009

Dec. 24, 2009

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Changelog: > gdiplus: Add stub for GdipIsVisibleClipEmpty You might as well implement it right away, it should be fairly trivial. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] wineboot: Generate the HKCU\Volatile Environment registry key.
by Alexandre Julliard Dec. 24, 2009

Dec. 24, 2009

Andrew Nguyen <arethusa26(a)gmail.com> writes: > @@ -453,7 +453,6 @@ HKLM,Software\Microsoft\DirectPlay\Service Providers\Serial Connection For Direc > HKLM,Software\Microsoft\DirectPlay\Service Providers\Serial Connection For DirectPlay,"Path",,"dpmodemx.dll" > > [Environment] > -HKLM,System\CurrentControlSet\Control\Session Manager\Environment,"APPDATA",,"%16410%" > HKLM,System\CurrentControlSet\Control\Session Manager\Environment,"ComSpec",0x00020000,"%11%\cmd.exe" > HKLM,System\CurrentControlSet\Control\Session Manager\Environment,"LOCALAPPDATA",,"%16412%" > HKLM,System\CurrentControlSet\Control\Session Manager\Environment,"PATH",0x00020002,"%11%;%10%;%11%\wbem" Looks good, but you should do the same thing for LOCALAPPDATA. -- Alexandre Julliard julliard(a)winehq.org

1 0

<kein Betreff>
by Detlef Riekenberg Dec. 24, 2009

Dec. 24, 2009

___________________________________________________________ Preisknaller: WEB.DE DSL Flatrate für nur 16,99 Euro/mtl.! http://produkte.web.de/go/02/

1 0

Re: [PATCH 1/2] comctl32/updown: Don't update buddy text if it's the same.
by Paul Vriens Dec. 24, 2009

Dec. 24, 2009

On 12/22/2009 10:43 PM, Nikolay Sivov wrote: > Don't update buddy text if it's the same. > > There's at least one application that depends on this behavior: > http://bugs.winehq.org/show_bug.cgi?id=18574 > > This bug is closed cause crash no longer occurs in 1.1.35 due > a regression it contains, the real problem is fixed by this patch. Hi Nikolay, This one introduces a test failure on NT4 but I guess it's due to comctl32 4.72 and not the OS. NT4/4.72 sends a WM_SETTEXT instead of WM_GETTEXT (just tested, it's the only message). Could you have a look? The NT4 boxes at winetestbot.geldorp.nl have this issue. -- Cheers, Paul.

2 4

Re: [PATCH] Replace builtin WineFile Execute Dialog with standard RunFileDialog
by Dmitry Timoshkov Dec. 24, 2009

Dec. 24, 2009

"Steven Edwards" <winehacker(a)gmail.com> wrote: > - Removed the LoadLibrary calls in favor of GetModuleHandle as suggested > by Paul Vriens > - Match the bad formating of the rest of the file Avoiding a needless renaming of ID_EXECUTE to ID_RUN would make the patch much smaller. Also avoiding useless typedef, making WineFile_OnRun() static, using correct casts, avoiding hungarian notation and magic flags would make the patch slightly cleaner. -- Dmitry.

2 1

Re: winefile - replace Run/Execute dialog with standard Shell32 RunFileDlg
by Paul Vriens Dec. 23, 2009

Dec. 23, 2009

On 12/23/2009 07:08 PM, Steven Edwards wrote: > + hShell32 = LoadLibraryW(wszShell32); Isn't shell32 already available (it's imported, see Makefile.in)? If so a GetModuleHandleW() would suffice. -- Cheers, Paul.

2 1

trivial cmd test suite
by Dan Kegel Dec. 23, 2009

Dec. 23, 2009

http://kegel.com/wine/sweng/2010/#tests now points to a trivial test suite for cmd that is currently driven by a shell script (so on windows you need to install cygwin). Later I'll replace the shell script with a C program that bundles the test data into the executable to allow its use in WineTestBot and winetest. (I'm away from my office, so I haven't tested it on Wine yet.) Austin also has a small test for cmd in http://code.google.com/p/winezeug/source/browse/trunk/appinstall/scripts/cm… The main difference between the two is that people writing tests have to do lots of escaping in Austin's (because his test data is inline in the script) but not in mine (because test data is stored in external files during authoring; it will be packed into the executable later when I translate this into C). - Dan

1 0

Patch for mmdevapi/tests/dependency.c
by Paul Vriens Dec. 23, 2009

Dec. 23, 2009

Hi Maarten, Your patch to fix the test failure for boxes with no soundcard was not committed (yet?). Would the following patch be ok? It also includes more cleanup. -- Cheers, Paul.

1 0

Parser for cmd language?
by Dan Kegel Dec. 23, 2009

Dec. 23, 2009

There are lots of bugs filed for little (or big) problems in wine's cmd that involve parsing the command language: 21047 cmd does not handle for %%a in ('command') 21046 cmd does not handle all operators in 'if' command 20161 cmd can't handle echo commands containing quotes and redirection 19784 cmd doesn't handle ( ) scoping; breaks firefox build 18712 cmd: "if defined ... " command crashes. 18407 cmd.exe: set command seems broken 18346 cmd does not support the "^" escape character 18057 cmd.exe: mishandled quoted built-in commands with parameters (programs/cmd/wcmdmain.c: has_space==1 && opt_s==0) 15359 cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build. The existing parser in cmd is pretty weak. I wonder if it might not be time to write a new parser -- either using some parser generator tool, or more likely, a plain old recursive descent parser -- that can handle the language better. Also, some of the builtins need to be split out into separate executables, see e.g. 18059 - Unity Indie Trial exits because attrib.exe is missing (which might relax the requirements on the parser inside cmd slightly)

5 21

Re: [1/5] WineD3D: Revert the GL usage confusion
by Roderick Colenbrander Dec. 23, 2009

Dec. 23, 2009

On Tue, Dec 22, 2009 at 4:51 PM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > We had a discussion in wine-devel a few days ago about which GL usage is better. The red book also agrees with the GL wiki, but the GL 3.0 spec uses the confusing language the extension used. > > In my performance testing there is no difference, which suggests that this is a rather academic issue, unless you happen to run a game that is exactly hitting your card's bus transfer limits and/or video memory limits, but not the CPU and GPU ALU performance limits. > I'm not convinced the code should be changed back. All docs mention to use DYNAMIC_DRAW. On some implementations there might be a difference. I don't see a reason to change it. Did you get a response on the question you submitted to opengl.org? From what I understood the main difference between STREAM_DRAW and DYNAMIC_DRAW is that in case of dynamic, system memory which can be accessed using DMA is used and else this guarantee isn't given. I would keep it at the value which is correct as indicated by all documentation. If you want to change it, tests should be carried out on different drivers and GPUs OR wait for the feedback from opengl.org/ Roderick

2 2

Re: [2/5] WineD3D: Use unload instead of duplicating buffer remove code
by Henri Verbeet Dec. 23, 2009

Dec. 23, 2009

2009/12/22 Stefan Dösinger <stefan(a)codeweavers.com>: > - HeapFree(GetProcessHeap(), 0, This->conversion_shift); > + IWineD3DBuffer_UnLoad(iface); > + This->flags &= ~WINED3D_BUFFER_CREATEBO; UnLoad() doesn't free "conversion_shift".

2 1

Status check for patches 56770/56772
by Nathan Gallaher Dec. 22, 2009

Dec. 22, 2009

Seeing if there was anything I can do to help either of these patches move along. Don't want them to get lost. ~Nate

2 1

Re: gdiplus: Implement GdipGet/SetStringFormatMeasurableCharacterRanges.
by Vincent Povirk Dec. 22, 2009

Dec. 22, 2009

> + format->character_ranges = GdipAlloc(rangeCount * sizeof(CharacterRange)); > + if (!format->character_ranges) > + return OutOfMemory; > > - return NotImplemented; > + memcpy(format->character_ranges, ranges, sizeof(CharacterRange) * rangeCount); > + format->range_count = rangeCount; > + > + return Ok; > } Won't this leak memory if I set it twice? -- Vincent Povirk

1 0

Re: [2/4] imagehlp/tests: Add tests for adding/removing multiple certificates
by Paul Vriens Dec. 22, 2009

Dec. 22, 2009

On 12/04/2009 05:11 PM, Owen Rudge wrote: > --- > dlls/imagehlp/tests/integrity.c | 68 > +++++++++++++++++++++++++++++++-------- > 1 files changed, 54 insertions(+), 14 deletions(-) > > Hi Owen, This test fails on Win95 but only because the size of the dll is not aligned on a 16byte boundary. Using a different dll on XP for this test (my XP box has 36,921 for imeshare.dll for example) also throws up an error. Would something like this be ok: file_size_orig = get_file_size(); + if (file_size_orig % 16 != 0) + { + trace("We need to adjust the file size\n"); + file_size_orig = ((file_size_orig / 16) + 1) * 16; + } Does anybody know if '16' is indeed the alignment needed? -- Cheers, Paul.

2 3

Re: advapi32/tests: Fix test crash in Wine
by Nikolay Sivov Dec. 22, 2009

Dec. 22, 2009

On 12/22/2009 20:09, Vladimir Pankratov wrote: > Hello all. > > Fixed test crash in Wine. > > changed files: > dlls/advapi32/tests/eventlog.c > > Thanks. Looks like you're hiding a real problem. BTW, I don't see any crashes on Wine in test page. How did you test it?

2 1

Re: [1/2] wininet: Always set last error in HttpSendRequest{,Ex}.
by Paul Vriens Dec. 22, 2009

Dec. 22, 2009

On 12/21/2009 11:13 AM, Hans Leidekker wrote: > + SetLastError(0xdeadbeef); > r = HttpSendRequest(hr, NULL, 0, NULL, 0); > + error = GetLastError(); > ok(r, "HttpSendRequest failed\n"); > + ok(error == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %u\n", error); Hi Hans, This one introduces 5 (sometimes extra) failures on Win98/WinMe: http://test.winehq.org/data/tests/wininet:http.html Not all test_basic_request() fail btw: test_basic_request(si.port, "GET", "/test1"); /* FAILS */ test_basic_request(si.port, "POST", "/test5"); /* FAILS */ test_basic_request(si.port, "RPC_IN_DATA", "/test5"); /* SUCCEEDS */ test_basic_request(si.port, "RPC_OUT_DATA", "/test5"); /* SUCCEEDS */ test_basic_request(si.port, "GET", "/test6"); /* FAILS */ test_basic_request(si.port, "GET", "/testF"); /* FAILS */ test_basic_request(si.port, "GET", "/quit"); /* FAILS */ For simplicity we could just add a broken() although that's not a 100% correct. Or only use broken() when dealing with GEt/POST? Thoughts? -- Cheers, Paul.

1 0

Re: mshtml: Added JavaScript tests architecture and simple tests.
by Alexandre Julliard Dec. 21, 2009

Dec. 21, 2009

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/tests/Makefile.in | 2 + > dlls/mshtml/tests/jstest.html | 20 ++ > dlls/mshtml/tests/rsrc.rc | 20 ++ > dlls/mshtml/tests/script.c | 735 > ++++++++++++++++++++++++++++++++++++++++- > 4 files changed, 759 insertions(+), 18 deletions(-) > create mode 100644 dlls/mshtml/tests/jstest.html > create mode 100644 dlls/mshtml/tests/rsrc.rc It doesn't work here: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so script.c && touch script.ok 0[157e88]: IMM32: InitKeyboardLayout, aKeyboardLayout=04090409, sCodePage=1252, sIMEProperty=00090000 0[157e88]: IMM32: InitKeyboardLayout, aKeyboardLayout=04090409, sCodePage=1252, sIMEProperty=00090000 0[157e88]: file wine:res://Z:/home/julliard/wine/wine/dlls/mshtml/tests/mshtml_test.exe/jstest.html, line 5: ReferenceError: external is not defined -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: tools/widl: Split expr_int_const off from expr
by Rob Shearman Dec. 21, 2009

Dec. 21, 2009

2009/6/28 Gerald Pfeifer <gerald(a)pfeifer.com>: > diff --git a/tools/widl/parser.y b/tools/widl/parser.y > index c2f1abc..01aa060 100644 > --- a/tools/widl/parser.y > +++ b/tools/widl/parser.y > @@ -622,56 +633,54 @@ m_expr: { $$ = make_expr(EXPR_VOID); } > | expr > ; > > -expr: aNUM { $$ = make_exprl(EXPR_NUM, $1); } > - | aHEXNUM { $$ = make_exprl(EXPR_HEXNUM, $1); } > +expr: expr_int_const > | aDOUBLE { $$ = make_exprd(EXPR_DOUBLE, $1); } > + | '-' aDOUBLE { $$ = make_exprd(EXPR_DOUBLE, -($2)); } This is covered by the production for the binary minus operator that already exists, so I'm not sure what you're trying to achieve here. > | tFALSE { $$ = make_exprl(EXPR_TRUEFALSE, 0); } > - | tNULL { $$ = make_exprl(EXPR_NUM, 0); } > | tTRUE { $$ = make_exprl(EXPR_TRUEFALSE, 1); } > | aSTRING { $$ = make_exprs(EXPR_STRLIT, $1); } > | aWSTRING { $$ = make_exprs(EXPR_WSTRLIT, $1); } > - | aIDENTIFIER { $$ = make_exprs(EXPR_IDENTIFIER, $1); } > | expr '?' expr ':' expr { $$ = make_expr3(EXPR_COND, $1, $3, $5); } > | expr LOGICALOR expr { $$ = make_expr2(EXPR_LOGOR, $1, $3); } > | expr LOGICALAND expr { $$ = make_expr2(EXPR_LOGAND, $1, $3); } > - | expr '|' expr { $$ = make_expr2(EXPR_OR , $1, $3); } > - | expr '^' expr { $$ = make_expr2(EXPR_XOR, $1, $3); } > - | expr '&' expr { $$ = make_expr2(EXPR_AND, $1, $3); } > | expr EQUALITY expr { $$ = make_expr2(EXPR_EQUALITY, $1, $3); } > | expr INEQUALITY expr { $$ = make_expr2(EXPR_INEQUALITY, $1, $3); } > | expr '>' expr { $$ = make_expr2(EXPR_GTR, $1, $3); } > | expr '<' expr { $$ = make_expr2(EXPR_LESS, $1, $3); } > | expr GREATEREQUAL expr { $$ = make_expr2(EXPR_GTREQL, $1, $3); } > | expr LESSEQUAL expr { $$ = make_expr2(EXPR_LESSEQL, $1, $3); } > - | expr SHL expr { $$ = make_expr2(EXPR_SHL, $1, $3); } > - | expr SHR expr { $$ = make_expr2(EXPR_SHR, $1, $3); } > - | expr '+' expr { $$ = make_expr2(EXPR_ADD, $1, $3); } > - | expr '-' expr { $$ = make_expr2(EXPR_SUB, $1, $3); } > - | expr '%' expr { $$ = make_expr2(EXPR_MOD, $1, $3); } > - | expr '*' expr { $$ = make_expr2(EXPR_MUL, $1, $3); } > - | expr '/' expr { $$ = make_expr2(EXPR_DIV, $1, $3); } > | '!' expr { $$ = make_expr1(EXPR_LOGNOT, $2); } > - | '~' expr { $$ = make_expr1(EXPR_NOT, $2); } > - | '+' expr %prec POS { $$ = make_expr1(EXPR_POS, $2); } > - | '-' expr %prec NEG { $$ = make_expr1(EXPR_NEG, $2); } > | '&' expr %prec ADDRESSOF { $$ = make_expr1(EXPR_ADDRESSOF, $2); } > | '*' expr %prec PPTR { $$ = make_expr1(EXPR_PPTR, $2); } > | expr MEMBERPTR aIDENTIFIER { $$ = make_expr2(EXPR_MEMBER, make_expr1(EXPR_PPTR, $1), make_exprs(EXPR_IDENTIFIER, $3)); } > | expr '.' aIDENTIFIER { $$ = make_expr2(EXPR_MEMBER, $1, make_exprs(EXPR_IDENTIFIER, $3)); } > | '(' type ')' expr %prec CAST { $$ = make_exprt(EXPR_CAST, $2, $4); } > - | tSIZEOF '(' type ')' { $$ = make_exprt(EXPR_SIZEOF, $3, NULL); } > | expr '[' expr ']' { $$ = make_expr2(EXPR_ARRAY, $1, $3); } > - | '(' expr ')' { $$ = $2; } > ; > > expr_list_int_const: expr_int_const { $$ = append_expr( NULL, $1 ); } > | expr_list_int_const ',' expr_int_const { $$ = append_expr( $1, $3 ); } > ; > > -expr_int_const: expr { $$ = $1; > - if (!$$->is_const) > - error_loc("expression is not an integer constant\n"); > - } > +expr_int_const: aNUM { $$ = make_exprl(EXPR_NUM, $1); } > + | aHEXNUM { $$ = make_exprl(EXPR_HEXNUM, $1); } > + | tNULL { $$ = make_exprl(EXPR_NUM, 0); } > + | aIDENTIFIER { $$ = make_exprs(EXPR_IDENTIFIER, $1); } aIDENTIFIER isn't necessarily a constant expression. > + | '~' expr_int_const { $$ = make_expr1(EXPR_NOT, $2); } > + | '+' expr_int_const %prec POS { $$ = make_expr1(EXPR_POS, $2); } > + | '-' expr_int_const %prec NEG { $$ = make_expr1(EXPR_NEG, $2); } > + | expr_int_const SHL expr_int_const { $$ = make_expr2(EXPR_SHL, $1, $3); } > + | expr_int_const SHR expr_int_const { $$ = make_expr2(EXPR_SHR, $1, $3); } > + | expr_int_const '+' expr_int_const { $$ = make_expr2(EXPR_ADD, $1, $3); } > + | expr_int_const '-' expr_int_const { $$ = make_expr2(EXPR_SUB, $1, $3); } > + | expr_int_const '%' expr_int_const { $$ = make_expr2(EXPR_MOD, $1, $3); } > + | expr_int_const '*' expr_int_const { $$ = make_expr2(EXPR_MUL, $1, $3); } > + | expr_int_const '/' expr_int_const { $$ = make_expr2(EXPR_DIV, $1, $3); } > + | expr_int_const '|' expr_int_const { $$ = make_expr2(EXPR_OR , $1, $3); } > + | expr_int_const '^' expr_int_const { $$ = make_expr2(EXPR_XOR, $1, $3); } > + | expr_int_const '&' expr_int_const { $$ = make_expr2(EXPR_AND, $1, $3); } Using "expr_int_const" instead of "expr" here prevents a many forms of expressions from being parsed. > + | tSIZEOF '(' type ')' { $$ = make_exprt(EXPR_SIZEOF, $3, NULL); } > + | '(' expr ')' { $$ = $2; } > ; > > expr_const: expr { $$ = $1; It looks like you'll have to find another way of fixing the issue you are trying to fix. -- Rob Shearman

3 2

Re: qedit.dll: Add minimal stubs for NullRenderer and SampleGrabber
by Alexandre Julliard Dec. 21, 2009

Dec. 21, 2009

Paul Chitescu <paulc(a)voip.null.ro> writes: > Changelog: > qedit.dll: Add minimal stubs for NullRenderer and SampleGrabber. > > It doesn't make much sense to break this patch in two since most applications > connect a SampleGrabber to a NullRenderer to capture frames. That doesn't mean you can't split the patch. > +#define DEF_COMMON(iface)\ > +static ULONG WINAPI NullRenderer_ ## iface ## _AddRef(iface *ptr)\ > +{\ > + return InterlockedIncrement(&GET_THIS(ptr,iface)->refCount);\ > +}\ > +static ULONG WINAPI NullRenderer_ ## iface ## _Release(iface *ptr)\ > +{\ > + NR_Impl *This = GET_THIS(ptr,iface);\ > + ULONG refCount = InterlockedDecrement(&This->refCount);\ > + if (refCount == 0) \ > + {\ > + NullRenderer_cleanup(This);\ > + CoTaskMemFree(This);\ > + return 0;\ > + }\ > + return refCount;\ > +}\ > +static HRESULT WINAPI NullRenderer_ ## iface ## _QueryInterface(iface *ptr, REFIID riid, void **ppvObject)\ > +{\ > + return NullRenderer_query(GET_THIS(ptr,iface), riid, ppvObject);\ > +} > + > +/* Macro to put common IUnknown pointers in interface's vtable */ > +#define VTBL_COMMON(iface)\ > +NullRenderer_ ## iface ## _QueryInterface,\ > +NullRenderer_ ## iface ## _AddRef,\ > +NullRenderer_ ## iface ## _Release, Please don't add ugly macros like those, spell things out explicitly. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 3/4] kernel32/path: Fix last error in SearchPathA/W with tests
by Paul Vriens Dec. 21, 2009

Dec. 21, 2009

On 12/21/2009 02:32 AM, Nikolay Sivov wrote: > Fix last error in SearchPathA/W with tests > Hi Nikolay, Any reason all tests are relying on both the A- and W-version being available? SearchPathA is implemented on Win98. SearchPathW is exported but not implemented. This means the current tests will fail on Win98 for example: path.c:1490: Test failed: Expected ERROR_INVALID_PARAMETER, got 2 path.c:1497: Test failed: Expected ERROR_INVALID_PARAMETER, got 78 path.c:1504: Test failed: Expected ERROR_INVALID_PARAMETER, got 78 So SearchPathA returns something different for the last error and the SearchPathW tests already fail because GetWindowsDirectoryW() is not implemented (next to SearchPathW itself not being implemented of course). -- Cheers, Paul.

2 3

some 16 bit apps crash with gcc-4.3 (Ubuntu Intrepid); work with 4.2 (Hardy) - Caesar 3
by Joerg-Cyril.Hoehle＠t-systems.com Dec. 21, 2009

Dec. 21, 2009

Hi, the news is that a few 16bit apps crash in Wine, apparently depending on the gcc version used to compile Wine. This was known to affect copy-protected apps, but in the present case, copy protection is not involved. >perhaps that old wine-1.1.16 was compiled with Ubuntu Hardy, not Intrepid... Indeed that is the difference: - Meine Traumburg (children game probably nobody knows outside Germany) crashes at start; - Caesar III from Sierra (mine is the German version) aborts before the second installer screen ("error 112") with no revealing error message or stack dump using a Wine compiled in Ubuntu Intrepid. They work fine with a Wine compiled in Ubuntu Hardy. Sorry, I don't use any newer Ubuntu (yet). Wine-1.1.16 and 1.1.34 behave the same. http://wiki.winehq.org/GccVersions mentions that some versions of gcc miscompile some code relevant for copy protection. However the above apps are not protected AFAICT! (They are trivial to install on HD without the need for the CD at run-time.) So gcc (presumably) affects "regular" code in Wine. The winesrc/include/config.h file on both systems is the same except for one line about mpg123; that's why I believe gcc is to blame (or Wine does some 16bit assembly magic that's not supported by gcc and thus produces random results). Hardy uses gcc-4.2 (Wiki page says "known to work/this isn't certain") Intrepid uses gcc-4.3 (Wiki page says "not tested") It would be interesting to re-evaluate bugs.winehq for bugs with keyword "win16". Regards, Jörg Höhle

1 0

Re: [2/2] wininet: Free per-thread error info upon exit from an async procedure.
by Jacek Caban Dec. 21, 2009

Dec. 21, 2009

Hi Hans. On 12/21/09 11:14 AM, Hans Leidekker wrote: > Found by Valgrind. > --- > dlls/wininet/internet.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c > index d749e53..2b8d767 100644 > --- a/dlls/wininet/internet.c > +++ b/dlls/wininet/internet.c > @@ -3127,8 +3127,12 @@ static DWORD CALLBACK INTERNET_WorkerThreadFunc(LPVOID lpvParam) > HeapFree(GetProcessHeap(), 0, lpRequest); > > workRequest.asyncproc(&workRequest); > - > WININET_Release( workRequest.hdr ); > + > + if (g_dwTlsErrIndex != TLS_OUT_OF_INDEXES) > + { > + HeapFree(GetProcessHeap(), 0, TlsGetValue(g_dwTlsErrIndex)); > + } > You have to set TLS value to NULL otherwise it will crash on next INTERNET_SetLastError in the same thread on another async call. But the right way to fix this is to get rid of INTERNET_[GS]etLastError. This is useless and has proven to result in code that has many failure paths without last error set. I've already removed most of these calls and I'm near to getting rid of all of them except ones in ftp.c. Thanks, Jacek

2 1

Isn't it a bug?
by Luis Busquets Dec. 21, 2009

Dec. 21, 2009

From some time when I run Civilization4 I get a myriad of these messages and others with other formats: err:d3d:getColorBits Unsupported format: WINED3DFMT_R16G16_FLOAT err:d3d:IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt Unable to check compatibility for Format=WINED3DFMT_R16G16_FLOAT After looking in the wine code I have found out that what happens is that Civ calls the function IDirect3D9Impl_CheckDepthStencilMatch The implementation of wine then calls IWineD3D_CheckDepthStencilMatch which then calls IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt <http://source.winehq.org/ident?i=IWineD3DImpl_IsPixelFormatCompatibleWithRe…> for each format that the adapter supports until it finds a supported format: Problem: IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt <http://source.winehq.org/ident?i=IWineD3DImpl_IsPixelFormatCompatibleWithRe…> tries to match the supported pixel format of the adapter with the requested format. If the supported pixel format of the adapter is of type WGL_TYPE_RGBA_ARB, it tries to getColorBits of the format even if the format to try is a floating format, getColorBits responds with an error and same does IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt <http://source.winehq.org/ident?i=IWineD3DImpl_IsPixelFormatCompatibleWithRe…>. Certainly, the answer is correct (FALSE) but the problem is that it fills the screen with ERR that are due to wine checking things for which there is no need as they are directly false. So my question is if it is possible to do IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt <http://source.winehq.org/ident?i=IWineD3DImpl_IsPixelFormatCompatibleWithRe…> right away check if: cfg->iPixelType ==WGL_TYPE_RGBA_ARB <http://source.winehq.org/ident?i=WGL_TYPE_RGBA_ARB> and format_desc is a floating format then return FALSE right away no need to fill ERR same if cfg->iPixelType ==WGL_TYPE_RGBA_FLOAT_AR <http://source.winehq.org/ident?i=WGL_TYPE_RGBA_FLOAT_ARB>B <http://source.winehq.org/ident?i=WGL_TYPE_RGBA_ARB> and format_desc is not a floating format then return FALSE right away no need to fill ERR If you do not like this solution, getColorBits could be modified so that it does not file an error for floating point formats but just responds with 0 for all bit sizes when the format is a floating point without filling an error. What do you prefer? Can somebody propose a patch with this kind of behaviour or something better so that my Civ4 does not respond with this myriad of errors? <http://source.winehq.org/ident?i=WGL_TYPE_RGBA_ARB>

2 2

Limit Bugzilla fields access
by Nikolay Sivov Dec. 21, 2009

Dec. 21, 2009

Hi. I think it's not bad to remove some not useful in Wine's bugzilla fields from bug page: - whiteboard: what is it for? - difficulty - this really means nothing, usually set by reporter and not used by developers at all; - alias - used by reporters some times, but often reset by bugzilla buys (don't know why actually). Also it might be good to enable version field only on bug creation for people with report only permissions, version is often changed after reporter tested app again on newer version, after that bugzilla maintainers change it back and so on. The less the better, should be a rule here. Don't know is some of that fields configurable or code change required, but still I'm sure it's possible. Thanks.

2 1

WineTestBot changes
by Greg Geldorp Dec. 20, 2009

Dec. 20, 2009

Updates to the test bot: - Improve log parsing and error reporting - Send notification email on job completion - Run winetest64-latest.exe on 64-bit machines - Show warning message if job is submitted without command line arg - Attempt to display times in users own timezone - Add possibility to set WINETEST_DEBUG and WINETEST_REPORT_SUCCESS env vars The code (LGPL) is now hosted on SourceForge in the "wine/winetestbot" git repository. Ge.

1 0

Broken-down time (struct tm)
by Erich Hoover Dec. 20, 2009

Dec. 20, 2009

I will soon have access to a network license for a piece of software that uses the Sentinel Protection Driver (ie. I do not need USB support), so I am looking into implementing ExSystemTimeToLocalTime (Bug 19395) so that the driver will work properly. In the process of researching a good way to support this feature I found that the "broken-down time structure" (struct tm) has a member for the local timezone offset from GMT (tm_gmtoff). According to the man pages this feature requires that _BSD_SOURCE be defined before including time.h; however, I found this member being used in dlls/msvcrt/time.c without this #define. So, the question I have is whether it is OK to use tm_gmtoff in Wine (whether there is a portability concern) and the proper way to include time.h to use this feature. Erich Hoover ehoover(a)mines.edu

2 2

Recent User32 <=> windowClass assembly findings
by Nikolay Sivov Dec. 20, 2009

Dec. 20, 2009

Hopefully my first attempt to implement class redirection wasn't committed --- http://source.winehq.org/patches/data/56761 --- cause it's definitely incomplete. After some testing I've got new info here (to be added to patch comments above): 1) not statically linked sxs module is loaded not only on window creation but on GetClassInfo() (GetClassInfoEx() is to be tested but I think it's the same). This is a case only on vista+ systems, xp doesn't attempt to load assembly on GetClassInfo(); 2) "versioned" attribute in windowClass element affects redirection behavior, when set to "no" user32 doesn't try to load assembly at all. Second problem requires a FindActCtxSectionString() to actually fill key data with undocumented format, I did some dumping basing on length value reported: similar way it's done for dll redirection test (with a dword pointer) and useful fields are actually obvious - such as classname and module name. First problem stops me cause I don't know what way to prefer here. Any advices are welcome. P.S. Maybe it helps - native returned class data in case of vista+ and comctl32 v6 contains pointers to winproc as "FFFFxxxx" format, high word is constant. Personally I don't know what is supposed to mean, builtin classes without redirection don't show such patterns.

1 0

Re: wine autodetec 32/64 application
by Roderick Colenbrander Dec. 20, 2009

Dec. 20, 2009

Hi Giuseppe, Support for 64-bit is under heavy development and it our goal for Wine 1.2. A simple script to forward execution to 32-bit or 64-bit wine is not enough. Work is going on to integrate 32-bit and 64-bit Wine. Parts of the infrastructure for this are already in place (e.g. a shared wineserver) but other bits for a shared registry and prefix are still in development. It is not clear how we will invoke 32-bit or 64-bit Wine yet. I would recommend to check out Alexandre his keynote which discusses 64-bit Wine http://haar.student.utwente.nl/~julius/wineconf/julliardkeynote2009.ogv Roderick On Sat, Dec 19, 2009 at 5:17 PM, Giuseppe Della Bianca <bepii(a)libero.it> wrote: > Hi. > > This attached wine script can autodetect the wine 32/64 and application > PE32/PE32+, and autorun the correct wine program. > > This wine script support the application with name with space, and with > windows path. > > Regards. > Gdb > > > >

2 1

Conformance tess for cmd?
by Dan Kegel Dec. 19, 2009

Dec. 19, 2009

Has anyone written conformance tests for cmd? I imagine they'd mostly just be a bunch of batch files with matching expected output files.

4 6

re: Broken-down time (struct tm)
by Dan Kegel Dec. 19, 2009

Dec. 19, 2009

fwiw, looks like it might be a problem when building on Solaris: https://issues.asterisk.org/view.php?id=12022 Not sure what to do when that field is missing offhand.

1 0

Re: comdlg32: Check if the shell view exists before using it to execute commands
by Nikolay Sivov Dec. 19, 2009

Dec. 19, 2009

On 12/19/2009 20:47, Paul Chitescu wrote: > Changelog: > comdlg32: Check if the shell view exists before using it to execute commands. > > Prevents crashing if trying to create new folder with a R/O Registry (which is > a bug by itself in a different module). > Don't you mind add a test for that and previous patches?

2 1

Re: [2/2][tools]winetest: fix filesize limit
by Paul Vriens Dec. 19, 2009

Dec. 19, 2009

Hi André, On 12/19/2009 06:01 PM, André Hentschel wrote: > if (defined $dll) { We should only get here if we've received a start of a test but not the end. > # Either winetest crashed or the report file was cut off > $_=""; > - if ($filesize == $maxfilesize) { > + if ($filesize> $maxfilesize) { This can never happen as $maxfilesize is where it is cut off. The whole reason for this check is to decide whether we have a crash or "just" a file limit reached. If the size of the file is the maximum and we didn't get an end for the test we can assume it has been cut off at the sender. -- Cheers, Paul.

2 1

ucla dxdiag sources now in separate repo...
by Dan Kegel Dec. 19, 2009

Dec. 19, 2009

... until they can be merged. That seems like a better solution than just keeping the patches around in hyperspace. The tree is at http://code.google.com/p/yadxdiag/ If anyone would like to help finish this up, please let me know. The spinning cube test is pretty cool. - Dan

1 0

re: msi: fix leak in cond.y
by Nate Gallaher Dec. 18, 2009

Dec. 18, 2009

I should have mentioned in the commit message that this approach took heavy inspiration from the solution to the same problem in sql.y.

1 0

re: daily 16 bit tests?
by Dan Kegel Dec. 18, 2009

Dec. 18, 2009

Joerg-Cyril.Hoehle wrote: > there have been a number of 16bit changes lately (accompanied by a > few regressions) and I've been wondering whether some bot somewhere > has been setup to execute 16 bit tests (I read that there's a 16bit > testsuite somewhere, not integrated into Wine tests)? The procedure for running the 16 bit tests is given at http://code.google.com/p/win16test/source/browse/trunk/src/README It'd be great to integrate them into the daily test runs somehow. Maybe they could at least be incorporated into winetest.exe? Tips: When installing openwatcom with winetricks, be sure to select 'all' rather than 'selective', or you'll end up without the 16 bit tools you need; the symptom will be 'make all' fails because it's trying to use 32 bit headers. About four tests hang currently - you have to kill them with ^C use touch to bypass them, and rerun 'make tests'. Of the tests that don't hang, three currently fail. And it looks like a few of the tests don't pass on all windows machines, see http://code.google.com/p/win16test/issues/detail?id=1

1 0

Re: [usp10 5/6] Fix the ABC width calculations in ScriptPlace
by Alexandre Julliard Dec. 18, 2009

Dec. 18, 2009

Jason Green <jave27(a)gmail.com> writes: > - if (pABC) TRACE("Total for run: abcA=%d, abcB=%d, abcC=%d\n", pABC->abcA, pABC->abcB, pABC->abcC); > + if (pABC) > + { > + ABC tmp; > + > + > + /* the compositie 'A' width is simply the padding from the first glyph in the run */ > + get_cache_glyph_widths(psc, pwGlyphs[0], &tmp); > + pABC->abcA = tmp.abcA; > + > + /* the compositie 'C' width is simply the padding from the last glyph in the run */ > + get_cache_glyph_widths(psc, pwGlyphs[cGlyphs - 1], &tmp); > + pABC->abcC = tmp.abcC; > + > + /* since the 'B' width now includes the 'A' and 'C' widths, we must adjust it slightly */ > + pABC->abcB -= pABC->abcA + pABC->abcC; > + > + TRACE("Total for run: abcA=%d, abcB=%d, abcC=%d\n", pABC->abcA, pABC->abcB, pABC->abcC); > + } That's too complicated, there's no reason to retrieve the sizes twice, just handle that in the main loop. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [usp10 3/6] Fix the handling of spaces in ScriptBreak and ScriptShape
by Alexandre Julliard Dec. 18, 2009

Dec. 18, 2009

Jason Green <jave27(a)gmail.com> writes: > commit 93b60cf8b1bcdabf008437b00cde35e162bdad1c > Author: Jason Green <jason(a)transgaming.com> > Date: Thu Dec 17 10:56:39 2009 -0500 > > Fix the handling of spaces in ScriptBreak and ScriptShape > From: Eric van Beurden <ericvb(a)transgaming.com> It doesn't work: ../../../tools/runtest -q -P wine -M usp10.dll -T ../../.. -p usp10_test.exe.so usp10.c && touch usp10.ok usp10.c:1245: Test failed: fWhiteSpace set usp10.c:1256: Test failed: fWhiteSpace set make[2]: *** [usp10.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mapi32: add French translation
by Nicolas Le Cam Dec. 18, 2009

Dec. 18, 2009

Hi Frédéric, Using "absence" and "installé" in the same sentence doesn't sound right. Something like "L'envoi de courriel a échoué car vous n'avez pas de client mail MAPI installé." or "L'envoi de courriel a échoué du fait de l'absence de client mail MAPI." should be simpler and more correct. -- Nicolas Le Cam

2 1

gcrypt windows build is done on linux, uses wine to run test suite
by Dan Kegel Dec. 18, 2009

Dec. 18, 2009

Here's an interesting tidbit. gcrypt's windows version's only supported build environment is mingw on unix/linux, and it relies on wine to run its test suite. - Dan ---------- Forwarded message ---------- From: Simon Josefsson <simon(a)josefsson.org> Date: Thu, Dec 17, 2009 at 12:57 PM Subject: Re: gcrypt windows build To: "Hoyt, David" <hoyt6(a)llnl.gov> Cc: Werner Koch <wk(a)gnupg.org>, "gcrypt-devel(a)gnupg.org" <gcrypt-devel(a)gnupg.org> "Hoyt, David" <hoyt6(a)llnl.gov> writes: >> We only support cross-builds from a POSIX platform. If you try to build it on the traget platform it may or may not work. > > How do you test a cross-compiled library? How do you run your test > programs to validate your cross-compiled libraries are working > correctly? Do you have any tips on how I could get the test programs > working? Use wine. Just install MinGW and Wine under Linux, and then build libgcrypt like this: ./configure --host=i586-mingw32msvc --build=i686-pc-linux-gnu It will invoke the self-tests automatically, if you have the binfmt-support package installed. If you want a makefile that does everything, check out <http://josefsson.org/gnutls4win/Makefile>. /Simon _______________________________________________ Gcrypt-devel mailing list Gcrypt-devel(a)gnupg.org http://lists.gnupg.org/mailman/listinfo/gcrypt-devel

2 1

daily 16 bit tests?
by Joerg-Cyril.Hoehle＠t-systems.com Dec. 18, 2009

Dec. 18, 2009

Hi, there have been a number of 16bit changes lately (accompanied by a few regressions) and I've been wondering whether some bot somewhere has been setup to execute 16 bit tests (I read that there's a 16bit testsuite somewhere, not integrated into Wine tests)? I believe that would be a good thing to have. BTW, I've come across a weird situation where a 16bit app crashes in "recent" Wine. Actually, I've an old build of wine-1.1.16 which works, but when I recompile 1.1.16 (or anything more recent) nowadays, the app crashes. Except for Ubuntu's security updates and installation of libmpg123, I don't see what's changed on this machine. Anybody with similar experience? Hmm, perhaps that old wine-1.1.16 was compiled with Ubuntu Hardy, not Intrepid... Regards, Jörg Höhle.

1 0

Re: Alexandre Julliard : user32: Add a thunking mechanism for 16-bit edit word break procedures.
by Eric Pouech Dec. 17, 2009

Dec. 17, 2009

Alexandre Julliard a écrit : > Module: wine > Branch: master > Commit: dcec342b50524562844f64d43d423ed2c83c1f97 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=dcec342b50524562844f64d43… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Fri Dec 11 14:52:28 2009 +0100 > > user32: Add a thunking mechanism for 16-bit edit word break procedures. > > > Alexandre, shouldn't the thunk be released in EDIT_WM_NCDestroy upon EDITSTATE destruction ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 3

Re: [5/5] WineD3D: Implement buffer subrange mapping with GL_APPLE_flush_buffer_range
by Henri Verbeet Dec. 17, 2009

Dec. 17, 2009

2009/12/15 Stefan Dösinger <stefan(a)codeweavers.com>: > @@ -85,6 +85,21 @@ static void buffer_create_buffer_object(struct wined3d_buffer *This) ... > + This->maps = HeapAlloc(GetProcessHeap(), 0, sizeof(*This->maps)); This is the wrong place for that. Either do it in buffer_init(), or in buffer_Map(). Keeping track of maps should also be in a separate patch, and you should integrate "lock_count". > +struct map_range A "wined3d_" prefix wouldn't hurt. > + LONG maps_size; Does a signed variable really make sense here? > + /* TODO: GL_ARB_map_buffer_range */ > + return gl_info->supported[APPLE_FLUSH_BUFFER_RANGE]; As a general rule, I think it makes sense to add support for ARB extensions (when available) before vendor specific extensions.

3 7

Re: [usp10 1/6] Fix an uninitialized static variable.
by Juan Lang Dec. 17, 2009

Dec. 17, 2009

Hi Jason, - static const ABC nil; + static const ABC nil = {0}; This has no effect, as static variables are implicitly initialized to 0 anyway. It might be a little less surprising this way.. --Juan

3 6

Re: [dbghelp 1/2] Check for incorrectly set ClientPointers flag
by Eric Pouech Dec. 17, 2009

Dec. 17, 2009

Jason Green a écrit : I don't think it's a good idea to change the exception structure passed by the caller to the minidump creation it's better to hard wire the optimization in dump_exception_info A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Valgrind warnings down 50% from last month
by Dan Kegel Dec. 17, 2009

Dec. 17, 2009

The total count of valgrind warnings in the wine test suite has gone down from about 2000 a month ago http://kegel.com/wine/valgrind/logs/2009-11-16-19.12.errs.txt to about 1000 today http://kegel.com/wine/valgrind/logs/2009-12-15-07.57.errs.txt (as computed by http://kegel.com/wine/valgrind/logs/count.sh.txt ). Thanks to everyone who has been helping clean this up! Let's see if we can cut it down another 50% by this time next month...

1 2