December 2009 - Wine-Devel - list.winehq.org

Re: ntdll: add partial support for HEAP_FREE_CHECKING_ENABLED heap overrun detection (take 2)
by Alexandre Julliard Dec. 3, 2009

Dec. 3, 2009

Dan Kegel <dank(a)kegel.com> writes: > @@ -467,6 +475,156 @@ static void test_HeapQueryInformation(void) > ok(info == 0 || info == 1 || info == 2, "expected 0, 1 or 2, got %u\n", info); > } > > +static LPVOID (WINAPI * pRtlAllocateHeap)(HANDLE,ULONG,ULONG); > +static HANDLE (WINAPI * pRtlCreateHeap)(ULONG,PVOID,SIZE_T,SIZE_T,PVOID,PRTL_HEAP_DEFINITION); > +static HANDLE (WINAPI * pRtlDestroyHeap)(HANDLE); > +static NTSTATUS (WINAPI * pRtlFreeHeap)(HANDLE, ULONG, PVOID); > +static ULONG (WINAPI * pRtlGetNtGlobalFlags)(void); > +static LPVOID (WINAPI * pRtlReAllocateHeap)(HANDLE, ULONG, PVOID, ULONG); > +static SIZE_T (WINAPI * pRtlSizeHeap)( HANDLE, ULONG, LPCVOID); > +static BOOLEAN (WINAPI * pRtlValidateHeap)(HANDLE, ULONG, LPCVOID); > + > +static HMODULE hntdll; Now that it's in kernel32 you should of course use the kernel32 heap functions instead. > @@ -348,7 +349,10 @@ HANDLE thread_init(void) > peb->NtGlobalFlag = get_global_flag(); > > /* create the process heap */ > - if (!(peb->ProcessHeap = RtlCreateHeap( HEAP_GROWABLE, NULL, 0, 0, NULL, NULL ))) > + heapflags = HEAP_GROWABLE; > + if (peb->NtGlobalFlag & FLG_HEAP_ENABLE_FREE_CHECK) > + heapflags |= HEAP_FREE_CHECKING_ENABLED; > + if (!(peb->ProcessHeap = RtlCreateHeap( heapflags, NULL, 0, 0, NULL, NULL ))) Is there any reason for not doing this for all created heaps, instead of just the main one? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/6] WineD3D: Add a function for initializing surface sysmem
by Henri Verbeet Dec. 3, 2009

Dec. 3, 2009

2009/12/2 Stefan Dösinger <stefan(a)codeweavers.com>: > - updateSurfaceDesc((IWineD3DSurfaceImpl *)swapchain->frontBuffer, pPresentationParameters); > + hr = updateSurfaceDesc((IWineD3DSurfaceImpl *)swapchain->frontBuffer, pPresentationParameters); > + if(FAILED(hr)) > + { > + IWineD3DSwapChain_Release((IWineD3DSwapChain *) swapchain); > + return hr; > + } > + > for(i = 0; i < swapchain->presentParms.BackBufferCount; i++) { > - updateSurfaceDesc((IWineD3DSurfaceImpl *)swapchain->backBuffer[i], pPresentationParameters); > + hr = updateSurfaceDesc((IWineD3DSurfaceImpl *)swapchain->backBuffer[i], pPresentationParameters); > + if(FAILED(hr)) > + { > + IWineD3DSwapChain_Release((IWineD3DSwapChain *) swapchain); > + return hr; > + } > } IWineD3DDeviceImpl_Reset() suffers from similar issues in general, so maybe we just don't care, but if one of the updateSurfaceDesc() calls fails you're left with inconsistent surface sizes. > + This->Flags |= SFLAG_INSYSMEM; Why is this in surface_init_sysmem(), instead of a ModifyLocation() call after the call to surface_init_sysmem()?

2 2

Re: RFC: dsound: Add support for enumerating capture devices through openal, try 4
by Ken Thomases Dec. 3, 2009

Dec. 3, 2009

On Dec 2, 2009, at 12:11 PM, Maarten Lankhorst wrote: > This patch doesn't apply, just a rfc email to see if this approach > is correct :) > +static void *openal_handle = RTLD_DEFAULT; > +#ifdef SONAME_LIBOPENAL > + char error[128]; > + openal_handle = wine_dlopen(SONAME_LIBOPENAL, RTLD_NOW, error, > sizeof(error)); > + if (!openal_handle) > + ERR("Couldn't load " SONAME_LIBOPENAL ": %s\n", error); > +#endif > +#define LOAD_FUNCPTR(f) \ > + if((p##f = wine_dlsym(openal_handle, #f, NULL, 0)) == NULL) { \ > + ERR("Couldn't lookup %s in libopenal\n", #f); \ > + failed = 1; \ > + } > + > + LOAD_FUNCPTR(alcCreateContext); By defaulting to RTLD_DEFAULT on the Mac (where SONAME_LIBOPENAL won't be defined), is there any risk that wine_dlsym will find the symbols from Wine's openal32.dll.so rather than the linked OpenAL framework? If it does, is that a problem? I had proposed using RTLD_NEXT for the default to avoid that possibility, although it seems that RTLD_NEXT isn't universally available. We might use RTLD_NEXT if it's defined and RTLD_DEFAULT otherwise. -Ken

2 1

Slackware packager?
by Jeremy White Dec. 3, 2009

Dec. 3, 2009

So Adam Schreiber reports that he's no longer doing the Slackware packages. Is there an active Packager currently? If so, can you submit a patch to remove Adam's name and insert yours? If not, I guess I'll submit a patch to remove that column for Slackware... Cheers, Jeremy

2 1

Re: [3/6] WineD3D: A function for checking if a surface is offscreen
by Henri Verbeet Dec. 3, 2009

Dec. 3, 2009

2009/12/2 Stefan Dösinger <stefan(a)codeweavers.com>: > @@ -5674,7 +5674,7 @@ static void color_fill_fbo(IWineD3DDevice *iface, IWineD3DSurface *surface, > IWineD3DSwapChain *swapchain; > > swapchain = get_swapchain(surface); > - if (swapchain) { > + if (!surface_is_offscreen(surface)) { That's ok, but the code that sets up the scissor rect further down also uses "swapchain" like this. Also, some of the changes to e.g. read_from_framebuffer() in patch 4 are really the same as what you're doing in this patch. Btw, note that the surface being offscreen is the common case, and onscreen surfaces are the exception. Maybe surface_is_onscreen() makes more sense, but I'll leave that up to you.

2 1

re: RFC: winediag script
by Dan Kegel Dec. 2, 2009

Dec. 2, 2009

I love the idea. Could it be packaged with wine, or do you think it would be better off being a cousin of winetricks?

2 1

Re: [3/6] imagehlp: Implement ImageRemoveCertificate
by Jacek Caban Dec. 2, 2009

Dec. 2, 2009

Hi Owen, Owen Rudge wrote: > --- > dlls/imagehlp/integrity.c | 73 > +++++++++++++++++++++++++++++++++++++-- > dlls/imagehlp/tests/integrity.c | 4 +- > 2 files changed, 72 insertions(+), 5 deletions(-) + cert_data = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, data_size); + + if (!cert_data) + return FALSE; + + ret = SetFilePointer(FileHandle, offset + cert_size_padded, NULL, FILE_BEGIN); + + if (ret == INVALID_SET_FILE_POINTER) + return FALSE; + + /* Read any subsequent certificates */ + r = ReadFile(FileHandle, cert_data, data_size, &count, NULL); + + if ((!r) || (count != data_size)) + return FALSE; + + SetFilePointer(FileHandle, offset, NULL, FILE_BEGIN); + + /* Write them one index back */ + r = WriteFile(FileHandle, cert_data, data_size, &count, NULL); + + if ((!r) || (count != data_size)) + return FALSE; + + HeapFree(GetProcessHeap(), 0, cert_data); You leak cert_data on errors here. Jacek

1 0

Tests question.
by David Anderson Dec. 2, 2009

Dec. 2, 2009

I am trying to get the tests to run before I submit a patch to shdocvw/webbrowser.c. My first attempts to get the tests to run. This morning I did cd /home/davea/winebld/wine git fetch; git rebase origin # make sure you're up to date ./configure && make depend && make # rebuild the tree rm -rf ~/.wine # be sure to test in a clean WINEPREFIX sudo cp /home/downloads/wine_gecko-1.0.0-x86.cab /usr/local/share/wine/gecko sh ../apps/winetricks winxp mkdir /home/davea/.wine/drive_c/windows/system32/gecko/1.0.0/wine_gecko /bin/echo -n "Wine Gecko 1.0.0" >/home/davea/.wine/drive_c/windows/system32/gec ko/1.0.0/wine_gecko/VERSION cat /home/davea/.wine/drive_c/windows/system32/gecko/1.0.0/wine_gecko/VERSION make testclean make test and it failed on an init_d3d8 call. ../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p d3d8_test.exe.so visual.c && touch visual.ok err:wgl:opengl_error No OpenGL support compiled in. err:d3d_caps:WineD3D_CreateFakeGLContext Can't find a suitable iPixelFormat. err:d3d:InitAdapters Failed to get a gl context for default adapter err:d3d:WineDirect3DCreate Direct3D8 is not available without opengl visual.c:131: Tests skipped: could not create D3D8 visual.c:1312: Test failed: Could not initialize direct3d make[2]: *** [visual.ok] Error 1 make[2]: Leaving directory `/home/davea/winebld/wine/dlls/d3d8/tests' make[1]: *** [d3d8/tests/__test__] Error 2 make[1]: Leaving directory `/home/davea/winebld/wine/dlls' make: *** [dlls/__test__] Error 2 I note that d3d8/tests/visual.c does a win_skip() when the init_d3d3() fails. Why not a skip() ? Changing the win_skip here to: if (!d3d8_ptr) { skip("could not create D3D8\n"); return NULL; } enables the test to continue. Which is right? win_skip or skip? Why? This is on Ubuntu 9.10 (32bit), open-src drivers, ATI 4350 pci card. Thanks in advance for any clues. DavidAnderson

2 1

Re: Tests question.
by James Mckenzie Dec. 2, 2009

Dec. 2, 2009

>I am trying to get the tests to run before I submit a patch to >shdocvw/webbrowser.c. My first attempts to get the tests to run. > >This morning I did >cd /home/davea/winebld/wine >git fetch; git rebase origin # make sure you're up to date >./configure && make depend && make # rebuild the tree >rm -rf ~/.wine # be sure to test in a clean WINEPREFIX > >sudo cp /home/downloads/wine_gecko-1.0.0-x86.cab /usr/local/share/wine/gecko >sh ../apps/winetricks winxp >mkdir /home/davea/.wine/drive_c/windows/system32/gecko/1.0.0/wine_gecko >/bin/echo -n "Wine Gecko 1.0.0" > >/home/davea/.wine/drive_c/windows/system32/gec >ko/1.0.0/wine_gecko/VERSION >cat >/home/davea/.wine/drive_c/windows/system32/gecko/1.0.0/wine_gecko/VERSION >make testclean >make test > >and it failed on an init_d3d8 call. > >../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p >d3d8_test.exe.so visual.c && touch visual.ok >err:wgl:opengl_error No OpenGL support compiled in. This is what is causing the error. I get the same error on a series of Wine builds for MacOSX and I do have openGL support compiled in as far as I know. >err:d3d_caps:WineD3D_CreateFakeGLContext Can't find a suitable iPixelFormat. >err:d3d:InitAdapters Failed to get a gl context for default adapter >err:d3d:WineDirect3DCreate Direct3D8 is not available without opengl this is where Direct3D8 cannot initialize due to the above error. >visual.c:131: Tests skipped: could not create D3D8 >visual.c:1312: Test failed: Could not initialize direct3d And finally you get this error when running the test. >make[2]: *** [visual.ok] Error 1 >make[2]: Leaving directory `/home/davea/winebld/wine/dlls/d3d8/tests' >make[1]: *** [d3d8/tests/__test__] Error 2 >make[1]: Leaving directory `/home/davea/winebld/wine/dlls' >make: *** [dlls/__test__] Error 2 > >I note that d3d8/tests/visual.c does a win_skip() when the init_d3d3() >fails. Why not a skip() ? > Because it will cause your test to pass is not a good reason to put in a skip(). Fix the OpenGL error and this test should give proper results. James McKenzie

1 0

RFC: winediag script
by Roderick Colenbrander Dec. 2, 2009

Dec. 2, 2009

Hi, Over the years I have assisted a lot of people setting up Wine. In a lot of cases Wine doesn't work well because of missing libraries, pulseaudio, misconfigured display drivers and so on. I have written a script called 'winediag' which attempts to scan a system for the most common problems. Right now it contains mostly display driver related checks and a few basic audio / printing checks. I hope people have suggestions for most tests e.g. network tests (/etc/hosts, samba), more thorough driver checks and son. What do you guys think about it so far? (BTW I'm not a shell guru, so I would love to get some positive feedback) Thanks, Roderick Colenbrander

1 0

Re: [PATCH 1/2] msvcrt: Add test to check if signal(SIGBREAK, ...) works (todo_wine).
by James Mckenzie Dec. 2, 2009

Dec. 2, 2009

Peter Rosin <peda(a)lysator.liu.se> >Subject: [PATCH 1/2] msvcrt: Add test to check if signal(SIGBREAK, ...) works (todo_wine). > > AUTHORS is not a developer editable file. Resubmit without this change. When you have submitted enough changes to Wine, you name will be added by AJ. James McKenzie

1 0

Valgrind cleanup status
by Dan Kegel Dec. 2, 2009

Dec. 2, 2009

The logs of valgrind errors at http://kegel.com/wine/valgrind/logs/ are showing a nice downward trend: date files errors nonleak errors 2009-10-23 84 2383 339 2009-10-26 82 2344 319 2009-10-27 82 2318 294 2009-10-28 83 2325 294 2009-10-29 80 2279 253 2009-10-30 81 2304 280 2009-11-03 80 2612 301 2009-11-04 78 2290 276 2009-11-05 79 2295 268 2009-11-09 73 2215 254 2009-11-10 75 2266 296 2009-11-11 75 2236 263 2009-11-13 72 2264 234 2009-11-16 69 1724 222 2009-11-17 69 1711 221 2009-11-18 88 1736 253 2009-11-19 85 1696 247 2009-11-26 76 1628 168 2009-11-27 88 1797 302 2009-11-30 76 1779 288 2009-12-01 73 1723 230 The spike at 11-27 was when I started running with my heap tail corruption detection patch; those errors were present before, but not detected. Thanks to everyone who's been chipping away at these warnings. (Part of the decline has been knowing which suppressions to add, but that's ok, cleaner logs are good.) I'm mostly worried about nonleak errors for now, so I might be undercounting leak errors somewhat. As always, more help with these would be welcome. Some of the errors aren't that hard to deal with (but at the same time, some of them look easy but are subtle, so take care). - Dan

1 0

Re: [2/4] ntdll: add support for the HEAP_FREE_CHECKING_ENABLED style of heap overrun detection.
by Alexandre Julliard Dec. 2, 2009

Dec. 2, 2009

Dan Kegel <dank(a)kegel.com> writes: > @@ -85,6 +85,7 @@ typedef struct > > #define ARENA_INUSE_FILLER 0x55 > #define ARENA_FREE_FILLER 0xaa > +#define ARENA_PAD_FILLER(address) (((int)(address) & 1) ? 0xee : 0xfe) Don't cast addresses to int. > +static PVOID HEAP_ValidateTail( const HEAP *heap, const void *arena, const void *p, SIZE_T size, SIZE_T filler_size ) > +{ > + unsigned char *tail = ((unsigned char *)p) + size; > + int j=0; Please use correct types. j should be a SIZE_T, tail should be a const pointer. > @@ -1477,7 +1561,9 @@ BOOLEAN WINAPI RtlFreeHeap( HANDLE heap, ULONG flags, PVOID ptr ) > pInUse = (ARENA_INUSE *)ptr - 1; > if (!(subheap = HEAP_FindSubHeap( heapPtr, pInUse ))) > { > - if (!find_large_block( heapPtr, ptr )) goto error; > + ARENA_LARGE *arena = find_large_block( heapPtr, ptr ); > + if (!arena) goto error; > + if (!validate_large_arena( heapPtr, arena, NOISY )) goto error; Validation should only happen when explicitly requested. > diff --git a/dlls/ntdll/tests/heap.c b/dlls/ntdll/tests/heap.c > new file mode 100644 > index 0000000..7cfa554 > --- /dev/null > +++ b/dlls/ntdll/tests/heap.c The tests should go with the existing heap tests in kernel32. > +static void test_free_overrun(void) > +{ > + if ((pRtlGetNtGlobalFlags() & FLG_HEAP_ENABLE_FREE_CHECK) == 0) { > + skip("\ > +Skipping heap free padding overrun test. To enable:\n\ > +on Wine, use gflags to enable global heap free checking, or set the following key:\n\ > +[HKEY_LOCAL_MACHINE\\System\\CurrentControlSet\\Control\\Session Manager]\n\ > +\"GlobalFlag\"=dword:00000020\n\ > +On Windows, use gflags to enable heap free checking for ntdll_test.exe.\n"); > + return; You should create your own heap with checking enabled so that it can be tested in all cases. Also the patch is still too large, changes to sensitive areas like the heap code should be very small and focused. -- Alexandre Julliard julliard(a)winehq.org

2 3

New winetricks 20091125: new verbs ie7, alsa, fbo, pbuffer, ...
by Dan Kegel Dec. 2, 2009

Dec. 2, 2009

Pie's in the oven, time for another winetricks release. Changes in this version: Add experimental dotnet35 verb Add IE7 verb. Based on a patch by Hans Leidekker. Add verbs alsa, audioio, coreaudio, esound, jack, nas, oss to override sound driver Add verbs backbuffer, fbo, pbuffer for setting offscreen rendering buffer Don't crash winecfg if native comctl32 is used Fix gecko to work with wine-1.1.33. Make vc2003toolkit and psdk2003 verbs run on windows On cleanup, remove $WINETRICKS_TMP, not just the files in it Sorted command menu Update Firefox to 3.5.5 Update mpc to latest version, move the exe to Program Files and add it to %PATH% Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Thanks to Austin English, Erik Inge Bolsoe, and Hans Leidekker. This message posted in gmail (basic mode) in ie7 in wine.

3 3

Silencing RtlNtStatusToDosErrorNoTeb() a bit
by Wolfram Sang Dec. 2, 2009

Dec. 2, 2009

Hi, while debugging an application (Project One, available at [1]), I noticed that wine (today's git) throws a lot of these fixmes: fixme:ntdll:RtlNtStatusToDosErrorNoTeb no mapping for c0000109 Looking around, I found this page[2] stating that ERROR_MR_MID_NOT_FOUND is an expected return value for c0000109, so that the fixme is not needed here. I updated the if clause accordingly: diff --git a/dlls/ntdll/error.c b/dlls/ntdll/error.c index 9469f6f..e125163 100644 --- a/dlls/ntdll/error.c +++ b/dlls/ntdll/error.c @@ -68,7 +68,9 @@ ULONG WINAPI RtlNtStatusToDosErrorNoTeb( NTSTATUS status ) if (status < table->end) { DWORD ret = table->table[status - table->start]; - if (ret == ERROR_MR_MID_NOT_FOUND) FIXME( "no mapping for %08x\n", status ); + if (ret == ERROR_MR_MID_NOT_FOUND && + status != STATUS_MESSAGE_NOT_FOUND) + FIXME( "no mapping for %08x\n", status ); return ret; } table++; This solution has the advantage of being not very intrusive, but the disadvantage that it might be not nicely maintainable. Another &&-block has to be added for each other status found validly returning ERROR_MR_MID_NOT_FOUND. Another solution might be to define, let's say, ERROR_WINE_FIXME for all real fixmes and convert them to ERROR_MR_MID_NOT_FOUND. Something like (just a draft): #define ERROR_WINE_FIXME 0xffffffff DWORD ret = table->table[status - table->start]; if (ret == ERROR_WINE_FIXME) { FIXME( "no mapping for %08x\n", status ); ret = ERROR_MR_MID_NOT_FOUND; } return ret; [and lots of table entries changed] Well, this is pretty intrusive, but may be better distinguishing the different cases perhaps. Then again, this additional #define is polluting the ERROR_-namespace. I think I prefer the first version for now, perhaps there is no second status validly returning ERROR_MR_MID_NOT_FOUND? Any advice on how I should proceed? Thanks in advance, Wolfram [1] ftp://ftp.scs-trc.net/pub/c64/Tools/Graphics/Project1_V0.5.zip [2] http://support.microsoft.com/kb/113996

2 2

Re: [3/5] imagehlp: Implement ImageAddCertificate
by Alexandre Julliard Dec. 1, 2009

Dec. 1, 2009

Owen Rudge <orudge(a)codeweavers.com> writes: > + sd = &nt_hdr.OptionalHeader.DataDirectory[IMAGE_FILE_SECURITY_DIRECTORY]; > + > + sd->Size = dwSize; > + sd->VirtualAddress = dwOfs; > + > + TRACE("size = %x addr = %x\n", sd->Size, sd->VirtualAddress); > + > + /* write the header back again */ > + count = SetFilePointer(handle, dos_hdr.e_lfanew, NULL, FILE_BEGIN); > + > + if (count == INVALID_SET_FILE_POINTER) > + return FALSE; > + > + count = 0; > + > + r = WriteFile(handle, &nt_hdr, sizeof nt_hdr, &count, NULL); The virtual address is not necessarily the same as the disk offset. Also you should check the various header sizes and magic numbers. The existing code is broken in that respect too, but as long as it was only reading it wasn't a big problem. Once we start modifying the file it needs to be much more robust. -- Alexandre Julliard julliard(a)winehq.org

2 1

Introducing WineTestBot
by Greg Geldorp Dec. 1, 2009

Dec. 1, 2009

Or, for those who like to be buzzword compliant, the Wine Testing Cloud Service. Inspired by all the talk about testing during WineConf 2009, I set out to fill a gap in Wine testing. Most of the Wine developers don't have access to a battery of Windows machines to run the tests they write/modify on. As a result, there are quite a few regressions in the tests themselves. The WineTestBot provides a whole bunch of Windows machines, ready to accept and run your modified tests. In its current state you can submit Windows executables (most likely cross-compiled on a Linux box) to the bot, which will run it in VMs of your choice. So, how does this work in practice? First, go to https://winetestbot.geldorp.nl and click on "Register" to register an account. Once your account is approved (you'll receive a notification via email) you can log in. After log in, the menu in the sidebar changes to include an item "Submit job". This allows you to upload an .exe from your local system to the bot. You can pick the VMs (Windows versions) you want to run the test on. From the "Home" page you can see the status of your job, by clicking on the job id you get a bit more info about the progress. Once the test is completed, the stdout generated by the test is retrieved from each VM and made available via that web page. The tests are run on VMware ESX VMs, so it's probably not all that useful to run sound and DirectDraw tests on them. Also, no Win9x VMs are available. I haven't set up 64-bit VMs yet, but those should be easy to add. Before each test run, the VMs are reset to a clean snapshot, so no cruft from old tests will be left around. Your test shouldn't take more than 5 minutes, which is more than the WineTest framework allows anyway. For each Windows version, there is a "base" VM and there can be additional VMs too. The idea is that the base VM is running the most up-to-date and most often used variation of that Windows version, so running your test on the base VMs should give you a good indication on how the test behaves. Additionally, you can run your tests on the other variations too. So, for example for XP the base VM is XP Professional SP3, but there are additional VMs like SP2, Media Center Edition, and a non-English version available too. Obviously, even when you use all available VMs you'll cover a very small subset of all possible configurations (most notably you won't test on a single physical system) so please do check http://test.winehq.org after your patch has been accepted to see if you introduced failures on other machines. The plan for the future is to extend this a bit. Speaking from my own experience, I know that programmers like to be as lazy as possible. Which means that having to cross-compile your test before you can send it off to the bot will be seen as a bit of a hurdle. So the next step will be to allow you to upload the git diff instead of a Windows executable. The bot will apply your diff to a git tree and take care of creating the cross-compiled Windows executable, which it will then run on the Windows VMs. Step 3 will be to have the bot watch wine-patches for anything that might impact the tests and do the apply diff/cross-compile/run thing automatically. Obviously I'll be looking at Dan's patch watcher for this 3rd step. Security is a concern, but perhaps more for me than for you :-). I have to trust you not to abuse this system. If you want to do something naughty please do it on your own machine. There are some safeguards in the system, like the timeout. In general, you should not expect any privacy, I do have access to the consoles of the VMs and firewall logs. If you want to use this system for something else than Wine tests, please talk to me first. I'd like to thank Paul Vriens who acted as beta tester and made some valuable suggestions. I welcome feedback so if you have any ideas on how to improve this thing further please let me know. Ge.

5 6

Re: [PATCH] mshtml: check for NULL return from allocations
by Jacek Caban Dec. 1, 2009

Dec. 1, 2009

Hi Marcus, Marcus Meissner wrote: > Hi, > > Coverity thinks we miss NULL checks and yes, we do. > Added some. > > (...) > > - wstrbuf_init(&buf); > + if (!wstrbuf_init(&buf)) > + return E_OUTOFMEMORY; > range_to_string(This, &buf); > - if(buf.buf) > - *p = SysAllocString(buf.buf); > + *p = SysAllocString(buf.buf); > wstrbuf_finish(&buf); > > TRACE("ret %s\n", debugstr_w(*p)); > + if (!*p) > + return E_OUTOFMEMORY; > return S_OK; > } This check is not meant to check allocation failure, but to check if range_to_string set it to NULL. We even have a tests for this. More error handling is a good thing to do, but this check should remain unchanged. Thanks, Jacek

1 0

Re: [PATCH 2/2] jscript: Added lastIndex tests.
by Paul Vriens Dec. 1, 2009

Dec. 1, 2009

On 11/30/2009 09:12 PM, Jacek Caban wrote: > --- > dlls/jscript/tests/regexp.js | 66 > ++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 66 insertions(+), 0 deletions(-) > > Hi Jacek, This one introduces test failures on Vista+ : http://test.winehq.org/data/tests/jscript:run.html Could you have a look? -- Cheers, Paul.

2 3

work underway: Dependency on openal incoming
by Maarten Lankhorst Dec. 1, 2009

Dec. 1, 2009

Hi all, This message is mostly aimed towards package maintainers, since one of the discussions at wineconf last year was that package maintainers would like to hear in advance about changing dependencies. Wine's DirectSound implementation will, in the next release or the release after that, rely on OpenAL, the recommended library for linux or bsd's is openal-soft, and preferably a recent version, as old versions might miss certain experimental extensions that dsound will need. Mac users shouldn't need an external openal library, since it has its own openal implementation. Without openal at compile-time, dsound will still build, but report no sound devices found. Some games or other applications may refuse to run if no dsound devices are found, so its recommended that you build with openal. If openal is compiled in, but missing at runtime, dsound.dll will refuse to load, which probably means most games will not run either. Cheers, Maarten

3 5

Re: dlls/kernel32/path.c: Fix return values for UNC pathnames in GetLongPathNameW
by Alexandre Hardy Dec. 1, 2009

Dec. 1, 2009

Thanks Paul, Right! Tried to implement it too fast! Other parts of the test code dereference the function pointer and I took my lead from there without checking properly. As far as the length goes, I don't really know much about UNC pathnames, so I'm not sure what exactly the result should be. I will need to read up to find an example that I can guarantee the length of. Kind regards Alexandre On Tue, Dec 1, 2009 at 12:52 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > On 12/01/2009 08:44 AM, Alexandre Hardy wrote: >> >> + length = (*pGetLongPathNameW)(unc_path,NULL,0); > > Why the brackets around *pGetLongPathNameW? > >> + ok(length>0,"GetLongPathNameA: Failed on UNC Pathname >> (length=%d)\n",length); > > You called the W-function so the ok text needs to be adjusted. You also know > the length so why not check explicitly? > > -- > Cheers, > > Paul. > -- -------------------------------------------------- Alexandre Hardy http://www.ahardy.za.net -- -------------------------------------------------- Alexandre Hardy http://www.ahardy.za.net

1 0

Re: dlls/kernel32/path.c: Fix return values for UNC pathnames in GetLongPathNameW
by Paul Vriens Dec. 1, 2009

Dec. 1, 2009

On 12/01/2009 08:44 AM, Alexandre Hardy wrote: > + length = (*pGetLongPathNameW)(unc_path,NULL,0); Why the brackets around *pGetLongPathNameW? > + ok(length>0,"GetLongPathNameA: Failed on UNC Pathname (length=%d)\n",length); You called the W-function so the ok text needs to be adjusted. You also know the length so why not check explicitly? -- Cheers, Paul.

1 1

Re: [PATCH 4/5] dsound: Add support for OpenAL IDirectSoundCaptureBuffer
by Chris Robinson Dec. 1, 2009

Dec. 1, 2009

Hi. On Monday 30 November 2009 1:56:20 pm Maarten Lankhorst wrote: > + if (This->playing) > + { > + pos2 = This->format->nSamplesPerSec / 100; > + pos2 *= This->format->nBlockAlign; > + pos2 += pos1; > + if (!This->looping && pos2 > This->buf_size) > + pos2 = 0; > + else > + pos2 %= This->buf_size; > + } Does non-looping capture let the write position get to This->buf_size? It looks like a position of This->buf_size should set the position to 0 too, if This->buf_size+1 would. > + if (format->wFormatTag == WAVE_FORMAT_EXTENSIBLE) > + { > + WAVEFORMATEXTENSIBLE *wfe = (WAVEFORMATEXTENSIBLE*)format; > + if (!IsEqualGUID(&wfe->SubFormat, > &KSDATAFORMAT_SUBTYPE_IEEE_FLOAT)) > + return DSERR_BADFORMAT; > + else if (format->cbSize < sizeof(WAVEFORMATEXTENSIBLE)- > sizeof(WAVEFORMATEX)) > + return DSERR_INVALIDPARAM; > + else if (format->cbSize > sizeof(WAVEFORMATEXTENSIBLE)- > sizeof(WAVEFORMATEX) > + && format->cbSize != sizeof(WAVEFORMATEXTENSIBLE)) > + return DSERR_CONTROLUNAVAIL; > + } You should probably check the cbSize before accessing the extended information, otherwise it may indicate that there isn't enough space for the extended information. Also, is it necessary to reject formats with a higher cbSize than needed (IIRC, Wine's tests showed some Windows versions allowed it)? > + buf_format = alGetEnumValue(fmt_str); Unfortunately, you can't call this function when a context is not set (it'll probably work on some systems, but technically shouldn't). And setting a context makes no sense for capture. Setting buf_format directly to the enum in the switches should be all you need to do.. just make sure to initialize it to 0 so the check won't use it uninitialized. > + This->dev = alcCaptureOpenDevice(This->parent->device, > This->format->nSamplesPerSec, buf_format, This->buf_size); Note that the buffer size given to OpenAL is in sample frames, not bytes. It's not a direct problem here, per se, but it may be an issue if a large size is requested (ie, where n samples would work, but n*2 or n*4 won't).

2 1

File owner permissions
by Ben Peddell Dec. 1, 2009

Dec. 1, 2009

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 What do you think is the best course of action for setting the owner permissions on a file: 1. Base the file owner permissions on the DACL permissions of the groups the file owner is a member of? (My patch or similar) 2. Change the file owner permissions only if they are listed in the DACL? (Paul Chitescu's patch or similar) 3. Allow the file owner read/write/traverse access (u+rwX) to their own files by default? (similar to #2) 4. Bypass the file-owner-permissions-cannot-be-overridden issue by having a third-party trustee (like SYSTEM) own and have full access to the files. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAksUuqAACgkQTHDAI68NsunuQACePqDXjcfvvDXhoEI0rH4WB5Ri 3+YAnjqioPVg9li+Axbo3vUMueqn9phd =pNiD -----END PGP SIGNATURE-----

1 0

dual platform win32/linux malware
by Dan Kegel Dec. 1, 2009

Dec. 1, 2009

The apocalypse approaches: http://ask.slashdot.org/article.pl?sid=09/12/01/0025213 Perhaps this will drive people towards using totally locked down systems...

2 1