December 2009 - Wine-Devel - list.winehq.org

Re: [1/6]user32:SwitchDesktop API Implementation (try 2)
by Vitaliy Margolen Dec. 13, 2009

Dec. 13, 2009

shanmukha sainath addepalli wrote: > Hi, > > These are the series of patches for the Implementation of > SwitchDesktop and OpenInputDesktop API in user32.dll. SwitchDesktop > API is useful for switching between two desktops. Multi desktop > applications use this API functionality to switch between desktops. > Each patch have to be atomic - it should compile on it's own and work. This and other patches in your series won't compile / work. > + SERVER_START_REQ( switch_desktop ) Here you depend on a service call that's not yet defined. Wine will not compile this way. Vitaliy.

1 0

Interfacing with AppDB database
by Sean Hodges Dec. 13, 2009

Dec. 13, 2009

Hey all, I'm hoping to write an application that interfaces with the AppDB database. Can anyone point me in the direction of who I can contact over this? There appears to be no Web service or obvious way to query AppDB beyond navigating the site itself. Could you CC me in any replies as well, as I'm not subscribed to this list. Thanks, Sean

3 2

Re: mshtml: Implement IHTMLImgElement get_Name
by Paul Vriens Dec. 13, 2009

Dec. 13, 2009

On 12/13/2009 12:11 PM, Alistair Leslie-Hughes wrote: > + ok_(__FILE__,line) (!lstrcmpW(sNameImage, tmp), "expected '%s' got '%s'\n", wine_dbgstr_w(sNameImage), wine_dbgstr_w(tmp)); Hi Alistair, Could you use strcmp_wa instead of lstrcmpW as that function is not present on Win9x/WinMe? -- Cheers, Paul.

1 0

meaning of "Hardware" field in bugzilla?
by Dan Kegel Dec. 13, 2009

Dec. 13, 2009

Does "mac" mean "powerpc mac only"? I rather thought it meant "apple macintosh", regardless of cpu. I ask because Austin has just gone through and changed lots of "mac" bugs to "pc" even though the bugs were on Intel macs, which just seems wrong.

8 8

Sound concerns
by Maarten Lankhorst Dec. 12, 2009

Dec. 12, 2009

Hi all, I believe most oconcerns about OpenAL have been addressed. One of the open questions was whether midi and wave would be synced. And I think the most likely answer is that they aren't, even on windows. On windows winmm midi drivers use winmm timeGetTime or QueryPerformanceCounter for DirectMusic. Sample accurate wave is used to sync with midi, by using exclusive mode or the asio model. If there are any other open concerns, apart from packaging, let me know, since I really want to get dsound openal merged. :) If there are still concerns that are open I would like to know, especially if they affect wasapi which is defined in include/audioclient.idl and audiopolicy.idl Cheers, Maarten.

3 5

Re: [3/3] winex11.drv: Use the old method to delete the desktop window.
by Alexandre Julliard Dec. 11, 2009

Dec. 11, 2009

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > @@ -516,6 +516,14 @@ static void handle_wm_protocols( HWND hwnd, XClientMessageEvent *event ) > HMENU hSysMenu; > POINT pt; > > + if (hwnd == GetDesktopWindow()) > + { > + /* The desktop window does not have a close button that we can > + * pretend to click. Therefore, we simply send it a close command. */ > + PostMessageW( hwnd, WM_X11DRV_DELETE_WINDOW, 0, 0 ); > + return; > + } You could just as well send the WM_SYSCOMMAND directly. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: WineD3D: Frontbuffers are always onscreen
by Henri Verbeet Dec. 11, 2009

Dec. 11, 2009

2009/12/10 Stefan Dösinger <stefan(a)codeweavers.com>: > @@ -6304,7 +6304,7 @@ HRESULT create_primary_opengl_context(IWineD3DDevice *iface, IWineD3DSwapChain * ... > - swapchain->context[0]->render_offscreen = swapchain->render_to_fbo; > + swapchain->context[0]->render_offscreen = surface_is_offscreen(target); This will introduce a warning, surface_is_offscreen() takes an IWineD3DSurface pointer. > - > - swapchain->context[0]->render_offscreen = swapchain->render_to_fbo; ... > + if(swapchain->context[0]) > + { > + swapchain->context[0]->render_offscreen = swapchain->render_to_fbo; > + } That's pretty ugly, couple of points: - It doesn't make sense for "render_to_fbo" to be TRUE for a swapchain without back buffer. - Setting "render_offscreen" is really the responsibility of the context_create() call, similar to create_primary_opengl_context(). - The line is actually wrong, the relevant context has been setup to render to the front buffer, so "render_offscreen" should always be FALSE, even if there is a back buffer.

2 6

Valgrind errors: 893 leaks, 105 conditional depends on uninit, 63 invalid read, 12 invalid write, ...
by Dan Kegel Dec. 11, 2009

Dec. 11, 2009

Here's a more detailed breakdown of the current valgrind warnings when running the wine test suite as of yesterday, with the ntdll/heap warnings suppressed (as they will be from now on): 1 --25396-- VALGRIND INTERNAL ERROR: Valgrind received a signal 11 (SIGSEGV) - exiting 1 vex x86->IR: unhandled instruction bytes: 0xFB 0xC3 0x0 0x0 2 Source and destination overlap 3 Use of uninitialised value of size 4 4 Invalid read of size 1 4 Invalid write of size 4 4 Unhandled exception: illegal instruction 5 Unhandled exception: page fault on write 7 Unhandled exception: page fault on read 7 Invalid free() / delete / delete[] 8 Invalid write of size 1 14 Syscall param writev(vector[...]) points to uninitialised byte(s) 19 Invalid read of size 4 40 Invalid read of size 2 105 Conditional jump or move depends on uninitialised value(s) 893 X bytes are definitely lost I think *all* the remaining invalid write errors are bogus, either they're in GetDIBits, in a video driver, or in the stack backtracing code. All of the remaining invalid free errors are in the oleaut32 vartype test: Invalid free() / delete / delete[] at notify_free (heap.c:255) by RtlFreeHeap (heap.c:1748) by SysFreeString (oleaut.c:194) by test_VarBstrFromDate (vartype.c:4910) by func_vartype (vartype.c:6276) by run_test (test.h:535) by main (test.h:585) Address 0x7f0a1560 is not stack'd, malloc'd or (recently) free'd for which I've filed http://bugs.winehq.org/show_bug.cgi?id=20992

1 0

UNC Pathname handling
by Alexandre Hardy Dec. 11, 2009

Dec. 11, 2009

Hi, I have written a patch to add basic UNC pathname support which tries to handle UNC pathnames according to the MSDN spec. The patch satisfies some of the UNC pathname tests for GetLongPathNameA, but is actually intended to fix GetLongPathNameW. I am not entirely satisfied with the patch, and would appreciate some comments. Some issues: 1) Paths prefixed by '\\?\' require GetLongPathName to handle strings of length 32767. I don't like the fact that the patch creates two such large strings on the local stack, should the memory be dynamically allocated only when needed? 2) The handling of shares \\hostname\C$ is implemented, but no other shares are handled. And even in this case, only the host on which wine is executed is handled, no other hosts are handled. I have read that Windows 7 disables this share by default. So should wine be handling this particular URL, or should more general sharing be implemented? The patch is included as an attachment to this message. Kind regards Alexandre -- -------------------------------------------------- Alexandre Hardy http://www.ahardy.za.net

2 16

Re: shdocvw: Fix test for non-english IE MUI (try 2)
by Nicolas Le Cam Dec. 11, 2009

Dec. 11, 2009

2009/12/11 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > Hi, > > > Changelog: > shdocvw: Fix test for non-english IE MUI > > Best Regards > Alistair Leslie-Hughes > > > > Hi Alistair, - ok(!strcmp_wa(sName, "Microsoft Web Browser Control"), "got '%s', expected 'Microsoft Web Browser Control'\n", wine_dbgstr_w(sName)); + if (PRIMARYLANGID(LANGIDFROMLCID(GetThreadLocale())) == LANG_ENGLISH) + ok(!strcmp_wa(sName, "Microsoft Web Browser Control"), "got '%s', expected 'Microsoft Web Browser Control'\n", wine_dbgstr_w(sName)); + else /* Non-English cannot be blant. */ + ok(sName!=NULL, "get_Name return a NULL string.\n"); Did you mean blank ? -- Nicolas Le Cam

1 0

Re: [PATCH 2/2] server: Include user groups in file mode calculation when user is file owner
by Alexandre Julliard Dec. 11, 2009

Dec. 11, 2009

"Ben Peddell" <klightspeed(a)netspace.net.au> writes: > @@ -474,7 +475,9 @@ mode_t sd_to_mode( const struct security_descriptor *sd, const SID *owner ) > if (access & FILE_EXECUTE) > denied_mode |= S_IXUSR|S_IXGRP|S_IXOTH; > } > - else if (security_equal_sid( sid, owner )) > + else if (security_equal_sid( sid, owner ) || > + (security_equal_sid( user, owner ) && > + token_sid_present( current->process->token, sid, TRUE ))) > { > unsigned int access = generic_file_map_access( ad_ace->Mask ); > if (access & FILE_READ_DATA) > @@ -498,7 +501,9 @@ mode_t sd_to_mode( const struct security_descriptor *sd, const SID *owner ) > if (access & FILE_EXECUTE) > new_mode |= S_IXUSR|S_IXGRP|S_IXOTH; > } > - else if (security_equal_sid( sid, owner )) > + else if (security_equal_sid( sid, owner ) || > + (security_equal_sid( user, owner ) && > + token_sid_present( current->process->token, sid, FALSE ))) You should most likely set the group permissions too in that case. -- Alexandre Julliard julliard(a)winehq.org

2 3

Unable to cleanly install cups-devel.i686 on a Fedora 12 x86_64 machine
by Alex Villacís Lasso Dec. 11, 2009

Dec. 11, 2009

I have just updated my setup to Fedora 12 on 64 bits, and I want to compile Wine for this setup. I followed the instructions at: http://wiki.winehq.org/WineOn64bit on the section for Fedora 12. However, I have the following error when trying to install the packages as directed by the wiki: Error en la verificación de la transacción: file /usr/bin/cups-config from install of cups-devel-1:1.4.2-7.fc12.i686 conflicts with file from package cups-devel-1:1.4.2-7.fc12.x86_64 Resumen de errores ------------- What I understand from this is that /usr/bin/cups-config is provided by both packages, and cannot be marked as shared by both packages. I want to have both 32 and 64-bit support for compiling programs that use CUPS. Does this problem have a clean workaround? Or should I complain instead to the Fedora packagers?

5 4

Re: [2/3] wineboot: Terminate processes immediately after WM_ENDSESSION.
by Juan Lang Dec. 10, 2009

Dec. 10, 2009

Hi Vincent, - /* wait for app to quit on its own for a while */ - ret = WaitForSingleObject( process_handle, PROCQUIT_TIMEOUT ); + /* Check whether the app quit on its own */ + ret = WaitForSingleObject( process_handle, 0 ); CloseHandle( process_handle ); if (ret == WAIT_TIMEOUT) I'm confused why you removed the timeout. The documented behavior[1, 2] is to wait a short timeout, show a dialog if the app hasn't quit by then, then kill it. This change makes wineboot terminate a process immediately. Is this really necessary to fix the bug? I'd expect that you want to handle the WAIT_OBJECT_0 case in addition to the WAIT_TIMEOUT case, and leave the timeout alone. --Juan [1] http://blogs.msdn.com/michen/archive/2008/04/04/Application-termination-whe… [2] http://blogs.msdn.com/oldnewthing/archive/2008/04/21/8413175.aspx

2 2

Leaks galore!
by Dan Kegel Dec. 10, 2009

Dec. 10, 2009

http://kegel.com/wine/valgrind/logs/2009-12-05-01.15/ shows the same results as http://kegel.com/wine/valgrind/logs/2009-12-04-18.45/ but with a looser filter, i.e. I now even show files whose only sin is a memory leak (in the past, I had suppressed those because I cared more about non-leak errors). It also suppresses several more persistent sources of warnings, for which I've filed a couple bugs: http://bugs.winehq.org/show_bug.cgi?id=20917 http://bugs.winehq.org/show_bug.cgi?id=20919 With those changes, I now see 457 non-leak errors, (~134 of which are due to the fresh regression http://bugs.winehq.org/show_bug.cgi?id=20920 ) and 1560 leak errors (~300 of which are due to ntlm_auth, which I'm still trying to suppress), in the wine conformance test suite.

5 12

Re: [ddraw/tests] Fix some test failures on Vista+
by Stefan Dösinger Dec. 10, 2009

Dec. 10, 2009

Am 10.12.2009 um 13:21 schrieb Paul Vriens: > <0004-Fix-some-test-failures-on-Vista.patch> > const char *name; > DDPIXELFORMAT fmt; > BOOL getdc_capable; > + HRESULT alt_result; > } testdata[] = { You are setting the alt_result only for the 4 failing tests. I think C sets the others to 0 because the initializer is static data I think its better to explicitly set it in all other test formats to avoid confusion

2 4

Re: winedbg: Add spanish translation
by Paul Vriens Dec. 10, 2009

Dec. 10, 2009

On 12/09/2009 03:30 AM, Jaime Rave wrote: > +LANGUAGE LANG_SPANISH, SUBLANG_DEFAULT Hi, Shouldn't this one need a SUBLANG_NEUTRAL instead? Or is this translation specific to "Spanish (Traditional Sort)"? See also: http://wiki.winehq.org/SublangNeutral -- Cheers, Paul.

1 0

Re: [PATCH 2/2] mmdevapi: add some initial tests
by Alexandre Julliard Dec. 10, 2009

Dec. 10, 2009

1 0

Re: [PATCH 2/7] dsound: Clean up DSPROPERTY_DescriptionW, try 2
by Detlef Riekenberg Dec. 10, 2009

Dec. 10, 2009

On Mi, 2009-12-09 at 16:57 +0100, Maarten Lankhorst wrote: > + { > + /* FIXME: Still a memory leak.. */ This should be fixed before sending to wine-patches -- By by ... Detlef

2 1

Re: [3/5] WineD3D: Test and fix ddraw and d3d9 GetDC differences
by Paul Vriens Dec. 10, 2009

Dec. 10, 2009

On 09/05/2009 04:54 PM, Stefan Dösinger wrote: > This patch uses a d3d9-side filter in favor of adding a 2nd set of > getdc-capable format flags. > Hi Stefan, These tests have failures on Vista+ boxes: dsurface.c:3243: Test failed: GetDC on a D3DFMT_X8B8G8R8 surface failed(0x88760249), expected it to work dsurface.c:3243: Test failed: GetDC on a D3DFMT_X8B8G8R8 surface failed(0x88760249), expected it to work dsurface.c:3243: Test failed: GetDC on a D3DFMT_A4R4G4B4 surface failed(0x88760249), expected it to work dsurface.c:3243: Test failed: GetDC on a D3DFMT_X4R4G4B4 surface failed(0x88760249), expected it to work These are real ones with NVIDIA, ATI and Intel cards but also VMware boxes with the latest VMware driver "VMware SVGA 3D (Microsoft Corporation - WDDM)". Should I change the test to introduce an alternative result for these 4 formats? -- Cheers, Paul.

2 1

Re: [PATCH 3/4] jscript: Added Function constructor tests.
by Detlef Riekenberg Dec. 10, 2009

Dec. 10, 2009

On Do, 2009-12-10 at 01:15 +0100, Jacek Caban wrote: > +func = new Function(); > +tmp = func(); > +ok(tmp === undefined, "func(1,3,2) = " + tmp) Greetings from Copy & Paste -- By by ... Detlef

1 0

Re: Wine performance improvement
by 임은지 Dec. 9, 2009

Dec. 9, 2009

Dan Kegel wrote: > > > Interesting! Clearly a long ways off from production-ready, but > it's fun to see somebody trying this. > > A few notes: > > Please clean up the patch a bit to remove lines like this: > +//FIXME("handle : %ld \n", handle); > and extra files like > dlls/ws2_32/tests/test.sh > > Please avoid hand-editing > include/wine/server_protocol.h > The start of the file even says: > * This file is automatically generated; DO NO EDIT! > * Edit server/protocol.def instead and re-run tools/make_requests > > Please switch to plain text for future posts. It's very > hard to read in the archive; see > http://www.winehq.org/pipermail/wine-devel/2009-December/080394.html > > Please identify the author(s) of the new code for copyright purposes, > and ensure they agree to licensing their code under the LGPL (for Wine) > and GPL (for Linux kernel). > > I'm sure other people will have more to say. > Thank you for your comments. I will cleanup the patch as you suggested and send it.

3 2

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.
by Ken Thomases Dec. 9, 2009

Dec. 9, 2009

The call to setenv() has 0 (false) as its third parameter, so that LANG is not overwritten. -Ken On Nov 23, 2009, at 9:12 AM, Charles Davis wrote: > --- > dlls/kernel32/locale.c | 53 > +++++++++++++++++++++++++---------------------- > 1 files changed, 28 insertions(+), 25 deletions(-) > > > > diff --git a/dlls/kernel32/locale.c b/dlls/kernel32/locale.c > index fb9b517..d9ea8eb 100644 > --- a/dlls/kernel32/locale.c > +++ b/dlls/kernel32/locale.c > @@ -2925,32 +2925,35 @@ void LOCALE_Init(void) > UINT ansi_cp = 1252, oem_cp = 437, mac_cp = 10000, unix_cp; > > #ifdef __APPLE__ > - /* MacOS doesn't set the locale environment variables so we have to do it ourselves */ > - CFArrayRef preferred_locales, all_locales; > CFStringRef user_language_string_ref = NULL; > - char user_locale[50]; > - char* p; > - > - CFLocaleRef user_locale_ref = CFLocaleCopyCurrent(); > - CFStringRef user_locale_string_ref = CFLocaleGetIdentifier( user_locale_ref ); > - > - CFStringGetCString( user_locale_string_ref, user_locale, sizeof(user_locale), kCFStringEncodingUTF8 ); > - CFRelease( user_locale_ref ); > - /* Strip modifiers because setlocale() can't parse them. */ > - if ((p = strchr( user_locale, '@' ))) *p = 0; > - if (!strchr( user_locale, '.' )) strcat( user_locale, ".UTF-8" ); > - unix_cp = CP_UTF8; /* default to utf-8 even if we don't get a valid locale */ > - setenv( "LANG", user_locale, 0 ); > - TRACE( "setting locale to '%s'\n", user_locale ); > - > - /* We still want to set the retrieve the preferred language as chosen in > - System Preferences.app, because it can differ from CFLocaleCopyCurrent(). > - */ > - all_locales = CFLocaleCopyAvailableLocaleIdentifiers(); > - preferred_locales = CFBundleCopyLocalizationsForPreferences( all_locales, NULL ); > - if (preferred_locales && CFArrayGetCount( preferred_locales )) > - user_language_string_ref = CFArrayGetValueAtIndex( preferred_locales, 0 ); > - CFRelease( all_locales ); > + if (!getenv( "LANG" )) > + { > + /* MacOS doesn't set the locale environment variables so we have to do it ourselves */ > + CFArrayRef preferred_locales, all_locales; > + char user_locale[50]; > + char* p; > + > + CFLocaleRef user_locale_ref = CFLocaleCopyCurrent(); > + CFStringRef user_locale_string_ref = CFLocaleGetIdentifier( user_locale_ref ); > + > + CFStringGetCString( user_locale_string_ref, user_locale, sizeof(user_locale), kCFStringEncodingUTF8 ); > + CFRelease( user_locale_ref ); > + /* Strip modifiers because setlocale() can't parse them. */ > + if ((p = strchr( user_locale, '@' ))) *p = 0; > + if (!strchr( user_locale, '.' )) strcat( user_locale, ".UTF-8" ); > + unix_cp = CP_UTF8; /* default to utf-8 even if we don't get a valid locale */ > + setenv( "LANG", user_locale, 0 ); > + TRACE( "setting locale to '%s'\n", user_locale ); > + > + /* We still want to set the retrieve the preferred language as chosen in > + System Preferences.app, because it can differ from CFLocaleCopyCurrent(). > + */ > + all_locales = CFLocaleCopyAvailableLocaleIdentifiers(); > + preferred_locales = CFBundleCopyLocalizationsForPreferences( all_locales, NULL ); > + if (preferred_locales && CFArrayGetCount( preferred_locales )) > + user_language_string_ref = CFArrayGetValueAtIndex( preferred_locales, 0 ); > + CFRelease( all_locales ); > + } > #endif /* __APPLE__ */ > > setlocale( LC_ALL, "" ); > > >

7 19

Regression on Tuesday Dec 8
by Susan Cragin Dec. 9, 2009

Dec. 9, 2009

I was installing Dragon NaturallySpeaking on Tuesday with git and noticed that it was very slow to load. In addition, the "automatic" registration doesn't work as well as it used to. The link to the Scansoft site, to generate the code, does not work. Regression test? Sigh.

1 0

Re: [1/5] ole32: Change the base IStorage filename to a pointer type.
by Paul Vriens Dec. 9, 2009

Dec. 9, 2009

On 12/07/2009 10:17 PM, Vincent Povirk wrote: > + /* Stat always returns the full path, even for files opened with a relative path. */ > + GetCurrentDirectoryW(MAX_PATH, prev_dir); > + > + GetTempPathW(MAX_PATH, temp); > + > + SetCurrentDirectoryW(temp); > + > + GetFullPathNameW(filename, MAX_PATH, full_path,&rel_path); > + > + r = StgCreateDocfile( rel_path, STGM_CREATE | STGM_SHARE_EXCLUSIVE | > + STGM_READWRITE |STGM_TRANSACTED, 0,&stg); Hi Vincent, These tests currently crash on Win9x/WinME due . I rewrote that test to just use A-functions but there are loads of lstrcmpW tests that of course always fail on Win9x (not implemented). Do you think it's worthwhile changing these tests to cope with Win9x/WinMe? -- Cheers, Paul.

2 2

Re: libs/wine: don't try to read() a directory
by Alexandre Julliard Dec. 9, 2009

Dec. 9, 2009

Dan Kegel <dank(a)kegel.com> writes: > Fixes http://bugs.winehq.org/show_bug.cgi?id=20942 Introducing an fd leak to fix a Valgrind warning is not much of an improvement ;-) -- Alexandre Julliard julliard(a)winehq.org

2 1