December 2009 - Wine-Devel - list.winehq.org

Re: [PATCH 1/6] mshtml: Forward IHTMLFrameElement::get_dispid and invoke to its content window
by Jacek Caban Dec. 7, 2009

Dec. 7, 2009

Hi Andrew, This idea looks bad. What are you trying to fix? Jacek

2 1

dxgi:device tests crash on X64_64
by Paul Vriens Dec. 7, 2009

Dec. 7, 2009

Hi Henri, I'm trying to fix at least the crashes on X64_64 for this test. The tests are done on a Windows 7 64bit VMware guest. The strange thing is that when I crosscompile the tests as is (64bit of course) the tests don't crash. When I add the following (first thing): BOOL is_wow64; IsWow64Process( GetCurrentProcess(), &is_wow64 ); the tests crashes at DXGID3D10CreateDevice() in create_device(). I added that IsWow64Process() just to see if I was indeed running the 64bit version of the test. Any idea what's going on? -- Cheers, Paul.

2 7

Re: [PATCH] winhttp: check for endCert being NULL (Coverity)
by Juan Lang Dec. 6, 2009

Dec. 6, 2009

Hi Marcus, - if (ret) + if (ret && endCert) ret = netconn_verify_cert( endCert, store, server ); In this case you'll return TRUE if endCert is NULL, implying that the certificate chain is valid when it most likely isn't, or at least its validity couldn't be verified. If you could add an "else ret = FALSE" branch that'd be preferable. Thanks, --Juan

1 0

Re: ole32: Fix invalid memory access in storage32
by Huw Davies Dec. 6, 2009

Dec. 6, 2009

Nathan Gallaher wrote: > > In StorageImpl_construct(): > For pwcsName strings shorter than DIRENTRY_NAME_BUFFER_LEN-1, an invalid > read would be noted by valgrind as the memcpy wanders off the end of the > string. Do the needful to calculate the required string length. By the way, in storage32.h the filename member of struct StorageBaseImpl is declared as WCHAR filename[DIRENTRY_NAME_BUFFER_LEN]; shouldn't it be WCHAR filename[DIRENTRY_NAME_MAX_LEN]; ? Huw.

3 2

Re: listview: Fix LISTVIEW_CancelEditLabel to not save the changed text
by Nikolay Sivov Dec. 6, 2009

Dec. 6, 2009

Jeff Latimer wrote: > --- > dlls/comctl32/listview.c | 2 +- > dlls/comctl32/tests/listview.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Hi, Jeff. This is obviously wrong. Test will fail on native systems after your patch. What is a problem with current code, any bugs reported?

2 2

Using trace in tests
by James McKenzie Dec. 6, 2009

Dec. 6, 2009

All: I'm asking a question again, don't 'shoot' me, but I've noticed the use of the trace() function in tests and I would like to use this to troubleshoot what is incorrect in the EM_FORMATRANGE patch as it is not passing on MacOSX builds. The test appears to pass on WindowsXP sp2 as the failures did not appear in the winetest_latest for Wine-1.1.33. So, how do I enable the trace's I've added for testing so that I can fix the patch? Thank you. James McKenzie

2 5

Re: [PATCH 1/7] dsound: Remove support for IKsPropertySet for now
by Robert Reif Dec. 5, 2009

Dec. 5, 2009

Maarten Lankhorst wrote: > -- > As I said, I'm confident nobody uses it, since wine never implemented it properly anyway > --- > I think you will find that you will have to add it back later because both interfaces are commonly used. The private interface is used for enumerating devices and is the only way of getting some information about the actual hardware. The buffer interface is commonly used to determine special hardware effects. Programs do check even if wine doesn't implement them because most windows sound cards don't either. In fact, now that you will be using openal you might have the opportunity to actually add real effects!

8 17

Re: shdocvw: Implement IWebBrowser2_get_Name
by Paul Vriens Dec. 5, 2009

Dec. 5, 2009

On 12/04/2009 12:51 PM, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > shdocvw: Implement IWebBrowser2_get_Name > > Best Regards > Alistair Leslie-Hughes > > Hi Alistair, This one introduces a test failure on non-English boxes: https://winetestbot.geldorp.nl/JobDetails.pl?Key=49 or http://test.winehq.org/data/6b8c9aee4fd57ac1f2f949992b3c5a6702f780a2/xp_wtb… (which is the same box btw). Could you have a look? -- Cheers, Paul.

1 1

Re: shell32: Fix a test failure on 64-bit systems.
by Vincent Povirk Dec. 5, 2009

Dec. 5, 2009

Don't commit this. It seems the failure does not appear on 64-bit Windows systems, which means that the test is actually correct and the implementation needs to be fixed. On Fri, Dec 4, 2009 at 11:59 AM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > > > > -- Vincent Povirk

1 0

Re: Juan Lang : winhttp: Check the certificate in an https connection using the crypto api.
by Michael Stefaniuc Dec. 4, 2009

Dec. 4, 2009

Juan, On 12/04/2009 04:11 PM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 82d07c405168df59db17d298bc3b8476f13540e9 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=82d07c405168df59db17d298b… > > Author: Juan Lang<juan.lang(a)gmail.com> > Date: Thu Dec 3 11:28:40 2009 -0800 > > winhttp: Check the certificate in an https connection using the crypto api. this breaks compilation on Fedora 12; F11 works fine though. gcc -c -I/home/michi/work/wine/dlls/winhttp -I. -I/home/michi/work/wine/include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o net.o /home/michi/work/wine/dlls/winhttp/net.c /home/michi/work/wine/dlls/winhttp/net.c: In function ‘netconn_secure_verify’: /home/michi/work/wine/dlls/winhttp/net.c:342: error: ‘struct stack_st_X509’ has no member named ‘num’ /home/michi/work/wine/dlls/winhttp/net.c:346: error: ‘struct stack_st_X509’ has no member named ‘data’ /home/michi/work/wine/dlls/winhttp/net.c: In function ‘netconn_init’: /home/michi/work/wine/dlls/winhttp/net.c:450: warning: assignment discards qualifiers from pointer target type make: *** [net.o] Error 1 bye michael

2 2

Re: mshtml: Added PersistStreamInit_InitNew implementation
by Jacek Caban Dec. 4, 2009

Dec. 4, 2009

Hi Piotr, Piotr Caban wrote: > --- > dlls/mshtml/mshtml_private.h | 1 + > dlls/mshtml/nsevents.c | 25 ++++++----- > dlls/mshtml/persist.c | 84 +++++++++++++++++++++++++++++------- > dlls/mshtml/tests/htmldoc.c | 95 > ++++++++++++++++++++++++++++++++++++++++-- > 4 files changed, 173 insertions(+), 32 deletions(-) hres = IOleClientSite_QueryInterface(doc->client, &IID_IOleCommandTarget, (void**)&olecmd); if(SUCCEEDED(hres)) { - VARIANT state, progress; - - V_VT(&progress) = VT_I4; - V_I4(&progress) = 0; - IOleCommandTarget_Exec(olecmd, NULL, OLECMDID_SETPROGRESSPOS, OLECMDEXECOPT_DONTPROMPTUSER, - &progress, NULL); - - V_VT(&state) = VT_I4; - V_I4(&state) = 0; - IOleCommandTarget_Exec(olecmd, NULL, OLECMDID_SETDOWNLOADSTATE, OLECMDEXECOPT_DONTPROMPTUSER, - &state, NULL); + if(doc->download_state) { + VARIANT state, progress; + + V_VT(&progress) = VT_I4; + V_I4(&progress) = 0; + IOleCommandTarget_Exec(olecmd, NULL, OLECMDID_SETPROGRESSPOS, + OLECMDEXECOPT_DONTPROMPTUSER, &progress, NULL); + + V_VT(&state) = VT_I4; + V_I4(&state) = 0; + IOleCommandTarget_Exec(olecmd, NULL, OLECMDID_SETDOWNLOADSTATE, + OLECMDEXECOPT_DONTPROMPTUSER, &state, NULL); + } + doc->download_state = 0; You should clear download_state if client doesn't implement IOleCommandTarget interface too. Thanks, Jacek

1 0

Re: [4/6] WineD3D: Infrastructure to render swapchains to a FBO
by Henri Verbeet Dec. 4, 2009

Dec. 4, 2009

2009/12/4 Stefan Dösinger <stefan(a)codeweavers.com>: > hr = create_primary_opengl_context(iface, (IWineD3DSwapChain *) swapchain); > + if(SUCCEEDED(hr)) > + { > + swapchain->context[0]->render_offscreen = swapchain->render_to_fbo; > + } This should probably be part of create_primary_opengl_context(). > +static inline void swapchain_blit(IWineD3DSwapChainImpl *This, struct wined3d_context *context) It's kind of obvious because of the "context" parameter, but for consistency please document the requirement for the caller to provide an active context.

1 0

Re: [2/6] WineD3D: A function for checking if a surface is offscreen
by Henri Verbeet Dec. 4, 2009

Dec. 4, 2009

2009/12/4 Stefan Dösinger <stefan(a)codeweavers.com>: > GLenum buffer = surface_get_gl_buffer((IWineD3DSurface *) This, (IWineD3DSwapChain *)swapchain); > + > + IWineD3DSurface_GetContainer((IWineD3DSurface *) This, &IID_IWineD3DSwapChain, (void **)&swapchain); That doesn't look quite right. Also, you should check the return value for GetContainer().

1 0

Locale data update request
by Nikolay Sivov Dec. 4, 2009

Dec. 4, 2009

Hi, guys. I've finally got some time today to complete genitive name support in GetDateFormat(). Now to make it useful for users I'd like to ask translators to update NLS files for languages that use this month form. I'm sure it's present in some Slavonic languages like Ukrainian and Belorussian, maybe some others (Asian?) too. Thanks.

1 0

Anti aliased fonts in wine - minimum font size
by Avery Pennarun Dec. 4, 2009

Dec. 4, 2009

Hi all, I'm using Microsoft Office 2002 under wine. According to the instructions here: http://www.wine-reviews.net/wine-reviews/tips-n-tricks/how-to-enable-font-a… ...I've enabled font anti-aliasing, and it does work for fonts above a particular point size. However, it seems to turn itself off below a certain size. How can I configure the minimum font size at which to allow anti-aliasing? I've looked through the wine source and didn't see any obvious references to font size in the anti-aliasing-related code. Thanks, Avery

4 7

Re: ntdll: add partial support for HEAP_FREE_CHECKING_ENABLED heap overrun detection (take 3)
by Alexandre Julliard Dec. 4, 2009

Dec. 4, 2009

Dan Kegel <dank(a)kegel.com> writes: > @@ -1261,6 +1297,8 @@ HANDLE WINAPI RtlCreateHeap( ULONG flags, PVOID addr, SIZE_T totalSize, SIZE_T c > totalSize = HEAP_DEF_SIZE; > flags |= HEAP_GROWABLE; > } > + if (NtCurrentTeb() && NtCurrentTeb()->Peb && (NtCurrentTeb()->Peb->NtGlobalFlag & FLG_HEAP_ENABLE_FREE_CHECK)) > + flags |= HEAP_FREE_CHECKING_ENABLED; This can't work, you can't use NtCurrentTeb before the TEB is properly initialized. -- Alexandre Julliard julliard(a)winehq.org

1 0

WineConf 2009 videos
by Julius Schwartzenberg Dec. 4, 2009

Dec. 4, 2009

Hi, All the videos from WineConf 2009 are online now. The links can be found on the wiki page: http://wiki.winehq.org/WineConf2009 Because my camera isn't the greatest, Audacity was used to remove the noise from the audio track and using Kdenlive with melt the keynote video was filtered to make things somewhat visible again (the lights were off during that presentation). Thanks a lot to Roderick Colenbrander and grub_booter from #kdenlive, who helped me a lot with all of this :) Let me know if you have any comments on the videos! Thanks, Julius

1 0

d3d8 test failure, more details.
by David Anderson Dec. 4, 2009

Dec. 4, 2009

Thanks to James Mckenzie and Austin English for earlier hints. I've installed more stuff (ubuntu packages) and spent a bit more time with d3d8. I assume most people get these tests to work, so I'm a bit distressed I cannot seem to get them to work properly, 100%. The large amount of test code that 'just works' is impressive. I'd be reassured I was not breaking things in any patch I submit if I could figure out why I'm not getting 100% (that is, what the heck might I be doing wrong?). Any hints/suggestions would be welcome. In dlls/d3d8/tests/visual.c one has the call that gets errors: 1357 if (caps.VertexShaderVersion >= D3DVS_VERSION(1, 1)) 1358 { 1359 test_rcp_rsq(device_ptr); 1360 } and test_rcp_rsq() does some *VertexShade calls not made elsewhere. The last few lines of 'make test' output in d3d8/tests are: fixme:d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface fixme:d3d_draw:drawPrimitive Using software emulation because manual fog coordinates are provided visual.c:598: Test failed: Color components differ: c1 = 80, c2 = 00, c3 = 80 visual.c:632: Test failed: Color components differ: c1 = 80, c2 = 00, c3 = 80 visual.c:634: Test failed: Color component value is 80 make: *** [visual.ok] Error 3 These failures are in test_rcp_rsq(), the function called at line 1359. Note that other calls to to getPixelColor() (a function in the test code, tests/visual.c) work fine. Only when a couple of special Shaders are invoked does getPixelColor() get something the test does not expect. Possibly IDirect3DDevice8_CreateVertexShader() is not setting things up right or somehow the 'DRI' code in package libgl1-mesa-dri is not being effective? I stuck a couple sleep(5) calls in the test source (to slow things down at the error points) and I can see the shader code has an effect visually (the test code generates small-ish windows with color blocks). Compiling d3d8 and its test code -g (that is, no -O2) gets exactly the same results. Ubuntu9.10. Intel(R) Core(TM)2 Duo CPU E8500 cpu. ATI 4350 PCI graphics. q2 616: dpkg-query -l '*mesa*' Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Cfg-files/Unpacked/Failed-cfg/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name Version Description +++-==============-==============-============================================ un libgl1-mesa <none> (no description available) ii libgl1-mesa-de 7.6.0-1ubuntu4 A free implementation of the OpenGL API -- G ii libgl1-mesa-dr 7.6.0-1ubuntu4 A free implementation of the OpenGL API -- D ii libgl1-mesa-dr 7.6.0-1ubuntu4 Debugging symbols for the Mesa DRI modules un libgl1-mesa-dr <none> (no description available) ii libgl1-mesa-gl 7.6.0-1ubuntu4 A free implementation of the OpenGL API -- G ii libgl1-mesa-gl 7.6.0-1ubuntu4 Debugging symbols for the Mesa GLX runtime un libgl1-mesa-sw <none> (no description available) ii libglu1-mesa 7.6.0-1ubuntu4 The OpenGL utility library (GLU) ii libglu1-mesa-d 7.6.0-1ubuntu4 The OpenGL utility library -- development fi ii mesa-common-de 7.6.0-1ubuntu4 Developer documentation for Mesa un mesa-glide2-de <none> (no description available) ii mesa-utils 7.6.0-1ubuntu4 Miscellaneous Mesa GL utilities un mesag-dev <none> (no description available) un mesag3 <none> (no description available) un mesag3+ggi-dev <none> (no description available) un xlibmesa-dev <none> (no description available) un xlibmesa-dri <none> (no description available) ii xlibmesa-gl-de 1:7.4+3ubuntu1 transitional package for Debian etch un xlibmesa-glu-d <none> (no description available) un xlibmesa3 <none> (no description available) un xlibosmesa-dev <none> (no description available) The 'libgl1-mesa-swx11*' packages are not installed, swx11 seems to be incompatible with some of the mesa stuff above (according to synaptic package manager). Any hints/suggestions would be welcome.

2 1

Please Review - Revised OS X Application Bundle patch
by Steven Edwards Dec. 4, 2009

Dec. 4, 2009

Hi, If any of the OS X hackers have time, could you guys take a look at the following patch? I'd like to get it in to move on to more interesting stuff like the icon generation cleanup in winemenubuilder using windowscodecs.dll, OS X association support and perhaps even proper dock integration. I've been testing this with the PowerPoint 2003 viewer and it works for me. I'd be interested in hearing if anyone has trouble with other applications. You need to have Wine installed somewhere in your path or you will need to manually hardcode the path to your wine executable in the script generator just like with the menu builder on the linux side. I don't like the amount of #ifdef'ing I had to do but didn't really see a better way. I know before Alexandre will accept he most likely will want me to - Cleanup comments a bit. - Maybe shorten some of the variable and function names So I am looking for any other feedback you have. Documentation on bundles can be found at the following location http://developer.apple.com/mac/library/documentation/CoreFoundation/Concept… Changelog: Implement Application Bundle support for OS X using the CoreFoundation to generate Information Property Lists Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: shell32: Implement IPersistFile_fnSaveCompleted
by Nikolay Sivov Dec. 3, 2009

Dec. 3, 2009

Vladimir Pankratov wrote: > Hello all. > > Implemented IPersistFile_fnSaveCompleted. > > changed files: > dlls/shell32/shelllink.c > > Thanks. --- + TRACE("(%p)->(%s)\n",This,debugstr_w(pszFileName)); + return S_OK; /* MSDN says: return value S_OK, returned in all cases */ --- You shouldn't care much of what MSDN says, please provide some tests.

1 0

Fixing the kernel32:actctx tests on Vista+
by Paul Vriens Dec. 3, 2009

Dec. 3, 2009

Hi Jacek, You are the original author of these tests. Is there any reason the "test3.manifest" name is reused? The tests currently crash (intermittently on some) on Vista+ and with the attached patch things seem to get better. I'm just renaming one of the manifest files so there are no duplicates in these tests. -- Cheers, Paul.

4 7

Re: [PATCH 1/2] msvcrt: Add test to check if signal(SIGBREAK, ...) works (todo_wine).
by Charles Davis Dec. 3, 2009

Dec. 3, 2009

You don't get added to AUTHORS until you've hacked on Wine enough. I learned that the hard way when I tried to put my name at the top of an already-existing file. Chip

4 3

Re: [4/6] WineD3D: Infrastructure to render swapchains to a FBO
by Henri Verbeet Dec. 3, 2009

Dec. 3, 2009

2009/12/2 Stefan Dösinger <stefan(a)codeweavers.com>: > @@ -1082,6 +1082,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl_CreateSwapChain(IWineD3DDevice *iface, > object->wineD3DDevice = This; > object->parent = parent; > object->ref = 1; > + object->render_to_fbo = FALSE; This is redundant, the field is already initialized to 0. > @@ -1880,6 +1881,9 @@ static HRESULT WINAPI IWineD3DDeviceImpl_Init3D(IWineD3DDevice *iface, > > switch(wined3d_settings.offscreen_rendering_mode) { > case ORM_FBO: > + This->offscreenBuffer = GL_COLOR_ATTACHMENT0; This change is probably correct, but note that if it matters you're probably doing something wrong. > @@ -959,22 +963,25 @@ static void read_from_framebuffer(IWineD3DSurfaceImpl *This, CONST RECT *rect, v ... > @@ -3102,7 +3109,7 @@ static inline void fb_copy_to_texture_direct(IWineD3DSurfaceImpl *This, IWineD3D ... > @@ -3241,12 +3248,12 @@ static inline void fb_copy_to_texture_hwstretch(IWineD3DSurfaceImpl *This, IWine Most of this should be part of patch 3. Note that since we have SFLAG_SWAPCHAIN we don't really need to pass the swapchain to surface_get_gl_buffer() anymore, we can just cast This->container directly to IWineD3DSwapChainImpl *. > +static inline void swapchain_blit(IWineD3DSwapChainImpl *This, struct wined3d_context *context) We have a number of functions now that do something very similar to what this function does. Perhaps it's time to spend some time on our blitter in order to unify those?

2 3

Re: [5/6] imagehlp: Recalculate PE checksum after file modification
by Alexandre Julliard Dec. 3, 2009

Dec. 3, 2009

Owen Rudge <orudge(a)codeweavers.com> writes: > +static BOOL IMAGEHLP_RecalculateChecksum(HANDLE handle) > +{ > + IMAGE_DOS_HEADER dos_hdr; > + IMAGE_NT_HEADERS nt_hdr; > + HANDLE hMapping; > + LPVOID BaseAddress; > + DWORD FileLength, count, HeaderSum, CheckSum = 0; > + BOOL r; > + > + TRACE("handle %p\n", handle); > + > + /* read the DOS header */ > + count = SetFilePointer(handle, 0, NULL, FILE_BEGIN); > + > + if (count == INVALID_SET_FILE_POINTER) > + return FALSE; > + > + count = 0; > + > + r = ReadFile(handle, &dos_hdr, sizeof dos_hdr, &count, NULL); > + > + if (!r) > + return FALSE; > + > + if (count != sizeof dos_hdr) > + return FALSE; > + > + /* verify magic number of 'MZ' */ > + if (dos_hdr.e_magic != 0x5A4D) > + return FALSE; > + > + /* read the PE header */ > + count = SetFilePointer(handle, dos_hdr.e_lfanew, NULL, FILE_BEGIN); > + > + if (count == INVALID_SET_FILE_POINTER) > + return FALSE; > + > + count = 0; > + r = ReadFile(handle, &nt_hdr, sizeof nt_hdr, &count, NULL); > + > + if (!r) > + return FALSE; > + > + if (count != sizeof nt_hdr) > + return FALSE; > + > + /* verify NT signature */ > + if (nt_hdr.Signature != IMAGE_NT_SIGNATURE) > + return FALSE; Please write a helper for this, we don't need 3 implementations of the same thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/6] imagehlp: Verify magic numbers and pad certificates to 8 byte boundaries
by Alexandre Julliard Dec. 3, 2009

Dec. 3, 2009

Owen Rudge <orudge(a)codeweavers.com> writes: > @@ -64,6 +64,10 @@ static BOOL IMAGEHLP_GetSecurityDirOffset( HANDLE handle, > if( count != sizeof dos_hdr ) > return FALSE; > > + /* verify magic number of 'MZ' */ > + if( dos_hdr.e_magic != 0x5A4D ) > + return FALSE; > + > /* read the PE header */ > count = SetFilePointer( handle, dos_hdr.e_lfanew, NULL, FILE_BEGIN ); > if( count == INVALID_SET_FILE_POINTER ) > @@ -75,6 +79,10 @@ static BOOL IMAGEHLP_GetSecurityDirOffset( HANDLE handle, > if( count != sizeof nt_hdr ) > return FALSE; > > + /* verify NT signature */ > + if( nt_hdr.Signature != IMAGE_NT_SIGNATURE ) > + return FALSE; > + > sd = &nt_hdr.OptionalHeader. > DataDirectory[IMAGE_FILE_SECURITY_DIRECTORY]; You also need to check the optional header magic to differentiate between 32-bit and 64-bit PE files. -- Alexandre Julliard julliard(a)winehq.org

1 0