December 2009 - Wine-Devel - list.winehq.org

Broken-down time (struct tm)
by Erich Hoover Dec. 20, 2009

Dec. 20, 2009

I will soon have access to a network license for a piece of software that uses the Sentinel Protection Driver (ie. I do not need USB support), so I am looking into implementing ExSystemTimeToLocalTime (Bug 19395) so that the driver will work properly. In the process of researching a good way to support this feature I found that the "broken-down time structure" (struct tm) has a member for the local timezone offset from GMT (tm_gmtoff). According to the man pages this feature requires that _BSD_SOURCE be defined before including time.h; however, I found this member being used in dlls/msvcrt/time.c without this #define. So, the question I have is whether it is OK to use tm_gmtoff in Wine (whether there is a portability concern) and the proper way to include time.h to use this feature. Erich Hoover ehoover(a)mines.edu

2 2

Recent User32 <=> windowClass assembly findings
by Nikolay Sivov Dec. 20, 2009

Dec. 20, 2009

Hopefully my first attempt to implement class redirection wasn't committed --- http://source.winehq.org/patches/data/56761 --- cause it's definitely incomplete. After some testing I've got new info here (to be added to patch comments above): 1) not statically linked sxs module is loaded not only on window creation but on GetClassInfo() (GetClassInfoEx() is to be tested but I think it's the same). This is a case only on vista+ systems, xp doesn't attempt to load assembly on GetClassInfo(); 2) "versioned" attribute in windowClass element affects redirection behavior, when set to "no" user32 doesn't try to load assembly at all. Second problem requires a FindActCtxSectionString() to actually fill key data with undocumented format, I did some dumping basing on length value reported: similar way it's done for dll redirection test (with a dword pointer) and useful fields are actually obvious - such as classname and module name. First problem stops me cause I don't know what way to prefer here. Any advices are welcome. P.S. Maybe it helps - native returned class data in case of vista+ and comctl32 v6 contains pointers to winproc as "FFFFxxxx" format, high word is constant. Personally I don't know what is supposed to mean, builtin classes without redirection don't show such patterns.

1 0

Re: wine autodetec 32/64 application
by Roderick Colenbrander Dec. 20, 2009

Dec. 20, 2009

Hi Giuseppe, Support for 64-bit is under heavy development and it our goal for Wine 1.2. A simple script to forward execution to 32-bit or 64-bit wine is not enough. Work is going on to integrate 32-bit and 64-bit Wine. Parts of the infrastructure for this are already in place (e.g. a shared wineserver) but other bits for a shared registry and prefix are still in development. It is not clear how we will invoke 32-bit or 64-bit Wine yet. I would recommend to check out Alexandre his keynote which discusses 64-bit Wine http://haar.student.utwente.nl/~julius/wineconf/julliardkeynote2009.ogv Roderick On Sat, Dec 19, 2009 at 5:17 PM, Giuseppe Della Bianca <bepii(a)libero.it> wrote: > Hi. > > This attached wine script can autodetect the wine 32/64 and application > PE32/PE32+, and autorun the correct wine program. > > This wine script support the application with name with space, and with > windows path. > > Regards. > Gdb > > > >

2 1

Conformance tess for cmd?
by Dan Kegel Dec. 19, 2009

Dec. 19, 2009

Has anyone written conformance tests for cmd? I imagine they'd mostly just be a bunch of batch files with matching expected output files.

4 6

re: Broken-down time (struct tm)
by Dan Kegel Dec. 19, 2009

Dec. 19, 2009

fwiw, looks like it might be a problem when building on Solaris: https://issues.asterisk.org/view.php?id=12022 Not sure what to do when that field is missing offhand.

1 0

Re: comdlg32: Check if the shell view exists before using it to execute commands
by Nikolay Sivov Dec. 19, 2009

Dec. 19, 2009

On 12/19/2009 20:47, Paul Chitescu wrote: > Changelog: > comdlg32: Check if the shell view exists before using it to execute commands. > > Prevents crashing if trying to create new folder with a R/O Registry (which is > a bug by itself in a different module). > Don't you mind add a test for that and previous patches?

2 1

Re: [2/2][tools]winetest: fix filesize limit
by Paul Vriens Dec. 19, 2009

Dec. 19, 2009

Hi André, On 12/19/2009 06:01 PM, André Hentschel wrote: > if (defined $dll) { We should only get here if we've received a start of a test but not the end. > # Either winetest crashed or the report file was cut off > $_=""; > - if ($filesize == $maxfilesize) { > + if ($filesize> $maxfilesize) { This can never happen as $maxfilesize is where it is cut off. The whole reason for this check is to decide whether we have a crash or "just" a file limit reached. If the size of the file is the maximum and we didn't get an end for the test we can assume it has been cut off at the sender. -- Cheers, Paul.

2 1

ucla dxdiag sources now in separate repo...
by Dan Kegel Dec. 19, 2009

Dec. 19, 2009

... until they can be merged. That seems like a better solution than just keeping the patches around in hyperspace. The tree is at http://code.google.com/p/yadxdiag/ If anyone would like to help finish this up, please let me know. The spinning cube test is pretty cool. - Dan

1 0

re: msi: fix leak in cond.y
by Nate Gallaher Dec. 18, 2009

Dec. 18, 2009

I should have mentioned in the commit message that this approach took heavy inspiration from the solution to the same problem in sql.y.

1 0

re: daily 16 bit tests?
by Dan Kegel Dec. 18, 2009

Dec. 18, 2009

Joerg-Cyril.Hoehle wrote: > there have been a number of 16bit changes lately (accompanied by a > few regressions) and I've been wondering whether some bot somewhere > has been setup to execute 16 bit tests (I read that there's a 16bit > testsuite somewhere, not integrated into Wine tests)? The procedure for running the 16 bit tests is given at http://code.google.com/p/win16test/source/browse/trunk/src/README It'd be great to integrate them into the daily test runs somehow. Maybe they could at least be incorporated into winetest.exe? Tips: When installing openwatcom with winetricks, be sure to select 'all' rather than 'selective', or you'll end up without the 16 bit tools you need; the symptom will be 'make all' fails because it's trying to use 32 bit headers. About four tests hang currently - you have to kill them with ^C use touch to bypass them, and rerun 'make tests'. Of the tests that don't hang, three currently fail. And it looks like a few of the tests don't pass on all windows machines, see http://code.google.com/p/win16test/issues/detail?id=1

1 0