February 2009 - Wine-Devel - list.winehq.org

Re: [1/2]tools/winemaker: add project-file support(try3)
by Francois Gouget Feb. 23, 2009

Feb. 23, 2009

Hi, I had a look at this patch and here are some comments. The case of the filenames in the dsp and dsw files may not match the case of the filenames on the filesystem. So you need to ajsut the names before you put them in the makefile. I believe search_from() can be used for that. I see that you're translating the Visual C++ compiler flags to gcc compiler flags. That's good. But I'm not sure about the following conversion from /GX to -fexceptions. Exception handling is pretty different between windows and Unix. Do you know if /GX is about structured exception handing? I really couldn't tell, but maybe some exception expert will know. I see you're converting the /Zp1 option which is very nice (packing being one of the disagreements between Visual C++ and gcc). But you don't do it for Zp(2|4|8|16). I believe you could do it by simply appending the packing size to the '-fpack-struct=' option. (But maybe I missed something) A bigger issue is that you're putting all the compiler options in CXXEXTRA which only applies to C++ code. But in the dsp file it looks like this applies to both C and C++ code. So it probably should be put in both (except -fexceptions which seems to be on by default in C++, but that's minor). About the commented out call to fix_file_and_directory_names(), I don't think winemaker should go and modify files outside of '.'. So I think it's safe to remove this call entirely. Also I have some questions about a couple of heuristics: if ($has_headers) { push @{@$project_settings[$T_INCLUDE_PATH]},"-I."; } Is this still needed? In source_scan_directory() it was needed because we had no idea what the include path was supposed to look like. But the project file should define it clearly enough for us. However I have a dsp file in a directory with a header file and I don't see a '/I.'. So maybe it is implied? Also this part seems wrong: # Finally if we are building both libraries and programs in # this project, then the programs should be linked with all # the libraries The project file should be explicit enough on this part for us not to have to do any guessing. Also do we really need to worry much about matching source file with a given target? Won't we always have a single target per dsp file? In which case the matching can probably be simplified. The end of source_scan_project_file() looks pretty similar to the end of source_scan_directory(). Maybe some code can be shared. To make the patch smaller you can first submit the dsp parser, then the dsw one, the vcproj one, and finally the sln one. And once that's done, it would be nice to integrate this all with the regular source_scan() function, so that if it detects one of these files in the subdirectories, it invokes the appropriate project parser for that directory and stops recursing. That can be done as a further separate patch. Style issues: The style issues are at least partly my fault as I used two-space indentation and braces on the same line when I first wrote winemaker. Nowadays I'd prefer 4-space indentation with braces on their own line but that's a bit tricky when maintaining a consistent indentation. In any case, in places your code is too incoherent. For instance: } elsif(/^# TARGTYPE/) { if (/[[:space:]]0x0101$/) { # Win32 (x86) Application $prj_target_type=1; This snippet has both 2 and 4 space indentation and it's all new code. There's also an indentation problem there: } } foreach my $source (@sources_misc) { if ($source =~ /^$basename/i) { Personnally I'd recommend to maintain a consistent indentation scheme at least per function (though the policy is more to be consistent per file normally :-/ ). Also, I'd prefer to have a space between 'if' and the prentheseses and braces. You can also simplify a some string concatenations. Replace: $prj_target_cflags=$prj_target_cflags."-D".$1." "; with $prj_target_cflags.="-D$1 "; In any case, thanks for taking this on. I think you're pretty close to the end (even if you don't feel that way after reading the above<g>). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ If you think the whole world revolves around you, quit staring at the GPS display while driving.

1 0

Re: msctf: add internal function for handling TfClientIds
by James Mckenzie Feb. 23, 2009

Feb. 23, 2009

Alexandre Julliard <julliard(a)winehq.org> wrote on Feb 23: > >Aric Stewart <aric(a)codeweavers.com> writes: > >> + /* If i understand this correctly at most a process should generate >> + * only a handful of these... But in case I am wrong */ >> + if (id_last == 65535) >> + { >> + ERR("TfClientIds generated exceeds USHORT limit\n"); >> + return 0x0; >> + } >> + id_last++; >> + id->id = MAKELONG(id_last, magic); >> + id->data = data; >> + list_add_head(&clientids,&id->entry); > >Using an array index would be cleaner than having to search through the >list everytime you use an id. > Also, aren't linked lists inefficient as well. Searching through them can be very intense, unless they are small (< 5 elements). Anything larger than this and an array would be more efficient. James McKenzie

2 1

Re: [7/7] setupapi/tests: start dialog.c test file with a test for SetupPromptForDiskA
by Paul Vriens Feb. 23, 2009

Feb. 23, 2009

Ricardo Filipe wrote: > > > ------------------------------------------------------------------------ > > Hi, Could you turn that skip() into a win_skip()? Usually it's a good idea to do a SetLastError(0xdeadbeef or something like that) before calling the function, especially because you are relying on that last error for the ok() test. -- Cheers, Paul.

2 1

Re: ole32: change a pointer cast from DWORD to DWORD_PTR
by Rob Shearman Feb. 23, 2009

Feb. 23, 2009

2009/2/22 Austin English <austinenglish(a)gmail.com>: > diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c > index b8ddba8..7360f66 100644 > --- a/dlls/ole32/compobj.c > +++ b/dlls/ole32/compobj.c > @@ -2007,7 +2007,7 @@ HRESULT WINAPI CoRegisterClassObject( > * Use the address of the chain node as the cookie since we are sure it's > * unique. FIXME: not on 64-bit platforms. > */ > - newClass->dwCookie = (DWORD)newClass; > + newClass->dwCookie = (DWORD_PTR)newClass; > > /* > * Since we're making a copy of the object pointer, we have to increase its Since dwCookie is of type DWORD this is just hiding the problem. The correct solution is to store a process-wide index and then to increase this every time a class object is registered and use it for the cookie. CoRevokeClassObject already looks through the list of registered classes to find the cookie so this doesn't need to be changed. -- Rob Shearman

1 0

Re: Win to Lin Library Wrapper
by King InuYasha Feb. 23, 2009

Feb. 23, 2009

On Mon, Feb 16, 2009 at 1:26 PM, Chris Robinson <chris.kcat(a)gmail.com>wrote: > On Monday 16 February 2009 9:38:19 am Seth Shelnutt wrote: > > I had an interesting thought the other day, and that is to having some > > built in support for forwarding windows dlls to linux .so's. > > IIRC, this kind of thing is generally discouraged, except in cases where > needed (eg. opengl32). Part of the problem is internal differences.. for > example, what would a Linux .so do if it's given a Win32 filename path? > Other > problems would be if the Linux equivalent wants a Window for a function > argument and the DLL wants an HWND instead, or if the DLL has > more/different > functions (eg. CUDA on Win32 has functions for dealing with D3D objects; > CUDA > on Linux doesn't, and it wouldn't be straight forward to even implement > them > through wined3d). > > Something like OpenGL, and even OpenAL to some degree, would directly > benefit > from having the DLLs forwarded to their host equivalents as it provides > better > access to the hardware and better integration with the host system. > Something > like zlib or ogg/vorbis and stuff wouldn't though, since the code should > largely be the same, and save for some bugs/inefficiencies in Wine (which > should be fixed), would work identically. > > > Does Wine yet have the capability to interface with HAL for Win32 hardware access similar to NT? It looks like it doesn't from all this talk of forwarding DLLs. What we should do instead of trying to forward DLLs, which is asking for more trouble than its worth, is try to get the NT layer to connect to UNIX HAL so that DLLs can link directly to HAL and operate the hardware.

6 11

Re: msctf: add internal function for handling TfClientIds
by Alexandre Julliard Feb. 23, 2009

Feb. 23, 2009

Aric Stewart <aric(a)codeweavers.com> writes: > + /* If i understand this correctly at most a process should generate > + * only a handful of these... But in case I am wrong */ > + if (id_last == 65535) > + { > + ERR("TfClientIds generated exceeds USHORT limit\n"); > + return 0x0; > + } > + id_last++; > + id->id = MAKELONG(id_last, magic); > + id->data = data; > + list_add_head(&clientids,&id->entry); Using an array index would be cleaner than having to search through the list everytime you use an id. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3d8: some 64-bit fixes
by Henri Verbeet Feb. 23, 2009

Feb. 23, 2009

2009/2/23 Austin English <austinenglish(a)gmail.com>: > + STDMETHOD(ApplyStateBlock)(THIS_ DWORD_PTR Token) PURE; > + STDMETHOD(CaptureStateBlock)(THIS_ DWORD_PTR Token) PURE; > + STDMETHOD(DeleteStateBlock)(THIS_ DWORD_PTR Token) PURE; > + STDMETHOD(CreateStateBlock)(THIS_ D3DSTATEBLOCKTYPE Type,DWORD_PTR * pToken) PURE; Which version of the DXSDK does this match?

2 2

Re: user32: change a pointer cast from DWORD to DWORD_PTR
by Austin English Feb. 23, 2009

Feb. 23, 2009

2009/2/22 Austin English <austinenglish(a)gmail.com>: > -- > -Austin > Ignore this patch please. -- -Austin

1 0

Greatings
by Piotr Skólski Feb. 22, 2009

Feb. 22, 2009

Hi. I want help you. I know c glibc and svn. I don't know git(but i'm leraning) and winapi(i don't know how learn without windows). Where my skils will be usefull. I have StarCraft and i want help you with dib engine but my skils are still too low (i don't know how patch my git tree with max dib engine). Bye. Piotr Skólski (SQLek) <sql7(a)wp.pl>

2 1

Wine download page usability problem
by Dan Kegel Feb. 22, 2009

Feb. 22, 2009

I got email from a friend who complained how hard it was to install wine. Turns out he assumed he had to go to winehq.org and follow the download instructions there, when all he needed to do was do Applications / Add/Remove and pick Wine. Can we add in a line at the top saying "Stable version 1.0.1 of Wine can usually be installed just like any other Linux application using your package manager (e.g. in Ubuntu, do Applications / Add/Remove, select Wine, and click Apply Changes). If that doesn't work, or if you need a newer version of Wine, here's how to get it." ? I know, that clutters things even more. Suggestions for achieving the same thing more concisely would be welcome. I think we should also move the text "This endorsement is the primary recognition that CodeWeavers has requested in exchange for hosting the Wine web site." to the bottom of the page, and change it to read "Thanks to CodeWeavers for hosting WineHQ.org". - Dan

17 30

Jaunty and pulseaudio
by Dan Kegel Feb. 22, 2009

Feb. 22, 2009

https://lists.ubuntu.com/archives/ubuntu-devel-discuss/2009-February/007108… says the pulseaudio daemon will autorestart, so anyone who's been relying on killing it might want to test with fresh jaunty to see if they've fixed the problems...

1 0

Re: opengl: wglMakeCurrent should call glflush before proceeding
by Chris Robinson Feb. 22, 2009

Feb. 22, 2009

On Saturday 21 February 2009 2:00:26 pm Jérôme Gardou wrote: > according to > http://msdn.microsoft.com/en-us/library/dd374387(VS.85).aspx, > wglMakeCurrent proceeds a flush before switching. glXMakeCurrent also forces a flush: http://www.opengl.org/documentation/specs/man_pages/hardcopy/GL/html/glx/xm… If it needs a wglFlush, it should call X11DRV_wglFlush (and only if there's a current context; you can't call gl* functions without one set). It can be an exceptionally costly call though, especially if it's going to be flushed again immediately after, so unless it's needed to fix some bug, I'd recommend not flushing explicitly.

2 1

Re: Icehamster?
by Shlomi Fish Feb. 21, 2009

Feb. 21, 2009

Hi Seth! On Fri, Jan 23, 2009 at 4:46 AM, Seth <seth.goldy(a)gmail.com> wrote: > ..or possibly Winapt. I read through your documentation and i am quite > interested in your idea. I'm not much of a programmer, but i have a > need knowledge of windows, registry, what dlls are doing, how to find > dependencies, and who knows what else. I've been around windows since the > age of 9 with windows 3.1 I've recently come to grips with the value of > open source software and the superiority of the Linux operating system (ie.\ > the reason why it's more secure, not just the fact that it is). I'm mostly > curious if you're still actively pursuing this project, I didn't assume that > i would be needed as a contributor to this project. > I never really started pursuing Winapt. Most I got to was the initial planning documentation: http://svn.berlios.de/svnroot/repos/winapt/winapt/trunk/docs/design/ Anyway, it is my intention to start working on this soon. I have a few loose ends to sort out before that with my other open-source endeavours. Regards, -- Shlomi Fish > > > -seth -- ------------------------------------------ Shlomi Fish http://www.shlomifish.org/ Electrical Engineering studies. In the Technion. Been there. Done that. Forgot a lot. Remember too much.

2 1

Re: Status of USB driver support?
by emiliano esposito Feb. 21, 2009

Feb. 21, 2009

Alexander Morozov ha scritto: >> git clone git://source.winehq.org/git/wine.git ~/wine-git >> git-am 0001... >> git-am 0002... >> > > You should run tools/make_makefiles before configuring. Thanks. I redid it from scratch, and imported the relevant keys directly from windows. Now this is what I get after launching the program: fixme:ntoskrnl:KeInitializeSpinLock stub: 0x129824 wine: Call from 0x7ee2e8b0 to unimplemented function usbd.sys.USBD_GetUSBDIVersion, aborting wine: Unimplemented function usbd.sys.USBD_GetUSBDIVersion called at address 0x7ee2e8b0 (thread 0022), starting debugger... Unhandled exception: unimplemented function usbd.sys.USBD_GetUSBDIVersion called in 32-bit code (0x7ee2e923) Then a lot of debug info follows, register dumps and so on. After that, the program continues normally. Don't know if it would be worth posting, please let me know.

3 4

Re: fusion/tests: Do not use a fixed path to the assembly
by James Hawkins Feb. 21, 2009

Feb. 21, 2009

On Thu, Feb 19, 2009 at 4:14 PM, Detlef Riekenberg <wine.dev(a)web.de> wrote: > > James: A fixed path is broken by design. > A "Thanks for spending weeks of your time laboriously testing and implementing fusion" would have sufficed. -- James Hawkins

3 2

Problem cross compiling after adding tests for inet_ntop
by Jeff Latimer Feb. 20, 2009

Feb. 20, 2009

I have been writing some tests for InetNtop/inet_ntop and placed them in dlls/ws2_32/tests/sock.c (snip of the code is below) but when I cross compile I get: make crosstest i386-mingw32-gcc -c -I. -I. -I../../../include -I../../../include -g -O2 -o sock.cross.o sock.c i386-mingw32-gcc protocol.cross.o sock.cross.o testlist.cross.o -o ws2_32_crosstest.exe -L../../../dlls ../../../libs/port/libwine_port.a -L../../../dlls/ws2_32 -L../../../dlls/kernel32 -lws2_32 -lkernel32 sock.cross.o: In function `test_inet_addr': /wing/dlls/ws2_32/tests/sock.c:2013: undefined reference to `_inet_ntop(a)16' /wing/dlls/ws2_32/tests/sock.c:2025: undefined reference to `_inet_ntop(a)16' /wing/dlls/ws2_32/tests/sock.c:2029: undefined reference to `_inet_ntop(a)16' /wing/dlls/ws2_32/tests/sock.c:2032: undefined reference to `_inet_ntop(a)16' collect2: ld returned 1 exit status make: *** [ws2_32_crosstest.exe] Error 1 I am using unmodified winsock.spec and ws2_32.spec files. It does not look like inet_ntop has been used in tests previously. Any ideas on what I need to do to get crosstest to work? ---- dlls/ws2_32/tests/sock.c static void test_inet_addr(void) { u_long addr; char dst[16]; char dst6[64]; u_char ip6_addr[16] = {0x20,0x30,0xa4,0xb1}; const char * pdst; struct in_addr in; struct in6_addr in6; u_long addr0_Num = 0x00000000; PCSTR addr0_Str = "0.0.0.0"; u_long addr1_Num = 0x20201015; PCSTR addr1_Str = "21.16.32.32"; u_char addr2_Num[16] = {0,0,0,0,0,0,0,0,0,0,0xff,0xfe,0xcC,0x98,0xbd,0x74}; PCSTR addr2_Str = "::fffe:cc98:bd74"; addr = inet_addr(NULL); in.S_un.S_addr = addr; trace("addr=%ld\n",addr); ok(addr == INADDR_NONE, "inet_addr succeeded unexpectedly\n"); in.S_un.S_addr = addr0_Num; pdst = InetNtop(AF_INET,(void*)&in.S_un.S_addr,dst,sizeof(dst)); ok(strcmp(pdst, addr1_Str),"Address %s != %s\n", pdst, addr0_Str); ok(pdst != NULL, "InetNtop failed %s\n", dst); pdst = inet_ntoa(*((struct in_addr*)&in.s_addr)); ok(pdst != NULL, "InetNtop succeeded unexpectedly %s\n", dst); ok(!strcmp(pdst, addr1_Str),"Address %s != %s\n", pdst, addr0_Str); trace ("addr=%s\n",pdst); in.S_un.S_addr = addr1_Num; pdst = inet_ntoa(*((struct in_addr*)&in.s_addr)); ok(pdst != NULL, "inet_ntoa succeeded unexpectedly %s\n", dst); ok(!strcmp(pdst, addr1_Str),"Address %s != %s\n", pdst, addr1_Str); trace ("addr=%s\n",pdst); pdst = InetNtop(AF_INET6,(void*)&in.S_un.S_addr,dst,sizeof(dst)); trace ("addr=%s\n",pdst); ok(pdst != NULL, "InetNtop failed %s\n", dst); memcpy(in6.s6_addr,ip6_addr,sizeof(ip6_addr)); pdst = InetNtop(AF_INET6,(void*)&in6.s6_addr,dst6,sizeof(dst6)); ok(pdst != NULL, "InetNtop failed %s\n", dst6); memcpy(in6.u.Byte,addr2_Num,sizeof(addr2_Num)); pdst = InetNtop(AF_INET6,(void*)&in6.s6_addr,dst6,sizeof(dst6)); ok(pdst != NULL, "InetNtop failed %s\n", dst6); ok(!strcmp(pdst, addr2_Str),"Address %s != %s\n", pdst, addr2_Str); }

1 1

Closing fixed bugs
by Dan Kegel Feb. 20, 2009

Feb. 20, 2009

A few months ago, Alexandre started including lists of fixed bugs in his release announcements. See e.g. http://www.winehq.org/announce/1.1.15, which says Bugs fixed in 1.1.15: 5694 Lionhead Black & White 2 demo crashes 7014 Unhandled page fault when exiting Commandos - BEL 7297 MIDI in/out fails, ports recognized ... I rather like those lists. He generates them by simply querying for open but fixed bugs right when he does the release; he then closes the bugs. They're good for PR if nothing else. For this to work, we have to let Alexandre be the only person to close fixed bugs. (Of course, it's ok for other people to mark bugs fixed, and it's ok for anyone to close invalid or dup bugs.) If anybody else closes a fixed bug, it won't show up in the list of fixed bugs for any release. A corner case is when a bug is marked fixed sometime after release. I think it's ok to leave it for Alexandre to close; that way it shows up in at least one release announcement. Even if it shows up a few releases late, that's better than not showing up at all. Sound reasonable? I ask because Vitaliy closed http://bugs.winehq.org/show_bug.cgi?id=10923 even after I tried to explain this to him, so I figured it needed a wider discussion. - Dan

4 4

Re: Wine download page usability problem
by Remco Feb. 20, 2009

Feb. 20, 2009

And now also to the list: On Fri, Feb 20, 2009 at 9:32 PM, Remco <remco47(a)gmail.com> wrote: > On Fri, Feb 20, 2009 at 9:28 PM, Dan Kegel <dank(a)kegel.com> wrote: >> >> Please try again, and paste the entire output page, I've added more info. >> >> Thanks! >> > > Firefox 3 on an unknown distribution Linux! > > userAgent Mozilla/5.0 (X11; U; Linux x86_64; en; rv:1.9.0.6) > Gecko/20080528 Epiphany/2.22 Firefox/3.0 > > I don't think you're gonna be able to get the distribution name out of > that... a problem with Epiphany I guess. > > Remco >

3 4

Possible to run arbitrary PHP code on pipermail server
by Remco Feb. 20, 2009

Feb. 20, 2009

I read the following e-mail on pipermail: http://www.winehq.org/pipermail/wine-devel/2009-February/073428.html Try downloading the PHP attachment from there; it will actually execute and give you an HTML page. This could easily be abused! Remco

2 1

Re: user32: implement support for HBMENU_POPUP_* magic menu bitmaps and use them to decorate the system menu
by Austin English Feb. 20, 2009

Feb. 20, 2009

2009/2/20 Rein Klazes <wijn(a)online.nl>: > Hi, > > See subject. > > Rein. > > > > A testcase would be helpful. -- -Austin

1 0

Re: user32: implement support for HBMENU_POPUP_* magic menu bitmaps and use them to decorate the system menu
by Peter Oberndorfer Feb. 20, 2009

Feb. 20, 2009

On Freitag 20 Februar 2009, Rein Klazes wrote: > Hi, > > See subject. > > Rein. > Hi, mostly minor code style comments. > if( hMenu ) { > + MENUINFO minfo; > + MENUITEMINFOW miteminfo; > POPUPMENU* menu = MENU_GetMenu(hMenu); > menu->wFlags |= MF_SYSMENU | MF_POPUP; > SetMenuDefaultItem(hMenu, SC_CLOSE, FALSE); > + > + minfo.cbSize = sizeof( MENUINFO); > + minfo.dwStyle = MNS_CHECKORBMP; > + minfo.fMask = MIM_STYLE; > + SetMenuInfo( hMenu, &minfo); > + > + miteminfo.cbSize = sizeof( MENUITEMINFOW); > + miteminfo.fMask = MIIM_BITMAP; > + miteminfo.hbmpItem = HBMMENU_POPUP_CLOSE; > + SetMenuItemInfoW( hMenu, SC_CLOSE, FALSE, &miteminfo); > + miteminfo.hbmpItem = HBMMENU_POPUP_RESTORE; > + SetMenuItemInfoW( hMenu, SC_RESTORE, FALSE, &miteminfo); > + miteminfo.hbmpItem = HBMMENU_POPUP_MAXIMIZE; > + SetMenuItemInfoW( hMenu, SC_MAXIMIZE, FALSE, &miteminfo); > + miteminfo.hbmpItem = HBMMENU_POPUP_MINIMIZE; > + SetMenuItemInfoW( hMenu, SC_MINIMIZE, FALSE, &miteminfo); > } I think this part deserves a bit more spacing to be readable. Something like the above looks better IMO. Also there is some inconsistent spacing around the beginning and end ()/{} which does not match the rest of the file. > + logfont.lfHeight = min( h, w) - 2 ; > + TextOutW( hdc, rect->left, rect->top, bmchr, 1); double space after '=' and ',' > case (INT_PTR)HBMMENU_POPUP_CLOSE: > + bmchr[0] = 0x72; > + break; > case (INT_PTR)HBMMENU_POPUP_RESTORE: > + bmchr[0] = 0x32; > + break; > case (INT_PTR)HBMMENU_POPUP_MAXIMIZE: > + bmchr[0] = 0x31; > + break; > case (INT_PTR)HBMMENU_POPUP_MINIMIZE: > + bmchr[0] = 0x30; > + break; The constants seem to be equal to DFCS_CAPTION... I just tried to use DrawFrameControl but it seems to always draw a border around the images. And i did not find the right parameters for not drawing a border. It could save some code for font setup but i guess it is not usable for this :-( > + TRACE(" height %d rect %s\n", logfont.lfHeight, wine_dbgstr_rect( rect)); leftover from debugging or is it still needed? Greetings Peter

1 0

Re: msi: begin support for finding network last sources in find_published_source
by James Hawkins Feb. 20, 2009

Feb. 20, 2009

On Thu, Feb 19, 2009 at 12:28 PM, Aric Stewart <aric(a)codeweavers.com> wrote: > > Fix for office 2007 sp 1 install. > --- > dlls/msi/media.c | 33 +++++++++++++++++++++++++++++++++ > 1 files changed, 33 insertions(+), 0 deletions(-) > I believe you're going down the wrong road with respect to the Office 2007 SP1 installer. None of the files installed/patched by SP1 need access to the original media, or stored local copies of the cab archives. With the fullfile install (which I'm not sure there's another version), you should be able to remove the original media, erase the stored cab files, and successfully install SP1. The fact that our implementation tries to access those cabs or the original media is the bug. There are many conditions and variables that factor in to whether a file should be reinstalled or not, and most of them have been fixed, but this patch is hiding all of the rest of the bugs. I'm not sure if you got the email I sent Jer about this problem, but the real bug is that we aren't handling the REINSTALL variable correctly (or REINSTALLMODE for that matter.) Can you please describe the exact case for why this patch is needed? -- James Hawkins

2 4

Re: Wine download page usability problem
by James Mckenzie Feb. 20, 2009

Feb. 20, 2009

Austin English <austinenglish(a)gmail.com> wrote: >Sent: Feb 20, 2009 10:32 AM >To: Dan Kegel <dank(a)kegel.com> >Cc: "wine-devel(a)winehq.org" <wine-devel(a)winehq.org> >Subject: Re: Wine download page usability problem > >On Fri, Feb 20, 2009 at 11:24 AM, Dan Kegel <dank(a)kegel.com> wrote: >> >> Can we add in a line at the top saying >> "Stable version 1.0.1 of Wine can usually be installed >> just like any other Linux application using your >> package manager (e.g. in Ubuntu, do Applications / Add/Remove, >> select Wine, and click Apply Changes). > >Nitpick, but instead of 'Linux', use 'native'. FreeBSD's ports >contains wine, as well as NetBSD's. Please exclude MacOSX which does not include Wine and I doubt it ever will. > >> I think we should also move the text >> "This endorsement is the primary recognition that CodeWeavers has >> requested in exchange for hosting the Wine web site." >> to the bottom of the page, and change it to read >> "Thanks to CodeWeavers for hosting WineHQ.org". > >+1 > ++1 James McKenzie

2 1

Re: msadp32.acm, winemp3.acm: Removed compiler warning
by Ricardo Filipe Feb. 20, 2009

Feb. 20, 2009

you should send one patch per email, dan should have told you that :P good to see you guys on the project :) 2009/2/20 Adam Stoelting <astoelting(a)ucla.edu> > Hello, > > These are my first patches. I am graduate student at UCLA and am trying to > help with porting Wine to 64 bit. I haven't seen any Microsoft source code > or done any dll dissasembly on my own. > > Change Log: > Removed the compiler pointer cast warning for dlls/msadp32.acm/msadp32.c > and > dlls/winemp3.acm/mpegl3.c. > > Thanks, > Adam > > > >

1 0

Re: [12/13] fusion: Sort the list of assemblies built during enumeration.
by James Hawkins Feb. 20, 2009

Feb. 20, 2009

On Thu, Feb 19, 2009 at 5:06 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > > This hopefully fixes the test failures on Alexandre's machine. > This isn't how it's done on Windows. On Windows, the order is based solely on directory enumeration, which we don't try to match in Wine. The fix is to check for all N results N times, where N is the number of assemblies enumerated. -- James Hawkins

3 6