February 2009 - Wine-Devel - list.winehq.org

Re: search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?
by James Mckenzie Feb. 17, 2009

Feb. 17, 2009

Alexandre Julliard <julliard(a)winehq.org> wrote: >Sent: Feb 17, 2009 5:07 AM >To: Dan Kegel <dank(a)kegel.com> >Cc: "wine-devel(a)winehq.org" <wine-devel(a)winehq.org> >Subject: Re: search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one? > >Dan Kegel <dank(a)kegel.com> writes: > >> See http://bugs.winehq.org/show_bug.cgi?id=14980 >> >> Essentially, to run Office 2007, you have to set an override >> for riched20. Since Office installs a new, spiffier version >> of riched20 in its own private directory, and expects to >> find it there, isn't it a bug that we don't let it have it? > >There's no guarantee that using the private version would help. In some >cases it does, in other cases it makes things worse. So defaulting to >builtin is preferable, this way at least when it doesn't work we have a >chance of fixing it. > I think the phrase for this is 'dll hell'. That is Application A ships with and places a copy of xyz.dll in the program directory and uses it, exclusively. This was fine for some versions of Windows when xyz.dll could add in its own functions at the end of the dll and include all of the functionality of the system provided xyz.dll. However, this breaks when the system is upgraded (witness what happened to a bunch of programs when XP SP2 was released or you upgraded from Windows 3.1 to Windows 3.11, etc.). This may or may not happen with Wine because we added the ability to first call the Native xyz.dll and if a function did not exist there, call Wine's xyz.dll. This allows the Wine project to call Wine specific versions of library code and continue to use program supplied dlls. Good idea and one that should be retained. However, some programs will NOT function without their program specific dlls, and it appears that Office 2007 is one of them. Thus, it will be necessary to switch from built-in to native, built-in for this program until Wine incorporates all of the new functions. This may also be true of other programs. James McKenzie

3 2

[RFC] Named Pipes emulation and interoperability layer
by Luke Kenneth Casson Leighton Feb. 17, 2009

Feb. 17, 2009

http://lkcl.net/namedpipes/namedpipes-emulation.txt this specification is intended to be implemented as a library, similar to a systems library that provides for example TCP/IP in userspace. thus it could easily be utilised by samba, samba tng, samba 4, apache runtime or in fact any POSIX-compliant system that intends to offer interoperable "Windows NT Named Pipe Emulation". the purpose of the document is to provide a guide to creating emulated implementation of Windows NT Named Pipes. implementors could use this to communicate between clients and servers inside their applications (such as the Wine application), with the added benefit that additional applications (such as the Samba application) that also conformed to the specification could interoperate. For example, the creation of a NamedPipe inside a Samba service could be talked to by a Wine client, and vice-versa. ultimately the specification _could_ potentially be used as a guide to writing a kernel-level implementation of Windows NT Named Pipes emulation. Note that this specification does NOT include "transfer of data over a network", as that task is carried out by SMB clients and SMB servers utilising SMBopenX, SMBclose, SMBreadX, SMBwriteX and SMBtrans2 subcommands 0x1, 0x26 and 0x53 to represent SetNPHS, WaitNamedPipe and TransactNamedPipe. Note that this specification does NOT have the API of the Win32 functions it is intended to emulate but is instead based very much on the design of the SMB protocols (much simplified), and thus provides an exact topological mapping of all SMB operations necessary to provide full Named Pipes functionality. Missing from the specification (but mandatory) at this time is PeekNamedPipe and GetNamedPipeHandleState, because it is clear that the functionality inside of Samba is entirely missing support for such (see call_trans2qpipeinfo in samba 3 smbd/trans2.c source code). Research WILL be required at a later stage in the form of running Win32 test applications, along with examination of the resultant network traffic, in order to determine the necessary support inside Samba for these two vital Named Pipe operations. From the design of Wine, and the stub code in smbd/trans2.c it is likely that these two functions will simply be direct mappings from NtQueryFileInformation #defines onto Trans2_QueryFileInfo, with blindingly obvious parameters and data structures to anyone familiar with both dlls/ntdll/file.c in Wine, and smbd/trans2.c in Samba. l.

1 0

http://wiki.winehq.org/NamedPipes - documenting the samba / wine NamedPipes integration
by Luke Kenneth Casson Leighton Feb. 17, 2009

Feb. 17, 2009

i've been updating this page with relevant information that is part requirements specification, part documentation. of particular relevance is the lack of support (in both tng and samba 3) for transferring SetNamedPipeHandleState semantics, although the "stub" functionality inside tng (smbd/pipe-proxy.c) at least records the NP message-mode flags, and then _completely_ ignores them ha ha :) exactly how this is to be implemented is unclear, and to be absolutely honest, by far the simplest-sounding approach may be to actually compile samba up as a win32 app! under such circumstances, it would be incredibly easy to then call the wine-emulated NamedPipe win32 functions CreateNamedPipe, SetNamedPipeHandleState etc. etc. given that samba tng has _already_ successfully been ported to win32, it has a head start here. and in that regard, ReactOS has it made, done and dusted! the alternative is... gaahd, i dunno... messy, to say the least, and *shudder* an mmap'd tdb is sounding _really_ attractive. tell me if this sounds reasonable. basically, a mini-wineserver protocol - a mini-SMB protocol - is required. commands to "send", "receive", "setnamedpipestate", "waitnamedpipestate" and "close". all required. * samba 3 / tng create or access named pipes as emulations over unix domain sockets, including sending a security context. in samba 3, that's called a SamInfo3, but it looks suspiciously like a NETLOGON NET_USER_INFO_3) and in tng it's a NET_USER_INFO_3... so... yep, it looks like just the name has been changed. * a program wants to create or access a named pipe; it asks wineserver (via a new function) to create or open up a unix domain socket. the locations will be the same. i.e. tng / samba3's unix domain socket pipe locations same as wineserver's. * sending / receiving of the security context blob is done in the dlls NOT in wineserver, so as to avoid blocking wineserver. * read, write, snphs, wnphs are all done with a 2-byte command prefix, followed by parameters, followed by data. exactly the same as is done in SMB and in wineserver. ... you know... if SMB wasn't so damn complicated i'd say bugger it, just send the SMBs to Wine, for _it_ to sort out!! in fact, with cliffsd's auto-generated SMB parsing code, that might even still be a valid option, given that the relevant code for parsing the SMBs is public domain. what do people think? does this sound like a reasonable proposition - a mini SMB/wineserver protocol - for use for inter-communication between wine and samba in order to exchange named pipe traffic? l.

3 5

Re: search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?
by James Mckenzie Feb. 17, 2009

Feb. 17, 2009

Austin English <austinenglish(a)gmail.com> wrote: >Sent: Feb 17, 2009 7:27 AM >To: Alexandre Julliard <julliard(a)winehq.org> >Cc: "wine-devel(a)winehq.org" <wine-devel(a)winehq.org>, Dan Kegel <dank(a)kegel.com> >Subject: Re: search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one? > >On Tue, Feb 17, 2009 at 6:07 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: >> Dan Kegel <dank(a)kegel.com> writes: >> >>> See http://bugs.winehq.org/show_bug.cgi?id=14980 >>> >>> Essentially, to run Office 2007, you have to set an override >>> for riched20. Since Office installs a new, spiffier version >>> of riched20 in its own private directory, and expects to >>> find it there, isn't it a bug that we don't let it have it? >> >> There's no guarantee that using the private version would help. In some >> cases it does, in other cases it makes things worse. So defaulting to >> builtin is preferable, this way at least when it doesn't work we have a >> chance of fixing it. >> > >What happened to 'bug for bug compatibility'? > Austin: These are considered private dlls as they extend functions that do not exist in the original system dll. When they are incorporated into the standard system dlls, then the new functions, and bugs, should be incorporated into the Wine versions. I think this is what AJ and Dan K are saying. James McKenzie

1 0

Re: search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?
by James Mckenzie Feb. 17, 2009

Feb. 17, 2009

Dan Kegel <dank(a)kegel.com> >Sent: Feb 17, 2009 7:26 AM >To: James Mckenzie <jjmckenzie51(a)earthlink.net> >Cc: Alexandre Julliard <julliard(a)winehq.org>, "wine-devel(a)winehq.org" <wine-devel(a)winehq.org> >Subject: Re: search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one? > >On Tue, Feb 17, 2009 at 6:23 AM, James Mckenzie ><jjmckenzie51(a)earthlink.net> wrote: >> However, some programs will NOT function without their program specific dlls, and it appears that Office 2007 is one of them. Thus, it will be necessary to switch from built-in to native, built-in for this program until Wine incorporates all of the new functions. > >But in this case, the app is using a private fork of the DLL in question, >and the new functions in the private fork will probably never go >into the public one. Dan, never assume what the Evil Empire is going to do. They may or may not put this into the dlls in Windows7 (TM). Since I'm strictly Mac for now, I don't have any idea either. Maybe someone with this operating system can look into this and give us feedback, but I'm with you as this is another method of operation of this company. James McKenzie

1 0

Re: tools/winemaker: change tabs into eight spaces
by James Mckenzie Feb. 17, 2009

Feb. 17, 2009

André Hentschel <nerv(a)dawncrow.de> wrote: > > Changes the spacing of the entire file. Also, if you are going to take this time, change indenting to two or four per level. James McKenzie

1 0

Re: [1/4](try 2)wininet: parse cookie information from cookie value
by Alexandre Julliard Feb. 17, 2009

Feb. 17, 2009

Aric Stewart <aric(a)codeweavers.com> writes: > + ptr = strchrW(ptr,';'); > + *ptr = 0; > + ptr++; > + while (*ptr == ' ') ptr++; /* whitespace */ > + /* FIXME use LOCALE_INVARIANT when implemented */ > + if (CompareStringW(MAKELCID(LANG_ENGLISH, SUBLANG_DEFAULT), > + NORM_IGNORECASE, ptr, 6, szDomain, 6) == 2) You need to check that the next char is a valid terminator (probably '=', not sure if other values are possible). Also using strncmpiW would make the code more readable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11.drv: Map Super_L, Super_R, and Menu keys, correctly.
by James Mckenzie Feb. 17, 2009

Feb. 17, 2009

Paul Bryan Roberts <pbronline-wine(a)yahoo.co.uk> wrote: > >> You need to generate the patch from the top of the wine directory. You >> also need to use your real name for copyright-tracking purposes. > >"copyright-tracking purposes" > That is a way of saying that we need, for legal reasons, to know the originator of each and every line of code that exists in the Wine project code base. >and there was me thinking you wanted my real name so I could take all your feedback personally. ;) > That's another reason for using your real name. However, the first reason is that if you do not supply your real name, your code will not be accepted into the project no matter how critically it is needed. James McKenzie

1 0

big patch to implement SetupPromptForDisk (please comment)
by Ricardo Filipe Feb. 17, 2009

Feb. 17, 2009

hello guys. i have took the endeavour of making my first dialog patch, managed to do it this weekend, to implement SetupPromptForDisk, which i stubbed but had some problems on the stub. gave me some big headaches to make this work x) so here is the patch, i've made the two versions of the dialog, but before submiting i'd like your comments on it. what is wrong in it? in which file should it be? i left it in stubs.c but i think misc.c might be a better place. is it testable? i once asked this on IRC and got a "no" for response, is it not testable? should i put some comments? code documentation (or lack there of) is a flaw of mine... i'm hoping for your replies so that i can submit as soon as possible. i've made some tests for "manual" testing and i have tested in "A vampire Story", the game that needed the stub, and it all worked fine. yhey! it lacks LOTS of details though, i just implemented the juice of it and some simple details. regards.

3 3

Re: winex11.drv: Map Super_L, Super_R, and Menu keys, correctly.
by Paul Bryan Roberts Feb. 17, 2009

Feb. 17, 2009

> You need to generate the patch from the top of the wine directory. You > also need to use your real name for copyright-tracking purposes. "copyright-tracking purposes" is there a Wiki page that explains this to the uninitiated ? I looked, did not find. Google led me straight back to the cited post on wine-devel(a)winehq.org. and there was me thinking you wanted my real name so I could take all your feedback personally. ;)

2 1

Wine talk on FOSDEM
by Marcus Meissner Feb. 16, 2009

Feb. 16, 2009

Hi, A week ago I went to Bruessel / Bruxelles in Belgium to the largest opensource developer conference in Europa, FOSDEM 2009. openSUSE has a developer room there the last years and we fill our time by holding talks, mostly concerning openSUSE and stuff that we do for the distribution and what our developers do. So the openSUSE organizers asked me to hold a talk on Wine this year, after my LinuxTag talk was so well received. I expected that like 20-30 people would show up, but it actually were around 110 according to our camera guy and they filled up the room. I have no idea why Wine is so interesting though. I gave a basic introduction and overview mostly and in the end tried to demo iTunes (failed, because installation was not successful in preparation) and demoed Heroes of Might and Magic III (successful). If you want to watch my 45 minutes: http://tube.opensuse.org/fosdem09/fosdem09_day2_03-wine.ogg (196MB) And my slides are here (feel free to reuse): http://files.opensuse.org/opensuse/en/0/05/Fosdem2009-wine.pdf http://files.opensuse.org/opensuse/en/0/05/Fosdem2009-wine.odp I also said hi to some ReactOS guys. Funnily all of them in suit and tie. :) Ciao, Marcus

4 3

WINEDEBUG/Test suite
by Austin English Feb. 16, 2009

Feb. 16, 2009

Howdy, Got a bit bored over the weekend and updated my build script to build wine daily while I'm at work, then automatically run the test suite under different (currently 6) configurations. Currently, it tests: no winedebug (ae-ub-810) Wine running under a virtual desktop (ae-ub-810-virtdesktop) # this one was broken in today's test...err, not run under a virtual desktop, fixed for tomorrow's. Needed a sleep 5s to get the virtual desktop setting saved before running the test suite. WINEDEBUG=+heap (ae-ub-810-heap) WINEDEBUG=+relay (ae-ub-810-relay) WINEDEBUG=+seh (ae-ub-810-seh) WINEDEBUG=+all (ae-ub-810-all) It's got some interesting results: http://test.winehq.org/data/3fa05ae6a7c08f9534badfeffbe02db9e00ab47a/#group… Currently, several tests timeout because of it (not worried about those...besides, I just ordered parts for a quad core on newegg, so those may be gone soon). The more interesting thing is that some test fail with memory corruption, etc. Most notably, crypt32:chain, crypt32:encode, crypt32:sip, d3d9:visual, ddraw:visual, oleaut32:tmarshal, riched20:editor, riched32:editor, and rpcrt4:cstub. There are several crashes as well (netapi32:access, jscript:run, msi:msi) all with a similar error. I filed http://bugs.winehq.org/show_bug.cgi?id=17415 for that. I filed a few other bugs for some of these issues, but not all of them...hopefully some of them will be fixed before I get the chance to :-p. I'd appreciate if everyone took a couple minutes to look at any areas of the code they're familiar with and see if they can fix these failures. I plan to test around with various optimizations, e.g., -O0, etc., since I recall at WineConf 2008 there were some failures only showing up under those configurations. If that shows anything consistent, I'll add them. -- -Austin

1 0

Re: urlmon: Correctly test to see if PutProperty_CLASSIDPROP is called
by Paul Vriens Feb. 16, 2009

Feb. 16, 2009

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > urlmon: Correctly test to see if PutProperty_CLASSIDPROP is called > > Best Regards > Alistair Leslie-Hughes > > > > > > > ------------------------------------------------------------------------ > > Hi Alistair, This patch introduced some test failures on Win98 up to W2K. Could you have a look? Looks like we need some broken or optional logic. -- Cheers, Paul.

2 1

office 2007 student trial downloaded, activated, and started ok!
by Dan Kegel Feb. 16, 2009

Feb. 16, 2009

Golly, Wine must be getting good. The student trial (though not the pro trial) of office 2007 from http://office.microsoft.com seems to install, activate, and start properly with no hacks at all. Can't edit the default document though, it says "selection locked". Guess I'll try the overrides listed in the appdb. I'm just blown away that the whole download experience worked. There were two nits: 1) no progress indication other than on the taskbar, and 2) the file was downloaded to $HOME/%MYDOCS%. Are we not expanding something properly?

1 1

Re: richedit: Removed unused ME_Document structure.
by James McKenzie Feb. 16, 2009

Feb. 16, 2009

Dylan Smith wrote: > The ME_TextBuffer structure is what is used to store the document (as a > linked list), so the ME_Document structure isn't being used. There was > also a document pointer in the ME_Paragraph structure that was also > unused, so I removed it because it is probably related to this used > structure. > --- > Would this be needed for EM_FORMATRANGE support or can this safely be removed. Don't want to delete and then add back code. James McKenzie

2 1

Debian Etch, Lenny and Squeeze packages
by Ben Klein Feb. 16, 2009

Feb. 16, 2009

Debian Lenny has gone stable. YAY! I've already got chroots and my build scripts set up for Debian Squeeze, which is the new testing, so I'll be able to produce packages of Wine for Squeeze without trouble, but there are some issues I'd like comment on. 1) I will not supply packages for Etch/amd64 (this used to be a TODO for me). No negotiation on this, but I am willing to assist people to compile/package it themselves if there's a good reason for not upgrading to Lenny. 2) I'll still build Etch/i386 packages (because it's damn easy for me to do so), but how long should this go on for? Ideally, we should encourage people to upgrade to Lenny. 3) Do we want to set up a Squeeze repository with 1.1.15 in it, or should we wait until the next release to set up a Squeeze repository? If the former, I will build packages specifically on/for Squeeze - best to do it this way for maximum compatibility. Ideally, I'd like a standardised policy on points #2 and #3, so that we know what's going on for the next release of Debian (I know, long-term planning). Scott, I'd value your opinion too, even though you only do Ubuntu packages now.

2 2

Win to Lin Library Wrapper
by Seth Shelnutt Feb. 16, 2009

Feb. 16, 2009

I had an interesting thought the other day, and that is to having some built in support for forwarding windows dlls to linux .so's. A while back, I had worked on the CUDA wrapper, which basically just transfers the calls from the dll to so. At that point I didn't work on a CAL wrapper because there was not linux support from ATI with CAL. Now there is, and has been and someone has requested a CAL wrapper for folding(a)home. I've started the work on it but I have been thinking, that I think it might be benifical to have some sort of built in support in wine for this. A method for automatically sending calls made to a .dll to the linux counterpart .so, if one exist. The work involved with making a wrapper for CUDA or CAL isn't that much, it's fairly simple in the grand scheme of things. However I'm sure there must be a lot of 3rd party, non-microsoft libraries that have windows and linux counter parts, that both expect the same inputs and. I know wine already does a lot of this, but some sort of automation in the process, in which if a call is made to cudart.dll, wine sees it, and transfers the calls to cudart.so. The list of .dlls and respective .so s could simply be kept in the registry for easy editing, and adding of libraries without the need to recompile wine. Hopefully I've put my idea across clearly. What are everyone's thoughts? Thanks, Seth Shelnutt

5 4

Please advise: Wine problem with Oracle database installation
by Robert Feb. 16, 2009

Feb. 16, 2009

Dear support, I have met a problem when installing Oracle database with Wine. The error message is as follows: "Failed loading com.sun.java.accessibility.eventqueuemonitor:java.lang.classnotfoundexception:com.sun.java.accessibility.util.eventqueuemonitor" I wonder whether this problem is due to JDK plug-in is not supported in Wine. Please kindly advise. Thanks a lot! Regards Robert

2 1

Re: [3/3] WineD3D: Pass the requested srgb flag to PreLoad
by Henri Verbeet Feb. 16, 2009

Feb. 16, 2009

2009/2/14 Stefan Dösinger <stefan(a)codeweavers.com>: > + SRGB_DONTKNOW = 0, /* Uses the cached value(e.g. external calls) */ SRGB_ANY or SRGB_EITHER is probably a nicer name. Do the enum elements need explicit values? You can probably drop the typedef as well, I don't think it adds anything useful. (I already mentioned some reservations about the extent of the changes to the internal interfaces for sRGB texture duplication on IRC, but lets merge it anyway and see where it goes.)

2 1

Re: wininet: parse cookie information from cookie value
by Rob Shearman Feb. 16, 2009

Feb. 16, 2009

2009/2/13 Aric Stewart <aric(a)codeweavers.com>: > + if (CompareStringW(GetThreadLocale(), NORM_IGNORECASE, ptr, 6, > + szDomain, 6) == 2) LOCALE_INVARIANT should be used when comparing with a constant string. See here for the reasons why: http://blogs.msdn.com/michkap/archive/2004/12/29/344136.aspx http://blogs.msdn.com/larryosterman/archive/2004/07/01/171078.aspx http://msdn.microsoft.com/en-us/library/dd373795(VS.85).aspx It doesn't look like it's implemented in Wine, so I guess you should just use MAKELCID(LANG_ENGLISH, SUBLANG_DEFAULT) with a FIXME to use LOCALE_INVARIANT when it's implemented. And, yes, there's probably lots of other places where we do case insensitive comparisons incorrectly like this, but we should stop introducing new ones. -- Rob Shearman

2 1

Re: winex11.drv: Map Super_L, Super_R, and Menu keys correctly.
by Rob Shearman Feb. 16, 2009

Feb. 16, 2009

2009/2/13 GerbilSoft <gerbilsoft(a)verizon.net>: > --- keyboard.c.orig 2009-02-12 11:50:28.110457529 -0500 > +++ keyboard.c 2009-02-12 11:52:06.061206978 -0500 You need to generate the patch from the top of the wine directory. You also need to use your real name for copyright-tracking purposes. -- Rob Shearman

1 0

[Fwd: Windows on Linux App of the Year]
by Jeremy White Feb. 15, 2009

Feb. 15, 2009

We've won the 'Windows on Linux' award of the year on LinuxQuestions.org again (by quite a large margin, I might add). Woohoo! Cheers, Jeremy

2 1

1.1.15 failing to build -- what changed?
by Scott Ritchie Feb. 15, 2009

Feb. 15, 2009

1.1.15 fails to build using an identical layout to 1.1.14, which means something has changed with either the build dependencies or the way configure is working. Here's the build failure I'm getting on amd64, but it fails on all arches: http://launchpadlibrarian.net/22606029/buildlog_ubuntu-intrepid-amd64.wine_… I'm going to sleep now, but hopefully I'll figure this out Valentine's day. In the meanwhile, 1.1.15 won't be available in Ubuntu packages just yet. Thanks, Scott Ritchie

5 12

Updated cebit presentation. Looking for ideas...
by Dan Kegel Feb. 15, 2009

Feb. 15, 2009

I've been slowly finishing my cebit presentation. The current draft is at http://kegel.com/cebit/ It now talks briefly about winetricks, and uses firefox and safari as examples of installing and running platinum and bronze apps. It also talks more about support, since a windows admin I showed it to said windows admins were generally scared of trying to support open source apps. If anyone has suggestions for how to make this presentation more appealing/informative/convincing to newbies who are only familiar with windows, please let me know. Also, if anyone can tell my why firefox doesn't show the Windows logo until you refresh sometimes, I'd be grateful. Maybe it's because the same image is used twice in the same page? - Dan

4 6

WINEGATE.DLL: Wine gateway to native Unix libraries
by Martin Hinner Feb. 15, 2009

Feb. 15, 2009

Hello, I have created a small library to allow Win32 applications running under Wine to load native Unix shared libraries (.so). First (one-hour hack) version is available at http://martin.hinner.info/tmp/winegate.tar.gz ; Please consider inclusion in WINE tree (dll/ directory). Please note that Makefile.in as well as configure scripts will likely need some changes. Purpose of this Wine DLL is to allow Windows applications to use directly Unix library functions. This is useful for example for applications which talk to specific drivers and it's not efficient/possible to create system native DLL for such driver or library. Win32 app. vendor is required only to detect execution under Wine and load proper native library. WinGate.DLL exports dlopen/dlsym/dlclose/dlerror functions which allow Windows app to load additional libraries and use them. This library should export all functions that are required to load additional libraries and detect type & version of system we're running on. I believe that NO additional functions are required as you can always import uname() and call it to obtain more information on the running system, so dlopen/dlsym/dlclose is enough. Maybe some 'getwineversion' function should be included - waiting for your comments. I am sure there will be a lot of people arguing that Win32 application SHOULD NOT be modified to behave differently in Wine. I agree that in most cases it's better to fix Wine than applications, but there are real world problems that cannot be efficiently solved outside the application. One good example is when Win32 app has to talk to custom hardware. In many cases there are native Linux drivers that have different API/etc and it is very very difficult to create wrapper library between Windows-style and Linux/Unix-style drivers. In such cases it's much easier to modify source code of Windows app to use either Linux or Windows drivers/DLLs/etc. Example how to use WINEGATE.DLL is in winesupp.zip (please note this is quite silly example). If you want to see real world application which uses this library, go to http://www.jtagtest.com I have chosen name Wingate because google did not reveal any other use of such name and I think it fits it's purpose. Feel free to suggest any other names or just rename the library. Martin

6 14

Re: Start DDE interface from Explorer Process. Add DDE stubs.
by Dmitry Timoshkov Feb. 15, 2009

Feb. 15, 2009

"Jeremiah Flerchinger" <jeremiah.flerchinger(a)gmail.com> wrote: > Explorer.exe now calls ShellDdeInit. Progman stubs will now be started/used in Shell32. > Amazingly any apps with a Progman DDE interface will also be called. Shell32 can handle > all major functionality, but a running progman.exe (for example) will be able to > synchronize internal values with changes made by Shell32. This patch just adds a lot of confusion and mess. As I suggested you should start with a simple test app and see how it really supposed to work. -- Dmitry.

2 1

Re: [2/3] WineD3D: Add a debug function for surface locations
by Henri Verbeet Feb. 15, 2009

Feb. 15, 2009

2009/2/14 Stefan Dösinger <stefan(a)codeweavers.com>: > +const char *debug_surflocation(DWORD flag) { > + switch(flag & SFLAG_LOCATIONS) { > + case SFLAG_INSYSMEM: return "SFLAG_INSYSMEM"; > + case SFLAG_INDRAWABLE: return "SFLAG_INDRAWABLE"; > + case SFLAG_INTEXTURE: return "SFLAG_INTEXTURE"; > + case SFLAG_INSRGBTEX: return "SFLAG_INSRGBTEX"; > + > + case SFLAG_INSYSMEM | SFLAG_INDRAWABLE: return "SFLAG_INSYSMEM | SFLAG_INDRAWABLE"; > + case SFLAG_INSYSMEM | SFLAG_INTEXTURE: return "SFLAG_INSYSMEM | SFLAG_INTEXTURE"; > + case SFLAG_INSYSMEM | SFLAG_INSRGBTEX: return "SFLAG_INSYSMEM | SFLAG_INSRGBTEX"; > + > + case SFLAG_INDRAWABLE | SFLAG_INTEXTURE: return "SFLAG_INDRAWABLE | SFLAG_INTEXTURE"; > + case SFLAG_INDRAWABLE | SFLAG_INSRGBTEX: return "SFLAG_INDRAWABLE | SFLAG_INSRGBTEX"; > + > + case SFLAG_INTEXTURE | SFLAG_INSRGBTEX: return "SFLAG_INTEXTURE | SFLAG_INSRGBTEX"; > + > + case SFLAG_INSYSMEM | SFLAG_INDRAWABLE | SFLAG_INTEXTURE: > + return "SFLAG_INSYSMEM | SFLAG_INDRAWABLE | SFLAG_INTEXTURE"; > + case SFLAG_INSYSMEM | SFLAG_INDRAWABLE | SFLAG_INSRGBTEX: > + return "SFLAG_INSYSMEM | SFLAG_INDRAWABLE | SFLAG_INSRGBTEX"; > + case SFLAG_INSYSMEM | SFLAG_INTEXTURE | SFLAG_INSRGBTEX: > + return "SFLAG_INSYSMEM | SFLAG_INTEXTURE | SFLAG_INSRGBTEX"; > + case SFLAG_INDRAWABLE | SFLAG_INTEXTURE | SFLAG_INSRGBTEX: > + return "SFLAG_INDRAWABLE | SFLAG_INTEXTURE | SFLAG_INSRGBTEX"; > + > + case SFLAG_INSYSMEM | SFLAG_INDRAWABLE | SFLAG_INTEXTURE | SFLAG_INSRGBTEX: > + return "SFLAG_INSYSMEM | SFLAG_INDRAWABLE | SFLAG_INTEXTURE | SFLAG_INSRGBTEX"; > + > + default: return "Unknown location flag combination"; > + } > +} I think using wine_dbg_sprintf() would be a lot more practical.

1 0

[patch] review requested: message-mode named pipes
by Luke Kenneth Casson Leighton Feb. 15, 2009

Feb. 15, 2009

http://bugs.winehq.org/attachment.cgi?id=19477 * functionality of non-message-mode (byte type) is preserved. * putting too many messages into the queue runs wineserver out of file descriptors, but the solutions to that are too much work for this revision, to be included, so - tough. * research indicates that message-mode is supposed to block when resources are low, but that would require a per-file mutex. again - too much work for this revision. l.

1 0

[patch but not quite ready] NamedPipes messagemode
by Luke Kenneth Casson Leighton Feb. 15, 2009

Feb. 15, 2009

http://bugs.winehq.org/show_bug.cgi?id=17195 with only one significant bug - some memory corruption - the semantics are now correct in the namedpipe messagemode patch. i drew a diagram outlining the data structures / design http://bugs.winehq.org/attachment.cgi?id=19449 because it's so horrendous that even i want to throw up. assistance in finding the memory corruption would be really helpful. an assert is thrown after more than 4 short reads are performed on the same namedpipe, with this straaaange error: ead: file.c:631: server_get_named_pipe_fd: Assertion `wine_server_ptr_handle(fd_handle) == handle' failed. ead: server.c:628: server_get_unix_fd: Assertion `wine_server_ptr_handle(fd_handle) == handle' failed. wine: Assertion failed at address 0xf7ca8d7f (thread 000f), starting debugger... err:ntdll:RtlpWaitForCriticalSection section 0x7bc99ee0 "server.c: fd_cache_section" wait timed out in thread 000f, blocked by 0014, retrying (60 sec) i'll try to write a simplified test because that's the "threadread" test on which this occurs. i can't quite believe that all 5 tests can be passed [by reducing the number of short reads to less than 4]. it's been a bit of a "drunken walk" development style, i'm afraid :) notes: * in order to preserve message-mode semantics correctly, each message gets ITS OWN socketpair. the socketpair is used EXCLUSIVELY for that one message and is NOT re-used by the other end. so if it's client writing to server, one message, that's one socketpair. if it's server writing to client, one message, that's another socketpair. if client writes 20 messages to server, that's 20 new socketpairs, if at same time server writes 25 messages to client, and nobody's done any reading yet, that's a total of 45 outstanding socketpairs - 90 filedescriptors. this is not a hoax. it's the only way i could think of that preserves messagemode semantics correctly. * for each end - client and server - to be able to "block", waiting at any time, there MUST be at LEAST one socketpair in each of the queues. so, initially, that's what's done: one pair of socketpairs are created, one for the client, one for the server. on the FIRST write (to server, or to client), this initial "empty" socketpair must be written to; subsequent writes (to server or to client, each) must have a NEW socketpair created. * on a read, a socketpair must "hang about" - MUST not be shut down - until there is a new one created (which happens only on a new write). in this way, multiple threads will always have a filedescriptor to block on. * when a read has read all available data, the socketpair is marked as "finished" but is NOT shut down. * on each write, if a new socketpair is created, then and ONLY then can "old" marked socketpairs be shut down. * shutdown of read-sockets, on which [potentially many] reader[s] are waiting will result in an EPIPE. this is an ACCEPTABLE error IFF no data has been read yet, i.e. at the start of a new message. what happens, basically, is that the "old" socketpair - even though it had been used already by the previous reader - is what the thread "blocks" on (because you have to block on _something_). and on the _very_ first message, of course, you block on the specially-prepared initial socketpair, the one that had to be created and marked as "as-yet unwritten to". * you can see at line 872 of ntdlls/file.c (after patch is applied) that oh whoopsie, EPIPE occurred, but we've not read any data at all, just grab another filedescriptor from wineserver and try again. in this way, wineserver hands out the next available message from the filedescriptor queue. if yet _another_ EPIPE occurs, then all that means is that another thread "got there first", wow big deal, around you go again. * indicating that data has been read is performed using a special wineserver message "NAMED_PIPE_SUB_AVAILDATA" using server_set_named_pipe_info(). this horrible hack passes information to wineserver telling it to subtract the amount of data read in userspace from the filedescriptor data structure (fdqueue) representing that socketpair. * indicating that data _will_ be available is performed again using server_set_named_pipe_info(), this time using a message "NAMED_PIPE_SET_AVAILDATA". the set is performed BEFORE the actual write, otherwise a reader will "unblock" and potentially try to set the available data to negative!!! this would be baaad. * a critical section is performed around all uses of server_set_named_pipe_info() and server_get_named_pipe_fd(). this is NOT the same critical section as server_get_handle_fd(). i don't know if this makes any difference. things that cannot be done: * you cannot do the read or the write inside wineserver (server_named_pipe_read() will be deleted, later). the reason is complex to describe, but boils down to "blocking in userspace on the socket in order to wait for a message" and "non-blocking read on the same socket in order to get the data" are unfortunately mutually incompatible. one screws up the other if you set or clear O_NONBLOCK. * you cannot send the length as a 4-byte "header" down the socket, to be read as a length and then that much data read out. if you have multiple readers blocking on the same filedescriptor, how do you make sure that only one of them reads the length?? they're all blocking on the same socket! send the length multiple times?? how do you know how many readers there are?? short answer: you can't. so - scratch that idea. [ok - maybe you could do a critical section, but you'd have to do one per file, and i'm not ready or willing to add an array of per-file-handle critical sections to ntdll without further discussion] issues: * multiple readers of the same socket, when reading data amounts that are larger than the SO_RCVBUF and/or SO_SNDBUF, could potentially end up corrupting the data because of overlaps in the reads. given that this is _already_ a problem, in the existing Wine code, i am not going to be dealing with this issue, in this iteration. particularly as solutions involve having to do per-file critical sections and YES that's a generic problem even on standard files not just pipes not just messagemode pipes ALL files. * running out of socketpairs; protecting the message queue length. i believe there's a default message queue length in NT, but even so, the number of file descriptors this [necessary] design uses up is _horrendous_. one pair per message! but - tough luck. the options are pretty limited and constrained by the requirements. so: if anyone says to me, "no this cannot work, you cannot _possibly_ have got correct messagemode semantics purely in userspace and without sending length fields, you _must_ do the reads and writes inside wineserver", then... well... that will be a good way to get me to unsubscribe from wine-devel. if anyone can think of any other ideas, or implementations, or optimisations, then... well... unless they're _really_ good ideas, they'll have to wait :) ideas such as using a separate socketpair for communicating "length" messages are welcome, if accompanied by well-laid-out explanations, because my brain is turning to jelly with this stuff and i could do with some light reading instead of working it out myself :) l.

2 4

Re: AppDB new design: Top 10s still look ugly
by André Hentschel Feb. 15, 2009

Feb. 15, 2009

Ricardo Filipe schrieb: > 2009/2/15 André Hentschel <nerv(a)dawncrow.de <mailto:nerv(a)dawncrow.de>> > > Ricardo Filipe schrieb: > > hi andré, > > alex didn't apply your patch. he just fixed the .css to give it the > > same style as it had before. > > > > 2009/2/15 André Hentschel <nerv(a)dawncrow.de > <mailto:nerv(a)dawncrow.de> <mailto:nerv(a)dawncrow.de > <mailto:nerv(a)dawncrow.de>>> > > > > Hello, > > Bug #16466 is declared as fixed. but it isnt. my patch should do > > something else. > > I wanted let each top 10 in its own color(platin, gold or > bronce) and > > not to have the platin-look for all. > > anything went wrong while using my patch. maybe the other patch > > went in, > > too? > > It should be this style: > http://www.funplugged.bplaced.net/appdb/ > > > > > > > Hi Ricardo, > but its not the same as before, look at my attachment in bug > #16466, do > you see something else then me? > > > it's not bug #16466 for sure :P > i don't really remember how it was before, and i'm not too fond of > having gold and silver apps with the white too, but it serves it's > function fine... > you'd better talk to alex on that to be sure what's the objective. sorry, it was #16442

1 0

AppDB new design: Top 10s still look ugly
by André Hentschel Feb. 15, 2009

Feb. 15, 2009

Hello, Bug #16466 is declared as fixed. but it isnt. my patch should do something else. I wanted let each top 10 in its own color(platin, gold or bronce) and not to have the platin-look for all. anything went wrong while using my patch. maybe the other patch went in, too? It should be this style: http://www.funplugged.bplaced.net/appdb/

2 2

Re: mshtml: Correctly test to see if PutProperty_CLASSIDPROP is called
by Alistair Leslie-Hughes Feb. 15, 2009

Feb. 15, 2009

Ignore this, the subject is wrong. "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:4997DB01.1000602(a)hotmail.com... > Hi, > > Changelog: > mshtml: Correctly test to see if PutProperty_CLASSIDPROP is called. > > Best Regards > Alistair Leslie-Hughes > > > > -------------------------------------------------------------------------------- > From 14267df8f532c7acc7cc184c3c1e020639ca8702 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Fri, 6 Feb 2009 20:03:47 +1100 > Subject: [PATCH] Corrected tests > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/urlmon/tests/url.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/urlmon/tests/url.c b/dlls/urlmon/tests/url.c > index c062cf8..e5895c4 100644 > --- a/dlls/urlmon/tests/url.c > +++ b/dlls/urlmon/tests/url.c > @@ -313,7 +313,7 @@ static DWORD WINAPI thread_proc(PVOID arg) > CHECK_CALLED(Obj_OnProgress_BEGINSYNCOPERATION); > CHECK_CALLED(CreateInstance); > CHECK_CALLED(PutProperty_MIMETYPEPROP); > - CLEAR_CALLED(PutProperty_CLASSIDPROP); > + CHECK_CALLED(PutProperty_CLASSIDPROP); > CHECK_CALLED(Load); > CHECK_CALLED(Obj_OnProgress_ENDSYNCOPERATION); > CHECK_CALLED(OnObjectAvailable); > @@ -612,7 +612,7 @@ static HRESULT WINAPI Protocol_Start(IInternetProtocol > *iface, LPCWSTR szUrl, > CHECK_CALLED(Obj_OnProgress_BEGINSYNCOPERATION); > CHECK_CALLED(CreateInstance); > CHECK_CALLED(PutProperty_MIMETYPEPROP); > - CLEAR_CALLED(PutProperty_CLASSIDPROP); > + CHECK_CALLED(PutProperty_CLASSIDPROP); > CHECK_CALLED(Load); > CHECK_CALLED(Obj_OnProgress_ENDSYNCOPERATION); > CHECK_CALLED(OnObjectAvailable); > -- > 1.5.4.3 > > -------------------------------------------------------------------------------- > >

1 0

Proposal: put Winetricks into Wine menu
by Dan Kegel Feb. 15, 2009

Feb. 15, 2009

I know, when I wrote Winetricks, I meant it as a developers' tool only. But... then... people started using it, and it made sense to provide it as a way to download missing visual C++ runtimes etc. for average users. Quite a few newbies trip over the fact that it needs cabextract installed. Let's make it easy for folks, actually package it up along with Wine (SuSE does this already), and put it in the Wine menu right beneath "Uninstall Windows Software". What do people think? It might make life easier for a lot of folks. (And, come to think of it, we should include some documentation in that menu. "man wine" just doesn't cut it for the average gui user, and "wine manual page" in the gnome help browser is a broken link. But that's a separate issue.) - Dan

3 4

Wine desktop integration: current directory of app launched with doubleclick?
by Dan Kegel Feb. 15, 2009

Feb. 15, 2009

I *almost* have a great success story to report; the only thing keeping it from being a success story is the current directory chosen by Nautilus when double-clicking on .exe files. My wife hurt a finger trying to impersonate a Sampsonite Luggage gorilla, and had to go to a hand doctor. Along the way her hand got x-rayed, and the doctor handed her a cd-rom with the x-ray pictures on it. The disc has an autorun.inf on it that should start ViewSel.exe. I don't know if that's supposed to work with Wine and Nautilus, but probably doubleclicking on ViewSel.exe does the same thing. ViewSel.exe puts up two big buttons: low res (which launches a web browser on an html file), and high res (which launches a DICOM viewer). If you cd to the root of the cd-rom drive and run ViewSel, it works. If the current directory is anything else, it doesn't work. If you start the autorun app via Nautilus, those buttons don't work, so presumably it sets the current directory to something other than the root of the drive. To see, I created a wrapper shell script, ~/bin/mywine, containing #!/bin/sh pwd > /tmp/log and used "Start with" to launch ViewSel.exe with ~/bin/mywine. This showed that the current directory was $HOME. I had a look at the gnome code to see how it decided, but it was a bit hard to follow. (See gnome_vfs_mime_application_launch_with_env.) So I tried a little shell magic. I created a new wrapper shell script that assumes the argument is a path to a file, and sets the current directory to the directory containing that file: #!/bin/sh DIR=`dirname "$1"` DIR=`cd "$DIR"; pwd` cd "$DIR" wine "$@" That worked better; it let ViewSel.exe launch the DICOM viewer. So... I suppose the next step is to look at the debian/ubuntu packages for wine and see if that little wrapper script could be incorporated into the default way file browsers start wine? It sure would be nice if apps that expected the current directory to behave like this (it's not uncommon!) Just Worked. - Dan

4 9

Re: [Bug 17104] Drives in winecfg can not be set correctly for paths containing non-latin (probably multibyte) characters. [utf-8]
by Austin English Feb. 14, 2009

Feb. 14, 2009

On Sat, Feb 14, 2009 at 5:59 PM, <wine-bugs(a)winehq.org> wrote: > http://bugs.winehq.org/show_bug.cgi?id=17104 > > > Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > Status|RESOLVED |CLOSED > > > > > --- Comment #10 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2009-02-14 17:59:35 --- > Confirming fixed. > > Closing bug fixed in wine-1.1.15. > > > -- > Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email > Do not reply to this email, post in Bugzilla using the > above URL to reply. > ------- You are receiving this mail because: ------- > You are on the CC list for the bug. > Perhaps we should wait for bugs to be closed by AJ in the next release, even if they were fixed in a previous release? That way, they should up in the release notes. Dan brought it up on another bug, and I agree...but figured it should be brought up here. Thoughts? -- -Austin

2 1

Re: mshtml: allow REG_EXPAND_SZ values for GeckoCabDir
by Juan Lang Feb. 14, 2009

Feb. 14, 2009

Hi Christoph, - /* @@ Wine registry key: HKCU\Software\Wine\MSHTML */ - res = RegOpenKeyW(HKEY_CURRENT_USER, mshtml_keyW, &hkey); - if(res != ERROR_SUCCESS) - return FALSE; - file_name = heap_alloc(size+sizeof(GECKO_FILE_NAME)); - res = RegQueryValueExA(hkey, "GeckoCabDir", NULL, &type, (PBYTE)file_name, &size); + /* @@ Wine registry key: HKCU\Software\Wine\MSHTML */ + res = RegGetValueA(HKEY_CURRENT_USER, mshtml_keyA, "GeckoCabDir", RRF_RT_ANY, &type, (PBYTE)file_name, &size); This change is unrelated to the subject. One change per patch, please. + if(res != ERROR_SUCCESS || (type != REG_SZ && type != REG_EXPAND_SZ)) { heap_free(file_name); return FALSE; } If you're allowing REG_EXPAND_SZ, oughtn't you call ExpandEnvironmentVariablesA as well? --Juan

2 2

Re: Proposal: put Winetricks into Wine menu
by Dan Kegel Feb. 14, 2009

Feb. 14, 2009

So, for people packaging wine, here's a proposed plan: 0. See http://wiki.winehq.org/winetricks if you're not familiar with winetricks 1. Download http://www.kegel.com/wine/winetricks (or get it via svn, see http://code.google.com/p/winezeug ) It's a monolithic shell script, so you don't need to compile it or anything. 2. Move it to /usr/bin and do chmod +x /usr/bin/winetricks 3. Add a dependecy on cabextract, sha1sum, and wget or curl. 4. In your package's changelog, note which version of Winetricks you pulled down. You'll want to pull down a fresh one every time you package Wine, as it contains download URLs that occasionally go stale. (In particular, I need to update the gecko URL for wine-1.1.5, I'll do that today.) The Suse packages already do all the above steps, I think; you might ask Marcus Meissner if you want to confirm the details. Here's the part that I don't think anybody does yet: 5. Add a menu item under Applications / Wine that runs /usr/bin/winetricks. In Ubuntu, the existing menu items are Programs Browse C: Drive Configure Wine Uninstall Wine Software Assuming we name the menu item Winetricks, the menu would then look like Programs Browse C: Drive Configure Wine Uninstall Wine Software Winetricks Now, at some point we should come up with a better menu item name than Winetricks, but I have no idea how to sum it up properly. winetricks has a fair bit of name recognition, and requires no localization, so let's run with that name until we figure out what it should really be called, and what the GUI really should look like in the end. (We also need a menu item there for "Help Using Wine", but nobody's written that yet. It can't just be links to the FAQ, since it has to work while offline.) Sound good? - Dan

3 3

GSoC 2009 coming up
by Kai Blin Feb. 14, 2009

Feb. 14, 2009

Hi folks, the organization application period for GSoC 2009 is starting on March 9th, so it's time to get our http://wiki.winehq.org/SummerOfCode wiki page in shape again. Detlef Riekenberg and Roderick Colenbrander made a good start, so if the rest of you could check and make sure that all the projects on there still make sense? We should also investigate possible changes to the requirements (weekly reports to the mailing list come to mind). Maarten, any comments? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 1

Re: Firefox 3 runs faster on Linux+Wine than on Linux -- comparative to running on Windows
by Susan Cragin Feb. 14, 2009

Feb. 14, 2009

>Hi, > >For those not monitoring slashdot [1], there is an article [2] that is >comparing the Google V8 benchmark on Windows and Linux versions of >Firefox 3. > >The result of this is that the Windows and Wine runs are pretty close >(241 vs 227) when compared to the Linux run (181) and Opera (155). > >I wonder what the results are like on Firefox 3.1 with tracemonkey >enabled on Windows, Wine and Linux. > >[1] http://tech.slashdot.org/article.pl?sid=09/02/13/0058251 >[2] http://www.tuxradar.com/content/browser-benchmarks-2-even-wine-beats-linux-… > >- Reece One thing that interested me... one person wrote that Linux/Firefox compiled with msvc was faster than gcc, because msvc is better at optimization. Has anyone tried compiling wine with msvc? Susan

3 2

msvcrt:file test failures under wine and winetest
by Austin Lund Feb. 13, 2009

Feb. 13, 2009

I've been playing around with the odd failure that occurs on some platforms for the msvcrt:file tests. http://test.winehq.org/data/6a1537c4b5037be5253c33021fda3a02430533f7/#group… I am able to recreate it on my computer running ubuntu 8.10. (tag: apl-u810-dell630) I was trying to nail down what exactly problem was when I found the following: $ ./programs/winetest/winetest -o out -c msvcrt:file 2> /dev/null && tail -n 8 out Test output: msvcrt:file start dlls/msvcrt/tests/file.c - file: 3 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 5 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 5 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 462 tests executed (0 marked as todo, 0 failures), 0 skipped. msvcrt:file done (0) It seemed to succeed when it was the only test run. I played around for a bit with this and found the combination of tests which causes the failure: $ ./programs/winetest/winetest -o out -c msvcrtd:debug msvcrt:file 2> /dev/null && tail -n 13 out Test output: msvcrtd:debug start dlls/msvcrtd/tests/debug.c - debug: 2 tests executed (0 marked as todo, 0 failures), 0 skipped. msvcrtd:debug done (0) msvcrt:file start dlls/msvcrt/tests/file.c - file: 3 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. file.c:1057: Test failed: fstat(stdin) failed: errno=2 file.c:1066: Tests skipped: stdin is not a char device? st_mode=100666 file: 5 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 5 tests executed (0 marked as todo, 0 failures), 0 skipped. file: 458 tests executed (0 marked as todo, 1 failure), 1 skipped. msvcrt:file done (1) Also of note is that when doing "make test" this failure never occurs. So whatever is going on, it is a strange interaction between msvcrtd:debug msvcrt:file tests and winetest. Another point to make is that the error that corresponds to errno=2 is "No such file or directory", which is an odd message for a filedes which is meant to be stdin. Does anyone have any tips on what to look at to nail this one down?

1 0

Firefox 3 runs faster on Linux+Wine than on Linux -- comparative to running on Windows
by Reece Dunn Feb. 13, 2009

Feb. 13, 2009

Hi, For those not monitoring slashdot [1], there is an article [2] that is comparing the Google V8 benchmark on Windows and Linux versions of Firefox 3. The result of this is that the Windows and Wine runs are pretty close (241 vs 227) when compared to the Linux run (181) and Opera (155). I wonder what the results are like on Firefox 3.1 with tracemonkey enabled on Windows, Wine and Linux. [1] http://tech.slashdot.org/article.pl?sid=09/02/13/0058251 [2] http://www.tuxradar.com/content/browser-benchmarks-2-even-wine-beats-linux-… - Reece

3 3

Re: atmlib: add stub dll
by Nikolay Sivov Feb. 13, 2009

Feb. 13, 2009

Austin English wrote: > Needed by photoshop cs4. See bug 16385. > > diff --git a/dlls/atmlib/atmlib_main.c b/dlls/atmlib/atmlib_main.c > new file mode 100644 > index 0000000..bb17989 > --- /dev/null > +++ b/dlls/atmlib/atmlib_main.c > @@ -0,0 +1,45 @@ > +/* > + * MSSIGN32 implementation > + * > + * Copyright 2009 Austin English > + * > Hi, Austin, not mssign32 ).

2 2

Re: wintrust(3/3): Fix a couple tests on a variety of systems
by Ge van Geldorp Feb. 13, 2009

Feb. 13, 2009

> From: Alexandre Julliard <julliard(a)winehq.org> > > Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > > > I sent out an email earlier to ask if we should include more > > information in the header of the report. We could use that > > information, if this change will be accepted by AJ, to > > limit the reporting only to boxes were we have admin rights. > > > > As soon as all boxes have zero failures (yeah, right) we > > can remove that limit. > > Yes, we will want to fix these tests eventually, since we > will some day support multi-user setups where normal users > won't have admin rights, and we will need tests to make sure > we fail the right way. But in the meantime we can certainly > block these reports and concentrate on the more meaningful failures. I'll take that as a hint to switch my test machines to full admin. Should result in quite a bit more green. Ge.

1 0

Re: [sane.ds try2 1/3] Get resolution from sane, instead of hard coding -1.
by Juan Lang Feb. 13, 2009

Feb. 13, 2009

Hi Jeremy, a couple comments: - pImageInfo->XResolution.Whole = -1; + if (sane_option_get_int(activeDS.deviceHandle, "resolution", &resolution) == SANE_STATUS_GOOD) + pImageInfo->XResolution.Whole = pImageInfo->YResolution.Whole = resolution; (snip) +/* Option functions */ +#ifdef SONAME_LIBSANE +SANE_Status sane_option_get_int(SANE_Handle h, const char *option_name, SANE_Int *val); +#endif With this change, sane.ds will not compile unless SONAME_LIBSANE is defined. Is this intended? More likely not, and you need to provide a version of sane_option_get_int when it isn't defined, or use an #ifdef at the call site (ick.) The other comment is, is adding a new file (option.c) really necessary? If you're planning to expand it a lot, perhaps, but just for this one small function it looks like overkill to me. --Juan

2 2

RFC: patch to advapi32's cred tests
by Juan Lang Feb. 13, 2009

Feb. 13, 2009

Hi all, I've written a patch which should fix the failing advapi32 cred tests that mirrors the skips in the existing tests: diff --git a/dlls/advapi32/tests/cred.c b/dlls/advapi32/tests/cred.c index 58103c6..bb6935b 100644 --- a/dlls/advapi32/tests/cred.c +++ b/dlls/advapi32/tests/cred.c @@ -238,7 +238,13 @@ static void test_generic(void) new_cred.UserName = (char *)"winetest"; ret = pCredWriteA(&new_cred, 0); - ok(ret, "CredWriteA failed with error %d\n", GetLastError()); + ok(ret || broken(GetLastError() == ERROR_NO_SUCH_LOGON_SESSION), + "CredWriteA failed with error %d\n", GetLastError()); + if (!ret) + { + skip("couldn't write generic credentials, skipping tests\n"); + return; + } ret = pCredEnumerateA(NULL, 0, &count, &creds); ok(ret, "CredEnumerateA failed with error %d\n", GetLastError()); I'm wondering whether a better patch would be to change the persist type from CRED_PERSIST_ENTERPRISE to CRED_PERSIST_LOCAL_MACHINE. Rob, this is particularly aimed at you since you wrote the original tests: is there a good reason to use CRED_PERSIST_ENTERPRISE here? --Juan

2 2

How to get more info on timed out/crashed tests?
by Juan Lang Feb. 13, 2009

Feb. 13, 2009

Hi all, there are a number of tests at test.winehq.org that indicate that they're timed out or crashed. The difficulty is, I have no access to machines running the version of Windows on which the test is timing out or failing, and the data about the crash are not helpful in pinpointing the failing test. How can we get more information about these timeouts/crashes? --Juan

3 3

RE: [1/2] gdiplus/tests: Some tests for Image raw format value
by Nikolay Sivov Feb. 13, 2009

Feb. 13, 2009

Anything wrong with that? http://www.winehq.org/pipermail/wine-patches/2009-February/069267.html http://www.winehq.org/pipermail/wine-patches/2009-February/069273.html

1 0

Re: wintrust(3/3): Fix a couple tests on a variety of systems
by Paul Vriens Feb. 13, 2009

Feb. 13, 2009

Juan Lang wrote: > --Juan > > > ------------------------------------------------------------------------ > > This is of course on boxes where people dont' run winetest as a administrator. I'm not sure if ERROR_ACCESS_DENIED is thus actually an acceptable failure. In other tests we have used skip() for this. -- Cheers, Paul.

4 5

Proposed goal for website: happily usable at 800x600?
by Dan Kegel Feb. 13, 2009

Feb. 13, 2009

What with netbooks with small screens abounding, it might make sense to review our web site and make sure its most important parts are usable in an 800x600 screen (easy to simulate, just resize your browser until xwininfo says it's 800x550, those gnome top and bottom bars chew 25 pixels each). That's asking a lot, I suppose... - Dan

7 9

Re: [PATCH] comdlg32: check for lfs NULL ptr (Coverity)
by Alexandre Julliard Feb. 13, 2009

Feb. 13, 2009

Marcus Meissner <marcus(a)jet.franken.de> writes: > CID 119, 188, resubmit with working patch from earlier round. > > I guess we could also just let it crash if this happens, but > I am not feeling comfortable. These are internal functions, it doesn't make sense to call them with NULL. -- Alexandre Julliard julliard(a)winehq.org

1 0