February 2009 - Wine-Devel - list.winehq.org

Re: [PATCH] cryptui: check NULL ptr differently (Coverity)
by Paul Vriens Feb. 5, 2009

Feb. 5, 2009

Marcus Meissner wrote: > Hi, > > CID 829, cryptui fails to handle data being NULL > correctly after the if (data) branch. > > Since it is a allocation error, just return on failure. > > Ciao, Marcus > --- > dlls/cryptui/main.c | 35 +++++++++++++++++------------------ > 1 files changed, 17 insertions(+), 18 deletions(-) > > diff --git a/dlls/cryptui/main.c b/dlls/cryptui/main.c > index 498c158..1fe2ed0 100644 > --- a/dlls/cryptui/main.c > +++ b/dlls/cryptui/main.c > @@ -1076,25 +1076,24 @@ static LRESULT CALLBACK cert_mgr_dlg_proc(HWND hwnd, UINT msg, WPARAM wp, > HWND tab = GetDlgItem(hwnd, IDC_MGR_STORES); > > data = HeapAlloc(GetProcessHeap(), 0, sizeof(struct CertMgrData)); > - if (data) > + if (!data) > + return 0; > + data->imageList = ImageList_Create(16, 16, ILC_COLOR4 | ILC_MASK, 2, 0); > + if (data->imageList) > { > - data->imageList = ImageList_Create(16, 16, ILC_COLOR4 | ILC_MASK, > - 2, 0); > - if (data->imageList) > - { > - HBITMAP bmp; > - COLORREF backColor = RGB(255, 0, 255); > + HBITMAP bmp; > + COLORREF backColor = RGB(255, 0, 255); > + > + bmp = LoadBitmapW(hInstance, MAKEINTRESOURCEW(IDB_SMALL_ICONS)); > + ImageList_AddMasked(data->imageList, bmp, backColor); > + DeleteObject(bmp); > + ImageList_SetBkColor(data->imageList, CLR_NONE); > + SendMessageW(GetDlgItem(hwnd, IDC_MGR_CERTS), LVM_SETIMAGELIST, > + LVSIL_SMALL, (LPARAM)data->imageList); > + } > + SetWindowLongPtrW(hwnd, DWLP_USER, (LPARAM)data); > + data->title = pCryptUICertMgr->pwszTitle; > > - bmp = LoadBitmapW(hInstance, MAKEINTRESOURCEW(IDB_SMALL_ICONS)); > - ImageList_AddMasked(data->imageList, bmp, backColor); > - DeleteObject(bmp); > - ImageList_SetBkColor(data->imageList, CLR_NONE); > - SendMessageW(GetDlgItem(hwnd, IDC_MGR_CERTS), LVM_SETIMAGELIST, > - LVSIL_SMALL, (LPARAM)data->imageList); > - } > - SetWindowLongPtrW(hwnd, DWLP_USER, (LPARAM)data); > - data->title = pCryptUICertMgr->pwszTitle; > - } > initialize_purpose_selection(hwnd); > add_cert_columns(hwnd); > if (pCryptUICertMgr->pwszTitle) You are mixing tabs and spaces in this one. -- Cheers, Paul.

1 0

Quick and dirty testcases for MS-DOS API?
by Dan Kegel Feb. 4, 2009

Feb. 4, 2009

Looking at http://bugs.winehq.org/show_bug.cgi?id=17181 I get a feeling that we really need some testcases to verify we conform to the 16 bit MS-DOS API. Yeah, even though 16 bit is on the way out, there's still some use for a few win16 programs, and they use MS-DOS for file I/O. We could merge in http://win16test.googlecode.com, but that requires the Watcom C compiler, and "apt-cache search watcom" still comes up empty (unless you're on Ark Linux, see http://www.openwatcom.org/index.php/Installing_Open_Watcom_on_Linux ) And the Linux build had problems building DOS apps last time I tried anyway. But "apt-get install nasm" works great, so let's use it to run just a few crucial testcases, in particular, the one that keeps DOS apps from recursively deleting directories. What I'm thinking is to add a configure check for nasm. If it's present, and the target is 32 bit Intel, dlls/winedos/tests would use it to assemble a few simple assembly testcases. The test cases would be run from a normal test case (so no deep integration), and only when running on a machine capable of running 16 bit code. I'll probably have an include file for routines to print PASS and FAIL, but otherwise it'll be very, very bare bones. 'Course, I have no idea when I'll have time to do this, but I imagine it won't be too complicated. It wouldn't bother me at all if somebody beat me to it. - Dan

7 13

Re: [PATCH] mshtml: fixed second buffer argument to MultiByteToWideChar
by Austin English Feb. 4, 2009

Feb. 4, 2009

On Wed, Feb 4, 2009 at 2:11 PM, Marcus Meissner <marcus(a)jet.franken.de> wrote: > Hi, > > Targetbuffer length must not be -1. > > Ciao, Marcus > --- > dlls/mshtml/editor.c | 2 +- > dlls/mshtml/navigate.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/editor.c b/dlls/mshtml/editor.c > index 7cbdf2e..e92cf96 100644 > --- a/dlls/mshtml/editor.c > +++ b/dlls/mshtml/editor.c > @@ -588,7 +588,7 @@ static HRESULT exec_fontname(HTMLDocument *This, DWORD cmdexecopt, VARIANT *in, > > len = MultiByteToWideChar(CP_ACP, 0, stra, -1, NULL, 0); > strw = heap_alloc(len*sizeof(WCHAR)); > - MultiByteToWideChar(CP_ACP, 0, stra, -1, strw, -1); > + MultiByteToWideChar(CP_ACP, 0, stra, -1, strw, len); > nsfree(stra); > > V_BSTR(out) = SysAllocString(strw); > diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c > index 188cdd7..6e41699 100644 > --- a/dlls/mshtml/navigate.c > +++ b/dlls/mshtml/navigate.c > @@ -657,7 +657,7 @@ static void parse_post_data(nsIInputStream *post_data_stream, LPWSTR *headers_re > else > headers = heap_alloc((len+1)*sizeof(WCHAR)); > > - len = MultiByteToWideChar(CP_ACP, 0, ptr2, ptr-ptr2, headers+headers_len, -1); > + len = MultiByteToWideChar(CP_ACP, 0, ptr2, ptr-ptr2, headers+headers_len, len); > headers_len += len; > > ptr2 = ptr; > -- > 1.5.6 > > > Are these coverity fixes? -- -Austin

2 1

Re: mshtml: Implement IHTMLStyle_put_backgroundColor
by Alistair Leslie-Hughes Feb. 4, 2009

Feb. 4, 2009

Hi Ricardo, > hi alistair, > you say it implements the put method but the patch has only the get > method... typo? > Thanks for picking this up. It's a typo, Ill resend shortly. Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH] mshtml: call install_cab_file() with name directly on non-Wine
by Steven Edwards Feb. 4, 2009

Feb. 4, 2009

On Wed, Feb 4, 2009 at 1:11 PM, Marcus Meissner <marcus(a)jet.franken.de> wrote: > Hi, > > A ReactOS developer told me that if the wine_get_dos_file_name() does > not return a function, we should just pass in the current filename > to install_cab_file. > > So I coded it, but the non-UNIX path is untested. > <snip> > Wonder why he does not send a patch himself. Heh maybe his Julliard ranking is not high enough. ;) > + } else { /* ReactOS mode. */ Maybe this should say Windows mode or Mingw mode. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

messagemode named pipes investigation: blocking-reads block writers indefinitely
by Luke Kenneth Casson Leighton Feb. 4, 2009

Feb. 4, 2009

fascinatingly strange observation came out of writing the latest test (threadwrites) to do namedpipe interoperability testing. main process: blocking-read on namedpipe. 5 threads: write to same named pipe the writes NEVER return (this is with xp). so that WOULD indicate that there IS a per-pipe mutex (and that there are bugs in nt!) l.

1 1

X11DRV_XRandR_Cleanup() is not used
by Francois Gouget Feb. 4, 2009

Feb. 4, 2009

dlls/x11drv/xrandr.c defines a X11DRV_XRandR_Cleanup() function but it is not actually used anywhere. If I remember correctly past wine-devel emails, restoring the right XRandR mode when an application exits can be tricky (especially in case of a crash). So maybe this is why the function is not called, though I'm not sure it's even related. So my question is: should this function be removed? Or should I simply send a patch calling it from x11drv_main.c:process_detach(), enclosed with the appropriate SONAME_LIBXRANDR? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Good judgment comes from experience, and experience comes from bad judgment -- Barry LePatner

2 1

Re: [2/3] Add initial "write text" support for VGA graphic modes. Requires mode info unify patch
by Alexandre Julliard Feb. 4, 2009

Feb. 4, 2009

Jeremiah Flerchinger <jeremiah.flerchinger(a)gmail.com> writes: > else > { > - FIXME("Write %c at (%i,%i) - not yet supported in graphic modes.\n", (char)ascii, x, y); > + dat = vga_fb_window_data; > + /* get attribute values */ > + fgColor = attr & 0x0F; > + bgColor = (attr & 0x70)>>4; > + /* Create DC to draw font on */ > + hDC = CreateCompatibleDC(NULL); > + if (hDC == 0) > + { > + ERR("CreateCompatibleDC FAILED. \n"); > + } > + /* Create bitmap to draw font on > + * define bitmap info {size, width, height, planes, bits, compression, sizeimage} > + * origin defaults to top left. negative height makes origin at bottom left. > + */ > + hTempBmp = CreateDIBSection( hDC, &bmi, DIB_RGB_COLORS, (void**)&pSrcData, NULL, 0 ); > + if (hTempBmp == NULL) > + { > + ERR("CreateDIBSection FAILED. \n"); > + } You should actually handle the errors, not just print an ERR and go on using invalid data. > + /* get a font compatable to old IBM ROM (IBM extended character set) */ > + IBM_hFont = (HFONT) GetStockObject( OEM_FIXED_FONT ); > + GetObjectA ( IBM_hFont, sizeof(LOGFONTA), & IBM_lFont ); > + /* scale character & set attributes - FIXME tweak or make better font for smaller sizes */ > + IBM_lFont.lfWidth = ModeInfo->CharWidth; > + IBM_lFont.lfHeight = ModeInfo->CharHeight; > + /* create new font with desired properties */ > + ModIBM_hFont = CreateFontIndirectA ( & IBM_lFont ); > + if (ModIBM_hFont == NULL) > + { > + ERR("CreateFontIndirectA FAILED. \n"); > + } > + SelectObject(hDC, hTempBmp); > + SelectObject(hDC, ModIBM_hFont); > + SetTextColor(hDC, fgColor<<16); /* set text color 0x00bbggrr */ > + SetBkColor(hDC, bgColor<<16); /* set text color 0x00bbggrr */ > + /* define where char is drawn on bitmap */ > + rect.left = 0; > + rect.top = 0; > + rect.bottom = ModeInfo->CharHeight-1; > + rect.right = ModeInfo->CharWidth-1; > + /* draw char onto temporary bitmap */ > + DrawTextHeight = DrawTextA(hDC, (char *)&ascii, 1, &rect, DT_LEFT); > + if (DrawTextHeight == 0) > + { > + ERR("DrawTextA FAILED. \n"); > + } > + /* translate from TextRow & TextCol to PixelRow & PixelCol */ > + x = x * ModeInfo->CharWidth; > + y = y * ModeInfo->CharHeight; > + /* translate & copy char into display buffer */ > + for (ih = 0; ih < ModeInfo->CharHeight; ih = ih+1) Please cut down on the number of comments, there's no need to explain what each line of code is doing, that's adding more noise than information. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comctl32: Save and restore colours when adding masked images
by Hans Leidekker Feb. 4, 2009

Feb. 4, 2009

Hi Peter, > This patch will save and restore the colours when adding a masked image > to ImageList. Some lines in this patch were wrapped, please attach it like you do in your other mails. -Hans

2 1

Re: mshtml: Implement IHTMLStyle_put_backgroundColor
by ricardo_barbano＠hotmail.com Feb. 4, 2009

Feb. 4, 2009

hi alistair, you say it implements the put method but the patch has only the get method... typo? regards, ricardo -------------------------------------------------- From: "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> Sent: Wednesday, February 04, 2009 5:02 AM To: <wine-patches(a)winehq.org> Subject: mshtml: Implement IHTMLStyle_put_backgroundColor > Hi, > > Changelog: > mshtml: Implement IHTMLStyle_put_backgroundColor > > Best Regards > Alistair Leslie-Hughes > > > > > From fde0238571c3eca78527600d846ff88add6510b0 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Wed, 4 Feb 2009 16:01:05 +1100 > Subject: [PATCH] Implement IHTMLStyle_put_backgroundColor > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/mshtml/htmlstyle.c | 6 ++++-- > dlls/mshtml/tests/dom.c | 6 ++++++ > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c > index ad9d095..4964c10 100644 > --- a/dlls/mshtml/htmlstyle.c > +++ b/dlls/mshtml/htmlstyle.c > @@ -743,8 +743,10 @@ static HRESULT WINAPI > HTMLStyle_put_backgroundColor(IHTMLStyle *iface, VARIANT v > static HRESULT WINAPI HTMLStyle_get_backgroundColor(IHTMLStyle *iface, > VARIANT *p) > { > HTMLStyle *This = HTMLSTYLE_THIS(iface); > - FIXME("(%p)->(%p)\n", This, p); > - return E_NOTIMPL; > + TRACE("(%p)->(%p)\n", This, p); > + > + V_VT(p) = VT_BSTR; > + return get_style_attr(This, STYLEID_BACKGROUND_COLOR, &V_BSTR(p)); > } > > static HRESULT WINAPI HTMLStyle_put_backgroundImage(IHTMLStyle *iface, > BSTR v) > diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c > index 62a07bc..77075fb 100644 > --- a/dlls/mshtml/tests/dom.c > +++ b/dlls/mshtml/tests/dom.c > @@ -2906,6 +2906,12 @@ static void test_default_style(IHTMLStyle *style) > test_border_styles(style, str); > SysFreeString(str); > > + hres = IHTMLStyle_get_backgroundColor(style, &v); > + ok(hres == S_OK, "get_backgroundColor: %08x\n", hres); > + ok(V_VT(&v) == VT_BSTR, "type failed: %d\n", V_VT(&v)); > + ok(!V_BSTR(&v), "str=%s\n", dbgstr_w(V_BSTR(&v))); > + VariantClear(&v); > + > hres = IHTMLStyle_QueryInterface(style, &IID_IHTMLStyle2, > (void**)&style2); > ok(hres == S_OK, "Could not get IHTMLStyle2 iface: %08x\n", hres); > if(SUCCEEDED(hres)) { > -- > 1.5.4.3 > > > >

1 0

Need help for D3DXComputeSphereBounding
by paulo lesgaz Feb. 4, 2009

Feb. 4, 2009

Hello, I am trying to implement D3DXComputerSphereBounding. The attached test cases success with a native d3dx9 but fail with a native d3dx8. Can anyone could explain why? Thanks in advance

1 0

Happy user says: "You’ve done the impossible, and it is good."
by Dan Kegel Feb. 4, 2009

Feb. 4, 2009

A user is declaring that Wine has succeeded: http://loobin.wordpress.com/2009/01/13/wine-ascendant/ http://loobin.wordpress.com/2009/02/03/wine-going-production/

1 0

Re: MSVCRT: Still problems in ASCII Mode
by Dan Kegel Feb. 4, 2009

Feb. 4, 2009

Thanks. Please don't use rand() in testcases, though. Would a constant 'a' suffice in this case? Which app did you find this in, btw? On Tue, Feb 3, 2009 at 1:55 PM, Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> wrote: > Hello, > > it seems that in ASCII mode, fseek() may disturb reading. Appended patch > adds a todo_wine. > > Bye > -- > Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de > > Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt > --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- > diff --git a/dlls/msvcrt/tests/file.c b/dlls/msvcrt/tests/file.c > index 9032e51..2a72212 100644 > --- a/dlls/msvcrt/tests/file.c > +++ b/dlls/msvcrt/tests/file.c > @@ -306,7 +306,8 @@ static void test_asciimode(void) > { > FILE *fp; > char buf[64]; > - int c, i, j; > + int c, i, j, done, count1, count2; > + > > /* Simple test of CR CR LF handling. Test both fgets and fread code paths, they're different! */ > fp = fopen("ascii.tst", "wb"); > @@ -372,6 +373,46 @@ static void test_asciimode(void) > ok((c = fgetc(fp)) == '1', "fgetc fails to read next char when positioned on \\r\n"); > fclose(fp); > > + fp= fopen("ascii.tst","wb"); > + for (i=0; i<1000; i++) > + { > + unsigned char c = (rand()+ ' ') & 0x7f; > + if (isgraph(c) || (c == ' ')) > + fputc(c, fp); > + else if ((c == '\r') || (c == '\n')) > + fputs("\r\n", fp); > + } > + fclose(fp); > + > + done = 0; > + count1 = 0; > + > + fp = fopen("ascii.tst", "r"); > + while (!done) > + { > + c= fgetc(fp); > + if (c == EOF) > + done = 1; > + else if (isalnum(c)) > + count1 ++; > + } > + fclose(fp); > + > + done = 0; > + count2 = 0; > + > + fp = fopen("ascii.tst", "r"); > + while (!done) > + { > + c= fgetc(fp); > + fseek(fp, 0, SEEK_CUR); > + if (c == EOF) > + done = 1; > + else if (isalnum(c)) > + count2 ++; > + } > + fclose(fp); > + todo_wine ok((count1 == count2), "fseek caused short read %d vs %d\n", count2, count1); > unlink("ascii.tst"); > } > >

2 2

Re: shdocvw: Correct OnAmbientPropertyChange regession
by Jacek Caban Feb. 3, 2009

Feb. 3, 2009

Alistair Leslie-Hughes wrote: > Hi, > After testing on XP, it appears that OnAmbientPropertyChange when > passwed DISP_UNKNOWN doesnt check all properties. > > Changelog: > shdocvw: Correct OnAmbientPropertyChange regession + CHECK_NOT_CALLED(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); + CHECK_NOT_CALLED(Invoke_AMBIENT_SILENT); + CHECK_NOT_CALLED(Invoke_AMBIENT_USERMODE); + CHECK_NOT_CALLED(Invoke_AMBIENT_DLCONTROL); + CHECK_NOT_CALLED(Invoke_AMBIENT_USERAGENT); + CHECK_NOT_CALLED(Invoke_AMBIENT_PALETTE); These checks don't make sense here. If you don't set these calls as expected, CHECK_EXPECT will fail when they are called. Jacek

2 1

Fixing AppDB once and for all
by Zachary Goldberg Feb. 3, 2009

Feb. 3, 2009

All, So it seems to be almost every other day now when somebody mentions how broken the appdb rating system is. This "broken-ness" has had several high level discussions on Wine-Devel. There have also been many, many proposed solutions to this problem. I do not wish to discuss these problems or these solutions in this thread. It is time something was done about this. By done I mean agreed upon (probably the harder part) then implemented in code and published to the winehq server(s). I'de like to arrange an IRC discussion for all those interested in finalizing an attack plan, and then assigning the responsibility of doing it to somebody who is capable and has the time (perhaps myself). Lets (arbitrarily) set a time for the chat at: When: 11PM UTC (6PM EST) 2/6/09 (Friday) Where: #winehackers If this arbitrary time seems to be poorly chosen for a large number of people then please propose an alternative well in advance so all are aware of it. --Zach

6 6

Re: Fixing AppDB once and for all
by James Mckenzie Feb. 3, 2009

Feb. 3, 2009

Zachary Goldberg <zgold(a)bluesata.com> >Sent: Feb 3, 2009 12:27 PM >To: James Mckenzie <jjmckenzie51(a)earthlink.net> >Cc: Wine Devel <wine-devel(a)winehq.org>, Jeremy Newman <jnewman(a)codeweavers.com> >Subject: Re: Fixing AppDB once and for all > >2009/2/3 James Mckenzie <jjmckenzie51(a)earthlink.net>: >> This would be too early for people on the West Coast of the United States by about three hours. >> >> No time will be satisfactory for all people who work on this project. >> >> What I feel is necessary at this point is to collect who lives in what time zone so that we incovience as few people as possible. >> >> Since this would be Saturday in Asia, this time may work for the majority of the people on this list. >> >> Also, will there be a transcript of the discussion and where will it be placed since this has a major impact on the functionality of the Applications Database. >> >> James McKenzie >> >> > >I have made a wiki on winehq with an agenda which will be updated with >the results (and maybe transcript?) of the conversation. > >http://wiki.winehq.org/AppDBUpgrades Thank you for your forward thinking and thoughtfulness. I look forward to reading the Wiki and reviewing what is determined during the IRC conversation as I will not be able to attend. James McKenzie

1 0

Re: wine honor roll slashdotted
by James Mckenzie Feb. 3, 2009

Feb. 3, 2009

Dan Kegel <dank(a)kegel.com> wrote: >Sent: Feb 3, 2009 6:48 AM >To: Wine Devel <wine-devel(a)winehq.org> >Subject: wine honor roll slashdotted > >http://tech.slashdot.org/article.pl?sid=09/02/03/0112249 > >One comment mentions the grade inflation on the appdb, >i.e. platinum apps that have not been thoroughly tested >or don't really qualify as platinum... > Dan: Sadly, I agree with the grade inflation. We need a grading interface that will generate whether or not an application is Plat/Gold/Silver/Bronze/Garbage based upon user input. This usually stops the inflation. James McKenzie

4 3

Re: advapi32: add Security Label sids used by IE7
by Paul Vriens Feb. 3, 2009

Feb. 3, 2009

Aric Stewart wrote: > --- > dlls/advapi32/security.c | 4 ++++ > include/winnt.h | 16 +++++++++++++++- > 2 files changed, 19 insertions(+), 1 deletions(-) > > > > ------------------------------------------------------------------------ > > You added WinUntrustedLabelSid to winnt.h but not to security.c. Is that correct? -- Cheers, Paul.

2 1

Re: kernel32/tests: Add a CreateMutex test. (Win9X todo)
by Dmitry Timoshkov Feb. 3, 2009

Feb. 3, 2009

"Florian Tobias Schandinat" <FlorianSchandinat(a)gmx.de> wrote: > this test shows a difference between Win9X and NT. (tested on Win98SE > and WinXP) Some apps expect the Win9X behaviour to work. I don't know > what's the right way to fix it. Any advice or patch is welcome. How do that apps work under NT based Windows versions like XP or Vista? -- Dmitry.

2 1

Re: winedos: Improve PIT emulation.
by Alexandre Julliard Feb. 3, 2009

Feb. 3, 2009

Florian Tobias Schandinat <FlorianSchandinat(a)gmx.de> writes: > + /* Convert: time counter -> PIT counter > + * GetSystemTimeAsFileTime: 10000000 Hz > + * PIT frequency: 1193182 Hz */ > + val = (DWORD)(val - delta*1193182./10000000.) % (maxval + 1); You should probably use QueryPerformanceCounter as it already uses the correct frequency. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: shdocvw: OnAmbientPropertyChange should refresh all properties with a DISPID_UNKNOWN (try 2)
by Paul Vriens Feb. 3, 2009

Feb. 3, 2009

Alistair Leslie-Hughes wrote: > Hi, > Added Tests > > Changelog: > shdocvw: OnAmbientPropertyChange should refresh all properties with > a DISPID_UNKNOWN > > Best Regards > Alistair Leslie-Hughes > > > > > > ------------------------------------------------------------------------ > > Hi, These new tests fails on W98, NT4, W2K3 and Vista (no other reports are in yet). Could you have a look? -- Cheers, Paul.

2 1

Re: propsys: Stub for PSRegisterPropertySchema (resent)
by Alexandre Julliard Feb. 3, 2009

Feb. 3, 2009

Nikolay Sivov <bunglehead(a)gmail.com> writes: > @@ -0,0 +1,34 @@ > +/* > + * Property schema routines > + * > + * Copyright 2009 Nikolay Sivov > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#include <stdarg.h> > + > +#include "windef.h" > +#include "winbase.h" > +#include "wine/debug.h" > + > +WINE_DEFAULT_DEBUG_CHANNEL(propsys); > + > +HRESULT WINAPI PSRegisterPropertySchema(PCWSTR path) > +{ > + FIXME("stub\n"); > + > + return E_NOTIMPL; > +} I don't think you need a new file for this. If someday there's a lot of code in there it can be split off to a separate file then. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Stub DDE interface for Progman.exe
by Austin English Feb. 3, 2009

Feb. 3, 2009

On Mon, Feb 2, 2009 at 11:24 PM, Jeremiah Flerchinger <jeremiah.flerchinger(a)gmail.com> wrote: > Stubs basic DDE interface of Progman.exe. Similar to Progman stub in > shell32.dll. Both will need to be extended and a 3rd progman interface > will need to be added in user32. > --- > programs/progman/main.c | 148 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 148 insertions(+), 0 deletions(-) > > diff --git a/programs/progman/main.c b/programs/progman/main.c > index 83a346c..51dbcff 100644 > --- a/programs/progman/main.c > +++ b/programs/progman/main.c > @@ -56,6 +154,12 @@ int PASCAL WinMain (HINSTANCE hInstance, HINSTANCE prev, LPSTR cmdline, int show > Globals.hGroups = 0; > Globals.hActiveGroup = 0; > > + /**/ > + DdeInitializeW(&dwDDEInst, DdeCallback, APPCLASS_STANDARD, 0); > + hszProgmanTopic = DdeCreateStringHandleW(dwDDEInst, wszProgman, CP_WINUNICODE); > + hszProgmanService = DdeCreateStringHandleW(dwDDEInst, wszProgman, CP_WINUNICODE); > + DdeNameService(dwDDEInst, hszProgmanService, 0, DNS_REGISTER); > + Empty comment. > + case WM_DDE_TERMINATE: > + printf("Progman.exe: WM_DDE_TERMINATE stub \n"); > +// PostMessage( (HWND)wParam, WM_DDE_TERMINATE, (WPARAM)hWnd, 0); > + break; > } > return(DefFrameProc(hWnd, Globals.hMDIWnd, msg, wParam, lParam)); > } C++ comments are not allowed. Thanks for helping Wine! -- -Austin

1 0

wine honor roll slashdotted
by Dan Kegel Feb. 3, 2009

Feb. 3, 2009

http://tech.slashdot.org/article.pl?sid=09/02/03/0112249 One comment mentions the grade inflation on the appdb, i.e. platinum apps that have not been thoroughly tested or don't really qualify as platinum...

1 0

Re: d3d9/tests : LockRect acquires the lock if D3DLOCK_NOSYSLOCK is not specified.
by Jérôme Gardou Feb. 3, 2009

Feb. 3, 2009

Forget this one please.

2 1

[winetest] Make sure we can test .NET dlls on Windows (need some advice)
by Paul Vriens Feb. 3, 2009

Feb. 3, 2009

Hi, Sent to wine-devel so I don't jeopardize my rating too much ;) .NET dlls cannot be found with the existing logic in winetest, mainly because they are not in the search path. If the normal loading of a dll fails we now check against a fixed set of names (fusion only for now). If it's a .NET dll we check if this one is there (according to .NET's mscoree) and get the file information. We can use to existing version checking stuff for that part as it's a normal dll. Remarks, suggestions? Changelog Make sure we can test .NET dlls on Windows -- Cheers, Paul.

1 0

Re: ntdll: add a warning about running wine as root (try 2)
by Vincent Povirk Feb. 2, 2009

Feb. 2, 2009

The patch does not apply to current master. Vincent Povirk On Mon, Feb 2, 2009 at 8:01 PM, Austin English <austinenglish(a)gmail.com> wrote: > Been seeing it quite a bit recently in the forums. While the patches > to break using sudo/su have helped a bit, seems some users are > convinced they need to run wine as root. This adds a non fatal > message, so no functionality is lost for those that _do_ need to run > as root. > > Try 2: > Made warning a bit more verbose. Changed geteuid to getuid, since we > already check for that function, and geteuid is a bit is superfluous, > since sudo should already be prevented. > > -- > -Austin > > > >

2 1

Re: jscript: Don't fail tests if IActiveScriptParse isn't supported
by Jacek Caban Feb. 2, 2009

Feb. 2, 2009

Hi Juan, These failures are on Win64 where we should query for different interface. I've sent a patch to fix it: http://www.winehq.org/pipermail/wine-patches/2009-February/068760.html Jacek

2 1

Re: Simplify dlls/comctl32/rebar.c
by Francois Gouget Feb. 2, 2009

Feb. 2, 2009

On Fri, 30 Jan 2009, Gerald Pfeifer wrote: > (It's not clear which parameters we'd really need if it is ever fully > implemented.) > > ChangeLog: > Simplify. [...] > > Index: dlls/comctl32/rebar.c [...] > @@ -3618,7 +3618,6 @@ REBAR_WindowProc (HWND hwnd, UINT uMsg, > > /* case RB_SETCOLORSCHEME: */ > /* case RB_SETPALETTE: */ > -/* return REBAR_GetPalette (infoPtr, wParam, lParam); */ > > case RB_SETPARENT: Once the commented out return has been removed it looks like RB_SETCOLORSCHEME and RB_SETPALETTE are meant to fall through to RB_SETPARENT, which does not seem right... So I'd leave a comment there, maybe /* return ...; */. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Research is the transformation of money to knowledge. Innovation is the transformation of knowledge to money. -- Dr. Hans Meixner

2 1

Re: Simple but awesome demos of Wine?
by Brian Vincent Feb. 2, 2009

Feb. 2, 2009

Oh, by the way, I was using Fedora Core 10. I was pretty impressed with the distro - my Intel wireless card worked out of the box and so did sound. That's the first time I've had that happen on a Dell Latitude notebook. However, sound in Wine didn't work at all. I made absolutely no effort to fix it, but a quick look at the settings showed it was trying to use ALSA. I was hoping Wine's sound had progressed to the point where it would at least work if the underlying distro was using sound in sane manner, which I'm kind of assuming Core 10 does. Is it a packaging issue? -Brian

2 1

deb packages archive down?
by Tom Wickline Feb. 2, 2009

Feb. 2, 2009

Hello, I have been trying to access the Wine deb archives for about six hours now and Ive been receiving a "connection to the server was reset" error. I'm not sure how long this has been the case but can the maintainer of the archive please look into this failure? http://wine.budgetdedicated.com/archive/index.html Cheers, Tom -- http://www.wine-reviews.net/ http://bordeauxgroup.com/

4 3

DIB Engine - Separated in small patches
by Massimo Del Fedele Feb. 2, 2009

Feb. 2, 2009

As requested I separated the engine in small patches, trying to keep original authors when possible. As the post didn't appear here (problem with zipped files, maybe ?), I've put it on bug 421 page. I whish to know if it can be ok for including on wine tree. Ciao Max

3 2

wine.budgetdedicated.com down?
by Dan Kegel Feb. 2, 2009

Feb. 2, 2009

I can't download debian wine packages from wine.budgetdedicated.com today...

4 4

Re: [2/2] mshtml: Add support for IHTMLStyle4 interface
by Jacek Caban Feb. 2, 2009

Feb. 2, 2009

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Add support for IHTMLStyle4 interface > --- dlls/mshtml/Makefile.in | 1 + dlls/mshtml/htmlstyle.c | 4 ++ dlls/mshtml/htmlstyle.h | 3 + dlls/mshtml/htmlstyle4.c | 135 ++++++++++++++++++++++++++++++++++++++++++++++ dlls/mshtml/tests/dom.c | 7 +++ 5 files changed, 150 insertions(+), 0 deletions(-) create mode 100644 dlls/mshtml/htmlstyle4.c This interface has very few methods so it doesn't make sense to add new file for it. Jacek

1 0

Re: [1/2] mshtml: Add support for IHTMLStyle3 interface
by Jacek Caban Feb. 2, 2009

Feb. 2, 2009

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Add support for IHTMLStyle3 interface > + + hres = IHTMLStyle_QueryInterface(style, &IID_IHTMLStyle3, (void**)&style3); + ok(hres == S_OK, "Could not get IHTMLStyle3 iface: %08x\n", hres); + if(SUCCEEDED(hres)) { + IHTMLStyle3_Release(style3); + } Please use style_iids to test QueryInterface calls. Jacek

1 0

Re: Anything wrong with this patch?
by Ben Klein Feb. 2, 2009

Feb. 2, 2009

2009/1/24 Jérôme Gardou <jerome.gardou(a)gmail.com>: > Ben Klein a écrit : >> >> 2009/1/24 Jerome Leclanche <adys.wh(a)gmail.com>: >> >>> (Damnit, gmail interface) >>> Pipermail shows as empty, here. >>> >>> On Fri, Jan 23, 2009 at 10:05 PM, Jérôme Gardou <jerome.gardou(a)gmail.com> >>> wrote: >>> >>>> http://www.winehq.org/pipermail/wine-patches/2009-January/067564.html >>>> Any comment on this one? Related to bug 15616. >> >> Looks like >> http://www.winehq.org/pipermail/wine-patches/2009-January/067564.html >> has a brief description that says "See bug 15616", but the previous >> mail http://www.winehq.org/pipermail/wine-patches/2009-January/067565.html >> has the actual patch. >> >> Jérôme, be more careful when submitting patches! :) > > strange... the first one is the original message, the second one looks like > the attachment... Maybe something wrong with thunderbird. I'll resend if > needed. > I just looked at bug 15616. Maybe you should look at it too. Also, please hit "Reply to all" so your message gets sent to the mailing list too :)

3 7

Re: [2/2] mlang: Export a couple of functions by ordinal.
by Dmitry Timoshkov Feb. 2, 2009

Feb. 2, 2009

"Hans Leidekker" <hans(a)codeweavers.com> wrote: > IE7 imports these and possibly others by ordinal. > > -Hans > > diff --git a/dlls/mlang/mlang.spec b/dlls/mlang/mlang.spec > index 1e8f022..689ad27 100644 > --- a/dlls/mlang/mlang.spec > +++ b/dlls/mlang/mlang.spec > @@ -1,14 +1,15 @@ > +112 stdcall ConvertINetUnicodeToMultiByte(ptr long ptr ptr ptr ptr) > +120 stdcall LcidToRfc1766A(long ptr long) > +121 stdcall LcidToRfc1766W(long ptr long) > + > @ stdcall ConvertINetMultiByteToUnicode(ptr long ptr ptr ptr ptr) > @ stub ConvertINetReset > @ stdcall ConvertINetString(ptr long long ptr ptr ptr ptr) > -@ stdcall ConvertINetUnicodeToMultiByte(ptr long ptr ptr ptr ptr) > @ stdcall -private DllCanUnloadNow() > @ stdcall -private DllGetClassObject(ptr ptr ptr) > @ stdcall -private DllRegisterServer() > @ stdcall -private DllUnregisterServer() > @ stdcall GetGlobalFontLinkObject() > @ stdcall IsConvertINetStringAvailable(long long) > -@ stdcall LcidToRfc1766A(long ptr long) > -@ stdcall LcidToRfc1766W(long ptr long) > @ stdcall Rfc1766ToLcidA(ptr str) > @ stdcall Rfc1766ToLcidW(ptr wstr) I've compared the exports of win98 and winxp versions of mlang.dll and they have exactly the same ordinals assigned. So it should be safe to assign ordinals to all mlang exports (it's worth to mention that PSDK doesn't ship an mlang.lib). -- Dmitry.

1 0

Re: BOOL WINAPI versus BOOL in d3dx9 and d3dx8
by Tony Wasserka Feb. 2, 2009

Feb. 2, 2009

> Hi, > > the declaration of IntersectionTri is > BOOL IntersectionTri(.....) in d3dx8mesh.h and > BOOL WINAPI? IntersectionTri(.....) in d3dx9mesh.h . > > Is the latter one compatible with the former one (so I can forward d3dx9 function to the d3dx8 one) > or must I implement them separately? > > David It's already forwarded in d3dx9_36.spec to d3dx8, so you don't need to implement it twice. I was pretty careful when creating that specfile, i.e. it's in 99% safe to trust it ;) As a rule of thumb, every d3dx9 function which has no device (or any other D3D9 specific interface) parameter and has the exact same parameter list can safely be forwarded to d3dx8. However, are you sure it's only BOOL in d3dx8? AFAIK, dll functions always have to be WINAPI, as the calling convention gets screwed up otherwise... Best regards, Tony

2 1

wined3d and winex11 hand in hand...
by Jérôme Gardou Feb. 2, 2009

Feb. 2, 2009

Quite oddly enough, wined3d and winex11 don't communicate with each other at all (well, wined3d uses WGL in gdi32, and gdi32 is based on winex11), and this leads to problems which are tricky to resolve... For instance, when a d3d application wants to disable screensavers, there is no way to do this through the windows api, but xlib provides XSetScreenSaver which is axactly what we need there. Would it be a good way to do this, as in user32 and gdi32, to create a driver structure holding each function pointer we would need, and forward them to stub if unavailable?

2 2

performance issue when OffscreenRenderingMode = "pbuffer"
by Jérôme Gardou Feb. 1, 2009

Feb. 1, 2009

I tried to play Supreme Commander using pbuffer option instead of fbo. I was quite happy with it, since I gained quite a bunch of performance (I mean, something I really COULD see), but after a while, the performance dropped dramatically, to ~4-5 fps. I tested quite a few thing, and I finally found that pixel bufers were not taken in account when calculating available texture memory. The game then allocated more textures, and good opengl didn't dare complain when putting them in system memory. Attached is a patch which should solve the problem. For those who are curious, try setting VideoMemorySize to 200 instead of 256. It works just like a charm. >From 8e7b7e517b15e2ddb2cdd1526dfab3dfbf856bd5 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?J=C3=A9r=C3=B4me=20Gardou?= <jerome.gardou(a)laposte.net> Date: Sun, 25 Jan 2009 02:34:03 +0100 Subject: [PATCH] wined3d: take pixel buffers in account when calculating texture ram. --- dlls/wined3d/context.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c index da3053a..9fad82d 100644 --- a/dlls/wined3d/context.c +++ b/dlls/wined3d/context.c @@ -898,6 +898,9 @@ WineD3DContext *CreateContext(IWineD3DDeviceImpl *This, IWineD3DSurfaceImpl *tar } This->frag_pipe->enable_extension((IWineD3DDevice *) This, TRUE); + if(create_pbuffer) + WineD3DAdapterChangeGLRam(This, ((IWineD3DSurfaceImpl*)(ret->surface))->currentDesc.Width * ((IWineD3DSurfaceImpl*)(ret->surface))->currentDesc.Height * ((IWineD3DSurfaceImpl*)(ret->surface))->bytesPerPixel) ; + return ret; out: @@ -988,6 +991,7 @@ void DestroyContext(IWineD3DDeviceImpl *This, WineD3DContext *context) { if(context->isPBuffer) { GL_EXTCALL(wglReleasePbufferDCARB(context->pbuffer, context->hdc)); GL_EXTCALL(wglDestroyPbufferARB(context->pbuffer)); + WineD3DAdapterChangeGLRam(This,(-1) * ((IWineD3DSurfaceImpl*)(context->surface))->currentDesc.Width * ((IWineD3DSurfaceImpl*)(context->surface))->currentDesc.Height * ((IWineD3DSurfaceImpl*)(context->surface))->bytesPerPixel) ; } else ReleaseDC(context->win_handle, context->hdc); pwglDeleteContext(context->glCtx); -- 1.6.0.6

5 8

[RFC] Port of Stefan Dösinger's ARB_vertex_program fixed-function vertex pipeline replacement to 1.1.14
by Paul TBBle Hampson Feb. 1, 2009

Feb. 1, 2009

>From the discussion regarding the drawStridedSlow implementation of vertex blending, what shook out was the suggestion that WineD3D will need a vertex-program fixed function vertex pipeline at some point anyway, and therefore it doesn't make sense to add another software implementation to drawStridedSlow but to instead get the vertex pipeline in place and build the vertex blending functionality on top of that. Towards that aim, I've ported Stefan Dösinger's initial implementation of this from October last year [1] to what turned out to be 1.1.14. It fails two more D3D9 tests than 1.1.14: visual.c:914: Test failed: Transformed vertex with linear vertex fog has color 0000ff00 visual.c:986: Test failed: Transformed vertex with linear vertex fog has color 0000ff00 (I don't know if these failed when it was first implemented, so I don't know if the problem is the patch, the port, or even the test. This is on my nVidia 8600 w/180.22 binary drivers, in case it makes a difference.) I haven't run it with any games yet, or profiled it. Stefan's commented since that it was slower than the current system, albeit unoptimised, and that was the reason he didn't undertake any further work on it. I don't know what games use the fixed-function pipeline, so I'm open to suggestions and bug report references. All but the last patch in this tarball are ports of Stefan's original, and were done using git-am so still retain his original headers. The sorta-nasty no_d3dcolor_swizzle code in get_color and its caller in the last patch is entirely my fault though. ^_^ The last patch is actually also from Stefan's code, but it's an attempt by me to reinsert fog code I have removed, possibly incorrectly. However, it didn't fix the above fog failures, so I left it as a separate patch. I'm not totally sure I've got all the hard parts of the port right. The two relevant changes since these patches were applied were the implementation of EXT_vertex_buffer_bgra and the rearrangement of the fog code. For EXT_vertex_array_bgra and vertex_pipe->can_convert_d3dcolor, I'm not sure if there are places that check one and should check the other, and I'm not sure if the test in state.c line 4280 (streamsrc) is doing the right thing. I think it is doing the right thing. The vertex program recognises and handles a position_transformed vertex declaration itself. Of the original 13-patch series, patches 4 and 5 were rendered completely uninteresting by the fog changes, and 7 and 13 had already gone into the main tree. There was also what I believe was a bug in patch 2, which basically left pCaps->MaxUserClipPlanes uninitialised rather than fetching the value from the vertex_pipeline's get_caps method result. Anyway, here it is. I hope this is of benefit to someone. The next thing I plan to do with this is try and wrap my head around the internals of the arbvp vertex program so I can implement vertex blending there. [1] http://www.mail-archive.com/wine-devel(a)winehq.org/msg49501.html -- ----------------------------------------------------------- Paul "TBBle" Hampson, B.Sc, LPI, MCSE Very-later-year Asian Studies student, ANU The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361) Paul.Hampson(a)Pobox.com Of course Pacman didn't influence us as kids. If it did, we'd be running around in darkened rooms, popping pills and listening to repetitive music. -- Kristian Wilson, Nintendo, Inc, 1989 License: http://creativecommons.org/licenses/by/2.5/au/ -----------------------------------------------------------

2 1

[patch] review requested - NamedPipe Message mode (was Reliable Datagram / Stream behaviour of NT Pipes)
by Luke Kenneth Casson Leighton Feb. 1, 2009

Feb. 1, 2009

http://bugs.winehq.org/attachment.cgi?id=19132 ok this is the beginnings of an implementation of messagemode, it passes the test1 and send2recv2 tests and fails the shortread test as part of PeekNamedPipe(). i'm not exactly sure why, yet. i get the distinct feeling that there's confusion over who writes into the wineserver data structures what the "availdata" is. msrpc.exe says "set availdata to 9", msrpcd.exe says "set it to 0, we did a write!" and it's all just ohhhh dear. also i have double-copies of server_set_named_pipe_info(), one in kernel32 and another in ntdll because i am using it in both places, i think SetNamedPipeHandleState() should be calling an NtFsControlIo rather than using server_set_named_pipe_info() but for the life of me i _really_ don't want to be finding out what the heck that function is :) hmm, maybe i can find out by copying ntdll.dll over to wine and doing a WINEDEBUG=trace+ntdll,kernel32 to see what functions get called. anyway the primary purpose of submitting the patch is to ask people if i'm along the right lines. anything seriously objectionable, etc. etc. l.

3 6

Fwd: A basic implementation for increased security in wine proposal
by Guillaume SH Feb. 1, 2009

Feb. 1, 2009

---------- Forwarded message ---------- From: Guillaume SH <gsh.debianlists(a)gmail.com> Date: 2009/2/1 Subject: Re: A basic implementation for increased security in wine proposal To: Marcus Meissner <marcus(a)jet.franken.de> Hi Marcus, I stand corrected, as it appears I was way too naive in my understanding of software security, hence the example I provided. Regarding you explanation justifying there is no need to protect API against misuse, I am still not convinced, but I will think about it and try to get to a thorough understanding. Thank you for clarifying, Guillaume 2009/2/1 Marcus Meissner <marcus(a)jet.franken.de> > On Sun, Feb 01, 2009 at 10:41:25AM +0100, Guillaume SH wrote: > > > Hi Paul, > > > > You asked me to actually describe the security I am concerned about, so I > am > > going for it : > > > > Imagine an ill-intentioned people, call it the attackers. By the mean of > > simply creating the following C application (based on classical "Hello > > word") : > > > > > > #include needed header > > > > int main (int argc, char * argv[]) > > { > > /* printf ( "Hello world!" ); */ > > GetOverlappedResult(0, NULL, NULL, FALSE); > > > > return EXIT_SUCCESS; > > } > > > > > > Running this application on wine, I get to have my crash, with the > > possibility of an exploit. So all I have to do know is to find a vector > to > > make you and some other people willing to run my application. > > > > I won't describe in detail the way to perform the exploit as : > > 1 - I don't know how to proceed and I don't want to > > 2 - It would be showing poor sense of responsibilities > > If you can run an application ... it already can do everything! > > No need to protect APIs against misuse, they run at the same privilege > level as your code. > > Ciao, Marcus >

2 1

Re: [PATCH] kernel32: handle section=NULL in WritePrivateProfileStructW (Coverity)
by Nikolay Sivov Feb. 1, 2009

Feb. 1, 2009

Marcus Meissner wrote: > Hi, > > CID 69, section name NULL will just crash in the calls below and > without it we cannot work anyway. So return FALSE; > > Ciao, Marcus > --- > dlls/kernel32/profile.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/kernel32/profile.c b/dlls/kernel32/profile.c > index 3c5ef1c..5dddc23 100644 > --- a/dlls/kernel32/profile.c > +++ b/dlls/kernel32/profile.c > @@ -1799,6 +1799,8 @@ BOOL WINAPI WritePrivateProfileStructW (LPCWSTR section, LPCWSTR key, > > if (!section && !key && !buf) /* flush the cache */ > return WritePrivateProfileStringW( NULL, NULL, NULL, filename ); > + if (!section) > + return FALSE; > > /* allocate string buffer for hex chars + checksum hex char + '\0' */ > outstring = HeapAlloc( GetProcessHeap(), 0, (bufsize*2 + 2 + 1) * sizeof(WCHAR) ); > What about a test on this? Does native module crash or not?

1 0

Re: [PATCH] winspool.drv: Check return value of EnumPrintersA
by Detlef Riekenberg Feb. 1, 2009

Feb. 1, 2009

On Sa, 2009-01-31 at 11:09 +0100, Marcus Meissner wrote: > - EnumPrintersA(PRINTER_ENUM_LOCAL, NULL, 5, NULL, 0, &needed, > &num); > - if(needed) { > + if (EnumPrintersA(PRINTER_ENUM_LOCAL, NULL, 5, NULL, 0, &needed, > &num) && needed) { EnumPrinterA must always update "needed". "nedded" is 0, when EnumPrintersA failed or when no printer is installed. Line 1555 has similar code -- By by ... Detlef

2 1

A basic implementation for increased security in wine proposal
by Guillaume SH Feb. 1, 2009

Feb. 1, 2009

Hi project, Following the two previous threads, I am posting here a draft patch implementing my proposal. So, to begin with I will remind you the principle : All function callable from outside wine, should be added sanity checks : if safe_mode_on and (sanity_check1_failed or sanity_check2_failed [...] ) { ExitWineCleanlyAndAdvertiseUser; } safe_mode_on value being read from registry (one and only time at wine startup). So if safe_mode_on is set to true, sanity check are performed and in case of failure wine advertise user and terminate cleanly Else, sanity check aren't performed and on a bad input wine is crashing. I've only produced a basic implementation, clearly marking as TODO items left to be done (by the way they are too much for me to handle, as I am no match for you when it comes to implementation). My goal here is firstly to demonstrate feasibility (hardly reached) and usefulness of the proposal. Secondly it is to provide something concrete. Please note than "unsafe" mode behave exactly the same than latest git version of wine (some more operations occur, however, so is not strictly equal in term of performance) I tested the two modes with the help of wine test suite, restricted to kernel/file.c, test_overlapped and I considered only : all must-be-successful tests GetOverlappedResult(0, NULL, &result, FALSE); GetOverlappedResult(0, &ov, NULL, FALSE); (these last two cannot be used in the same run, in either mode) Results are as follow (test are wine_test calls wine on linux(1) platform only ) : 1 - all must-be-successful tests 100% succeed in the two modes 2 - in safe mode, the last two triggers the user message and wine exit 3 - in unsafe mode, the last two triggers a crash Consequently, based on theses results no regression is identified. As I received some more informations in last thread (thank you for enhancing my comprehension of the problem), I will again expose the problem, taking them into account : The problem I am considering (and I may be mistaken here as I am not an expert) is called "Unchecked Error Condition"(2) and it is a referenced weakness (CWE id 391), rated "Medium" in likelihood of exploit, by serious people. Personally, I don't mind that Microsoft is ignoring it and promote usage of early crash or whatever. You are providing a software, presenting security defects that you choose not to fix because they are compliant with your goals. Consequently, at the very least you should explicitly advertise your users, confronting them with their responsibilities. I have read(3) on winehq a warning stating that wine is beta software, not ready for general use. I have read too about the "bug for bug" compatibility. So user's advertisement about security is rather thin and implicit. Please consider the problem, you need to do something about it, it is your responsibility. And continue the good work, you rocks ! Guillaume (1) wine version : wine 1.1.14 with the attached patch applied on top of it OS : debian testing amd64 (2) http://cwe.mitre.org/data/definitions/391.html (3) http://www.winehq.org/about/ PS : I have observed that you are very active about fixing other security issues : + buffer overflow + NULL pointer dereference + variable signedness + ... I seems to me that hopefully, you performs those fixes without consideration for "Is windows doing the same ?". I will be sad the day I will see a commit "Remove resource release because Windows is doing the same" or "Remove buffer overflow fix because app A (2 million copies sold) rely on it".

4 7

Re: dinput: Move gain support from effect to device
by Vitaliy Margolen Feb. 1, 2009

Feb. 1, 2009

Vincent Pelletier wrote: > Hi. > > Windows supports setting force feedback effect gain at 2 levels: > - device > - effect > There is support for the former on Linux, but not for the latter. > > > + DWORD ff_gain; > }; ... > + This->ff_gain = max(0, (int) pd->dwData); First why do you typecase DWORD to (int) to assign to DWORD? Second DWORD will always be > 0. If you want to check it against limit then just check it being <= 10000 otherwise return error. > + if (This->joyfd != -1) { You should be checking This->base.acquired instead of fd. > + event.value = This->ff_gain * 0xFFFF / 10000; You should use MulDiv instead because this can be optimized out by compiler into something that won't be as accurate. Vitaliy.

2 1

Wine magazine articles?
by Dan Kegel Jan. 31, 2009

Jan. 31, 2009

Hey everyone, does Wine have a gallery of press clippings anywhere? I couldn't find one, so I started one at http://wiki.winehq.org/Reviews just for long-form reviews. If you remember any good reviews of Wine (1.0 or later especially), please link them in there. - Dan

1 0