February 2009 - Wine-Devel - list.winehq.org

EVE online losing its Linux Client
by Zachary Goldberg Feb. 9, 2009

Feb. 9, 2009

http://games.slashdot.org/article.pl?sid=09/02/08/206252&from=rss It seems that a game studio found that Wine worked so well that they have given up their efforts to maintain a native client. While encouraging that Wine works so well, there is a very interesting debate which could be had as to whether or not this kind of affect is desirable. -Zach

4 5

[Fwd: Re: [Wine] imagicos]
by James McKenzie Feb. 8, 2009

Feb. 8, 2009

Sent to wrong mailing list. Comment stands. Apple is almost as bad as Microsoft with trademark enforcement. James McKenzie -------- Original Message -------- Subject: Re: [Wine] imagicos Date: Sun, 08 Feb 2009 19:58:52 -0700 From: James McKenzie <jjmckenzie51(a)earthlink.net> To: IneedAname <wineappdb(a)googlemail.com> CC: Wine <wine-users(a)winehq.org> References: <COL113-W24AF1F36974642B52CBF95ABBE0(a)phx.gbl> <d7e40be30902061716r3c4270c3kc2566b41c6724d32(a)mail.gmail.com> <COL113-W31685C183F8C6E91FA9A38ABBE0(a)phx.gbl> <20090207032351.1a709d63(a)test-main> IneedAname wrote: > > This whole thing would be funny if it was not for: > > Read cost. > http://www.imagicos.com/why.html > > Rip off! > http://www.imagicos.com/get.html > > And possible trademark infringment (iMagic OS X) . This might turn out to be an interesting legal battle. I won't be 'buying' a copy anywhere. James McKenzie

1 0

New coverity run Feb 7, 14 new warnings
by Dan Kegel Feb. 8, 2009

Feb. 8, 2009

Congrats to everyone who's been cleaning up Coverity warnings, especially Marcus (http://marcusmeissner.livejournal.com/24466.html) Here are the yet-uninspected warnings that are in the Feb 7 run but not in the Jan 30 run: 884 REVERSE_INULL compile_file_regex dlls/dbghelp/symbol.c 883 RESOURCE_LEAK forward tools/winegcc/winegcc.c 882 RESOURCE_LEAK build tools/winegcc/winegcc.c 881 RESOURCE_LEAK build tools/winegcc/winegcc.c 880 RESOURCE_LEAK build tools/winegcc/winegcc.c 879 RESOURCE_LEAK compile tools/winegcc/winegcc.c 878 RESOURCE_LEAK compile tools/winegcc/winegcc.c 877 RESOURCE_LEAK compile tools/winegcc/winegcc.c 876 OVERRUN_STATIC DOSVM_outport dlls/winedos/ioports.c 875 NULL_RETURNS __wine_make_gdi_object_system dlls/gdi32/gdiobj.c 874 FORWARD_NULL merge_diff_row dlls/msi/database.c 873 FORWARD_NULL HTMLStyle_put_fontWeight dlls/mshtml/htmlstyle.c 872 FORWARD_NULL NTDLL__vsnprintf dlls/ntdll/printf.c 871 DEADCODE reg_delete programs/reg/reg.c If anyone wants access to the Coverity data, let me or one of the other coverity users know. - Dan

3 3

Question about redirection handles in wcmd
by Erich Hoover Feb. 8, 2009

Feb. 8, 2009

I tracked down an issue where an application was running into a sharing problem in WCMD_execute when it created redirects to the same file more than once. I originally hacked around this issue by changing the sharing mode for redirects, but I've now narrowed down the issue. I discovered that the file handle is not being closed when a command has completed and that this issue is caused by the "old handle" value being INVALID_HANDLE_VALUE: http://source.winehq.org/source/programs/cmd/wcmdmain.c#L1562 The "old handle" value is being set to this because of a call to GetStdHandle (you see, GetStdHandle(STD_OUTPUT_HANDLE) == INVALID_HANDLE_VALUE): http://source.winehq.org/source/programs/cmd/wcmdmain.c#L1399 So, my question is whether the call to GetStdHandle is important. If not then line 1399 can easily be simplified to: old_stdhandles[handle] = idx_stdhandles[handle]; Make this change resolves the sharing issue that I'm seeing, but if it is important to use GetStdHandle there then instead the "cleanup" code located near line 1562 needs to be more intelligent. Erich Hoover ehoover(a)mines.edu

1 1

New Wine Gecko package
by Jacek Caban Feb. 8, 2009

Feb. 8, 2009

Hi all, The last release of Wine Gecko caused a few regressions. Thanks to Alexandre, we've found the reason. The bad news is that the fix requires a new package. I've uploaded RC build to: http://gerwazy.lo3.wroc.pl/~jcaban/wine/wine_gecko-0.9.1.cab I'd appreciate if people that observe the regression (mostly strange crashed) could retest bugs with this build. To do so, you will need the new package and the attached patch. Also quick tests with random apps would be nice. This is a bugfix release based on the same codebase as 0.9.0 version so I don't expect any new regressions with it. Also the last debug version was accidentally stripped. It will be fixed in this release. I'm planning to do the release tomorrow, so it will be in Git on Friday. Thanks, Jacek >From 35f651d05f04dc80dd85451d48428d5c6174dac2 Mon Sep 17 00:00:00 2001 From: Jacek Caban <jacek(a)codeweavers.com> Date: Thu, 5 Feb 2009 00:17:09 +0100 Subject: [PATCH] mshtml: Wine Gecko 0.9.1 release. To: wine-patches <wine-patches(a)winehq.org> --- dlls/mshtml/htmldoc.c | 4 +++- dlls/mshtml/mshtml_private.h | 1 + dlls/mshtml/mutation.c | 15 +++++++++++++++ dlls/mshtml/nsembed.c | 4 +++- dlls/mshtml/nsiface.idl | 3 ++- 5 files changed, 24 insertions(+), 3 deletions(-) diff --git a/dlls/mshtml/htmldoc.c b/dlls/mshtml/htmldoc.c index 32da2e0..a6aa73f 100644 --- a/dlls/mshtml/htmldoc.c +++ b/dlls/mshtml/htmldoc.c @@ -214,8 +214,10 @@ static ULONG WINAPI HTMLDocument_Release(IHTMLDocument2 *iface) ConnectionPointContainer_Destroy(&This->cp_container); - if(This->nsdoc) + if(This->nsdoc) { + remove_mutation_observer(This->nscontainer, This->nsdoc); nsIDOMHTMLDocument_Release(This->nsdoc); + } if(This->nscontainer) NSContainer_Release(This->nscontainer); diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index e4c98a7..b67c485 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -510,6 +510,7 @@ void NSContainer_Release(NSContainer*); void init_mutation(NSContainer*); void set_mutation_observer(NSContainer*,nsIDOMHTMLDocument*); +void remove_mutation_observer(NSContainer*,nsIDOMHTMLDocument*); void HTMLDocument_LockContainer(HTMLDocument*,BOOL); void show_context_menu(HTMLDocument*,DWORD,POINT*,IDispatch*); diff --git a/dlls/mshtml/mutation.c b/dlls/mshtml/mutation.c index ea61d5a..ab9649c 100644 --- a/dlls/mshtml/mutation.c +++ b/dlls/mshtml/mutation.c @@ -55,6 +55,21 @@ void set_mutation_observer(NSContainer *nscontainer, nsIDOMHTMLDocument *nshtmld nsIDOMNSDocument_Release(nsdoc); } +void remove_mutation_observer(NSContainer *nscontainer, nsIDOMHTMLDocument *nshtmldoc) +{ + nsIDOMNSDocument *nsdoc; + nsresult nsres; + + nsres = nsIDOMHTMLDocument_QueryInterface(nshtmldoc, &IID_nsIDOMNSDocument, (void**)&nsdoc); + if(NS_FAILED(nsres)) { + ERR("Could not get nsIDOMNSDocument: %08x\n", nsres); + return; + } + + nsIDOMNSDocument_WineRemoveObserver(nsdoc, NSDOCOBS(nscontainer)); + nsIDOMNSDocument_Release(nsdoc); +} + #define IE_MAJOR_VERSION 7 #define IE_MINOR_VERSION 0 diff --git a/dlls/mshtml/nsembed.c b/dlls/mshtml/nsembed.c index ee386ac..16ac21e 100644 --- a/dlls/mshtml/nsembed.c +++ b/dlls/mshtml/nsembed.c @@ -857,8 +857,10 @@ void update_nsdocument(HTMLDocument *doc) return; } - if(doc->nsdoc) + if(doc->nsdoc) { + remove_mutation_observer(doc->nscontainer, doc->nsdoc); nsIDOMHTMLDocument_Release(doc->nsdoc); + } doc->nsdoc = nsdoc; diff --git a/dlls/mshtml/nsiface.idl b/dlls/mshtml/nsiface.idl index 219ac0c..ef64145 100644 --- a/dlls/mshtml/nsiface.idl +++ b/dlls/mshtml/nsiface.idl @@ -23,7 +23,7 @@ * compatible with XPCOM, usable in C code. */ -cpp_quote("#define GECKO_VERSION \"0.9.0\"") +cpp_quote("#define GECKO_VERSION \"0.9.1\"") cpp_quote("#define GECKO_VERSION_STRING \"Wine Gecko \" GECKO_VERSION") import "wtypes.idl"; @@ -873,6 +873,7 @@ interface nsIDOMNSDocument : nsISupports /* Wine extensions */ nsresult WineAddObserver(nsIDocumentObserver *aObserver); + nsresult WineRemoveObserver(nsIDocumentObserver *aObserver); nsresult WineAddScriptRunner(nsIRunnable *aRunnable); } -- 1.6.0.6

6 9

Re: mshtml/tests: skip tests if gecko is not available
by Jacek Caban Feb. 8, 2009

Feb. 8, 2009

Hi Austin, Austin English wrote: - hres = IHTMLDocument2_get_body(doc, &body); - ok(hres == S_OK, "get_body failed: %08x\n", hres); - if(body) { + hres = IHTMLDocument2_get_body(doc, &body); + ok(hres == S_OK, "get_body failed: %08x\n", hres); You check body before getting it, so it can't work and these tests would always be skipped. I've sent a correct version. Jacek

1 0

LookupIconIdFromDirectory16() is unused
by Francois Gouget Feb. 8, 2009

Feb. 8, 2009

dlls/user32/cursoricon.c defines a LookupIconIdFromDirectory16() function which is not used anywhere. What is strange is thar user.exe.spec exports a LookupIconIdFromDirectoryEx() function. So shouldn't it export a LookupIconIdFromDirectory() function too? In which case I suspect that LookupIconIdFromDirectory16() would be its implementation... Unfortunately I have no information about what 16bit dlls are supposed to export... -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Any sufficiently advanced bug is indistinguishable from a feature. -- from some indian guy

4 4

tests with new DIB [2]
by Evgeny Burzak Feb. 8, 2009

Feb. 8, 2009

Hello, my plays with programs here: * Flash 8 has some missing icons, fonts and i-face glitches. Also it crached when i try to paste big text piece. * Flash CS 3 seems the same, but i haven`t chance to deep in, cause it says that my license expired =) Note that both 8 & CS has big speed up when turned on full anti-aliasing. * IE6 has some broken icons and problems with fonts: strings looks like lines in one px sometimes. * Firefox 3 works veeeery slowly and has errors in pages layout as well as IE. -- Evgeny Burzak <buzzilo(a)gmael.сом>

1 0

Bugzilla default assignment for secur32
by Kai Blin Feb. 8, 2009

Feb. 8, 2009

Hi folks, since SSL support sort of works, we're getting a large amount of SSL-related bugs. As I don't deal with the SSL-implementation at all, could some Bugzilla admin remove me as defauly assignee for secur32 bugs again? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 1

Re: Support for Dragon NS in Wine
by Susan Cragin Feb. 7, 2009

Feb. 7, 2009

3 2