April 2009 - Wine-Devel - list.winehq.org

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Wine runs IE7!
by Hans Leidekker Nov. 26, 2010

Nov. 26, 2010

Well, sort of. I found bugs in shell32, rpcrt4, comctl32 and wininet that I had to implement, stub and override my way past before it would render a page, but finally, here's the obligatory screenshot. -Hans

3 2

meaning of "Hardware" field in bugzilla?
by Dan Kegel Dec. 13, 2009

Dec. 13, 2009

Does "mac" mean "powerpc mac only"? I rather thought it meant "apple macintosh", regardless of cpu. I ask because Austin has just gone through and changed lots of "mac" bugs to "pc" even though the bugs were on Intel macs, which just seems wrong.

8 8

search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?
by Dan Kegel Oct. 18, 2009

Oct. 18, 2009

See http://bugs.winehq.org/show_bug.cgi?id=14980 Essentially, to run Office 2007, you have to set an override for riched20. Since Office installs a new, spiffier version of riched20 in its own private directory, and expects to find it there, isn't it a bug that we don't let it have it? Sounds like it's time to write a conformance test... sure would be nice if that override wasn't needed.

9 26

re: Wine t-shirts?
by Dan Kegel Sept. 3, 2009

Sept. 3, 2009

Maarten wrote: > Why don't we have wine t-shirts any more? I dunno, where were they before? I just looked, couldn't find any on cafepress.com. I'd like to bring back the Codeweavers drunken penguin t-shirts, perhaps with a slightly more generic Wine design. Coincidentally, I found some site on the net had taken the logo from that shirt and erased the Crossover logo from the wine bottle; here's a cleaned-up copy: http://kegel.com/wine/wine-penguin-corkscrew.png

15 34

DxDiag Demo Patch
by Allen Hair Aug. 15, 2009

Aug. 15, 2009

Hello Wine Developers, Over the last couple of months I have been part of a team of students at UCLA who have been developing an implementation of the DxDiag application to release with Wine. After a long quarter, we have produced a working implementation. Some of the features are still missing but most of the functionality has been completed. I hope that our work proves useful to the Wine project. Attached is a patch that will add our code to the source tree. This patch is not meant to be committed, but should provide a demonstration of the application so far. Any feedback would be appreciated, I will try to incorporate any suggestions as I work on releasing incremental patches over the next few weeks. - Allen Hair

6 7

winequartz.drv Mac OS X UI discontinued?
by Adam Strzelecki July 11, 2009

July 11, 2009

Hi, I know that CodeWeavers supports quite nicely Mac builds of Wine, and CrossOver for Mac, yet all of them are X11. There was also once Darwine - an effort to provide Carbon Wine UI driver and Mac optimizations & L&F. Pretty many of those were merged back to Wine, but not winequartz.drv. Do you guys think about reviving winequartz.drv? This would greatly improve Wine on Mac as we could have native Mac fonts handling that's faster than FreeType, Dock icons for Wine applications, and few others. There's still old copy of the it hanging around, but it is abandoned, and no longer compiles with Wine. Or I think it would be cool to write new winecocoa.drv or sthing like that, as Apple officially states that Carbon is deprecated. While it is not well documented, it is pretty easy with Cocoa to make console non-bundled process to be UI foreground process and handle events and Dock: (This code is copyrighted by myself ;P) > int main(int argc, const char * argv[]) { > ProcessSerialNumber psn = {0, kCurrentProcess}; > OSStatus returnCode = TransformProcessType(&psn, > kProcessTransformToForegroundApplication); > SetFrontProcess(&psn); > > NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init]; > [NSApplication sharedApplication]; > > NSImage *icon = [NSImage imageNamed:@"NSApplicationIcon"]; > [NSApp setApplicationIconImage:icon]; > > [NSApp finishLaunching]; > > NSWindow *window = [[NSWindow alloc] > initWithContentRect:NSMakeRect(0, 0, 100, 100) > styleMask:NSTitledWindowMask| > NSClosableWindowMask|NSMiniaturizableWindowMask|NSResizableWindowMask > backing:NSBackingStoreBuffered defer:NO]; > [window center]; > [window setTitle:@"Test"]; > > NSButton *button = [[NSButton alloc] > initWithFrame:NSMakeRect(10, 10, 80, 80)]; > [button setTitle:@"What?"]; > [button setBezelStyle:1]; > [[window contentView] addSubview:button]; > [button release]; > > [window makeKeyAndOrderFront:NSApp]; > > while(1) { > NSEvent *event = [NSApp > nextEventMatchingMask:NSAnyEventMask > untilDate > :[NSDate distantFuture] > inMode:NSDefaultRunLoopMode > dequeue:YES > ]; > if(event) [NSApp sendEvent:event]; > } > [pool release]; > return 0; > } BTW. I heard that someone previously working for Wine project is now in Apple, it is true? Regards, -- Adam Strzelecki |: nanoant.com :|

20 55

Wine translation statistics sources
by Mikołaj Zalewski June 22, 2009

June 22, 2009

Hi, I didn't update the translation statistics (http://www.mikolaj.zalewski.pl/wine-transl/) very regularly lately - my server is a bit broken and I can't run the scripts from cron but have remember to do it manually from a different computer. I have plans to fix it, but in the mean time, as some people may want fresh data, I have finished the changes I've been working on and uploaded the sources. It should be very easy to run them on ones machine and check the tree one has on disk - there is a README with explanations. The archive is available at http://www.mikolaj.zalewski.pl/dl/wine-transl.tgz . It is the latest version that adds support for dumping/diffing dialogs. Mikolaj Zalewski

8 17

XI2 DirectInput mouse implementation RFC (Tarballed)
by Paul TBBle Hampson June 2, 2009

June 2, 2009

(Resend, the first email never arrived. I didn't realise one of my patches was 33k >_<) I've thrown together a rather-rough-but-working-in-a-limited-sense implementation of XInput2-based DirectInput. It's got a fair few problems, I'm mainly interested in feedback on the approach, although obviously any code or style criticisms are welcome. Current limitations: * Doesn't check for XInput2.h, so it won't build without it. (Laziness) It will _run_ without XInput2, falling back to the current dinput WndProc hooks even if compiled with XInput2 support. * Doesn't send button-ups; XI2 can't distinguish button up from down * Doesn't send events after button-down until after button-up on a window. I'm pretty sure this is an XI2 bug, but it might be a design feature. * Doesn't support exclusive mode. XI2 bug (grabs not yet implemented) Hopefully this can be implemented entirely within the dinput code in winex11drv (ie disabling and hiding the mouse on acquire. dinput already takes care of unacquiring when we are no longer the foreground app) * Mouse buttons aren't remapped nicely downwards. Need to look harder at this, my mouse reports buttons 1, 2, 3, 4, 5, 8, 9, 10, 11 and 12 under X. 4 and 5 are scroll, 6 and 7 might be horizontal scroll in which case if this is always the case we can just remap downwards. Might need to implement device querying to confirm mouse button mapping... * Only supports the Mouse. Adding keyboard support should be really trivial compared to actually getting the framework right. * Doesn't detect capabilities... A mouse with a horizontal scroll wheel'd have four axes. I haven't looked to see if DirectInput can support that, or if our dinput code can easily accomodate more axes or buttons than the current 3/8 setup. This the point we'd need another callthrough from gdimouse to the graphics driver. * Assumes a process will only try and acquire the mouse once. I'm not sure that this is a bad assumption, and it might be that dinput makes this a valid assumption for us. * Assumes no one else wants GenericEvents. Some day we'll need a GenericEvent handler system inside WineX11, particularly if wintab gets converted to XInput 2 support. Easy enough to do now if wanted. * gdimouse uses Wine Mouse GUID value. I'm not sure where these come from, if anywhere. Trivial to fix before submission. If this format is fine, then the first patch is basically ready to go, the latter two patches may need to be re-split or merged more sensibly. In the libs folder I've also attached a couple of fixes for the XI2 stuff if anyone wants to try it. One only affects 64-bit builds, and one fixes XCB locking assertions which you could probably otherwise ignore. So they're both kinda optional in the Wine context. Also one more patch, against the xinput utility from whot's git tree, to fix a compile failure in the XI2 test functionality. -- Paul "TBBle" Hampson, Paul.Hampson(a)Pobox.com Shorter .sig for a more eco-friendly paperless office.

4 13

Need help writing test
by Igor Tarasov May 20, 2009

May 20, 2009

Hi! I've found few visual glitches in comctl32/toolbar, and now try to write this all down as conformance tests, but I have some problems. I see that there is bug, when I test it with control spy. But when I repeat it in testcase, it won't work. Here is how you can reproduce it: TB_SETBITMAPSIZE 20,20 TB_SETBUTTONSIZE 30,30 TB_SETBITMAPSIZE 10,10 Now, if you do TB_SETBUTTONSIZE, you'll see the difference. builtin comctl will return 17,16. Native - 30,16. But when I write something like this: rebuild_toolbar_with_buttons(&hToolbar); himl = ImageList_LoadImage(GetModuleHandle(NULL), MAKEINTRESOURCE(IDB_BITMAP_80x15), 20, 2, CLR_NONE, IMAGE_BITMAP, LR_DEFAULTCOLOR); ok(SendMessageA(hToolbar, TB_SETIMAGELIST, 0, (LRESULT)himl) == 0, "TB_SETIMAGELIST failed\n"); SendMessageA(hToolbar, TB_SETBITMAPSIZE, 0, MAKELONG(20, 20)); SendMessageA(hToolbar, TB_SETBUTTONSIZE, 0, MAKELONG(30, 30)); ok(SendMessageA(hToolbar, TB_GETBUTTONSIZE, 0, 0) == MAKELONG(30, 30), "Unexpected button size\n"); SendMessageA(hToolbar, TB_SETBITMAPSIZE, 0, MAKELONG(10, 10)); compare((int)SendMessageA(hToolbar, TB_GETBUTTONSIZE, 0, 0), MAKELONG(30, 16), "%x"); This test fails, when I test it with native comctl32 (the size is 17,16). Why could this happen or what am I doing wrong? -- Igor

2 2

Office 2007 MSI Crash - Null dereference @ MsiViewExecute
by Mike Kaplinskiy May 4, 2009

May 4, 2009

I was looking at the trace of the crash from bug 17600, and it looks like a custom action is calling MsiViewExecute with a null hRec. I (sadly) don't know much about the wine MSI architecture, but the msiobj_lock on line 484 should fail since rec will never be fetched (null). I think the intention was to make it query->hdr (as it is released later). Sorry if I'm dead wrong - just my 2c

3 5

Re: IE and MSN Messenger 7.0
by Ben Klein May 3, 2009

May 3, 2009

2009/5/1 Cissyvonwinckelmann <cissyvonwinckelmann(a)planet.nl>: > hartelijk dank Benm ja ik moet snel een andere pc hebben, want dit is een > hele ouwe dan krijg je de moeilijkheden, > groetjes cissy > I have to use Google Language Tools to translate your text, so I apologise if I misunderstand you. The "old problems" with Messenger (you actually didn't say which Messenger it is, Yahoo or MSN?) in Wine are not likely to go away without a lot of work. As this is the developers' mailing list, we would welcome patches/modifications to Wine to make it work better. Without a discussion on the development side, your questions are better directed to wine-users mailing list or the forum, or some other user-oriented support path. Regardless, it is strongly recommended that you look into using a native client (i.e. something you don't need Wine to run) such as Pidgin.

2 2

Dib Engine: some update
by Massimo Del Fedele May 1, 2009

May 1, 2009

I put on bug's 421 page an update of my dib engine. It implements AlphaBlend, StretchBlt and has many color fixes. If you want to try it, just follow instructions on above page. Ciao Max

3 5

Wine + Mono + application = library not found?
by Seth Shelnutt May 1, 2009

May 1, 2009

Hello all, I'm trying to see if I can get a folding monitor, http://code.google.com/p/hfm-net/ working in Wine. I've installed the latest wine, 1.1.20, and the latest mono for windows 2.4. It seems however that either mono or Wine, I think wine, is not seeing the library file from gtk. However it is in my lib folder. Does anyone have any idea where wine is looking for the lib to be at? This is on a Debian "testing" (Squeeze I guess, but I keep my repos under the "testing" and no name, I use the wine "sid" repo) install. shelnutt(a)K-Server:~/Downloads/HFM Release 0.1.1.10$ wine HFM.exe Unhandled Exception: System.TypeInitializationException: An exception was thrown by the type initializer for System.Windows.Forms.MimeIconEngine ---> System.DllNotFoundException: libgdk-x11-2.0.so.0 at (wrapper managed-to-native) System.Windows.Forms.GnomeUtil:gdk_init_check (intptr,intptr) at System.Windows.Forms.GnomeUtil.Init () [0x00000] at System.Windows.Forms.GnomeUtil.GetIcon (System.String icon, Int32 size) [0x00000] at System.Windows.Forms.GnomeHandler.AddGnomeIcon (System.String internal_mime_type, System.String name) [0x00000] at System.Windows.Forms.GnomeHandler.CreateUIIcons () [0x00000] at System.Windows.Forms.GnomeHandler.Start () [0x00000] at System.Windows.Forms.MimeIconEngine..cctor () [0x00000] --- End of inner exception stack trace --- at System.Windows.Forms.WinFileSystem..ctor () [0x00000] at System.Windows.Forms.MWFVFS..ctor () [0x00000] at System.Windows.Forms.FileDialog..ctor () [0x00000] at System.Windows.Forms.OpenFileDialog..ctor () [0x00000] at (wrapper remoting-invoke-with-check) System.Windows.Forms.OpenFileDialog:.ctor () at HFM.Forms.frmMain.InitializeComponent () [0x00000] at HFM.Forms.frmMain..ctor () [0x00000] at (wrapper remoting-invoke-with-check) HFM.Forms.frmMain:.ctor () at HFM.Program.Main (System.String[] argv) [0x00000] shelnutt(a)K-Server:~/Downloads/HFM Release 0.1.1.10$ locate libgdk-x11-2.0.so.0 /home/shelnutt/opt/gps/lib/libgdk-x11-2.0.so.0 /usr/lib/libgdk-x11-2.0.so.0 /usr/lib/libgdk-x11-2.0.so.0.1600.1 Thanks, Seth Shelnutt

2 1

IE and MSN Messenger 7.0
by Cissyvonwinckelmann May 1, 2009

May 1, 2009

dag, bestaat er voor mij nog een mogelijkheid om messenger 7.0 te downloaden. Heb dus nog Windows Me, heel graag antwoord, groet cissy cissyvonwinckelmann(a)planet.nl

3 2

Re: Wine + Mono + application = library not found?
by Hin-Tak Leung April 30, 2009

April 30, 2009

I use wine + win32 mono quite regularly (my .net app does some gdi some p/invoke stuff). Wine or mono takes extra dll's from $PATH, and also from the application's directory. The windows version of the gtk library is actually in .wine/drive_c/Program\ Files/Mono-2.4/bin/ . The way I would run your application would be: cd .wine/drive_c/Program\ Files/Mono-2.4/bin/ \ && wine ./mono.exe H:/Downloads/HFM Release 0.1.1.10/HFM.exe (note the "H:" for home dir under windows). There are probably other ways of doing it, but I think mine is guaranteed to work. --- On Fri, 1/5/09, Seth Shelnutt <shelnutt2(a)gmail.com> wrote: > Hello all, > > I'm trying to see if I can get a folding monitor, http://code.google.com/p/hfm-net/ > working in Wine. I've installed the latest wine, 1.1.20, > and the latest mono for windows 2.4. It seems however that > either mono or Wine, I think wine, is not seeing the library > file from gtk. However it is in my lib folder. Does anyone > have any idea where wine is looking for the lib to be at? > This is on a Debian "testing" (Squeeze I guess, > but I keep my repos under the "testing" and no > name, I use the wine "sid" repo) install. > > > > > shelnutt(a)K-Server:~/Downloads/HFM Release 0.1.1.10$ wine > HFM.exe > > Unhandled Exception: System.TypeInitializationException: An > exception was thrown by the type initializer for > System.Windows.Forms.MimeIconEngine ---> > System.DllNotFoundException: libgdk-x11-2.0.so.0 > > > at (wrapper managed-to-native) > System.Windows.Forms.GnomeUtil:gdk_init_check > (intptr,intptr) > at System.Windows.Forms.GnomeUtil.Init () [0x00000] > at System.Windows.Forms.GnomeUtil.GetIcon (System.String > icon, Int32 size) [0x00000] > > > at System.Windows.Forms.GnomeHandler.AddGnomeIcon > (System.String internal_mime_type, System.String name) > [0x00000] > at System.Windows.Forms.GnomeHandler.CreateUIIcons () > [0x00000] > at System.Windows.Forms.GnomeHandler.Start () [0x00000] > > > > at System.Windows.Forms.MimeIconEngine..cctor () > [0x00000] > --- End of inner exception stack trace --- > at System.Windows.Forms.WinFileSystem..ctor () [0x00000] > > at System.Windows.Forms.MWFVFS..ctor () [0x00000] > > > at System.Windows.Forms.FileDialog..ctor () [0x00000] > at System.Windows.Forms.OpenFileDialog..ctor () > [0x00000] > at (wrapper remoting-invoke-with-check) > System.Windows.Forms.OpenFileDialog:.ctor () > at HFM.Forms.frmMain.InitializeComponent () [0x00000] > > > at HFM.Forms.frmMain..ctor () [0x00000] > at (wrapper remoting-invoke-with-check) > HFM.Forms.frmMain:.ctor () > at HFM.Program.Main (System.String[] argv) [0x00000] > > shelnutt(a)K-Server:~/Downloads/HFM Release 0.1.1.10$ locate > libgdk-x11-2.0.so.0 > > > /home/shelnutt/opt/gps/lib/libgdk-x11-2.0.so.0 > /usr/lib/libgdk-x11-2.0.so.0 > /usr/lib/libgdk-x11-2.0.so.0.1600.1 > > > Thanks, > > Seth Shelnutt > > > > -----Inline Attachment Follows----- > > >

1 0

New Icons are very good, but not yet perfect
by Joel Holdsworth April 30, 2009

April 30, 2009

Hi All, Great stuff with the new Tango icons for Wine - they're a definite improvement. One observation: it looks like the icons that I have installed do not have versions that have been tuned for small size: 16x16 and especially 22x22. If I understand correctly, the scaled icons were drawn for 48x48, which means that when the icon is drawn at size 22x22 in my gnome menu, there will be line width of 0.46px which looks too faint next to the other icons which have been tuned for small sizes, and have 1px lines. Does anyone know anything about this? Thanks Joel Holdsworth

3 2

Re: [PATCH] This patch fixes context menu crashes for edit controls asapparent in vb apps.
by Dmitry Timoshkov April 30, 2009

April 30, 2009

And what is the reason of the crash? Please add a test case replicating the problem first. -- Dmitry.

1 0

Re: Added Polish translation
by Jeremy Newman April 30, 2009

April 30, 2009

Your templates include html,head,meta, and body tags. Please strip them out and resubmit the patch. Otherwise everything looks good. -Newman Łukasz Wojniłowicz wrote: > From: Łukasz Wojniłowicz <Wojnilowicz(a)nslw.hstl.put.poznan.pl> > > --- > include/data.php | 4 + > templates/pl/.cvsignore | 2 + > templates/pl/announce.template | 19 +++ > templates/pl/download.template | 280 ++++++++++++++++++++++++++++++++++++ > templates/pl/download/deb.template | 127 ++++++++++++++++ > templates/pl/home.template | 70 +++++++++ > templates/pl/interview.template | 18 +++ > templates/pl/irc.template | 27 ++++ > templates/pl/lang.template | 36 +++++ > templates/pl/news.template | 21 +++ > templates/pl/search.template | 40 +++++ > 11 files changed, 644 insertions(+), 0 deletions(-) > create mode 100644 templates/pl/.cvsignore > create mode 100644 templates/pl/announce.template > create mode 100644 templates/pl/download.template > create mode 100644 templates/pl/download/deb.template > create mode 100644 templates/pl/home.template > create mode 100644 templates/pl/interview.template > create mode 100644 templates/pl/irc.template > create mode 100644 templates/pl/lang.template > create mode 100644 templates/pl/news.template > create mode 100644 templates/pl/search.template >

1 0

re: This patch fixes context menu crashes for edit controls as apparent in vb apps.
by Dan Kegel April 30, 2009

April 30, 2009

Hi Martin, thanks for the patch. Two suggestions: 1) if possible, please write a conformance test. 2) It appears you're a ReactOS developer, so you should expect some turbulence. You may have to go the "file a really good bug" route if Wine can't accept your patches. - Dan

2 1

Re: Disabling File attachments on Wiki
by Dmitry Timoshkov April 30, 2009

April 30, 2009

[please don't forget to cc: wine-devel] "Jeff Latimer" <lats(a)yless4u.com.au> wrote: >>> It would be also helpful to to get all wiki user account list (check it >>> time from time for suspicious names) and have an ability to delete >>> accounts >>> of known spammers for Wiki admins. Is it possible? >> Another thing that would probably help to get rid of spammers' accounts >> is to (regularly) delete all user accounts without a personal page. > It would also get rid of anyone who did not want to create a home page. Then it's time to do that, with a short description what your intentions/ activity is in the Wine project. > I just created one /just in case/ but really don't want to. What's the point in having a Wiki account then? -- Dmitry.

9 28

Re: Sound problems with latest kernel -- formerly a pulseaudio thread but not any more
by Susan Cragin April 30, 2009

April 30, 2009

>>>>> I have tested the following and I believe found they were not the problem: >>>>--snip-- >>>>> (3) problem with pulseaudio >>>> >>>>How did you determine this? I thought you said your version of Ubuntu >>>>was crippled if pulseaudio was removed, so did you use pasuspender? If >>>>so, did you verify there was no pulseaudio process running while you >>>>were testing Wine? >>> >>> After I started my testing, I did run into problems when I tried to re-install pulseaudio and then remove it, but the PA problem was unrelated. Ubuntu said there was a PA bug, and issued a fix. After I applied the fix, no more problems working with pulseaudio removed. So the whole thing was sort of a red herring. >>> >>> I have re-installed my entire system since that problem went away, and immediately purged pulseaudio, and that's where I'm working from now. Still same problem. >> >>OK, thanks for that clarification. >> >>So you've tracked the problem down to kernel version 2.6.29? What >>version of ALSA drivers are in your working and broken kernels? > >I've actually tracked it to before that. > >Wine's audio last worked with one of Ubuntu's generic kernels, probably 2.6.28-10. >Ubuntu's current repository kernel is 2.6.28-11. That's the one I that caused the problem. >The experimental bug-fix kernel is 2.6.28-12. That does not solve my problem. >(Here's where I got the kernel: http://kernel.ubuntu.com/~dtchen/test-kernels/ ) > >When my kernel worked, my drivers were 0.1.19 -- one of Tashaki Iwai's daily stable builds from a couple of weeks ago. >They are 0.1.19 now, today's daily stable build, compiled against 2.6.29-1-rt8-custom, which is what I am running at the moment. > >My 29-rt kernel is showing the same problems as the two kernels mentioned above. >FWIW, the person who compiled the RT kernel said that he did so without applying the Ubuntu patches. So that tells me that the change took place outside the Ubuntu patches. Well, this may be a pulseaudio problem after all. It may not be a wine problem. For the first time this morning, I tried running audacity -- the linux version. (My system has pulseaudio purged.) Audacity behaves the same way under Linux it does under wine, freezing when I stop and re-start the record function. I filed ubuntu bug 369762.

1 0

Re: Ubuntu no longer works correctly without pulseaudio
by Susan Cragin April 30, 2009

April 30, 2009

>wineoss is not a viable solution to the pulseaudio problem, but this >is a real nasty issue where the solution is "as long as it works for >you, it's fine". > >What exactly is the issue with purging pulseaudio? Though this should >be taken up with ubuntu's bugs tracker. pulseaudio should be >considered optional, since ALSA/dmix works wherever pulseaudio with >ALSA backend works, even if it is opt-out. Ben, sorry... You probably haven't been following this thread closely. I determined a couple of days ago that pulseaudio was not actually my problem even though I thought it was. I just kept the name of the thread. One of wine's developers asked me if linux's (or Ubuntu's) alsa-wrappers could have changed, and if wine's alsa-wrappers could therefore need updating. The fact that something works under winecfg OSS (but not under winecfg ALSA) is a valuable piece of diagnostic information. My value to this group is usually as a canary in the mine. Because I have the latest kernel, and the latest updates, I am able to spot problems before they hit the mainstream. And remember, this is a developers' group, not a users group. Experimentation is grist for the mill. Susan

4 4

Patch
by Anthony Keith April 30, 2009

April 30, 2009

http://bugs.winehq.org/show_bug.cgi?id=17237 Is there a patch for this in Ubuntu and if so where do I get it and how do I patch. I am new to Ubuntu and my wife loves big fish games. Thanks Tony __________________________________________________________________ Looking for the perfect gift? Give the gift of Flickr! http://www.flickr.com/gift/

2 1

Something wrong with those ?
by Massimo Del Fedele April 30, 2009

April 30, 2009

http://www.winehq.org/pipermail/wine-patches/2009-April/072442.html http://www.winehq.org/pipermail/wine-patches/2009-April/072452.html Ciao Max

2 1

Fw: Re: Sound problems with latest kernel -- formerly a pulseaudio thread but not any more
by Susan Cragin April 29, 2009

April 29, 2009

Whoops. This should have gone to the list. >Susan Cragin wrote: >>>>>> I have tested the following and I believe found they were not the problem: >>>>> --snip-- >>>>>> (3) problem with pulseaudio >>>>> How did you determine this? I thought you said your version of Ubuntu >>>>> was crippled if pulseaudio was removed, so did you use pasuspender? If >>>>> so, did you verify there was no pulseaudio process running while you >>>>> were testing Wine? >>>> After I started my testing, I did run into problems when I tried to re-install pulseaudio and then remove it, but the PA problem was unrelated. Ubuntu said there was a PA bug, and issued a fix. After I applied the fix, no more problems working with pulseaudio removed. So the whole thing was sort of a red herring. >>>> >>>> I have re-installed my entire system since that problem went away, and immediately purged pulseaudio, and that's where I'm working from now. Still same problem. >>> OK, thanks for that clarification. >>> >>> So you've tracked the problem down to kernel version 2.6.29? What >>> version of ALSA drivers are in your working and broken kernels? >> >> I've actually tracked it to before that. >> >> Wine's audio last worked with one of Ubuntu's generic kernels, probably 2.6.28-10. >> Ubuntu's current repository kernel is 2.6.28-11. That's the one I that caused the problem. >> The experimental bug-fix kernel is 2.6.28-12. That does not solve my problem. >> (Here's where I got the kernel: http://kernel.ubuntu.com/~dtchen/test-kernels/ ) >> >> When my kernel worked, my drivers were 0.1.19 -- one of Tashaki Iwai's daily stable builds from a couple of weeks ago. >> They are 0.1.19 now, today's daily stable build, compiled against 2.6.29-1-rt8-custom, which is what I am running at the moment. >> >> My 29-rt kernel is showing the same problems as the two kernels mentioned above. >> FWIW, the person who compiled the RT kernel said that he did so without applying the Ubuntu patches. So that tells me that the change took place outside the Ubuntu patches. >> >> > >I've had a few users report crashing in steam games as a result of >pulseaudio: https://bugs.launchpad.net/bugs/367379 -- do you think this >is all related? > >Thanks, >Scott Ritchie Maybe. From the bug, it's hard to tell. But here's what I think. I think that the kernel made changes recently that changed how sound relates to the kernel, and tied pulseaudio closer to the kernel (hence those error messages I got under 2.6.28-11, which kernel was acknowledged to be buggy the day it came out). Some of the bugs they either backed out or corrected with 2.6.28-12. It would be interesting to see if they can get steam running with that kernel. If you are working with the steam-bug people ask them to add the below kernel, purge pulseaudio, and test with alsa only. http://kernel.ubuntu.com/~dtchen/test-kernels/ Of course, they need headers, image & restricted modules. Susan

1 0

Re: Sound problems with latest kernel -- formerly a pulseaudio thread but not any more
by Susan Cragin April 29, 2009

April 29, 2009

>>>> I have tested the following and I believe found they were not the problem: >>>--snip-- >>>> (3) problem with pulseaudio >>> >>>How did you determine this? I thought you said your version of Ubuntu >>>was crippled if pulseaudio was removed, so did you use pasuspender? If >>>so, did you verify there was no pulseaudio process running while you >>>were testing Wine? >> >> After I started my testing, I did run into problems when I tried to re-install pulseaudio and then remove it, but the PA problem was unrelated. Ubuntu said there was a PA bug, and issued a fix. After I applied the fix, no more problems working with pulseaudio removed. So the whole thing was sort of a red herring. >> >> I have re-installed my entire system since that problem went away, and immediately purged pulseaudio, and that's where I'm working from now. Still same problem. > >OK, thanks for that clarification. > >So you've tracked the problem down to kernel version 2.6.29? What >version of ALSA drivers are in your working and broken kernels? I've actually tracked it to before that. Wine's audio last worked with one of Ubuntu's generic kernels, probably 2.6.28-10. Ubuntu's current repository kernel is 2.6.28-11. That's the one I that caused the problem. The experimental bug-fix kernel is 2.6.28-12. That does not solve my problem. (Here's where I got the kernel: http://kernel.ubuntu.com/~dtchen/test-kernels/ ) When my kernel worked, my drivers were 0.1.19 -- one of Tashaki Iwai's daily stable builds from a couple of weeks ago. They are 0.1.19 now, today's daily stable build, compiled against 2.6.29-1-rt8-custom, which is what I am running at the moment. My 29-rt kernel is showing the same problems as the two kernels mentioned above. FWIW, the person who compiled the RT kernel said that he did so without applying the Ubuntu patches. So that tells me that the change took place outside the Ubuntu patches.

2 1

Re: kernel32: Send exception information to winedbg for display in the crash dialog
by Alexandre Julliard April 29, 2009

April 29, 2009

Paul Chitescu <paulc(a)voip.null.ro> writes: > Changelog: > kernel32: Send exception information to winedbg for display in the crash > dialog That info (and more) can be determined by the debugger itself, there's no need to pass it from kernel32. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: try5 [1/4](resend) kernel32/tests: Add tests for GetVolumeInformationA and QueryDosDevice
by Paul Vriens April 29, 2009

April 29, 2009

Guy Albertelli wrote: > Fixed memory leak and changed skip to win_skip in this patch. > Add todo_wine as necessary so all tests pass. > > Changelog: > - Enhance QueryDosDevice test for attempting to return all devices. > - Add tests for GetVolumeInformationA testing the different root dir formats. > --- > dlls/kernel32/tests/volume.c | 138 ++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 134 insertions(+), 4 deletions(-) > > > > ------------------------------------------------------------------------ > > One of the tests fails on all W2K, XP and W2K3 boxes (no Vista results yet): http://test.winehq.org/data/tests/kernel32:volume.html Could you have a look? There is also a lot of trace/debugging information coming from these new tests. Is this needed? -- Cheers, Paul.

2 3

Re: winedbg: Accept a 3rd parameter to --auto to be used as extra info in the crash dialog
by Eric Pouech April 29, 2009

April 29, 2009

Paul Chitescu a écrit : > Changelog: > winedbg: Accept a 3rd parameter to --auto to be used as extra info in the > crash dialog > > Next patch will actually send this info to the debugger from kernel32. > > ------------------------------------------------------------------------ > > this is not necessary to pass the information to winedbg, everything's needed is accessible from winedbg see tgt_active.c / dbg_handle_exception A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

GL_APPLE_FENCE shares the same token in dlls/wined3d_gl.h with GL_FENCE_STATUS_NV.
by ace102 April 29, 2009

April 29, 2009

Hi, I noticed GL_APPLE_FENCE shares the same token in dlls/wined3d_gl.h with GL_FENCE_STATUS_NV. GL_FENCE_STATUS_NV http://www.opengl.org/registry/specs/NV/fence.txt Currently 0x84F3 GL_APPLE_FENCE http://www.opengl.org/registry/specs/APPLE/fence.txt Currently 0x84F3 Should be 0x8A0B from documentation. Is this by design or just something that slipped through the cracks? Thought I should alert someone just in case.:) Thanks. ----- Error:Success -- View this message in context: http://www.nabble.com/GL_APPLE_FENCE-shares-the-same-token-in-dlls-wined3d_… Sent from the Wine - Devel mailing list archive at Nabble.com.

4 3

Re: Sound problems with latest kernel -- formerly a pulseaudio thread but not any more
by Susan Cragin April 29, 2009

April 29, 2009

>2009/4/29 Susan Cragin <susancragin(a)earthlink.net>: >> I have tested the following and I believe found they were not the problem: >--snip-- >> (3) problem with pulseaudio > >How did you determine this? I thought you said your version of Ubuntu >was crippled if pulseaudio was removed, so did you use pasuspender? If >so, did you verify there was no pulseaudio process running while you >were testing Wine? After I started my testing, I did run into problems when I tried to re-install pulseaudio and then remove it, but the PA problem was unrelated. Ubuntu said there was a PA bug, and issued a fix. After I applied the fix, no more problems working with pulseaudio removed. So the whole thing was sort of a red herring. I have re-installed my entire system since that problem went away, and immediately purged pulseaudio, and that's where I'm working from now. Still same problem. Susan

2 1

Sound problems with latest kernel -- formerly a pulseaudio thread but not any more
by Susan Cragin April 29, 2009

April 29, 2009

I'm changing the name of the thread. Pulseaudio has nothing to do with my current problem. I thought it did back when I started the thread, but my testing turned out to be incomplete. I still don't know what the problem is, but I believe it has to do with the way wine relates to the current Ubuntu configuration. Using the most current kernel, the most current updates (and using tomorrow's kernels and updates) dmix and dsnoop I believe are not recognized properly by wine because I'm not getting any sound through them. And I did file a bug, but I filed it back when I still thought it was a wine regression, so it's been a long and painful process of discovery. I have tested the following and I believe found they were not the problem: (1) wine regression: (2) problem with my experimental sound drivers; (3) problem with pulseaudio; (4) bizarre problem unique to me -- and for this I reinstalled the system an tested with the base before moving on. When I did the last install, with the current Ubuntu Studio, I got the same result using the downloaded Generic kernel. (Studio can use both Generic and Real-time kernels. Linux-rt didn't work for other reasons. It crashed on bootup.) I was informed that both then-current kernels had problems. So I got the linux-generic with current Ubuntu patches and a successful re-compile of the linux-rt without Ubuntu patches. And I still have exactly the same problem. Here are my current kernels: linux-rt: 2.6.29.1-rt8-custom (It doesn't include Ubuntu's patches.) linux-generic 2.6.28-12 (this is from the Ubuntu site and has Ubuntu's patches) When I run audacity through wine, I get the following input choices: MIME: Wine wave in mapper - Input MIME: dsnoop:Generic MIME: dsnoop:Generic Windows DirectSound: Primary Sound Capture Driver Windows DirectSound: dsnoop:Generic Windows DirectSound: dsnoop:Generic When I use the second option (MME: dsnoop:Generic) it works on the first pass, but when I try to stop and start it again -- no go. The second recording area pops up but it seems to "shimmer." The recording meter does not move. And then it freezes. (That is approximately what happens to me training DNS.) When I use the 5th option (Windows DirectSound: dsnoop:generic) it works on the first pass, but when I stop/start it I get the following error message: Error when opening sound device. Please check the input device settings and the project sample rate.

2 1

Mmap/malloc redirection (bug 13335, seems to affect 3D games mainly)
by Paul TBBle Hampson April 29, 2009

April 29, 2009

Bug 13335 [1] is basically "OpenGL games crash or run slow". There's two symptoms here, and they're to do with proprietary video drivers. When the nVidia driver fails to mmap stuff from /dev/nvidia0, it starts failing OpenGL commands with GL_OUT_OF_MEMORY. When the FireGL driver fails to mmap or malloc (I don't know which), it falls back to indrect rendering. The problem in both cases is because Wine mmaps most of the 32-bit memory space for itself and then parcels this back out through HeapAlloc and related methods. When the GL libraries calls mmap and malloc themselves, for quite large blocks of memory, they fail because there's nowhere in the address space for those large blocks of memory to go. The first linked patch [2] in bug 13335 fixes this by redirecting mmap calls into ntdll which unmaps a block of address space, and performs the mmap into that address space, effectively handing that address space over to the library for the duration of the mmap's existence. I can't claim credit for that, I merely took Thunderbird's forward-ported version of Alexandre's original patch and forward-ported it further to 1.1.19. The second linked patch [3] simply redirects malloc and related calls to RtlAllocateHeap, rather like the msvcrt malloc-type calls are handled. The latter's almost certainly in the wrong place in ntdll, but it keeps ntdll from needing two copies of the pthread_functions structure. The bug's staring to accumulate some feedback that this helps for games that otherwise tend to crash after playing for a little while, and I've not had any luck catching people on IRC to look over the patches, so I'm wondering if anyone would like to provide feedback on these patches, as to whether they are the right approach, and if there are things that could be handled more cleanly. [1] http://bugs.winehq.org/show_bug.cgi?id=13335 [2] http://bugs.winehq.org/attachment.cgi?id=20483 [3] http://bugs.winehq.org/attachment.cgi?id=20484 -- ----------------------------------------------------------- Paul "TBBle" Hampson, B.Sc, LPI, MCSE Very-later-year Asian Studies student, ANU The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361) Paul.Hampson(a)Pobox.com Of course Pacman didn't influence us as kids. If it did, we'd be running around in darkened rooms, popping pills and listening to repetitive music. -- Marcus Brigstocke http://www.marcusbrigstocke.com/pacman.asp License: http://creativecommons.org/licenses/by/2.5/au/ -----------------------------------------------------------

1 0

The DIB engine... does anyone know how to get it into Wine?
by Luke Benstead April 29, 2009

April 29, 2009

Hi all, I've been watching the DIB engine work that has been going on in bug 421. It looks like Max has made massive progress getting Autocad working by the sound of it, almost perfectly and also improvements in Starcraft have been reported. However, he accepts (and Alexandre has confirmed) that neither of the two approaches he has tried is the right one and he believes (as do others) that any correct approach requires massive changes to GDI32, which if I read it right, no one seems to know how to do incrementally. Autocad is one of those apps, like Photoshop, which people need to be able to use and won't switch away from Windows without it. In fact, Autocad more so than Photoshop because there is no (almost) feature equivalent alternative available (like the GIMP for Photoshop). So it's frustrating to know that someone has it working, but vanilla Wine isn't going to see it working in the near future. My question is this: does anyone know how to incrementally implement the necessary changes? Is it even possible? If it's not possible, is it work considering branching Wine to implement it correctly, for merging back into trunk at a later stage once it's been thoroughly tested? I'm wondering if Wine's development process just doesn't allow for a big change like this, and perhaps it's the development model that is the reason bug 421 is so long standing? Any thoughts, I just want to spur some discussion on this because it seems that everyone that attempts a DIB engine hits a wall :) Luke.

9 16

Re: gdiplus: Implement GdipCreateHBITMAPFromBitmap
by Nikolay Sivov April 29, 2009

April 29, 2009

Massimo Del Fedele wrote: > Massimo Del Fedele ha scritto: >> Should work for both DIBs and DDBs format, but strange enough the >> IPicture bitmap >> inside wine gdiplus bitmap is always a 32 bit DDB by now... haven't >> found any >> other case. >> >> Ciao >> >> Max >> >> >> ------------------------------------------------------------------------ >> >> > sorry again... another dumb copy/paste :-( > Former had a spurious FIXME used for debugging purposes > > Max + IPicture_get_Handle(bitmap->image.picture, (OLE_HANDLE*)&hbm); + if(!hbm) + /* FIXME: return appropriate error code */ + return GenericError; + + /* gets bitmap data and find out bitmap's type */ + if(!(size = GetObjectW(hbm, sizeof(DIBSECTION), &ds))) + { + ERR("Couldn't get bitmap data\n"); + return GenericError; + } Could be HICON here (see GdipCreateBitmapFromHICON) or metafile. Since there's no tests for that could you please an explicit FIXME for that types?

2 1

Re: try5 [4/4](resend) kernel32: Fix GetVolumeNameForVolumeMountPointW to match Mountmgr
by Alexandre Julliard April 29, 2009

April 29, 2009

Guy Albertelli <galberte(a)neo.rr.com> writes: > mountmgr.sys uses a specific format for "unique volume name". Make > GetVolumeNameForVolumeMountPointW match that format for the returned > unique volume name. It should actually query mountmgr, not try to guess the name that mountmgr is using. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/3] iphlpapi: Add tests for GetAdaptersAddresses.
by Paul Vriens April 29, 2009

April 29, 2009

Hans Leidekker wrote: > diff --git a/dlls/iphlpapi/tests/iphlpapi.c b/dlls/iphlpapi/tests/iphlpapi.c > index 2fc5e0d..a03cc85 100644 > +static void test_GetAdaptersAddresses(void) > +{ > + ULONG ret, size; > + IP_ADAPTER_ADDRESSES *aa; > + IP_ADAPTER_UNICAST_ADDRESS *ua; > + > + if (!gGetAdaptersAddresses) return; Could you add a win_skip()? -- Cheers, Paul.

1 0

Re: gdiplus: partially implement GdipBitmapSetPixel
by Nikolay Sivov April 29, 2009

April 29, 2009

Massimo Del Fedele wrote: > This one implements GdipBitmapSetPixel() besides unhandled alpha channel. > > Ciao > > Max + SetPixel(hdc, x, y, ((color << 16) & 0xff0000) | (color & 0x00ff00) | ((color >> 16) & 0x0000ff)); Use ARGB2COLORREF(ARGB color) from gdiplus.c for that.

1 0

Re: [clusapi] Don't print an out parameter
by Hans Leidekker April 29, 2009

April 29, 2009

On Wednesday 29 April 2009 10:08:56 am Paul Vriens wrote: > Was going through some logs on Bugzilla and noticed this. > > Changelog > Don't print an out parameter The spec entry for ClusterEnum also needs a fix. -Hans

1 0

Re: [3/7] gdiplus: add blend information to linear gradient brushes
by Vincent Povirk April 28, 2009

April 28, 2009

Don't commit this one. It leaks the gdi brush when GdipCreateLineBrush fails. Vincent Povirk On Tue, Apr 28, 2009 at 6:39 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > >

1 0

re: The DIB engine... does anyone know how to get it into Wine?
by Dan Kegel April 28, 2009

April 28, 2009

Max's work has been great in that a) he has found and fixed bugs that affect Autocad, and gotten those bugfixes into the trunk, and b) he is slowly working his way towards a DIB engine prototype that actually greatly improves speed on some important apps without hurting other apps. If I recall correctly, previous efforts stalled partly because they didn't actually provide a real speedup. So I'm really glad Max is doing what he's doing, even if it's not destined for the trunk, because he is nevertheless paving the way in some sense. - Dan

5 10

Re: [2/5] WineD3D: Improve the GLSL spam filter
by Henri Verbeet April 28, 2009

April 28, 2009

2009/4/28 Stefan Dösinger <stefan(a)codeweavers.com>: > I think this is getting pretty rediculous. I think we should either just always print the infolog, or give the infolog its own debug channel and make this a WARN.

2 3

Re: [3/5] WineD3D: Implement texldd
by Henri Verbeet April 28, 2009

April 28, 2009

2009/4/28 Stefan Dösinger <stefan(a)codeweavers.com>: > + /* What good are texrect grad functions? I don't know, but GL_EXT_gpu_shader4 defines them. > + * There is no GL_ARB_shader_texture_lod spec yet, so I don't know if they're defined there > + */ So how are you using the extension without a spec? > +static void pshader_glsl_texldd(const struct wined3d_shader_instruction *ins) Please call this "shader_glsl_texldd".

2 3

Re: Ubuntu no longer works correctly without pulseaudio
by Susan Cragin April 28, 2009

April 28, 2009

http://bugs.winehq.org/show_bug.cgi?id=18133. >The alsadriver settings that freeze during training are as follows (and they are the ones that used to work): > >wave-out devices: dmix:Generic (there were three of these) >wave-in devices: dsnoop:Generic (ditto) > >My working mixer device was HD-Audio-Generic. >(I had three cards, the other mixers were HDA Intel and iMic USB audio system) > >Now, to get the program to work at all without freezing, I re-install the kernel. Then only the USB works properly. The settings I see are as follows. > >wave-out devices: ALC660-VD Analog > USB Audio > >wave-in devices: (same) Good news. By changing in winecfg alsa to oss, I was able to get USB and my on-board cards (including Creative X-fi) to work, and to work VERY well. No freezing during training. Smooth recognition. And very fast. (My new souped-up real-time kernel may have something to do with that.) I cannot control the volume by the program (I have to use alsamixer). OSS Driver wave out devices / wave in devices / mixer devices all show these three: Realtek ALC660-VD USB Mixer Creative CA0110-IBG

2 1

Romanian translation
by Dimitriu Petru April 28, 2009

April 28, 2009

Good day. I'm a Romanian ReactOS translator. (For those who don't know, ReactOS is an operating system which seeks to be 100% compatible and similar to Windows NT.) Many translations from Wine are passed to the ReactOS project when synchronizing the source code. That leads to the fact that I can't directly translate and/or update any translation of ReactOS files that are in sync with Wine. Some translations are already done here on the Wine project but some of them are wrong (For example Basic colours is translated incorrectly as Culori de basă when the correct translation is Culori de bază), others don't fit with the rest of the translations (The translations of ReactOS should retain the terminology used in Windows. In Windows, Cancel is translated to Revocare, in Wine the translation is Renunţă which is the imperative form of the verb a renunţa - to give up). I was told I should speak to you if I want to change these translations but the problem is that many Linux distributions are translated in Romanian using Renunţă as Cancel etc and if I try to change the translation in Wine, then the Romanian Linux-users will strongly disagree ... Now that's a problem! What do you suggest I should do?

7 9

Re: [PATCH 2/2] [Kernel32]: fix the management of input records withENHANCED_KEY set
by Dmitry Timoshkov April 28, 2009

April 28, 2009

"Eric Pouech" <eric.pouech(a)orange.fr> wrote: > --- a/dlls/kernel32/editline.c > +++ b/dlls/kernel32/editline.c > @@ -818,7 +818,7 @@ WCHAR* CONSOLE_Readline(HANDLE hConsoleIn) > /* EPP WCEL_Dump(&ctx, "before func"); */ > ofs = ctx.ofs; > /* mask out some bits which don't interest us */ > - ks = ir.Event.KeyEvent.dwControlKeyState & ~(NUMLOCK_ON|SCROLLLOCK_ON|CAPSLOCK_ON|ENHANCED_KEY); > + ks = ir.Event.KeyEvent.dwControlKeyState & ~(NUMLOCK_ON|SCROLLLOCK_ON|CAPSLOCK_ON); This reverts the following commit http://www.winehq.org/pipermail/wine-cvs/2008-October/049124.html which was a fix for the bug 4558. -- Dmitry.

1 0

Re: [1/4] ws2_32/tests: Resend: IPv6 tests for WSAAddressToStringA
by Detlef Riekenberg April 27, 2009

April 27, 2009

On Mo, 2009-04-27 at 20:48 +1000, Jeff Latimer wrote: > - ok( len == sizeof( expect4 ), "Got size %d\n", len); > + ok( len == sizeof( expect4 ), "Expected size to be %d, got %d\n", > sizeof( expect4 ), len); Do not use sizeof() in a test. > + /*check to see it IPv6 is available */ > + v6 = socket(AF_INET6, SOCK_STREAM, IPPROTO_TCP); > + if (v6 == INVALID_SOCKET) { > + skip("Could not create IPv6 socket (LastError: %d; %d > expected if IPv6 not available).\n", > + WSAGetLastError(), WSAEAFNOSUPPORT); > + goto end; There is no reason, that the reader must guess from the log, if the result is a failure or an expected behavior. You should detect, that IPv6 is not available and handle that case nice. if ((v6 == INVALID_SOCKET) && (WSAGetLastError() == WSAEAFNOSUPPORT)) { skip("IPv6 not supported on this system\n"); goto end; } ok(v6 !== INVALID_SOCKET, "create an IPv6 socket failed with %d\n", WSAGetLastError()); if (v6 == INVALID_SOCKET) { skip("No IPv6 socket\n"); goto end; } I know, that the same message is already in the current logs. That should be handled the same way. Thanks for pick up IPv6 -- By by ... Detlef

2 1