April 2009 - Wine-Devel - list.winehq.org

Re: Ubuntu no longer works correctly without pulseaudio
by Susan Cragin April 27, 2009

April 27, 2009

> Bug 1813 is a really old bug for something else (fixed in 2003). Did you >> forget a digit? > That would be http://bugs.winehq.org/show_bug.cgi?id=18133. > >- Reece Hi. Yes, that's the bug. Here's everything I know, and probably more than you want to know, but I don't know what to leave out. My system is on the bleeding edge of everything, which can be a problem when it comes time to diagnose. I have been using Ubuntu Jaunty Studio since its first beta, and it's now fairly mature. I compile every wine git and test it, using Dragon NaturallySpeaking. Usually everything works as well or better than it has. In addition to that, I compile my own alsa-driver because I use a Creative SoundBlaster X-fi soundcard. They are a one-time install and I used the stable daily build. They had been working well for weeks, and I had not updated them in at least a day or two. About 10 days ago, when I did my daily wine build and installed DNS, the training froze. My first thought was a wine regression, but I was busy and didn't test for a few days. Then I did a couple of regression tests that seemed to succeed, but really the just marked the first change I tagged as the problem. I tested back further than the problem appeared. Still no luck. Solution? That it's not wine's problem, it is something else that has been introduced. Then I tried using a new alsa-driver, and a new alsa-libs with it. Nothing. Then I tested various configurations of pulseaudio, purged and not-purged. No changes. Then I reinstalled the whole Ubuntu-Studio system. In the meantime, Ubuntu-Studio had switched to using the Real-Time kernel as a default. The kernel froze before wine had a chance to. Back to the drawing board. I downloaded the generic kernel. That seemed to work for USB audio only. I tried compiling alsa-drivers, and installing them, and then USB stopped receiving sound. Then someone on my ubuntu-studio users list compiled a generic (non-ubuntu) realtime kernel. I installed it in the crudest way possible, by double-clicking on the DEB. Success, but for the USB soundcard only. The alsadriver settings that freeze during training are as follows (and they are the ones that used to work): wave-out devices: dmix:Generic (there were three of these) wave-in devices: dsnoop:Generic (ditto) My working mixer device was HD-Audio-Generic. (I had three cards, the other mixers were HDA Intel and iMic USB audio system) Now, to get the program to work at all without freezing, I re-install the kernel. Then only the USB works properly. The settings I see are as follows. wave-out devices: ALC660-VD Analog USB Audio wave-in devices: (same) So, what do you make of all this? Are dmix and dsnoop being bypassed? Susan

1 0

Re: winedbg: add a crash dialog for --auto mode
by Austin English April 27, 2009

April 27, 2009

2009/4/16 Mikołaj Zalewski <mikolaj(a)zalewski.pl>: > This version of the patch uses the now implemented GetProcessImageFileName. > > From 549bdead0736d63bc2c05557b6813a64b53aa2ec Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Miko=C5=82aj_Zalewski?= <mikolaj(a)zalewski.pl> > Date: Sun, 21 Dec 2008 22:28:32 +0100 > Subject: [PATCH] winedbg: add a crash dialog for --auto mode > > --- > dlls/kernel32/tests/debugger.c | 96 ++++++++++++++--------- > programs/winedbg/Makefile.in | 5 +- > programs/winedbg/crashdlg.c | 172 > ++++++++++++++++++++++++++++++++++++++++ > programs/winedbg/debugger.h | 6 ++ > programs/winedbg/intvar.h | 3 + > programs/winedbg/resource.h | 34 ++++++++ > programs/winedbg/rsrc.rc | 26 ++++++ > programs/winedbg/rsrc_En.rc | 53 ++++++++++++ > programs/winedbg/tgt_active.c | 16 +++- > programs/winedbg/winedbg.c | 36 +++++--- > 10 files changed, 392 insertions(+), 55 deletions(-) Howdy Mikołaj, Looks like this patch caused a regression in http://bugs.winehq.org/show_bug.cgi?id=18216. Could you have a look? Before, it would crash, but the app continued on happily. After the crash dialog patch, the debugger is spawned infinitely, until the X client limit is reached. Seems to be hitting a loop somewhere... -- -Austin

2 1

Ubuntu no longer works correctly without pulseaudio
by Susan Cragin April 27, 2009

April 27, 2009

I just thought I would alert the list. I had a problem with sound oddities a few days ago, and filed bug 1813. The possible culprits were wine's daily build, my experimental alsa-driver, and standard Ubuntu updates. The Ubuntu updates won. Ubuntu no longer works correctly with pulseaudio purged. I have to use wine with pasuspender. Susan

3 2

Re: xinput: Better match native export order.
by Alexandre Julliard April 27, 2009

April 27, 2009

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > See bug 18218 > --- > dlls/xinput1_3/xinput1_3.spec | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) If an app depends on specific ordinals you should of course list them explicitly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Status of "USB device support in wine"
by Uwe Bonnes April 27, 2009

April 27, 2009

Hallo, I tried to run Alexander Morozov's patches against wine-git with libusb and ftd2x devices. Two remarks: - The files from ftp://ftp.etersoft.ru/pub/people/amorozov/usb/current/ miss lines in configure.ac to trigger the Makefile generation for usbd.sys and usbhub.sys. - The HardwareID in the registry is the end of the Registry key http://msdn.microsoft.com/en-us/library/dd568018.aspx You can use the string itself in the win registry. This helps, if you don't have the devices installed on a windows machine available. Both dll/drivers pair (libusb0.dll/libusb0.sys and ftd2xx.dll/ftdibus.sys) work an a lot devices and so must scan the bus for matching devices. I didn't get wine with the patches to do anything sensible in that case. Alexander, could you perhaps have a look (ftd2xx at http://www.ftdichip.com/Drivers/D2XX.htm and libusb-win32 at sourceforge) Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Reparse point unit tests patches
by Paul TBBle Hampson April 27, 2009

April 27, 2009

I posted a series of patches to add reparse point headers and junction point unit tests, as a basis from which to fix bug 12401. Is there any chance of these going in as they are, or do I need to sit on them until I or someone else implements the functionality they're testing? I'm linking to the old version, but git has been happily rebasing them for me up to and including 1.1.20, so they should still be applicable, or I can repost the latest versions. I suspect the relevance of this patch has changed since the change of fixed disk reported filesystem from NTFS to UnixFS. (ie bug 10601 isn't dependant on bug 12401 after that change, see bug 10601 comment 23) but I think it's a good thing to have in the Wine tree anyway. [PATCH 1/2] Add definitions used by reparse points http://www.winehq.org/pipermail/wine-patches/2009-January/067226.html [PATCH 2/2] Add unit tests for junction points using reparse point interface http://www.winehq.org/pipermail/wine-patches/2009-January/067227.html -- ----------------------------------------------------------- Paul "TBBle" Hampson, B.Sc, LPI, MCSE Very-later-year Asian Studies student, ANU The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361) Paul.Hampson(a)Pobox.com Of course Pacman didn't influence us as kids. If it did, we'd be running around in darkened rooms, popping pills and listening to repetitive music. -- Kristian Wilson, Nintendo, Inc, 1989 License: http://creativecommons.org/licenses/by/2.5/au/ -----------------------------------------------------------

2 2

Re: user32/tests: show that vertical and horizontal window scroll bar info is not created independently.
by Paul Vriens April 26, 2009

April 26, 2009

Rein Klazes wrote: > test case for bug #18102 > --- > dlls/user32/tests/scroll.c | 131 +++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 130 insertions(+), 1 deletions(-) > > diff --git a/dlls/user32/tests/scroll.c b/dlls/user32/tests/scroll.c > index 4f602c2..5cf3fcd 100644 > --- a/dlls/user32/tests/scroll.c > +++ b/dlls/user32/tests/scroll.c > @@ -220,6 +220,130 @@ static void scrollbar_test_track(void) > ok( IsWindow( hScroll), "Scrollbar has gone!\n"); > } > > +/* some tests designed to show that Horizontal and Vertical > + * window scroll bar info are not created independently */ > +static void scrollbar_test_default( DWORD style) > +{ > + INT min, max, ret; > + HWND hwnd; > + SCROLLINFO si = { sizeof( SCROLLINFO), SIF_TRACKPOS }; > + > + hwnd = CreateWindowExA( 0, "static", "", WS_POPUP | style, > + 0, 0, 10, 10, 0, 0, 0, NULL); > + assert( hwnd != 0); > + > + ret = GetScrollRange( hwnd, SB_VERT, &min, &max); > + ok( ret || > + broken( !ret) /* Win 98/ME */ > + , "GetScrollRange failed.\n"); No comments on the patch as I don't know enough of this stuff. The comma at the start of a new line looks strange though (couple of these in the patch). > + scrollbar_test_default( 0); > +if( 0) { /* enable this when the todo's in scrollbar_test_default are fixed */ > + scrollbar_test_default( WS_HSCROLL); > + scrollbar_test_default( WS_VSCROLL); > + scrollbar_test_default( WS_HSCROLL | WS_VSCROLL); > +} Does Wine crash on these? -- Cheers, Paul.

2 1

Re: kernel32/tests: Added last error tests for GetPrivateProfileString
by Dmitry Kislyuk April 26, 2009

April 26, 2009

I don't have a particular app for you, however, there can easily be apps that would behave differently from how they would on Windows due to these last errors not being set to what the app expects. Do you have a reason why Wine behavior should not match the Windows behavior in these test cases? By Windows behavior I am referring to the more recent Windows versions of course. Dmitry --- On Thu, 4/23/09, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > From: Paul Vriens <paul.vriens.wine(a)gmail.com> > Subject: Re: kernel32/tests: Added last error tests for GetPrivateProfileString > To: dimaki(a)rocketmail.com > Cc: wine-devel(a)winehq.org > Date: Thursday, April 23, 2009, 2:41 AM > Dmitry Kislyuk wrote: > > > > > > Any particular reason for adding these tests? Is there an > app depending on the last error? > > -- Cheers, > > Paul. >

3 2

Old regression in Autocad
by Massimo Del Fedele April 26, 2009

April 26, 2009

Following patch c3bdda810243ed6c8d6b9960d1df3b534653b438 is first bad commit commit c3bdda810243ed6c8d6b9960d1df3b534653b438 Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Sep 24 18:19:46 2008 +0200 mshtml: Use ActiveScript for JavaScript in file protocol documents. :040000 040000 61b72d076d5bcefd2ec1938442972f252d1ce7fc 7ce674ba65d818a7bbd8df8c6b4482fc024e1ebb M dlls Caused a regression on AutoCAD registration page display, which worked before with native shlwapi and now is broken even with it. Without native shlwapi for autocad 2005 and both shlwapi AND urlmon for Autocad 2008 it is broken anyways. Please look at bug 12570 for details, in particular at comment #44 for a simple test. Ciao Max

1 1

[1/7] [wined3d] add ps_np2fixup_t ptr to shader_arb_priv (review)
by Tobias Jakobi April 26, 2009

April 26, 2009

For review: This patchset implements np2 texcoord fixup in ARB mode. Constants used to store texture dimensions are already packed, using the same data structures like the GLSL packing code. The code is finished and works quite well. It has been tested with Max Payne 2, HL2 and FEAR. All games now work with post-processing effects and anything else that needs NP2 textures on the nvidia FX series. Greets, Tobias -- Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger01

2 2

gdi32 font-link patch issues? (Bug 18044)
by Paul TBBle Hampson April 26, 2009

April 26, 2009

I posted a series of patches to fix a font-link problem highlighted by utorrent 1.8, but which would affect any application that uses MS Shell Dlg as a UI font. (Or any other substituted font, in fact) I haven't had any feedback on the latest iteration, so I was wondering if anyone had any objections I'm unaware of, or if there was any other reason they hadn't gone in? [PATCH 1/4] gdi32: Don't add duplicate system_links entries http://www.winehq.org/pipermail/wine-patches/2009-April/071949.html [PATCH 2/4] gdi32: fetch child fonts by real parent font name http://www.winehq.org/pipermail/wine-patches/2009-April/072006.html [PATCH 3/4] gdi32: Ensure font name comparisons are case-insensitive http://www.winehq.org/pipermail/wine-patches/2009-April/071951.html [PATCH 4/4] gdi32: Remove tabs from init_system_links TRACEs http://www.winehq.org/pipermail/wine-patches/2009-April/071952.html -- ----------------------------------------------------------- Paul "TBBle" Hampson, B.Sc, LPI, MCSE Very-later-year Asian Studies student, ANU The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361) Paul.Hampson(a)Pobox.com Of course Pacman didn't influence us as kids. If it did, we'd be running around in darkened rooms, popping pills and listening to repetitive music. -- Kristian Wilson, Nintendo, Inc, 1989 License: http://creativecommons.org/licenses/by/2.5/au/ -----------------------------------------------------------

1 0

Re: msi/tests: Test type for INT column.
by Hans Leidekker April 25, 2009

April 25, 2009

> - "( `Property` CHAR(255), `Value` CHAR(1) PRIMARY KEY `Property`)" ); > + "( `Property` CHAR(255), `Value` CHAR(1), `Intvalue` INT PRIMARY KEY `Property`)" ); > ok( r == ERROR_SUCCESS , "Failed to create table\n" ); ... > ok( check_record( rec, 2, "Value"), "wrong record type\n"); >+ ok( check_record( rec, 3, "IntValue"), "wrong record type\n"); These changes don't agree on the case of 'Intvalue', causing this test to fail. It would be interesting to see if the remaining column types also need the extra flag. -Hans

2 1

Re: riched20: fix placement of crlf on font table streamout
by Austin English April 25, 2009

April 25, 2009

On Sat, Apr 25, 2009 at 12:56 PM, Massimo Del Fedele <max(a)veneto.com> wrote: > In riched20/writer.c the font table was erroneously streamed out with a \r\n > after > each font, instead of end of font table. Can be easily checked on rtf output > from windows. AutoCAD 2005 was very picky with this, expecting an opened or > closed bracked after each font, crashing if not found. > Fixes Bug 14827 Can you add a testcase for this? -- -Austin

2 2

Generating stats on regression bugs in bugzilla
by Scott Ritchie April 25, 2009

April 25, 2009

I had a theory that we might be getting better at preventing regressions now than a year or so ago due to the expansion of things like AppDB and the test suite. It'd be nice to have some sort of data though. Would it be reasonable to comb through the bugzilla database for all the bugs tagged regression and analyze them? I'm interested in: 1) quantity and frequency of bugs tagged regression that were filed at various dates since the release of 1.0. I'm not sure whether it's better to use the version number field in bugzilla as a proxy for "first version with regression" or to just guess that from the date. 2) how long regression bugs took to be fixed Thanks, Scott Ritchie

3 3

Re: msi/tests: Test type for INT column.
by Austin English April 25, 2009

April 25, 2009

On Sat, Apr 25, 2009 at 9:55 AM, Hib Eris <Hib(a)hiberis.nl> wrote: > This patch adds a check for the type of INT columns in msi database tables. > > > --- > dlls/msi/tests/db.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > Howdy Hib, You need to wrap failing tests in todo_wine, e.g., for your patch: diff --git a/dlls/msi/tests/db.c b/dlls/msi/tests/db.c index b2c7d06..cf74070 100644 --- a/dlls/msi/tests/db.c +++ b/dlls/msi/tests/db.c @@ -1128,7 +1128,7 @@ static void test_viewgetcolumninfo(void) r = run_query( hdb, 0, "CREATE TABLE `Properties` " - "( `Property` CHAR(255), `Value` CHAR(1) PRIMARY KEY `Property`)" ); + "( `Property` CHAR(255), `Value` CHAR(1), `Intvalue` INT PRIMARY KEY `Property`)" ); ok( r == ERROR_SUCCESS , "Failed to create table\n" ); /* check the column types */ @@ -1137,12 +1137,14 @@ static void test_viewgetcolumninfo(void) ok( check_record( rec, 1, "S255"), "wrong record type\n"); ok( check_record( rec, 2, "S1"), "wrong record type\n"); + ok( check_record( rec, 3, "I2"), "wrong record type\n"); MsiCloseHandle( rec ); /* check the type in _Columns */ ok( 0x3dff == get_columns_table_type(hdb, "Properties", 1 ), "_columns table wrong\n"); ok( 0x1d01 == get_columns_table_type(hdb, "Properties", 2 ), "_columns table wrong\n"); + todo_wine ok( 0x1502 == get_columns_table_type(hdb, "Properties", 3 ), "_columns table wrong\n"); /* now try the names */ rec = get_column_info( hdb, "select * from `Properties`", MSICOLINFO_NAMES ); @@ -1150,6 +1152,7 @@ static void test_viewgetcolumninfo(void) ok( check_record( rec, 1, "Property"), "wrong record type\n"); ok( check_record( rec, 2, "Value"), "wrong record type\n"); + todo_wine ok( check_record( rec, 3, "IntValue"), "wrong record type\n"); MsiCloseHandle( rec ); Then, in your second patch, for whatever you fix, remove the todo_wine. The test suite should pass before and after every patch. Thanks for helping Wine! -- -Austin

1 0

How do I get off the Wine mailing lists?
by Rich Gilson April 25, 2009

April 25, 2009

Can somebody please help me get off the mailing lists? I have tried using the website to unsubscribe my email account from each mailing list and that didn't work. I've also tried sending a message to the mailing list with the word 'unsubscribe' as the subject and that didn't work. Can anybody tell me what I need to do to get off the lists?

2 1

Re: include: Define IN6ADDR_ANY_INIT and IN6ADDR_LOOPBACK_INIT and code for IN6_IS_ADDR_LOOPBACK
by Jeff Latimer April 25, 2009

April 25, 2009

Jeff Latimer wrote: > This patch enables putty to compile and run using IPv6. I meant to say that André Hentschel was doing the hard work with putty and merely ask me to do this little bit. Jeff

3 2

msi/tests: Test type for INT column.
by Hib Eris April 25, 2009

April 25, 2009

Hi all, I have just send in my first patch to wine-patches. Unfortunately it contains a small mistake. My apologies for that. I will resend a correct patch soon. I guess I was just too happy with my patch and wanted to share it as soon as possible.. or actually more soon than possible. Kind regards, Hib Eris

1 0

Re: Wine release 1.1.20
by Evil Jay April 25, 2009

April 25, 2009

Another great set of bugfixes and improvements, as usual. Keep up the great work devs - it's much appreciated! -J Alexandre Julliard wrote: > The Wine development release 1.1.20 is now available. > > What's new in this release (see below for details): > - Show a dialog on application crashes. > - Much improved OLE copy/paste support. > - Various listview improvements. > - More Direct3D code cleanups. > - Various bug fixes. > > The source is available from the following locations: > > http://ibiblio.org/pub/linux/system/emulators/wine/wine-1.1.20.tar.bz2 > http://prdownloads.sourceforge.net/wine/wine-1.1.20.tar.bz2 > > Binary packages for various distributions will be available from: > > http://www.winehq.org/site/download > > You will find documentation on http://www.winehq.org/site/documentation > > You can also get the current source directly from the git > repository. Check http://www.winehq.org/site/git for details. > > Wine is available thanks to the work of many people. See the file > AUTHORS in the distribution for the complete list. > > ---------------------------------------------------------------- > > Bugs fixed in 1.1.20: > > 2221 Hyper Chem v7.5 doesn't open/save files > 4464 d3dx9_*.dll are unimplemented > 9084 Panzer General III SE pinkish text instead of transparent > 9102 Panzer General III Scorched Earth in-game crash (memcpy) > 9637 Switchball only shows a blank screen > 10253 Fraps does not record videos or take a screenshot > 11716 star wars battlefront crashes with sound enabled > 12040 Stronghold 2 1.4: crash when starting the application > 12057 Power! Estimator renders numerical cell text incorrectly > 12393 adobe illustrator 10 crashed on startup > 12560 Perfect World: Corrupt Bitmap Images > 13563 Nestopia: crashes with enabled shaders > 13820 Yahoo! Messenger 9.0 beta hangs on login > 13825 Morrowind pagefaults when trying to run fullscreen with missing videos > 14456 Diablo II hangs when it loses focus > 14812 dsound bug causes games to crash > 14970 everquest crashes in winmm > 15081 Perfect World - Grey Characters > 15088 Lotus Approach page faults on open dialog > 15172 File Names with spaces seen as seperate files > 15303 dragonshard crashes or presents a corurpted screen > 15494 ddraw_test throws an exception when run > 15557 GTA Trylogy can't install > 15566 GTA 3 doesn't find DVD > 15575 Word Pro table nubmers get reformatted > 15603 Screen periodically erased in Starfleet Command II > 15622 Everquest crashes > 15630 Program LaTeXPiX crashes at startup > 15764 Homeworld 2 Patch (homeworld2_update_en_10_11.exe) to v1.1: crash during setup > 15881 Pharaoh - can't play on fullscreen > 16613 A Vampyre Story Demo installer doesn't work > 16989 Cobra 11 Nitro: Cars drawn as artifacts > 17198 World Editor: Tree Component of Unit Editor doesn't (re)draw correctly > 17397 Ventrilo 3.0.4 won't initialize GSM 6.10 codec stream > 17478 Fix dpa warning from comctl32/listview.c > 17498 winemaker fails on 64-bit systems > 17528 3D Mark 2001 SE Dragothic: Textures not rendered on running humans > 17774 Fable crashes on starting a new or existing game > 17910 Black & White: Crashes in texture code at start > 17984 Invalid handle for RegOpenKeyExA in win64 bit application > 17987 Autocad toolbars mis-sized > 17991 QueryPathOfRegTypeLib fails to locate typelib when (major.minor) = (0xffff.0xffff) > 18007 Subtitle Workshop "Save as.." selection menu not appearing > 18030 Images not show (or flickering) in old app > 18076 SmartDraw.exe: unimplemented function gdiplus.dll.GdipBitmapSetResolution > 18090 Watchtower Library no longer starts > 18111 Powerhorse crashes > 18114 rpcrt4.NdrDllCanUnloadNow: COM proxy/stub factory reference count eval incorrect (crashes Visual Studio 2005 on exit) > 18125 Drawing problem in Wine > 18150 Foobar2000 properties dialog is blank > 18155 Approach crashes on File, Export > > ---------------------------------------------------------------- > > Changes since 1.1.19: > > Alexandre Julliard (18): > c2man: Fix the array reference syntax and the return value regexps. > user32/tests: Fix a couple of test failures on Windows. > user32/tests: Fix a few sysparams tests on various Windows versions. > configure: Remove checks for headers that are no longer used. > jscript: Avoid size_t in printf width specifier. > ws2_32/tests: Avoid sizeof in traces. > kernel32: Make sure the string is properly terminated in QueryFullProcessImageNameW. > dbghelp: Add a few more 64-bit symbol functions. > imagehlp: Forward some more 64-bit functions to dbghelp. > winex11.drv: Don't give focus to a minimized window upon take focus. > include: Add defines for 32-bit dbghelp functions on 64-bit. > comctl32: Repaint comboex control upon WM_SETREDRAW, like other common controls do. > advapi32/tests: Fix a couple of test failures on Vista. > user32/tests: Fix a couple of dimension checks on W2k3 and Vista. > include: Fix the SYSTEM_CACHE_INFORMATION structure for Win64. > include: Fix the DDE structures for 64-bit. > user32: Fix the DDE service formatting for 64-bit. > user32/tests: Don't try to unpack or free invalid handles. > > Andrew Nguyen (1): > gdiplus: Stub GdipBitmapSetResolution. > > André Hentschel (9): > start: Correct German translation. > winemaker: Add -m32 flag to support winegcc-changes. > winemaker: Fix whitespace handling for libs. > winemaker: Fix wrong place for case-check. > winemaker: Parse include dirs from vcproj file. > winemaker: Remove unused function. > winemaker: Print version in Makefile header. > winemaker: Print all copyrights in banner. > winemaker: Canonicalize directory name if used as target name. > > Aric Stewart (23): > msctf/test: Test enabling and disabling Language Profiles. > msctf/tests: Add framework for a TextService for testing. > msctf: Correct order of arguments to OnSetFocus sink call. > msctf: Release focused DocumentMgr on Deactivate and make sure to do a OnSetFocus Sink. > msctf: ITfDocumentMgr::GetBase returns the top if there is only one context pushed. > msctf: Correct index for being unable to pop last context. We need to leave one behind. > msctf: Add locking flags. > msctf: Helper functions for generating DWORD cookies. > msctf/tests: Setup test framework for ITfThreadMgrEventSink. > msctf/tests: Test activation and deactivation of a text service. > msctf/tests: Test DocumentMgr creation and Focus. > msctf/tests: Test ITfContext Push, Pop, GetTop and GetBase. > msctf/tests: Add ITextStoreACP interface for testing. > msctf: Make use of generated cookies in sinks to allow 64 bit compatibility. > msctf: Add ITfKeystrokeMgr framework to ThreadMgr. > msctf: Define ITfKeyEventSink. > msctf: Define the TF_MOD_* Constants. > msctf/tests: Framework for testing ITfKeystrokeMgr. > msctf/tests: Test ITfKeystrokeMgr::UnpreserveKey and ITfKeystrokeMgr::PreserveKey. > msctf/tests: Test ITfKeystrokeMgr::IsPreservedKey. > msctf/tests: Test framework for ITfKeyEventSink. > ole32: CoGetTreatAsClass should return S_FALSE if it cannot even find the key for the requested CLSID. > msctf/tests: Use ITfInputProcessorProfiles::GetCurrentLanguage to get gLangid. > > Austin English (2): > wineps.drv: Fix a memory leak. > ole32: Rename a macro to prevent a conflict on NetBSD. > > Brad Martin (1): > wined3d: Fix prototype for EnumAdapterModes. > > Christian Costa (19): > quartz: Data may be incomplete at the end of file so do not assert if we have less data than expected. > amstream: Turn Initialize FIXME into a TRACE. > amstream: Initialize the stream in OpenFile if not done before. > amstream/tests: Beginning of tests. > amstream/tests: Fix crosstest build. > mciqtz32: Use opened state to avoid device to be closed several times. > mciqtz32: Fix some traces. > mciqtz32: Hook MCI_STOP. > mciqtz32: Show messages in hex as they are defines in headers. > amstream/tests: Improve render file test. Move OpenFile specific test into a separate test function. > winedump: When generating preamble, use 4 spaces instead of tabs. Remove extra break. > xmllite: Add stubbed dll for xmllite. > ddraw: Handle refcount of lights when interacting with viewport. > ddraw/tests: Add tests for refcount handling of light with viewport. > d3dxof: Accept longer string size. > mciqtz32: Remove all remaining tabs. > mciqtz32: Move MCIQTZ_mciGetOpenDev at the top and always use it. > mciqtz32: Make sure the device is valid before starting the play. > mciqtz32: Stop the device only after param and device checks are done. > > Colin Finck (1): > mshtml: Fix the size passed to MultiByteToWideChar. > > Damjan Jovanovic (1): > winemenubuilder: Build freedesktop MIME type list for later use. > > Dan Kegel (1): > ntdll: Add missing valgrind hook in RtlAllocateHeap. > > David Adam (4): > ddraw: Remove useless comments. > d3d8: Add tests for IDirect3D8Device_Reset. > d3d9: Add tests for IDirect3D9Device_Reset. > wined3d: SetDepthStencilSurface is always called when AutoDepthStencil is enabled. > > Detlef Riekenberg (5): > oleaut32: VarCat must use localized names for VT_BOOL. > oleaut32/tests: Replace lstrcpyW and lstrcatW with memcpy to fix failures on win95. > msi/tests: Replace lstrcatW with memcpy to fix failures on win95. > winetest: Add support for --version, --help and /?. > winetest: Add option -x to extract all test. > > Dmitry Kislyuk (1): > kernel32: Added GetPrivateProfileSection and GetPrivateProfileString tests for empty section scenario. > > Dmitry Timoshkov (2): > oleaut32: Add some additional tests for QueryPathOfRegTypeLib, make them pass under Wine. > winedbg: Fix a typo in the comment. > > Dylan Smith (1): > richedit: Null terminate streamed out rich text. > > Florian Köberle (2): > comctl32/tests: Test expanding of a invisible sub tree. > comctl32: Fix expanding of invisible sub trees. > > Francois Gouget (9): > wineesd.drv: Add a trailing '\n' to a WARN() trace. > dinput: Add a trailing '\n' to ERR() messages. > Assorted spelling fixes. > winapi: parse_c_declarations() is not used. Remove it. > winapi: Fix the parse_c_declaration() prototype and remove unused variables. > winapi: trampoline is not used so remove it. > winapi: Remove some dead code. > winapi: Fix the C-parser combined getter/setter prototypes. > wined3d: Avoid using an implicit value to set fogcoord to 0.0. > > Frans Kool (8): > mshtml: Corrected Dutch translations. > wordpad: Fixed Dutch translations. > setupapi: Fixed Dutch translations. > reg: Fixed Dutch translations. > regedit: Fixed Dutch translations. > shell32: Fixed Dutch translations. > kernel32: Added Dutch translations. > crypt32: Corrected Dutch translations. > > Ge van Geldorp (2): > secur32: Implement more GetUserNameEx() formats. > secur32/tests: Fix GetUserNameEx() tests. > > Giuseppe Bilotta (1): > comctl32/toolbar: Fix trace info for TOOLBAR_InternalInsertButtonsT. > > Hans Leidekker (13): > msi: Support setting summary information by importing a _SummaryInformation table. > user32: By default, return all zeroes in the first half of the keyboard layout name. > winex11.drv: Set HKCU\Keyboard Layout\Preload key. > advapi32: Fix buffer size query for CreateWellKnownSid. > msvcrt: Implement ___lc_codepage_func, ___lc_collate_cp_func and ___lc_handle_func. > programs: Add stub termsv.exe. > msi: Fix a double free. > msi: Fix another double free. > server: Add requests to set and retrieve default dacl. > ntdll: Implement NtQuery/SetInformationToken(TokenDefaultDacl). > kernel32: Improve GetVolumePathName stub. > wininet: Fix parsing of cookies with attributes. > wininet: Replace any existing cookie header. > > Henri Verbeet (35): > wined3d: Pass a struct wined3d_shader_dst_param to shader_arb_get_write_mask(). > wined3d: Get rid of the "token" field from struct wined3d_shader_dst_param. > wined3d: Don't die if a vertex shader has samplers. > wined3d: Group instruction context information together in struct wined3d_shader_context. > wined3d: Introduce struct wined3d_shader_src_param. > wined3d: Store the register type in struct wined3d_shader_src_param. > wined3d: Store the register index in struct wined3d_shader_src_param. > wined3d: Store the source modifiers in struct wined3d_shader_src_param. > wined3d: Create a relative addressing token for 1.x shaders in the frontend. > wined3d: Store the source relative addressing token as a struct wined3d_shader_src_param. > wined3d: Store the destination relative addressing token as a struct wined3d_shader_src_param. > wined3d: Pass a struct wined3d_shader_src_param to shader_glsl_get_register_name() for the relative addressing token. > wined3d: Pass a struct wined3d_shader_src_param to shader_glsl_add_src_param(). > wined3d: Simplify replicating the .x swizzle in shader_hw_mov(). > wined3d: Pass a struct wined3d_shader_src_param to shader_arb_add_src_param(). > wined3d: Pass a struct wined3d_shader_src_param to pshader_gen_input_modifier_line(). > wined3d: Explicitly pass the source modifier to shader_glsl_gen_modifier(). > wined3d: Store the source swizzle in struct wined3d_shader_src_param. > wined3d: Add a separate function for converting swizzles to strings. > wined3d: Pass a struct wined3d_shader_src_param to shader_glsl_get_swizzle(). > wined3d: Pass a struct wined3d_shader_src_param to shader_arb_get_swizzle(). > wined3d: Get rid of the token field from struct wined3d_shader_src_param. > wined3d: Get rid of the WINED3DVS_* swizzle constants. > wined3d: Handle the swizzle shift in the frontend rather than the backend. > wined3d: Handle the source modifier shift in the frontend rather than the backend. > wined3d: Handle the destination modifier shift in the frontend rather than the backend. > wined3d: Move some frontend specfic code to baseshader.c. > wined3d: Move frontend specfic constants to baseshader.c. > wined3d: Downgrade an ERR to a WARN. > wined3d: Get rid of the shared_handle parameter. > wined3d: Handle the opcode specific control shift in the frontend rather than the backend. > wined3d: Use a more reasonable limit for the number of mipmap levels. > wined3d: The first shader token should be the version token. > wined3d: Add a function to read an opcode from SM1-3 bytecode. > wined3d: Use shader_sm1_read_opcode() in shader_get_registers_used(). > > Huw Davies (50): > ole32: Store a cached version of the local data object's enumeration. > ole32: Change helper function to return the matching entry. > ole32: Rewrite the clipboard window's wndproc to use the cached enum data. > ole32: Add support for rendering stream data to the clipboard. > ole32: Make all formats available to the clipboard. > ole32: Add support for rendering storage data to the clipboard. > ole32: Use helper function to duplicate global memory. > ole32: Unicodify window creation. Don't register the class as global. > ole32: Add a helper function to return the ole clipboard structure. > ole32: Add a helper function to set and release the source IDataObject. > ole32: Add a function to return (and possibly create) the clipboard's window. > ole32: Don't pass a window if we're reading from the clipboard. > ole32: Rename a variable. > ole32: Store the marshalled IDataObject in a window property of the clipboard window. > ole32: If there's a current data object on the ole clipboard GetData should use it. > ole32/tests: Tests that show the consumer data object isn't a singleton. > ole32: The consumer data object is not a singleton, but reflects the state of the clipboard when it was acquired. > ole32: Now that the consumer side of the clipboard separated from the main clipboard object, simplify the initialization code. > ole32: After a call to GetData the consumer should hold a ref on the source data object. > ole32/tests: Add a few more reference count tests. > ole32: Add support for getting global handle objects from a flushed clipboard. > ole32: Add support for getting stream based objects from a flushed clipboard. > ole32: Add support for getting storage based objects from a flushed clipboard. > ole32: OleFlushClipboard should render all formats to the clipboard. > ole32: Try global and stream types if the requested types don't match the source. > ole32/tests: Tests for a flushed clipboard. > wineps.drv: Fix compile error. > winex11.drv: Fix ordering of synthesized text formats. > winex11.drv: Fix typo so that emf -> mfpict synthesis works. > ole32: Make get_priv_data return target device ptrs (rather than offsets) and add a couple of helper functions to simplify this process. > ole32: Check that the target devices match. > ole32: Don't set cf_dataobject if we're clearing the clipboard. > ole32: Add support for enumerating non-ole clipboard formats. > user32/tests: Fix tests on win9x. > ole32/tests: OleGetClipboard doesn't return the same object under win9x, winme and nt4. > ole32/tests: win9x, winme and nt4 ignore the target device. > ole32/tests: win9x and winme don't have CF_UNICODETEXT. > ole32/tests: win64 sets the lsb of the final DWORD in the ole private data header. > ole32/tests: win9x and winme don't enumerate duplicated cfFormats. > ole32/tests: Add some tests to exercise the enumerator. > ole32: Improve the TRACEs by printing the fmtetc contents. > ole32/tests: Rename variable to avoid a conflict on some systems. > ole32/tests: For win9x and winme the size of the data on the clipboard may be larger than expected. > ole32: Add a stub for OleCreateFromDataEx. > ole32: Register a few more clipboard formats and make them have global scope. > ole32: Rewrite OleQueryCreateFromData so it compares clipboard format ids rather than strings and be sure to free the enumerator. > ole32: Expose the marshalled data on the clipboard rather than as a window prop so that other processes can actually read it. > ole32: Fix a couple of comments. > winex11.drv: Print clipboard formats in hex. > ole32/tests: Improve the traces in the test. > > Igor Tarasov (3): > comctl32: Fix regression caused by 2d751ee56afced908d0788b936fa4aac1b29f1a1. > comctl32: Fix typo in TOOLBAR_SetButtonSize code. > comctl32: TOOLBAR_SetImageList should recalculate toolbar only if it is necessary. > > Jacek Caban (1): > mshtml: Added IPersistHistory stub implementation. > > Jeff Latimer (3): > ws2_32: WSAAddressToStringA should return length of ANSI address string and should include the trailing null. > ws2_32: WSAAddressToStringW should return length of unicode address string should and include the trailing null. > include: Bring in6_addr into line with the MS definition. > > Jesse Allen (2): > dsound: Allow a special cbSize case in CreateSoundBuffer. > dsound: Fix test for some windows versions. > > Juan Lang (1): > crypt32: Fix a test failure on Windows 98. > > Kai Blin (2): > secur32: Work around ntlm_auth in Samba 3.0.28a being broken for cached credentials. > sxs: Implement a stub CreateAssemblyCache to make Publish or Perish install. > > Ken Sharp (1): > winedbg: Correct slight typo in winedbg dialog. > > Ken Thomases (5): > winecoreaudio: Eliminate some unnecessary code. > winecoreaudio: Avoid potential deadlock in wodOpen. > winecoreaudio: Avoid a race between closing and opening the waveOut device. > winecoreaudio: For waveOut, don't use STOPPED state; it's redundant. > winecoreaudio: Avoid a race between closing and opening the waveIn device. > > Konstantin Kondratyuk (1): > fonts: Add Kazakhstan's symbols into tahoma. > > Marcus Meissner (1): > amstream/tests: Handle directdraw not being created (Coverity 920). > > Michael Stefaniuc (11): > opengl32: Remove superfluous pointer casts. > mshtml/tests: Replace long with LONG. > riched20/tests: Use better types than long. > ws2_32: Use better types for some variables. > msi: Remove superfluous cast of a MSIHANDLE in a TRACE(). > msi/tests: Replace long with LONG. > comdlg32: Fix the Slovak translation. > wordpad: "Fix" the Turkish translation. > rpcrt4: Replace some usage of the long type. > winedbg: Remove some superfluous pointer casts. > user32/tests: Don't use the long type. > > Mikołaj Zalewski (1): > winedbg: Add a crash dialog for --auto mode. > > Nicolas Le Cam (7): > msi/tests: Test MsiRecordGetString on null and empty strings. > msi: Fix buffer length value returned by MSI_RecordGetStringW on null and empty strings. > wininet/tests: Fix HttpSendRequestW test on IE5. > msi: Enfore use of GetFileAttributes return value. > msi/tests: Add empty dir test for the DrLocator part of the AppSearch action. > msi: Fix ACTION_AppSearchDr on empty path. > msi/tests: Fix package test when run on a different drive than C:\. > > Nikolay Sivov (19): > comctl32/listview: Fix selection handling in LVM_SORTITEMS (with some tests). > comctl32/listview: Fix a regression caused by 59148d0bb549ff8690f15f14571a715e3fdd43a5. > comctl32/listview: Fix some comment typos. > comctl32/listview: Implemented LVM_SORTITEMSEX. > comctl32/listview: Add a ListView_GetTextBkColor macro. > comctl32/listview: Slightly enlarge rectangle when drawing checkbox. > comctl32/listview: Switching to/from LVS_OWNERDATA isn't allowed after creation. > comctl32/listview: Fix a regression caused by 9c1a0e468f5cfbe9d863852ed5a42390f2cbfeb4. > comctl32/listview: Some tests for LVS_SINGLESEL switchover. > fonts: Fix a typo in copyright text. > comctl32/listview: LVM_SETITEM is unsupported on LVS_OWNERDATA. > comctl32/listview: Add a TRACE(..) to LISTVIEW_CreateHeader. > comctl32/listview: Header should be created when LVS_EX_HEADERDRAGDROP set. > comctl32/listview: Additional tests for LVM_GETSUBITEMRECT. > comctl32/listview: Partial fix for LVM_GETSUBITEMRECT for item == -1. > comctl32/tests: Remove tests failing on most platforms. > comctl32/tests: Existing items aren't resorted after LVS_SORTASCENDING added. > comctl32/tests: Tests for LVM_GETCOLUMNORDERARRAY: it actually uses HDM_GETORDERARRAY. > comctl32/listview: Fix LVM_GETCOLUMNORDERARRAY passing message to header. > > Paul TBBle Hampson (1): > dinput: Add missing newline to trace message. > > Paul Vriens (15): > usp10/tests: Skip some tests on WinME. > shell32/tests: Fix some test failures on Vista. > gdi32/tests: Skip several tests on Win9x. > rpcrt4: Fix NdrDllCanUnloadNow. > shell32/tests: Fix some test failures on NT4. > gdi32/tests: Fix a test failure on NT4. > shell32/tests: Fix a test failure on Win95 and NT4. > include: Add missing GdipGetLogFontA definition. > gdiplus: Return the correct result in GdipCreateFontFromLogfontA. > gdiplus: Convert lfFaceName from W to A, not the other way around. > gdiplus/tests: Fix test failures on Win98 by using A-functions. > shell32/tests: Fix some test failures on Win9x and NT4. > shell32/tests: Fix a test failure on Win98. > setupapi/tests: Fix a test failure on Win98. > gdiplus/tests: Fix a test failure on Win98. > > Peter Schauer (1): > comctl32/listview: Fix warning from DPA_GetPtr. > > Reece Dunn (2): > winecfg: Fix the size of the application static text in Spanish. > winecfg: Fix the size of the application static text in Japanese. > > Rein Klazes (5): > msvcrt: Correct implementation of _ecvt() with tests. > user32: When repainting a static control with SS_BITMAP style, do not erase the background if there is no valid bitmap to paint. > msvcrt: Do not set the windows version to 0.5. > msvcrt/tests: Add some tests for strtok(). > comdlg32: Fix a crash in LookIn combo box WM_COMMAND message handler. > > Roderick Colenbrander (3): > wined3d: Update Nvidia driver version information. > wined3d: Report the driver description as reported by the Windows drivers when a device string is entered in our device table. > opengl: Add WGL_EXT_pixel_format_packed_float support. > > Stefan Dösinger (5): > wined3d: Add a more formal framework for driver quirks. > wined3d: Move the generic mac glsl uniform fixup to the quirk table. > wined3d: Move the remaining quirks into the quirk table. > wined3d: Reserve additional GLSL constants on some drivers. > wined3d: Merge match_apple and implementation_is_apple. > > Tobias Jakobi (2): > wined3d: Add newline to fixme. > wined3d: Rename some NP2 fixup variables and update comments. > > Vincent Povirk (2): > mciavi32: Remove unnecessary string buffers in MCIAVI_mciSet. > shell32: Implement SHGetNewLinkInfo[AW]. > > Vitaliy Margolen (5): > dinput: Make EnumDevices and GetObjectInfo consistent about GUIDs. > dinput: Remove redundant stuff. > dinput: Make props array a part of the generic joystick struct. > dinput: Convert evdev joystick to new base class. > dinput: Use more friendly name for the joystick than its device path. > > Łukasz Wojniłowicz (2): > kernel32: Added Polish translations. > cmd: Updated Polish translations. > > -- > Alexandre Julliard > julliard(a)winehq.org > > > >

1 0

Re: Need help writing test
by Detlef Riekenberg April 25, 2009

April 25, 2009

Hi Igor > I've found few visual glitches in comctl32/toolbar, and now try to > write this all down as conformance tests, Thanks for your work on comctl32 > TB_SETBITMAPSIZE 20,20 > TB_SETBUTTONSIZE 30,30 > TB_SETBITMAPSIZE 10,10 > > Now, if you do TB_SETBUTTONSIZE, you'll see the difference. builtin > comctl will return 17,16. Native - 30,16. Did you mean TB_GETBUTTONSIZE? Native comctl32 in Wine or native on Windows? Did you test your used size in Windows with different UI settings? ( dpi, Theme) I expect, that you will get a different result. (I will try your code, when I'm back at home) > This test fails, when I test it with native comctl32 (the size is > 17,16). Why could this happen or what am I doing wrong? It's possibele, that Wine can resize the Height (shink to 16) but fail to resize the Width (shrink to 17) When native comctl32 in returns 30,16 in Wine, but 17,16 in Windows, then something outside comctl32 is expected by native comctl32, but missing/wrong in Wine. -- By by ... Detlef ____________________________________________________________________ Psssst! Schon vom neuen WEB.DE MultiMessenger gehört? Der kann`s mit allen: http://www.produkte.web.de/messenger/?did=3123

2 1

Re: [2/2] wininet: HTTP_HttpAddRequestHeadersW should ignore 0-lengthheaders
by Dmitry Timoshkov April 25, 2009

April 25, 2009

"Paul TBBle Hampson" <Paul.Hampson(a)Pobox.com> wrote: > + if (strlenW(lpszStart)==0) > + { > + /* Skip 0-length headers */ > + lpszStart = lpszEnd; > + bSuccess = TRUE; > + continue; > + } Instead of 'if (strlenW(lpszStart)==0)' it's much simpler to do 'if (!*lpszStart)', and move the fix to HTTP_InterpretHttpHeader(). -- Dmitry.

2 1

Re: [1/2] D3D: Limit d3d8 and d3d9 vshader constants to 256
by Henri Verbeet April 24, 2009

April 24, 2009

Not my preferred fix, but I suppose it works. > @@ -359,6 +359,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetDeviceCaps(LPDIRECT3DDEVICE8 iface > if(pCaps->VertexShaderVersion > D3DVS_VERSION(1,1)){ > pCaps->VertexShaderVersion = D3DVS_VERSION(1,1); > } > + pCaps->MaxVertexShaderConst = min(256, pCaps->MaxVertexShaderConst); I think you should use D3D8_MAX_VERTEX_SHADER_CONSTANTF here.

2 1

Re: [1/7] [wined3d] move creation of NP2 fixup uniforms into separate loop (retry)
by Henri Verbeet April 24, 2009

April 24, 2009

2009/4/23 Tobias Jakobi <Liquid.Acid(a)gmx.net>: > ps_np2fixup_t is still stored in ps_compiled_shader and I have no intention to change this, since the ARB code is going to use the exact same structure. NAK

3 5

Re: Dan's dotest reports
by chris ahrendt April 24, 2009

April 24, 2009

André Hentschel wrote: > chris ahrendt schrieb: >> Are the Wine Developers using this report? >> >> Chris >> >> >> >> >> >> >> >> >> > If you are talking about the testsuite(test.winehq.org) then it is not > the only source of information for developers but an important one. > > yes that is what I am talking about... just wanted to make sure that by running the tests on linux the results get used...

2 1

Dan's dotest reports
by chris ahrendt April 24, 2009

April 24, 2009

Are the Wine Developers using this report? Chris

2 1

Re: [1/4] Resend: ws2_32/tests: add tests for Inet_Ntop and inet_ntoa
by Alexandre Julliard April 24, 2009

April 24, 2009

Jeff Latimer <lats(a)yless4u.com.au> writes: > @@ -55,6 +55,9 @@ > ok ( cond tmp, msg, GetCurrentThreadId(), err); \ > } while (0); > > +/* Function pointers */ > +static HMODULE hws2_32 = 0; > +static PCTSTR (WINAPI *pInetNtop)(int,LPVOID,LPTSTR,ULONG) = 0; There's no point in resending if you don't fix the reason it was rejected the first time. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [3/5] wined3d: The first shader token should be the version token.
by Stefan Dösinger April 24, 2009

April 24, 2009

Am Freitag, 24. April 2009 09:21:23 schrieb Henri Verbeet: Did you test this? What if the shader starts with a comment?

2 1

Re: Extensive ScrollDC investigation (resubmit)
by Alexandre Julliard April 24, 2009

April 24, 2009

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -120,13 +122,58 @@ BOOL CDECL X11DRV_ScrollDC( HDC hdc, INT dx, INT dy, const RECT *lprcScroll, > if( TRACE_ON( scroll)) dump_region( "Destination scroll region: ", DstRgn); > /* if there are any, do it */ > if( res > NULLREGION) { > - RECT rect ; > + RECT rect; > + HRGN UpdateClip = CreateRectRgn(0,0,0,0); > + /* Scroll Window does not scroll any already invalid areas */ > + if (GetUpdateRgn(WindowFromDC(hdc),UpdateRgn,FALSE)!=NULLREGION) > + { > + HRGN SrcMask; > + /* Apparently special case. If the update Rgn fills the entire > + DstRgn windows appears to ignore it */ This looks very wrong. Retrieving the update region from a DC doesn't seem right in the first place, and it you have to ignore it in some cases it shows that there's something else going on here. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: Redirector code in Wine?
by Dan Kegel April 24, 2009

April 24, 2009

Kai wrote: > I'm trying to figure out where the wine server actually decides if a file > actually is a file on disk, a local or a remote pipe. Any pointers? Search for FileFsDeviceInformation in ntdll/file.c, maybe.

2 1

Re: richedit: Null terminate streamed out rich text.
by Massimo Del Fedele April 24, 2009

April 24, 2009

Dylan Smith ha scritto: > This can easily be tested by saving a rich text document in wordpad. The > rich text will always be null terminated, unlike plain text files which > will not have a terminating null byte. > > I noticed in a bug 14827 that AutoCAD 2005 looked for this NULL byte to > determine the length of the rich text in its EditStreamCallback function > given to EM_STREAMOUT, instead of using the cb parameter that provides > the length. > --- > dlls/riched20/writer.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > The patch is right (IMHO) but AutoCAD bug 14827 is still present, I guess it's another issue probably related to \fonttbl streaming out. Ciao Max

1 0

NetBSD compiler warnings patches - review request
by Austin English April 24, 2009

April 24, 2009

Howdy, I recently started retesting NetBSD (5.0 this time), and have filed bugs for most of the warnings. A few of them I have patches ready for, but figured I should probably get reviewed first: First up, bug 18161: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -I/usr/pkg/include -I/usr/include -I/usr/X11R7/include/freetype2 -I/usr/X11R7/include -O2 -I/usr/pkg/include -I/usr/include -I/usr/X11R7/include/freetype2 -I/usr/X11R7/include -o cdrom.o cdrom.c cdrom.c: In function 'CDROM_DeviceIoControl': cdrom.c:1728: warning: 'lun' may be used uninitialized in this function cdrom.c:1728: warning: 'targetid' may be used uninitialized in this function cdrom.c:1728: warning: 'busid' may be used uninitialized in this function cdrom.c:1728: warning: 'portnum' may be used uninitialized in this function Fixed by cdrom.txt Bug 18162: gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -I/usr/pkg/include -I/usr/include -I/usr/X11R7/include/freetype2 -I/usr/X11R7/include -O2 -I/usr/pkg/include -I/usr/include -I/usr/X11R7/include/freetype2 -I/usr/X11R7/include -o treeview.o treeview.c treeview.c: In function 'TestCallback': treeview.c:279: warning: value computed is not used treeview.c:304: warning: value computed is not used treeview.c:313: warning: value computed is not used treeview.c:322: warning: value computed is not used treeview.c: In function 'TestExpandInvisible': treeview.c:769: warning: value computed is not used Fixed by treeview.txt. Also tested on windows 2k, test still passes. Bug 18165: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -I/usr/pkg/include -I/usr/include -I/usr/X11R7/include/f reetype2 -I/usr/X11R7/include -O2 -I/usr/pkg/include -I/usr/include -I/usr/X11R7/include/freetype2 -I/usr/X11R7/include -o net.o net.c net.c: In function 'netconn_init': net.c:243: warning: assignment discards qualifiers from pointer target type Fixed by winhttp.txt. Also fixes a similar problem in wininet/netconnection.c Bug 18166: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -I/usr/pkg/include -I/usr/include -I/usr/X11R7/include/freetype2 -I/usr/X11R7/include -O2 -I/usr/pkg/include -I/usr/include -I/usr/X11R7/include/freetype2 -I/usr/X11R7/include -o directory.o directory.c directory.c: In function 'wine_getdirentries': directory.c:1289: warning: implicit declaration of function 'getdirentries' There's a NetBSD bug here. Their version of getdirentries returns the old 32-bit inode struct dirent, while dirent.h has the new 64-bit inode struct dirent inode since NetBSD version 3.99.8. While it arguably should be fixed on their end, we already have a wrapper in there for an OS X bug... directory.txt fixes it. -- -Austin

3 2

Redirector code in Wine?
by Kai Blin April 24, 2009

April 24, 2009

Hi folks, I'm trying to figure out where the wine server actually decides if a file actually is a file on disk, a local or a remote pipe. Any pointers? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 1

Re: [1/5] WineD3D: Support the full amount of constants in GLSL
by Alexandre Julliard April 23, 2009

April 23, 2009

Stefan Dösinger <stefan(a)codeweavers.com> writes: > Am Mittwoch, 22. April 2009 21:03:41 schrieb Stefan Dösinger: > Use this patch instead. Henri spotted some missing parentheses in the code It doesn't work here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:8782: Tests skipped: D3DFMT_G16R16F textures not supported visual.c:8782: Tests skipped: D3DFMT_G32R32F textures not supported visual.c:7572: Tests skipped: Card has unconditional pow2 support, skipping conditional NP2 tests fixme:d3d_shader:print_glsl_info_log Error received from GLSL shader #4: "Vertex info\n-----------\nInternal error: assembly compile error for vertex shader at offset 42905:\n-- error message --\nline 1063, column 1: error: too many program parameters\n-- internal assembly text --\n!!NVvp4.0\n# cgc version 2.1.0000, build date Nov 4 2008\n# command line args: \n#vendor N"... fixme:d3d_shader:set_glsl_shader_program >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from Find glsl program uniform locations @ glsl_shader.c / 3613 fixme:d3d_shader:set_glsl_shader_program >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB(programId) @ glsl_shader.c / 3627 fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3758 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 visual.c:744: Test failed: Expected color 00ffff00, got 00000000 (for input -2.400000, instruction mova) fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3758 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 visual.c:744: Test failed: Expected color 00ffff00, got 00000000 (for input -1.600000, instruction mova) fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3758 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 visual.c:744: Test failed: Expected color 0000ffff, got 00000000 (for input -0.400000, instruction mova) fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3758 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 visual.c:744: Test failed: Expected color 0000ffff, got 00000000 (for input 0.400000, instruction mova) fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3758 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 visual.c:744: Test failed: Expected color 00ff00ff, got 00000000 (for input 1.600000, instruction mova) fixme:d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgramObjectARB @ glsl_shader.c / 3758 fixme:d3d_shader:shader_glsl_load_constants >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUniform4fvARB @ glsl_shader.c / 574 visual.c:744: Test failed: Expected color 00ff00ff, got 00000000 (for input 2.400000, instruction mova) visual.c:8643: Tests skipped: Only 1 simultaneous render target supported, skipping MRT test make[2]: *** [visual.ok] Error 6 -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: ole32: CoGetTreatAsClass should return S_FALSE if it cannot even find the key for the requested CLSID
by Paul Vriens April 23, 2009

April 23, 2009

Aric Stewart wrote: > > Fixes issues with IE7 involving constant prompting to click to run > ActiveX controls when none are present > Includes test > --- > dlls/ole32/compobj.c | 3 +++ > dlls/ole32/tests/compobj.c | 18 ++++++++++++++++++ > 2 files changed, 21 insertions(+), 0 deletions(-) > > > > ------------------------------------------------------------------------ > > Wouldn't it be better to use some other GUID here: + hr = pCoGetTreatAsClass(&GUID_NULL,&out); + ok (hr == S_FALSE, "expected S_FALSE got %x\n",hr); + ok (IsEqualGUID(&out,&GUID_NULL), "expected to get same clsid back\n"); That way we would know if Windows indeed leaves the clsid alone or returns the NULL GUID? Something like: static GUID deadbeef = {0xdeadbeef,0xdead,0xbeef,{0xde,0xad,0xbe,0xef,0xde,0xad,0xbe,0xef}}; -- Cheers, Paul.

2 1

Re: wined3d: Avoid using an implicit value to set fogcoord to 0.0.
by Stefan Dösinger April 23, 2009

April 23, 2009

This patch looks ok. I have the same patch in my send queue, but it seems Francois was quicker with sending it

1 0

Re: [PATCH 1/2] ole32: Register the clipboard formats at load time.
by Alexandre Julliard April 23, 2009

April 23, 2009

Huw Davies <huw(a)codeweavers.com> writes: > --- > dlls/ole32/clipboard.c | 54 +++++++++++++++++++++++++++++------------ > dlls/ole32/compobj.c | 2 + > dlls/ole32/compobj_private.h | 14 +++++++++++ > 3 files changed, 54 insertions(+), 16 deletions(-) It would be nicer to do this when needed, so that we don't have to initialize the graphics driver just because ole32 was imported. -- Alexandre Julliard julliard(a)winehq.org

2 1

[PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString
by Giuseppe Bilotta April 23, 2009

April 23, 2009

Trying to add a separator with an invalid pointer in iString to a toolbar works in Windows, showing that the field is ignored. --- dlls/comctl32/tests/toolbar.c | 51 +++++++++++++++++++++++++++++++++++++++++ 1 files changed, 51 insertions(+), 0 deletions(-) diff --git a/dlls/comctl32/tests/toolbar.c b/dlls/comctl32/tests/toolbar.c index 1946095..91a72e0 100644 --- a/dlls/comctl32/tests/toolbar.c +++ b/dlls/comctl32/tests/toolbar.c @@ -1300,6 +1300,56 @@ static void test_getstring(void) DestroyWindow(hToolbar); } +static void test_deadbeef(void) +{ + HWND hToolbar = NULL; + TBBUTTON buttons[2]; + INT r; + + rebuild_toolbar_with_buttons(&hToolbar); + + ZeroMemory(&buttons, sizeof(buttons)); + + /* Some programs (e.g. Graphmatica 2.0f) forget to initialize the iString + * field for separators. If the random bit pattern of this field looks like + * a pointer, trying to follow it casues a crash (pagefault). This does not + * happen in Windows XP, 2008 or Vista, suggesting that this field is + * ignored in Windows in this case. */ + buttons[0].idCommand = 0; + buttons[0].fsStyle = BTNS_SEP; + buttons[0].fsState = TBSTATE_ENABLED; + buttons[0].iString = 0xdeadbeef; + +#if 0 + /* It is also possible that a poorly written program doesn't initialize the + * iString field of an actual button. Different versions of Windows seem to + * operate differently in this case. + * + Windows XP doesn't seem to be bothered in the least + * + Windows 2008 crashes + * + Windows Vista does not crash, but the subsequent TB_ADDBUTTONS + * call fails + * Since I know of no program that suffers from this particular issue, I'm + * commenting out this part of the test for the time being. If it gets + * uncommented, the subsequent TB_ADDBUTTONS should be adjusted + * appropriately. */ + + buttons[1].idCommand = 1; + buttons[1].fsStyle = BTNS_BUTTON; + buttons[1].fsState = 0; + buttons[1].iString = 0xdeadbeef; +#endif + + r = SendMessage(hToolbar, TB_ADDBUTTONS, 1, (LPARAM)buttons); + expect(1, r); + + /* TODO: another test that might be worth doing, to get more insight on how + * Windows handles things, would be to introduce a separator with + * 0xdeadbeef as iString, and then change its style to make into a real + * button. */ + + DestroyWindow(hToolbar); +} + START_TEST(toolbar) { WNDCLASSA wc; @@ -1336,6 +1386,7 @@ START_TEST(toolbar) test_dispinfo(); test_setrows(); test_getstring(); + test_deadbeef(); PostQuitMessage(0); while(GetMessageA(&msg,0,0,0)) { -- 1.6.2.254.g84bde

3 8

Re: [mshtml] Fix the size passed to MultiByteToWideChar for real
by Dmitry Timoshkov April 23, 2009

April 23, 2009

"Colin Finck" <mail(a)colinfinck.de> wrote: wrote: > @@ -425,6 +425,7 @@ static LPWSTR get_url(void) > HKEY hkey; > DWORD res, type; > DWORD size = INTERNET_MAX_URL_LENGTH*sizeof(WCHAR); > + DWORD returned_size; > LPWSTR url; > > static const WCHAR wszGeckoUrl[] = {'G','e','c','k','o','U','r','l',0}; > @@ -438,14 +439,14 @@ static LPWSTR get_url(void) > > > url = heap_alloc(size); > > - res = RegQueryValueExW(hkey, wszGeckoUrl, NULL, &type, (LPBYTE)url, &size); > + res = RegQueryValueExW(hkey, wszGeckoUrl, NULL, &type, (LPBYTE)url, &returned_size); returned_size must be intialized first. -- Dmitry.

2 1

Re: kernel32/tests: Added last error tests for GetPrivateProfileString
by Paul Vriens April 23, 2009

April 23, 2009

Dmitry Kislyuk wrote: > > Any particular reason for adding these tests? Is there an app depending on the last error? -- Cheers, Paul.

1 0

[7/7] [wined3d] correct now faulty comment (review)
by Tobias Jakobi April 22, 2009

April 22, 2009

-- Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger01

1 0

[6/7] [wined3d] force constant reload for NP2 fixup in shader_arb_select (review)
by Tobias Jakobi April 22, 2009

April 22, 2009

-- Neu: GMX FreeDSL Komplettanschluss mit DSL 6.000 Flatrate + Telefonanschluss für nur 17,95 Euro/mtl.!* http://dslspecial.gmx.de/freedsl-surfflat/?ac=OM.AD.PD003K11308T4569a

1 0

[5/7] [wined3d] remove comment about np2fixup not implemented for ARB mode (review)
by Tobias Jakobi April 22, 2009

April 22, 2009

-- Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger01

1 0

[4/7] [wined3d] implement shader_arb_load_np2fixup_constants (review)
by Tobias Jakobi April 22, 2009

April 22, 2009

-- Neu: GMX FreeDSL Komplettanschluss mit DSL 6.000 Flatrate + Telefonanschluss für nur 17,95 Euro/mtl.!* http://dslspecial.gmx.de/freedsl-surfflat/?ac=OM.AD.PD003K11308T4569a

1 0

[3/7] [wined3d] shader_hw_sample: add NP2 fixup code (review)
by Tobias Jakobi April 22, 2009

April 22, 2009

-- Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger01

1 0

[2/7] [wined3d] shader_generate_arb_declarations: add NP2 fixup code (review)
by Tobias Jakobi April 22, 2009

April 22, 2009

-- Neu: GMX FreeDSL Komplettanschluss mit DSL 6.000 Flatrate + Telefonanschluss für nur 17,95 Euro/mtl.!* http://dslspecial.gmx.de/freedsl-surfflat/?ac=OM.AD.PD003K11308T4569a

1 0

Re: [4/4] (Try2) msi/tests: Fix package test when run on a different drive than C:\.
by James Hawkins April 22, 2009

April 22, 2009

On Wed, Apr 22, 2009 at 12:05 PM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: > Try2: Use helper function added in second patch, as suggested by James. > > This one finally fixes current relative path test to expect correct > value. > This version isn't using a helper function. Please thoroughly go over your patches before submitting them. Your subject says try2, but I know it's been more than that, so we've seen at least 12-16 emails/patches for this set now. -- James Hawkins

2 2

Re: [1/7] [wined3d] add ps_np2fixup_t struct to ps_compiled_shader
by Henri Verbeet April 22, 2009

April 22, 2009

2009/4/21 Tobias Jakobi <liquid.acid(a)gmx.net>: > +struct ps_np2fixup_t { > + unsigned char idx[MAX_FRAGMENT_SAMPLERS]; /* indices to the real constant */ > + GLfloat* const_cache; /* constant cache for fast reloading (without readback) */ > + WORD swz; /* bitfield used to determine if we have to swizzle the constant */ > + WORD num_consts; > +}; > + - I'm sure I mentioned this before, but please don't add code without using it. - Why is this in struct ps_compiled_shader? This really looks like something that should be internal to the backend. - What is the point of const_cache? - Writing "GLfloat* const_cache;" is legal C, but really doesn't make a lot of sense. The * is part of the declarator rather than the base type. An example like "int* p, q;" should make this more obvious. - swz is redundant. "prog->np2Fixup_data->swz & (1 << i)" really isn't more efficient than "idx & 1"

3 7

Re: [1/7] [wined3d] add ps_np2fixup_t struct to ps_compiled_shader
by Stefan Dösinger April 22, 2009

April 22, 2009

Am Dienstag, 21. April 2009 23:37:51 schrieb Tobias Jakobi: > + unsigned char idx[MAX_FRAGMENT_SAMPLERS]; /* indices to the real constant */ I don't remember how you plan to use the ps_np2fixup_t structure in the ARB backend, but an unsigned char might turn out to be too limited if you end up storing ARB constant numbers in there, since cards can have more than 256 constants. For your GLSL code it is good enough because you just store values from 1-8.

2 2

Re: [1/2] comctl32/listview: Additional tests for LVM_GETSUBITEMRECT
by Paul Vriens April 22, 2009

April 22, 2009

Nikolay Sivov wrote: > Changelog: > - Additional tests for LVM_GETSUBITEMRECT > >>From 2f2cb8e54b81ff6be7229b7931945a3bb76f4bde Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <bunglehead(a)gmail.com> > Date: Wed, 22 Apr 2009 13:05:56 -0400 > Subject: Additional tests for LVM_GETSUBITEMRECT > > --- > dlls/comctl32/tests/listview.c | 41 ++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 41 insertions(+), 0 deletions(-) > > diff --git a/dlls/comctl32/tests/listview.c b/dlls/comctl32/tests/listview.c > index 6f205fd..fba7a01 100644 > --- a/dlls/comctl32/tests/listview.c > +++ b/dlls/comctl32/tests/listview.c > @@ -847,6 +847,7 @@ static void test_create(void) > LONG_PTR ret; > LONG r; > LVCOLUMNA col; > + RECT rect; > WNDCLASSEX cls; > cls.cbSize = sizeof(WNDCLASSEX); > ok(GetClassInfoEx(GetModuleHandle(NULL), "SysListView32", &cls), "GetClassInfoEx failed\n"); > @@ -976,6 +977,31 @@ static void test_create(void) > ok(IsWindow(hHeader), "Header should be created\n"); > ok(hHeader == GetDlgItem(hList, 0), "Expected header as dialog item\n"); > DestroyWindow(hList); > + > + /* requesting header info with LVM_GETSUBITEMRECT doesn't create it */ > + hList = CreateWindow("SysListView32", "Test", LVS_REPORT, 0, 0, 100, 100, NULL, NULL, > + GetModuleHandle(NULL), 0); > + ok(!IsWindow(hHeader), "Header shouldn't be created\n"); > + ok(NULL == GetDlgItem(hList, 0), "NULL dialog item expected\n"); > + > + rect.left = LVIR_BOUNDS; > + rect.top = 1; > + rect.right = rect.bottom = -10; > + r = SendMessage(hList, LVM_GETSUBITEMRECT, -1, (LPARAM)&rect); > +todo_wine > + ok(r != 0, "Expected not-null LRESULT\n"); > + > + hHeader = (HWND)SendMessage(hList, LVM_GETHEADER, 0, 0); > + ok(!IsWindow(hHeader), "Header shouldn't be created\n"); > + ok(NULL == GetDlgItem(hList, 0), "NULL dialog item expected\n"); > + > + expect(0, rect.left); > +todo_wine { > + expect(0, rect.right); > + expect(0, rect.top); These first 3 seems to fail on everything from W2K downwards. Could you have a look? -- Cheers, Paul.

2 3

Remote named pipes and stuff.
by Kai Blin April 22, 2009

April 22, 2009

Hi folks, I'm at SambaXP again, and so of course the cifs Kernel driver folks talked to me about the named pipe implementation. It seems like they are still trying to figure out how this could be implemented in the cleanest way. However, Jeff Layton asked me about a use case, and I have to admit I can't think of one off the top of my head. So, what application do we have that fails to work due to the lack of remote named pipes? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 1