April 2009 - Wine-Devel - list.winehq.org

re: Remote named pipes and stuff.
by Dan Kegel April 22, 2009

April 22, 2009

Kai asked: > Is there a use case for remote named pipes? http://support.microsoft.com/kb/q238949/ shows that SQL Server supports named pipes as an access method. Some apps or sites might assume that works, and not be able to use TCP/IP for this. Google finds at least three examples of people wanting to used named pipes in previous wine threads: http://groups.google.com/group/comp.emulators.ms-windows.wine/msg/06fbfdfb5… "I'm trying to run a Delphi application on Wine. The application uses BDE to talk to a MSSQL server, but database communication does not work. Enable debugging i see this error message: warn:file:wine_nt_to_unix_file_name L"SRVCAF1\\pipe\\sql\\query" not found in ...dosdevices/unc warn:ntdll:NtCreateFile L"\\??\\UNC\\SRVCAF1\\pipe\\sql\\query" not found (c000003a) warn:file:CreateFileW Unable to create file L"\\\\SRVCAF1\\pipe\\sql\ \query" (status c000003a) Is this UNC pipe supposed to work on Wine? " (I think you even replied to that thread :-) http://groups.google.com/group/comp.emulators.ms-windows.wine/msg/e7323dfa9… "I am trying to connect a client with named pipes to a remote server. Using the kernel32 function CreateFile I get the folling message: fixme:file:wine_nt_to_unix_file_name UNC name L"\\??\\UNC\\192.168.1.157\\pipe\\Archiv\\Server" not supported I am using Wine20040505. Is the anybody out there who can help? To be frank, I am a rooky using wine an Linux, but... ;o) " http://groups.google.com/group/comp.emulators.ms-windows.wine/msg/a3d22d752… "[Outlook seems to use a named pipe to connect to Exchange: fixme:win32:WaitNamedPipeA \\EXCH_CTL2\pipe\epmapper 0x00000000 "] So, there you have it. Databases, Microsoft Exchange, and the like seem to like using remote named pipes. - Dan

1 0

[PATCH] comctl32/toolbar.c: fix trace info for TOOLBAR_InternalInsertButtonsT
by Giuseppe Bilotta April 22, 2009

April 22, 2009

TOOLBAR_DumpTBButton should be invoked over the button currently being inserted, and not always over the first button. --- dlls/comctl32/toolbar.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/comctl32/toolbar.c b/dlls/comctl32/toolbar.c index cf54df7..851a5cc 100644 --- a/dlls/comctl32/toolbar.c +++ b/dlls/comctl32/toolbar.c @@ -1832,7 +1832,7 @@ TOOLBAR_InternalInsertButtonsT(TOOLBAR_INFO *infoPtr, INT iIndex, UINT nAddButto for (iButton = 0; iButton < nAddButtons; iButton++) { TBUTTON_INFO *btnPtr = &infoPtr->buttons[iIndex + iButton]; - TOOLBAR_DumpTBButton(lpTbb, fUnicode); + TOOLBAR_DumpTBButton(lpTbb + iButton, fUnicode); ZeroMemory(btnPtr, sizeof(*btnPtr)); -- 1.6.2.254.g84bde

1 0

Re: Article on wine development strategy
by Scott Ritchie April 22, 2009

April 22, 2009

Vincent Povirk wrote: > Your model makes bugs that show up in only a few applications very > rare. I've added some to your existing model with duct tape. I > arbitrarily decided that about 40% of apps would have 1 or 2 unique > bugs, in addition to the current ones. > You can better model this by just changing the probability distribution of the various bugs and using the "alternate" method where each bug has an absolute probability of affecting a given app. Then make about 1000 bugs have .05% probability or so, and odds are most of them will only affect one or two apps (if you have 2500 you're modelling) > The result is an exponential curve, until about 80% of apps are > solved. After that, the curve is linear. > > This makes a sort of sense. If we do it right, we're likely to fix the > bugs that affect a lot of apps before we finish with the ones that > affect one or two. Once the major bugs are fixed, Wine and Windows > become comparable to a more "normal" set of different interface > implementations: largely compatible, but a few developers will > continue finding subtle differences to rely on forever. The rate at > which apps hit these differences should be fairly consistent. > > I do wish I had a better way to do this than tacking it on to the > existing stuff. I think I broke pickNextBug, but fortunately that's > unused until all apps are solved. > > If you increased the number of very rare (1 or 2 apps) bugs in a less > crappy way, it might show something smoother. > I'll try my suggested method now. > I have a feeling that in general the exact shape depends mostly on how > likely it is for a bug to occur in multiple apps and on how many bugs > each app has. If a typical app has only a few bugs (the constants > you've chosen imply that it doesn't), things look very nice at the > start. If a typical bug affects many apps (the constants you've chosen > imply that it does), things look very nice at the end. > Yeah, I'll note that whether a typical app has a few bugs or a lot of bugs to start with depends on whether we want to model "from the start" or from here on out. Thanks, Scott Ritchie

1 0

Re: msvcrt/tests : add some tests for strtok()
by Alexandre Julliard April 22, 2009

April 22, 2009

Rein Klazes <wijn(a)online.nl> writes: > - pmemcpy(mem+5, mem,nLen+1); > - ok(pmemcmp(mem+5,xilstring, nLen) == 0, > - "Got result %s\n",mem+5); > + if( pmemcpy) { > + pmemcpy(mem+5, mem,nLen+1); > + ok(pmemcmp(mem+5,xilstring, nLen) == 0, > + "Got result %s\n",mem+5); > + } else > + skip("memcpy not found\n"); I doubt any version of the dll is missing memcpy, and even so that should be a separate patch. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: comctl32: TOOLBAR_SetImageList should recalulate toolbar only if it is necessary
by Alexandre Julliard April 22, 2009

April 22, 2009

Igor Tarasov <tarasov.igor(a)gmail.com> writes: > Forgot the patch :) > > 2009/4/19 Igor Tarasov <tarasov.igor(a)gmail.com>: >> Currently TOOLBAR_SetImageList recalculates toolbar and button sizes >> even if there is no need in this (when new image list bitmap sizes are >> equal to toolbar bitmap sizes). This overwrites button sizes that >> might have been defined by application, and thus leads to visual >> glitches. Native comctl does not change any toolbar sizes on >> TB_SETIMAGELIST when bitmap size is the same. It doesn't work here: ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so toolbar.c && touch toolbar.ok toolbar.c:934: Test failed: Unexpected button size toolbar.c:936: Test failed: Unexpected button size toolbar.c:944: Test failed: Unexpected button size toolbar.c:946: Test failed: invalid rect (button) (0,2) (163,40) - expected (0,2) (163,26) toolbar.c:946: Test failed: invalid rect (button) (163,2) (326,40) - expected (163,2) (326,26) toolbar.c:946: Test failed: invalid rect (button) (326,2) (489,40) - expected (326,2) (489,26) toolbar.c:946: Test failed: invalid rect (button) (489,2) (652,40) - expected (489,2) (652,26) toolbar.c:946: Test failed: invalid rect (button) (652,2) (819,40) - expected (652,2) (819,26) toolbar.c:946: Test failed: invalid rect (button) (819,2) (850,40) - expected (819,2) (850,26) toolbar.c:949: Test failed: invalid rect (button) (0,2) (163,40) - expected (0,0) (163,38) toolbar.c:949: Test failed: invalid rect (button) (163,2) (326,40) - expected (163,0) (326,38) toolbar.c:949: Test failed: invalid rect (button) (326,2) (489,40) - expected (326,0) (489,38) toolbar.c:949: Test failed: invalid rect (button) (489,2) (652,40) - expected (489,0) (652,38) make[2]: *** [toolbar.ok] Error 13 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [4/4] msi/tests: Fix package test when run on a different drive than C:\.
by James Hawkins April 21, 2009

April 21, 2009

On Tue, Apr 21, 2009 at 2:30 PM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: > This one finally fixes current relative path test to expect correct > value. > + drives = GetLogicalDrives(); + lstrcpyA(path, "A:\\"); + for (i = 0; i < 26; path[0] = '\0', i++) + { + if (!(drives & (1 << i))) + continue; + + path[0] = 'A' + i; + if (GetDriveType(path) != DRIVE_FIXED) + continue; + + lstrcatA(path + 3, CURR_DIR + 3); + attr = GetFileAttributesA(path); + if (attr != INVALID_FILE_ATTRIBUTES && (attr & FILE_ATTRIBUTE_DIRECTORY)) + { + if (path[lstrlenA(path)-1] != '\\') + lstrcatA(path, "\\"); + break; + } + path[3] = '\0'; + } Same as 2/4. Please refactor and add many nice comments detailing exactly what is happening in native msi to make this necessary. -- James Hawkins

2 2

Changing the language that wine runs in (testing language versions of dialogs)
by Reece Dunn April 21, 2009

April 21, 2009

Hi, Looking at http://bugs.winehq.org/show_bug.cgi?id=18125, it has winecfg from wine 1.1.19 running in Spanish. The screenshot shows that the static text is wrapped over 4 lines, but the text is clipped (should be 8x4 dlus high). This is not the issue reported there, but I would like to fix it and improve the layout. So, how do I change locale? Especially from a just-built version of Wine. I have tried: LANG=es ./wine winecfg LANG=es.UTF-8 ./wine winecfg LC_ALL=es ./wine winecfg LC_ALL=es.UTF-8 ./wine winecfg and export LANG=es && ./wine winecfg variants. I have also tried changing the system regional and language settings. None of these have worked. It's not on the FAQ either. I am using Kubuntu 9.04. Thanks, - Reece

5 6

Re: [2/4] msi/tests: Add empty dir test for the DrLocator part of the AppSearch action.
by James Hawkins April 21, 2009

April 21, 2009

On Tue, Apr 21, 2009 at 2:30 PM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: > This patch adds a test to demonstrate current wrong behaviour in case of > an empty path, it is basically there to validate last patch of the > series that change relative path test behaviour (i.e. expected values), > as it seems it was rejected because it wasn't backed up by a previous > test. > + drives = GetLogicalDrives(); + lstrcpyA(path, "A:\\"); + for (i = 0; i < 26; i++) + { + if ((drives & (1 << i))) + { + path[0] = 'A' + i; + + if (GetDriveType(path) == DRIVE_FIXED) + break; + } + path[0] = '\0'; + } Please refactor this into a helper function. A comment describing exactly what is being tested and why this bit of code is needed would be beneficial. -- James Hawkins

1 0

Re: dsound: Allow a special cbSize case in CreateSoundBuffer (updated)
by Detlef Riekenberg April 21, 2009

April 21, 2009

On Mo, 2009-04-20 at 21:51 -0700, Jesse Allen wrote: > In CreateSoundBuffer, some apps pass sizeof(WAVEFORMATEXTENSIBLE) for > the cbSize and we have to allow it, but only when the SubFormat is > KSDATAFORMAT_SUBTYPE_PCM. > > This updated patch is simpler... at the expense of being less clear ;) > > Includes test cases which were verified on WinXP. > Fixes bug #11716 Hi Jesse. Your patch introduced failures for the dsound-test on some systems with win98, w2k and w2k3. ( http://test.winehq.org/data/tests/dsound:dsound8.html ) Can you please take a look? Thanks -- By by ... Detlef

1 0

Win64 keyword?
by Austin English April 21, 2009

April 21, 2009

Howdy, Seems quite a few bugs have been filed recently about our win64 support. While setting the hardware to PC-X86-64 describes the hardware accurately, it doesn't really tell us if the user is running 32 bit wine or 64 bit wine on their 64 bit OS. We've already got a win16 keyword, so how about a win64 keyword to make searching for these bugs easier? -- -Austin

2 1

DIB Engine - New approach
by Massimo Del Fedele April 21, 2009

April 21, 2009

The approach taken so far consisted in having 2 device pointers inside GDI32, one for dib engine and the other for normal display driver. This way had the disadvantage of having to keep in sync the DC with the right driver depending on selected bitmap, which lead to many small changes spread along all gdi code; going deeper with development this approach showed many limits and problems. So I decided to start again from scratch with a completely different approach which is giving good results and is quite less invasive on gdi32 code. Instead of doing : -- DIB ENGINE / GDI32 --- \ -- X11 DRIVER I took this approach : GDI32 -- DIB ENGINE -- X11 DRIVER The (X11) display driver is loaded from inside the engine, which replaces it from gdi32 point of view. The changes in gdi32 are *very* limited, just in driver.c code, making it to load (if desired) the engine instead of normal x11 driver. No other changes needed. I added as usual the code allowing to enable/disable the engine on request by registry and/or environment variable. If the engine is not present or disabled, the driver loader falls back to usual behaviour. The Engine then loads the X11 driver in init phase and acts as a gate depending on selected BMP, forwarding to X11 driver all requests for DDB bitmaps and doing the job itself for DIB ones. This approach showed many advantages, and I' almost ready converting all old code to it. By now I'm posting here 3 patches showing the approach; the posted driver is a simple pass-throu one, so it just forwards all calls to X11 driver. The last patch of the series shows the forking behaviour of DIB/DDB processing from inside the engine, but still forwarding all to X11. I'd like some comments on the approach taken; on next days I'll post a more complete code with most of the engine implemented. Ciao Max

3 5

Re: [1/5]msctf/test: setup test framework for ITfThreadMgrEventSink
by Alexandre Julliard April 21, 2009

April 21, 2009

Aric Stewart <aric(a)codeweavers.com> writes: > +static HRESULT WINAPI ThreadMgrEventSink_OnInitDocumentMgr(ITfThreadMgrEventSink *iface, > +ITfDocumentMgr *pdim) > +{ > + trace("%s\n",__FUNCTION__); > + return S_OK; > +} trace() already includes the file and line, and __FUNCTION__ is not portable, please avoid it in tests. -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine patch code review or what to do if patches get stuck?
by Igor Tarasov April 21, 2009

April 21, 2009

Hi! The reason of why I write this to you is simple: my patches have stuck again and I don't know what to do. But since this happening not with me only and not this happens regularly, I have thought about looking at the problem a bit wider. Is there any code review system for patches that are sent to wine-patches? Or just some developers monitor wine-patches and say something if they have something to say? Or, how does Alexander make decisions regarding committing patches? I've been thinking about some kind of web-based system, like one used at http://codereview.chromium.org/ It would be nice, if there was sime kind of bot, that would grab all patches from wine-patches, sort them, make some initial analysis (maybe, run local test git repository, make various tests, check that threre are no conflicts, check code style (at least whitespace changes) etc). Then it could set a flag and report back to the sender. For instance it would flag "tests fail" and send details back to sender. Or "whitespace change detected" and send back the quoted diff parts. Then, somebody of developers might review it and put his mark/comments that would go to wine-devel (if necessary), or to sender directly. There could be simple templates for test reviews for common problems, and tags, such as "sure?" that means, that more explanations are needed why that implementation is correct. "too hackish" that means that style or code itself is of bad quality. "whitespace" whitespacechange detected. "tests required" tests are really required for this patch to go in. "okay", means that reviewer recommends the patch for commitment. "wrong", means that patch is totally wrong ..etc Some of these tags mean that report goes directly to developer, and patch is marked as obsolete, others make system send some feedback to wine-dev. It would take just few clicks for reviewer to get it done. This would provide good feedback, also this would help the one who makes the decisions to see that others have already checked that patch and what they think about that. Sometimes "no feedback" means that you just dont know - is there something wrong? Or maybe your patch wos not understood correctly? Or there are doubts that what you did is right? Or what? It would be better to have feedback like "are you serious?" than nothing at all :) P.S: the patches in question are http://www.winehq.org/pipermail/wine-patches/2009-April/072009.html and http://www.winehq.org/pipermail/wine-patches/2009-April/072013.html . They both are soo simple, that I even don't know how to ask of what's wrong with them :) -- Igor

5 6

Re: [1/2](try 2)msctf: helper functions for generating DWORD cookies
by Alexandre Julliard April 21, 2009

April 21, 2009

Aric Stewart <aric(a)codeweavers.com> writes: > + else if (id_last == array_size) > + { > + CookieInternal **new_cookies = NULL; > + new_cookies = HeapReAlloc(GetProcessHeap(),0,cookies,sizeof(CookieInternal*) * (array_size * 2)); > + if (!new_cookies) > + { > + array_size = 0; > + ERR("Out of memory, Unable to realloc cookies array\n"); > + return 0x0; > + } > + cookies = new_cookies; > + array_size *= 2; > + } > + > + /* try to reuse IDs if possible */ > + for (i = 0; i < id_last; i++) > + if (cookies[i] == NULL) break; It would be smarter to reuse the ID before growing the array. Also you could mark free entries with a 0 id or something like that, and avoid a level of indirection (and some memory leaks...) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [kernel32] add unittests for registry keys of serial ports
by Alexandre Julliard April 21, 2009

April 21, 2009

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > + RegOpenKeyA(HKEY_LOCAL_MACHINE, "Hardware\\Description\\System", &desc_sys); > + RegOpenKeyA(HKEY_LOCAL_MACHINE, "Hardware\\Devicemap\\Serialcomm", &sercom); > + RegOpenKeyA(HKEY_LOCAL_MACHINE, "Software\\Microsoft\\Windows NT\\CurrentVersion\\Ports", &sw_ports); You need to check for failure and handle it properly. I doubt you'll be able to open these keys on Win9x for instance. > + result = RegOpenKeyA(HKEY_LOCAL_MACHINE, "System\\Select", &sub_key1); > + if(ERROR_SUCCESS == result) { > + size = sizeof(count1); > + result = RegQueryValueExA( sub_key1, "Current", NULL, NULL, (LPBYTE) &count1, &size); > + RegCloseKey(sub_key1); > + } > + if(ERROR_SUCCESS == result) { > + sprintf(sub_key1_name, "System\\ControlSet%03d\\Enum\\ACPI", count1); > + RegOpenKeyA(HKEY_LOCAL_MACHINE, sub_key1_name, &acpi); > + } Do you really have an app that accesses ControlSetxxx directly? CurrentControlSet is a lot easier to work with. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Possible regression today's git wine-1.1.19-153-g55ad3fd
by Susan Cragin April 21, 2009

April 21, 2009

>>>>>Ohhh... got a nice crash after a re-boot. >>>> >>>> Never mind that. This looks more promising. At least, to me it does. The actctx error I get all the time, but I've never seen the other, and it happend right as the system froze up. >>>> >>>> fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.VC80.MFCLOC" (8.0.50608.0) >>>> err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Broken pipe >>>> err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Broken pipe >>>> err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Broken pipe >>>> err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Success >>> >>> Interesting. You are running Ubuntu studio 8.10 without pulseaudio, right? >>> >>> Have you updated the system between version runs (that may have >>> reintroduced pulseaudio, for example)? >>> >>> Are you running any other sound applications (or the sound that is >>> played after boot on Ubuntu)? >>> >>> Could you perform a git bisect to identify the guilty change? >> >>Doing some investigation, I have found >>(http://alsa.opensrc.org/index.php/HowTo_Asynchronous_Playback) >>""" >>That is basically all there is to the callback. Note however, that >>this example does not include error checking, which is a good idea of >>course. Occasionally, you may have to restore from a buffer under-run, >>in case the computer was caught up in some other process and didn't >>get to calling your callback. Whenever this happens, the first >>operation you perform on the device, in this case >>snd_pcm_avail_update, will return -EPIPE (a 'Broken Pipe' error). You >>can restore from this by calling the snd_pcm_prepare function again. >>""" >> >>This may be what you are experiencing here. I'd need to look into this >>further, but to be honest, I'm a little out of depth with the Windows >>and Wine sound interfaces. >> >>- Reece > >Reece: >I purged pulseaudio and checked that it had not been re-installed. I run Ubuntu 9.04 with all updates. I also use a test version of alsa-driver since my sound card is difficult to recognize but so far have had only great results -- no impact on wine at all. >The problem I am experiencing manifests itself in the program freezing... could be the sound, could also be the buttons doing something odd. One button's on-off toggle switches suddenly with no input on my part. >Regression test is below. >Susan > >b958dfdc4769515c0ef56c401430dd3e3980aabf is first bad commit >commit b958dfdc4769515c0ef56c401430dd3e3980aabf >Author: Huw Davies <huw(a)codeweavers.com> >Date: Thu Apr 16 11:51:45 2009 +0100 > > ole32: Change helper function to return the matching entry. > >:040000 040000 2964979dee4f353e1d565f7c20d8fdcc534f006d 8744cfee2e33db4799f58f102825103f565e18b9 M dlls I filed bug #18133, which has more detail and a screenshot. Susan

1 0

Re: [PATCH 5/5] user32/tests: Fix tests on win9x.
by Paul Vriens April 21, 2009

April 21, 2009

Huw Davies wrote: > --- > dlls/user32/tests/clipboard.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > > ------------------------------------------------------------------------ > > Was just about to sent a patch along those lines. Isn't it better to mark that win9x (and winME as well btw) one as broken()? -- Cheers, Paul.

2 4

Re: Article on wine development strategy
by Susan Cragin April 21, 2009

April 21, 2009

I would like to put in my two cents for making Dragon NaturallySpeaking 10 work at about "50%." DNS 10 is a terrible program in a lot of ways. It's interface is over-engineered, clumsy, unintuitive, and packed with features that the average user never even looks at. People who don't know DNS say, "I'd love to dictate into word, format by voice command, etc." People who know DNS well, say "just give me accuracy and speed, and forget everything else." Those people usually tend to be the natural DNS constituency: either disabled or want to churn out a tremendous amount of text without typing. I think my point here is that happiness depends not only on % but on the type of program. Not all programs are created equal. Not all features are a good idea. Susan Cragin

8 9

Maybe already known stuff, but.....
by Massimo Del Fedele April 21, 2009

April 21, 2009

Today I found this : #include "execinfo.h" void BT(void) { void *array[50]; size_t size; char **strings; size_t i; size = backtrace (array, 50); strings = backtrace_symbols (array, size); printf ("Obtained %zd stack frames.\n", size); for (i = 0; i < size; i++) printf ("%s\n", strings[i]); free (strings); } That allow to dump a backtrace (here max 50 frames) from inside a running program. Quite useful if app is non debuggable and don't run with +relay on because of copy protection. Ciao Max

2 2

NetBSD compile error
by Austin English April 21, 2009

April 21, 2009

I just installed NetBSD 5.0RC4 on a spare hard drive, and tried compiling Wine. I hadn't seen this error before, but I'm not sure if the regression is on NetBSD or Wine's end. Google doesn't show too much for this error, other than that apparently NetBSD's libexec requires execname to not be NULL: case 2: /* ORIGIN */ if (execname == NULL) xerr(1, "execname not specified in AUX vector"); if ((ep = strrchr(p = execname, '/')) == NULL) xerr(1, "bad execname `%s' in AUX vector", execname); break; http://ftp.lahtermaher.org/pub/os/netbsd/cvs/src/libexec/ld.elf_so/expand.c… austin987$ make LD_LIBRARY_PATH="../../libs/wine:$LD_LIBRARY_PATH" ../../tools/wrc/wrc --nostdinc -I. -I. -I../../include -I../../include -D__WINESRC__ -D_ADVAPI32_ -foversion.res version.rc execname not specified in AUX vector: No such file or directory *** Error code 1 Can anyone shed some light on this error? -- -Austin

1 0

Re: Possible regression today's git wine-1.1.19-153-g55ad3fd
by Susan Cragin April 21, 2009

April 21, 2009

>2009/4/20 Reece Dunn <msclrhd(a)googlemail.com>: >> 2009/4/20 Susan Cragin <susancragin(a)earthlink.net>: >>>>Ohhh... got a nice crash after a re-boot. >>> >>> Never mind that. This looks more promising. At least, to me it does. The actctx error I get all the time, but I've never seen the other, and it happend right as the system froze up. >>> >>> fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.VC80.MFCLOC" (8.0.50608.0) >>> err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Broken pipe >>> err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Broken pipe >>> err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Broken pipe >>> err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Success >> >> Interesting. You are running Ubuntu studio 8.10 without pulseaudio, right? >> >> Have you updated the system between version runs (that may have >> reintroduced pulseaudio, for example)? >> >> Are you running any other sound applications (or the sound that is >> played after boot on Ubuntu)? >> >> Could you perform a git bisect to identify the guilty change? > >Doing some investigation, I have found >(http://alsa.opensrc.org/index.php/HowTo_Asynchronous_Playback) >""" >That is basically all there is to the callback. Note however, that >this example does not include error checking, which is a good idea of >course. Occasionally, you may have to restore from a buffer under-run, >in case the computer was caught up in some other process and didn't >get to calling your callback. Whenever this happens, the first >operation you perform on the device, in this case >snd_pcm_avail_update, will return -EPIPE (a 'Broken Pipe' error). You >can restore from this by calling the snd_pcm_prepare function again. >""" > >This may be what you are experiencing here. I'd need to look into this >further, but to be honest, I'm a little out of depth with the Windows >and Wine sound interfaces. > >- Reece Reece: I purged pulseaudio and checked that it had not been re-installed. I run Ubuntu 9.04 with all updates. I also use a test version of alsa-driver since my sound card is difficult to recognize but so far have had only great results -- no impact on wine at all. The problem I am experiencing manifests itself in the program freezing... could be the sound, could also be the buttons doing something odd. One button's on-off toggle switches suddenly with no input on my part. Regression test is below. Susan b958dfdc4769515c0ef56c401430dd3e3980aabf is first bad commit commit b958dfdc4769515c0ef56c401430dd3e3980aabf Author: Huw Davies <huw(a)codeweavers.com> Date: Thu Apr 16 11:51:45 2009 +0100 ole32: Change helper function to return the matching entry. :040000 040000 2964979dee4f353e1d565f7c20d8fdcc534f006d 8744cfee2e33db4799f58f102825103f565e18b9 M dlls

1 0

Re: dsound: Allow a special cbSize case in CreateSoundBuffer
by Maarten Lankhorst April 20, 2009

April 20, 2009

Hey Jesse, Jesse Allen schreef: > OK now do you have comments? I have test cases. > > On Sun, Apr 19, 2009 at 6:30 PM, Jesse Allen <the3dfxdude(a)gmail.com> wrote: > >> In CreateSoundBuffer, some apps pass sizeof(WAVEFORMATEXTENSIBLE) for >> the cbSize and we have to allow it, but only when the SubFormat is >> KSDATAFORMAT_SUBTYPE_PCM. >> >> Includes test cases which were verified on WinXP. >> Fixes bug #11716 >> If you want me to review a patch add me to cc please. The variable size_ok is unneeded here, you can rewrite that so that it will fall through if test fails. Apart from that it looks ok to me. Cheers, Maarten.

1 0

Re: Possible regression today's git wine-1.1.19-153-g55ad3fd
by Susan Cragin April 20, 2009

April 20, 2009

>Ohhh... got a nice crash after a re-boot. Never mind that. This looks more promising. At least, to me it does. The actctx error I get all the time, but I've never seen the other, and it happend right as the system froze up. fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.VC80.MFCLOC" (8.0.50608.0) err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Broken pipe err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Broken pipe err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Broken pipe err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Success

2 2

Janitor: list.h functions defined but not used
by Glenn L. McGrath April 20, 2009

April 20, 2009

Hi all, im new to the list, im interested in grinding away at some of the warnings wine generates... make depend was complaining about some static inline functions that it thinks arent used, this patch uses __attribute__ ((used)) to disable the warning. Glenn

7 7

Re: (Try2) wininet/tests: Fix HttpSendRequestW test on Win2k platform.
by Hans Leidekker April 20, 2009

April 20, 2009

On Monday 20 April 2009 20:14:14 Nicolas Le Cam wrote: > Win2k SP4 seems to be the only platform that follows what msdn says (see > http://msdn.microsoft.com/en-us/library/aa384247(VS.85).aspx) wininet is bundled with Internet Explorer, so it's more useful to look at the Explorer version than the Windows version. > Perhaps passing header's length to HttpSendRequest instead of adding a > broken expected value would be better. Let me know. No, the length parameter is the essence of this test. I wrote it because I saw IE7 call HttpSendRequestW like this which contradicts MSDN. The test shows that MSDN is outdated; on recent wininet HttpSendRequestW will calculate the header length for you. -Hans

2 1

Re: Possible regression today's git wine-1.1.19-153-g55ad3fd
by Susan Cragin April 20, 2009

April 20, 2009

>Dragon NaturallySpeaking freezes up today during training, without crashing. >I will do a regression test if needed, but suspect that the freeze may be already known and/or affect many programs. >Susan Ohhh... got a nice crash after a re-boot. fixme:gdiplus:GdipCreateHBITMAPFromBitmap stub fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.VC80.MFCLOC" (8.0.50608.0) err:ole:CoRevokeClassObject called from wrong apartment, should be called from 80000002c err:ole:CoRevokeClassObject called from wrong apartment, should be called from 80000002c err:ole:CoRevokeClassObject called from wrong apartment, should be called from 80000002c err:ole:CoRevokeClassObject called from wrong apartment, should be called from 80000002c err:ole:CoRevokeClassObject called from wrong apartment, should be called from 80000002c err:ole:CoRevokeClassObject called from wrong apartment, should be called from 80000002c err:ole:CoRevokeClassObject called from wrong apartment, should be called from 80000002c err:ole:CoRevokeClassObject called from wrong apartment, should be called from 80000002c err:ole:CoRevokeClassObject called from wrong apartment, should be called from 80000002c err:ntdll:RtlpWaitForCriticalSection section 0x7bc9c624 "loader.c: loader_section" wait timed out in thread 0040, blocked by 0042, retrying (60 sec) susan(a)ubuntu:~/.wine/drive_c/Program Files/Nuance/NaturallySpeaking10/Program$

1 0

Possible regression today's git wine-1.1.19-153-g55ad3fd
by Susan Cragin April 20, 2009

April 20, 2009

Dragon NaturallySpeaking freezes up today during training, without crashing. I will do a regression test if needed, but suspect that the freeze may be already known and/or affect many programs. The terminal output was singularly unhelpful. After deleting all the lines that I see every time often enough to have memorized them, I come up with the following, but none of it happened at the point of crash. Susan err:ole:local_server_thread ConnectNamedPipe failed with error 231 fixme:wininet:set_cookie Unknown additional option L"expires = Thu, 01-Jan-2099 00:00:00 GMT" fixme:winstation:GetUserObjectInformationW not supported index 4 err:ntdll:NtQueryInformationToken Unhandled Token Information class 12! fixme:mstask:MSTASK_ITaskScheduler_Enum 0x15bd40, 0x32f088: stub fixme:mstask:MSTASK_ITask_GetExitCode (0x155c18, 0x32f124): stub fixme:mstask:MSTASK_ITaskScheduler_Enum 0x15bd40, 0x32f088: stub fixme:mstask:MSTASK_ITask_GetExitCode (0x155c18, 0x32f124): stub fixme:mstask:MSTASK_ITaskScheduler_Enum 0x15bd40, 0x32f088: stub fixme:mstask:MSTASK_ITask_GetExitCode (0x155c18, 0x32f124): stub fixme:gdiplus:GdipSetLinePresetBlend not implemented fixme:keyboard:UnregisterHotKey (0x1008c,1): stub fixme:keyboard:RegisterHotKey (0x1008c,1,0x00000000,106): stub

1 0

Re: [3/3] msi: Add tests for importing a _SummaryInformation table. (resend)
by Alexandre Julliard April 20, 2009

April 20, 2009

Hans Leidekker <hans(a)codeweavers.com> writes: > diff --git a/dlls/msi/tests/db.c b/dlls/msi/tests/db.c > index b2c7d06..41510c4 100644 > --- a/dlls/msi/tests/db.c > +++ b/dlls/msi/tests/db.c This fails here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so db.c && touch db.ok db.c:1679: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1682: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1683: Test failed: Expected 14, got 0 db.c:1686: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1687: Test failed: Expected VT_I2, got 3341460 db.c:1688: Test failed: Expected 1252, got 1617263564 db.c:1692: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1693: Test failed: Expected VT_LPSTR, got 3341460 db.c:1694: Test failed: Expected 18, got 50 db.c:1695: Test failed: Expected "Installer Database", got db.c:1700: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1701: Test failed: Expected VT_LPSTR, got 3341460 db.c:1702: Test failed: Expected "Installer description", got db.c:1707: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1708: Test failed: Expected VT_LPSTR, got 3341460 db.c:1709: Test failed: Expected "WineHQ", got db.c:1714: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1715: Test failed: Expected VT_LPSTR, got 3341460 db.c:1716: Test failed: Expected "Installer", got db.c:1721: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1722: Test failed: Expected VT_LPSTR, got 3341460 db.c:1723: Test failed: Expected "Installer comments", got db.c:1728: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1729: Test failed: Expected VT_LPSTR, got 3341460 db.c:1730: Test failed: Expected "Intel;1033", got db.c:1735: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1736: Test failed: Expected VT_LPSTR, got 3341460 db.c:1737: Test failed: Expected "{12345678-1234-1234-1234-123456789012}", got db.c:1741: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1742: Test failed: Expected VT_FILETIME, got 3341460 db.c:1745: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1746: Test failed: Expected VT_FILETIME, got 3341460 db.c:1749: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1750: Test failed: Expected VT_I4, got 3341460 db.c:1751: Test failed: Expected 200, got 1617263564 db.c:1754: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1755: Test failed: Expected VT_I4, got 3341460 db.c:1756: Test failed: Expected 2, got 1617263564 db.c:1759: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1760: Test failed: Expected VT_I4, got 3341460 db.c:1761: Test failed: Expected 2, got 1617263564 db.c:1765: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1766: Test failed: Expected VT_LPSTR, got 3341460 db.c:1767: Test failed: Expected "Vim", got make[2]: *** [db.ok] Error 44 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll: add missing RtlReAllocateHeap valgrind hook, add tests
by Alexandre Julliard April 20, 2009

April 20, 2009

Dan Kegel <dank(a)kegel.com> writes: > More related to http://bugs.winehq.org/show_bug.cgi?id=18067 > This adds the missing valgrind hook, and adds tests that > show up the old problem if run under valgrind. The tests should go with the other existing heap tests in kernel32. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: add a couple testcases for GetNamedSecurityInfo (try 3)
by Paul Vriens April 20, 2009

April 20, 2009

Austin English wrote: > Added win_skip for NT4, where it would crash (thanks Paul!). > > > > ------------------------------------------------------------------------ > > Discussed this one briefly with Austin. Still need a little bit of love. -- Cheers, Paul.

1 0

Abiword unit / regression testing under Wine?
by Dan Kegel April 20, 2009

April 20, 2009

It looks like you can build Abiword for Windows on Linux: http://abiword.com/mailinglists/abiword-dev/2008/Jan/0021.html Has anybody tried running the Abiword unit or regression tests on Wine? http://www.abisource.com/wiki/Unit_Test http://svn.abisource.com/abiword-testsuite/trunk/README - Dan

3 4

Re: sxs: Implement a stub CreateAssemblyCache to make Publish or Perish install.
by Kai Blin April 20, 2009

April 20, 2009

On Sunday 19 April 2009 23:55:14 Kai Blin wrote: > As mentioned by the authors of Publish or Perish in their FAQ > (http://www.harzing.com/pop_faq.htm#Q309) Wine exporting sxs.dll and not > providing a real CreateAssemblyCache function trips up the installer. > This patch allows Publish or Perish to install without issues. > > Thanks to Donnie Berkholz for pointing me at this issue. > --- > dlls/sxs/sxs.c | 10 ++++++++++ > dlls/sxs/sxs.spec | 2 +- > 2 files changed, 11 insertions(+), 1 deletions(-) Of course the moment I sent this, I found the real implementation in fusion.dll. Sending a forward, feel free to ignore this patch. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

3 2

Re: [PATCH 1/2] Handle refcount of lights when interacting with viewport.
by Henri Verbeet April 19, 2009

April 19, 2009

2009/4/19 Christian Costa <titan.costa(a)wanadoo.fr>: > @@ -760,6 +760,8 @@ IDirect3DViewportImpl_AddLight(IDirect3DViewport3 *iface, > lpDirect3DLightImpl->activate(lpDirect3DLightImpl); > } > > + IDirect3DLight_AddRef(lpDirect3DLight); > + > LeaveCriticalSection(&ddraw_cs); > return D3D_OK; > } > @@ -798,6 +800,7 @@ IDirect3DViewportImpl_DeleteLight(IDirect3DViewport3 *iface, > cur_light->active_viewport = NULL; > This->num_lights--; > This->map_lights &= ~(1<<lpDirect3DLightImpl->dwLightIndex); > + IDirect3DLight_Release(lpDirect3DLight); > LeaveCriticalSection(&ddraw_cs); > return D3D_OK; > } The patch looks ok in principle, but I think it's nicer to keep these close to the code that actually manipulates the list.

1 0

Re: wined3d: Fix prototype for EnumAdapterModes
by Stefan Dösinger April 19, 2009

April 19, 2009

Am Freitag, 17. April 2009 03:10:26 schrieb Brad Martin: > --- > include/wine/wined3d.idl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/wine/wined3d.idl b/include/wine/wined3d.idl > index b8691a7..6f86688 100644 > --- a/include/wine/wined3d.idl > +++ b/include/wine/wined3d.idl > @@ -2222,8 +2222,8 @@ interface IWineD3D : IWineD3DBase > ); > HRESULT EnumAdapterModes( > [in] UINT adapter_idx, > - [in] UINT mode_idx, > [in] WINED3DFORMAT format, > + [in] UINT mode_idx, > [out] WINED3DDISPLAYMODE *mode > ); > HRESULT GetAdapterDisplayMode( Are you sure you can do this without adjusting the implementation function in dlls/wined3d/directx.c and the callers in d3d9, d3d8 and ddraw? I don't have the code checked out currently, so I can't check. Maybe the calls and the implementation match and just the .idl prototype is different.

2 1

Re: gdi32: fetch child fonts by real parent font name
by Lei Zhang April 19, 2009

April 19, 2009

On Tue, Apr 14, 2009 at 7:11 AM, Paul TBBle Hampson <Paul.Hampson(a)pobox.com> wrote: > This patch fixes bug 18044. > > Basically, the built-in FontLink functionality for subsituting > alternative fonts where a certain font is missing glyphs (used > by default for Tahoma and Microsoft Sans Serif under Windows) doesn't > work if the font is loaded via a FontSubstitution entry. > > The only place this is really likely to happen turns out to be using > MS Shell Dlg as a font name, which is generally discouraged for general > UI use (as far as I can tell, you're supposed to use a lookup function > which normally returns Tahoma or Microsoft Sans Serif directly) but > this happens to be the case for uTorrent 1.8 onwards. > -- > Paul "TBBle" Hampson, Paul.Hampson(a)Pobox.com This looks a lot like http://www.winehq.org/pipermail/wine-patches/2008-December/065543.html.

2 1

XI2 DirectInput mouse implementation RFC
by Paul TBBle Hampson April 19, 2009

April 19, 2009

I've thrown together a rather-rough-but-working-in-a-limited-sense implementation of XInput2-based DirectInput. It's got a fair few problems, I'm mainly interested in feedback on the approach, although obviously any code or style criticisms are welcome. Current limitations: * Doesn't check for XInput2.h, so won't build without it. * Doesn't send mouse-ups. XI2 bug. * Doesn't send events after mouse-down until after mouse-up on a window. I'm pretty sure this is an XI2 bug, but it might be a design feature. * Doesn't support exclusive mode. XI2 bug (grabs not yet implemented) * Mouse buttons aren't remapped nicely downwards. Need to look harder at this, my mouse reports buttons 1, 2, 3, 4, 5, 8 and 9 under X. 4 and 5 are scroll, 6 and 7 might be horizontal scroll in which case if this is always the case we can just remap downwards. * Only supports the Mouse. Adding keyboard support should be really trivial compared to actually getting the framework right. If this format is fine, then the first patch is basically ready to go, the latter two patches may need to be re-split or merged more sensibly. I've also attached a couple of fixes for the XI2 stuff if anyone wants to try it. One only affects 64-bit builds, and one fixes XCB locking assertions which you could probably otherwise ignore. So they're both kinda option in the Wine context. And one more patch, against the xinput utility from whot's git tree, to fix a compile failure. 0001-Unlock-display-after-XIQueryVersion.patch > libXi 0001-Clear-definitions-of-X-types-defined-to-wire-types.patch > x11proto-input 0001-Ensure-we-have-a-definition-of-BYTE.patch > xinput -- Paul "TBBle" Hampson, Paul.Hampson(a)Pobox.com Shorter .sig for a more eco-friendly paperless office.

1 0

Re: [PATCH 2/4] gdi32: fetch child fonts by real parent font name
by James McKenzie April 19, 2009

April 19, 2009

Paul TBBle Hampson wrote: > This patch fixes bug 18044. > > Basically, the built-in FontLink functionality for subsituting > alternative fonts where a certain font is missing glyphs (used > by default for Tahoma and Microsoft Sans Serif under Windows) doesn't > work if the font is loaded via a FontSubstitution entry. > > The only place this is really likely to happen turns out to be using > MS Shell Dlg as a font name, which is generally discouraged for general > UI use (as far as I can tell, you're supposed to use a lookup function > which normally returns Tahoma or Microsoft Sans Serif directly) but > this happens to be the case for uTorrent 1.8 onwards. > > Paul: Where is the patch? I could not find it. James McKenzie

2 1

Icons, logos, Tango, consistency, the user experience, and our project looks like a 2D champaign flute
by Scott Ritchie April 18, 2009

April 18, 2009

A user submitted a bug report to launchpad complaining that the Wine icon is not Tango compliant: https://bugs.launchpad.net/ubuntu/+source/wine/+bug/358645 So, what is Tango Compliance? Well, the Tango icons all use a set of design standards, and you can find them here: http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines In short, it means the Wine icon looks very out of place when it is placed alongside all the other Tango-compliant icons on the system. If you click the Applications button on an Ubuntu system, for instance, you'll see 7 three dimensional, front perspective, on the table, lit from above, well-bordered and highlighted icons. At the bottom you see a two dimensional, heavily tilted underneath perspective, hovering in midair, lit from the lower right, thick-bordered Wine icon. In short, it's ugly, but our real goal here is usability. Making Wine blend in is part of that, however it's also important we deliver a consistent experience: as ugly as it is, I thought, that icon is our project's logo, so we should use the same image throughout. But then, I realized, we don't use the same logo consistently! If you go to winehq.org you'll see another logo, which fits in with the website theme very well but is nevertheless quite different from the Tango icons. From a user's perspective, changing the Wine icon on the system can present a very slight familiarity issue: you're jarred for a second while you realize that the old Wine icon is gone and the new icon (helpfully next to the familiar words Wine) is actually the same program. This is the main place where the user sees the Wine icon, as we don't yet display it on other areas where they may be interacting with Wine (eg, by placing a small Wine icon next to the program icon as in http://brainstorm.ubuntu.com/ideatorrent/idea/2141) Accordingly, a change here will be narrow, and if we make it now (before the icon needs to be used elsewhere) there is a minimal amount of familiarity loss. A new icon makes a program feel new, so the user will expect some change. Accordingly, I'd like to propose updating our icons when we move forward with the 1.2 release. This will coincide with the inclusion of several of the Wine integration projects I'll be including in the coming months, such that the user will see it all (with a new, consistant icon) in one big package in the October wave of distro releases like Ubuntu 9.10. So, what should that new icon be? Well, tango compliance is one major goal, as is recognizability as a Wine glass. Fortunately, someone has already made a Tango-compliant Wine logo here: http://lists.freedesktop.org/archives/tango-artists/attachments/20060331/63… Now, if you're like me, the second you saw that you went "Whoa, that doesn't look like the Wine icon! It looks completely different!" The glass on the website, for instance, is much more narrow: http://winehq.org/images/winehq_logo_glass_sm.png Now, I'm not a drinker, but I do know that real wine people can be very, very picky about these kind of things. After giving the wikipedia article (http://en.wikipedia.org/wiki/Wine_glass) and a few other websites a full read, I can categorically state one thing: we're using the wrong glass for red wine. Now, whether the icon we use should be the right kind of glass or not is an aesthetic choice. Personally I'd use a red wine glass but one with a slightly narrower bowl than in the tango icon above (a "Bordeaux" glass rather than a "Burgundy" glass) http://www.the-gift-of-wine.com/Images/glass_bordeaux.jpg http://www.the-gift-of-wine.com/Images/glass_burgundy.jpg Anyway, I suspect most of you really really won't care, as long as it looks something like a wine glass and has the words Wine next to it. But I did want to start a discussion, especially because this represents our projects logo and is, to a real extent, more than just an icon. Meanwhile, I'll try drumming up some artists to see if I can get a few different Tango-compliant icons for us to chose from. Thanks, Scott Ritchie

10 16

Article on wine development strategy
by Dan Kegel April 18, 2009

April 18, 2009

http://yokozar.org/blog/archives/48 is a fun little look at using simulation to see how various strategies might affect Wine development. The one that worked out best was to pick some random user who's almost happy, fix the last few bugs that are keeping his apps from working, and then once he's happy, move on to the next such user. - Dan

6 9

re: Icons, logos, Tango, consistency, the user experience, and our project looks like a 2D champaign flute
by Dan Kegel April 18, 2009

April 18, 2009

The Ubuntu Studio logos look fine. I'd be happy with adopting them if they really make Wine fit in better with modern desktops. No need to wait for 1.2, just check 'em in now, 1.2 will be along soon enough.

9 13

Re: advapi32: add testcases for GetNamedSecurityInfo (try 2)
by Paul Vriens April 17, 2009

April 17, 2009

Austin English wrote: > Changelog: Fixed Paul's concerns. > > > > ------------------------------------------------------------------------ > > Implementation piece is not needed as GetNamedSecurityInfoW already takes care of those parameters. The second test crashes on NT4. Instead of surrounding that with an if(0) I suggest to surround it with an if(pCreateWellKnownSid). That function is available as of W2K so we skip on NT4 (and we already skip on Win9x). I also suggest to add a win_skip() if you decide to take that route. -- Cheers, Paul.

2 1

Re: [2/2] ntdll: Implement NtQueryInformationToken(TokenDefaultDacl).
by Detlef Riekenberg April 17, 2009

April 17, 2009

On Fr, 2009-04-17 at 12:53 +0200, Hans Leidekker wrote: > + Dacl = HeapAlloc(GetProcessHeap(), 0, Size); > + ret = GetTokenInformation(Token, TokenDefaultDacl, Dacl, Size, > &Size); > + ok(ret, "GetTokenInformation(TokenDefaultDacl) failed with error > %u\n", GetLastError()); > + > CloseHandle(Token); Please cleanup properly: HeapFree(GetProcessHeap(), 0, Dacl); -- By by ... Detlef

1 0

Re: oleaut32: [Patch 1/2] VarCat must use localized names for VT_BOOL
by Paul Vriens April 17, 2009

April 17, 2009

Detlef Riekenberg wrote: > http://test.winehq.org/data/f212579ae9a1b770ebd34cec20f95e1977bb57f0/xp_dr-… > > While reading the code for a test failure on all of my Windows > installations, > the current code was already strange: > > 5436 ok(hres == VARCMP_EQ || > 5437 broken(hres == VARCMP_GT), "Expected VARCMP_EQ, got %08x\n", > hres); > > I feel bad for adding a "broken(hres == VARCMP_LT)". > > Extending vartest and inserting a trace made the localization error > obvisious: > VARCMP_LT was returned when comparing "12Falsch" and "12False". > > The failure for the similar test (VT_BOOL with True: "12Wahr" > > "12True") > was hidden by the wrong "broken(hres == VARCMP_GT)". > > We have also another XP Machine that produced this failure. > (xp-home-SP2-czech) > > > > > ------------------------------------------------------------------------ > > Hi Detlef, The lstrcpyW and lstrcatW additions to init() in the tests don't work on Win95. I guess that's where the new failures come from: http://test.winehq.org/data/ed74088d7ddf0c389e7596237add7cb751b17a0a/95_W95… Could you have a look? -- Cheers, Paul.

2 3

Re: try5 [4/4] kernel32: Fix GetVolumeNameForVolumeMountPointW to match Mountmgr
by Austin English April 17, 2009

April 17, 2009

n Thu, Apr 16, 2009 at 10:00 PM, Guy Albertelli <galberte(a)neo.rr.com> wrote: > mountmgr.sys uses a specific format for "unique volume name". Make > GetVolumeNameForVolumeMountPointW match that format for the returned > unique volume name. > > Changelog > - Make GetVolumeNameForVolumeMountPointW match mountmgr.sys for format of "unique volume name" > --- > dlls/kernel32/tests/volume.c | 2 -- > dlls/kernel32/volume.c | 12 +++++++++--- > 2 files changed, 9 insertions(+), 5 deletions(-) > > > > > Series worked fine this time :-). Thanks for helping Wine! -- -Austin

1 0

Fwd: [Wine] The easiest way to convert Mod/Tod video from JVC and any vi
by Austin English April 17, 2009

April 17, 2009

There's been a lot of this spam recently (below). Can you take a look Jeremy? Perhaps banning that IP range if it's in the same block? Thanks! -- -Austin ---------- Forwarded message ---------- From: llhhhh0 <wineforum-user(a)winehq.org> Date: Wed, Apr 15, 2009 at 3:51 AM Subject: [Wine] The easiest way to convert Mod/Tod video from JVC and any vi To: wine-users(a)winehq.org question: 1: What is .Mod and .Tod video? 2: How to convert .Mod and .Tod video to AVI, MPG, WMV, MPEG? 3. How to convert any video to the format you want? Answer: 1 .MOD and .TOD is the video format generated by most popular digital camcorders such as Panasonic SV AV100, Canon MOD Camcorders, JVC (MOD and TOD) and Panasonic (MOD only). It is not the common format, so it can not be accepted by popular portable players.

4 4

Re: ntdll: add missing valgrind hook in RtlAllocateHeap
by Rob Shearman April 16, 2009

April 16, 2009

2009/4/15 Dan Kegel <dank(a)kegel.com>: > Two chromium unit tests reported phony errors > when run on wine on valgrind because > RtlAllocateHeap sometimes returned an > allocation without notifying valgrind about it. RtlReAllocateHeap is also missing valgrind notifications for the large block paths. It also appears that the function leaks memory in the realloc small -> large path. -- Rob Shearman

1 0

Winprinfo tool
by Saulius Krasuckas April 16, 2009

April 16, 2009

I just have struck one tool related to Windows printer drivers [*]: | In the process of developing a Windows printer driver, we created this | winprinfo tool to allow us to query the printer system from the point of | view of an application: there are several APIs that permit a wide range | of query. This tool exercises them all and proved to be indispensible in | our development. ... | Once a printer has been opened, there are several Win32 API calls that | can be used to query the device. These are DeviceCapabilities(), | GetDeviceCaps, and EnumForms() (there may be more, but we'll add them as | we discover them. | | Driver Info / GetPrinterDriver() | By fetching a DRIVER_INFO_4 object for this printer, we're able to | show the version (kernel or user), as well as the paths used for all the | support files (driver and UI DLLs, plus the dependent files). | | DEVMODE / DeviceCapabilities() | A central data structure involved in printing is the DEVMODE, which | is a collection of settings that apply to a printjob. Each printer has a | group of default settings that are used in the absense of any user input | on the subject, and they are managed with the printer's setup GUI. | Using the DeviceCapabilities() API function, we are able to extract | a number of individual parameters from the DEVMODE and report them. | | GetDeviceCaps() | Since a printer is a "graphics device", there are some kinds of | parameters that are in common with other devices such as video displays. | The GetDeviceCaps() call returns a small set of numeric parameters, many | of which have no real interest to printer developers. | | EnumForms() | The NT print spooler supports the notion of "forms", which is simply | a way of attaching a name to a specifically-sized piece of output media. | There are built-in sizes such as Letter and Legal, but there are at | least a hundreds defined for oddball paper sizes all over the world. A | print driver can define additional forms as well, though the interaction | between the central forms database and the driver is still a little | unclear. My guess, it could usefull for guys like Detlef working on Winspool and Co. also. Then it can query printers over SMB. One more (probably) interesting note (with regard to running the tool on Wine): | We built this to run strictly on NT/Win2000/XP platforms: if it works at | all on Win95/98/ME, we'd be very surprised. [*] http://unixwiz.net/tools/winprinfo.html

2 1

Suppressing the screen saver in a full screen game
by Scott Ritchie April 16, 2009

April 16, 2009

Ubuntu 9.04's new notification system is really nice and non obtrusive, however it can still get in the way if you need the entire screen. Accordingly, the notifications system has been designed to not draw notifications when a program such as a movie player is telling the operating system to suppress the screen saver. I propose we enable this functionality for Wine whenever we've switched to a full screen mode. I assume there's also a similar function for applications on Windows, so if we haven't done so already we should probably implement that and suppress the screen saver then as well. Thoughts? Thanks, Scott Ritchie

3 2

Re: advapi32: add testcases for GetNamedSecurityInfo
by Paul Vriens April 16, 2009

April 16, 2009

Austin English wrote: > Testing for bug 18071. Passes under Wine/2k. > > > > ------------------------------------------------------------------------ > > We bail out on pObjectName being NULL: + if (!pObjectName || !ppSecurityDescriptor) return ERROR_INVALID_PARAMETER; + This means this if() right after that is not needed anymore: if( pObjectName ) { -- Cheers, Paul.

1 1

NTFS filesystem features -> WONTFIX?
by Austin English April 16, 2009

April 16, 2009

See http://bugs.winehq.org/show_bug.cgi?id=17938 for background. Vitaliy closed this bug, saying it's an application bug that it depends on seeing NTFS file system type for certian program features. I don't think it should be a WONTFIX, as the only reason that change was introduced was to enable _another_ program to install successfully. Is there any reason we can't allow the reported file system to be changed? I'm sure there are other applications that test for it and change their behavior according to the file system type. A quick google search shows at least one application that does (http://boards2.sega.com/sega_board/viewtopic.php?p=2669064&sid=449f531c594a…) That install will likely now fail in Wine, because of this behavior. -- -Austin

16 29