April 2009 - Wine-Devel - list.winehq.org

Re: advapi32: add testcases for GetNamedSecurityInfo (try 2)
by Paul Vriens April 17, 2009

April 17, 2009

Austin English wrote: > Changelog: Fixed Paul's concerns. > > > > ------------------------------------------------------------------------ > > Implementation piece is not needed as GetNamedSecurityInfoW already takes care of those parameters. The second test crashes on NT4. Instead of surrounding that with an if(0) I suggest to surround it with an if(pCreateWellKnownSid). That function is available as of W2K so we skip on NT4 (and we already skip on Win9x). I also suggest to add a win_skip() if you decide to take that route. -- Cheers, Paul.

2 1

Re: [2/2] ntdll: Implement NtQueryInformationToken(TokenDefaultDacl).
by Detlef Riekenberg April 17, 2009

April 17, 2009

On Fr, 2009-04-17 at 12:53 +0200, Hans Leidekker wrote: > + Dacl = HeapAlloc(GetProcessHeap(), 0, Size); > + ret = GetTokenInformation(Token, TokenDefaultDacl, Dacl, Size, > &Size); > + ok(ret, "GetTokenInformation(TokenDefaultDacl) failed with error > %u\n", GetLastError()); > + > CloseHandle(Token); Please cleanup properly: HeapFree(GetProcessHeap(), 0, Dacl); -- By by ... Detlef

1 0

Re: oleaut32: [Patch 1/2] VarCat must use localized names for VT_BOOL
by Paul Vriens April 17, 2009

April 17, 2009

Detlef Riekenberg wrote: > http://test.winehq.org/data/f212579ae9a1b770ebd34cec20f95e1977bb57f0/xp_dr-… > > While reading the code for a test failure on all of my Windows > installations, > the current code was already strange: > > 5436 ok(hres == VARCMP_EQ || > 5437 broken(hres == VARCMP_GT), "Expected VARCMP_EQ, got %08x\n", > hres); > > I feel bad for adding a "broken(hres == VARCMP_LT)". > > Extending vartest and inserting a trace made the localization error > obvisious: > VARCMP_LT was returned when comparing "12Falsch" and "12False". > > The failure for the similar test (VT_BOOL with True: "12Wahr" > > "12True") > was hidden by the wrong "broken(hres == VARCMP_GT)". > > We have also another XP Machine that produced this failure. > (xp-home-SP2-czech) > > > > > ------------------------------------------------------------------------ > > Hi Detlef, The lstrcpyW and lstrcatW additions to init() in the tests don't work on Win95. I guess that's where the new failures come from: http://test.winehq.org/data/ed74088d7ddf0c389e7596237add7cb751b17a0a/95_W95… Could you have a look? -- Cheers, Paul.

2 3

Re: try5 [4/4] kernel32: Fix GetVolumeNameForVolumeMountPointW to match Mountmgr
by Austin English April 17, 2009

April 17, 2009

n Thu, Apr 16, 2009 at 10:00 PM, Guy Albertelli <galberte(a)neo.rr.com> wrote: > mountmgr.sys uses a specific format for "unique volume name". Make > GetVolumeNameForVolumeMountPointW match that format for the returned > unique volume name. > > Changelog > - Make GetVolumeNameForVolumeMountPointW match mountmgr.sys for format of "unique volume name" > --- > dlls/kernel32/tests/volume.c | 2 -- > dlls/kernel32/volume.c | 12 +++++++++--- > 2 files changed, 9 insertions(+), 5 deletions(-) > > > > > Series worked fine this time :-). Thanks for helping Wine! -- -Austin

1 0

Fwd: [Wine] The easiest way to convert Mod/Tod video from JVC and any vi
by Austin English April 17, 2009

April 17, 2009

There's been a lot of this spam recently (below). Can you take a look Jeremy? Perhaps banning that IP range if it's in the same block? Thanks! -- -Austin ---------- Forwarded message ---------- From: llhhhh0 <wineforum-user(a)winehq.org> Date: Wed, Apr 15, 2009 at 3:51 AM Subject: [Wine] The easiest way to convert Mod/Tod video from JVC and any vi To: wine-users(a)winehq.org question: 1: What is .Mod and .Tod video? 2: How to convert .Mod and .Tod video to AVI, MPG, WMV, MPEG? 3. How to convert any video to the format you want? Answer: 1 .MOD and .TOD is the video format generated by most popular digital camcorders such as Panasonic SV AV100, Canon MOD Camcorders, JVC (MOD and TOD) and Panasonic (MOD only). It is not the common format, so it can not be accepted by popular portable players.

4 4

Re: ntdll: add missing valgrind hook in RtlAllocateHeap
by Rob Shearman April 16, 2009

April 16, 2009

2009/4/15 Dan Kegel <dank(a)kegel.com>: > Two chromium unit tests reported phony errors > when run on wine on valgrind because > RtlAllocateHeap sometimes returned an > allocation without notifying valgrind about it. RtlReAllocateHeap is also missing valgrind notifications for the large block paths. It also appears that the function leaks memory in the realloc small -> large path. -- Rob Shearman

1 0

Winprinfo tool
by Saulius Krasuckas April 16, 2009

April 16, 2009

I just have struck one tool related to Windows printer drivers [*]: | In the process of developing a Windows printer driver, we created this | winprinfo tool to allow us to query the printer system from the point of | view of an application: there are several APIs that permit a wide range | of query. This tool exercises them all and proved to be indispensible in | our development. ... | Once a printer has been opened, there are several Win32 API calls that | can be used to query the device. These are DeviceCapabilities(), | GetDeviceCaps, and EnumForms() (there may be more, but we'll add them as | we discover them. | | Driver Info / GetPrinterDriver() | By fetching a DRIVER_INFO_4 object for this printer, we're able to | show the version (kernel or user), as well as the paths used for all the | support files (driver and UI DLLs, plus the dependent files). | | DEVMODE / DeviceCapabilities() | A central data structure involved in printing is the DEVMODE, which | is a collection of settings that apply to a printjob. Each printer has a | group of default settings that are used in the absense of any user input | on the subject, and they are managed with the printer's setup GUI. | Using the DeviceCapabilities() API function, we are able to extract | a number of individual parameters from the DEVMODE and report them. | | GetDeviceCaps() | Since a printer is a "graphics device", there are some kinds of | parameters that are in common with other devices such as video displays. | The GetDeviceCaps() call returns a small set of numeric parameters, many | of which have no real interest to printer developers. | | EnumForms() | The NT print spooler supports the notion of "forms", which is simply | a way of attaching a name to a specifically-sized piece of output media. | There are built-in sizes such as Letter and Legal, but there are at | least a hundreds defined for oddball paper sizes all over the world. A | print driver can define additional forms as well, though the interaction | between the central forms database and the driver is still a little | unclear. My guess, it could usefull for guys like Detlef working on Winspool and Co. also. Then it can query printers over SMB. One more (probably) interesting note (with regard to running the tool on Wine): | We built this to run strictly on NT/Win2000/XP platforms: if it works at | all on Win95/98/ME, we'd be very surprised. [*] http://unixwiz.net/tools/winprinfo.html

2 1

Suppressing the screen saver in a full screen game
by Scott Ritchie April 16, 2009

April 16, 2009

Ubuntu 9.04's new notification system is really nice and non obtrusive, however it can still get in the way if you need the entire screen. Accordingly, the notifications system has been designed to not draw notifications when a program such as a movie player is telling the operating system to suppress the screen saver. I propose we enable this functionality for Wine whenever we've switched to a full screen mode. I assume there's also a similar function for applications on Windows, so if we haven't done so already we should probably implement that and suppress the screen saver then as well. Thoughts? Thanks, Scott Ritchie

3 2

Re: advapi32: add testcases for GetNamedSecurityInfo
by Paul Vriens April 16, 2009

April 16, 2009

Austin English wrote: > Testing for bug 18071. Passes under Wine/2k. > > > > ------------------------------------------------------------------------ > > We bail out on pObjectName being NULL: + if (!pObjectName || !ppSecurityDescriptor) return ERROR_INVALID_PARAMETER; + This means this if() right after that is not needed anymore: if( pObjectName ) { -- Cheers, Paul.

1 1

NTFS filesystem features -> WONTFIX?
by Austin English April 16, 2009

April 16, 2009

See http://bugs.winehq.org/show_bug.cgi?id=17938 for background. Vitaliy closed this bug, saying it's an application bug that it depends on seeing NTFS file system type for certian program features. I don't think it should be a WONTFIX, as the only reason that change was introduced was to enable _another_ program to install successfully. Is there any reason we can't allow the reported file system to be changed? I'm sure there are other applications that test for it and change their behavior according to the file system type. A quick google search shows at least one application that does (http://boards2.sega.com/sega_board/viewtopic.php?p=2669064&sid=449f531c594a…) That install will likely now fail in Wine, because of this behavior. -- -Austin

16 29