April 2009 - Wine-Devel - list.winehq.org

Re: [4/10] WineD3D: Merge IWineD3DIndexBuffer and IWineD3DBuffer
by Henri Verbeet April 5, 2009

April 5, 2009

2009/4/4 Stefan Dösinger <stefan(a)codeweavers.com>: > + WINED3DRESOURCETYPE WineD3DRType; > TRACE("(%p)->(%d, %d, %d, %08x, %d, %d)\n", This, Adapter, DeviceType, AdapterFormat, Usage, RType, CheckFormat); > > + switch(RType) { > + case D3DRTYPE_VERTEXBUFFER: > + case D3DRTYPE_INDEXBUFFER: > + WineD3DRType = WINED3DRTYPE_BUFFER; > + break; > + > + default: > + WineD3DRType = RType; > + break; > + } > + This should have been in the first patch. The same goes for the other changes touching WINED3DRESOURCETYPE.

1 0

Re: [3/10] WineD3D: Merge indexbuffer and buffer implementations
by Henri Verbeet April 5, 2009

April 5, 2009

Personally I would've eliminated the implementation differences first (the main difference is when the data is copied, unmap vs. preload), and then just killed IWineD3DIndexBufferImpl once they were the same from an implementation point of view. Eg., you can ignore the conversion if you can prove it never happens for index buffers. > - desc->FVF = This->fvf; > + > + /* Temporary hack */ > + if(This->buffer_type_hint == GL_ARRAY_BUFFER_ARB) { > + desc->FVF = This->fvf; > + } This is extremely ugly. > + /* No conversion is needed on index buffers for now */ > + if (This->resource.format_desc->format != WINED3DFMT_VERTEXDATA) return FALSE; > + This is redundant, buffer_find_decl() will never be called for index buffers. Related to that, the bind_count field now has an ambiguous name, it only refers to how often the buffer is bound as vertex data, not index data, or any other type of potential binding (eg. stream output in the future). > + if(This->buffer_type_hint == GL_ELEMENT_ARRAY_BUFFER_ARB) { I realise wined3d is pretty much unsalvageable in terms of style consistency, but buffer.c is fairly consistent at the moment. I don't care too much about style differences, but I figured I'd mention it.

1 0

new refcount for d3d ??
by paulo lesgaz April 5, 2009

April 5, 2009

Hello, looking at the web page: http://www.nabble.com/d3d:-Bug-in-handling-of-depth-stencil-surfaces,-and-p… I read that there are problems with the ref count in d3d wine implementation. Does there exist any plan to fix it? Or can we try to implement the Jim's idea about it? David

4 6

Re: winemenubuilder: disable debug output for .desktop files
by Vincent Povirk April 4, 2009

April 4, 2009

On Fri, Apr 3, 2009 at 4:05 PM, Vincent Povirk <madewokherd+8cd9(a)gmail.com> wrote: > I'll work on a patch for the FIXME thing. Turns out this is not "fairly easy" but actually "incredibly difficult". We have a fallback case at http://source.winehq.org/source/include/wine/debug.h#L133 with a macro that returns a statement that ends in a function call, omitting the arguments and semicolon. This allows us to do FIXME_(channel)("message\n");. I can handle this in the other cases (where the macro result ends in a macro that takes arguments), but I can't see a way to create a static variable in a statement that ends in a function call that we only execute sometimes. Vincent Povirk

3 2

urlmon/misc test and the use of URLZONEREG_DEFAULT
by Paul Vriens April 4, 2009

April 4, 2009

Hi, Just build me a fresh W2K3 box with SP2 and all updates (including IE7). I get some errors when I run winetest: urlmon:misc misc.c:884: Test failed: (1400) policy=3, expected 0 misc.c:884: Test failed: (1e05) policy=10000, expected 20000 This particular test test_url_action() checks the registry values under HKLM and then checks with IInternetZoneManager_GetZoneActionPolicy() if it gets the same result. Obviously that failed in my case. It turns out that the returned value came from HKCU and not from HKLM. So the question is, does somebody now what URLZONEREG_DEFAULT defaults to? HKCR or HKLM and is this always the same or are there circumstances that make the default different. I guess I could write a test that checks both HKLM and HKCR and directly modifies the registry values in both hives to see what IInternetZoneManager_GetZoneActionPolicy() is using. Ideas, thoughts? -- Cheers, Paul.

2 4

Re: [2/2] shell32: Define PT_FOLDERW.
by Austin English April 4, 2009

April 4, 2009

On Sat, Apr 4, 2009 at 6:59 AM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: > Define PT_FOLDERW in pidl.h to complete this series. You're changing the indent of some of the defines. If you're going to change some, change them all to make them consistent (PT_COMP has two tabs). -- -Austin

2 3

Re: 'Interactive' tests on Windows 2003
by Ge van Geldorp April 4, 2009

April 4, 2009

From: "James Hawkins" <truiken(a)gmail.com> > On Fri, Jun 13, 2008 at 8:40 AM, Francois Gouget <fgouget(a)free.fr> wrote: > > > > Someone asked to check which tests require interaction when running in > > my Windows 2003 VM. However I cannot find the corresponding email (it > > might have been on irc), so I'm sending this data to the list. > > > > So the only interaction that was needed was caused by this IE > > security dialog: > > > > Content within this application coming from the Web site listed > > below is being blocked by Internet Explorer Enhanced Security > > Configuration. > > > > > > Only three tests were impacted: > > * mshtml_test dom > > -> 1508 tests run but 0 failures happened when just closing the > > dialog. > > > > * mshtml_test script (about:security_mshtml_test.exe) > > -> 21 tests run and 13 failures if the dialog is just closed, and 0 > > failures if mshtml_test is manually added to the 'allowed' list. > > > > * urlmon_test misc > > -> 923 tests run but 0 failures if the dialog is just closed. > > > > > > When run by winetest these tests just time out though. > > > > Thanks Francois (I asked on IRC a while back). I get these dialogs in > 2k3 as well. Do you think we should add a check for > winetest_interactive before the calls that bring up the permission > dialog? If anyone else knows of a better way, let us know. Actually, the interactive test is already there: http://www.winehq.org/pipermail/wine-cvs/2009-January/051706.html http://www.winehq.org/pipermail/wine-cvs/2009-January/051707.html Ge.

1 0

Re: gdi32/enhmfdrv: Actaully save the state in SaveDC and RestoreDCin the metafile
by Dmitry Timoshkov April 4, 2009

April 4, 2009

It would be cleaner to check for GDI_NO_MORE_WORK in SaveDC/RestoreDC instead of duplicating their code. -- Dmitry.

2 1

Re: winemenubuilder: disable debug output for .desktop files
by Vincent Povirk April 3, 2009

April 3, 2009

On Fri, Apr 3, 2009 at 4:09 PM, Austin English <austinenglish(a)gmail.com> wrote: > Why couldn't you simply use a second WINEDEBUG="fixme+all,err+all" to > override the variable in the .desktop file? The command is "env WINEPREFIX="..." WINEDEBUG=-all ...". No matter what I set WINEDEBUG to when I start that, wine will see a WINEDEBUG value of -all. Vincent Povirk

2 1

Re: winemenubuilder: disable debug output for .desktop files
by Vincent Povirk April 3, 2009

April 3, 2009

I'm not sure if this is a good idea. I don't think it's safe to assume that stderr will be lost if the program was started from a .desktop file. If default debug output slows anything down noticeably, that should probably be fixed. Vincent Povirk On Fri, Apr 3, 2009 at 2:40 PM, Austin English <austinenglish(a)gmail.com> wrote: > Users aren't running in a terminal, so debug output only slows things down. > > -- > -Austin > > > >

2 3