May 2009 - Wine-Devel - list.winehq.org

Re: [PATCH 2/2] ole32/tests: Add tests to show the WdtpInterfacePointer marshal data looks like the result of CoMarshalInterface.
by Paul Vriens May 19, 2009

May 19, 2009

Huw Davies wrote: > --- > dlls/ole32/tests/usrmarshal.c | 38 +++++++++++++++++++++----------------- > 1 files changed, 21 insertions(+), 17 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Huw, Could you have a look at the test results are test.winehq.org> This patch and the other one against usrmarshall.c introduced some test failures on several platforms. -- Cheers, Paul.

1 1

Re: [PATCH 8/8] urlmon: Added binding with MIME filter tests.
by Alexandre Julliard May 19, 2009

May 19, 2009

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/tests/url.c | 782 > ++++++++++++++++++++++++++++++++++++++--------- > 1 files changed, 636 insertions(+), 146 deletions(-) This is failing here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so url.c && touch url.ok url.c:2939: Test failed: mon should be destroyed here url.c:2940: Test failed: bctx should be destroyed here make: *** [url.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [wintrust/tests] Add some basic CryptCATOpen tests
by Detlef Riekenberg May 19, 2009

May 19, 2009

On Mo, 2009-05-18 at 16:07 +0200, Paul Vriens wrote: > + hcat = pCryptCATOpen(emptyW, 0, 0, 0, 0); > + todo_wine > + { > + ok(hcat != NULL && hcat != INVALID_HANDLE_VALUE, "Expected a > correct handle\n"); > + ok(GetLastError() == ERROR_SUCCESS, > + "Expected ERROR_SUCCESS, got %08x\n", GetLastError()); > + } MSDN documents INVALID_HANDLE_VALUE on failure. When NULL is valid result, then a comment about the MSDN error would be nice. Did you have an application, that need ERROR_SUCCESS? The result of GetLastError() should only be tested, when the function failed, or when GetLastError is documented to be valid on success. -- By by ... Detlef

2 1

Re: winspool.drv: implement semi-stub of EnumJobsW
by Detlef Riekenberg May 18, 2009

May 18, 2009

On Mo, 2009-05-18 at 19:30 +0400, Vitaly Perov wrote: > --- > dlls/winspool.drv/info.c | 36 +++++++++++++++++++++++++++++++++++- > 1 files changed, 35 insertions(+), 1 deletions(-) The correct location for an implementation is localspl.dll For which Application did you changed the stub? The important thing to decide first, what Wine is allowed to return: a) Informations from Wine and from Host-OS b) Informations from Wine only (will be empty most of the time) The current code is using "b", but your Patch added: c) Informations from the Host-OS only which is not correct. I'm fine to migrate from "b" to "a". Thanks for working on printing. -- By by ... Detlef

1 0

Re: [2/3] d3dx9: Add utility functions for loading files and resources into memory
by Stefan Dösinger May 18, 2009

May 18, 2009

Am Montag, 18. Mai 2009 17:44:17 schrieb Tony Wasserka: > +HRESULT LoadFileIntoMemoryA(LPCSTR filename, LPVOID *buffer, DWORD *length) Do you need this function? Woudn't it be better to wrap A->W at the API level and have all internal functions W only? > + handle = CreateFileW(filename, GENERIC_READ, FILE_SHARE_READ, 0, OPEN_EXISTING, 0, 0); > + if(handle == INVALID_HANDLE_VALUE) return D3DERR_INVALIDCALL; > + > + *length = GetFileSize(handle, NULL); >+ if(*length == INVALID_FILE_SIZE) return D3DERR_INVALIDCALL; > + > + *buffer = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, *length); Is there a particular reason not to use mmap, or whatever the Windows equivalent is?

1 0

Re: [shell32] Improve the Dutch 'about' message box
by Reece Dunn May 18, 2009

May 18, 2009

2009/5/12 Paul Vriens <paul.vriens.wine(a)gmail.com>: > Hi, > > Changed the sizes of the buttons and window to be the same as in > English. This make sure the 'Wine license' button can be fully read in > Dutch. > > - DEFPUSHBUTTON "OK", IDOK, 153, 133, 50, 12, WS_TABSTOP > + DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP According to Windows guidelines, command buttons (http://msdn.microsoft.com/en-us/library/aa511453.aspx) should be 50 x 14 DLUs (they can be wider than 50 DLUs, but only if the text is bigger than that, which it shouldn't for OK buttons) and have a 4 DLU spacing between other controls. This is so they look good in the presence of themes. - Reece

5 9

Re: [4/4]msctf: starting implementation of ITfContext::RequestEditSession and ITextStoreACPSink::OnLockGranted
by Alexandre Julliard May 18, 2009

May 18, 2009

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/msctf/context.c | 68 > ++++++++++++++++++++++++++++++++++-- > dlls/msctf/tests/inputprocessor.c | 29 +++++++++++----- > include/textstor.idl | 2 + > 3 files changed, 86 insertions(+), 13 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M msctf.dll -T ../../.. -p msctf_test.exe.so inputprocessor.c && touch inputprocessor.ok inputprocessor.c:155: Test succeeded inside todo block: GetStatus called too many times make[2]: *** [inputprocessor.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] winhttp: avoid NULL ptr dereference (Coverity 927)
by Alexandre Julliard May 18, 2009

May 18, 2009

Marcus Meissner <marcus(a)jet.franken.de> writes: > Not sure if we need to set these values in all error paths, > but definitely not in the NULL lpwhr. (lpwhdr?) There's no reason to have NULL checks in internal functions. -- Alexandre Julliard julliard(a)winehq.org

1 0

[Article] WINE and the importance of application compatibility
by nn May 17, 2009

May 17, 2009

WINE and the importance of application compatibility http://community.zdnet.co.uk/blog/0,1000000567,10012751o-2000630136b,00.htm Need a Holiday? Win a $10,000 Holiday of your choice. Enter now.http://us.lrd.yahoo.com/_ylc=X3oDMTJxN2x2ZmNpBF9zAzIwMjM2MTY2MTMEdG1fZG…

3 2

SoC 2009 / Application Test Suite Update
by Austin English May 17, 2009

May 17, 2009

Howdy all, I've been working on the test suite. I've got a few basic tests set up with notepad, and I'm currently working on setting up the framework, using AutoHotKey to both run all the tests and parse the logs for failures/passing todo's. For those interested, here's the first 'real' script I've written. It sets up a test directory (C:\appinstall), downloads sha1sum.exe (if it doesn't exist), verifies its own sha1sum, downloads winscp.exe (portable version), sets up winscp.ini with its settings (I was going to use keyboard/mouse control, but ftp.winehq.org times out to quickly, and adjusting that setting with mouse/keyboard would be a lot more trouble), runs winscp, downloads welcome.msg, closes winscp, sha1sum's welcome.msg, and finally, deletes welcome.msg and winscp.ini. It already found one bug :-): http://bugs.winehq.org/show_bug.cgi?id=18455. On windows, when selecting the file to download, winscp pops up a dialog to allow you to put in an alternate path to save the file. On windows, it's already selected, so one can simply type a different path. On Wine, it's not selected, breaking the script. It's an easy work around (sending {HOME}, followed by {SHIFT}{END}), it's interesting that the script allows us to find such subtle bugs. Back to work... -- -Austin

3 4

WINE Intel
by MD.IMAM HOSSAIN May 17, 2009

May 17, 2009

Dear WINE Developers, Good morning. A great journey to WINE's Direct3D support since the beginning of its life time. Now it is so mature that I can play big games like FIFA 2006-2009, Need For Speed ProStreet, Need For Speed Undercover, Hitman Blood Money and so many easily. It already has Shader Model 1, Shader Model 2, Shader Model 3 support. What is I am going to say is that all of the bits of 3D it has are only and fully supported on nVidia based graphics card due to their superior Linux driver. But nVidia is not alone in the graphics card building field. There are other manufacturer around them. Majority of the C.P.U comes up with the INTEL integrated graphics card. We all very well know that their Linux driver lack most of the modern 3D bits. But most of the user do not know about that. They just get frustrated with WINE. Some DirectX 7 games runs very well in nVidia graphics card but not in INTEL. Same thing is for some DirectX8, DirectX8.1. I do not know but I suspect that WINE's various Direct3D code utilizes OpenGL nVidia Extension or higher level OpenGL ARB Extension rather that lower one. That's why while INTEL OpenGL driver does support DirectX7, DirectX8 level 3D wine does not able to run many games on INTEL Linux graphics driver. While those many games run on nVidia Linux driver. I hope WINE will someday have better INTEL OpenGL support. Your sincerely, MD. IMAM HOSSAIN

4 3

SourceForge 2009 Community Choice Award
by André Hentschel May 17, 2009

May 17, 2009

Last Year we got a funny award, lets nominate Wine for some serios things at http://sourceforge.net/community/cca09

1 0

Re: comdlg32: Optimize german Find and FindReplace Dialog(try2)
by James Mckenzie May 16, 2009

May 16, 2009

Dawncrow: Your fix does not match what is displayed in W2K. What does this dialog look like in WindowsXP? James McKenzie -----Original Message----- >From: Dawncrow <webmaster(a)dawncrow.de> >Sent: May 15, 2009 11:14 AM >To: wine-patches <wine-patches(a)winehq.org> >Subject: comdlg32: Optimize german Find and FindReplace Dialog(try2) > >compare can be found here: >http://www.dritimage.de/uploads/bilder/124241122145_comdlg32winepatch.jpeg >--- > dlls/comdlg32/cdlg_De.rc | 14 +++++++------- > 1 files changed, 7 insertions(+), 7 deletions(-) > >

1 0

Detecting an invalid handle in setupapi
by Paul Vriens May 16, 2009

May 16, 2009

Hi, I'm trying to install Microsoft's MMC (W2K3) and it crashes every now and then with different symptoms. I've tracked it down to what I think is a fault in the application that triggers a bug in Wine. All inf files that are read are closed with SetupCloseInfFile but the app is still trying to use the handle in a call to SetupFindFirstLineA. On Windows (tested on W2K3) this will lead to a failure of SetupFindFirstLineA with a last error of ERROR_INVALID_HANDLE. On Wine we don't check the handle and thus the outcome cannot be predicted (mostly crash). What ways do we have to detect invalid handles or better yet how can this be solved? -- Cheers, Paul.

2 1

Error in a shader compilation
by Doffle Alain May 16, 2009

May 16, 2009

Hi, I'm trying to get rid of an error I observe in a wine trace (cf. attachement). fixme:d3d_shader:print_glsl_info_log Error received from GLSL shader #32: "0(37) : error C1068: array index out of bounds\n" In my understanding, it comes from an incompatibility between the two lines : trace:d3d_shader:shader_vaddline GL HW (2, 13) : uniform vec4 VC[253]; and trace:d3d_shader:shader_vaddline GL HW (37, 1057) : gl_Position.zw = (VC[254].xy); Can you please give me some help/hint/advice about the correct way to solve this problem please ?

1 0

Re: ole32: process all sent and some posted messages inCoWaitForMultipleHandles
by Dmitry Timoshkov May 16, 2009

May 16, 2009

"Vincent Povirk" <vincent(a)codeweavers.com> wrote: > With a test program that uses CoWaitForMultipleHandles in a single-thread > apartment as a main loop, I found that on Windows all sent messages were > processed, the program's window did redraw, keyboard and mouse input was >ignored, and only posted messsages from 0x3e0 through 0x3e8 were processed. > This brings Wine's behavior in line with what I observed. That's WM_DDE_FIRST and WM_DDE_LAST. -- Dmitry.

1 0

Re: Add tests for DirectDraw surface reference counting
by Stefan Dösinger May 16, 2009

May 16, 2009

Am Freitag, 15. Mai 2009 13:52:23 schrieb Luke Benstead: > Reference counts are wrong in Wine which causes some games to fail. > I'm working patches to make these tests pass so we can remove the > todo_wine's. > > Luke. The patch adds trailing whitespeaces in a few lines. Please remove them. Otherwise the code looks good to me.

3 2

Re: wine-devel Digest, Vol 46, Issue 55
by Steve Dodier May 15, 2009

May 15, 2009

Hello, If it's clear the distro list is quite messed, I think the distinction between Ubuntu Kubuntu and Xubuntu must be kept, because for install, Ubuntu ships with PulseAudio and Compiz by default, which cause a lot of problems, while Xubuntu is free of that and has its compositor shutdown by default. Another way to get rid of that would be to add a few checkboxes for the known problematic bits of the tests (ie. kind of GPU / Presence of Pulse/Compiz / use of winetricks), which would result in easier work for the bug triagers. Anyways, I don't want my post to be a "severity levels" 2, so let me know if you think there's interest in digging into this and i'll post on the forum. Cordially, SD. PS : this is the first time i post on this list. I'm merely an user, sometimes helping other ones on #winehq and in launchpad. I'm also the self-appointed part-time apprentice of the guru Scott Ritchie :p -- Steve Dodier OpenPGP : 0E5E4ECB IRC : SiDi on irc.freenode.net Jabber : sidi(a)im.apinc.org steve.dodier(a)gmail.com https://launchpad.net/~sidi

1 0

Re: (try3)Fix ATI HD4800 being reported as ATI 9500
by Ricardo Filipe May 15, 2009

May 15, 2009

2009/5/15 Robert Key <hpestilence(a)gmail.com> > Same patch but with the 2048MB X2 comment removed, thanks > Roderick. > > the previous try has been commited today... so if you want to fix the comment you have to send another patch, or leave it like it is.

1 0

AppDB and Distributions
by André Hentschel May 15, 2009

May 15, 2009

Hi, It's getting more and more strange in our AppDB. If a user is running Ubuntu 9.04, he has 14 options which distribution called Ubuntu 9.04 to choose. 14? There only should be two, the 32-Bit and the 64-Bit Version. If we don't stop that we get more and more chaos in our DB. So why this mess? I guess the users choose one and then see a way deeper some fields called "Distribution Name:" and "Distribution URL:", but they don't read the headline "New Distribution". Maybe we should do something like "IF (choosen distribution) THEN (dont allow to make new one)". Or maybe hide the "New Distribution"-Fields a bit more or make the "New" bigger. Beside clones like "Ubuntu 9.04 Jaunty x86_64" and "Ubuntu 9.04 "Jaunty" x86_64 (+ variants like Kubuntu)" there are also old Alphas which should be removed, same thing for other Versions. see also Bug 17401 Thanks for reading Best regards André Hentschel

1 0

Re: [1/2] winetest: malloc() & co are encapsulated, so encapsulate free() too.
by Alexandre Julliard May 15, 2009

May 15, 2009

Francois Gouget <fgouget(a)free.fr> writes: > It's not very clean to encapsulate malloc() & co with xmalloc(), etc, > but to then call free() directly. It means if the implementation of > xmalloc() is changed to call HeapAlloc() all the free() have to be > changed. So encapsulate free() too. xmalloc() is clearly a wrapper around malloc(), so there's no need to rename free(). If you want to change the allocation you should rename both to heap_alloc/heap_free or something like that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Fiddling with EnumServicesStatusExW
by Paul Vriens May 15, 2009

May 15, 2009

(I accidentally only sent this message to Rob only) Hi, To get away from the tests stuff I thought I'd resurrect my plans to implement EnumServiceStatusExW (the A-version is needed by SysInternal's Process Explorer amongst others). I have most of the stuff ready: - Added svcctl_EnumServicesStatusExW to /wine/wine-git/include/wine/svcctl.idl - Added svcctl_EnumServicesStatusExW to /wine/wine-git/programs/services/rpc.c - Added a enumeration routine to /wine/wine-git/programs/services/services.c (and .h of course) - Changed EnumServiceStatusExW in /wine/wine-git/dll/advapi32/service.c to call svcctl_EnumServicesStatusExW There is one important thing I can't get my head around. The call to EnumServicesStatusExW passes a pointer to a BYTE * lpServices with a length of cBufSize. lpServices is an array of some ENUM_SERVICE_STATUS_PROCESSW structs. The first two parameters of these structs are pointers to WCHAR strings. The strings for all these structs (on Windows) can be found after all the structs themselves. So imagine that we should have 2 services in our lpServices to be passed back to the initial caller: 0000 [0].lpServiceName -> 0088 0008 [0].lpDisplayName -> 0114 0016 [0].SERVICE_STATUS struct of 7 DWORDS 0044 [1].lpServiceName -> 0140 0052 [1].lpDisplayName -> 0166 0060 [1].SERVICE_STATUS struct of 7 DWORDS 0088 "ServiceName1" 0114 "DisplayName1" 0140 "ServiceName1' 0166 "DisplayName1" (The above is what EnumServicesStatusExW would pass back to the caller) The enumeration I have in services.c fills the lpServiceName pointer to the actual string. Likewise for lpDisplayName. This is all in the RPC world (where the lpServices address is different to the caller passed address). When lpServices is passed back to the caller I can see that the SERVICE_STATUS structs are correct but the pointers to the strings are pointing to the original ones. How can I make sure the pointers to the strings are correctly passed back as well? Should the RPC stuff take care of these pointers and 'translate' them? We could of course teach EnumServicesStatusExW to change the pointers to the appropriate ones. We know exactly where there strings are so it should be fairly trivial to change those pointers. This however seems like a hack. Any idea is welcome. -- Cheers, Paul.

2 2

Re: (try2)Fix ATI HD4800 being reported as ATI 9500
by Roderick Colenbrander May 15, 2009

May 15, 2009

The patch itself is correct but the comment regarding the X2 4800 is incorrect. Those cards indeed have 2GB of video memory (and the PR people mention that to you) but the boards contain two GPUs and both need a have a copy of textures and other resources (though the GPUs can communicate using a high speed bus). Effectively the amount of video memory is still 1GB. Roderick On Fri, May 15, 2009 at 2:29 AM, Robert Key <hpestilence(a)gmail.com> wrote: > Changelog: > * Added support for the ATI HD 4800 series (should be all of them). > Used a HD4830 device id for HD4800 cards in wined3d_gl.h. > > > >

1 0

DIB Engine - first set of fixings agains wine test suite
by Massimo Del Fedele May 14, 2009

May 14, 2009

I started fixing failures against test suite. Most of bitmap ones are fixed, remaining are due to still stubbed funcs. Now the problem is that it fixed also most todo_wines on bitmap suite.... As usual, on bug 421 page for who wants to test it. Ciao Max

3 4

Request for update of the AUTHORS-file
by André Hentschel May 14, 2009

May 14, 2009

The Authors file wasnt updated since 2008-06-16. I maybe would send a patch but i bet Julliard has a Script :)

1 0