May 2009 - Wine-Devel - list.winehq.org

Re: comdlg32: fix romanian translation
by Michael Stefaniuc May 4, 2009

May 4, 2009

André Hentschel wrote: > suggested by Dimitriu Petru > --- > dlls/comdlg32/cdlg_Ro.rc | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) This patch is wrong. The Romanian language uses "ț" aka "t with comma below accent" and not "ţ" which is "t with cedilla". bye michael

1 0

GUI debugging
by Benoit SCHWINDEN May 4, 2009

May 4, 2009

Hello, I am trying to make a very special application working with Wine 1.1.20 (Loris, from Ever Ezida, a library management software). Almost everything is functionnal, but there is a little graphical bug with some texfields. Also, I would like to know if there are some ways to debug a GUI, especially a way to know which library or DLL is called to display a part of this GUI (ie know what DLL is used to display my faulties text fields). Thanks a lot by advance. Best regards, Benoit. -- Benoit SCHWINDEN Direction Informatique Groupe GNU/Linux Université de Strasbourg 03 90 24 12 46

1 0

Giving up for now
by Joel Holdsworth May 4, 2009

May 4, 2009

Hi All, I've hit a bit of a wall with alpha blended icons. CreateIcon is working fine for icon creation, but ExtractIcon and LoadIconFromResource etc. are all proving more of a problem. All of these use various GDI DIB functions to coerce the icon bitmap to the correct colour depth and size. The problem is that preserving the alpha channel through these DIB functions seems to be impossible because they go via X11, so until the dib engine is merged (after hell freezes over) I'm not sure I can go much further. Joel

4 10

Re: Office 2007 MSI Crash - Null dereference @ MsiViewExecute
by Mike Kaplinskiy May 4, 2009

May 4, 2009

On Sun, May 3, 2009 at 10:36 PM, James Hawkins <truiken(a)gmail.com> wrote: > On Sun, May 3, 2009 at 1:52 PM, Mike Kaplinskiy > <mike.kaplinskiy(a)gmail.com> wrote: >> On Thu, Apr 30, 2009 at 1:08 PM, James Hawkins <truiken(a)gmail.com> wrote: >>> On Thu, Apr 30, 2009 at 4:03 AM, Austin English <austinenglish(a)gmail.com> wrote: >>>> On Tue, Apr 28, 2009 at 9:27 PM, Mike Kaplinskiy >>>> <mike.kaplinskiy(a)gmail.com> wrote: >>>>> I was looking at the trace of the crash from bug 17600, and it looks like >>>>> a custom action is calling MsiViewExecute with a null hRec. >>>>> >>>>> I (sadly) don't know much about the wine MSI architecture, but the >>>>> msiobj_lock on line 484 should fail since rec will never be fetched >>>>> (null). I think the intention was to make it query->hdr (as it is >>>>> released later). >>>> >>>> A testcase for it would show if you're right or wrong ;-). >>>> >>> >>> Not really. If you grep through the msi tests, you'll see that we >>> call MsiViewExecute with NULL hRec all over the place. That doesn't >>> mean there isn't a bug, just saying. >>> >>> -- >>> James Hawkins >>> >> >> So I got a little time to look into this, and was completely blown >> away. Apparently doing >> >> TRACE("dereferencing 0?=%p\n", (void *) &(((MSIRECORD *) NULL)->hdr)); >> >> works, since nothing ever gets dereferenced. I will post a patch for >> this small nit. >> >> On a slightly different note, I have traced the problem in office 2007 >> to the patch by James, and in particular to INSERT_execute. The row >> index gets set to 0 if the primary key is null (which is what office >> install is doing), but if the insert is temporary TABLE_insert assumes >> that row >= tv->table->row_count, and subtracts from the row index, >> putting us in the negatives (or high positives due to uint). >> >> I have a patch for this, but I don't know how to make a testcase (all >> I know is office installs), so would anyone mind pointing me to >> somewhere that explains msi temporary inserts? >> >> And should I post the patch up on wine-patches to get it critiqued? >> (sorry, first time) >> > > I'll take a look at your patch. No offense intended, but it's > probably not correct. The problem is a beast and deeply rooted in the > way we store temporary rows in the DB. I have a huge test patch for > it, and I had a fix, but my linux HD got fragged (bummer). > > -- > James Hawkins > (Sorry, forgot to forward to the list) Thanks James. I'm not gonna post it on the patches list quiet yet then. I checked that the msi tests pass with the patch as well. Mike.

1 0

Office 2007 MSI Crash - Null dereference @ MsiViewExecute
by Mike Kaplinskiy May 4, 2009

May 4, 2009

I was looking at the trace of the crash from bug 17600, and it looks like a custom action is calling MsiViewExecute with a null hRec. I (sadly) don't know much about the wine MSI architecture, but the msiobj_lock on line 484 should fail since rec will never be fetched (null). I think the intention was to make it query->hdr (as it is released later). Sorry if I'm dead wrong - just my 2c

3 5

Re: Severity levels
by Ken Sharp May 3, 2009

May 3, 2009

IneedAname wrote: > On Sun, 03 May 2009 18:10:03 +0100 > Ken Sharp <kennybobs(a)o2.co.uk> wrote: > >> That would be the "Show Apps affected by this bug" link then. >> http://appdb.winehq.org/viewbugs.php?bug_id=16281 > > Thanks I missed that so how but my first point still stands. > Not really. 16281 certainly isn't a major loss of functionality, no matter how many bugs are attached to it.

1 0

Re: user32: combine horizontal and vertical window scroll bar info in a single structure.
by Alexandre Julliard May 3, 2009

May 3, 2009

Rein Klazes <wijn(a)online.nl> writes: > - if (!infoPtr && alloc) > + if (!infoPtr && ( alloc || (wndPtr->dwStyle & (WS_VSCROLL | WS_HSCROLL)))) > { This bit doesn't look right, and defeats the purpose of the alloc flag. It would need some more test cases. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: wine-devel Digest, Vol 46, Issue 10
by chris ahrendt May 3, 2009

May 3, 2009

wine-devel-request(a)winehq.org wrote: > _______________________________________________ > wine-devel mailing list - wine-devel(a)winehq.org > http://www.winehq.org/mailman/listinfo/wine-devel > > > ------------------------------------------------------------------------ > > Subject: > Re: RFC on Base Wine Config > From: > Kai Blin <kai.blin(a)gmail.com> > Date: > Sun, 3 May 2009 09:04:13 +0200 > To: > wine-devel(a)winehq.org > > To: > wine-devel(a)winehq.org > > > On Sunday 03 May 2009 07:07:35 Ben Klein wrote: > >> 2009/5/3 chris ahrendt <celticht32(a)yahoo.com>: >> > > Replying to Ben's email as I didn't get Chris' email Ben replied to. > I would also like to note that I don't appreciate the tone both of these > emails are taking in the end. Please try to be civil. > > That being said, let me get to the technical part. > > >>> I guess I am not being completely clear somewhat.... >>> If I am in windows and go into explorer... >>> >> We've been through this before. Wine is not Windows. In Wine, the >> drive has to be mapped in dosdevices. >> >>> go to a network drive. I do >>> not nescisarily have to map that drive in order to run an application >>> (so long as the DLLS it needs, if any, are not just on that drive). I >>> can click the application >>> and it runs. I realise this may be a fundamental difference between unix >>> and windows but still they should theoretically run the same. >>> > > The important part here is that your local drives are local drives. Don't > confuse the Wine drive mappings with network drive mappings in Windows. Think > about a Wine drive mapping like plugging a new hdd into your box. > > >> But you're NOT running the test from a network drive, are you? And >> even if you were, you'd need some way to inform Wine that it's there, >> which would be to map it to a drive. Does Wine even support >> Windows-style shares? >> > > Nope. We could, but then you'd have to create a Samba share to allow us to use > the directory. I'm pretty sure a wine drive mapping is easier and faster. > > >>> Also from >>> a command line I can do (I think if I am remembering correctly (been >>> doing to much z work lately) ) //server/directory/app.exe and it will >>> retrieve and run the app... (I think) >>> > > That's a bit besides the point, as this is still a valid UNC path. Now imagine > I've got a USB hdd with my app on it, and that's usually connected at U:, > with my app being at U:\test\app.exe. Now the logic in Windows mapping my USB > drive to U: is just what the wine dosdevice mapping is like. If I now tell > windows to remove the USB device, my desktop link to U:\test\app.exe is not > going to work anymore. > > >> This message appears in your bug report: >> >>> Warning: could not find DOS drive for current working directory >>> '/home/cahrendt/wine-git/dlls/inetmib1/tests', starting in the Windows >>> directory. >>> > > Here my analogy would be a bit stretched, as in that you'd still manage to be > on the USB drive while it's already been disconnected. But basically you're > trying to run a program that's on a drive not connected to your wine "box". > > Cheers, > Kai > > > Thanks Kai, This is the kind of dialog I was looking for in the RFC. This makes sense. In a way with you are in a seperate 'region' and do not have access to that regions resources unless you map it. Even though wine is not a emulator it is essentially a VM running in userspace on the box that you need to allocate some resources to. (not so much like solaris 10 or zVM's where you can set up resources for everything). Ok clear now. Chris

1 0

Limit of todo_wine ?
by Massimo Del Fedele May 3, 2009

May 3, 2009

Today writing a testcase I found a "problem" on todo_wine construct. In short : void first_test_part() { ok(test1(), "failed\n"); } void second_test_part() { ok(test2(), "failed\n"); } todo_wine { first_test_part(); second_test_part(); } this "fails" (i.e. is marked as passing inside todo_wine block) if first_test_part() passes, which is not what wished; in this case the test should be considered passing if BOTH first and second part passes, and failed otherwise. The problem arose on bitmap creation test (gdiplus) on which the testcase should check for creation success AND bitmap internal consiscency. My example is short, but in my case there's a single function used to test many kind of bitmaps; that's impossible to do with todo_wine actual construct. It could be obviously separated into many functions, each enclosed on its own todo_wine, but this would vanify the "single test function for many bitmaps types" way. Max

2 2

Re: [shell32] stub for ExtractVersionResource16W
by Dmitry Timoshkov May 3, 2009

May 3, 2009

"Stefan Leichter" <Stefan.Leichter(a)camline.com> wrote: > +/*********************************************************************** > + * ExtractVersionResource16W (SHELL32.@) > + */ > +BOOL WINAPI ExtractVersionResource16W(LPWSTR s, DWORD d) { > + FIXME("(%s %x) stub!\n", debugstr_w(s), d); > + return FALSE; > +} Please follow the braces placement style of the file. Also you might be interested that according to http://www.geoffchappell.com/viewer.htm?doc=studies/windows/shell/shell32/h… ExtractVersionResource16W is discontinued starting from Windows Vista. -- Dmitry.

3 3

Re: RFC on Base Wine Config
by chris ahrendt May 3, 2009

May 3, 2009

Juan Lang wrote: >> ok then I am very confused then... >> I deleted the / mapping all together and then ran the dotest script and >> the make test scripts >> dotest fails if the / mapping is not there along with the inetmib1 >> test. I opened a bug >> concerning the inetmib test failing and was told that my configuration >> with the / mapping deleted >> was an invalid wine configuration that the / is absolutely needed by wine. >> >> So I am confused... is it required or not? >> > > It is not required. What _is_ required is that the path to the > current executable is mapped, somewhere. I suggested you remap Z: to > / as it's the default, and it was the most concise way to ensure that > your configuration met the requirement. As Ben said, you could map > any drive. Heck, you could have mapped Q: to the dlls/inetmib1/tests > directory and the inetmib1 test would have worked, while having no > mapping would not work. > --Juan > > > I realise this juan... I guess I am not being completely clear somewhat.... If I am in windows and go into explorer... go to a network drive. I do not nescisarily have to map that drive in order to run an application (so long as the DLLS it needs, if any, are not just on that drive). I can click the application and it runs. I realise this may be a fundamental difference between unix and windows but still they should theoretically run the same. Also from a command line I can do (I think if I am remembering correctly (been doing to much z work lately) ) //server/directory/app.exe and it will retrieve and run the app... (I think) Chris

5 6

Re: RFC on Base Wine Config
by chris ahrendt May 3, 2009

May 3, 2009

Ben Klein wrote: > 2009/5/3 chris ahrendt <celticht32(a)yahoo.com>: > >> I have noticed something with reporting bugs and problems that are >> encountered... >> >> If the user is allowed to delete the Z: share to / once this is done >> things start acting strange or not working. >> > > In general, you can't run apps outside of what's linked to in > dosdevices. You certainly can't launch them from inside Wine. The link > to / is mostly there for convenience so you don't have to keep dumping > downloads (e.g. patches or small installers) in ~/.wine/drive_c every > time you want to install them, and partly to allow Wine to launch > applications in /usr/bin et al (e.g. winebrowser). > > >> Many people have done this for various reasons. >> > > Yes, and it's valid to do so. > > >> My suggestion is to do the following: >> >> 1. If we have a base configuration that should not change for settings >> IE the Z: mapping then do not allow this to be changed or deleted in >> winecfg. If someone is dumb enough to go into the ini file and delete it >> then they should know better. >> > > This would make a lot of people unhappy (like the creation of the > Universe) for "various reasons". > > >> 2. If it is critical that the Z: or drive mapping be there for / then >> if its missing should wine then handle this condition? >> > > 1) It's not critical. > 2) Wine already handles this condition. It's no different from any > other drive link in this way. It doesn't even have to be Z; you can > manually change it to be D if you really want. The only critical drive > is C: and that IS handled differently (especially in winecfg). > > > ok then I am very confused then... I deleted the / mapping all together and then ran the dotest script and the make test scripts dotest fails if the / mapping is not there along with the inetmib1 test. I opened a bug concerning the inetmib test failing and was told that my configuration with the / mapping deleted was an invalid wine configuration that the / is absolutely needed by wine. So I am confused... is it required or not? and if it is then we get back to my original RFC here =D Chris

2 1

RFC on Base Wine Config
by chris ahrendt May 3, 2009

May 3, 2009

I have noticed something with reporting bugs and problems that are encountered... If the user is allowed to delete the Z: share to / once this is done things start acting strange or not working. Many people have done this for various reasons. My suggestion is to do the following: 1. If we have a base configuration that should not change for settings IE the Z: mapping then do not allow this to be changed or deleted in winecfg. If someone is dumb enough to go into the ini file and delete it then they should know better. 2. If it is critical that the Z: or drive mapping be there for / then if its missing should wine then handle this condition? Chris

2 1

error report
by Ruben Hillewaere May 3, 2009

May 3, 2009

Hello, I wanted to install (Dar)wine on my Intel Mac, first I've tried with the binaries found on http://wiki.winehq.org/MacOSX/Installing The installation goes fine, but running any of the apps fails. So, instead, I've tried to build Wine from Scratch, this is what I get: ruben(a)CakeSlicer:~/distrib$ ./create_darwine_distrib.sh $VERSION ~/ Desktop/wine-$VERSION # Packaging Darwine for version 1.1.20 using Wine sources in /Users/ ruben/Desktop/wine-1.1.20... # Building Wine in /Users/ruben/Desktop/wine-1.1.20 (warning: takes a long time)... configure: WARNING: mach-o/dyld_images.h: present but cannot be compiled configure: WARNING: mach-o/dyld_images.h: check for missing prerequisite headers? configure: WARNING: mach-o/dyld_images.h: see the Autoconf documentation configure: WARNING: mach-o/dyld_images.h: section "Present But Cannot Be Compiled" configure: WARNING: mach-o/dyld_images.h: proceeding with the preprocessor's result configure: WARNING: mach-o/dyld_images.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ## configure: error: FreeType development files not found. Fonts will not be built. Use the --without-freetype option if you really want this. ***** Error: Can't build wine thanks for keeping me informed about this error, Ruben Hillewaere PhD student, COMO Vrije Universiteit Brussel Department of Computer Science Pleinlaan 2 B-1050 Brussels Belgium

2 1

Re: IE and MSN Messenger 7.0
by Ben Klein May 3, 2009

May 3, 2009

2009/5/1 Cissyvonwinckelmann <cissyvonwinckelmann(a)planet.nl>: > hartelijk dank Benm ja ik moet snel een andere pc hebben, want dit is een > hele ouwe dan krijg je de moeilijkheden, > groetjes cissy > I have to use Google Language Tools to translate your text, so I apologise if I misunderstand you. The "old problems" with Messenger (you actually didn't say which Messenger it is, Yahoo or MSN?) in Wine are not likely to go away without a lot of work. As this is the developers' mailing list, we would welcome patches/modifications to Wine to make it work better. Without a discussion on the development side, your questions are better directed to wine-users mailing list or the forum, or some other user-oriented support path. Regardless, it is strongly recommended that you look into using a native client (i.e. something you don't need Wine to run) such as Pidgin.

2 2

RE: Question about my user32 tests patch
by Ge van Geldorp May 2, 2009

May 2, 2009

Hi Joel, > From: Joel Holdsworth <joel(a)airwebreathe.org.uk> > > How do you deal with this problem, because presumably not every test > contributor has VMs ready to confirm the behaviour of 95, 98, ME, 2000, > XP and Vista. Do I submit the patch as-is, in the knowlege that it will > cause failures in old windows? Presumably not - so what do you suggest I > do? I have a whole bunch of VMs set up specifically for Wine testing, so feel free to send me patches you think might behave differently on different Windows versions. One caveat: I personally stopped caring about 9x when Win2000 came out, so I'm not testing on those versions. The good (but unsurprising) news is that your new tests pass on all my XP (4 different configurations) and Win2k3 (also 4 different configurations) machines. I don't see failures on NT4, but perhaps the test was skipped there? The bad news is they failed on W2k, Vista and Win2k8. I've attached the test reports for all failures. Ge.

1 0

Re: Implement gdiplus.dll.GdipSetPathGradientPresetBlend
by Vincent Povirk May 2, 2009

May 2, 2009

> +GpStatus WINGDIPAPI GdipSetPathGradientPresetBlend(GpPathGradient *brush, GDIPCONST REAL *blend, > + GDIPCONST REAL *pos, INT count) The types here don't match MSDN: http://msdn.microsoft.com/en-us/library/ms534047(VS.85).aspx

1 0

FYI: First running winelib64-port!!!
by André Hentschel May 2, 2009

May 2, 2009

Hi, afer playing around with about 20 source-codes of open-source-project it got one compiled as winelib64-app(and also as 32-Bit winelib-app). It is WinVi 2.99 (http://www.winvi.de) The only difference i found between the original build and my two winelib builds are some GUI-specific things. Tomorrow i will have a look where to write something down about that in the wiki. As i already wrote, PuTTY compiles as winelib64-app, too, but it doesn't run. That's the reason why i called WinVi the first winelib64-app. Best regards André Hentschel

1 0

Question about my user32 tests patch
by Joel Holdsworth May 2, 2009

May 2, 2009

Hi All, I just submitted my first ever patch to wine-patches (attached) - good news. In retrospect I may have been a little premature. The patch adds tests for user32:DrawIcon and user32:DrawIconEx including tests for icon alpha blending which wine does not currently support. It occured to me that my alpha tests will fail in versions of Windows that don't support alpha blending - but the problem is I'm not sure at what point alpha began to be supported. I only have a VM for XP - and I think, but I don't know for sure, that alpha icons began to be supported in 2000. How do you deal with this problem, because presumably not every test contributor has VMs ready to confirm the behaviour of 95, 98, ME, 2000, XP and Vista. Do I submit the patch as-is, in the knowlege that it will cause failures in old windows? Presumably not - so what do you suggest I do? I now have code to make DrawIcon pass the alpha tests, and I'm hoping to have DrawIconEx ready in a few hours. With these done it should be possible to in-cooperate my Tango patches, which should improve the appearance of wine quite substantially. Thanks Joel

2 2

FYI: 64-Bit Winelib-compilation
by André Hentschel May 2, 2009

May 2, 2009

Hi, these days i got my gcc 4.4 working and first compiled wine64. Next thing i did was to modify winemaker to generate Makefiles for 64-Bit compilation. I first tried something simple and it worked great, so i took my modified Putty-sourcecode and gave it a try. And wow it worked great! Just compiled fine. To my suprise it didnt run. Since todays git, the modified winemaker got in and i hope it might be usefull! Best regards André Hentschel

2 3

Wine fundraising idea
by Austin English May 2, 2009

May 2, 2009

Howdy, I was reading through a GSoC thread on how people are spending their coding money. Someone posted that they thought people should donate to miro, the internet HDTV player. They've got a pretty neat donation scheme, where people can 'adopt' a line of code, and get updates on it, etc. Pretty neat: https://www.getmiro.com/adopt/ Just food for thought, for those of y'all wanting to add $ to the WineHQ coffers, for WineConf, or what not (*cough* test/compile farm *cough*). -- -Austin

2 1

Re: msi/tests: Fix MsiApplyMultiplePatches tests on Windows.
by Juan Lang May 1, 2009

May 1, 2009

Hi Nicolas, - ok(DeleteFileA("lithium.txt"), "Expected lithium.txt to exist\n"); + ok(DeleteFileA("lithium.txt"), "Expected lithium.txt to exist\n"); Please don't include whitespace-only changes in your patch. - + Same here. Thanks, --Juan

1 0

Re: Sound problems with latest kernel -- formerly a pulseaudio thread but not any more
by Susan Cragin May 1, 2009

May 1, 2009

>I filed ubuntu bug 369762. Ubuntu didn't think much of my bug. They sent me the following recipe to cure it, and marked the bug invalid. 1) Edit /etc/pulse/client.conf, and change "autospawn = yes" to "autospawn = no" 2) `touch $HOME/.pulse_a11y_nostart' 3) `asoundconf list' 4) choose the desired card from the previous command's output, and use `asoundconf set-default-card CARD', replacing CARD as appropriate 5) `killall pulseaudio' https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/348353 mentions a recent kernel patch that routes all audio through pulse. I wonder if this patch is the culprit?

3 2

Re: Wine fundraising idea
by James Mckenzie May 1, 2009

May 1, 2009

Austin English <austinenglish(a)gmail.com> >Sent: May 1, 2009 12:39 PM >To: Wine Devel <wine-devel(a)winehq.org> >Subject: Wine fundraising idea > >Howdy, > +1 James McKenzie

1 0

Trying buildbot on wine; foiled by distutils expecting mscoree to be resident?
by Dan Kegel May 1, 2009

May 1, 2009

I decided to try running buildbot on Wine today. The installation procedure is roughly wine msiexec /i python-2.6.2.msi /qb wine Twisted_NoDocs-8.2.0.win32-py2.6.exe The last bit complains Traceback (most recent call last): File "C:\Python26\scripts\twisted_postinstall.py", line 11, in <module> from twisted.scripts import tkunzip File "C:\Python26\lib\site-packages\twisted\scripts\tkunzip.py", line 26, in <module> from twisted.internet import reactor, defer File "C:\Python26\lib\site-packages\twisted\internet\reactor.py", line 37, in <module> from twisted.internet import selectreactor File "C:\Python26\lib\site-packages\twisted\internet\selectreactor.py", line 21, in <module> from twisted.internet import posixbase File "C:\Python26\lib\site-packages\twisted\internet\posixbase.py", line 25, in <module> from twisted.internet import tcp, udp File "C:\Python26\lib\site-packages\twisted\internet\tcp.py", line 78, in <module> from twisted.internet import defer, base, address File "C:\Python26\lib\site-packages\twisted\internet\defer.py", line 17, in <module> from twisted.python import log, failure, lockfile File "C:\Python26\lib\site-packages\twisted\python\lockfile.py", line 28, in <module> from win32api import OpenProcess ImportError: No module named win32api and hangs, possibly because of http://twistedmatrix.com/trac/ticket/3707 so I tried doing wine pywin32-212.win32-py2.6.exe first. This fails immediately as described in http://bugs.winehq.org/show_bug.cgi?id=13844 It seems to terminate because it tries to get a handle to the loaded copy of mscoree.dll and fails (because there isn't one). The installer seems to have been created by python's distutils. Mark Hammond seems to be well aware of low level issues that affect the installer, see e.g. http://bugs.python.org/issue5075 so perhaps he could explain why the installer expects mscoree.dll to be resident...

2 2