May 2009 - Wine-Devel - list.winehq.org

Re: comctl32/ipaddress: Use ok() test instead of assert()
by Paul Vriens May 27, 2009

May 27, 2009

Nikolay Sivov wrote: > This test fails to create window sometimes on Win95, > let's turn it into general failure. > > Changelog: > - replace assert() with ok() test > >>From b63fc6defb497505ecaab4921449327e875ab252 Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <bunglehead(a)gmail.com> > Date: Wed, 27 May 2009 14:26:37 +0400 > Subject: Use ok() test instead of assert() > > --- > dlls/comctl32/tests/ipaddress.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/dlls/comctl32/tests/ipaddress.c b/dlls/comctl32/tests/ipaddress.c > index d04223c..b8f30e4 100644 > --- a/dlls/comctl32/tests/ipaddress.c > +++ b/dlls/comctl32/tests/ipaddress.c > @@ -33,8 +33,6 @@ static HWND create_ipaddress_control (void) > handle = CreateWindowEx(0, WC_IPADDRESS, NULL, > WS_BORDER|WS_VISIBLE, 0, 0, 0, 0, > NULL, NULL, NULL, NULL); > - assert(handle); > - > return handle; > } > > @@ -45,6 +43,7 @@ static void test_get_set_text(void) > INT r; > > hwnd = create_ipaddress_control(); > + ok(hwnd != NULL, "Expected window to be created\n"); > Shouldn't you insert a return here when hwnd is NULL. The following tests will fail as well I guess. -- Cheers, Paul.

2 5

Re: [mshtml/tests] Fix 2 test failures on IE8
by Jacek Caban May 27, 2009

May 27, 2009

Hi Paul, Paul Vriens wrote: > Changelog > Fix 2 test failures on IE8 > - ok(disp == (void*)0xdeadbeef, "disp=%p\n", disp); + ok(disp == (void*)0xdeadbeef || + disp == NULL, /* IE8 */ This test does no longer make sense. It would be better to remove it and preferably change implementation to match IE8. Thanks, Jacek

2 2

Re: d3d9/tests: add simple test to show that QualityLevels is not zero, when we call CheckDeviceMultiSampleType with D3DMULTISAMPLE_NONE
by Jeff Zaroyko May 26, 2009

May 26, 2009

On Wed, May 27, 2009 at 7:47 AM, Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > This test shows second bug in > http://www.winehq.org/pipermail/wine-bugs/2009-May/177221.html > > I tested this on my laptop (under windows) with an ATI-card, my desktop > computer (that has nvidia) only runs Linux, so i could not test it on nvidia > under windows, if anyone could do that that would be nice. > No failures on Vista, nv9800, 180.81.

1 0

Re: [PATCH 05/10] msi: Add support for importing binary OBJECTS.
by Hib Eris May 26, 2009

May 26, 2009

On Tue, May 26, 2009 at 8:57 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Hib Eris <hib(a)hiberis.nl> writes: > >> I have looked at my new code and it does not seem wrong to me, but >> maybe it is somewhere else. Unfortunately, as I cannot reproduce this >> failure, I have no idea how to debug it. Does this fail for other >> people as well? >> >> Just a wild guess... could it have something to do with 64-bit vs. >> 32-bit? I am running on 32-bit. Alexandre, did you run the test on 32 >> or 64 bit? > > 32-bit of course, nothing works on 64-bit <g> > > It's heap corruption, you forgot to allocate space for the terminating > null in msi_import_stream_filename. And you should probably use strdupW > instead. Ahhh, I see! I will create a new patch. Thanks. A question about using strdupW: In my patch I use msi_alloc and msi_realloc to allocate memory for the returned string and use msi_free to free it again. If I would use stdupW to create a string copy instead of msi_alloc, would it then still be okay to use msi_realloc and msi_free? According to http://source.winehq.org/WineAPI/StrDupW.html I should use LocalFree to free the memory? I've seem some more places where msi_free and StdDupW were mixed, so I guess it will work. But is it considered good practice? Hib

2 1

[PATCH 05/10] msi: Add support for importing binary OBJECTS.
by Hib Eris May 26, 2009

May 26, 2009

Hi all, hmm, I've tested it again with current git, and it still works fine here. I have looked at my new code and it does not seem wrong to me, but maybe it is somewhere else. Unfortunately, as I cannot reproduce this failure, I have no idea how to debug it. Does this fail for other people as well? Just a wild guess... could it have something to do with 64-bit vs. 32-bit? I am running on 32-bit. Alexandre, did you run the test on 32 or 64 bit? So, I can only ask for someone to please also try http://www.winehq.org/pipermail/wine-patches/2009-May/073272.html and see if it works for him/her. Hib On Tue, May 26, 2009 at 3:30 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Hib Eris <hib(a)hiberis.nl> writes: > >> --- >> dlls/msi/database.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++--- >> dlls/msi/msipriv.h | 3 +- >> dlls/msi/record.c | 2 +- >> dlls/msi/tests/db.c | 12 +++++----- >> 4 files changed, 68 insertions(+), 12 deletions(-) > > This doesn't work here: > > ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so db.c && touch db.ok > wine: Unhandled page fault on write access to 0x00000004 at address 0x7bc4460e (thread 0019), starting debugger... > Unhandled exception: page fault on write access to 0x00000004 in 32-bit code (0x7bc4460e). > Register dump: > CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b > EIP:7bc4460e ESP:0032f770 EBP:0032f7e8 EFLAGS:00010202( R- -- I - - - ) > EAX:00000000 EBX:7bc94448 ECX:00110014 EDX:00000000 > ESI:0012dcc8 EDI:0012dc48 > Stack dump: > 0x0032f770: 0032f784 00110014 00000020 0012dd00 > 0x0032f780: 0032f794 4d430002 0032f7bc 0012dc58 > 0x0032f790: 0032f7a4 00110014 00000070 4d430003 > 0x0032f7a0: 00000000 4d430003 00000000 00000000 > 0x0032f7b0: 00000000 00000000 00000000 4d430000 > 0x0032f7c0: 0012dc58 00000070 00000000 00000000 > Backtrace: > =>0 0x7bc4460e HEAP_CreateFreeBlock+0x3be(subheap=0x110014, ptr=0x12dc48, size=128) [/home/julliard/wine/wine/dlls/ntdll/../../include/wine/list.h:98] in ntdll (0x0032f7e8) > 1 0x7bc44847 HEAP_MakeInUseBlockFree+0x57(subheap=0x110014, pArena=<is not available>) [/home/julliard/wine/wine/dlls/ntdll/heap.c:586] in ntdll (0x0032f838) > 2 0x7bc44b3c RtlFreeHeap+0x18c(heap=0x110000, flags=2, ptr=0x12dcc8) [/home/julliard/wine/wine/dlls/ntdll/heap.c:1480] in ntdll (0x0032f898) > 3 0x6081aa8e free_table+0x3e(table=<register EDI not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/msipriv.h:1059] in msi (0x0032f8b8) > 4 0x6081abae free_cached_tables+0x2e(db=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/../../include/wine/list.h:133] in msi (0x0032f8c8) > 5 0x607d3ec2 MSI_CloseDatabase+0x42(arg=0x12b7e8) [/home/julliard/wine/wine/dlls/msi/database.c:66] in msi (0x0032f8e8) > 6 0x607e6b58 msiobj_release+0x48(info=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/handle.c:257] in msi (0x0032f918) > 7 0x607e6ccf MsiCloseHandle+0xbf(handle=<is not available>) [/home/julliard/wine/wine/dlls/msi/handle.c:311] in msi (0x0032f948) > 8 0x6066abda test_binary_import+0x33a() [/home/julliard/wine/wine/dlls/msi/tests/db.c:1991] in msi_test (0x0032fca8) > 9 0x60677d7e func_db+0x264e() [/home/julliard/wine/wine/dlls/msi/tests/db.c:7672] in msi_test (0x0032fde8) > 10 0x60749a80 run_test+0x130(name="db.c") [/home/julliard/wine/wine/dlls/msi/tests/../../../include/wine/test.h:456] in msi_test (0x0032fe28) > 11 0x60749c6f main+0x11f(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/tests/../../../include/wine/test.h:505] in msi_test (0x0032fed8) > 12 0x6074a484 __wine_spec_exe_entry+0x84(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in msi_test (0x0032ff08) > 13 0x7b878660 start_process+0x130(arg=(nil)) [/home/julliard/wine/wine/dlls/kernel32/process.c:941] in kernel32 (0x0032ffe8) > 14 0x6002bc07 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) > 0x7bc4460e HEAP_CreateFreeBlock+0x3be [/home/julliard/wine/wine/dlls/ntdll/../../include/wine/list.h:98] in ntdll: movl %eax,0x4(%edx) > 98 elem->next->prev = elem->prev; > > > -- > Alexandre Julliard > julliard(a)winehq.org >

2 2

Re: patch wined3d
by Stefan Dösinger May 26, 2009

May 26, 2009

Am Dienstag, 26. Mai 2009 18:13:49 schrieb Pavel Prochazka: Is there any reason why we'd want 32 backbuffer swapchains? The currentl limit comes from d3d9(no more than 3 backbuffers allowed). We can certainly change it, but I doubt that any Windows driver supports that in ddraw. If there is no limit in ddraw(provide a test), we should remove the limit and make it dynamic.

1 0

Re: patch wined3d
by Henri Verbeet May 26, 2009

May 26, 2009

2009/5/26 Pavel Prochazka <prochapa(a)inf.upol.cz>: > +»······int i=1; > + > +»······/*it moves all backbuffers by 1 to left form id = 1, > +»······the backbuffer swap to frontbuffer and frontbuffer swaps to the end of chain > +»······Something like this: > +»······»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······------------^»··»······· > +»······»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······|»······»·······»·······| > +»······|FrontBuffer| |BackBuffer0|BackBuffer1|Backbuffer2|....|BackbufferN| > +»······ »····»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······^ > +»······»·······|---------------------------------------------------------------| > +»······»·······^ > +»······»·······|---------------------| > + > +»······»·······»·······»·······»·······»·······»·······»·······»·······»·······»······· > +»······*/ > + > +»······for(;i<This->presentParms.BackBufferCount-1;i++)· > +»······{ > +»······»·······hlp1 = (IWineD3DSurfaceImpl *)This->backBuffer[i]; > +»······»·······hlp2 = (IWineD3DSurfaceImpl *)This->backBuffer[i+1]; > +»······»·······hlp1->hDC = hlp2->hDC; > +»······»·······hlp1->dib.DIBsection = hlp2->dib.DIBsection; > +»······»·······hlp1->dib.bitmap_data = hlp2->dib.bitmap_data; > +»······»·······hlp1->resource.allocatedMemory = hlp2->resource.allocatedMemory; > +»······»·······hlp1->dib.client_memory = hlp2->dib.client_memory; > +»······} > + > +»······hlp1 = (IWineD3DSurfaceImpl *)This->backBuffer[i]; > +»······hlp1->hDC = front->hDC; > +»······hlp1 = (IWineD3DSurfaceImpl *)This->backBuffer[i]; > +»······hlp1->dib.DIBsection = front->dib.DIBsection; > +»······hlp1->dib.bitmap_data = front->dib.bitmap_data; > +»······hlp1->resource.allocatedMemory = front->resource.allocatedMemory; > +»······hlp1->dib.client_memory = front->dib.client_memory; > +»······ > +··· Style issues aside, that's not a very efficient way to implement a swapchain.

1 0

Re: [1/4] comctl32/listview: Basic LVM_GETVIEWRECT tests
by Paul Vriens May 26, 2009

May 26, 2009

Nikolay Sivov wrote: > Changelog: > - Basic LVM_GETVIEWRECT tests > > + todo_wine expect(104, rect.right); > + expect(0, rect.top); > + expect(73, rect.bottom); The first and last one of these 3 introduces errors on several boxes (see test.winehq.org) I guess these numbers can't be hardcoded and need to be calculated somehow? Could you have a look? -- Cheers, Paul.

2 1

Problem Running Winetricks
by Michael May 26, 2009

May 26, 2009

Hi, When I run winetricks, it consistently loops through and creates output files winetricks.1 , winetricks.2 , etc ... until I break the terminal. And doesn't do much more. Each of these files shows:

2 1

Re: [PATCH 05/10] msi: Add support for importing binary OBJECTS.
by Alexandre Julliard May 26, 2009

May 26, 2009

Hib Eris <hib(a)hiberis.nl> writes: > --- > dlls/msi/database.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++--- > dlls/msi/msipriv.h | 3 +- > dlls/msi/record.c | 2 +- > dlls/msi/tests/db.c | 12 +++++----- > 4 files changed, 68 insertions(+), 12 deletions(-) This doesn't work here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so db.c && touch db.ok wine: Unhandled page fault on write access to 0x00000004 at address 0x7bc4460e (thread 0019), starting debugger... Unhandled exception: page fault on write access to 0x00000004 in 32-bit code (0x7bc4460e). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7bc4460e ESP:0032f770 EBP:0032f7e8 EFLAGS:00010202( R- -- I - - - ) EAX:00000000 EBX:7bc94448 ECX:00110014 EDX:00000000 ESI:0012dcc8 EDI:0012dc48 Stack dump: 0x0032f770: 0032f784 00110014 00000020 0012dd00 0x0032f780: 0032f794 4d430002 0032f7bc 0012dc58 0x0032f790: 0032f7a4 00110014 00000070 4d430003 0x0032f7a0: 00000000 4d430003 00000000 00000000 0x0032f7b0: 00000000 00000000 00000000 4d430000 0x0032f7c0: 0012dc58 00000070 00000000 00000000 Backtrace: =>0 0x7bc4460e HEAP_CreateFreeBlock+0x3be(subheap=0x110014, ptr=0x12dc48, size=128) [/home/julliard/wine/wine/dlls/ntdll/../../include/wine/list.h:98] in ntdll (0x0032f7e8) 1 0x7bc44847 HEAP_MakeInUseBlockFree+0x57(subheap=0x110014, pArena=<is not available>) [/home/julliard/wine/wine/dlls/ntdll/heap.c:586] in ntdll (0x0032f838) 2 0x7bc44b3c RtlFreeHeap+0x18c(heap=0x110000, flags=2, ptr=0x12dcc8) [/home/julliard/wine/wine/dlls/ntdll/heap.c:1480] in ntdll (0x0032f898) 3 0x6081aa8e free_table+0x3e(table=<register EDI not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/msipriv.h:1059] in msi (0x0032f8b8) 4 0x6081abae free_cached_tables+0x2e(db=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/../../include/wine/list.h:133] in msi (0x0032f8c8) 5 0x607d3ec2 MSI_CloseDatabase+0x42(arg=0x12b7e8) [/home/julliard/wine/wine/dlls/msi/database.c:66] in msi (0x0032f8e8) 6 0x607e6b58 msiobj_release+0x48(info=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/handle.c:257] in msi (0x0032f918) 7 0x607e6ccf MsiCloseHandle+0xbf(handle=<is not available>) [/home/julliard/wine/wine/dlls/msi/handle.c:311] in msi (0x0032f948) 8 0x6066abda test_binary_import+0x33a() [/home/julliard/wine/wine/dlls/msi/tests/db.c:1991] in msi_test (0x0032fca8) 9 0x60677d7e func_db+0x264e() [/home/julliard/wine/wine/dlls/msi/tests/db.c:7672] in msi_test (0x0032fde8) 10 0x60749a80 run_test+0x130(name="db.c") [/home/julliard/wine/wine/dlls/msi/tests/../../../include/wine/test.h:456] in msi_test (0x0032fe28) 11 0x60749c6f main+0x11f(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/tests/../../../include/wine/test.h:505] in msi_test (0x0032fed8) 12 0x6074a484 __wine_spec_exe_entry+0x84(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in msi_test (0x0032ff08) 13 0x7b878660 start_process+0x130(arg=(nil)) [/home/julliard/wine/wine/dlls/kernel32/process.c:941] in kernel32 (0x0032ffe8) 14 0x6002bc07 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) 0x7bc4460e HEAP_CreateFreeBlock+0x3be [/home/julliard/wine/wine/dlls/ntdll/../../include/wine/list.h:98] in ntdll: movl %eax,0x4(%edx) 98 elem->next->prev = elem->prev; -- Alexandre Julliard julliard(a)winehq.org

1 0

Mac OS X Joystick problem
by Nathan Gray May 26, 2009

May 26, 2009

Hi all, I was happy to see that you recently added support for joysticks in OS X. (As you may or may not recall, I started to work on that problem a while back but never found time to finish it.) In any case, I was disappointed to find that my MS Sidewinder Precision Pro (USB) still doesn't work in the two games I tried -- The IL-2 Sturmovik demo and the Descent Freespace demo. The joystick seems not to be detected at all, from what I can tell. I filed a bug a while back in bugzilla[1] but it doesn't seem to have gotten any attention. Does the joystick code work for other people? Does it require any special configuration? I'm using Mike Kronenberg's 1.1.20 build. Thanks, -n8 [1] http://bugs.winehq.org/show_bug.cgi?id=18424 -- http://n8gray.org

3 6

/. wants a fork
by Remco May 26, 2009

May 26, 2009

Oh great, now there is poison on slashdot: http://tech.slashdot.org/article.pl?sid=09/05/24/2044239 Let's not fork, shall we? Remco

15 14

wine on MacOS 10.5.7: 3/4 success
by Joerg-Cyril.Hoehle＠t-systems.com May 25, 2009

May 25, 2009

Hi, here are my findings about compiling and using wine on an "early 2009" Mac Mini with NVidia graphics, without Fink or Macports. I hope it'll help other people. The good news first: + compilation essentially works. + Pharaoh (1.2 update, nocd) works in desktop mode. - old (16bit?) apps cause winevdm to crash, e.g. PharaohDemo's setup.exe Details follow. Bugs will be submitted separately. The setup is: + "early 2009" NVidia 9400 Mac Mini with OS 10.5.6 + XCode from DVD install disk. I did not install the whole thing, just a few packages, e.g. + gcc4.2 + DeveloperToolsCLI, + DevSDK, X11SDK, OpenGLSDK + CoreAudioSDK etc., without e.g. - gcc4.0 - MacOSX10.5 - DeveloperTools (actually, this one contains the Xcode.app but now complains that it cannot install into a non-empty directory - any ideas?) + Mac OS 10.5.7 update (includes X11 manpages) + XQuartz' X11.2.33.2 Not installing gcc-4.0, I changed the stale symlink /usr/bin/gcc->gcc-4.0 to gcc-4.2. I used neither Fink nor MacPorts. I found /usr/bin/ in MacOS full of OSS already. Like a Debian (hence Ubuntu) system, every tool has its manpage! Fink was not used because I was told it's obsolete. Macports was nuked after it started to configure and compile software as root, which violates my software acceptance policy. Another time I'll try pre-compiled binaries from Mike Kronenberg to see if that makes a difference, but as I plan to do as much regression testing as on Linux, I'll stick with git and compiling myself. ---------------- Compiling checking png.h usability... no checking png.h presence... no checking for png.h... no png is in /usr/X11/include plus /usr/X11/lib/libpng*, not /usr/include Alas, configure tests for png long before testing for X. Will submit bug. ---- checking mach-o/dyld_images.h usability... no checking mach-o/dyld_images.h presence... yes configure: WARNING: mach-o/dyld_images.h: present but cannot be compiled configure: WARNING: mach-o/dyld_images.h: check for missing prerequisite headers? configure: WARNING: mach-o/dyld_images.h: see the Autoconf documentation configure: WARNING: mach-o/dyld_images.h: section "Present But Cannot Be Compiled" configure: WARNING: mach-o/dyld_images.h: proceeding with the preprocessor's result configure: WARNING: mach-o/dyld_images.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ## Ruben Hillewaere already mentioned this in http://www.winehq.org/pipermail/wine-devel/2009-May/075287.html In file included from conftest.c:67: /usr/include/mach-o/dyld_images.h:65: error: expected specifier-qualifier-list before 'bool' Perhaps a mising bool typedef? ---- configure --verbose summary configure: libhal 32-bit development files not found, no dynamic device support. configure: libgnutls 32-bit development files not found, no schannel support. configure: libsane 32-bit development files not found, scanners won't be supported. configure: libgphoto2 32-bit development files not found, digital cameras won't be supported. configure: liblcms 32-bit development files not found, Color Management won't be supported. configure: libcapi20 32-bit development files not found, ISDN won't be supported. configure: WARNING: libjpeg 32-bit development files not found, JPEG won't be supported. configure: WARNING: libpng 32-bit development files not found, PNG won't be supported. configure: Finished. Do 'make depend && make' to compile Wine. Pretty much what I know from Ubuntu (except for jpeg+hal), where I never bothered to install the lcms or sane or SSL developer packages. ---- compilation warnings In file included from opengl_ext.h:28, from opengl_ext.c:5: /usr/X11/include/GL/gl.h:1387:1: warning: "GL_GLEXT_PROTOTYPES" redefined In file included from opengl_ext.c:5: opengl_ext.h:27:1: warning: this is the location of the previous definition Looks like a bug I'll submit to the XQuartz project. audiounit.c: In function `SynthUnit_CreateDefaultSynthUnit': audiounit.c:351: warning: `AUGraphNewNode' is deprecated (declared at /System/Library/Frameworks/AudioToolbox.framework/Headers/AUGraph.h:674) This is bug #11242 Wine build complete. ---------------- Running ./wine winecfg wine: created the configuration directory '/Users/xyz/.wine' ---- FreeType library issue resolved Wine cannot find the FreeType font library. To enable Wine to use TrueType fonts please install a version of FreeType greater than or equal to 2.0.5. http://www.freetype.org Building font metrics. This may take some time... Font metrics: 0.0% done fixme:font:LFD_InitFontInfo DBCS fonts like '-daewoo-gothic-medium-r-normal--16-120-100-100-c-160-ksc5601.1987-0' are not working correctly now. [... hundreds of messages like this ...] err:font:XFONT_BuildMetrics failed to load -misc-stheiti-medium-r-normal--100-*-100-100-p-0-ibm-cp866 Font metrics: 100.0% done [... repeated anew for every process started ...] "dlopen() searches the following the following until it finds a compatible Mach-O file: $LD_LIBRARY_PATH, $DYLD_LIBRARY_PATH, current working directory, $DYLD_FALLBACK_LIBRARY_PATH Note: There are no configuration files to control dlopen searching." Set one of those to /usr/X11/lib, because that's where libfreetype* resides in MacOS. There's no need to turn to MacPorts. LD_LIBRARY_PATH=/usr/X11/lib ./wine notepad lets wine finds hundreds of fonts. BTW, Macports' wrapper uses DYLD_FALLBACK_LIBRARY_PATH The ./wine wrapper itself sets DYLD_LIBRARY_PATH to its internal .so dir. Maybe it would not be a good idea to add this directory to the official ./wine wrapper, as it could cause conflicts with Fink or Macports sets of libraries? ---- err:process:__wine_kernel_init boot event wait timed out I get this one *sometimes* on a Linux box as well... ---- no 16 bit apps? winevdm crashes with identical messages on: - Pumuckl Klabauterjagd - Minigolf 1997 (not in AppDB) - Meine Traumburg (dito) - PharaoDemo's setup.exe PharaoDemo:setup.exe "The program winevdm.exe has encountered a serious error ..." Unhandled exception: page fault on read access to 0xffffffff in 32-bit code (1017:00000c1d). Probably a lot of installers will be affected. Is this caused by the mach-o/dyld_images.h warning from configure? Is there no 16bit support on Intel MacOS yet? ---- Pharaoh console log Copying my Linux Pharaoh (1.2 update, nocd) directory over to the Mac, I was pleased to see the title screen and the application running. err:d3d_caps:IWineD3DImpl_FillGLCaps Invalid nVidia version string: "2.0 NVIDIA-1.5.44" The string probably originates from XQuartz' X11.2.33.2. The wine source code expects a space after NVIDIA. Is it actually meningful to return the Apple 1.5 major+minor to a windows program? (On Linux, the numbers are much higher, e.g. "2.1.2 NVIDIA 173.14.09" or "2.1.0 NVIDIA 97.55" -- 2 samples from Google). fixme:d3d:IWineD3DImpl_FillGLCaps OpenGL implementation supports 16 vertex samplers and 16 total samplers fixme:d3d:IWineD3DImpl_FillGLCaps Expected vertex samplers + MAX_TEXTURES(=8) > combined_samplers fixme:win:EnumDisplayDevicesW ((null),0,0x32f664,0x00000000), stub! fixme:x11drv:X11DRV_desktop_SetCurrentMode Cannot change screen BPP from 32 to 16 well known from Linux. fixme:wave:wodDsCreate DirectSound not implemented fixme:wave:wodDsCreate The (slower) DirectSound HEL mode will be used instead. probably ok. Pharaoh plays the music. ---- full screen mode Full-screen does not work with Pharaoh. The application exits after: err:x11settings:X11DRV_ChangeDisplaySettingsEx No matching mode found 1024x768x16 @0! (NoRes) err:x11settings:X11DRV_ChangeDisplaySettingsEx No matching mode found 800x600x16 @0! (NoRes) err:x11settings:X11DRV_ChangeDisplaySettingsEx No matching mode found 640x480x16 @0! (NoRes) The LCD's native resolution is higher than those. Hope this helps, Jörg Höhle

2 3

Icon Refresh News (and a question)
by Joel Holdsworth May 25, 2009

May 25, 2009

Hi All, I've been working away little by little at my icons work, and I'm beginning to make a little progress: http://www.airwebreathe.org.uk/alpha-tango-icons.png The screenshot montage shows my work on getting HICONs and HIMAGELISTs to support the alpha channel, combined with a refreshed icon set from Tango. Right now, a lot of the changes I've made are rather bodged, but I'm encouraged because at least here we see a proof of principle. To get this to work, I've basically had to go through fixing places where the alpha channel is incorrectly stripped or ignored. All of them are relatively easily fixed, except the ones in the stretch blt functions. StretchBlt, StretchDIBits et al. seem to have a fast path and a slow path. The fast path is active when no stretching or translation should occur. The slow path performs all other cases, but my tests show that only the fast path preserves the alpha channel. The reason must be that the stretch is performed in X - but this is a problem, because I don't know if it's possible for X to preserve alpha. Does anyone know? My demo has replaced the offending StretchBlts with BitBlts, which works fine, unless the icon has to be rescaled. Does anyone have any thoughts or comments? Thanks Joel

2 2

Re: winhlp32: Avoid duplicate assignment in WINHELP_GetWindowInfo(). (RESEND)
by Eric Pouech May 25, 2009

May 25, 2009

Gerald Pfeifer a écrit : > Originally sent ten days ago; looks obvious to me? > > Gerald > > ChangeLog: > Avoid duplicate assignment in WINHELP_GetWindowInfo(). > > diff --git a/programs/winhlp32/winhelp.c b/programs/winhlp32/winhelp.c > index 7f74d8b..d1980e5 100644 > --- a/programs/winhlp32/winhelp.c > +++ b/programs/winhlp32/winhelp.c > @@ -278,7 +278,7 @@ HLPFILE_WINDOWINFO* WINHELP_GetWindowInfo(HLPFILE* hlpfile, LPCSTR name) > mwi.origin.x = mwi.origin.y = mwi.size.cx = mwi.size.cy = CW_USEDEFAULT; > mwi.style = SW_SHOW; > mwi.win_style = WS_OVERLAPPEDWINDOW; > - mwi.sr_color = mwi.sr_color = 0xFFFFFF; > + mwi.sr_color = 0xFFFFFF; > } > return &mwi; > } > > > > > fix is wrong the second should be nr_color instead of sr_color (hence the "double" assignment) A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Bugzilla: I dont stay logged in
by André Hentschel May 25, 2009

May 25, 2009

Hi, If i log in with both Checkboxes selected, i can do exactly one thing, and then i am logged out again. For example: if i am on a bug and log in, i can write a comment and got logged out. if i log in and select "add an attachment" i can fill the form, but the next step doesnt work correct because i got logged out. can someone fix it please?

3 2

failure to recognize "early 2009" Mac Mini nVidia 9400 OpenGL version string
by Joerg-Cyril.Hoehle＠t-systems.com May 25, 2009

May 25, 2009

Hi, as of wine-1.1.21, wine does not recognize the "early 2009" Mac Mini OpenGL version string from nVidia: err:d3d_caps:IWineD3DImpl_FillGLCaps Invalid nVidia version string: "2.0 NVIDIA-1.5.44" The string probably originates from XQuartz' X11.2.3.3.2. The wine source code expects a space after NVIDIA. On Linux, the numbers are much higher, e.g. "2.1.2 NVIDIA 173.14.09" or "2.1.0 NVIDIA 97.55" -- 2 samples from Google. Before I submit a patch to have wine recognize either space or "-" as separator, I'd like to query the list whether it actually makes sense to return major = 1, minor = 5, i.e. Apple numbers to a MS-Windows program? Or should I not care about the useage and just parse the string (i.e. submit patch)? Thanks, Jörg Höhle

3 2

DXTn textures in D3DX9
by Tony Wasserka May 25, 2009

May 25, 2009

Hi everyone, I'm working on implementing D3DXLoadSurfaceFromFileInMemory right now, but I've got a problem. The function most convert a loaded surface's data to a user specified surface format (I did not yet find a way to do it elsehow, UpdateTexture and StretchRect are to limited for that task, suggestions welcome if I missed anything). Now, if the user specifies that D3DX9 needs to convert e.g. an R8G8B8 surface to DXT1 (or to save a surface to a DXTn compressed DDS file), I'm not sure wether I can implement that behavior; on #winehackers I was told that the (de)compression part is coverered by S3's patents, but the Gimp DDS plugin and this (http://mollyrocket.com/forums/viewtopic.php?t=392) seem to provide OSS solutions for it anways. So... Can anybody tell me for sure wether I may implement this code or not? Best regards, Tony

6 10

News on Wine 1.1.21/MacOSX/XQuartz 2.3.3
by James McKenzie May 24, 2009

May 24, 2009

The news is good. First, if you are using Tiger, X11 is still broken and probably will remain so. Second, you do not need to upgrade to Leopard 10.5.7 to use XQuartz 2.3.3, the installer was fixed so it would install on 10.5.6. Third, Graphical games that depend on GLSL functions work. I tried dOOm, the Windows95 version, and it is definitely playable. Frame rates drop whenever you pick something up, but this also happens with CrossOver Games for Mac. This does not happen with Crossover Pro for Mac 7.1. I do not have any other programs that depend on GLSL functionality, but I suspect they will work on this combination. BTW, the version of Wine for Mac that I used for testing was built using Mike Kronenberg's Build Environment 1.1.5. James McKenzie

7 13

annoying pkg-config problem on 64 bit Ubuntu 8.10
by Dan Kegel May 24, 2009

May 24, 2009

On Ubuntu 8.10: $ pkg-config --libs dbus-1 -L//lib -ldbus-1 This leads to configure:13190: checking for dbus_connection_close in -ldbus-1 configure:13225: gcc -m32 -o conftest -g -O2 -DDBUS_API_SUBJECT_TO_CHANGE -I/usr/include/hal -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include conftest.c -ldbus-1 -L//lib -lhal -ldbus-1 >&5 /usr/bin/ld: //lib/libdbus-1.so: incompatible target configure:13253: result: no Also affects sane. Haven't checked Jaunty yet to see if it's still busted. We may need to postprocess pkg-config's output to add the missing 32 in some cases. Not sure if it's worth it.

5 5

Re: [PATCH 01/10] msi/tests: Add tests for binary OBJECTS.
by Austin English May 24, 2009

May 24, 2009

On Sun, May 24, 2009 at 11:51 AM, Hib Eris <hib(a)hiberis.nl> wrote: > Hi, > > I will send 10 patches for msi.dll that will add support for OBJECT > types in the Msi Database and that will allow you to merge in new > tables. > > This will make the WiX (Windows Installer XML) toolkit work a lot better. > > Please review and provide feedback on what can be improved as this is > my first substantial patch series to wine. > > Kind regards, > > Hib Eris > > > --- > dlls/msi/tests/db.c | 84 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 84 insertions(+), 0 deletions(-) > > > > Great work. Thanks for helping Wine! -- -Austin

1 0

Using Windows ODBC drivers
by martti May 24, 2009

May 24, 2009

Types successfully tested under wine: DB Type=PostgreSQL, Usefullness=100% Wine use: 1.1.21

1 0

re: urlmon: Cache binding notif window.
by Dan Kegel May 24, 2009

May 24, 2009

Hi Jacek, why do you have tls_list in http://www.winehq.org/pipermail/wine-patches/2009-May/072833.html ? The usual idiom is to just free each thread's data in THREAD_DETACH, isn't it? I ran into this while chasing a crash regression in Sketchup, see Anastasius' comments in http://bugs.winehq.org/show_bug.cgi?id=18601 - Dan

2 1

[comctl32] Test request
by Nikolay Sivov May 24, 2009

May 24, 2009

Hi. I've just prepared some simple MRU tests and I need test them on various native platfoms - tested only on xp sp2 so this one could be skipped. Could somebody do it?

1 0

Updating bugs in Bugzilla
by Ken Sharp May 24, 2009

May 24, 2009

Hi all, Is there any way I can have access to update bugs that I did not open in Bugzilla? I update a lot of bugs and some of them are not set correctly (incorrect component or incorrect URL). Wrong URLs are a real pain because it can lead to testing the wrong version of an app (see Bug 13371). At the moment I have to ask someone with access to make these changes for me, and they're not always done. I don't want to ask them repeatedly because they have better things to do, I'm sure, and it would be easier if I could do it myself. I have admin access on the AppDB for this reason. Is there any way I could have a similar access on Bugzilla? I had no idea where to send this email to... Thanks, Ken.

1 1

Static-ify rsaenh/mpi?
by Francois Gouget May 23, 2009

May 23, 2009

So dlls/rsaenh/mpi.c defines 13 functions that are only used there. So they could be made static by tweaking mpi.c and tomcrypt.h. However my understanding is that this files has been imported in Wine from another project so maybe it's not a good idea to diverge much from them. What do you think? Should we just leave them as is? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A particle is an irreducible representation of the Poincaré Group - Eugene Wigner

2 3

re: Updating bugs in Bugzilla
by Dan Kegel May 23, 2009

May 23, 2009

Ken Sharp asked: > [Can I have bugzilla privs?] OK, you have them now. Please them wisely.

1 0

[patch] segv on use-after-free in dsound/buffer.c
by Yuriy Kaminskiy May 23, 2009

May 23, 2009

Hello! One of games rarely crashed with segv in line 86 of dsound/buffer.c: 85: IDirectSoundBuffer_Release((LPDIRECTSOUNDBUFFER)This->dsb); 86: This->dsb->notify = NULL; (sorry, I failed to save actual backtrace at the time). This looks like typical assign-after-free bug. I've applied attached patch (wine-1.1.7, now on 1.1.19), no crashes so far (btw, similar *Secodary*Release method down in code uses proper order - assign-NULL-then-release).

2 1

Re: News on Wine 1.1.21/MacOSX/XQuartz 2.3.3
by James Mckenzie May 22, 2009

May 22, 2009

Roderick Colenbrander wrote about Re: News on Wine 1.1.21/MacOSX/XQuartz 2.3.3 > >On Wed, May 20, 2009 at 4:04 PM, Austin English <austinenglish(a)gmail.com> wrote: >> On Wed, May 20, 2009 at 4:46 AM, Roderick Colenbrander >> <thunderbird2k(a)gmail.com> wrote: >>> On Tue, May 19, 2009 at 6:41 PM, Mike Kronenberg >>> <mike.kronenberg(a)kronenberg.org> wrote: >>>> On 18.05.2009, at 06:56, Dmitry Timoshkov wrote: >>>> >>>>> "James McKenzie" <jjmckenzie51(a)earthlink.net> wrote: >>>>> >>>>>> Austin: >>>>>> Contact Mike Kronenberg or Zach Drayer and see what they currently >>>>>> have. >>>>> >>>>> IMHO since they haven't even bothered so far to change the license from >>>>> GPL to LGPL to match Wine, and clarify what exactly is so much different >>>>> in their builds so that they insist on different naming (Darwine vs. >>>>> Wine), >>>>> they shouldn't be even considered as partners to the Wine project. >>>>> >>>>> If we could have our own Wine builds for Intel Macs, that would finally >>>>> help to avoid this confusion Darwine adds, and remove it from our Wiki >>>>> altogether (since it's apparently where the users coming to them from). >>>>> >>>>> -- >>>>> Dmitry. >>>>> >>>>> >>>> >>>> >>>> >>>> Hi, >>>> >>>> (I hope I did not double-post, but somehow my mail from yesterday was eaten >>>> by filter-gnomes) >>>> >>>> It's not about being willing to, but plain lack of time. >>>> I follow this list closely and work on solutions as time permits. >>>> After half a year, it's been four weeks now that I am able again to build >>>> and test on a regular base again. >>>> >>>> There are other components on OS X that need some love, like the >>>> winehelper.app into which I'm looking atm. >>>> >>>> License and renaming is definitely on the list. >>>> I thought to revamp the package, once the winehelper is replaced, to not >>>> double do the work. >>>> >>>> As already mentioned, I build the dependencies and store them inside the >>>> apple .app package, which allows for drag'n'drop installation and removal. >>>> >>>> Having the dependencies as frameworks would be even better, as there is a >>>> lot of trouble with PATHS, especially if multiple environments are on the >>>> system, like fink and macports. >>>> >>>> But if the name-change is the most pressing issue, I will gladly do that >>>> with this weekends release. >>>> >>>> Mike Kronenberg >>>> >>>> >>>> >>> >>> Could you also upload some docs / scripts on how to build 'DarWine' >>> from scratch? I have an app which I need to run on osx which I like to >>> package as well. I have time to help fixing osx issues (duplicating >>> the effort is not worth it). >>> >>> Roderick >>> >>> >>> >> >> It's available under 'build env': >> http://www.kronenberg.org/darwine/buildenv-1.1.5.zip >> >> -- >> -Austin >> > >Thanks, I used this to compile wine 1.1.21 for testing purposes this >week. I had to update the scripts a bit (e.g. use newere versions of >some libraries and tools because the old ones are offline). I can post >a patch against the old script. Further don't ship the opengl hack >anymore for new wine packages as you are aware it isn't needed for >xquartz 2.3.3 anymore. Everyone should move to the latest xquartz. >This might prevent some opengl bug reports which I have to close on >bugzilla as well ;) > Does XQuartz 2.3.3 apply on Tiger systems? The 'hack' is for both Tiger and Leopard so that some missing functions will work. Please list the updated libraries so that I can upgrade the script as well. James McKenzie

1 0

Entry point not found for GetDiskInfoA (wininet_crosstest.exe)
by Detlef Riekenberg May 22, 2009

May 22, 2009

In "dlls/wininet/tests/urlcache.c", GetDiskInfoA is called, but wininet.dll (native and wine) export this function only by ordinal. When I build the crosstest, my mingw [i586-mingw32msvc-gcc (GCC) 4.2.1-sjlj (mingw32-2)] creates a named Import for GetDiskInfoA with an ordinal hint of 65. Using that executable on Windows or Wine is not possible (Entry point not found for GetDiskInfoA) The wininet_test.exe on winehq has an ordinal Import of 102 in that place. How can we fix that? (My patch to use an ordinal import in the test was dropped: http://www.winehq.org/pipermail/wine-patches/2009-May/073130.html ) -- By by ... Detlef

2 2

Handle Types: Big flaw in wine
by Daniel Santos May 22, 2009

May 22, 2009

As I've been working with user32, adding tests & such, I've noticed that gdi32 also suffers from the same drawbacks: it appears to have no mechanism to track object types with handles. Thus, the functions (that I've examined thus far) simply assume that the caller responsibly passed a handle to the correct object type and proceeds with that assumption. This is the cause of at least one bug that I know of (18371). Right now, I'm trying to determine the best way to implement a solution and I'm still green to wine's architecture. My initial thought was a handle type table in user32 that would just contain a handle's type as a byte (or possibly two types packed in one byte since there are less than 16) using a huge ugly 64k table that directly mapped handle to entry (ugly but correct) and something more efficient later. But I'm wondering if it wouldn't be more appropriate to put something like that in kernel32's global arena table. Input appreciated. Daniel

1 0

Using TlsGetValue internally
by Daniel Santos May 22, 2009

May 22, 2009

I'm playing with user32/cursoricon.c and winex11.drv/mouse.c and have noticed that one of the TODOs is that SetCursor (and probably lots others) clear the last error when they do not do so in windows. I tracked down the cause and winex11.drv's primary function for retrieving its per-thread data, x11drv_thread_data() calls the public kernel32 function TlsGetValue, which must set the last error to zero by specification. So, should we be using some internal function to get the TLS data that does not alter SetLastError or should we just save the last error in winex11.drv, call TlsGetValue and then restore the last error state? The later seems hack-ish, but the former sounds like a pain. Thanks, Daniel

1 0

Re: Change BITS_IBackgroundCopyJob_SetPriority to a stub so the EvE-Online patcher works.
by Ricardo Filipe May 21, 2009

May 21, 2009

2009/5/20 Tim Wright <timw(a)splhi.com> > The EvE-online updater blows up because it's trying to set the download > priority in BITS (qmgr) and that isn't implemented. Simply stubbing it to > return S_OK is sufficient to allow it to work. > > Third attempt at sending. For some reason, it isn't being posted from > git-send-email even though the Cc: arrives just fine at another account. > Patch against git repository. This is bug 18528/12312. > > > > --- > dlls/qmgr/job.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/qmgr/job.c b/dlls/qmgr/job.c > index 3baa893..09693a3 100644 > --- a/dlls/qmgr/job.c > +++ b/dlls/qmgr/job.c > @@ -334,8 +334,8 @@ static HRESULT WINAPI > BITS_IBackgroundCopyJob_SetPriority( > IBackgroundCopyJob2 *iface, > BG_JOB_PRIORITY Val) > { > - FIXME("Not implemented\n"); > - return E_NOTIMPL; > + FIXME("(%p,0x%08x) stub\n", iface, Val); > + return S_OK; > } > > static HRESULT WINAPI BITS_IBackgroundCopyJob_GetPriority( > -- > 1.6.0.4 > > > > > your previous patch was already commited. check git page the next day when you send patches. http://source.winehq.org/git/wine.git/?a=commit;h=cb26244adb4e15ab60e4d02b5… ;)

2 1

Re: Bugzilla upgrade - opening attachments in browser
by Austin English May 21, 2009

May 21, 2009

On Wed, May 20, 2009 at 6:05 AM, Igor Tarasov <tarasov.igor(a)gmail.com> wrote: > attachment.cgi shows that it relies on allow_attachment_display > parameter in bugzilla configuration. It has to be set to true. > > -- > Igor > Can a bugzilla admin please enable this? -- -Austin

3 4

Re: shell32: for FO_COPY, if the destination is an empty string, SHFileOperation should use the current directory.
by Alexandre Julliard May 21, 2009

May 21, 2009

lionel_debroux(a)yahoo.fr writes: > @@ -1179,6 +1181,15 @@ static HRESULT copy_files(FILE_OPERATION *op, const FILE_LIST *flFrom, FILE_LIST > const FILE_ENTRY *entryToCopy; > const FILE_ENTRY *fileDest = &flTo->feFiles[0]; > > + /* If the destination is empty, SHFileOperation should use the current directory */ > + if (!fileDest) > + { > + WCHAR currd[MAX_PATH]; > + GetCurrentDirectoryW(MAX_PATH, currd); > + parse_file_list(flTo, currd); > + fileDest = &flTo->feFiles[0]; > + } This can't possibly work. parse_file_list requires a null-terminated list, and you will be overwriting the previous data. This needs more thought. -- Alexandre Julliard julliard(a)winehq.org

2 2

DIB Engine - Mostly fixed against test suite
by Massimo Del Fedele May 21, 2009

May 21, 2009

Remaining bugs are related to : 1) Some color on monochrome bitmaps.... here I guess nobody knows how to do it right. I fixed some todo wine (most) but have 2 failures which wine does right. Seldom used anyways, and happens only on weird palettes. I guess not ever Microsoft knows what they did on this respect :-) 2) an AlphaBlend() call which should fail and doesn't. Here I really don't know why it should fail..... Uninfluent, anyways. 3) GetDIBits on a source DIB with BPP <= 8 fails to retrieve the original DIB palette, and synthesizes a new one instead. For the moment I found no simple way to grab the palette from inside GetDIBits without maintaining a linked list of HBITMAP <--> internal bitmaps. Not worth the effort for the moment anyways. If somebody notices weird colors due to it, I'll try to fix..... There are still some missing/buggy features rarely used that aren't spotted by testsuite; by now I've no time to fix them, anyways no one felt into them up to now :-) Austin, could you please retest it against test suite ? (code on Bug421 page) Ciao Max

6 9

Need help writing test
by Igor Tarasov May 20, 2009

May 20, 2009

Hi! I've found few visual glitches in comctl32/toolbar, and now try to write this all down as conformance tests, but I have some problems. I see that there is bug, when I test it with control spy. But when I repeat it in testcase, it won't work. Here is how you can reproduce it: TB_SETBITMAPSIZE 20,20 TB_SETBUTTONSIZE 30,30 TB_SETBITMAPSIZE 10,10 Now, if you do TB_SETBUTTONSIZE, you'll see the difference. builtin comctl will return 17,16. Native - 30,16. But when I write something like this: rebuild_toolbar_with_buttons(&hToolbar); himl = ImageList_LoadImage(GetModuleHandle(NULL), MAKEINTRESOURCE(IDB_BITMAP_80x15), 20, 2, CLR_NONE, IMAGE_BITMAP, LR_DEFAULTCOLOR); ok(SendMessageA(hToolbar, TB_SETIMAGELIST, 0, (LRESULT)himl) == 0, "TB_SETIMAGELIST failed\n"); SendMessageA(hToolbar, TB_SETBITMAPSIZE, 0, MAKELONG(20, 20)); SendMessageA(hToolbar, TB_SETBUTTONSIZE, 0, MAKELONG(30, 30)); ok(SendMessageA(hToolbar, TB_GETBUTTONSIZE, 0, 0) == MAKELONG(30, 30), "Unexpected button size\n"); SendMessageA(hToolbar, TB_SETBITMAPSIZE, 0, MAKELONG(10, 10)); compare((int)SendMessageA(hToolbar, TB_GETBUTTONSIZE, 0, 0), MAKELONG(30, 16), "%x"); This test fails, when I test it with native comctl32 (the size is 17,16). Why could this happen or what am I doing wrong? -- Igor

2 2

Re: gdiplus: implement partially transparent solid fill brushes
by Vincent Povirk May 20, 2009

May 20, 2009

Don't commit this one. I forgot to pre-multiply the alpha. Vincent Povirk On Wed, May 20, 2009 at 11:33 AM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > >

1 0

Re: [PATCH] Add missing classes for DOMDocument in msxml, and add test-cases back it up.
by Austin English May 20, 2009

May 20, 2009

On Tue, May 19, 2009 at 3:07 PM, Judy Devyak <judycarol(a)ameritech.net> wrote: > > > > You forgot the patch. -- -Austin

1 0

Re: [PATCH 7/8] urlmon: Added MIME filter handling in BindProtocol tests.
by Paul Vriens May 20, 2009

May 20, 2009

Jacek Caban wrote: > --- > dlls/urlmon/tests/protocol.c | 723 > +++++++++++++++++++++++++++++++++++------- > 1 files changed, 608 insertions(+), 115 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Jacek, This introduces extra failures on what seems to be mostly on IE7 and higher; see test.winehq.org. Could you have a look? -- Cheers, Paul.

2 1

malloc() use in rpcrt4/tests/server.c
by Francois Gouget May 20, 2009

May 20, 2009

Is there a specific reason for using malloc() in these tests? Testing that rpcrt4 does not assume HeapAlloc pointers? (but why would it even care?) Here are the relevant lines: in midl_user_allocate(): dlls/rpcrt4/tests/server.c:56: use HeapXxx(): return malloc(n); in array_tests(): dlls/rpcrt4/tests/server.c:1212: use HeapXxx(): dc = malloc(FIELD_OFFSET(doub_carr_t, a[2])); dlls/rpcrt4/tests/server.c:1214: use HeapXxx(): dc->a[0] = malloc(FIELD_OFFSET(doub_carr_1_t, a[3])); dlls/rpcrt4/tests/server.c:1219: use HeapXxx(): dc->a[1] = malloc(FIELD_OFFSET(doub_carr_1_t, a[2])); -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Cahn's Axiom: When all else fails, read the instructions.

1 0

Re: [PATCH] winhttp: avoid NULL ptr dereference (Coverity 927)
by Paul Vriens May 20, 2009

May 20, 2009

Marcus Meissner wrote: > Hi, > > Not sure if we need to set these values in all error paths, > but definitely not in the NULL lpwhr. (lpwhdr?) > > Ciao, Marcus > --- > dlls/wininet/http.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c > index 212ff9f..53c3743 100644 > --- a/dlls/wininet/http.c > +++ b/dlls/wininet/http.c > @@ -3831,8 +3831,9 @@ static BOOL HTTP_OpenConnection(LPWININETHTTPREQW lpwhr) > > TRACE("-->\n"); > > + if (!lpwhr) goto lend2; > > - if (NULL == lpwhr || lpwhr->hdr.htype != WH_HHTTPREQ) > + if (lpwhr->hdr.htype != WH_HHTTPREQ) > { > INTERNET_SetLastError(ERROR_INVALID_PARAMETER); > goto lend; > @@ -3894,6 +3895,7 @@ lend: > lpwhr->read_pos = lpwhr->read_size = 0; > lpwhr->read_chunked = FALSE; > > +lend2: > TRACE("%d <--\n", bSuccess); > return bSuccess; > } Hi Marcus, After AJ's remark you marked this Coverity one as "lpwhr can not be NULL". Should we thus delete the "NULL == lpwhr" altogether? -- Cheers, Paul.

2 1

Bugzilla upgrade - opening attachments in browser
by Austin English May 20, 2009

May 20, 2009

It seems the bugzilla upgrade stopped allowing opening attachments in browser. Not sure if that's by choice or just an unchanged setting, but having to open .txt/.jpeg/.png files in outside applications is a bit annoying...Any possibility of fixing that? -- -Austin

2 1

user32: improvements
by Daniel Santos May 20, 2009

May 20, 2009

In the process of working on this bug (http://bugs.winehq.org/show_bug.cgi?id=18371) I have discovered that user32's SetCursor function does not ensure that the the handle passed is valid or that it is even a handle to a cursor object (and it seems that the lingo for user32 objects is "resources"). The root cause of this problem is that the app attempts to use a cursor after it already destroyed it. At first, this just causes the cursor to be blank. Then, it would appear that the handle is re-used for a different type of resource, which leads to the gibberish image & subsequent hang. When this app runs on windows, I presume that the SetCursor calls just fail and the app resumes harmlessly ignoring the failure (or correcting it, either way). In general, this flaw will affect applications which use the user32 api irresponsibly, and I'm certain that a great number of windows apps out there, to some extent, do. My 1st step is to write some tests that illustrate/prove this problem (and that it works on windows) and I'm building the tests now so I can start on that. However, I've been reading up and considering how to implement a solution. I presume that this problem affects every user32 handle & function related to them, but I have only thoroughly examined mousecursor.c, so please forgive any incorrect assumptions I still have at this point (and let me know if I'm way off!). There was a quaint MSDN article on how the windows GDI32 dll manages GDI objects that even gave the internal structure, etc. (http://msdn.microsoft.com/en-us/magazine/cc188782.aspx) Although this only covers gdi32, I'm getting the idea that what needs to happen in user32 isn't too much different. Essentially, it would seem that user32 needs to associate a handle with a type and it would *appear* at this point that would be sufficient. However, I need to gain a better understanding of the nuisances of user32 objects.. From reading this ms kb article (http://support.microsoft.com/kb/184802) it seems that the windows user32 maintains 3 different types of heaps, a global one, one for each desktop and a different (differently sized?) one for non-interactive desktops. Windows' "global heap" is where user32 stores it's handle table, presumably which, simply associates a kernel32 handle with appropriate information for user32 objects, similar to the way GDI does (as illustrated in the above referenced MSDN article). Thus, if you create a thread, it can never have the same handle value as a cursor, icon, etc. So I'm going to write my tests on my windows machine, starting with only the mousecursor.c stuff because there appears to be quite a lot of ground to cover. If anybody has any feedback, corrections to anything I've said, etc. please do reply. Daniel

1 0

Re: Detecting an invalid handle in setupapi
by Daniel Santos May 19, 2009

May 19, 2009

oops, I meant to reply-all on this. --- On Mon, 5/18/09, Daniel Santos <javatroubadour(a)yahoo.com> wrote: From: Daniel Santos <javatroubadour(a)yahoo.com> Subject: Re: Detecting an invalid handle in setupapi To: "Paul Vriens" <paul.vriens.wine(a)gmail.com> Date: Monday, May 18, 2009, 5:43 PM I'm so very glad you brought this up Paul. I'm new to wine development and I've been working on Lord of the Rings Online issues and I have discovered and validated that the root cause of two of my problems are related (http://bugs.winehq.org/show_bug.cgi?id=18371) There are numerous places in Wine where the validity of handles are not checked. If the handle turns out to be invalid, then a NULL pointer is simply passed instead (which sometimes has an alternate meaning). Worse yet, in the code I was working with (dlls/kernel32/global16.c) the type of object the handle refers to is not stored! I see this as a critical flaw in Wine and I hope I can come up with a viable solution. I'm planning on setting up some test programs to examine the bit-data of some windows objects (starting with user32 -- where my issue lies) as any solution will have to be bit-compatibile with windows since apps like paint shop pro de-reference handles and examine the data of the underlying objects. In truth, if the LOTRO app didn't destroy objects it was still using and then try to use them, the problem wouldn't exist -- this part of wine will work perfectly if the app behaved responsibly. But development timelines and pressures frequently lead to code that works, but is incorrect and is a part of reality. Daniel --- On Sat, 5/16/09, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: From: Paul Vriens <paul.vriens.wine(a)gmail.com> Subject: Detecting an invalid handle in setupapi To: "wine-devel(a)winehq.org" <wine-devel(a)winehq.org> Date: Saturday, May 16, 2009, 12:18 PM Hi, I'm trying to install Microsoft's MMC (W2K3) and it crashes every now and then with different symptoms. I've tracked it down to what I think is a fault in the application that triggers a bug in Wine. All inf files that are read are closed with SetupCloseInfFile but the app is still trying to use the handle in a call to SetupFindFirstLineA. On Windows (tested on W2K3) this will lead to a failure of SetupFindFirstLineA with a last error of ERROR_INVALID_HANDLE. On Wine we don't check the handle and thus the outcome cannot be predicted (mostly crash). What ways do we have to detect invalid handles or better yet how can this be solved? -- Cheers, Paul.

1 0

Re: winemaker: add include-directory parsing
by Paul Vriens May 19, 2009

May 19, 2009

André Hentschel wrote: > --- > tools/winemaker | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi André, Not a comment on the patch itself but this is the third time you tried with the same patch. We usually add a 'resend' to the subject of a patch that is, uuh resend. If it's another revision we add 'try x'. In your case you should probably ask (on wine-devel) for comments or contact AJ directly on irc. -- Cheers, Paul.

1 0

re: [Article] WINE and the importance of application compatibility
by Dan Kegel May 19, 2009

May 19, 2009

James McKensie wrote: > WE need to get to the point where most of the common business type > applications will run in Wine without a bunch of twiddling and fixes. Well, yes. That was one of my goals during my big Wine push ( http://www.winehq.org/pipermail/wine-devel/2008-February/062550.html ), and I think we made a lot of progress. Still lots to do, as you know. Sure would be nice if we could convince the DoD they needed a second source for Windows :-) - Dan

9 10

Gecko installation broken?
by Stefan Dösinger May 19, 2009

May 19, 2009

Hi, Is my setup broken, or does the gecko installation fail? In a new wine prefix, when I open builtin iexplore, I get the installation dialog. The download runs successfully, but after installation iexplore still says that HTML rendering is currently disabled. When I run iexplore again, I again see the Wine Gecko installer dialog box. My hacky nightly game tests ran into this problem. The last successfull Team Fotress 2 test run is from May 14, 2009. After that my Gecko setup script failed and did not even try to start up Steam. Cheers, Stefan

4 6

Re: ntdll/tests: Mark return value of RtlUnicodeStringToInteger("", 16) as broken for nt4.
by Paul Vriens May 19, 2009

May 19, 2009

Huw Davies wrote: > --- > dlls/ntdll/tests/rtlstr.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > Hi, I don't think this is correct. This test has always succeeded until March 9th. There haven't been any changes to the test in that period, but I remember an upgrade of winehq in that weekend. In other words, there is more to it. Testing a simple cross compiled version of this test doesn't yield an error on NT4. -- Cheers, Paul.

3 2

Re: gdiplus: implement GdipTransformPoints
by Nikolay Sivov May 19, 2009

May 19, 2009

Vincent Povirk wrote: >From 1de9b2291bf9a5617ca1e3b0cba5f1260889c259 Mon Sep 17 00:00:00 2001 From: Vincent Povirk <vincent(a)codeweavers.com> Date: Mon, 23 Mar 2009 16:34:12 -0500 Subject: [PATCH] gdiplus: implement GdipTransformPoints It's a strange way to check enumeration with integer comparison, isn't it? And not clear in this particular case. > + if (stat == Ok) > + { > + unitscale = convert_unit(graphics->hdc, graphics->unit); > + > + if(graphics->unit != UnitDisplay) > + unitscale *= graphics->scale; > + > + if (src_space <= CoordinateSpaceWorld && dst_space >= CoordinateSpacePage) > + GdipMultiplyMatrix(matrix, graphics->worldtrans, MatrixOrderAppend); > + if (src_space <= CoordinateSpacePage && dst_space >= CoordinateSpaceDevice) > + GdipScaleMatrix(matrix, unitscale, unitscale, MatrixOrderAppend); > + > + if (dst_space <= CoordinateSpacePage && src_space >= CoordinateSpaceDevice) > + GdipScaleMatrix(matrix, 1.0/unitscale, 1.0/unitscale, MatrixOrderAppend); > + if (dst_space <= CoordinateSpaceWorld && src_space >= CoordinateSpacePage) > + { > + GpMatrix *inverted_transform; > + stat = GdipCloneMatrix(graphics->worldtrans, &inverted_transform); > + if (stat == Ok) > + { > + GdipInvertMatrix(inverted_transform); > + GdipMultiplyMatrix(matrix, inverted_transform, MatrixOrderAppend); > + GdipDeleteMatrix(inverted_transform); > + } > + Maybe it's better to use 'switch' for source coords with falling and ifs inside cases for destination. <= CoordinateSpaceWorld is just CoordinateSpaceWorld >= CoordinateSpaceDevice - is CoordinateSpaceDevice.

3 3