June 2009 - Wine-Devel - list.winehq.org

Re: [PATCH 4/4] gdi32: Add tests for the GetWinMetaFileBits MFCOMMENT record.
by Paul Vriens June 30, 2009

June 30, 2009

Huw Davies wrote: > --- > dlls/gdi32/tests/metafile.c | 80 +++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 80 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Huw, Could you use CreateEnhMetaFileA here: + SetRect(&rc, 1000,2000, 3000, 6000); + emf_dc = CreateEnhMetaFileW(display_dc, NULL, &rc, NULL); The W-version is not implemented on Win9x so this test would crash. -- Cheers, Paul.

2 1

Removing active maintainers
by Joerg-Cyril.Hoehle＠t-systems.com June 30, 2009

June 30, 2009

Hi, so far I found that Remco made the best suggestions. >From a quality of service point of view, unmaintained apps provide a more pleasing experience to the test data submiter: data is generally accepted within a fraction of a day. Not so for maintained apps. Why? Simple: there's a (large?) pool of general admins, so response time is low. OTOH, what response time can you expect from a single maintainer? My suggestion variant is: Delegate submissions after no more than 3 days from the maintainer to the general pool. Or what Remco suggested: accept by default pool, still notify maintainers so they can edit it afterwards. Easy to understand; easy to implement; best response time. Why look elsewhere? Find something else for removing people who volunteered(!) to maintain something. E.g. I'll be on vacation for 3 weeks, I'll never leave a ~/.vacation to please spammers, so I find the "8day response or be kicked" pretty tough. Regards, Jörg Höhle

1 0

Re: gdiplus: implement horizontal alignment in GdipDrawString
by Vincent Povirk June 29, 2009

June 29, 2009

Whoops, forgot to check that format is not NULL. Don't commit this. Vincent Povirk On Mon, Jun 29, 2009 at 4:39 PM, Vincent Povirk<vincent(a)codeweavers.com> wrote: > > > >

1 0

Remove FIXME keyword from bugzilla
by Austin English June 29, 2009

June 29, 2009

It serves no purpose, after all, 'FIXME's are not bugs'. -- -Austin

2 1

Re: appwiz.cpl: updated French translation
by Paul Vriens June 29, 2009

June 29, 2009

Frédéric Delanoy wrote: > Some adaptation to English dialog too: "Add/Remove" button was renamed to "Remove", since its only purpose is to uninstall apps. > > > ------------------------------------------------------------------------ > > Hi Frédéric But the message clear says "or to modify its installed components". So I guess a more appropriate text on the button would be "Modify/Remove" (or something alike). -- Cheers, Paul.

4 5

A new kid
by MD.IMAM HOSSAIN June 29, 2009

June 29, 2009

Dear WINE Developers, A short biography of me: A University Student of Electrical & Electronics Engineering Department. Live in Bangladesh in the city of Chittagong. I am a moderate Linux User, A moderate C programmer and have little knowledge about C++ programming. I wish to contribute to the WINE Project. What I could do for it. Please, give me a path. Best regard, MD. IMAM HOSSAIN

3 2

shdocvw: would it be allright to pretend succes in IWebBrowser2::Stop?
by Louis. Lenders June 29, 2009

June 29, 2009

Hi, i try run an app that bails out because WebBrowser_Stop returns E_NOTIMPL. Just like another app i already filed a bug for (http://bugs.winehq.org/show_bug.cgi?id=9895) it expects ERROR_SUCCESS. According to MSDN this function "Cancels a pending navigation or download, and stops dynamic page elements, such as background sounds and animations". My question is, would it be ok to just pretend ERROR_SUCCESS (as i think now), or would there be any unwanted side effects for other apps that use this function,and do we have to wait for a real implementation (maybe Jacek has a clue?) Regards Louis

1 0

re: Removing active maintainers
by Dan Kegel June 29, 2009

June 29, 2009

A few comments: 1. I agree that it is useful to remove obsolete, uninformative comments in the appdb. (You have to be careful to leave the old informative ones, though; if somebody has a great workaround or bug that might still be useful, don't delete it.) 2. The wiki is not the place for appdb-like stuff; duplication of information silos is generally a bad idea. Yes, I created a few wiki pages for Adobe apps, but that was a temporary hack, and the appdb provides almost enough flexibility. (What's missing is the ability to add howto's and notes at the application level, i.e. one level higher than the version level where they all go right now, but that's not usually a dealbreaker.) 3. Eight days is way too quick to remove an inactive maintainer. Six months is more like it. 4. The Wine community has some abrasive characters in it. Periodically we have to ask some of them to chill out. Everyone who is very active should take care that they don't get too curt with other developers or with users. A basic level of courtesy shouldn't be too hard. Dogfights where two maintainers are asking to have each other thrown out are a good sign that both of said developers need to chill. 'Nuff said. - Dan

8 12

Re: transl: fix score-counter
by Michael Stefaniuc June 29, 2009

June 29, 2009

André Hentschel wrote: > If e.g. 4 langs are on score 1, then next score entry is 5. > This corrects the counter, so that next score is 2 I wouldn't count that as a bug but as a matter of taste. I prefer the way it is now. There are 4 other languages before the respective language so it comes in only 5th. And changes to one of the 4 languages before it won't make the score of the language change. > --- > transl/php/index.php | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) bye michael

1 0

Re: transl: fix score-counter
by Ricardo Filipe June 29, 2009

June 29, 2009

2009/6/29 André Hentschel <nerv(a)dawncrow.de> > If e.g. 4 langs are on score 1, then next score entry is 5. > This corrects the counter, so that next score is 2 > --- > transl/php/index.php | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > the score right now gives a count of the number of languages on that step. it's more useful than giving the order score because that we can infer by the position on the list visually, IMHO.

2 1

Re: Removing active maintainers
by Remco June 29, 2009

June 29, 2009

On Mon, Jun 29, 2009 at 4:18 PM, Rosanne DiMesio<dimesio(a)earthlink.net> wrote: > On Mon, 29 Jun 2009 15:48:17 +0200 > Remco <remco47(a)gmail.com> wrote: >> >> Ok, I thought everybody got their AppDB updates by mail. But whichever >> way you receive notice of queued submissions without maintainers, >> that's where the maintained submissions can be sent after 24 hours. >> >> Remco > > Admins can already see all test reports in the queue. That's not the issue. The issue is removing maintainers who aren't doing their job. If we do their job for them, with no consequences to the negligent maintainer, that merely covers up the problem. So the issue is not that queued submissions aren't handled, but... what? I thought the problem was unhandled submissions, caused by negligent maintainers. But if that problem is not there, what problem are negligent maintainers causing? Remco

2 1

Re: [4/4] comctl32/rebar: Update Rebar structure
by Paul Vriens June 29, 2009

June 29, 2009

Nikolay Sivov wrote: > Changelog: > - Update Rebar structure > >>From b0d8b14a60f391144077cf8c053df5ea36fd22c4 Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <bunglehead(a)gmail.com> > Date: Sun, 28 Jun 2009 03:40:20 +0400 > Subject: Update Rebar structure > > --- > include/commctrl.h | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/include/commctrl.h b/include/commctrl.h > index 2c887d0..beecb52 100644 > --- a/include/commctrl.h > +++ b/include/commctrl.h > @@ -1988,6 +1988,9 @@ typedef struct tagREBARBANDINFOA > UINT cxIdeal; > LPARAM lParam; > UINT cxHeader; > + /* _WIN32_WINNT >= 0x0600 */ > + RECT rcChevronLocation; > + UINT uChevronState; > } REBARBANDINFOA, *LPREBARBANDINFOA; > > typedef REBARBANDINFOA const *LPCREBARBANDINFOA; > @@ -2014,6 +2017,9 @@ typedef struct tagREBARBANDINFOW > UINT cxIdeal; > LPARAM lParam; > UINT cxHeader; > + /* _WIN32_WINNT >= 0x0600 */ > + RECT rcChevronLocation; > + UINT uChevronState; > } REBARBANDINFOW, *LPREBARBANDINFOW; > > typedef REBARBANDINFOW const *LPCREBARBANDINFOW; Hi Nikolay, Looks like this introduces test failures on everything below Vista. Could you check? -- Cheers, Paul.

1 0

Re: [PATCH 1/2] Include: Add fil_data.idl to describe IAMFilterData interface (resend)
by Alexandre Julliard June 29, 2009

June 29, 2009

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > @@ -29,6 +29,7 @@ PUBLIC_IDL_H_SRCS = \ > dxgi.idl \ > dxgitype.idl \ > exdisp.idl \ > + fil_data.idl \ This file doesn't seem to be part of the SDK. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [1/2] makedep: Add support for multiple object file extensions.
by Alexandre Julliard June 29, 2009

June 29, 2009

Francois Gouget <fgouget(a)free.fr> writes: > This is useful to generate dependencies for crossbuilds. -o is traditionally used for the output file, so something like -x would probably be preferable. Also specifying multiple extensions by repeating the option (-xfoo -xbar instead of -xfoo:bar) is probably nicer, especially for usage in makefiles. -- Alexandre Julliard julliard(a)winehq.org

1 0

Anyone at LinuxTag?
by Dan Kegel June 29, 2009

June 29, 2009

According to http://www.heise.de/newsticker/Bund-foerdert-Open-Source-Projekte--/meldung… Germany's going to put 20 million euros into open source. They'll probably throw it all down a rathole, but hey, maybe some small fraction will go to useful projects. If anyone's at LinuxTag, maybe it would be worth wandering over to Halle 7.2a, Stand 111 and chat the projects up to see if any of them have any interest in Wine...

6 12

Direct3D Shader
by MD.IMAM HOSSAIN June 29, 2009

June 29, 2009

Dear Developers, Is there any possibilities to use nVidia Cg Library for Wine's Direct3D pixel and vertex shader. It will help Linux Intel On Board Graphics Card owners. Because nVidia's Cg support all graphics card. best regards, MD. IMAM HOSSAIN

1 0

Re: fix overflow in several advapi32 crypt functions hidden by broken WideCharToMultiByte
by Dmitry Timoshkov June 29, 2009

June 29, 2009

"Christoph von Wittich" <Christoph(a)ApiViewer.de> wrote: > When you would have a look at the winetests you would have noticed two > failures about passing in negative values... Which winetests should I look at? The WideCharToMultiByte ones? Then the patch is wrong. That's unusual to expect that somebody reads your mind. -- Dmitry.

1 0

Re: user32: GetTitleBarInfo: Handle hwnd and tbi when passing NULL (try 3)
by Frédéric Delanoy June 29, 2009

June 29, 2009

Kovács András wrote: > Hi, > > This patch is for GetTitleBarInfo <...> > > Andras Kovacs Not so problematic, but you can simplify 'if (IsWindow(hwnd) == FALSE)' with 'if (! IsWindow(hwnd))' Frédéric

1 0

XI2 DirectInput/RawInput/WH_*_LL hooks
by Paul TBBle Hampson June 28, 2009

June 28, 2009

I've been thinking about the XI2 a fair bit since the last time we discussed it on the mailing list, and a few things have come to mind, which I think need sanity checking before I explore any harder. I'm assuming we want one X11 connection turning XI2 events into WH_*_LL events, RawInput events, and DirectInput events, simply because WH_*_LL events are actually sent out by wineserver to all processes, so we only want one of those per XI2 event. This leads me to retaining the current WH_*_LL-based implementation of DI, but with cursor management and control (ie all the stuff Exclusive mode brings to the table) handling via a graphics driver hook or similar. However, the mechanism for feeding the XI2 events to the wineserver as WH_*_LL events is a little tricky. XI2 events need their own thread and hence X connection, as we cannot rely on a WinMain loop hitting X11DRV_MsgWaitForMultipleObjectsEx in a timely manner, or in fact all. The three possibilities I see are: *) Most recent foreground application catches XI2 events in its own spawned thread. Need to elect a replacement on process exit. Easiest to co-ordinate with non-XI2 hook-feeding code. *) Wineserver gains an X11 connection, for XI2 use only. This is generally bad, only here for completeness. *) A new process (ala services.exe) which grabs XI2 events from X11 via its own connection and feeds them to the wineserver. I'm inclined to think the latter one is the best option of the three, and it requires simply that the winex11.drv detect XI2 presence and if found, it disable its own WH_*_LL feeding code and spawn the XI2 process if it is not already running. It avoids the complicated coordination dance you would need for the first option to avoid losing messages. Mind you, I've been thinking this away from the codebase, so it's mostly mindwork right now. But unless I get any better suggestions or criticism, I'll prolly knock up a sample implementation of the third option next time I play with this, and see if I can get the DI keyboard interface implemented. -- ----------------------------------------------------------- Paul "TBBle" Hampson, B.Sc, LPI, MCSE Very-later-year Asian Studies student, ANU The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361) Paul.Hampson(a)Pobox.com Of course Pacman didn't influence us as kids. If it did, we'd be running around in darkened rooms, popping pills and listening to repetitive music. -- Marcus Brigstocke http://www.marcusbrigstocke.com/pacman.asp License: http://creativecommons.org/licenses/by/2.5/au/ -----------------------------------------------------------

4 4

Re: [2/2] GetTitleBarInfo tests for NULL values
by Nikolay Sivov June 28, 2009

June 28, 2009

Kovács András wrote: > Hi, > > GetTitleBarInfo tests for NULL values. > > > Best Regards, > > Kovács András > What about this one: --- ret = GetTitleBarInfo(NULL, NULL); --- What error code will come first?

1 0

Re: [1/2] Handle hwnd and tbi when passing NULL
by Nikolay Sivov June 28, 2009

June 28, 2009

Kovács András wrote: > Hi, > > This patch is for GetTitleBarInfo, when it gets NULL hwnd and/or pti > parameter. > GTA IV tries to use this function with NULL, NULL parameters. > This doesn't hurt Windows, but crashes in wine. > Tested against Windows 7. > > Best Regards, > > Andras Kovacs > --- TRACE("(%p %p)\n", hwnd, tbi); .... + TRACE("tbi is NULL.\n"); --- That's a duplication you don't really need. This one isn't very useful too: --- + TRACE("Invalid hwnd.\n"); ---

1 0

Re: [1/2] Handle hwnd and tbi when passing NULL
by Austin English June 28, 2009

June 28, 2009

2009/6/28 Kovács András <andras(a)csevego.net>: > Hi, > > This patch is for GetTitleBarInfo, when it gets NULL hwnd and/or pti > parameter. > GTA IV tries to use this function with NULL, NULL parameters. > This doesn't hurt Windows, but crashes in wine. > Tested against Windows 7. > > Best Regards, > > Andras Kovacs Not a big deal, but in the future, please add the component at the beginning of your e-mail's subject, e.g.: user32: Handle hwnd and tbi when passing NULL in GetTitleBarInfo it's much easier to know what the purpose of the patch is without reading it that way (for those people that only read certain sections of the code). -- -Austin

1 0

Re: [1/1] Handle hwnd and tbi when passing NULL
by Nikolay Sivov June 28, 2009

June 28, 2009

Kovács András wrote: > Hi, > > This patch is for GetTitleBarInfo, when it gets NULL hwnd and/or pti > parameter. > GTA IV tries to use this function with NULL, NULL parameters. > This doesn't hurt Windows, but crashes in wine. > Tested against Windows 7. > > Best Regards, > > Andras Kovacs > I think IsWindow() will be enough here. Also add tests for that please.

1 0

Re: winedbg italian translation
by Nikolay Sivov June 28, 2009

June 28, 2009

Davide Pizzetti wrote: > Il giorno dom, 28/06/2009 alle 17.43 +0400, Nikolay Sivov ha scritto: > >> Davide Pizzetti wrote: >> >>> I've got another question: i've created some new files and translated >>> them into italian. How can i submit them as a patch? I made a git diff >>> but these files i created don't appear there >>> >>> >> As I told you. Do 'git add <new file path relative to tree>'. This will >> add it to your local repo. >> >> > i used 'git add' but i can't understand how i can submit the new files > as a patch, since i get only a diff for the list of the current > languages > Do 'git commit -a' and 'git format-patch' will do what you want after that.

1 0

Re: winedbg italian translation
by Nikolay Sivov June 28, 2009

June 28, 2009

Davide Pizzetti wrote: > I've got another question: i've created some new files and translated > them into italian. How can i submit them as a patch? I made a git diff > but these files i created don't appear there > As I told you. Do 'git add <new file path relative to tree>'. This will add it to your local repo.

1 0